fix(core): Throw error in UI on expression referencing missing node but do not fail execution (#5158)

fix(core): Throw error in UI on expression referencing missing node but
do not fail execution
This commit is contained in:
Jan Oberhauser 2023-01-13 09:22:37 -06:00 committed by GitHub
parent 146bc3bff5
commit c9e158e458
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -575,14 +575,14 @@ export class WorkflowDataProxy {
get(target, name, receiver) {
const nodeName = name.toString();
// TODO: re-enable this for v1.0.0 release
// if (that.workflow.getNode(nodeName) === null) {
// throw new ExpressionError(`"${nodeName}" node doesn't exist`, {
// runIndex: that.runIndex,
// itemIndex: that.itemIndex,
// failExecution: true,
// });
// }
if (that.workflow.getNode(nodeName) === null) {
throw new ExpressionError(`"${nodeName}" node doesn't exist`, {
runIndex: that.runIndex,
itemIndex: that.itemIndex,
// TODO: re-enable this for v1.0.0 release
// failExecution: true,
});
}
return that.nodeDataGetter(nodeName);
},