fix: fix workflow saving and grabber notch

This commit is contained in:
Alex Grozav 2023-07-18 14:51:44 +03:00
parent feb45664a8
commit d24dbaf9e9
7 changed files with 12 additions and 17 deletions

View file

@ -1,5 +1,5 @@
<template>
<Card :loading="loading" :title="collection.name" @click="onClick">
<Card :loading="loading" :title="collection.name">
<template #footer>
<n8n-text size="small" color="text-light">
{{ collection.workflows.length }}
@ -31,11 +31,6 @@ export default defineComponent({
Card,
NodeList,
},
methods: {
onClick(e: MouseEvent) {
this.$emit('click', e);
},
},
});
</script>

View file

@ -197,10 +197,8 @@ export default defineComponent({
},
},
setup() {
const loadingService = useLoadingService();
return {
loadingService,
...useLoadingService(),
...useTitleChange(),
...useToast(),
...useMessage(),

View file

@ -694,7 +694,7 @@ export default defineComponent({
<style lang="scss">
.ndv-wrapper {
overflow: hidden;
overflow: visible;
}
.data-display-wrapper {
@ -711,7 +711,7 @@ export default defineComponent({
padding: 0 !important;
height: 100%;
min-height: 400px;
overflow: hidden;
overflow: visible;
border-radius: 8px;
}
}

View file

@ -291,10 +291,10 @@ export default defineComponent({
return this.ndvStore.outputPanelEditMode;
},
isCommunityNode(): boolean {
return isCommunityPackageName(this.node.type);
return isCommunityPackageName(this.node?.type);
},
isTriggerNode(): boolean {
return this.nodeTypesStore.isTriggerNode(this.node.type);
return this.nodeTypesStore.isTriggerNode(this.node?.type);
},
workflowOwnerName(): string {
return this.workflowsEEStore.getWorkflowOwnerName(`${this.workflowsStore.workflowId}`);
@ -614,7 +614,7 @@ export default defineComponent({
}
// Save the node name before we commit the change because
// we need the old name to rename the node properly
const nodeNameBefore = parameterData.node || this.node.name;
const nodeNameBefore = parameterData.node || this.node?.name;
const node = this.workflowsStore.getNodeByName(nodeNameBefore);
if (node === null) {
@ -935,8 +935,8 @@ export default defineComponent({
onMissingNodeLearnMoreLinkClick() {
this.$telemetry.track('user clicked cnr docs link', {
source: 'missing node modal source',
package_name: this.node.type.split('.')[0],
node_type: this.node.type,
package_name: this.node?.type.split('.')[0],
node_type: this.node?.type,
});
},
onStopExecution() {

View file

@ -8,7 +8,6 @@
:disabled="disabled"
:class="$style.button"
:type="type"
@click="$emit('click')"
/>
</span>
</template>

View file

@ -38,6 +38,7 @@ export function useLoadingService() {
}
return {
loadingService,
startLoading,
setLoadingText,
stopLoading,

View file

@ -748,6 +748,8 @@ export const workflowHelpers = defineComponent({
return true;
} catch (error) {
console.error(error);
this.uiStore.removeActiveAction('workflowSaving');
if (error.errorCode === 100) {