mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-11-14 08:34:07 -08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

self review

Browse source
This commit is contained in:
Charlie Kolb 2024-11-11 09:42:41 +01:00
parent 4cd0e73097
commit d5a6e6c3c2
No known key found for this signature in database
3 changed files with 4 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
cypress/e2e/30-langchain.cy.ts
View file

@ -459,7 +459,7 @@ describe('Langchain Integration', () => {
getNoToolsUsedCallout().should('exist'); getNoToolsUsedCallout().should('exist');
}); });
it('should not show tool info notice if tools were used during execution', () => { it.only('should not show tool info notice if tools were used during execution', () => {
addNodeToCanvas(MANUAL_CHAT_TRIGGER_NODE_NAME, true); addNodeToCanvas(MANUAL_CHAT_TRIGGER_NODE_NAME, true);
addNodeToCanvas(AGENT_NODE_NAME, true); addNodeToCanvas(AGENT_NODE_NAME, true);
@ -492,10 +492,7 @@ describe('Langchain Integration', () => {
main: { output: outputMessage }, main: { output: outputMessage },
}, },
metadata: { metadata: {
subRun: [ subRun: [{ node: AI_LANGUAGE_MODEL_OPENAI_CHAT_MODEL_NODE_NAME, runIndex: 0 }],
{ node: AI_LANGUAGE_MODEL_OPENAI_CHAT_MODEL_NODE_NAME, runIndex: 0 },
{ node: AI_TOOL_CALCULATOR_NODE_NAME, runIndex: 0 },
],
}, },
}), }),
createMockNodeExecutionData(AI_TOOL_CALCULATOR_NODE_NAME, {}), createMockNodeExecutionData(AI_TOOL_CALCULATOR_NODE_NAME, {}),

6
packages/editor-ui/src/components/OutputPanel.vue
View file

@ -387,11 +387,7 @@ const shouldShowWarning = computed(() => {
<template v-if="shouldShowWarning" #table-user-info> <template v-if="shouldShowWarning" #table-user-info>
<div :class="$style.noToolsUsedAlert" data-test-id="no-tools-used-callout"> <div :class="$style.noToolsUsedAlert" data-test-id="no-tools-used-callout">
<N8nCallout theme="secondary"> <N8nCallout theme="secondary">
{{ {{ i18n.baseText('ndv.output.noToolUsedInfo') }}
i18n.baseText('ndv.output.noToolUsedInfo.title') +
'. ' +
i18n.baseText('ndv.output.noToolUsedInfo.description')
}}
</N8nCallout> </N8nCallout>
</div> </div>
</template> </template>

3
packages/editor-ui/src/plugins/i18n/locales/en.json
View file

@ -978,8 +978,7 @@
"ndv.output.tooMuchData.showDataAnyway": "Show data", "ndv.output.tooMuchData.showDataAnyway": "Show data",
"ndv.output.tooMuchData.title": "Display data?", "ndv.output.tooMuchData.title": "Display data?",
"ndv.output.waitingToRun": "Waiting to execute...", "ndv.output.waitingToRun": "Waiting to execute...",
"ndv.output.noToolUsedInfo.title": "None of your tools were used in this run", "ndv.output.noToolUsedInfo": "None of your tools were used in this run. Try giving your tools clearer names and descriptions to help the AI",
"ndv.output.noToolUsedInfo.description": "Try giving your tools clearer names and descriptions to help the AI",
"ndv.title.cancel": "Cancel", "ndv.title.cancel": "Cancel",
"ndv.title.rename": "Rename", "ndv.title.rename": "Rename",
"ndv.title.renameNode": "Rename node", "ndv.title.renameNode": "Rename node",