Elias Meire
fbcd1d40ed
fix(Notion Node): Handle empty values correctly for Notion selects + multi selects ( #7383 )
...
Github issue / Community forum post (link here to close automatically):
2023-10-09 18:04:41 +02:00
कारतोफ्फेलस्क्रिप्ट™
8187be1b7d
feat(editor): Make PDF and Audio binary-data viewable in the UI ( #7367 )
...
fixes #7361
2023-10-09 17:43:57 +02:00
कारतोफ्फेलस्क्रिप्ट™
732b15a1fa
fix(Google Sheets Node): Fix "Maximum call stack size exceeded" error on too many rows ( #7384 )
...
Fixes:
1. https://community.n8n.io/t/google-sheets-error-maximum-call-stack-size-exceeded/31006
2. https://community.n8n.io/t/error-maximum-call-stack-size-exceeded-in-google-sheet-read-rows/20307
2023-10-09 16:58:16 +02:00
कारतोफ्फेलस्क्रिप्ट™
c5ee06cc61
refactor(core): Refactor nodes loading (no-changelog) ( #7283 )
...
fixes PAY-605
2023-10-09 16:09:23 +02:00
कारतोफ्फेलस्क्रिप्ट™
789e1e7ed4
fix(core): Add an option to enable postgres ssl with default certs ( #6889 )
...
CP-809
2023-10-09 13:55:03 +02:00
Csaba Tuncsik
b3247e5935
feat(editor): Workflow history [WIP]- Add restore and clone into new workflow actions (no-changelog) ( #7359 )
2023-10-09 13:50:08 +02:00
Jon
77643e5ccb
fix(HTML Node): Update property fields to not use expressions on drag ( #7379 )
...
When dragging an expression into a "binary property" or "json property"
field we should use the key name rather than the expression.
2023-10-09 10:23:46 +01:00
Ricardo Espinoza
a43f720658
fix: Add role check for upgrade path ( #7374 )
...
Github issue / Community forum post (link here to close automatically):
---------
Co-authored-by: Mutasem <mutdmour@gmail.com>
2023-10-09 11:18:08 +02:00
Iván Ovejero
3fa27647d8
fix(editor): Remove excess margin below run data editor ( #7372 )
...
https://n8nio.slack.com/archives/C03594NKD7W/p1696605203051309
<img width="581" alt="Capture 2023-10-06 at 17 48 51@2x"
src="https://github.com/n8n-io/n8n/assets/44588767/c00ecd2e-1f6b-4041-9854-1b6012513a5d ">
2023-10-09 09:20:37 +02:00
Elias Meire
3e7a4d3b2c
fix(Google Drive Trigger Node): Add Shared Drives support ( #7369 )
...
Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/google-drive-node-cant-access-google-shared-drives/8760
2023-10-06 19:59:33 +02:00
Michael Auerswald
b8608cee6d
feat(core): Add Job Summary to Worker response ( #7360 )
2023-10-06 17:52:27 +02:00
Michael Kret
c8c14ca0af
feat(Execute Workflow Node): Run once for each item mode ( #7289 )
...
Github issue / Community forum post (link here to close automatically):
2023-10-06 18:04:33 +03:00
कारतोफ्फेलस्क्रिप्ट™
597669aa62
refactor(core): Move copyInputItems to node helpers (no-changelog) ( #7299 )
2023-10-06 16:25:58 +02:00
Iván Ovejero
34bda535e6
refactor(core): Create controller for binary data (no-changelog) ( #7363 )
...
This PR adds a controller for binary data + integration tests.
2023-10-06 16:21:13 +02:00
Iván Ovejero
63e11e4be9
fix(core): Prevent object deletion request on no prefix match ( #7366 )
2023-10-06 15:46:39 +02:00
Elias Meire
7b773cc5cc
feat(Loop Over Items (Split in Batches) Node): Automatically add a loop + rename ( #7228 )
...
Github issue / Community forum post (link here to close automatically):
---------
Co-authored-by: Michael Kret <michael.k@radency.com>
2023-10-06 15:31:18 +02:00
Michael Auerswald
afa683a06f
refactor(core): Have one orchestration service per instance type ( #7303 )
...
webhook instances will not listen to either worker or event log messages
on the Redis pub/sub channel
2023-10-06 13:58:11 +02:00
Michael Kret
193181a9c6
feat(Notion Node): Fetch child blocks recursively ( #7304 )
...
Github issue / Community forum post (link here to close automatically):
2023-10-06 14:55:44 +03:00
Michael Kret
97bb703d0a
fix(Google BigQuery Node): Location default to jobReference ( #7354 )
...
Github issue / Community forum post (link here to close automatically):
2023-10-06 14:16:55 +03:00
Ricardo Espinoza
1dfa052301
feat(editor): Support autologin for upgrade path ( #7316 )
...
Github issue / Community forum post (link here to close automatically):
2023-10-06 13:16:27 +02:00
Cornelius Suermann
f4d8c9eed5
feat: Improve error msg when attempting to redeem the same activation code multiple times (no-changelog) ( #7355 )
2023-10-05 17:08:30 +02:00
Csaba Tuncsik
cd12a5990a
feat(editor): Workflow history [WIP]- Improve switching between workflow history and editor (no-changelog) ( #7353 )
2023-10-05 15:49:59 +02:00
Iván Ovejero
1a661e6d00
feat(core): Integrate object store as binary data manager ( #7253 )
...
Depends on: #7225 | Story:
[PAY-848](https://linear.app/n8n/issue/PAY-848 )
This PR integrates the object store service as a new binary data manager
for Enterprise.
2023-10-05 15:25:17 +02:00
Michael Kret
e5ad1e7e4d
fix(Set Node): Increase search priority ( #7358 )
...
Github issue / Community forum post (link here to close automatically):
2023-10-05 16:19:19 +03:00
Tomi Turtiainen
afbf0c3d5e
fix(editor): Use display option's @Version specifier ( #7351 )
...
Nodes can have properties that have a displayOption which specifies a
version
for which node versions that property applies to. We should take this
into
account when forming the action types for a Node in the NodeList.
For example Notion node has 2 version which have different Page
operations.
2023-10-05 15:57:47 +03:00
github-actions[bot]
aa1bf95136
🚀 Release 1.10.0 ( #7350 )
...
# [1.10.0](https://github.com/n8n-io/n8n/compare/n8n@1.9.0...n8n@1.10.0 )
(2023-10-05)
### Bug Fixes
* **Convert to/from binary data Node:** Rename 'Move Binary Data' to
'Convert to/from binary data'
([#7318 ](https://github.com/n8n-io/n8n/issues/7318 ))
([5e6c1d45e6c1d4f4b#7305 ](https://github.com/n8n-io/n8n/issues/7305 ))
([16912231691223789#7333 ](https://github.com/n8n-io/n8n/issues/7333 ))
([1b4848a1b4848afcb#7340 ](https://github.com/n8n-io/n8n/issues/7340 ))
([6d3d1786d3d1789db#7298 ](https://github.com/n8n-io/n8n/issues/7298 ))
([3aac22b3aac22b4c1#7346 ](https://github.com/n8n-io/n8n/issues/7346 ))
([b59b908b59b9086d7#7290 ](https://github.com/n8n-io/n8n/issues/7290 ))
([7ebf8f37ebf8f327a#7295 ](https://github.com/n8n-io/n8n/issues/7295 ))
([ddc26c2ddc26c21bd#7312 ](https://github.com/n8n-io/n8n/issues/7312 ))
([04dfcd704dfcd73be#7322 ](https://github.com/n8n-io/n8n/issues/7322 ))
([37047603704760724#2670 ](https://github.com/n8n-io/n8n/issues/2670 )
* **Notion Node:** Rename Notion API Key to Internal Integration Token
([#7176 ](https://github.com/n8n-io/n8n/issues/7176 ))
([ec2aa38ec2aa3819c#7300 ](https://github.com/n8n-io/n8n/issues/7300 ))
([763d451763d4514fa#7313 ](https://github.com/n8n-io/n8n/issues/7313 ))
([f0a6687f0a66873b9#7315 ](https://github.com/n8n-io/n8n/issues/7315 ))
([b3fc00eb3fc00e045#7183 ](https://github.com/n8n-io/n8n/issues/7183 ))
([8f9fe628f9fe6269b#7235 ](https://github.com/n8n-io/n8n/issues/7235 ))
([00a4b8b00a4b8b0c6#7246 ](https://github.com/n8n-io/n8n/issues/7246 )
[#7137 ](https://github.com/n8n-io/n8n/issues/7137 )
* Workflow History pruning and prune time settings
([#7343 ](https://github.com/n8n-io/n8n/issues/7343 ))
([0adc5330adc533719
2023-10-05 14:12:37 +02:00
Omar Ajoue
5cfd87692f
refactor: Add log messages to debug worker init issues ( #7238 )
...
Github issue / Community forum post (link here to close automatically):
2023-10-05 13:37:25 +02:00
कारतोफ्फेलस्क्रिप्ट™
169175080a
ci: Fix WorkflowHistoryManager tests (no-changelog) ( #7356 )
...
[DB Tests](https://github.com/n8n-io/n8n/actions/runs/6418058186 )
2023-10-05 13:14:57 +02:00
Milorad FIlipović
7ebf8f327a
fix(editor): Fix disappearing NDV header in code nodes ( #7290 )
...
Github issue / Community forum post (link here to close automatically):
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-10-05 12:31:52 +02:00
Csaba Tuncsik
4bc9164032
feat(editor): Workflow history [WIP]- Add workflow history opening button to main header component (no-changelog) ( #7310 )
...
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
2023-10-04 16:45:18 +02:00
OlegIvaniv
b59b9086d7
fix(editor): Fix canvas endpoint snapping when dragging connection ( #7346 )
...
Github issue / Community forum post (link here to close automatically):
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
2023-10-04 16:10:42 +02:00
Elias Meire
ddc26c21bd
fix(editor): Fix RLC not loading when an expression can't resolve ( #7295 )
...
Also fixes label (list -> From list)
Github issue / Community forum post (link here to close automatically):
2023-10-04 16:01:44 +02:00
Tomi Turtiainen
1b4848afcb
fix(core): Fix pruning of non-finished executions ( #7333 )
...
This fixes a bug in the pruning (soft-delete). The pruning was a bit too
aggressive, as it also pruned executions that weren't in an end state
yet. This only becomes an issue if there are long-running executions
(e.g. workflow with Wait node) or the prune parameters are set to keep
only a tiny number of executions.
2023-10-04 16:32:05 +03:00
Giulio Andreini
942d0b91fc
docs(editor): New Nodes Panel title for triggers ( #7314 )
...
Github issue / Community forum post (link here to close automatically):
2023-10-04 15:27:40 +02:00
Val
0adc533719
feat: Workflow History pruning and prune time settings ( #7343 )
...
Github issue / Community forum post (link here to close automatically):
2023-10-04 13:57:21 +01:00
Milorad FIlipović
6d3d1789db
fix(editor): Disable email confirmation banner for trialing users ( #7340 )
...
Github issue / Community forum post (link here to close automatically):
2023-10-04 13:36:51 +02:00
Elias Meire
5e6c1d4f4b
fix(Convert to/from binary data Node): Rename 'Move Binary Data' to 'Convert to/from binary data' ( #7318 )
...
Github issue / Community forum post (link here to close automatically):
2023-10-04 13:23:33 +02:00
Elias Meire
b3fc00e045
fix(Typeform Trigger Node): Change output format for TypeForm trigger to object instead of array ( #7315 )
...
Github issue / Community forum post (link here to close automatically):
---------
Co-authored-by: Michael Kret <michael.k@radency.com>
2023-10-04 12:39:31 +02:00
Elias Meire
3aac22b4c1
fix(editor): Display value of selected matching column in RMC ( #7298 )
...
Github issue / Community forum post (link here to close automatically):
2023-10-04 12:36:24 +02:00
कारतोफ्फेलस्क्रिप्ट™
101255d186
ci: Make builds release-channel aware. Add support for scheduled beta builds ( #7323 )
...
ADO-1121
---------
Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
2023-10-03 20:49:04 +02:00
Michael Kret
8f9fe6269b
feat(core): Add "Sent by n8n" attribution ( #7183 )
...
Github issue / Community forum post (link here to close automatically):
---------
Co-authored-by: Giulio Andreini <g.andreini@gmail.com>
2023-10-03 11:18:59 +03:00
Michael Kret
f0a66873b9
fix(Set Node): Do not stringify null and undefined ( #7313 )
...
Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/null-and-undefined-in-string-fields/31060/1
2023-10-03 11:18:33 +03:00
Elias Meire
3704760724
fix(Jira Software Node): Get all users in dropdown/RLC ( #7322 )
...
Github issue / Community forum post (link here to close automatically):
fixes #2670
---------
Co-authored-by: Michael Kret <michael.k@radency.com>
2023-10-03 10:04:58 +02:00
greyliath
e7a90c73b3
fix(Acuity Scheduling Trigger Node): Update logo for Acuity Scheduling (no-changelog) ( #7321 )
2023-10-02 17:17:47 +01:00
कारतोफ्फेलस्क्रिप्ट™
00a4b8b0c6
feat(core): Add support for building LLM applications ( #7235 )
...
This extracts all core and editor changes from #7246 and #7137 , so that
we can get these changes merged first.
ADO-1120
[DB Tests](https://github.com/n8n-io/n8n/actions/runs/6379749011 )
[E2E Tests](https://github.com/n8n-io/n8n/actions/runs/6379751480 )
[Workflow Tests](https://github.com/n8n-io/n8n/actions/runs/6379752828 )
---------
Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
Co-authored-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Alex Grozav <alex@grozav.com>
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-10-02 17:33:43 +02:00
Milorad FIlipović
04dfcd73be
fix(editor): Separate cloud endpoint calls ( #7312 )
...
This PR untangles calls to cloud endpoints so failure in one of them
doesn't stop others to go through.
2023-10-02 14:25:03 +02:00
Iván Ovejero
1691223789
fix(core): Account for itemless case on restoring binary data ID ( #7305 )
...
https://linear.app/n8n/issue/PAY-862
2023-10-02 09:13:55 +02:00
Csaba Tuncsik
d1b6c7fd79
feat(editor): Workflow history [WIP]- create workflow history list component (no-changelog) ( #7186 )
...
Co-authored-by: Omar Ajoue <krynble@gmail.com>
2023-09-29 17:48:36 +02:00
Omar Ajoue
ec0379378e
feat(core): Add plan name to telemetry (no-changelog) ( #7296 )
...
Github issue / Community forum post (link here to close automatically):
2023-09-29 15:41:32 +02:00
कारतोफ्फेलस्क्रिप्ट™
6a1557bc50
Merge tag 'n8n@1.9.0'
2023-09-29 14:28:06 +02:00
कारतोफ्फेलस्क्रिप्ट™
f8406c04b1
ci: Fix typescript incremental builds (no-changelog) ( #7275 )
...
`tsBuildInfoFile` is supposed to be relative to `tsconfig` like `outDir`
is.
Because of this, we are currently saving the TS incremental build cache
for all packages in the same file. This is likely causing issues where
the built backend code sometimes does not accurately map to the current
source code.
This PR changes the incremental build setup to keep the cache in
individual `dist` folders, like it used to be up until a 2 months ago,
before https://github.com/n8n-io/n8n/pull/6816 .
2023-09-29 13:26:06 +02:00
Michael Kret
763d4514fa
fix(Postgres Node): Node requires comma-separated string even when using a single parameter through an expression ( #7300 )
...
Github issue / Community forum post (link here to close automatically):
2023-09-29 13:27:31 +03:00
Elias Meire
ec2aa3819c
fix(Notion Node): Rename Notion API Key to Internal Integration Token ( #7176 )
...
Github issue / Community forum post (link here to close automatically):
2023-09-29 09:21:29 +02:00
github-actions[bot]
167124ceb8
🚀 Release 1.9.0 ( #7288 )
...
# [1.9.0](https://github.com/n8n-io/n8n/compare/n8n@1.8.0...n8n@1.9.0 )
(2023-09-28)
### Bug Fixes
* **Airtable Node:** Attachments field type fix
([#7227 ](https://github.com/n8n-io/n8n/issues/7227 ))
([2af967c2af967cf88#7282 ](https://github.com/n8n-io/n8n/issues/7282 ))
([a80abada80abad3af#7251 ](https://github.com/n8n-io/n8n/issues/7251 ))
([484035e484035eb51#7244 ](https://github.com/n8n-io/n8n/issues/7244 ))
([33991e933991e92d0#7229 ](https://github.com/n8n-io/n8n/issues/7229 ))
([67b985f67b985fe89#7272 ](https://github.com/n8n-io/n8n/issues/7272 ))
([5b3121c5b3121c415#7252 ](https://github.com/n8n-io/n8n/issues/7252 ))
([4b014284b014286cf#7261 ](https://github.com/n8n-io/n8n/issues/7261 ))
([861cac5861cac5257#6948 ](https://github.com/n8n-io/n8n/issues/6948 ))
([01325140132514f8b#2178 ](https://github.com/n8n-io/n8n/issues/2178 )
[#2810 ](https://github.com/n8n-io/n8n/issues/2810 )
[#3855 ](https://github.com/n8n-io/n8n/issues/3855 )
[#2813 ](https://github.com/n8n-io/n8n/issues/2813 )
* **editor:** Add debug feature docs link
([#7240 ](https://github.com/n8n-io/n8n/issues/7240 ))
([4614e1e4614e1e1c9#7236 ](https://github.com/n8n-io/n8n/issues/7236 ))
([647fc6c647fc6c555#7215 ](https://github.com/n8n-io/n8n/issues/7215 ))
([2491ccf2491ccf4d9https://github.com/n8n-io/n8n/issues/7188 )
([303bc8e303bc8e71e#7293 ](https://github.com/n8n-io/n8n/issues/7293 ))
([0bc33b10bc33b1cc2#7286 ](https://github.com/n8n-io/n8n/issues/7286 ))
([cde23a1cde23a1bb1#7294 ](https://github.com/n8n-io/n8n/issues/7294 ))
([8bc369d8bc369dd40#7212 ](https://github.com/n8n-io/n8n/issues/7212 ))
([01e934001e9340621#7277 ](https://github.com/n8n-io/n8n/issues/7277 ))
([53a750253a7502d20#6964 ](https://github.com/n8n-io/n8n/issues/6964 ))
([bf74f09bf74f09d69#7234 ](https://github.com/n8n-io/n8n/issues/7234 ))
([0083a9e0083a9e45d#7225 ](https://github.com/n8n-io/n8n/issues/7225 ))
([fa84545fa845453bb#7232 ](https://github.com/n8n-io/n8n/issues/7232 )
([60c152d60c152dc72#7205 ](https://github.com/n8n-io/n8n/issues/7205 ))
([b0e98b5b0e98b59a6#7268 ](https://github.com/n8n-io/n8n/issues/7268 ))
([e4c302ce4c302c683#7260 ](https://github.com/n8n-io/n8n/issues/7260 ))
([db01164db01164ce1
2023-09-28 17:22:28 +02:00
कारतोफ्फेलस्क्रिप्ट™
cf5a0ca456
ci: Refactor DB tests (no-changelog) ( #7292 )
...
[DB tests](https://github.com/n8n-io/n8n/actions/runs/6340094467 )
2023-09-28 16:53:05 +02:00
Marcus
0bc33b1cc2
fix(HTTP Request Node): Add suggestion how to fix '429 - too many requests' errors ( #7293 )
...
Github issue / Community forum post (link here to close automatically):
2023-09-28 16:00:45 +02:00
Michael Kret
8bc369dd40
fix(Respond to Webhook Node): JSON output from expression fix ( #7294 )
...
Github issue / Community forum post (link here to close automatically):
https://github.com/n8n-io/n8n/issues/7077
2023-09-28 16:46:00 +03:00
Michael Auerswald
53a7502d20
feat(core): Add secrets provider reload and refactor ( #7277 )
...
This PR adds a message for queue mode which triggers an external secrets
provider reload inside the workers if the configuration has changed on
the main instance.
It also refactors some of the message handler code to remove cyclic
dependencies, as well as remove unnecessary duplicate redis clients
inside services (thanks to no more cyclic deps)
2023-09-28 12:57:35 +02:00
Val
a80abad3af
fix(core): Change WorkflowHistory nodes/connections columns to be json ( #7282 )
...
Github issue / Community forum post (link here to close automatically):
2023-09-28 10:37:33 +02:00
Michael Kret
cde23a1bb1
fix(Item Lists Node): Concatenate operation pairedItems fix ( #7286 )
...
Github issue / Community forum post (link here to close automatically):
---------
Co-authored-by: Jonathan Bennetts <jonathan.bennetts@gmail.com>
2023-09-28 10:20:54 +03:00
कारतोफ्फेलस्क्रिप्ट™
0132514f8b
fix(core): Use consistent timezone-aware timestamps in postgres ( #6948 )
...
Fixes:
* ENG-51 / N8N-2490
* PAY-397
* #2178
* #2810
* #3855
Supersedes #2813
[DB
Tests](https://github.com/n8n-io/n8n/actions/runs/6000780146/job/16273596338 )
2023-09-27 18:44:47 +02:00
कारतोफ्फेलस्क्रिप्ट™
ebce6fe1b0
refactor(core): Skip sending webhook activation errors to Sentry (no-changelog) ( #7171 )
2023-09-27 16:57:52 +02:00
Michael Auerswald
07d072c28f
fix(core): Bump License SDK Version (no-changelog) ( #7279 )
2023-09-27 16:29:09 +02:00
Val
0083a9e45d
feat(core): Initial workflow history API ( #7234 )
...
Github issue / Community forum post (link here to close automatically):
2023-09-27 15:22:39 +01:00
Milorad FIlipović
d936ca0c9f
fix(editor): Update cloud endpoint paths (no-changelog) ( #7274 )
...
Github issue / Community forum post (link here to close automatically):
2023-09-27 13:44:03 +02:00
Omar Ajoue
861cac5257
fix(core): Prevent executions from displaying Running status incorrectly ( #7261 )
...
Github issue / Community forum post (link here to close automatically):
https://linear.app/n8n/issue/HELP-338/large-number-of-long-running-executions-for-nadjalemlist#comment-18d1fc96
After investigating this issue with @ivov and @flipswitchingmonkey we've
identified this missing assignment of execution status.
This is the only inconsistency we've found that could cause executions
to continue displaying as `Running` even after finished.
2023-09-27 12:38:53 +02:00
कारतोफ्फेलस्क्रिप्ट™
5b3121c415
fix(core): Make DNS resolution order configurable ( #7272 )
2023-09-27 12:19:18 +02:00
Jon
e4c302c683
feat(MISP Node): Update credential to support HTTP Request node ( #7268 )
2023-09-27 11:05:48 +01:00
Michael Auerswald
6d7fe95c58
fix(core): Do not set ttl globally in test (no-changelog) ( #7271 )
2023-09-27 12:03:15 +02:00
Jon
cd6e22887f
docs: Update alias for iCalendar node ( #7269 )
2023-09-27 09:49:40 +01:00
Iván Ovejero
fa845453bb
feat(core): Introduce object store service ( #7225 )
...
Depends on https://github.com/n8n-io/n8n/pull/7220 | Story:
[PAY-840](https://linear.app/n8n/issue/PAY-840/introduce-object-store-service-and-manager-for-binary-data )
This PR introduces an object store service for Enterprise edition. Note
that the service is tested but currently unused - it will be integrated
soon as a binary data manager, and later for execution data.
`amazonaws.com` in the host is temporarily hardcoded until we integrate
the service and test against AWS, Cloudflare and Backblaze, in the next
PR.
This is ready for review - the PR it depends on is approved and waiting
for CI.
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-09-27 09:42:35 +02:00
Jon
2c4e25c06b
fix(PagerDuty Node): Fix typos for incident descriptions (no-changelog) ( #7267 )
2023-09-27 08:07:58 +01:00
Iván Ovejero
db01164ce1
perf(core): Skip unneeded calls on every pruning cycle ( #7260 )
2023-09-26 16:53:38 +02:00
Alex Grozav
0824800dff
fix(editor): Fix issue that double incoming connection often does not resolve expression (no-changelog) ( #7257 )
...
Cherry-picked from AI Tool Creation branch
---------
Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
2023-09-26 14:33:42 +01:00
Michael Auerswald
4b014286cf
fix(core): Make senderId required for all command messages ( #7252 )
...
all commands sent between main instance and workers need to contain a
server id to prevent senders from reacting to their own messages,
causing loops
this PR makes sure all sent messages contain a sender id by default as
part of constructing a sending redis client.
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-09-26 13:58:06 +02:00
Iván Ovejero
77d6e3fc07
refactor(core): Include workflow ID in binary data writes (no-changelog) ( #7220 )
...
Depends on: https://github.com/n8n-io/n8n/pull/7195 | Story:
[PAY-837](https://linear.app/n8n/issue/PAY-837/implement-object-store-manager-for-binary-data )
This PR includes `workflowId` in binary data writes so that the S3
manager can support this filepath structure
`/workflows/{workflowId}/executions/{executionId}/binaryData/{binaryFilename}`
to easily delete binary data for workflows. Also all binary data service
and manager methods that take `workflowId` and `executionId` are made
consistent in arg order.
Note: `workflowId` is included in filesystem mode for compatibility with
the common interface, but `workflowId` will remain unused by filesystem
mode until we decide to restructure how this mode stores data.
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-09-25 18:04:52 +02:00
Iván Ovejero
75541e91f2
refactor(core)!: Make getBinaryStream async ( #7247 )
...
Story: [PAY-846](https://linear.app/n8n/issue/PAY-846 ) | Related:
https://github.com/n8n-io/n8n/pull/7225
For the S3 backend for external storage of binary data and execution
data, the `getAsStream` method in the binary data manager interface used
by FS and S3 will need to become async. This is a breaking change for
nodes-base.
2023-09-25 16:59:45 +02:00
Iván Ovejero
484035eb51
fix(core): Fix binary data manager check on pruning ( #7251 )
...
Ensure that we do not attempt to prune binary data in `default` binary
data mode.
2023-09-25 16:50:11 +02:00
Ricardo Espinoza
d47986aec3
fix: Bug when trailing user reset password on instance (no-changelog) ( #7250 )
...
Github issue / Community forum post (link here to close automatically):
2023-09-25 09:55:33 -04:00
Mutasem Aldmour
01e9340621
feat: Add onboarding flow ( #7212 )
...
Github issue / Community forum post (link here to close automatically):
2023-09-25 15:49:36 +02:00
Ricardo Espinoza
60c152dc72
feat: Add user cloud it to telemetry ( #7232 )
...
Github issue / Community forum post (link here to close automatically):
2023-09-25 12:59:41 +02:00
Iván Ovejero
33991e92d0
fix(core): Fix missing execution ID in webhook-based workflow producing binary data ( #7244 )
...
Story: https://linear.app/n8n/issue/PAY-839
This is a longstanding bug, fixed now so that the S3 backend for binary
data can use execution IDs as part of the filename.
To reproduce:
1. Set up a workflow with a POST Webhook node that accepts binary data.
2. Activate the workflow and call it sending a binary file, e.g. `curl
-X POST -F "file=@/path/to/binary/file/test.jpg"
http://localhost:5678/webhook/uuid `
3. Check `~/.n8n/binaryData`. The binary data and metadata files will be
missing the execution ID, e.g. `11869055-83c4-4493-876a-9092c4708b9b`
instead of `39011869055-83c4-4493-876a-9092c4708b9b`.
2023-09-25 12:30:28 +02:00
Iván Ovejero
dcc9cc13ed
feat(core): Remove storeMetadata and getSize from binary data manager interface (no-changelog) ( #7195 )
...
Depends on: #7164 | Story:
[PAY-838](https://linear.app/n8n/issue/PAY-838/introduce-object-store-service-for-binary-data )
This PR removes `storeMetadata` and `getSize` from the binary data
manager interface, as these are specific to filesystem mode. Also this
disambiguates identifiers:
```
binaryDataId
filesystem:289b4aac51e-dac6-4167-b793-6d5c415e2b47 {mode}:{fileId}
fileId - FS
289b4aac51e-dac6-4167-b793-6d5c415e2b47 {executionId}{uuid}
fileId - S3
/workflows/{workflowId}/executions/{executionId}/binary_data/b4aac51e-dac6-4167-b793-6d5c415e2b47
```
Note: The object store changes originally in this PR were extracted out
into the final PR.
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-09-25 10:07:06 +02:00
Iván Ovejero
6d6e2488c6
refactor(core): Generalize binary data manager interface (no-changelog) ( #7164 )
...
Depends on: #7092 | Story:
[PAY-768](https://linear.app/n8n/issue/PAY-768 )
This PR:
- Generalizes the `IBinaryDataManager` interface.
- Adjusts `Filesystem.ts` to satisfy the interface.
- Sets up an S3 client stub to be filled in in the next PR.
- Turns `BinaryDataManager` into an injectable service.
- Adjusts the config schema and adds new validators.
Note that the PR looks large but all the main changes are in
`packages/core/src/binaryData`.
Out of scope:
- `BinaryDataManager` (now `BinaryDataService`) and `Filesystem.ts` (now
`fs.client.ts`) were slightly refactored for maintainability, but fully
overhauling them is **not** the focus of this PR, which is meant to
clear the way for the S3 implementation. Future improvements for these
two should include setting up a backwards-compatible dir structure that
makes it easier to locate binary data files to delete, removing
duplication, simplifying cloning methods, using integers for binary data
size instead of `prettyBytes()`, writing tests for existing binary data
logic, etc.
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-09-22 17:22:12 +02:00
Csaba Tuncsik
4614e1e1c9
fix(editor): Add debug feature docs link ( #7240 )
2023-09-22 13:27:08 +02:00
Michael Kret
647fc6c555
fix(editor): Fix SQL editor issue ( #7236 )
...
Github issue / Community forum post (link here to close automatically):
2023-09-22 14:17:54 +03:00
Iván Ovejero
e8e44f6b6e
refactor(core): Log binary data file write errors (no-changelog) ( #7237 )
...
This PR adds logging for binary data file write errors, to capture why
executions sometimes point to non-existing binary data files. See
[Sentry
error](https://n8nio.sentry.io/issues/4495134693/?alert_rule_id=14556563&alert_type=issue¬ification_uuid=4b50a5da-6ae9-472e-9658-984cca824762&project=4503924908883968&referrer=slack ).
2023-09-22 11:48:20 +02:00
Jon
c0df5cdfd4
fix(APITemplate.io Node): Fix action description for create pdf (no-changelog) ( #7226 )
...
Github issue / Community forum post (link here to close automatically):
https://github.com/n8n-io/n8n/issues/7224
2023-09-22 07:27:00 +01:00
Val
bf74f09d69
feat(core): Add Tournament as the new default expression evaluator ( #6964 )
...
Github issue / Community forum post (link here to close automatically):
---------
Co-authored-by: Omar Ajoue <krynble@gmail.com>
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-09-21 13:57:45 +01:00
Elias Meire
67b985fe89
fix(core): Handle filename* with quotes in Content-Disposition header ( #7229 )
...
Github issue / Community forum post (link here to close automatically):
2023-09-21 14:54:10 +02:00
Michael Kret
2af967cf88
fix(Airtable Node): Attachments field type fix ( #7227 )
...
Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/possible-airtable-bug-when-creating-attachment-record/29288
2023-09-21 15:00:41 +03:00
Ricardo Espinoza
303bc8e71e
fix: Issue enforcing user limits on start plan ( #7188 )
2023-09-21 05:56:40 -04:00
Milorad FIlipović
b0e98b59a6
feat(editor): Rework banners framework and add email confirmation banner ( #7205 )
...
This PR introduces banner framework overhaul:
First version of the banner framework was built to allow multiple
banners to be shown at the same time. Since that proven to be the case
we don't need and it turned out to be pretty messy keeping only one
banner visible in such setup, this PR reworks it so it renders only one
banner at a time, based on [this priority
list](https://www.notion.so/n8n/Banner-stack-60948c4167c743718fde80d6745258d5?pvs=4#6afd052ec8d146a1b0fab8884a19add7 )
that is assembled together with our product & design team.
### How to test banner stack:
1. Available banners and their priorities are registered
[here](f9f122d46d/packages/editor-ui/src/components/banners/BannerStack.vue (L14)b80d2e3bec/packages/editor-ui/src/stores/cloudPlan.store.ts (L59)https://chrome.google.com/webstore/detail/resource-override/pkoacgokdfckfpndoffpifphamojphii )
(URL -> File) that will serve user data that triggers this banner:
- **URL**: `*/rest/cloud/proxy/admin/user/me`
- **File**:
```
{
"confirmed": false,
"id": 1,
"email": "test@test.com",
"username": "test"
}
```
3. Run n8n
2023-09-21 09:47:21 +02:00
Mutasem Aldmour
2491ccf4d9
fix: Ensure new Set node is on top of search list ( #7215 )
...
Github issue / Community forum post (link here to close automatically):
2023-09-20 16:47:51 +02:00
कारतोफ्फेलस्क्रिप्ट™
8bb22292d5
Merge tag 'n8n@1.8.0'
2023-09-20 16:20:34 +02:00
Iván Ovejero
cd08c8e4c6
refactor(core): Implement soft-deletions for executions ( #7092 )
...
Based on #7065 | Story: https://linear.app/n8n/issue/PAY-771
n8n on filesystem mode marks binary data to delete on manual execution
deletion, on unsaved execution completion, and on every execution
pruning cycle. We later prune binary data in a separate cycle via these
marker files, based on the configured TTL. In the context of introducing
an S3 client to manage binary data, the filesystem mode's mark-and-prune
setup is too tightly coupled to the general binary data management
client interface.
This PR...
- Ensures the deletion of an execution causes the deletion of any binary
data associated to it. This does away with the need for binary data TTL
and simplifies the filesystem mode's mark-and-prune setup.
- Refactors all execution deletions (including pruning) to cause soft
deletions, hard-deletes soft-deleted executions based on the existing
pruning config, and adjusts execution endpoints to filter out
soft-deleted executions. This reduces DB load, and keeps binary data
around long enough for users to access it when building workflows with
unsaved executions.
- Moves all execution pruning work from an execution lifecycle hook to
`execution.repository.ts`. This keeps related logic in a single place.
- Removes all marking logic from the binary data manager. This
simplifies the interface that the S3 client will meet.
- Adds basic sanity-check tests to pruning logic and execution deletion.
Out of scope:
- Improving existing pruning logic.
- Improving existing execution repository logic.
- Adjusting dir structure for filesystem mode.
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-09-20 15:21:42 +02:00
Giulio Andreini
09a7cf0980
docs(Google Sheets Node): Operations naming update (no-changelog) ( #7211 )
...
Github issue / Community forum post (link here to close automatically):
2023-09-20 15:20:56 +02:00
github-actions[bot]
ecd5d93c19
🚀 Release 1.8.0 ( #7219 )
...
# [1.8.0](https://github.com/n8n-io/n8n/compare/n8n@1.7.0...n8n@1.8.0 )
(2023-09-20)
### Bug Fixes
* **core:** Make parsing of content-type and content-disposition headers
more flexible ([#7217 ](https://github.com/n8n-io/n8n/issues/7217 ))
([d41546bd41546b899#7149 ](https://github.com/n8n-io/n8n/issues/7149 )
* **core:** Resolve domains to IPv4 first
([#7206 ](https://github.com/n8n-io/n8n/issues/7206 ))
([e9ce531e9ce531210#7172 ](https://github.com/n8n-io/n8n/issues/7172 ))
([54bf66d54bf66d335#7182 ](https://github.com/n8n-io/n8n/issues/7182 ))
([3c055e43c055e4d8d#7163 ](https://github.com/n8n-io/n8n/issues/7163 ))
([07a641707a6417f0f#7165 ](https://github.com/n8n-io/n8n/issues/7165 ))
([aaf87c3aaf87c3edd#7196 ](https://github.com/n8n-io/n8n/issues/7196 ))
([6bc477b6bc477b50e#7177 ](https://github.com/n8n-io/n8n/issues/7177 ))
([321780d321780d4a2#7180 ](https://github.com/n8n-io/n8n/issues/7180 ))
([cf776b8cf776b8f17#7179 ](https://github.com/n8n-io/n8n/issues/7179 ))
([d317e09d317e09c59#7184 ](https://github.com/n8n-io/n8n/issues/7184 ))
([9f797b99f797b96d8#7154 ](https://github.com/n8n-io/n8n/issues/7154 ))
([fdac2c8fdac2c8572#7201 ](https://github.com/n8n-io/n8n/issues/7201 ))
([12a316812a3168367#4449 ](https://github.com/n8n-io/n8n/issues/4449 ))
([556a613556a6132ba#6348 ](https://github.com/n8n-io/n8n/issues/6348 ))
([3a474553a474552b2
2023-09-20 15:10:20 +02:00
Elias Meire
d41546b899
fix(core): Make parsing of content-type and content-disposition headers more flexible ( #7217 )
...
fixes #7149
2023-09-20 14:40:06 +02:00
Marcus
6bc477b50e
fix(HTML Node): Add pairedItem support for 'Convert to HTML Table' operation ( #7196 )
...
Github issue / Community forum post (link here to close automatically):
Co-authored-by: Michael Kret <michael.k@radency.com>
2023-09-20 13:56:53 +02:00
