Val
1cb92ffe16
feat: Replace owner checks with scope checks (no-changelog) ( #7846 )
...
Github issue / Community forum post (link here to close automatically):
2023-11-29 14:48:36 +00:00
कारतोफ्फेलस्क्रिप्ट™
d5762a7539
ci: Fix docker builds for releases ( #7865 )
2023-11-29 15:25:50 +01:00
Jon
5207a2fe52
fix(Google Sheets Node): Fix issue with paired items not being set correctly ( #7862 )
...
https://community.n8n.io/t/error-unknown-top-level-item-key-paireditems-item-0/33536/
Co-authored-by: Michael Kret <michael.k@radency.com>
2023-11-29 14:12:50 +00:00
oleg
51d1f5b820
fix(Notion Node): Fix broken Notion node parameters ( #7864 )
...
We've introduced a new version(`2.1` of Notion node in #7791 but not all
`diplayOptions` conditions were updated. This would effectively prevent
most of the required Notion fields from loading.
This PR adds the new version to all `@version` display conditions which
contain version `2`.
https://github.com/n8n-io/n8n/assets/12657221/4254c646-43b6-46b3-adcc-1b17746901da
Github issue / Community forum post (link here to close automatically):
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Michael Kret <michael.k@radency.com>
2023-11-29 15:11:54 +01:00
कारतोफ्फेलस्क्रिप्ट™
6d9342e676
Merge tag 'n8n@1.19.0'
2023-11-29 14:12:24 +01:00
Iván Ovejero
476806ebb0
feat(core): Allow admin creation ( #7837 )
...
https://linear.app/n8n/issue/PAY-1038
2023-11-29 13:55:41 +01:00
Marcus
5ba5ed8e3c
fix(AWS DynamoDB Node): Improve error message parsing ( #7793 )
...
Github issue / Community forum post (link here to close automatically):
2023-11-29 13:44:13 +01:00
github-actions[bot]
303cf31331
🚀 Release 1.19.0 ( #7863 )
...
#
[1.19.0](https://github.com/n8n-io/n8n/compare/n8n@1.18.0...n8n@1.19.0 )
(2023-11-29)
### Bug Fixes
* **core:** Ensure member and admin cannot be promoted to owner
([#7830 ](https://github.com/n8n-io/n8n/issues/7830 ))
([9b87a599b87a596cahttps://github.com//linear.app/n8n/issue/PAY-985/add-user-role-modification-endpoint/issues/comment-62355f6 )
* **core:** Prevent error messages due to statistics about data loading
([#7824 ](https://github.com/n8n-io/n8n/issues/7824 ))
([847f6ac847f6ac771#7788 ](https://github.com/n8n-io/n8n/issues/7788 ))
([fdb2c18fdb2c18ecc#6141 ](https://github.com/n8n-io/n8n/issues/6141 ))
([d2c18c5d2c18c5727#7811 ](https://github.com/n8n-io/n8n/issues/7811 ))
([d497041d4970410e1#7833 ](https://github.com/n8n-io/n8n/issues/7833 ))
([3ab3ec93ab3ec9da8#7789 ](https://github.com/n8n-io/n8n/issues/7789 ))
([902beff902beffce5#7841 ](https://github.com/n8n-io/n8n/issues/7841 ))
([8b993848b99384367#7843 ](https://github.com/n8n-io/n8n/issues/7843 ))
([40741074074107511#7842 ](https://github.com/n8n-io/n8n/issues/7842 ))
([28ac5a728ac5a750e#7853 ](https://github.com/n8n-io/n8n/issues/7853 ))
([c063398c0633987bf#7778 ](https://github.com/n8n-io/n8n/issues/7778 ))
([5835e055835e055d3#7808 ](https://github.com/n8n-io/n8n/issues/7808 ))
([685ffd7685ffd7413#7800 ](https://github.com/n8n-io/n8n/issues/7800 ))
([d548872d5488725a8#7782 ](https://github.com/n8n-io/n8n/issues/7782 ))
([6208af06208af07eb#7801 ](https://github.com/n8n-io/n8n/issues/7801 ))
([73ec75373ec7533ce#7336 ](https://github.com/n8n-io/n8n/issues/7336 ))
([87def6087def60979#7737 ](https://github.com/n8n-io/n8n/issues/7737 ))
([a37f1cba37f1cb0ba#7786 ](https://github.com/n8n-io/n8n/issues/7786 ))
([aae45b0aae45b043b#7455 ](https://github.com/n8n-io/n8n/issues/7455 ))
([99a9ea499a9ea497a#7797 ](https://github.com/n8n-io/n8n/issues/7797 ))
([7a86d367a86d36068#7834 ](https://github.com/n8n-io/n8n/issues/7834 ))
([2356fb02356fb0f0c#7731 ](https://github.com/n8n-io/n8n/issues/7731 ))
([da85198da851986f6#7702 ](https://github.com/n8n-io/n8n/issues/7702 ))
([67a889167a88914f2#7847 ](https://github.com/n8n-io/n8n/issues/7847 ))
([72852a672852a60eb#7763 ](https://github.com/n8n-io/n8n/issues/7763 ))
([77bc8ec77bc8ecd4b#7791 ](https://github.com/n8n-io/n8n/issues/7791 ))
([d667bcad667bca658#7829 ](https://github.com/n8n-io/n8n/issues/7829 ))
([90bb6ba90bb6ba417
2023-11-29 13:17:03 +01:00
Michael Kret
c72229fbe2
fix(core): Rename ’Marketing & Content' category to 'Marketing' (no-changelog) ( #7823 )
...
Github issue / Community forum post (link here to close automatically):
2023-11-29 13:37:46 +02:00
Val
e282ea242d
fix: Return scopes on owner setup endpoint (no-changelog) ( #7860 )
...
Github issue / Community forum post (link here to close automatically):
2023-11-29 11:33:32 +00:00
Iván Ovejero
c08c5cc37b
refactor(core): Switch plain errors in cli to ApplicationError ( #7857 )
...
Ensure all errors in `cli` are `ApplicationError` or children of it and
contain no variables in the message, to continue normalizing all the
errors we report to Sentry
Follow-up to: https://github.com/n8n-io/n8n/pull/7839
2023-11-29 12:25:10 +01:00
Jan Oberhauser
87def60979
feat: Add AI tool building capabilities ( #7336 )
...
Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/langchain-memory-chat/23733
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Val <68596159+valya@users.noreply.github.com>
Co-authored-by: Alex Grozav <alex@grozav.com>
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
Co-authored-by: Deborah <deborah@starfallprojects.co.uk>
Co-authored-by: Jesper Bylund <mail@jesperbylund.com>
Co-authored-by: Jon <jonathan.bennetts@gmail.com>
Co-authored-by: Michael Kret <88898367+michael-radency@users.noreply.github.com>
Co-authored-by: Giulio Andreini <andreini@netseven.it>
Co-authored-by: Mason Geloso <Mason.geloso@gmail.com>
Co-authored-by: Mason Geloso <hone@Masons-Mac-mini.local>
Co-authored-by: Mutasem Aldmour <mutasem@n8n.io>
2023-11-29 12:13:55 +01:00
Milorad FIlipović
8b99384367
fix(editor): Fix cloud plan data loading on instance ( #7841 )
...
Moving cloud hooks and store initialization logic after users are
authenticated. This will ensure user local account is available when
their cloud plan data is being fetched.
This PR also adds the following error handling improvements:
- Added error handling to the same initialization logic
- Fixed empty `catch` clauses inside the cloud store which caused it to
silently fail and complicated debugging of this bug
2023-11-29 10:51:15 +01:00
Jon
90bb6ba417
feat(Slack Node): Add support for getting the profile of a user ( #7829 )
...
Github issue / Community forum post (link here to close automatically):
https://github.com/n8n-io/n8n/issues/7825
This adds support for getting a users profile which returns different
data to the existing user info (Get) operation we have.
Test Workflow
```
{
"meta": {
"instanceId": "8c8c5237b8e37b006a7adce87f4369350c58e41f3ca9de16196d3197f69eabcd"
},
"nodes": [
{
"parameters": {},
"id": "69f437fb-9962-4d51-91bb-0ef4b3827e49",
"name": "When clicking \"Execute Workflow\"",
"type": "n8n-nodes-base.manualTrigger",
"typeVersion": 1,
"position": [
880,
380
]
},
{
"parameters": {
"resource": "user",
"user": {
"__rl": true,
"value": "U035F563JSW",
"mode": "list",
"cachedResultName": "jonathan"
}
},
"id": "826828db-598b-40c7-b085-5b01f2c10d73",
"name": "Get Info",
"type": "n8n-nodes-base.slack",
"typeVersion": 2.1,
"position": [
1120,
260
],
"credentials": {
"slackApi": {
"id": "E4DnXIyNuRxi5GSz",
"name": "Slack account"
}
}
},
{
"parameters": {
"resource": "user",
"operation": "getProfile",
"user": {
"__rl": true,
"value": "U035F563JSW",
"mode": "list",
"cachedResultName": "jonathan"
}
},
"id": "9de02c3f-e17c-4a32-a64e-11aaa0b36120",
"name": "Get Profile",
"type": "n8n-nodes-base.slack",
"typeVersion": 2.1,
"position": [
1120,
440
],
"credentials": {
"slackApi": {
"id": "E4DnXIyNuRxi5GSz",
"name": "Slack account"
}
}
}
],
"connections": {
"When clicking \"Execute Workflow\"": {
"main": [
[
{
"node": "Get Info",
"type": "main",
"index": 0
},
{
"node": "Get Profile",
"type": "main",
"index": 0
}
]
]
}
},
"pinData": {}
}
```
2023-11-29 08:37:18 +00:00
Alex Grozav
72852a60eb
feat(editor): Replace middleware for Role checks with Scope checks ( #7847 )
2023-11-29 10:35:40 +02:00
Csaba Tuncsik
d4970410e1
fix(editor): Add telemetry to workflow history ( #7811 )
2023-11-29 09:09:21 +01:00
Milorad FIlipović
c0633987bf
fix(editor): Fix mouse position in workflow previews ( #7853 )
...
This PR fixes mouse position detection in workflow previews (executions
preview and workflow history view):
https://github.com/n8n-io/n8n/assets/2598782/83237b76-b099-4560-9c47-a963f0848297
**Cause**:
We were setting `isDemo` state in canvas store only when the `NodeView`
component is activated, which never happens for `NodeView` instances
that are kept alive (above mentioned workflow previews)
**Fix**:
This workflow updates store state also when the `NodeView` component is
mounted.
2023-11-28 19:02:19 +01:00
Tomi Turtiainen
28ac5a750e
fix(editor): Fix icon for unknown node type ( #7842 )
2023-11-28 19:16:51 +02:00
कारतोफ्फेलस्क्रिप्ट™
2f8cb419df
ci: Fix editor tests when coverage is enabled (no-changelog) ( #7827 )
...
[Test run
](https://github.com/n8n-io/n8n/actions/runs/7021272455/job/19103012704 )
2023-11-28 18:04:30 +01:00
Csaba Tuncsik
685ffd7413
fix(editor): Suppress dev server websocket messages in workflow view ( #7808 )
2023-11-28 17:30:44 +01:00
कारतोफ्फेलस्क्रिप्ट™
117962d473
feat(core): Update LLM applications building support (no-changelog) ( #7710 )
...
extracted out of #7336
---------
Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
Co-authored-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Alex Grozav <alex@grozav.com>
2023-11-28 16:47:28 +01:00
कारतोफ्फेलस्क्रिप्ट™
4a89504d54
fix(editor): Fix push connection on WorkerList and CommunityNodes pages (no-changelog) ( #7851 )
2023-11-28 16:45:50 +01:00
Csaba Tuncsik
e87e928144
fix(editor): Remove ability for users to select admin role in the UI (no-changelog) ( #7850 )
2023-11-28 15:11:02 +01:00
Iván Ovejero
2356fb0f0c
feat(core): Set up endpoint for all existing roles with license flag ( #7834 )
...
https://linear.app/n8n/issue/PAY-1034/create-endpoint-to-list-all-existing-roles
2023-11-28 14:16:47 +01:00
Tomi Turtiainen
4074107511
fix(editor): Fix credential icon for old node type version ( #7843 )
...
If a credential was for a node's older version, its icon was not shown.
2023-11-28 15:14:22 +02:00
Val
a37f1cb0ba
feat: Add initial scope checks via decorators ( #7737 )
2023-11-28 11:41:34 +00:00
कारतोफ्फेलस्क्रिप्ट™
753cbc1e96
refactor(editor): Delete some barrel files and reduce circular dependencies (no-changelog) ( #7838 )
2023-11-28 12:15:08 +01:00
Csaba Tuncsik
3ab3ec9da8
fix(editor): Allow owners and admins to share workflows and credentials they don't own ( #7833 )
2023-11-28 11:44:55 +01:00
Iván Ovejero
1c6178759c
refactor(core): Reorganize error hierarchy in cli package (no-changelog) ( #7839 )
...
Ensure all errors in `cli` inherit from `ApplicationError` to continue
normalizing all the errors we report to Sentry
Follow-up to: https://github.com/n8n-io/n8n/pull/7820
2023-11-28 10:19:27 +01:00
Jon
38f24a6184
fix(Google Calendar Trigger Node): Fix issue preventing birthday and holiday calendars from working ( #7832 )
...
Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/issue-with-some-google-calendars/33411
---------
Co-authored-by: Michael Kret <michael.k@radency.com>
2023-11-28 09:11:05 +00:00
Michael Kret
d5488725a8
fix(Google Sheets Node): Read operation execute for each item ( #7800 )
...
Github issue / Community forum post (link here to close automatically):
2023-11-28 11:02:11 +02:00
Michael Kret
df691fba0c
fix(core): Node version in the user added node to workflow canvas event (no-changelog) ( #7814 )
...
Github issue / Community forum post (link here to close automatically):
2023-11-27 19:50:20 +02:00
Iván Ovejero
9b87a596ca
fix(core): Ensure member and admin cannot be promoted to owner ( #7830 )
...
https://linear.app/n8n/issue/PAY-985/add-user-role-modification-endpoint#comment-62355f6b
2023-11-27 17:35:58 +01:00
Tomi Turtiainen
ac744d6702
test: Ado 1296 add e2e tests ( #7792 )
...
Adds e2e tests for the template credential setup.
2023-11-27 17:18:10 +02:00
Omar Ajoue
847f6ac771
fix(core): Prevent error messages due to statistics about data loading ( #7824 )
...
Statistics collection about the first time a workflow loads data simply
attempts an insert to db, and if it fails, we just ignore.
This was causing this query to fire against production workflows
multiple times, and since we want to insert only and detect whether the
insertion failed, performing a select first provides gains both in terms
of performance, as it's usually faster than trying an insertion as well
as preventing unnecessary noise in logs.
Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/duplicate-key-value-violates-unique-constraint-workflow-statistics-pkey-still-happening/29283
https://github.com/n8n-io/n8n/issues/7256
https://community.n8n.io/t/error-log-arriving-in-postgres/30191
https://github.com/n8n-io/n8n/issues/7256
https://community.n8n.io/t/cant-launch-webhooks-unable-to-find-data-of-execution/31867
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-11-27 15:43:48 +01:00
Michael Kret
73ec7533ce
fix(Microsoft SQL Node): Prevent double escaping table name ( #7801 )
...
Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/issue-my-mssql-update-in-latest-version/32966
2023-11-27 16:41:35 +02:00
Iván Ovejero
dff8456382
refactor(core): Reorganize error hierarchy in core and workflow packages (no-changelog) ( #7820 )
...
Ensure all errors in `core` and `workflow` inherit from
`ApplicationError` so that we start normalizing all the errors we report
to Sentry
Follow-up to:
https://github.com/n8n-io/n8n/pull/7757#discussion_r1404338844
### `core` package
`ApplicationError`
- `FileSystemError` (abstract)
- `FileNotFoundError`
- `DisallowedFilepathError`
- `BinaryDataError` (abstract)
- `InvalidModeError`
- `InvalidManagerError`
- `InvalidExecutionMetadataError`
### `workflow` package
`ApplicationError`
- `ExecutionBaseError` (abstract)
- `WorkflowActivationError`
- `WorkflowDeactivationError`
- `WebhookTakenError`
- `WorkflowOperationError`
- `SubworkflowOperationError`
- `CliWorkflowOperationError`
- `ExpressionError`
- `ExpressionExtensionError`
- `NodeError` (abstract)
- `NodeOperationError`
- `NodeApiError`
- `NodeSSLError`
Up next:
- Reorganize errors in `cli`
- Flatten the hierarchy in `workflow` (do we really need
`ExecutionBaseError`?)
- Remove `ExecutionError` type
- Stop throwing plain `Error`s
- Replace `severity` with `level`
- Add node and credential types as `tags`
- Add workflow IDs and execution IDs as `extras`
2023-11-27 15:33:21 +01:00
Tomi Turtiainen
aae45b043b
feat: Ado 1296 spike credential setup in templates ( #7786 )
...
- Add a 'Setup template credentials' view to setup the credentials of a
template before it is created
2023-11-27 16:30:28 +02:00
Val
27e048c201
feat: Add Licensed decorator (no-changelog) ( #7828 )
...
Github issue / Community forum post (link here to close automatically):
2023-11-27 13:46:18 +00:00
Michael Kret
d667bca658
feat(Notion Node): Option to simplify output in getChildBlocks operation ( #7791 )
...
Github issue / Community forum post (link here to close automatically):
---------
Co-authored-by: Marcus <marcus@n8n.io>
2023-11-27 15:02:57 +02:00
Csaba Tuncsik
137e23853f
feat: Add user role select to users list settings page ( #7796 )
...
2023-11-27 13:38:03 +01:00
Val
5acb7b94c0
refactor: Refactor variables controller into a RestController (no-changelog) ( #7822 )
...
Github issue / Community forum post (link here to close automatically):
2023-11-27 12:17:09 +00:00
Iván Ovejero
7b8532d3a3
refactor(core): Move execution progress saving to standalone utility (no-changelog) ( #7770 )
...
This PR continues the effort of moving logic inside execution lifecycle
hooks into standalone testable functions, as a stepping stone to
refactoring the hooks themselves.
2023-11-27 13:10:43 +01:00
कारतोफ्फेलस्क्रिप्ट™
2807ddcd0d
fix(editor): Setup push connection in NodeView (no-changelog) ( #7821 )
2023-11-27 12:48:48 +01:00
Iván Ovejero
75a5807c72
perf(core): Make user controller tests faster (no-changelog) ( #7819 )
...
Before: `17.949 s`
After: `3.886 s`
Followup to:
https://github.com/n8n-io/n8n/pull/7797#discussion_r1404148034
2023-11-27 11:56:06 +01:00
Csaba Tuncsik
83086af247
build: Fix vite config (switch to module type) ( #7818 )
2023-11-27 10:56:57 +01:00
Alex Grozav
7cc7f226e5
fix(editor): Fix broken element-plus loading spinner (no-changelog) ( #7817 )
...
<img width="976" alt="image"
src="https://github.com/n8n-io/n8n/assets/6179477/aea8a4c8-277e-4527-b6e9-a5c3427097b6 ">
<img width="117" alt="image"
src="https://github.com/n8n-io/n8n/assets/6179477/14c8876c-5e26-4154-9fdf-8b1fe9e5f806 ">
2023-11-27 10:50:50 +02:00
कारतोफ्फेलस्क्रिप्ट™
1b60cfb8f1
ci: Fix new user patching endpoint tests (no-changelog) ( #7816 )
...
user ids are uuids, and in the future we should add proper input
validation to prevent invalid user ids reaching the DB like this.
2023-11-27 09:35:09 +01:00
Csaba Tuncsik
152883eed1
build: Upgrade lint related packages ( #7790 )
2023-11-27 09:11:52 +01:00
कारतोफ्फेलस्क्रिप्ट™
d2c18c5727
fix(core): Use AbortController to notify nodes to abort execution ( #6141 )
...
and add support for cancelling ongoing operations inside a node.
---------
Co-authored-by: Oleg Ivaniv <me@olegivaniv.com>
2023-11-24 18:17:06 +01:00
Milorad FIlipović
0ec67dabf7
fix(editor): Fix UserStack vertical centering (no-changelog) ( #7806 )
...
Dropdown items in `UserStack`component are not properly vertically
aligned. That's particularly noticeable when the items are hovered:
2023-11-24 16:38:11 +01:00
Iván Ovejero
eec2ec1ff8
refactor(core): Consolidate path-related errors in Sentry (no-changelog) ( #7757 )
...
Keep reporting [path-related
errors](https://n8nio.sentry.io/issues/4649493725 ) in Sentry but
consolidate them in a single error group.
Also, add `options.extra` as `meta` so they remain visible in debug
logs:
```
2023-11-24T11:50:54.852Z | error | ReportableError: Something went wrong "{ test: 123, file: 'LoggerProxy.js', function: 'exports.error' }"
```
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-11-24 14:42:46 +01:00
Iván Ovejero
7a86d36068
feat(core): Allow user role modification ( #7797 )
...
https://linear.app/n8n/issue/PAY-985
```
PATCH /users/:id/role
unauthenticated user
✓ should receive 401 (349 ms)
member
✓ should fail to demote owner to member (349 ms)
✓ should fail to demote owner to admin (359 ms)
✓ should fail to demote admin to member (381 ms)
✓ should fail to promote other member to owner (353 ms)
✓ should fail to promote other member to admin (377 ms)
✓ should fail to promote self to admin (354 ms)
✓ should fail to promote self to owner (371 ms)
admin
✓ should receive 400 on invalid payload (351 ms)
✓ should receive 404 on unknown target user (351 ms)
✓ should fail to demote owner to admin (349 ms)
✓ should fail to demote owner to member (347 ms)
✓ should fail to promote member to owner (384 ms)
✓ should fail to promote admin to owner (350 ms)
✓ should be able to demote admin to member (354 ms)
✓ should be able to demote self to member (350 ms)
✓ should be able to promote member to admin (349 ms)
owner
✓ should be able to promote member to admin (349 ms)
✓ should be able to demote admin to member (349 ms)
✓ should fail to demote self to admin (348 ms)
✓ should fail to demote self to member (354 ms)
```
2023-11-24 11:40:08 +01:00
Tomi Turtiainen
87fa3c2985
test: Remove obsolete snapshot ( #7803 )
...
Fixes
```
Snapshots 1 obsolete
↳ src/components/banners/__tests__/V1Banner.spec.ts
· V1 Banner > should render banner if user is not woner 1
```
2023-11-24 11:53:28 +02:00
Elias Meire
da851986f6
feat(editor): Add node name and version to NDV node settings ( #7731 )
...
<img width="580" alt="image"
src="https://github.com/n8n-io/n8n/assets/8850410/85ac1c6e-9116-436a-a2ed-8d0ac162a287 ">
<img width="580" alt="image"
src="https://github.com/n8n-io/n8n/assets/8850410/08b37377-cef5-4f80-80c0-addfdd37f728 ">
---------
Co-authored-by: Giulio Andreini <andreini@netseven.it>
2023-11-23 18:28:07 +01:00
Elias Meire
902beffce5
fix(editor): Disable context menu actions in read-only mode ( #7789 )
...
Github issue / Community forum post (link here to close automatically):
2023-11-23 17:10:45 +01:00
Val
865192adf0
feat: Add global admin role (no-changelog) ( #7781 )
...
Github issue / Community forum post (link here to close automatically):
2023-11-23 13:38:11 +00:00
Michael Auerswald
5835e055d3
fix(editor): Show nice error when environment is not set up ( #7778 )
...
Adds a nicer error message with a link for owners who press Push to Git
without having a repository connected yet.
2023-11-23 13:50:03 +01:00
Alex Grozav
67a88914f2
feat(editor): Add routing middleware, permission checks, RBAC store, RBAC component ( #7702 )
...
Github issue / Community forum post (link here to close automatically):
---------
Co-authored-by: Csaba Tuncsik <csaba@n8n.io>
2023-11-23 13:22:47 +02:00
Iván Ovejero
fdb2c18ecc
fix(core): Tighten checks for multi-main setup usage ( #7788 )
...
https://n8nio.slack.com/archives/C05HRPLSGTT/p1700731476321999?thread_ts=1700729359.746899&cid=C05HRPLSGTT
2023-11-23 12:18:39 +01:00
Marcus
6208af07eb
fix(HTTP Request Node): Enable expressions for binary input data fields ( #7782 )
...
Github issue / Community forum post (link here to close automatically):
https://github.com/n8n-io/n8n/issues/7775
2023-11-23 11:58:50 +01:00
Csaba Tuncsik
e128b23a2b
build: Upgrade to Vite 5 ( #7784 )
2023-11-23 11:55:02 +01:00
Milorad FIlipović
77bc8ecd4b
feat(editor): Show avatars for users currently working on the same workflow ( #7763 )
...
This PR introduces the following changes:
- New Vue stores: `collaborationStore` and `pushConnectionStore`
- Front-end push connection handling overhaul: Keep only a singe
connection open and handle it from the new store
- Add user avatars in the editor header when there are multiple users
working on the same workflow
- Sending a heartbeat event to back-end service periodically to confirm
user is still active
- Back-end overhauls (authored by @tomi):
- Implementing a cleanup procedure that removes inactive users
- Refactoring collaboration service current implementation
---------
Co-authored-by: Tomi Turtiainen <10324676+tomi@users.noreply.github.com>
2023-11-23 10:14:34 +01:00
Michael Kret
99a9ea497a
feat(core): Add Support for custom CORS origins for webhooks ( #7455 )
...
node-850
https://community.n8n.io/t/add-ability-to-set-cors-allow-list-in-n8n-webhooks/7610
https://community.n8n.io/t/configure-cors-pre-flight-request-option-method-in-the-roadmap/32189
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-11-22 17:49:56 +01:00
कारतोफ्फेलस्क्रिप्ट™
96fd2c51bd
fix(core): Show webhook urls for all webhook nodes (no-changelog) ( #7783 )
...
This reverts parts of https://github.com/n8n-io/n8n/pull/7113
2023-11-22 17:45:26 +01:00
Csaba Tuncsik
50f568560f
perf: Make frontend linting faster (no-changelog) ( #7717 )
...
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-11-22 15:01:22 +01:00
github-actions[bot]
e01617ad64
🚀 Release 1.18.0 ( #7780 )
...
#
[1.18.0](https://github.com/n8n-io/n8n/compare/n8n@1.17.0...n8n@1.18.0 )
(2023-11-22)
### Bug Fixes
* **core:** Account for non-ASCII chars in filename on binary data
download ([#7742 ](https://github.com/n8n-io/n8n/issues/7742 ))
([b4ebb1ab4ebb1a28d#7724 ](https://github.com/n8n-io/n8n/issues/7724 ))
([f96c1d2f96c1d2044#7744 ](https://github.com/n8n-io/n8n/issues/7744 ))
([b7c5c74b7c5c7406f#7750 ](https://github.com/n8n-io/n8n/issues/7750 ))
([6be453b6be453b716#7723 ](https://github.com/n8n-io/n8n/issues/7723 ))
([e2ffd39e2ffd397fc#7730 ](https://github.com/n8n-io/n8n/issues/7730 ))
([ebee1a5ebee1a5908#7761 ](https://github.com/n8n-io/n8n/issues/7761 ))
([366cd67366cd672a7#7766 ](https://github.com/n8n-io/n8n/issues/7766 ))
([0d3d33d0d3d33dd1f#7722 ](https://github.com/n8n-io/n8n/issues/7722 ))
([44d3b3e44d3b3ed7e#7764 ](https://github.com/n8n-io/n8n/issues/7764 ))
([ff0b651ff0b6511f7#7608 ](https://github.com/n8n-io/n8n/issues/7608 ))
([2064f7f2064f7f251#7734 ](https://github.com/n8n-io/n8n/issues/7734 ))
([ce002a6ce002a6cc6#7729 ](https://github.com/n8n-io/n8n/issues/7729 ))
([5d4a52d5d4a52d3b7#7678 ](https://github.com/n8n-io/n8n/issues/7678 ))
([4f307644f307646f3#7751 ](https://github.com/n8n-io/n8n/issues/7751 ))
([82f320282f3202a2d#7721 ](https://github.com/n8n-io/n8n/issues/7721 ))
([4dbae0e4dbae0e2e9#7643 ](https://github.com/n8n-io/n8n/issues/7643 ))
([4c408254c4082503c#7620 ](https://github.com/n8n-io/n8n/issues/7620 ))
([8d12c1a8d12c1ad8d#7503 ](https://github.com/n8n-io/n8n/issues/7503 ))
([188176518817651ec
2023-11-22 14:32:25 +01:00
कारतोफ्फेलस्क्रिप्ट™
db77353272
fix(core): Pass correct node reference to NodeExecuteFunctions.getLoadOptionsFunctions (no-changelog) ( #7779 )
...
NODE-947
2023-11-22 13:24:23 +01:00
Milorad FIlipović
2064f7f251
fix(editor): Validate user info before submiting ( #7608 )
...
Validate first and last names before saving them to database. This
should prevent security issue with un-sanitized data that ends up in
emails.
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-11-22 12:14:44 +01:00
कारतोफ्फेलस्क्रिप्ट™
9b4856e7de
feat(core): Make postgres pool-size configurable (no-changelog) ( #7772 )
...
When we upgrade typeorm in #5151 , we switched from no pooling to a
default pool-size of 10. This somehow significantly deteriorates the
performance of queries when the application is under load.
2023-11-21 18:13:08 +01:00
Iván Ovejero
3459eb6c2f
refactor(core): Include execution progress in save settings (no-changelog) ( #7769 )
2023-11-21 17:33:44 +01:00
Michael Auerswald
0d3d33dd1f
fix(editor): Only show push to git menu item to owners ( #7766 )
...
Removes the menu entry of "Push to Git" from the workflow menu for
non-owners, since they would not be able to push in the first place.
2023-11-21 15:20:15 +01:00
Michael Auerswald
ff0b6511f7
fix(editor): Use project diagram icon for worker view ( #7764 )
...
Swap monster truck for project diagram icon
2023-11-21 15:18:14 +01:00
Marcus
4f307646f3
fix(Item Lists Node): Don't check same type in remove duplicates operation ( #7678 )
...
Github issue / Community forum post (link here to close automatically):
---------
Co-authored-by: Michael Kret <michael.k@radency.com>
2023-11-21 13:10:59 +01:00
Michael Auerswald
366cd672a7
fix(editor): Move workerview entry into settings menu ( #7761 )
...
As the worker view is not an essential function, it is being moved from
the main side bar to the settings side bar for the time being.
2023-11-21 11:29:24 +01:00
Iván Ovejero
b7c5c7406f
fix(core): Ensure failed executions are saved in queue mode ( #7744 )
...
This PR adds `status` to run data so that
`determineFinalExecutionStatus` resolves correctly on execution failure
and removes the cleanup that is being duplicated in a worker hook.
Followup to https://github.com/n8n-io/n8n/pull/7138
Should fix:
- https://github.com/n8n-io/n8n/issues/7705
-
https://linear.app/n8n/issue/PAY-964/no-execution-found-after-execution-fails
-
https://linear.app/n8n/issue/PAY-1010/execution-deletion-in-queue-mode-not-complying-with-settings
2023-11-20 16:03:02 +01:00
Deborah
ad04986ce7
docs: Update docs links for data transformation functions and ifEmpty ( #7758 )
...
Github issue / Community forum post (link here to close automatically):
2023-11-20 13:40:28 +00:00
Elias Meire
8d12c1ad8d
feat(editor): Add node context menu ( #7620 )
...
2023-11-20 14:37:12 +01:00
Milorad FIlipović
4dbae0e2e9
feat: Add Creator hub link to Templates page ( #7721 )
...
Replace the `New Blank Workflow` button with link to the new Creator Hub
in the Templates page
2023-11-20 10:51:46 +01:00
Iván Ovejero
0fda8d9aac
refactor(core): Stop reporting to Sentry NodeApiError outside 500 range (no-changelog) ( #7753 )
...
https://n8nio.sentry.io/issues/4312838883 (and many others)
Followup to https://github.com/n8n-io/n8n/pull/7662
2023-11-17 17:49:28 +01:00
Iván Ovejero
6be453b716
fix(core): Guard against node not found on cancelling test webhook ( #7750 )
...
https://n8nio.sentry.io/issues/4623682198
2023-11-17 17:10:26 +01:00
Iván Ovejero
82f3202a2d
fix(JotForm Trigger Node): Fix iteration on form loader ( #7751 )
...
https://n8nio.sentry.io/issues/4636463129
2023-11-17 16:42:30 +01:00
Iván Ovejero
6d19f88080
refactor(core): Stop reporting to Sentry unknown cred on mapping (no-changelog) ( #7752 )
...
https://n8nio.sentry.io/issues/4563418905
2023-11-17 16:17:44 +01:00
Iván Ovejero
4c4082503c
feat(core): Coordinate manual workflow activation and deactivation in multi-main scenario ( #7643 )
...
Followup to #7566 | Story: https://linear.app/n8n/issue/PAY-926
### Manual workflow activation and deactivation
In a multi-main scenario, if the user manually activates or deactivates
a workflow, the process (whether leader or follower) that handles the
PATCH request and updates its internal state should send a message into
the command channel, so that all other main processes update their
internal state accordingly:
- Add to `ActiveWorkflows` if activating
- Remove from `ActiveWorkflows` if deactivating
- Remove and re-add to `ActiveWorkflows` if the update did not change
activation status.
After updating their internal state, if activating or deactivating, the
recipient main processes should push a message to all connected
frontends so that these can update their stores and so reflect the value
in the UI.
### Workflow activation errors
On failure to activate a workflow, the main instance should record the
error in Redis - main instances should always pull activation errors
from Redis in a multi-main scenario.
### Leadership change
On leadership change...
- The old leader should stop pruning and the new leader should start
pruning.
- The old leader should remove trigger- and poller-based workflows and
the new leader should add them.
2023-11-17 15:58:50 +01:00
कारतोफ्फेलस्क्रिप्ट™
2d039010db
fix(editor): Fix Admin panel icon in the sidebar for cloud deployments (no-changelog) ( #7738 )
...
Co-authored-by: ricardo <ricardoespinoza105@gmail.com>
Co-authored-by: Mutasem Aldmour <mutasem@n8n.io>
2023-11-17 14:44:47 +01:00
कारतोफ्फेलस्क्रिप्ट™
b66b8c18e9
fix(editor): Remove n8nHooksNext flag (no-changelog) ( #7733 )
...
Hooks won't be injected anymore
https://github.com/n8n-io/n8n-hosted-backend/pull/816
2023-11-17 14:44:28 +01:00
Mutasem Aldmour
44d3b3ed7e
fix(editor): Show v1 banner dismiss button if owner ( #7722 )
...
Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/v1-upgrade-banner-shall-be-dismissed-permanently/32775
2023-11-17 14:15:13 +01:00
Jon
ce002a6cc6
fix(GitHub Node): Fix issue preventing file edits on branches ( #7734 )
...
Github issue / Community forum post (link here to close automatically):
https://github.com/n8n-io/n8n/issues/7614
2023-11-17 13:07:33 +00:00
कारतोफ्फेलस्क्रिप्ट™
db094f2d7e
fix(core): Fix all dependency versions for backend packages (no-changelog) ( #7745 )
...
Once the packages are published to NPM, they don't have the
`pnpm-lock.yaml` to fix dependency versions. Which means that any
dependency with `^` gets auto-upgrade to the latest matching minor,
which can cause issues like
[this](https://github.com/node-cache-manager/node-cache-manager/issues/611 ).
2023-11-17 13:49:18 +01:00
कारतोफ्फेलस्क्रिप्ट™
fc60e9a809
refactor(core): Convert dynamic node-parameter routes to a decorated controller (no-changelog) ( #7284 )
...
1. Reduce a lot of code duplication
2. Move more endpoints out of `Server.ts`
3. Move all query-param parsing and validation into a middleware to make
the route handlers simpler.
2023-11-17 12:03:05 +01:00
Iván Ovejero
05ed86c64b
refactor: Stop reporting to Sentry Facebook multi-webhook error (no-changelog) ( #7743 )
...
https://n8nio.sentry.io/issues/4640072705
2023-11-17 11:39:46 +01:00
Iván Ovejero
0408299c7d
refactor(core): Stop reporting to Sentry unrecognized node errors (no-changelog) ( #7728 )
...
https://n8nio.sentry.io/issues/4636584213
2023-11-17 10:25:10 +01:00
Iván Ovejero
b4ebb1a28d
fix(core): Account for non-ASCII chars in filename on binary data download ( #7742 )
...
https://n8nio.sentry.io/issues/4641538638
2023-11-17 10:07:44 +01:00
Ricardo Espinoza
8e0ae3cf8c
refactor: Extract Invitation routes to InvitationController (no-changelog) ( #7726 )
...
This PR:
- Creates `InvitationController`
- Moves `POST /users` to `POST /invitations` and move related test to
`invitations.api.tests`
- Moves `POST /users/:id` to `POST /invitations/:id/accept` and move
related test to `invitations.api.tests`
- Adjusts FE to use new endpoints
- Moves all the invitation logic to the `UserService`
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-11-16 12:39:43 -05:00
Csaba Tuncsik
e2ffd397fc
fix(editor): Handle permission edge cases (empty scopes) ( #7723 )
2023-11-16 18:08:23 +01:00
Iván Ovejero
5d4a52d3b7
fix(Google Sheets Node): Check for null before destructuring ( #7729 )
...
https://n8nio.sentry.io/issues/4613453684
2023-11-16 16:50:06 +01:00
Val
d39bb2540f
feat: Add scopes to /login endpoint (no-changelog) ( #7718 )
...
Github issue / Community forum post (link here to close automatically):
2023-11-16 11:11:55 +00:00
कारतोफ्फेलस्क्रिप्ट™
ebee1a5908
fix(editor): Make sure LineController is registered with chart.js ( #7730 )
...
Tree shaking in production build of the editor-ui package removed the
LineController, this makes sure it is in the final package.
2023-11-16 11:57:43 +01:00
Michael Auerswald
f96c1d2044
fix(core): Correct permissions for getstatus ( #7724 )
2023-11-15 16:54:33 +01:00
Csaba Tuncsik
18817651ec
feat(editor): Node IO filter ( #7503 )
...
Co-authored-by: Omar Ajoue <krynble@gmail.com>
2023-11-15 16:19:48 +01:00
