Cornelius Suermann
a8b4684192
build: Bump license-sdk to v2.9.1 (no-changelog) ( #8420 )
2024-01-23 14:44:46 +01:00
Iván Ovejero
c0bc94c78f
refactor(core): Finish removing UserManagementHelper (no-changelog) ( #8418 )
2024-01-23 13:58:31 +01:00
Iván Ovejero
a0a1830696
feat(core): Email recipients on resource shared ( #8408 )
2024-01-23 12:03:59 +01:00
Danny Martini
ae06fdeb62
fix(core): Fix update workflow cli command being unable to activate all workflows ( #8412 )
...
Co-authored-by: Daniel Schröder <daniel.schroeder@skriptfabrik.com>
2024-01-23 10:59:06 +01:00
Iván Ovejero
49b52c4f1d
refactor(core): Bring active executions into executions controller (no-changelog) ( #8371 )
2024-01-23 09:48:50 +01:00
कारतोफ्फेलस्क्रिप्ट™
913c8c6b0c
feat(core): Upgrade oclif (no-changelog) ( #8381 )
2024-01-22 18:25:36 +01:00
Cornelius Suermann
d597c2ab29
feat: Extend collection of usage metrics during license renewal (no-changelog) ( #8369 )
...
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
2024-01-22 12:29:28 +01:00
Iván Ovejero
f35d4fcbd8
refactor(core): Simplify OrchestrationService (no-changelog) ( #8364 )
2024-01-22 11:16:29 +01:00
Danny Martini
07e6705256
feat(core): Custom session timeout and refresh configuration ( #8342 )
2024-01-22 09:54:13 +01:00
Giulio Andreini
f4f496ae85
docs(editor): All buttons to sentence case (no-changelog) ( #8399 )
2024-01-22 09:20:02 +01:00
Jon
9883eda42e
fix: Fix openapi generation (no-changelog) ( #8398 )
2024-01-19 18:15:33 +01:00
Iván Ovejero
749ac2b407
fix(core): Adjust starter node priority for manual executions with pinned activators ( #8386 )
2024-01-19 10:18:04 +01:00
कारतोफ्फेलस्क्रिप्ट™
c7c4ae4514
feat(core): Upgrade swagger (no-changelog) ( #8384 )
2024-01-18 14:16:14 +01:00
Tomi Turtiainen
f31cc0743f
fix: Force posthog recording to be disabled outside cloud ( #8374 )
2024-01-18 14:44:27 +02:00
Jon
fc94377036
fix: Fix issue preventing secrets with a - in the path from being imported ( #8378 )
2024-01-18 09:24:58 +00:00
Tomi Turtiainen
99457019f7
feat: Nudge users to become template creators if eligible ( #8357 )
2024-01-17 19:07:34 +02:00
कारतोफ्फेलस्क्रिप्ट™
3912c5e7ab
feat(core): Upgrade axios and follow-redirects to address CVE-2023-26159 ( #8366 )
2024-01-17 16:41:01 +01:00
कारतोफ्फेलस्क्रिप्ट™
639d34769e
feat(core): Upgrade bull and ioredis to address CVE-2023-52079 ( #8365 )
2024-01-17 16:33:54 +01:00
Tomi Turtiainen
9a1cc56806
fix: Set '@typescript-eslint/return-await' rule to 'always' for node code (no-changelog) ( #8363 )
...
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2024-01-17 17:08:50 +02:00
Iván Ovejero
2eb829a6b4
refactor(core): Use DI in execution services (no-changelog) ( #8358 )
2024-01-17 15:42:19 +01:00
github-actions[bot]
7268d24259
🚀 Release 1.25.0 ( #8362 )
...
Co-authored-by: netroy <netroy@users.noreply.github.com>
2024-01-17 14:20:55 +01:00
Iván Ovejero
771d2fa341
test(core): Fix cleanup in test teardown script (no-changelog) ( #8361 )
2024-01-17 14:01:56 +01:00
Omar Ajoue
d5455d7acc
fix(core): Report when waitTill is invalid and handle it ( #8356 )
2024-01-17 13:08:20 +01:00
कारतोफ्फेलस्क्रिप्ट™
7cdbb424e3
refactor(core): Move methods from WorkflowHelpers into various workflow services (no-changelog) ( #8348 )
2024-01-17 10:16:13 +01:00
Iván Ovejero
d4c93b1607
fix(core): Prevent issues with missing or mismatching encryption key ( #8332 )
2024-01-16 18:25:53 +01:00
Iván Ovejero
7bb2d1799e
refactor(core): Consolidate executions controllers (no-changelog) ( #8349 )
2024-01-16 16:52:21 +01:00
कारतोफ्फेलस्क्रिप्ट™
64ceb16af6
refactor(core): Use DI in PermissionChecker (no-changelog) ( #8344 )
2024-01-16 14:15:29 +01:00
Iván Ovejero
420b4271a9
refactor(core): Move typeorm operators from Public API (no-changelog) ( #8319 )
2024-01-16 13:35:43 +01:00
Omar Ajoue
e1acb5911a
refactor: Make execution IDs mandatory in BE ( #8299 )
...
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
2024-01-16 09:53:17 +00:00
Iván Ovejero
0f4f472a72
refactor(core): Eliminate dead Redis code (no-changelog) ( #8292 )
2024-01-16 09:31:45 +01:00
Iván Ovejero
5fbd7971e0
fix(core): Account for immediate confirmation request during test webhook creation ( #8329 )
2024-01-16 09:17:41 +01:00
Ricardo Espinoza
3c2a4000ae
refactor(core): Use DI for LDAP code (no-changelog) ( #8248 )
...
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2024-01-15 09:01:48 -05:00
Iván Ovejero
1a0e285553
feat(core): Implement inter-main communication for test webhooks in multi-main setup ( #8267 )
2024-01-12 11:48:58 +01:00
oleg
884396ea0d
fix(API): Fix manual chat trigger execution ( #8300 )
...
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
2024-01-11 14:01:07 +01:00
Omar Ajoue
8c7f39907f
fix: Properly output saml validation errors ( #8284 )
2024-01-10 16:56:04 +01:00
github-actions[bot]
8a4231e9f6
🚀 Release 1.24.0 ( #8290 )
...
Co-authored-by: ivov <ivov@users.noreply.github.com>
2024-01-10 16:16:25 +01:00
Omar Ajoue
8a7c629ea1
fix: Store workflow settings when saving an execution ( #8288 )
2024-01-10 14:20:37 +00:00
Michael Kret
ccde38a8a8
fix(Monday.com Node): Migrate to api 2023-10 ( #8254 )
2024-01-10 11:17:00 +02:00
Iván Ovejero
5032bf0e34
fix(core): Fix test webhook deregistration ( #8247 )
2024-01-09 16:02:32 +01:00
Iván Ovejero
0dabe5c74e
fix: Fix user reinvites on FE and BE ( #8261 )
2024-01-09 13:52:34 +01:00
Tomi Turtiainen
3b996a7da0
feat(core): Validate shutdown handlers on startup ( #8260 )
2024-01-08 17:46:45 +02:00
Tomi Turtiainen
8affdf680d
fix: Hide cred setup button from canvas (no-changelog) ( #8255 )
2024-01-08 13:59:04 +02:00
Iván Ovejero
90c065e999
refactor(core): Convert workflows controller to DI (no-changelog) ( #8253 )
2024-01-08 12:54:23 +01:00
कारतोफ्फेलस्क्रिप्ट™
ac1c642fdd
fix(core): Do not add Authentication header when authentication type is body ( #8201 )
2024-01-08 12:38:24 +01:00
Jan Oberhauser
ccb2b076f8
fix: Resolve expressions in credentials following paired item ( #8250 )
...
## Summary
Fixes the issue that pairedItem information was not available in
expressions that got used in credentials
## Related tickets and issues
[PAY-1207](https://linear.app/n8n/issue/PAY-1207/paireditem-expressions-not-working-correctly-in-credentials )
## Review / Merge checklist
- [x] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
> A feature is not complete without tests.
---------
Co-authored-by: Omar Ajoue <krynble@gmail.com>
2024-01-08 09:48:20 +00:00
Iván Ovejero
f2939568cf
perf(core): Optimize workflow activation errors ( #8242 )
...
At https://github.com/n8n-io/n8n/pull/8213 we introduced Redis hashes
for workflow ownership and manual webhooks...
- to remove clutter from multiple related keys at the top level,
- to improve performance by preventing serializing-deserializing, and
- to guarantee atomicity during concurrent updates in multi-main setup.
Workflow activation errors can also benefit from this. Added test
coverage as well.
To test manually, create a workflow with a trigger with an invalid
credential, edit the workflow's `active` column to `true`, and restart.
The activation error should show as a red triangle on canvas and in the
workflow list.
2024-01-05 13:06:42 +01:00
Iván Ovejero
23a4ac96c0
refactor(core): Continue moving typeorm operators to repositories (no-changelog) ( #8212 )
...
Follow-up to: https://github.com/n8n-io/n8n/pull/8186
2024-01-05 13:06:24 +01:00
Iván Ovejero
f53c482939
perf(core): Improve caching service ( #8213 )
...
Story: https://linear.app/n8n/issue/PAY-1188
- Implement Redis hashes on the caching service, based on Micha's work
in #7747 , adapted from `node-cache-manager-ioredis-yet`. Optimize
workflow ownership lookups and manual webhook lookups with Redis hashes.
- Simplify the caching service by removing all currently unused methods
and options: `enable`, `disable`, `getCache`, `keys`, `keyValues`,
`refreshFunctionEach`, `refreshFunctionMany`, `refreshTtl`, etc.
- Remove the flag `N8N_CACHE_ENABLED`. Currently some features on
`master` are broken with caching disabled, and test webhooks now rely
entirely on caching, for multi-main setup support. We originally
introduced this flag to protect against excessive memory usage, but
total cache usage is low enough that we decided to drop this setting.
Apparently this flag was also never documented.
- Overall caching service refactor: use generics, reduce branching, add
discriminants for cache kinds for better type safety, type caching
events, improve readability, remove outdated docs, etc. Also refactor
and expand caching service tests.
Follow-up to: https://github.com/n8n-io/n8n/pull/8176
---------
Co-authored-by: Michael Auerswald <michael.auerswald@gmail.com>
2024-01-05 11:52:44 +01:00
Iván Ovejero
22a5f5258d
feat(core): Cache test webhook registrations ( #8176 )
...
In a multi-main setup, we have the following issue. The user's client
connects to main A and runs a test webhook, so main A starts listening
for a webhook call. A third-party service sends a request to the test
webhook URL. The request is forwarded by the load balancer to main B,
who is not listening for this webhook call. Therefore, the webhook call
is unhandled.
To start addressing this, cache test webhook registrations, using Redis
for queue mode and in-memory for regular mode. When the third-party
service sends a request to the test webhook URL, the request is
forwarded by the load balancer to main B, who fetches test webhooks from
the cache and, if it finds a match, executes the test webhook. This
should be transparent - test webhook behavior should remain the same as
so far.
Notes:
- Test webhook timeouts are not cached. A timeout is only relevant to
the process it was created in, so another process retrieving from Redis
a "foreign" timeout will be unable to act on it. A timeout also has
circular references, so `cache-manager-ioredis-yet` is unable to
serialize it.
- In a single-main scenario, the timeout remains in the single process
and is cleared on test webhook expiration, successful execution, and
manual cancellation - all as usual.
- In a multi-main scenario, we will need to have the process who
received the webhook call send a message to the process who created the
webhook directing this originating process to clear the timeout. This
will likely be implemented via execution lifecycle hooks and Redis
channel messages checking session ID. This implementation is out of
scope for this PR and will come next.
- Additional data in test webhooks is not cached. From what I can tell,
additional data is not needed for test webhooks to be executed.
Additional data also has circular references, so
`cache-manager-ioredis-yet` is unable to serialize it.
Follow-up to: #8155
2024-01-03 16:58:33 +01:00
github-actions[bot]
053503531f
🚀 Release 1.23.0 ( #8205 )
...
#
[1.23.0](https://github.com/n8n-io/n8n/compare/n8n@1.22.0...n8n@1.23.0 )
(2024-01-03)
### Bug Fixes
* **Asana Node:** Omit body from GET, HEAD, and DELETE requests
([#8057 ](https://github.com/n8n-io/n8n/issues/8057 ))
([15ffd4f15ffd4fb9f#8189 ](https://github.com/n8n-io/n8n/issues/8189 ))
([cfe9525cfe9525dd4#8123 ](https://github.com/n8n-io/n8n/issues/8123 ))
([fa8bd8bfa8bd8b9eb#8121 ](https://github.com/n8n-io/n8n/issues/8121 ))
([ffaa30dffaa30ddc4#8128 ](https://github.com/n8n-io/n8n/issues/8128 ))
([21788d921788d9153#8164 ](https://github.com/n8n-io/n8n/issues/8164 ))
([ea7e76fea7e76fa3b#8060 ](https://github.com/n8n-io/n8n/issues/8060 ))
([ef3a577ef3a57719e#8126 ](https://github.com/n8n-io/n8n/issues/8126 ))
([c83d9f4c83d9f45ba#8178 ](https://github.com/n8n-io/n8n/issues/8178 ))
([cf7f668cf7f6688ba#8114 ](https://github.com/n8n-io/n8n/issues/8114 ))
([711fa2b711fa2b925#8196 ](https://github.com/n8n-io/n8n/issues/8196 ))
([d01e42ad01e42a2aa#8198 ](https://github.com/n8n-io/n8n/issues/8198 ))
([5c078f15c078f1b3d#8116 ](https://github.com/n8n-io/n8n/issues/8116 ))
([e928210e928210ccd#8118 ](https://github.com/n8n-io/n8n/issues/8118 ))
([39e45d839e45d8b92#8173 ](https://github.com/n8n-io/n8n/issues/8173 ))
([405e267405e26757e#8190 ](https://github.com/n8n-io/n8n/issues/8190 ))
([11cda4111cda41214#8200 ](https://github.com/n8n-io/n8n/issues/8200 ))
([3b6ae2d3b6ae2d0a5#8154 ](https://github.com/n8n-io/n8n/issues/8154 ))
([8e873ca8e873ca2f3#8153 ](https://github.com/n8n-io/n8n/issues/8153 ))
([e94b8a6e94b8a6c30#8129 ](https://github.com/n8n-io/n8n/issues/8129 ))
([a169b74a169b74062#8185 ](https://github.com/n8n-io/n8n/issues/8185 ))
([17a4e2e17a4e2ea80#8109 ](https://github.com/n8n-io/n8n/issues/8109 ))
([e9c7fd7e9c7fd7397#7708 ](https://github.com/n8n-io/n8n/issues/7708 ))
([bec0faebec0faed9e#8144 ](https://github.com/n8n-io/n8n/issues/8144 ))
([e126ed7e126ed74f3#7651 ](https://github.com/n8n-io/n8n/issues/7651 ))
([5e16dd45e16dd4ab4#8104 ](https://github.com/n8n-io/n8n/issues/8104 ))
([01e9a7901e9a79238#8097 ](https://github.com/n8n-io/n8n/issues/8097 ))
([3a881be3a881be6c2#8124 ](https://github.com/n8n-io/n8n/issues/8124 ))
([ab74badab74bade05#8088 ](https://github.com/n8n-io/n8n/issues/8088 ))
([517b050517b050d0a#8150 ](https://github.com/n8n-io/n8n/issues/8150 ))
([518a99e518a99e528#8080 ](https://github.com/n8n-io/n8n/issues/8080 ))
([66460f666460f66b0#8199 ](https://github.com/n8n-io/n8n/issues/8199 ))
([65c8e1265c8e12b96
2024-01-03 13:41:28 +01:00
