Commit graph

7710 commits

Author SHA1 Message Date
agobrech 18d2e7cd57
fix(LinkedIn Node): Update the version of the API (#5720)
* 🐛 Change request to follow new API version

* Extract urn from response header

* Change body params for image and media request

* Fix body for Image and Article posts

* remove console log

---------

Co-authored-by: Marcus <marcus@n8n.io>
2023-03-31 15:04:43 +02:00
Alex Grozav 97b35daf0a
fix: Fix parameter inputField ref not yet mounted (no-changelog) (#5864)
* fix: fix parameter inputField ref not yet mounted

* fix: move optional chaining

* fix: fix focus condition
2023-03-31 15:59:54 +03:00
Milorad FIlipović 0a59002ef8
feat(editor): Enable saving workflow when node details view is open (#5856)
* feat(editor): Enable saving workflow when node details view is open
*  Preventing event propagation
*  Move save event handler to `NodeDetailsView`
*  Added e2e tests
* 👕 Fixing linting and removing unnecessary event logic

---------

Co-authored-by: Oleg Ivaniv <oleg@n8n.io>
2023-03-31 13:59:09 +02:00
Michael Auerswald 83aef17120
feat(core): Read ephemeral license from environment and clean up ee flags (#5808)
Co-authored-by: Cornelius Suermann <cornelius@n8n.io>
2023-03-31 13:51:38 +02:00
Iván Ovejero 3ae69337ee
fix(editor): Curb overeager item access linting (#5865)
 Curb overeager item access linting
2023-03-31 13:33:57 +02:00
Michael Kret e11a30a640
fix(HubSpot Trigger Node): Developer API key is required for webhooks 2023-03-31 14:02:32 +03:00
Michael Kret 085660d7d7
fix(core): Fix curl import error when no data 2023-03-31 14:01:21 +03:00
Michael Kret 0da3b96cfc
fix(HTML Extract Node): Support for dot notation in JSON property 2023-03-31 14:00:45 +03:00
Mutasem Aldmour e3884ce378
fix: Add droppable state for booleans when mapping (#5838) 2023-03-31 12:35:02 +02:00
Csaba Tuncsik 96533a995c
fix(editor): Disable password reset on desktop with no user management (#5853)
* fix(editor): disable password reset on desktop if there is no user management

* fix(editor): disable password reset on desktop if there is no user management
2023-03-31 11:42:11 +02:00
OlegIvaniv a13866e233
fix(editor): Add $if, $min, $max to root expression autocomplete (#5858) 2023-03-31 11:37:25 +02:00
Iván Ovejero 4b11642a8c
refactor(editor): Remove CTA for errored node (#5857)
🔥 Remove CTA for errored node
2023-03-31 11:27:27 +02:00
Iván Ovejero 1b8c35ab87
feat(editor): Allow tab to accept completion (#5855)
 Allow `tab` to accept completion
2023-03-31 11:23:16 +02:00
Michael Kret f7f9d915b1
feat(Filter Node): Show discarded items 2023-03-31 10:27:33 +03:00
Iván Ovejero 11692c55f3
fix(editor): Support backspacing with modifier key (#5845)
Support backspacing with modifier key
2023-03-31 09:19:49 +02:00
OlegIvaniv 1eba4788f2
fix(editor): Prevent NDV schema view pagination (#5844)
* fix(editor): Prevent NDV schema view pagination

* Linting fixes
2023-03-31 08:31:19 +02:00
Michael Kret b7a20dd3a2
fix(Date & Time Node): Add info box at top of date and time explaining expressions 2023-03-30 20:03:58 +03:00
Jan Oberhauser 6c35518ed9 Merge tag 'n8n@0.222.0' 2023-03-30 17:43:27 +02:00
Jon db2544146f
fix(Redis Node): Fix issue with hash set not working as expected (#5832) 2023-03-30 16:04:34 +01:00
कारतोफ्फेलस्क्रिप्ट™ 5bcab8fcbe
fix(core): Password reset should pass in the correct values to external hooks (#5842) 2023-03-30 16:44:39 +02:00
कारतोफ्फेलस्क्रिप्ट™ d0788ee8e1
fix(editor): Show correct status on canceled executions (#5813)
Co-authored-by: Milorad Filipovic <milorad@n8n.io>
2023-03-30 16:27:40 +02:00
कारतोफ्फेलस्क्रिप्ट™ 41cdee7bc7
refactor(core): Switch Tags queries from QueryBuilder to Repository API (no-changelog) (#5819)
Co-authored-by: Omar Ajoue <krynble@gmail.com>
2023-03-30 16:25:51 +02:00
Mutasem Aldmour f8f584c136
fix(editor): Fix mapping with special characters (#5837)
* fix: Fix mapping with special characters

* refactor: rename var

* test: update more unit tests

* test: update mapping test

* test: update mapping test
2023-03-30 15:50:47 +02:00
Iván Ovejero ddc8f30e6d
fix(editor): Disable Grammarly in expression editors (#5826)
* 🔥 Disable Grammarly in expression editor modal input

* Add also to inline
2023-03-30 15:48:43 +02:00
Michael Auerswald fa5bc814b0
fix(core): Deactivate active workflows during import (#5840)
* deactivate imported workflows

* improve test

* fix for combined import (and test)

* cleanup
2023-03-30 15:33:30 +02:00
कारतोफ्फेलस्क्रिप्ट™ e4796c169b
ci: Run db tests with a table-prefix as well (no-changelog) (#5818) 2023-03-30 15:09:13 +02:00
github-actions[bot] e92a993694
🚀 Release 0.222.0 (#5786) 2023-03-30 14:53:19 +02:00
OlegIvaniv 0b0024d722
fix(editor): Prevent error from showing-up when duplicating unsaved workflow (#5833)
* fix(editor): Prevent error from showing-up when duplicating unsaved workflow

* Add unsaved workflow duplicate test
2023-03-30 14:34:04 +02:00
कारतोफ्फेलस्क्रिप्ट™ 87e979c19a
feat: Upgrade TypeScript to v5 (no-changelog) (#5755) 2023-03-30 13:59:59 +02:00
Iván Ovejero b69129bd78
fix(editor): Fix connection lost hover text not showing (#5828)
🐛 Fix connection lost hover text not showing
2023-03-30 13:43:37 +02:00
Michael Kret b408550e9f
fix(Set Node): Convert string to number 2023-03-30 14:29:47 +03:00
OlegIvaniv aacbb54bef
fix(core): Do not user util.types.isProxy for tracking of augmented objects (#5836) 2023-03-30 13:29:36 +02:00
Jon d86e693019
fix(editor): Fix issue preventing execution preview loading when in an iframe (#5817) 2023-03-30 12:17:12 +01:00
Marcus 6f720919c9
feat(Schedule Trigger Node): Linking to crontab.guru examples (no-changelog) (#5834)
linking to crontab.guru examples instead of cronmaker.com

Co-authored-by: Jon <jonathan.bennetts@gmail.com>
2023-03-30 13:07:16 +02:00
Michael Auerswald 2216455760
feat(core): Prevent non owners password reset when saml is enabled (#5788)
* prevent non owners from pw reset when saml is enabled

* improve tests

* change error type
2023-03-30 12:44:53 +02:00
कारतोफ्फेलस्क्रिप्ट™ 9e9003bf13
ci: Drop support for Node.js 14 (#5835)
Node.js 14 goes EOL on 2023-04-30, and support for it should be dropped.
https://github.com/nodejs/Release#release-schedule
2023-03-30 12:23:39 +02:00
Val 744c3fd211
fix(core): Waiting workflows not stopping (#5811)
fix: Waiting workflows not stopping
2023-03-30 10:12:29 +01:00
Michael Kret 739b9b07f0
fix(core): Service account private key as a password field 2023-03-30 11:49:51 +03:00
कारतोफ्फेलस्क्रिप्ट™ 58fda255fe
refactor: Revert "refactor(core): Use typedi to manage EventBus singletons (#5795)" (no-changelog) (#5825)
Revert "refactor(core): Use typedi to manage EventBus singletons (no-changelog) (#5795)"

This reverts commit 522c790817.
2023-03-30 09:59:04 +02:00
कारतोफ्फेलस्क्रिप्ट™ 6c35ffa82c
fix(core): Handle Date and RegExp objects in AugmentObject (#5809) 2023-03-29 21:36:56 +02:00
कारतोफ्फेलस्क्रिप्ट™ 4f91525022
fix(core): Handle Date and RegExp correctly in jsonStringify (#5812) 2023-03-29 21:10:19 +02:00
कारतोफ्फेलस्क्रिप्ट™ 522c790817
refactor(core): Use typedi to manage EventBus singletons (no-changelog) (#5795) 2023-03-29 20:38:47 +02:00
कारतोफ्फेलस्क्रिप्ट™ be373bb859
Revert "feat(core): Read ephemeral license from environment and cleanup ee flags (#5797)" (#5816)
Revert "feat(core): Read ephemeral license from environment and clean up ee flags (#5797)"

This reverts commit a81ca7c19c.
2023-03-29 18:00:29 +02:00
Michael Auerswald a81ca7c19c
feat(core): Read ephemeral license from environment and clean up ee flags (#5797)
* remove enterprise feature schema for license.cert

* bump license sdk version

* Update packages/cli/package.json

Co-authored-by: Cornelius Suermann <cornelius@n8n.io>

---------

Co-authored-by: Cornelius Suermann <cornelius@n8n.io>
2023-03-28 17:21:40 +02:00
agobrech 5f6183a031
ci: Improve categorisation of errors in the Test-Workflow (no-changelog) (#5772)
* Add warning messages for bad gateway and insufficient balance

* Remove console.logs

---------

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <netroy@users.noreply.github.com>
2023-03-28 13:21:22 +02:00
Jon 1409f5d652
feat(ServiceNow Node): Add support for work notes when updating an incident (#5791) 2023-03-28 10:48:09 +01:00
Michael Kret 082c61701c
fix(Google Sheets Node): Unit tests (no-changelog) 2023-03-27 19:23:18 +03:00
Jon a1306c6903
fix(HTTP Request Node): Fix AWS credentials to stop removing url params for STS (#5790) 2023-03-27 16:56:02 +01:00
Michael Kret 0625e2e6bc
fix(Google Sheets Node): Fix insertOrUpdate cell update with object 2023-03-27 17:56:36 +03:00
कारतोफ्फेलस्क्रिप्ट™ 18efaf397a
fix(core): Do not mark duplicates as circular references in jsonStringify (#5789)
* fix(core): jsonStringify should not mark duplicates as circular references

* not mark duplicates as circular references in the code node as well
2023-03-27 16:22:59 +02:00
Michael Auerswald f15f4bdcf2
feat(core): Convert eventBus controller to decorator style and improve permissions (#5779) 2023-03-27 12:30:03 +02:00
Jan Oberhauser dd20127961 Merge tag 'n8n@0.221.2' 2023-03-24 18:22:47 +01:00
Michael Auerswald 47ee357059
feat(core): Improve ldap/saml toggle and tests (#5771)
* improve ldap/saml toggle and tests

* import cleanup

* reject regular login users when saml is enabled

* lint fix
2023-03-24 17:46:06 +01:00
कारतोफ्फेलस्क्रिप्ट™ 30aeeb70b4
fix(core): Ensure that all non-lazy-loaded community nodes get post-processed correctly (#5782)
If you install a community node with `polling: true`, activating a workflow with that node fails with an error: `WorkflowActivationError: There was a problem activating the workflow: "Could not get parameter "pollTimes"!"`.

You can test this by installing `n8n-nodes-rss-feed-trigger`, creating a workflow with the `RSS Trigger` node, and then trying to activate it. Activation will fail on `master`, but work as expected on this branch.
2023-03-24 17:29:56 +01:00
कारतोफ्फेलस्क्रिप्ट™ 161de110ce
fix(core): Improve community nodes loading (#5608) 2023-03-24 17:04:26 +01:00
Mutasem Aldmour 696e43a919
feat: Add test overrides (#5642)
* feat: Add test overrides

* feat: add more func to test with

* test: add tests for posthog store

* fix: only init once

* fix: only init once

* test: fix
2023-03-24 15:57:22 +01:00
OlegIvaniv 78c9707fa7
refactor(editor): Migrate mouseSelect & deviceSupportHelpers mixins to composables (no-changelog) (#5775)
* refactor(editor): Migrate mouseSelect & deviceSupportHelpers mixins to composables (no-changelog)

* Fix node drop position and correct event listeners
2023-03-24 14:52:06 +01:00
कारतोफ्फेलस्क्रिप्ट™ c9d9069c0e
refactor(core): Stronger typing for workflow settings (no-changelog) (#5754) 2023-03-24 13:11:48 +01:00
Michael Auerswald d33a1ac1e9
fix(core): Assign properties.success earlier to set executionStatus correctly (#5773)
assign properties.success earlier
2023-03-24 12:53:43 +01:00
github-actions[bot] 136f752dbc
🚀 Release 0.221.2 (#5774)
Co-authored-by: netroy <netroy@users.noreply.github.com>
2023-03-24 12:47:49 +01:00
Michael Auerswald 6c7772a0b3 fix(core): Assign properties.success earlier to set executionStatus correctly 2023-03-24 12:44:49 +01:00
कारतोफ्फेलस्क्रिप्ट™ e67ad29625
fix(core): Initialize queue in the webhook server as well (#5766)
fix(core): Initialize queue in the webhook server as well (no-changelog)
2023-03-24 10:47:21 +01:00
github-actions[bot] 1663319c1f
🚀 Release 0.221.1 (#5767)
Co-authored-by: netroy <netroy@users.noreply.github.com>
2023-03-24 07:30:14 +01:00
कारतोफ्फेलस्क्रिप्ट™ 163859b87a fix(core): Initialize queue in the webhook server as well 2023-03-23 20:30:56 +01:00
Csaba Tuncsik d78a41db54
feat: Execution custom data saving and filtering (#5496)
* wip: workflow execution filtering

* fix: import type failing to build

* fix: remove console.logs

* feat: execution metadata migrations

* fix(editor): Move global executions filter to its own component

* fix(editor): Using the same filter component in workflow level

* fix(editor): a small housekeeping

* checking workflowId in filter applied

* fix(editor): update filter after resolving merge conflicts

* fix(editor): unify empy filter status

* feat(editor): add datetime picker to filter

* feat(editor): add meta fields

* fix: fix button override in datepicker panel

* feat(editor): add filter metadata

* feat(core): add 'startedBefore' execution filter prop

* feat(core): add 'tags' execution query filter

* Revert "feat(core): add 'tags' execution query filter"

This reverts commit a7b968081c.

* feat(editor): add translations and tooltip and counting selected filter props

* fix(editor): fix label layouts

* fix(editor): update custom data docs link

* fix(editor): update custom data tooltip position

* fix(editor): update tooltip text

* refactor: Ignore metadata if not enabled by license

* fix(editor): Add paywall states to advanced execution filter

* refactor: Save custom data also for worker mode

* fix: Remove duplicate migration name from list

* fix(editor): Reducing filter complexity and add debounce to text inputs

* fix(editor): Remove unused import, add comment

* fix(editor): simplify event listener

* fix: Prevent error when there are running executions

* test(editor): Add advanced execution filter basic unit test

* test(editor): Add advanced execution filter state change unit test

* fix: Small lint issue

* feat: Add indices to speed up queries

* feat: add customData limits

* refactor: put metadata save in transaction

* chore: remove unneed comment

* test: add tests for execution metadata

* fix(editor): Fixes after merge conflict

* fix(editor): Remove unused import

* wordings and ui fixes

* fix(editor): type fixes

* feat: add code node autocompletions for customData

* fix: Prevent transaction issues and ambiguous ID in sql clauses

* fix(editor): Suppress requesting current executions if metadata is used in filter (#5739)

* fix(editor): Suppress requesting current executions if metadata is used in filter

* fix(editor): Fix arrows for select in popover

* refactor: Improve performance by correcting database indices

* fix: Lint issue

* test: Fix broken test

* fix: Broken test

* test: add call data check for saveExecutionMetadata test

---------

Co-authored-by: Valya Bullions <valya@n8n.io>
Co-authored-by: Alex Grozav <alex@grozav.com>
Co-authored-by: Omar Ajoue <krynble@gmail.com>
Co-authored-by: Romain Minaud <romain.minaud@gmail.com>
2023-03-23 18:07:46 +01:00
कारतोफ्फेलस्क्रिप्ट™ 4c583e2be4
ci: Fix saml.api.test.ts (no-changelog) (#5764) 2023-03-23 16:54:35 +01:00
Jan Oberhauser 15412b2b2b Merge tag 'n8n@0.221.0' 2023-03-23 16:08:56 +01:00
Cornelius Suermann 573bc8bcea
docs: Refer to docker.n8n.io/n8nio/n8n for pulling n8n docker images (no-changelog) (#5763) 2023-03-23 15:38:01 +01:00
github-actions[bot] 5dd92c6b94
🚀 Release 0.221.0 (#5726) 2023-03-23 15:37:49 +01:00
Michael Auerswald 4498c6013d
fix(core): Persist CurrentAuthenticationMethod setting change (#5762)
* limit user invites when saml is enabled

* persist CurrentAuthenticationMethod
2023-03-23 15:13:05 +01:00
Michael Auerswald 57748b71e5
feat(core): Limit user invites when SAML is enabled (#5761)
limit user invites when saml is enabled
2023-03-23 15:12:19 +01:00
कारतोफ्फेलस्क्रिप्ट™ b0cfd69f2b
fix(core): Setup nodeHelpers that aren't exposed in the code sandbox (no-changelog) (#5753) 2023-03-23 15:11:18 +01:00
agobrech 4ac944af30 fix(HTTP Request Node): Fix AWS credentials to automatically deconstruct the url (#5751)
Workaround to use decompose uri whe OptionsUri is being used
2023-03-23 12:57:37 +01:00
कारतोफ्फेलस्क्रिप्ट™ a70e639c75 fix(core): Require Auth on icons and nodes/credentials types static files (no-changelog) (#5745) 2023-03-23 12:57:22 +01:00
Jan Oberhauser cefec7739b fix(Split In Batches Node): Roll back changes in v1 and create v2 (#5747) 2023-03-23 12:56:55 +01:00
Milorad FIlipović d3a34ab71b
fix(editor): Use credentials when fetching node and credential types (#5760)
fix(editor): Use credentials when fetching node and credential types with axios
2023-03-23 10:31:08 +00:00
Mutasem Aldmour a732374f24
fix: Update Posthog no-capture (#5693)
* feat: add no-capture class for schema view

* fix: add ee nocapture

* fix: update no capture

* fix: update ndv capturing

* feat: remove no capture from empty resources list

* lint: fix

* test: update tests

* test: add json view tests

* fix: update more class to cover

* lint: fix
2023-03-23 11:20:11 +01:00
Michael Auerswald ac18c0b9eb
fix(core): Return SAML service provider urls with config (#5759)
return sp urls with config
2023-03-23 10:42:19 +01:00
agobrech d30b892395
fix(HTTP Request Node): Fix AWS credentials to automatically deconstruct the url (#5751)
Workaround to use decompose uri whe OptionsUri is being used
2023-03-22 22:04:25 +01:00
OlegIvaniv 02810a9ba3
feat(editor): Fix ResourceLocator dropdown style (#5714)
* fix(editor): Fix ResourceLocator dropdown style

* Fix other popper classes

* Fix app hanging if loading many remote parameter options

* Make ResourceLocatorDropdown flex

* Override scrollbar styles

* Hide resource locator on outside click not input blur
2023-03-22 15:36:10 +01:00
Michael Kret cc9fe7b91f
feat(Filter Node): New node 2023-03-22 16:16:27 +02:00
कारतोफ्फेलस्क्रिप्ट™ 5dda3f2c61
fix(core): Require Auth on icons and nodes/credentials types static files (no-changelog) (#5745) 2023-03-22 14:22:50 +01:00
कारतोफ्फेलस्क्रिप्ट™ 38e91ab730
refactor(core): Stop importing LoggerProxy and createDeferredPromise in nodes-base (no-changelog) (#5742)
* refactor(core): Stop importing LoggerProxy in nodes-base

* refactor(core): Stop importing createDeferredPromise in nodes-base
2023-03-22 14:04:15 +01:00
Manish Dhanwal 40aacf9279
feat(core): Make OAuth2 error handling consistent with success handling (#5555)
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-03-22 12:53:49 +01:00
Jan Oberhauser 135b0d3e27
fix(Split In Batches Node): Roll back changes in v1 and create v2 (#5747) 2023-03-22 12:05:07 +01:00
Jan Oberhauser b199947c97
ci: Upgrade sanitize-html from 2.9.0 to 2.10.0 (#5744)
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-03-21 16:38:48 +01:00
Michael Auerswald b6d8a0f985
fix(core): Remove circular refs from Code and push msg (#5741)
* remove circular refs from code items (and lint fixes)

* cleanup

---------

* add some tests

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-03-21 15:34:30 +01:00
agobrech 199a91b398
fix(HTTP Request Node): Add streaming to binary response (#5701)
Revert "fix(HTTP Request Node): Remove streaming response  (#5663)"

This reverts commit 8a21fefbc6.
2023-03-21 15:03:47 +01:00
कारतोफ्फेलस्क्रिप्ट™ 34d7fcc27e
ci: Fix linting issues on master (no-changelog) (#5740) 2023-03-21 12:11:59 +01:00
कारतोफ्फेलस्क्रिप्ट™ 469ce32957
fix(core): Upgrade luxon to address CVE-2023-22467 (#5731)
[GitHub Advisory](https://github.com/advisories/GHSA-3xq5-wjfh-ppjc)
2023-03-21 09:50:29 +01:00
कारतोफ्फेलस्क्रिप्ट™ 4a4e2be96c
fix(core): Upgrade simple-git to address CVE-2022-25912 (#5730)
[GitHub Advisory](https://github.com/advisories/GHSA-9p95-fxvg-qgq2)
2023-03-21 09:48:55 +01:00
कारतोफ्फेलस्क्रिप्ट™ fd81c74251
fix(core): Upgrade sqlite3 to address CVE-2022-43441 (#5732)
[GitHub Advisory](https://github.com/advisories/GHSA-jqv5-7xpx-qj74)
2023-03-21 09:48:22 +01:00
कारतोफ्फेलस्क्रिप्ट™ 564bc03d3f
fix(core): Upgrade convict to address CVE-2023-0163 (#5729)
fix(core): upgrade convict to address CVE-2023-0163

also, do not allow passing any cli arguments to config.
2023-03-21 09:47:50 +01:00
agobrech 33d9784319
fix(core): Improve axios error handling in nodes (#5699)
* fix(core): Improve axios error handling in nodes

* handle axios errors without a response (like when connection fails)

---------

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-03-20 17:34:14 +01:00
agobrech 46d013cbc5
test(Date & Time Node): Skip the test when local timezone is not in UTC (no-changelog) (#5735)
Check for moment default timezone in dateTime tests
2023-03-20 16:55:40 +01:00
OlegIvaniv cb2ba97f38
fix(editor): Fix the canvas node distance when automatically injecting manual trigger (#5716)
fix(editor): Fix the canvas node distance when automatically adding manual trigger
2023-03-20 11:11:32 +01:00
Csaba Tuncsik 6916628a9f
feat(editor): SSO login button (#5615)
* feat(editor): SSO login button

* feat(editor): SSO login button

* feat(editor): SSO login button
2023-03-17 21:07:08 +01:00
Michael Auerswald e0ea97af8d
fix(core): Fix calling error workflows in main mode recovery (#5698)
* fix calling error workflows in main mode recovery

* cleanup

* remove WorkflowExecuteAdditionalData export from index

* revert refactor to fix test

* Update index.ts

---------

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <netroy@users.noreply.github.com>
2023-03-17 18:02:49 +01:00
Milorad FIlipović 19dded18c9
feat(editor): Move canvas by holding Space or Middle mouse button (#5719)
*  Implemented canvas move on space+drag
*  Added middle mouse key canvas move
*  Handling cursor changes when moving canvas with middle mouse button
* 💄 Consolidate naming
2023-03-17 17:38:54 +01:00
कारतोफ्फेलस्क्रिप्ट™ 6242cac53b
ci: Refactor cli tests to speed up CI (no-changelog) (#5718)
* ci: Refactor cli tests to speed up CI (no-changelog)

* upgrade jest to address memory leaks
2023-03-17 17:24:05 +01:00
Michael Auerswald be172cb720
fix(core): Return saml attributes after connection test (#5717)
return saml attributes for test
2023-03-17 15:56:51 +01:00
Milorad FIlipović 341bfb810f
fix(editor): Remove cloud check when pre-selecting auth options (no-changelog) (#5711) 2023-03-17 15:14:55 +01:00
Milorad FIlipović fb8755ea3c
fix(editor): Disable tooltip for display modes that don't support mapping (#5715)
fix(editor): Disable mapping tooltip for display modes that don't support mapping
2023-03-17 13:24:08 +01:00
Milorad FIlipović cd7a55ba5a
fix(editor): Fix redo in code and expression editor (#5708)
* fix(editor): Fix redo in code and expression editor
*  Updating keymap to use platform-specific command key
2023-03-17 13:23:49 +01:00
Val 233f1fa7ec
feat(QuickChart Node): Add QuickChart node (#3572)
*  Add basic QuickChart node

* 🏷️ Fix up types

* ❇️ Add Boxplot and Violin

* ❇️ Add point styles

* ❇️ Add horizontal charts

*  Make possible to provide array of labels via expressions

*  Improvements

*  Improvements

* 🎨 fix lint errors

* ️disable chart types we don't want to support in P0

* ️support setting labels manually or using an array

* ️move Horizontal parameter into options

* ️ update "Put Output In Field" param description and hint

* ️ removed font color

* ️fix Device Pixel Ratio

* ️fix Polar Chart not working

* ️Show Fill param only for charts supporting it

* ️Show pointStyle param only for charts supporting it

* ️remove second "Chart Type" option

*  updated error message, added json data, updated description

* Add codex json file

*  add unit test

*  improve unit test

*  removed any, added aliases

---------

Co-authored-by: ricardo <ricardoespinoza105@gmail.com>
Co-authored-by: Marcus <marcus@n8n.io>
Co-authored-by: Michael Kret <michael.k@radency.com>
2023-03-17 12:50:26 +01:00
कारतोफ्फेलस्क्रिप्ट™ 6a8c9b7ccc
refactor: Improve typings for webhook methods (no-changelog) (#5713) 2023-03-17 12:25:31 +01:00
Michael Auerswald a28396ee91
fix(core): Fix telemetry execution status for manual workflows executions (#5712)
fix telemetry execution status
2023-03-17 11:02:48 +01:00
Milorad FIlipović f59b591c93
feat(editor): Recommend and pre-select auth type with overrides (#5684)
* feat(editor): Recommend auth type with overrides and pre-select them when creating new credentials
*  Only auto-selecting credentials on cloud
2023-03-17 09:01:39 +01:00
Csaba Tuncsik 7a352efff9
fix(editor): Fix execution list item selection (#5606)
* fix(editor): Fix execution list item selection

* fix(editor): Delete only selected executions

* fix(editor): Fix clear selection

* fix(editor): Fix clear selection

* fix(editor): Fix clear selection

* feat(editor): Add select all existing executions checkbox

* fix(editor): Do not mark later loaded executions selected

* test(editor): Add execution list unit test

* fix(editor): Fix selection

* test(editor): update execution selection test

* fix(editor): Handle UI state when there is no execution

* fix(editor): Remove unnecessary logic

* test(editor): Add more execution list unit tests and fake data generation

* test(editor): Add more execution list unit tests

* test(editor): Simplifying test setup

* chore: update pnpm lock after resolving merge conflocts

* chore: fix package version

* fix: Improved executions deletion to prevent crashing and fixed removal of failed executions

* fix: Add comment to clarify why change was needed

* fix: fix executions list bug when selecting all and changing filter

* fix: fix execution lists running execution showing up on different workflow id

* fix(editor): Deleting an execution while all are selected

* fix(editor): Deleting an execution while all are selected

---------

Co-authored-by: Omar Ajoue <krynble@gmail.com>
Co-authored-by: Alex Grozav <alex@grozav.com>
2023-03-17 06:18:23 +01:00
Ricardo Espinoza 3718612bd7
test(core): Use instance owner instead of owner shell for SAML tests (no-changelog) (#5706)
Use instance owner instead of owner shell
2023-03-16 15:34:28 +01:00
कारतोफ्फेलस्क्रिप्ट™ 9bd7529193
refactor(core): Use an IoC container to manage singleton classes [Part-2] (no-changelog) (#5690)
* use typedi for UserManagementMailer

* use typedi for SamlService

* fix typos

* use typedi for Queue

* use typedi for License

* convert some more code to use typedi
2023-03-16 15:34:13 +01:00
Milorad FIlipović c07f838ce6
fix(editor): Fix for large notifications being cut off (#5705)
fix(editor): Fix for large notification being cut off
2023-03-16 15:29:57 +01:00
Jan Oberhauser 0876c38aae
feat(core): Augment data instead of copying it (#5487) 2023-03-16 15:14:34 +01:00
github-actions[bot] ca91d2b712
🚀 Release 0.220.0 (#5704) 2023-03-16 14:49:21 +01:00
OlegIvaniv 7025efe865
fix(editor): Properly handle mapping of dragged expression if it contains hyphen (#5703) 2023-03-16 14:10:30 +01:00
Giulio Andreini 02e35819ab
feat(IF Node): Node description update no-changelog (#5702) 2023-03-16 13:23:55 +01:00
Milorad FIlipović 11bf260bf1
fix(editor): Fix autocomplete for complex expresions (#5695)
*  Fixing autocomplete for expressions as function arguments

*  Added more autocomplete tests

*  Improving autocomplete for complex expressions

*  Handling complex operation expressions in autocomplete
2023-03-16 12:13:02 +01:00
OlegIvaniv 541850f95f
feat(editor): Add support for schema view in the NDV output (#5688)
* feat(editor): Add support for schema view in the NDV output

* Make intercepts waiting optional in waitForLoad method

* Update RunDataSchema snapshots

* Do not reset output panel view on execution, properly key run RunDataSchemaItem to make sure they are unique across panels

* Update snapshot tests

* Make adding of schema view button option more readable
2023-03-16 10:19:12 +01:00
romainminaud 58232bec61
fix(editor): Fix owner set-up checkbox wording (#5697)
update checkbox wording
2023-03-16 09:58:40 +01:00
Alex Grozav 29f2629716
feat: Add basic Datatable and Pagination components (#5652)
* feat: add Datatable component

* feat: migrate to n8n-pagination and add datatable tests

* chore: fix linting issue
2023-03-15 18:52:02 +02:00
कारतोफ्फेलस्क्रिप्ट™ b4e60c3b47
refactor: Rewrite workflow public-api tests to avoid timeouts (no-changelog) (#5696) 2023-03-15 14:24:09 +01:00
कारतोफ्फेलस्क्रिप्ट™ 6c74d41f23
fix: Fix nodes-base hot-reloading (no-changelog) (#5694) 2023-03-15 10:59:25 +01:00
Jon ba73fff27d
feat(OpenAI Node): Add support for gpt4 on chat completion (#5692) 2023-03-15 09:41:02 +00:00
Jon d1e3c192ba
fix(Metabase Node): Fix issue with question results not correctly being returned (#5665) 2023-03-14 17:47:37 +00:00
Jan Oberhauser 2f7639e9e4
feat(Split In Batches Node): Make it easy to combine processed data (#5655)
feat(SplitInBatches Node): Make it easy to combine processed data
2023-03-14 18:42:41 +01:00
OlegIvaniv de1db927cb
feat(editor): Do not show actions panel for single-action nodes (#5683) 2023-03-14 16:41:49 +01:00
Val 39c871d514
test: Add expression transform tests (#5497) (no-changelog)
test: add expression transform tests
2023-03-14 15:22:52 +00:00
Mutasem Aldmour 332d50c5f1
feat(Item Lists Node): Update actions (#5648)
feat(Itemlists): Update actions
2023-03-14 14:28:49 +01:00
कारतोफ्फेलस्क्रिप्ट™ eb3ba83e63
ci: Setup code-coverage reporting for frontend packages (no-changelog) (#5679) 2023-03-14 13:13:21 +01:00
Michael Auerswald ef07528cc2
feat(core): Improve SAML connection test (#5680)
* improve saml test

* cleanup

* remove unused SamlConfiguration types
2023-03-13 19:47:57 +01:00
Alex Grozav d253aa3e95
feat: Add Mirage.js server to enable editor-ui unit tests (#5671)
feat: add Mirage.js server to enable editor-ui unit tests
2023-03-13 11:05:08 +02:00
Michael Auerswald c6ba0bd8de
feat(core): Convert saml controller to decorator style (#5653) (no-changelog) 2023-03-10 19:19:52 +01:00
कारतोफ्फेलस्क्रिप्ट™ 90afa5e55f
fix(core): Initialize License and LDAP in the correct order (#5673) 2023-03-10 19:05:51 +01:00
कारतोफ्फेलस्क्रिप्ट™ 3831201aaf
ci: Setup code-coverage reporting (no-changelog) (#5669) 2023-03-10 16:53:05 +01:00
Jan Oberhauser 5f238ea641
fix(editor): Display correct error message for env access (#5634) 2023-03-10 14:16:18 +01:00
Jan Oberhauser dc0e052c83 Merge tag 'n8n@0.219.1' 2023-03-10 13:54:26 +01:00
github-actions[bot] a881512b49
🚀 Release 0.219.1 (#5668) 2023-03-10 13:30:40 +01:00
agobrech 974d57dfed fix(HTTP Request Node): Remove streaming response (#5663)
Remove useStream option from requestOptions
2023-03-10 12:10:18 +01:00
agobrech 8a21fefbc6
fix(HTTP Request Node): Remove streaming response (#5663)
Remove useStream option from requestOptions
2023-03-10 11:54:26 +01:00
Jan Oberhauser dd93c0890b Merge tag 'n8n@0.219.0' 2023-03-09 18:38:19 +01:00
कारतोफ्फेलस्क्रिप्ट™ 7a4e9ef5fa
refactor: Remove n8n-core dependency in nodes-base (no-changelog) (#5649) 2023-03-09 18:13:15 +01:00
github-actions[bot] 40a6ab814d
🚀 Release 0.219.0 (#5659) 2023-03-09 18:04:39 +01:00
agobrech 5790e5e719
fix(core): Fix trying to pipe a non stream on errors (no-changelog) (#5660) 2023-03-09 17:48:33 +01:00
कारतोफ्फेलस्क्रिप्ट™ 1979eb8a9c
fix(core): Fix issues with LDAP reset and LDAP init (no-changelog) (#5657)
* fix(core): Ldap reset should recreate the default config

* fix(core): init ldap before registering the routes for it
2023-03-09 16:24:44 +01:00
agobrech ce0d9d2bed
feat(HTTP Request Node): Move from Binary Buffer to Binary streaming (#5610)
*  Change from binary buffer to binary streaming

* Remove console.logs

* Import Readable from the correct lib

* stream response

* parametersToKeyValue doesn't need to be async anymore

* Fix bodyParameter reduce method

* parametersToKeyValue doesn't need to be async anymore

* handle streaming responses

* send `Content-Length` and `Content-Type` on binary requests

* Add new helper function for binary data

* Add binary function to helpers interface

* Fix bug in error handler

* Fix issue with wrongfully assigned headers to body

* Fix test workflow

* Remove console.logs

* Remove unnecsessary type

* Remove concat dependency already imported in workflow package

* Update pnpm-lock file

* Small fixes, asyncronous error message

* reset the lockfile

* Remove buffer check and simplify error handling

---------

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-03-09 15:38:54 +01:00
OlegIvaniv a9c63f980f
feat(editor): Only redirect new users to blank canvas (no-changelog) (#5654)
* feat(editor): Bring new users to empty canvas

* fix(editor): Revert empty /workflows redirect

* Provide `COMMIT_INFO_BRANCH` and uncomment demo experiment

* Only change redirect after set-up/sign-up to new canvas

* Fix failing specs

* Prevent redirect for demo experiment

* Fix workflows cards spacing
2023-03-09 15:26:27 +01:00
OlegIvaniv ac2f89a18a
feat(editor): Do not automatically add manual trigger on node plus (#5644)
* feat(editor): Do not add manual trigger node if node creator trigger via canvas actions

* Add e2e tests

* Install cypress-plugin-tab, do not use cy.realPress as it hangs the tests

* Exclude tab tests
2023-03-09 15:22:12 +01:00
कारतोफ्फेलस्क्रिप्ट™ d872866add
feat(core): Allow using middlewares with decorators on a per-route basis (no-changelog) (#5656) 2023-03-09 15:08:48 +01:00
कारतोफ्फेलस्क्रिप्ट™ 356e916194
refactor(core): Convert more routes to use the decorator pattern (no-changelog) (#5611)
* move nodeTypes api to a controller class
* move tags api to a controller class
* move LDAP routes to a controller class
* move nodes routes to a controller class
2023-03-09 14:42:13 +01:00
Alex Grozav 493f7a1c92
fix: Fetch credentials on workflows view to include in duplicated workflows (#5532)
fix: fetch credentials on workflows view to include in duplicated workflows
2023-03-09 14:23:38 +02:00
Jon e56fbfef3e
feat(Mindee Node): Add support for v4 API (#5559) 2023-03-09 10:06:03 +00:00
Jon 971d5ae8f5
feat(Microsoft SQL Node): Add support for self signed certificates (#5160) 2023-03-09 10:05:03 +00:00
romainminaud 5b9c521d04
fix(editor): Only fetch new versions at app launch (#5647)
only call nextVersions once
2023-03-09 11:01:30 +01:00
Ricardo Espinoza 6500e985ee
fix(core): Use new version of riot-tmpl in workflow package (no-changelog) (#5619)
* Use new version of riot-tmpl

* update lock file
2023-03-09 09:13:48 +01:00
Michael Auerswald 6f27b445ca
feat(core): Refactor and add SAML preferences for service provider instance (#5637)
* create SP through parameters instead of metadata

* refactor SAML prefs and add SP configurations
2023-03-09 09:08:23 +01:00
Jon 89d25995c3
docs(Github Trigger Node): Add notice and more meaningful error around permissions (#5551) 2023-03-08 16:04:45 +00:00
Syed Ali Shahbaz 2889e53b37
feat(Cal Trigger Node): Update to support v2 webhooks (#5331) 2023-03-08 15:58:15 +00:00
OlegIvaniv 354edf6886
feat(editor): Redirect users to canvas if they don't have any workflows (#5629)
* feat(editor): Bring new users to empty canvas

* Fix failing e2e tests and revert CLI implementation

* Revert editor-ui Interface changes

* Try to mock /settings and /active

* Revert canvas test changes, reload after executions in 20-workflow-executions

* Make sure we include manual executiosn before running them in 20-workflow-executions

* Make sure to re-init node view when replacing empty workflows route, show phantom loader
2023-03-08 15:11:13 +01:00
कारतोफ्फेलस्क्रिप्ट™ 0b6fa6b20e
ci: Setup TS project references for nodes-base, and stop packaging tests in the npm package (no-changelog) (#5635) 2023-03-08 14:33:13 +01:00
agobrech 0d49ad8b93
fix(core): Add a helper function to convert binary streams to buffers (no-changelog) (#5641) 2023-03-08 14:32:27 +01:00
romainminaud c81656d149
fix: Fix color discrepancies for executions list items (#5640)
fix color discrepancies for exec items
2023-03-08 12:28:23 +01:00
Michael Auerswald 419969c0d7
fix(core): Rename advancedFilters to advancedExecutionFilters (#5643)
rename advancedFilters to advancedExecutionFilters
2023-03-07 18:35:52 +01:00
Mutasem Aldmour e52aa46842
chore: Clean up distribution test (#5639) 2023-03-07 15:41:02 +01:00
Michael Auerswald 0b5ef09e7c
feat(core): Add advancedFilters feature flag (#5638)
adds advancedFilters feature flag
2023-03-07 14:18:10 +01:00
कारतोफ्फेलस्क्रिप्ट™ 5eb0d52459
refactor: Unify binary-data assertion across all nodes (no-changelog) (#5624) 2023-03-06 17:33:32 +01:00
Jon 01a2160b3b
feat(Mattermost Node): Add self signed certificate support (#5630) 2023-03-06 16:27:49 +00:00
कारतोफ्फेलस्क्रिप्ट™ 45ccdd3bb5
fix(core): Allow serving icons for custom nodes with npm scoped names (#5626) 2023-03-06 13:36:47 +01:00
Michael Auerswald ca66ec8f4d
feat(core): Add SAML XML validation (#5600)
* consolidate SSO settings

* update saml settings

* fix type error

* limit user changes when saml is enabled

* add test

* add toggle endpoint and fetch metadata

* rename enabled param

* add handling of POST saml login request

* add config test endpoint

* adds saml XML validation

* add comment

* protect test endpoint

* improve ignoreSSL and some cleanup

* fix wrong schema used

* remove console.log
2023-03-06 09:44:25 +01:00
Jan Oberhauser 1c65bff31d
fix(OpenAI Node): Simplify code (#5618)
fix(OpenAI Node): Simplifiy code
2023-03-05 17:43:17 +01:00
कारतोफ्फेलस्क्रिप्ट™ 3c57062571
refactor: Fix some typos (no-changelog) (#5616) 2023-03-03 18:49:19 +01:00
कारतोफ्फेलस्क्रिप्ट™ 4e244937c9
refactor: catch doesn't need to have a param (no-changelog) (#5614) 2023-03-03 18:18:49 +01:00
agobrech 9420b0fdf8
feat(Slack Node): Move from Binary Buffer to Binary streaming (#5612)
 Add Binary streaming instead of binary buffering
2023-03-03 18:11:27 +01:00
Jon e949db3525
fix(OpenAI Node): Fix issue with expressions not working with chat complete (#5609) 2023-03-03 16:08:12 +00:00
Csaba Tuncsik 2eba050461
fix(editor): Fix ElButton overrides (#5605)
* fix(editor): Fix ElButton overrides

* fix(editor): Fix ElButton overrides
2023-03-03 11:48:45 +01:00
Michael Auerswald 523fa71705
feat(core): Add SAML post and test endpoints (#5595)
* consolidate SSO settings

* update saml settings

* fix type error

* limit user changes when saml is enabled

* add test

* add toggle endpoint and fetch metadata

* rename enabled param

* add handling of POST saml login request

* add config test endpoint
2023-03-03 10:19:43 +01:00
Michael Auerswald b5179597f3
feat(core): Limit user changes when saml is enabled (#5577)
* consolidate SSO settings

* update saml settings

* fix type error

* limit user changes when saml is enabled

* add test
2023-03-03 10:05:30 +01:00
github-actions[bot] a91b631411
🚀 Release 0.218.0 (#5601)
* 🚀 Release 0.218.0

* Update Changelog

---------

Co-authored-by: janober <janober@users.noreply.github.com>
Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
2023-03-02 17:32:52 +01:00
OlegIvaniv 0004dc7ee8
ci(editor): Run e2e tests in parallel and improve build caching (#5445)
* WIP: Cypress parallel CI run test

* Trigger action on branch push

* Change build artifacts path

* Make sure to checkout the repo for testing job

* Use Cypress action for installing

* Lock cypress action userd version

* Skip node install step since we're using cypress node16 container

* Let Cypress handle pnpm install

* Use setup-node action for caching pnpm

* Set CYPRESS_CACHE_FOLDER

* Set CYPRESS_CACHE_FOLDER

* Manually cache pnpm store

* Dont fix pnpm version

* Use caching action also in testing job

* Zip packages dist before uploading the artifacts and change caching key

* Use absolute build paths for zipping job

* Use zip command in action

* Use tar for zipping packages

* Debuggin directory ls

* Debugging caching of modules

* Attempt to fix permissions issue

* Porivde Cypress executable via `CYPRESS_RUN_BINARY`

* Cache /github/home

* Adjust caching keys

* Debug: search for cypress exec

* Debugging: List dirs

* Use pnpm install action to install node_modules

* Do not log /home/runner

* Use node_modules/.bin Cypress binary

* Use absolute path to nodue modules

* Run Cypress via custom command

* Try with patched cypress action

* Revert logging

* Manually specify cypress config file

* Use absolute paths

* Fix cypress config name

* Debug print cypress config

* Remove debugging, increase to 4 containers

* Increase amount of containers

* Add env-version matrix

* Replace node14 with node18 in testing matrix

* Remove debugging and add node 14

* Use just node14

* Use cypress:base and remove browser req

* Give more general timeouts

* Try with node16

* Change cache directive position

* Replace zip artifact upload with cache

* Cache full packages not just dist

* Test with variable inputs

* Add commit info message

* Remove wrongly commited code

* Allow WF API dispatch

* Try Chrome browser again for comparison

* Include Monaco in the build

* Make e2e workflow re-usable

* Comment out invalid reusable workflow args

* Use electron and add node 14 run

* Fix env arg

* Provide custom ci-build-id

* Refactor remaining e2e workflow to use reusable action

* Remove single matrix directive

* Refactor ci-pull-req

* Make lint job dependant on test jobs

* Disable debugging job

* Make containers dynamic

* Cleanup & install git for linting action

* Use regular buntu image for PR linting

* Debugging failing tests

* Remove fixed spec name

* Debug e2e env var

* Do not use realkeypress which crashes electron runner

* Debugging

* chore: remove console

* chore: remove console

* test: remove node 14 tests

* test: replace test branch with master

* test: use tests in current branch

* test: use relative path

* chore: clean up

* test: only trigger on approval

* ci: update test PR

* ci: use curr branch

* ci: only run 14 on schedule, not for slack command

* ci: only run test on approval

* ci: clean up branch, rename step

* ci: rename steps

* ci: clean up cancel

* ci: clean up env var

* ci: set var

* ci: use chromef

* ci: use electron

* chore: add console log

* chore: add console log

* ci: update to string

* ci: set all env options

* test: build

* ci: fix step issue

* Fix failing tests & upgrade to Cypress 12

* Allow WF dispatch of e2e reusable

* Fix wrong naming in e2e-tests workflow

* Redeploy

* Fix tests

* Fix NDV tests and remove skipping of webhooks execution tests

* Fix clipboard read command

* Fix execution failing tests

* Reset before each 15 and 3

* Fix flaky tests

* Cleanup and log envs

* Test fixes

* Default owner spec fixes

* Get rid of CYPRESS_RUN_ENV

* Increase amount of containers, cleanup and add mock for credentials test call

* Cleanup & fix PR tests unit tests

* Wait for WF to loade in sharing spec

* Do linting and unit tests first

* Use frozen lockfile

* Revert back ci pull request jobs order

* Refine credential input selector and move cy.waitForLoad to correct position in 15-scheduler spec

* test: build

* Wait for WF execution instead of arbitraty timeout in WF execution spec, change order of jobs for ci pull request

* Fix flaky 3-default owner spec and wait for execution list to load in 20-workflow-executions

* Use setup node action

* Remove caching for lint/unit tests

* Experiment with parallel test & lint on ci

* Provide cache key dynamically

* Run e2e in parallel on pr

* Only run node14 e2e on daily schedule

* Make sure to generate generate new ci-build-id on re-runs

* Remove debugging prints

* Address PR comments

* Rename custom onBeforeUnload handler

* Make sure 19-execution spec waits for wf to load properly before import fixtures

---------

Co-authored-by: Mutasem <mutdmour@gmail.com>
2023-03-02 16:50:21 +01:00
Mutasem Aldmour 5040fea93e
fix: Fix issues with nodes missing in nodes panel (#5599)
* fix: Fix issues with nodes missing in nodes panel

* fix: fix logic for deteriming app category

* chore: add comment

* chore: remove sort
2023-03-02 18:27:56 +03:00
Jon 4f5013ff53
fix: Show RabbitMQ node in nodes panel (#5598) 2023-03-02 14:35:13 +00:00
Jon 06c5ecbdf3
feat(OpenAI Node): Add support for ChatGPT (#5596) 2023-03-02 14:17:29 +00:00
Mutasem Aldmour 1f7b478920
fix: Fix mapping paths when appending to empty expression (#5591)
* fix: Fix mapping when appending to empty expression

* fix: refactor logic out

* test: add tests

* test: add tests

* fix: fix bug where value does not get updated when mapping

* test: add test for bug

* test: add test for bug
2023-03-02 15:02:29 +03:00
Michael Auerswald 31cc8de829
feat(core): Add SAML settings and consolidate LDAP under SSO (#5574)
* consolidate SSO settings

* update saml settings

* fix type error
2023-03-02 09:00:51 +01:00
agobrech f61d779667
feat(Jira Software Node): Support binary streaming for very large binary files (#5589)
Move from buffer to binary streaming
2023-03-01 18:14:07 +01:00
Jon f3c943ef81
feat(Telegram Node): Add Parse Mode to Send Document operation (#5554) 2023-03-01 14:47:09 +00:00
Mutasem Aldmour 91bd0146f3
feat: Add distribution test tracking (#5588) 2023-03-01 14:13:15 +03:00
Mutasem Aldmour eac4275a7e
fix: Stop showing mapping hint after mapping (#5586)
* fix: Stop showing mapping hint after mapping

* fix: set value correctly

* chore: clean up mapping hint code
2023-03-01 14:02:34 +03:00
agobrech aa2beaa800
fix(Item Lists Node): Tweak item list summarize field naming (#5572)
* Remove brackets and double quotes from fieldname

* Fix bug with duplicate field

* Parse field names from splitbyfield

* Fix error with field name remove console.logs

* Add versioning to itemlist

* Fix naming

* Remove comment
2023-02-28 18:00:39 +01:00
Mutasem Aldmour d6d1c07a53
fix: Show Execute Workflow node in nodes panel (#5583)
* fix: Show Execute Workflow node in nodes panel

* chore: remove wrong comment
2023-02-28 17:51:33 +03:00
कारतोफ्फेलस्क्रिप्ट™ e3ef9f7c7b
ci: Update ReadBinaryFile Documentation URL (no-changelog) (#5581)
this is a follow up on https://github.com/n8n-io/n8n/pull/5490
2023-02-28 12:00:52 +01:00
Mutasem Aldmour 20c4919513
feat: Add events to enable onboarding checklist (#5536)
* feat: Add new event hooks

* fix: update event

* feat: Add more functionality for webhooks

*  Not sending onboarding checklist event from templates page

* 🔥 Removing quotes added by mistake

*  Added rest of events needed for onboarding checklist

* 💄 Hiding appcues checklist inside iframes

* 💄 Updating appcues selector

* fix: remove unnessary fix

* fix: fix schedule node

* refactor: bake events into segment store

* refactor: rename store

* refactor: use node keys

* refactor: remove unnessary

* chore: clean up store

* refactor: add key for event

* fix: allow tracking on template pages

* chore: remove comment

* fix: buidl

* refactor: block event if in iframe

* fix: fix tracking nodes

* refactor: track experiments once

* fix: ensure tracking works

* chore: remove comment

* fix: lint

* fix: lint

---------

Co-authored-by: Milorad Filipovic <milorad@n8n.io>
2023-02-28 13:44:37 +03:00
Milorad FIlipović ae634407a4
feat(editor): Add missing documentation to autocomplete items for inline code editor (#5560)
*  Added documentation for extension functions with arguments

*  Adding custom autocomplete item types. This enables us to show different items with same labels.

* 📚 Adding missing info for extensions autocomplete items

*  Added Luxon autocomplete docs

* 💡 Completing Luxon static methods autocomplete documentation

*  Refactoring Luxon autocomplete logic

*  Handling the case when autocomplete item doesn't have defined inline documentation

*  Added correct doc info to Luxon instance properties

*  Added missing documentation and notice footer for autocomplete popup.

* 👕 Fixing lint error

* ✔️ Removing `Object.hasOwn` function, since it's not supported in node v14
2023-02-28 07:34:03 +03:00
Michael Kret bb4db58819
fix(core): Remove linting exceptions in nodes-base, @typescript-eslint/no-unsafe-argument (no-changelog) 2023-02-28 05:39:43 +02:00
Jan Oberhauser 3172ea376e Merge tag 'n8n@0.217.2' 2023-02-27 13:07:35 +01:00
github-actions[bot] 948b37592f
🚀 Release 0.217.2 (#5573) 2023-02-27 12:42:56 +01:00
कारतोफ्फेलस्क्रिप्ट™ a19ec6ac94
fix(core): Revert isPending check on the user entity (#5571) 2023-02-27 12:35:59 +01:00
कारतोफ्फेलस्क्रिप्ट™ 43eec66828 fix(core): Revert isPending check on the user entity (#5571) 2023-02-27 12:35:29 +01:00
Csaba Tuncsik 51eedaccd4 fix(core): Fix Filtering of Workflow by Tags (#5570) 2023-02-27 12:35:01 +01:00
कारतोफ्फेलस्क्रिप्ट™ 2137ae23d7 fix(core): Fix execution pruning queries (#5562)
* fix(core): Execution pruning should delete query should use the `OR` operator

* fix(core): Prune executions in a chunk to avoid sqlite error "Expression tree is too large"

* reduce the memory usage during execution pruning
2023-02-27 12:35:01 +01:00
Csaba Tuncsik ea2035b510
fix(core): Fix Filtering of Workflow by Tags (#5570) 2023-02-27 12:25:45 +01:00
Giulio Andreini 1942fd8232
feat(editor): Show parameter hint on multilines (#5014)
Single/multi line for hints.
2023-02-27 09:25:57 +03:00
Michael Auerswald 40a934bbb4
feat(core): Add SAML login setup (#5515)
* initial commit with sample data

* basic saml setup

* cleanup console logs

* limit saml endpoints through middleware

* basic login and token issue

* saml service and cleanup

* refactor and create user

* get/set saml prefs

* fix authentication issue

* redirect to user details

* merge fix

* add generated password to saml user

* update user from attributes where possible

* refactor and fix creating new user

* rename saml prefs key

* minor cleanup

* Update packages/cli/src/config/schema.ts

Co-authored-by: Omar Ajoue <krynble@gmail.com>

* Update packages/cli/src/config/schema.ts

Co-authored-by: Omar Ajoue <krynble@gmail.com>

* Update packages/cli/src/controllers/auth.controller.ts

Co-authored-by: Omar Ajoue <krynble@gmail.com>

* code review changes

* fix default saml enabled

* remove console.log

* fix isSamlLicensed

---------

Co-authored-by: Omar Ajoue <krynble@gmail.com>
2023-02-24 20:37:19 +01:00
कारतोफ्फेलस्क्रिप्ट™ 88de6613bd
fix(core): Fix execution pruning queries (#5562)
* fix(core): Execution pruning should delete query should use the `OR` operator

* fix(core): Prune executions in a chunk to avoid sqlite error "Expression tree is too large"

* reduce the memory usage during execution pruning
2023-02-24 18:02:34 +01:00
Jan Oberhauser 1c86a59e62 Merge tag 'n8n@0.217.1' 2023-02-24 17:35:22 +01:00
github-actions[bot] 9735188195
🚀 Release 0.217.1 (#5565) 2023-02-24 16:21:55 +01:00
Omar Ajoue b30db10d89 fix: Prevent executions from displaying as running forever (#5563)
* fix: Prevent executions from displaying as running forever

* fix: Correct migration query
2023-02-24 16:16:24 +01:00
Omar Ajoue 46d9ac6c6f
fix: Prevent executions from displaying as running forever (#5563)
* fix: Prevent executions from displaying as running forever

* fix: Correct migration query
2023-02-24 14:53:49 +01:00
Jan Oberhauser 534629c146 Merge tag 'n8n@0.217.0' 2023-02-24 12:26:41 +01:00
github-actions[bot] a72ef21817
🚀 Release 0.217.0 (#5553) 2023-02-23 18:21:17 +01:00
Alex Grozav f0695827f5
feat: Migrate packages from lodash to lodash-es (no-changelog) (#5538) 2023-02-23 16:16:05 +01:00
Michael Auerswald e2d7c1804f
fix(editor): Apply correct IRunExecutionData to finished workflow (#5552)
fix wrong IRunExecutionData being applied
2023-02-23 13:00:28 +01:00
romainminaud a53f3998a2
feat: Check new n8n version at start (no-changelog) (#5542)
check new version at start

Co-authored-by: Alex Grozav <alex@grozav.com>
2023-02-23 11:43:03 +01:00
Csaba Tuncsik 7c517cb530
fix(editor): Remove 'crashed' status from filter (#5524)
* fix(editor): remove 'crashed' status from filter

* fix(editor): remove 'crashed' and 'new' status from filter

* fix(editor): add 'status' to response

* fix(editor): create request filter for workflow level execution filtering

* fix(editor): update filters

* fix(editor): simplify condition

* fix(editor): update filters

* fix(editor): optimizing data loading flow

* fix(editor): always load past executions
2023-02-23 11:13:21 +01:00
OlegIvaniv 4998ab2350
fix(editor): Fix an issue with zoom and canvas nodes connections (#5548) 2023-02-23 09:48:42 +01:00
Jonathan Bennetts f965469e13
fix(Google Calendar Node): Fix incorrect labels for start and end times when getting all events (#5529) 2023-02-23 08:34:41 +00:00
Jonathan Bennetts 3af3db160b
fix: fix typo in error messages when a property does not exist (#4310) 2023-02-23 08:33:43 +00:00
agobrech 4a209e1dd9
feat: Hide sensible value in Auth Header Credentials and Auth Query Credentials (#5534)
* ️ Enable passord type on value

* ️ Enable password type on query auth cred
2023-02-23 09:31:46 +01:00
कारतोफ्फेलस्क्रिप्ट™ 1bff044252
refactor(WhatsApp Node): Avoid using BinaryDataManager directly from n8n-core (#5544) 2023-02-23 08:51:08 +01:00
Jan Oberhauser e251439333
fix(Discord Node): Fix wrong error message being displayed (#5547) 2023-02-22 15:54:52 +01:00
OlegIvaniv 0fbb3f0f02
fix(core): Do not remove empty output connections arrays in PurgeInvalidWorkflowConnections migration (#5546)
fix(cli): Do not remove empty output connections arrays in PurgeInvalidWorkflowConnections migration
2023-02-22 14:20:06 +01:00
Michael Auerswald 17eff4d7d6
fix(core): Fix execution status filters (#5533)
* fix status filters

* fix countfilter

* add migrations to backfill status

* fix migrations
2023-02-21 21:44:46 +01:00
कारतोफ्फेलस्क्रिप्ट™ 52f740b9e8
refactor(core): Use an IoC container to manage singleton classes [Part-1] (no-changelog) (#5509)
* add typedi

* convert ActiveWorkflowRunner into an injectable service

* convert ExternalHooks into an injectable service

* convert InternalHooks into an injectable service

* convert LoadNodesAndCredentials into an injectable service

* convert NodeTypes and CredentialTypes into an injectable service

* convert ActiveExecutions into an injectable service

* convert WaitTracker into an injectable service

* convert Push into an injectable service

* convert ActiveWebhooks and  TestWebhooks into an injectable services

* handle circular references, and log errors when a circular dependency is found
2023-02-21 19:21:56 +01:00
Jan Oberhauser b44526cd49 Merge tag 'n8n@0.216.1' 2023-02-21 18:47:26 +01:00
Jonathan Bennetts b3e1793ac0
fix(Discourse Node): Fix issue with credential test not working (#5520) 2023-02-21 15:20:28 +00:00
agobrech f1589d4f0f
feat: Add Required path name mapping to multiple nodes (#5369)
*  Add requiresDataPath to Set

* Add Data path mapping to rename keys

* Add required path name to airtable

* Add required data path

* Add required data path to airtable trigger

* Fix multiple keyword for required path

* ️use multiple for Airtable ignore fields

---------

Co-authored-by: Marcus <marcus@n8n.io>
2023-02-21 14:49:59 +01:00
Michael Kret 7ecd5e59ec
fix(Compare Datasets Node): UI tweaks and fixes 2023-02-21 15:42:00 +02:00
Mutasem Aldmour d47d0086cc
feat: Add new event hooks (#5530)
* feat: Add new event hooks

* fix: update event
2023-02-21 16:34:39 +03:00
github-actions[bot] 7400c35a48
🚀 Release 0.216.1 (#5531)
* 🚀 Release 0.216.1

* fix(core): Do not allow arbitrary path traversal in the credential-translation endpoint (#5522)

* fix(core): Do not allow arbitrary path traversal in BinaryDataManager (#5523)

* fix(core): User update endpoint should only allow updating email, firstName, and lastName (#5526)

* fix(core): Do not explicitly bypass auth on urls containing `.svg` (#5525)

* 📚 Update CHANGELOG.md

---------

Co-authored-by: janober <janober@users.noreply.github.com>
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <netroy@users.noreply.github.com>
Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
2023-02-21 14:24:02 +01:00
कारतोफ्फेलस्क्रिप्ट™ fe782c8f6a ci: Setup a semi-automated release process (no-changelog) (#5504)
* ci: Setup a semi-automated release process (no-changelog)

* create tag/release before deleting the temporary branch
2023-02-21 14:16:04 +01:00
कारतोफ्फेलस्क्रिप्ट™ 3ae005cafe
ci: Setup a semi-automated release process (no-changelog) (#5504)
* ci: Setup a semi-automated release process (no-changelog)

* create tag/release before deleting the temporary branch
2023-02-21 14:04:35 +01:00
Michael Kret 5d74a2f89a
fix(Postgres Node): Fix for tables containing field named json 2023-02-21 14:16:18 +02:00
कारतोफ्फेलस्क्रिप्ट™ f58573dba3
fix(core): Do not explicitly bypass auth on urls containing .svg (#5525) 2023-02-21 11:52:22 +01:00
Milorad FIlipović 684d717520
fix(editor): Fix unexpected date rendering on front-end (#5528)
🔥 Remove front-end date rendering logic that changes date timezone to workflow TZ
2023-02-21 11:27:15 +01:00
कारतोफ्फेलस्क्रिप्ट™ 510855d958
fix(core): User update endpoint should only allow updating email, firstName, and lastName (#5526) 2023-02-21 11:22:54 +01:00
कारतोफ्फेलस्क्रिप्ट™ eef2574067
fix(core): Do not allow arbitrary path traversal in BinaryDataManager (#5523) 2023-02-21 11:21:17 +01:00
कारतोफ्फेलस्क्रिप्ट™ f0f8d59fee
fix(core): Do not allow arbitrary path traversal in the credential-translation endpoint (#5522) 2023-02-21 11:21:04 +01:00
Mutasem Aldmour 26a20ed47e
feat: Support feature flag evaluation server side (#5511)
* feat(editor): roll out schema view

* feat(editor): add posthog tracking

* refactor: use composables

* refactor: clean up console log

* refactor: clean up impl

* chore: clean up impl

* fix: fix demo var

* chore: add comment

* refactor: clean up

* chore: wrap error func

* refactor: clean up import

* refactor: make store

* feat: enable rudderstack usebeacon, move event to unload

* chore: clean up alert

* refactor: move tracking from hooks

* fix: reload flags on login

* fix: add func to setup

* fix: clear duplicate import

* chore: add console to tesT

* chore: add console to tesT

* fix: try reload

* chore: randomize instnace id for testing

* chore: randomize instnace id for testing

* chore: add console logs for testing

* chore: move random id to fe

* chore: use query param for testing

* feat: update PostHog api endpoint

* feat: update rs host

* feat: update rs host

* feat: update rs endpoints

* refactor: use api host for BE events as well

* refactor: refactor out posthog client

* feat: add feature flags to login

* feat: add feature flags to login

* feat: get feature flags to work

* feat: add created at to be events

* chore: add todos

* chore: clean up store

* chore: add created at to identify

* feat: add posthog config to settings

* feat: add bootstrapping

* chore: clean up

* chore: fix build

* fix: get dates to work

* fix: get posthog to recognize dates

* chore: refactor

* fix: update back to number

* fix: update key

* fix: get experiment evals to work

* feat: add posthog to signup router

* feat: add feature flags on sign up

* chore: clean up

* fix: fix import

* chore: clean up loading script

* feat: add timeout, fix: script loader

* fix: test timeout and get working on 8080

* refactor: move out posthog

* feat: add experiment tracking

* fix: clear tracked on reset

* fix: fix signup bug

* fix: handle errors when telmetry is disabled

* refactor: remove redundant await

* fix: add back posthog to telemetry

* test: fix test

* test: fix test

* test: add tests for posthog client

* lint: fix

* fix: fix issue with slow decide endpoint

* lint: fix

* lint: fix

* lint: fix

* lint: fix

* chore: address PR feedback

* chore: address PR feedback

* feat: add onboarding experiment
2023-02-21 11:35:35 +03:00
Jonathan Bennetts ee21b7a1cf
fix(Baserow Node): Fix issue with get all not correctly using filters (#5519) 2023-02-20 16:04:43 +00:00
Jonathan Bennetts 1c476770a7
fix(S3 Node): Fix issue with get many buckets not outputting data (#5514) 2023-02-20 15:54:59 +00:00
Jonathan Bennetts 11b467137e
feat: Deprecate Read Binary File node (#5490) 2023-02-20 15:03:30 +00:00
OlegIvaniv 1c0966957d
fix(editor): Fix adding of wrong actions when filtering in the node actions panel (no-changelog) (#5518) 2023-02-20 15:59:38 +01:00
Omar Ajoue 75a094a8c0
fix: Fixes an issue when saving an active workflow without triggers would cause n8n to be stuck (#5513)
fix: Allow saving and editing when an active workflow is saved without triggers
2023-02-20 12:22:27 +01:00
Ahsan Virani db702932f3
feat(core): Add configurable execution history limit (#5505)
* Prune execution data when more than cofnfigured limit

* use stricter typings

* use `pruneDataMaxCount`

---------

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-02-20 10:28:38 +01:00
OlegIvaniv 9a1e7b52f7
feat(editor): Unify regular and trigger node creator panels (#5315)
* WIP: Merge TriggerHelperPanel with MainPanel

* WIP: Implement switching between views

* Remove logging

* WIP: Rework search

* Fix category toggling and search results display

* Fix node item description

* Sort actions based on the root view

* Adjust personalisation modal, make trigger canvas node round

* Linting fixes

* Fix filtering of API options

* Fix types and no result state

* Cleanup

* Linting fixes

* Adjust mode prop for node creator tracking

* Fix merging of core nodes and filtering of single placeholder actions

* Lint fixes

* Implement actions override, fix node creator view item spacing and increase click radius of trigger node icon

* Fix keyboard view navigation

* WIP: E2E Tests

* Address product review

* Minor fixes & cleanup

* Fix tests

* Some more test fixes

* Add specs to check actions and panels

* Update personalisation survey snapshot
2023-02-17 15:08:26 +01:00
कारतोफ्फेलस्क्रिप्ट™ 561882f599
refactor(core): Improve instance owner setup and add unit tests (no-changelog) (#5499)
* refactor(core): Avoid fetching all workflows and credentials for the owner setup screen

* refactor(core): Add unit tests for the owner controller
2023-02-17 10:59:09 +01:00
कारतोफ्फेलस्क्रिप्ट™ 12104bc4a3
refactor(core): Delete unused GET /me endpoint (no-changelog) (#5498) 2023-02-17 10:58:48 +01:00
Michael Auerswald d143f3f2ec
feat(core): Add execution runData recovery and status field (#5112)
* adds ExecutionEvents view modal to ExecutionList

* fix time rendering and remove wf column

* checks for unfinished executions and fails them

* prevent re-setting stoppedAt for execution

* some cleanup / manually create rundata after crash

* quicksave

* remove Threads lib, log worker rewrite

* cleanup comment

* fix sentry destination return value

* test for tests...

* run tests with single worker

* fix tests

* remove console log

* add endpoint for execution data recovery

* lint cleanup and some refactoring

* fix accidental recursion

* remove cyclic imports

* add rundata recovery to Workflowrunner

* remove comments

* cleanup and refactor

* adds a status field to executions

* setExecutionStatus on queued worker

* fix onWorkflowPostExecute

* set waiting from worker

* get crashed status into frontend

* remove comment

* merge fix

* cleanup

* catch empty rundata in recovery

* refactor IExecutionsSummary and inject nodeExecution Errors

* reduce default event log size to 10mb from 100mb

* add per node execution status

* lint fix

* merge and lint fix

* phrasing change

* improve preview rendering and messaging

* remove debug

* Improve partial rundata recovery

* fix labels

* fix line through

* send manual rundata to ui at crash

* some type and msg push fixes

* improve recovered item rendering in preview

* update workflowStatistics on recover

* merge fix

* review fixes

* merge fix

* notify eventbus when ui is back up

* add a small timeout to make sure the UI is back up

* increase reconnect timeout to 30s

* adjust recover timeout and ui connection lost msg

* do not stop execution in editor after x reconnects

* add executionRecovered push event

* fix recovered connection not green

* remove reconnect toast and  merge existing rundata

* merge editor and recovered data for own mode
2023-02-17 10:54:07 +01:00
Michael Auerswald 3a9c257f55
feat(core): Add saml feature flag (#5494)
adds saml feature flag
2023-02-16 15:05:39 +01:00
Jan Oberhauser 12ae095154 🔖 Release n8n@0.216.0 2023-02-16 12:18:57 +00:00
Jan Oberhauser f3f026cb5e ⬆️ Set n8n-core@0.155.0, n8n-editor-ui@0.182.0, n8n-nodes-base@0.214.0 and n8n-workflow@0.137.0 on n8n 2023-02-16 12:18:57 +00:00
Jan Oberhauser dab9d78c30 🔖 Release n8n-editor-ui@0.182.0 2023-02-16 12:16:41 +00:00
Jan Oberhauser 8630e84cfe ⬆️ Set n8n-design-system@0.54.0 and n8n-workflow@0.137.0 on n8n-editor-ui 2023-02-16 12:16:41 +00:00
Jan Oberhauser 18cbc6aa23 🔖 Release n8n-design-system@0.54.0 2023-02-16 12:16:25 +00:00
Jan Oberhauser 33798a20dc 🔖 Release n8n-nodes-base@0.214.0 2023-02-16 12:15:14 +00:00
Jan Oberhauser fda6db2bd1 ⬆️ Set n8n-core@0.155.0 and n8n-workflow@0.137.0 on n8n-nodes-base 2023-02-16 12:15:14 +00:00
Jan Oberhauser ebb1fa85d6 🔖 Release n8n-node-dev@0.94.0 2023-02-16 12:15:03 +00:00
Jan Oberhauser a823166527 ⬆️ Set n8n-core@0.155.0 and n8n-workflow@0.137.0 on n8n-node-dev 2023-02-16 12:15:03 +00:00
Jan Oberhauser 36df2de758 🔖 Release n8n-core@0.155.0 2023-02-16 12:14:53 +00:00
Jan Oberhauser 21484a9dab ⬆️ Set n8n-workflow@0.137.0 on n8n-core 2023-02-16 12:14:53 +00:00
Jan Oberhauser 49865b7b62 🔖 Release n8n-workflow@0.137.0 2023-02-16 12:14:40 +00:00
Mutasem Aldmour 3de49e8f78
feat: Update telemetry api endpoints (#5482)
* feat: update PostHog api endpoint

* feat: update rs host

* feat: update rs host

* feat: update rs endpoints

* refactor: use api host for BE events as well
2023-02-16 15:07:08 +03:00
Marcus 00ac4c308a
feat(Github Node): Use resource locator component (#5489)
️RLC for Repository Owner and Repository Name
2023-02-16 12:54:42 +01:00
Milorad FIlipović 6592d144d1
feat(editor): Add most important native props and methods to autocomplete (#5486)
*  Implemented support for documentation links in autocomplete tooltips
*  Added support for arguments and code stying in autocomplete documentation. Added build-in string functions docs.
*  Added support for args without types in autocomplete, Added array native functions.
*  Added native Number and Object methods to autocomplete
*  Added support for native properties in autocomplete
* 📚 Added comment for next phase
* ✔️ Updating tests to account for native autocomplete options. Fixing lint errros.
* 👌 Addressing design review comments
* 🎨 Using design-system tokens instead of colors for autocomplete
2023-02-16 12:47:19 +01:00
feelgood-interface af703371fc
fix(HTTP Request Node): Ignore empty body for auto detect json (#5215) 2023-02-16 11:00:06 +00:00
Jonathan Bennetts 7954ed3cfb
feat(Slack Node): Add support for manually inputting a channel name (#5488) 2023-02-16 10:45:03 +00:00
Csaba Tuncsik 593b5d299a
test(editor): Execution testing from UI perspective (no-changelog) (#5429)
* test(editor): Execution testing from UI perspective

* test(editor): Execution testing from UI perspective

* test(editor): Execution test rename

* test(editor): Execution test rename and add stop test

* test(editor): Execution test with webhook

* test(editor): Execution test with webhook
2023-02-16 11:41:25 +01:00
Csaba Tuncsik a2c6ea9e11
fix(core): Remove unnecessary info from GET /workflows response (#5311)
* fix(core): Remove unnecessary info from `GET /workflows` response

* fix(core): Remove unnecessary info from `GET /workflows` response

* fix(core): Remove credentials from `GET /workflows` response

* fix(core): Update unit tests for `GET /workflows` response

* fix(core): Remove `usedCredentials` from `GET /workflows` response

* fix(core): Update unit tests for `GET /workflows` response

* fix(core): remove nodes from getMany

* fix(core): remove unnecessary owner props from workflow list items

* fix(core): fix lint error

* fix(core): remove unused function

* fix(core): simplifying ownerId usage

* fix(core): trim down the query for workflow listing
2023-02-16 10:36:24 +01:00
Jonathan Bennetts 1a20fd9f46
fix(Bubble Node): Fix pagination issue when returning all objects (#5483) 2023-02-16 09:01:56 +00:00
Jonathan Bennetts 71cba06b7c
feat(Notion Node): Add icon support for page and database page creation (#5468) 2023-02-16 09:00:54 +00:00
कारतोफ्फेलस्क्रिप्ट™ a9f08fc5ba
fix(core): Fix issues with community node installation (no-changelog) (#5481)
This fixes the following issues:
* After a community node is installed, we were not calling `postProcessLoaders`, which was causing a bunch of unexpected behaviors, and sometimes even crashes. This was only happening in the session where the package was installed. After a crash, the restarted service was working without these issues.
* After a community node is installed, the icon for the nodes and credentials were missing in the UI, as we were creating one icons route per installed package at startup, and this did not handle newly installed packages. restarting the service fixes this issue as well.

Fixes https://community.n8n.io/t/showing-weird-count-on-community-nodes/23035
2023-02-15 16:09:53 +01:00
Alex Grozav 6265f3a27a
feat(editor): Update to personalization survey v4 (#5474)
* feat(editor): update to personalization survey v4

* refactor: rename role other key for consistency

* feat: add reported source to survey

* test: add unit tests for personalization modal
2023-02-15 15:05:55 +02:00
Marcus a3d8fac73a
feat(Github Trigger Node): Use resource locator component (#5253)
* ️wip

* ️RLC Search Function for getUsers and getRepositories

* 🐛fix Repository RLC by name url

* 🐛 search method getRepositories include forks

* 🐛 fix repository name can have a dot

* 🐛 fix RLC extractValue without optional

* 🎨 fix linting errors

* 🎨 using prefix 'e.g.' in RLC placeholders

---------

Co-authored-by: Michael Kret <michael.k@radency.com>
2023-02-15 13:12:28 +01:00
Milorad FIlipović 0cf45bc4c8
fix(core): Fix data transformation function that are reported not to work properly (#5338)
* 🔥 Remove test extensions
* 🚧 Add test description
* 📘 Expand types
*  Export extensions
*  Export collection
*  Mark all proxies
* ✏️ Rename for clarity
*  Export from barrel
*  Create datatype completions
*  Mount datatype completions
* 🧪 Adjust tests
*  Add `path` prop
* 🔥 Remove `()` from completion labels
*  Filter out completions for pseudo-proxies
* 🐛 Fix method error
*  Add metrics
* ✏️ Improve naming
*  Start completion on empty resolvable
*  Implement completion previews
*  Break out completion manager
*  Implement in expression editor modal
* ✏️ Improve naming
*  Filter out irrelevant completions
*  Add preview hint
* ✏️ Improve comments
* 🎨 Style preview hint
*  Expand `hasNoParams`
*  Add spacing for readability
*  Add error codes
* ✏️ Add comment
* 🐛 Fix Esc behavior
*  Parse Unicode
*  Throw on invalid `DateTime`
*  Fix second root completion detection
*  Switch message at completable prefix position
* 🐛 Fix function names for non-dev build
* 🐛 Fix `json` handling
* 🔥 Comment out previews
* ♻️ Apply feedback
* 🔥 Remove extensions
* 🚚 Rename extensions
*  Adjust some implementations
* 🔥 Remove dummy extensions
* 🐛 Fix object regex
* ♻️ Apply feedback
* ✏️ Fix typos
* ✏️ Add `fn is not a function` message
* 🔥 Remove check
*  Add `isNotEmpty` for objects
* 🚚 Rename `global` to `alpha`
* 🔥 Remove `encrypt`
*  Restore `is not a function` error
*  Support `week` on `extract()`
* 🧪 Fix tests
*  Add validation to some string extensions
*  Validate number arrays in some extensions
* 🧪 Fix tests
* ✏️ Improve error message
*  Revert extensions framework changes
* 🧹 Previews cleanup
*  Condense blank completions
*  Refactor dollar completions
*  Refactor non-dollar completions
*  Refactor Luxon completions
*  Refactor datatype completions
*  Use `DATETIMEUNIT_MAP`
* ✏️ Update test description
*  Revert "Use `DATETIMEUNIT_MAP`"
This reverts commit 472a77df5c.
* 🧪 Add tests
* ♻️ Restore generic extensions
* 🔥 Remove logs
* 🧪 Expand tests
*  Add `Math` completions
* ✏️ List breaking change
*  Add doc tooltips
* 🐛 Fix node selector regex
* 🐛 Fix `context` resolution
* 🐛 Allow dollar completions in args
*  Make numeric array methods context-dependent
* 📝 Adjust docs
* 🐛 Fix selector ref
*  Surface error for valid URL
* 🐛 Disallow whitespace in `isEmail` check
* 🧪 Fix test for `isUrl`
*  Add comma validator in `toFloat`
*  Add validation to `$jmespath()`
*  Revert valid URL error
*  Adjust `$jmespath()` validation
* 🧪 Adjust `isUrl` test
*  Remove `{}` and `[]` from compact
* ✏️ Update docs
* 🚚 Rename `stripTags` to `removeTags`
*  Do not inject whitespace inside resolvable
*  Make completions aware of `()`
* ✏️ Add note
*  Update sorting
*  Hide active node name from node selector
* 🔥 Remove `length()` and its aliases
*  Validate non-zero for `chunk`
* ✏️ Reword all error messages
* 🐛 Fix `$now` and `$today`
*  Simplify with `stripExcessParens`
*  Fold luxon into datatype
* 🧪 Clean up tests
* 🔥 Remove tests for removed methods
* 👕 Fix type
* ⬆️ Upgrade lang pack
*  Undo change to `vitest` command
* 🔥 Remove unused method
*  Separate `return` line
* ✏️ Improve description
* 🧪 Expand tests for initial-only completions
* 🧪 Add bracket-aware completions
*  Make check for `all()` stricter
* ✏️ Adjust explanatory comments
* 🔥 Remove unneded copy
* 🔥 Remove outdated comment
*  Make naming consistent
* ✏️ Update comments
*  Improve URL scheme check
* ✏️ Add comment
* 🚚 Move extension
* ✏️ Update `BREAKING-CHANGES.md`
* ✏️ Update upcoming version
* ✏️ Fix grammar
* ✏️ Shorten message
* 🐛 Fix `Esc` behavior
* 🐛 Fix `isNumeric`
*  Using UTC to handle-dates on back-end
*  Added more unit tests for date extensions
*  Not using `JSON.stringify` to render dates
*  Using `deep-equal` library instead of our `deepCompare` function
*  Adding more tests to array extensions
*  Fixing `inBetween` extension function
*  Added tests for `.inBetween()`
*  Updating `isEven` and `isOdd` to throw for floats
*  Updating `Array.merge()` so it works without arguments
* 🔀 Fixing leftover merge confilct
*  Updating `removeFieldsContaining` and `keepFieldsContaining` to throw on empty strings
*  Fixing `pluck()` so it returns only plucked values
* ⬆️ Updating pnpm lockfile
* 👕 Fixing lint errors
*  Using workflow timezone to display dates
* ✔️ Updating tests with workflow timezone
*  Not using system timezone when creating Luxon dates
*  Updating `merge()` and `pluck()` array functions
* 🔀 Sync with `master`: Removing code that was preserved during merge
*  Updating `.pluck()` to return full array if no arguments are passed
*  Updating `keepFieldsContaining` and `merge` object functions
*  Using week as default for `date.extract()`
*  Adding more test cases for DT functions
*  Removing `Object.merge` extension function. Adding missing `deep-equal` dependency
*  Handling `toDate` case when time component is not specified
*  Using workflow's timezone to render dates in output panel, updated unit tests after removing `Object.merge` function
*  Not parsing numbers as dates
* 👕 Fixing lint errors
*  Fixing a typo
*  Making date detection more strict so only stringified dates are getting converted
* 👌 Addressing PR feedback
* 🔥 Removing leftover comment
---------

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
2023-02-15 10:50:16 +01:00
कारतोफ्फेलस्क्रिप्ट™ 83505cb0d4
ci(core): Add unit tests for "me" controller (no-changelog) (#5479) 2023-02-15 09:00:41 +01:00
कारतोफ्फेलस्क्रिप्ट™ a6c59fcbc2
fix(core): Use stricter typing on queries in cli commands (no-changelog) (#5476)
This has been broken since TypeORM upgrade

Fixes:
https://linear.app/n8n/issue/ENG-50
https://community.n8n.io/t/execute-command-stdout/22994
2023-02-14 17:05:53 +01:00
कारतोफ्फेलस्क्रिप्ट™ 522ddfc0cd
fix(editor): Fix Vite dev mode (no-changelog) (#5475)
because of the updated dev tooling in https://github.com/n8n-io/n8n/pull/5454, vite dev mode is crashing because of the `util` package looking for `process.env`.
2023-02-14 16:10:39 +01:00
Alex Grozav 36108f82a1
feat(editor): Add correct credential owner contact details for readonly credentials (#5208)
* feat: add correct credential owner contact details for readonly credentials

* chore: remove unnecessary translation

* fix: update credential owner name to be retrieved using usedCredentials

* fix: correct credentialownername getter typing
2023-02-14 16:13:22 +02:00
Alex Grozav 246189f6da
feat: Add workflow and credential sharing access e2e tests (#5463)
feat: add workflow and credential sharing access e2e tests
2023-02-14 16:13:00 +02:00
कारतोफ्फेलस्क्रिप्ट™ b25c10a0e1
ci: Update the "Check Documentation URLs" workflow (no-changelog) (#5473)
* ci: Update the "Check Documentation URLs" workflow (no-changelog)

* fix the documentation url for HtmlExtract node
2023-02-14 13:00:15 +01:00
कारतोफ्फेलस्क्रिप्ट™ f7cbd6b17e
feat(editor): Upgrade to Storybook v7 (no-changelog) (#5454)
Storybook 6 + Webpack 4 are pulling in a lot of dependencies that are blocking us from supporting node 18.
2023-02-14 12:44:13 +01:00
Milorad FIlipović 3b9eec77ec
test(editor): Add e2e tests for executions preview (#5458)
*  Added initial tests for executions preview
* 🔥 Removing unneeded actions
* 👌 Renaming test suite, moving mock executions logic to util function
2023-02-14 11:39:19 +01:00
Jan Oberhauser 0ba5573162 🔖 Release n8n@0.215.2 2023-02-14 10:10:30 +00:00
कारतोफ्फेलस्क्रिप्ट™ 4dc458eca5
fix(core): Fix the issue with test webhooks getting removed incorrectly (no-changelog) (#5466)
This broke because of the change [here](https://github.com/n8n-io/n8n/pull/5443/files#diff-b386248ff00977749c873ed85821c241b773e9740d7e7adf94e05b73b350ed74L152).
`finally` block is called even if there is a `return` in the `try` block, and this is causing the test webhook to be removed, even when it shouldn't be removed.
2023-02-13 16:16:53 +01:00
Jan Oberhauser 8f25073a22 🔖 Release n8n@0.215.1 2023-02-11 15:53:54 +00:00
Jan Oberhauser 1627f8b444 ⬆️ Set n8n-core@0.154.1, n8n-editor-ui@0.181.1, n8n-nodes-base@0.213.1 and n8n-workflow@0.136.1 on n8n 2023-02-11 15:53:54 +00:00
Jan Oberhauser 498a724e26 🔖 Release n8n-editor-ui@0.181.1 2023-02-11 15:51:38 +00:00
Jan Oberhauser b9ef0a3664 ⬆️ Set n8n-workflow@0.136.1 on n8n-editor-ui 2023-02-11 15:51:37 +00:00
Jan Oberhauser c25a5a99a6 🔖 Release n8n-nodes-base@0.213.1 2023-02-11 15:50:36 +00:00
Jan Oberhauser b064a2e8cc ⬆️ Set n8n-core@0.154.1 and n8n-workflow@0.136.1 on n8n-nodes-base 2023-02-11 15:50:36 +00:00
Jan Oberhauser 8c4d1f73b5 🔖 Release n8n-node-dev@0.93.1 2023-02-11 15:50:23 +00:00
Jan Oberhauser 04eb832bfa ⬆️ Set n8n-core@0.154.1 and n8n-workflow@0.136.1 on n8n-node-dev 2023-02-11 15:50:22 +00:00
Jan Oberhauser be17ec6e82 🔖 Release n8n-core@0.154.1 2023-02-11 15:50:13 +00:00
Jan Oberhauser 89c9875423 ⬆️ Set n8n-workflow@0.136.1 on n8n-core 2023-02-11 15:50:13 +00:00
Jan Oberhauser a245dbe0c9 🔖 Release n8n-workflow@0.136.1 2023-02-11 15:50:03 +00:00
Jan Oberhauser 339655611f
fix(core): Fix issue that worker and webhook service close directly (#5461) 2023-02-11 09:46:10 -06:00
कारतोफ्फेलस्क्रिप्ट™ 59f5c4221e
fix(core): Handle versioned custom nodes correctly (#5313) 2023-02-10 18:33:04 +01:00
agobrech 309c995364
test: Change workflows to test from safe list to skip list (#5457)
* Remove check by safe list to skip list

* add an option to skip using statistics events

---------

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-02-10 17:11:06 +01:00
Jan Oberhauser 231b690605 🔖 Release n8n@0.215.0 2023-02-10 15:46:55 +00:00
Jan Oberhauser ffc88977ef ⬆️ Set n8n-core@0.154.0, n8n-editor-ui@0.181.0, n8n-nodes-base@0.213.0 and n8n-workflow@0.136.0 on n8n 2023-02-10 15:46:55 +00:00
Jan Oberhauser 8fa8aaa4b1 🔖 Release n8n-editor-ui@0.181.0 2023-02-10 15:44:37 +00:00
Jan Oberhauser 565f1216e3 ⬆️ Set n8n-design-system@0.53.0 and n8n-workflow@0.136.0 on n8n-editor-ui 2023-02-10 15:44:37 +00:00
Jan Oberhauser 2fb54e922a 🔖 Release n8n-design-system@0.53.0 2023-02-10 15:44:19 +00:00
Jan Oberhauser 595ef1ee95 🔖 Release n8n-nodes-base@0.213.0 2023-02-10 15:43:13 +00:00
Jan Oberhauser 829edf3c26 ⬆️ Set n8n-core@0.154.0 and n8n-workflow@0.136.0 on n8n-nodes-base 2023-02-10 15:43:13 +00:00
Jan Oberhauser 89ea19a7ce 🔖 Release n8n-node-dev@0.93.0 2023-02-10 15:42:58 +00:00
Jan Oberhauser 24411ba953 ⬆️ Set n8n-core@0.154.0 and n8n-workflow@0.136.0 on n8n-node-dev 2023-02-10 15:42:58 +00:00
Jan Oberhauser d857d87f8b 🔖 Release n8n-core@0.154.0 2023-02-10 15:42:44 +00:00
Jan Oberhauser 6e431eb8a8 ⬆️ Set n8n-workflow@0.136.0 on n8n-core 2023-02-10 15:42:44 +00:00
Jan Oberhauser 7ec7e31565 🔖 Release n8n-workflow@0.136.0 2023-02-10 15:42:33 +00:00
कारतोफ्फेलस्क्रिप्ट™ 9a331ec7b6
fix(core): Stop using unbound calls to stopProcess (no-changelog) (#5456) 2023-02-10 16:34:39 +01:00
Marcus d266401ed8
test(Read PDF Node): Unit tests (no-changelog) (#5453)
 add ReadPDF node test

Co-authored-by: Michael Kret <michael.k@radency.com>
2023-02-10 16:26:26 +01:00
Marcus 9698c7e7ea
test(Move Binary Data Node): Unit tests (no-changelog) (#5442)
*  add Move Binary Data test

*  improve Move Binary Data Test -

---------

Co-authored-by: Michael Kret <michael.k@radency.com>
2023-02-10 15:33:32 +01:00
Omar Ajoue a2e2ec5442
test: Add tests for ActiveWorkflowRunner class (#5278) 2023-02-10 15:24:20 +01:00
कारतोफ्फेलस्क्रिप्ट™ 538984dc2f
feat(core): Add support for WebSockets as an alternative to Server-Sent Events (#5443)
Co-authored-by: Matthijs Knigge <matthijs@volcano.nl>
2023-02-10 15:02:47 +01:00
कारतोफ्फेलस्क्रिप्ट™ 5194513850
refactor(core): Delete duplicate code across all commands (#5452) 2023-02-10 14:59:20 +01:00
Milorad FIlipović 8494c97821
test(editor): Add e2e tests for personal settings page (#5451)
 Added tests for personal user settings
2023-02-10 13:12:06 +01:00
Michael Kret 40879f67cb
test(iCalendar Node): Unit tests (no-changelog) 2023-02-10 12:55:07 +02:00
Michael Kret 649c7ccfb1
test(Markdown Node): Unit tests (no-changelog) 2023-02-10 12:30:37 +02:00
Michael Kret b641a3e36d
test(Compare Datasets Node): Unit tests (no-changelog) 2023-02-10 11:57:54 +02:00
Valya 287fa9cd06
test(core): Add basic expression tests (no-changelog) (#5439)
* test(core): add basic expression tests

* test: fix $if test not working properly
2023-02-10 10:05:34 +01:00
Marcus 5b1e3a3fd3
test(Write Binary File Node): Unit tests (no-changelog) (#5440)
*  add write binary file test

* 🎨 cleanup

---------

Co-authored-by: Michael Kret <michael.k@radency.com>
2023-02-10 09:53:20 +01:00
Iván Ovejero 136b74de5e
test: Upgrade vitest (no-changelog) (#5307)
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-02-10 03:20:15 +01:00
Jan Oberhauser 69f5d6a9fd Merge branch 'n8n_0.214.3' 2023-02-09 12:44:36 -06:00
Jan Oberhauser c278f010ef 🔖 Release n8n@0.214.3 2023-02-09 12:38:05 -06:00
Jan Oberhauser 48740f8763 ⬆️ Set n8n-editor-ui@0.180.3 on n8n 2023-02-09 12:36:56 -06:00
Jan Oberhauser 8f36ce3ffb 🔖 Release n8n-editor-ui@0.180.3 2023-02-09 19:33:34 +01:00
Omar Ajoue 7fc96571e0 fix: MySQL migration parses database contents if necessary (fix for MariaDB) (#5441) 2023-02-09 11:29:43 -06:00
OlegIvaniv b57ec1d6ab fix(editor): Prevent creation of input connections for nodes without input slot (#5425)
* fix(editor): Prevent creation of input connections for nodes without input

* WIP: Workflow checks service and controller

* fix: Created SQLite migration to remove broken connections

* Cleanup & add mysql/posgres migrations

* Linter fixes

* Unify the migration scripts

* Escape migration workflow_entity

* Wrap the migration in try/catch and do not parse nodes and connection if mysql/postgres

* Do migration changes also fro mysql

* refactor: Wrap only the necessary call in try catch block

---------

Co-authored-by: Omar Ajoue <krynble@gmail.com>
2023-02-09 11:29:34 -06:00
Omar Ajoue 2eb72a6c9f
fix: MySQL migration parses database contents if necessary (fix for MariaDB) (#5441) 2023-02-09 18:15:20 +01:00
Jonathan Bennetts 57a2b9cceb
fix(Linear Node): Fix issue with Issue States not loading correctly (#5435) 2023-02-09 15:58:52 +00:00
Michael Kret 32de081b0c
test(Compression Node): Unit tests (no-changelog) 2023-02-09 17:13:39 +02:00
OlegIvaniv 018f8a3510
fix(editor): Prevent creation of input connections for nodes without input slot (#5425)
* fix(editor): Prevent creation of input connections for nodes without input

* WIP: Workflow checks service and controller

* fix: Created SQLite migration to remove broken connections

* Cleanup & add mysql/posgres migrations

* Linter fixes

* Unify the migration scripts

* Escape migration workflow_entity

* Wrap the migration in try/catch and do not parse nodes and connection if mysql/postgres

* Do migration changes also fro mysql

* refactor: Wrap only the necessary call in try catch block

---------

Co-authored-by: Omar Ajoue <krynble@gmail.com>
2023-02-09 16:04:26 +01:00
Milorad FIlipović d9a4c2c66d
test(editor): Add user management e2e tests (#5438)
*  Added initial UM test using new commands
*  Added rest of the UM tests
2023-02-09 16:00:55 +01:00
Mutasem Aldmour b8980f6118
test: Add more data mapping tests (#5389)
* test: Add more data mapping tests

* test: add tests for preview mapping

* test: update wording

* test: add more tests

* test: fix up prev node test

* test: stop popup

* test: add mapping test for paths

* test: revert back param changes

* test: fix mapping tests

* test: reset db

* test: fix up mapping tests

* test: fix up mapping tests

* test: update tests to be more stable

* chore: clean up unused command

* fix: fix up before unload bug

* fix: fix data transformation tests

* test: fix up flaky webhook tests

* test: fix up flaky webhook tests

* test: fix up flaky dt tests
2023-02-09 17:59:01 +03:00
कारतोफ्फेलस्क्रिप्ट™ 00befbc75a
ci(editor): Faster builds on the CI (no-changelog) (#5422) 2023-02-09 15:47:34 +01:00
Marcus e01192e7af
test(Read Binary File Node): Unit tests (no-changelog) (#5436)
 add Read Binary Data node unit test

Co-authored-by: Michael Kret <michael.k@radency.com>
2023-02-09 15:31:10 +01:00
agobrech fdf47a96de
fix(core): Fix import command for workflows with old format(pre UM) (#5403)
* Replace invalid credentials when importing workflows

* Remove useless console.logs
2023-02-09 15:24:09 +01:00
Michael Kret 1ea1935b9a
test(RSS Read Node): Unit tests (no-changelog) 2023-02-09 16:13:23 +02:00
Valya c7b58e0ed1
fix(core): Expression extension failing with optional chaining (#5370)
* wip

* fix: working optional chaining polyfill

* fix: polyfill optional chaining on extended functions

* test: add optional chaining tests
2023-02-09 13:57:45 +00:00
agobrech 40f4ec75fa
test(Date & Time Node): Unit tests (no-changelog) (#5415)
*  Add tests to DateTime node

* Test different timezone

* Try new fix

* Fix workflow change time of workflow exec in UTC

* Check if UTC is correctly setup

---------

Co-authored-by: Marcus <marcus@n8n.io>
2023-02-09 14:54:24 +01:00
Marcus 3e2d76ec79
test(Code Node): Unit tests (no-changelog) (#5373)
*  test setup

* ️basic test with run once for all and each items

* 🎨 fix linting error

* ️update to new Helper.setup(tests)

*  migrate tests to pin data approach
2023-02-09 13:56:39 +01:00
कारतोफ्फेलस्क्रिप्ट™ 172472664d
ci: Upgrade dev tooling (no-changelog) (#5424)
* Typescript
* Jest
* Turborepo
* pnpm
2023-02-09 13:52:41 +01:00
agobrech d4d55b0684
test(Crypto Node): Unit tests (no-changelog) (#5433)
* Add test to Crypto Node

*  added test to generate random uuid

---------

Co-authored-by: Marcus <marcus@n8n.io>
2023-02-09 13:03:53 +01:00
agobrech 43abe225a0
test(Rename Keys Node): Unit tests (no-changelog) (#5428)
Add test for Rename Keys node
2023-02-09 12:26:51 +01:00
कारतोफ्फेलस्क्रिप्ट™ 0fb4d7fc19
fix(core): Stop creating icons directories (no-changelog) (#5431)
forgot to remove this in https://github.com/n8n-io/n8n/pull/5419
2023-02-09 11:45:32 +01:00
Michael Kret 9024e4dcc7
test(Stop and Error Node): Unit tests (no-changelog) 2023-02-09 12:29:02 +02:00
Michael Kret 2150ea0e79
test(HTTP Request Node): Unit tests (no-changelog) 2023-02-09 12:25:26 +02:00
Michael Kret b5948cbe13
test(XML Node): Unit tests (no-changelog) 2023-02-09 12:23:25 +02:00
कारतोफ्फेलस्क्रिप्ट™ 52cb185637
refactor(core): Upgrade typeorm (no-changelog) (#5423)
[Now we can use aggregate functions directly over the repository API](https://github.com/typeorm/typeorm/pull/9737)
2023-02-09 10:44:07 +01:00
Iván Ovejero e0c4c25227
test: Add e2e workflow tags (no-changelog) (#5411)
* 🧪 Add workflow tags tests

*  Create `openTagManagerModal`

*  Add wait to prevent detached DOM element

*  Add wait to mirror other tests
2023-02-09 10:04:12 +01:00