Mutasem Aldmour
01e9340621
feat: Add onboarding flow ( #7212 )
...
Github issue / Community forum post (link here to close automatically):
2023-09-25 15:49:36 +02:00
Iván Ovejero
33991e92d0
fix(core): Fix missing execution ID in webhook-based workflow producing binary data ( #7244 )
...
Story: https://linear.app/n8n/issue/PAY-839
This is a longstanding bug, fixed now so that the S3 backend for binary
data can use execution IDs as part of the filename.
To reproduce:
1. Set up a workflow with a POST Webhook node that accepts binary data.
2. Activate the workflow and call it sending a binary file, e.g. `curl
-X POST -F "file=@/path/to/binary/file/test.jpg"
http://localhost:5678/webhook/uuid `
3. Check `~/.n8n/binaryData`. The binary data and metadata files will be
missing the execution ID, e.g. `11869055-83c4-4493-876a-9092c4708b9b`
instead of `39011869055-83c4-4493-876a-9092c4708b9b`.
2023-09-25 12:30:28 +02:00
Iván Ovejero
6d6e2488c6
refactor(core): Generalize binary data manager interface (no-changelog) ( #7164 )
...
Depends on: #7092 | Story:
[PAY-768](https://linear.app/n8n/issue/PAY-768 )
This PR:
- Generalizes the `IBinaryDataManager` interface.
- Adjusts `Filesystem.ts` to satisfy the interface.
- Sets up an S3 client stub to be filled in in the next PR.
- Turns `BinaryDataManager` into an injectable service.
- Adjusts the config schema and adds new validators.
Note that the PR looks large but all the main changes are in
`packages/core/src/binaryData`.
Out of scope:
- `BinaryDataManager` (now `BinaryDataService`) and `Filesystem.ts` (now
`fs.client.ts`) were slightly refactored for maintainability, but fully
overhauling them is **not** the focus of this PR, which is meant to
clear the way for the S3 implementation. Future improvements for these
two should include setting up a backwards-compatible dir structure that
makes it easier to locate binary data files to delete, removing
duplication, simplifying cloning methods, using integers for binary data
size instead of `prettyBytes()`, writing tests for existing binary data
logic, etc.
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-09-22 17:22:12 +02:00
Val
bf74f09d69
feat(core): Add Tournament as the new default expression evaluator ( #6964 )
...
Github issue / Community forum post (link here to close automatically):
---------
Co-authored-by: Omar Ajoue <krynble@gmail.com>
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-09-21 13:57:45 +01:00
Ricardo Espinoza
303bc8e71e
fix: Issue enforcing user limits on start plan ( #7188 )
2023-09-21 05:56:40 -04:00
Iván Ovejero
cd08c8e4c6
refactor(core): Implement soft-deletions for executions ( #7092 )
...
Based on #7065 | Story: https://linear.app/n8n/issue/PAY-771
n8n on filesystem mode marks binary data to delete on manual execution
deletion, on unsaved execution completion, and on every execution
pruning cycle. We later prune binary data in a separate cycle via these
marker files, based on the configured TTL. In the context of introducing
an S3 client to manage binary data, the filesystem mode's mark-and-prune
setup is too tightly coupled to the general binary data management
client interface.
This PR...
- Ensures the deletion of an execution causes the deletion of any binary
data associated to it. This does away with the need for binary data TTL
and simplifies the filesystem mode's mark-and-prune setup.
- Refactors all execution deletions (including pruning) to cause soft
deletions, hard-deletes soft-deleted executions based on the existing
pruning config, and adjusts execution endpoints to filter out
soft-deleted executions. This reduces DB load, and keeps binary data
around long enough for users to access it when building workflows with
unsaved executions.
- Moves all execution pruning work from an execution lifecycle hook to
`execution.repository.ts`. This keeps related logic in a single place.
- Removes all marking logic from the binary data manager. This
simplifies the interface that the S3 client will meet.
- Adds basic sanity-check tests to pruning logic and execution deletion.
Out of scope:
- Improving existing pruning logic.
- Improving existing execution repository logic.
- Adjusting dir structure for filesystem mode.
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-09-20 15:21:42 +02:00
कारतोफ्फेलस्क्रिप्ट™
e9ce531210
fix(core): Resolve domains to IPv4 first ( #7206 )
2023-09-19 15:56:38 +02:00
Cornelius Suermann
050ba706d3
fix: Attempt license renewal when n8n starts (no-changelog) ( #7204 )
...
This change is needed so that the newly introduced floating licenses
will be attempted to be claimed when n8n starts up.
2023-09-19 12:10:23 +02:00
Michael Auerswald
9f797b96d8
feat(core): Add command to trigger license refresh on workers ( #7184 )
...
This PR implements the updated license SDK so that worker and webhook
instances do not auto-renew licenses any more.
Instead, they receive a `reloadLicense` command via the Redis client
that will fetch the updated license after it was saved on the main
instance
This also contains some refactoring with moving redis sub and pub
clients into the event bus directly, to prevent cyclic dependency
issues.
2023-09-17 11:05:54 +02:00
Csaba Tuncsik
240b2f075e
feat(editor): Add Workflow history route and base page (no-changelog) ( #7161 )
2023-09-15 13:17:04 +02:00
Michael Auerswald
fdac2c8572
feat(core): Add rsa option to ssh key generation ( #7154 )
...
PR adds a new field to the SourceControlPreferences as well as to the
POST parameters for the `source-control/preferences` and
`source-control/generate-key-pair` endpoints. Both now accept an
optional string parameter `keyGeneratorType` of `'ed25519' | 'rsa'`
Calling the `source-control/generate-key-pair` endpoint with the
parameter set, it will also update the stored preferences accordingly
(so that in the future new keys will use the same method)
By default ed25519 is being used. The default may be changed using a new
environment parameter:
`N8N_SOURCECONTROL_DEFAULT_SSH_KEY_TYPE` which can be `rsa` or `ed25519`
RSA keys are generated with a length of 4096 bytes.
2023-09-14 11:34:51 +02:00
Michael Auerswald
0c6169ee22
refactor(core): Move event and telemetry handling into workers in queue mode ( #7138 )
...
# Motivation
In Queue mode, finished executions would cause the main instance to
always pull all execution data from the database, unflatten it and then
use it to send out event log events and telemetry events, as well as
required returns to Respond to Webhook nodes etc.
This could cause OOM errors when the data was large, since it had to be
fully unpacked and transformed on the main instance’s side, using up a
lot of memory (and time).
This PR attempts to limit this behaviour to only happen in those
required cases where the data has to be forwarded to some waiting
webhook, for example.
# Changes
Execution data is only required in cases, where the active execution has
a `postExecutePromise` attached to it. These usually forward the data to
some other endpoint (e.g. a listening webhook connection).
By adding a helper `getPostExecutePromiseCount()`, we can decide that in
cases where there is nothing listening at all, there is no reason to
pull the data on the main instance.
Previously, there would always be postExecutePromises because the
telemetry events were called. Now, these have been moved into the
workers, which have been given the various InternalHooks calls to their
hook function arrays, so they themselves issue these telemetry and event
calls.
This results in all event log messages to now be logged on the worker’s
event log, as well as the worker’s eventbus being the one to send out
the events to destinations. The main event log does…pretty much nothing.
We are not logging executions on the main event log any more, because
this would require all events to be replicated 1:1 from the workers to
the main instance(s) (this IS possible and implemented, see the worker’s
`replicateToRedisEventLogFunction` - but it is not enabled to reduce the
amount of traffic over redis).
Partial events in the main log could confuse the recovery process and
would result in, ironically, the recovery corrupting the execution data
by considering them crashed.
# Refactor
I have also used the opportunity to reduce duplicate code and move some
of the hook functionality into
`packages/cli/src/executionLifecycleHooks/shared/sharedHookFunctions.ts`
in preparation for a future full refactor of the hooks
2023-09-14 07:58:15 +02:00
कारतोफ्फेलस्क्रिप्ट™
34ebffea45
refactor(core): Move workerCommandHandler into worker.ts (no-changelog) ( #7160 )
2023-09-13 14:51:41 +02:00
कारतोफ्फेलस्क्रिप्ट™
22edc03cab
fix(core): Ignore missing user-agent on bot check (no-changelog) ( #7153 )
2023-09-12 19:57:25 +02:00
कारतोफ्फेलस्क्रिप्ट™
1d1a022def
feat(core): Add an option to enable WAL mode for SQLite ( #7118 )
...
https://www.sqlite.org/wal.html
2023-09-07 15:58:48 +02:00
Michael Auerswald
7b49cf2a2c
feat(core): Add commands to workers to respond with current state ( #7029 )
...
This PR adds new endpoints to the REST API:
`/orchestration/worker/status` and `/orchestration/worker/id`
Currently these just trigger the return of status / ids from the workers
via the redis back channel, this still needs to be handled and passed
through to the frontend.
It also adds the eventbus to each worker, and triggers a reload of those
eventbus instances when the configuration changes on the main instances.
2023-09-07 14:44:19 +02:00
कारतोफ्फेलस्क्रिप्ट™
273d0913fe
feat(HTTP Request Node): Determine binary file name from content-disposition headers ( #7032 )
...
Fixes:
https://community.n8n.io/t/http-request-node-read-filename-from-content-disposition-header-when-downloading-files/13453
https://community.n8n.io/t/read-filename-from-content-disposition-header-when-downloading-files/22192
2023-09-06 12:38:37 +02:00
Omar Ajoue
25dc4d7825
feat: Add workflow history repository files (no-changelog) ( #7071 )
2023-09-06 12:23:40 +02:00
कारतोफ्फेलस्क्रिप्ट™
a910757cc5
fix(core): Add support for in-transit encryption (TLS) on Redis connections ( #7047 )
...
Fixes https://community.n8n.io/t/upgrade-from-1-1-1-to-1-2-0/30148
2023-09-05 18:18:50 +02:00
कारतोफ्फेलस्क्रिप्ट™
cc37a5046a
fix(core): Lazy-load express-openapi-validator to reduce initial memory spike (no-changelog) ( #7111 )
2023-09-05 14:42:14 +02:00
Iván Ovejero
0036a4726c
refactor(core): Move static data handling to workflow service (no-changelog) ( #7104 )
2023-09-05 13:42:31 +02:00
Michael Auerswald
011ee2e04b
fix(core): Split event bus controller into community and ee ( #7107 )
2023-09-05 13:32:09 +02:00
Iván Ovejero
b7320f5322
refactor(core): Set up ExecutionMetadata
service (no-changelog) ( #7103 )
...
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-09-05 09:13:30 +02:00
कारतोफ्फेलस्क्रिप्ट™
cffda65b33
refactor(core): Add an option to use simple recovery process by default ( #7097 )
2023-09-04 19:58:36 +02:00
कारतोफ्फेलस्क्रिप्ट™
ee36f2d20b
refactor(core): Disable slow-query log by default (no-changelog) ( #7096 )
...
Fixes:
https://community.n8n.io/t/stop-logging-full-query-for-execution/29732
[Slack
Conversation](https://n8nio.slack.com/archives/C035KBDA917/p1693218994681939 )
2023-09-04 17:59:08 +02:00
कारतोफ्फेलस्क्रिप्ट™
f286bd33c1
ci: Fix linting (no-changelog) ( #7099 )
2023-09-04 17:07:11 +02:00
Iván Ovejero
8a28e98ec8
fix(core): Disallow orphan executions ( #7069 )
...
Until https://github.com/n8n-io/n8n/pull/7061 we had an edge case where
a manual unsaved workflow when run creates an orphan execution, i.e. a
saved execution not pointing to any workflow. This execution is only
ever visible to the instance owner (even if triggered by a member), and
is wrongly stored as unfinished and crashed. This PR enforces that the
DB disallows any such executions from making it into the DB.
This is needed also for the S3 client, which will include the
`workflowId` in the path-like filename.
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-09-04 16:57:10 +02:00
Cornelius Suermann
e26553f198
feat(core): Add support for floating licenses ( #7090 )
...
This PR updates the license-sdk to v2.5.0 which introduces optional
support for floating licenses.
2023-09-04 15:56:20 +02:00
Iván Ovejero
fd78021b68
feat(core): Add list query middleware to credentials ( #7041 )
2023-09-04 15:00:25 +02:00
Iván Ovejero
413e0bccb4
feat(core): Migration for soft deletions for executions ( #7088 )
...
Based on https://github.com/n8n-io/n8n/pull/7065
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-09-04 14:34:03 +02:00
Iván Ovejero
442b910ffb
refactor(core): Consolidate CredentialsService.getMany()
(no-changelog) ( #7028 )
...
Consolidate `CredentialsService.getMany()` in preparation for adding
list query middleware to `GET /credentials`.
2023-09-04 10:37:16 +02:00
Iván Ovejero
008cdcce56
ci: Fix lint to fix build ( #7076 )
2023-09-01 16:23:23 +02:00
कारतोफ्फेलस्क्रिप्ट™
97f87ae0fc
refactor(core): Add addColumns
and dropColumns
to the migrations DSL (no-changelog) ( #7073 )
2023-09-01 15:19:49 +02:00
Iván Ovejero
51093f649d
refactor: Move community package logic to service (no-changelog) ( #6973 )
2023-09-01 15:13:19 +02:00
कारतोफ्फेलस्क्रिप्ट™
2432dcc661
fix(core): Prevent bots from scanning the application (no-changelog) ( #7066 )
...
N8N-6878
2023-09-01 13:54:35 +02:00
कारतोफ्फेलस्क्रिप्ट™
a693b29134
ci: Fix prettier auto-formatting (no-changelog) ( #7063 )
2023-09-01 13:29:31 +02:00
Iván Ovejero
fa3d7070b0
refactor(core): Remove unneeded call from CreateWorkflowHistoryTable
migration (no-changelog) ( #7072 )
...
https://github.com/n8n-io/n8n/pull/7069/files#r1312786460
2023-09-01 12:16:24 +02:00
Iván Ovejero
95cb127dfa
refactor(core): Remove slow LDAP query and unused telemetry event ( #7068 )
...
https://linear.app/n8n/issue/PAY-660
2023-09-01 12:05:14 +02:00
Mutasem Aldmour
8a8d4e8bb3
fix: Load remote resources even if expressions in non requried parameters resolve ( #6987 )
...
Github issue / Community forum post (link here to close automatically):
2023-08-31 16:40:20 +02:00
Iván Ovejero
8cd4db0ab7
refactor(core): Simplify marking logic in binary data manager (no-changelog) ( #7046 )
...
- For a saved execution, we write to disk binary data and metadata.
These two are only ever deleted via `POST /executions/delete`. No marker
file, so untouched by pruning.
- For an unsaved execution, we write to disk binary data, binary data
metadata, and a marker file at `/meta`. We later delete all three during
pruning.
- The third flow is legacy. Currently, if the execution is unsaved, we
actually store it in the DB while running the workflow and immediately
after the workflow is finished during the `onWorkflowPostExecute()` hook
we delete that execution, so the second flow applies. But formerly, we
did not store unsaved executions in the DB ("ephemeral executions") and
so we needed to write a marker file at `/persistMeta` so that, if the
ephemeral execution crashed after the step where binary data was stored,
we had a way to later delete its associated dangling binary data via a
second pruning cycle, and if the ephemeral execution succeeded, then we
immediately cleaned up the marker file at `/persistMeta` during the
`onWorkflowPostExecute()` hook.
This creation and cleanup at `/persistMeta` is still happening, but this
third flow no longer has a purpose, as we now store unsaved executions
in the DB and delete them immediately after. Hence the third flow can be
removed.
2023-08-31 16:02:20 +02:00
कारतोफ्फेलस्क्रिप्ट™
9d70ce3a15
ci: Fix occasionally failing MFA e2e test (no-changelog) ( #7040 )
2023-08-29 15:39:10 +02:00
Omar Ajoue
a4578d68a5
feat: Create workflow history database migration (no-changelog) ( #7031 )
...
Github issue / Community forum post (link here to close automatically):
For the upcoming workflow history feature, we're creating the necessary
database tables.
Also changes the schema for Postgres so the versionId column is now
properly a UUID. The `using` statement prevents losing data, basically
converting the strings to UUIDs.
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <netroy@users.noreply.github.com>
2023-08-29 12:01:11 +02:00
Iván Ovejero
53361d1d62
refactor: Move node i18n logic to NodeTypes
(no-changelog) ( #7035 )
2023-08-29 10:46:24 +02:00
Iván Ovejero
b716241b42
feat(core): Add filtering, selection and pagination to users ( #6994 )
...
https://linear.app/n8n/issue/PAY-646
2023-08-28 16:13:17 +02:00
कारतोफ्फेलस्क्रिप्ट™
8bdb07d33d
fix(core): Setup websocket keep-live messages ( #6866 )
...
fixes #6757
2023-08-28 10:26:27 +02:00
कारतोफ्फेलस्क्रिप्ट™
596b5695cd
fix(Webhook Node): Fix URL params for webhooks ( #6986 )
...
Fixes:
https://community.n8n.io/t/empty-params-variables-in-webhook-node-after-upgrading-to-n8n-1-3-1/29624
2023-08-25 13:28:32 +02:00
Iván Ovejero
87cf1d9c1b
refactor(core): Make controller constructors consistent (no-changelog) ( #7015 )
2023-08-25 13:23:22 +02:00
Alex Grozav
ed927d34b2
feat: External Secrets storage for credentials ( #6477 )
...
Github issue / Community forum post (link here to close automatically):
---------
Co-authored-by: Romain Minaud <romain.minaud@gmail.com>
Co-authored-by: Valya Bullions <valya@n8n.io>
Co-authored-by: Csaba Tuncsik <csaba@n8n.io>
Co-authored-by: Giulio Andreini <g.andreini@gmail.com>
Co-authored-by: Omar Ajoue <krynble@gmail.com>
2023-08-25 10:33:46 +02:00
कारतोफ्फेलस्क्रिप्ट™
72f65dcdd6
refactor(core): Do not import BaseCommand outside src/commands
(no-changelog) ( #7008 )
2023-08-25 00:17:00 +02:00
कारतोफ्फेलस्क्रिप्ट™
92d4befea6
fix(core): Fix AddMfaColumns migration for sqlite (no-changelog) ( #7006 )
...
When ever we have migrations that use `.addColumn` or `.dropColumn`,
typeorm recreates tables for sqlite. so, we need to disable foreign key
enforcement for sqlite, or else data in some tables can get deleted
because of `ON DELETE CASCADE`
[This has happened in the
past](https://github.com/n8n-io/n8n/pull/6739 ), and we should really
come up with a way to prevent this from happening again.
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Oleg Ivaniv <me@olegivaniv.com>
2023-08-24 09:31:37 -04:00
Ricardo Espinoza
2b7ba6fdf1
feat(core): Add MFA ( #4767 )
...
https://linear.app/n8n/issue/ADO-947/sync-branch-with-master-and-fix-fe-e2e-tets
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-08-23 22:59:16 -04:00
Iván Ovejero
8c38d85e76
fix(core): Fix import:workflow
command ( #6996 )
...
Ref: https://github.com/n8n-io/n8n/actions/runs/5946170960
To test:
```sh
./packages/cli/bin/n8n export:workflow --all --output=./all-workflows.json
./packages/cli/bin/n8n import:workflow --input=./all-workflows.json
```
2023-08-23 15:15:14 +02:00
Iván Ovejero
96a9de68a0
refactor(core): Move all user DB access to UserRepository
( #6910 )
...
Prep for https://linear.app/n8n/issue/PAY-646
2023-08-22 15:58:05 +02:00
Omar Ajoue
67b88f75f4
feat(core): Add a warning to error workflows that cannot be started due to permission or settings ( #6961 )
...
Github issue / Community forum post (link here to close automatically):
This PR aims to address an issue where an Error workflow cannot be
started, either due to insufficient permissions or because its settings
prevent it from being called.
The way of addressing this is by creating a failed execution for the
appointed error workflow stating the error, as can be seen below.
This means the execution itself won't start, as it's prevented before
the execution beings, but we save a "stub" execution to show the error.
![Screenshot 2023-08-17 at 16 17
02](https://github.com/n8n-io/n8n/assets/219272/d8ec0144-13c5-4b11-b91c-a6b440816ccf )
2023-08-22 15:26:33 +02:00
Iván Ovejero
2cfa6d344e
refactor: Consolidate WorkflowService.getMany()
(no-changelog) ( #6892 )
...
In scope:
- Consolidate `WorkflowService.getMany()`.
- Support non-entity field `ownedBy` for `select`.
- Support `tags` for `filter`.
- Move `addOwnerId` to `OwnershipService`.
- Remove unneeded check for `filter.id`.
- Simplify DTO validation for `filter` and `select`.
- Expand tests for `GET /workflows`.
Workflow list query DTOs:
```
filter → name, active, tags
select → id, name, active, tags, createdAt, updatedAt, versionId, ownedBy
```
Out of scope:
- Migrate `shared_workflow.roleId` and `shared_credential.roleId` to
string IDs.
- Refactor `WorkflowHelpers.getSharedWorkflowIds()`.
2023-08-22 13:19:37 +02:00
Iván Ovejero
9b9b891e68
refactor(core): Move remaining tags logic to service (no-changelog) ( #6920 )
...
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-08-22 12:24:43 +02:00
Michael Auerswald
7b96820218
fix(core): Add recoveryInProgress flag file ( #6962 )
...
Issue: during startup, unfinished executions trigger a recovery process
that, under certain circumstances, can in itself crash the instance
(e.g. by running our of memory), resulting in an infinite recovery loop
This PR aims to change this behaviour by writing a flag file when the
recovery process starts, and removing it when it finishes. In the case
of a crash, this flag will persist and upon the next attempt, the
recovery will instead do the absolute minimal (marking executions as
'crashed'), without attempting any 'crashable' actions.
2023-08-18 17:12:24 +02:00
Iván Ovejero
4fc69b776c
fix(core): Set up OAuth2 cred test ( #6960 )
...
https://linear.app/n8n/issue/PAY-728
2023-08-18 16:18:44 +02:00
Michael Auerswald
b6a00febbd
fix(core): Replace throw with warning when deactivating a non-active workflow ( #6969 )
...
Replaces a throw with a warning message instead, since the failure in
question is not serious enough to warrant stopping the application.
2023-08-18 14:04:49 +02:00
कारतोफ्फेलस्क्रिप्ट™
9455bcfef5
fix(Webhook Node): Backward compatible form-data parsing for non-array fields ( #6967 )
2023-08-18 12:34:42 +02:00
Ricardo Espinoza
270946a93b
feat: Remove PostHog event calls ( #6915 )
2023-08-17 11:39:32 -04:00
कारतोफ्फेलस्क्रिप्ट™
41c3cc89ca
refactor(core): Delete some duplicate code between ActiveWebhooks and ActiveWorkflowRunner (no-changelog) ( #6951 )
2023-08-17 17:18:14 +02:00
कारतोफ्फेलस्क्रिप्ट™
8f8a1de3dd
feat(core): Add support for ready hooks, and credentials overwrite endpoint in workers ( #6954 )
2023-08-17 15:42:57 +02:00
Iván Ovejero
413570c49d
feat(editor): Show banner for non-production licenses ( #6943 )
...
https://linear.app/n8n/issue/PAY-692
2023-08-17 14:00:17 +02:00
Iván Ovejero
7ce5d8fd90
refactor: Upgrade to Prettier 3 (no-changelog) ( #6947 )
...
Supersedes https://github.com/n8n-io/n8n/pull/6937
Excluding fixtures and test workflow JSONs to avoid having to update
tests.
2023-08-16 17:13:57 +02:00
कारतोफ्फेलस्क्रिप्ट™
bb76c18073
ci: Fix executeBatch command to fix workflow tests (no-changelog) ( #6946 )
...
This broke because [we started returning an explicit `undefined` on
error
descriptions](https://github.com/n8n-io/n8n/pull/6841/files#diff-ea9bff15fe880ac829cc642c7e72a25d2348e331e77fc060cbe11a6effb6aeaeR430 )
[Test
run](https://github.com/n8n-io/n8n/actions/runs/5879776481/job/15945235163 )
2023-08-16 16:53:17 +02:00
OlegIvaniv
fde6ad1e7f
feat(editor): Ask AI in Code node ( #6672 )
...
* feat(editor): Ask AI tab and CLi connection
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Remove old getSchema util method
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Increase CSS specificity of the CodeNodeEditor global overrides
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* feat(editor): Magic Connect
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Improve AI controller, load conditionally, UX modal imporvements
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Extract-out AI curl
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Move loading phrases to locale, add support for ask ai experiment
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix build
* adjust communication
* fix: Remove duplicate source control preferences fetching (no-changelog) (#6675 )
fix: remove duplicate source control preferences fetching (no-changelog)
* fix(Slack Node): Add UTM params to n8n reference in Slack message (no-changelog) (#6668 )
fix(Slack Node): Add UTM params to n8n reference in Slack message
* fix(FileMaker Node): Improve returned error responses (#6585 )
* fix(Microsoft Outlook Node): Fix issue with category not correctly applying (#6583 )
* feat(Airtable Node): Overhaul (#6200 )
* fix(core): Deleting manual executions should defer deleting binary data (#6680 )
deleting manual executions should defer deleting binary data
* fix(editor): Add paywall state to non owner users for Variables (#6679 )
* fix(editor): Add paywall state to non owner users for Variables
* fix(editor): Add variables view tests
* fix(editor): remove link from paywall state for non owner
* fix(editor): fix displaying logic
* refactor(core): Refactor WorkflowStatistics code (no-changelog) (#6617 )
refactor(core): Refactor WorkflowStatistics code
* fix(editor): Hide Execute Node button for unknown nodes (#6684 )
* feat: Allow hiding credential params on cloud (#6687 )
* fix: Stop n8n from complaining about credentials when saving a new workflow form a template (#6671 )
* fix(core): Upgrade semver to address CVE-2022-25883 (#6689 )
* fix(core): Upgrade semver to address CVE-2022-25883
[GH Advisory](https://github.com/advisories/GHSA-c2qf-rxjj-qqgw )
* enforce the patched version of semver everywhere in the dev setup
* ci: Fix test checker glob (no changelog) (#6682 )
ci: Fix test checker glob
* fix(API): Do not add starting node on workflow creation (#6686 )
* fix(API): Do not add starting node on workflow creation
* chore: Remove comment
* fix(core): Filter out workflows that failed to activate on startup (#6676 )
* fix(core): Deactivate on init workflow that should not be retried
* fix(core): Filter out workflows with activation errors
* fix(core): Load SAML libraries dynamically (#6690 )
load SAML dynamically
* fix(crowd.dev Node): Fix documentation urls for crowd.dev credentials and nodes (#6696 )
* feat(Read PDF Node): Replace pdf-parse with pdfjs, and add support for streaming and encrypted PDFs (#6640 )
* feat: Allow `eslint-config` to be externally consumable (#6694 )
* feat: Allow `eslint-config` to be externally consumable
* refactor: Adjust import styles
* fix(Contentful Node): Fix typo in credential name (no-changelog) (#6692 )
* fix(editor): Ensure default credential values are not detected as dirty state (#6677 )
* fix(editor): Ensure default credential values are not detected as dirty state
* chore: Remove logging
* refactor: Improve comment
* feat(Google Cloud Storage Node): Use streaming for file uploads (#6462 )
fix(Google Cloud Storage Node): Use streaming for file uploads
* fix(editor): Prevent RMC from loading schema if it's already cached (#6695 )
* fix(editor): Prevent RMC from loading schema if it's already cached
* ✅ Adding new tests for RMC
* 👕 Fixing lint errors
* 👌 Updating inline loader styling
* fix(API): Fix issue with workflow setting not supporting newer nanoids (#6699 )
* ci: Fix test workflows (no-changelog) (#6698 )
* ci: Fix test workflows (no-changelog)
We removed `pdf-parse` in #6640 , so we need to get these test PDF files from the `test-workflows` repo instead ([which has been updated to include these files](0f6ef1c804
))
* remove `\n` from ids and skipList text files
* fix(core): Banner dismissal should also work for users migrating to v1 (no-changelog) (#6700 )
* fix(Postgres Node): For select queries, empty result should be be replaced with `{"success":true}` (#6703 )
* fix(Postgres Node): For select queries, empty result should be be replaced with `{"success":true}`
* ⚡ less checks
---------
Co-authored-by: Michael Kret <michael.k@radency.com>
* feat(editor): Removing `ph-no-capture` class from some elements (#6674 )
* feat(editor): Remove `.ph-no-capture` class from some of the fields
* ✔️ Updating test snapshots
* ⚡ Redacting expressions preview in credentials form
* 🔧 Disable posthog input masking
* 🚨 Testing PostHog iFrame settings
* Reverting iframe test
* ⚡ Hiding API key in PostHog recordings
* ✅ Added tests for redacted values
* ✔️ Updating checkbox snapshots after label component update
* ✔️ Updating test snapshots in editor-ui
* 👕 Fix lint errors
* fix(editor): Remove global link styling in v1 banner (#6705 )
* fix: Add missing indices on sqlite (#6673 )
* fix: enforce tag name uniqueness on sqlite
* rename migration and add other missing indices
* add tags tests
* test: Move test timeout to `/cli` (no-changelog) (#6712 )
* fix(core): Redirect user to previous url after SSO signin (#6710 )
redirect user to previous url after SSO signin
* fix(FTP Node): List recursive ignore . and .. to prevent infinite loops (#6707 )
ignore . and .. to prevent infinite loop
Co-authored-by: Michael Kret <michael.k@radency.com>
* ci: Fix running e2e tests in dev mode (no-changelog) (#6717 )
* fix(Google BigQuery Node): Error description improvement (#6715 )
* fix(GitLab Trigger Node): Fix trigger activation 404 error (#6711 )
* fix webhook checkExists not deleting static data
* improve webhook checkExists not deleting static data
* fix(core): Support redis cluster in queue mode (#6708 )
* support redis cluster
* cleanup, fix config schema
* set default prefix to bull
* fix(editor): Skip error line highlighting if out of range (#6721 )
* fix(AwsS3 Node): Fix issue if bucket name contains a '.' (#6542 )
* test(editor): Add canvas actions E2E tests (#6723 )
* test(editor): Add canvas actions E2E tests
* test(editor): Open category items in node creator when category dropped on canvas
* test(editor): Have new position counted only once in drag
* test(editor): rename test
* feat(Rundeck Node): Add support for node filters (#5633 )
* fix(Gmail Trigger Node): Early returns in case of no data (#6727 )
* fix(core): Use JWT as reset password token (#6714 )
* use jwt to reset password
* increase expiration time to 1d
* drop user id query string
* refactor
* use service instead of package in tests
* sqlite migration
* postgres migration
* mysql migration
* remove unused properties
* remove userId from FE
* fix test for users.api
* move migration to the common folder
* move type assertion to the jwt.service
* Add jwt secret as a readonly property
* use signData instead of sign in user.controller
* remove base class
* remove base class
* add tests
* ci: Fix tests on postgres (no-changelog)
* refactor(core): Prevent community packages queries if feature is disabled (#6728 )
* feat(core): Add cache service (#6729 )
* add cache service
* PR adjustments
* switch to maxSize for memory cache
* Revert "test(editor): Add canvas actions E2E tests" (#6736 )
Revert "test(editor): Add canvas actions E2E tests (#6723 )"
This reverts commit 052d82b220
.
* fix(Postgres Node): Arrays in query replacement fix (#6718 )
* fix(Telegram Trigger Node): Add guard to 'include' call on null or undefined (#6730 )
* fix(core): Use `exec` in docker images to forward signals correctly (#6732 )
* refactor(core): Move webhook DB access to repository (no-changelog) (#6706 )
* refactor(core): Move webhook DB access to repository (no-changelog)
* make sure `DataSource` is initialized before it's dependencies
at some point I hope to replace `DataSource` with a custom `DatabaseConnection` service class that can then disconnect and reconnect from DB without having to update all repositories.
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
* feat: Environments release using source control (#6653 )
* initial telemetry setup and adjusted pull return
* quicksave before merge
* feat: add conflicting workflow list to pull modal
* feat: update source control pull modal
* fix: fix linting issue
* feat: add Enter keydown event for submitting source control push modal (no-changelog)
feat: add Enter keydown event for submitting source control push modal
* quicksave
* user workflow table for export
* improve telemetry data
* pull api telemetry
* fix lint
* Copy tweaks.
* remove authorName and authorEmail and pick from user
* rename owners.json to workflow_owners.json
* ignore credential conflicts on pull
* feat: several push/pull flow changes and design update
* pull and push return same data format
* fix: add One last step toast for successful pull
* feat: add up to date pull toast
* fix: add proper Learn more link for push and pull modals
* do not await tracking being sent
* fix import
* fix await
* add more sourcecontrolfile status
* Minor copy tweak for "More info".
* Minor copy tweak for "More info".
* ignore variable_stub conflicts on pull
* ignore whitespace differences
* do not show remote workflows that are not yet created
* fix telemetry
* fix toast when pulling deleted wf
* lint fix
* refactor and make some imports dynamic
* fix variable edit validation
* fix telemetry response
* improve telemetry
* fix unintenional delete commit
* fix status unknown issue
* fix up to date toast
* do not export active state and reapply versionid
* use update instead of upsert
* fix: show all workflows when clicking push to git
* feat: update Up to date pull translation
* fix: update read only env checks
* do not update versionid of only active flag changes
* feat: prevent access to new workflow and templates import when read only env
* feat: send only active state and version if workflow state is not dirty
* fix: Detect when only active state has changed and prevent generation a new version ID
* feat: improve readonly env messages
* make getPreferences public
* fix telemetry issue
* fix: add partial workflow update based on dirty state when changing active state
* update unit tests
* fix: remove unsaved changes check in readOnlyEnv
* fix: disable push to git button when read onyl env
* fix: update readonly toast duration
* fix: fix pinning and title input in protected mode
* initial commit (NOT working)
* working push
* cleanup and implement pull
* fix getstatus
* update import to new method
* var and tag diffs are no conflicts
* only show pull conflict for workflows
* refactor and ignore faulty credentials
* add sanitycheck for missing git folder
* prefer fetch over pull and limit depth to 1
* back to pull...
* fix setting branch on initial connect
* fix test
* remove clean workfolder
* refactor: Remove some unnecessary code
* Fixed links to docs.
* fix getstatus query params
* lint fix
* dialog to show local and remote name on conflict
* only show remote name on conflict
* fix credential expression export
* fix: Broken test
* dont show toast on pull with empty var/tags and refactor
* apply frontend changes from old branch
* fix tag with same name import
* fix buttons shown for non instance owners
* prepare local storage key for removal
* refactor: Change wording on pushing and pulling
* refactor: Change menu item
* test: Fix broken test
* Update packages/cli/src/environments/sourceControl/types/sourceControlPushWorkFolder.ts
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
---------
Co-authored-by: Alex Grozav <alex@grozav.com>
Co-authored-by: Giulio Andreini <g.andreini@gmail.com>
Co-authored-by: Omar Ajoue <krynble@gmail.com>
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* fix(core): Fix RemoveResetPasswordColumns migration for sqlite (no-changelog) (#6739 )
* ci: Update changelog generation to work with node 18
* refactor: Remove webhook from `IDatabaseCollections` (no-changelog) (#6745 )
* refactor: Remove webhook from `IDatabaseCollections`
* refactor: Remove also from `collections`
* 🚀 Release 1.1.0 (#6746 )
Co-authored-by: netroy <netroy@users.noreply.github.com>
* fix(Lemlist Node): Fix pagination issues with campaigns and activities (#6734 )
* ci: Fix linting issues (no-changelog) (#6747 )
* fix(core): Allow ignoring SSL issues on generic oauth2 credentials (#6702 )
* refactor: Remove all references to the resetPasswordToken field (no-changelog) (#6751 )
refactor: remove all references to the resetPasswordToken field (no-changelog)
* refactor(core): Use mixins to delete redundant code between Entity classes (no-changelog) (#6616 )
* db entities don't need an ID before they are inserted
* don't define constructors on entity classes, use repository.create instead
* use mixins to reduce duplicate code in db entity classes
* fix: Display source control buttons properly (#6756 )
* feat(editor): Migrate Design System and Editor UI to Vue 3 (#6476 )
* feat: remove vue-fragment (no-changelog)
* feat: partial design-system migration
* feat: migrate info-accordion and info-tip components
* feat: migrate several components to vue 3
* feat: migrated several components
* feat: migrate several components
* feat: migrate several components
* feat: migrate several components
* feat: re-exported all design system components
* fix: fix design for popper components
* fix: editor kind of working, lots of issues to fix
* fix: fix several vue 3 migration issues
* fix: replace @change with @update:modelValue in several places
* fix: fix translation linking
* fix: fix inline-edit input
* fix: fix ndv and dialog design
* fix: update parameter input event bindings
* fix: rename deprecated lifecycle methods
* fix: fix json view mapping
* build: update lock file
* fix(editor): revisit last conflict with master and fix issues
* fix(editor): revisit last conflict with master and fix issues
* fix: fix expression editor bug causing code mirror to no longer be reactive
* fix: fix resource locator bug
* fix: fix vue-agile integration
* fix: remove global import for vue-agile
* fix: replace element-plus buttons with n8n-buttons everywhere
* fix(editor): Fix various element-plus styles (#6571 )
* fix(editor): Fix various element-plus styles
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Remove debugging code
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Address PR comments
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix(editor): Fix loading in production mode [Vue 3] (#6578 )
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix(editor): First round of e2e tests fixes with Vue 3 (#6579 )
* fix(editor): Fix broken smoke and workflow list e2e tests
* ✔️ Fix failing canvas action tests. Updating some selectors used in credentials and workflow tests
* feat: add vue 3 eslint rules and fix issues
* fix: fix tags-dropdown
* fix: fix white-space issues caused by i18n-t
* fix: rename non-generic click events
* fix: fix search in resources list layout
* fix: fix datatable paginator
* fix: fix popper select caret and dropdown size
* fix: add width to action-dropdown
* fix: fix workflow settings icon not being hidden
* fix: refactor newly added code
* fix: fix merge issue
* fix: fix ndv credentials watcher
* fix: fix workflow saving and grabber notch
* fix: fix nodes list panel transition
* fix: fix node title visibility
* fix: fix data unpinning
* fix: fix value access
* fix: show input panel only if trigger panel enabled or not trigger node
* fix: fix tags dropdown and executions status spcing
* fix(editor): Prevent execution list to load back when leaving the route (#6697 )
fix(editor): prevent execution list to load back when leaving the route
* fix: fix drawer visibility
* fix: fix expression toggle padding
* fix: fix expressions editor styling
* chore: prepare for testing
* fix: fix styling for el-button without patching
* test: fix unit tests in design-system
* test: fix most unit tests
* fix: remove import cycle.
* fix: fix personalization modal tests
* fix further resource mapper test adjustments
* fix: fix multiple tests and n8n-route attr duplication
* fix: fix source control tets
* fix: fixed remaining unit tests
* fix: fix workflows and credentials e2e tests
* fix: fix localizeNodeNames
* fix: update ndv e2e tests
* fix: fix popper left placement arrow
* fix: fix 5-ndv e2e tests
* fix: fix 6-code-node e2e tests
* fix(editor): Drop click outside directive from NodeCreator (#6716 )
* fix(editor): Drop click outside directive from NodeCreator
* fix(editor): make sure mouseup outside is unbound at least before the component is unmounted
* fix: fix 10-settings-log-streaming e2e tests
* fix: fix node redrawing
* fix: fix tooltip buttons styling
* fix: fix varous e2e suites
* fix: fix 15-scheduler-node e2e suite
* fix: fix route watcher
* fix: fixed param name update and credential edit
* feat: update event names
* refactor: Remove deprecated `$data` (#6576 )
Co-authored-by: Alex Grozav <alex@grozav.com>
* fix: fix 17-sharing e2e suite
* fix: fix tags dropdown
* fix: fix tags manager
* fix(editor): move :deep selectors to a separate scoped style block
* fix: fix sticky component and inline text edit
* fix: update e2e tests
* fix: remove button override references
* fix(editor): Adjust spacing in templates for Vue 3 (#6744 )
* fix(editor): Adjust spacing in templates
* fix: Undo unneeded change
* fix: Undo unneeded change
* fix(editor): Adjust NDV height for Vue 3 (#6742 )
fix(editor): Adjust NDV height
* fix(editor): Restore collapsed sidebar items for Vue 3 (#6743 )
fix(editor): Restore collapsed sidebar items
* fix: fix linting issues
* fix: fix design-system deps
* fix: post-merge fixes
* fix: update tests
* fix: increase timeout for executionslist tets
* chore: fix linting issue
* fix: fix 14-mapping e2e tests in ci
* fix: re-enable tests
* fix: fix workflow duplication e2e tests after tags update
* fix(editor): Change component prop to be typed
* fix: fix tags dropdown in duplicate wf modal
* fix: fix focus behaviour in tags selector
* fix: fix tag creation
* fix: fix log streaming e2e race condition
* fix(editor): Fix Vue 3 linting issues (#6748 )
* fix(editor): Fix Vue 3 linting issues
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix MainSidebar linter issues
* revert pnpm lock
* update pnpm lock file
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Alex Grozav <alex@grozav.com>
* fix(editor): Some css fixes for vue3 branch (#6749 )
* ✨ Fixing filter button height
* ✨ Update input modal button position
* ✨ Updating tags styling
* ✨ Fix event logging settings spacing
* 👕 Fixing lint errors
* fix: fix linting issues
* Revert to `// eslint-disable-next-line @typescript-eslint/no-misused-promises` disabling of mixins init
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix: fix css issue
* fix(editor): Lint fix
* fix(editor): Fix settings initialisation (#6750 )
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix: fix initial settings loading
* fix: replace realClick with click force
* fix: fix randomly failing mapping e2e tests
* fix(editor): Fix menu item event handling
* fix: fix resource filters dropdown events (#6752 )
* fix: fix resource filters dropdown events
* fix: remove teleported:false
* fix: fix event selection event naming (#6753 )
* fix: removed console.log (#6754 )
* fix: rever await nextTick changes
* fix: redo linting changes
* fix(editor): Redraw node connections if adding more than one node to canvas (#6755 )
* fix(editor): Redraw node connections if adding more than one node to canvas
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Update position before connection two nodes
* Lint fix
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Alex Grozav <alex@grozav.com>
* fix(editor): Fix `ResourceMapper` unit tests (#6758 )
* ✔️ Fix matching columns test
* ✔️ Fix multiple matching columns test
* ✔️ Removing `skip` from the last test
* fix: Allow pasting a big workflow (#6760 )
* fix: pasting a big workflow
* chore: update comment
* refactor: move try/catch to function
* refactor: move try/catch to function
* fix(editor): Fix modal layer width
* fix: fix position changes
* fix: undo it.only
* fix: make undo/redo multiple steps more verbose
* fix: Fix value survey styles (#6764 )
* fix: fix value survey styles
* fix: lint
* Revert "fix: lint"
72869c431f
* fix: lint
* fix(editor): Fix collapsed sub menu
* fix: Fix drawer animation (#6767 )
fix: drawer animation
* fix(editor): Fix source control buttons (#6769 )
* fix(editor): Fix App loading & auth (#6768 )
* fix(editor): Fix App loading & auth
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Await promises
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Fix eslint error
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Csaba Tuncsik <csaba@n8n.io>
Co-authored-by: OlegIvaniv <me@olegivaniv.com>
Co-authored-by: Milorad FIlipović <milorad@n8n.io>
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
Co-authored-by: Mutasem Aldmour <4711238+mutdmour@users.noreply.github.com>
* perf(editor): Memoize locale translate calls during actions generation (#6773 )
performance(editor): Memoize locale translate calls during actions generation
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix(editor): Close tags dropdown when modal is opened (#6766 )
* feat: remove vue-fragment (no-changelog)
* feat: partial design-system migration
* feat: migrate info-accordion and info-tip components
* feat: migrate several components to vue 3
* feat: migrated several components
* feat: migrate several components
* feat: migrate several components
* feat: migrate several components
* feat: re-exported all design system components
* fix: fix design for popper components
* fix: editor kind of working, lots of issues to fix
* fix: fix several vue 3 migration issues
* fix: replace @change with @update:modelValue in several places
* fix: fix translation linking
* fix: fix inline-edit input
* fix: fix ndv and dialog design
* fix: update parameter input event bindings
* fix: rename deprecated lifecycle methods
* fix: fix json view mapping
* build: update lock file
* fix(editor): revisit last conflict with master and fix issues
* fix(editor): revisit last conflict with master and fix issues
* fix: fix expression editor bug causing code mirror to no longer be reactive
* fix: fix resource locator bug
* fix: fix vue-agile integration
* fix: remove global import for vue-agile
* fix: replace element-plus buttons with n8n-buttons everywhere
* fix(editor): Fix various element-plus styles (#6571 )
* fix(editor): Fix various element-plus styles
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Remove debugging code
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Address PR comments
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix(editor): Fix loading in production mode [Vue 3] (#6578 )
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix(editor): First round of e2e tests fixes with Vue 3 (#6579 )
* fix(editor): Fix broken smoke and workflow list e2e tests
* ✔️ Fix failing canvas action tests. Updating some selectors used in credentials and workflow tests
* feat: add vue 3 eslint rules and fix issues
* fix: fix tags-dropdown
* fix: fix white-space issues caused by i18n-t
* fix: rename non-generic click events
* fix: fix search in resources list layout
* fix: fix datatable paginator
* fix: fix popper select caret and dropdown size
* fix: add width to action-dropdown
* fix: fix workflow settings icon not being hidden
* fix: refactor newly added code
* fix: fix merge issue
* fix: fix ndv credentials watcher
* fix: fix workflow saving and grabber notch
* fix: fix nodes list panel transition
* fix: fix node title visibility
* fix: fix data unpinning
* fix: fix value access
* fix: show input panel only if trigger panel enabled or not trigger node
* fix: fix tags dropdown and executions status spcing
* fix(editor): Prevent execution list to load back when leaving the route (#6697 )
fix(editor): prevent execution list to load back when leaving the route
* fix: fix drawer visibility
* fix: fix expression toggle padding
* fix: fix expressions editor styling
* chore: prepare for testing
* fix: fix styling for el-button without patching
* test: fix unit tests in design-system
* test: fix most unit tests
* fix: remove import cycle.
* fix: fix personalization modal tests
* fix further resource mapper test adjustments
* fix: fix multiple tests and n8n-route attr duplication
* fix: fix source control tets
* fix: fixed remaining unit tests
* fix: fix workflows and credentials e2e tests
* fix: fix localizeNodeNames
* fix: update ndv e2e tests
* fix: fix popper left placement arrow
* fix: fix 5-ndv e2e tests
* fix: fix 6-code-node e2e tests
* fix(editor): Drop click outside directive from NodeCreator (#6716 )
* fix(editor): Drop click outside directive from NodeCreator
* fix(editor): make sure mouseup outside is unbound at least before the component is unmounted
* fix: fix 10-settings-log-streaming e2e tests
* fix: fix node redrawing
* fix: fix tooltip buttons styling
* fix: fix varous e2e suites
* fix: fix 15-scheduler-node e2e suite
* fix: fix route watcher
* fix: fixed param name update and credential edit
* feat: update event names
* refactor: Remove deprecated `$data` (#6576 )
Co-authored-by: Alex Grozav <alex@grozav.com>
* fix: fix 17-sharing e2e suite
* fix: fix tags dropdown
* fix: fix tags manager
* fix(editor): move :deep selectors to a separate scoped style block
* fix: fix sticky component and inline text edit
* fix: update e2e tests
* fix: remove button override references
* fix(editor): Adjust spacing in templates for Vue 3 (#6744 )
* fix(editor): Adjust spacing in templates
* fix: Undo unneeded change
* fix: Undo unneeded change
* fix(editor): Adjust NDV height for Vue 3 (#6742 )
fix(editor): Adjust NDV height
* fix(editor): Restore collapsed sidebar items for Vue 3 (#6743 )
fix(editor): Restore collapsed sidebar items
* fix: fix linting issues
* fix: fix design-system deps
* fix: post-merge fixes
* fix: update tests
* fix: increase timeout for executionslist tets
* chore: fix linting issue
* fix: fix 14-mapping e2e tests in ci
* fix: re-enable tests
* fix: fix workflow duplication e2e tests after tags update
* fix(editor): Change component prop to be typed
* fix: fix tags dropdown in duplicate wf modal
* fix: fix focus behaviour in tags selector
* fix: fix tag creation
* fix: fix log streaming e2e race condition
* fix(editor): Fix Vue 3 linting issues (#6748 )
* fix(editor): Fix Vue 3 linting issues
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix MainSidebar linter issues
* revert pnpm lock
* update pnpm lock file
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Alex Grozav <alex@grozav.com>
* fix(editor): Some css fixes for vue3 branch (#6749 )
* ✨ Fixing filter button height
* ✨ Update input modal button position
* ✨ Updating tags styling
* ✨ Fix event logging settings spacing
* 👕 Fixing lint errors
* fix: fix linting issues
* Revert to `// eslint-disable-next-line @typescript-eslint/no-misused-promises` disabling of mixins init
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix: fix css issue
* fix(editor): Lint fix
* fix(editor): Fix settings initialisation (#6750 )
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix: fix initial settings loading
* fix: replace realClick with click force
* fix: fix randomly failing mapping e2e tests
* fix(editor): Fix menu item event handling
* fix: fix resource filters dropdown events (#6752 )
* fix: fix resource filters dropdown events
* fix: remove teleported:false
* fix: fix event selection event naming (#6753 )
* fix: removed console.log (#6754 )
* fix: rever await nextTick changes
* fix: redo linting changes
* fix(editor): Redraw node connections if adding more than one node to canvas (#6755 )
* fix(editor): Redraw node connections if adding more than one node to canvas
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Update position before connection two nodes
* Lint fix
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Alex Grozav <alex@grozav.com>
* fix(editor): Fix `ResourceMapper` unit tests (#6758 )
* ✔️ Fix matching columns test
* ✔️ Fix multiple matching columns test
* ✔️ Removing `skip` from the last test
* fix: Allow pasting a big workflow (#6760 )
* fix: pasting a big workflow
* chore: update comment
* refactor: move try/catch to function
* refactor: move try/catch to function
* fix(editor): Fix modal layer width
* fix: fix position changes
* fix: undo it.only
* fix: make undo/redo multiple steps more verbose
* fix: Fix value survey styles (#6764 )
* fix: fix value survey styles
* fix: lint
* Revert "fix: lint"
72869c431f
* fix: lint
* fix(editor): Close tags dropdown when modal is opened
* ✔️ Updating tag selectors in e2e tests
* ✔️ Using tab to blur dropdown after adding tags
* ✔️ Clicking on the New Tab button instead of the tags dropdown to open it
* Reverting merge changes added by mistake
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Alex Grozav <alex@grozav.com>
Co-authored-by: Csaba Tuncsik <csaba@n8n.io>
Co-authored-by: OlegIvaniv <me@olegivaniv.com>
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
Co-authored-by: Mutasem Aldmour <4711238+mutdmour@users.noreply.github.com>
* fix: Show NodeIcon tooltips by removing pointer-events: none (#6777 )
fix: show NodeIcon tooltips by removing pointer-events: none
* fix: Respect set modal widths (#6771 )
* feat: remove vue-fragment (no-changelog)
* feat: partial design-system migration
* feat: migrate info-accordion and info-tip components
* feat: migrate several components to vue 3
* feat: migrated several components
* feat: migrate several components
* feat: migrate several components
* feat: migrate several components
* feat: re-exported all design system components
* fix: fix design for popper components
* fix: editor kind of working, lots of issues to fix
* fix: fix several vue 3 migration issues
* fix: replace @change with @update:modelValue in several places
* fix: fix translation linking
* fix: fix inline-edit input
* fix: fix ndv and dialog design
* fix: update parameter input event bindings
* fix: rename deprecated lifecycle methods
* fix: fix json view mapping
* build: update lock file
* fix(editor): revisit last conflict with master and fix issues
* fix(editor): revisit last conflict with master and fix issues
* fix: fix expression editor bug causing code mirror to no longer be reactive
* fix: fix resource locator bug
* fix: fix vue-agile integration
* fix: remove global import for vue-agile
* fix: replace element-plus buttons with n8n-buttons everywhere
* fix(editor): Fix various element-plus styles (#6571 )
* fix(editor): Fix various element-plus styles
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Remove debugging code
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Address PR comments
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix(editor): Fix loading in production mode [Vue 3] (#6578 )
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix(editor): First round of e2e tests fixes with Vue 3 (#6579 )
* fix(editor): Fix broken smoke and workflow list e2e tests
* ✔️ Fix failing canvas action tests. Updating some selectors used in credentials and workflow tests
* feat: add vue 3 eslint rules and fix issues
* fix: fix tags-dropdown
* fix: fix white-space issues caused by i18n-t
* fix: rename non-generic click events
* fix: fix search in resources list layout
* fix: fix datatable paginator
* fix: fix popper select caret and dropdown size
* fix: add width to action-dropdown
* fix: fix workflow settings icon not being hidden
* fix: refactor newly added code
* fix: fix merge issue
* fix: fix ndv credentials watcher
* fix: fix workflow saving and grabber notch
* fix: fix nodes list panel transition
* fix: fix node title visibility
* fix: fix data unpinning
* fix: fix value access
* fix: show input panel only if trigger panel enabled or not trigger node
* fix: fix tags dropdown and executions status spcing
* fix(editor): Prevent execution list to load back when leaving the route (#6697 )
fix(editor): prevent execution list to load back when leaving the route
* fix: fix drawer visibility
* fix: fix expression toggle padding
* fix: fix expressions editor styling
* chore: prepare for testing
* fix: fix styling for el-button without patching
* test: fix unit tests in design-system
* test: fix most unit tests
* fix: remove import cycle.
* fix: fix personalization modal tests
* fix further resource mapper test adjustments
* fix: fix multiple tests and n8n-route attr duplication
* fix: fix source control tets
* fix: fixed remaining unit tests
* fix: fix workflows and credentials e2e tests
* fix: fix localizeNodeNames
* fix: update ndv e2e tests
* fix: fix popper left placement arrow
* fix: fix 5-ndv e2e tests
* fix: fix 6-code-node e2e tests
* fix(editor): Drop click outside directive from NodeCreator (#6716 )
* fix(editor): Drop click outside directive from NodeCreator
* fix(editor): make sure mouseup outside is unbound at least before the component is unmounted
* fix: fix 10-settings-log-streaming e2e tests
* fix: fix node redrawing
* fix: fix tooltip buttons styling
* fix: fix varous e2e suites
* fix: fix 15-scheduler-node e2e suite
* fix: fix route watcher
* fix: fixed param name update and credential edit
* feat: update event names
* refactor: Remove deprecated `$data` (#6576 )
Co-authored-by: Alex Grozav <alex@grozav.com>
* fix: fix 17-sharing e2e suite
* fix: fix tags dropdown
* fix: fix tags manager
* fix(editor): move :deep selectors to a separate scoped style block
* fix: fix sticky component and inline text edit
* fix: update e2e tests
* fix: remove button override references
* fix(editor): Adjust spacing in templates for Vue 3 (#6744 )
* fix(editor): Adjust spacing in templates
* fix: Undo unneeded change
* fix: Undo unneeded change
* fix(editor): Adjust NDV height for Vue 3 (#6742 )
fix(editor): Adjust NDV height
* fix(editor): Restore collapsed sidebar items for Vue 3 (#6743 )
fix(editor): Restore collapsed sidebar items
* fix: fix linting issues
* fix: fix design-system deps
* fix: post-merge fixes
* fix: update tests
* fix: increase timeout for executionslist tets
* chore: fix linting issue
* fix: fix 14-mapping e2e tests in ci
* fix: re-enable tests
* fix: fix workflow duplication e2e tests after tags update
* fix(editor): Change component prop to be typed
* fix: fix tags dropdown in duplicate wf modal
* fix: fix focus behaviour in tags selector
* fix: fix tag creation
* fix: fix log streaming e2e race condition
* fix(editor): Fix Vue 3 linting issues (#6748 )
* fix(editor): Fix Vue 3 linting issues
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix MainSidebar linter issues
* revert pnpm lock
* update pnpm lock file
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Alex Grozav <alex@grozav.com>
* fix(editor): Some css fixes for vue3 branch (#6749 )
* ✨ Fixing filter button height
* ✨ Update input modal button position
* ✨ Updating tags styling
* ✨ Fix event logging settings spacing
* 👕 Fixing lint errors
* fix: fix linting issues
* Revert to `// eslint-disable-next-line @typescript-eslint/no-misused-promises` disabling of mixins init
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix: fix css issue
* fix(editor): Lint fix
* fix(editor): Fix settings initialisation (#6750 )
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix: fix initial settings loading
* fix: replace realClick with click force
* fix: fix randomly failing mapping e2e tests
* fix(editor): Fix menu item event handling
* fix: fix resource filters dropdown events (#6752 )
* fix: fix resource filters dropdown events
* fix: remove teleported:false
* fix: fix event selection event naming (#6753 )
* fix: removed console.log (#6754 )
* fix: rever await nextTick changes
* fix: redo linting changes
* fix(editor): Redraw node connections if adding more than one node to canvas (#6755 )
* fix(editor): Redraw node connections if adding more than one node to canvas
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Update position before connection two nodes
* Lint fix
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Alex Grozav <alex@grozav.com>
* fix(editor): Fix `ResourceMapper` unit tests (#6758 )
* ✔️ Fix matching columns test
* ✔️ Fix multiple matching columns test
* ✔️ Removing `skip` from the last test
* fix: Allow pasting a big workflow (#6760 )
* fix: pasting a big workflow
* chore: update comment
* refactor: move try/catch to function
* refactor: move try/catch to function
* fix(editor): Fix modal layer width
* fix: fix position changes
* fix: undo it.only
* fix: make undo/redo multiple steps more verbose
* fix: Fix value survey styles (#6764 )
* fix: fix value survey styles
* fix: lint
* Revert "fix: lint"
72869c431f
* fix: lint
* fix(editor): Fix collapsed sub menu
* fix: Fix drawer animation (#6767 )
fix: drawer animation
* fix(editor): Fix source control buttons (#6769 )
* fix: Respect modal width
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Alex Grozav <alex@grozav.com>
Co-authored-by: Csaba Tuncsik <csaba@n8n.io>
Co-authored-by: OlegIvaniv <me@olegivaniv.com>
Co-authored-by: Milorad FIlipović <milorad@n8n.io>
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* fix(editor): Fix tooltip opening delay prop name (#6776 )
fix(editor): fix tooltip opening delay prop name
* fix(editor): Fix collapsed sub menu elements (#6778 )
* fix: Remove number input arrows (no-changelog) (#6782 )
fix: remove number input arrows
* ci: Update most of the dev tooling (no-changelog) (#6780 )
* fix(TheHive Node): Treat `ApiKey` as a secret (#6786 )
* test(editor): Prevent node view unload by default in e2e run (#6787 )
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix(editor): Resolve vue 3 related console-warnings (#6779 )
* fix(editor): Resolve vue 3 related console-warnings
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Use span as component wrapper instead of div
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Wrap popover component in span
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix(editor): Vue3 - Fix modal positioning and multi-select tag sizing (#6783 )
* ✨ Updating modals positioning within the overlay
* 💄 Implemented multi-select variant with small tabs
* ✔️ Removing password link clicks while modal is open in e2e tests
* Set generous timeout for $paramter resolve
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Oleg Ivaniv <me@olegivaniv.com>
* ci: Fix linting issues (no-changelog) (#6788 )
* ci: Fix linting (no-changelog)
* lintfix for nodes-base as well
* fix(editor): Fix code node highlight error (#6791 )
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* feat(core): Credentials for popular SecOps services, Part 1 (#6775 )
* refactor: Clear unused ESLint directives from BE packages (no-changelog) (#6798 )
* refactor(core): Cache workflow ownership (#6738 )
* refactor: Set up ownership service
* refactor: Specify cache keys and values
* refactor: Replace util with service calls
* test: Mock service in tests
* refactor: Use dependency injection
* test: Write tests
* refactor: Apply feedback from Omar and Micha
* test: Fix tests
* test: Fix missing spot
* refactor: Return user entity from cache
* refactor: More dependency injection!
* fix(editor): Prevent text edit dialog from re-opening in same tick (#6781 )
* fix: prevent reopenning textedit dialog in same tick
* fix: add same logic for code edit dialog
* fix: remove stop modifier
* fix: blur input field when closing modal, removing default element-plus behaviour
* test(editor): Do not chain invoke calls after assertions in 24-ndv-paired-item e2e spec (no-changelog) (#6800 )
* test(editor): Do not chaing invoke calls after assertions in 24-ndv-paired-item e2e spec
* Do not chaing realHover after assertion
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Remove .only
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix(Todoist Node): Fix issue with section id being ignored (#6799 )
* test(editor): Add canvas actions E2E tests (#6723 ) (#6790 )
* test(editor): Add canvas actions E2E tests (#6723 )
* test(editor): Add canvas actions E2E tests
* test(editor): Open category items in node creator when category dropped on canvas
* test(editor): Have new position counted only once in drag
* test(editor): rename test
(cherry picked from commit 052d82b220
)
* test: fix drag positioning
* fix(core): Add missing primary key on the `execution_data` table on postgres (#6797 )
* fix: Review fixes
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix: Fin locales
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Fix merging errors
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Map erros based on statusCode
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Fix code replacing
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Fix code formatting
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Address review points
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Optionally access total_tokens
* Clean-up Ask AI modal
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Store prompt in sessionStorage
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Improve schema generation, only get parent nodes
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Send error messages to telemetry, aske before switching tabs
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Add locale
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Post-merge cleanup
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Move Ask AI into separate folder
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Lint fix
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Constants lint fix
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Add Ask AI e2e tests and fix linting issues
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Move CircleLoader to design-lib
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Replace circle-lodaer and move el-tabs styles to n8n theme
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Fix placeholder & e2e tests
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Remove old CircleLoader
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: ricardo <ricardoespinoza105@gmail.com>
Co-authored-by: Alex Grozav <alex@grozav.com>
Co-authored-by: Romain Dunand <romain@1-more-thing.com>
Co-authored-by: Jon <jonathan.bennetts@gmail.com>
Co-authored-by: Michael Kret <88898367+michael-radency@users.noreply.github.com>
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <netroy@users.noreply.github.com>
Co-authored-by: Csaba Tuncsik <csaba@n8n.io>
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
Co-authored-by: Omar Ajoue <krynble@gmail.com>
Co-authored-by: Michael Auerswald <michael.auerswald@gmail.com>
Co-authored-by: Milorad FIlipović <milorad@n8n.io>
Co-authored-by: Michael Kret <michael.k@radency.com>
Co-authored-by: Val <68596159+valya@users.noreply.github.com>
Co-authored-by: Marcus <56945030+maspio@users.noreply.github.com>
Co-authored-by: Jordan Hall <Jordan@libertyware.co.uk>
Co-authored-by: qg-horie <36725144+qg-horie@users.noreply.github.com>
Co-authored-by: Ricardo Espinoza <ricardo@n8n.io>
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
Co-authored-by: Ali Afsharzadeh <afsharzadeh8@gmail.com>
Co-authored-by: Giulio Andreini <g.andreini@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Mutasem Aldmour <4711238+mutdmour@users.noreply.github.com>
2023-08-16 13:08:10 +02:00
Cornelius Suermann
198a977f57
feat(core): Show a banner when running a non-prod license (no-changelog) ( #6849 )
...
* add feat:showNonProdBanner
* fix linting
* fix linting
2023-08-16 10:05:03 +02:00
Xavier Calland
eead6d49f2
feat: Add support for not requiring SMTP auth with user management ( #3742 )
2023-08-15 09:55:58 +01:00
कारतोफ्फेलस्क्रिप्ट™
96ff1f847d
fix(HTTP Request Node): Improve error handling for TCP socket errors when Continue On Fail
is enabled ( #6925 )
2023-08-14 17:26:40 +02:00
कारतोफ्फेलस्क्रिप्ट™
a82107fb05
fix(Respond to Webhook Node): Return headers in response ( #6921 )
2023-08-14 12:38:17 +02:00
Omar Ajoue
139e08a549
fix: Add only necessary information to executions (no-changelog) ( #6916 )
...
* fix: Add only necessary information to executions
* Fix lint
* fix: lint issue
---------
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
2023-08-14 09:44:04 +02:00
कारतोफ्फेलस्क्रिप्ट™
10c15874b2
fix(core): Restore body parsing for all content-types for non webhook routes (no-changelog)( #6911 )
...
Changes in https://github.com/n8n-io/n8n/pull/6394 removed xml body parsing for all non-webhook routes. This broken SAML endpoints as they need the XML body parser to function correctly.
2023-08-11 09:18:33 +02:00
Michael Kret
7f0db60f15
refactor(core): Abstract away duplication when finding first pinned trigger (no-changelog) ( #5927 )
2023-08-10 15:06:16 +03:00
कारतोफ्फेलस्क्रिप्ट™
f3fce48155
fix(core): Fix fetching of EE executions ( #6901 )
...
fix(core): fix fetching of EE executions
2023-08-10 10:38:22 +02:00
कारतोफ्फेलस्क्रिप्ट™
718e61354d
fix(core): Update frontend urls when using the --tunnel
option ( #6898 )
...
fix(core): update frontend urls when using the `--tunnel` option
2023-08-09 19:07:45 +02:00
कारतोफ्फेलस्क्रिप्ट™
cfeb322b3b
fix(core): Don't let bull override the default redis config ( #6897 )
2023-08-09 18:10:58 +02:00
Omar Ajoue
3d2f4406d7
feat(core): Debug in Editor flag (no-changelog) ( #6888 )
...
* feat(cli): Debug in Editor flag (no-changelog)
* fix: Lint issue
* chore: Use correct lock version
* fix: Remove dependency cycle
2023-08-09 16:38:17 +02:00
कारतोफ्फेलस्क्रिप्ट™
6553d92c7c
fix(core): Log crash causes to console when sentry is disabled ( #6890 )
2023-08-09 13:29:57 +02:00
Iván Ovejero
dceff675ec
perf(core): Add filtering and pagination to GET /workflows
( #6845 )
...
* Initial setup
* Specify max paginated items
* Simplify
* Add tests
* Add more tests
* Add migrations
* Add top-level property
* Add field selection
* Cleanup
* Rename `total` to `count`
* More cleanup
* Move query logic into `WorkflowRepository`
* Create `AbstractRepository`
* Cleanup
* Fix name
* Remove leftover comments
* Replace reference
* Add default for `rawSkip`
* Remove unneeded typing
* Switch to `class-validator`
* Simplify
* Simplify
* Type as optional
* Make typing more accurate
* Fix lint
* Use `getOwnPropertyNames`
* Use DSL
* Set schema at repo level
* Cleanup
* Remove comment
* Refactor repository methods to middleware
* Add middleware tests
* Remove old test files
* Remove generic experiment
* Reuse `reportError`
* Remove unused type
* Cleanup
* Improve wording
* Reduce diff
* Add missing mw
* Use `Container.get`
* Adjust lint rule
* Reorganize into subdir
* Remove unused directive
* Remove nodes
* Silly mistake
* Validate take
* refactor(core): Adjust index handling in new migrations DSL (no-changelog) (#6876 )
* refactor(core): Adjust index handling in new migrations DSL (no-changelog)
* Account for custom index name
* Also for dropping
* Fix `select` issue with `relations`
* Tighten validation
* Ensure `ownerId` is not added when specifying `select`
2023-08-09 12:30:02 +02:00
Iván Ovejero
6796d9e5d6
fix(core): Add sharing data to workflows in EE executions ( #6872 )
...
* fix(core): Add sharing data to workflows in EE executions
* Address feedback
2023-08-08 14:28:05 +02:00
Iván Ovejero
11440bfd3c
refactor(core): Move tag collection into repository (no-changelog) ( #6860 )
...
* refactor(core): Move tag collection into repository
* Fix tests
* Address feedback
* Fix missing spot
2023-08-08 14:08:56 +02:00
Michael Auerswald
6499f42481
feat(core): Add unique id to instances ( #6863 )
...
* add serverId and workerId
* adjust id format
* fix logger init / test
* update implementation
2023-08-07 17:03:21 +02:00
Michael Auerswald
adcf5a96e8
feat(core): Add metrics option to cache ( #6846 )
...
* add metrics to cache
* use events for metrics
* pr comments / broken test
* lint fix
* update the test
* improve tests
* Update packages/cli/src/config/schema.ts
* disable flaky test
* lint fix
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <netroy@users.noreply.github.com>
2023-08-04 20:51:07 +02:00
Michael Auerswald
fdfc6c5a92
fix(core): Handle empty keys in cache service (no-changelog) ( #6854 )
...
* fix handle empty keys in cache service
* add test
* add cache mock test
* add simpler mocking, and add tests for all the updated methods
* don't use RedisStore specifically in the mock
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-08-04 19:44:41 +02:00
Michael Kret
5ab30fdd95
fix(core): OAuth1 authentication fix for Clever Cloud API ( #6847 )
2023-08-04 19:49:00 +03:00
कारतोफ्फेलस्क्रिप्ट™
75be1a9c0d
feat(core): Create a dsl for writing db agnostic migrations ( #6853 )
2023-08-04 17:49:02 +02:00
Jan Oberhauser
a8bfb46183
fix(core): Fix WebSocket close codes
2023-08-04 16:40:03 +02:00
Omar Ajoue
63ffe67dad
feat(core): Add workflow history initial setup (no-changelog) ( #6852 )
...
* feat: Add workflow history initial setup
* fix: Add feature to missing controller
2023-08-04 12:27:06 +02:00
Iván Ovejero
0511458d41
perf(core): Cache webhooks ( #6825 )
...
* refactor: Initial setup
* Refactor for clarity
* Comments to clarify
* More replacements
* Simplify with `fullPath`
* Fix tests
* Implement remaining methods
* chore: Fix misresolved conflicts
* Simplify syntax
* Reduce diff
* Minor cleanup
* Fix lint
* Inject dependency
* Improve typings
* Remove unused method
* Restore method
* Add comment
* Rename in test
* Restore comments
* Clean up dynamic webhook handling
* Clean up tests
* Remove redundant `cache` prefix
* fix: Correct `uniquePath` for dynamic webhooks
2023-08-04 11:52:45 +02:00
Nihaal Sangha
6ec7033bb7
fix(core): Fix source control name and email being switched ( #6839 )
2023-08-03 15:19:54 +02:00
Iván Ovejero
e4f041815a
perf(core): Cache roles ( #6803 )
...
* refactor: Create `RoleService`
* refactor: Refactor to use service
* refactor: Move `getUserRoleForWorkflow`
* refactor: Clear out old `RoleService`
* refactor: Consolidate utils into service
* refactor: Remove unused methods
* test: Add tests
* refactor: Remove redundant return types
* refactor: Missing utility
* chore: Remove commented out bit
* refactor: Make `Db.collections.Repository` inaccessible
* chore: Cleanup
* feat: Prepopulate cache
* chore: Remove logging
* fix: Account for tests where roles are undefined
* fix: Restore `prettier.prettierPath`
* test: Account for cache enabled and disabled
* fix: Restore `Role` in `Db.collections`
* refactor: Simplify by removing `orFail`
* refactor: Rename for clarity
* refactor: Use `cacheKey` for readability
* refactor: Validate role before creation
* refacator: Remove redundant `cache` prefix
* ci: Lint fix
* test: Fix e2e
2023-08-03 08:58:36 +02:00
Michael Auerswald
659ca26fe7
fix(core): Change VariablesService to DI and use caching ( #6827 )
...
* support redis cluster
* cleanup, fix config schema
* set default prefix to bull
* initial commit
* improve logging
* improve types and refactor
* list support and refactor
* fix redis service and tests
* add comment
* add redis and cache prefix
* use injection
* lint fix
* clean schema comments
* improve naming, tests, cluster client
* merge master
* cache returns unknown instead of T
* update cache service, tests and doc
* remove console.log
* VariablesService as DI, add caching, fix tests
* do not cache null or undefined values
* import fix
* more DI and remove collections
* fix merge
* lint fix
* rename to ~Cached
* fix test for CI
* fix ActiveWorkflowRunner test
2023-08-02 14:51:09 +02:00
Michael Auerswald
3cad60e918
feat(core): Make Redis available for backend communication ( #6719 )
...
* support redis cluster
* cleanup, fix config schema
* set default prefix to bull
* initial commit
* improve logging
* improve types and refactor
* list support and refactor
* fix redis service and tests
* add comment
* add redis and cache prefix
* use injection
* lint fix
* clean schema comments
* improve naming, tests, cluster client
* merge master
* cache returns unknown instead of T
* update cache service, tests and doc
* remove console.log
* do not cache null or undefined values
* fix merge
* lint fix
2023-08-02 12:51:25 +02:00
कारतोफ्फेलस्क्रिप्ट™
31d8f478ee
refactor(core): Parse Webhook request bodies on-demand ( #6394 )
...
Also,
1. Consistent CORS support ~on all three webhook types~ waiting webhooks never supported CORS. I'll fix that in another PR
2. [Fixes binary-data handling when request body is text, json, or xml](https://linear.app/n8n/issue/NODE-505/webhook-binary-data-handling-fails-for-textplain-files ).
3. Reduced number of middleware that each request has to go through.
4. Removed the need to maintain webhook endpoints in the auth-exception list.
5. Skip all middlewares (apart from `compression`) on Webhook routes.
6. move `multipart/form-data` support out of individual nodes
7. upgrade `formidable`
8. fix the filenames on binary-data in webhooks nodes
9. add unit tests and integration tests for webhook request handling, and increase test coverage
2023-08-01 17:32:30 +02:00
कारतोफ्फेलस्क्रिप्ट™
53e58b408a
fix(core): Fix loading of scoped-community packages ( #6807 )
...
fix(code): Fix loading of scoped-community packages
2023-07-31 17:55:16 +02:00
कारतोफ्फेलस्क्रिप्ट™
b7ca27afcf
refactor(core): Delete more redundant code across migrations (Part 1) (no-changelog) ( #6691 )
2023-07-31 17:35:53 +02:00
Michael Kret
f6bf9e9887
fix(core): Restrict read/write file paths access ( #6582 )
2023-07-31 15:20:39 +03:00
कारतोफ्फेलस्क्रिप्ट™
dc295ac5bf
fix(core): Add missing primary key on the execution_data
table on postgres ( #6797 )
2023-07-31 12:35:42 +02:00
Iván Ovejero
ffae8edce3
refactor(core): Cache workflow ownership ( #6738 )
...
* refactor: Set up ownership service
* refactor: Specify cache keys and values
* refactor: Replace util with service calls
* test: Mock service in tests
* refactor: Use dependency injection
* test: Write tests
* refactor: Apply feedback from Omar and Micha
* test: Fix tests
* test: Fix missing spot
* refactor: Return user entity from cache
* refactor: More dependency injection!
2023-07-31 11:37:09 +02:00
Iván Ovejero
72523462ea
refactor: Clear unused ESLint directives from BE packages (no-changelog) ( #6798 )
2023-07-31 11:00:48 +02:00
कारतोफ्फेलस्क्रिप्ट™
6fb8a9ee39
ci: Fix linting issues (no-changelog) ( #6788 )
...
* ci: Fix linting (no-changelog)
* lintfix for nodes-base as well
2023-07-28 18:28:17 +02:00
कारतोफ्फेलस्क्रिप्ट™
dc2ba743eb
refactor(core): Use mixins to delete redundant code between Entity classes (no-changelog) ( #6616 )
...
* db entities don't need an ID before they are inserted
* don't define constructors on entity classes, use repository.create instead
* use mixins to reduce duplicate code in db entity classes
2023-07-27 11:53:37 +02:00
कारतोफ्फेलस्क्रिप्ट™
e6903a87b5
refactor: Remove all references to the resetPasswordToken field (no-changelog) ( #6751 )
...
refactor: remove all references to the resetPasswordToken field (no-changelog)
2023-07-27 11:53:25 +02:00
कारतोफ्फेलस्क्रिप्ट™
feac369f6c
fix(core): Allow ignoring SSL issues on generic oauth2 credentials ( #6702 )
2023-07-26 17:56:59 +02:00
कारतोफ्फेलस्क्रिप्ट™
db3c12ffc7
ci: Fix linting issues (no-changelog) ( #6747 )
2023-07-26 13:47:54 +02:00
Iván Ovejero
40d7419821
refactor: Remove webhook from IDatabaseCollections
(no-changelog) ( #6745 )
...
* refactor: Remove webhook from `IDatabaseCollections`
* refactor: Remove also from `collections`
2023-07-26 11:58:38 +02:00
कारतोफ्फेलस्क्रिप्ट™
1438a737b3
fix(core): Fix RemoveResetPasswordColumns migration for sqlite (no-changelog) ( #6739 )
2023-07-26 09:39:15 +02:00
Michael Auerswald
fc7aa8bd66
feat: Environments release using source control ( #6653 )
...
* initial telemetry setup and adjusted pull return
* quicksave before merge
* feat: add conflicting workflow list to pull modal
* feat: update source control pull modal
* fix: fix linting issue
* feat: add Enter keydown event for submitting source control push modal (no-changelog)
feat: add Enter keydown event for submitting source control push modal
* quicksave
* user workflow table for export
* improve telemetry data
* pull api telemetry
* fix lint
* Copy tweaks.
* remove authorName and authorEmail and pick from user
* rename owners.json to workflow_owners.json
* ignore credential conflicts on pull
* feat: several push/pull flow changes and design update
* pull and push return same data format
* fix: add One last step toast for successful pull
* feat: add up to date pull toast
* fix: add proper Learn more link for push and pull modals
* do not await tracking being sent
* fix import
* fix await
* add more sourcecontrolfile status
* Minor copy tweak for "More info".
* Minor copy tweak for "More info".
* ignore variable_stub conflicts on pull
* ignore whitespace differences
* do not show remote workflows that are not yet created
* fix telemetry
* fix toast when pulling deleted wf
* lint fix
* refactor and make some imports dynamic
* fix variable edit validation
* fix telemetry response
* improve telemetry
* fix unintenional delete commit
* fix status unknown issue
* fix up to date toast
* do not export active state and reapply versionid
* use update instead of upsert
* fix: show all workflows when clicking push to git
* feat: update Up to date pull translation
* fix: update read only env checks
* do not update versionid of only active flag changes
* feat: prevent access to new workflow and templates import when read only env
* feat: send only active state and version if workflow state is not dirty
* fix: Detect when only active state has changed and prevent generation a new version ID
* feat: improve readonly env messages
* make getPreferences public
* fix telemetry issue
* fix: add partial workflow update based on dirty state when changing active state
* update unit tests
* fix: remove unsaved changes check in readOnlyEnv
* fix: disable push to git button when read onyl env
* fix: update readonly toast duration
* fix: fix pinning and title input in protected mode
* initial commit (NOT working)
* working push
* cleanup and implement pull
* fix getstatus
* update import to new method
* var and tag diffs are no conflicts
* only show pull conflict for workflows
* refactor and ignore faulty credentials
* add sanitycheck for missing git folder
* prefer fetch over pull and limit depth to 1
* back to pull...
* fix setting branch on initial connect
* fix test
* remove clean workfolder
* refactor: Remove some unnecessary code
* Fixed links to docs.
* fix getstatus query params
* lint fix
* dialog to show local and remote name on conflict
* only show remote name on conflict
* fix credential expression export
* fix: Broken test
* dont show toast on pull with empty var/tags and refactor
* apply frontend changes from old branch
* fix tag with same name import
* fix buttons shown for non instance owners
* prepare local storage key for removal
* refactor: Change wording on pushing and pulling
* refactor: Change menu item
* test: Fix broken test
* Update packages/cli/src/environments/sourceControl/types/sourceControlPushWorkFolder.ts
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
---------
Co-authored-by: Alex Grozav <alex@grozav.com>
Co-authored-by: Giulio Andreini <g.andreini@gmail.com>
Co-authored-by: Omar Ajoue <krynble@gmail.com>
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
2023-07-26 09:25:01 +02:00
Iván Ovejero
bcfc5e717b
refactor(core): Move webhook DB access to repository (no-changelog) ( #6706 )
...
* refactor(core): Move webhook DB access to repository (no-changelog)
* make sure `DataSource` is initialized before it's dependencies
at some point I hope to replace `DataSource` with a custom `DatabaseConnection` service class that can then disconnect and reconnect from DB without having to update all repositories.
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-07-25 18:17:34 +02:00
Michael Auerswald
c0d2bac94d
feat(core): Add cache service ( #6729 )
...
* add cache service
* PR adjustments
* switch to maxSize for memory cache
2023-07-25 11:56:38 +02:00
Iván Ovejero
e1e6d4a749
refactor(core): Prevent community packages queries if feature is disabled ( #6728 )
2023-07-25 10:22:32 +02:00
Ricardo Espinoza
89f44021b9
fix(core): Use JWT as reset password token ( #6714 )
...
* use jwt to reset password
* increase expiration time to 1d
* drop user id query string
* refactor
* use service instead of package in tests
* sqlite migration
* postgres migration
* mysql migration
* remove unused properties
* remove userId from FE
* fix test for users.api
* move migration to the common folder
* move type assertion to the jwt.service
* Add jwt secret as a readonly property
* use signData instead of sign in user.controller
* remove base class
* remove base class
* add tests
2023-07-24 17:40:17 -04:00
Michael Auerswald
4029386349
fix(core): Support redis cluster in queue mode ( #6708 )
...
* support redis cluster
* cleanup, fix config schema
* set default prefix to bull
2023-07-21 23:31:52 +02:00
Michael Auerswald
08331c63fb
fix(core): Redirect user to previous url after SSO signin ( #6710 )
...
redirect user to previous url after SSO signin
2023-07-20 17:23:29 +02:00
Val
b1838f7fab
fix: Add missing indices on sqlite ( #6673 )
...
* fix: enforce tag name uniqueness on sqlite
* rename migration and add other missing indices
* add tags tests
2023-07-20 10:34:45 +01:00
कारतोफ्फेलस्क्रिप्ट™
8bb7243c2d
fix(core): Banner dismissal should also work for users migrating to v1 (no-changelog) ( #6700 )
2023-07-19 15:59:49 +02:00
कारतोफ्फेलस्क्रिप्ट™
cc29c4da74
ci: Fix test workflows (no-changelog) ( #6698 )
...
* ci: Fix test workflows (no-changelog)
We removed `pdf-parse` in #6640 , so we need to get these test PDF files from the `test-workflows` repo instead ([which has been updated to include these files](0f6ef1c804
))
* remove `\n` from ids and skipList text files
2023-07-19 14:15:38 +02:00
Jon
c7e10130d6
fix(API): Fix issue with workflow setting not supporting newer nanoids ( #6699 )
2023-07-19 13:02:35 +01:00
Michael Auerswald
fce5609fa3
fix(core): Load SAML libraries dynamically ( #6690 )
...
load SAML dynamically
2023-07-18 16:01:56 +02:00
Iván Ovejero
667c15d0df
fix(core): Filter out workflows that failed to activate on startup ( #6676 )
...
* fix(core): Deactivate on init workflow that should not be retried
* fix(core): Filter out workflows with activation errors
2023-07-18 15:57:14 +02:00
Iván Ovejero
92192fbd61
fix(API): Do not add starting node on workflow creation ( #6686 )
...
* fix(API): Do not add starting node on workflow creation
* chore: Remove comment
2023-07-18 14:03:19 +02:00
कारतोफ्फेलस्क्रिप्ट™
f4a18ba87d
refactor(core): Refactor WorkflowStatistics code (no-changelog) ( #6617 )
...
refactor(core): Refactor WorkflowStatistics code
2023-07-18 11:28:24 +02:00
कारतोफ्फेलस्क्रिप्ट™
462a674d17
fix(core): Deleting manual executions should defer deleting binary data ( #6680 )
...
deleting manual executions should defer deleting binary data
2023-07-18 10:51:22 +02:00
Milorad FIlipović
028c899166
fix(editor): Fix mysql migration query for v1 banner (no-changelog) ( #6669 )
...
fix(editor): Fix mysql migration query for v1 banner
2023-07-17 10:54:01 +02:00
Milorad FIlipović
4240e76253
feat(editor): Implement new banners framework ( #6603 )
...
* ⚡ Implemented new grid row - banners
* ✨ Fixing node creator and executions sidebar position after layout update
* 💄 Added configurable round corners to the Callout component
* ⚡ Fixing mouse position detection and main tab bar position
* ⚡ Implemented basic banner component structure
* ⚡ Implemented banner state and dismiss logic
* ⚡ Fixing grid layout. Updating banners height state dynamically
* ⚡ Fix zoom to fit position, mouse position in demo mode and callout vertical alignment
* ⚡ Implementing proper trial banners logic
* 💄 Only showing execution usage data once the sidebar is fully expanded
* ✨ Implemented permanent/temporary dismiss logic for v1 flag
* ⚡ Minor refactoring of banner logic
* ⚡ Updating permanent dismiss logic to work with all banners
* 👕 Fixing linting errors
* ✔️ Updating Callout component test snapshots
* 💄 Tweaking zoom to fit position
* ✔️ Updating testing endpoints to use new store data
* ✅ Added banners unit tests
* ✔️ Fixing failing banner tests
* ✅ Added more banner tests
* ⚡ Updating banners dimensions on resize, removing leftover code
* ✔️ Removing store import from API file
* 👕 Fixing lint errors
* ⚡ Updating migration files
* ⚡ Using query parameters in migrations
* 👌 Addressing design review feedback
* ⚡ Updating upgrade plan button click
* ⚡ Updating the migrations syntax
* 👌 Updating permanent banner dismiss endpoint and back-end logic
* 👌 Refactoring trial banner component and ui store
* 👌 Addressing more points from code review
* 👌 Moving DOM logic from the store
* ✔️ Updated callout component snapshots
* 👌 Updating mysql migration file
* ✔️ Updating e2e test canvas coordinates after setting it's position to absolute
* 👌 Addressing back-end review feedback
* 👌 Improving typing around banners
* 👕 Fixing lint errors
2023-07-14 15:36:17 +02:00
कारतोफ्फेलस्क्रिप्ट™
ff0759530d
fix(core): Handle all uncaught exception, not just the ones from Axios ( #6666 )
2023-07-14 13:10:25 +02:00
Michael Auerswald
eedde24cc0
fix(core): Use lower cased email for SAML email attribute ( #6663 )
...
lower case saml email attribute
2023-07-13 23:41:52 +02:00
कारतोफ्फेलस्क्रिप्ट™
b895ba438a
refactor(core): Reduce boilterplate code in between tests 🧹 , and fix the tests in node.js 20 (no-changelog) ( #6654 )
...
refactor(core): Reduce boilterplate code in between tests
also cleaned up some imports, and fixed the tests in node.js 20
2023-07-13 10:14:48 +02:00
Iván Ovejero
3e07ffa73e
refactor: Move CLI commands types to own dir (no-changelog) ( #6658 )
...
refactor: Move CLI commands types to own dir
2023-07-13 10:10:08 +02:00
Iván Ovejero
c35f2b97b3
refactor: Remove outdated publicly accessible warning (no-changelog) ( #6657 )
2023-07-13 09:58:55 +02:00
OlegIvaniv
e5620ab1e4
feat(API): Implement users account quota guards ( #6434 )
...
* feat(cli): Implement users account quota guards
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Remove comment
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Address PR comments
- Getting `usersQuota` from `Settings` repo
- Revert `isUserManagementEnabled` helper
- Fix FE listing of users
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Refactor isWithinUserQuota getter and fix tests
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Revert testDb.ts changes
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Cleanup & improve types
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Fix duplicated method
* Fix failing test
* Remove `isUserManagementEnabled` completely
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Check for globalRole.name to determine if user is owner
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Fix unit tests
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Set isInstanceOwnerSetUp in specs
* Fix SettingsUserView UM
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* refactor: License typings suggestions for users quota guards (#6636 )
refactor: License typings suggestions
* Update packages/cli/src/Ldap/helpers.ts
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* Update packages/cli/test/integration/shared/utils.ts
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* Address PR comments
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Use 403 for all user quota related errors
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
2023-07-12 14:11:46 +02:00
कारतोफ्फेलस्क्रिप्ट™
329d22f5d1
fix(core): Reduce memory consumption on BinaryDataManager.init
( #6633 )
...
fix(core): Reduce memory consumption on BinaryDataManager.init
When there are a few thousand binary data file to delete, the `deleteMarkedFiles` and `deleteMarkedPersistedFiles` methods need a lot of memory to process these files, irrespective of if these files have any data or not.
2023-07-12 10:08:29 +02:00
Iván Ovejero
d6b2ae0255
refactor: Stop using .d.ts
files for type-collection files (no-changelog) ( #6634 )
...
refactor: Stop using `.d.ts` files for type-collection files
2023-07-10 19:35:34 +02:00
कारतोफ्फेलस्क्रिप्ट™
07744986ea
fix(core): Fix credentials lazy-loading (no-changelog) ( #6615 )
2023-07-10 17:57:26 +02:00
OlegIvaniv
aa53c46367
feat(Slack Node): Add option to include link to workflow in Slack node ( #6611 )
...
* feat(Slack Node): Add “automated by” message to Slack node’s post message
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Pass instanceBaseUrl to node context
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Move `includeLinkToWorkflow` to options
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* keep "includeLinkToWorkflow" hidden
* Only append the message for version 2.1 and up
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: ricardo <ricardoespinoza105@gmail.com>
2023-07-10 15:03:21 +02:00
OlegIvaniv
9460bdd3be
ci: Fix v1 banner migration (no-changelog) ( #6628 )
...
* fix(cli): Fix v1 banner migration
* Update packages/cli/src/databases/migrations/mysqldb/1646992772331-CreateUserManagement.ts
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <netroy@users.noreply.github.com>
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <netroy@users.noreply.github.com>
2023-07-10 11:10:44 +02:00
OlegIvaniv
071e56f7fd
feat(core): Only show V1 banner to users who migrated ( #6622 )
...
* feat(editor): Only show V1 banner to users who migrated
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Set the v1 banner dismissed flag in settings table create migration
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
2023-07-07 15:57:05 +02:00
कारतोफ्फेलस्क्रिप्ट™
a76223307f
refactor(core): Load cookieParser
middleware only once (no-changelog) ( #6614 )
...
[Server.ts already explicitly loads `cookieParser`](https://github.com/n8n-io/n8n/blob/master/packages/cli/src/Server.ts#L571 )
2023-07-07 09:57:03 +02:00
कारतोफ्फेलस्क्रिप्ट™
8002213538
ci: Fix linting issues (no-changelog)
2023-07-06 09:28:34 +02:00
कारतोफ्फेलस्क्रिप्ट™
e33cc2c27c
Merge remote-tracking branch 'origin/master' into release/1.0.1
2023-07-05 20:01:24 +02:00
कारतोफ्फेलस्क्रिप्ट™
d97edbcffa
fix(core): Make node execution order configurable, and backward-compatible ( #6507 )
...
* fix(core): Make node execution order configurable, and backward-compatible
* ⚡ Also add new Merge-Node behaviour
* ⚡ Fix typo
* Fix lint issue
* update labels
* rename legacy to v0
* remove the unnecessary log
* default all new workflows to use v1 execution-order
* remove the controller changes
* clone default settings to avoid it getting modified
---------
Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
2023-07-05 18:47:34 +02:00
कारतोफ्फेलस्क्रिप्ट™
282e6aedb3
fix: Fix migrations for postgres and mysql (no-changelog) ( #6600 )
...
fix: Fix migrations for postgres and mysql
2023-07-05 14:40:35 +02:00
कारतोफ्फेलस्क्रिप्ट™
31cba87d30
fix(core): Improve the performance of last 2 sqlite migrations ( #6522 )
2023-07-05 13:46:42 +02:00
कारतोफ्फेलस्क्रिप्ट™
9def7a729b
fix(core): Remove typeorm patches, but still enforce transactions on every migration ( #6594 )
...
* revert(core): Remove typeorm patches, but still enforce transactions on every migration
This reverts #6519
* always re-enable foreign keys, and explicitly rollback transaction
2023-07-05 11:26:49 +02:00
कारतोफ्फेलस्क्रिप्ट™
f0dfc3cf4e
ci: Hide v1 banner in e2e tests to fix 2-credentials.cy.ts (no-changelog)
2023-07-04 22:22:35 +02:00
कारतोफ्फेलस्क्रिप्ट™
b9da67b653
fix(core): Fix migrations for MySQL/MariaDB ( #6591 )
2023-07-04 21:14:05 +02:00
कारतोफ्फेलस्क्रिप्ट™
c906e7391b
fix(core): Route /rest/workflows/new
correctly (no-changelog) ( #6572 )
2023-07-04 21:07:48 +02:00
कारतोफ्फेलस्क्रिप्ट™
f841f187ec
fix(core): Ensure valid logger
is passed to every migration (no-changelog) ( #6563 )
2023-07-04 21:07:12 +02:00
कारतोफ्फेलस्क्रिप्ट™
4c854f4f23
refactor: Setup node context API, and consolidate code between Webhook and Wait nodes (no-changelog) ( #6464 )
2023-07-04 16:17:50 +02:00
कारतोफ्फेलस्क्रिप्ट™
29882a6f39
fix(core): Fix migrations for MySQL/MariaDB ( #6591 )
2023-07-04 16:02:40 +02:00
कारतोफ्फेलस्क्रिप्ट™
ffb4e470b5
fix(core): Update pruning related config defaults for v1 ( #6577 )
...
* Save manual executions by default
* Enable executions data pruning by default
* Keep a maximum of 10000 executions by default
Co-authored-by: Cornelius Suermann <cornelius@n8n.io>
2023-07-04 10:49:04 +02:00
कारतोफ्फेलस्क्रिप्ट™
3b9e65e9e0
fix(core): Route /rest/workflows/new
correctly (no-changelog) ( #6572 )
2023-06-30 08:51:39 +02:00
कारतोफ्फेलस्क्रिप्ट™
9bd49e844a
fix(core): Ensure valid logger
is passed to every migration (no-changelog) ( #6563 )
2023-06-28 17:25:43 +02:00
Michael Auerswald
4b755fb0b4
fix(core): Use owners file to export wf owners ( #6547 )
...
* remove owner from exported workflow
* use owners file to export wf owners
* update sharedworkflow owners
* fix logic
* further update logic
* add updatetAt to local changes
* additional filter for cred export
* optimize query
* remove transactions and optimize query
* reduce array size and add updated at to tags status
2023-06-28 11:06:40 +02:00
OlegIvaniv
f89ef83c76
feat(editor): Prevent saving of workflow when canvas is loading ( #6497 )
...
* feat(editor): Prevent saving of pristine workflow
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Prevent saving if loading
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Fix 7-workflow-actions spec
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Restrict delay intercept to GET only
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Wait for WF patch
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Add helper to remove all active WFs in e2e
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Use META_KEY env var
* Remove cy.wait
* Delete debugging DB reset console log
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Fix clashin mixins `isReadOnly` property
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
2023-06-27 13:05:20 +02:00
कारतोफ्फेलस्क्रिप्ट™
988c4a6354
ci: executeBatch
should compare JSON after serialization, to avoid inconsistencies between main and own mode
2023-06-27 10:33:21 +02:00
Michael Auerswald
9294e2da3c
fix(core): Add empty credential value marker to show empty pw field ( #6532 )
...
add empty credential value marker to show empty pw field
2023-06-23 18:23:28 +02:00
Michael Auerswald
b06462f441
fix(core): Rename to credential_stubs and variable_stubs.json ( #6528 )
...
rename to credential_stubs and variable_stubs.json
2023-06-23 12:32:00 +02:00
कारतोफ्फेलस्क्रिप्ट™
0e071724ee
ci: Refactor e2e tests to delete boilerplate code (no-changelog) ( #6524 )
2023-06-23 00:38:12 +02:00
कारतोफ्फेलस्क्रिप्ट™
abe7f71627
refactor: Remove pre-setup prompt on owner setup ( #6495 )
2023-06-22 21:11:38 +02:00
Jan Oberhauser
0287d5becd
feat(core): Change node execution order (most top-left one first) ( #6246 )
...
* feat(core): Change node execution order (most top-left one first)
* ⚡ Fix issue with multi-output-nodes
* ⚡ Remove not needed meta-entry in test
* fix the e2e test
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-06-22 21:11:29 +02:00
Iván Ovejero
0fe415add2
feat(editor): Add v1 banner ( #6443 )
2023-06-22 21:05:04 +02:00
Omar Ajoue
632ea275b7
refactor: Removal of request lib from the code ( #6413 )
...
* refactor: Removal of request lib from the code
2023-06-22 21:05:04 +02:00
Iván Ovejero
8c008f5d22
refactor(core)!: Remove basic-auth, external-jwt-auth, and no-auth options ( #6362 )
...
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-06-22 20:03:47 +02:00
कारतोफ्फेलस्क्रिप्ट™
a45a2c8c41
feat(core)!: Stop loading community nodes from node_modules ( #6396 )
...
All custom/community nodes should be installed in `~/.n8n/nodes`.
2023-06-22 19:58:05 +02:00
कारतोफ्फेलस्क्रिप्ट™
f6366160a4
feat(core): Remove conditional defaults in V1 release ( #6363 )
2023-06-22 19:54:32 +02:00
कारतोफ्फेलस्क्रिप्ट™
e152cfe27c
fix(core): All migrations should run in a transaction ( #6519 )
2023-06-22 17:51:17 +02:00
कारतोफ्फेलस्क्रिप्ट™
d255b094dd
fix(core): Fix import:credential
on postgres (no-changelog) ( #6515 )
...
Since we switched to string ids, we don't need to update the `_seq` values for postgres.
We removed this bit for the `import:workflow` [here](https://github.com/n8n-io/n8n/pull/6345/files#diff-ff45b1d8db8d3dc67d19aa34e4d066e4156ddcd311c0b8d75a3d082009065197L230 ), but missed updating this file.
2023-06-22 16:54:05 +02:00
कारतोफ्फेलस्क्रिप्ट™
8dc828b704
fix(core): Fix the db:revert
command (no-changelog) ( #6506 )
2023-06-22 09:06:31 +02:00
कारतोफ्फेलस्क्रिप्ट™
42a9e20e32
fix(core): Add additional path-traversal guards on res.sendFile calls (no-changelog) ( #6505 )
2023-06-21 22:20:47 +02:00
Omar Ajoue
044c710a8e
fix: Make MySQL migration for nano id change compatible with version 5.7 ( #6498 )
...
* fix: Make migration for MySQL compatible with version 5.7
* fix: Correct syntax
* fix: Syntax for primary key creation
* fix: Remove unnecessary constraint statement
* fix: Name columns for sqlite migration to prevent issues
* ci: Always run DB tests with table-prefix and alt-schema
* add tablePrefix to migrations (mysql not fixed)
* fix character_set on mysql migrations
* fix mysql collation version difference
* cater for mariadb collations
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
Co-authored-by: Michael Auerswald <michael.auerswald@gmail.com>
2023-06-21 17:10:47 +02:00
कारतोफ्फेलस्क्रिप्ट™
5bf83f8bf6
fix(core): Use correct scopes-separator when generating authorization urls ( #6502 )
2023-06-21 15:19:38 +02:00
Ricardo Espinoza
6ab350209d
feat(core): Add GET /users endpoints to public API ( #6360 )
2023-06-21 13:22:00 +02:00
कारतोफ्फेलस्क्रिप्ट™
25b92169ae
fix(core): Fix OAuth2 callback for grantType=clientCredentials
( #6500 )
...
Co-authored-by: agobrech <ael.gobrecht@gmail.com>
2023-06-21 12:25:27 +02:00
agobrech
fc7261aca6
feat(core): Add PKCE for OAuth2 ( #6324 )
...
* Remove authorization header when empty
* Import pkce
* Add OAuth2 with new grant type to Twitter
* Add pkce logic auto assign authorization code if pkce not defined
* Add pkce to ui and interfaces
* Fix scopes for Oauth2 twitter
* Deubg + pass it through header
* Add debug console, add airtable cred
* Remove all console.logs, make PKCE in th body only when it exists
* Remove invalid character ~
* Remove more console.logs
* remove body inside query
* Remove useless grantype check
* Hide oauth2 twitter waiting for overhaul
* Remove redundant header removal
* Remove more console.logs
* Add comment for code verifier
* Remove uneeded scopes
* Restore client id in callback
* Revert "Add OAuth2 with new grant type to Twitter"
This reverts commit 1c3b331aa1
.
* Remove oauth2 from twitter
* Remove properties linked to oauth2
* Fix lodash imports
* remove redundant check
* remove redundant codeVerifier
* patch pkce-challenge to avoid generating `code_verifier` with `~`
* store `codeVerifier` on the DB like `csrfSecret`
* remove unrelated changes
---------
Co-authored-by: Marcus <marcus@n8n.io>
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-06-21 10:54:32 +02:00
Michael Auerswald
c3ba0123ad
feat: Migrate integer primary keys to nanoids ( #6345 )
...
* first commit for postgres migration
* (not working)
* sqlite migration
* quicksave
* fix tests
* fix pg test
* fix postgres
* fix variables import
* fix execution saving
* add user settings fix
* change migration to single lines
* patch preferences endpoint
* cleanup
* improve variable import
* cleanup unusued code
* Update packages/cli/src/PublicApi/v1/handlers/workflows/workflows.handler.ts
Co-authored-by: Omar Ajoue <krynble@gmail.com>
* address review notes
* fix var update/import
* refactor: Separate execution data to its own table (#6323 )
* wip: Temporary migration process
* refactor: Create boilerplate repository methods for executions
* fix: Lint issues
* refactor: Added search endpoint to repository
* refactor: Make the execution list work again
* wip: Updating how we create and update executions everywhere
* fix: Lint issues and remove most of the direct access to execution model
* refactor: Remove includeWorkflowData flag and fix more tests
* fix: Lint issues
* fix: Fixed ordering of executions for FE, removed transaction when saving execution and removed unnecessary update
* refactor: Add comment about missing feature
* refactor: Refactor counting executions
* refactor: Add migration for other dbms and fix issues found
* refactor: Fix lint issues
* refactor: Remove unnecessary comment and auto inject repo to internal hooks
* refactor: remove type assertion
* fix: Fix broken tests
* fix: Remove unnecessary import
* Remove unnecessary toString() call
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* fix: Address comments after review
* refactor: Remove unused import
* fix: Lint issues
* fix: Add correct migration files
---------
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* remove null values from credential export
* fix: Fix an issue with queue mode where all running execution would be returned
* fix: Update n8n node to allow for workflow ids with letters
* set upstream on set branch
* remove typo
* add nodeAccess to credentials
* fix unsaved run check for undefined id
* fix(core): Rename version control feature to source control (#6480 )
* rename versionControl to sourceControl
* fix source control tooltip wording
---------
Co-authored-by: Romain Minaud <romain.minaud@gmail.com>
* fix(editor): Pay 548 hide the set up version control button (#6485 )
* feat(DebugHelper Node): Fix and include in main app (#6406 )
* improve node a bit
* fixing continueOnFail() ton contain error in json
* improve pairedItem
* fix random data returning object results
* fix nanoId length typo
* update pnpm-lock file
---------
Co-authored-by: Marcus <marcus@n8n.io>
* fix(editor): Remove setup source control CTA button
* fix(editor): Remove setup source control CTA button
---------
Co-authored-by: Michael Auerswald <michael.auerswald@gmail.com>
Co-authored-by: Marcus <marcus@n8n.io>
* fix(editor): Update source control docs links (#6488 )
* feat(DebugHelper Node): Fix and include in main app (#6406 )
* improve node a bit
* fixing continueOnFail() ton contain error in json
* improve pairedItem
* fix random data returning object results
* fix nanoId length typo
* update pnpm-lock file
---------
Co-authored-by: Marcus <marcus@n8n.io>
* feat(editor): Replace root events with event bus events (no-changelog) (#6454 )
* feat: replace root events with event bus events
* fix: prevent cypress from replacing global with globalThis in import path
* feat: remove emitter mixin
* fix: replace component events with event bus
* fix: fix linting issue
* fix: fix breaking expression switch
* chore: prettify ndv e2e suite code
* fix(editor): Update source control docs links
---------
Co-authored-by: Michael Auerswald <michael.auerswald@gmail.com>
Co-authored-by: Marcus <marcus@n8n.io>
Co-authored-by: Alex Grozav <alex@grozav.com>
* fix tag endpoint regex
---------
Co-authored-by: Omar Ajoue <krynble@gmail.com>
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
Co-authored-by: Romain Minaud <romain.minaud@gmail.com>
Co-authored-by: Csaba Tuncsik <csaba@n8n.io>
Co-authored-by: Marcus <marcus@n8n.io>
Co-authored-by: Alex Grozav <alex@grozav.com>
2023-06-20 19:13:18 +02:00
कारतोफ्फेलस्क्रिप्ट™
6ccab3eaaa
feat(Webhook Node): Stream binary response in lastNode.firstEntryBinary
mode ( #6463 )
2023-06-19 13:54:56 +02:00
कारतोफ्फेलस्क्रिप्ट™
9978e2760b
fix(core): Fix the url sent in the password-reset emails ( #6466 )
2023-06-17 10:23:22 +02:00
Chris Wu
1111c915f2
refactor(core): Replace lodash's "soft-deprecated" individual packages with lodash
to resolve CVE (no-changelog) ( #6450 )
...
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-06-16 16:26:35 +02:00
Csaba Tuncsik
1fe6459569
feat: Audit Logs - add new page to frontend [WIP] (no-changelog) ( #6418 )
...
* feat: Audit Logs (WIP)
* feat: Audit Logs license depending contents
* fix(editor): simplify import
* fix(editor): add audit logs to server
2023-06-15 08:33:28 +02:00
Michael Auerswald
cc44af9243
fix(core): Allow all executions to be stopped ( #6386 )
...
* allow all executions to be stopped and fix display issue
* limit cancelation and add recover for unknown states
2023-06-08 09:17:59 +02:00
Csaba Tuncsik
dba3f44bc0
fix(editor): Adding branch color ( #6380 )
...
* fix(editor): Adding branch color
* fix(editor): backend refactor preferences update
* fix(editor): frontend refactor preferences update
2023-06-06 11:23:53 +02:00
Ricardo Espinoza
e95e8de500
refactor(editor): Remove user activation modal (no-changelog) ( #6361 )
...
* Remove user activation modal
* remove export from index.ts
* Update pnpm-lock.yaml
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-06-05 13:47:06 -04:00
agobrech
3a1e96dc6d
ci: Improve Test-worklows messages ( #6290 )
...
* Update test-worklows action
* Improve error messages
* Fix output data to slack
* Fix slackmessage
* add github flag
* add slack config
* Add result to github output
* Fix output string
* Remove old comment for oauth2
* Remove console.logs
* Improve message
* Update to different slack action
* update payload
* Fix wrong json
* debugging
* Revert "update payload"
This reverts commit 4ea955c85e
.
* Reverted to old slack action
* Update slack config
* Remove fallback value
* Change config name
* tests
* more tests
* tests
* Use single message
* message fixes
* Final fixes
* Correct channel
* delete slack.yml config
* keep unused Export credentials step for later
---------
Co-authored-by: Marcus <marcus@n8n.io>
2023-06-05 11:20:58 +02:00
Iván Ovejero
85500d76fb
refactor: Add deprecation notice for UM disabled mode ( #6367 )
2023-06-02 13:26:12 +02:00
Iván Ovejero
de77762e51
refactor: Add deprecation notice for basic auth and JWT auth ( #6349 )
2023-06-01 11:22:29 +02:00
Csaba Tuncsik
1b321416c0
feat: Version control mvp ( #6271 )
...
* implement basic git service
* cleanup connected prop
* add skeleton of git functions
* initial import/export setup
* split out export service
* refactor and improve export
* begin import
* more commands and basic import
* clean up imports with transactions
* work folder import functions
* reintroduce versionid
* add missing import to pull workfolder
* add get-status endpoint
* add cleanup to disconnect
* add initRepo options
* add more checks and cleanup
* minor cleanup
* refactor prefs
* fix server.ts
* fix sending deleted files
* rename files to ee
* add variable override and fix critical cred import bug
* fix mkdir race condition
* make initRepo default to true
* fix front back integration
* improve connect flow
* add comment to generated ssh key
* fix(editor): use useToast composable
* fix buttons size
* commenting out repo init for now
* fix(editor): update UI logic
* fix(editor): remove console.log
* fix(editor): remove unused ref
* adjust endpoints for improved UI
* fix(editor): add push and pull buttons
* keep or not ssh key
* switching file name to id
* fix(editor): add success messages, fix save button
* fixed faulty diff preventing pull
* fix build
* fix(editor): adding loader to VC components
* removing duplicate exports
* improve conflict finding on push pull
* manage pull conflict
* alternate push pull
* fix pull confirmation
* fix rm and credential export/import
* switch to alternative pull implementation
* fix initial commit
* fix(editor): subscribing to VC store action to refresh lists
* fix(editor): wrap VC store actions with try
* feat: add fine-grained file selection for push action
* fix: close modal after successful push
* fix(editor): VC preferences validation
* fix confirm
* fix: update endpoint to /get-status
* feat: update pull modal override changes message
* fix missing wf error
* undo
* removing connect endpoint
* fix(editor): add button titles
* fix(editor): cleaning up store action
* add version-control/set-read-only protection
* fix(editor): adding set branch readonly
* fix(editor): remove Push button if branch set to readonly
* fix(editor): fix some styles
* fix(editor): remove duplicate and delete actions in WF list when branch is readonly
* fix: load status before opening selective push modal
* fix(editor): extend readonly logic
* add cleanup after failed initRepo
* fix deleted files crashing get-status
* fix n8n-checkbox in staging dialog
* fix(editor): fix loading
* fix(editor): resize buttons
* fix(editor): fix translation
* fix(editor): fix copy text size
* fix(editor): fix copy text size
* fix(editor): add disconnection confirmation
* fix(editor): add disconnection confirmation
* fix(editor): set large buttons
* add public api Pull endpoint
* feat: add refresh ssh key
* return prefs when new keys are generated
* fix(editor): adding readOnly mode to main header
* fix(editor): adding readOnly mode to workflow settings
* improve credential owner import
* add middleware to endpoints
* improve public api error/doc
* do not create branch if one already exists
* update wordings for connect toasts
* fix(editor): updating and separating readonly modes
* fix(editor): fix readonly mode in WF list
* fix(editor): disable elements dragging on canvas in readonly mode (WIP: not working when NodeView page is loaded first)
* fix(editor): fix canvas draggables in readonly env
* fix(editor): remove unused variables
* fix(editor): hide actions in node connections when readonly
* fix(editor): hide actions in node connections when readonly
* fix(editor): disable Save button when readonly
* fix(editor): disable Save settings if no branch is selected
* fix(editor): lint fix
* fix(editor): update snapshots
* fix(editor): replace Loading... text
* fix(editor): reset Loading... text
* reset branchname on disconnect
* fix(editor): adding some translations
* fix(editor): fix unit test
* fix(editor): fix loading
* fix(editor): set settings saved message
* fix(editor): update connection flag
* fix branchName not returning after connect
* temporary (but still breaking) fix for postgres
* fix(editor): adding tooltip to Push/Pull buttons when they're collapsed
* fix(editor): enabled activator in readonly mode
* fix test
* fix(editor): disabling new item addition for workflows in readonly mode
* fix(editor): modify Pull/Push button tooltips
* do not commit empty variables file
---------
Co-authored-by: Michael Auerswald <michael.auerswald@gmail.com>
Co-authored-by: Romain Minaud <romain.minaud@gmail.com>
Co-authored-by: Alex Grozav <alex@grozav.com>
2023-05-31 15:01:57 +02:00
Milorad FIlipović
04cfa548af
feat(editor): Implement Resource Mapper component ( #6207 )
...
* ⚡ scaffolding
* ⚡ finished scaffolding
* ⚡ renamed types
* ⚡ updated subtitle
* ⚡ renamed functions file, UI updates
* ⚡ query parameters fixes, ui updates, refactoring
* ⚡ fixes for credentials test, setup for error parsing
* ⚡ rlc for schema and table, error handling tweaks
* ⚡ delete operation, new options
* ⚡ columns loader
* ⚡ linter fixes
* ⚡ where clauses setup
* ⚡ logic for processing where clauses
* ⚡ select operation
* ⚡ refactoring
* ⚡ data mode for insert and update, wip
* ⚡ data mapping, insert update, skip on conflict option
* ⚡ select columns with spaces fix
* ⚡ update operation update, wip
* ⚡ finished update operation
* ⚡ upsert operation
* ⚡ ui fixes
* Copy updates.
* Copy updates.
* ⚡ option to convert empty strings to nulls, schema checks
* ⚡ UI requested updates
* ⚡ ssh setup WIP
* ⚡ fixes, ssh WIP
* ⚡ ssh fixes, credentials
* ⚡ credentials testing update
* ⚡ uncaught error fix
* ⚡ clean up
* ⚡ address in use fix
* ⚡ improved error message
* ⚡ tests setup
* ⚡ unit tests wip
* ⚡ config files clean up
* ⚡ utils unit tests
* ⚡ refactoring
* ⚡ setup for testing operations, tests for deleteTable operation
* ⚡ executeQuery and insert operations tests
* ⚡ select, update, upsert operations tests
* ⚡ runQueries tests setup
* ⚡ hint to query
* Copy updates.
* ⚡ ui fixes
* ⚡ clean up
* ⚡ error message update
* ⚡ ui update
* Minor tweaks to query params decription.
* feat(Google Sheets Node): Implement Resource mapper in Google Sheets node (#5752 )
* ✨ Added initial resource mapping support in google sheets node
* ✨ Wired mapping API endpoint with node-specific logic for fetching mapping fields
* ✨ Implementing mapping fields logic for google sheets
* ✨ Updating Google Sheets execute methods to support resource mapper fields
* 🚧 Added initial version of `ResourceLocator` component
* 👌 Added `update` mode to resource mapper modes
* 👌 Addressing PR feedback
* 👌 Removing leftover const reference
* 👕 Fixing lint errors
* ⚡ singlton for conections
* ⚡ credentials test fix, clean up
* feat(Postgres Node): Add resource mapper to new version of Postgres node (#5814 )
* ⚡ scaffolding
* ⚡ finished scaffolding
* ⚡ renamed types
* ⚡ updated subtitle
* ⚡ renamed functions file, UI updates
* ⚡ query parameters fixes, ui updates, refactoring
* ⚡ fixes for credentials test, setup for error parsing
* ⚡ rlc for schema and table, error handling tweaks
* ⚡ delete operation, new options
* ⚡ columns loader
* ⚡ linter fixes
* ⚡ where clauses setup
* ⚡ logic for processing where clauses
* ⚡ select operation
* ⚡ refactoring
* ⚡ data mode for insert and update, wip
* ⚡ data mapping, insert update, skip on conflict option
* ⚡ select columns with spaces fix
* ⚡ update operation update, wip
* ⚡ finished update operation
* ⚡ upsert operation
* ⚡ ui fixes
* Copy updates.
* Copy updates.
* ⚡ option to convert empty strings to nulls, schema checks
* ⚡ UI requested updates
* ⚡ ssh setup WIP
* ⚡ fixes, ssh WIP
* ⚡ ssh fixes, credentials
* ⚡ credentials testing update
* ⚡ uncaught error fix
* ⚡ clean up
* ⚡ address in use fix
* ⚡ improved error message
* ⚡ tests setup
* ⚡ unit tests wip
* ⚡ config files clean up
* ⚡ utils unit tests
* ⚡ refactoring
* ⚡ setup for testing operations, tests for deleteTable operation
* ⚡ executeQuery and insert operations tests
* ⚡ select, update, upsert operations tests
* ⚡ runQueries tests setup
* ⚡ hint to query
* Copy updates.
* ⚡ ui fixes
* ⚡ clean up
* ⚡ error message update
* ⚡ ui update
* Minor tweaks to query params decription.
* ✨ Updated Postgres node to use resource mapper component
* ✨ Implemented postgres <-> resource mapper type mapping
* ✨ Updated Postgres node execution to use resource mapper fields in v3
* 🔥 Removing unused import
---------
Co-authored-by: Michael Kret <michael.k@radency.com>
Co-authored-by: Giulio Andreini <g.andreini@gmail.com>
* feat(core): Resource editor componend P0 (#5970 )
* ✨ Added inital value of mapping mode dropdown
* ✨ Finished mapping mode selector
* ✨ Finished implementing mapping mode selector
* ✨ Implemented 'Columns to match on' dropdown
* ✨ Implemented `loadOptionsDependOn` support in resource mapper
* ✨ Implemented initial version of mapping fields
* ✨ Implementing dependant fields watcher in new component setup
* ✨ Generating correct resource mapper field types. Added `supportAutoMap` to node specification and UI. Not showing fields with `display=false`. Pre-selecting matching columns if it's the only one
* ✨ Handling matching columns correctly in UI
* ✨ Saving and loading resourceMapper values in component
* ✨ Implemented proper data saving and loading
* ✨ ResourceMapper component refactor, fixing value save/load
* ✨ Refactoring MatchingColumnSelect component. Updating Sheets node to use single key match and Postgres to use multi key
* ✨ Updated Google Sheets node to work with the new UI
* ✨ Updating Postgres Node to work with new UI
* ✨ Additional loading indicator that shown if there is no mapping mode selector
* ✨ Removing hard-coded values, fixing matching columns ordering, refactoring
* ✨ Updating field names in nodes
* ✨ Fixing minor UI issues
* ✨ Implemented matching fields filter logic
* ✨ Moving loading label outside of fields list
* ✅ Added initial unit tests for resource mapper
* ✅ Finished default rendering test
* ✅ Test refactoring
* ✅ Finished unit tests
* 🔨 Updating the way i18n is used in resource mapper components
* ✔️ Fixing value to match on logic for postgres node
* ✨ Hiding mapping fields when auto-map mode is selected
* ✨ Syncing selected mapping mode between components
* ✨ Fixing dateTime input rendering and adding update check to Postgres node
* ✨ Properly handling database connections. Sending null for empty string values.
* 💄 Updated wording in the error message for non-existing rows
* ✨ Fixing issues with selected matching values
* ✔️ Updating unit tests after matching logic update
* ✨ Updating matching columns when new fields are loaded
* ✨ Defaulting to null for empty parameter values
* ✨ Allowing zero as valid value for number imputs
* ✨ Updated list of types that use datepicker as widger
* ✨ Using text inputs for time types
* ✨ Initial mapping field rework
* ✨ Added new component for mapping fields, moved bit of logic from root component to matching selector, fixing some lint errors
* ✨ Added tooltip for columns that cannot be deleted
* ✨ Saving deleted values in parameter value
* ✨ Implemented control to add/remove mapping fields
* ✨ Syncing field list with add field dropdown when changing dependent values
* ✨ Not showing removed fields in matching columns selector. Updating wording in matching columns selector description
* ✨ Implementing disabled states for add/remove all fields options
* ✨ Saving removed columns separately, updating copy
* ✨ Implemented resource mapper values validation
* ✨ Updated validation logic and error input styling
* ✨ Validating resource mapper fields when new nodes are added
* ✨ Using node field words in validation, refactoring resource mapper component
* ✨ Implemented schema syncing and add/remove all fields
* ✨ Implemented custom parameter actions
* ✨ Implemented loading indicator in parameter options
* 🔨 Removing unnecessary constants and vue props
* ✨ Handling default values properly
* ✨ Fixing validation logic
* 👕 Fixing lint errors
* ⚡ Fixing type issues
* ⚡ Not showing fields by default if `addAllFields` is set to `false`
* ✨ Implemented field type validation in resource mapper
* ✨ Updated casing in copy, removed all/remove all option from bottom menu
* ✨ Added auto mapping mode notice
* ✨ Added support for more types in validation
* ✨ Added support for enumerated values
* ✨ Fixing imports after merging
* ✨ Not showing removed fields in matching columns selector. Refactoring validation logic.
* 👕 Fixing imports
* ✔️ Updating unit tests
* ✅ Added resource mapper schema tests
* ⚡ Removing `match` from resource mapper field definition, fixing matching columns loading
* ⚡ Fixed schema merging
* ⚡ update operation return data fix
* ⚡ review
* 🐛 Added missing import
* 💄 Updating parameter actions icon based on the ui review
* 💄 Updating word capitalisation in tooltips
* 💄 Added empty state to mapping fields list
* 💄 Removing asterisk from fields, updating tooltips for matching fields
* ⚡ Preventing matching fields from being removed by 'Remove All option'
* ⚡ Not showing hidden fields in the `Add field` dropdown
* ⚡ Added support for custom matching columns labels
* ⚡ query optimization
* ⚡ fix
* ⚡ Optimizing Postgres node enumeration logic
* ⚡ Added empty state for matching columns
* ⚡ Only fully loading fields if there is no schema fetched
* ⚡ Hiding mapping fields if there is no matching columns available in the schema
* ✔️ Fixing minor issues
* ✨ Implemented runtime type validation
* 🔨 Refactoring validation logic
* ✨ Implemented required check, added more custom messages
* ✨ Skipping boolean type in required check
* Type check improvements
* ✨ Only reloading fields if dependent values actually change
* ✨ Adding item index to validation error title
* ✨ Updating Postgres fetching logic, using resource mapper mode to determine if a field can be deleted
* ✨ Resetting field values when adding them via the addAll option
* ⚡ Using minor version (2.2) for new Postgres node
* ⚡ Implemented proper date validation and type casting
* 👕 Consolidating typing
* ✅ Added unit tests for type validations
* 👌 Addressing front-end review comments
* ⚡ More refactoring to address review changes
* ⚡ Updating leftover props
* ⚡ Added fallback for ISO dates with invalid timezones
* Added timestamp to datetime test cases
* ⚡ Reseting matching columns if operation changes
* ⚡ Not forcing auto-increment fields to be filled in in Postgres node. Handling null values
* 💄 Added a custom message for invalid dates
* ⚡ Better handling of JSON values
* ⚡ Updating codemirror readonly stauts based on component property, handling objects in json validation
* Deleting leftover console.log
* ⚡ Better time validation
* ⚡ Fixing build error after merging
* 👕 Fixing lint error
* ⚡ Updating node configuration values
* ⚡ Handling postgres arrays better
* ⚡ Handling SQL array syntax
* ⚡ Updating time validation rules to include timezone
* ⚡ Sending expressions that resolve to `null` or `undefined` by the resource mapper to delete cell content in Google Sheets
* ⚡ Allowing removed fields to be selected for match
* ⚡ Updated the query for fetching unique columns and primary keys
* ⚡ Optimizing the unique query
* ⚡ Setting timezone to all parsed dates
* ⚡ Addressing PR review feedback
* ⚡ Configuring Sheets node for production, minor vue component update
* New cases added to the TypeValidation test.
* ✅ Tweaking validation rules for arrays/objects and updating test cases
---------
Co-authored-by: Michael Kret <michael.k@radency.com>
Co-authored-by: Giulio Andreini <g.andreini@gmail.com>
2023-05-31 11:56:09 +02:00
Michael Auerswald
792b1c1ffb
feat(core): Add metadata (customdata) to event log ( #6334 )
...
* add metadata (customdata) to event log
* lint fix
* use reduce
2023-05-30 17:59:55 +02:00
Michael Auerswald
77e3f1551d
feat: Add manual login option and password reset link for SSO ( #6328 )
...
* consolidate IUserSettings in workflow and add allowSSOManualLogin
* add pw reset link to owners ui
2023-05-30 12:52:02 +02:00
Cornelius Suermann
0e4c615d0d
fix(core): Do not track errored workflow executions for automated executions (no-changelog) ( #6322 )
...
* fix(core): Do not track errored workflow executions for automated executions
* fix test
* fix test
* fix test
* do not track 'Workflow execution count' event when all counts are 0
* fix test
* fix test
* fix test
* fix test
* fix test
* fix test
* fix test
* fix test
* fix test
2023-05-28 12:08:46 +02:00
Michael Auerswald
0631f69d98
fix(core): Optimize getSharedWorkflowIds query ( #6314 )
...
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-05-26 18:02:55 +02:00
कारतोफ्फेलस्क्रिप्ट™
e046f656fe
feat(core): Remove all floating promises. Enforce @typescript-eslint/no-floating-promises
( #6281 )
2023-05-24 02:01:45 +02:00
Alex Grozav
e3a53fd19d
feat: Add SSO SAML metadataUrl support and various improvements ( #6139 )
...
* feat: add various sso improvements
* fix: remove test button assertion
* fix: fix type imports
* test: attempt fixing unit tests
* fix: changed to using useToast for error toasts
* Minor copy tweaks and swapped buttons position.
* fix locale ref
* align error with UI wording
* simplify saving ux
* fix pretty
* fix: update saml sso setting saving
* fix: undo try/catch changes when saving saml config
* metadata url tab selected at first
* chore: fix linting issue
* test: fix activation checkbox test
---------
Co-authored-by: Giulio Andreini <g.andreini@gmail.com>
Co-authored-by: Michael Auerswald <michael.auerswald@gmail.com>
Co-authored-by: Romain Minaud <romain.minaud@gmail.com>
2023-05-23 16:25:28 +03:00
Omar Ajoue
42c79cd6f1
fix: Initialize license in queue mode correctly ( #6301 )
2023-05-23 13:01:50 +02:00
Omar Ajoue
55b755cb44
fix: Prevent removing manual executions when setting says to save ( #6300 )
2023-05-23 13:00:26 +02:00
Michael Auerswald
ed7f3b845f
fix(core): Optimize SharedWorkflow queries ( #6297 )
...
* optimize SharedWorkflow queries
* fix int to string ids
2023-05-23 09:40:38 +02:00
कारतोफ्फेलस्क्रिप्ट™
37506050c3
fix(core): Prevent app crashes because of unhandled promises in poll and trigger nodes ( #6278 )
...
fixes https://community.n8n.io/t/n8n-server-container-after-read-econnreset-and-write-epipe-errors-in-imap-version-2-node/24012
2023-05-19 15:43:50 +02:00
कारतोफ्फेलस्क्रिप्ट™
a1b1f24ddf
feat(core): Replace client-oauth2 with an in-repo package ( #6266 )
...
Co-authored-by: Marcus <marcus@n8n.io>
2023-05-17 16:40:53 +02:00
कारतोफ्फेलस्क्रिप्ट™
b7d30f3eab
fix: Revert "Replace client-oauth2 with an in-repo package" (no-changelog) ( #6265 )
...
Revert "feat(core): Replace client-oauth2 with an in-repo package (#6056 )"
This reverts commit 77ac953eaf
.
2023-05-17 10:53:03 +02:00
agobrech
8ae2d801d8
feat(Respond to Webhook Node): Move from Binary Buffer to Binary streaming ( #5613 )
...
* replace binary buffer with binary streaming
* Add binary assertion and remove duplicate code
* handle streams correctly
* fix binary response in `own` mode
* fix stream response missing headers
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <netroy@users.noreply.github.com>
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
Co-authored-by: Marcus <marcus@n8n.io>
2023-05-17 10:06:24 +02:00
कारतोफ्फेलस्क्रिप्ट™
77ac953eaf
feat(core): Replace client-oauth2 with an in-repo package ( #6056 )
...
Co-authored-by: Marcus <marcus@n8n.io>
2023-05-16 16:31:11 +02:00
Tom
79d0a0f247
feat(core): Return OAuth2 error body if available ( #5794 )
...
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-05-16 11:19:41 +02:00
Ricardo Espinoza
cd7c312fbd
feat(editor): Add cloud ExecutionsUsage and API blocking using licenses ( #6159 )
...
* Add ExecutionsUsage component
* set $sidebar-expanded-width back to 200px
* add days using interpolation
* Rename PlanData type to CloudPlanData
* Rename Metadata type to PlanMetadata
* Make prop block in the update button
* Use variable in line-height
* Remove progressBarSection class
* fix trial expiration calculation
* mock expirationDate and fix issue with days left
* Remove unnecesary property from class .container
* inject component data via props
* Check for plan data during app mounting and keep data in the store
* Remove mounted hook
* redirect when upgrade plan is clicked
* Remove computed properties
* Remove instance property as it's not needed anymore
* Flatten plan object
* remove console.log
* Add all cloud types within its own namespace
* keep redirection inside component
* get computed properties back
* Improve polling logic
* Move cloudData to its own store
* Remove commented interfaces
* remove cloudPlan from user store
* fix imports
* update logic for userIsTrialing method
* centralize userIsTrialing method
* redirect to production change plan page always
* Call staging or production cloud api depending on base URL
* remove setting store form ExecutionUsage.vue
* fix linting issue
* Add trial group to PlanMetadata group
* Move helpers into the store
* make staging url check more specific
* make cloud state nullable
* fix linting issue
* swap mockup date for endpoint
* Make getCurrentPlan async
* asas
* Improvements
* small improvements
* chore: resolve conflicts
* make sure there is data before calculating trial expiration
* Fix issue with component not loading on first page load
* type safety improvements
* apply component ui feedback
* fix linting issue
* chore: clean up unnecessary change from merge conflict
* feat: Block api feature using licenses, show notice page for trial cloud users (#6187 )
* rename planSpec to plan
* Remove instance property as it's not needed anymore
* Flatten plan object
* remove console.log
* feat: disable api using license
* feat: add api page
* chore: resolve conflicts
* chore: resolve conflicts
* feat: update and refactor a bit
* fix: update endpoints
* fix: update endpoints
* fix: use host
* feat: update copy
* fix linting issues
---------
Co-authored-by: ricardo <ricardoespinoza105@gmail.com>
* add pluralization to days left text
---------
Co-authored-by: Mutasem <mutdmour@gmail.com>
Co-authored-by: Mutasem Aldmour <4711238+mutdmour@users.noreply.github.com>
2023-05-15 17:16:13 -04:00
कारतोफ्फेलस्क्रिप्ट™
a4c0cc9b5c
feat(core): Reduce the number of events sent to Sentry ( #6235 )
2023-05-15 15:54:48 +02:00
कारतोफ्फेलस्क्रिप्ट™
51c89db6dc
ci: Fix linting issue on master (no-changelog) ( #6232 )
2023-05-11 17:13:23 +02:00
कारतोफ्फेलस्क्रिप्ट™
9db49d0c18
fix(core): Make sure that special polling parameters are available on community nodes as well ( #6230 )
...
This broke in 0.227.0.
2023-05-11 16:19:55 +02:00
कारतोफ्फेलस्क्रिप्ट™
500c0ebce3
fix(core): Ensure DB repositories are initialized before the DB migrations are run ( #6220 )
...
also remove the need to re-open sqlite db connection
2023-05-10 17:53:04 +02:00
Omar Ajoue
d5e62ff096
fix: Prevent unnecessary error messages also for data loaded flag ( #6201 )
...
* fix: Prevent unnecessary error messages also for data loaded flag
* refactor: Search if data has been loaded before trying to save and fire other events
* fix broken test
* fix lint issue
2023-05-10 13:10:39 +02:00
कारतोफ्फेलस्क्रिप्ट™
6eed763f23
ci: Fix linting issue on master (no-changelog) ( #6217 )
2023-05-10 11:09:11 +02:00
कारतोफ्फेलस्क्रिप्ट™
9e7b9fb443
feat(core): Improve health check ( #6205 )
...
* remove unnecesary Db re-initialization
this is from before we added `Db.init` in `WorkflowRunnerProcess`
* feat(core): Improved health check
* make health check not care about DB connections
* close DB connections, and shutdown the timer
2023-05-10 10:27:04 +02:00
Omar Ajoue
06948b5ba5
fix: Correctly save executions that failed when polling as error instead of new ( #6192 )
2023-05-09 12:58:08 +02:00
Omar Ajoue
fad5781635
refactor: Add deprecation notice for WEBHOOK_TUNNEL_URL ( #6194 )
2023-05-08 15:52:13 +02:00
Omar Ajoue
1da71645f2
refactor(core): Add deprecation notice for own mode ( #6195 )
...
* refactor: Add deprecation notice for own mode
* Undo default value change
2023-05-08 15:03:44 +02:00
कारतोफ्फेलस्क्रिप्ट™
b499d27f08
feat(core): Update config defaults for for v1 (no-changelog) ( #6196 )
...
feat(core): Change config defaults when the release is V1
2023-05-08 13:46:20 +02:00
Omar Ajoue
0673a39fa0
refactor: Add deprecation notice for MySQL and MariaDB ( #6189 )
...
* refactor: Add deprecation notice for MySQL and MariaDB
* Update packages/cli/src/commands/BaseCommand.ts
Co-authored-by: Cornelius Suermann <cornelius@n8n.io>
---------
Co-authored-by: Cornelius Suermann <cornelius@n8n.io>
2023-05-08 12:16:20 +02:00
Michael Auerswald
f00b2ae3ea
fix(core): Move nodeExecute InternalHook calls to hookFunctionsSave ( #6193 )
...
nodeExecute InternalHooks to hookFunctionsSave
2023-05-05 17:49:43 +02:00
कारतोफ्फेलस्क्रिप्ट™
82fe6383ef
refactor(core): Delete boilerplate code across migrations (no-changelog) ( #5254 )
2023-05-05 11:28:59 +02:00
OlegIvaniv
5abdba2304
ci: Revert full db reset for e2e (no-changelog) ( #6182 )
2023-05-04 16:19:31 +02:00
Cornelius Suermann
97578c7505
fix: Log unhandled errors during license activation (no-changelog) ( #6165 )
2023-05-03 14:26:29 +02:00
OlegIvaniv
e88232ede2
test: Address flaky setup e2e (no-changelog) ( #6085 )
...
* test: Add /setup intercept for `skipSetup` command (no-changelog)
* Drop all tables for e2e reset, intercept account setup request
* Fix linting issues
* Allow to skip setup account request intercept and linting fixes
* Make sure variables are loaded
* Use PATCH for enabling of e2e features
* Do not exclude migration table from truncation
* Add user sign-up intercept
2023-05-03 14:06:06 +02:00
Ricardo Espinoza
570790ed0c
fix(core): Fix bug running addUserActivatedColumn migration on MariaDB ( #6157 )
2023-05-03 11:04:47 +02:00
Cornelius Suermann
a3d26eff79
fix: Prevent invocations of 'GET /rest/license' from returning an error when ephemeral licenses are used ( #6154 )
...
* fix: Prevent error when invoking with an ephemeral license
* add tests
2023-05-03 10:43:13 +02:00
Michael Kret
a0dd17e115
fix(core): Better error message in Webhook node when using the POST method
2023-05-02 17:27:05 +03:00
Michael Auerswald
25fe14be56
fix(core): Remove SAML config metadataUrl if XML metadata is set directly ( #6143 )
...
remove metadataUrl if metadata is set directly
2023-05-02 11:22:34 +02:00
Michael Auerswald
839a56a682
fix(core): Fix canceled execution status ( #6142 )
2023-05-02 10:37:35 +02:00
Michael Auerswald
c0b1cddc91
fix(core): Improve saml endpoints and audit events ( #6107 )
...
* update saml endpoints and login audit
* fix(core): Skip auth for controllers/routes that don't use the `Authorized` decorator
* fix linting
* lint fix
* add tests and fix endpoint permission
* add hook test
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-04-28 18:11:33 +02:00
Ricardo Espinoza
5974af1903
fix(core): Only take into account users that active for the first time to show activation modal (no-changelog) ( #6121 )
...
only take into account users that active for the first time
2023-04-28 10:56:24 +02:00
कारतोफ्फेलस्क्रिप्ट™
59aee2270b
fix(core): Skip auth for controllers/routes that don't use the Authorized
decorator, or use Authorized('none')
( #6106 )
2023-04-27 12:51:55 +02:00
कारतोफ्फेलस्क्रिप्ट™
6335e0938d
fix(editor): Make the frontend work again when NODE_FUNCTION_ALLOW_EXTERNAL
is set (no-changelog) ( #6058 )
2023-04-25 18:18:46 +02:00
Iván Ovejero
88724bb056
ci: Enforce no unused imports (no-changelog) ( #6073 )
2023-04-25 11:47:03 +02:00
Michael Auerswald
f3b4701863
feat(core): Manage version control settings ( #6079 )
...
* expand VersionControlPreferences
* use Authorized decorator for vc endpoints instead of middleware
* validate preferences with class-validator
* cleanup
* cleanup
2023-04-24 17:13:25 +02:00
Ricardo Espinoza
13ef3c1d20
feat(core): Add instanceId to n8n.ready hook (no-changelog) ( #6007 )
...
* add instanceId to n8n.ready hook
* Set instanceId during configuration method
2023-04-24 09:12:00 -04:00
कारतोफ्फेलस्क्रिप्ट™
308a94311f
refactor: Async functions don't need to explicitly return promises (no-changelog) ( #6041 )
2023-04-24 13:17:08 +02:00
Jimw383
03be725cef
SSO/SAML : add Base URL to redirects in acsHandler ( #5923 )
...
add Base URL to redirects in acsHandler
I modified the redirections to include the base URL of the instance so that the redirects remain correct even if the instance is accessed from a subdirectory.
Co-authored-by: Michael Auerswald <michael.auerswald@gmail.com>
2023-04-24 12:36:50 +02:00
Cornelius Suermann
eaf7090919
fix(core): Skip license activation when instance was already activated ( #6064 )
2023-04-24 11:46:04 +02:00
कारतोफ्फेलस्क्रिप्ट™
1eeadc6114
refactor(core): Setup decorator based RBAC (no-changelog) ( #5787 )
2023-04-24 11:45:31 +02:00
Ricardo Espinoza
8a38624cbc
feat(core): Add migration to add property userActivated to user settings (no-changelog) ( #5940 )
...
* Add userActivated migration
* Fix migration logic
* Remove duplication when retrieving the activated users
* Fix bug updating settings in mysql
* Make userSettings type conform with naming convention
* Disable naming convention rule only in IDatabaseCollections interface
* Fix down method in Postgres migration
* Reset '{}' to NULL when reversing migration
2023-04-21 11:15:08 -04:00
Cornelius Suermann
ab12d3e327
feat(core): Add license:info command ( #6047 )
...
* feat(core): Add license:info command
* revert changes to start.ts
* revert changes to start.ts
* fix typo
2023-04-21 17:10:10 +02:00
Michael Auerswald
ac245fdb8d
refactor(editor): Consolidate IN8nUISettings interface ( #6055 )
...
* consolidate IN8nUISettings
* cleanup
2023-04-21 13:30:57 +02:00
Michael Kret
0e93fe064e
refactor(core): Forbid raw enums (no-changelog)
2023-04-21 14:23:15 +03:00
Michael Auerswald
da31925083
refactor(core): Sort variables files under variables folder ( #6051 )
...
sort variables files under variables folder
2023-04-21 13:08:16 +02:00
Michael Auerswald
71ed1f410c
feat(core): Add SSH key generation ( #6006 )
...
* basic prefs and ssh key generation
* review change
* cleanup save
* lint fix
2023-04-19 17:46:10 +02:00
कारतोफ्फेलस्क्रिप्ट™
c87262a312
docs: Stop assuming the user's gender in code comments (no-changelog) ( #6015 )
2023-04-19 16:00:49 +02:00
Jan Oberhauser
62f993c84f
feat(core): Add support for digestAuth to httpRequest and declarative style ( #5676 )
...
feat(core): Add support to digestAuth to httpRequest and declarative style
2023-04-19 13:44:41 +02:00
कारतोफ्फेलस्क्रिप्ट™
fe058aa8ee
fix(core): Use tablePrefix in the CreateVariables migration (no-changelog) ( #6011 )
2023-04-19 12:42:46 +02:00
Michael Auerswald
33299ca61a
feat(core): Add versionControl feature flag ( #6000 )
...
add versionControl feature flag
2023-04-18 13:29:26 +02:00
Val
1bb987140a
feat: Add variables feature ( #5602 )
...
* feat: add variables db models and migrations
* feat: variables api endpoints
* feat: add $variables to expressions
* test: fix ActiveWorkflowRunner tests failing
* test: a different fix for the tests broken by $variables
* feat: variables licensing
* fix: could create one extra variable than licensed for
* feat: Add Variables UI page and $vars global property (#5750 )
* feat: add support for row slot to datatable
* feat: add variables create, read, update, delete
* feat: add vars autocomplete
* chore: remove alert
* feat: add variables autocomplete for code and expressions
* feat: add tests for variable components
* feat: add variables search and sort
* test: update tests for variables view
* chore: fix test and linting issue
* refactor: review changes
* feat: add variable creation telemetry
* fix: Improve variables listing and disabled case, fix resource sorting (no-changelog) (#5903 )
* fix: Improve variables disabled experience and fix sorting
* fix: update action box margin
* test: update tests for variables row and datatable
* fix: Add ee controller to base controller
* fix: variables.ee routes not being added
* feat: add variables validation
* fix: fix vue-fragment bug that breaks everything
* chore: Update lock
* feat: Add variables input validation and permissions (no-changelog) (#5910 )
* feat: add input validation
* feat: handle variables view for non-instance-owner users
* test: update variables tests
* fix: fix data-testid pattern
* feat: improve overflow styles
* test: fix variables row snapshot
* feat: update sorting to take newly created variables into account
* fix: fix list layout overflow
* fix: fix adding variables on page other than 1. fix validation
* feat: add docs link
* fix: fix default displayName function for resource-list-layout
* feat: improve vars expressions ux, cm-tooltip
* test: fix datatable test
* feat: add MATCH_REGEX validation rule
* fix: overhaul how datatable pagination selector works
* feat: update completer description
* fix: conditionally update usage syntax based on key validation
* test: update datatable snapshot
* fix: fix variables-row button margins
* fix: fix pagination overflow
* test: Fix broken test
* test: Update snapshot
* fix: Remove duplicate declaration
* feat: add custom variables icon
---------
Co-authored-by: Alex Grozav <alex@grozav.com>
Co-authored-by: Omar Ajoue <krynble@gmail.com>
2023-04-18 12:41:55 +02:00
Michael Auerswald
4c994faec1
fix(core): Improve SAML connection test result views ( #5981 )
...
* improve test result views
* refactor
* lint fix
2023-04-14 15:49:10 +02:00
Omar Ajoue
49d838f628
fix(core): Fix broken API permissions in public API ( #5978 )
2023-04-14 11:05:42 +02:00
Iván Ovejero
1a8a9f8ddb
fix(core): Fix lint on SAML controller (no-changelog) ( #5967 )
...
* 👕 Fix lint on SAML controller
* 📘 Type request properly
* Update requests.ts
* 🚚 Move type to module
Assuming ACS falls under configuration.
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <netroy@users.noreply.github.com>
2023-04-13 14:14:55 +02:00
Michael Auerswald
8474cd386d
fix(core): Skip SAML onboarding for users with first- and lastname ( #5966 )
...
skip onboarding for users with first- and lastname
2023-04-13 10:09:50 +02:00
कारतोफ्फेलस्क्रिप्ट™
10f8c35dbb
refactor(core): Use injectable classes for db repositories (part-1) (no-changelog) ( #5953 )
...
Co-authored-by: ricardo <ricardoespinoza105@gmail.com>
2023-04-12 10:59:14 +02:00
Ricardo Espinoza
725393dae6
feat(editor): Add user activation survey ( #5677 )
...
* ⚡ Add user activation survey
* Fix typo
* Avoid showing the modal when there is a modal view
* Allow to redirect to specific execution
* Improve structure
* Handle errors when sharing feedback
* update withFeatureFlag function
* Fix linting issue
* Set user activation flag on workflowExecutionCompleted event
* Revert update user settings functionality
* Remove unnecessary changes
* fix linting issue
* account for new functionality in tests
* Small improvements
* keep once instace of the model open between tabs
* Add sorting to GET /executions
* type parameters for GET /executions
a
* Add constant for local store key
* Add execution mode filtering
* fix linting issue
* Do not override settings when setting isOnboarded true
* Add update user settings endpoint
* improvements
* revert changes to /GET executions
* Fix typo
* Add userActivated flag to user store
* Add E2E test
* Fix linting issue
* Update pnpm-lock
* Revert unnecessary change
* Centralize user's settings update
* Remove unused ref in userActivationSurvey modal
* Use aliased imports
* Use createEventBus function in component
* Fix tests
2023-04-11 12:43:47 -04:00
Michael Auerswald
3e382ef85e
fix(core): Fix issue where sub workflows would display as running forever after failure to start ( #5905 )
...
* fixed recovery / status for early return in main mode
* mark non-data returning executions in own mode as failed
* improve error handling
2023-04-06 11:36:11 +02:00
कारतोफ्फेलस्क्रिप्ट™
2881ee9ecc
fix(core): App should not crash with a custom rest endpoint ( #5911 )
...
fixes #5880
2023-04-06 11:35:05 +02:00
कारतोफ्फेलस्क्रिप्ट™
6689451e8c
fix(core): Do not execute workflowExecuteBefore
hook when resuming executions from a waiting state ( #5727 )
2023-04-06 10:18:19 +02:00
कारतोफ्फेलस्क्रिप्ट™
e7aaa9425a
fix(core): Make WorkflowStatistics tests pass on all databases (no-changelog) ( #5909 )
2023-04-05 14:51:43 +02:00
Csaba Tuncsik
04f8600bbd
feat(editor): SSO onboarding ( #5756 )
...
* feat(editor): SSO onboarding
* fix(editor): add SAML onboarding page
* fix(editor): submit user name on SAML onboarding
2023-04-04 18:18:16 +02:00
Omar Ajoue
2b06673b2e
refactor: Upsert workflow statistics to suppress unnecessary error messages ( #5863 )
2023-04-04 18:11:21 +02:00
Csaba Tuncsik
f4e59499fc
feat(editor): SSO setup ( #5736 )
...
* feat(editor): SSO settings page
* feat(editor): SSO settings page
* feat(editor): SSO settings page
* feat(editor): SSO settings page
* feat(editor): SSO settings page
* feat(editor): SSO settings page
* Merge remote-tracking branch 'origin/master' into pay-170-sso-set-up-page
# Conflicts:
# packages/cli/src/sso/saml/routes/saml.controller.ee.ts
* feat(editor): Prevent SSO settings page route
* feat(editor): some UI improvements
* fix(editor): SSO settings saml config optional chaining
* fix return values saml controller
* fix(editor): drop dompurify
* fix(editor): save xml as is
* return authenticationMethod with settings
* fix(editor): add missing prop to server
* chore(editor): code formatting
* fix ldap/saml enable toggle endpoint
* fix missing import
* prevent faulty ldap setting from breaking startup
* remove sso fake-door from users page
* fix(editor): update SSO settings route permissions + unit testing
* fix(editor): update vite config for test
* fix(editor): add paddings to SSO settings page buttons, add translation
* fix(editor): fix saml unit test
* fix(core): Improve saml test connection function (#5899 )
improve-saml-test-connection return
---------
Co-authored-by: Michael Auerswald <michael.auerswald@gmail.com>
Co-authored-by: Romain Minaud <romain.minaud@gmail.com>
2023-04-04 14:28:29 +02:00
Alex Grozav
df2ea0f5ec
fix: Add optional chaining for 'isArtificalRecoveredEventItem' (no-changelog) ( #5860 )
...
* fix: add optional chaining for isArtificalRecoveredEventItem
* fix: fix isArtificalRecoveredEventItem typo
2023-04-03 16:04:59 +03:00
कारतोफ्फेलस्क्रिप्ट™
ddbfcc7d93
fix(core): Use table-prefixes in queries in import commands ( #5887 )
2023-04-03 14:32:49 +02:00
कारतोफ्फेलस्क्रिप्ट™
e47190b560
fix(core): Fix the issue of nodes not loading when run via npx ( #5888 )
2023-04-03 12:14:41 +02:00
OlegIvaniv
d9f1e1e1ed
test(editor): Fix failing licensing related e2e specs (no-changelog) ( #5884 )
...
test(editor): Fix failing licensing related specs
2023-04-03 09:49:55 +02:00
Iván Ovejero
62751b5a0b
refactor: Add lint rule no-unused-param-in-catch-clause
( #5868 )
...
👕 Add lint rule `no-unused-param-in-catch-clause`
2023-03-31 16:44:08 +02:00
Michael Auerswald
83aef17120
feat(core): Read ephemeral license from environment and clean up ee flags ( #5808 )
...
Co-authored-by: Cornelius Suermann <cornelius@n8n.io>
2023-03-31 13:51:38 +02:00
Michael Kret
085660d7d7
fix(core): Fix curl import error when no data
2023-03-31 14:01:21 +03:00
कारतोफ्फेलस्क्रिप्ट™
5bcab8fcbe
fix(core): Password reset should pass in the correct values to external hooks ( #5842 )
2023-03-30 16:44:39 +02:00
कारतोफ्फेलस्क्रिप्ट™
41cdee7bc7
refactor(core): Switch Tags queries from QueryBuilder to Repository API (no-changelog) ( #5819 )
...
Co-authored-by: Omar Ajoue <krynble@gmail.com>
2023-03-30 16:25:51 +02:00
Michael Auerswald
fa5bc814b0
fix(core): Deactivate active workflows during import ( #5840 )
...
* deactivate imported workflows
* improve test
* fix for combined import (and test)
* cleanup
2023-03-30 15:33:30 +02:00
Michael Auerswald
2216455760
feat(core): Prevent non owners password reset when saml is enabled ( #5788 )
...
* prevent non owners from pw reset when saml is enabled
* improve tests
* change error type
2023-03-30 12:44:53 +02:00
Val
744c3fd211
fix(core): Waiting workflows not stopping ( #5811 )
...
fix: Waiting workflows not stopping
2023-03-30 10:12:29 +01:00
कारतोफ्फेलस्क्रिप्ट™
58fda255fe
refactor: Revert "refactor(core): Use typedi to manage EventBus singletons ( #5795 )" (no-changelog) ( #5825 )
...
Revert "refactor(core): Use typedi to manage EventBus singletons (no-changelog) (#5795 )"
This reverts commit 522c790817
.
2023-03-30 09:59:04 +02:00
कारतोफ्फेलस्क्रिप्ट™
522c790817
refactor(core): Use typedi to manage EventBus singletons (no-changelog) ( #5795 )
2023-03-29 20:38:47 +02:00
कारतोफ्फेलस्क्रिप्ट™
be373bb859
Revert "feat(core): Read ephemeral license from environment and cleanup ee flags ( #5797 )" ( #5816 )
...
Revert "feat(core): Read ephemeral license from environment and clean up ee flags (#5797 )"
This reverts commit a81ca7c19c
.
2023-03-29 18:00:29 +02:00
Michael Auerswald
a81ca7c19c
feat(core): Read ephemeral license from environment and clean up ee flags ( #5797 )
...
* remove enterprise feature schema for license.cert
* bump license sdk version
* Update packages/cli/package.json
Co-authored-by: Cornelius Suermann <cornelius@n8n.io>
---------
Co-authored-by: Cornelius Suermann <cornelius@n8n.io>
2023-03-28 17:21:40 +02:00
agobrech
5f6183a031
ci: Improve categorisation of errors in the Test-Workflow (no-changelog) ( #5772 )
...
* Add warning messages for bad gateway and insufficient balance
* Remove console.logs
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <netroy@users.noreply.github.com>
2023-03-28 13:21:22 +02:00
Michael Auerswald
f15f4bdcf2
feat(core): Convert eventBus controller to decorator style and improve permissions ( #5779 )
2023-03-27 12:30:03 +02:00
Michael Auerswald
47ee357059
feat(core): Improve ldap/saml toggle and tests ( #5771 )
...
* improve ldap/saml toggle and tests
* import cleanup
* reject regular login users when saml is enabled
* lint fix
2023-03-24 17:46:06 +01:00
कारतोफ्फेलस्क्रिप्ट™
30aeeb70b4
fix(core): Ensure that all non-lazy-loaded community nodes get post-processed correctly ( #5782 )
...
If you install a community node with `polling: true`, activating a workflow with that node fails with an error: `WorkflowActivationError: There was a problem activating the workflow: "Could not get parameter "pollTimes"!"`.
You can test this by installing `n8n-nodes-rss-feed-trigger`, creating a workflow with the `RSS Trigger` node, and then trying to activate it. Activation will fail on `master`, but work as expected on this branch.
2023-03-24 17:29:56 +01:00
कारतोफ्फेलस्क्रिप्ट™
161de110ce
fix(core): Improve community nodes loading ( #5608 )
2023-03-24 17:04:26 +01:00
कारतोफ्फेलस्क्रिप्ट™
c9d9069c0e
refactor(core): Stronger typing for workflow settings (no-changelog) ( #5754 )
2023-03-24 13:11:48 +01:00
Michael Auerswald
d33a1ac1e9
fix(core): Assign properties.success earlier to set executionStatus correctly ( #5773 )
...
assign properties.success earlier
2023-03-24 12:53:43 +01:00
कारतोफ्फेलस्क्रिप्ट™
e67ad29625
fix(core): Initialize queue in the webhook server as well ( #5766 )
...
fix(core): Initialize queue in the webhook server as well (no-changelog)
2023-03-24 10:47:21 +01:00
Csaba Tuncsik
d78a41db54
feat: Execution custom data saving and filtering ( #5496 )
...
* wip: workflow execution filtering
* fix: import type failing to build
* fix: remove console.logs
* feat: execution metadata migrations
* fix(editor): Move global executions filter to its own component
* fix(editor): Using the same filter component in workflow level
* fix(editor): a small housekeeping
* checking workflowId in filter applied
* fix(editor): update filter after resolving merge conflicts
* fix(editor): unify empy filter status
* feat(editor): add datetime picker to filter
* feat(editor): add meta fields
* fix: fix button override in datepicker panel
* feat(editor): add filter metadata
* feat(core): add 'startedBefore' execution filter prop
* feat(core): add 'tags' execution query filter
* Revert "feat(core): add 'tags' execution query filter"
This reverts commit a7b968081c
.
* feat(editor): add translations and tooltip and counting selected filter props
* fix(editor): fix label layouts
* fix(editor): update custom data docs link
* fix(editor): update custom data tooltip position
* fix(editor): update tooltip text
* refactor: Ignore metadata if not enabled by license
* fix(editor): Add paywall states to advanced execution filter
* refactor: Save custom data also for worker mode
* fix: Remove duplicate migration name from list
* fix(editor): Reducing filter complexity and add debounce to text inputs
* fix(editor): Remove unused import, add comment
* fix(editor): simplify event listener
* fix: Prevent error when there are running executions
* test(editor): Add advanced execution filter basic unit test
* test(editor): Add advanced execution filter state change unit test
* fix: Small lint issue
* feat: Add indices to speed up queries
* feat: add customData limits
* refactor: put metadata save in transaction
* chore: remove unneed comment
* test: add tests for execution metadata
* fix(editor): Fixes after merge conflict
* fix(editor): Remove unused import
* wordings and ui fixes
* fix(editor): type fixes
* feat: add code node autocompletions for customData
* fix: Prevent transaction issues and ambiguous ID in sql clauses
* fix(editor): Suppress requesting current executions if metadata is used in filter (#5739 )
* fix(editor): Suppress requesting current executions if metadata is used in filter
* fix(editor): Fix arrows for select in popover
* refactor: Improve performance by correcting database indices
* fix: Lint issue
* test: Fix broken test
* fix: Broken test
* test: add call data check for saveExecutionMetadata test
---------
Co-authored-by: Valya Bullions <valya@n8n.io>
Co-authored-by: Alex Grozav <alex@grozav.com>
Co-authored-by: Omar Ajoue <krynble@gmail.com>
Co-authored-by: Romain Minaud <romain.minaud@gmail.com>
2023-03-23 18:07:46 +01:00
कारतोफ्फेलस्क्रिप्ट™
4c583e2be4
ci: Fix saml.api.test.ts (no-changelog) ( #5764 )
2023-03-23 16:54:35 +01:00
Michael Auerswald
4498c6013d
fix(core): Persist CurrentAuthenticationMethod setting change ( #5762 )
...
* limit user invites when saml is enabled
* persist CurrentAuthenticationMethod
2023-03-23 15:13:05 +01:00
Michael Auerswald
57748b71e5
feat(core): Limit user invites when SAML is enabled ( #5761 )
...
limit user invites when saml is enabled
2023-03-23 15:12:19 +01:00
Michael Auerswald
ac18c0b9eb
fix(core): Return SAML service provider urls with config ( #5759 )
...
return sp urls with config
2023-03-23 10:42:19 +01:00
कारतोफ्फेलस्क्रिप्ट™
5dda3f2c61
fix(core): Require Auth on icons and nodes/credentials types static files (no-changelog) ( #5745 )
2023-03-22 14:22:50 +01:00
Manish Dhanwal
40aacf9279
feat(core): Make OAuth2 error handling consistent with success handling ( #5555 )
...
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-03-22 12:53:49 +01:00
Michael Auerswald
b6d8a0f985
fix(core): Remove circular refs from Code and push msg ( #5741 )
...
* remove circular refs from code items (and lint fixes)
* cleanup
---------
* add some tests
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-03-21 15:34:30 +01:00
कारतोफ्फेलस्क्रिप्ट™
34d7fcc27e
ci: Fix linting issues on master (no-changelog) ( #5740 )
2023-03-21 12:11:59 +01:00
कारतोफ्फेलस्क्रिप्ट™
564bc03d3f
fix(core): Upgrade convict to address CVE-2023-0163 ( #5729 )
...
fix(core): upgrade convict to address CVE-2023-0163
also, do not allow passing any cli arguments to config.
2023-03-21 09:47:50 +01:00
Csaba Tuncsik
6916628a9f
feat(editor): SSO login button ( #5615 )
...
* feat(editor): SSO login button
* feat(editor): SSO login button
* feat(editor): SSO login button
2023-03-17 21:07:08 +01:00
Michael Auerswald
e0ea97af8d
fix(core): Fix calling error workflows in main mode recovery ( #5698 )
...
* fix calling error workflows in main mode recovery
* cleanup
* remove WorkflowExecuteAdditionalData export from index
* revert refactor to fix test
* Update index.ts
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <netroy@users.noreply.github.com>
2023-03-17 18:02:49 +01:00
कारतोफ्फेलस्क्रिप्ट™
6242cac53b
ci: Refactor cli tests to speed up CI (no-changelog) ( #5718 )
...
* ci: Refactor cli tests to speed up CI (no-changelog)
* upgrade jest to address memory leaks
2023-03-17 17:24:05 +01:00
Michael Auerswald
be172cb720
fix(core): Return saml attributes after connection test ( #5717 )
...
return saml attributes for test
2023-03-17 15:56:51 +01:00