Commit graph

10433 commits

Author SHA1 Message Date
कारतोफ्फेलस्क्रिप्ट™ 9fd6319583
fix(core): Reduce memory usage in credentials risk auditing (#7663) 2023-11-09 14:39:16 +01:00
कारतोफ्फेलस्क्रिप्ट™ 5edf722209
ci: Stop disabling linting rules that are explicitly set to warn (no-changelog) (#7669) 2023-11-09 14:05:39 +01:00
कारतोफ्फेलस्क्रिप्ट™ ad596abeb9
ci: Disable Workflow filters e2e tests to unblock the CI (no-changelog) (#7668) 2023-11-09 13:30:17 +01:00
Iván Ovejero 16a1a92f18
refactor(core): Stop reporting to Sentry credential-not-found error (no-changelog) (#7665)
https://n8nio.sentry.io/issues/4528134408
2023-11-09 10:55:13 +01:00
Val 0468ded0db
feat: Add permissions package (no-changelog) (#7650)
Github issue / Community forum post (link here to close automatically):
2023-11-08 15:42:40 +00:00
कारतोफ्फेलस्क्रिप्ट™ 0346b211a7
ci(core): Reduce memory usage in tests (part-1) (no-changelog) (#7654) 2023-11-08 16:29:39 +01:00
Michael Kret 6a53c2a375
feat(Discord Node): Overhaul (#5351)
Github issue / Community forum post (link here to close automatically):

---------

Co-authored-by: Giulio Andreini <g.andreini@gmail.com>
Co-authored-by: Marcus <marcus@n8n.io>
2023-11-08 16:11:23 +02:00
Ricardo Espinoza afd637b5ea
feat(editor): Add workflow filters to querystring (#7456)
fixes:
https://linear.app/n8n/issue/ADO-1222/feature-save-filters-in-workflows
2023-11-08 08:42:53 -05:00
कारतोफ्फेलस्क्रिप्ट™ 8171ad4fa8 Merge tag 'n8n@1.16.0' 2023-11-08 14:31:09 +01:00
Ricardo Espinoza 8359364536
feat(editor): Add color selector to sticky node (#7453)
fixes: https://linear.app/n8n/issue/ADO-1223/feature-sticky-colors

---------

Co-authored-by: Giulio Andreini <g.andreini@gmail.com>
Co-authored-by: Mutasem <mutdmour@gmail.com>
2023-11-08 08:23:57 -05:00
github-actions[bot] e5c6a1bdf9
🚀 Release 1.16.0 (#7652)
#
[1.16.0](https://github.com/n8n-io/n8n/compare/n8n@1.15.1...n8n@1.16.0)
(2023-11-08)


### Bug Fixes

* **core:** Comply with custom default for workflow saving settings
([#7634](https://github.com/n8n-io/n8n/issues/7634))
([48c068f](48c068f97b))
* **core:** Decrease reset password token expire time
([#7598](https://github.com/n8n-io/n8n/issues/7598))
([2aa7f63](2aa7f6375a))
* **core:** Ensure `init` before checking leader or follower in
multi-main scenario ([#7621](https://github.com/n8n-io/n8n/issues/7621))
([a994ba5](a994ba5e8d))
* **core:** Ensure pruning starts only after migrations have completed
([#7626](https://github.com/n8n-io/n8n/issues/7626))
([f748de9](f748de9567))
* **core:** Fix accessor error when running partial execution
([#7618](https://github.com/n8n-io/n8n/issues/7618))
([26361df](26361dfcd3)),
closes [#6229](https://github.com/n8n-io/n8n/issues/6229)
* **core:** Make password-reset urls valid only for single-use
([#7622](https://github.com/n8n-io/n8n/issues/7622))
([6031424](60314248f4))
* **Crypto Node:** Fix issue with value not appearing for Sign action
([#7619](https://github.com/n8n-io/n8n/issues/7619))
([5df583f](5df583f783))
* **editor:** Allow overriding theme from query params
([#7591](https://github.com/n8n-io/n8n/issues/7591))
([2854a0c](2854a0cf46))
* **editor:** Fix issue that frontend breaks with unkown nodes
([#7596](https://github.com/n8n-io/n8n/issues/7596))
([db56a9e](db56a9ee37))
* **editor:** Fix local storage flags defaulting to undefined string
([#7603](https://github.com/n8n-io/n8n/issues/7603))
([151e60f](151e60f829))
* **editor:** Fix workflow history prune time limit (getting hours
instead of days) ([#7644](https://github.com/n8n-io/n8n/issues/7644))
([3d5a485](3d5a485bcf))
* **editor:** Hide not supported node options
([#7597](https://github.com/n8n-io/n8n/issues/7597))
([b532a7b](b532a7bdb7))
* **editor:** Remove unknown credentials on pasting workflow
([#7582](https://github.com/n8n-io/n8n/issues/7582))
([d633753](d633753687))
* **editor:** Reset canvas zoom before workspace reset in node view
([#7625](https://github.com/n8n-io/n8n/issues/7625))
([78b84af](78b84af8d1))
* **editor:** Zoom in/out on canvas the same amount on scroll/gesture
([#7602](https://github.com/n8n-io/n8n/issues/7602))
([c92402a](c92402a3ca))
* **Facebook Lead Ads Trigger Node:** Fix issue with missing scope for
business management ([#7616](https://github.com/n8n-io/n8n/issues/7616))
([32b85ba](32b85ba2fe))


### Features

* **core:** Add the node version to telemetry in node_graph_string
([#7449](https://github.com/n8n-io/n8n/issues/7449))
([59dc36a](59dc36abd9))
* **core:** Coordinate workflow activation in multiple main scenario in
internal API ([#7566](https://github.com/n8n-io/n8n/issues/7566))
([c857e42](c857e42677))
* **core:** Initial support for two-way communication over websockets
([#7570](https://github.com/n8n-io/n8n/issues/7570))
([ac87701](ac877014ed))
* **core:** Log executed migrations with info level
([#7586](https://github.com/n8n-io/n8n/issues/7586))
([7dac9ab](7dac9ab82c))
* **core:** Rate limit forgot password endpoint
([#7604](https://github.com/n8n-io/n8n/issues/7604))
([5790e25](5790e251b8))
* **LinkedIn Node:** Add support for Article thumbnails
([#7489](https://github.com/n8n-io/n8n/issues/7489))
([e6d3d1a](e6d3d1a4c2))
* **NocoDB Node:** Add new data apis and workspace support
([#7329](https://github.com/n8n-io/n8n/issues/7329))
([da2d2a8](da2d2a83bb))

Co-authored-by: ivov <ivov@users.noreply.github.com>
2023-11-08 14:20:22 +01:00
Csaba Tuncsik 020042ef1a
fix(editor): Redirect to workflow editor after saving in debug mode (#7645) 2023-11-08 14:04:02 +01:00
Jon 5df583f783
fix(Crypto Node): Fix issue with value not appearing for Sign action (#7619)
Github issue / Community forum post (link here to close automatically):
https://github.com/n8n-io/n8n/issues/7611
2023-11-08 10:22:15 +00:00
mertmit da2d2a83bb
feat(NocoDB Node): Add new data apis and workspace support (#7329)
- Changed old NocoDB logo with new one
To support new release of [NocoDB
(v0.202.4)](https://github.com/nocodb/nocodb/releases/tag/0.202.4):
- Added a new version(3) to support new data apis and workspaces
- Renamed `project` to `base` for new version (kept labels for old
versions for backwards compatibility)

---------

Signed-off-by: mertmit <mertmit99@gmail.com>
Co-authored-by: Jonathan Bennetts <jonathan.bennetts@gmail.com>
2023-11-08 10:04:35 +00:00
Yulian Diaz 32b85ba2fe
fix(Facebook Lead Ads Trigger Node): Fix issue with missing scope for business management (#7616)
Github issue / Community forum post (link here to close automatically): 

Community:
https://community.n8n.io/t/facebook-lead-trigger-issue-with-permissions/32500

GH Issue: https://github.com/n8n-io/n8n/issues/7615
2023-11-08 10:02:18 +00:00
Iván Ovejero 3a776e0132
refactor(core): Stop reporting to Sentry missing-node-on-retry error (no-changelog) (#7648)
https://n8nio.sentry.io/issues/4612370603
2023-11-08 10:09:33 +01:00
Csaba Tuncsik 3d5a485bcf
fix(editor): Fix workflow history prune time limit (getting hours instead of days) (#7644) 2023-11-07 17:44:58 +01:00
Iván Ovejero 48c068f97b
fix(core): Comply with custom default for workflow saving settings (#7634)
https://linear.app/n8n/issue/PAY-982
2023-11-07 16:26:55 +01:00
Tomi Turtiainen ac877014ed
feat(core): Initial support for two-way communication over websockets (#7570)
- Enable two-way communication with web sockets
- Enable sending push messages to specific users
- Add collaboration service for managing active users for workflow

Missing things:
- State is currently kept only in memory, making this not work in
multi-master setups
- Removing a user from active users in situations where they go inactive
or we miss the "workflow closed" message
- I think a timer based solution for this would cover most edge cases.
I.e. have FE ping every X minutes, BE removes the user unless they have
received a ping in Y minutes, where Y > X
- FE changes to be added later by @MiloradFilipovic 

Github issue / Community forum post (link here to close automatically):

---------

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-11-07 17:26:45 +02:00
कारतोफ्फेलस्क्रिप्ट™ a3a26109c6
ci: Conditionally re-enable coverage for frontend packages (no-changelog) (#7641)
Disabled coverage in https://github.com/n8n-io/n8n/pull/7637, but forgot
to conditionally re-enable them for builds on `master`
2023-11-07 15:59:25 +01:00
कारतोफ्फेलस्क्रिप्ट™ f0fc5b16d3
ci(core): Load config schema after process.env has been overwritten (no-changelog) (#7550) 2023-11-07 15:58:28 +01:00
कारतोफ्फेलस्क्रिप्ट™ 60314248f4
fix(core): Make password-reset urls valid only for single-use (#7622) 2023-11-07 15:35:43 +01:00
Ricardo Espinoza b3470fd64d
fix: Error handling on forgot password page (no-changelog) (#7633)
fixes:
https://linear.app/n8n/issue/ADO-1339/fix-error-handling-on-forgot-password-page
2023-11-07 08:45:58 -05:00
कारतोफ्फेलस्क्रिप्ट™ 2f665683fc
ci: Improve CI performance (no-changelog) (#7637)
1. Split backend and frontend tests to avoid them running in parallel
2. Enable coverage only on `master`
2023-11-07 14:19:39 +01:00
Iván Ovejero f748de9567
fix(core): Ensure pruning starts only after migrations have completed (#7626)
https://linear.app/n8n/issue/PAY-986/bug-execution-pruning-timer-is-started-before-the-database-is-ready

---------

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-11-07 13:56:01 +01:00
Iván Ovejero c857e42677
feat(core): Coordinate workflow activation in multiple main scenario in internal API (#7566)
Story: https://linear.app/n8n/issue/PAY-926

This PR coordinates workflow activation on instance startup and on
leadership change in multiple main scenario in the internal API. Part 3
on manual workflow activation and deactivation will be a separate PR.

### Part 1: Instance startup

In multi-main scenario, on starting an instance...
- [x] If the instance is the leader, it should add webhooks, triggers
and pollers.
- [x] If the instance is the follower, it should not add webhooks,
triggers or pollers.
- [x] Unit tests.

### Part 2: Leadership change 

In multi-main scenario, if the main instance leader dies…

- [x] The new main instance leader must activate all trigger- and
poller-based workflows, excluding webhook-based workflows.
- [x] The old main instance leader must deactivate all trigger- and
poller-based workflows, excluding webhook-based workflows.
- [x] Unit tests.

To test, start two instances and check behavior on startup and
leadership change:

```
EXECUTIONS_MODE=queue N8N_LEADER_SELECTION_ENABLED=true N8N_LICENSE_TENANT_ID=... N8N_LICENSE_ACTIVATION_KEY=... N8N_LOG_LEVEL=debug npm run start

EXECUTIONS_MODE=queue N8N_LEADER_SELECTION_ENABLED=true N8N_LICENSE_TENANT_ID=... N8N_LICENSE_ACTIVATION_KEY=... N8N_LOG_LEVEL=debug N8N_PORT=5679 npm run start
```
2023-11-07 13:48:48 +01:00
Mutasem Aldmour 151e60f829
fix(editor): Fix local storage flags defaulting to undefined string (#7603)
useStorage takes the default value `undefined` and sets it in local
storage.. also returns "undefined" as string which breaks onboarding
flows

Github issue / Community forum post (link here to close automatically):
2023-11-07 10:06:08 +01:00
Csaba Tuncsik 78b84af8d1
fix(editor): Reset canvas zoom before workspace reset in node view (#7625) 2023-11-06 18:15:49 +01:00
कारतोफ्फेलस्क्रिप्ट™ 4934462b41
fix(editor): More dark-mode fixes (no-changelog) (#7624)
This fixes:
1. The `OR` divider background when SSO Login is enabled
2. Scanning of QR code in settings in dark mode
2023-11-06 14:32:38 +01:00
Iván Ovejero 26361dfcd3
fix(core): Fix accessor error when running partial execution (#7618)
https://n8nio.sentry.io/issues/3760335947

Followup to #6229
2023-11-06 13:48:13 +01:00
Jan Oberhauser db56a9ee37
fix(editor): Fix issue that frontend breaks with unkown nodes (#7596)
Because of recent changes does the frontend break when a node is not
known.

![Screenshot from 2023-11-03
08-27-43](https://github.com/n8n-io/n8n/assets/6249596/ab340c3c-9b72-4220-b1f8-70d80f7a5522)



Github issue / Community forum post (link here to close automatically):

---------

Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Oleg Ivaniv <me@olegivaniv.com>
2023-11-06 13:44:05 +01:00
Iván Ovejero a994ba5e8d
fix(core): Ensure init before checking leader or follower in multi-main scenario (#7621)
This PR ensures `MultiMainInstancePublisher` is initialized before
checking if the instance is leader or follower. Followers skip license
init, license check, and pruning start and stop.
2023-11-06 12:03:35 +01:00
Iván Ovejero 52f655f3d2
refactor(Google Sheets Node): Stop reporting to Sentry sheet not found error (no-changelog) (#7617)
https://n8nio.sentry.io/issues/4264383378
2023-11-06 11:36:22 +01:00
Ricardo Espinoza b11c4de039
fix(editor): Focus mfa token input (no-changelog) (#7610)
Github issue / Community forum post (link here to close automatically):
2023-11-04 20:34:05 -04:00
Ricardo Espinoza 5790e251b8
feat(core): Rate limit forgot password endpoint (#7604)
Github issue / Community forum post (link here to close automatically):

---------

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <netroy@users.noreply.github.com>
2023-11-03 13:44:12 -04:00
कारतोफ्फेलस्क्रिप्ट™ acec9bad71
refactor(core): Convert OAuth1/OAuth2 routes to decorated controller classes (no-changelog) (#5973) 2023-11-03 17:20:54 +01:00
Omar Ajoue c6049a2e97
feat(editor): Fix some UTM tags (no-changelog) (#7583)
Github issue / Community forum post (link here to close automatically):
2023-11-03 16:17:39 +01:00
Alex Grozav 24dfc95974
feat(editor): Improve performance by importing routes dynamically and add route guards (no-changelog) (#7567)
**Before:**
<img width="657" alt="image"
src="https://github.com/n8n-io/n8n/assets/6179477/0bcced2b-9d3a-43b3-80d7-3c72619941fa">


**After:**
<img width="660" alt="image"
src="https://github.com/n8n-io/n8n/assets/6179477/e74e0bbf-bf33-49b4-ae11-65f640405ac8">
2023-11-03 16:22:37 +02:00
Elias Meire c92402a3ca
fix(editor): Zoom in/out on canvas the same amount on scroll/gesture (#7602)
Github issue / Community forum post (link here to close automatically):

https://community.n8n.io/t/ctrl-mousewheel-zoom-jumps-out-possible-to-avoid/31952
2023-11-03 14:09:18 +01:00
कारतोफ्फेलस्क्रिप्ट™ 0bd4e742da
refactor(core): Migrate from crypto-js to native crypto (#7556)
[`crypto-js` has been
discontinued](1da3dabf93)

PS: We'll remove `crypto-js` usage from `n8n-workflow` and
`@n8n_io/license-sdk` in separate PRs.
2023-11-03 13:26:20 +01:00
Alex Grozav 135f9214f5
feat(editor): Update storybook to 7.5.2 (no-changelog) (#7601)
Github issue / Community forum post (link here to close automatically):
2023-11-03 14:14:51 +02:00
Tomi Turtiainen 2aa7f6375a
fix(core): Decrease reset password token expire time (#7598)
Decrease the expiration time from 1 day to 20 minutes

Github issue / Community forum post (link here to close automatically):
2023-11-03 13:32:08 +02:00
Jan Oberhauser b532a7bdb7
fix(editor): Hide not supported node options (#7597)
Currently Trigger-Nodes and Sub-Nodes display options that do not make
sense or work like:
- Always Output Data
- Execute Once
- On Error

This PR hides those options for nodes that can not make use of them
anyway to not confuse users.

Github issue / Community forum post (link here to close automatically):
2023-11-03 12:18:00 +01:00
Csaba Tuncsik 85e1a10021
refactor(editor): Simplify data count in NDV (no-changelog) (#7568) 2023-11-03 12:07:04 +01:00
Iván Ovejero 6d42fad31a
refactor(core): Consolidate binary file not found errors (no-changelog) (#7585)
Logging was originally to see if there was a binary data file failing to
be written for [this
user](https://linear.app/n8n/issue/PAY-844/filesystem-binary-data-mode-causing-alerts-in-cloud)
but the cause was not a file failed to be written but a missing `fileId`
in a binary data item in an execution. The error should no longer be
thrown as of 1.12. See story for more info.

This PR is for cleanup and to consolidate any file not found errors in
the context of binary data, to track if this happens again.
2023-11-03 11:41:15 +01:00
Jon e6d3d1a4c2
feat(LinkedIn Node): Add support for Article thumbnails (#7489)
Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/linkedin-post-not-showing-image-for-url/10789/


![image](https://github.com/n8n-io/n8n/assets/4688521/5142b984-f531-4731-8510-c7136087861e)

This adds a new property to add a thumbnail binary property for articles
this fixes the previews no longer working because of the LinkedIn API
change.

![image](https://github.com/n8n-io/n8n/assets/4688521/76271525-5791-4bdc-ae73-1fdbb3986694)
2023-11-03 09:50:28 +00:00
Milorad FIlipović 9c55702661
fix(editor): Fix flaky ResourceMapper unit tests (no-changelog) (#7593)
Github issue / Community forum post (link here to close automatically):
2023-11-03 09:56:19 +01:00
कारतोफ्फेलस्क्रिप्ट™ bb2c266e48 Merge tag 'n8n@1.15.1' 2023-11-02 18:11:06 +01:00
Iván Ovejero d633753687
fix(editor): Remove unknown credentials on pasting workflow (#7582)
https://linear.app/n8n/issue/PAY-881
2023-11-02 17:26:39 +01:00
Iván Ovejero 81f43805aa
refactor(core): Stop reporting to Sentry node parameter value extraction failure (no-changelog) (#7587)
https://n8nio.sentry.io/issues/4595192919
2023-11-02 16:28:44 +01:00