Iván Ovejero
70ae90fa3c
refactor: Apply more eslint-plugin-n8n-nodes-base autofixable rules ( #3432 )
...
* ⚡ Update `lintfix` script
* 👕 Remove unneeded lint exceptions
* 👕 Run baseline `lintfix`
* 👕 Apply `node-param-description-miscased-url` (#3441 )
* 👕 Apply `rule node-param-placeholder-miscased-id` (#3443 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply `node-param-option-name-wrong-for-upsert` (#3446 )
* 👕 Apply `node-param-min-value-wrong-for-limit` (#3442 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* Apply `node-param-display-name-wrong-for-dynamic-options` (#3454 )
* 🔨 fix
* ⚡ Fix `Assigned To` fields
Co-authored-by: Michael Kret <michael.k@radency.com>
* 👕 Apply `rule node-param-default-wrong-for-number` (#3453 )
* 👕 Apply `node-param-default-wrong-for-string` (#3452 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* Apply `node-param-display-name-miscased` (#3449 )
* 🔨 fix
* 🔨 exceptions
* ⚡ review fixes
* 👕 Apply `node-param-description-lowercase-first-char` (#3451 )
* ⚡ fix
* ⚡ review fixes
* ⚡ fix
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply `node-param-description-wrong-for-dynamic-options` (#3456 )
* Rule working as intended
* Add rule
* 🔥 Remove repetitions
* 👕 Add exceptions
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Small fix for `node-param-description-wrong-for-dynamic-options`
* 👕 Apply `node-param-default-wrong-for-fixed-collection` (#3460 )
* 👕 Apply `node-param-description-line-break-html-tag` (#3462 )
* 👕 Run baseline `lintfix`
* 👕 Apply `node-param-options-type-unsorted-items` (#3459 )
* ⚡ fix
* 🔨 exceptions
* Add exception for Salesmate and Zoom
Co-authored-by: Michael Kret <michael.k@radency.com>
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* ⚡ Restore `lintfix` command
Co-authored-by: Omar Ajoue <krynble@gmail.com>
Co-authored-by: Michael Kret <88898367+michael-radency@users.noreply.github.com>
Co-authored-by: agobrech <45268029+agobrech@users.noreply.github.com>
Co-authored-by: Michael Kret <michael.k@radency.com>
Co-authored-by: brianinoa <54530642+brianinoa@users.noreply.github.com>
2022-06-03 19:23:49 +02:00
Jan Oberhauser
bdb84130d6
feat(core): Add support for pairedItem (beta) ( #3012 )
...
* ✨ Add pairedItem support
* 👕 Fix lint issue
* 🐛 Fix resolution in frontend
* 🐛 Fix resolution issue
* 🐛 Fix resolution in frontend
* 🐛 Fix another resolution issue in frontend
* ⚡ Try to automatically add pairedItem data if possible
* ⚡ Cleanup
* ⚡ Display expression errors in editor UI
* 🐛 Fix issue that it did not display errors in production
* 🐛 Fix auto-fix of missing pairedItem data
* 🐛 Fix frontend resolution for not executed nodes
* ⚡ Fail execution on pairedItem resolve issue and display information
about itemIndex and runIndex
* ⚡ Allow that pairedItem is only set to number if runIndex is 0
* ✨ Improve Expression Errors
* ⚡ Remove no longer needed code
* ⚡ Make errors more helpful
* ⚡ Add additional errors
* 👕 Fix lint issue
* ⚡ Add pairedItem support to core nodes
* ⚡ Improve support in Merge-Node
* ⚡ Fix issue with not correctly converted incoming pairedItem data
* 🐛 Fix frontend resolve issue
* 🐛 Fix frontend parameter name display issue
* ⚡ Improve errors
* 👕 Fix lint issue
* ⚡ Improve errors
* ⚡ Make it possible to display parameter name in error messages
* ⚡ Improve error messages
* ⚡ Fix error message
* ⚡ Improve error messages
* ⚡ Add another error message
* ⚡ Simplify
2022-06-03 17:25:07 +02:00
Iván Ovejero
336fc9e2a8
feat(core): Allow credential reuse on HTTP Request node ( #3228 )
...
* ✨ Create controller
* ⚡ Mount controller
* ✏️ Add error messages
* ✨ Create scopes fetcher
* ⚡ Account for non-existent credential type
* 📘 Type scopes request
* ⚡ Adjust error message
* 🧪 Add tests
* ✨ Introduce simple node versioning
* ⚡ Add example how to read version in node-code for custom logic
* 🐛 Fix setting of parameters
* 🐛 Fix another instance where it sets the wrong parameter
* ⚡ Remove unnecessary TOODs
* ✨ Re-version HTTP Request node
* 👕 Satisfy linter
* ⚡ Retrieve node version
* ⏪ Undo Jan's changes to Set node
* 🧪 Fix CI/CD for `/oauth2-credential` tests (#3230 )
* 🐛 Fix notice warning missing background color (#3231 )
* 🐛 Check for generic auth in node cred types
* ⚡ Refactor credentials dropdown for HTTP Request node (#3222 )
* ⚡ Discoverability flow (#3229 )
* ✨ Added node credentials type proxy. Changed node credentials input order.
* ⚡ Add computed property from versioning branch
* 🐛 Fix cred ref lost and unsaved
* ⚡ Make options consistent with cred type names
* ⚡ Use prop to set component order
* ⚡ Use constant and version
* ⚡ Fix rendering for generic auth creds
* ⚡ Mark as required on first selection
* ⚡ Implement discoverability flow
* ⚡ Mark as required on subsequent selections
* ⚡ Fix marking as required after cred deletion
* ⚡ Refactor to clean up
* ⚡ Detect position automatically
* ⚡ Add i18n to option label
* ⚡ Hide subtitle for custom action
* ⚡ Detect active credential type
* ⚡ Prop drilling to re-render select
* 🔥 Remove unneeded property
* ✏️ Rename arg
* 🔥 Remove unused import
* 🔥 Remove unneeded getters
* 🔥 Remove unused import
* ⚡ Generalize cred component positioning
* ⚡ Set up request
* 🐛 Fix edge case in endpoint
* ⚡ Display scopes alert box
* ⏪ Revert "Generalize cred comp positioning"
This reverts commit 75eea89273⚡ Consolidate HTTPRN check
* ⚡ Fix hue percentage to degree
* 🔥 Remove unused import
* 🔥 Remove unused import
* 🔥 Remove unused class
* 🔥 Remove unused import
* 📘 Create type for HTTPRN v2 auth params
* ✏️ Rename check
* 🔥 Remove unused import
* ✏️ Add i18n to `reportUnsetCredential()`
* ⚡ Refactor Alex's spacing changes
* ⚡ Post-merge fixes
* ⚡ Add docs link
* 🔥 Exclude Notion OAuth cred
* ✏️ Update copy
* ✏️ Rename param
* 🎨 Reposition notice and simplify styling
* ✏️ Update copy
* ✏️ Update copy
* ⚡ Hide params during custom action
* ⚡ Show notice if any cred type supported
* 🐛 Prevent scopes text overflow
* 🔥 Remove superfluous check
* ✏️ Break up docstring
* 🎨 Tweak notice styling
* ⚡ Reorder cred param in Webhook node
* ✏️ Shorten cred name in scopes notice
* 🧪 Update Notice snapshots
* 🐛 Fix check when `globalRole` is `undefined`
* ⏪ Revert 3f2c4a6⚡ Apply feedback from Product
* 🧪 Update snapshot
* ⚡ Adjust regex expansion pattern for singular
* 🔥 Remove unused import
* 🔥 Remove logging
* ⚡ Make `somethingElse` key more unique
* ⚡ Move something else to constants
* ⚡ Consolidate notice component
* ⚡ Apply latest feedback
* 🧪 Update tests
* 🧪 Update snapshot
* ✏️ Fix singular version
* 🧪 Finalize tests
* ✏️ Rename constant
* 🧪 Expand tests
* 🔥 Remove `truncate` prop
* 🚚 Move scopes fetching to store
* 🚚 Move method to component
* ⚡ Use constant
* ⚡ Refactor `Notice` component
* 🧪 Update tests
* 🔥 Remove unused keys
* ⚡ Inject custom API call option
* 🔥 Remove unused props
* 🎨 Use `compact` prop
* 🧪 Update snapshots
* 🚚 Move scopes to store
* 🚚 Move `nodeCredentialTypes` to parent
* ✏️ Rename cred types per branding
* 🐛 Clear scopes when none
* ⚡ Add default
* 🚚 Move `newHttpRequestNodeCredentialType` to parent
* 🔥 Remove test data
* ⚡ Separate lines for readability
* ⚡ Change reference from node to node name
* ✏️ Rename i18n keys
* ⚡ Refactor OAuth check
* 🔥 Remove unused key
* 🚚 Move `OAuth1/2 API` to i18n
* ⚡ Refactor `skipCheck`
* ⚡ Add `stopPropagation` and `preventDefault`
* 🚚 Move active credential scopes logic to store
* 🎨 Fix spacing for `NodeWebhooks` component
* ⚡ Implement feedback
* ⚡ Update HTTPRN default and issue copy
* Refactor to use `CredentialsSelect` param (#3304 )
* ⚡ Refactor into cred type param
* ⚡ Componentize scopes notice
* 🔥 Remove unused data
* 🔥 Remove unused `loadOptions`
* ⚡ Componentize `NodeCredentialType`
* 🐛 Fix param validation
* 🔥 Remove dup methods
* ⚡ Refactor all references to `isHttpRequestNodeV2`
* 🎨 Fix styling
* 🔥 Remove unused import
* 🔥 Remove unused properties
* 🎨 Fix spacing for Pipedrive Trigger node
* 🎨 Undo Webhook node styling change
* 🔥 Remove unused style
* ⚡ Cover `httpHeaderAuth` edge case
* 🐛 Fix `this.node` reference
* 🚚 Rename to `credentialsSelect`
* 🐛 Fix mistaken renaming
* ⚡ Set one attribute per line
* ⚡ Move condition to instantiation site
* 🚚 Rename prop
* ⚡ Refactor away `prepareScopesNotice`
* ✏️ Rename i18n keys
* ✏️ Update i18n calls
* ✏️ Add more i18n keys
* 🔥 Remove unused props
* ✏️ Add explanatory comment
* ⚡ Adjust check in `hasProxyAuth`
* ⚡ Refactor `credentialSelected` from prop to event
* ⚡ Eventify `valueChanged`, `setFocus`, `onBlur`
* ⚡ Eventify `optionSelected`
* ⚡ Add `noDataExpression`
* 🔥 Remove logging
* 🔥 Remove URL from scopes
* ⚡ Disregard expressions for display
* 🎨 Use CSS modules
* 📘 Tigthen interface
* 🐛 Fix generic auth display
* 🐛 Fix generic auth validation
* 📘 Loosen type
* 🚚 Move event params to end
* ⚡ Generalize reference
* ⚡ Refactor generic auth as `credentialsSelect` param
* ⏪ Restore check for `httpHeaderAuth `
* 🚚 Rename `existing` to `predefined`
* Extend metrics for HTTP Request node (#3282 )
* ⚡ Extend metrics
* 🧪 Add tests
* ⚡ Update param names
Co-authored-by: Alex Grozav <alex@grozav.com>
* ⚡ Update check per new branch
* ⚡ Include generic auth check
* ⚡ Adjust telemetry (#3359 )
* ⚡ Filter credential types by label
Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
Co-authored-by: Alex Grozav <alex@grozav.com>
2022-05-24 11:36:19 +02:00
Iván Ovejero
63b6c9f128
refactor: Apply more eslint-plugin-n8n-nodes-base autofixable rules ( #3243 )
...
* ✏️ Alphabetize rules
* 🔖 Update version
* ⚡ Update lintfix command
* ⚡ Run baseline lintfix
* 📦 Update package-lock.json
* 👕 Apply `node-param-description-untrimmed` (#3200 )
* Removing unneeded backticks (#3249 )
* 👕 Apply node-param-description-wrong-for-return-all (#3253 )
* 👕 Apply node-param-description-missing-limit (#3252 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply node-param-description-excess-final-period (#3250 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply node-param-description-unencoded-angle-brackets (#3256 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply node-param-description-url-missing-protocol (#3258 )
* 👕 Apply `node-param-description-miscased-id` (#3254 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply node-param-description-wrong-for-limit (#3257 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply node-param-description-wrong-for-ignore-ssl-issues (#3261 )
* 👕 Apply rule
* ⚡ Restore lintfix script
* ⚡ Restore lintfix script
Co-authored-by: agobrech <45268029+agobrech@users.noreply.github.com>
Co-authored-by: Omar Ajoue <krynble@gmail.com>
Co-authored-by: Michael Kret <88898367+michael-radency@users.noreply.github.com>
2022-05-06 23:01:25 +02:00
Omar Ajoue
d3fecb9f6d
🎨 Centralize error throwing for encryption keys and credentials ( #3105 )
...
* Centralized error throwing for encryption key
* Unifying the error message used by cli and core packages
* Improvements to error messages to make it more DRY
* Removed unnecessary throw
* Throwing error when credential does not exist to simplify node behavior (#3112 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
2022-04-15 08:00:47 +02:00
TheFSilver
bd9064cd0e
feat(HTTP Request Node): Add support for OPTIONS method ( #3030 )
2022-03-25 22:55:43 +01:00
Justin Halter
8a88f948f2
feat(HTTP Request Node): Allow Delete requests with body ( #2900 )
...
delete request with body parameters
Co-authored-by: Justin Halter <jhalter@weare5stones.com>
2022-03-19 20:09:42 +01:00
Harshil Agrawal
9335ee5deb
⚡ Update Codex files ( #2797 )
2022-02-11 13:20:42 +01:00
Jan Oberhauser
1566dafb3e
🐛 Make sure that header keys are always lower case #2663
2022-01-21 10:55:19 +01:00
Ahsan Virani
224ef736de
🐛 Binary data handling fixes ( #2629 )
...
* Update node airtable
* Update nodenextcloud
* Update node spreadsheet
* Update node cortex, dropbox, editImage nodes
* Update node emailSend
* Update node ftp
* Update node googleDrive
* Update node googleDrive fix
* Update node youtube
* Update node htmlExtract
* Update node linkedIn
* Update node mailgun
* Update node matrix
* Update node pipedrive
* Update node readPdf
* Update node facebookGraphApi
* Update node httpRequest
* Update node nocoDB
* Update node httpRequest, respondToWebhook
* Update node signi4
* Update node slack
* Update node zulip
* cleanup
* fix generic funcs
* 🐛 Fix EditImage Node
Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
2022-01-03 22:42:42 +01:00
Jan Oberhauser
6453996de3
✨ Add support for Query Auth
2021-12-05 17:00:41 +01:00
Iván Ovejero
0764c49dcf
🔥 Remove line breaks from param descriptions ( #2473 )
...
* 🔥 Remove line breaks from param descriptions
* 🔥 Remove more line breaks
* 🎨 Fix spacing for list item in tooltip
* ⚡ Apply multiline with <p> tags
* ⚡ Improve <code> and <a> tags
* ✏️ Improve grammar and spelling
* ⚡ Add missing <p> tags
* ✏️ Make "multiple" phrasing consistent
* ⚡ Fix unneeded quote escapes
* ⚡ Encode angle brackets
* ⚡ Fix typo and copy-paste artifact
2021-11-25 18:10:06 +01:00
Jan Oberhauser
d0bde5e0c6
🔀 Merge branch 'master' into fix/http-request-node
2021-11-19 10:19:48 +01:00
Iván Ovejero
766f74c782
🚚 Directorize and alphabetize nodes ( #2445 )
...
* 🚚 Directorize nodes
* ⚡ Alphabetize nodes and credentials
* 🔥 Remove unused node
* 🔥 Remove unused codex
* 🔥 Remove duplicate cred file references
* 🐛 Fix node file paths
* 🔥 Remove duplicate node reference
2021-11-17 17:30:14 +01:00
