Commit graph

7399 commits

Author SHA1 Message Date
Iván Ovejero a1259898c0
feat(editor): Inline expression editor (#4814)
* WIP

* 🔥 Remove unneeded watch

*  Further setup

*  Fix import

*  Minor tweaks

* 🔥 Remove logging

* 🎨 Add some styling

* 🎨 More styling changes

* 🐛 Fix wrong marking of stale data

* 🎨 Prevent fx on dragging

* 🔥 Remove logging

*  Refine draggable target offsets

* refactor(editor): Consolidate expression management logic (#4836)

*  Extract `ExpressionFunctionIcon`

*  Simplify syntax

*  Move to mixin

* 🎨 Format

* 📘 Unify types

*  Dedup double brace handler

*  Consolidate resolvable highlighter

* 🎨 Format

*  Consolidate language pack

* ✏️ Add comment

*  Move completions to plugins

*  Partially deduplicate themes

* refactor(editor): Apply styling feedback to inline expression editor (#4846)

* 🎨 Adjust styling for expression parameter input

* 🎨 Style outputs differently

*  Set single line for RLC

* 🎨 Style both openers identically

* 🐛 Prevent defocus on resize

*  Adjust line height

* 🎨 Adjust border with for expression input

*  Fix font family for inline output

*  Set up telemetry

*  Complete telemetry

*  Simplify event source

*  Set monospaced font for inline output

* 🎨 Hide cursor on schema pill drop

* 🧪 Update snapshots

*  Consolidate editor styles

* ✏️ Add tech debt comments

*  Improve naming

*  Improve inside resolvable detection

*  Improve var naming

* 🔥 Remove outdated comment

* 🚚 Move constant to data

* ✏️ Clarify comments

* 🔥 Remove outdated comments

* 🔥 Remove unneeded try-catch

* 🔥 Remove unneeded method

* 🔥 Remove unneeded check

* 🔥 Remove `openExpression` check

* 🔥 Remove unused timeout

* 🔥 Remove commented out sections

*  Use Pinia naming convention

*  Re-evaluate on change of `ndvInputData`

* 🐛 Fix handling of `0` in number-type input

* 🐛 Surface focus and blur for mapping hints

* 🔥 Remove logging

* ✏️ Reword error

*  Change kebab-case to PascalCase

*  Refactor state fields for clarity

*  Support double bracing on selection

* 🎨 More styling

*  Miscellaneous cleanup

*  Disregard error on drop

* 🎨 Fix schema pill styling

* 🎨 More `background` to `background-color` fixes

* 🧪 Update snapshots

* 🎨 Replace non-existing var with white

* 🧪 Update snapshot

* 📦 Integrate `codemirror-lang-n8n-expression`

* 🎨 Fix formatting

* 🧪 Re-update test snapshots

* 🧪 Update selectors for inline editor

* 🔥 Remove unused test ID

* 📘 Add type for `currentNodePaneType`

*  Refactor mixin to util

*  Use `:global`

* 🔥 Remove comment

*  Add watch

*  Change import style

* 👕 Fix lint

*  Refactor preventing blur on resize

* 🔥 Remove comment

* 🧪 Re-update snapshots

* 🎨 Prettify

* 👕 Fix lint

* 🔥 Remove comment

Co-authored-by: Mutasem <mutdmour@gmail.com>
2022-12-14 14:43:02 +01:00
Alex Grozav f73267ffa5
fix: Update permission for showing workflow caller policy (#4916)
* fix: Update permission for showing workflow caller polic

* fix: remove unused store setting
2022-12-14 15:42:21 +02:00
Alex Grozav 990d13d366
feat: Update last credential accessor removal message (no-changelog) (#4925) 2022-12-14 15:31:31 +02:00
Alex Grozav 1bcfb39698
feat: Update credential sharing messages (no-changelog) (#4927)
feat: Update cred sharing messages
2022-12-14 15:25:36 +02:00
कारतोफ्फेलस्क्रिप्ट™ 8675b45e43
fix: Improve VSCode debugging setup (no-changelog) (#4922)
* gracefully shutdown n8n while debugging in vscode

* capture stdout/stderr in vscode debugging instead of just the console.logs
2022-12-14 11:59:06 +01:00
Milorad FIlipović 69e9bf082b
test(editor): Add e2e tests for undo/redo (#4904)
*  Added history store and mixin
*  Implemented node position change undo/redo
*  Implemented move nodes bulk command
*  Not clearing the redo stack after pushing the bulk command
* 🔨 Implemented commands using classes
* 🔥 Removed unnecessary interfaces and actions
* 🔥 Removing unused constants
* 🔨 Refactoring classes file
*  Adding eventBus to command obects
*  Added undo/redo support for adding and removing nodes
*  Implemented initial add/remove connections undo support
*  Covering some corner cases with reconnecting nodes
*  Adding undo support for reconnecting nodes
*  Fixing going back and forward between undo and redo
*  Implemented async command revert
*  Preventing push to undo if bulk redo/undo is in progress
*  Handling re-connecting nodes and stopped pushing empty bulk actions to undo stack
*  Handling adding a node between two connected nodes
*  Handling the case of removing multiple connections on the same index. Adding debounce to undo/redo keyboard calls
*  Removing unnecessary timeouts, adding missing awaits, refactoring
*  Resetting history when opening new workflow, fixing incorrect bulk recording when inserting node
* ✔️ Fixing lint error
*  Minor refactoring + some temporary debugging logs
*  Preserving node properties when undoing it's removal, removing some unused repaint code
*  Added undo/redo support for import workflow and node enable/disable
* 🔥 Removing some unused constant
*  Added undo/redo support for renaming nodes
*  Fixing rename history recording
*  Added undo/redo support for duplicating nodes
* 📈 Implemented telemetry events
* 🔨 A bit of refactoring
*  Fixing edgecases in removing connection and moving nodes
*  Handling case of adding duplicate nodes when going back and forward in history
*  Recording connections added directly to store
*  Moving main history reset after wf is opened
* 🔨 Simplifying rename recording
* 📈 Adding NDV telemetry event, updating existing event name case
* 📈 Updating telemetry events
*  Added initial undo/redo tests
*  Fixing duplicate connections on undo/redo
*  Stopping undo events from firing constantly on keydown
*  Added connection test for undo/redo
* 📈 Updated telemetry event for hitting undo in NDV
*  Adding undo support for disabling nodes using keyboard shortcuts
*  Added more tests for adding and deleting nodes undo/redo
*  Preventing adding duplicate connection commands to history
* 📈 Adding connection assertions to delete node tests
*  Clearing redo stack when new change is added
*  Preventing adding connection actions to undo stack while redoing them
* 👌 Addressing PR comments part 1
* 👌 Moving undo logic for disabling nodes to `NodeView`
* 👌 Implemented command comparing logic
*  Fix for not clearing redo stack on every user action
*  Fixing recording when moving nodes
*  Fixing undo for moving connections
*  Fixing tracking new nodes after latest merge
*  Fixing broken bulk delete
*  Added tests for moving nodes
*  Added tests for deleting connections
*  Added tests for disabling nodes
*  Added node rename tests
*  Added tests for duplicating and pasting nodes
*  Added multi-step undo/redo tests
*  Fixing assertion condition
*  Fixing timeout issue between keyboard strokes
* ⬆️ Updating pnpm lock file
*  Waiting for page load to finish before each test
*  Adding proper handling of meta key press
* 🚨 Temporarily disabling slack notifications
*  Adding check before clicking connection actions
*  Removing comments from other undo tests
* 🎨 Fixing a typo
2022-12-14 10:33:44 +01:00
Iván Ovejero 5ca2148c7e
refactor(editor): Apply Prettier (no-changelog) (#4920)
*  Adjust `format` script

* 🔥 Remove exemption for `editor-ui`

* 🎨 Prettify

* 👕 Fix lint
2022-12-14 10:04:10 +01:00
Alex Grozav bcde07e032
feat: Set all resources view as default subview (#4919) 2022-12-14 10:29:35 +02:00
OlegIvaniv 74100d3d5b
fix(editor): Do not show actions dialog for actionless triggers when selected via keyboard (#4911) 2022-12-13 16:47:03 +01:00
Jan Oberhauser 1b07505603 📚 Update CHANGELOG.md and main package.json to 0.207.1 2022-12-13 09:45:04 -06:00
Iván Ovejero 66fdc53808
fix: Update pnpm-lock to fix build (#4910)
📦 Update pnpm-lock
2022-12-13 16:42:05 +01:00
freya 0f40ca39ba
feat(core): Allow for hiding usage page via environment (#4899) 2022-12-13 13:59:22 +00:00
Jan Oberhauser de4b4bee9b 🔖 Release n8n@0.207.1 2022-12-13 13:18:03 +00:00
Jan Oberhauser f5bba9cf31 ⬆️ Set n8n-editor-ui@0.173.1 and n8n-nodes-base@0.205.1 on n8n 2022-12-13 13:18:03 +00:00
Jan Oberhauser 3bca6a98b6 🔖 Release n8n-editor-ui@0.173.1 2022-12-13 13:15:41 +00:00
Jan Oberhauser 78dabeb552 🔖 Release n8n-nodes-base@0.205.1 2022-12-13 13:14:36 +00:00
Csaba Tuncsik 0b6d47086a
fix(editor): Schema view render empty data (#4902)
* fix(editor): Schema view render empty data

* fix(editor): Schema view switch n8n-alert with n8n-info-tip

* Revert "fix(editor): Schema view render empty data"

This reverts commit 0294b5e8 for Alert component

* chore(editor): code styling fix

* fix(editor): Table view empty data hint

* Revert "fix(editor): Table view empty data hint"

This reverts commit d42dabf2c5.
2022-12-13 14:00:20 +01:00
Jonathan Bennetts 7d7fe34f5d
docs: Add codex file to Venafi TLS Protect Cloud Trigger (#4367) 2022-12-13 11:38:00 +00:00
OlegIvaniv 297a043875
test(editor): Fix flaky workflow tags e2e tests and store screenshots from CI runs (#4903)
* test(editor): Fix flaky add tags e2e specs, and upload cypress artifacts on failure

* Only run smoke test to debug the pipeline

* Add waitForLoad command and revert debugging changes
2022-12-13 11:55:51 +01:00
Alex Grozav b4d3f12b51
feat: Update readonly node notice when using foreign credentials (no-changelog) (#4895) 2022-12-13 10:55:31 +02:00
Milorad FIlipović 3fc2d7cc5a
fix(editor): Fix for wrong keycode when shift is pressed (#4898) 2022-12-12 17:39:33 +01:00
कारतोफ्फेलस्क्रिप्ट™ 91e9a88e3a
fix: Ensure parent directory exists before copying over the icons to generated static directory (#4865)
fix: Ensure parent directory exists before copying over the icon to generated static directory.

This fixes the issue of icons not showing up for custom nodes that use a package-name with a `/` in them.
2022-12-12 16:41:18 +01:00
Jan Oberhauser 61aafc9873 📚 Update CHANGELOG.md and main package.json to 0.207.0 2022-12-12 09:03:33 -06:00
Jan Oberhauser 2958729863 🔖 Release n8n@0.207.0 2022-12-12 14:59:11 +00:00
Jan Oberhauser 2ef5fea802 ⬆️ Set n8n-core@0.147.0, n8n-editor-ui@0.173.0, n8n-nodes-base@0.205.0 and n8n-workflow@0.129.0 on n8n 2022-12-12 14:59:11 +00:00
Jan Oberhauser 965584460b 🔖 Release n8n-editor-ui@0.173.0 2022-12-12 14:57:04 +00:00
Jan Oberhauser f942e1a0d3 ⬆️ Set n8n-design-system@0.47.0 and n8n-workflow@0.129.0 on n8n-editor-ui 2022-12-12 14:57:03 +00:00
Jan Oberhauser 1726918c68 🔖 Release n8n-design-system@0.47.0 2022-12-12 14:56:46 +00:00
Jan Oberhauser 00ee8a5962 🔖 Release n8n-nodes-base@0.205.0 2022-12-12 14:55:48 +00:00
Jan Oberhauser 597df229dd ⬆️ Set n8n-core@0.147.0 and n8n-workflow@0.129.0 on n8n-nodes-base 2022-12-12 14:55:47 +00:00
Jan Oberhauser a63026d416 🔖 Release n8n-node-dev@0.86.0 2022-12-12 14:55:36 +00:00
Jan Oberhauser cb3703f0b4 ⬆️ Set n8n-core@0.147.0 and n8n-workflow@0.129.0 on n8n-node-dev 2022-12-12 14:55:36 +00:00
Jan Oberhauser 23055773c0 🔖 Release n8n-core@0.147.0 2022-12-12 14:55:27 +00:00
Jan Oberhauser 406b9519b2 ⬆️ Set n8n-workflow@0.129.0 on n8n-core 2022-12-12 14:55:27 +00:00
Jan Oberhauser 4f0b1cde4d 🔖 Release n8n-workflow@0.129.0 2022-12-12 14:55:17 +00:00
Alex Grozav c013245db7
feat: Add sharing permissions info for workflow sharees (#4892)
* feat: Add sharing permissions info for workflow sharees

* fix: Remove infotip for owner
2022-12-12 14:46:34 +02:00
Alex Grozav 1cce8eaf16
fix(editor): Fix credential sharing issues handler when no matching id or name (#4879)
* fix: fix credential sharing issues handler when no matching id or name

* feat: Show erroring credential name as placeholder when available

* feat: Add (unavailable) descriptor for unavailable credentials
2022-12-12 14:46:10 +02:00
Alex Grozav 74b831b9b7
fix: Update translation for sharing toast (no-changelog) (#4893) 2022-12-12 14:45:45 +02:00
Alex Grozav ca8e85933f
fix: Remove delete sharee prompt except when deleting last cred accessor (no-changelog) (#4894)
* fix: Remove delete sharee prompt except when deleting last cred accessor (no-changelog)

* chore: Remove unused translation
2022-12-12 14:44:29 +02:00
Alex Grozav 7d2e2ee0f7
fix: Remove foreign credentials when copying nodes or duplicating workflow (#4880)
* fix: Remove foreign credentials when copying nodes or duplicating workflow

* chore: fix linting issue
2022-12-12 12:59:16 +02:00
Alex Grozav 4765d767e3
feat: Update credential test error message for sharees (#4864) 2022-12-12 11:53:22 +02:00
Alex Grozav 6f1b78df98
feat: Handle sharing features when user skips owner setup (#4850) 2022-12-12 11:53:02 +02:00
Csaba Tuncsik b0c158c64f
fix(editor): Schema view shows checkbox in case of empty data (#4889)
* fix(editor): Schema view show nothing in case of empty data

* fix(editor): Schema view test for empty data
2022-12-12 10:08:29 +01:00
Iván Ovejero 07b2f7678c
fix(core): Remove nodeGetter checks (#4883)
🔥 Remove `nodeGetter` checks
2022-12-12 09:46:53 +01:00
OlegIvaniv b689d2d7c2
fix(editor): Avoid adding manual trigger node when webhook node is added (#4887) 2022-12-12 09:34:34 +01:00
कारतोफ्फेलस्क्रिप्ट™ b80e38817d
ci: Add libc6-compat to nightly docker builds (no-changelog) (#4885)
ci: add libc6-compat to nightly docker build (no-changelog)
2022-12-11 21:15:13 +01:00
कारतोफ्फेलस्क्रिप्ट™ 3b969d2cd1
fix(Move Binary Data Node): Stringify objects before encoding them in MoveBinaryData (#4882)
* stringify objects before encoding them objects in MoveBinaryData

* add fileSize and fileType on MoveBinaryData converted data

* show `view` option for text files as well

* improve how JSON binary data is shown in the UI
2022-12-11 14:10:54 +01:00
कारतोफ्फेलस्क्रिप्ट™ f4481e24e8
ci: Upgrade pnpm and turborepo (no-changelog) (#4878) 2022-12-09 17:16:26 +01:00
Milorad FIlipović 983c5447c5
fix(editor): Fix for broken tab navigation (#4881)
🐛 Fixing broken tab navigation
2022-12-09 15:32:01 +01:00
Milorad FIlipović b2aba48dfe
feat(editor): Add undo/redo support for canvas actions (#4787)
*  Added history store and mixin
*  Implemented node position change undo/redo
*  Implemented move nodes bulk command
*  Not clearing the redo stack after pushing the bulk command
* 🔨 Implemented commands using classes
* 🔥 Removed unnecessary interfaces and actions
* 🔥 Removing unused constants
* 🔨 Refactoring classes file
*  Adding eventBus to command obects
*  Added undo/redo support for adding and removing nodes
*  Implemented initial add/remove connections undo support
*  Covering some corner cases with reconnecting nodes
*  Adding undo support for reconnecting nodes
*  Fixing going back and forward between undo and redo
*  Implemented async command revert
*  Preventing push to undo if bulk redo/undo is in progress
*  Handling re-connecting nodes and stopped pushing empty bulk actions to undo stack
*  Handling adding a node between two connected nodes
*  Handling the case of removing multiple connections on the same index. Adding debounce to undo/redo keyboard calls
*  Removing unnecessary timeouts, adding missing awaits, refactoring
*  Resetting history when opening new workflow, fixing incorrect bulk recording when inserting node
* ✔️ Fixing lint error
*  Minor refactoring + some temporary debugging logs
*  Preserving node properties when undoing it's removal, removing some unused repaint code
*  Added undo/redo support for import workflow and node enable/disable
* 🔥 Removing some unused constant
*  Added undo/redo support for renaming nodes
*  Fixing rename history recording
*  Added undo/redo support for duplicating nodes
* 📈 Implemented telemetry events
* 🔨 A bit of refactoring
*  Fixing edgecases in removing connection and moving nodes
*  Handling case of adding duplicate nodes when going back and forward in history
*  Recording connections added directly to store
*  Moving main history reset after wf is opened
* 🔨 Simplifying rename recording
* 📈 Adding NDV telemetry event, updating existing event name case
* 📈 Updating telemetry events
*  Fixing duplicate connections on undo/redo
*  Stopping undo events from firing constantly on keydown
* 📈 Updated telemetry event for hitting undo in NDV
*  Adding undo support for disabling nodes using keyboard shortcuts
*  Preventing adding duplicate connection commands to history
*  Clearing redo stack when new change is added
*  Preventing adding connection actions to undo stack while redoing them
* 👌 Addressing PR comments part 1
* 👌 Moving undo logic for disabling nodes to `NodeView`
* 👌 Implemented command comparing logic
*  Fix for not clearing redo stack on every user action
*  Fixing recording when moving nodes
*  Fixing undo for moving connections
*  Fixing tracking new nodes after latest merge
*  Fixing broken bulk delete
*  Preventing undo/redo when not on main node view tab
* 👌 Addressing PR comments
* 👌 Addressing PR comment
2022-12-09 15:07:37 +01:00