Michael Kret
b7aea957b8
feat: Do not show errors not processed by n8n (no-changelog) ( #9598 )
...
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2024-06-20 08:45:00 +03:00
कारतोफ्फेलस्क्रिप्ट™
216ec079c9
feat(editor): Create separate components for JS and JSON editors (no-changelog) ( #8156 )
...
## Summary
This is part-1 of refactoring our code editors to extract different type
of editors into their own components.
In part-2 we'll
1. delete a of unused or duplicate code
2. switch to a `useEditor` composable to bring more UX consistency
across all the code editors.
## Review / Merge checklist
- [x] PR title and summary are descriptive
- [x] Tests included
2023-12-29 10:49:27 +01:00
कारतोफ्फेलस्क्रिप्ट™
6aa7b93473
refactor(core): Deprecate prepareOutputData (no-changelog) ( #7091 )
2023-09-05 12:59:02 +02:00
कारतोफ्फेलस्क्रिप्ट™
dfe0fa65f8
fix(Code Node): Switch over to vm2 fork ( #7018 )
...
[Fork is here](https://github.com/n8n-io/vm2 ). Currently there are no
modifications in it.
2023-08-30 11:17:04 +02:00
कारतोफ्फेलस्क्रिप्ट™
bcbec52552
fix(Code Node): Update vm2 to address CVE-2023-32313 ( #6318 )
...
GH advisory: https://github.com/advisories/GHSA-p5gc-c584-jj6v
2023-05-25 12:55:53 +02:00
कारतोफ्फेलस्क्रिप्ट™
308a94311f
refactor: Async functions don't need to explicitly return promises (no-changelog) ( #6041 )
2023-04-24 13:17:08 +02:00
कारतोफ्फेलस्क्रिप्ट™
7a4e9ef5fa
refactor: Remove n8n-core dependency in nodes-base (no-changelog) ( #5649 )
2023-03-09 18:13:15 +01:00
Michael Kret
bb4db58819
fix(core): Remove linting exceptions in nodes-base, @typescript-eslint/no-unsafe-argument (no-changelog)
2023-02-28 05:39:43 +02:00
Iván Ovejero
b03e358a12
refactor: Integrate consistent-type-imports in nodes-base (no-changelog) ( #5267 )
...
* 👕 Enable `consistent-type-imports` for nodes-base
* 👕 Apply to nodes-base
* ⏪ Undo unrelated changes
* 🚚 Move to `.eslintrc.js` in nodes-base
* ⏪ Revert "Enable `consistent-type-imports` for nodes-base"
This reverts commit 529ad72b05👕 Fix severity
2023-01-27 12:22:44 +01:00
Michael Kret
6608e69457
refactor(core): Remove linting exceptions in nodes-base (no-changelog) ( #4944 )
2023-01-13 18:11:56 +01:00
कारतोफ्फेलस्क्रिप्ट™
c738aa53e9
docs: Fix all credential documentation urls, and add a CI job to regularly validate these urls ( #5012 )
...
* add or update documentation URLs for all credentials
* add UTM params to documentation urls even when they are absolute urls
* Setup a CI job to validate documentation urls after every release
* Fix FacebookGraphApi documentation URL
* also validate node documentation urls
Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
2022-12-22 17:01:29 +01:00
Michael Kret
61e26804ba
refactor(core): Remove linting exceptions in nodes-base ( #4794 )
...
* ⚡ enabled array-type
* ⚡ await-thenable on
* ⚡ ban-types on
* ⚡ default-param-last on
* ⚡ dot-notation on
* ⚡ member-delimiter-style on
* ⚡ no-duplicate-imports on
* ⚡ no-empty-interface on
* ⚡ no-floating-promises on
* ⚡ no-for-in-array on
* ⚡ no-invalid-void-type on
* ⚡ no-loop-func on
* ⚡ no-shadow on
* ⚡ ban-ts-comment re enabled
* ⚡ @typescript-eslint/lines-between-class-members on
* address my own comment
* @typescript-eslint/return-await on
* @typescript-eslint/promise-function-async on
* @typescript-eslint/no-unnecessary-boolean-literal-compare on
* @typescript-eslint/no-unnecessary-type-assertion on
* prefer-const on
* @typescript-eslint/prefer-optional-chain on
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2022-12-02 21:54:28 +01:00
Michael Kret
9d6a2c32d7
refactor(core): fixes n8n-local-rules/no-json-parse-json-stringify warnings ( #4407 )
...
* 🔨 fixes
* 🔨 set rule to error
2022-10-21 17:24:58 +02:00
Iván Ovejero
1db4fa2bf8
feat(Code Node): create Code node ( #3965 )
...
* Introduce node deprecation (#3930 )
✨ Introduce node deprecation
* 🚧 Scaffold out Code node
* 👕 Fix lint
* 📘 Create types file
* 🚚 Rename theme
* 🔥 Remove unneeded prop
* ⚡ Override keybindings
* ⚡ Expand lintings
* ⚡ Create editor content getter
* 🚚 Ensure all helpers use `$`
* ✨ Add autocompletion
* ⚡ Filter out welcome note node
* ⚡ Convey error line number
* ⚡ Highlight error line
* ⚡ Restore logging from node
* ✨ More autocompletions
* ⚡ Streamline completions
* ✏️ Update placeholders
* ⚡ Update linter to new methods
* 🔥 Remove `$nodeItem` completions
* ⚡ Re-update placeholders
* 🎨 Fix formatting
* 📦 Update `package-lock.json`
* ⚡ Refresh with multi-line empty string
* ⚡ Account for syntax errors
* 🔥 Remove unneeded variant
* ⚡ Minor improvements
* ⚡ Add more autocompletions
* 🚚 Rename extension
* 🔥 Remove outdated comments
* 🚚 Rename field
* ✨ More autocompletions
* ⚡ Fix up error display when empty text
* 🔥 Remove logging
* ✨ More error validation
* 🐛 Fix `pairedItem` to `pairedItem()`
* ⚡ Add item to validation info
* 📦 Update `package-lock.json`
* ⚡ Leftover fixes
* ⚡ Set `insertNewlineAndIndent`
* 📦 Update `package-lock.json`
* 📦 Re-update `package-lock.json`
* 👕 Add lint exception
* 📘 Add type to mixin type
* Clean up comment
* ⚡ Refactor completion per new requirements
* ⚡ Adjust placeholders
* ⚡ Add `json` autocompletions for `$input`
* 🎨 Set border
* ⚡ Restore local completion source
* ⚡ Implement autocompletion for imports
* ⚡ Add `.*` to follow user typing on autocompletion
* 📘 Fix typings in autocompletions
* 👕 Add linting for use of `item()`
* 📦 Update `package-lock.json`
* 🐛 Fix for `$items(nodeName)[0]`
* ⚡ Filter down built-in modules list
* ⚡ Refactor error handling
* ⚡ Linter and validation improvements
* ⚡ Apply review feedback
* ♻️ More general refactorings
* ⚡ Add dot notation utility
* Customize input handler
* ⚡ Support `.json.` completions
* ⚡ Adjust placeholder
* ⚡ Sort imports
* 🔥 Remove blank rows addition
* ⚡ Add more error validation
* 📦 Update `package-lock.json`
* ⚡ Make date logging consistent
* 🔧 Adjust linting highlight range
* ⚡ Add line numbers to each item mode errors
* ⚡ Allow for links in error descriptions
* ⚡ More input validation
* ⚡ Expand linting to loops
* ⚡ Deprecate Function and Function Item nodes
* 🐛 Fix placeholder syntax
* 📘 Narrow down type
* 🚚 Rename using kebab-case
* 🔥 Remove `mapGetters`
* ✏️ Fix casing
* ⚡ Adjust import for type
* ✏️ Fix quotes
* 🐛 Fix `activeNode` reference
* ⚡ Use constant
* 🔥 Remove logging
* ✏️ Fix typo
* ⚡ Add missing `notice`
* ✏️ Add tags
* ✏️ Fix alias
* ✏️ Update copy
* 🔥 Remove wrong linting
* ✏️ Update copy
* ⚡ Add validation for `null`
* ⚡ Add validation for non-object and non-array
* ⚡ Add validation for non-array with json
* ✏️ Intentionally use wrong spelling
* ⚡ More validation
* ✏️ More copy updates
* ✏️ Placeholder updates
* ⏪ Restore spelling
* ⚡ Fix var name
* ✏️ More copy updates
* ⚡ Add luxon autocompletions
* ⚡ Make scrollable
* ⚡ Fix comma from merge conflict resolution
* 📦 Update `package-lock.json`
* 👕 Fix lint detail
* 🎨 Set font family
* ⚡ Bring in expressions fix
* ♻️ Address feedback
* ⚡ Exclude codemirror packages from render chunks
* 🐛 Fix placeholder not showing on first load
* feat(editor-ui): Replace `lezer` with `esprima` in client linter (#4192 )
* 🔥 Remove addition from misresolved conflict
* ⚡ Replace `lezer` with `esprima` in client linter
* ⚡ Add missing key
* 📦 Update `package-lock.json`
* ⚡ Match dependencies
* 📦 Update `package-lock.json`
* 📦 Re-update `package-lock.json`
* ⚡ Match whitespace
* 🐛 Fix selection
* ⚡ Expand validation
* 🔥 Remove validation
* ✏️ Update copy
* 🚚 Move to constants
* ⚡ More `null` validation
* ⚡ Support `all()` with index to access item
* ⚡ Gloss over n8n syntax error
* 🎨 Re-style diagnostic button
* 🔥 Remove `item` as `itemAlias`
* ⚡ Add linting for `item.json` in single item mode
* ⚡ Refactor to add label info descriptions
* ⚡ More autocompletions
* 👕 Fix lint
* ⚡ Simplify typings
* feat(nodes-base): Multiline autocompletion for `code-node-editor` (#4220 )
* ⚡ Simplify typings
* ⚡ Consolidate helpers in utils
* ⚡ Multiline autocompletion for standalone vars
* 🔥 Remove unneeded mixins
* ✏️ Update copy
* ✏️ Prep TODOs
* ⚡ Multiline completion for `$input.method` + `$input.item`
* 🔥 Remove unused method
* 🔥 Remove another unused method
* 🚚 Move luxon strings to helpers
* ⚡ Multiline autocompletion for methods output
* ⚡ Refactor to use optional chaining
* 👕 Fix lint
* ✏️ Update TODOs
* ⚡ Multiline autocompletion for `json` fields
* 📘 Add typings
* ⚡ De-duplicate callback to forEach
* 🐛 Fix autocompletions not working with leading whitespace
* 🌐 Apply i18n
* 👕 Fix lint
* :constructor: Second-period var usage completions
* 👕 Fix lint
* 👕 Add exception
* ⚡ Add completion telemetry
* 📘 Add typing
* ⚡ Major refactoring to organize
* 🐛 Fix multiline `.all()[index]`
* 🐛 Do not autoclose square brackets prior to `.json`
* 🐛 Fix accessor for multiline `jsonField` completions
* ⚡ Add completions for half-assignments
* 🐛 Fix `jsonField` completions for `x.json`
* ✏️ Improve comments
* 🐛 Fix `.json[field]` for multiline matches
* ⚡ Cleanup
* 📦 Update `package-lock.json`
* 👕 Fix lint
* 🐛 Rely on original value for custom matcher
* ⚡ Create `customMatcherJsonFieldCompletions` to simplify setup
* 🐛 Include selector in `customMatcherJsonField` completions
* ✏️ Make naming consistent
* ✏️ Add docline
* ⚡ Finish self-review cleanup
* 🔥 Remove outdated comment
* 📌 Pin luxon to major-minor
* ✏️ Fix typo
* 📦 Update `package-lock.json`
* 📦 Update `package-lock.json`
* 📦 Re-update `package-lock.json`
* ➕ Add `luxon` for Gmail node
* 📦 Update `package-lock.json`
* ⚡ Replace Function with Code in suggested nodes
* 🐛 Fix `$prevNode` completions
* ✏️ Update `$execution.mode` copy
* ⚡ Separate luxon getters from methods
* ⚡ Adjusting linter to tolerate `.binary`
* ⚡ Adjust top-level item keys check
* ⚡ Anticipate user expecting `item` to pre-exist
* ⚡ Add linting for legacy item access
* ⚡ Add hint for attempted `items` access
* ⚡ Add keybinding for toggling comments
* ✏️ Update copy of `all`, `first`, `last` and `itemMatching`
* 🐛 Make `input.all()` etc act on copies
* 📦 Update `package-lock.json`
* 🐛 Fix guard in `$input.last()`
* ♻️ Address Jan's feedback
* ⬆️ Upgrade `eslint-plugin-n8n-nodes-base`
* 📦 Update `package-lock.json`
* 🔥 Remove unneeded exceptions
* ⚡ Restore placeholder logic
* ⚡ Add placeholders to client
* ⚡ Account for shadow item
* ✏️ More completion info labels
* 👕 Fix lint
* ✏️ Update copy
* ✏️ Update copy
* ✏️ More copy updates
* 📦 Update `package-lock.json`
* ⚡ Add more validation
* ⚡ Add placheolder on first load
* Replace `Cmd` with `Mod`
* 📦 Update `package-lock.json`
2022-10-13 14:28:02 +02:00
Mike Arvela
6e8e4f5937
fix(nodes-base): fix and harmonize all primaryDocumentation links ( #4191 )
...
* fix(nodes-base): fix and harmonize all primaryDocumentation links
* feat(workflow, cli): expose documentation links to UI via node codex
* fix(editor-ui): link to correct node and credential documentation URLs
* config(nodes-base): update 'format' script to also format node descriptor json
* chore: fix outdated links to node reference documentation
2022-09-29 13:33:16 +03:00
Michael Kret
de4ca3b0cc
test(UM tests): add missing UM tests n8n-3648 ( #4077 )
...
* ⚡ added test for users reinvite
2022-09-12 17:07:56 +02:00
Rhys Williams
f6064ef278
fix(core & function nodes): Update function nodes to work with binary-data-mode 'filesystem'. ( #3845 )
...
* Initial Fix
* Self-Review #1
* Lint
* Added support for FunctionItem. Minor updates.
* Self-review
* review comments. Added testing.
* Self Review
* Fixed memory handling on data manager use.
* Fixes for unnecessary memory leaks.
2022-09-11 16:42:09 +02:00
Michael Kret
0ecbb4a19d
refactor: Format nodes-base package (A-F) ( #3800 )
...
* 🔨 prettier formated nodes - A
* 🔨 prettier formated nodes - B
* ⚡ prettier formated nodes - C
* ⚡ prettier formated nodes - D
* ⚡ prettier formated nodes - E-F
* 🎨 Adjust nodes-base formatting command (#3805 )
* Format additional files in nodes A-F (#3811 )
* ⚡ fixes
* 🎨 Add Mindee to ignored dirs
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
2022-08-01 22:47:55 +02:00
Iván Ovejero
63b6c9f128
refactor: Apply more eslint-plugin-n8n-nodes-base autofixable rules ( #3243 )
...
* ✏️ Alphabetize rules
* 🔖 Update version
* ⚡ Update lintfix command
* ⚡ Run baseline lintfix
* 📦 Update package-lock.json
* 👕 Apply `node-param-description-untrimmed` (#3200 )
* Removing unneeded backticks (#3249 )
* 👕 Apply node-param-description-wrong-for-return-all (#3253 )
* 👕 Apply node-param-description-missing-limit (#3252 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply node-param-description-excess-final-period (#3250 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply node-param-description-unencoded-angle-brackets (#3256 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply node-param-description-url-missing-protocol (#3258 )
* 👕 Apply `node-param-description-miscased-id` (#3254 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply node-param-description-wrong-for-limit (#3257 )
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👕 Apply node-param-description-wrong-for-ignore-ssl-issues (#3261 )
* 👕 Apply rule
* ⚡ Restore lintfix script
* ⚡ Restore lintfix script
Co-authored-by: agobrech <45268029+agobrech@users.noreply.github.com>
Co-authored-by: Omar Ajoue <krynble@gmail.com>
Co-authored-by: Michael Kret <88898367+michael-radency@users.noreply.github.com>
2022-05-06 23:01:25 +02:00
Michael Kret
e8500e6937
feat: Add new expression variables and support for luxon
...
* 🔨 scaffolding for and
* 🔨 added autocomplete
* 🔨 N8N-2961-New-expression-variables
* 🔨 added luxon DateTime to expressions and Functions node, replased with , clean up
* 🔨 added and , fixed return values
* 🔨 added tests for new variables
* 🔨 removed unnecessary import
* 🔨 return type fix
* 🔨 working on review, wip
* 🔨 working on review, improved errors, wip
* 🔨 fixed disappearing error message box
* 🔨 excluded variables from function node, added jmespath setup
* :hamer: added $jmsepath to function nodes
* 🔨 replacing proxy with data when using jmespath
* 🔨 renamed function
* 🔨 updated tips to function nodes
* 🔨 fixes for errors messages
* 🔨 review fixes
* 🔨 removed $input and $() from autocomplete
* ⚡ removed comments
* ⚡ Remove unused code
Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
2022-03-13 10:34:44 +01:00
Michael Kret
62e05cf0b3
⚡ Tolerate missing json key in function node output ( #2885 )
...
* 🔨 implemented Tolerate missing json key in function node output
* 🔨 clean up
* Small change to code
* ⚡ tolerate returning object
* ⚡ Rename function
Co-authored-by: Omar Ajoue <krynble@gmail.com>
Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
2022-03-07 09:54:52 +01:00
Harshil Agrawal
9335ee5deb
⚡ Update Codex files ( #2797 )
2022-02-11 13:20:42 +01:00
Jan Oberhauser
6d0a4d2132
⚡ Always stringify data of Function-Nodes ( #2606 )
...
* ⚡ Always stringify data of Function-Nodes
* ⚡ Fix lint issue and fix data
2022-01-02 10:33:15 +01:00
Jan Oberhauser
b4f2251bcb
⚡ Improvements
2021-12-23 21:00:08 +01:00
Jan Oberhauser
4ab7257c2b
🐛 Fix issue with comments in last line
2021-12-23 18:02:32 +01:00
Jan Oberhauser
0f1b8779e4
⚡ Add line numbers to errors
2021-12-23 15:16:42 +01:00
Jan Oberhauser
fa760ee26b
⚡ Improve autocomplete and a few other changes
2021-12-23 11:41:46 +01:00
Iván Ovejero
766f74c782
🚚 Directorize and alphabetize nodes ( #2445 )
...
* 🚚 Directorize nodes
* ⚡ Alphabetize nodes and credentials
* 🔥 Remove unused node
* 🔥 Remove unused codex
* 🔥 Remove duplicate cred file references
* 🐛 Fix node file paths
* 🔥 Remove duplicate node reference
2021-11-17 17:30:14 +01:00
