Milorad FIlipović
2aed788dc3
feat(editor): Send template id as string in all telemetry events ( #8498 )
2024-01-31 13:34:11 +01:00
कारतोफ्फेलस्क्रिप्ट™
839dd96c7d
refactor(core): Move all code related to onServerStarted into InternalHooks (no-changelog) ( #8500 )
2024-01-31 13:29:17 +01:00
Omar Ajoue
0e9a5a2ab2
fix: Properly iterate over credentials with expressions ( #8502 )
2024-01-31 13:12:18 +01:00
Danny Martini
39e8754784
fix(core): Don't report executions that have been paused as failed to rudderstack and log streams ( #8501 )
2024-01-31 11:21:15 +01:00
Iván Ovejero
dac511b710
refactor(core): Modernize credentials controllers and services (no-changelog) ( #8488 )
...
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2024-01-31 09:48:48 +01:00
कारतोफ्फेलस्क्रिप्ट™
0febe62ad0
fix(AwsS3 Node): Fix handling of bucket with dot in name ( #8475 )
2024-01-30 17:05:59 +01:00
Milorad FIlipović
e643a126f4
feat(editor): Implement loading and error states for dynamically loaded components in node parameter list ( #8477 )
2024-01-30 14:27:42 +01:00
कारतोफ्फेलस्क्रिप्ट™
121a55b691
feat(core): Remove own execution-process mode ( #8490 )
2024-01-30 12:51:40 +01:00
oleg
79c9763122
refactor(editor): Prevent router.replace from computed property (no-changelog) ( #8489 )
...
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
2024-01-30 12:00:10 +01:00
Milorad FIlipović
327cc8df73
fix(editor): Send template id as a number in telemetry events ( #8484 )
2024-01-30 10:37:06 +01:00
कारतोफ्फेलस्क्रिप्ट™
5cb55270b7
refactor(core): Replace promisify-d node calls with native promises (no-changelog) ( #8464 )
2024-01-30 09:49:23 +01:00
Iván Ovejero
238b54c77b
fix(core): Fix stopping and retrying failed executions ( #8480 )
2024-01-29 16:34:58 +01:00
oleg
981ea3930e
feat: Add model parameter to OpenAI embeddings ( #8481 )
...
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
2024-01-29 16:34:23 +01:00
Csaba Tuncsik
eb27ed068b
fix(editor): Disable expression editor modal opening on readonly field ( #8457 )
2024-01-29 16:34:10 +01:00
Iván Ovejero
9e93980957
fix(core): Prevent calling internal hook email event if emailing is disabled ( #8462 )
...
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2024-01-29 16:15:30 +01:00
Giulio Andreini
97b398871d
docs(editor): Copy and aliases tweaks (no-changelog) ( #8465 )
2024-01-29 10:13:30 +01:00
Mutasem Aldmour
56da2e4352
fix: Open executions with large number of execution items without crashing tab ( #8423 )
...
Co-authored-by: Tomi Turtiainen <10324676+tomi@users.noreply.github.com>
2024-01-29 09:33:00 +01:00
Iván Ovejero
db48bdd6d1
fix(core): Handle zero execution statistics on metrics collection during license renewal ( #8463 )
2024-01-26 17:50:19 +01:00
कारतोफ्फेलस्क्रिप्ट™
2fba0e8d58
feat(core): Upgrade Rudderstack SDK to address CVE-2023-45857 ( #8368 )
2024-01-26 16:58:44 +01:00
Danny Martini
9f11eba0a4
fix(core): Point users to the official documentation when they use n8n --help ( #8440 )
2024-01-26 15:16:53 +01:00
Elias Meire
70af67e744
fix: Use correct node version when pasting/importing nodes ( #8456 )
...
Co-authored-by: Michael Kret <michael.k@radency.com>
2024-01-26 15:09:50 +01:00
Michael Kret
8a595d1527
fix(Microsoft Excel 365 Node): Better error and description on unsupported range in upsert, update, getRange operations ( #8452 )
2024-01-26 15:33:29 +02:00
कारतोफ्फेलस्क्रिप्ट™
c70fa66e76
refactor(core): Use DI for WorkflowRunner (no-changelog) ( #8372 )
2024-01-26 13:49:39 +01:00
Michael Kret
bf11c7c1bd
feat(Google Calendar Node): Next occurrence property in recurring events ( #8444 )
2024-01-26 14:36:57 +02:00
Michael Kret
fc5c562785
fix(HTML Node): Escape data path value in JSON Property ( #8441 )
2024-01-26 13:51:03 +02:00
कारतोफ्फेलस्क्रिप्ट™
7c49004018
refactor(core): Use DI for eventBus code - Part 1 (no-changelog) ( #8434 )
2024-01-26 12:21:15 +01:00
कारतोफ्फेलस्क्रिप्ट™
3cc0f81c02
docs: Update MemoryChatRetriever docs url (no-changelog) ( #8455 )
2024-01-26 12:04:51 +01:00
Jon
c2ffd4e645
fix(Gotify Node): Add option to set content type to support Markdown messages ( #8442 )
2024-01-26 10:33:23 +00:00
कारतोफ्फेलस्क्रिप्ट™
5981263b73
ci: Upgrade miragejs to address CVE-2020-8203 (no-changelog) ( #8450 )
2024-01-26 11:26:21 +01:00
Elias Meire
c21c4b9178
feat: Add new 'is empty' and 'is not empty' operators to Filter ( #8445 )
...
Co-authored-by: Michael Kret <michael.k@radency.com>
2024-01-26 11:17:41 +01:00
Csaba Tuncsik
ad4b298be3
fix(editor): Fix workflows filter resetting ( #8411 )
2024-01-26 06:55:08 +01:00
Csaba Tuncsik
caab97e667
fix(editor): Show pin button on binary output but disable it with tooltip ( #8388 )
2024-01-26 06:54:49 +01:00
Michael Kret
dafacb90c6
fix(Merge Node): Passing on no items to "Input 2" results in wrong output items ( #8438 )
2024-01-25 19:11:23 +02:00
कारतोफ्फेलस्क्रिप्ट™
ef4507c821
Merge tag 'n8n@1.26.0'
2024-01-25 16:49:18 +01:00
कारतोफ्फेलस्क्रिप्ट™
cc2f0ada76
ci: Enforce noUnusedLocals on all backend and nodes packages (no-changelog) ( #8428 )
2024-01-25 14:33:35 +01:00
Tomi Turtiainen
c3ec503836
feat: Add telemetry to become creator CTA (no-changelog) ( #8429 )
2024-01-25 10:24:13 +02:00
कारतोफ्फेलस्क्रिप्ट™
f438082442
fix(core): Run the down migration correctly when transaction: false is set (no-changelog) ( #8432 )
2024-01-24 19:07:47 +01:00
Michael Kret
ed7d6b7b3a
feat(core): Display conditions in displayOptions (no-changelog) ( #7888 )
2024-01-24 18:04:46 +02:00
कारतोफ्फेलस्क्रिप्ट™
d6deceacde
refactor(core): Remove roleId indirection (no-changelog) ( #8413 )
2024-01-24 13:38:57 +01:00
github-actions[bot]
111d2ebe68
🚀 Release 1.26.0 ( #8427 )
...
Co-authored-by: ivov <ivov@users.noreply.github.com>
2024-01-24 13:28:47 +01:00
कारतोफ्फेलस्क्रिप्ट™
1affebd85e
refactor(core): Remove unused code from Server.ts (no-changelog) ( #8426 )
2024-01-24 12:55:43 +01:00
Jon
e9fea16301
fix(Switch Node): Fix issue preventing some regex patterns from working ( #8422 )
2024-01-24 09:30:09 +00:00
Jon
7660d7e735
feat(LinkedIn Node): Add support for Community Management API ( #7451 )
2024-01-24 09:28:42 +00:00
कारतोफ्फेलस्क्रिप्ट™
7386f79362
fix(editor): Fix copy to clipboard on insecure contexts ( #8425 )
2024-01-24 09:53:31 +01:00
Jon
4b3ea81028
fix(Google Drive Node): Fix issue preventing upload / update working in some configurations ( #8417 )
2024-01-23 16:30:15 +00:00
Cornelius Suermann
a8b4684192
build: Bump license-sdk to v2.9.1 (no-changelog) ( #8420 )
2024-01-23 14:44:46 +01:00
Iván Ovejero
c0bc94c78f
refactor(core): Finish removing UserManagementHelper (no-changelog) ( #8418 )
2024-01-23 13:58:31 +01:00
Iván Ovejero
2257ec63b3
fix(core): Fix removal of triggers and pollers from memory on deactivation in multi-main setup ( #8416 )
2024-01-23 12:34:40 +01:00
Iván Ovejero
a0a1830696
feat(core): Email recipients on resource shared ( #8408 )
2024-01-23 12:03:59 +01:00
Danny Martini
ae06fdeb62
fix(core): Fix update workflow cli command being unable to activate all workflows ( #8412 )
...
Co-authored-by: Daniel Schröder <daniel.schroeder@skriptfabrik.com>
2024-01-23 10:59:06 +01:00
Iván Ovejero
49b52c4f1d
refactor(core): Bring active executions into executions controller (no-changelog) ( #8371 )
2024-01-23 09:48:50 +01:00
कारतोफ्फेलस्क्रिप्ट™
913c8c6b0c
feat(core): Upgrade oclif (no-changelog) ( #8381 )
2024-01-22 18:25:36 +01:00
Michael Kret
2c146cca62
feat(Microsoft Teams Node): Overhaul ( #7477 )
...
Co-authored-by: Giulio Andreini <andreini@netseven.it>
2024-01-22 18:35:09 +02:00
Jon
44f6ef2ed7
fix(Asana Node): Fix issue when connecting to the new Asana environment ( #8404 )
2024-01-22 12:39:19 +00:00
Elias Meire
08e7db4648
fix(Notion Node): Fix is_empty query on formula fields ( #8397 )
2024-01-22 12:39:53 +01:00
Cornelius Suermann
d597c2ab29
feat: Extend collection of usage metrics during license renewal (no-changelog) ( #8369 )
...
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
2024-01-22 12:29:28 +01:00
Iván Ovejero
ebf2b0d55c
fix(editor): Fix doclines for plus and minus ( #8405 )
2024-01-22 12:28:30 +01:00
Iván Ovejero
35449667bf
fix(editor): Fix secondary icon for environments on sidebar menu item ( #8407 )
2024-01-22 12:28:21 +01:00
Iván Ovejero
f35d4fcbd8
refactor(core): Simplify OrchestrationService (no-changelog) ( #8364 )
2024-01-22 11:16:29 +01:00
Iván Ovejero
2ccb754e52
fix(editor): Fix invisible community package update button ( #8406 )
2024-01-22 10:33:08 +01:00
Nihaal Sangha
c64e893b60
fix(Discord Node): Remove requirement on message for webhooks ( #8377 )
2024-01-22 09:16:20 +00:00
Danny Martini
07e6705256
feat(core): Custom session timeout and refresh configuration ( #8342 )
2024-01-22 09:54:13 +01:00
Giulio Andreini
f4f496ae85
docs(editor): All buttons to sentence case (no-changelog) ( #8399 )
2024-01-22 09:20:02 +01:00
Jon
9883eda42e
fix: Fix openapi generation (no-changelog) ( #8398 )
2024-01-19 18:15:33 +01:00
Alex Grozav
b6d775768f
feat(editor): Migrate moveNodeWorkflow mixin to useCanvasPanning composable ( #8322 )
2024-01-19 16:27:44 +02:00
Ricardo Espinoza
75d3ecca1c
fix(editor): Rename Execute previous nodes label to Test previous nodes (no-changelog) ( #8392 )
2024-01-19 09:00:03 -05:00
Csaba Tuncsik
83228e26fb
fix(editor): Add pinned data for freshly added nodes ( #8323 )
2024-01-19 14:44:54 +01:00
Elias Meire
ff92fc7fef
feat(Execute Workflow Node): Add 'Wait For Sub-Workflow Completion' option ( #8389 )
...
Co-authored-by: Michael Kret <michael.k@radency.com>
2024-01-19 14:31:54 +01:00
Elias Meire
1b0ba2c028
fix(Microsoft SQL Node): Prevent MSSQL max parameters error by chunking ( #8390 )
2024-01-19 14:31:44 +01:00
Alex Grozav
d2b3c1048e
feat(editor): Add additional email domains to our disallowed list for self-serve enterprise license (no-changelog) ( #8161 )
2024-01-19 15:21:49 +02:00
Tomi Turtiainen
e43cf2fd71
fix(editor): Enable ctrl/cmd click in workflow editor header ( #8387 )
2024-01-19 14:28:44 +02:00
Michael Kret
284d965b5a
fix(core): Missing pairedItem fixes ( #8394 )
2024-01-19 13:47:25 +02:00
Michael Kret
2c14371481
fix(AMQP Trigger Node): Properly close connection after manual test step ( #8396 )
2024-01-19 13:39:18 +02:00
Jon
daba5bb250
fix(AWS SQS Node): Fix issue preventing data from being sent correctly ( #8382 )
2024-01-19 11:28:41 +00:00
Tomi Turtiainen
e606e841ee
fix(editor): Use web native <a> element in nav menus ( #8385 )
2024-01-19 12:52:39 +02:00
Tomi Turtiainen
6fcf5ddcdd
fix(editor): Use cursor pointer on close icon (no-changelog) ( #8395 )
2024-01-19 12:51:44 +02:00
Iván Ovejero
749ac2b407
fix(core): Adjust starter node priority for manual executions with pinned activators ( #8386 )
2024-01-19 10:18:04 +01:00
Marcus
11176124b5
feat(Telegram Trigger Node): Verify Webhook requests ( #8383 )
...
Co-authored-by: Jonathan Bennetts <jonathan.bennetts@gmail.com>
2024-01-19 09:09:11 +01:00
Michael Kret
25f51f4fd7
fix(core): Errors are returned on the success branch if error item has other keys in addition to 'error' ( #8380 )
2024-01-18 17:35:59 +02:00
Elias Meire
ade7d30053
fix(editor): Open native context menu when editing Sticky ( #8370 )
2024-01-18 15:14:41 +01:00
कारतोफ्फेलस्क्रिप्ट™
c7c4ae4514
feat(core): Upgrade swagger (no-changelog) ( #8384 )
2024-01-18 14:16:14 +01:00
Tomi Turtiainen
f31cc0743f
fix: Force posthog recording to be disabled outside cloud ( #8374 )
2024-01-18 14:44:27 +02:00
Tomi Turtiainen
1aa35b190a
fix: Set '@typescript-eslint/return-await' rule to 'always' for FE (no-changelog) ( #8373 )
2024-01-18 11:28:01 +02:00
Jon
fc94377036
fix: Fix issue preventing secrets with a - in the path from being imported ( #8378 )
2024-01-18 09:24:58 +00:00
Deborah
976fe2e6c8
fix: Change the UI text for some filter operations ( #8360 )
2024-01-18 08:50:54 +00:00
Tomi Turtiainen
99457019f7
feat: Nudge users to become template creators if eligible ( #8357 )
2024-01-17 19:07:34 +02:00
कारतोफ्फेलस्क्रिप्ट™
3912c5e7ab
feat(core): Upgrade axios and follow-redirects to address CVE-2023-26159 ( #8366 )
2024-01-17 16:41:01 +01:00
कारतोफ्फेलस्क्रिप्ट™
639d34769e
feat(core): Upgrade bull and ioredis to address CVE-2023-52079 ( #8365 )
2024-01-17 16:33:54 +01:00
Tomi Turtiainen
9a1cc56806
fix: Set '@typescript-eslint/return-await' rule to 'always' for node code (no-changelog) ( #8363 )
...
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2024-01-17 17:08:50 +02:00
Iván Ovejero
2eb829a6b4
refactor(core): Use DI in execution services (no-changelog) ( #8358 )
2024-01-17 15:42:19 +01:00
Michael Kret
01280815c9
fix(Microsoft Outlook Node): Message -> Send with attachments ( #8238 )
2024-01-17 16:18:49 +02:00
github-actions[bot]
7268d24259
🚀 Release 1.25.0 ( #8362 )
...
Co-authored-by: netroy <netroy@users.noreply.github.com>
2024-01-17 14:20:55 +01:00
Iván Ovejero
771d2fa341
test(core): Fix cleanup in test teardown script (no-changelog) ( #8361 )
2024-01-17 14:01:56 +01:00
Omar Ajoue
d5455d7acc
fix(core): Report when waitTill is invalid and handle it ( #8356 )
2024-01-17 13:08:20 +01:00
Giulio Andreini
48a0f91c72
docs(Discord Node): Better OAuth description (no-changelog) ( #8350 )
2024-01-17 13:01:19 +01:00
Elias Meire
b51cbb325e
fix(Salesforce Node): Upgrade to API version 59 ( #8346 )
2024-01-17 12:55:12 +01:00
Elias Meire
eb1320fd7a
fix(core): Parse any readable stream response instead of only IncomingMessage ( #8359 )
2024-01-17 12:31:20 +01:00
Iván Ovejero
159b328587
fix(editor): Capture indexed access expressions when building completions ( #8331 )
2024-01-17 11:02:40 +01:00
कारतोफ्फेलस्क्रिप्ट™
7cdbb424e3
refactor(core): Move methods from WorkflowHelpers into various workflow services (no-changelog) ( #8348 )
2024-01-17 10:16:13 +01:00
कारतोफ्फेलस्क्रिप्ट™
ab52aaf7e9
feat(Redis Node): Update node-redis (no-changelog) ( #8269 )
...
Co-authored-by: Michael Kret <michael.k@radency.com>
2024-01-17 10:15:20 +01:00
Iván Ovejero
3734c89cf6
fix(core): Ensure waiting executions account for workflow timezone ( #8340 )
2024-01-16 18:28:19 +01:00
Iván Ovejero
d4c93b1607
fix(core): Prevent issues with missing or mismatching encryption key ( #8332 )
2024-01-16 18:25:53 +01:00
Iván Ovejero
7bb2d1799e
refactor(core): Consolidate executions controllers (no-changelog) ( #8349 )
2024-01-16 16:52:21 +01:00
कारतोफ्फेलस्क्रिप्ट™
b267bf07e3
fix(core): Prevent NodeErrors from being wrapped multiple times ( #8301 )
2024-01-16 16:18:34 +01:00
कारतोफ्फेलस्क्रिप्ट™
64ceb16af6
refactor(core): Use DI in PermissionChecker (no-changelog) ( #8344 )
2024-01-16 14:15:29 +01:00
Iván Ovejero
420b4271a9
refactor(core): Move typeorm operators from Public API (no-changelog) ( #8319 )
2024-01-16 13:35:43 +01:00
Omar Ajoue
e1acb5911a
refactor: Make execution IDs mandatory in BE ( #8299 )
...
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
2024-01-16 09:53:17 +00:00
Iván Ovejero
0f4f472a72
refactor(core): Eliminate dead Redis code (no-changelog) ( #8292 )
2024-01-16 09:31:45 +01:00
Iván Ovejero
5fbd7971e0
fix(core): Account for immediate confirmation request during test webhook creation ( #8329 )
2024-01-16 09:17:41 +01:00
Tomi Turtiainen
dfa486e4f2
fix: Change setup credentials modal title (no-changelog) ( #8338 )
2024-01-16 09:31:44 +02:00
Ricardo Espinoza
4277e92ec0
feat(editor): Add new /templates/search endpoint ( #8227 )
...
Updating n8n front-end to use the new search endpoint powered by TypeSense.
Endpoint is deployed on staging API so, in order to test it, use this env var:
```export N8N_TEMPLATES_HOST=https://api-staging.n8n.io/api ```
**NOTE**: This PR should not be merged until [backend changes](https://github.com/n8n-io/creators-site/pull/118 ) are merged and released.
## Related tickets and issues
https://linear.app/n8n/issue/ADO-1555/update-in-app-search-to-work-with-the-new-back-end
## Review / Merge checklist
- [x] PR title and summary are descriptive. **Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise.** ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it from happening again.
> A feature is not complete without tests.
2024-01-15 16:19:24 -05:00
कारतोफ्फेलस्क्रिप्ट™
bb2be8d705
fix(Microsoft SQL Node): Fix "Maximum call stack size exceeded" error on too many rows ( #8334 )
2024-01-15 17:52:39 +01:00
Michael Kret
c921665f9a
fix(AwsS3 Node): Return confirmation of success after upload ( #8312 )
2024-01-15 18:00:47 +02:00
Jon
cf7131d766
fix(Google Drive Node): Fix issue preventing service account from downloading files ( #7642 )
2024-01-15 15:06:47 +00:00
कारतोफ्फेलस्क्रिप्ट™
52a2e25a25
fix(core): Replace all moment imports with moment-timezone ( #8337 )
2024-01-15 15:45:33 +01:00
Ricardo Espinoza
e3cedf7db0
fix(Venafi TLS Protect Cloud Node): Remove parameter Application Server Type ( #8325 )
...
## Summary
Parameter was removed from the API.
## Review / Merge checklist
- [x] PR title and summary are descriptive. **Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise.** ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
2024-01-15 09:25:59 -05:00
Ricardo Espinoza
dac0ddaf16
fix: Typos in nodes infoboxes (no-changelog) ( #8324 )
...
## Summary
Title self explanatory
## Related tickets and issues
https://linear.app/n8n/issue/ADO-1687/bug-fix-typo-on-info-box
## Review / Merge checklist
- [x] PR title and summary are descriptive. **Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise.** ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
2024-01-15 09:12:43 -05:00
Ricardo Espinoza
057d7d0318
fix(Venafi TLS Protect Cloud Trigger Node): Handle new webhook payload format ( #8326 )
2024-01-15 09:03:23 -05:00
Ricardo Espinoza
6b92d49ea5
fix(editor): Fix issue with synchronization table on LDAP not loading data ( #8327 )
...
## Summary
When we migrated to Vue3, we updated to a new component and did not provide the right props.
before:
https://www.loom.com/share/ce12b21fdda44176b3e949a00c582252
now:
https://www.loom.com/share/354d1dcb51bd47a9910d5bfe34c7c9b8
## Related tickets and issues
https://linear.app/n8n/issue/PAY-1134/ldap-synchronization-table-in-ui-remains-empty-even-after-successful
## Review / Merge checklist
- [x] PR title and summary are descriptive. **Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise.** ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
2024-01-15 09:03:10 -05:00
Ricardo Espinoza
3c2a4000ae
refactor(core): Use DI for LDAP code (no-changelog) ( #8248 )
...
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2024-01-15 09:01:48 -05:00
Michael Kret
a6a5372b5f
fix(OpenAI Node): Load correct models for operation ( #8313 )
2024-01-15 15:13:38 +02:00
Deborah
c8a2fe05d2
docs: Update link in manual chat trigger node (no-changelog) ( #8328 )
2024-01-15 11:54:32 +00:00
oleg
464be93323
feat: Implement Chat Memory Manager node ( #8127 )
...
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Michael Kret <michael.k@radency.com>
2024-01-15 10:13:54 +02:00
oleg
851060dd3f
fix: Add fallback resolver for langchain modules ( #8308 )
...
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
2024-01-12 18:33:33 +01:00
कारतोफ्फेलस्क्रिप्ट™
63b738a542
fix(Ollama Model Node): Use a simpler credentials test ( #8318 )
2024-01-12 16:37:46 +01:00
कारतोफ्फेलस्क्रिप्ट™
0776814ed8
fix(core): Prevent invalid compressed responses from making executions stuck forever ( #8315 )
2024-01-12 15:18:46 +01:00
Michael Kret
e0804768e8
fix(Supabase Node): Pagination for get all rows ( #8311 )
2024-01-12 15:14:10 +02:00
Iván Ovejero
1a0e285553
feat(core): Implement inter-main communication for test webhooks in multi-main setup ( #8267 )
2024-01-12 11:48:58 +01:00
Tomi Turtiainen
135553bd6b
feat: Redirect users without feature flag from template cred setup (no-changelog) ( #8302 )
2024-01-12 12:10:39 +02:00
oleg
c2748802a2
ci: Add @aws-sdk/credential-provider-node and @aws-sdk/types modules (no-changelog) ( #8310 )
...
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
2024-01-11 18:46:21 +01:00
Alex Grozav
1824ff6a13
fix(editor): Add back missing computed prop (no-changelog) ( #8306 )
2024-01-11 16:56:42 +02:00
Alex Grozav
361cda6a7e
fix: Disable @typescript-eslint/no-use-before-define rule (no-changelog) ( #8304 )
2024-01-11 16:15:54 +02:00
Alex Grozav
2b98835bf4
fix(editor): Remove pinData mixin (no-changelog) ( #8303 )
2024-01-11 15:04:52 +02:00
Csaba Tuncsik
3b8ccb9fb9
fix(editor): Properly set colors for connections and labels on nodes with pinned data ( #8209 )
...
Co-authored-by: Alex Grozav <alex@grozav.com>
2024-01-11 14:03:23 +01:00
oleg
884396ea0d
fix(API): Fix manual chat trigger execution ( #8300 )
...
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
2024-01-11 14:01:07 +01:00
Mutasem Aldmour
93b969a327
fix: Fix node graph telemetry with default values ( #8297 )
2024-01-11 13:25:40 +01:00
Elias Meire
dcc76f3480
fix(editor): Add read only mode to filter component ( #8285 )
2024-01-11 10:28:15 +01:00
Tomi Turtiainen
d877d3ce92
fix: Adjust cred setup telemetry (no-changelog) ( #8294 )
2024-01-10 19:41:25 +02:00
कारतोफ्फेलस्क्रिप्ट™
05c43faa2d
fix(HTTP Request Node): Delete response.request only when it's a valid circular references ( #8293 )
2024-01-10 18:05:19 +01:00
Omar Ajoue
8c7f39907f
fix: Properly output saml validation errors ( #8284 )
2024-01-10 16:56:04 +01:00
कारतोफ्फेलस्क्रिप्ट™
53612def31
Merge tag 'n8n@1.24.0'
2024-01-10 16:23:39 +01:00
github-actions[bot]
8a4231e9f6
🚀 Release 1.24.0 ( #8290 )
...
Co-authored-by: ivov <ivov@users.noreply.github.com>
2024-01-10 16:16:25 +01:00
Alex Grozav
d32e6a60da
feat(editor): Migrate deviceSupportHelpers mixin to useDeviceSupport composable (no-changelog) ( #8289 )
2024-01-10 16:42:01 +02:00
Omar Ajoue
8a7c629ea1
fix: Store workflow settings when saving an execution ( #8288 )
2024-01-10 14:20:37 +00:00
Elias Meire
3b01eb60c9
fix(MySQL Node): Only escape table names when needed ( #8246 )
2024-01-10 14:41:00 +01:00
Elias Meire
dce28f9cb9
feat(Google Sheets Node): Add "By Name" option to selector for Sheets ( #8241 )
...
Co-authored-by: Michael Kret <michael.k@radency.com>
2024-01-10 14:30:09 +01:00
Michael Kret
e796e7f06d
feat(MongoDB Node): Add support for TLS ( #8266 )
2024-01-10 15:02:05 +02:00
Alex Grozav
94c9cd4080
feat: Update @n8n/chat exports and add example images (no-changelog) ( #8274 )
2024-01-10 14:50:41 +02:00
Michael Kret
ccde38a8a8
fix(Monday.com Node): Migrate to api 2023-10 ( #8254 )
2024-01-10 11:17:00 +02:00
Tomi Turtiainen
23abd8fb49
fix: Small ui fixes to workflow cred setup modal (no-changelog) ( #8280 )
2024-01-09 18:32:42 +02:00
Anush
4401db3a2f
fix: Fix issue with API key being required for the Qdrant Node ( #8237 )
2024-01-09 16:09:31 +00:00
Eric Koleda
f11aa06d27
feat(Coda Node): Add User-Agent for requests to Coda (no-changelog) ( #7771 )
...
Co-authored-by: Jonathan Bennetts <jonathan.bennetts@gmail.com>
2024-01-09 16:02:04 +00:00
vacitbaydarman
e056aa9c4d
fix(FTP Node): FTP connection failed due to missing password credential in node ( #8131 )
...
Co-authored-by: Marcus <marcus@n8n.io>
2024-01-09 15:39:30 +00:00
Iván Ovejero
d5dcbbf8e5
ci: Fix lint setup in chat package (no-changelog) ( #8275 )
2024-01-09 16:37:05 +01:00
कारतोफ्फेलस्क्रिप्ट™
d1ca368c7d
ci: Fix codecov reporting, and include all packages (no-changelog) ( #8276 )
2024-01-09 16:18:20 +01:00
Iván Ovejero
5032bf0e34
fix(core): Fix test webhook deregistration ( #8247 )
2024-01-09 16:02:32 +01:00
Deborah
90404a4b88
docs: Update links in deprecated langchain nodes to avoid linting errors (no-changelog) ( #8273 )
2024-01-09 14:50:00 +01:00
Iván Ovejero
0dabe5c74e
fix: Fix user reinvites on FE and BE ( #8261 )
2024-01-09 13:52:34 +01:00
कारतोफ्फेलस्क्रिप्ट™
b1c1372bc2
docs: Update primaryDocumentation urls for nodes updated in #7651 (no-changelog) ( #8270 )
2024-01-09 12:22:12 +01:00
Alex Grozav
af49e95cc7
feat: Add Chat Trigger node ( #7409 )
...
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
Co-authored-by: Jesper Bylund <mail@jesperbylund.com>
Co-authored-by: OlegIvaniv <me@olegivaniv.com>
Co-authored-by: Deborah <deborah@starfallprojects.co.uk>
Co-authored-by: Jan Oberhauser <janober@users.noreply.github.com>
Co-authored-by: Jon <jonathan.bennetts@gmail.com>
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
Co-authored-by: Michael Kret <88898367+michael-radency@users.noreply.github.com>
Co-authored-by: Giulio Andreini <andreini@netseven.it>
Co-authored-by: Mason Geloso <Mason.geloso@gmail.com>
Co-authored-by: Mason Geloso <hone@Masons-Mac-mini.local>
Co-authored-by: Mutasem Aldmour <mutasem@n8n.io>
2024-01-09 13:11:39 +02:00
कारतोफ्फेलस्क्रिप्ट™
1387541e33
fix(Github Trigger Node): Enforce SSL validation by default ( #8265 )
2024-01-09 11:34:05 +01:00
Jesper Bylund
9d40ae8b74
fix(editor): Tweaking button sizes in execution preview ( #8206 )
2024-01-09 10:20:22 +00:00
Iván Ovejero
055cc785fd
fix(core): Avoid wrapping ExecutionBaseError to prevent misreporting to Sentry (no-changelog) ( #8262 )
2024-01-09 10:11:28 +01:00
Tomi Turtiainen
3b996a7da0
feat(core): Validate shutdown handlers on startup ( #8260 )
2024-01-08 17:46:45 +02:00
oleg
d37b9084b2
feat: Implement MistralCloud Chat & Embeddings nodes ( #8239 )
...
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Michael Kret <michael.k@radency.com>
2024-01-08 16:17:55 +01:00
Tomi Turtiainen
38d91c43e3
fix: Adjust set up template button styles (no-changelog) ( #8259 )
2024-01-08 16:34:28 +02:00
कारतोफ्फेलस्क्रिप्ट™
fc2903096e
fix(Webhook Node): Fix handling of form-data files ( #8256 )
2024-01-08 14:33:14 +01:00
Tomi Turtiainen
b6c42cc084
fix(editor): Unify canvas button positioning ( #8258 )
2024-01-08 14:44:56 +02:00
Tomi Turtiainen
04836e5c56
feat: Rename template cred setup feature flag (no-changelog) ( #8257 )
2024-01-08 14:33:21 +02:00
Alex Grozav
8c8caac4e8
feat(editor): Migrate debounce mixin to useDebounce composable (no-changelog) ( #8244 )
2024-01-08 14:00:49 +02:00
Tomi Turtiainen
8affdf680d
fix: Hide cred setup button from canvas (no-changelog) ( #8255 )
2024-01-08 13:59:04 +02:00
Tomi Turtiainen
7899f7aca5
fix: Adjust telemetry from canvas (no-changelog) ( #8252 )
2024-01-08 13:56:16 +02:00
Iván Ovejero
90c065e999
refactor(core): Convert workflows controller to DI (no-changelog) ( #8253 )
2024-01-08 12:54:23 +01:00
कारतोफ्फेलस्क्रिप्ट™
ac1c642fdd
fix(core): Do not add Authentication header when authentication type is body ( #8201 )
2024-01-08 12:38:24 +01:00
Jan Oberhauser
ccb2b076f8
fix: Resolve expressions in credentials following paired item ( #8250 )
...
## Summary
Fixes the issue that pairedItem information was not available in
expressions that got used in credentials
## Related tickets and issues
[PAY-1207](https://linear.app/n8n/issue/PAY-1207/paireditem-expressions-not-working-correctly-in-credentials )
## Review / Merge checklist
- [x] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
> A feature is not complete without tests.
---------
Co-authored-by: Omar Ajoue <krynble@gmail.com>
2024-01-08 09:48:20 +00:00
Tomi Turtiainen
008fd5a917
test: Add e2e tests for cred setup on workflow editor (no-changelog) ( #8245 )
...
## Summary
Follow-up to https://github.com/n8n-io/n8n/pull/8240
Adds e2e tests for the template credential setup in workflow editor
## Related tickets and issues
https://linear.app/n8n/issue/ADO-1463/feature-enable-users-to-close-and-re-open-the-setup
2024-01-08 11:35:18 +02:00
Tomi Turtiainen
3cf6704dbb
feat: Enable cred setup for workflows created from templates (no-changelog) ( #8240 )
...
## Summary
Enable users to open credential setup for workflows that have been
created from templates if they skip it.
Next steps (will be their own PRs):
- Add telemetry events
- Add e2e test
- Hide the button when user sets up all the credentials
- Change the feature flag to a new one
## Related tickets and issues
https://linear.app/n8n/issue/ADO-1637/feature-support-template-credential-setup-for-http-request-nodes-that
2024-01-05 18:07:57 +02:00
Ricardo Espinoza
df5d07bcb8
feat(editor): Update copy: Execute --> Test ( #8137 )
...
## Summary
Title self explanatory
## Related tickets and issues
https://linear.app/n8n/issue/ADO-129/update-copy-execute-test
## Review / Merge checklist
- [x] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
2024-01-05 10:23:51 -05:00
Ricardo Espinoza
2d6e406e21
fix(editor): Vertically center workflow preview loading state ( #8231 )
...
## Summary
Title self explanatory
before:
<img width="1198" alt="image"
src="https://github.com/n8n-io/n8n/assets/16496553/26c29cad-b376-40fd-9881-343f5e722d58 ">
now:
<img width="1211" alt="image"
src="https://github.com/n8n-io/n8n/assets/16496553/9f2d4020-6bf8-481a-b69f-eddb57cfaaae ">
## Related tickets and issues
[ado-1645-fix-center-loading-preview-loading-state
](https://linear.app/n8n/issue/ADO-1645/fix-center-loading-preview-loading-state )
## Review / Merge checklist
- [ x] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
2024-01-05 09:04:39 -05:00
Iván Ovejero
f2939568cf
perf(core): Optimize workflow activation errors ( #8242 )
...
At https://github.com/n8n-io/n8n/pull/8213 we introduced Redis hashes
for workflow ownership and manual webhooks...
- to remove clutter from multiple related keys at the top level,
- to improve performance by preventing serializing-deserializing, and
- to guarantee atomicity during concurrent updates in multi-main setup.
Workflow activation errors can also benefit from this. Added test
coverage as well.
To test manually, create a workflow with a trigger with an invalid
credential, edit the workflow's `active` column to `true`, and restart.
The activation error should show as a red triangle on canvas and in the
workflow list.
2024-01-05 13:06:42 +01:00
Iván Ovejero
23a4ac96c0
refactor(core): Continue moving typeorm operators to repositories (no-changelog) ( #8212 )
...
Follow-up to: https://github.com/n8n-io/n8n/pull/8186
2024-01-05 13:06:24 +01:00
Elias Meire
bed04ec122
fix(Postgres Node): Stop marking autogenerated columns as required ( #8230 )
...
## Summary
Postgres columns can be
- [generated as
identity](https://www.postgresqltutorial.com/postgresql-tutorial/postgresql-identity-column/ )
- [generated by a custom
expression](https://www.postgresql.org/docs/current/ddl-generated-columns.html )
In these 2 cases, the column is not required when inserting a new row.
This PR makes sure these types of column are not marked required in n8n.
### How to test
1. Create a Postgres table with all types of generated columns:
for version >= 10
```sql
CREATE TABLE "public"."test_table" (
"id" int8 NOT NULL DEFAULT nextval('test_table_id_seq'::regclass),
"identity_id" bigint GENERATED ALWAYS AS IDENTITY,
"id_plus" numeric GENERATED ALWAYS AS (id + 5) STORED,
"title" varchar NOT NULL,
"created_at" timestamp DEFAULT now(),
PRIMARY KEY ("id")
)
```
Before 10 you have to use serial or bigserial types:
```sql
CREATE TABLE distributors (
did serial not null primary key,
name varchar(40) NOT NULL CHECK (name <> '')
);
```
2. Add a postgres node to canvas and try to insert data without the
generated columns
3. Should successfully insert
More info in Linear/Github issue ⬇️
## Related tickets and issues
- fixes #7084
-
https://linear.app/n8n/issue/NODE-816/rmc-not-all-id-fields-should-be-required
-
https://linear.app/n8n/issue/NODE-681/postgres-cant-map-automatically-if-database-requires-a-field
## Review / Merge checklist
- [ ] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
> A feature is not complete without tests.
---------
Co-authored-by: Michael Kret <michael.k@radency.com>
2024-01-05 12:37:33 +01:00
Elias Meire
048b588852
fix: Make params panel double width for all SQL nodes ( #8236 )
...
## Summary
Make params panel double width for all SQL nodes
<img width="1445" alt="image"
src="https://github.com/n8n-io/n8n/assets/8850410/422e7c6c-90c9-4cf0-832b-fab7679275d3 ">
## Related tickets and issues
https://linear.app/n8n/issue/NODE-986/make-all-sql-nodes-have-a-double-width-params-pane
## Review / Merge checklist
- [ ] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
> A feature is not complete without tests.
2024-01-05 12:31:11 +01:00
oleg
184ed8e17d
refactor: Migrate genericHelpers mixin to composable ( #8220 )
...
## Summary
- Moved out canvas loading handling to canvas store
- Tag editable routes via meta to remove router dependency from generic
helpers
- Replace all occurrences of `genericHelpers` mixin with composable and
audit usage
- Moved out `isRedirectSafe` and `getRedirectQueryParameter` out of
genericHelpers to remove dependency on router
Removing the router dependency is important, because `useRouter` and
`useRoute` compostables are only available if called from component
instance. So if composable is nested within another composable, we
wouldn't be able to use these. In this case we'd always need to inject
the router and pass it through several composables. That's why I moved
the `readonly` logic to router meta and `isRedirectSafe` and
`getRedirectQueryParameter` out as they were only used in a single
component.
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
2024-01-05 12:23:28 +01:00
Iván Ovejero
f53c482939
perf(core): Improve caching service ( #8213 )
...
Story: https://linear.app/n8n/issue/PAY-1188
- Implement Redis hashes on the caching service, based on Micha's work
in #7747 , adapted from `node-cache-manager-ioredis-yet`. Optimize
workflow ownership lookups and manual webhook lookups with Redis hashes.
- Simplify the caching service by removing all currently unused methods
and options: `enable`, `disable`, `getCache`, `keys`, `keyValues`,
`refreshFunctionEach`, `refreshFunctionMany`, `refreshTtl`, etc.
- Remove the flag `N8N_CACHE_ENABLED`. Currently some features on
`master` are broken with caching disabled, and test webhooks now rely
entirely on caching, for multi-main setup support. We originally
introduced this flag to protect against excessive memory usage, but
total cache usage is low enough that we decided to drop this setting.
Apparently this flag was also never documented.
- Overall caching service refactor: use generics, reduce branching, add
discriminants for cache kinds for better type safety, type caching
events, improve readability, remove outdated docs, etc. Also refactor
and expand caching service tests.
Follow-up to: https://github.com/n8n-io/n8n/pull/8176
---------
Co-authored-by: Michael Auerswald <michael.auerswald@gmail.com>
2024-01-05 11:52:44 +01:00
Michael Kret
b201ff8f23
fix(Nextcloud Node): Throw an actual error if server responded with Fatal error ( #8234 )
...
## Summary
Nextcloud and Yourls receiving response with OK status as string
containing 'Fatal error', throw an actual error in such case
## Related tickets and issues
https://linear.app/n8n/issue/NODE-1035/nextcloud-and-yourls-throw-an-actual-error-if-server-responded-with
2024-01-05 12:13:29 +02:00
Tomi Turtiainen
6e78d2346e
fix: Adjust 'use template' feature telemetry (no-changelog) ( #8232 )
...
- Add extra params to 'User closed cred setup' event
- Fire 'User closed cred setup' only when template has creds
- Skip cred setup page if template has no creds required
- Fire 'User inserted workflow template' also in cred setup
2024-01-05 11:52:10 +02:00
Michael Kret
cda49a4747
fix(Set Node): Field not excluded if dot notation disabled and field was set by using drag-and-drop from ui ( #8233 )
...
## Summary
Sanitize fields when dot notation disabled
## Related tickets and issues
https://community.n8n.io/t/edit-fields-set-new-set-node-cannot-delete-field-with-space-or-non-latin-character-when-support-dot-notation-is-off/31989
https://linear.app/n8n/issue/NODE-883/set-edit-fields-node-spaces-in-field-names-break-fields-to-exclude
2024-01-05 11:15:33 +02:00
Michael Kret
43e8e5e540
fix(NocoDB Node): Download attachments ( #8235 )
...
## Summary
PR fixes Get Many fails to execute when Download Attachments is set to
true
## Related tickets and issues
https://community.n8n.io/t/nocodb-unable-to-download-file/33333
https://linear.app/n8n/issue/NODE-960/nocodb-row-get-many-fails-to-execute-when-download-attachments-is-set
2024-01-05 11:15:10 +02:00
Tomi Turtiainen
8a78ae1739
fix: Add template id to workflows created from templates (no-changelog) ( #8226 )
...
In #8088 template ID was added to workflow metadata, but it was missing
from workflows that were created using the template credential setup.
This fixes that.
2024-01-05 10:36:59 +02:00
Elias Meire
071e6d6b6e
feat(editor): Add fullscreen view to code editor ( #8084 )
...
## Summary
<img width="1240" alt="image"
src="https://github.com/n8n-io/n8n/assets/8850410/2819f4ce-c343-431a-8a88-a1bc9c4b572a ">
<img width="2649" alt="image"
src="https://github.com/n8n-io/n8n/assets/8850410/36862aaf-cc4c-4668-bdc8-cf5a6f00babe ">
1. Add code node and open it
3. Click the fullscreen button in the bottom right
4. A fullscreen dialog should appear and allow editing the code
5. Changes made in the fullscreen dialog should be applied to the
original code editor when closed
It should work the same way for HTML/SQL/JSON editors
⚠️ Modal layout was updated so that modals/dialogs are centered, try to
test some modals
## Related tickets and issues
https://linear.app/n8n/issue/NODE-1009/add-fullscreen-view-to-code-node
## Review / Merge checklist
- [ ] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
> A feature is not complete without tests.
---------
Co-authored-by: Giulio Andreini <andreini@netseven.it>
2024-01-04 17:23:24 +01:00
Ricardo Espinoza
8f22a265d6
fix(editor): Only load suggested templates for owners ( #8228 )
...
## Summary
Title is self explanatory
2024-01-04 10:19:25 -05:00
Michael Kret
270328ccf6
feat(HTTP Request Node): Interval Between Requests option for pagination ( #8224 )
...
## Summary
Option to add delay between request when using pagination
## Related tickets and issues
https://linear.app/n8n/issue/NODE-1029/http-request-pagination-feature-doesnt-use-batch-settings
https://github.com/n8n-io/n8n/issues/8062
2024-01-04 17:11:16 +02:00
Alex Grozav
b50d8058cf
feat(editor): Migrate pinData mixin to usePinnedData composable (no-changelog) ( #8207 )
...
## Summary
Required as part of NodeView refactoring:
- Migrates `pinData` mixin to `usePinnedData` composable.
- Adds `useActiveNode` and `useNodeType` composables
## Related tickets and issues
https://linear.app/n8n/issue/N8N-6355/pindata
## Review / Merge checklist
- [x] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [x] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [x] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
> A feature is not complete without tests.
2024-01-04 11:22:56 +02:00
Michael Kret
f4092a9e49
feat(Switch Node): Overhaul ( #7855 )
...
Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/switch-node-to-more-than-one-path/32791/2
https://community.n8n.io/t/switch-node-routing-same-value-multiple-output/29424
---------
Co-authored-by: Elias Meire <elias@meire.dev>
Co-authored-by: Giulio Andreini <andreini@netseven.it>
2024-01-04 11:03:03 +02:00
Tomi Turtiainen
cd3f5b5b1f
fix: Fix template credential setup for nodes that dont have credentials ( #8208 )
...
Fix template credential setup for templates whose workflow includes
nodes that require credentials but the workflow definition does not have
them defined. Like for example
https://n8n.io/workflows/1344-save-email-attachments-to-nextcloud/
2024-01-04 10:21:36 +02:00
Ricardo Espinoza
4186884740
fix: Stop showing fake door templates when user clicks on "use template" (no-changelog) ( #8219 )
...
## Summary
We stop showing the fake-door templates when the user clicks on "notify
me when it's is available" (this notification is shown when the user
clicks on "use template"). This PR changes this behavior and stop
showing the fakedoor templates when the user clicks on "use template".
Additionally, also increases the "template coming soon" notification
time from 4.5 seconds to 10 seconds.
<img width="395" alt="image"
src="https://github.com/n8n-io/n8n/assets/16496553/2e643b1f-dd52-46f0-951f-29e630241f73 ">
2024-01-03 17:04:30 -05:00
Michael Kret
edbc5bb59a
fix(core): Unsafe isAxiosError property access (no-changelog) ( #8197 )
...
## Summary
in some cases the actual error does not get returned. It is apparently
reproducible with the OpenAI node but will probably also be a bug and so
a problem in other nodes:
https://community.n8n.io/t/problem-in-node-openai-cannot-read-properties-of-undefined-reading-isaxioserror/34716/9
## Related tickets and issues
https://linear.app/n8n/issue/NODE-1028/actual-error-does-not-always-get-returned
## Review / Merge checklist
- [ ] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
> A feature is not complete without tests.
2024-01-03 20:43:31 +02:00
Ricardo Espinoza
8a3c87f69c
fix(editor): Items count display in running workflow ( #8148 )
...
## Summary
> Describe what the PR does and how to test. Photos and videos are
recommended.
Every time the `MainHeader` component is created, we register a new
handler for the "push" messages. Unfortunately this becomes an issue if
you go multiple times to a page that renders the `MainHeader`, e.g
`/workflow/:id`, without refreshing the page; because all handlers will
be called, causing behavior duplication.
I added the possibility of passing an ID, and made impossible to have
multiple handlers with the same ID However, it does not seems to be
needed to support an array of handlers in the pushConnection store. If
that is the case:
1. We might want to have only one handler for the push connections at
all times, which would be a much simpler approach.
2. Register the handler on app.mount instead.
The issue seems to have been introduced
[here](https://github.com/n8n-io/n8n/pull/7763/files#diff-f5dae80a64b9951bb6691f1b9d439423cf84fa0cc9601b3f2c00904f3135e8deR48 )
Before the change:
https://www.loom.com/share/85cf8ef896254d848a13a6c6438daa47
With the change:
https://www.loom.com/share/f5c4ffac421d46cc8e389364e1c357d3
## Related tickets and issues
https://linear.app/n8n/issue/ADO-1596/bug-items-count-display-in-running-workflow
## Review / Merge checklist
- [x] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
> A feature is not complete without tests.
2024-01-03 11:31:33 -05:00
Iván Ovejero
22a5f5258d
feat(core): Cache test webhook registrations ( #8176 )
...
In a multi-main setup, we have the following issue. The user's client
connects to main A and runs a test webhook, so main A starts listening
for a webhook call. A third-party service sends a request to the test
webhook URL. The request is forwarded by the load balancer to main B,
who is not listening for this webhook call. Therefore, the webhook call
is unhandled.
To start addressing this, cache test webhook registrations, using Redis
for queue mode and in-memory for regular mode. When the third-party
service sends a request to the test webhook URL, the request is
forwarded by the load balancer to main B, who fetches test webhooks from
the cache and, if it finds a match, executes the test webhook. This
should be transparent - test webhook behavior should remain the same as
so far.
Notes:
- Test webhook timeouts are not cached. A timeout is only relevant to
the process it was created in, so another process retrieving from Redis
a "foreign" timeout will be unable to act on it. A timeout also has
circular references, so `cache-manager-ioredis-yet` is unable to
serialize it.
- In a single-main scenario, the timeout remains in the single process
and is cleared on test webhook expiration, successful execution, and
manual cancellation - all as usual.
- In a multi-main scenario, we will need to have the process who
received the webhook call send a message to the process who created the
webhook directing this originating process to clear the timeout. This
will likely be implemented via execution lifecycle hooks and Redis
channel messages checking session ID. This implementation is out of
scope for this PR and will come next.
- Additional data in test webhooks is not cached. From what I can tell,
additional data is not needed for test webhooks to be executed.
Additional data also has circular references, so
`cache-manager-ioredis-yet` is unable to serialize it.
Follow-up to: #8155
2024-01-03 16:58:33 +01:00
