Jan Oberhauser
db56a9ee37
fix(editor): Fix issue that frontend breaks with unkown nodes ( #7596 )
...
Because of recent changes does the frontend break when a node is not
known.
Github issue / Community forum post (link here to close automatically):
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Oleg Ivaniv <me@olegivaniv.com>
2023-11-06 13:44:05 +01:00
Ricardo Espinoza
b11c4de039
fix(editor): Focus mfa token input (no-changelog) ( #7610 )
...
Github issue / Community forum post (link here to close automatically):
2023-11-04 20:34:05 -04:00
Ricardo Espinoza
5790e251b8
feat(core): Rate limit forgot password endpoint ( #7604 )
...
Github issue / Community forum post (link here to close automatically):
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <netroy@users.noreply.github.com>
2023-11-03 13:44:12 -04:00
Omar Ajoue
c6049a2e97
feat(editor): Fix some UTM tags (no-changelog) ( #7583 )
...
Github issue / Community forum post (link here to close automatically):
2023-11-03 16:17:39 +01:00
Alex Grozav
24dfc95974
feat(editor): Improve performance by importing routes dynamically and add route guards (no-changelog) ( #7567 )
...
**Before:**
<img width="657" alt="image"
src="https://github.com/n8n-io/n8n/assets/6179477/0bcced2b-9d3a-43b3-80d7-3c72619941fa ">
**After:**
<img width="660" alt="image"
src="https://github.com/n8n-io/n8n/assets/6179477/e74e0bbf-bf33-49b4-ae11-65f640405ac8 ">
2023-11-03 16:22:37 +02:00
Elias Meire
c92402a3ca
fix(editor): Zoom in/out on canvas the same amount on scroll/gesture ( #7602 )
...
Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/ctrl-mousewheel-zoom-jumps-out-possible-to-avoid/31952
2023-11-03 14:09:18 +01:00
Jan Oberhauser
b532a7bdb7
fix(editor): Hide not supported node options ( #7597 )
...
Currently Trigger-Nodes and Sub-Nodes display options that do not make
sense or work like:
- Always Output Data
- Execute Once
- On Error
This PR hides those options for nodes that can not make use of them
anyway to not confuse users.
Github issue / Community forum post (link here to close automatically):
2023-11-03 12:18:00 +01:00
Csaba Tuncsik
85e1a10021
refactor(editor): Simplify data count in NDV (no-changelog) ( #7568 )
2023-11-03 12:07:04 +01:00
Milorad FIlipović
9c55702661
fix(editor): Fix flaky ResourceMapper unit tests (no-changelog) ( #7593 )
...
Github issue / Community forum post (link here to close automatically):
2023-11-03 09:56:19 +01:00
कारतोफ्फेलस्क्रिप्ट™
bb2c266e48
Merge tag 'n8n@1.15.1'
2023-11-02 18:11:06 +01:00
Iván Ovejero
d633753687
fix(editor): Remove unknown credentials on pasting workflow ( #7582 )
...
https://linear.app/n8n/issue/PAY-881
2023-11-02 17:26:39 +01:00
Mutasem Aldmour
2854a0cf46
fix(editor): Allow overriding theme from query params ( #7591 )
...
Allow overriding theme through query params.. to be able to override it
from preview iframe in webcomponent
Github issue / Community forum post (link here to close automatically):
2023-11-02 16:06:33 +01:00
github-actions[bot]
fbce8f5298
🚀 Release 1.15.1 ( #7592 )
...
##
[1.15.1](https://github.com/n8n-io/n8n/compare/n8n@1.14.0...n8n@1.15.1 )
(2023-11-02)
### Bug Fixes
* **core:** Ensure execution deletion in worker lifecycle hook
([#7481 ](https://github.com/n8n-io/n8n/issues/7481 ))
([742c8a8742c8a8534#7560 ](https://github.com/n8n-io/n8n/issues/7560 ))
([b350568b350568505#7408 ](https://github.com/n8n-io/n8n/issues/7408 ))
([479f902479f90231d#7523 ](https://github.com/n8n-io/n8n/issues/7523 ))
([1055bd31055bd3762#7576 ](https://github.com/n8n-io/n8n/issues/7576 ))
([437c95e437c95e84e#7569 ](https://github.com/n8n-io/n8n/issues/7569 ))
([9bdb85c9bdb85c4ce#7519 ](https://github.com/n8n-io/n8n/issues/7519 ))
([65e559365e5593233#7528 ](https://github.com/n8n-io/n8n/issues/7528 ))
([ae616f1ae616f146b#7544 ](https://github.com/n8n-io/n8n/issues/7544 ))
([3b5e1813b5e181e66#7532 ](https://github.com/n8n-io/n8n/issues/7532 ))
([2853fcf2853fcff73#7434 ](https://github.com/n8n-io/n8n/issues/7434 ))
([12a89e612a89e6d14#7516 ](https://github.com/n8n-io/n8n/issues/7516 ))
([df89685df89685e15#7348 ](https://github.com/n8n-io/n8n/issues/7348 ))
([c05bc67c05bc6728d#7573 ](https://github.com/n8n-io/n8n/issues/7573 ))
([1d81afc1d81afcbdf#7534 ](https://github.com/n8n-io/n8n/issues/7534 ))
([97627059762705833#7555 ](https://github.com/n8n-io/n8n/issues/7555 ))
([7a56e587a56e58a60#7460 ](https://github.com/n8n-io/n8n/issues/7460 ))
([655efea655efeaf66#7526 ](https://github.com/n8n-io/n8n/issues/7526 ))
([3d95b243d95b243e9#7527 ](https://github.com/n8n-io/n8n/issues/7527 ))
([442c73e442c73e63b#7559 ](https://github.com/n8n-io/n8n/issues/7559 ))
([ce14f62ce14f6266b#5993 ](https://github.com/n8n-io/n8n/issues/5993 ))
([cc2bd2ecc2bd2e19c#7572 ](https://github.com/n8n-io/n8n/issues/7572 ))
([ff279abff279ab411#7474 ](https://github.com/n8n-io/n8n/issues/7474 ))
([b72040ab72040aa54#6980 ](https://github.com/n8n-io/n8n/pull/6980 ))
([07467830746783e02
2023-11-02 14:52:11 +01:00
github-actions[bot]
73e9a216b7
🚀 Release 1.15.0 ( #7580 )
...
#
[1.15.0](https://github.com/n8n-io/n8n/compare/n8n@1.14.0...n8n@1.15.0 )
(2023-11-02)
### Bug Fixes
* **core:** Ensure execution deletion in worker lifecycle hook
([#7481 ](https://github.com/n8n-io/n8n/issues/7481 ))
([742c8a8742c8a8534#7560 ](https://github.com/n8n-io/n8n/issues/7560 ))
([b350568b350568505#7408 ](https://github.com/n8n-io/n8n/issues/7408 ))
([479f902479f90231d#7523 ](https://github.com/n8n-io/n8n/issues/7523 ))
([1055bd31055bd3762#7576 ](https://github.com/n8n-io/n8n/issues/7576 ))
([437c95e437c95e84e#7569 ](https://github.com/n8n-io/n8n/issues/7569 ))
([9bdb85c9bdb85c4ce#7519 ](https://github.com/n8n-io/n8n/issues/7519 ))
([65e559365e5593233#7528 ](https://github.com/n8n-io/n8n/issues/7528 ))
([ae616f1ae616f146b#7544 ](https://github.com/n8n-io/n8n/issues/7544 ))
([3b5e1813b5e181e66#7532 ](https://github.com/n8n-io/n8n/issues/7532 ))
([2853fcf2853fcff73#7434 ](https://github.com/n8n-io/n8n/issues/7434 ))
([12a89e612a89e6d14#7516 ](https://github.com/n8n-io/n8n/issues/7516 ))
([df89685df89685e15#7348 ](https://github.com/n8n-io/n8n/issues/7348 ))
([c05bc67c05bc6728d#7534 ](https://github.com/n8n-io/n8n/issues/7534 ))
([97627059762705833#7555 ](https://github.com/n8n-io/n8n/issues/7555 ))
([7a56e587a56e58a60#7460 ](https://github.com/n8n-io/n8n/issues/7460 ))
([655efea655efeaf66#7526 ](https://github.com/n8n-io/n8n/issues/7526 ))
([3d95b243d95b243e9#7527 ](https://github.com/n8n-io/n8n/issues/7527 ))
([442c73e442c73e63b#7559 ](https://github.com/n8n-io/n8n/issues/7559 ))
([ce14f62ce14f6266b#5993 ](https://github.com/n8n-io/n8n/issues/5993 ))
([cc2bd2ecc2bd2e19c#7572 ](https://github.com/n8n-io/n8n/issues/7572 ))
([ff279abff279ab411#7474 ](https://github.com/n8n-io/n8n/issues/7474 ))
([b72040ab72040aa54#6980 ](https://github.com/n8n-io/n8n/pull/6980 ))
([07467830746783e02
2023-11-02 11:47:11 +01:00
Jan Oberhauser
be49778388
fix(editor): Fix more dark mode issues (no-changelog) ( #7578 )
...
Github issue / Community forum post (link here to close automatically):
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
Co-authored-by: Giulio Andreini <andreini@netseven.it>
2023-11-02 10:57:08 +01:00
Alex Grozav
721a36637c
feat(editor): Handle pin data edge cases and unify validation (no-changelog) ( #6685 )
...
Github issue / Community forum post (link here to close automatically):
2023-11-02 10:43:02 +02:00
कारतोफ्फेलस्क्रिप्ट™
100291e109
refactor(editor): Dark theme improvements (no-changelog) ( #7574 )
...
Co-authored-by: Mutasem Aldmour <4711238+mutdmour@users.noreply.github.com>
2023-11-01 17:56:15 +01:00
Mutasem Aldmour
1d81afcbdf
fix: Fix dark mode small issues ( #7573 )
...
Github issue / Community forum post (link here to close automatically):
2023-11-01 16:27:32 +01:00
Jan Oberhauser
cc2bd2e19c
feat(HTTP Request Node): Add pagination support ( #5993 )
...
Is still WIP and does not implement the correct UI yet.
Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/pagination-included-into-http-node/15080
https://community.n8n.io/t/how-to-paginate-through-data-in-http-requests/28103
2023-11-01 14:24:43 +01:00
Giulio Andreini
0746783e02
refactor(editor): Color palette updates, introduce dark mode ( #6980 )
...
Github issue / Community forum post (link here to close automatically):
---------
Co-authored-by: Mutasem <mutdmour@gmail.com>
2023-11-01 13:33:36 +01:00
Csaba Tuncsik
b94b8b2eb0
fix(editor): Rename and move isObjectLiteral utility function (no-changelog) ( #7565 )
2023-10-31 21:28:01 +01:00
OlegIvaniv
774d521dbd
fix(editor): Keep NodeView component alive for TEMPLATE_IMPORT and WORKFLOW_ONBOARDING routes (no-changelog) ( #7557 )
...
Github issue / Community forum post (link here to close automatically):
2023-10-31 10:03:57 +01:00
Jan Oberhauser
655efeaf66
feat(core): Add optional Error-Output ( #7460 )
...
Add an additional optional error output to which all items get sent that
could not be processed.
Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/error-connector-for-nodes/3094
https://community.n8n.io/t/error-handling-at-node-level-detect-node-execution-status/26791
---------
Co-authored-by: OlegIvaniv <me@olegivaniv.com>
2023-10-30 18:42:47 +01:00
Csaba Tuncsik
3b5e181e66
fix(editor): Fix NDV close after using input select ( #7544 )
2023-10-30 13:44:19 +01:00
Csaba Tuncsik
2853fcff73
fix(editor): Fix NDV unexpected re-render ( #7532 )
2023-10-30 09:22:08 +01:00
कारतोफ्फेलस्क्रिप्ट™
c05bc6728d
fix(editor): Handle localStorage being blocked/unavailable ( #7348 )
2023-10-27 15:51:20 +02:00
कारतोफ्फेलस्क्रिप्ट™
35bb42c1b9
refactor(core): Avoid passing around static state like default timezone (no-changelog) ( #7221 )
2023-10-27 14:17:52 +02:00
Iván Ovejero
62c096710f
refactor: Run lintfix (no-changelog) ( #7537 )
...
- Fix autofixable violations
- Remove unused directives
- Allow for PascalCased variables - needed for dynamically imported or
assigned classes, decorators, routers, etc.
2023-10-27 14:15:02 +02:00
Alex Grozav
1c4ac02db5
fix(editor): Fix executions sidebar height (no-changelog) ( #6909 )
...
<img width="1397" alt="image"
src="https://github.com/n8n-io/n8n/assets/6179477/cb142085-3b21-4e18-9f0d-92c5c4018578 ">
2023-10-27 14:32:23 +03:00
Csaba Tuncsik
12a89e6d14
fix(editor): Fix route component caching, incorrect use of array reduce method and enable WF history feature ( #7434 )
...
Co-authored-by: Giulio Andreini <andreini@netseven.it>
2023-10-26 20:47:42 +02:00
Iván Ovejero
ae616f146b
fix(editor): Do not truncate form inputs ( #7528 )
2023-10-26 17:54:51 +02:00
Jan Oberhauser
df89685e15
fix(editor): Fixes the issue that Switch Node can not be created ( #7516 )
...
Fixes the issue that currently no Switch-Node can be created by for
example pressing + on the parent node or via tab when another node is
already selected.
Github issue / Community forum post (link here to close automatically):
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Oleg Ivaniv <me@olegivaniv.com>
2023-10-26 09:46:26 +02:00
कारतोफ्फेलस्क्रिप्ट™
05586a900d
refactor(core): Make Logger a service (no-changelog) ( #7494 )
2023-10-25 16:35:22 +02:00
github-actions[bot]
db4e61ba24
🚀 Release 1.14.0 ( #7514 )
...
# [1.14.0](https://github.com/n8n-io/n8n/compare/n8n@1.13.0...n8n@1.14.0 )
(2023-10-25)
### Features
* **Switch Node:** Add support for infinite Switch outputs
([#7499 ](https://github.com/n8n-io/n8n/issues/7499 ))
([2febc612febc61ec9
2023-10-25 15:34:57 +02:00
कारतोफ्फेलस्क्रिप्ट™
28aabb845a
Merge remote-tracking branch 'origin/release/1.13.0'
2023-10-25 14:50:48 +02:00
OlegIvaniv
2febc61ec9
feat(Switch Node): Add support for infinite Switch outputs ( #7499 )
...
Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/add-more-outputs-to-switch-node/3864
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
2023-10-25 14:34:47 +02:00
github-actions[bot]
2987587e34
🚀 Release 1.13.0 ( #7512 )
...
# [1.13.0](https://github.com/n8n-io/n8n/compare/n8n@1.12.0...n8n@1.13.0 )
(2023-10-25)
### Bug Fixes
* **core:** Do not return `inviteAcceptUrl` in response if email was
sent ([#7465 ](https://github.com/n8n-io/n8n/issues/7465 ))
([55c6a1b55c6a1b0d3#7500 ](https://github.com/n8n-io/n8n/issues/7500 ))
([6f452986f45298d3d#7496 ](https://github.com/n8n-io/n8n/issues/7496 ))
([774fe20774fe202bf#7461 ](https://github.com/n8n-io/n8n/issues/7461 ))
([83762e083762e051d#7479 ](https://github.com/n8n-io/n8n/issues/7479 ))
([76c048176c04815f7#7485 ](https://github.com/n8n-io/n8n/issues/7485 ))
([519680c519680c2cf#7458 ](https://github.com/n8n-io/n8n/issues/7458 ))
([3c0a1663c0a166f7f#7466 ](https://github.com/n8n-io/n8n/issues/7466 ))
([bc47365bc473655fb#7483 ](https://github.com/n8n-io/n8n/issues/7483 ))
([450e0cc450e0cc66a#7463 ](https://github.com/n8n-io/n8n/issues/7463 ))
([ab6a9bbab6a9bbac2#7467 ](https://github.com/n8n-io/n8n/issues/7467 ))
([a739245a739245332#7498 ](https://github.com/n8n-io/n8n/issues/7498 ))
([baecb93baecb93bef#7464 ](https://github.com/n8n-io/n8n/issues/7464 ))
([5c46bb05c46bb09c1#7444 ](https://github.com/n8n-io/n8n/issues/7444 ))
([4e660234e66023cd4#7505 ](https://github.com/n8n-io/n8n/issues/7505 ))
([05e6f2a05e6f2a6ac#7311 ](https://github.com/n8n-io/n8n/issues/7311 ))
([647372b647372be27#7511 ](https://github.com/n8n-io/n8n/issues/7511 ))
([c47d27dc47d27dd6d#7113 ](https://github.com/n8n-io/n8n/issues/7113 ))
([ac814a9ac814a9c61#7488 ](https://github.com/n8n-io/n8n/issues/7488 ))
([7b1973c7b1973c058#7386 ](https://github.com/n8n-io/n8n/issues/7386 ))
([689360e689360ee06
2023-10-25 14:29:28 +02:00
Mutasem Aldmour
c47d27dd6d
feat(editor): Add PH tracking to event ( #7511 )
...
Github issue / Community forum post (link here to close automatically):
2023-10-25 12:18:19 +02:00
OlegIvaniv
450e0cc66a
fix(editor): Fix connections disappearing after reactivating canvas and renaming a node ( #7483 )
...
Github issue / Community forum post (link here to close automatically):
-
https://community.n8n.io/t/1-11-1-possible-bug-all-nodes-randomly-losing-their-connectors/31856
- https://community.n8n.io/t/lines-between-nodes-have-disappeared/31846
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
2023-10-23 10:07:33 +02:00
कारतोफ्फेलस्क्रिप्ट™
3c0a166f7f
fix(editor): Allow importing the same workflow multiple times ( #7458 )
...
Fixes #7457
2023-10-20 13:58:30 +02:00
Elias Meire
ac814a9c61
feat(Facebook Lead Ads Trigger Node): Add Facebook Lead Ads Trigger Node ( #7113 )
...
Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/facebook-lead-ads-integration/4590/19
---------
Co-authored-by: Marcus <marcus@n8n.io>
2023-10-20 13:43:55 +02:00
कारतोफ्फेलस्क्रिप्ट™
91dfc4d513
feat(core): Update LLM applications building support (no-changelog) ( #7418 )
...
extracted out of #7336
---------
Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
Co-authored-by: OlegIvaniv <me@olegivaniv.com>
Co-authored-by: Jan Oberhauser <janober@users.noreply.github.com>
Co-authored-by: Val <68596159+valya@users.noreply.github.com>
Co-authored-by: Alex Grozav <alex@grozav.com>
Co-authored-by: Deborah <deborah@starfallprojects.co.uk>
Co-authored-by: Jesper Bylund <mail@jesperbylund.com>
Co-authored-by: Jon <jonathan.bennetts@gmail.com>
2023-10-20 10:52:56 +02:00
Milorad FIlipović
bc473655fb
fix(editor): Fix canvas selection breaking after interacting with node actions ( #7466 )
...
Sometimes canvas selection stops working after users interact with node
action buttons (for example if node is moved by dragging one of the
buttons)
NOTE: Ticket number in the branch name is wrong, this fixes ADO-1226
2023-10-20 09:26:40 +02:00
Csaba Tuncsik
c7c8048430
feat(editor): Workflow history [WIP] - Remove pinned data from workflow history version preview (no-changelog) ( #7406 )
2023-10-19 14:38:00 +02:00
Csaba Tuncsik
82129694c6
feat(editor): Workflow history [WIP] - Add cloned workflow link to success toast message (no-changelog) ( #7405 )
2023-10-19 14:02:59 +02:00
github-actions[bot]
ef58a23d21
🚀 Release 1.12.0 ( #7459 )
...
# [1.12.0](https://github.com/n8n-io/n8n/compare/n8n@1.11.0...n8n@1.12.0 )
(2023-10-18)
### Bug Fixes
* **core:** Add check that queue is defined and remove cyclic dependency
([#7404 ](https://github.com/n8n-io/n8n/issues/7404 ))
([45f2ef345f2ef373e#7411 ](https://github.com/n8n-io/n8n/issues/7411 ))
([2b6a15e2b6a15e478#7424 ](https://github.com/n8n-io/n8n/issues/7424 ))
([ec14141ec141416e2#7368 ](https://github.com/n8n-io/n8n/issues/7368 ))
([2f4d91b2f4d91b2cd#7417 ](https://github.com/n8n-io/n8n/issues/7417 ))
([770390477039044eb#7435 ](https://github.com/n8n-io/n8n/issues/7435 ))
([e01b9e5e01b9e5ae1#7419 ](https://github.com/n8n-io/n8n/issues/7419 ))
([46977a246977a2aff#7320 ](https://github.com/n8n-io/n8n/issues/7320 ))
([367255a367255ab2c#7377 ](https://github.com/n8n-io/n8n/issues/7377 ))
([c599006c599006b91#7357 ](https://github.com/n8n-io/n8n/issues/7357 ))
([d8531a5d8531a53b9#7432 ](https://github.com/n8n-io/n8n/issues/7432 ))
([c3f0be8c3f0be809f#7416 ](https://github.com/n8n-io/n8n/issues/7416 ))
([e9b6ab0e9b6ab04cd#7450 ](https://github.com/n8n-io/n8n/issues/7450 ))
([a2d2e3da2d2e3dda7#7439 ](https://github.com/n8n-io/n8n/issues/7439 ))
([40707fa40707fa692#7436 ](https://github.com/n8n-io/n8n/issues/7436 ))
([9d241a09d241a0d6d#7156 ](https://github.com/n8n-io/n8n/issues/7156 ))
([57c609357c609384a#7130 ](https://github.com/n8n-io/n8n/issues/7130 ))
([3ddc1763ddc176dfa#7448 ](https://github.com/n8n-io/n8n/issues/7448 ))
([79f23fb79f23fb939
2023-10-18 17:43:29 +02:00
Michael Kret
3ddc176dfa
feat(n8n Form Trigger Node): New node ( #7130 )
...
Github issue / Community forum post (link here to close automatically):
based on https://github.com/joffcom/n8n-nodes-form-trigger
---------
Co-authored-by: Giulio Andreini <g.andreini@gmail.com>
2023-10-17 07:09:30 +03:00
Inga
c599006b91
fix(editor): Open only one tab with plans page ( #7377 )
...
## Issue
In community edition, clicking on "View plans" button on "Settings" ->
"Usage and plan" page (e.g. http://127.0.0.1:5678/settings/usage ) opens
two new tabs with n8n pricing (one of them with UTM tracking, another
without).
This was introduced in #6317 , when click handler of "View plans" link
container [started
calling](https://github.com/n8n-io/n8n/pull/6317/files#diff-0bf26afac8a06e03b3d39d0668f22408859355b585a9ab420800c125e33f0691R109 )
`uiStore.goToUpgrade(...)` which opens n8n pricing in a new tab, while
browser opens another tab for the link URL.
The simplest fix, implemented in this PR, is to prevent default event
handling (so that, after `onViewPlans` is called, browser will not
attempt to process the click additionally as clicking on the link),
similarly to how it is prevented on some other pages. It only solves the
immediate problem of browser opening two new tabs on clicking "View
plans".
Note that **I didn't implement any tests for the changed behavior**,
because it was not covered by tests before, and I couldn't quite figure
out how to cover it now within the existing test approach (considering
that testing the fact that only one new tab is open will likely require
to write entirely new tests relying on puppeteer; as far as I can see,
no existing `editor-ui` tests are doing anything like that). I'll gladly
implement tests for the new behavior if you tell me how you would like
them to look.
The existing tests for `editor-ui` still pass; I didn't run tests for
other subpackages (see "additional contribution notes" below).
## Additional notes on the issue.
I'm not sure that the change in this PR is the correct long-term
solution for the issue, because the URLs for these two methods (custom
click handler for link container and default link handling) are slightly
different:
* Custom click handler calls `useTelemetryStore().track('User clicked
upgrade CTA', ...)`; then calls `sendUsageTelemetry('view_plans')` (it
feels weird that two calls to telemetry are made); then opens new tab
for `https://n8n.io/pricing?utm_campaign=open&source=usage_page ` (note
that prior to #7316 the second call to telemetry was done after the new
tab is opened, not before);
* Link itself refers to another page, with slightly different tracking
parameters:
`https://subscription.n8n.io/?instanceid=[REDACTED]&version=1.10.0&callback=http%3A%2F%2F127.0.0.1%3A5678%2Fsettings%2Fusage&source=usage_page `;
but this page redirects to `https://n8n.io/pricing/ `.
It is not clear which one of the two is the right way of doing things.
Although `goToUpgrade` is called in 20 places throughout `editor-ui`,
while `viewPlansUrl`, as far as I can see, is used for this button only.
Additionally, since Settings pages don't work without JS anyway, I can
only think of two separate scenarios where any tab would be opened:
* Left-clicking the link (or Ctrl-clicking, or pressing Space or Enter
when the link is focused, or tapping): previously, both custom click
handler was executed and link's `href` was opened; in this PR, only
custom click handler is executed (similarly to how it is done in the
other places where `goToUpgrade` is called);
* Right-clicking (or long tapping, or opening context menu in any other
way) and selecting "open link in new tab" (or similar): opens a new tab
for URL from the `href` attribute (and does not send any telemetry at
all).
I'd say that the better permanent solution would probably be to get rid
of one of these methods entirely, and only rely on another in all cases
(for me, as an outside contributor, the preferred way would be for
custom click handler to only send telemetry, while letting my browser
handle the actual navigation). However, that would be a large change,
much more than one line in this PR.
Additionally, other similar places where `goToUpgrade` is currently
called (directly or indirectly) would also need to be adapted for this
change.
## Additional contribution notes
As a first-time contributor, I've encountered several things I didn't
expect; I'm not sure if they should be expected or are issues:
1. Tests for the entire monorepo consume a lot of RAM; 20GB free RAM was
not enough, so I couldn't run tests for the entire monorepo and had to
only run them for `packages/editor-ui`;
2. Linting is very slow; `pnpm lint` in `packages/editor-ui` takes ten
minutes to complete;
3. It seems that types are not checked. Code OSS highlights numerous
errors in code files: for example, `'debug'` is incompatible with
`CloudUpdateLinkSourceType` expected by `goToUpgrade` here:
3e7a4d3b2c/packages/editor-ui/src/composables/useExecutionDebugging.ts (L128)
2023-10-13 14:14:26 +02:00
Milorad FIlipović
367255ab2c
fix(editor): Fix remote options fetching on every keystroke ( #7320 )
...
Github issue / Community forum post (link here to close automatically):
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-10-12 14:18:35 +02:00
github-actions[bot]
e6ba841c5f
🚀 Release 1.11.0 ( #7402 )
...
# [1.11.0](https://github.com/n8n-io/n8n/compare/n8n@1.10.0...n8n@1.11.0 )
(2023-10-11)
### Bug Fixes
* **core:** Add an option to enable postgres ssl with default certs
([#6889 ](https://github.com/n8n-io/n8n/issues/6889 ))
([789e1e7789e1e7ed4#7399 ](https://github.com/n8n-io/n8n/issues/7399 ))
([47e895347e8953ec9#7326 ](https://github.com/n8n-io/n8n/issues/7326 ))
([e2c3c7ae2c3c7aceb#7366 ](https://github.com/n8n-io/n8n/issues/7366 ))
([63e11e463e11e4be9#7382 ](https://github.com/n8n-io/n8n/issues/7382 ))
([86e7ec786e7ec796a#7376 ](https://github.com/n8n-io/n8n/issues/7376 ))
([7e06b317e06b31a5f#7392 ](https://github.com/n8n-io/n8n/issues/7392 ))
([7ed466d7ed466db7f#7372 ](https://github.com/n8n-io/n8n/issues/7372 ))
([3fa27643fa27647d8#7400 ](https://github.com/n8n-io/n8n/issues/7400 ))
([2b075bf2b075bfc2d#7351 ](https://github.com/n8n-io/n8n/issues/7351 ))
([afbf0c3afbf0c3d5e#7354 ](https://github.com/n8n-io/n8n/issues/7354 ))
([97bb70397bb703d0a#7369 ](https://github.com/n8n-io/n8n/issues/7369 ))
([3e7a4d33e7a4d3b2c#7384 ](https://github.com/n8n-io/n8n/issues/7384 ))
([732b15a732b15a1fa#7379 ](https://github.com/n8n-io/n8n/issues/7379 ))
([77643e577643e5ccb#7383 ](https://github.com/n8n-io/n8n/issues/7383 ))
([fbcd1d4fbcd1d40ed#7358 ](https://github.com/n8n-io/n8n/issues/7358 ))
([e5ad1e7e5ad1e7e4d#7385 ](https://github.com/n8n-io/n8n/issues/7385 ))
([6479eb16479eb180f#7360 ](https://github.com/n8n-io/n8n/issues/7360 ))
([b8608ceb8608cee6d#7253 ](https://github.com/n8n-io/n8n/issues/7253 ))
([1a661e61a661e6d00#7307 ](https://github.com/n8n-io/n8n/issues/7307 ))
([0847623](0847623f85#7367 ](https://github.com/n8n-io/n8n/issues/7367 ))
([8187be18187be1b7d#7316 ](https://github.com/n8n-io/n8n/issues/7316 ))
([1dfa0521dfa052301#7289 ](https://github.com/n8n-io/n8n/issues/7289 ))
([c8c14cac8c14ca0af#7297 ](https://github.com/n8n-io/n8n/issues/7297 ))
([965db8f965db8f7f2#7228 ](https://github.com/n8n-io/n8n/issues/7228 ))
([7b773cc7b773cc5cc#7304 ](https://github.com/n8n-io/n8n/issues/7304 ))
([193181a193181a9c6
2023-10-11 13:38:34 +02:00
