mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-11-15 09:04:07 -08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity
11519 commits 1056 branches 1593 tags 393 MiB
Commit graph

2172 commits

Author SHA1 Message Date
Ricardo Espinoza 552cf8f3db
fix(editor): Fix type errors in the SettingsLdapView.vue (no-changelog) (#9308) 2024-05-06 11:20:55 -04:00
कारतोफ्फेलस्क्रिप्ट™ b65e0e2811
fix(editor): Show MFA section to instance owner, even when external auth is enabled (#9301) 2024-05-03 15:03:59 +02:00
Iván Ovejero d92f994913
fix(editor): Resolve $vars and $secrets in expressions in credentials fields (#9289) 2024-05-03 14:39:31 +02:00
Alex Grozav ff0955c995
refactor(editor): Migrate pushConnection mixin to composable and remove collaboration store side effects (no-changelog) (#9249) 2024-05-03 10:26:15 +03:00
Alex Grozav cd9bc44bdd
feat: Add Ask AI to HTTP Request Node (#8917) 2024-05-02 13:52:15 +03:00
Michael Kret ed98ca2fb7
fix(Jira Trigger Node): Update credentials UI (#9198) 2024-05-01 07:26:09 +03:00
Iván Ovejero 426a12ac0e
fix(editor): Prevent excess runs in manual execution with run data (#9259) 2024-04-30 15:00:17 +02:00
oleg 96f02bd655
feat(Groq Chat Model Node): Add support for Groq chat models (#9250) 
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Michael Kret <michael.k@radency.com>
 2024-04-30 09:37:30 +02:00
Alex Grozav c6b4c6dbf2
refactor(editor): Rewrite TabBar to composition API (no-changelog) (#9231) 2024-04-29 16:10:48 +03:00
Alex Grozav 1c261f85a3
refactor(editor): Migrate header WorkflowDetails to composition api (no-changelog) (#9186) 2024-04-29 07:53:42 +03:00
Iván Ovejero 11a3572144
fix(editor): Fix and report settings being null in workflow payloads (no-changelog) (#9227) 2024-04-26 15:30:51 +02:00
Elias Meire 99f384e2cf
fix(editor): Fix read-only mode in inline expression editor (#9232) 2024-04-26 15:12:06 +02:00
Iván Ovejero fec04d5f79
fix(editor): Throw expression error on attempting to set variables at runtime (#9229) 2024-04-26 14:03:27 +02:00
Michael Kret 2bf0a3933e
feat(Webhook Node): Setting to enable multiple outputs/methods (#9086) 
Co-authored-by: Giulio Andreini <andreini@netseven.it>
 2024-04-24 08:46:16 +03:00
Elias Meire 29ee4fab61
fix(Google Sheets Node): Fix "Append or Update" on an empty sheet (#9175) 
Co-authored-by: Michael Kret <michael.k@radency.com>
 2024-04-23 10:29:39 +02:00
oleg f5ccb5fe33
fix(editor): Fix sessionId for manual chat trigger execution (#9187) 
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
 2024-04-23 09:20:51 +02:00
Elias Meire 5acbfb4234
fix(editor): Prevent duplicate values in preview for SQL editor (#9129) 2024-04-22 14:57:41 +02:00
Elias Meire 85780eade5
fix(editor): Fix expression preview when previous node is selected (#9140) 2024-04-19 10:07:00 +02:00
Alex Grozav a3eea3ac5e
feat(editor): Refactor and unify executions views (no-changelog) (#8538) 2024-04-19 07:50:18 +02:00
Elias Meire 135ef75add
fix(editor): Fix parameter reset on credential change in Discord node (#9137) 2024-04-18 14:56:04 +02:00
Milorad FIlipović 53101960e6
fix: Update sales templates card content (no-changelog) (#9155) 2024-04-18 12:30:30 +02:00
Elias Meire 1c7acbb629
refactor: Refactor ParameterInput to composition API + fix all TS errors (no-changelog) (#9006) 2024-04-18 11:48:52 +02:00
oleg f1215cdb6b
feat(Google Gemini Chat Model Node): Add support for new Google Gemini models (#9130) 
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Michael Kret <michael.k@radency.com>
 2024-04-15 13:56:44 +02:00
Elias Meire 064e8f4a1d
fix(editor): Render dates correctly in parameter hint (#9089) 2024-04-11 12:09:55 +02:00
Michael Kret c00150bb8f
fix(editor): Do not show overlapping trash icon in the node's settings (#9119) 2024-04-11 11:32:16 +03:00
Elias Meire 98bcd50bab
feat(editor): Add object keys that need bracket access to autocomplete (#9088) 2024-04-10 16:33:59 +02:00
Jon 4eb4ade3a8
docs: Update wording for Advanced AI in nodes panel (#9091) 2024-04-10 11:23:43 +01:00
कारतोफ्फेलस्क्रिप्ट™ d46635fdb9
fix(editor): Set browser-id on all relative urls (no-changelog) (#9097) 2024-04-09 15:12:23 +02:00
Tomi Turtiainen 8c2622549b
feat: Add telemetry event 'User clicked AI error helper button' (no-changelog) (#9096) 2024-04-09 14:33:15 +03:00
Ahsan Virani aa1370469e
feat(editor): Remove cloud deployment check from settings route middlewareOptions (no-changelog) (#9095) 2024-04-09 13:02:15 +02:00
Tomi Turtiainen 4ac02dd5f4
fix(editor): UX improvements to mfa setup modal (#9059) 
Co-authored-by: Giulio Andreini <andreini@netseven.it>
 2024-04-09 13:57:14 +03:00
कारतोफ्फेलस्क्रिप्ट™ 28261047c3
feat(core): Prevent session hijacking (#9057) 2024-04-09 11:20:35 +02:00
Michael Kret 5793e5644a
feat: Append item index suffix to an error message, if provided, and node has many input items (#9070) 2024-04-09 11:33:26 +03:00
Csaba Tuncsik 92f6cbfba3
fix(editor): Fix displaying logic of execution retry button (#9061) 2024-04-09 10:25:12 +02:00
Michael Kret 3dd70a17e2
fix(editor): Drop outgoing connections on order changed event for nodes with dynamic outputs (#9055) 2024-04-09 04:46:52 +03:00
Iván Ovejero 3bcfef95f6
fix(editor): Expand range of allowed characters in expressions (#9083) 
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
 2024-04-08 16:31:52 +02:00
Tomi Turtiainen 50dd90db1a
fix: Fix some vue warnings (no-changelog) (#9069) 2024-04-08 13:08:28 +03:00
Tomi Turtiainen 7467aa30e6
fix(editor): Fix issues in dark mode (#9068) 
Co-authored-by: Giulio Andreini <andreini@netseven.it>
 2024-04-08 09:21:54 +03:00
Milorad FIlipović f2143620ba
fix(editor): Connecting nodes to triggers when adding them together (#9042) 2024-04-05 15:46:02 +02:00
oleg 32df17104c
fix(editor): Allow pinning of AI root nodes (#9060) 
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
 2024-04-05 15:00:31 +02:00
Ricardo Espinoza caea27dbb5
fix(editor): Fix issue with case insensitive tags (#9071) 2024-04-05 09:00:18 -04:00
Iván Ovejero b8ab049932
refactor(core, editor): Remove legacy nodesAccess (no-changelog) (#9016) 2024-04-05 13:17:34 +02:00
Iván Ovejero ba986fb018
refactor(editor): Remove legacy audit logs view (no-changelog) (#9053) 2024-04-05 10:23:27 +02:00
कारतोफ्फेलस्क्रिप्ट™ 637b6c4d3e
refactor(editor): Do not make rest api calls for disabled features (no-changelog) (#9046) 2024-04-04 15:53:34 +02:00
Csaba Tuncsik db4f8d49a3
fix(editor): Fix execution with wait node (#9051) 2024-04-04 12:33:29 +02:00
Ricardo Espinoza dff8f7ac94
fix(editor): Issue showing Auth2 callback section when all properties are overriden (#8999) 2024-04-04 05:30:37 -04:00
Omar Ajoue bc6575afbb
fix(editor): Rerun failed nodes in manual executions (#9050) 
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
 2024-04-04 11:28:35 +02:00
Ricardo Espinoza f6ce81e7da
fix(editor): Canvas showing error toast when clicking outside of "import workflow by url" modal (#9001) 2024-04-04 05:15:37 -04:00
Tomi Turtiainen 71c54cba52
fix: Fix missing input panel in node details view (#9043) 2024-04-04 11:13:37 +03:00
Milorad FIlipović 3c9a1d2da3
fix(editor): Prevent saving workflow while another save is in progress (#9048) 2024-04-04 09:59:02 +02:00
Iván Ovejero 042aa62fc2
fix(editor): Make Webhook node pinnable (#9047) 2024-04-03 17:41:15 +02:00
Iván Ovejero bcd39a110b
fix(editor): Add fallback for expression resolution in multi-output case (#9045) 2024-04-03 17:07:58 +02:00
Csaba Tuncsik ec9fe98a35
fix(editor): Make share modal content scrollable (#9025) 2024-04-03 16:50:25 +02:00
Tomi Turtiainen 77b359ada6
fix: Fix vue type warnings (no-changelog) (#9038) 2024-04-03 15:04:21 +03:00
कारतोफ्फेलस्क्रिप्ट™ 072c3db97d
refactor(core): Rename push sessionId to pushRef (#8905) 2024-04-03 13:43:14 +02:00
Tomi Turtiainen eaaefd76da
feat: Allow workflow execution even if it has errors (#9037) 2024-04-03 14:35:06 +03:00
Milorad FIlipović 02219dde2f fix: Stop listening button not working in NDV (#9023) 2024-04-03 12:18:50 +02:00
Ricardo Espinoza 4668db20fb fix(editor): Issue with JSON editor getting cut off (#9000) 2024-04-03 12:15:19 +02:00
Milorad FIlipović 4619dec285 feat(editor): Update templates links (#9024) 2024-04-03 12:15:08 +02:00
Csaba Tuncsik aac77e1668 fix(editor): Fix execution debug button (#9018) 2024-04-03 12:15:07 +02:00
Michael Kret 3fd97e4c72
fix: Prevent chat modal opening on 'Test workflow' click (#9009) 
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Oleg Ivaniv <me@olegivaniv.com>
 2024-04-01 17:08:00 +03:00
Ricardo Espinoza bead7eb840
fix(editor): Hover and active states not showing in execution list on dark mode (#9002) 
Co-authored-by: Giulio Andreini <andreini@netseven.it>
 2024-03-29 11:13:48 -04:00
Elias Meire 8788e2a35b
fix(editor): UI enhancements and fixes for expression inputs (#8996) 2024-03-29 16:01:32 +01:00
Iván Ovejero 2aab78b058
feat(core): Introduce AWS secrets manager as external secrets store (#8982) 2024-03-28 10:15:58 +01:00
Michael Kret ae75cf414a
fix: Get all parent nodes > useRunWorkflow (no-changelog) (#8992) 2024-03-28 11:12:36 +02:00
Elias Meire 295b650fb8
fix(editor): Make inputs in the filter component regular inputs by default (#8980) 2024-03-27 09:52:58 +01:00
Elias Meire 160dfd383d
feat(editor): Show tip when user can type dot after an expression (#8931) 2024-03-26 15:23:30 +01:00
कारतोफ्फेलस्क्रिप्ट™ 372d5c7d01
ci: Upgrade eslint, prettier, typescript, and some other dev tooling (no-changelog) (#8895) 
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
 2024-03-26 14:22:57 +01:00
Csaba Tuncsik 117b57ccc5
fix(editor): Fix accidental IDE code addition (#8971) 2024-03-26 10:50:31 +01:00
Giulio Andreini 264f918d97
fix(editor): Nodes connectors improvements (#8945) 
Co-authored-by: Elias Meire <elias@meire.dev>
 2024-03-26 09:54:04 +01:00
Iván Ovejero 69807a5efb
refactor(core): Unify failed and error execution status (no-changelog) (#8943) 2024-03-25 17:52:07 +01:00
Elias Meire 0e4216d7af
fix(editor): Use bracket notation for all invalid identifiers in expressions (#8933) 2024-03-22 13:53:06 +01:00
Milorad FIlipović 666867a236
feat: Fetch user cloud role and pass it on in website links (#8942) 2024-03-22 11:33:39 +01:00
Giulio Andreini 3f13d8f41a
fix(editor): Fix error message color in output panel for dark mode (no-changelog) (#8950) 2024-03-22 09:18:27 +01:00
Elias Meire 45461c8cb5
fix: Overhaul expression error messages related to paired item (#8765) 2024-03-21 16:59:22 +01:00
oleg 5f53d76e39
fix(editor): Fix opening of chat window when executing a child node (#8789) 
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Michael Kret <michael.k@radency.com>
 2024-03-21 09:23:15 +01:00
Elias Meire 5e84c2ab89
feat(editor): Add missing extension methods for expressions (#8845) 2024-03-20 12:05:54 +01:00
Elias Meire d7bfd45333
feat(editor): Add type information to autocomplete dropdown (#8843) 2024-03-19 18:10:14 +01:00
कारतोफ्फेलस्क्रिप्ट™ 669bd830e9
feat(editor): Block the frontend when trying to access n8n from another host over http (#8906) 2024-03-18 18:34:41 +01:00
Csaba Tuncsik 6955e8991c
fix(editor): Remove isOwner from IUser interface (#8888) 2024-03-18 11:39:15 +01:00
Elias Meire 0c179e4e51
feat(editor): Refactor expression editors and mixins to composition API (#8894) 
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
 2024-03-15 18:40:37 +01:00
Elias Meire a5261d6ebb
fix(editor): Improve expression editor performance by removing watchers (#8900) 2024-03-15 15:14:20 +01:00
Csaba Tuncsik a92d8bfc6e
fix(editor): Fix source control docs link in add workflow button tooltip (#8891) 2024-03-15 12:46:25 +00:00
Omar Ajoue bcbff76055
fix(editor): Add proper scroll to Environments push modal (#8883) 2024-03-14 09:26:04 +00:00
Michael Kret 4861556a1c
fix: Chat Trigger exclude summarization node from valid ai nodes (#8875) 2024-03-14 09:43:56 +02:00
Alex Grozav 948c383999
feat: Add AI Error Debugging using OpenAI (#8805) 2024-03-13 16:48:00 +02:00
Elias Meire e78cc2d8d2
feat(editor): Help users discover expressions when using drag n drop (#8869) 2024-03-13 12:57:08 +01:00
Csaba Tuncsik dd40570056
fix(editor): Fix workflow card open action (#8839) 2024-03-12 11:32:34 +01:00
Michael Kret e10fa379d3
fix: Disable pinning for root nodes from canvas (#8848) 2024-03-11 15:36:03 +02:00
Omar Ajoue bde4c6c7a1
fix: Allow sharee to use workflows with http request node without credential access (#8841) 2024-03-11 09:43:30 +00:00
Omar Ajoue 261b9c73d6
fix: Display readable error when manual executions contains large payload (#8834) 2024-03-08 12:23:27 +00:00
Elias Meire 76fe960a76
fix: Improve filter component error handling (#8832) 2024-03-08 10:10:32 +01:00
Giulio Andreini 5301323906
feat(editor): Improve errors in output panel (#8644) 
Co-authored-by: Michael Kret <michael.k@radency.com>
 2024-03-07 18:08:01 +02:00
Elias Meire 6e2aa405fc
fix(editor): Make inputs in the filter component expressions by default (#8784) 2024-03-07 17:01:56 +01:00
Elias Meire 9b4618dd5e
feat(editor): Add sections to autocomplete dropdown (#8720) 
Co-authored-by: Giulio Andreini <andreini@netseven.it>
 2024-03-07 17:01:05 +01:00
Michael Kret ed6dc86d60
feat: Add more AI node info to telemetry (#8827) 2024-03-07 12:46:07 +02:00
oleg 0f7ae3f50a
refactor: Update Langchain to 0.1.41 & add support for Claude 3 (#8825) 
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Michael Kret <michael.k@radency.com>
 2024-03-07 11:36:36 +01:00
Omar Ajoue d778cae9f5
feat: Track self serve trial (no-changelog) (#8801) 2024-03-06 10:29:47 +00:00
Michael Kret 35f6826150
feat: Track node errors on PostHog (#8774) 
Co-authored-by: Marcus <marcus@n8n.io>
 2024-03-05 16:58:14 +02:00
Elias Meire c7c17673cb
fix(editor): Fix NDV output tabs resetting on any click (#8808) 2024-03-05 15:45:41 +01:00
oleg bfda8ead0c
fix(editor): Fix retrieving of messages from memory in chat modal (#8807) 
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
 2024-03-05 13:53:46 +01:00
Elias Meire 8c993aa59d
fix(editor): Update assignment hint when user hovers table row (#8782) 2024-03-05 12:42:06 +01:00
Elias Meire 5d5466343e
fix(editor): Set correct type for right input in filter component (#8771) 2024-03-05 12:19:30 +01:00
Omar Ajoue 0d10befd60
refactor: Remove node access control (#8730) 2024-03-04 16:11:35 +00:00
Michael Kret 0481e6e6e7
fix(n8n Form Trigger Node): Do not open pop up when data is pinned in trigger (#8781) 2024-03-01 12:43:10 +02:00
Alex Grozav 3cbe1e2136
feat(editor): Migrate workflowRun mixin to useRunWorkflow composable (no-changelog) (#8711) 2024-02-27 11:39:45 +02:00
Elias Meire f9a99ec029
feat: No expression error when node hasn’t executed (#8448) 
Co-authored-by: Giulio Andreini <andreini@netseven.it>
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
 2024-02-27 10:29:16 +01:00
Omar Ajoue 737170893d
feat: Allow instance owners and admins to edit all credentials (#8716) 
Co-authored-by: Danny Martini <despair.blue@gmail.com>
 2024-02-27 08:26:36 +00:00
Milorad FIlipović 27f3166272
fix: Send user id when setting up an account (#8639) 2024-02-27 09:21:16 +01:00
Alex Grozav c0be43bdbe
fix(editor): Fix various typecheck issues (no-changelog) (#8739) 2024-02-26 16:05:12 +02:00
oleg 2c172e9fb3
fix(editor): Remove NDVSubConnections component console.log (no-changelog) (#8737) 
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
 2024-02-26 10:22:51 +01:00
oleg a973b9c077
fix(editor): Hide previous execution data for sub-nodes in debug mode if it has execution error (#8710) 
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
 2024-02-26 10:22:42 +01:00
Alex Grozav 4b01335aa4
feat: Add env variables to support exposing /workflows/demo route and /nodes.json route (#8506) 
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
 2024-02-23 18:20:12 +02:00
Elias Meire 3ba2cdcadb
fix(editor): Update Filter component state when value is updated (#8684) 2024-02-23 13:45:42 +01:00
oleg 41b191e055
feat(editor): AI Floating Nodes (#8703) 
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
 2024-02-23 13:34:32 +01:00
Jan Oberhauser a29b41ec55
fix(core): Fix pairedItem issue with partial manual executions (#8575) 
Co-authored-by: Danny Martini <danny@n8n.io>
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
 2024-02-23 11:43:08 +01:00
कारतोफ्फेलस्क्रिप्ट™ 8a88d15684
fix(editor): Do not break NDV for version-less nodes (#8714) 2024-02-22 15:37:29 +01:00
oleg 246f8cfcc3
feat(editor): Retrieve previous chat message on arrow-up (#8696) 
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
 2024-02-22 09:32:34 +01:00
Elias Meire 23a1bc40a2
fix(editor): Correctly set condition operator when changed (#8700) 2024-02-21 14:53:42 +01:00
कारतोफ्फेलस्क्रिप्ट™ 059d281fd1
feat(core): Move execution permission checks earlier in the lifecycle (#8677) 2024-02-21 14:47:02 +01:00
Milorad FIlipović a573146135
fix(editor): Send protocol and n8n version in templates destination parameter, stop redirecting template preview page to website (#8691) 2024-02-21 13:09:16 +01:00
Elias Meire 890c2bd52b
fix(editor): Escape node names with quotes in autocomplete and drag'n'drop (#8663) 2024-02-21 10:43:34 +01:00
Omar Ajoue c346002cc6
feat: Allow product updates as well as security updates (no-changelog) (#8689) 2024-02-21 09:11:42 +00:00
Elias Meire e2f2fc910d
fix(editor): Wrap expressions in resource locator component (#8673) 2024-02-20 17:22:44 +01:00
Elias Meire 20446bdf11
feat(editor): Add chevron to filter component operator select (#8633) 2024-02-20 15:19:16 +01:00
Elias Meire c943a51a28
fix(editor): Handle drag-n-dropping from other nodes in assignment component (#8661) 2024-02-20 11:21:10 +01:00
Csaba Tuncsik 40c7f77a35
fix(editor): Fix node runData and pinned data check on manual run (#8669) 2024-02-19 13:02:20 +01:00
Csaba Tuncsik 46fe544b9a
fix(editor): Fix unnecessary execution of nodes when there is pin data (#8567) 
Co-authored-by: Omar Ajoue <krynble@gmail.com>
 2024-02-16 16:24:07 +00:00
Csaba Tuncsik 9c0fe413d9
fix(editor): Use proper composable for localization (#8660) 2024-02-16 14:51:29 +01:00
Elias Meire 66cbe54e1d
fix(editor): Filter component: do not clear expression when changing operator (#8635) 2024-02-16 14:32:43 +01:00
Elias Meire 8e9d3106a5
fix(editor): Fix SQL editors not always re-rendering when query changes (#8621) 2024-02-16 11:26:43 +01:00
कारतोफ्फेलस्क्रिप्ट™ 8c665e4d20
refactor(editor): Re-organize n8n logo files (no-changelog) (#8483) 2024-02-16 10:42:32 +01:00
कारतोफ्फेलस्क्रिप्ट™ bf729aa2f0
refactor(editor): Do not use CodeNodeEditor anywhere except the Code node (no-changelog) (#8636) 2024-02-15 11:35:50 +01:00
Michael Kret 941278db68
feat(OpenAI Node): Overhaul (#8335) 2024-02-15 10:15:58 +02:00
Elias Meire 9c7e0266ee
fix(editor): Debounce expression changes (#8629) 2024-02-14 15:23:11 +01:00
Milorad FIlipović bf4f896373
feat: Add telemetry event when users click on templates link (#8625) 2024-02-14 13:26:44 +01:00
oleg f5274302f8
fix: Fix resolving of expressions of deeply nested sub-nodes (#8612) 2024-02-14 10:42:55 +01:00
Elias Meire 3b2078c3ca
fix(HTTP Request Node): Handle special characters in pagination expressions + improve hint text (#8576) 
Co-authored-by: Michael Kret <michael.k@radency.com>
 2024-02-12 17:32:27 +01:00
oleg 510bf8905d
refactor(editor): Refactor workflowHelpers mixin to composable (no-changelog) (#8600) 2024-02-12 10:45:05 +01:00
Mutasem Aldmour 64b10d7f5c
refactor: Remove any appcues events (#8597) 2024-02-09 15:15:59 +01:00
Milorad FIlipović 79b09fdf84
feat(editor): Use website as the main templates repository (#8591) 2024-02-09 13:47:43 +01:00
Omar Ajoue 7501ad8f3c
feat: Add support for AI log streaming (#8526) 
Co-authored-by: Oleg Ivaniv <me@olegivaniv.com>
 2024-02-09 09:41:01 +00:00
Elias Meire de6d466e5e
refactor: Add lint rule for unsafe property access with lodash get/set (no-changelog) (#8587) 2024-02-08 15:32:04 +01:00
Elias Meire 2799de491b
feat: Add assignment component with drag and drop to Set node (#8283) 
Co-authored-by: Giulio Andreini <andreini@netseven.it>
 2024-02-06 18:34:34 +01:00
Elias Meire 994754bf39
feat(editor): Add delete and disable button to nodes on hover (#8482) 2024-02-02 16:02:41 +01:00
Elias Meire 612771e032
fix(editor): Prune values that are not in the schema in the ResourceMapper component (#8478) 2024-02-02 11:28:12 +01:00
Milorad FIlipović 2aed788dc3
feat(editor): Send template id as string in all telemetry events (#8498) 2024-01-31 13:34:11 +01:00
Milorad FIlipović e643a126f4
feat(editor): Implement loading and error states for dynamically loaded components in node parameter list (#8477) 2024-01-30 14:27:42 +01:00
oleg 79c9763122
refactor(editor): Prevent router.replace from computed property (no-changelog) (#8489) 
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
 2024-01-30 12:00:10 +01:00
Milorad FIlipović 327cc8df73
fix(editor): Send template id as a number in telemetry events (#8484) 2024-01-30 10:37:06 +01:00
Csaba Tuncsik eb27ed068b
fix(editor): Disable expression editor modal opening on readonly field (#8457) 2024-01-29 16:34:10 +01:00
Giulio Andreini 97b398871d
docs(editor): Copy and aliases tweaks (no-changelog) (#8465) 2024-01-29 10:13:30 +01:00
Mutasem Aldmour 56da2e4352
fix: Open executions with large number of execution items without crashing tab (#8423) 
Co-authored-by: Tomi Turtiainen <10324676+tomi@users.noreply.github.com>
 2024-01-29 09:33:00 +01:00
Elias Meire c21c4b9178
feat: Add new 'is empty' and 'is not empty' operators to Filter (#8445) 
Co-authored-by: Michael Kret <michael.k@radency.com>
 2024-01-26 11:17:41 +01:00
Csaba Tuncsik ad4b298be3
fix(editor): Fix workflows filter resetting (#8411) 2024-01-26 06:55:08 +01:00
Csaba Tuncsik caab97e667
fix(editor): Show pin button on binary output but disable it with tooltip (#8388) 2024-01-26 06:54:49 +01:00
Tomi Turtiainen c3ec503836
feat: Add telemetry to become creator CTA (no-changelog) (#8429) 2024-01-25 10:24:13 +02:00
कारतोफ्फेलस्क्रिप्ट™ d6deceacde
refactor(core): Remove roleId indirection (no-changelog) (#8413) 2024-01-24 13:38:57 +01:00
कारतोफ्फेलस्क्रिप्ट™ 7386f79362
fix(editor): Fix copy to clipboard on insecure contexts (#8425) 2024-01-24 09:53:31 +01:00
Iván Ovejero 49b52c4f1d
refactor(core): Bring active executions into executions controller (no-changelog) (#8371) 2024-01-23 09:48:50 +01:00
Iván Ovejero 35449667bf
fix(editor): Fix secondary icon for environments on sidebar menu item (#8407) 2024-01-22 12:28:21 +01:00
Iván Ovejero 2ccb754e52
fix(editor): Fix invisible community package update button (#8406) 2024-01-22 10:33:08 +01:00
Giulio Andreini f4f496ae85
docs(editor): All buttons to sentence case (no-changelog) (#8399) 2024-01-22 09:20:02 +01:00
Alex Grozav b6d775768f
feat(editor): Migrate moveNodeWorkflow mixin to useCanvasPanning composable (#8322) 2024-01-19 16:27:44 +02:00
Ricardo Espinoza 75d3ecca1c
fix(editor): Rename Execute previous nodes label to Test previous nodes (no-changelog) (#8392) 2024-01-19 09:00:03 -05:00
Csaba Tuncsik 83228e26fb
fix(editor): Add pinned data for freshly added nodes (#8323) 2024-01-19 14:44:54 +01:00
Alex Grozav d2b3c1048e
feat(editor): Add additional email domains to our disallowed list for self-serve enterprise license (no-changelog) (#8161) 2024-01-19 15:21:49 +02:00
Tomi Turtiainen e43cf2fd71
fix(editor): Enable ctrl/cmd click in workflow editor header (#8387) 2024-01-19 14:28:44 +02:00
Tomi Turtiainen e606e841ee
fix(editor): Use web native <a> element in nav menus (#8385) 2024-01-19 12:52:39 +02:00
Tomi Turtiainen 6fcf5ddcdd
fix(editor): Use cursor pointer on close icon (no-changelog) (#8395) 2024-01-19 12:51:44 +02:00
Elias Meire ade7d30053
fix(editor): Open native context menu when editing Sticky (#8370) 2024-01-18 15:14:41 +01:00
Tomi Turtiainen 1aa35b190a
fix: Set '@typescript-eslint/return-await' rule to 'always' for FE (no-changelog) (#8373) 2024-01-18 11:28:01 +02:00
Deborah 976fe2e6c8
fix: Change the UI text for some filter operations (#8360) 2024-01-18 08:50:54 +00:00
Tomi Turtiainen 99457019f7
feat: Nudge users to become template creators if eligible (#8357) 2024-01-17 19:07:34 +02:00
Iván Ovejero 159b328587
fix(editor): Capture indexed access expressions when building completions (#8331) 2024-01-17 11:02:40 +01:00
Tomi Turtiainen dfa486e4f2
fix: Change setup credentials modal title (no-changelog) (#8338) 2024-01-16 09:31:44 +02:00
Ricardo Espinoza 4277e92ec0
feat(editor): Add new /templates/search endpoint (#8227) 
Updating n8n front-end to use the new search endpoint powered by TypeSense.

Endpoint is deployed on staging API so, in order to test it, use this env var:
```export N8N_TEMPLATES_HOST=https://api-staging.n8n.io/api```

**NOTE**: This PR should not be merged until [backend changes](https://github.com/n8n-io/creators-site/pull/118) are merged and released.

## Related tickets and issues
https://linear.app/n8n/issue/ADO-1555/update-in-app-search-to-work-with-the-new-back-end


## Review / Merge checklist
- [x] PR title and summary are descriptive. **Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise.** ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md))
- [ ] Tests included.
   > A bug is not considered fixed, unless a test is added to prevent it from happening again.
   > A feature is not complete without tests.
 2024-01-15 16:19:24 -05:00
Ricardo Espinoza 6b92d49ea5
fix(editor): Fix issue with synchronization table on LDAP not loading data (#8327) 
## Summary

When we migrated to Vue3, we updated to a new component and did not provide the right props. 

before:

https://www.loom.com/share/ce12b21fdda44176b3e949a00c582252


now:

https://www.loom.com/share/354d1dcb51bd47a9910d5bfe34c7c9b8


## Related tickets and issues
https://linear.app/n8n/issue/PAY-1134/ldap-synchronization-table-in-ui-remains-empty-even-after-successful

## Review / Merge checklist
- [x] PR title and summary are descriptive. **Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise.** ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md))
 2024-01-15 09:03:10 -05:00
Tomi Turtiainen 135553bd6b
feat: Redirect users without feature flag from template cred setup (no-changelog) (#8302) 2024-01-12 12:10:39 +02:00
Alex Grozav 1824ff6a13
fix(editor): Add back missing computed prop (no-changelog) (#8306) 2024-01-11 16:56:42 +02:00
Alex Grozav 2b98835bf4
fix(editor): Remove pinData mixin (no-changelog) (#8303) 2024-01-11 15:04:52 +02:00
Csaba Tuncsik 3b8ccb9fb9
fix(editor): Properly set colors for connections and labels on nodes with pinned data (#8209) 
Co-authored-by: Alex Grozav <alex@grozav.com>
 2024-01-11 14:03:23 +01:00
Elias Meire dcc76f3480
fix(editor): Add read only mode to filter component (#8285) 2024-01-11 10:28:15 +01:00
Tomi Turtiainen d877d3ce92
fix: Adjust cred setup telemetry (no-changelog) (#8294) 2024-01-10 19:41:25 +02:00
Alex Grozav d32e6a60da
feat(editor): Migrate deviceSupportHelpers mixin to useDeviceSupport composable (no-changelog) (#8289) 2024-01-10 16:42:01 +02:00
Tomi Turtiainen 23abd8fb49
fix: Small ui fixes to workflow cred setup modal (no-changelog) (#8280) 2024-01-09 18:32:42 +02:00
Iván Ovejero 0dabe5c74e
fix: Fix user reinvites on FE and BE (#8261) 2024-01-09 13:52:34 +01:00
Alex Grozav af49e95cc7
feat: Add Chat Trigger node (#7409) 
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
Co-authored-by: Jesper Bylund <mail@jesperbylund.com>
Co-authored-by: OlegIvaniv <me@olegivaniv.com>
Co-authored-by: Deborah <deborah@starfallprojects.co.uk>
Co-authored-by: Jan Oberhauser <janober@users.noreply.github.com>
Co-authored-by: Jon <jonathan.bennetts@gmail.com>
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
Co-authored-by: Michael Kret <88898367+michael-radency@users.noreply.github.com>
Co-authored-by: Giulio Andreini <andreini@netseven.it>
Co-authored-by: Mason Geloso <Mason.geloso@gmail.com>
Co-authored-by: Mason Geloso <hone@Masons-Mac-mini.local>
Co-authored-by: Mutasem Aldmour <mutasem@n8n.io>
 2024-01-09 13:11:39 +02:00
Jesper Bylund 9d40ae8b74
fix(editor): Tweaking button sizes in execution preview (#8206) 2024-01-09 10:20:22 +00:00
Tomi Turtiainen 38d91c43e3
fix: Adjust set up template button styles (no-changelog) (#8259) 2024-01-08 16:34:28 +02:00
Tomi Turtiainen b6c42cc084
fix(editor): Unify canvas button positioning (#8258) 2024-01-08 14:44:56 +02:00
Tomi Turtiainen 04836e5c56
feat: Rename template cred setup feature flag (no-changelog) (#8257) 2024-01-08 14:33:21 +02:00
Alex Grozav 8c8caac4e8
feat(editor): Migrate debounce mixin to useDebounce composable (no-changelog) (#8244) 2024-01-08 14:00:49 +02:00
Tomi Turtiainen 8affdf680d
fix: Hide cred setup button from canvas (no-changelog) (#8255) 2024-01-08 13:59:04 +02:00
Tomi Turtiainen 7899f7aca5
fix: Adjust telemetry from canvas (no-changelog) (#8252) 2024-01-08 13:56:16 +02:00
Tomi Turtiainen 008fd5a917
test: Add e2e tests for cred setup on workflow editor (no-changelog) (#8245) 
## Summary

Follow-up to https://github.com/n8n-io/n8n/pull/8240

Adds e2e tests for the template credential setup in workflow editor


## Related tickets and issues

https://linear.app/n8n/issue/ADO-1463/feature-enable-users-to-close-and-re-open-the-setup
 2024-01-08 11:35:18 +02:00
Tomi Turtiainen 3cf6704dbb
feat: Enable cred setup for workflows created from templates (no-changelog) (#8240) 
## Summary

Enable users to open credential setup for workflows that have been
created from templates if they skip it.

Next steps (will be their own PRs):
- Add telemetry events
- Add e2e test
- Hide the button when user sets up all the credentials
- Change the feature flag to a new one

## Related tickets and issues

https://linear.app/n8n/issue/ADO-1637/feature-support-template-credential-setup-for-http-request-nodes-that
 2024-01-05 18:07:57 +02:00
Ricardo Espinoza df5d07bcb8
feat(editor): Update copy: Execute --> Test (#8137) 
## Summary

Title self explanatory


## Related tickets and issues
https://linear.app/n8n/issue/ADO-129/update-copy-execute-test

## Review / Merge checklist
- [x] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md))
 2024-01-05 10:23:51 -05:00
Ricardo Espinoza 2d6e406e21
fix(editor): Vertically center workflow preview loading state (#8231) 
## Summary

Title self explanatory

before:

<img width="1198" alt="image"
src="https://github.com/n8n-io/n8n/assets/16496553/26c29cad-b376-40fd-9881-343f5e722d58">

now:

<img width="1211" alt="image"
src="https://github.com/n8n-io/n8n/assets/16496553/9f2d4020-6bf8-481a-b69f-eddb57cfaaae">



## Related tickets and issues
[ado-1645-fix-center-loading-preview-loading-state

](https://linear.app/n8n/issue/ADO-1645/fix-center-loading-preview-loading-state)

## Review / Merge checklist
- [ x] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md))
 2024-01-05 09:04:39 -05:00
oleg 184ed8e17d
refactor: Migrate genericHelpers mixin to composable (#8220) 
## Summary
- Moved out canvas loading handling to canvas store
- Tag editable routes via meta to remove router dependency from generic
helpers
- Replace all occurrences of `genericHelpers` mixin with composable and
audit usage
- Moved out `isRedirectSafe` and `getRedirectQueryParameter` out of
genericHelpers to remove dependency on router

Removing the router dependency is important, because `useRouter` and
`useRoute` compostables are only available if called from component
instance. So if composable is nested within another composable, we
wouldn't be able to use these. In this case we'd always need to inject
the router and pass it through several composables. That's why I moved
the `readonly` logic to router meta and `isRedirectSafe` and
`getRedirectQueryParameter` out as they were only used in a single
component.

---------

Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
 2024-01-05 12:23:28 +01:00
Tomi Turtiainen 6e78d2346e
fix: Adjust 'use template' feature telemetry (no-changelog) (#8232) 
- Add extra params to 'User closed cred setup' event
- Fire 'User closed cred setup' only when template has creds
- Skip cred setup page if template has no creds required
- Fire 'User inserted workflow template' also in cred setup
 2024-01-05 11:52:10 +02:00
Tomi Turtiainen 8a78ae1739
fix: Add template id to workflows created from templates (no-changelog) (#8226) 
In #8088 template ID was added to workflow metadata, but it was missing
from workflows that were created using the template credential setup.
This fixes that.
 2024-01-05 10:36:59 +02:00
Elias Meire 071e6d6b6e
feat(editor): Add fullscreen view to code editor (#8084) 
## Summary

<img width="1240" alt="image"
src="https://github.com/n8n-io/n8n/assets/8850410/2819f4ce-c343-431a-8a88-a1bc9c4b572a">
<img width="2649" alt="image"
src="https://github.com/n8n-io/n8n/assets/8850410/36862aaf-cc4c-4668-bdc8-cf5a6f00babe">

1. Add code node and open it
3. Click the fullscreen button in the bottom right
4. A fullscreen dialog should appear and allow editing the code
5. Changes made in the fullscreen dialog should be applied to the
original code editor when closed

It should work the same way for HTML/SQL/JSON editors

⚠️ Modal layout was updated so that modals/dialogs are centered, try to
test some modals

## Related tickets and issues
https://linear.app/n8n/issue/NODE-1009/add-fullscreen-view-to-code-node



## Review / Merge checklist
- [ ] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
   > A feature is not complete without tests.

---------

Co-authored-by: Giulio Andreini <andreini@netseven.it>
 2024-01-04 17:23:24 +01:00
Ricardo Espinoza 8f22a265d6
fix(editor): Only load suggested templates for owners (#8228) 
## Summary
Title is self explanatory
 2024-01-04 10:19:25 -05:00
Alex Grozav b50d8058cf
feat(editor): Migrate pinData mixin to usePinnedData composable (no-changelog) (#8207) 
## Summary
Required as part of NodeView refactoring:
- Migrates `pinData` mixin to `usePinnedData` composable.
- Adds `useActiveNode` and `useNodeType` composables 

## Related tickets and issues
https://linear.app/n8n/issue/N8N-6355/pindata

## Review / Merge checklist
- [x] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md))
- [x] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up
ticket created.
- [x] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
   > A feature is not complete without tests.
 2024-01-04 11:22:56 +02:00
Michael Kret f4092a9e49
feat(Switch Node): Overhaul (#7855) 
Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/switch-node-to-more-than-one-path/32791/2

https://community.n8n.io/t/switch-node-routing-same-value-multiple-output/29424

---------

Co-authored-by: Elias Meire <elias@meire.dev>
Co-authored-by: Giulio Andreini <andreini@netseven.it>
 2024-01-04 11:03:03 +02:00
Tomi Turtiainen cd3f5b5b1f
fix: Fix template credential setup for nodes that dont have credentials (#8208) 
Fix template credential setup for templates whose workflow includes
nodes that require credentials but the workflow definition does not have
them defined. Like for example
https://n8n.io/workflows/1344-save-email-attachments-to-nextcloud/
 2024-01-04 10:21:36 +02:00
Ricardo Espinoza 4186884740
fix: Stop showing fake door templates when user clicks on "use template" (no-changelog) (#8219) 
## Summary

We stop showing the fake-door templates when the user clicks on "notify
me when it's is available" (this notification is shown when the user
clicks on "use template"). This PR changes this behavior and stop
showing the fakedoor templates when the user clicks on "use template".
Additionally, also increases the "template coming soon" notification
time from 4.5 seconds to 10 seconds.

<img width="395" alt="image"
src="https://github.com/n8n-io/n8n/assets/16496553/2e643b1f-dd52-46f0-951f-29e630241f73">
 2024-01-03 17:04:30 -05:00
Ricardo Espinoza 8a3c87f69c
fix(editor): Items count display in running workflow (#8148) 
## Summary
> Describe what the PR does and how to test. Photos and videos are
recommended.

Every time the `MainHeader` component is created, we register a new
handler for the "push" messages. Unfortunately this becomes an issue if
you go multiple times to a page that renders the `MainHeader`, e.g
`/workflow/:id`, without refreshing the page; because all handlers will
be called, causing behavior duplication.

I added the possibility of passing an ID, and made impossible to have
multiple handlers with the same ID However, it does not seems to be
needed to support an array of handlers in the pushConnection store. If
that is the case:

1. We might want to have only one handler for the push connections at
all times, which would be a much simpler approach.
2. Register the handler on app.mount instead.

The issue seems to have been introduced
[here](https://github.com/n8n-io/n8n/pull/7763/files#diff-f5dae80a64b9951bb6691f1b9d439423cf84fa0cc9601b3f2c00904f3135e8deR48)

Before the change:

https://www.loom.com/share/85cf8ef896254d848a13a6c6438daa47

With the change:

https://www.loom.com/share/f5c4ffac421d46cc8e389364e1c357d3

## Related tickets and issues

https://linear.app/n8n/issue/ADO-1596/bug-items-count-display-in-running-workflow


## Review / Merge checklist
- [x] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
   > A feature is not complete without tests.
 2024-01-03 11:31:33 -05:00
Michael Kret 5e16dd4ab4
feat(core): Improvements/overhaul for nodes working with binary data (#7651) 
Github issue / Community forum post (link here to close automatically):

---------

Co-authored-by: Giulio Andreini <andreini@netseven.it>
Co-authored-by: Marcus <marcus@n8n.io>
 2024-01-03 13:08:16 +02:00
कारतोफ्फेलस्क्रिप्ट™ 5c078f1b3d
fix(editor): Fix UI urls when hosted behind a path prefix (#8198) 
fixes #8061
 2024-01-03 11:37:01 +01:00
कारतोफ्फेलस्क्रिप्ट™ cfe9525dd4
fix(core): Better input validation for the changeRole endpoint (#8189) 
also refactored the code to
1. stop passing around `scope === 'global'`, since this code can be used
only for changing globalRole.
2. leak less details when input validation fails.

## Review / Merge checklist
- [x] PR title and summary are descriptive
- [x] Tests included
 2024-01-03 09:33:35 +01:00
Milorad FIlipović d01e42a2aa
fix(editor): Fix templates view layout (#8196) 
## Summary
Recent changes to the template info carousel component broke the layout
of the templates way so it had excessive width when templates categories
carousel was visible.
This PR reverts disables CSS that held it in place.


## Related tickets and issues
Fixes ADO-1628


## Review / Merge checklist
- [ ] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
   > A feature is not complete without tests.
 2024-01-02 14:13:09 +01:00
Alex Grozav f5a4bfe40c
feat(editor): Migrate copyPaste mixin to composables (no-changelog) (#8179) 2023-12-29 12:13:24 +02:00
कारतोफ्फेलस्क्रिप्ट™ 216ec079c9
feat(editor): Create separate components for JS and JSON editors (no-changelog) (#8156) 
## Summary
This is part-1 of refactoring our code editors to extract different type
of editors into their own components.
In part-2 we'll
1. delete a of unused or duplicate code
2. switch to a `useEditor` composable to bring more UX consistency
across all the code editors.

## Review / Merge checklist
- [x] PR title and summary are descriptive
- [x] Tests included
 2023-12-29 10:49:27 +01:00
कारतोफ्फेलस्क्रिप्ट™ cf7f6688ba
fix(editor): Enable explicit undo keyboard shortcut across all code editors (#8178) 
Fixes [ADO-801](https://linear.app/n8n/issue/ADO-801),
[PAY-632](https://linear.app/n8n/issue/PAY-632), and
[PAY-730](https://linear.app/n8n/issue/PAY-730)
Also fixes #5297

## Review / Merge checklist
- [x] PR title and summary are descriptive
 2023-12-28 14:55:23 +01:00
Alex Grozav 405e26757e
fix(editor): Prevent storing pairedItem data inside of pinData (#8173) 
## Summary
When pinning data after an execution, the pairedItem data gets stored in
the pinData field. This creates problems during executions.

Before:
<img width="1141" alt="image"
src="https://github.com/n8n-io/n8n/assets/6179477/e555d00a-6ff2-4601-8072-3194a0c5e1c2">

After: 
<img width="1140" alt="image"
src="https://github.com/n8n-io/n8n/assets/6179477/d97e9d90-28f5-4dcc-b63e-62497c646994">


## Related tickets and issues

https://linear.app/n8n/issue/PAY-812/wrong-error-shown-when-paireditem-fails-because-of-incorrect-pinned


## Review / Merge checklist
- [x] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md))
- [x] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up
ticket created.
- [x] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
   > A feature is not complete without tests.
 2023-12-28 12:59:01 +02:00
कारतोफ्फेलस्क्रिप्ट™ 68cff4c59e
refactor(editor): Improve linting for component and prop names (no-changelog) (#8169) 2023-12-28 09:49:58 +01:00
Milorad FIlipović 517b050d0a
feat(editor): Add template Id to workflow metadata (#8088) 
## Summary
Adding a link between the workflow and the template it originated from
by saving `templateId` in the workflow metadata

## Related tickets and issues
ADO-1537

## Review / Merge checklist
- [x] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up
ticket created.
- [x] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
   > A feature is not complete without tests.
 2023-12-22 15:07:05 +01:00
Mutasem Aldmour c83d9f45ba
fix(editor): Avoid sanitizing output to search node data (#8126) 
## Summary
In search feature, output sanitization was added to support `<mark` tag
in output panel to highlight searched text. This removes any html like
data in the input/output panel..
This PR removes sanitization while keeping text highlights..


## Related tickets and issues
https://community.n8n.io/t/n8n-output/33997
https://community.n8n.io/t/html-tags-in-editor-rendered/34240
https://github.com/n8n-io/n8n/issues/8081
https://linear.app/n8n/issue/ADO-1594/node-output-view-not-consistent
https://linear.app/n8n/issue/ADO-1597/bug-xml-display-issue


## Review / Merge checklist
- [X] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
   > A feature is not complete without tests.
 2023-12-22 15:03:40 +01:00
Milorad FIlipović ab74bade05
feat(editor): Add node execution status indicator to output panel (#8124) 
## Summary
Adding node execution status indicator to the output panel ([Figma
HiFi](https://www.figma.com/file/iUduV3M4W5wZT7Gw5vgDn1/NDV-output-pane-success-state)).

## Related tickets and issues
Fixes ADO-480

## Review / Merge checklist
- [x] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up
ticket created.
- [x] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
   > A feature is not complete without tests.
 2023-12-22 12:50:36 +01:00
कारतोफ्फेलस्क्रिप्ट™ 021add0f39
refactor(core): Move active workflows endpoints to a decorated controller class (no-changelog) (#8101) 
This is a continuation of migrating all rest endpoints to decorated controller classes
 2023-12-22 11:28:42 +01:00
Milorad FIlipović 39e45d8b92
fix(editor): Prevent canvas undo/redo when NDV is open (#8118) 
## Summary
Preventing canvas undo/redo while NDV or any modal is open. We already
had a NDV open check in place but looks like it was broken by unreactive
ref inside `useHistoryHelper` composable.
This PR fixes this by using store getter directly inside the helper
method and adds modal open check.

## Related tickets and issues
Fixes ADO-657

## Review / Merge checklist
- [ ] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
   > A feature is not complete without tests.
 2023-12-22 08:42:53 +01:00
Milorad FIlipović 711fa2b925
fix(editor): Fix operation change failing in certain conditions (#8114) 
## Summary
This PR handles the case when there are multiple parameters with the
same name but different `options` and `displayOptions`. In this case, if
one of such fields is set, changing the dependent parameter value so the
other should be shown causes an error in case their options are not
compatible (this
[check](7806a65229/packages/workflow/src/NodeHelpers.ts (L786))).

#### Example:
LDAP node has two `options` properties with the same name:
1. `attributes` with predefined options (`add`, `replace`, `delete`).
Shown when **Update** operation is selected
2. `attributes` with a collection of `attribute` objects. Shows for the
**Create** operation

Setting one of these parameter values and switching operation so the
other is shown breaks the app.
This PR checks if there is a value saved for such parameter and removes
it before calling `getNodeParameters` in `valueChanged` handler.

## Related tickets and issues
Fixes ADO-1589

## Review / Merge checklist
- [x] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up
ticket created.
- [x] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
   > A feature is not complete without tests.
 2023-12-22 08:41:20 +01:00
Ricardo Espinoza e9c7fd7397
fix: Show public API upgrade CTA when feature is not enabled (#8109) 
## Summary
> Describe what the PR does and how to test. Photos and videos are
recommended.

Shows the public API upgrade CTA when the feature is not enabled. Now
trialing users in cloud would see the API on the settings menu and can
upgrade from there.

When public API feature disabled: 

<img width="1863" alt="image"
src="https://github.com/n8n-io/n8n/assets/16496553/a9052f6b-151f-4ebb-80df-5ff2fa643e85">

When public API feature enabled with no API key:

<img width="1861" alt="image"
src="https://github.com/n8n-io/n8n/assets/16496553/fdfe7296-425e-4410-a8cb-f25535bc9df4">

When public API feature enabled with API key:

<img width="1423" alt="image"
src="https://github.com/n8n-io/n8n/assets/16496553/a8426cbf-ff73-43c4-8c60-b00274bca46e">



## Related tickets and issues
[> Include links to **Linear ticket** or Github issue or Community forum
post. Important in order to close *automatically* and provide context to
r](https://linear.app/n8n/issue/ADO-1282/feature-api-page-missing-for-trial-users)eviewers.



## Review / Merge checklist
- [x] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md))
- [x] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
   > A feature is not complete without tests.
 2023-12-21 09:06:54 -05:00
Iván Ovejero edfa78414d
feat(editor): Finalize workers view (#8052) 
https://linear.app/n8n/issue/PAY-1065
 2023-12-20 17:49:14 +01:00
Iván Ovejero d917dfe9f8
refactor(editor): Remove tracking for SAML test success (no-changelog) (#8108) 
Follow-up to: https://github.com/n8n-io/n8n/pull/8102

It turns out that SAML test success cannot be tracked on the FE. We
might track on the BE, but after further discussion with Product, we do
not really need to track this property, so this PR simply removes it.
 2023-12-20 15:23:00 +01:00
Elias Meire 8df49e134d
fix(editor): Make keyboard shortcuts more strict; don't accept extra Ctrl/Alt/Shift keys (#8024) 
## Summary
Keyboard shortcuts such as Shift+S get triggered even when other keys
(Ctrl/Alt) are pressed, creating conflicts with browser or OS shortcuts.

This PR makes keyboard shortcuts more strict: the exact combination
needs to be pressed, no extra keys allowed.
--> Ctrl+Shift+S will no longer trigger the Shift+S shortcut to add a
sticky note

## Related tickets and issues
https://n8nio.slack.com/archives/C035KBDA917/p1702545933647959
 2023-12-20 12:06:49 +01:00
Alex Grozav fcff34c401
fix(editor): Move versions check to init function and refactor store (no-changelog) (#8067) 2023-12-20 12:49:40 +02:00
Iván Ovejero faadfd6d4a
refactor(editor): Add telemetry for SSO/SAML (no-changelog) (#8102) 
https://linear.app/n8n/issue/PAY-1142
 2023-12-20 11:41:39 +01:00
Iván Ovejero 1d1cb0d3c5
fix(editor): Ensure execution data overrides pinned data when copying in executions view (#8009) 
https://linear.app/n8n/issue/PAY-1063


https://community.n8n.io/t/execution-history-node-output-copy-to-clipboard-copies-pinned-data-instead-of-executed-node-output/33248?u=mutedjam
 2023-12-20 10:42:26 +01:00
Mutasem Aldmour 4b86926752
fix(editor): Fix copy/paste issue when switch node is in workflow (#8103) 
## Summary
Fix bug where copy/pasting a node breaks the view. Issue seems to be
that copied workflow does not have Switch node when workflow is
rerendering..

<img width="1942" alt="Screenshot 2023-12-19 at 18 16 23"
src="https://github.com/n8n-io/n8n/assets/4711238/ad53b8ae-3693-4733-8f6b-7bc9e7b9d216">




## Related tickets and issues
[Linear ticket
ADO-1504](https://linear.app/n8n/issue/ADO-1504/unwanted-nodes-connections-after-copypaste-of-n8n-form-trigger)


## Review / Merge checklist
- [X] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up
ticket created.
- [x] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
   > A feature is not complete without tests.
 2023-12-20 10:13:59 +01:00
Iván Ovejero 38d1336fa7
refactor: Add telemetry for RBAC (no-changelog) (#8056) 
https://linear.app/n8n/issue/PAY-1142
 2023-12-19 17:02:52 +01:00
कारतोफ्फेलस्क्रिप्ट™ 64eb9bbc36
fix: Upgrade axios to address CVE-2023-45857 (#7713) 
[GH Advisory](https://github.com/advisories/GHSA-wf5p-g6vw-rhxx)
 2023-12-19 16:17:01 +01:00
कारतोफ्फेलस्क्रिप्ट™ 9d22c7a278
feat(editor): Gracefully ignore invalid payloads in postMessage handler (#8096) 
It's possible for browser extensions to send `message` events to an n8n window.
This change improves the already existing check to ignore invalid messages.

Fixes https://community.n8n.io/t/errors-in-the-browser-console-on-n8n-1-version/33910
 2023-12-19 15:20:29 +01:00
Milorad FIlipović 36a923cf7b
feat(editor): Add lead enrichment suggestions to workflow list (#8042) 
## Summary
We want to show lead enrichment template suggestions to cloud users that
agreed to this. This PR introduces the front-end part of this feature
- Handoff document
- Figma Hi-fi
- [How to
test](https://linear.app/n8n/issue/ADO-1549/[n8n-fe]-update-workflows-list-page-to-show-fake-door-templates#comment-b6644c99)

Tests are being worked on in a separate PR

## Related tickets and issues
Fixes ADO-1546
Fixes ADO-1549
Fixes ADO-1604

## Review / Merge checklist
- [ ] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
   > A feature is not complete without tests.

---------

Co-authored-by: ricardo <ricardoespinoza105@gmail.com>
 2023-12-19 09:10:03 -05:00
Alex Grozav 5ed4d19059
feat: Add opt-in enterprise license trial checkbox (no-changelog) (#7826) 
<img width="518" alt="image"
src="https://github.com/n8n-io/n8n/assets/6179477/6422a057-de94-49dc-90fd-7381b5642902">

---------

Co-authored-by: Omar Ajoue <krynble@gmail.com>
 2023-12-19 14:58:30 +02:00
Iván Ovejero a7ffed245a
refactor(editor): Add telemetry for log streaming (no-changelog) (#8075) 
https://linear.app/n8n/issue/PAY-1065
 2023-12-19 13:18:13 +01:00
Iván Ovejero d44602913f
refactor(editor): Add telemetry for debug in editor (no-changelog) (#8073) 
https://linear.app/n8n/issue/PAY-1142
 2023-12-19 12:23:30 +01:00
Mutasem Aldmour 63a6e7e034
fix(editor): Update image sizes in template description not to be full width always (#8037) 
## Summary
Update image sizes in template description not to be full width always.


## Related tickets and issues

https://linear.app/n8n/issue/ADO-1506/bug-fix-images-in-template-descriptions


## Review / Merge checklist
- [X] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up
ticket created.
- [x] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
   > A feature is not complete without tests.
 2023-12-18 17:40:00 +01:00
Iván Ovejero 62ce962ec9
refactor(editor): Add telemetry for workflow history (no-changelog) (#8072) 
https://linear.app/n8n/issue/PAY-1142
 2023-12-18 16:10:45 +01:00
Iván Ovejero 8fc9888541
refactor(editor): Add telemetry for workers view (#8055) 
https://linear.app/n8n/issue/PAY-1142
 2023-12-18 12:21:13 +01:00
Csaba Tuncsik aad57e2da1
fix(editor): Update wording when an instance owner or admin is viewing a credential they do not own (no-changelog) (#8054) 
## Summary
Now that instance admins and owners can share on credentials, we need to
tweak the wording so it's clear what they can do in the UI and the
access they have.

### Acceptance Criteria

When an instance owner/admin views a credential they do not own, we
should show the following text `You can view this credential because you
have permission to read and share (and rename or delete it too).`

When an instance owner/admin views a credential they do not own and has
NOT been shared with them, we should show the following text `You can
view this credential because you have permission to read and share (and
rename or delete it too). You can share it with yourself or other users
to use it in a workflow.`
 2023-12-18 08:31:00 +00:00
Csaba Tuncsik 2689c37e87
fix(editor): Cleanup Executions page component (#8053) 
## Summary
Remove duplicated `created` VUE component lifecycle method
 2023-12-15 18:18:25 +01:00
Csaba Tuncsik 329e5bf9ee
fix(editor): Add back credential use permission (#8023) 
## Summary
A shared credential is not selectable in NDV

Aim

If a credential is shared with a user they should be able to select it
in node details view
 2023-12-14 13:36:36 +01:00
Csaba Tuncsik fcb8b91f37
fix(editor): Disable auto scroll and list size check when clicking on executions (#7983) 
## Summary
Auto scrolling to the active execution is unnecessary as well as
checking if more items can be loaded.

#### How to test the change:
1. Open a workflow with a long list of executions (preferably with more
executions that fits in the list when first rendered and need to use
infinite scroll to load more items)
2. Go to executions tabs
3. Scroll to the bottom
4. Click on an item that is visible only if the list is scrolled down.

The list should not be scrolled to the active item automatically
 2023-12-14 12:37:03 +01:00
Alex Grozav 3436f15e82
fix(editor): Fix dialogVisibleChanged hooks event when meta.value is undefined (no-changelog) (#7986) 
## Summary
Provide details about your pull request and what it adds, fixes, or
changes. Photos and videos are recommended.

In specific scenarios `meta.value` can come as `undefined`, causing the
hook to fail.

#### How to test the change:
1. Close Expression editor modal dialog with empty value


## Issues fixed
Include links to Github issue or Community forum post or **Linear
ticket**:
> Important in order to close automatically and provide context to
reviewers


https://linear.app/n8n/issue/N8N-7084/typeerror-evalueslice-is-not-a-function-in-evalueslice1-evalueslice-is
https://n8nio.sentry.io/issues/4715787194/


## Review / Merge checklist
- [x] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again. A feature is not complete without tests.
  >
> *(internal)* You can use Slack commands to trigger [e2e
tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227)
or [deploy test
instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce)
or [deploy early access version on
Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).
 2023-12-14 13:13:02 +02:00
oleg b780436a6b
perf(editor): Improve canvas rendering performance (#8022) 
## Summary
- Refactor usage of `setSuspendDrawing`, removing it from loops and only
calling it after batch operations are done
- Batch adding of nodes to improve copy/paste and workflow load
performance
- Cache i18n calls
- Debounce connections dragging handler if there are more than 20 nodes


## Related tickets and issues
> Include links to **Linear ticket** or Github issue or Community forum
post. Important in order to close *automatically* and provide context to
reviewers.
- https://community.n8n.io/t/slow-ui-in-big-scenarios/33830/8

---------

Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
 2023-12-14 12:01:00 +01:00
Csaba Tuncsik e3c363d72c
fix(editor): Turn off executions list auto-refresh after leaving the page (#8005) 
## Summary
Fixes the bug when users leave the executions page but there is still an
ongoing request for executions.

---------

Co-authored-by: Alex Grozav <alex@grozav.com>
 2023-12-14 11:50:00 +01:00
Csaba Tuncsik b29b4d442b
fix(editor): Show credential share info only to appropriate users (#8020) 
## Summary
The credential owner should not see the sharing info box


![image](https://github.com/n8n-io/n8n/assets/5410822/d85b47f8-f4cf-4009-beaf-03bc62008feb)
 2023-12-14 11:48:51 +01:00
Michael Kret 953a58f18b
feat(n8n Form Trigger Node): Improvements (#7571) 
Github issue / Community forum post (link here to close automatically):

---------

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
Co-authored-by: Giulio Andreini <andreini@netseven.it>
 2023-12-13 17:00:51 +02:00
Jan Oberhauser 26f0d57f5f
fix(editor): Fix bug with node names with certain characters (#8013) 
## Summary
Fixes the issue that dots and other special characters can not be used
in node-names


## Related tickets and issues

https://linear.app/n8n/issue/ADO-1244/nodes-wont-output-data-if-the-name-contains-some-characters

https://community.n8n.io/t/bug-report-name-of-node-affects-output-data/31674
https://community.n8n.io/t/stripe-output-data/32418/1
https://community.n8n.io/t/monday-com-returning-items-but-no-data/31834
https://community.n8n.io/t/no-data-while-there-is-actually-data/32563
https://community.n8n.io/t/bug-report-periods-in-node-names/34119
https://github.com/n8n-io/n8n/issues/7896


## Review / Merge checklist
- [ ] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
   > A feature is not complete without tests.

---------

Co-authored-by: Alex Grozav <alex@grozav.com>
 2023-12-13 14:57:01 +00:00
Elias Meire 8a5343401d
feat(editor): Filter component + implement in If node (#7490) 
New Filter component + implementation in If node (v2)

<img width="3283" alt="image"
src="https://github.com/n8n-io/n8n/assets/8850410/35c379ef-4b62-4d06-82e7-673d4edcd652">

---------

Co-authored-by: Giulio Andreini <andreini@netseven.it>
Co-authored-by: Michael Kret <michael.k@radency.com>
 2023-12-13 14:45:22 +01:00
Jan Oberhauser b00b9057a4
fix(editor): Fix Webhook URL expansion icon (#8011) 
Changes the rotation of the icon. 

New collapsed:
![Screenshot from 2023-12-13
12-06-12](https://github.com/n8n-io/n8n/assets/6249596/2991a660-d6b4-4272-88cf-6a2356d02a7e)

New expanded:
![Screenshot from 2023-12-13
12-06-22](https://github.com/n8n-io/n8n/assets/6249596/0766db9e-b868-49a8-9009-dfff4ab0b13b)
 2023-12-13 12:40:44 +01:00
Giulio Andreini 8f364087c9
docs(editor): Change to Summarize icon and Advanced section description (no-changelog) (#8008) 
## Summary
- Change the description of the Advanced" section
- Replace the icon of Summarize



## Related tickets and issues
https://linear.app/n8n/issue/NODE-984/data-transformations-menu-minor-fixes



## Review / Merge checklist
- [ ] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
   > A feature is not complete without tests.
 2023-12-13 12:18:29 +01:00
Tomi Turtiainen 08ee307209
feat(editor): Show template credential setup based on feature flag (#7989) 
Replace the local storage based feature flag with posthog feature flag.

Also:
- Fix bunch of eslint warnings in posthog store
 2023-12-11 20:21:10 +02:00
Milorad FIlipović 240d259260
refactor(editor): Rename CollectionCard and CollectionCardCarousel (#7994) 
## Summary
As part of the plan to reuse current `CollectionCarousel` component,
this PR makes it, and the cards it uses, more generic by renaming them
and adds a new property to card component which can be used to hide the
item count.

#### How to test the change:
Until the component that will use this is implmeneted, this can be
tested manually:
1. Run n8n
2. Set `showItemCount` property for workflow collection cards to `false`
3. Check if workflow count is showing (it shouldn't) and if everything
rendering correctly

## Issues fixed
Fixes ADO-1567

## Review / Merge checklist
- [ ] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again. A feature is not complete without tests.
  >
> *(internal)* You can use Slack commands to trigger [e2e
tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227)
or [deploy test
instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce)
or [deploy early access version on
Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).
 2023-12-11 17:37:26 +01:00
Milorad FIlipović 393afef174
feat(editor): Add option to disable NDV in workflow previews (#7990) 
## Summary
This PR adds a new property to the `WorkflowPreview` component that
controls if the Node Details View can be opened in each workflow preview
or not.
This property is passed on to underlying `iframe` via the `postMessage`
and is used to disable pointer events for nodes and stickies in that
preview.

#### How to test the change:
Until the component that uses this flag is implemented this can be
tested manually. In this example, we'll use `WorkflowPreview` as part of
the `TemplatesWorkflowView` component
1. Pass `:canOpenNDV="false"` to this component
2. Run n8n
3. Open any template preview and check if nodes and stickies are
interactive
4. Open any workflow execution preview -> Nodes and Stickies should be
interactive

## Issues fixed
Fixes ADO-1548

## Review / Merge checklist
- [ ] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again. A feature is not complete without tests.
  >
> *(internal)* You can use Slack commands to trigger [e2e
tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227)
or [deploy test
instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce)
or [deploy early access version on
Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).
 2023-12-11 15:30:01 +01:00
Jon 97e39c39d9
docs: Replace references to set node (no-changelog) (#7973) 
## Summary
This replaces the set node references with edit fields.

Ref: https://n8nio.slack.com/archives/C036PA5D42D/p1702040900165709
 2023-12-11 10:10:03 +00:00
Elias Meire 939e471ed1
fix(editor): Fix collection select label (no-changelog) (#7978) 
## Summary

before & after


![image](https://github.com/n8n-io/n8n/assets/8850410/9eef4b99-4cab-41de-ad82-7dadb653f307)

<img width="575" alt="image"
src="https://github.com/n8n-io/n8n/assets/8850410/e7d5ecd5-427e-4664-897f-5a42e68e3661">

#### How to test the change:
1. Add Pipedrive > Create Deal
2. Click on "Add Field" under "Additional Fields"
3. Options should be properly displayed (Title case)


## Issues fixed
https://linear.app/n8n/issue/NODE-977

## Review / Merge checklist
- [ ] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again. A feature is not complete without tests.
  >
> *(internal)* You can use Slack commands to trigger [e2e
tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227)
or [deploy test
instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce)
or [deploy early access version on
Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).
 2023-12-11 09:50:21 +01:00
Iván Ovejero 148bc1d303
fix(editor): Add missing string for worker in log streaming (#7971) 
## Summary
Add missing string for worker in log streaming

Before: https://share.cleanshot.com/bN9ydg7N
After: https://share.cleanshot.com/sFLnFMJK

...

#### How to test the change:
1. ...


## Issues fixed
Include links to Github issue or Community forum post or **Linear
ticket**:
> Important in order to close automatically and provide context to
reviewers

...


## Review / Merge checklist
- [ ] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again. A feature is not complete without tests.
  >
> *(internal)* You can use Slack commands to trigger [e2e
tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227)
or [deploy test
instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce)
or [deploy early access version on
Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).
 2023-12-11 09:44:58 +01:00
oleg 35fbc37c8e
refactor(editor): Refactor nodeHelpers mixin to composable (#7810) 
- Convert `nodeHelpers` mixin into composable and fix types
- Replace usage of the mixin with the new composable
- Add missing store imports in components that were dependent on opaque
imports from nodeHelpers mixin
- Refactor the `CollectionParameter` component to the modern script
setup syntax
Github issue / Community forum post (link here to close automatically):

---------

Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
 2023-12-08 16:59:03 +01:00
Csaba Tuncsik e8a493f718
fix(editor): Prevent opening NDV search if / is typed in a contenteditable element (#7968) 
## Summary
Prevent opening NDV search if `/` is typed in a contenteditable element
...

#### How to test the change:
1. Create a workflow with a Code node that has some input and output
2. Run the workflow and then open the Code node
3. Type `/` anywhere in the Code node

#### Expected behavior:
NDV search should not be opened and focused
 2023-12-08 16:16:05 +01:00
Csaba Tuncsik 5b2defc867
fix(editor): Return early in ws message handler if no 'command' keyword is found (#7946) 
## Summary
Avoid processing websocket messages not n8n sent (filter on 'command'
keyword)
 2023-12-08 13:42:50 +01:00
oleg dcf12867b3
feat: AI nodes usability fixes + Summarization Chain V2 (#7949) 
Fixes:
- Refactor connection snapping when dragging and enable it also for
non-main connection types
- Fix propagation of errors from sub-nodes
- Fix chat scrolling when sending/receiving messages
- Prevent empty chat messages
- Fix sub-node selected styles
- Fix output names text overflow

Usability improvements:
- Auto-add manual chat trigger for agents & chain nodes
- Various labels and description updates
- Make the output parser input optional for Basic LLM Chain
- Summarization Chain V2 with a simplified document loader & text
chunking mode

#### How to test the change:
Example workflow showcasing different operation mode of the new
summarization chain:

[Summarization_V2.json](https://github.com/n8n-io/n8n/files/13599901/Summarization_V2.json)


## Issues fixed
Include links to Github issue or Community forum post or **Linear
ticket**:
> Important in order to close automatically and provide context to
reviewers
-
https://www.notion.so/n8n/David-Langchain-Posthog-notes-7a9294938420403095f4508f1a21d31d
- https://linear.app/n8n/issue/N8N-7070/ux-fixes-batch
- https://linear.app/n8n/issue/N8N-7071/ai-sub-node-bugs


## Review / Merge checklist
- [x] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md))
- [x] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again. A feature is not complete without tests.
  >
> *(internal)* You can use Slack commands to trigger [e2e
tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227)
or [deploy test
instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce)
or [deploy early access version on
Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).

---------

Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Elias Meire <elias@meire.dev>
 2023-12-08 13:42:32 +01:00
Csaba Tuncsik dbd62a4992
feat: Introduce advanced permissions (#7844) 
This PR introduces the possibility of inviting new users with an `admin`
role and changing the role of already invited users.
Also using scoped permission checks where applicable instead of using
user role checks.

---------

Co-authored-by: Val <68596159+valya@users.noreply.github.com>
Co-authored-by: Alex Grozav <alex@grozav.com>
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
 2023-12-08 12:52:25 +01:00
Elias Meire 675ec21d33
feat: Data transformation nodes and actions in Nodes Panel (#7760) 
- Split Items List node into separate nodes per action
- Review node descriptions
- New icons
- New sections in subcategories

---------

Co-authored-by: Giulio Andreini <andreini@netseven.it>
Co-authored-by: Deborah <deborah@starfallprojects.co.uk>
Co-authored-by: Michael Kret <michael.k@radency.com>
 2023-12-08 11:40:05 +01:00
Tomi Turtiainen a3ca7c7acd
fix: Disable continue button unless at least 1 cred has been filled (no-changelog) (#7959) 
Disable the continue button in template credential setup unless at least
one credential has been (pre-)filled
 2023-12-07 19:35:34 +02:00
Tomi Turtiainen dc1f14b0be
fix(editor): Send correct telemetry events in credential setup (no-changelog) (#7926) 
Send the `User opened cred setup` and `User closed cred setup` events
specified
[here](https://www.notion.so/n8n/Handoff-a1150c38f6e042db91fdf61c56900967?pvs=4)
 2023-12-07 17:25:33 +02:00
Mutasem Aldmour 04cabafef7
feat(editor): Add AppCues tracking for onboarding event (#7945) 
## Summary
We want to trigger a flow, every time the template onboarding event is
triggered. AppCues no longer supports flows triggering through Segment,
except directly.

#### How to test the change:
1. Open on Cloud, where AppCues scripts are available
2. import workflow through /workflows/onboarding/1946
3. Ensure event is sent.. if flow is enabled, flow should show

<img width="1702" alt="Screenshot 2023-12-07 at 14 39 51"
src="https://github.com/n8n-io/n8n/assets/4711238/e58daae8-4364-41a4-bfda-25edeea6cc69">



## Issues fixed
Include links to Github issue or Community forum post or **Linear
ticket**:
> Important in order to close automatically and provide context to
reviewers

https://linear.app/n8n/issue/ADO-1455/bug-appcues-trigger

## Review / Merge checklist
- [X] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up
ticket created.
- [x] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again. A feature is not complete without tests.
  >
> *(internal)* You can use Slack commands to trigger [e2e
tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227)
or [deploy test
instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce)
or [deploy early access version on
Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).
 2023-12-07 16:22:41 +01:00
Tomi Turtiainen b63f9cc533
feat(editor): Add user opened cred modal telemetry event (no-changelog) (#7927) 
## Summary

Add `User opened Credential modal` telemetry event to the template
credential setup page, as specified
[here](https://www.notion.so/n8n/Handoff-a1150c38f6e042db91fdf61c56900967?pvs=4)
 2023-12-07 16:05:43 +02:00
Iván Ovejero bc1c72f992
fix(editor): Allow SSH protocol in git repository URL for environments (#7944) 
## Summary
Allow SSH protocol in git repository URL for environments

...

#### How to test the change:
1. ...


## Issues fixed
Include links to Github issue or Community forum post or **Linear
ticket**:
> Important in order to close automatically and provide context to
reviewers

https://linear.app/n8n/issue/PAY-1097


## Review / Merge checklist
- [x] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up
ticket created.
- [x] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again. A feature is not complete without tests.
  >
> *(internal)* You can use Slack commands to trigger [e2e
tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227)
or [deploy test
instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce)
or [deploy early access version on
Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).
 2023-12-07 09:19:32 +01:00
Alex Grozav 92fa6233d3
fix: Run dev command only for core packages (no-changelog) (#7928) 
## Summary
Provide details about your pull request and what it adds, fixes, or
changes. Photos and videos are recommended.

- Filters out `@n8n/chat` and `n8n-design-system` from `pnpm run dev`
- Fixes dev/build error appearing due to code string `import ... from
'@n8n/chat'`

#### How to test the change:
1. `pnpm run dev` should work as expected
2. The command should not run for the two packages above
3. The error regarding `@n8n/chat` should no longer appear


## Issues fixed
Include links to Github issue or Community forum post or **Linear
ticket**:
> Important in order to close automatically and provide context to
reviewers


https://linear.app/n8n/issue/PAY-1089/run-dev-command-only-for-core-packages


## Review / Merge checklist
- [x] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md))
- [x] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up
ticket created.
- [x] Tests included. N/A
> A bug is not considered fixed, unless a test is added to prevent it
from happening again. A feature is not complete without tests.
  >
> *(internal)* You can use Slack commands to trigger [e2e
tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227)
or [deploy test
instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce)
or [deploy early access version on
Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).
 2023-12-06 17:28:33 +02:00
Alex Grozav 885dba6f12
refactor: Migrate externalHooks mixin to composables (no-changelog) (#7930) 
## Summary
Provide details about your pull request and what it adds, fixes, or
changes. Photos and videos are recommended.

As part of NodeView refactor, this PR migrates all externalHooks calls
to `useExternalHooks` composable.

#### How to test the change:
1. Run using env `export N8N_DEPLOYMENT_TYPE=cloud` 
2. Hooks should still run as expected


## Issues fixed
Include links to Github issue or Community forum post or **Linear
ticket**:
> Important in order to close automatically and provide context to
reviewers

https://linear.app/n8n/issue/N8N-6349/externalhooks


## Review / Merge checklist
- [x] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md))
- [x] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up
ticket created.
- [x] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again. A feature is not complete without tests.
  >
> *(internal)* You can use Slack commands to trigger [e2e
tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227)
or [deploy test
instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce)
or [deploy early access version on
Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).
 2023-12-06 17:28:09 +02:00
Alex Grozav 0a745d16e4
fix(editor): Add missing workflow id from route (no-changelog) (#7918) 
## Summary
Fixes missing workflow id from route.

#### How to test the change:
1. Go to executions page for a workflow without executions
2. Wait for autoRefresh to start
3. Error appears in console due to missing `name` parameter


## Issues fixed
Include links to Github issue or Community forum post or **Linear
ticket**:
> Important in order to close automatically and provide context to
reviewers

https://linear.app/n8n/issue/N8N-7075/error-missing-required-param-name


## Review / Merge checklist
- [x] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md))
- [x] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again. A feature is not complete without tests.
  >
> *(internal)* You can use Slack commands to trigger [e2e
tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227)
or [deploy test
instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce)
or [deploy early access version on
Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).
 2023-12-05 10:43:40 +02:00
Alex Grozav 6b678b5b9e
fix(editor): Use hasOwnProperty to check for canvas key on connector (no-changelog) (#7921) 
## Summary
Provide details about your pull request and what it adds, fixes, or
changes. Photos and videos are recommended.

Fixes `key in object` check by replacing with `hasOwnProperty`.

## Issues fixed
Include links to Github issue or Community forum post or **Linear
ticket**:
> Important in order to close automatically and provide context to
reviewers


https://linear.app/n8n/issue/N8N-7077/typeerror-cannot-use-in-operator-to-search-for-canvas-in-null

## Review / Merge checklist
- [x] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md))
- [x] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again. A feature is not complete without tests.
  >
> *(internal)* You can use Slack commands to trigger [e2e
tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227)
or [deploy test
instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce)
or [deploy early access version on
Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).
 2023-12-05 10:34:25 +02:00
Alex Grozav 7c57332d8f
fix(editor): Add missing activeNode check for redrawing (no-changelog) (#7919) 
## Summary
Wasn't able to reproduce, but `activeNode` sporadically returns null in
some scenarios. Added appropriate check.

## Issues fixed
Include links to Github issue or Community forum post or **Linear
ticket**:
> Important in order to close automatically and provide context to
reviewers


https://linear.app/n8n/issue/N8N-7076/typeerror-cannot-read-properties-of-null-reading-name


## Review / Merge checklist
- [x] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md))
- [x] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again. A feature is not complete without tests.
  >
> *(internal)* You can use Slack commands to trigger [e2e
tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227)
or [deploy test
instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce)
or [deploy early access version on
Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).
 2023-12-05 10:34:15 +02:00
Tomi Turtiainen 6448d4c8a5
fix(editor): Tune credential template layout (no-changelog) (#7903) 
Add max width to the content and scale it based on that
 2023-12-04 15:27:38 +02:00
Milorad FIlipović 4bd7ae29f7
perf(editor): Improve performance when opening large workflows with node issues (#7901) 
This PR should improve performance when opening large workflows that
contain node issues (Fixes ADO-1521)

**Background**
Main reason for this poor performance is that our `getCurrentWorkflow()`
store getter is unnecessarily heavy but on top of that we are calling it
more than we need. This addresses the second part of the issue by
changing the following:
- Pausing node issue processing while workflows are loading
- Only getting current workflow once (instead for every node) when
calling `refreshNodeIssues`

**Benchmark**
This was tested on a workflow attached to [this Linear
ticket](https://linear.app/n8n/issue/ADO-1501/deliveryhero-enterprise-instance-very-slow-loading-workflows)
and this fix brings down opening time from **~1m10s** to **~28s** on my
laptop.

**Tests**
- [Latest e2e tests
run](https://github.com/n8n-io/n8n/actions/runs/7060874994)

https://community.n8n.io/t/ui-very-slow-with-more-than-100-nodes/8236/14
 2023-12-04 10:57:03 +01:00
Csaba Tuncsik 132d691cbf
fix(editor): Replace isInstanceOwner checks with scopes where applicable (#7858) 
Co-authored-by: Alex Grozav <alex@grozav.com>
 2023-12-04 10:02:54 +01:00
Elias Meire 39fa8d21bb
feat(editor): Add sections to create node panel (#7831) 
This PR sets the stage for the node creator to handle sections within
subcategories. No visible changes result from this PR; the next PR will
define sections and assign nodes accordingly.

Sections are configurable in
`packages/editor-ui/src/components/Node/NodeCreator/viewsData.ts`:
```
{
	type: 'subcategory',
	key: FILES_SUBCATEGORY,
	category: CORE_NODES_CATEGORY,
	properties: {
		title: FILES_SUBCATEGORY,
		icon: 'file-alt',
		sections: [
			{
				key: 'popular',
				title: i18n.baseText('nodeCreator.sectionNames.popular'),
				items: ['n8n-nodes-base.readBinaryFiles', 'n8n-nodes-base.compression'],
			},
		],
	},
},
```

For example:
<img width="302" alt="image"
src="https://github.com/n8n-io/n8n/assets/8850410/74470c07-f4ea-4306-bd4a-8d33bd769b86">

---------

Co-authored-by: Michael Kret <michael.k@radency.com>
 2023-12-04 10:02:07 +01:00
Tomi Turtiainen a78729b12f
feat(editor): Allow partial template credential setup (no-changelog) (#7899) 
Enable continue button even if all credentials havent been setup
 2023-12-04 09:30:34 +02:00
Milorad FIlipović a8049a0def
perf(editor): Improve node rendering performance when opening large workflows (#7904) 
## Summary
In an effort to do as little processing as possible in each `Node`
component, this PR passes current workflow object to it as a property
instead of calling the slow `getCurrentWorkflow` store getter a few
times in each node. This should substantially improve loading times for
large workflows.

As a benchmark, I was using a workflow from [this Linear
ticket](https://linear.app/n8n/issue/ADO-1501/deliveryhero-enterprise-instance-very-slow-loading-workflows)
and this fix brought down opening time by **20 seconds**. Together with
fixes from #7901, this workflow was opening in less than **10 seconds**
on my laptop.

[Latest e2e run](https://github.com/n8n-io/n8n/actions/runs/7062162739)
#### How to test the change:
1. Open a large workflow
2. Observe loading time

## Issues fixed
ADO-1523
https://community.n8n.io/t/ui-very-slow-with-more-than-100-nodes/8236/14

## Review / Merge checklist
- [x] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again. A feature is not complete without tests.
  >
> *(internal)* You can use Slack commands to trigger [e2e
tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227)
or [deploy test
instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce)
or [deploy early access version on
Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).
 2023-12-01 17:50:11 +01:00
Tomi Turtiainen 38e4b56280
fix(editor): Tune styles of template credential setup (no-changelog) (#7898) 2023-12-01 16:00:48 +02:00
Tomi Turtiainen f8e93b3852
fix: Fix credential setup for templates with unnamed credentials (no-changelog) (#7891) 
The template credentials were matched before solely based on the
credential name on the template. This fixes the matching to use both
credential type name and credential name.
 2023-12-01 14:56:51 +02:00
Tomi Turtiainen fe3417a615
feat(editor): Select credentials in template setup if theres only one (#7879) 
Automatically select credentials in the template credential setup if
there's only one available.

NOTE! This feature is still behind a feature flag. To test, set:

```js
localStorage.setItem('template-credentials-setup', 'true')
```


https://github.com/n8n-io/n8n/assets/10324676/edc1f586-214f-4c37-b7ec-dd1786433dc1
 2023-11-30 15:46:14 +02:00
Tomi Turtiainen 627ddb91fb
feat(editor): Open template credential setup from collection (#7882) 
Open the template credential setup when using a template from the
collection view.

NOTE! This feature is still behind a feature flag. To test, set:

```js
localStorage.setItem('template-credentials-setup', 'true')
```


https://github.com/n8n-io/n8n/assets/10324676/46ccec7c-5a44-429e-99ad-1c10640e99e5
 2023-11-30 14:09:12 +02:00
Iván Ovejero ce2d388f05
fix(editor): Fix deletion of last execution at execution preview (#7883) 
https://linear.app/n8n/issue/PAY-1062
 2023-11-30 12:12:26 +01:00
Csaba Tuncsik 14f53def07
fix(editor): Restrict workflow and credential sharing to their owners (no-changelog) (#7870) 
Removing scope permission checks on workflow and credential sharing and
relying only on resource ownership.
Every user can share only the workflows and credentials they created.
 2023-11-29 16:36:49 +01:00
Jan Oberhauser 87def60979
feat: Add AI tool building capabilities (#7336) 
Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/langchain-memory-chat/23733

---------

Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Val <68596159+valya@users.noreply.github.com>
Co-authored-by: Alex Grozav <alex@grozav.com>
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
Co-authored-by: Deborah <deborah@starfallprojects.co.uk>
Co-authored-by: Jesper Bylund <mail@jesperbylund.com>
Co-authored-by: Jon <jonathan.bennetts@gmail.com>
Co-authored-by: Michael Kret <88898367+michael-radency@users.noreply.github.com>
Co-authored-by: Giulio Andreini <andreini@netseven.it>
Co-authored-by: Mason Geloso <Mason.geloso@gmail.com>
Co-authored-by: Mason Geloso <hone@Masons-Mac-mini.local>
Co-authored-by: Mutasem Aldmour <mutasem@n8n.io>
 2023-11-29 12:13:55 +01:00
Milorad FIlipović 8b99384367
fix(editor): Fix cloud plan data loading on instance (#7841) 
Moving cloud hooks and store initialization logic after users are
authenticated. This will ensure user local account is available when
their cloud plan data is being fetched.
This PR also adds the following error handling improvements:
- Added error handling to the same initialization logic
- Fixed empty `catch` clauses inside the cloud store which caused it to
silently fail and complicated debugging of this bug
 2023-11-29 10:51:15 +01:00
Alex Grozav 72852a60eb
feat(editor): Replace middleware for Role checks with Scope checks (#7847) 2023-11-29 10:35:40 +02:00
Csaba Tuncsik d4970410e1
fix(editor): Add telemetry to workflow history (#7811) 2023-11-29 09:09:21 +01:00
Milorad FIlipović c0633987bf
fix(editor): Fix mouse position in workflow previews (#7853) 
This PR fixes mouse position detection in workflow previews (executions
preview and workflow history view):


https://github.com/n8n-io/n8n/assets/2598782/83237b76-b099-4560-9c47-a963f0848297

**Cause**:
We were setting `isDemo` state in canvas store only when the `NodeView`
component is activated, which never happens for `NodeView` instances
that are kept alive (above mentioned workflow previews)

**Fix**:
This workflow updates store state also when the `NodeView` component is
mounted.
 2023-11-28 19:02:19 +01:00
Csaba Tuncsik 685ffd7413
fix(editor): Suppress dev server websocket messages in workflow view (#7808) 2023-11-28 17:30:44 +01:00
कारतोफ्फेलस्क्रिप्ट™ 117962d473
feat(core): Update LLM applications building support (no-changelog) (#7710) 
extracted out of #7336

---------

Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
Co-authored-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Alex Grozav <alex@grozav.com>
 2023-11-28 16:47:28 +01:00
कारतोफ्फेलस्क्रिप्ट™ 4a89504d54
fix(editor): Fix push connection on WorkerList and CommunityNodes pages (no-changelog) (#7851) 2023-11-28 16:45:50 +01:00
Csaba Tuncsik e87e928144
fix(editor): Remove ability for users to select admin role in the UI (no-changelog) (#7850) 2023-11-28 15:11:02 +01:00
Tomi Turtiainen 4074107511
fix(editor): Fix credential icon for old node type version (#7843) 
If a credential was for a node's older version, its icon was not shown.
 2023-11-28 15:14:22 +02:00
कारतोफ्फेलस्क्रिप्ट™ 753cbc1e96
refactor(editor): Delete some barrel files and reduce circular dependencies (no-changelog) (#7838) 2023-11-28 12:15:08 +01:00
Csaba Tuncsik 3ab3ec9da8
fix(editor): Allow owners and admins to share workflows and credentials they don't own (#7833) 2023-11-28 11:44:55 +01:00
Michael Kret df691fba0c
fix(core): Node version in the user added node to workflow canvas event (no-changelog) (#7814) 
Github issue / Community forum post (link here to close automatically):
 2023-11-27 19:50:20 +02:00
Tomi Turtiainen ac744d6702
test: Ado 1296 add e2e tests (#7792) 
Adds e2e tests for the template credential setup.
 2023-11-27 17:18:10 +02:00
Tomi Turtiainen aae45b043b
feat: Ado 1296 spike credential setup in templates (#7786) 
- Add a 'Setup template credentials' view to setup the credentials of a
template before it is created
 2023-11-27 16:30:28 +02:00
Csaba Tuncsik 137e23853f
feat: Add user role select to users list settings page (#7796) 
![CleanShot 2023-11-27 at 07 20
58](https://github.com/n8n-io/n8n/assets/5410822/40be0505-32ee-48a7-923e-ba6b4dbce670)
 2023-11-27 13:38:03 +01:00
कारतोफ्फेलस्क्रिप्ट™ 2807ddcd0d
fix(editor): Setup push connection in NodeView (no-changelog) (#7821) 2023-11-27 12:48:48 +01:00
Alex Grozav 7cc7f226e5
fix(editor): Fix broken element-plus loading spinner (no-changelog) (#7817) 
<img width="976" alt="image"
src="https://github.com/n8n-io/n8n/assets/6179477/aea8a4c8-277e-4527-b6e9-a5c3427097b6">
<img width="117" alt="image"
src="https://github.com/n8n-io/n8n/assets/6179477/14c8876c-5e26-4154-9fdf-8b1fe9e5f806">
 2023-11-27 10:50:50 +02:00
Csaba Tuncsik 152883eed1
build: Upgrade lint related packages (#7790) 2023-11-27 09:11:52 +01:00
कारतोफ्फेलस्क्रिप्ट™ d2c18c5727
fix(core): Use AbortController to notify nodes to abort execution (#6141) 
and add support for cancelling ongoing operations inside a node.

---------
Co-authored-by: Oleg Ivaniv <me@olegivaniv.com>
 2023-11-24 18:17:06 +01:00
Tomi Turtiainen 87fa3c2985
test: Remove obsolete snapshot (#7803) 
Fixes

```
  Snapshots  1 obsolete
             ↳ src/components/banners/__tests__/V1Banner.spec.ts
               · V1 Banner > should render banner if user is not woner 1
```
 2023-11-24 11:53:28 +02:00
Elias Meire da851986f6
feat(editor): Add node name and version to NDV node settings (#7731) 
<img width="580" alt="image"
src="https://github.com/n8n-io/n8n/assets/8850410/85ac1c6e-9116-436a-a2ed-8d0ac162a287">

<img width="580" alt="image"
src="https://github.com/n8n-io/n8n/assets/8850410/08b37377-cef5-4f80-80c0-addfdd37f728">

---------

Co-authored-by: Giulio Andreini <andreini@netseven.it>
 2023-11-23 18:28:07 +01:00
Elias Meire 902beffce5
fix(editor): Disable context menu actions in read-only mode (#7789) 
Github issue / Community forum post (link here to close automatically):
 2023-11-23 17:10:45 +01:00
Michael Auerswald 5835e055d3
fix(editor): Show nice error when environment is not set up (#7778) 
Adds a nicer error message with a link for owners who press Push to Git
without having a repository connected yet.
 2023-11-23 13:50:03 +01:00
Alex Grozav 67a88914f2
feat(editor): Add routing middleware, permission checks, RBAC store, RBAC component (#7702) 
Github issue / Community forum post (link here to close automatically):

---------

Co-authored-by: Csaba Tuncsik <csaba@n8n.io>
 2023-11-23 13:22:47 +02:00
Csaba Tuncsik e128b23a2b
build: Upgrade to Vite 5 (#7784) 2023-11-23 11:55:02 +01:00
Milorad FIlipović 77bc8ecd4b
feat(editor): Show avatars for users currently working on the same workflow (#7763) 
This PR introduces the following changes:
- New Vue stores: `collaborationStore` and `pushConnectionStore`
- Front-end push connection handling overhaul: Keep only a singe
connection open and handle it from the new store
- Add user avatars in the editor header when there are multiple users
working on the same workflow
- Sending a heartbeat event to back-end service periodically to confirm
user is still active

- Back-end overhauls (authored by @tomi):
  - Implementing a cleanup procedure that removes inactive users
  - Refactoring collaboration service current implementation

---------

Co-authored-by: Tomi Turtiainen <10324676+tomi@users.noreply.github.com>
 2023-11-23 10:14:34 +01:00
कारतोफ्फेलस्क्रिप्ट™ 96fd2c51bd
fix(core): Show webhook urls for all webhook nodes (no-changelog) (#7783) 
This reverts parts of https://github.com/n8n-io/n8n/pull/7113
 2023-11-22 17:45:26 +01:00
Csaba Tuncsik 50f568560f
perf: Make frontend linting faster (no-changelog) (#7717) 
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
 2023-11-22 15:01:22 +01:00
Michael Auerswald 0d3d33dd1f
fix(editor): Only show push to git menu item to owners (#7766) 
Removes the menu entry of "Push to Git" from the workflow menu for
non-owners, since they would not be able to push in the first place.
 2023-11-21 15:20:15 +01:00
Michael Auerswald ff0b6511f7
fix(editor): Use project diagram icon for worker view (#7764) 
Swap monster truck for project diagram icon
 2023-11-21 15:18:14 +01:00
Michael Auerswald 366cd672a7
fix(editor): Move workerview entry into settings menu (#7761) 
As the worker view is not an essential function, it is being moved from
the main side bar to the settings side bar for the time being.
 2023-11-21 11:29:24 +01:00
Elias Meire 8d12c1ad8d
feat(editor): Add node context menu (#7620) 
![image](https://github.com/n8n-io/n8n/assets/8850410/5a601fae-cb8e-41bb-beca-ac9ab7065b75)
 2023-11-20 14:37:12 +01:00
Milorad FIlipović 4dbae0e2e9
feat: Add Creator hub link to Templates page (#7721) 
Replace the `New Blank Workflow` button with link to the new Creator Hub
in the Templates page
 2023-11-20 10:51:46 +01:00
Iván Ovejero 4c4082503c
feat(core): Coordinate manual workflow activation and deactivation in multi-main scenario (#7643) 
Followup to #7566 | Story: https://linear.app/n8n/issue/PAY-926

### Manual workflow activation and deactivation

In a multi-main scenario, if the user manually activates or deactivates
a workflow, the process (whether leader or follower) that handles the
PATCH request and updates its internal state should send a message into
the command channel, so that all other main processes update their
internal state accordingly:

- Add to `ActiveWorkflows` if activating
- Remove from `ActiveWorkflows` if deactivating
- Remove and re-add to `ActiveWorkflows` if the update did not change
activation status.

After updating their internal state, if activating or deactivating, the
recipient main processes should push a message to all connected
frontends so that these can update their stores and so reflect the value
in the UI.

### Workflow activation errors

On failure to activate a workflow, the main instance should record the
error in Redis - main instances should always pull activation errors
from Redis in a multi-main scenario.

### Leadership change

On leadership change...

- The old leader should stop pruning and the new leader should start
pruning.
- The old leader should remove trigger- and poller-based workflows and
the new leader should add them.
 2023-11-17 15:58:50 +01:00
कारतोफ्फेलस्क्रिप्ट™ 2d039010db
fix(editor): Fix Admin panel icon in the sidebar for cloud deployments (no-changelog) (#7738) 
Co-authored-by: ricardo <ricardoespinoza105@gmail.com>
Co-authored-by: Mutasem Aldmour <mutasem@n8n.io>
 2023-11-17 14:44:47 +01:00
कारतोफ्फेलस्क्रिप्ट™ b66b8c18e9
fix(editor): Remove n8nHooksNext flag (no-changelog) (#7733) 
Hooks won't be injected anymore
https://github.com/n8n-io/n8n-hosted-backend/pull/816
 2023-11-17 14:44:28 +01:00
Mutasem Aldmour 44d3b3ed7e
fix(editor): Show v1 banner dismiss button if owner (#7722) 
Github issue / Community forum post (link here to close automatically):

https://community.n8n.io/t/v1-upgrade-banner-shall-be-dismissed-permanently/32775
 2023-11-17 14:15:13 +01:00
कारतोफ्फेलस्क्रिप्ट™ fc60e9a809
refactor(core): Convert dynamic node-parameter routes to a decorated controller (no-changelog) (#7284) 
1. Reduce a lot of code duplication
2. Move more endpoints out of `Server.ts`
3. Move all query-param parsing and validation into a middleware to make
the route handlers simpler.
 2023-11-17 12:03:05 +01:00
Ricardo Espinoza 8e0ae3cf8c
refactor: Extract Invitation routes to InvitationController (no-changelog) (#7726) 
This PR:

- Creates `InvitationController`
- Moves `POST /users` to `POST /invitations` and move related test to
`invitations.api.tests`
- Moves `POST /users/:id` to `POST /invitations/:id/accept` and move
related test to `invitations.api.tests`
- Adjusts FE to use new endpoints
- Moves all the invitation logic to the `UserService`

---------

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
 2023-11-16 12:39:43 -05:00
कारतोफ्फेलस्क्रिप्ट™ ebee1a5908
fix(editor): Make sure LineController is registered with chart.js (#7730) 
Tree shaking in production build of the editor-ui package removed the
LineController, this makes sure it is in the final package.
 2023-11-16 11:57:43 +01:00
Csaba Tuncsik 18817651ec
feat(editor): Node IO filter (#7503) 
Co-authored-by: Omar Ajoue <krynble@gmail.com>
 2023-11-15 16:19:48 +01:00
Giulio Andreini 0cebd28582
fix(editor): Dark mode sticky notes (no-changelog) (#7716) 2023-11-15 12:56:09 +01:00
Ricardo Espinoza 4020c14d59
refactor: Use POST /users to re-invite users (no-changelog) (#7714) 2023-11-15 06:40:57 -05:00
Giulio Andreini f1e7ef0117
fix(editor): Dark mode switch style fix and other tweaks (no-changelog) (#7599) 
Github issue / Community forum post (link here to close automatically):
 2023-11-14 17:13:30 +01:00
Alex Grozav a262c450f7
feat: Rewrite Front End cloud and posthog hooks using TypeScript (no-changelog) (#5491) 2023-11-13 15:10:42 +02:00
Michael Kret 1c7225ebdb
feat(core): Expression function $ifEmpty (#7660) 
Github issue / Community forum post (link here to close automatically):

---------

Co-authored-by: Elias Meire <elias@meire.dev>
 2023-11-13 13:28:41 +02:00
Elias Meire 14035e1244
feat(editor): Add HTTP request nodes for credentials without a node (#7157) 
Github issue / Community forum post (link here to close automatically):

---------

Co-authored-by: Giulio Andreini <g.andreini@gmail.com>
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
 2023-11-13 12:11:16 +01:00
Michael Kret 460ac85fda
fix(core): Send pairedItem error to Posthog (no-changelog) (#7697) 
Github issue / Community forum post (link here to close automatically):
 2023-11-13 13:07:12 +02:00
Michael Auerswald cbc690907f
feat(editor): Adds a EE view to show worker details and job status (#7600) 
This change expands on the command channel communication introduced
lately between the main instance(s) and the workers. The frontend gets a
new menu entry "Workers" which will, when opened, trigger a regular call
to getStatus from the workers. The workers then respond via their
response channel to the backend, which then pushes the status to the
frontend.
This introduces the use of ChartJS for metrics.
This feature is still in MVP state and thus disabled by default for the
moment.
 2023-11-10 23:48:31 +01:00
Csaba Tuncsik 37dd658dc5
fix(editor): More securely clear executions tab auto refresh timer (#7685) 2023-11-10 14:51:49 +01:00
Elias Meire 00dff50140
fix(editor): Fix resource mapper component being truncated (#7664) 
Github issue / Community forum post (link here to close automatically):
 2023-11-10 10:43:47 +01:00
Iván Ovejero f73a0597ba
refactor: Add rule no-constant-binary-expression (no-changelog) (#7670) 
https://eslint.org/docs/latest/rules/no-constant-binary-expression
 2023-11-09 17:50:59 +01:00
Michael Kret 6a53c2a375
feat(Discord Node): Overhaul (#5351) 
Github issue / Community forum post (link here to close automatically):

---------

Co-authored-by: Giulio Andreini <g.andreini@gmail.com>
Co-authored-by: Marcus <marcus@n8n.io>
 2023-11-08 16:11:23 +02:00
Ricardo Espinoza afd637b5ea
feat(editor): Add workflow filters to querystring (#7456) 
fixes:
https://linear.app/n8n/issue/ADO-1222/feature-save-filters-in-workflows
 2023-11-08 08:42:53 -05:00
Ricardo Espinoza 8359364536
feat(editor): Add color selector to sticky node (#7453) 
fixes: https://linear.app/n8n/issue/ADO-1223/feature-sticky-colors

---------

Co-authored-by: Giulio Andreini <g.andreini@gmail.com>
Co-authored-by: Mutasem <mutdmour@gmail.com>
 2023-11-08 08:23:57 -05:00
Csaba Tuncsik 020042ef1a
fix(editor): Redirect to workflow editor after saving in debug mode (#7645) 2023-11-08 14:04:02 +01:00
Csaba Tuncsik 3d5a485bcf
fix(editor): Fix workflow history prune time limit (getting hours instead of days) (#7644) 2023-11-07 17:44:58 +01:00
कारतोफ्फेलस्क्रिप्ट™ 60314248f4
fix(core): Make password-reset urls valid only for single-use (#7622) 2023-11-07 15:35:43 +01:00
Ricardo Espinoza b3470fd64d
fix: Error handling on forgot password page (no-changelog) (#7633) 
fixes:
https://linear.app/n8n/issue/ADO-1339/fix-error-handling-on-forgot-password-page
 2023-11-07 08:45:58 -05:00
Mutasem Aldmour 151e60f829
fix(editor): Fix local storage flags defaulting to undefined string (#7603) 
useStorage takes the default value `undefined` and sets it in local
storage.. also returns "undefined" as string which breaks onboarding
flows

Github issue / Community forum post (link here to close automatically):
 2023-11-07 10:06:08 +01:00
Csaba Tuncsik 78b84af8d1
fix(editor): Reset canvas zoom before workspace reset in node view (#7625) 2023-11-06 18:15:49 +01:00
कारतोफ्फेलस्क्रिप्ट™ 4934462b41
fix(editor): More dark-mode fixes (no-changelog) (#7624) 
This fixes:
1. The `OR` divider background when SSO Login is enabled
2. Scanning of QR code in settings in dark mode
 2023-11-06 14:32:38 +01:00
Jan Oberhauser db56a9ee37
fix(editor): Fix issue that frontend breaks with unkown nodes (#7596) 
Because of recent changes does the frontend break when a node is not
known.

![Screenshot from 2023-11-03
08-27-43](https://github.com/n8n-io/n8n/assets/6249596/ab340c3c-9b72-4220-b1f8-70d80f7a5522)



Github issue / Community forum post (link here to close automatically):

---------

Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Oleg Ivaniv <me@olegivaniv.com>
 2023-11-06 13:44:05 +01:00
Ricardo Espinoza b11c4de039
fix(editor): Focus mfa token input (no-changelog) (#7610) 
Github issue / Community forum post (link here to close automatically):
 2023-11-04 20:34:05 -04:00
Ricardo Espinoza 5790e251b8
feat(core): Rate limit forgot password endpoint (#7604) 
Github issue / Community forum post (link here to close automatically):

---------

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <netroy@users.noreply.github.com>
 2023-11-03 13:44:12 -04:00
Omar Ajoue c6049a2e97
feat(editor): Fix some UTM tags (no-changelog) (#7583) 
Github issue / Community forum post (link here to close automatically):
 2023-11-03 16:17:39 +01:00
Alex Grozav 24dfc95974
feat(editor): Improve performance by importing routes dynamically and add route guards (no-changelog) (#7567) 
**Before:**
<img width="657" alt="image"
src="https://github.com/n8n-io/n8n/assets/6179477/0bcced2b-9d3a-43b3-80d7-3c72619941fa">


**After:**
<img width="660" alt="image"
src="https://github.com/n8n-io/n8n/assets/6179477/e74e0bbf-bf33-49b4-ae11-65f640405ac8">
 2023-11-03 16:22:37 +02:00
Elias Meire c92402a3ca
fix(editor): Zoom in/out on canvas the same amount on scroll/gesture (#7602) 
Github issue / Community forum post (link here to close automatically):

https://community.n8n.io/t/ctrl-mousewheel-zoom-jumps-out-possible-to-avoid/31952
 2023-11-03 14:09:18 +01:00
Jan Oberhauser b532a7bdb7
fix(editor): Hide not supported node options (#7597) 
Currently Trigger-Nodes and Sub-Nodes display options that do not make
sense or work like:
- Always Output Data
- Execute Once
- On Error

This PR hides those options for nodes that can not make use of them
anyway to not confuse users.

Github issue / Community forum post (link here to close automatically):
 2023-11-03 12:18:00 +01:00
Csaba Tuncsik 85e1a10021
refactor(editor): Simplify data count in NDV (no-changelog) (#7568) 2023-11-03 12:07:04 +01:00
Milorad FIlipović 9c55702661
fix(editor): Fix flaky ResourceMapper unit tests (no-changelog) (#7593) 
Github issue / Community forum post (link here to close automatically):
 2023-11-03 09:56:19 +01:00
Iván Ovejero d633753687
fix(editor): Remove unknown credentials on pasting workflow (#7582) 
https://linear.app/n8n/issue/PAY-881
 2023-11-02 17:26:39 +01:00
Mutasem Aldmour 2854a0cf46
fix(editor): Allow overriding theme from query params (#7591) 
Allow overriding theme through query params.. to be able to override it
from preview iframe in webcomponent

Github issue / Community forum post (link here to close automatically):
 2023-11-02 16:06:33 +01:00
Jan Oberhauser be49778388
fix(editor): Fix more dark mode issues (no-changelog) (#7578) 
Github issue / Community forum post (link here to close automatically):

---------

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
Co-authored-by: Giulio Andreini <andreini@netseven.it>
 2023-11-02 10:57:08 +01:00
Alex Grozav 721a36637c
feat(editor): Handle pin data edge cases and unify validation (no-changelog) (#6685) 
Github issue / Community forum post (link here to close automatically):
 2023-11-02 10:43:02 +02:00
कारतोफ्फेलस्क्रिप्ट™ 100291e109
refactor(editor): Dark theme improvements (no-changelog) (#7574) 
Co-authored-by: Mutasem Aldmour <4711238+mutdmour@users.noreply.github.com>
 2023-11-01 17:56:15 +01:00
Mutasem Aldmour 1d81afcbdf
fix: Fix dark mode small issues (#7573) 
Github issue / Community forum post (link here to close automatically):
 2023-11-01 16:27:32 +01:00
Jan Oberhauser cc2bd2e19c
feat(HTTP Request Node): Add pagination support (#5993) 
Is still WIP and does not implement the correct UI yet.

Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/pagination-included-into-http-node/15080

https://community.n8n.io/t/how-to-paginate-through-data-in-http-requests/28103
 2023-11-01 14:24:43 +01:00
Giulio Andreini 0746783e02
refactor(editor): Color palette updates, introduce dark mode (#6980) 
Github issue / Community forum post (link here to close automatically):

---------

Co-authored-by: Mutasem <mutdmour@gmail.com>
 2023-11-01 13:33:36 +01:00
Csaba Tuncsik b94b8b2eb0
fix(editor): Rename and move isObjectLiteral utility function (no-changelog) (#7565) 2023-10-31 21:28:01 +01:00
OlegIvaniv 774d521dbd
fix(editor): Keep NodeView component alive for TEMPLATE_IMPORT and WORKFLOW_ONBOARDING routes (no-changelog) (#7557) 
Github issue / Community forum post (link here to close automatically):
 2023-10-31 10:03:57 +01:00
Jan Oberhauser 655efeaf66
feat(core): Add optional Error-Output (#7460) 
Add an additional optional error output to which all items get sent that
could not be processed.
![Screenshot from 2023-10-18
17-29-15](https://github.com/n8n-io/n8n/assets/6249596/e9732807-ab2b-4662-a5f6-bdff24f7ad55)

Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/error-connector-for-nodes/3094

https://community.n8n.io/t/error-handling-at-node-level-detect-node-execution-status/26791

---------

Co-authored-by: OlegIvaniv <me@olegivaniv.com>
 2023-10-30 18:42:47 +01:00
Csaba Tuncsik 3b5e181e66
fix(editor): Fix NDV close after using input select (#7544) 2023-10-30 13:44:19 +01:00
Csaba Tuncsik 2853fcff73
fix(editor): Fix NDV unexpected re-render (#7532) 2023-10-30 09:22:08 +01:00
कारतोफ्फेलस्क्रिप्ट™ c05bc6728d
fix(editor): Handle localStorage being blocked/unavailable (#7348) 2023-10-27 15:51:20 +02:00
कारतोफ्फेलस्क्रिप्ट™ 35bb42c1b9
refactor(core): Avoid passing around static state like default timezone (no-changelog) (#7221) 2023-10-27 14:17:52 +02:00
Iván Ovejero 62c096710f
refactor: Run lintfix (no-changelog) (#7537) 
- Fix autofixable violations
- Remove unused directives
- Allow for PascalCased variables - needed for dynamically imported or
assigned classes, decorators, routers, etc.
 2023-10-27 14:15:02 +02:00
Alex Grozav 1c4ac02db5
fix(editor): Fix executions sidebar height (no-changelog) (#6909) 
<img width="1397" alt="image"
src="https://github.com/n8n-io/n8n/assets/6179477/cb142085-3b21-4e18-9f0d-92c5c4018578">
 2023-10-27 14:32:23 +03:00
Csaba Tuncsik 12a89e6d14
fix(editor): Fix route component caching, incorrect use of array reduce method and enable WF history feature (#7434) 
Co-authored-by: Giulio Andreini <andreini@netseven.it>
 2023-10-26 20:47:42 +02:00
Iván Ovejero ae616f146b
fix(editor): Do not truncate form inputs (#7528) 2023-10-26 17:54:51 +02:00
Jan Oberhauser df89685e15
fix(editor): Fixes the issue that Switch Node can not be created (#7516) 
Fixes the issue that currently no Switch-Node can be created by for
example pressing + on the parent node or via tab when another node is
already selected.

Github issue / Community forum post (link here to close automatically):

---------

Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Oleg Ivaniv <me@olegivaniv.com>
 2023-10-26 09:46:26 +02:00
कारतोफ्फेलस्क्रिप्ट™ 05586a900d
refactor(core): Make Logger a service (no-changelog) (#7494) 2023-10-25 16:35:22 +02:00
OlegIvaniv 2febc61ec9
feat(Switch Node): Add support for infinite Switch outputs (#7499) 
Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/add-more-outputs-to-switch-node/3864

---------

Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
 2023-10-25 14:34:47 +02:00
Mutasem Aldmour c47d27dd6d
feat(editor): Add PH tracking to event (#7511) 
Github issue / Community forum post (link here to close automatically):
 2023-10-25 12:18:19 +02:00
OlegIvaniv 450e0cc66a
fix(editor): Fix connections disappearing after reactivating canvas and renaming a node (#7483) 
Github issue / Community forum post (link here to close automatically):
-
https://community.n8n.io/t/1-11-1-possible-bug-all-nodes-randomly-losing-their-connectors/31856
- https://community.n8n.io/t/lines-between-nodes-have-disappeared/31846

---------

Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
 2023-10-23 10:07:33 +02:00
कारतोफ्फेलस्क्रिप्ट™ 3c0a166f7f
fix(editor): Allow importing the same workflow multiple times (#7458) 
Fixes #7457
 2023-10-20 13:58:30 +02:00
Elias Meire ac814a9c61
feat(Facebook Lead Ads Trigger Node): Add Facebook Lead Ads Trigger Node (#7113) 
Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/facebook-lead-ads-integration/4590/19

---------

Co-authored-by: Marcus <marcus@n8n.io>
 2023-10-20 13:43:55 +02:00
कारतोफ्फेलस्क्रिप्ट™ 91dfc4d513
feat(core): Update LLM applications building support (no-changelog) (#7418) 
extracted out of #7336

---------

Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
Co-authored-by: OlegIvaniv <me@olegivaniv.com>
Co-authored-by: Jan Oberhauser <janober@users.noreply.github.com>
Co-authored-by: Val <68596159+valya@users.noreply.github.com>
Co-authored-by: Alex Grozav <alex@grozav.com>
Co-authored-by: Deborah <deborah@starfallprojects.co.uk>
Co-authored-by: Jesper Bylund <mail@jesperbylund.com>
Co-authored-by: Jon <jonathan.bennetts@gmail.com>
 2023-10-20 10:52:56 +02:00
Milorad FIlipović bc473655fb
fix(editor): Fix canvas selection breaking after interacting with node actions (#7466) 
Sometimes canvas selection stops working after users interact with node
action buttons (for example if node is moved by dragging one of the
buttons)
NOTE: Ticket number in the branch name is wrong, this fixes ADO-1226
 2023-10-20 09:26:40 +02:00
Csaba Tuncsik c7c8048430
feat(editor): Workflow history [WIP] - Remove pinned data from workflow history version preview (no-changelog) (#7406) 2023-10-19 14:38:00 +02:00
Csaba Tuncsik 82129694c6
feat(editor): Workflow history [WIP] - Add cloned workflow link to success toast message (no-changelog) (#7405) 2023-10-19 14:02:59 +02:00
Michael Kret 3ddc176dfa
feat(n8n Form Trigger Node): New node (#7130) 
Github issue / Community forum post (link here to close automatically):

based on https://github.com/joffcom/n8n-nodes-form-trigger

---------

Co-authored-by: Giulio Andreini <g.andreini@gmail.com>
 2023-10-17 07:09:30 +03:00
Inga c599006b91
fix(editor): Open only one tab with plans page (#7377) 
## Issue

In community edition, clicking on "View plans" button on "Settings" ->
"Usage and plan" page (e.g. http://127.0.0.1:5678/settings/usage) opens
two new tabs with n8n pricing (one of them with UTM tracking, another
without).
This was introduced in #6317 , when click handler of "View plans" link
container [started
calling](https://github.com/n8n-io/n8n/pull/6317/files#diff-0bf26afac8a06e03b3d39d0668f22408859355b585a9ab420800c125e33f0691R109)
`uiStore.goToUpgrade(...)` which opens n8n pricing in a new tab, while
browser opens another tab for the link URL.

The simplest fix, implemented in this PR, is to prevent default event
handling (so that, after `onViewPlans` is called, browser will not
attempt to process the click additionally as clicking on the link),
similarly to how it is prevented on some other pages. It only solves the
immediate problem of browser opening two new tabs on clicking "View
plans".

Note that **I didn't implement any tests for the changed behavior**,
because it was not covered by tests before, and I couldn't quite figure
out how to cover it now within the existing test approach (considering
that testing the fact that only one new tab is open will likely require
to write entirely new tests relying on puppeteer; as far as I can see,
no existing `editor-ui` tests are doing anything like that). I'll gladly
implement tests for the new behavior if you tell me how you would like
them to look.
The existing tests for `editor-ui` still pass; I didn't run tests for
other subpackages (see "additional contribution notes" below).

## Additional notes on the issue.

I'm not sure that the change in this PR is the correct long-term
solution for the issue, because the URLs for these two methods (custom
click handler for link container and default link handling) are slightly
different:
* Custom click handler calls `useTelemetryStore().track('User clicked
upgrade CTA', ...)`; then calls `sendUsageTelemetry('view_plans')` (it
feels weird that two calls to telemetry are made); then opens new tab
for `https://n8n.io/pricing?utm_campaign=open&source=usage_page` (note
that prior to #7316 the second call to telemetry was done after the new
tab is opened, not before);
* Link itself refers to another page, with slightly different tracking
parameters:
`https://subscription.n8n.io/?instanceid=[REDACTED]&version=1.10.0&callback=http%3A%2F%2F127.0.0.1%3A5678%2Fsettings%2Fusage&source=usage_page`;
but this page redirects to `https://n8n.io/pricing/`.
It is not clear which one of the two is the right way of doing things.
Although `goToUpgrade` is called in 20 places throughout `editor-ui`,
while `viewPlansUrl`, as far as I can see, is used for this button only.

Additionally, since Settings pages don't work without JS anyway, I can
only think of two separate scenarios where any tab would be opened:
* Left-clicking the link (or Ctrl-clicking, or pressing Space or Enter
when the link is focused, or tapping): previously, both custom click
handler was executed and link's `href` was opened; in this PR, only
custom click handler is executed (similarly to how it is done in the
other places where `goToUpgrade` is called);
* Right-clicking (or long tapping, or opening context menu in any other
way) and selecting "open link in new tab" (or similar): opens a new tab
for URL from the `href` attribute (and does not send any telemetry at
all).

I'd say that the better permanent solution would probably be to get rid
of one of these methods entirely, and only rely on another in all cases
(for me, as an outside contributor, the preferred way would be for
custom click handler to only send telemetry, while letting my browser
handle the actual navigation). However, that would be a large change,
much more than one line in this PR.
Additionally, other similar places where `goToUpgrade` is currently
called (directly or indirectly) would also need to be adapted for this
change.

## Additional contribution notes

As a first-time contributor, I've encountered several things I didn't
expect; I'm not sure if they should be expected or are issues:

1. Tests for the entire monorepo consume a lot of RAM; 20GB free RAM was
not enough, so I couldn't run tests for the entire monorepo and had to
only run them for `packages/editor-ui`;
2. Linting is very slow; `pnpm lint` in `packages/editor-ui` takes ten
minutes to complete;
3. It seems that types are not checked. Code OSS highlights numerous
errors in code files: for example, `'debug'` is incompatible with
`CloudUpdateLinkSourceType` expected by `goToUpgrade` here:
3e7a4d3b2c/packages/editor-ui/src/composables/useExecutionDebugging.ts (L128)
However, I'm not getting any errors during build. There is a `typecheck`
script defined in `package.json`, but `pnpm typecheck` fails with:
    ```
    n8n-toy-demo:~/projects/n8n/packages/editor-ui$ pnpm typecheck

> n8n-editor-ui@1.10.0 typecheck
/home/inga/projects/n8n/packages/editor-ui
    > vue-tsc --emitDeclarationOnly

error TS5069: Option 'emitDeclarationOnly' cannot be specified without
specifying
    option 'declaration' or option 'composite'.


    Found 1 error.

     ELIFECYCLE  Command failed with exit code 1.
    n8n-toy-demo:~/projects/n8n/packages/editor-ui$ 
    ```
Replacing `--emitDeclarationsOnly` with `--noEmit` in `package.json`
unblocks typechecking and results in seemingly, at first glance, correct
"Found 1924 errors in 306 files" (at least several of the reported
errors that I've checked seem to be correct).
But maybe I'm missing something and there are not in fact two thousands
type errors in `editor-ui`?
 2023-10-13 14:14:26 +02:00
Milorad FIlipović 367255ab2c
fix(editor): Fix remote options fetching on every keystroke (#7320) 
Github issue / Community forum post (link here to close automatically):

---------

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
 2023-10-12 14:18:35 +02:00
कारतोफ्फेलस्क्रिप्ट™ 2b075bfc2d
fix(editor): Sanitize HTML binary-data before rendering in the UI (#7400) 2023-10-11 12:09:19 +02:00
Csaba Tuncsik 53c3379282
feat(editor): Workflow history [WIP]- Create workflow history item preview component (no-changelog) (#7378) 
Co-authored-by: Giulio Andreini <g.andreini@gmail.com>
 2023-10-11 10:13:04 +02:00
Omar Ajoue 7ed466db7f
fix(editor): Make workflow history button available only for dev builds (#7392) 
Github issue / Community forum post (link here to close automatically):

---------

Co-authored-by: Csaba Tuncsik <csaba.tuncsik@gmail.com>
 2023-10-10 12:15:18 +02:00
Elias Meire 7e06b31a5f
fix(editor): Implement canvas zoom UX improvements (#7376) 
- Fix pinch-to-zoom
- Support command + scroll to zoom
- Improve accuracy of zooming (scroll more = zoom more)
- Zoom limits
- Zoom relative to mouse position
 2023-10-10 11:07:58 +02:00
Iván Ovejero 86e7ec796a
fix(editor): Fix completions for .json on quoted node name in Code node (#7382) 
To reproduce, request completion with `$input.first().json.` from a node
with a quote in the name, e.g. `When clicking "Execute Workflow"`.

Context:
https://linear.app/n8n/issue/PAY-635/autocomplete-only-supports-3-levels-of-children#comment-234f738b
 2023-10-10 10:05:41 +02:00
कारतोफ्फेलस्क्रिप्ट™ 8187be1b7d
feat(editor): Make PDF and Audio binary-data viewable in the UI (#7367) 
fixes #7361
 2023-10-09 17:43:57 +02:00