mirror of
https://github.com/n8n-io/n8n.git
synced 2024-12-28 14:09:43 -08:00
15693b0056
* feat: Design system color improvements and button component redesign. * feat: Added button focus state and unit tests. * refactor: Aligned n8n-button usage inside of editor-ui. * test: Updated snapshots. * refactor: Extracted focus outline width into scss variable. * fix: Fixed select input border-radius. * refactor: Removed element-ui references in button. * fix: Fixed scss variable imports. * feat: Added color-neutral variable story. * fix: Fixed color-secondary variable definition. * feat: Added color-white story. * test: Updated button snapshot. * feat: Replaced zoom buttons with new n8n-icon-button. * feat: Added stories for float utilities. * chore: Updated color shades generation code for later use. * chore: Removed color-white code. * chore: Updated story properties for button components. * fix: Added el-button fallback for places where el-button is not replaceable (messagebox). * feat: Reverted to css modules. Replaced el-button with n8n-button at application level. * test: Updated button snapshot. * fix: Fixed element-ui locally referenced buttons (via components: {}). * fix: Updated colors. Removed irrelevant validation. Added ElButton override component. * test: Updated button override snapshot. * fix: Various button adjustments and fixes. * fix: Updated button disabled state. * test: Updated snapshots. * fix: Consolidated css variables changes. * Data pinning (#3512) * refactor: Aligned n8n-button usage inside of editor-ui. * feat: Added edit data button on json hover. * feat: Extracted code editor into separate form component. * feat: Added edit data button on json hover. * feat: Added pinData and edit mode methods. * 🔥 Remove conflict markers * ✏️ Update i18n keys * ⚡ Add JSON validation * 🗃️ Add `pinData` column to `workflow_entity` * 📘 Tighten type * ⚡ Make `pinData` column nullable * ⚡ Adjust workflow endpoints for pin data * 📘 Improve types * ✏️ Improve wording * Inject pindata into items flow (#3420) * ⚡ Inject pin data - Second approach * 🔥 Remove unneeded lint exception * feat: Added edit data button on json hover. * feat: Extracted code editor into separate form component. * feat: Added edit data button on json hover. * fix: Fixed rebase conflicts. * ⏪ Undo button change * 🐛 Fix runNode call Adjust per update inbdb84130d6
* 🧪 Fix workflow tests * 🐛 More merge conflict fixes * feat: Added pin/unpin button and store mutations. * feat: Size check. Various design and ux improvements. * ⚡ Add transformer * ⚡ Hoist pin data * ⚡ Adjust endpoints for hoisted pin data * 📘 Expand interface * 🐛 Fix stray array * 👕 Fix build * 👕 Add lint exception * 👕 Fix header * 🎨 Add color secondary tints * ✨ Create `HeaderMessage` component * ⚡ Adjust `InfoTip` component * ✨ Add `HeaderMessage` to `RunData` * 🐛 Fix console error * 👕 Fix lint * ⚡ Consolidate `HeaderMessage` and `Callout` * ⏪ Undo `InfoTip` changes * 🔥 Remove duplicate icons * ⚡ Simplify template * 🎨 Change cursor for action text * 👕 Fix lint * ⚡ Add URL * 🐛 Fix handler name * ⚡ Use constant * ♻️ Refactor per feedback * fix: Various fixes after data pinning relocation. * fix: Added store mutation for setting pinned data. * feat: Added pinned state for workflow canvas node. * fix: Fixed workflow saving. * fix: Removed pinData hoisting (no longer necessary). * feat: Added canPinData flag to hide for input pane and binary data. Fixed unpin and execute flow. * ⚡ Fixes for canvas pin data (#3587) * ⚡ Fixes for canvas pin data * 📘 Rename type * 🧪 Fix unrelated Public API test * 🔥 Remove logging * feat: Updated pinData mixin to no longer include extra fields. * ⚡ Output same pindata for every run * 🎨 Fix cropping * 🔥 Remove unrelated logging * feat: Moved edit button next to pin button. * feat: Changed data to be inserted for empty state. * chore: Changed invalid editor output translation. * feat: Added error line reporting on JSON Validation. * feat: Migrated pinData edit mode to store. * chore: Merged duplicate node border color condition. * feat: Moved pin data validation to mixin. Added check before closing ndv modal. * fix: Changed pinned data size calculation to discard active node pin data. * feat: Added support for rename and delete node with pin data. * feat: Simplified editing state. Fixed edit mode in input panel after store migration. * feat: Various data pinning improvements. * fix: Fixed callout link underline. * refactor: Added support for both string and objects for data size check. * feat: Added disabled node check for input panel. Fixed monaco editor resizing. * fix: Fixed edit mode footer size. * ⚡ Fix pindata items per run * 👕 Remove unneeded exception * refactor: Added isValidPinData() helper method. * refactor: Changed how string size in bytes in calculated.g * refactor: Updated pinData mixin interface. * refactor: Merged filter and reduce in pinDataSize calculation. * fix: Changed code-editor to correct type. * fix: Added insert test data message to trigger nodes. * feat: Disabled data pinning for multiple output nodes. * refactor: Updated ndv.input.disabled translation to include node name. * refactor: Aligned n8n-button usage inside of editor-ui. * feat: Added edit data button on json hover. * feat: Extracted code editor into separate form component. * feat: Added edit data button on json hover. * feat: Added pinData and edit mode methods. * 🔥 Remove conflict markers * ✏️ Update i18n keys * ⚡ Add JSON validation * 🗃️ Add `pinData` column to `workflow_entity` * 📘 Tighten type * ⚡ Make `pinData` column nullable * ⚡ Adjust workflow endpoints for pin data * 📘 Improve types * ✏️ Improve wording * Inject pindata into items flow (#3420) * ⚡ Inject pin data - Second approach * 🔥 Remove unneeded lint exception * feat: Added edit data button on json hover. * feat: Extracted code editor into separate form component. * feat: Added edit data button on json hover. * fix: Fixed rebase conflicts. * ⏪ Undo button change * 🐛 Fix runNode call Adjust per update inbdb84130d6
* 🧪 Fix workflow tests * 🐛 More merge conflict fixes * feat: Added pin/unpin button and store mutations. * feat: Size check. Various design and ux improvements. * ⚡ Add transformer * ⚡ Hoist pin data * ⚡ Adjust endpoints for hoisted pin data * 📘 Expand interface * 🐛 Fix stray array * 👕 Fix build * 🎨 Add color secondary tints * ✨ Create `HeaderMessage` component * ⚡ Adjust `InfoTip` component * ✨ Add `HeaderMessage` to `RunData` * 🐛 Fix console error * 👕 Fix lint * ⚡ Consolidate `HeaderMessage` and `Callout` * ⏪ Undo `InfoTip` changes * 🔥 Remove duplicate icons * ⚡ Simplify template * 🎨 Change cursor for action text * 👕 Fix lint * ⚡ Add URL * 🐛 Fix handler name * ⚡ Use constant * ♻️ Refactor per feedback * fix: Various fixes after data pinning relocation. * fix: Added store mutation for setting pinned data. * feat: Added pinned state for workflow canvas node. * ⚡ Fixes for canvas pin data (#3587) * ⚡ Fixes for canvas pin data * 📘 Rename type * 🧪 Fix unrelated Public API test * 🔥 Remove logging * feat: Updated pinData mixin to no longer include extra fields. * fix: Removed pinData hoisting (no longer necessary). * chore: Merged duplicate node border color condition. * ⚡ Output same pindata for every run * 🎨 Fix cropping * 🐛 Fix excess closing template tag * fix: Removed rogue template tag after merge. * fix: Fixed code-editor resizing when moving ndv panel. * feat: Added node duplication pin data. * ⚡ Implement telemetry * ♻️ Add clarifications from call * fix: Fixed run data header height. * feat: Removed border from pin data callout. * feat: Added line-break before 'or insert pin data'. * feat: Changed enterEditMode to always insert test data if there's no execution data. * feat: Removed copy output tooltip. * feat: Removed unpin tooltip. * fix: Removed thumbtack icon rotation. * fix: Removed run info from Edit Output title. * feat: Hid edit and pin buttons when editing. * feat: Updated monaco code-editor padding and borders. * feat: Progress on pinData error message format * feat: Updated copy feature to work without any selected value. * feat: Moved save and cancel buttons. Cleared notifications on save. * feat: Changed pin data beforeClosing confirm text. * feat: Closing ndv when discarding or saving pindata on close. * feat: Added split in batches node to pin data denylist. * fix: Added missing margin-bottom to webhook node. * feat: Moved thumbtack icon to the right, replacing the checkmark. * fix: Hid pagination while editing. * feat: Added pin data discovery flow. * feat: Changed pin data discovery flow to avoid tooltip glitching. * fix: Changed copy selection to copy all input data. * feat: Updated pin data validation error message for unexpected single quotes. * fix: Replaced :manual='true' prop with manual shorthand. * fix: Removed unused variable. * chore: Renamed translation key to node.discovery.pinData. * refactor: Extracted isPinDataNodeType to pinData mixin. * fix: Updated watch condition to improve performance. * refactor: Renamed some pin data variables and methods as per review. * fix: Added partial translation for JSON.parse pin data error messages. * chore: Temporarily disabled failing unit test. * 🧪 Fix data pinning workflow retrieval test * 🔥 Remove unused imports * 🔥 Remove leftover line * ⚡ Skip pindata node issues on BE * ⚡ Skip pindata node issues on FE * ⚡ Hide `RunInfo` for pindata node * ⚡ Hide purple banner in edit output mode * feat: Updated data pinning discoverability flow. * fix: Fixed paginated data pinning. * fix: Disabled pin data in read only mode. * 🐛 Fix runtime error with non-array * fix: Loading pin data when opening execution. * ⚡ Adjust stale data warning for pinned data * ⚡ Skip auth in endpoint * ⚡ Mark start node for pinned trigger * ✏️ Comment on passthrough * 🔥 Remove comment * Final pindata metrics changes (#3673) * 🐛 Fix `pinData` tracked as `0` * ⚡ Add `is_pinned` to `nodesGraph` * 📘 Extend `IWorkflowBase` * ⚡ Handle `pinData` being `undefined` * ⚡ Add `data_pinning_tooltip_presented` * ♻️ Refactor to remove circular dependency * fix: Added pin data handling when importing workflow. (#3698) * 🔥 Remove helper from WorkflowExecute * ⚡ Add logic for single pinned trigger * 👕 Remove lint exception * fix: Added pin data handling in importWorkflowExact. * N8N-4077 data pinning discoverability part 2 (#3701) * fix: Fixed pin data discovery tooltip position when moving canvas. * feat: Updated data pinning discovery tooltip copy. * Fix data pinning build (#3702) * ⚡ Disable edit button for disabled node * ⚡ Ensure disabled pinned nodes are passthrough * 🐛 Fix JSON key unfurling in edit mode * ⚡ Improve implementation * 🐛 Fix console error * fix: Fixed copying pinned output data. (#3715) * Fix pinning for webhook responding with output from last node (#3719) * fix: Fixed entering edit mode after refresh. * fix: Fixed type error during build. * fix: RunData import formatting. * chore: Updated pin data types. * fix: Added missing type to stringSizeInBytes. Co-authored-by: Iván Ovejero <ivov.src@gmail.com> * fix: Showing pin data without executing the node only in output pane. * fix: Updated no data message when previous node not executed. * feat: Added expression input and evaluation for pin data nodes without execution. * chore: Fixed linting issues and removed remnant console.log(). * chore: Undone package-lock changes. * fix: Removed pin data store changes. * fix: Created a new object using vuex runExecutionData. * fix: Fixed bug appearing when adding a new node after executing. * fix: Fix editor-ui build * feat: Added green node connectors when having pin data output. * chore: Fixed linting errors. * fix: Added pin data eventBus unsubscribe. * fix: Added pin data color check after adding a connection. * 🎨 Add pindata styles Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
1265 lines
34 KiB
TypeScript
1265 lines
34 KiB
TypeScript
import express from 'express';
|
|
|
|
import { ActiveWorkflowRunner, Db } from '../../../src';
|
|
import config from '../../../config';
|
|
import { Role } from '../../../src/databases/entities/Role';
|
|
import { randomApiKey } from '../shared/random';
|
|
|
|
import * as utils from '../shared/utils';
|
|
import * as testDb from '../shared/testDb';
|
|
import { TagEntity } from '../../../src/databases/entities/TagEntity';
|
|
|
|
let app: express.Application;
|
|
let testDbName = '';
|
|
let globalOwnerRole: Role;
|
|
let globalMemberRole: Role;
|
|
let workflowOwnerRole: Role;
|
|
let workflowRunner: ActiveWorkflowRunner.ActiveWorkflowRunner;
|
|
|
|
jest.mock('../../../src/telemetry');
|
|
|
|
beforeAll(async () => {
|
|
app = await utils.initTestServer({ endpointGroups: ['publicApi'], applyAuth: false });
|
|
const initResult = await testDb.init();
|
|
testDbName = initResult.testDbName;
|
|
|
|
const [fetchedGlobalOwnerRole, fetchedGlobalMemberRole, fetchedWorkflowOwnerRole] =
|
|
await testDb.getAllRoles();
|
|
|
|
globalOwnerRole = fetchedGlobalOwnerRole;
|
|
globalMemberRole = fetchedGlobalMemberRole;
|
|
workflowOwnerRole = fetchedWorkflowOwnerRole;
|
|
|
|
utils.initTestTelemetry();
|
|
utils.initTestLogger();
|
|
utils.initConfigFile();
|
|
await utils.initNodeTypes();
|
|
workflowRunner = await utils.initActiveWorkflowRunner();
|
|
});
|
|
|
|
beforeEach(async () => {
|
|
await testDb.truncate(
|
|
['SharedCredentials', 'SharedWorkflow', 'Tag', 'User', 'Workflow', 'Credentials'],
|
|
testDbName,
|
|
);
|
|
|
|
config.set('userManagement.disabled', false);
|
|
config.set('userManagement.isInstanceOwnerSetUp', true);
|
|
});
|
|
|
|
afterEach(async () => {
|
|
await workflowRunner.removeAll();
|
|
});
|
|
|
|
afterAll(async () => {
|
|
await testDb.terminate(testDbName);
|
|
});
|
|
|
|
test('GET /workflows should fail due to missing API Key', async () => {
|
|
const owner = await testDb.createUser({ globalRole: globalOwnerRole });
|
|
|
|
const authOwnerAgent = utils.createAgent(app, {
|
|
apiPath: 'public',
|
|
auth: true,
|
|
user: owner,
|
|
version: 1,
|
|
});
|
|
|
|
const response = await authOwnerAgent.get('/workflows');
|
|
|
|
expect(response.statusCode).toBe(401);
|
|
});
|
|
|
|
test('GET /workflows should fail due to invalid API Key', async () => {
|
|
const owner = await testDb.createUser({ globalRole: globalOwnerRole, apiKey: randomApiKey() });
|
|
|
|
owner.apiKey = 'abcXYZ';
|
|
|
|
const authOwnerAgent = utils.createAgent(app, {
|
|
apiPath: 'public',
|
|
auth: true,
|
|
user: owner,
|
|
version: 1,
|
|
});
|
|
|
|
const response = await authOwnerAgent.get('/workflows');
|
|
|
|
expect(response.statusCode).toBe(401);
|
|
});
|
|
|
|
test('GET /workflows should return all owned workflows', async () => {
|
|
const member = await testDb.createUser({ globalRole: globalMemberRole, apiKey: randomApiKey() });
|
|
|
|
const authAgent = utils.createAgent(app, {
|
|
apiPath: 'public',
|
|
auth: true,
|
|
user: member,
|
|
version: 1,
|
|
});
|
|
|
|
await Promise.all([
|
|
testDb.createWorkflow({}, member),
|
|
testDb.createWorkflow({}, member),
|
|
testDb.createWorkflow({}, member),
|
|
]);
|
|
|
|
const response = await authAgent.get('/workflows');
|
|
|
|
expect(response.statusCode).toBe(200);
|
|
expect(response.body.data.length).toBe(3);
|
|
expect(response.body.nextCursor).toBeNull();
|
|
|
|
for (const workflow of response.body.data) {
|
|
const {
|
|
id,
|
|
connections,
|
|
active,
|
|
staticData,
|
|
nodes,
|
|
settings,
|
|
name,
|
|
createdAt,
|
|
updatedAt,
|
|
tags,
|
|
} = workflow;
|
|
|
|
expect(id).toBeDefined();
|
|
expect(name).toBeDefined();
|
|
expect(connections).toBeDefined();
|
|
expect(active).toBe(false);
|
|
expect(staticData).toBeDefined();
|
|
expect(nodes).toBeDefined();
|
|
expect(tags).toBeDefined();
|
|
expect(settings).toBeDefined();
|
|
expect(createdAt).toBeDefined();
|
|
expect(updatedAt).toBeDefined();
|
|
}
|
|
});
|
|
|
|
test('GET /workflows should return all owned workflows with pagination', async () => {
|
|
const member = await testDb.createUser({ globalRole: globalMemberRole, apiKey: randomApiKey() });
|
|
|
|
const authAgent = utils.createAgent(app, {
|
|
apiPath: 'public',
|
|
auth: true,
|
|
user: member,
|
|
version: 1,
|
|
});
|
|
|
|
await Promise.all([
|
|
testDb.createWorkflow({}, member),
|
|
testDb.createWorkflow({}, member),
|
|
testDb.createWorkflow({}, member),
|
|
]);
|
|
|
|
const response = await authAgent.get('/workflows?limit=1');
|
|
|
|
expect(response.statusCode).toBe(200);
|
|
expect(response.body.data.length).toBe(1);
|
|
expect(response.body.nextCursor).not.toBeNull();
|
|
|
|
const response2 = await authAgent.get(`/workflows?limit=1&cursor=${response.body.nextCursor}`);
|
|
|
|
expect(response2.statusCode).toBe(200);
|
|
expect(response2.body.data.length).toBe(1);
|
|
expect(response2.body.nextCursor).not.toBeNull();
|
|
expect(response2.body.nextCursor).not.toBe(response.body.nextCursor);
|
|
|
|
const responses = [...response.body.data, ...response2.body.data];
|
|
|
|
for (const workflow of responses) {
|
|
const {
|
|
id,
|
|
connections,
|
|
active,
|
|
staticData,
|
|
nodes,
|
|
settings,
|
|
name,
|
|
createdAt,
|
|
updatedAt,
|
|
tags,
|
|
} = workflow;
|
|
|
|
expect(id).toBeDefined();
|
|
expect(name).toBeDefined();
|
|
expect(connections).toBeDefined();
|
|
expect(active).toBe(false);
|
|
expect(staticData).toBeDefined();
|
|
expect(nodes).toBeDefined();
|
|
expect(tags).toBeDefined();
|
|
expect(settings).toBeDefined();
|
|
expect(createdAt).toBeDefined();
|
|
expect(updatedAt).toBeDefined();
|
|
}
|
|
|
|
// check that we really received a different result
|
|
expect(response.body.data[0].id).toBeLessThan(response2.body.data[0].id);
|
|
});
|
|
|
|
test('GET /workflows should return all owned workflows filtered by tag', async () => {
|
|
const member = await testDb.createUser({ globalRole: globalMemberRole, apiKey: randomApiKey() });
|
|
|
|
const authAgent = utils.createAgent(app, {
|
|
apiPath: 'public',
|
|
auth: true,
|
|
user: member,
|
|
version: 1,
|
|
});
|
|
|
|
const tag = await testDb.createTag({});
|
|
|
|
const [workflow] = await Promise.all([
|
|
testDb.createWorkflow({ tags: [tag] }, member),
|
|
testDb.createWorkflow({}, member),
|
|
]);
|
|
|
|
const response = await authAgent.get(`/workflows?tags=${tag.name}`);
|
|
|
|
expect(response.statusCode).toBe(200);
|
|
expect(response.body.data.length).toBe(1);
|
|
|
|
const {
|
|
id,
|
|
connections,
|
|
active,
|
|
staticData,
|
|
nodes,
|
|
settings,
|
|
name,
|
|
createdAt,
|
|
updatedAt,
|
|
tags: wfTags,
|
|
} = response.body.data[0];
|
|
|
|
expect(id).toBe(workflow.id);
|
|
expect(name).toBeDefined();
|
|
expect(connections).toBeDefined();
|
|
expect(active).toBe(false);
|
|
expect(staticData).toBeDefined();
|
|
expect(nodes).toBeDefined();
|
|
expect(settings).toBeDefined();
|
|
expect(createdAt).toBeDefined();
|
|
expect(updatedAt).toBeDefined();
|
|
|
|
expect(wfTags.length).toBe(1);
|
|
expect(wfTags[0].id).toBe(tag.id);
|
|
});
|
|
|
|
test('GET /workflows should return all owned workflows filtered by tags', async () => {
|
|
const member = await testDb.createUser({ globalRole: globalMemberRole, apiKey: randomApiKey() });
|
|
|
|
const authAgent = utils.createAgent(app, {
|
|
apiPath: 'public',
|
|
auth: true,
|
|
user: member,
|
|
version: 1,
|
|
});
|
|
|
|
const tags = await Promise.all([await testDb.createTag({}), await testDb.createTag({})]);
|
|
const tagNames = tags.map((tag) => tag.name).join(',');
|
|
|
|
const [workflow1, workflow2] = await Promise.all([
|
|
testDb.createWorkflow({ tags }, member),
|
|
testDb.createWorkflow({ tags }, member),
|
|
testDb.createWorkflow({}, member),
|
|
testDb.createWorkflow({ tags: [tags[0]] }, member),
|
|
testDb.createWorkflow({ tags: [tags[1]] }, member),
|
|
]);
|
|
|
|
const response = await authAgent.get(`/workflows?tags=${tagNames}`);
|
|
|
|
expect(response.statusCode).toBe(200);
|
|
expect(response.body.data.length).toBe(2);
|
|
|
|
for (const workflow of response.body.data) {
|
|
const { id, connections, active, staticData, nodes, settings, name, createdAt, updatedAt } =
|
|
workflow;
|
|
|
|
expect(id).toBeDefined();
|
|
expect([workflow1.id, workflow2.id].includes(id)).toBe(true);
|
|
|
|
expect(name).toBeDefined();
|
|
expect(connections).toBeDefined();
|
|
expect(active).toBe(false);
|
|
expect(staticData).toBeDefined();
|
|
expect(nodes).toBeDefined();
|
|
expect(settings).toBeDefined();
|
|
expect(createdAt).toBeDefined();
|
|
expect(updatedAt).toBeDefined();
|
|
|
|
expect(workflow.tags.length).toBe(2);
|
|
workflow.tags.forEach((tag: TagEntity) => {
|
|
expect(tags.some((savedTag) => savedTag.id === tag.id)).toBe(true);
|
|
});
|
|
}
|
|
});
|
|
|
|
test('GET /workflows should return all workflows for owner', async () => {
|
|
const owner = await testDb.createUser({ globalRole: globalOwnerRole, apiKey: randomApiKey() });
|
|
const member = await testDb.createUser({ globalRole: globalMemberRole });
|
|
|
|
const authOwnerAgent = utils.createAgent(app, {
|
|
apiPath: 'public',
|
|
auth: true,
|
|
user: owner,
|
|
version: 1,
|
|
});
|
|
|
|
await Promise.all([
|
|
testDb.createWorkflow({}, owner),
|
|
testDb.createWorkflow({}, member),
|
|
testDb.createWorkflow({}, owner),
|
|
testDb.createWorkflow({}, member),
|
|
testDb.createWorkflow({}, owner),
|
|
]);
|
|
|
|
const response = await authOwnerAgent.get('/workflows');
|
|
|
|
expect(response.statusCode).toBe(200);
|
|
expect(response.body.data.length).toBe(5);
|
|
expect(response.body.nextCursor).toBeNull();
|
|
|
|
for (const workflow of response.body.data) {
|
|
const {
|
|
id,
|
|
connections,
|
|
active,
|
|
staticData,
|
|
nodes,
|
|
settings,
|
|
name,
|
|
createdAt,
|
|
updatedAt,
|
|
tags,
|
|
} = workflow;
|
|
|
|
expect(id).toBeDefined();
|
|
expect(name).toBeDefined();
|
|
expect(connections).toBeDefined();
|
|
expect(active).toBe(false);
|
|
expect(staticData).toBeDefined();
|
|
expect(nodes).toBeDefined();
|
|
expect(tags).toBeDefined();
|
|
expect(settings).toBeDefined();
|
|
expect(createdAt).toBeDefined();
|
|
expect(updatedAt).toBeDefined();
|
|
}
|
|
});
|
|
|
|
test('GET /workflows/:id should fail due to missing API Key', async () => {
|
|
const owner = await testDb.createUser({ globalRole: globalOwnerRole });
|
|
|
|
owner.apiKey = null;
|
|
|
|
const authOwnerAgent = utils.createAgent(app, {
|
|
apiPath: 'public',
|
|
auth: true,
|
|
user: owner,
|
|
version: 1,
|
|
});
|
|
|
|
const response = await authOwnerAgent.get(`/workflows/2`);
|
|
|
|
expect(response.statusCode).toBe(401);
|
|
});
|
|
|
|
test('GET /workflows/:id should fail due to invalid API Key', async () => {
|
|
const owner = await testDb.createUser({ globalRole: globalOwnerRole, apiKey: randomApiKey() });
|
|
|
|
owner.apiKey = 'abcXYZ';
|
|
|
|
const authOwnerAgent = utils.createAgent(app, {
|
|
apiPath: 'public',
|
|
auth: true,
|
|
user: owner,
|
|
version: 1,
|
|
});
|
|
|
|
const response = await authOwnerAgent.get(`/workflows/2`);
|
|
|
|
expect(response.statusCode).toBe(401);
|
|
});
|
|
|
|
test('GET /workflows/:id should fail due to non-existing workflow', async () => {
|
|
const owner = await testDb.createUser({ globalRole: globalOwnerRole, apiKey: randomApiKey() });
|
|
|
|
const authOwnerAgent = utils.createAgent(app, {
|
|
apiPath: 'public',
|
|
auth: true,
|
|
user: owner,
|
|
version: 1,
|
|
});
|
|
|
|
const response = await authOwnerAgent.get(`/workflows/2`);
|
|
|
|
expect(response.statusCode).toBe(404);
|
|
});
|
|
|
|
test('GET /workflows/:id should retrieve workflow', async () => {
|
|
const member = await testDb.createUser({ globalRole: globalMemberRole, apiKey: randomApiKey() });
|
|
|
|
const authAgent = utils.createAgent(app, {
|
|
apiPath: 'public',
|
|
auth: true,
|
|
user: member,
|
|
version: 1,
|
|
});
|
|
|
|
// create and assign workflow to owner
|
|
const workflow = await testDb.createWorkflow({}, member);
|
|
|
|
const response = await authAgent.get(`/workflows/${workflow.id}`);
|
|
|
|
expect(response.statusCode).toBe(200);
|
|
|
|
const { id, connections, active, staticData, nodes, settings, name, createdAt, updatedAt, tags } =
|
|
response.body;
|
|
|
|
expect(id).toEqual(workflow.id);
|
|
expect(name).toEqual(workflow.name);
|
|
expect(connections).toEqual(workflow.connections);
|
|
expect(active).toBe(false);
|
|
expect(staticData).toEqual(workflow.staticData);
|
|
expect(nodes).toEqual(workflow.nodes);
|
|
expect(tags).toEqual([]);
|
|
expect(settings).toEqual(workflow.settings);
|
|
expect(createdAt).toEqual(workflow.createdAt.toISOString());
|
|
expect(updatedAt).toEqual(workflow.updatedAt.toISOString());
|
|
});
|
|
|
|
test('GET /workflows/:id should retrieve non-owned workflow for owner', async () => {
|
|
const owner = await testDb.createUser({ globalRole: globalOwnerRole, apiKey: randomApiKey() });
|
|
const member = await testDb.createUser({ globalRole: globalMemberRole });
|
|
|
|
const authOwnerAgent = utils.createAgent(app, {
|
|
apiPath: 'public',
|
|
auth: true,
|
|
user: owner,
|
|
version: 1,
|
|
});
|
|
|
|
// create and assign workflow to owner
|
|
const workflow = await testDb.createWorkflow({}, member);
|
|
|
|
const response = await authOwnerAgent.get(`/workflows/${workflow.id}`);
|
|
|
|
expect(response.statusCode).toBe(200);
|
|
|
|
const { id, connections, active, staticData, nodes, settings, name, createdAt, updatedAt } =
|
|
response.body;
|
|
|
|
expect(id).toEqual(workflow.id);
|
|
expect(name).toEqual(workflow.name);
|
|
expect(connections).toEqual(workflow.connections);
|
|
expect(active).toBe(false);
|
|
expect(staticData).toEqual(workflow.staticData);
|
|
expect(nodes).toEqual(workflow.nodes);
|
|
expect(settings).toEqual(workflow.settings);
|
|
expect(createdAt).toEqual(workflow.createdAt.toISOString());
|
|
expect(updatedAt).toEqual(workflow.updatedAt.toISOString());
|
|
});
|
|
|
|
test('DELETE /workflows/:id should fail due to missing API Key', async () => {
|
|
const owner = await testDb.createUser({ globalRole: globalOwnerRole });
|
|
|
|
const authOwnerAgent = utils.createAgent(app, {
|
|
apiPath: 'public',
|
|
auth: true,
|
|
user: owner,
|
|
version: 1,
|
|
});
|
|
|
|
const response = await authOwnerAgent.delete(`/workflows/2`);
|
|
|
|
expect(response.statusCode).toBe(401);
|
|
});
|
|
|
|
test('DELETE /workflows/:id should fail due to invalid API Key', async () => {
|
|
const owner = await testDb.createUser({ globalRole: globalOwnerRole, apiKey: randomApiKey() });
|
|
|
|
owner.apiKey = 'abcXYZ';
|
|
|
|
const authOwnerAgent = utils.createAgent(app, {
|
|
apiPath: 'public',
|
|
auth: true,
|
|
user: owner,
|
|
version: 1,
|
|
});
|
|
|
|
const response = await authOwnerAgent.delete(`/workflows/2`);
|
|
|
|
expect(response.statusCode).toBe(401);
|
|
});
|
|
|
|
test('DELETE /workflows/:id should fail due to non-existing workflow', async () => {
|
|
const owner = await testDb.createUser({ globalRole: globalOwnerRole, apiKey: randomApiKey() });
|
|
|
|
const authOwnerAgent = utils.createAgent(app, {
|
|
apiPath: 'public',
|
|
auth: true,
|
|
user: owner,
|
|
version: 1,
|
|
});
|
|
|
|
const response = await authOwnerAgent.delete(`/workflows/2`);
|
|
|
|
expect(response.statusCode).toBe(404);
|
|
});
|
|
|
|
test('DELETE /workflows/:id should delete the workflow', async () => {
|
|
const member = await testDb.createUser({ globalRole: globalMemberRole, apiKey: randomApiKey() });
|
|
|
|
const authAgent = utils.createAgent(app, {
|
|
apiPath: 'public',
|
|
auth: true,
|
|
user: member,
|
|
version: 1,
|
|
});
|
|
|
|
// create and assign workflow to owner
|
|
const workflow = await testDb.createWorkflow({}, member);
|
|
|
|
const response = await authAgent.delete(`/workflows/${workflow.id}`);
|
|
|
|
expect(response.statusCode).toBe(200);
|
|
|
|
const { id, connections, active, staticData, nodes, settings, name, createdAt, updatedAt } =
|
|
response.body;
|
|
|
|
expect(id).toEqual(workflow.id);
|
|
expect(name).toEqual(workflow.name);
|
|
expect(connections).toEqual(workflow.connections);
|
|
expect(active).toBe(false);
|
|
expect(staticData).toEqual(workflow.staticData);
|
|
expect(nodes).toEqual(workflow.nodes);
|
|
expect(settings).toEqual(workflow.settings);
|
|
expect(createdAt).toEqual(workflow.createdAt.toISOString());
|
|
expect(updatedAt).toEqual(workflow.updatedAt.toISOString());
|
|
|
|
// make sure the workflow actually deleted from the db
|
|
const sharedWorkflow = await Db.collections.SharedWorkflow.findOne({
|
|
workflow,
|
|
});
|
|
|
|
expect(sharedWorkflow).toBeUndefined();
|
|
});
|
|
|
|
test('DELETE /workflows/:id should delete non-owned workflow when owner', async () => {
|
|
const owner = await testDb.createUser({ globalRole: globalOwnerRole, apiKey: randomApiKey() });
|
|
const member = await testDb.createUser({ globalRole: globalMemberRole });
|
|
|
|
const authAgent = utils.createAgent(app, {
|
|
apiPath: 'public',
|
|
auth: true,
|
|
user: owner,
|
|
version: 1,
|
|
});
|
|
|
|
// create and assign workflow to owner
|
|
const workflow = await testDb.createWorkflow({}, member);
|
|
|
|
const response = await authAgent.delete(`/workflows/${workflow.id}`);
|
|
|
|
expect(response.statusCode).toBe(200);
|
|
|
|
const { id, connections, active, staticData, nodes, settings, name, createdAt, updatedAt } =
|
|
response.body;
|
|
|
|
expect(id).toEqual(workflow.id);
|
|
expect(name).toEqual(workflow.name);
|
|
expect(connections).toEqual(workflow.connections);
|
|
expect(active).toBe(false);
|
|
expect(staticData).toEqual(workflow.staticData);
|
|
expect(nodes).toEqual(workflow.nodes);
|
|
expect(settings).toEqual(workflow.settings);
|
|
expect(createdAt).toEqual(workflow.createdAt.toISOString());
|
|
expect(updatedAt).toEqual(workflow.updatedAt.toISOString());
|
|
|
|
// make sure the workflow actually deleted from the db
|
|
const sharedWorkflow = await Db.collections.SharedWorkflow.findOne({
|
|
workflow,
|
|
});
|
|
|
|
expect(sharedWorkflow).toBeUndefined();
|
|
});
|
|
|
|
test('POST /workflows/:id/activate should fail due to missing API Key', async () => {
|
|
const owner = await testDb.createUser({ globalRole: globalOwnerRole });
|
|
|
|
const authOwnerAgent = utils.createAgent(app, {
|
|
apiPath: 'public',
|
|
auth: true,
|
|
user: owner,
|
|
version: 1,
|
|
});
|
|
|
|
const response = await authOwnerAgent.post(`/workflows/2/activate`);
|
|
|
|
expect(response.statusCode).toBe(401);
|
|
});
|
|
|
|
test('POST /workflows/:id/activate should fail due to invalid API Key', async () => {
|
|
const owner = await testDb.createUser({ globalRole: globalOwnerRole, apiKey: randomApiKey() });
|
|
|
|
owner.apiKey = 'abcXYZ';
|
|
|
|
const authOwnerAgent = utils.createAgent(app, {
|
|
apiPath: 'public',
|
|
auth: true,
|
|
user: owner,
|
|
version: 1,
|
|
});
|
|
|
|
const response = await authOwnerAgent.post(`/workflows/2/activate`);
|
|
|
|
expect(response.statusCode).toBe(401);
|
|
});
|
|
|
|
test('POST /workflows/:id/activate should fail due to non-existing workflow', async () => {
|
|
const owner = await testDb.createUser({ globalRole: globalOwnerRole, apiKey: randomApiKey() });
|
|
|
|
const authOwnerAgent = utils.createAgent(app, {
|
|
apiPath: 'public',
|
|
auth: true,
|
|
user: owner,
|
|
version: 1,
|
|
});
|
|
|
|
const response = await authOwnerAgent.post(`/workflows/2/activate`);
|
|
|
|
expect(response.statusCode).toBe(404);
|
|
});
|
|
|
|
test('POST /workflows/:id/activate should fail due to trying to activate a workflow without a trigger', async () => {
|
|
const owner = await testDb.createUser({ globalRole: globalOwnerRole, apiKey: randomApiKey() });
|
|
|
|
const authOwnerAgent = utils.createAgent(app, {
|
|
apiPath: 'public',
|
|
auth: true,
|
|
user: owner,
|
|
version: 1,
|
|
});
|
|
|
|
const workflow = await testDb.createWorkflow({}, owner);
|
|
|
|
const response = await authOwnerAgent.post(`/workflows/${workflow.id}/activate`);
|
|
|
|
expect(response.statusCode).toBe(400);
|
|
});
|
|
|
|
test('POST /workflows/:id/activate should set workflow as active', async () => {
|
|
const member = await testDb.createUser({ globalRole: globalMemberRole, apiKey: randomApiKey() });
|
|
|
|
const authAgent = utils.createAgent(app, {
|
|
apiPath: 'public',
|
|
auth: true,
|
|
user: member,
|
|
version: 1,
|
|
});
|
|
|
|
const workflow = await testDb.createWorkflowWithTrigger({}, member);
|
|
|
|
const response = await authAgent.post(`/workflows/${workflow.id}/activate`);
|
|
|
|
expect(response.statusCode).toBe(200);
|
|
|
|
const { id, connections, active, staticData, nodes, settings, name, createdAt, updatedAt } =
|
|
response.body;
|
|
|
|
expect(id).toEqual(workflow.id);
|
|
expect(name).toEqual(workflow.name);
|
|
expect(connections).toEqual(workflow.connections);
|
|
expect(active).toBe(true);
|
|
expect(staticData).toEqual(workflow.staticData);
|
|
expect(nodes).toEqual(workflow.nodes);
|
|
expect(settings).toEqual(workflow.settings);
|
|
expect(createdAt).toEqual(workflow.createdAt.toISOString());
|
|
expect(updatedAt).toEqual(workflow.updatedAt.toISOString());
|
|
|
|
// check whether the workflow is on the database
|
|
const sharedWorkflow = await Db.collections.SharedWorkflow.findOne({
|
|
where: {
|
|
user: member,
|
|
workflow,
|
|
},
|
|
relations: ['workflow'],
|
|
});
|
|
|
|
expect(sharedWorkflow?.workflow.active).toBe(true);
|
|
|
|
// check whether the workflow is on the active workflow runner
|
|
expect(await workflowRunner.isActive(workflow.id.toString())).toBe(true);
|
|
});
|
|
|
|
test('POST /workflows/:id/activate should set non-owned workflow as active when owner', async () => {
|
|
const owner = await testDb.createUser({ globalRole: globalOwnerRole, apiKey: randomApiKey() });
|
|
const member = await testDb.createUser({ globalRole: globalMemberRole });
|
|
|
|
const authAgent = utils.createAgent(app, {
|
|
apiPath: 'public',
|
|
auth: true,
|
|
user: owner,
|
|
version: 1,
|
|
});
|
|
|
|
const workflow = await testDb.createWorkflowWithTrigger({}, member);
|
|
|
|
const response = await authAgent.post(`/workflows/${workflow.id}/activate`);
|
|
|
|
expect(response.statusCode).toBe(200);
|
|
|
|
const { id, connections, active, staticData, nodes, settings, name, createdAt, updatedAt } =
|
|
response.body;
|
|
|
|
expect(id).toEqual(workflow.id);
|
|
expect(name).toEqual(workflow.name);
|
|
expect(connections).toEqual(workflow.connections);
|
|
expect(active).toBe(true);
|
|
expect(staticData).toEqual(workflow.staticData);
|
|
expect(nodes).toEqual(workflow.nodes);
|
|
expect(settings).toEqual(workflow.settings);
|
|
expect(createdAt).toEqual(workflow.createdAt.toISOString());
|
|
expect(updatedAt).toEqual(workflow.updatedAt.toISOString());
|
|
|
|
// check whether the workflow is on the database
|
|
const sharedOwnerWorkflow = await Db.collections.SharedWorkflow.findOne({
|
|
where: {
|
|
user: owner,
|
|
workflow,
|
|
},
|
|
});
|
|
|
|
expect(sharedOwnerWorkflow).toBeUndefined();
|
|
|
|
const sharedWorkflow = await Db.collections.SharedWorkflow.findOne({
|
|
where: {
|
|
user: member,
|
|
workflow,
|
|
},
|
|
relations: ['workflow'],
|
|
});
|
|
|
|
expect(sharedWorkflow?.workflow.active).toBe(true);
|
|
|
|
// check whether the workflow is on the active workflow runner
|
|
expect(await workflowRunner.isActive(workflow.id.toString())).toBe(true);
|
|
});
|
|
|
|
test('POST /workflows/:id/deactivate should fail due to missing API Key', async () => {
|
|
const owner = await testDb.createUser({ globalRole: globalOwnerRole });
|
|
|
|
const authOwnerAgent = utils.createAgent(app, {
|
|
apiPath: 'public',
|
|
auth: true,
|
|
user: owner,
|
|
version: 1,
|
|
});
|
|
|
|
const response = await authOwnerAgent.post(`/workflows/2/deactivate`);
|
|
|
|
expect(response.statusCode).toBe(401);
|
|
});
|
|
|
|
test('POST /workflows/:id/deactivate should fail due to invalid API Key', async () => {
|
|
const owner = await testDb.createUser({ globalRole: globalOwnerRole, apiKey: randomApiKey() });
|
|
|
|
owner.apiKey = 'abcXYZ';
|
|
|
|
const authOwnerAgent = utils.createAgent(app, {
|
|
apiPath: 'public',
|
|
auth: true,
|
|
user: owner,
|
|
version: 1,
|
|
});
|
|
|
|
const response = await authOwnerAgent.post(`/workflows/2/deactivate`);
|
|
|
|
expect(response.statusCode).toBe(401);
|
|
});
|
|
|
|
test('POST /workflows/:id/deactivate should fail due to non-existing workflow', async () => {
|
|
const owner = await testDb.createUser({ globalRole: globalOwnerRole, apiKey: randomApiKey() });
|
|
|
|
const authOwnerAgent = utils.createAgent(app, {
|
|
apiPath: 'public',
|
|
auth: true,
|
|
user: owner,
|
|
version: 1,
|
|
});
|
|
|
|
const response = await authOwnerAgent.post(`/workflows/2/deactivate`);
|
|
|
|
expect(response.statusCode).toBe(404);
|
|
});
|
|
|
|
test('POST /workflows/:id/deactivate should deactive workflow', async () => {
|
|
const member = await testDb.createUser({ globalRole: globalMemberRole, apiKey: randomApiKey() });
|
|
|
|
const authAgent = utils.createAgent(app, {
|
|
apiPath: 'public',
|
|
auth: true,
|
|
user: member,
|
|
version: 1,
|
|
});
|
|
|
|
const workflow = await testDb.createWorkflowWithTrigger({}, member);
|
|
|
|
await authAgent.post(`/workflows/${workflow.id}/activate`);
|
|
|
|
const workflowDeactivationResponse = await authAgent.post(`/workflows/${workflow.id}/deactivate`);
|
|
|
|
const { id, connections, active, staticData, nodes, settings, name, createdAt, updatedAt } =
|
|
workflowDeactivationResponse.body;
|
|
|
|
expect(id).toEqual(workflow.id);
|
|
expect(name).toEqual(workflow.name);
|
|
expect(connections).toEqual(workflow.connections);
|
|
expect(active).toBe(false);
|
|
expect(staticData).toEqual(workflow.staticData);
|
|
expect(nodes).toEqual(workflow.nodes);
|
|
expect(settings).toEqual(workflow.settings);
|
|
expect(createdAt).toBeDefined();
|
|
expect(updatedAt).toBeDefined();
|
|
|
|
// get the workflow after it was deactivated
|
|
const sharedWorkflow = await Db.collections.SharedWorkflow.findOne({
|
|
where: {
|
|
user: member,
|
|
workflow,
|
|
},
|
|
relations: ['workflow'],
|
|
});
|
|
|
|
// check whether the workflow is deactivated in the database
|
|
expect(sharedWorkflow?.workflow.active).toBe(false);
|
|
|
|
expect(await workflowRunner.isActive(workflow.id.toString())).toBe(false);
|
|
});
|
|
|
|
test('POST /workflows/:id/deactivate should deactive non-owned workflow when owner', async () => {
|
|
const owner = await testDb.createUser({ globalRole: globalOwnerRole, apiKey: randomApiKey() });
|
|
const member = await testDb.createUser({ globalRole: globalMemberRole });
|
|
|
|
const authAgent = utils.createAgent(app, {
|
|
apiPath: 'public',
|
|
auth: true,
|
|
user: owner,
|
|
version: 1,
|
|
});
|
|
|
|
const workflow = await testDb.createWorkflowWithTrigger({}, member);
|
|
|
|
await authAgent.post(`/workflows/${workflow.id}/activate`);
|
|
|
|
const workflowDeactivationResponse = await authAgent.post(`/workflows/${workflow.id}/deactivate`);
|
|
|
|
const { id, connections, active, staticData, nodes, settings, name, createdAt, updatedAt } =
|
|
workflowDeactivationResponse.body;
|
|
|
|
expect(id).toEqual(workflow.id);
|
|
expect(name).toEqual(workflow.name);
|
|
expect(connections).toEqual(workflow.connections);
|
|
expect(active).toBe(false);
|
|
expect(staticData).toEqual(workflow.staticData);
|
|
expect(nodes).toEqual(workflow.nodes);
|
|
expect(settings).toEqual(workflow.settings);
|
|
expect(createdAt).toBeDefined();
|
|
expect(updatedAt).toBeDefined();
|
|
|
|
// check whether the workflow is deactivated in the database
|
|
const sharedOwnerWorkflow = await Db.collections.SharedWorkflow.findOne({
|
|
where: {
|
|
user: owner,
|
|
workflow,
|
|
},
|
|
});
|
|
|
|
expect(sharedOwnerWorkflow).toBeUndefined();
|
|
|
|
const sharedWorkflow = await Db.collections.SharedWorkflow.findOne({
|
|
where: {
|
|
user: member,
|
|
workflow,
|
|
},
|
|
relations: ['workflow'],
|
|
});
|
|
|
|
expect(sharedWorkflow?.workflow.active).toBe(false);
|
|
|
|
expect(await workflowRunner.isActive(workflow.id.toString())).toBe(false);
|
|
});
|
|
|
|
test('POST /workflows should fail due to missing API Key', async () => {
|
|
const owner = await testDb.createUser({ globalRole: globalOwnerRole });
|
|
|
|
const authOwnerAgent = utils.createAgent(app, {
|
|
apiPath: 'public',
|
|
auth: true,
|
|
user: owner,
|
|
version: 1,
|
|
});
|
|
|
|
const response = await authOwnerAgent.post('/workflows');
|
|
|
|
expect(response.statusCode).toBe(401);
|
|
});
|
|
|
|
test('POST /workflows should fail due to invalid API Key', async () => {
|
|
const owner = await testDb.createUser({ globalRole: globalOwnerRole, apiKey: randomApiKey() });
|
|
|
|
owner.apiKey = 'abcXYZ';
|
|
|
|
const authOwnerAgent = utils.createAgent(app, {
|
|
apiPath: 'public',
|
|
auth: true,
|
|
user: owner,
|
|
version: 1,
|
|
});
|
|
|
|
const response = await authOwnerAgent.post('/workflows');
|
|
|
|
expect(response.statusCode).toBe(401);
|
|
});
|
|
|
|
test('POST /workflows should fail due to invalid body', async () => {
|
|
const owner = await testDb.createUser({ globalRole: globalOwnerRole, apiKey: randomApiKey() });
|
|
|
|
const authOwnerAgent = utils.createAgent(app, {
|
|
apiPath: 'public',
|
|
auth: true,
|
|
user: owner,
|
|
version: 1,
|
|
});
|
|
|
|
const response = await authOwnerAgent.post('/workflows').send({});
|
|
|
|
expect(response.statusCode).toBe(400);
|
|
});
|
|
|
|
test('POST /workflows should create workflow', async () => {
|
|
const member = await testDb.createUser({ globalRole: globalMemberRole, apiKey: randomApiKey() });
|
|
|
|
const authAgent = utils.createAgent(app, {
|
|
apiPath: 'public',
|
|
auth: true,
|
|
user: member,
|
|
version: 1,
|
|
});
|
|
|
|
const payload = {
|
|
name: 'testing',
|
|
nodes: [
|
|
{
|
|
parameters: {},
|
|
name: 'Start',
|
|
type: 'n8n-nodes-base.start',
|
|
typeVersion: 1,
|
|
position: [240, 300],
|
|
},
|
|
],
|
|
connections: {},
|
|
staticData: null,
|
|
settings: {
|
|
saveExecutionProgress: true,
|
|
saveManualExecutions: true,
|
|
saveDataErrorExecution: 'all',
|
|
saveDataSuccessExecution: 'all',
|
|
executionTimeout: 3600,
|
|
timezone: 'America/New_York',
|
|
},
|
|
};
|
|
|
|
const response = await authAgent.post('/workflows').send(payload);
|
|
|
|
expect(response.statusCode).toBe(200);
|
|
|
|
const { id, name, nodes, connections, staticData, active, settings, createdAt, updatedAt } =
|
|
response.body;
|
|
|
|
expect(id).toBeDefined();
|
|
expect(name).toBe(payload.name);
|
|
expect(connections).toEqual(payload.connections);
|
|
expect(settings).toEqual(payload.settings);
|
|
expect(staticData).toEqual(payload.staticData);
|
|
expect(nodes).toEqual(payload.nodes);
|
|
expect(active).toBe(false);
|
|
expect(createdAt).toBeDefined();
|
|
expect(updatedAt).toEqual(createdAt);
|
|
|
|
// check if created workflow in DB
|
|
const sharedWorkflow = await Db.collections.SharedWorkflow.findOne({
|
|
where: {
|
|
user: member,
|
|
workflow: response.body,
|
|
},
|
|
relations: ['workflow', 'role'],
|
|
});
|
|
|
|
expect(sharedWorkflow?.workflow.name).toBe(name);
|
|
expect(sharedWorkflow?.workflow.createdAt.toISOString()).toBe(createdAt);
|
|
expect(sharedWorkflow?.role).toEqual(workflowOwnerRole);
|
|
});
|
|
|
|
test('PUT /workflows/:id should fail due to missing API Key', async () => {
|
|
const owner = await testDb.createUser({ globalRole: globalOwnerRole });
|
|
|
|
const authOwnerAgent = utils.createAgent(app, {
|
|
apiPath: 'public',
|
|
auth: true,
|
|
user: owner,
|
|
version: 1,
|
|
});
|
|
|
|
const response = await authOwnerAgent.put(`/workflows/1`);
|
|
|
|
expect(response.statusCode).toBe(401);
|
|
});
|
|
|
|
test('PUT /workflows/:id should fail due to invalid API Key', async () => {
|
|
const owner = await testDb.createUser({ globalRole: globalOwnerRole, apiKey: randomApiKey() });
|
|
|
|
owner.apiKey = 'abcXYZ';
|
|
|
|
const authOwnerAgent = utils.createAgent(app, {
|
|
apiPath: 'public',
|
|
auth: true,
|
|
user: owner,
|
|
version: 1,
|
|
});
|
|
|
|
const response = await authOwnerAgent.put(`/workflows/1`).send({});
|
|
|
|
expect(response.statusCode).toBe(401);
|
|
});
|
|
|
|
test('PUT /workflows/:id should fail due to non-existing workflow', async () => {
|
|
const owner = await testDb.createUser({ globalRole: globalOwnerRole, apiKey: randomApiKey() });
|
|
|
|
const authOwnerAgent = utils.createAgent(app, {
|
|
apiPath: 'public',
|
|
auth: true,
|
|
user: owner,
|
|
version: 1,
|
|
});
|
|
|
|
const response = await authOwnerAgent.put(`/workflows/1`).send({
|
|
name: 'testing',
|
|
nodes: [
|
|
{
|
|
parameters: {},
|
|
name: 'Start',
|
|
type: 'n8n-nodes-base.start',
|
|
typeVersion: 1,
|
|
position: [240, 300],
|
|
},
|
|
],
|
|
connections: {},
|
|
staticData: null,
|
|
settings: {
|
|
saveExecutionProgress: true,
|
|
saveManualExecutions: true,
|
|
saveDataErrorExecution: 'all',
|
|
saveDataSuccessExecution: 'all',
|
|
executionTimeout: 3600,
|
|
timezone: 'America/New_York',
|
|
},
|
|
});
|
|
|
|
expect(response.statusCode).toBe(404);
|
|
});
|
|
|
|
test('PUT /workflows/:id should fail due to invalid body', async () => {
|
|
const owner = await testDb.createUser({ globalRole: globalOwnerRole, apiKey: randomApiKey() });
|
|
|
|
const authOwnerAgent = utils.createAgent(app, {
|
|
apiPath: 'public',
|
|
auth: true,
|
|
user: owner,
|
|
version: 1,
|
|
});
|
|
|
|
const response = await authOwnerAgent.put(`/workflows/1`).send({
|
|
nodes: [
|
|
{
|
|
parameters: {},
|
|
name: 'Start',
|
|
type: 'n8n-nodes-base.start',
|
|
typeVersion: 1,
|
|
position: [240, 300],
|
|
},
|
|
],
|
|
connections: {},
|
|
staticData: null,
|
|
settings: {
|
|
saveExecutionProgress: true,
|
|
saveManualExecutions: true,
|
|
saveDataErrorExecution: 'all',
|
|
saveDataSuccessExecution: 'all',
|
|
executionTimeout: 3600,
|
|
timezone: 'America/New_York',
|
|
},
|
|
});
|
|
|
|
expect(response.statusCode).toBe(400);
|
|
});
|
|
|
|
test('PUT /workflows/:id should update workflow', async () => {
|
|
const member = await testDb.createUser({ globalRole: globalOwnerRole, apiKey: randomApiKey() });
|
|
|
|
const workflow = await testDb.createWorkflow({}, member);
|
|
|
|
const authAgent = utils.createAgent(app, {
|
|
apiPath: 'public',
|
|
auth: true,
|
|
user: member,
|
|
version: 1,
|
|
});
|
|
|
|
const payload = {
|
|
name: 'name updated',
|
|
nodes: [
|
|
{
|
|
parameters: {},
|
|
name: 'Start',
|
|
type: 'n8n-nodes-base.start',
|
|
typeVersion: 1,
|
|
position: [240, 300],
|
|
},
|
|
{
|
|
parameters: {},
|
|
name: 'Cron',
|
|
type: 'n8n-nodes-base.cron',
|
|
typeVersion: 1,
|
|
position: [400, 300],
|
|
},
|
|
],
|
|
connections: {},
|
|
staticData: '{"id":1}',
|
|
settings: {
|
|
saveExecutionProgress: false,
|
|
saveManualExecutions: false,
|
|
saveDataErrorExecution: 'all',
|
|
saveDataSuccessExecution: 'all',
|
|
executionTimeout: 3600,
|
|
timezone: 'America/New_York',
|
|
},
|
|
};
|
|
|
|
const response = await authAgent.put(`/workflows/${workflow.id}`).send(payload);
|
|
|
|
const { id, name, nodes, connections, staticData, active, settings, createdAt, updatedAt } =
|
|
response.body;
|
|
|
|
expect(response.statusCode).toBe(200);
|
|
|
|
expect(id).toBe(workflow.id);
|
|
expect(name).toBe(payload.name);
|
|
expect(connections).toEqual(payload.connections);
|
|
expect(settings).toEqual(payload.settings);
|
|
expect(staticData).toMatchObject(JSON.parse(payload.staticData));
|
|
expect(nodes).toEqual(payload.nodes);
|
|
expect(active).toBe(false);
|
|
expect(createdAt).toBe(workflow.createdAt.toISOString());
|
|
expect(updatedAt).not.toBe(workflow.updatedAt.toISOString());
|
|
|
|
// check updated workflow in DB
|
|
const sharedWorkflow = await Db.collections.SharedWorkflow.findOne({
|
|
where: {
|
|
user: member,
|
|
workflow: response.body,
|
|
},
|
|
relations: ['workflow'],
|
|
});
|
|
|
|
expect(sharedWorkflow?.workflow.name).toBe(payload.name);
|
|
expect(sharedWorkflow?.workflow.updatedAt.getTime()).toBeGreaterThan(
|
|
workflow.updatedAt.getTime(),
|
|
);
|
|
});
|
|
|
|
test('PUT /workflows/:id should update non-owned workflow if owner', async () => {
|
|
const owner = await testDb.createUser({ globalRole: globalOwnerRole, apiKey: randomApiKey() });
|
|
const member = await testDb.createUser({ globalRole: globalMemberRole });
|
|
|
|
const workflow = await testDb.createWorkflow({}, member);
|
|
|
|
const authAgent = utils.createAgent(app, {
|
|
apiPath: 'public',
|
|
auth: true,
|
|
user: owner,
|
|
version: 1,
|
|
});
|
|
|
|
const payload = {
|
|
name: 'name owner updated',
|
|
nodes: [
|
|
{
|
|
parameters: {},
|
|
name: 'Start',
|
|
type: 'n8n-nodes-base.start',
|
|
typeVersion: 1,
|
|
position: [240, 300],
|
|
},
|
|
{
|
|
parameters: {},
|
|
name: 'Cron',
|
|
type: 'n8n-nodes-base.cron',
|
|
typeVersion: 1,
|
|
position: [400, 300],
|
|
},
|
|
],
|
|
connections: {},
|
|
staticData: '{"id":1}',
|
|
settings: {
|
|
saveExecutionProgress: false,
|
|
saveManualExecutions: false,
|
|
saveDataErrorExecution: 'all',
|
|
saveDataSuccessExecution: 'all',
|
|
executionTimeout: 3600,
|
|
timezone: 'America/New_York',
|
|
},
|
|
};
|
|
|
|
const response = await authAgent.put(`/workflows/${workflow.id}`).send(payload);
|
|
|
|
const { id, name, nodes, connections, staticData, active, settings, createdAt, updatedAt } =
|
|
response.body;
|
|
|
|
expect(response.statusCode).toBe(200);
|
|
|
|
expect(id).toBe(workflow.id);
|
|
expect(name).toBe(payload.name);
|
|
expect(connections).toEqual(payload.connections);
|
|
expect(settings).toEqual(payload.settings);
|
|
expect(staticData).toMatchObject(JSON.parse(payload.staticData));
|
|
expect(nodes).toEqual(payload.nodes);
|
|
expect(active).toBe(false);
|
|
expect(createdAt).toBe(workflow.createdAt.toISOString());
|
|
expect(updatedAt).not.toBe(workflow.updatedAt.toISOString());
|
|
|
|
// check updated workflow in DB
|
|
const sharedOwnerWorkflow = await Db.collections.SharedWorkflow.findOne({
|
|
where: {
|
|
user: owner,
|
|
workflow: response.body,
|
|
},
|
|
});
|
|
|
|
expect(sharedOwnerWorkflow).toBeUndefined();
|
|
|
|
const sharedWorkflow = await Db.collections.SharedWorkflow.findOne({
|
|
where: {
|
|
user: member,
|
|
workflow: response.body,
|
|
},
|
|
relations: ['workflow', 'role'],
|
|
});
|
|
|
|
expect(sharedWorkflow?.workflow.name).toBe(payload.name);
|
|
expect(sharedWorkflow?.workflow.updatedAt.getTime()).toBeGreaterThan(
|
|
workflow.updatedAt.getTime(),
|
|
);
|
|
expect(sharedWorkflow?.role).toEqual(workflowOwnerRole);
|
|
});
|