2017-04-10 11:59:45 -07:00
// Copyright 2017 The Prometheus Authors
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
2017-01-02 01:34:55 -08:00
package tsdb
import (
2018-12-05 08:34:42 -08:00
"context"
2020-02-25 03:12:03 -08:00
"crypto/rand"
2023-11-16 10:54:41 -08:00
"errors"
2018-03-15 04:26:11 -07:00
"fmt"
2017-10-09 06:21:46 -07:00
"io"
2017-01-02 01:34:55 -08:00
"os"
2017-01-02 05:41:13 -08:00
"path/filepath"
2017-01-03 06:43:26 -08:00
"time"
2017-01-02 01:34:55 -08:00
2021-06-11 09:17:59 -07:00
"github.com/go-kit/log"
"github.com/go-kit/log/level"
2017-02-27 01:46:15 -08:00
"github.com/oklog/ulid"
2017-01-03 06:43:26 -08:00
"github.com/prometheus/client_golang/prometheus"
2023-07-02 15:16:26 -07:00
"golang.org/x/exp/slices"
2020-10-22 02:00:08 -07:00
2020-02-06 07:58:38 -08:00
"github.com/prometheus/prometheus/storage"
2019-08-13 01:34:14 -07:00
"github.com/prometheus/prometheus/tsdb/chunkenc"
"github.com/prometheus/prometheus/tsdb/chunks"
tsdb_errors "github.com/prometheus/prometheus/tsdb/errors"
"github.com/prometheus/prometheus/tsdb/fileutil"
"github.com/prometheus/prometheus/tsdb/index"
2019-09-19 02:15:41 -07:00
"github.com/prometheus/prometheus/tsdb/tombstones"
2017-01-02 01:34:55 -08:00
)
2018-03-15 04:26:11 -07:00
// ExponentialBlockRanges returns the time ranges based on the stepSize.
2017-07-07 04:46:41 -07:00
func ExponentialBlockRanges ( minSize int64 , steps , stepSize int ) [ ] int64 {
ranges := make ( [ ] int64 , 0 , steps )
curRange := minSize
for i := 0 ; i < steps ; i ++ {
ranges = append ( ranges , curRange )
2023-04-09 00:08:40 -07:00
curRange *= int64 ( stepSize )
2017-07-07 04:46:41 -07:00
}
return ranges
}
2017-03-02 05:32:09 -08:00
// Compactor provides compaction against an underlying storage
// of time series data.
2017-03-02 00:13:29 -08:00
type Compactor interface {
2019-02-26 11:50:37 -08:00
// Plan returns a set of directories that can be compacted concurrently.
// The directories can be overlapping.
2017-03-02 05:32:09 -08:00
// Results returned when compactions are in progress are undefined.
2017-08-09 02:10:29 -07:00
Plan ( dir string ) ( [ ] string , error )
2017-03-02 00:13:29 -08:00
2017-03-02 05:32:09 -08:00
// Write persists a Block into a directory.
2019-01-18 00:35:16 -08:00
// No Block is written when resulting Block has 0 samples, and returns empty ulid.ULID{}.
2018-06-27 06:47:11 -07:00
Write ( dest string , b BlockReader , mint , maxt int64 , parent * BlockMeta ) ( ulid . ULID , error )
2017-03-02 00:13:29 -08:00
2017-03-02 05:32:09 -08:00
// Compact runs compaction against the provided directories. Must
// only be called concurrently with results of Plan().
2018-11-15 04:20:54 -08:00
// Can optionally pass a list of already open blocks,
// to avoid having to reopen them.
2019-01-18 00:35:16 -08:00
// When resulting Block has 0 samples
// * No block is written.
// * The source dirs are marked Deletable.
// * Returns empty ulid.ULID{}.
2018-11-15 04:20:54 -08:00
Compact ( dest string , dirs [ ] string , open [ ] * Block ) ( ulid . ULID , error )
2017-03-02 00:13:29 -08:00
}
2017-08-09 02:10:29 -07:00
// LeveledCompactor implements the Compactor interface.
type LeveledCompactor struct {
2024-01-11 23:56:44 -08:00
metrics * CompactorMetrics
logger log . Logger
ranges [ ] int64
chunkPool chunkenc . Pool
ctx context . Context
maxBlockChunkSegmentSize int64
mergeFunc storage . VerticalChunkSeriesMergeFunc
postingsEncoder index . PostingsEncoder
enableOverlappingCompaction bool
2017-01-02 01:34:55 -08:00
}
2023-04-03 23:31:49 -07:00
type CompactorMetrics struct {
Ran prometheus . Counter
PopulatingBlocks prometheus . Gauge
OverlappingBlocks prometheus . Counter
Duration prometheus . Histogram
ChunkSize prometheus . Histogram
ChunkSamples prometheus . Histogram
ChunkRange prometheus . Histogram
2017-01-03 06:43:26 -08:00
}
2023-04-03 23:31:49 -07:00
func newCompactorMetrics ( r prometheus . Registerer ) * CompactorMetrics {
m := & CompactorMetrics { }
2017-01-03 06:43:26 -08:00
2023-04-03 23:31:49 -07:00
m . Ran = prometheus . NewCounter ( prometheus . CounterOpts {
2018-09-18 10:17:41 -07:00
Name : "prometheus_tsdb_compactions_total" ,
2017-01-06 02:40:09 -08:00
Help : "Total number of compactions that were executed for the partition." ,
2017-01-03 06:43:26 -08:00
} )
2023-04-03 23:31:49 -07:00
m . PopulatingBlocks = prometheus . NewGauge ( prometheus . GaugeOpts {
2018-12-07 07:49:23 -08:00
Name : "prometheus_tsdb_compaction_populating_block" ,
Help : "Set to 1 when a block is currently being written to the disk." ,
} )
2023-04-03 23:31:49 -07:00
m . OverlappingBlocks = prometheus . NewCounter ( prometheus . CounterOpts {
2019-02-14 05:29:41 -08:00
Name : "prometheus_tsdb_vertical_compactions_total" ,
Help : "Total number of compactions done on overlapping blocks." ,
} )
2023-04-03 23:31:49 -07:00
m . Duration = prometheus . NewHistogram ( prometheus . HistogramOpts {
2018-09-18 10:17:41 -07:00
Name : "prometheus_tsdb_compaction_duration_seconds" ,
2018-02-05 00:36:18 -08:00
Help : "Duration of compaction runs" ,
2021-01-25 10:12:18 -08:00
Buckets : prometheus . ExponentialBuckets ( 1 , 2 , 14 ) ,
2017-09-01 07:10:10 -07:00
} )
2023-04-03 23:31:49 -07:00
m . ChunkSize = prometheus . NewHistogram ( prometheus . HistogramOpts {
2018-09-18 10:17:41 -07:00
Name : "prometheus_tsdb_compaction_chunk_size_bytes" ,
2017-09-01 07:10:10 -07:00
Help : "Final size of chunks on their first compaction" ,
Buckets : prometheus . ExponentialBuckets ( 32 , 1.5 , 12 ) ,
} )
2023-04-03 23:31:49 -07:00
m . ChunkSamples = prometheus . NewHistogram ( prometheus . HistogramOpts {
2018-09-18 10:17:41 -07:00
Name : "prometheus_tsdb_compaction_chunk_samples" ,
2017-09-01 07:10:10 -07:00
Help : "Final number of samples on their first compaction" ,
Buckets : prometheus . ExponentialBuckets ( 4 , 1.5 , 12 ) ,
} )
2023-04-03 23:31:49 -07:00
m . ChunkRange = prometheus . NewHistogram ( prometheus . HistogramOpts {
2018-09-18 10:17:41 -07:00
Name : "prometheus_tsdb_compaction_chunk_range_seconds" ,
2017-09-01 07:10:10 -07:00
Help : "Final time range of chunks on their first compaction" ,
Buckets : prometheus . ExponentialBuckets ( 100 , 4 , 10 ) ,
2017-01-03 06:43:26 -08:00
} )
2017-01-06 02:40:09 -08:00
if r != nil {
r . MustRegister (
2023-04-03 23:31:49 -07:00
m . Ran ,
m . PopulatingBlocks ,
m . OverlappingBlocks ,
m . Duration ,
m . ChunkRange ,
m . ChunkSamples ,
m . ChunkSize ,
2017-01-06 02:40:09 -08:00
)
}
2017-01-03 06:43:26 -08:00
return m
}
2024-01-08 01:48:27 -08:00
type LeveledCompactorOptions struct {
// PE specifies the postings encoder. It is called when compactor is writing out the postings for a label name/value pair during compaction.
// If it is nil then the default encoder is used. At the moment that is the "raw" encoder. See index.EncodePostingsRaw for more.
PE index . PostingsEncoder
// MaxBlockChunkSegmentSize is the max block chunk segment size. If it is 0 then the default chunks.DefaultChunkSegmentSize is used.
MaxBlockChunkSegmentSize int64
// MergeFunc is used for merging series together in vertical compaction. By default storage.NewCompactingChunkSeriesMerger(storage.ChainedSeriesMerge) is used.
MergeFunc storage . VerticalChunkSeriesMergeFunc
2024-01-11 23:56:44 -08:00
// EnableOverlappingCompaction enables compaction of overlapping blocks. In Prometheus it is always enabled.
// It is useful for downstream projects like Mimir, Cortex, Thanos where they have a separate component that does compaction.
EnableOverlappingCompaction bool
2021-04-15 01:55:01 -07:00
}
2021-05-18 09:38:37 -07:00
func NewLeveledCompactorWithChunkSize ( ctx context . Context , r prometheus . Registerer , l log . Logger , ranges [ ] int64 , pool chunkenc . Pool , maxBlockChunkSegmentSize int64 , mergeFunc storage . VerticalChunkSeriesMergeFunc ) ( * LeveledCompactor , error ) {
2024-01-08 01:48:27 -08:00
return NewLeveledCompactorWithOptions ( ctx , r , l , ranges , pool , LeveledCompactorOptions {
2024-01-11 23:56:44 -08:00
MaxBlockChunkSegmentSize : maxBlockChunkSegmentSize ,
MergeFunc : mergeFunc ,
EnableOverlappingCompaction : true ,
2024-01-08 01:48:27 -08:00
} )
}
func NewLeveledCompactor ( ctx context . Context , r prometheus . Registerer , l log . Logger , ranges [ ] int64 , pool chunkenc . Pool , mergeFunc storage . VerticalChunkSeriesMergeFunc ) ( * LeveledCompactor , error ) {
return NewLeveledCompactorWithOptions ( ctx , r , l , ranges , pool , LeveledCompactorOptions {
2024-01-11 23:56:44 -08:00
MergeFunc : mergeFunc ,
EnableOverlappingCompaction : true ,
2024-01-08 01:48:27 -08:00
} )
}
func NewLeveledCompactorWithOptions ( ctx context . Context , r prometheus . Registerer , l log . Logger , ranges [ ] int64 , pool chunkenc . Pool , opts LeveledCompactorOptions ) ( * LeveledCompactor , error ) {
2017-09-01 02:46:46 -07:00
if len ( ranges ) == 0 {
2023-11-14 05:04:31 -08:00
return nil , fmt . Errorf ( "at least one range must be provided" )
2017-08-08 08:35:34 -07:00
}
2017-09-01 02:46:46 -07:00
if pool == nil {
2017-11-30 06:34:49 -08:00
pool = chunkenc . NewPool ( )
2017-01-02 01:34:55 -08:00
}
2019-02-14 05:29:41 -08:00
if l == nil {
l = log . NewNopLogger ( )
}
2024-01-11 02:07:54 -08:00
mergeFunc := opts . MergeFunc
if mergeFunc == nil {
2021-05-18 09:38:37 -07:00
mergeFunc = storage . NewCompactingChunkSeriesMerger ( storage . ChainedSeriesMerge )
}
2024-01-16 03:00:53 -08:00
maxBlockChunkSegmentSize := opts . MaxBlockChunkSegmentSize
if maxBlockChunkSegmentSize == 0 {
2024-01-08 01:48:27 -08:00
maxBlockChunkSegmentSize = chunks . DefaultChunkSegmentSize
}
2024-01-16 03:00:53 -08:00
pe := opts . PE
if pe == nil {
2024-01-08 01:48:27 -08:00
pe = index . EncodePostingsRaw
}
2017-09-01 02:46:46 -07:00
return & LeveledCompactor {
2024-01-11 23:56:44 -08:00
ranges : ranges ,
chunkPool : pool ,
logger : l ,
metrics : newCompactorMetrics ( r ) ,
ctx : ctx ,
maxBlockChunkSegmentSize : maxBlockChunkSegmentSize ,
mergeFunc : mergeFunc ,
postingsEncoder : pe ,
enableOverlappingCompaction : opts . EnableOverlappingCompaction ,
2017-09-01 02:46:46 -07:00
} , nil
2017-01-19 22:58:19 -08:00
}
2017-05-18 07:09:30 -07:00
type dirMeta struct {
dir string
meta * BlockMeta
}
2017-08-09 02:10:29 -07:00
// Plan returns a list of compactable blocks in the provided directory.
func ( c * LeveledCompactor ) Plan ( dir string ) ( [ ] string , error ) {
dirs , err := blockDirs ( dir )
2017-03-02 00:13:29 -08:00
if err != nil {
return nil , err
2017-01-03 06:43:26 -08:00
}
2018-02-28 03:04:55 -08:00
if len ( dirs ) < 1 {
return nil , nil
}
2017-01-17 21:18:32 -08:00
2017-05-18 08:30:52 -07:00
var dms [ ] dirMeta
2017-03-02 00:13:29 -08:00
for _ , dir := range dirs {
2019-06-24 08:42:29 -07:00
meta , _ , err := readMetaFile ( dir )
2017-03-02 00:13:29 -08:00
if err != nil {
return nil , err
2017-01-06 04:53:05 -08:00
}
2017-09-01 02:46:46 -07:00
dms = append ( dms , dirMeta { dir , meta } )
2017-03-02 00:13:29 -08:00
}
2017-08-13 01:41:08 -07:00
return c . plan ( dms )
}
func ( c * LeveledCompactor ) plan ( dms [ ] dirMeta ) ( [ ] string , error ) {
2023-09-21 13:53:51 -07:00
slices . SortFunc ( dms , func ( a , b dirMeta ) int {
2023-10-16 07:23:26 -07:00
switch {
case a . meta . MinTime < b . meta . MinTime :
return - 1
case a . meta . MinTime > b . meta . MinTime :
return 1
default :
return 0
}
2017-09-01 02:46:46 -07:00
} )
2017-01-30 00:42:38 -08:00
2019-02-14 05:29:41 -08:00
res := c . selectOverlappingDirs ( dms )
if len ( res ) > 0 {
return res , nil
}
// No overlapping blocks, do compaction the usual way.
2018-03-13 07:11:02 -07:00
// We do not include a recently created block with max(minTime), so the block which was just created from WAL.
// This gives users a window of a full block size to piece-wise backup new data without having to care about data overlap.
dms = dms [ : len ( dms ) - 1 ]
2017-08-09 02:10:29 -07:00
for _ , dm := range c . selectDirs ( dms ) {
res = append ( res , dm . dir )
2017-01-06 04:53:05 -08:00
}
2017-08-09 02:10:29 -07:00
if len ( res ) > 0 {
return res , nil
2017-07-12 09:16:12 -07:00
}
2019-01-18 00:35:16 -08:00
// Compact any blocks with big enough time range that have >5% tombstones.
2017-07-12 09:16:12 -07:00
for i := len ( dms ) - 1 ; i >= 0 ; i -- {
meta := dms [ i ] . meta
2017-09-01 02:46:46 -07:00
if meta . MaxTime - meta . MinTime < c . ranges [ len ( c . ranges ) / 2 ] {
2020-11-25 05:03:30 -08:00
// If the block is entirely deleted, then we don't care about the block being big enough.
// TODO: This is assuming single tombstone is for distinct series, which might be no true.
if meta . Stats . NumTombstones > 0 && meta . Stats . NumTombstones >= meta . Stats . NumSeries {
return [ ] string { dms [ i ] . dir } , nil
}
2017-07-12 09:16:12 -07:00
break
}
2017-09-01 02:46:46 -07:00
if float64 ( meta . Stats . NumTombstones ) / float64 ( meta . Stats . NumSeries + 1 ) > 0.05 {
2017-08-09 02:10:29 -07:00
return [ ] string { dms [ i ] . dir } , nil
2017-07-12 09:16:12 -07:00
}
}
return nil , nil
2017-07-06 12:29:26 -07:00
}
2017-08-03 09:33:13 -07:00
// selectDirs returns the dir metas that should be compacted into a single new block.
// If only a single block range is configured, the result is always nil.
2017-08-09 02:10:29 -07:00
func ( c * LeveledCompactor ) selectDirs ( ds [ ] dirMeta ) [ ] dirMeta {
2017-09-01 02:46:46 -07:00
if len ( c . ranges ) < 2 || len ( ds ) < 1 {
2017-07-07 04:46:41 -07:00
return nil
}
2017-08-03 09:33:13 -07:00
highTime := ds [ len ( ds ) - 1 ] . meta . MinTime
2017-07-06 12:29:26 -07:00
2017-09-01 02:46:46 -07:00
for _ , iv := range c . ranges [ 1 : ] {
2017-08-03 09:33:13 -07:00
parts := splitByRange ( ds , iv )
if len ( parts ) == 0 {
continue
2017-01-03 06:43:26 -08:00
}
2017-01-30 00:42:38 -08:00
2017-11-21 03:15:02 -08:00
Outer :
2017-08-03 09:33:13 -07:00
for _ , p := range parts {
2018-03-15 04:26:11 -07:00
// Do not select the range if it has a block whose compaction failed.
2017-11-21 03:15:02 -08:00
for _ , dm := range p {
if dm . meta . Compaction . Failed {
continue Outer
}
}
2017-08-03 09:33:13 -07:00
mint := p [ 0 ] . meta . MinTime
maxt := p [ len ( p ) - 1 ] . meta . MaxTime
// Pick the range of blocks if it spans the full range (potentially with gaps)
// or is before the most recent block.
// This ensures we don't compact blocks prematurely when another one of the same
// size still fits in the range.
if ( maxt - mint == iv || maxt <= highTime ) && len ( p ) > 1 {
return p
}
2017-07-06 12:29:26 -07:00
}
}
2017-08-03 09:33:13 -07:00
return nil
2017-01-04 12:11:15 -08:00
}
2019-04-08 05:27:06 -07:00
// selectOverlappingDirs returns all dirs with overlapping time ranges.
// It expects sorted input by mint and returns the overlapping dirs in the same order as received.
2019-02-14 05:29:41 -08:00
func ( c * LeveledCompactor ) selectOverlappingDirs ( ds [ ] dirMeta ) [ ] string {
2024-01-11 23:56:44 -08:00
if ! c . enableOverlappingCompaction {
return nil
}
2019-02-14 05:29:41 -08:00
if len ( ds ) < 2 {
return nil
}
var overlappingDirs [ ] string
globalMaxt := ds [ 0 ] . meta . MaxTime
for i , d := range ds [ 1 : ] {
if d . meta . MinTime < globalMaxt {
if len ( overlappingDirs ) == 0 { // When it is the first overlap, need to add the last one as well.
overlappingDirs = append ( overlappingDirs , ds [ i ] . dir )
}
overlappingDirs = append ( overlappingDirs , d . dir )
2019-04-08 05:27:06 -07:00
} else if len ( overlappingDirs ) > 0 {
break
2019-02-14 05:29:41 -08:00
}
if d . meta . MaxTime > globalMaxt {
globalMaxt = d . meta . MaxTime
}
}
return overlappingDirs
}
2017-08-03 09:33:13 -07:00
// splitByRange splits the directories by the time range. The range sequence starts at 0.
//
// For example, if we have blocks [0-10, 10-20, 50-60, 90-100] and the split range tr is 30
// it returns [0-10, 10-20], [50-60], [90-100].
2017-07-06 12:29:26 -07:00
func splitByRange ( ds [ ] dirMeta , tr int64 ) [ ] [ ] dirMeta {
2017-07-07 04:46:41 -07:00
var splitDirs [ ] [ ] dirMeta
2017-07-06 12:29:26 -07:00
2017-07-07 04:46:41 -07:00
for i := 0 ; i < len ( ds ) ; {
2017-08-03 09:33:13 -07:00
var (
group [ ] dirMeta
t0 int64
m = ds [ i ] . meta
)
2017-07-07 04:46:41 -07:00
// Compute start of aligned time range of size tr closest to the current block's start.
2017-07-13 07:13:59 -07:00
if m . MinTime >= 0 {
t0 = tr * ( m . MinTime / tr )
} else {
t0 = tr * ( ( m . MinTime - tr + 1 ) / tr )
}
// Skip blocks that don't fall into the range. This can happen via mis-alignment or
// by being the multiple of the intended range.
2019-03-18 07:14:10 -07:00
if m . MaxTime > t0 + tr {
2017-07-13 07:13:59 -07:00
i ++
continue
}
2017-01-19 10:45:52 -08:00
2017-07-07 04:46:41 -07:00
// Add all dirs to the current group that are within [t0, t0+tr].
for ; i < len ( ds ) ; i ++ {
2017-07-13 07:13:59 -07:00
// Either the block falls into the next range or doesn't fit at all (checked above).
2019-03-18 07:14:10 -07:00
if ds [ i ] . meta . MaxTime > t0 + tr {
2017-07-07 04:46:41 -07:00
break
2017-07-06 12:29:26 -07:00
}
2017-07-07 04:46:41 -07:00
group = append ( group , ds [ i ] )
2017-01-19 10:45:52 -08:00
}
2017-07-06 12:29:26 -07:00
2017-07-07 04:46:41 -07:00
if len ( group ) > 0 {
splitDirs = append ( splitDirs , group )
}
2017-07-06 12:29:26 -07:00
}
return splitDirs
2017-01-03 01:09:20 -08:00
}
2020-11-09 08:51:25 -08:00
// CompactBlockMetas merges many block metas into one, combining it's source blocks together
2022-01-05 01:40:00 -08:00
// and adjusting compaction level. Min/Max time of result block meta covers all input blocks.
2020-11-09 08:51:25 -08:00
func CompactBlockMetas ( uid ulid . ULID , blocks ... * BlockMeta ) * BlockMeta {
2017-08-28 15:39:17 -07:00
res := & BlockMeta {
2022-01-05 01:40:00 -08:00
ULID : uid ,
2017-08-28 15:39:17 -07:00
}
2017-01-28 23:11:47 -08:00
2017-06-07 00:52:20 -07:00
sources := map [ ulid . ULID ] struct { } { }
2022-01-05 01:40:00 -08:00
mint := blocks [ 0 ] . MinTime
maxt := blocks [ 0 ] . MaxTime
2017-01-03 06:43:26 -08:00
for _ , b := range blocks {
2022-01-05 01:40:00 -08:00
if b . MinTime < mint {
mint = b . MinTime
}
2019-02-14 05:29:41 -08:00
if b . MaxTime > maxt {
maxt = b . MaxTime
}
2017-08-09 02:10:29 -07:00
if b . Compaction . Level > res . Compaction . Level {
res . Compaction . Level = b . Compaction . Level
2017-06-07 00:52:20 -07:00
}
for _ , s := range b . Compaction . Sources {
sources [ s ] = struct { } { }
}
2018-06-27 06:47:11 -07:00
res . Compaction . Parents = append ( res . Compaction . Parents , BlockDesc {
ULID : b . ULID ,
MinTime : b . MinTime ,
MaxTime : b . MaxTime ,
} )
2017-01-02 01:34:55 -08:00
}
2017-08-09 02:10:29 -07:00
res . Compaction . Level ++
2017-06-07 00:52:20 -07:00
for s := range sources {
res . Compaction . Sources = append ( res . Compaction . Sources , s )
}
2023-09-21 13:53:51 -07:00
slices . SortFunc ( res . Compaction . Sources , func ( a , b ulid . ULID ) int {
return a . Compare ( b )
2017-06-07 00:52:20 -07:00
} )
2022-01-05 01:40:00 -08:00
res . MinTime = mint
2019-02-14 05:29:41 -08:00
res . MaxTime = maxt
2017-01-03 06:43:26 -08:00
return res
}
2017-01-02 01:34:55 -08:00
2017-08-09 02:10:29 -07:00
// Compact creates a new block in the compactor's directory from the blocks in the
// provided directories.
2018-11-15 04:20:54 -08:00
func ( c * LeveledCompactor ) Compact ( dest string , dirs [ ] string , open [ ] * Block ) ( uid ulid . ULID , err error ) {
2023-04-12 14:18:20 -07:00
return c . CompactWithBlockPopulator ( dest , dirs , open , DefaultBlockPopulator { } )
2023-04-03 23:31:49 -07:00
}
2023-04-12 14:18:20 -07:00
func ( c * LeveledCompactor ) CompactWithBlockPopulator ( dest string , dirs [ ] string , open [ ] * Block , blockPopulator BlockPopulator ) ( uid ulid . ULID , err error ) {
2018-03-15 04:26:11 -07:00
var (
blocks [ ] BlockReader
bs [ ] * Block
metas [ ] * BlockMeta
uids [ ] string
)
2018-11-15 04:20:54 -08:00
start := time . Now ( )
2017-03-02 05:32:09 -08:00
2017-03-02 00:13:29 -08:00
for _ , d := range dirs {
2019-06-24 08:42:29 -07:00
meta , _ , err := readMetaFile ( d )
2017-03-02 00:13:29 -08:00
if err != nil {
2017-12-05 02:49:22 -08:00
return uid , err
2017-03-02 00:13:29 -08:00
}
2017-03-06 00:33:55 -08:00
2018-11-15 04:20:54 -08:00
var b * Block
// Use already open blocks if we can, to avoid
// having the index data in memory twice.
for _ , o := range open {
if meta . ULID == o . Meta ( ) . ULID {
b = o
break
}
}
if b == nil {
var err error
2019-01-16 02:03:52 -08:00
b , err = OpenBlock ( c . logger , d , c . chunkPool )
2018-11-15 04:20:54 -08:00
if err != nil {
return uid , err
}
defer b . Close ( )
2017-08-28 15:39:17 -07:00
}
metas = append ( metas , meta )
2017-03-02 00:13:29 -08:00
blocks = append ( blocks , b )
2017-11-21 03:15:02 -08:00
bs = append ( bs , b )
2018-03-15 04:26:11 -07:00
uids = append ( uids , meta . ULID . String ( ) )
2017-03-02 00:13:29 -08:00
}
2020-02-25 03:12:03 -08:00
uid = ulid . MustNew ( ulid . Now ( ) , rand . Reader )
2017-05-18 07:09:30 -07:00
2020-11-09 08:51:25 -08:00
meta := CompactBlockMetas ( uid , metas ... )
2023-04-12 14:18:20 -07:00
err = c . write ( dest , meta , blockPopulator , blocks ... )
2017-11-21 03:15:02 -08:00
if err == nil {
2019-01-18 00:35:16 -08:00
if meta . Stats . NumSamples == 0 {
for _ , b := range bs {
b . meta . Compaction . Deletable = true
2019-06-24 08:42:29 -07:00
n , err := writeMetaFile ( c . logger , b . dir , & b . meta )
if err != nil {
2019-01-18 00:35:16 -08:00
level . Error ( c . logger ) . Log (
"msg" , "Failed to write 'Deletable' to meta file after compaction" ,
"ulid" , b . meta . ULID ,
)
}
2019-06-24 08:42:29 -07:00
b . numBytesMeta = n
2019-01-18 00:35:16 -08:00
}
uid = ulid . ULID { }
level . Info ( c . logger ) . Log (
"msg" , "compact blocks resulted in empty block" ,
"count" , len ( blocks ) ,
"sources" , fmt . Sprintf ( "%v" , uids ) ,
"duration" , time . Since ( start ) ,
)
} else {
level . Info ( c . logger ) . Log (
"msg" , "compact blocks" ,
"count" , len ( blocks ) ,
"mint" , meta . MinTime ,
"maxt" , meta . MaxTime ,
"ulid" , meta . ULID ,
"sources" , fmt . Sprintf ( "%v" , uids ) ,
"duration" , time . Since ( start ) ,
)
}
2017-12-05 02:49:22 -08:00
return uid , nil
2017-11-21 03:15:02 -08:00
}
2020-10-28 08:24:58 -07:00
errs := tsdb_errors . NewMulti ( err )
2023-03-23 03:10:00 -07:00
if ! errors . Is ( err , context . Canceled ) {
2019-01-24 03:33:12 -08:00
for _ , b := range bs {
if err := b . setCompactionFailed ( ) ; err != nil {
2023-11-16 10:54:41 -08:00
errs . Add ( fmt . Errorf ( "setting compaction failed for block: %s: %w" , b . Dir ( ) , err ) )
2019-01-24 03:33:12 -08:00
}
2017-11-21 03:15:02 -08:00
}
}
2020-10-28 08:24:58 -07:00
return uid , errs . Err ( )
2017-03-02 05:32:09 -08:00
}
2018-06-27 06:47:11 -07:00
func ( c * LeveledCompactor ) Write ( dest string , b BlockReader , mint , maxt int64 , parent * BlockMeta ) ( ulid . ULID , error ) {
2019-01-29 03:23:53 -08:00
start := time . Now ( )
2020-02-25 03:12:03 -08:00
uid := ulid . MustNew ( ulid . Now ( ) , rand . Reader )
2017-05-18 07:09:30 -07:00
2017-08-28 15:39:17 -07:00
meta := & BlockMeta {
ULID : uid ,
MinTime : mint ,
MaxTime : maxt ,
}
meta . Compaction . Level = 1
meta . Compaction . Sources = [ ] ulid . ULID { uid }
2018-06-27 06:47:11 -07:00
if parent != nil {
meta . Compaction . Parents = [ ] BlockDesc {
{ ULID : parent . ULID , MinTime : parent . MinTime , MaxTime : parent . MaxTime } ,
}
}
2023-04-12 14:18:20 -07:00
err := c . write ( dest , meta , DefaultBlockPopulator { } , b )
2018-03-15 04:26:11 -07:00
if err != nil {
return uid , err
}
2019-01-18 00:35:16 -08:00
if meta . Stats . NumSamples == 0 {
2020-10-14 06:29:59 -07:00
level . Info ( c . logger ) . Log (
"msg" , "write block resulted in empty block" ,
"mint" , meta . MinTime ,
"maxt" , meta . MaxTime ,
"duration" , time . Since ( start ) ,
)
2019-01-18 00:35:16 -08:00
return ulid . ULID { } , nil
}
2019-01-29 03:23:53 -08:00
level . Info ( c . logger ) . Log (
"msg" , "write block" ,
"mint" , meta . MinTime ,
"maxt" , meta . MaxTime ,
"ulid" , meta . ULID ,
"duration" , time . Since ( start ) ,
)
2018-03-15 04:26:11 -07:00
return uid , nil
2017-03-02 00:13:29 -08:00
}
2017-09-01 07:10:10 -07:00
// instrumentedChunkWriter is used for level 1 compactions to record statistics
// about compacted chunks.
type instrumentedChunkWriter struct {
ChunkWriter
size prometheus . Histogram
samples prometheus . Histogram
trange prometheus . Histogram
}
2017-11-30 06:34:49 -08:00
func ( w * instrumentedChunkWriter ) WriteChunks ( chunks ... chunks . Meta ) error {
2017-09-01 07:10:10 -07:00
for _ , c := range chunks {
w . size . Observe ( float64 ( len ( c . Chunk . Bytes ( ) ) ) )
w . samples . Observe ( float64 ( c . Chunk . NumSamples ( ) ) )
w . trange . Observe ( float64 ( c . MaxTime - c . MinTime ) )
}
return w . ChunkWriter . WriteChunks ( chunks ... )
}
2017-03-02 05:32:09 -08:00
// write creates a new block that is the union of the provided blocks into dir.
2023-04-12 14:18:20 -07:00
func ( c * LeveledCompactor ) write ( dest string , meta * BlockMeta , blockPopulator BlockPopulator , blocks ... BlockReader ) ( err error ) {
2017-11-21 03:15:02 -08:00
dir := filepath . Join ( dest , meta . ULID . String ( ) )
2020-08-10 22:56:08 -07:00
tmp := dir + tmpForCreationBlockDirSuffix
2019-02-07 00:09:42 -08:00
var closers [ ] io . Closer
2017-03-02 00:13:29 -08:00
defer func ( t time . Time ) {
2020-10-28 08:24:58 -07:00
err = tsdb_errors . NewMulti ( err , tsdb_errors . CloseAll ( closers ) ) . Err ( )
2019-02-06 06:09:42 -08:00
// RemoveAll returns no error when tmp doesn't exist so it is safe to always run it.
if err := os . RemoveAll ( tmp ) ; err != nil {
level . Error ( c . logger ) . Log ( "msg" , "removed tmp folder after failed compaction" , "err" , err . Error ( ) )
}
2023-04-03 23:31:49 -07:00
c . metrics . Ran . Inc ( )
c . metrics . Duration . Observe ( time . Since ( t ) . Seconds ( ) )
2017-03-02 00:13:29 -08:00
} ( time . Now ( ) )
2017-01-03 06:43:26 -08:00
2017-03-02 05:32:09 -08:00
if err = os . RemoveAll ( tmp ) ; err != nil {
2017-02-19 07:04:37 -08:00
return err
2017-01-03 06:43:26 -08:00
}
2017-02-19 07:04:37 -08:00
2021-10-22 01:06:44 -07:00
if err = os . MkdirAll ( tmp , 0 o777 ) ; err != nil {
2017-01-02 01:34:55 -08:00
return err
}
2017-03-02 05:35:06 -08:00
// Populate chunk and index files into temporary directory with
// data of all blocks.
2017-09-01 07:10:10 -07:00
var chunkw ChunkWriter
2021-04-15 01:55:01 -07:00
chunkw , err = chunks . NewWriterWithSegSize ( chunkDir ( tmp ) , c . maxBlockChunkSegmentSize )
2017-02-23 01:50:22 -08:00
if err != nil {
2023-11-16 10:54:41 -08:00
return fmt . Errorf ( "open chunk writer: %w" , err )
2017-02-23 01:50:22 -08:00
}
2019-02-07 00:09:42 -08:00
closers = append ( closers , chunkw )
2017-09-01 07:10:10 -07:00
// Record written chunk sizes on level 1 compactions.
if meta . Compaction . Level == 1 {
chunkw = & instrumentedChunkWriter {
ChunkWriter : chunkw ,
2023-04-03 23:31:49 -07:00
size : c . metrics . ChunkSize ,
samples : c . metrics . ChunkSamples ,
trange : c . metrics . ChunkRange ,
2017-09-01 07:10:10 -07:00
}
}
2024-01-08 01:48:27 -08:00
indexw , err := index . NewWriterWithEncoder ( c . ctx , filepath . Join ( tmp , indexFilename ) , c . postingsEncoder )
2017-02-24 22:24:20 -08:00
if err != nil {
2023-11-16 10:54:41 -08:00
return fmt . Errorf ( "open index writer: %w" , err )
2017-02-24 22:24:20 -08:00
}
2019-02-07 00:09:42 -08:00
closers = append ( closers , indexw )
2017-01-03 06:43:26 -08:00
2023-04-12 14:18:20 -07:00
if err := blockPopulator . PopulateBlock ( c . ctx , c . metrics , c . logger , c . chunkPool , c . mergeFunc , blocks , meta , indexw , chunkw ) ; err != nil {
2023-11-16 10:54:41 -08:00
return fmt . Errorf ( "populate block: %w" , err )
2017-01-03 06:43:26 -08:00
}
2017-05-18 07:09:30 -07:00
2018-12-05 08:34:42 -08:00
select {
case <- c . ctx . Done ( ) :
2019-02-06 04:07:35 -08:00
return c . ctx . Err ( )
2018-12-05 08:34:42 -08:00
default :
}
2018-09-20 22:31:22 -07:00
// We are explicitly closing them here to check for error even
// though these are covered under defer. This is because in Windows,
// you cannot delete these unless they are closed and the defer is to
// make sure they are closed if the function exits due to an error above.
2020-10-28 08:24:58 -07:00
errs := tsdb_errors . NewMulti ( )
2019-02-07 00:09:42 -08:00
for _ , w := range closers {
2020-10-28 08:24:58 -07:00
errs . Add ( w . Close ( ) )
2019-02-06 04:07:35 -08:00
}
2019-02-07 00:09:42 -08:00
closers = closers [ : 0 ] // Avoid closing the writers twice in the defer.
2020-10-28 08:24:58 -07:00
if errs . Err ( ) != nil {
return errs . Err ( )
2017-01-03 06:43:26 -08:00
}
2017-03-02 05:32:09 -08:00
2019-02-06 06:09:42 -08:00
// Populated block is empty, so exit early.
2019-01-18 00:35:16 -08:00
if meta . Stats . NumSamples == 0 {
return nil
}
2019-06-24 08:42:29 -07:00
if _ , err = writeMetaFile ( c . logger , tmp , meta ) ; err != nil {
2023-11-16 10:54:41 -08:00
return fmt . Errorf ( "write merged meta: %w" , err )
2019-01-18 00:35:16 -08:00
}
2017-05-14 02:06:26 -07:00
// Create an empty tombstones file.
2019-09-19 02:15:41 -07:00
if _ , err := tombstones . WriteFile ( c . logger , tmp , tombstones . NewMemTombstones ( ) ) ; err != nil {
2023-11-16 10:54:41 -08:00
return fmt . Errorf ( "write new tombstones file: %w" , err )
2017-05-14 02:06:26 -07:00
}
2017-10-04 01:42:25 -07:00
df , err := fileutil . OpenDir ( tmp )
2017-03-02 05:35:06 -08:00
if err != nil {
2023-11-16 10:54:41 -08:00
return fmt . Errorf ( "open temporary block dir: %w" , err )
2017-03-02 05:35:06 -08:00
}
2017-10-31 07:37:41 -07:00
defer func ( ) {
if df != nil {
df . Close ( )
}
} ( )
2017-06-11 15:05:04 -07:00
2019-04-03 01:16:54 -07:00
if err := df . Sync ( ) ; err != nil {
2023-11-16 10:54:41 -08:00
return fmt . Errorf ( "sync temporary dir file: %w" , err )
2017-03-02 05:35:06 -08:00
}
2017-03-02 05:32:09 -08:00
2018-03-15 04:26:11 -07:00
// Close temp dir before rename block dir (for windows platform).
2017-10-31 07:37:41 -07:00
if err = df . Close ( ) ; err != nil {
2023-11-16 10:54:41 -08:00
return fmt . Errorf ( "close temporary dir: %w" , err )
2017-10-31 07:37:41 -07:00
}
df = nil
2020-11-09 08:51:25 -08:00
// Block successfully written, make it visible in destination dir by moving it from tmp one.
2019-04-26 01:27:36 -07:00
if err := fileutil . Replace ( tmp , dir ) ; err != nil {
2023-11-16 10:54:41 -08:00
return fmt . Errorf ( "rename block dir: %w" , err )
2017-10-04 01:42:25 -07:00
}
2018-03-15 04:26:11 -07:00
2017-01-06 03:37:28 -08:00
return nil
2017-01-03 06:43:26 -08:00
}
2023-04-12 14:18:20 -07:00
type BlockPopulator interface {
2023-04-03 23:31:49 -07:00
PopulateBlock ( ctx context . Context , metrics * CompactorMetrics , logger log . Logger , chunkPool chunkenc . Pool , mergeFunc storage . VerticalChunkSeriesMergeFunc , blocks [ ] BlockReader , meta * BlockMeta , indexw IndexWriter , chunkw ChunkWriter ) error
}
2023-04-12 14:18:20 -07:00
type DefaultBlockPopulator struct { }
2023-04-03 23:31:49 -07:00
// PopulateBlock fills the index and chunk writers with new data gathered as the union
2017-03-02 05:32:09 -08:00
// of the provided blocks. It returns meta information for the new block.
2019-02-14 05:29:41 -08:00
// It expects sorted blocks input by mint.
2023-04-12 14:18:20 -07:00
func ( c DefaultBlockPopulator ) PopulateBlock ( ctx context . Context , metrics * CompactorMetrics , logger log . Logger , chunkPool chunkenc . Pool , mergeFunc storage . VerticalChunkSeriesMergeFunc , blocks [ ] BlockReader , meta * BlockMeta , indexw IndexWriter , chunkw ChunkWriter ) ( err error ) {
2018-10-12 02:45:19 -07:00
if len ( blocks ) == 0 {
return errors . New ( "cannot populate block from no readers" )
}
2017-08-05 04:31:48 -07:00
var (
2020-07-31 08:03:02 -07:00
sets [ ] storage . ChunkSeriesSet
Stream symbols during compaction. (#6468)
Rather than buffer up symbols in RAM, do it one by one
during compaction. Then use the reader's symbol handling
for symbol lookups during the rest of the index write.
There is some slowdown in compaction, due to having to look through a file
rather than a hash lookup. This is noise to the overall cost of compacting
series with thousands of samples though.
benchmark old ns/op new ns/op delta
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=101-4 539917175 675341565 +25.08%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=1001-4 2441815993 2477453524 +1.46%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=2001-4 3978543559 3922909687 -1.40%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=5001-4 8430219716 8586610007 +1.86%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=101-4 1786424591 1909552782 +6.89%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=1001-4 5328998202 6020839950 +12.98%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=2001-4 10085059958 11085278690 +9.92%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=5001-4 25497010155 27018079806 +5.97%
BenchmarkCompactionFromHead/labelnames=1,labelvalues=100000-4 2427391406 2817217987 +16.06%
BenchmarkCompactionFromHead/labelnames=10,labelvalues=10000-4 2592965497 2538805050 -2.09%
BenchmarkCompactionFromHead/labelnames=100,labelvalues=1000-4 2437388343 2668012858 +9.46%
BenchmarkCompactionFromHead/labelnames=1000,labelvalues=100-4 2317095324 2787423966 +20.30%
BenchmarkCompactionFromHead/labelnames=10000,labelvalues=10-4 2600239857 2096973860 -19.35%
benchmark old allocs new allocs delta
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=101-4 500851 470794 -6.00%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=1001-4 821527 791451 -3.66%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=2001-4 1141562 1111508 -2.63%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=5001-4 2141576 2111504 -1.40%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=101-4 871466 841424 -3.45%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=1001-4 1941428 1911415 -1.55%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=2001-4 3071573 3041510 -0.98%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=5001-4 6771648 6741509 -0.45%
BenchmarkCompactionFromHead/labelnames=1,labelvalues=100000-4 731493 824888 +12.77%
BenchmarkCompactionFromHead/labelnames=10,labelvalues=10000-4 793918 887311 +11.76%
BenchmarkCompactionFromHead/labelnames=100,labelvalues=1000-4 811842 905204 +11.50%
BenchmarkCompactionFromHead/labelnames=1000,labelvalues=100-4 832244 925081 +11.16%
BenchmarkCompactionFromHead/labelnames=10000,labelvalues=10-4 921553 1019162 +10.59%
benchmark old bytes new bytes delta
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=101-4 40532648 35698276 -11.93%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=1001-4 60340216 53409568 -11.49%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=2001-4 81087336 72065552 -11.13%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=5001-4 142485576 120878544 -15.16%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=101-4 208661368 203831136 -2.31%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=1001-4 347345904 340484696 -1.98%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=2001-4 585185856 576244648 -1.53%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=5001-4 1357641792 1358966528 +0.10%
BenchmarkCompactionFromHead/labelnames=1,labelvalues=100000-4 126486664 119666744 -5.39%
BenchmarkCompactionFromHead/labelnames=10,labelvalues=10000-4 122323192 115117224 -5.89%
BenchmarkCompactionFromHead/labelnames=100,labelvalues=1000-4 126404504 119469864 -5.49%
BenchmarkCompactionFromHead/labelnames=1000,labelvalues=100-4 119047832 112230408 -5.73%
BenchmarkCompactionFromHead/labelnames=10000,labelvalues=10-4 136576016 116634800 -14.60%
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
2019-12-17 11:49:54 -08:00
symbols index . StringIter
2020-07-31 08:03:02 -07:00
closers [ ] io . Closer
2019-02-14 05:29:41 -08:00
overlapping bool
2017-08-05 04:31:48 -07:00
)
2018-12-07 07:49:23 -08:00
defer func ( ) {
2020-10-28 08:24:58 -07:00
errs := tsdb_errors . NewMulti ( err )
if cerr := tsdb_errors . CloseAll ( closers ) ; cerr != nil {
2023-11-16 10:54:41 -08:00
errs . Add ( fmt . Errorf ( "close: %w" , cerr ) )
2020-07-14 01:36:22 -07:00
}
2020-10-28 08:24:58 -07:00
err = errs . Err ( )
2023-04-03 23:31:49 -07:00
metrics . PopulatingBlocks . Set ( 0 )
2018-12-07 07:49:23 -08:00
} ( )
2023-04-03 23:31:49 -07:00
metrics . PopulatingBlocks . Set ( 1 )
2019-01-18 08:58:17 -08:00
2019-07-23 01:04:48 -07:00
globalMaxt := blocks [ 0 ] . Meta ( ) . MaxTime
2017-01-03 06:43:26 -08:00
for i , b := range blocks {
2018-12-05 08:34:42 -08:00
select {
2023-04-03 23:31:49 -07:00
case <- ctx . Done ( ) :
return ctx . Err ( )
2018-12-05 08:34:42 -08:00
default :
}
2019-02-14 05:29:41 -08:00
if ! overlapping {
2019-07-23 01:04:48 -07:00
if i > 0 && b . Meta ( ) . MinTime < globalMaxt {
2023-04-03 23:31:49 -07:00
metrics . OverlappingBlocks . Inc ( )
2019-02-14 05:29:41 -08:00
overlapping = true
2023-04-03 23:31:49 -07:00
level . Info ( logger ) . Log ( "msg" , "Found overlapping blocks during compaction" , "ulid" , meta . ULID )
2019-02-14 05:29:41 -08:00
}
2019-07-23 01:04:48 -07:00
if b . Meta ( ) . MaxTime > globalMaxt {
globalMaxt = b . Meta ( ) . MaxTime
2019-02-14 05:29:41 -08:00
}
}
2020-03-25 12:13:47 -07:00
indexr , err := b . Index ( )
2017-10-09 06:21:46 -07:00
if err != nil {
2023-11-16 10:54:41 -08:00
return fmt . Errorf ( "open index reader for block %+v: %w" , b . Meta ( ) , err )
2017-10-09 06:21:46 -07:00
}
closers = append ( closers , indexr )
chunkr , err := b . Chunks ( )
if err != nil {
2023-11-16 10:54:41 -08:00
return fmt . Errorf ( "open chunk reader for block %+v: %w" , b . Meta ( ) , err )
2017-10-09 06:21:46 -07:00
}
closers = append ( closers , chunkr )
2017-06-07 04:42:53 -07:00
2017-10-09 06:21:46 -07:00
tombsr , err := b . Tombstones ( )
if err != nil {
2023-11-16 10:54:41 -08:00
return fmt . Errorf ( "open tombstone reader for block %+v: %w" , b . Meta ( ) , err )
2017-10-09 06:21:46 -07:00
}
closers = append ( closers , tombsr )
Reduce memory used by postings offset table.
Rather than keeping the offset of each postings list, instead
keep the nth offset of the offset of the posting list. As postings
list offsets have always been sorted, we can then get to the closest
entry before the one we want an iterate forwards.
I haven't done much tuning on the 32 number, it was chosen to try
not to read through more than a 4k page of data.
Switch to a bulk interface for fetching postings. Use it to avoid having
to re-read parts of the posting offset table when querying lots of it.
For a index with what BenchmarkHeadPostingForMatchers uses RAM
for r.postings drops from 3.79MB to 80.19kB or about 48x.
Bytes allocated go down by 30%, and suprisingly CPU usage drops by
4-6% for typical queries too.
benchmark old ns/op new ns/op delta
BenchmarkPostingsForMatchers/Block/n="1"-4 35231 36673 +4.09%
BenchmarkPostingsForMatchers/Block/n="1",j="foo"-4 563380 540627 -4.04%
BenchmarkPostingsForMatchers/Block/j="foo",n="1"-4 536782 534186 -0.48%
BenchmarkPostingsForMatchers/Block/n="1",j!="foo"-4 533990 541550 +1.42%
BenchmarkPostingsForMatchers/Block/i=~".*"-4 113374598 117969608 +4.05%
BenchmarkPostingsForMatchers/Block/i=~".+"-4 146329884 139651442 -4.56%
BenchmarkPostingsForMatchers/Block/i=~""-4 50346510 44961127 -10.70%
BenchmarkPostingsForMatchers/Block/i!=""-4 41261550 35356165 -14.31%
BenchmarkPostingsForMatchers/Block/n="1",i=~".*",j="foo"-4 112544418 116904010 +3.87%
BenchmarkPostingsForMatchers/Block/n="1",i=~".*",i!="2",j="foo"-4 112487086 116864918 +3.89%
BenchmarkPostingsForMatchers/Block/n="1",i!=""-4 41094758 35457904 -13.72%
BenchmarkPostingsForMatchers/Block/n="1",i!="",j="foo"-4 41906372 36151473 -13.73%
BenchmarkPostingsForMatchers/Block/n="1",i=~".+",j="foo"-4 147262414 140424800 -4.64%
BenchmarkPostingsForMatchers/Block/n="1",i=~"1.+",j="foo"-4 28615629 27872072 -2.60%
BenchmarkPostingsForMatchers/Block/n="1",i=~".+",i!="2",j="foo"-4 147117177 140462403 -4.52%
BenchmarkPostingsForMatchers/Block/n="1",i=~".+",i!~"2.*",j="foo"-4 175096826 167902298 -4.11%
benchmark old allocs new allocs delta
BenchmarkPostingsForMatchers/Block/n="1"-4 4 6 +50.00%
BenchmarkPostingsForMatchers/Block/n="1",j="foo"-4 7 11 +57.14%
BenchmarkPostingsForMatchers/Block/j="foo",n="1"-4 7 11 +57.14%
BenchmarkPostingsForMatchers/Block/n="1",j!="foo"-4 15 17 +13.33%
BenchmarkPostingsForMatchers/Block/i=~".*"-4 100010 100012 +0.00%
BenchmarkPostingsForMatchers/Block/i=~".+"-4 200069 200040 -0.01%
BenchmarkPostingsForMatchers/Block/i=~""-4 200072 200045 -0.01%
BenchmarkPostingsForMatchers/Block/i!=""-4 200070 200041 -0.01%
BenchmarkPostingsForMatchers/Block/n="1",i=~".*",j="foo"-4 100013 100017 +0.00%
BenchmarkPostingsForMatchers/Block/n="1",i=~".*",i!="2",j="foo"-4 100017 100023 +0.01%
BenchmarkPostingsForMatchers/Block/n="1",i!=""-4 200073 200046 -0.01%
BenchmarkPostingsForMatchers/Block/n="1",i!="",j="foo"-4 200075 200050 -0.01%
BenchmarkPostingsForMatchers/Block/n="1",i=~".+",j="foo"-4 200074 200049 -0.01%
BenchmarkPostingsForMatchers/Block/n="1",i=~"1.+",j="foo"-4 111165 111150 -0.01%
BenchmarkPostingsForMatchers/Block/n="1",i=~".+",i!="2",j="foo"-4 200078 200055 -0.01%
BenchmarkPostingsForMatchers/Block/n="1",i=~".+",i!~"2.*",j="foo"-4 311282 311238 -0.01%
benchmark old bytes new bytes delta
BenchmarkPostingsForMatchers/Block/n="1"-4 264 296 +12.12%
BenchmarkPostingsForMatchers/Block/n="1",j="foo"-4 360 424 +17.78%
BenchmarkPostingsForMatchers/Block/j="foo",n="1"-4 360 424 +17.78%
BenchmarkPostingsForMatchers/Block/n="1",j!="foo"-4 520 552 +6.15%
BenchmarkPostingsForMatchers/Block/i=~".*"-4 1600461 1600482 +0.00%
BenchmarkPostingsForMatchers/Block/i=~".+"-4 24900801 17259077 -30.69%
BenchmarkPostingsForMatchers/Block/i=~""-4 24900836 17259151 -30.69%
BenchmarkPostingsForMatchers/Block/i!=""-4 24900760 17259048 -30.69%
BenchmarkPostingsForMatchers/Block/n="1",i=~".*",j="foo"-4 1600557 1600621 +0.00%
BenchmarkPostingsForMatchers/Block/n="1",i=~".*",i!="2",j="foo"-4 1600717 1600813 +0.01%
BenchmarkPostingsForMatchers/Block/n="1",i!=""-4 24900856 17259176 -30.69%
BenchmarkPostingsForMatchers/Block/n="1",i!="",j="foo"-4 24900952 17259304 -30.69%
BenchmarkPostingsForMatchers/Block/n="1",i=~".+",j="foo"-4 24900993 17259333 -30.69%
BenchmarkPostingsForMatchers/Block/n="1",i=~"1.+",j="foo"-4 3788311 3142630 -17.04%
BenchmarkPostingsForMatchers/Block/n="1",i=~".+",i!="2",j="foo"-4 24901137 17259509 -30.69%
BenchmarkPostingsForMatchers/Block/n="1",i=~".+",i!~"2.*",j="foo"-4 28693086 20405680 -28.88%
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
2019-12-05 10:27:40 -08:00
k , v := index . AllPostingsKey ( )
2023-09-13 08:45:06 -07:00
all , err := indexr . Postings ( ctx , k , v )
2017-01-03 06:43:26 -08:00
if err != nil {
2017-08-28 15:39:17 -07:00
return err
2017-01-03 06:43:26 -08:00
}
2017-08-05 04:31:48 -07:00
all = indexr . SortedPostings ( all )
2020-07-31 08:03:02 -07:00
// Blocks meta is half open: [min, max), so subtract 1 to ensure we don't hold samples with exact meta.MaxTime timestamp.
2023-04-03 23:31:49 -07:00
sets = append ( sets , NewBlockChunkSeriesSet ( b . Meta ( ) . ULID , indexr , chunkr , tombsr , all , meta . MinTime , meta . MaxTime - 1 , false ) )
Stream symbols during compaction. (#6468)
Rather than buffer up symbols in RAM, do it one by one
during compaction. Then use the reader's symbol handling
for symbol lookups during the rest of the index write.
There is some slowdown in compaction, due to having to look through a file
rather than a hash lookup. This is noise to the overall cost of compacting
series with thousands of samples though.
benchmark old ns/op new ns/op delta
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=101-4 539917175 675341565 +25.08%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=1001-4 2441815993 2477453524 +1.46%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=2001-4 3978543559 3922909687 -1.40%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=5001-4 8430219716 8586610007 +1.86%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=101-4 1786424591 1909552782 +6.89%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=1001-4 5328998202 6020839950 +12.98%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=2001-4 10085059958 11085278690 +9.92%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=5001-4 25497010155 27018079806 +5.97%
BenchmarkCompactionFromHead/labelnames=1,labelvalues=100000-4 2427391406 2817217987 +16.06%
BenchmarkCompactionFromHead/labelnames=10,labelvalues=10000-4 2592965497 2538805050 -2.09%
BenchmarkCompactionFromHead/labelnames=100,labelvalues=1000-4 2437388343 2668012858 +9.46%
BenchmarkCompactionFromHead/labelnames=1000,labelvalues=100-4 2317095324 2787423966 +20.30%
BenchmarkCompactionFromHead/labelnames=10000,labelvalues=10-4 2600239857 2096973860 -19.35%
benchmark old allocs new allocs delta
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=101-4 500851 470794 -6.00%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=1001-4 821527 791451 -3.66%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=2001-4 1141562 1111508 -2.63%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=5001-4 2141576 2111504 -1.40%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=101-4 871466 841424 -3.45%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=1001-4 1941428 1911415 -1.55%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=2001-4 3071573 3041510 -0.98%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=5001-4 6771648 6741509 -0.45%
BenchmarkCompactionFromHead/labelnames=1,labelvalues=100000-4 731493 824888 +12.77%
BenchmarkCompactionFromHead/labelnames=10,labelvalues=10000-4 793918 887311 +11.76%
BenchmarkCompactionFromHead/labelnames=100,labelvalues=1000-4 811842 905204 +11.50%
BenchmarkCompactionFromHead/labelnames=1000,labelvalues=100-4 832244 925081 +11.16%
BenchmarkCompactionFromHead/labelnames=10000,labelvalues=10-4 921553 1019162 +10.59%
benchmark old bytes new bytes delta
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=101-4 40532648 35698276 -11.93%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=1001-4 60340216 53409568 -11.49%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=2001-4 81087336 72065552 -11.13%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=5001-4 142485576 120878544 -15.16%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=101-4 208661368 203831136 -2.31%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=1001-4 347345904 340484696 -1.98%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=2001-4 585185856 576244648 -1.53%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=5001-4 1357641792 1358966528 +0.10%
BenchmarkCompactionFromHead/labelnames=1,labelvalues=100000-4 126486664 119666744 -5.39%
BenchmarkCompactionFromHead/labelnames=10,labelvalues=10000-4 122323192 115117224 -5.89%
BenchmarkCompactionFromHead/labelnames=100,labelvalues=1000-4 126404504 119469864 -5.49%
BenchmarkCompactionFromHead/labelnames=1000,labelvalues=100-4 119047832 112230408 -5.73%
BenchmarkCompactionFromHead/labelnames=10000,labelvalues=10-4 136576016 116634800 -14.60%
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
2019-12-17 11:49:54 -08:00
syms := indexr . Symbols ( )
2017-01-03 06:43:26 -08:00
if i == 0 {
Stream symbols during compaction. (#6468)
Rather than buffer up symbols in RAM, do it one by one
during compaction. Then use the reader's symbol handling
for symbol lookups during the rest of the index write.
There is some slowdown in compaction, due to having to look through a file
rather than a hash lookup. This is noise to the overall cost of compacting
series with thousands of samples though.
benchmark old ns/op new ns/op delta
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=101-4 539917175 675341565 +25.08%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=1001-4 2441815993 2477453524 +1.46%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=2001-4 3978543559 3922909687 -1.40%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=5001-4 8430219716 8586610007 +1.86%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=101-4 1786424591 1909552782 +6.89%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=1001-4 5328998202 6020839950 +12.98%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=2001-4 10085059958 11085278690 +9.92%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=5001-4 25497010155 27018079806 +5.97%
BenchmarkCompactionFromHead/labelnames=1,labelvalues=100000-4 2427391406 2817217987 +16.06%
BenchmarkCompactionFromHead/labelnames=10,labelvalues=10000-4 2592965497 2538805050 -2.09%
BenchmarkCompactionFromHead/labelnames=100,labelvalues=1000-4 2437388343 2668012858 +9.46%
BenchmarkCompactionFromHead/labelnames=1000,labelvalues=100-4 2317095324 2787423966 +20.30%
BenchmarkCompactionFromHead/labelnames=10000,labelvalues=10-4 2600239857 2096973860 -19.35%
benchmark old allocs new allocs delta
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=101-4 500851 470794 -6.00%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=1001-4 821527 791451 -3.66%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=2001-4 1141562 1111508 -2.63%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=5001-4 2141576 2111504 -1.40%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=101-4 871466 841424 -3.45%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=1001-4 1941428 1911415 -1.55%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=2001-4 3071573 3041510 -0.98%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=5001-4 6771648 6741509 -0.45%
BenchmarkCompactionFromHead/labelnames=1,labelvalues=100000-4 731493 824888 +12.77%
BenchmarkCompactionFromHead/labelnames=10,labelvalues=10000-4 793918 887311 +11.76%
BenchmarkCompactionFromHead/labelnames=100,labelvalues=1000-4 811842 905204 +11.50%
BenchmarkCompactionFromHead/labelnames=1000,labelvalues=100-4 832244 925081 +11.16%
BenchmarkCompactionFromHead/labelnames=10000,labelvalues=10-4 921553 1019162 +10.59%
benchmark old bytes new bytes delta
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=101-4 40532648 35698276 -11.93%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=1001-4 60340216 53409568 -11.49%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=2001-4 81087336 72065552 -11.13%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=5001-4 142485576 120878544 -15.16%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=101-4 208661368 203831136 -2.31%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=1001-4 347345904 340484696 -1.98%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=2001-4 585185856 576244648 -1.53%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=5001-4 1357641792 1358966528 +0.10%
BenchmarkCompactionFromHead/labelnames=1,labelvalues=100000-4 126486664 119666744 -5.39%
BenchmarkCompactionFromHead/labelnames=10,labelvalues=10000-4 122323192 115117224 -5.89%
BenchmarkCompactionFromHead/labelnames=100,labelvalues=1000-4 126404504 119469864 -5.49%
BenchmarkCompactionFromHead/labelnames=1000,labelvalues=100-4 119047832 112230408 -5.73%
BenchmarkCompactionFromHead/labelnames=10000,labelvalues=10-4 136576016 116634800 -14.60%
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
2019-12-17 11:49:54 -08:00
symbols = syms
2017-01-03 06:43:26 -08:00
continue
}
2020-11-09 08:51:25 -08:00
symbols = NewMergedStringIter ( symbols , syms )
2017-01-02 02:12:28 -08:00
}
Stream symbols during compaction. (#6468)
Rather than buffer up symbols in RAM, do it one by one
during compaction. Then use the reader's symbol handling
for symbol lookups during the rest of the index write.
There is some slowdown in compaction, due to having to look through a file
rather than a hash lookup. This is noise to the overall cost of compacting
series with thousands of samples though.
benchmark old ns/op new ns/op delta
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=101-4 539917175 675341565 +25.08%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=1001-4 2441815993 2477453524 +1.46%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=2001-4 3978543559 3922909687 -1.40%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=5001-4 8430219716 8586610007 +1.86%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=101-4 1786424591 1909552782 +6.89%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=1001-4 5328998202 6020839950 +12.98%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=2001-4 10085059958 11085278690 +9.92%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=5001-4 25497010155 27018079806 +5.97%
BenchmarkCompactionFromHead/labelnames=1,labelvalues=100000-4 2427391406 2817217987 +16.06%
BenchmarkCompactionFromHead/labelnames=10,labelvalues=10000-4 2592965497 2538805050 -2.09%
BenchmarkCompactionFromHead/labelnames=100,labelvalues=1000-4 2437388343 2668012858 +9.46%
BenchmarkCompactionFromHead/labelnames=1000,labelvalues=100-4 2317095324 2787423966 +20.30%
BenchmarkCompactionFromHead/labelnames=10000,labelvalues=10-4 2600239857 2096973860 -19.35%
benchmark old allocs new allocs delta
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=101-4 500851 470794 -6.00%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=1001-4 821527 791451 -3.66%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=2001-4 1141562 1111508 -2.63%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=5001-4 2141576 2111504 -1.40%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=101-4 871466 841424 -3.45%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=1001-4 1941428 1911415 -1.55%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=2001-4 3071573 3041510 -0.98%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=5001-4 6771648 6741509 -0.45%
BenchmarkCompactionFromHead/labelnames=1,labelvalues=100000-4 731493 824888 +12.77%
BenchmarkCompactionFromHead/labelnames=10,labelvalues=10000-4 793918 887311 +11.76%
BenchmarkCompactionFromHead/labelnames=100,labelvalues=1000-4 811842 905204 +11.50%
BenchmarkCompactionFromHead/labelnames=1000,labelvalues=100-4 832244 925081 +11.16%
BenchmarkCompactionFromHead/labelnames=10000,labelvalues=10-4 921553 1019162 +10.59%
benchmark old bytes new bytes delta
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=101-4 40532648 35698276 -11.93%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=1001-4 60340216 53409568 -11.49%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=2001-4 81087336 72065552 -11.13%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=5001-4 142485576 120878544 -15.16%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=101-4 208661368 203831136 -2.31%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=1001-4 347345904 340484696 -1.98%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=2001-4 585185856 576244648 -1.53%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=5001-4 1357641792 1358966528 +0.10%
BenchmarkCompactionFromHead/labelnames=1,labelvalues=100000-4 126486664 119666744 -5.39%
BenchmarkCompactionFromHead/labelnames=10,labelvalues=10000-4 122323192 115117224 -5.89%
BenchmarkCompactionFromHead/labelnames=100,labelvalues=1000-4 126404504 119469864 -5.49%
BenchmarkCompactionFromHead/labelnames=1000,labelvalues=100-4 119047832 112230408 -5.73%
BenchmarkCompactionFromHead/labelnames=10000,labelvalues=10-4 136576016 116634800 -14.60%
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
2019-12-17 11:49:54 -08:00
for symbols . Next ( ) {
if err := indexw . AddSymbol ( symbols . At ( ) ) ; err != nil {
2023-11-16 10:54:41 -08:00
return fmt . Errorf ( "add symbol: %w" , err )
Stream symbols during compaction. (#6468)
Rather than buffer up symbols in RAM, do it one by one
during compaction. Then use the reader's symbol handling
for symbol lookups during the rest of the index write.
There is some slowdown in compaction, due to having to look through a file
rather than a hash lookup. This is noise to the overall cost of compacting
series with thousands of samples though.
benchmark old ns/op new ns/op delta
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=101-4 539917175 675341565 +25.08%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=1001-4 2441815993 2477453524 +1.46%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=2001-4 3978543559 3922909687 -1.40%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=5001-4 8430219716 8586610007 +1.86%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=101-4 1786424591 1909552782 +6.89%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=1001-4 5328998202 6020839950 +12.98%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=2001-4 10085059958 11085278690 +9.92%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=5001-4 25497010155 27018079806 +5.97%
BenchmarkCompactionFromHead/labelnames=1,labelvalues=100000-4 2427391406 2817217987 +16.06%
BenchmarkCompactionFromHead/labelnames=10,labelvalues=10000-4 2592965497 2538805050 -2.09%
BenchmarkCompactionFromHead/labelnames=100,labelvalues=1000-4 2437388343 2668012858 +9.46%
BenchmarkCompactionFromHead/labelnames=1000,labelvalues=100-4 2317095324 2787423966 +20.30%
BenchmarkCompactionFromHead/labelnames=10000,labelvalues=10-4 2600239857 2096973860 -19.35%
benchmark old allocs new allocs delta
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=101-4 500851 470794 -6.00%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=1001-4 821527 791451 -3.66%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=2001-4 1141562 1111508 -2.63%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=5001-4 2141576 2111504 -1.40%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=101-4 871466 841424 -3.45%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=1001-4 1941428 1911415 -1.55%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=2001-4 3071573 3041510 -0.98%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=5001-4 6771648 6741509 -0.45%
BenchmarkCompactionFromHead/labelnames=1,labelvalues=100000-4 731493 824888 +12.77%
BenchmarkCompactionFromHead/labelnames=10,labelvalues=10000-4 793918 887311 +11.76%
BenchmarkCompactionFromHead/labelnames=100,labelvalues=1000-4 811842 905204 +11.50%
BenchmarkCompactionFromHead/labelnames=1000,labelvalues=100-4 832244 925081 +11.16%
BenchmarkCompactionFromHead/labelnames=10000,labelvalues=10-4 921553 1019162 +10.59%
benchmark old bytes new bytes delta
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=101-4 40532648 35698276 -11.93%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=1001-4 60340216 53409568 -11.49%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=2001-4 81087336 72065552 -11.13%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=5001-4 142485576 120878544 -15.16%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=101-4 208661368 203831136 -2.31%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=1001-4 347345904 340484696 -1.98%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=2001-4 585185856 576244648 -1.53%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=5001-4 1357641792 1358966528 +0.10%
BenchmarkCompactionFromHead/labelnames=1,labelvalues=100000-4 126486664 119666744 -5.39%
BenchmarkCompactionFromHead/labelnames=10,labelvalues=10000-4 122323192 115117224 -5.89%
BenchmarkCompactionFromHead/labelnames=100,labelvalues=1000-4 126404504 119469864 -5.49%
BenchmarkCompactionFromHead/labelnames=1000,labelvalues=100-4 119047832 112230408 -5.73%
BenchmarkCompactionFromHead/labelnames=10000,labelvalues=10-4 136576016 116634800 -14.60%
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
2019-12-17 11:49:54 -08:00
}
}
2023-11-16 10:54:41 -08:00
if err := symbols . Err ( ) ; err != nil {
return fmt . Errorf ( "next symbol: %w" , err )
2017-08-05 04:31:48 -07:00
}
2020-07-31 08:03:02 -07:00
var (
2022-09-20 10:16:45 -07:00
ref = storage . SeriesRef ( 0 )
chks [ ] chunks . Meta
chksIter chunks . Iterator
2020-07-31 08:03:02 -07:00
)
set := sets [ 0 ]
if len ( sets ) > 1 {
2021-05-18 09:38:37 -07:00
// Merge series using specified chunk series merger.
// The default one is the compacting series merger.
2023-04-03 23:31:49 -07:00
set = storage . NewMergeChunkSeriesSet ( sets , mergeFunc )
2020-07-31 08:03:02 -07:00
}
// Iterate over all sorted chunk series.
2017-01-02 01:34:55 -08:00
for set . Next ( ) {
2018-12-05 08:34:42 -08:00
select {
2023-04-03 23:31:49 -07:00
case <- ctx . Done ( ) :
return ctx . Err ( )
2018-12-05 08:34:42 -08:00
default :
}
2020-07-31 08:03:02 -07:00
s := set . At ( )
2022-09-20 10:16:45 -07:00
chksIter = s . Iterator ( chksIter )
2020-07-31 08:03:02 -07:00
chks = chks [ : 0 ]
for chksIter . Next ( ) {
2022-07-06 05:34:02 -07:00
// We are not iterating in streaming way over chunk as
// it's more efficient to do bulk write for index and
2020-07-31 08:03:02 -07:00
// chunk file purposes.
chks = append ( chks , chksIter . At ( ) )
}
2023-11-16 10:54:41 -08:00
if err := chksIter . Err ( ) ; err != nil {
return fmt . Errorf ( "chunk iter: %w" , err )
2019-02-14 05:29:41 -08:00
}
2017-05-17 02:19:42 -07:00
2017-07-12 09:16:12 -07:00
// Skip the series with all deleted chunks.
if len ( chks ) == 0 {
continue
}
2020-07-31 08:03:02 -07:00
if err := chunkw . WriteChunks ( chks ... ) ; err != nil {
2023-11-16 10:54:41 -08:00
return fmt . Errorf ( "write chunks: %w" , err )
2017-01-02 01:34:55 -08:00
}
2020-07-31 08:03:02 -07:00
if err := indexw . AddSeries ( ref , s . Labels ( ) , chks ... ) ; err != nil {
2023-11-16 10:54:41 -08:00
return fmt . Errorf ( "add series: %w" , err )
2017-08-05 04:31:48 -07:00
}
2017-02-19 02:27:31 -08:00
2020-07-31 08:03:02 -07:00
meta . Stats . NumChunks += uint64 ( len ( chks ) )
2017-01-19 02:22:47 -08:00
meta . Stats . NumSeries ++
2020-07-31 08:03:02 -07:00
for _ , chk := range chks {
2017-07-12 09:31:26 -07:00
meta . Stats . NumSamples += uint64 ( chk . Chunk . NumSamples ( ) )
2017-07-12 09:16:12 -07:00
}
2017-01-02 01:34:55 -08:00
2020-07-31 08:03:02 -07:00
for _ , chk := range chks {
2023-04-03 23:31:49 -07:00
if err := chunkPool . Put ( chk . Chunk ) ; err != nil {
2023-11-16 10:54:41 -08:00
return fmt . Errorf ( "put chunk: %w" , err )
2018-09-20 01:33:52 -07:00
}
2017-08-08 08:35:34 -07:00
}
2019-12-11 09:20:41 -08:00
ref ++
2017-01-02 01:34:55 -08:00
}
2023-11-16 10:54:41 -08:00
if err := set . Err ( ) ; err != nil {
return fmt . Errorf ( "iterate compaction set: %w" , err )
2017-01-02 01:34:55 -08:00
}
2017-08-28 15:39:17 -07:00
return nil
2017-01-02 01:34:55 -08:00
}