mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2025-03-05 20:59:13 -08:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

Use Has instead of Get for existence test.

Browse source
This commit is contained in:
beorn7 2015-07-16 12:25:32 +02:00
parent ff08f0b6fe
commit 502aa9ded5
1 changed files with 2 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
storage/local/index/leveldb.go
View file

@ -110,12 +110,8 @@ func (l *LevelDB) Delete(key encoding.BinaryMarshaler) (bool, error) {
return false, err return false, err
} }
// Note that Delete returns nil if k does not exist. So we have to test // Note that Delete returns nil if k does not exist. So we have to test
// for existence with Get first. // for existence with Has first.
_, err = l.storage.Get(k, l.readOpts) if has, err := l.storage.Has(k, l.readOpts); !has || err != nil {
if err == leveldb.ErrNotFound {
return false, nil
}
if err != nil {
return false, err return false, err
} }
if err = l.storage.Delete(k, l.writeOpts); err != nil { if err = l.storage.Delete(k, l.writeOpts); err != nil {