mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2025-02-02 08:31:11 -08:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

Check nil err first when committing (#12625)

Browse source 
The most common case is to have a nil error when appending series, so
let's check that first instead of checking the 3 error types first.

Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
This commit is contained in:
Oleg Zaytsev 2023-08-01 14:04:45 +02:00 committed by GitHub
parent f26dfc95e6
commit cd7d0b69a2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
tsdb/head_append.go
View file

@ -930,6 +930,8 @@ func (a *headAppender) Commit() (err error) {
oooSample, _, err := series.appendable(s.T, s.V, a.headMaxt, a.minValidTime, a.oooTimeWindow) oooSample, _, err := series.appendable(s.T, s.V, a.headMaxt, a.minValidTime, a.oooTimeWindow)
switch err { switch err {
case nil:
// Do nothing.
case storage.ErrOutOfOrderSample: case storage.ErrOutOfOrderSample:
samplesAppended-- samplesAppended--
oooRejected++ oooRejected++
@ -939,8 +941,6 @@ func (a *headAppender) Commit() (err error) {
case storage.ErrTooOldSample: case storage.ErrTooOldSample:
samplesAppended-- samplesAppended--
tooOldRejected++ tooOldRejected++
case nil:
// Do nothing.
default: default:
samplesAppended-- samplesAppended--
} }