Bryan Boreham
174b26a5c0
Merge pull request #404 from grafana/fixup-labels-usage2
...
Fixup labels usage
2023-03-28 13:21:11 +01:00
Bryan Boreham
cc8eb55a22
tsdb: call StableHash as appropriate
...
labels.Labels.Hash() is not guaranteed to be stable over time.
2023-03-27 18:03:52 +00:00
Bryan Boreham
6009066423
tsdb/index tests: use labels.FromStrings
2023-03-27 18:03:52 +00:00
Bryan Boreham
2e22653db4
tsdb: use abstractions over Labels
...
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2023-03-27 18:03:52 +00:00
Bryan Boreham
9bb9faabb1
rules tests: use EmptyLabels instead of nil
...
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2023-03-27 18:03:52 +00:00
Bryan Boreham
aa9385ea88
tsdb: one more labels.FromStrings
...
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2023-03-27 17:41:57 +00:00
Bryan Boreham
0679437825
promql/tests: couple more labels.FromStrings
...
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2023-03-27 17:41:30 +00:00
Oleg Zaytsev
8a7ef4cfac
Merge pull request #462 from grafana/fix-block-compaction-failed-when-shutting-down-cherry-picked
...
Fix block compaction failed when shutting down
2023-03-23 12:12:08 +01:00
Oleg Zaytsev
1535deb62c
Fix context.Canceled wrapping in compaction
...
We need to make sure that `tsdb_errors.NewMulti` handles the errors.Is()
calls properly, like it's done in grafana/dskit.
Also we need to check that `errors.Is(err, context.Canceled)`, not that
`err == context.Canceled`.
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
2023-03-23 11:41:28 +01:00
Oleg Zaytsev
dfbd52113b
Test compaction not failed during shutdown
...
Test that blocks are not marked as "compaction failed" during shutdown.
This shouldn't happen but this test currently fails.
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
2023-03-23 11:41:28 +01:00
Oleg Zaytsev
581e5e961f
Merge pull request #461 from grafana/revert-460-implement-multi-errors-is
...
Revert "Implement Is() for multierrors"
2023-03-23 11:39:25 +01:00
Oleg Zaytsev
d69082ea9a
Revert "Implement Is() for multierrors"
2023-03-23 11:10:56 +01:00
Oleg Zaytsev
f7f1fc750c
Merge pull request #460 from grafana/implement-multi-errors-is
...
Implement Is() for multierrors
2023-03-22 17:55:37 +01:00
Oleg Zaytsev
3d8b5e89ae
Implement Is() for multierrors
...
We need to be able to identify the errors that a multierror wraps.
Especially in case of `context.Canceled`. This is the same
implementation of that method as we do in github.com/grafana/dskit/multierror
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
2023-03-22 17:29:39 +01:00
Marco Pracucci
74916ab06e
Merge pull request #457 from grafana/codesome/sync-prom
...
Sync with upstream Prometheus
2023-03-22 10:25:40 +01:00
Marco Pracucci
cc33c21548
Merge pull request #458 from grafana/allow-to-configure-block-postings-cache
...
Allow to configure compacted blocks postings for matchers cache
2023-03-22 09:33:26 +01:00
Ganesh Vernekar
7a33f5c2ca
Change UnsupportedMask to not clash with OutOfOrderMask
...
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
2023-03-22 13:19:49 +05:30
Marco Pracucci
330e9b69af
Allow to configure compacted blocks postings for matchers cache
...
Signed-off-by: Marco Pracucci <marco@pracucci.com>
2023-03-22 06:40:11 +01:00
Ganesh Vernekar
41649ceb1b
Merge remote-tracking branch 'upstream/main' into codesome/sync-prom
...
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
2023-03-22 08:35:08 +05:30
Julien Pivotto
8ac5363590
Merge pull request #12168 from roidelapluie/booldoc
...
Docs: use boolean instead of bool
2023-03-21 18:04:17 +01:00
Julien Pivotto
ae220724d4
Docs: use boolean instead of bool
...
boolean makes the type consistent and clickable on
https://prometheus.io/docs/prometheus/latest/configuration/configuration/
Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>
2023-03-21 17:28:31 +01:00
Julien Pivotto
de50efbf7a
Merge pull request #12165 from prometheus/release-2.43
...
Merge 2.43 in main
2023-03-21 17:26:28 +01:00
Björn Rabenstein
559adab471
Merge pull request #12085 from leizor/leizor/prometheus/issues/11204
...
Handle native histograms in remote read
2023-03-21 17:25:34 +01:00
Vernon Miller
ca0abf26c5
Adds an affirmative log message for successful WAL repair ( #12135 )
...
* Adds an affirmative log message for successful WAL repair
Signed-off-by: Vernon Miller <vernon.miller@grafana.com>
Signed-off-by: Vernon Miller <96601789+aldernero@users.noreply.github.com>
Co-authored-by: Ganesh Vernekar <ganeshvern@gmail.com>
2023-03-21 19:33:43 +05:30
Julien Pivotto
edfc3bcd02
Merge pull request #12164 from roidelapluie/rel-243
...
Address review comments on release 2.43 changelog.
2023-03-21 13:52:36 +01:00
Julien Pivotto
67f48f47c7
Address review comments
...
Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>
2023-03-21 13:50:48 +01:00
Julien Pivotto
842ab019ed
Merge pull request #12162 from roidelapluie/rel-2.43
...
Release 2.43.0
2023-03-21 13:49:31 +01:00
Julien Pivotto
1070c9b06c
Release 2.43.0
...
Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>
2023-03-21 13:07:51 +01:00
SuperQ
f14665b9e3
Fix docker tag sanitizer
...
Use a `-` instead of `_` to make the docker tag also pass semver checks.
Signed-off-by: SuperQ <superq@gmail.com>
2023-03-21 11:27:25 +01:00
Julien Pivotto
fd8992cdbd
Merge pull request #12137 from g3offrey/fix/update-prometheus-ansible-link
...
docs: update ansible installation link
2023-03-20 11:14:56 +01:00
Julien Pivotto
901937c6ac
Merge pull request #12142 from colega/store-the-remote-client-url-string
...
remote.Client: store urlString
2023-03-20 10:44:10 +01:00
Julien Pivotto
bc7ce50d85
Merge pull request #12115 from prometheus/superq/go_1.20
...
Update Go version
2023-03-16 23:50:51 +01:00
Julien Pivotto
d08254324e
Merge pull request #12149 from roidelapluie/relrc1-updatemakefile
...
Update makefile to better handle semver build metadata
2023-03-16 21:33:49 +01:00
Julien Pivotto
f8eb70c46d
Merge branch 'release-2.43' of https://github.com/prometheus/prometheus into release-2.43
2023-03-16 21:09:16 +01:00
Julien Pivotto
71b24c25c2
Merge pull request #12147 from roidelapluie/relrc1
...
2.43.0-rc.1
2023-03-16 21:08:51 +01:00
Julien Pivotto
331a7dfd21
Replace '+' with '_' in docker image tag for semver compatibility
...
This change introduces a new variable, SANITIZED_DOCKER_IMAGE_TAG, which
replaces any '+' characters in the original DOCKER_IMAGE_TAG with '_'
characters. This ensures better compatibility with semver standards,
particularly when using metadata in version tags.
Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>
2023-03-16 20:31:17 +01:00
Julien Pivotto
2c6168be5f
Release 2.43.0-rc.1
...
Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>
2023-03-16 20:21:40 +01:00
Bryan Boreham
934c520d37
labels: cope with mutating Builder during Range call
...
Although we had a different slice, the underlying memory was the same so
any changes meant we could skip some values.
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2023-03-16 20:15:10 +01:00
Bryan Boreham
bd23e8899d
labels: add test for Builder.Range
...
Including mutating the Builder being Ranged over.
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2023-03-16 20:15:08 +01:00
Bartlomiej Plotka
a494c44746
Merge pull request #12145 from bboreham/fix-label-builder
...
labels: cope with mutating Builder during Range call
2023-03-16 19:33:14 +01:00
Björn Rabenstein
d303fa77b9
Merge pull request #12144 from prometheus/beorn7/doc
...
docs: Clarify that range selectors use a closed interval
2023-03-16 17:15:26 +01:00
Bryan Boreham
3743d87c56
labels: cope with mutating Builder during Range call
...
Although we had a different slice, the underlying memory was the same so
any changes meant we could skip some values.
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2023-03-16 13:28:15 +00:00
Bryan Boreham
3c4ab7a069
labels: add test for Builder.Range
...
Including mutating the Builder being Ranged over.
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2023-03-16 13:25:55 +00:00
beorn7
71c57a1292
docs: Clarify that range selectors use a closed interval
...
Signed-off-by: beorn7 <beorn@grafana.com>
2023-03-16 13:55:57 +01:00
Abhijit Mukherjee
8f6d5dcd45
Fix: getting rid of EncOOOXOR chunk encoding ( #12111 )
...
Signed-off-by: mabhi <abhijit.mukherjee@infracloud.io>
2023-03-16 15:53:47 +05:30
Oleg Zaytsev
beb7d3b80f
remote.Client: store urlString
...
During remote write, we call url.String() twice:
- to add the Endpoint() to the span
- to actually know where whe should send the request
This value does not change over time, and it's not really that
lightweight to calculate. I wrote this simple benchmark:
func BenchmarkURLString(b *testing.B) {
u, err := url.Parse("https://remote.write.com/api/v1 ")
require.NoError(b, err)
b.Run("string", func(b *testing.B) {
count := 0
for i := 0; i < b.N; i++ {
count += len(u.String())
}
})
}
And the results are ~200ns/op, 80B/op, 3 allocs/op.
Yes, we're going to go to the network here, which is a huge amount of
resources compared to this, but still, on agents that send 500 requests
per second, that is 1500 wasteful allocations per second.
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
2023-03-16 09:53:10 +01:00
g3offrey
d01c51fad0
docs: update ansible installation link
...
Signed-off-by: g3offrey <11151445+g3offrey@users.noreply.github.com>
2023-03-15 15:58:44 +01:00
Ganesh Vernekar
58a8d526e8
Merge pull request #11992 from codesome/no-reencode-chunk
...
Do not re-encode head chunk for ChunkQuerier
2023-03-15 18:30:38 +05:30
Ganesh Vernekar
0a3f203c63
Update tests to not assume the chunk implementation
...
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
2023-03-15 17:58:37 +05:30
Ganesh Vernekar
45b025898f
Add BenchmarkHeadChunkQuerier and BenchmarkHeadQuerier
...
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
2023-03-15 17:58:31 +05:30