14232 commits

This branch

This branch

All branches

Author	SHA1	Message	Date
Yi	2cabd1b707	config: remove expand-external-labels flag in release 3.0 (#14657) ... remove expand-external-labels feature flag and enabled env arg expansion for external labels by default. Signed-off-by: jyz0309 <45495947@qq.com>	2024-10-17 10:25:05 +02:00
George Krajcsovits	6ce21b8399	Merge pull request #15172 from krajorama/update-client-golang ... chore(deps): update client_golang from 1.20.4 to 1.20.5	2024-10-16 15:26:41 +02:00
Bryan Boreham	5dd5aec0e6	Merge pull request #14599 from machine424/sigsegv ... test(tsdb): add a reproducer for https://github.com/prometheus/prometheus/issues/14422	2024-10-16 14:16:54 +01:00
György Krajcsovits	4271670a82	chore(deps): update client_golang from 1.20.4 to 1.20.5 ... Ref: https://github.com/prometheus/client_golang/releases/tag/v1.20.5 Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>	2024-10-16 15:02:13 +02:00
Joshua Hesketh	5a4e4f6936	Fix stddev/stdvar when aggregating histograms, NaNs, and infinities (#14941) ... promql: Fix stddev/stdvar when aggregating histograms, NaNs, and Infs Native histograms are ignored when calculating stddev or stdvar. However, for the first series of each group, a `groupedAggregation` is always created. If the first series that was encountered is a histogram then it acts as the equivalent of a 0 point. This change creates the first `groupedAggregation` with the `seen` field set to `false` if the point is a histogram, thus ignoring it like the rest of the aggregation function does. A new `groupedAggregation` will then be created once an actual float value is encountered. This commit also sets the `floatValue` field of the `groupedAggregation` to `NaN`, if the first float value of a group is `NaN` or `±Inf`, so that the outcome is consistently `NaN` once those values are in the mix. (The added tests fail without this change). Signed-off-by: Joshua Hesketh <josh@nitrotech.org> Signed-off-by: beorn7 <beorn@grafana.com> --------- Signed-off-by: Joshua Hesketh <josh@nitrotech.org> Signed-off-by: beorn7 <beorn@grafana.com> Co-authored-by: beorn7 <beorn@grafana.com>	2024-10-16 15:00:46 +02:00
akunszt	08a7162502	discovery: aws/ec2 unit tests (#14364) ... * discovery: add aws/ec2 unit tests * discovery: initial skeleton for aws/ec2 unit tests This is a - very likely - not too useful unit test for the AWS SD. It is commited so other people can check the basic logic and the implementation. Signed-off-by: Arpad Kunszt <akunszt@hiya.com> * discovery: fix linter complains about ec2_test.go Signed-off-by: Arpad Kunszt <akunszt@hiya.com> * discovery: add basic unit test for aws This tests only the basic labelling, not including the VPC related information. Signed-off-by: Arpad Kunszt <akunszt@hiya.com> * discovery: fix linter complains about ec2_test.go Signed-off-by: Arpad Kunszt <akunszt@hiya.com> * discovery: other linter fixes in aws/ec2_test.go Signed-off-by: Arpad Kunszt <akunszt@hiya.com> * discovery: implement remaining tests for aws/ec2 The coverage is not 100% but I think it is a good starting point if someone wants to improve that. Currently it covers all the AWS API calls. Signed-off-by: Arpad Kunszt <akunszt@hiya.com> * discovery: make linter happy in aws/ec2_test.go Signed-off-by: Arpad Kunszt <akunszt@hiya.com> * discovery: make utility funtcions private Signed-off-by: Arpad Kunszt <akunszt@hiya.com> * discover: no global variable in the aws/ec2 test Signed-off-by: Arpad Kunszt <akunszt@hiya.com> * discovery: common body for some tests in ec2 Signed-off-by: Arpad Kunszt <akunszt@hiya.com> * discovery: try to make golangci-lint happy Signed-off-by: Arpad Kunszt <akunszt@hiya.com> * discovery: make every non-test function private Signed-off-by: Arpad Kunszt <akunszt@hiya.com> * discovery: test for errors first in TestRefresh Signed-off-by: Arpad Kunszt <akunszt@hiya.com> * discovery: move refresh tests into the function This way people can find both the test cases and the execution of the test at the same place. Signed-off-by: Arpad Kunszt <akunszt@hiya.com> * discovery: fix copyright date Signed-off-by: Arpad Kunszt <akunszt@hiya.com> * discovery: remove misleading comment Signed-off-by: Arpad Kunszt <akunszt@hiya.com> * discovery: rename test for easier identification Signed-off-by: Arpad Kunszt <akunszt@hiya.com> * discovery: use static values for the test cases Signed-off-by: Arpad Kunszt <akunszt@hiya.com> * discover: try to make the linter happy Signed-off-by: Arpad Kunszt <akunszt@hiya.com> * discovery: drop redundant data from ec2 and use common ptr functions Signed-off-by: Arpad Kunszt <akunszt@hiya.com> * discovery: use Error instead of Equal Signed-off-by: Arpad Kunszt <akunszt@hiya.com> * discovery: merge refreshAZIDs tests into one Signed-off-by: Arpad Kunszt <akunszt@hiya.com> --------- Signed-off-by: Arpad Kunszt <akunszt@hiya.com>	2024-10-16 14:36:37 +02:00
George Krajcsovits	55419275ab	Merge pull request #15159 from prometheus/nhcb-scrape-optimize1 ... convertnhcb: use CutSuffix instead of regex replace for histogram name	2024-10-16 10:25:18 +02:00
machine424	ab2475c426	test(tsdb): add a reproducer for https://github.com/prometheus/prometheus/issues/14422 ... Signed-off-by: machine424 <ayoubmrini424@gmail.com>	2024-10-15 20:39:25 +02:00
Neeraj Gartia	d4b1f9eb33	Corrects the behaviour of binary opperators between histogram and float (#14726) ... promql: corrects binary operators functioning for mixed sample with histogram and float For invalid pairings of sample types, an annotation is added now. Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com> --------- Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>	2024-10-15 14:44:36 +02:00
Bryan Boreham	1e1f6ab9df	Merge pull request #15120 from bboreham/floor-ino-mint ... [BUGFIX] TSDB: Don't read in-order chunks from before head MinTime	2024-10-15 10:27:38 +01:00
Arthur Silva Sens	911c3efb96	Merge pull request #14976 from prometheus/prep-3.0-beta.1 ... Prepare 3.0.0-beta.1	2024-10-14 12:44:41 -03:00
György Krajcsovits	78de9bd10f	convertnhcb: use CutSuffix instead of regex replace for histogram name ... This is much quicker. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>	2024-10-14 16:50:05 +02:00
George Krajcsovits	522149a2ae	model: move classic NHCB conversion into its own file (#15156) ... * model: move classic to NHCB conversion into its own file In preparation for #14978. Author: Jeanette Tan <jeanette.tan@grafana.com> 2024-07-03 11:56:48 Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com> Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> Co-authored-by: Jeanette Tan <jeanette.tan@grafana.com> Co-authored-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> * Better naming from review comment Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> * Add doc strings. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> --------- Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com> Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> Co-authored-by: Jeanette Tan <jeanette.tan@grafana.com>	2024-10-14 14:23:11 +02:00
Manik Rana	c3b8582cf4	[PERF] textparse: optimize OM p.isCreatedSeries() (#15150) ... * refac: remove p.Metric usage Signed-off-by: Manik Rana <manikrana54@gmail.com> * perf: use bytes instead of strings Signed-off-by: Manik Rana <manikrana54@gmail.com> * chore: comments Signed-off-by: Manik Rana <Manikrana54@gmail.com> --------- Signed-off-by: Manik Rana <manikrana54@gmail.com> Signed-off-by: Manik Rana <Manikrana54@gmail.com>	2024-10-14 10:18:15 +01:00
George Krajcsovits	b8867f8ead	Merge pull request #15142 from krajorama/fix-appendhistogram-race ... bugfix: data race in head.Appender.AppendHistogram and Commit	2024-10-14 08:13:39 +02:00
M Viswanath Sai	16bba78f15	discovery: Improve Azure test coverage to 50% (#14586) ... * azure sd: separate refresh and refreshAzure * azure sd: create a client with mocked servers for tests * add test for refresh function --------- Signed-off-by: mviswanathsai <mviswanath.sai.met21@itbhu.ac.in>	2024-10-13 10:24:51 +02:00
dependabot[bot]	7ce9cfa6e4	Bump the k8s-io group with 3 updates (#15030) ... Bumps the k8s-io group with 3 updates: [k8s.io/api](https://github.com/kubernetes/api), [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) and [k8s.io/client-go](https://github.com/kubernetes/client-go). Updates `k8s.io/api` from 0.31.0 to 0.31.1 - [Commits](https://github.com/kubernetes/api/compare/v0.31.0...v0.31.1) Updates `k8s.io/apimachinery` from 0.31.0 to 0.31.1 - [Commits](https://github.com/kubernetes/apimachinery/compare/v0.31.0...v0.31.1) Updates `k8s.io/client-go` from 0.31.0 to 0.31.1 - [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md) - [Commits](https://github.com/kubernetes/client-go/compare/v0.31.0...v0.31.1) --- updated-dependencies: - dependency-name: k8s.io/api dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io - dependency-name: k8s.io/apimachinery dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io - dependency-name: k8s.io/client-go dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2024-10-12 10:40:23 +02:00
dependabot[bot]	1e3953ab13	Bump github.com/docker/docker (#15033) ... Bumps [github.com/docker/docker](https://github.com/docker/docker) from 27.2.0+incompatible to 27.3.1+incompatible. - [Release notes](https://github.com/docker/docker/releases) - [Commits](https://github.com/docker/docker/compare/v27.2.0...v27.3.1) --- updated-dependencies: - dependency-name: github.com/docker/docker dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2024-10-12 10:38:57 +02:00
Oleg Zaytsev	50ef0dc954	Fix MemPostings.Add and MemPostings.Get data race (#15141) ... * Tests for Mempostings.{Add,Get} data race * Fix MemPostings.{Add,Get} data race We can't modify the postings list that are held in MemPostings as they might already be in use by some readers. * Modify BenchmarkHeadStripeSeriesCreate to have common labels If there are no common labels on the series, we don't excercise the ordering part of MemSeries, as we're just creating slices of one element for each label value. --------- Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>	2024-10-11 15:21:15 +02:00
Julien	e6f9e2dde3	Merge pull request #15119 from roidelapluie/dochttp ... docs: extract HTTP client option documentation in their own sections	2024-10-11 13:10:34 +02:00
Ayoub Mrini	d9a54284f5	Merge pull request #14987 from machine424/yafix ... fix(notifier): avoid dropping known alertmanagers after each ApplyConfig	2024-10-10 21:14:35 +02:00
György Krajcsovits	bb70370d72	TSDB head: fix race between AppendHistogram and Commit ... Move writing memSeries lastHistogramValue and lastFloatHistogramValue after series creation under lock. The resulting code isn't totally correct in the sense that we're setting these values before Commit() , so they might be overwritten/rolled back later. Also Append of stale sample checks the values without lock, so there's still a potential race. The correct solution would be to set these only in Commit() which we actually do, but then Commit() would also need to process samples in order and not floats first, then histograms, then float histograms - which leads to not knowing what stale marker to write for histograms. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>	2024-10-10 16:59:15 +02:00
György Krajcsovits	631fadc4ca	Unit test for data race in head.Appender.AppendHistogram ... Two Appenders race when creating a series with a native histogram as the memSeries will be common and the lastHistogram field is written without lock. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>	2024-10-10 14:10:07 +02:00
Manik Rana	032ca9ef96	[PERF] textparse: further optimzations for OM CreatedTimestamps (#15097) ... * feat: Added more tests; some changes/optimizations when pair-programming with Bartek. Signed-off-by: Manik Rana <manikrana54@gmail.com> * chore: imports Signed-off-by: Manik Rana <manikrana54@gmail.com> * chore: gofumpt Signed-off-by: Manik Rana <manikrana54@gmail.com> * feat: use an efficient replacement to p.Metric Signed-off-by: Manik Rana <manikrana54@gmail.com> * feat: reduce mem allocs + comments Signed-off-by: Manik Rana <manikrana54@gmail.com> * chore: gofumpt Signed-off-by: Manik Rana <manikrana54@gmail.com> * chore: use single quotes Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com> Signed-off-by: Manik Rana <Manikrana54@gmail.com> * refac: rename Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com> Signed-off-by: Manik Rana <Manikrana54@gmail.com> * refac: rename to seriesHash Signed-off-by: Manik Rana <manikrana54@gmail.com> * refac: switch condition order Co-authored-by: George Krajcsovits <krajorama@users.noreply.github.com> Signed-off-by: Manik Rana <Manikrana54@gmail.com> * refac: switch condition order Co-authored-by: George Krajcsovits <krajorama@users.noreply.github.com> Signed-off-by: Manik Rana <Manikrana54@gmail.com> * feat: stronger checking Co-authored-by: George Krajcsovits <krajorama@users.noreply.github.com> Signed-off-by: Manik Rana <Manikrana54@gmail.com> * chore: fmt Signed-off-by: Manik Rana <manikrana54@gmail.com> * refac: pass pointer of buf into seriesHash() Signed-off-by: Manik Rana <manikrana54@gmail.com> --------- Signed-off-by: Manik Rana <manikrana54@gmail.com> Signed-off-by: Manik Rana <Manikrana54@gmail.com> Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com> Co-authored-by: George Krajcsovits <krajorama@users.noreply.github.com>	2024-10-10 12:01:13 +01:00
Björn Rabenstein	8b545bab2f	Merge pull request #15026 from huochexizhan/main ... fix: fix slice init length	2024-10-10 12:55:28 +02:00
Björn Rabenstein	720a2599a6	Merge pull request #15135 from prometheus/beorn7/docs ... docs: Update chunk layot for NHCB	2024-10-10 12:00:51 +02:00
huochexizhan	ff16fa1827	fix: fix slice init length ... Signed-off-by: huochexizhan <huochexizhan@outlook.com>	2024-10-10 16:14:40 +08:00
beorn7	12c39d5421	docs: Some nitpicking in chunks.md ... - `float histogram` → `floathistogram`, as it is used in the code. - Actual link encodings to the code (to find the actual numerical values). - `<bytes>` → `<data>` for consistency. Signed-off-by: beorn7 <beorn@grafana.com>	2024-10-09 14:32:12 +02:00
beorn7	a4cb52ff15	docs: Update chunk layot for NHCB ... Signed-off-by: beorn7 <beorn@grafana.com>	2024-10-09 14:19:20 +02:00
Björn Rabenstein	02d0de9987	Merge pull request #14997 from fionaliao/fl/update-format-docs ... Update chunk format docs with native histograms and OOO	2024-10-09 13:29:01 +02:00
Björn Rabenstein	5e987e7c7d	Merge pull request #15092 from jan--f/clarify-storage-contract ... storage: require selectors to always return matching results	2024-10-09 13:07:59 +02:00
Bryan Boreham	eaf98049e5	Few more 3.0-beta.1 CHANGELOGs ... Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	2024-10-08 18:15:55 +01:00
Bryan Boreham	eb90f238b7	Update CHANGELOG to commit 90f7832447 ... Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	2024-10-08 17:31:05 +01:00
Bryan Boreham	9623681543	Prepare 3.0.0-beta.1 ... Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	2024-10-08 17:27:10 +01:00
Julius Volz	90f7832447	Merge pull request #15084 from hvnsweeting/patch-1 ... docs: Querying basics: remove what can be graphed	2024-10-08 14:59:07 +02:00
Fiona Liao	8650d25804	Add additional basic nhcb unit tests (#15086) ... * Add additional basic nhcb unit tests * Update promql/promqltest/testdata/histograms.test Signed-off-by: Fiona Liao <fiona.liao@grafana.com> Signed-off-by: Fiona Liao <fiona.y.liao@gmail.com> Co-authored-by: George Krajcsovits <krajorama@users.noreply.github.com>	2024-10-08 14:34:32 +02:00
Viet Hung Nguyen	f0a9f62ce8	[DOCS] Querying basics: what can be graphed ... Put a scalar to query, it can be graphed. So the doc says "an expression that returns an instant vector is the only type which can be graphed." is not correct? And also, a query_range, which used for graph, always return a range vector <https://promlabs.com/blog/2020/06/18/the-anatomy-of-a-promql-query/#range-queries> , so it's confusing to read the above statement. Signed-off-by: Viet Hung Nguyen <hvn@familug.org>	2024-10-08 21:16:26 +09:00
Bryan Boreham	663a66b526	Merge pull request #11224 from dekimsey/consul-catalog-filter-support ... consul: Initial implemenation of catalog filter support	2024-10-08 12:38:17 +01:00
Bryan Boreham	b87b88ddc2	Merge branch 'main' into consul-catalog-filter-support ... Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	2024-10-08 12:20:31 +01:00
Björn Rabenstein	576000a457	Merge pull request #15111 from prometheus/beorn7/doc ... docs: Declare "float literals are time durations" as stable	2024-10-08 12:49:40 +02:00
Julius Volz	7b6259b29b	Merge pull request #15127 from roidelapluie/assets ... Add a note for pre-built assets	2024-10-08 11:37:20 +02:00
Julien	e5f604eb9a	Merge pull request #15045 from prometheus/dependabot/go_modules/github.com/klauspost/compress-1.17.10 ... Bump github.com/klauspost/compress from 1.17.9 to 1.17.10	2024-10-08 11:25:58 +02:00
Julien	24caa3653d	Merge pull request #15040 from prometheus/dependabot/go_modules/github.com/digitalocean/godo-1.126.0 ... Bump github.com/digitalocean/godo from 1.122.0 to 1.126.0	2024-10-08 11:25:37 +02:00
Julien	8406aa9c9c	Add a note for pre-built assets ... Signed-off-by: Julien <roidelapluie@o11y.eu>	2024-10-08 11:23:01 +02:00
dependabot[bot]	5dc59acada	Bump github.com/klauspost/compress from 1.17.9 to 1.17.10 ... Bumps [github.com/klauspost/compress](https://github.com/klauspost/compress) from 1.17.9 to 1.17.10. - [Release notes](https://github.com/klauspost/compress/releases) - [Changelog](https://github.com/klauspost/compress/blob/master/.goreleaser.yml) - [Commits](https://github.com/klauspost/compress/compare/v1.17.9...v1.17.10) --- updated-dependencies: - dependency-name: github.com/klauspost/compress dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>	2024-10-07 20:27:02 +00:00
dependabot[bot]	f3358f3c31	Bump github.com/digitalocean/godo from 1.122.0 to 1.126.0 ... Bumps [github.com/digitalocean/godo](https://github.com/digitalocean/godo) from 1.122.0 to 1.126.0. - [Release notes](https://github.com/digitalocean/godo/releases) - [Changelog](https://github.com/digitalocean/godo/blob/main/CHANGELOG.md) - [Commits](https://github.com/digitalocean/godo/compare/v1.122.0...v1.126.0) --- updated-dependencies: - dependency-name: github.com/digitalocean/godo dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>	2024-10-07 20:26:35 +00:00
Ben Kochie	805954d8f8	Merge pull request #14906 from tjhop/chore/3.0-adopt-slog ... chore!: adopt log/slog, remove go-kit/log	2024-10-07 22:25:16 +02:00
TJ Hoplock	6ebfbd2d54	chore!: adopt log/slog, remove go-kit/log ... For: #14355 This commit updates Prometheus to adopt stdlib's log/slog package in favor of go-kit/log. As part of converting to use slog, several other related changes are required to get prometheus working, including: - removed unused logging util func `RateLimit()` - forward ported the util/logging/Deduper logging by implementing a small custom slog.Handler that does the deduping before chaining log calls to the underlying real slog.Logger - move some of the json file logging functionality to use prom/common package functionality - refactored some of the new json file logging for scraping - changes to promql.QueryLogger interface to swap out logging methods for relevant slog sugar wrappers - updated lots of tests that used/replicated custom logging functionality, attempting to keep the logical goal of the tests consistent after the transition - added a healthy amount of `if logger == nil { $makeLogger }` type conditional checks amongst various functions where none were provided -- old code that used the go-kit/log.Logger interface had several places where there were nil references when trying to use functions like `With()` to add keyvals on the new *slog.Logger type Signed-off-by: TJ Hoplock <t.hoplock@gmail.com>	2024-10-07 15:58:50 -04:00
Julius Volz	65f6103539	Merge pull request #15118 from roidelapluie/notificationsdoc ... Document the notifications API	2024-10-07 15:50:06 +02:00
Julien	7eb73b10d8	Remove http client config from consul and digitalocean ... Signed-off-by: Julien <roidelapluie@o11y.eu>	2024-10-07 15:13:00 +02:00