Augustin Husson
452f4c96b7
Cut v2.50.0-rc.0 ( #13465 )
...
Signed-off-by: Augustin Husson <husson.augustin@gmail.com>
2024-02-13 10:21:23 +01:00
Bryan Boreham
ff6c83269c
Merge pull request #13452 from bboreham/go-cmp
...
Tests: Use DeepEqual replacement using go-cmp, which is more flexible
2024-02-12 15:40:08 +01:00
Björn Rabenstein
1efca80956
Merge pull request #13559 from prometheus/beorn7/promql
...
promql: Fix wrongly scoped range vectors
2024-02-12 14:34:33 +01:00
pschou
b66b0a5288
docs: improve "Querying Prometheus" readability ( #8492 )
...
Signed-off-by: schou <pschou@users.noreply.github.com>
Co-authored-by: George Krajcsovits <krajorama@users.noreply.github.com>
Co-authored-by: Bryan Boreham <bjboreham@gmail.com>
2024-02-09 17:37:14 +00:00
Bryan Boreham
12cac5bd5c
tsdb tests: use go-cmp instead of DeepEquals
...
Also one simpler call checking nil.
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2024-02-08 19:32:33 +00:00
Bryan Boreham
17f48f2b3b
Tests: use replacement DeepEquals in more places
...
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2024-02-08 19:32:33 +00:00
Bryan Boreham
d0dee51aac
scrape tests: check NaN values directly
...
Normally, a NaN value is never equal to any other value. Compare sample
values via `Float64bits` so that NaN values which are exactly the same
will compare equal.
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2024-02-08 19:30:20 +00:00
Bryan Boreham
5a6c8f9c15
promtool: use go-cmp instead of DeepEqual
...
go-cmp allows more control over unexported fields and implementation
details.
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2024-02-08 19:30:20 +00:00
Bryan Boreham
39af788dbd
Tests: use replacement DeepEquals using go-cmp
...
Use DeepEqual replacement using go-cmp, which is more flexible.
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2024-02-08 19:30:20 +00:00
Bryan Boreham
d77c30102e
utils: add DeepEqual replacement using go-cmp
...
go-cmp allows control over how unexported fields and implementation
details are handled.
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2024-02-08 19:30:20 +00:00
beorn7
553d92affd
model/labels: Fix new lint warning in test
...
Signed-off-by: beorn7 <beorn@grafana.com>
2024-02-07 18:12:26 +01:00
beorn7
86d7618d84
promql: Fix wrongly scoped range vectors
...
Fixes #11708 .
If a range vector is fixen in time with the @ modifier, it gets still
moved around for different steps in a range query. Since no additional
points are retrieved from the TSDB, this leads to steadily emptying
the range, leading to the weird behavior described in isse #11708 .
This only happens for functions listed in `AtModifierUnsafeFunctions`,
and the only of those that takes a range vector is `predict_linear`,
which is the reason why we see it only for this particular function.
Signed-off-by: beorn7 <beorn@grafana.com>
2024-02-07 18:07:51 +01:00
beorn7
384ab025e0
promql: Expose issue #11708
...
The shorter range in the test makes early points drop out of the range
in range queries, exposing the issue.
Signed-off-by: beorn7 <beorn@grafana.com>
2024-02-07 18:06:05 +01:00
Bryan Boreham
8655fe5401
Merge pull request #13491 from bboreham/faster-store-series
...
storage/remote: speed up StoreSeries by re-using labels.Builder
2024-02-06 17:16:32 +01:00
Bryan Boreham
3ce816fa3b
Merge pull request #13492 from bboreham/no-labelstrings-intern
...
labels: make InternStrings a no-op for stringlabels version
2024-02-06 17:15:10 +01:00
Arve Knudsen
0853e52f4e
util/runtime: Ignore nolintlint failure on OSX ( #13546 )
...
util/runtime: Make nolintlint ignore unconvert linter directive
---------
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
2024-02-06 13:53:37 +01:00
Björn Rabenstein
0a3fd8d958
Merge pull request #13543 from aknuds1/arve/portable-genproto
...
scripts/genproto.sh: Support OSX sed
2024-02-06 13:53:01 +01:00
Bryan Boreham
87e4284c99
Merge pull request #13545 from aknuds1/arve/golangci-lint-arm64
...
Makefile: enable golangci-lint on ARM64
2024-02-06 11:26:48 +01:00
Arve Knudsen
7d7787f250
Makefile: Support golangci-lint on ARM64
...
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
2024-02-06 13:51:16 +04:00
Arve Knudsen
e43a1d546a
scripts/genproto.sh: Support OSX sed
...
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
2024-02-06 12:34:03 +04:00
Bryan Boreham
6005ac6f9d
Merge pull request #9311 from Creatone/creatone/use-testify-3
...
tests: Move from t.Errorf and others. (Part 3)
2024-02-05 18:48:59 +01:00
Peter Štibraný
e2b9cfeeeb
Enforce chunks ordering when writing index. ( #8085 )
...
Document conditions on chunks. Add check on chunk time ordering.
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
2024-02-04 16:31:49 +01:00
Bryan Boreham
98c4889029
Merge pull request #9298 from Creatone/creatone/use-testify
...
tests: Move from t.Errorf and others.
2024-02-04 16:27:57 +01:00
Bryan Boreham
857138d3ce
review feedback
...
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2024-02-04 15:52:50 +01:00
Bryan Boreham
41f3eeb048
Merge pull request #13497 from captncraig/cmp_signedheaders
...
storage/remote: apply custom headers before sigv4 transport
2024-02-04 14:46:14 +01:00
Bryan Boreham
d3c1f0d8e0
promql: can now remove regex field from EvalNodeHelper
...
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2024-02-04 11:32:26 +01:00
Bryan Boreham
fdd5b85e06
promql: faster range-query of label_replace and label_join
...
These functions act on the labels only, so don't need to go step by step
over the samples in a range query.
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2024-02-04 11:12:55 +01:00
Matthias Loibl
805d51f6d3
Merge pull request #13505 from wbollock/fix/PrometheusNotIngestingSamples_label_matching
...
mixin: PrometheusNotIngestingSamples label matching
2024-02-03 11:53:18 +00:00
gotjosh
aa845f7c12
Merge pull request #13527 from pracucci/decouple-rule-concurrency-and-dependency-controller
...
Decouple ruler dependency controller from concurrency controller
2024-02-02 17:40:02 +01:00
Marco Pracucci
5ee3fbe825
Decouple ruler dependency controller from concurrency controller
...
Signed-off-by: Marco Pracucci <marco@pracucci.com>
2024-02-02 10:06:37 +01:00
Mikhail Fesenko
419dd265cc
Fix strange code, add messages to code brought in #8106 ( #13509 )
...
Signed-off-by: Mikhail Fesenko <proggga@gmail.com>
2024-02-02 10:00:38 +01:00
Faustas Butkus
6feffeb92e
promql: add histogram_avg function ( #13467 )
...
Add histogram_avg function
---------
Signed-off-by: Faustas Butkus <faustas.butkus@gmail.com>
Signed-off-by: Björn Rabenstein <github@rabenste.in>
Co-authored-by: Björn Rabenstein <github@rabenste.in>
2024-02-01 18:28:42 +01:00
Alan Protasio
c006c57efc
Proposal to improve FPointSlice and HPointSlice allocation. ( #13448 )
...
* Reusing points slice from previous series when the slice is under utilized
* Adding comments on the bench test
Signed-off-by: Alan Protasio <alanprot@gmail.com>
2024-02-01 16:22:38 +00:00
Bryan Boreham
b17f88b7fb
consul sd tests: don't call FailNow from a background goroutine
...
This is not allowed by the Go test framework.
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2024-02-01 15:15:48 +00:00
Bryan Boreham
46008fdecd
lint
...
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2024-02-01 14:57:11 +00:00
Bryan Boreham
16e68c01e4
tests: remove err from message when testify prints it already
...
For instance `require.NoError` will print the unexpected error; we don't
need to include it in the message.
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2024-02-01 14:18:01 +00:00
Paweł Szulik
1a47c7d59b
Refactor lexer tests to use testify.
...
Signed-off-by: Paweł Szulik <paul.szulik@gmail.com>
2024-02-01 13:51:31 +00:00
Paweł Szulik
b0c538787d
Refactor scrape tests to use testify.
...
Signed-off-by: Paweł Szulik <paul.szulik@gmail.com>
2024-02-01 13:51:31 +00:00
Paweł Szulik
6e9cca8158
Refactor web tests to use testify.
...
Signed-off-by: Paweł Szulik <paul.szulik@gmail.com>
2024-02-01 13:51:31 +00:00
Paweł Szulik
d5eb636a89
Refactor cmd tests to use testify.
...
Signed-off-by: Paweł Szulik <paul.szulik@gmail.com>
2024-02-01 13:51:31 +00:00
Mikhail Fesenko
5f2c3a5d3e
Small improvements, add const, remove copypasta ( #8106 )
...
Signed-off-by: Mikhail Fesenko <proggga@gmail.com>
Signed-off-by: Jesus Vazquez <jesusvzpg@gmail.com>
2024-02-01 14:30:50 +01:00
Ayoub Mrini
581d8d86b4
Pod status changes not discovered by Kube Endpoints SD ( #13337 )
...
* fix(discovery/kubernetes/endpoints): react to changes on Pods because some modifications can occur on them without triggering an update on the related Endpoints (The Pod phase changing from Pending to Running e.g.).
---------
Signed-off-by: machine424 <ayoubmrini424@gmail.com>
Co-authored-by: Guillermo Sanchez Gavier <gsanchez@newrelic.com>
2024-02-01 12:34:37 +00:00
Paweł Szulik
7f24efccdb
Refactor discovery tests to use testify.
...
Signed-off-by: Paweł Szulik <paul.szulik@gmail.com>
2024-01-31 16:42:11 +00:00
Paweł Szulik
5961f78186
Refactor tsdb tests to use testify.
...
Signed-off-by: Paweł Szulik <paul.szulik@gmail.com>
2024-01-31 16:03:17 +00:00
Will Bollock
839b9e5b53
fix: PrometheusNotIngestingSamples label matching
...
This alert will never return anything as the left side of the query has
the labels `[component, environment, instance, job, type]` while the
right side has `[component, environment, instance, job]`.
The `type` label was added to `prometheus_tsdb_head_samples_appended_total` in this PR but the mixin wasn't updated
for the new label: https://github.com/prometheus/prometheus/pull/11395
This was found with [pint](https://github.com/cloudflare/pint ) PromQL
linting
Signed-off-by: Will Bollock <wbollock@linode.com>
2024-01-31 09:08:36 -05:00
Bryan Boreham
34875ae8c7
Merge pull request #13499 from bboreham/tweak-remote-tests
...
storage/remote: document why two benchmarks are skipped
2024-01-31 12:02:12 +00:00
Bryan Boreham
b9fdf3dad1
storage/remote: document why two benchmarks are skipped
...
One was silently doing nothing; one was doing something but the work
didn't go up linearly with iteration count.
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2024-01-30 16:48:04 +00:00
gotjosh
ae2852be6a
Merge pull request #12946 from dannykopping/dannykopping/rule-deps
...
Evaluate independent rules concurrently
2024-01-30 15:27:16 +00:00
Craig Peterson
5b5230deb7
remote client: apply custom headers before sigv4 transport
...
Signed-off-by: Craig Peterson <192540+captncraig@users.noreply.github.com>
2024-01-30 09:27:00 -05:00
Bryan Boreham
cd4562d3a6
Merge pull request #13473 from bboreham/pure-mutex
...
tsdb: use cheaper Mutex on series
2024-01-30 09:57:08 +00:00