* Decouple remote client from ReadRecent feature.
* Separate remote read filter into a small, testable function.
* Use storage.Queryable interface to compose independent
functionalities.
In order to compose different querier implementations more easily, this
change introduces a separate storage.Queryable interface grouping the
query (Querier) function of the storage.
Furthermore, it adds a QueryableFunc type to ease writing very simple
queryable implementations.
* Adds a test covering the case where a target providers sends updated versions of the same target groups and the system should reconcile to the latest version of each of the target groups
* Refactors how input data is represented in the tests. It used to be literal declarations of necessary structs, now it is parsing yaml. Yaml declarations are half as long as the former. And these can be put in a fixture file
* Adds a tiny bit of refactoring on test timeouts
The labelsets returned from remote read are mutated in higher levels
(like seriesFilter.Labels()) and since the concreteSeriesSet didn't
return a copy, the external mutation affected the labelset in the
concreteSeries itself. This resulted in bizarre bugs where local and
remote series would show with identical label sets in the UI, but not be
deduplicated, since internally, a series might come to look like:
{__name__="node_load5", instance="192.168.1.202:12090", job="node_exporter", node="odroid", node="odroid"}
(note the repetition of the last label)
* flaky test caused by invalid fsnotify updates before the test files are written to disk causing the fd service to send empty `group[]` struct
* `close(filesReady)` needs to be before the file closing so that fsnotify triggers a new loop of the discovery service.
* nits
* use filepath.Join for the path url to be cross platform
* stupid mistake revert
* Use testutil in rules subpackage
* Fix manager test
* Use testutil in rules subpackage
* Fix manager test
* Fix rebase
* Change to testutil for applyConfig tests
This PR fixes#3072 by providing POST endpoints for `query` and `query_range`.
POST request must be made with `Content-Type: application/x-www-form-urlencoded` header.
* promu: Use same go invocation as prometheus' for building
If you override $(GO) var in prometheus Makefile in order to use
a custom go binary you might encounter errors while building promu
as promu's Makefile $(GO) var is also defined to look for go in the
$PATH and you might end up using different go binaries for building
prometheus and promu.
This patch makes prometheus Makefile pass its $(GO) var to promu's makefile
as environmental variable.
Signed-off-by: Sylvain Rabot <s.rabot@lectra.com>
* Makefile: Allow $(GO) to be set with environmental variable
Signed-off-by: Sylvain Rabot <s.rabot@lectra.com>
* Makefile: Fix hardcoded call to gofmt
Signed-off-by: Sylvain Rabot <s.rabot@lectra.com>
This doesn't perform any actual updates. (While that is something that
we should consider eventually, it leads down a rabbit hole and would
be too risky just before the 2.0.0 release.)
This is really just a clean-up. In particular:
- The following packages are not really used and thus removed:
- github.com/blang/semver
- github.com/coreos/go-oidc/http
- github.com/coreos/go-oidc/jose
- github.com/coreos/go-oidc/key
- github.com/coreos/go-oidc/oauth2
- github.com/coreos/go-oidc/oidc
- github.com/coreos/pkg/health
- github.com/coreos/pkg/httputil
- github.com/coreos/pkg/timeutil
- github.com/gophercloud/gophercloud/openstack/compute/v2/extensions
- github.com/pborman/uuid
- For unclear reasons, the checksum for the following packages were
wrong. The only change in this commit is to adjust the checksum in
vendor.json. No changes of source code involved.
- github.com/cespare/xxhash
- github.com/dgryski/go-bits
- github.com/golang/snappy
- Various packages from the github.com/gogo/protobuf repository are
used throughout the code. They are vendored from various sources
(different sub-vendoring of cockroachdb/cockroach and
k8s.io/client-go) and revisions. I made them all consistently
referring to the current version of the github.com/gogo/protobuf
repository. This _is_ a change of code, but a necessary one to clean
up the inconsistencies.
- For the github.com/influxdata/influxdb/... packages, the license
files were missing. Also, the revision time was wrong, again for
unknown reason.
This tries to avoid any real updates (as that would lead down a rabbit
hole, although I think we should check what dependencies need an
update one day) but at least tries to remove unused packages.
With the merge of dev-2.0 into master, the local storage code I used
to own has disappeared. @fabxc is the obvious most qualified person
for the new storage code.
Leaving me in just for “general code-level issues” would suggest I'm
in some overarching code custodian role, which doesn't really match
reality.
Open for other suggestions.
