71 commits

Author	SHA1	Message	Date
Neeraj Gartia	d4b1f9eb33	Corrects the behaviour of binary opperators between histogram and float (#14726) ... promql: corrects binary operators functioning for mixed sample with histogram and float For invalid pairings of sample types, an annotation is added now. Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com> --------- Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>	2024-10-15 14:44:36 +02:00
Björn Rabenstein	5b9148e552	Merge pull request #14820 from charleskorn/promqltest-native-histogram-format ... promqltest: use test expression format for histograms in assertion failure messages and include reset hint in the test expression	2024-09-20 16:47:08 +02:00
Charles Korn	6dbb4e1a94	Fix linting issues ... Signed-off-by: Charles Korn <charles.korn@grafana.com>	2024-09-20 11:49:54 +10:00
Nathan Baulch	50cd453c8f	chore: Fix typos (#14868) ... * Fix typos --------- Signed-off-by: Nathan Baulch <nathan.baulch@gmail.com>	2024-09-10 22:32:03 +02:00
Charles Korn	e67358d203	histogram: include counter reset hint in test expression output ... Signed-off-by: Charles Korn <charles.korn@grafana.com>	2024-09-04 15:46:52 +10:00
Jeanette Tan	9adc1699c3	fix according to code review ... Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	2024-06-07 18:50:59 +08:00
zenador	545a7e48f9	[nhcb branch] Enhance unit test framework for nhcb and warnings (#14009) ... * process custom values in histogram unit test framework * check for warnings when evaluating in unit test framework * add test cases for custom buckets in test framework Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	2024-05-08 13:58:24 +02:00
zenador	4acbb7dea6	Add custom buckets to native histogram chunks encoding (#13706) ... * add custom bounds to chunks encoding * change custom buckets schema number * rename custom bounds to custom values Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	2024-03-22 14:36:39 +01:00
György Krajcsovits	5d0a0a7542	Add custom buckets to native histogram model (#13592) ... * add custom buckets to native histogram model * simple copy for custom bounds * return errors for unsupported add/sub operations * add test cases for string and update appendhistogram in scrape to account for new schema * check fields which are supposed to be unused but may affect results in equals * allow appending custom buckets histograms regardless of max schema Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	2024-02-28 14:06:43 +01:00
Filip Petkovski	583f3e587c	Optimize histogram iterators (#13340) ... Optimize histogram iterators Histogram iterators allocate new objects in the AtHistogram and AtFloatHistogram methods, which makes calculating rates over long ranges expensive. In #13215 we allowed an existing object to be reused when converting an integer histogram to a float histogram. This commit follows the same idea and allows injecting an existing object in the AtHistogram and AtFloatHistogram methods. When the injected value is nil, iterators allocate new histograms, otherwise they populate and return the injected object. The commit also adds a CopyTo method to Histogram and FloatHistogram which is used in the BufferedIterator to overwrite items in the ring instead of making new copies. Note that a specialized HPoint pool is needed for all of this to work (`matrixSelectorHPool`). --------- Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> Co-authored-by: George Krajcsovits <krajorama@users.noreply.github.com>	2024-01-23 17:02:14 +01:00
zenador	a3ddfbd1ee	Add warnings for histogramRate applied with isCounter not matching counter/gauge histogram (#13392) ... Add warnings for histogramRate applied with isCounter not matching counter/gauge histogram --------- Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	2024-01-17 17:06:35 +01:00
Björn Rabenstein	928d07e3bd	Merge branch 'main' into arve/typos ... Signed-off-by: Björn Rabenstein <beorn@grafana.com>	2023-12-12 12:02:03 +01:00
Björn Rabenstein	85078b968f	Merge pull request #13208 from linasm/panic-free-float-histogram-add-sub ... FloatHistogram.Add/Sub: handle any schema change	2023-12-07 20:12:21 +01:00
Björn Rabenstein	de1ec731c7	Merge pull request #13212 from linasm/optimize-floatBucketIterator-for-common-case ... Histograms: optimize floatBucketIterator for common case	2023-12-07 20:11:58 +01:00
Linas Medziunas	bd895baefc	FloatHistogram.Add/Sub: handle any schema change ... Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com>	2023-12-07 20:50:54 +02:00
Arve Knudsen	237bfea46b	chunks.Reader: Fix typo in ChunkOrIterable doc string. ... Also fix comment typo in `FloatHistogram.Sub`. Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	2023-12-07 08:28:45 +01:00
Oleksandr Redko	2a75604f8e	Enable default revive rules (#13068) ... Signed-off-by: Oleksandr Redko <Oleksandr_Redko@epam.com>	2023-11-29 17:23:34 +00:00
Linas Medziunas	048886ae8a	Histograms: optimize floatBucketIterator for common case ... Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com>	2023-11-29 08:54:05 +02:00
Linas Medziunas	49613823f8	Reuse slices in [Float]Histogram.ReduceResolution ... Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com>	2023-11-28 15:45:31 +02:00
Björn Rabenstein	a6d4b8d97b	Merge pull request #13190 from linasm/fix-float-histogram-add-sub-mutating-argument ... Fix FloatHistogram.Add/Sub mutating its argument	2023-11-28 14:04:50 +01:00
Linas Medziunas	f99ecc376e	Fix FloatHistogram.Add/Sub mutating its argument ... Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com>	2023-11-26 09:26:34 +02:00
Linas Medziunas	ea1862aab4	Explicit schema check in [Float]Histogram.ReduceResolution ... Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com>	2023-11-25 11:38:15 +02:00
Ziqi Zhao	e250f09b5d	change origin schema in ReduceResolution method of histogram and float histogram (#13116) ... * change origin schema in ReduceResolution method of histogram and float histogram Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com> --------- Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>	2023-11-10 14:33:34 +01:00
Ziqi Zhao	ab2a7bb74f	add generic shrink function (#13001) ... Add `ReduceResolution` method to `Histogram` and `FloatHistogram` This takes the original `mergeToSchema` function and turns it into a more generic `reduceResolution` function, which is the building block for the new methods. The methods will help with addressing #12864. --------- Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>	2023-11-08 14:43:05 +01:00
Matthieu MOREL	05fba53e57	web : use Go standard package ... Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	2023-11-08 06:37:59 +00:00
Linas Medziunas	ebed7d0612	Change Validate to be a method on histogram structs ... Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com>	2023-11-03 16:47:59 +02:00
Linas Medžiūnas	e3e22abadb	Merge branch 'main' into linasm/optimize-floatBucketIterator2 ... Signed-off-by: Linas Medžiūnas <linasm@users.noreply.github.com>	2023-10-24 16:27:10 +03:00
Marc Tuduri	af7c31ee10	PR feedback ... Signed-off-by: Marc Tuduri <marctc@protonmail.com>	2023-10-18 11:53:50 +02:00
Marc Tuduri	8fededf6ad	promql(histograms): Change sample total calculation for histograms ... Signed-off-by: Marc Tuduri <marctc@protonmail.com>	2023-10-18 11:51:11 +02:00
Linas Medziunas	62bbb81e29	Mention bucket values in the comment ... Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com>	2023-10-14 21:30:40 +03:00
Linas Medziunas	ec823d9daf	Update comments, bitwise comparison of float buckets ... Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com>	2023-10-09 16:09:46 +03:00
Linas Medziunas	c5c5c569fa	Histogram performance: optimize floatBucketIterator ... Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com>	2023-10-09 09:40:59 +03:00
Linas Medziunas	3c047a3518	Expand docs comments ... Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com>	2023-09-28 09:08:09 +03:00
Linas Medziunas	dfb6292600	Compare FloatHistogram.[Zero]Count float values as binary ... Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com>	2023-09-28 09:06:54 +03:00
Linas Medziunas	cbd01fc296	Fix NaN sum check in [Float]Histogram.Equals method ... Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com>	2023-09-25 16:03:55 +03:00
Gregor Zeitlinger	f01718262a	Unit tests for native histograms (#12668) ... promql: Extend testing framework to support native histograms This includes both the internal testing framework as well as the rules unit test feature of promtool. This also adds a bunch of basic tests. Many of the code level tests can now be converted to tests within the framework, and more tests can be added easily. --------- Signed-off-by: Harold Dost <h.dost@criteo.com> Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com> Signed-off-by: Stephen Lang <stephen.lang@grafana.com> Co-authored-by: Harold Dost <h.dost@criteo.com> Co-authored-by: Stephen Lang <stephen.lang@grafana.com> Co-authored-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>	2023-08-25 23:35:42 +02:00
zenador	54aaa2bd7e	Add histogram_stdvar and histogram_stddev functions (#12614) ... * Add new function: histogram_stdvar and histogram_stddev Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	2023-08-24 21:02:14 +02:00
Ziqi Zhao	de172049ab	fix lint error ... Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>	2023-08-24 07:27:33 +08:00
Ziqi Zhao	d3633d4e76	Update model/histogram/float_histogram.go ... Co-authored-by: Björn Rabenstein <github@rabenste.in> Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>	2023-08-24 07:17:23 +08:00
Ziqi Zhao	893f97556f	use switch instead of if-else to fix lint error ... Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>	2023-08-23 13:13:25 +08:00
Ziqi Zhao	788061e509	remove unused addBucket function ... Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>	2023-08-23 12:55:59 +08:00
Ziqi Zhao	eab3c93e80	make code ready for review ... Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>	2023-08-23 12:52:24 +08:00
Ziqi Zhao	4787c879bc	add more elaborate benchmark test ... Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>	2023-08-21 13:28:06 +08:00
Ziqi Zhao	bf880a6e77	enhance floathistogram add and sub method ... Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>	2023-08-16 22:26:31 +08:00
Ziqi Zhao	ed1b307bca	enhance FloatHistogram CopyToSchema method (#12596) ... histogram: Improve performance of FloatHistogram.CopyToSchema Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com> --------- Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com> Co-authored-by: Björn Rabenstein <github@rabenste.in>	2023-07-27 13:27:13 +02:00
beorn7	9aadd54786	histogram: Fix bounds of buckets returned by floatBucketIterator ... The bounds weren't really used so far, so no actual bug in the code so far. But it's obviously confusing if the bounds returned by a floatBucketIterator with a target schema different from the original schema are wrong. Signed-off-by: beorn7 <beorn@grafana.com>	2023-07-19 18:19:18 +02:00
cui fliter	096ceca44f	remove repetitive words (#12556) ... Signed-off-by: cui fliter <imcusg@gmail.com>	2023-07-13 15:53:40 +02:00
Ziqi Zhao	42d9169ba1	enhance histogram_quantile to get min/max value ... Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>	2023-07-12 04:29:54 +08:00
Carrie Edwards	a462f7fa21	Add function for iterating through all buckets in reverse to find max bucket ... Signed-off-by: Carrie Edwards <edwrdscarrie@gmail.com>	2023-07-11 21:51:20 +08:00
zenador	191bf9055b	Handle more arithmetic operators for native histograms (#12262) ... Handle more arithmetic operators and aggregators for native histograms This includes operators for multiplication (formerly known as scaling), division, and subtraction. Plus aggregations for average and the avg_over_time function. Stdvar and stddev will (for now) ignore histograms properly (rather than counting them but adding a 0 for them). Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	2023-05-16 21:15:20 +02:00