beorn7
4998b9750f
chunkenc: Bugfix and naming tweaks
...
Signed-off-by: beorn7 <beorn@grafana.com>
2021-10-19 15:38:32 +02:00
beorn7
78ef9c6359
chunkenc: make xor reading more DRY
...
Signed-off-by: beorn7 <beorn@grafana.com>
2021-10-19 15:28:33 +02:00
beorn7
4a1b84f8b2
chunkenc: make xor writing more DRY
...
Signed-off-by: beorn7 <beorn@grafana.com>
2021-10-19 15:28:33 +02:00
Björn Rabenstein
3704c6c20a
Merge pull request #9533 from prometheus/beorn7/sparsehistogram
...
tsdb: Complete chunk format documentation
2021-10-19 13:51:46 +02:00
beorn7
1a4e54cfbb
tsdb: Complete chunk format documentation
...
This also tweaks and fixes a few things done previously.
Signed-off-by: beorn7 <beorn@grafana.com>
2021-10-19 13:51:30 +02:00
Björn Rabenstein
b0a0bfb0a1
Merge pull request #9535 from prometheus/beorn7/testing
...
chunkenc: Add test for chunk layout encoding
2021-10-19 11:56:02 +02:00
beorn7
0876d57aea
chunkenc: Add test for chunk layout encoding
...
And fix a bug exposed by it...
Signed-off-by: beorn7 <beorn@grafana.com>
2021-10-18 19:37:24 +02:00
Björn Rabenstein
8c1507ebaa
Merge pull request #9509 from prometheus/beorn7/sparsehistogram
...
Histogram encoding improvementes
2021-10-18 15:45:20 +02:00
beorn7
ad9b4c2b68
Fix typos
...
Signed-off-by: beorn7 <beorn@grafana.com>
2021-10-18 15:44:13 +02:00
beorn7
fe50d6fc14
Update chunk layout documentation
...
Signed-off-by: beorn7 <beorn@grafana.com>
2021-10-15 23:18:41 +02:00
beorn7
ed33aea392
Avoid redundant varint decoding in chunk appender construction
...
Signed-off-by: beorn7 <beorn@grafana.com>
2021-10-15 20:33:14 +02:00
beorn7
d31bb75dc4
Use VarbitUint rather than VarbitInt to encode len(spans)
...
Signed-off-by: beorn7 <beorn@grafana.com>
2021-10-15 15:27:32 +02:00
beorn7
3179215a59
Encode zero threshold first
...
This guaranees that the zero threshold is byte-aligned. Not sure if
that helps in any way, but at least it won't harm.
Signed-off-by: beorn7 <beorn@grafana.com>
2021-10-14 14:55:21 +02:00
beorn7
c5522677bf
Improve encoding of zero threshold
...
Signed-off-by: beorn7 <beorn@grafana.com>
2021-10-14 14:47:26 +02:00
beorn7
7093b089f2
Use more varbit in histogram chunks
...
This adds bit buckets for larger numbers to varbit encoding and also
an unsigned version of varbit encoding.
Then, varbit encoding is used for all the histogram chunk data instead
of varint.
Signed-off-by: beorn7 <beorn@grafana.com>
2021-10-13 20:03:35 +02:00
Björn Rabenstein
7309c20e7e
Merge pull request #9500 from codesome/resettests
...
Add unit test for counter reset header
2021-10-13 18:19:21 +02:00
Ganesh Vernekar
dcaf568279
Metadata -> Layout renaming
...
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
2021-10-13 20:27:48 +05:30
Ganesh Vernekar
4e206c7c77
Fix reviews
...
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
2021-10-13 20:23:31 +05:30
Ganesh Vernekar
85e6686f84
Add unit test for counter reset header
...
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
2021-10-13 15:57:42 +05:30
Björn Rabenstein
311673d62e
Save on slice allocations in histogramIterator ( #9494 )
...
Signed-off-by: beorn7 <beorn@grafana.com>
2021-10-13 14:43:49 +05:30
beorn7
468a89f1bf
Merge branch 'sparsehistogram' of github.com:prometheus/prometheus into sparsehistogram
2021-10-12 15:30:48 +02:00
beorn7
94729d9936
Merge branch 'main' into sparsehistogram
2021-10-12 15:30:20 +02:00
Björn Rabenstein
c450c01eb9
Remove obsolete TODOs about metadata ( #9490 )
...
Signed-off-by: beorn7 <beorn@grafana.com>
2021-10-12 17:00:30 +05:30
Björn Rabenstein
9486be535b
Add deprecation notice for the pkg directory ( #9477 )
...
As per consensus expressed on the dev summit:
https://docs.google.com/document/d/11LC3wJcVk00l8w5P3oLQ-m3Y37iom6INAMEu2ZAGIIE/edit?pli=1#heading=h.80qrixk0sjgv
Signed-off-by: beorn7 <beorn@grafana.com>
2021-10-12 10:54:12 +02:00
Julien Pivotto
e245edf5a4
Fix Levi's name in MAINTAINERS.md ( #9491 )
...
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
2021-10-12 02:05:22 +02:00
Björn Rabenstein
354d8d2ecf
Merge pull request #9488 from prometheus/beorn7/release
...
Volunteer @roidelapluie and @juliusv as upcoming release shepherds
2021-10-11 19:14:44 +02:00
Julien Pivotto
81cb67eb95
Add Levi as maintainer ( #9487 )
...
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
2021-10-11 17:46:59 +02:00
beorn7
810c1081cf
Volunteer @roidelapluie and @juliusv as upcoming release shepherds
...
Signed-off-by: beorn7 <beorn@grafana.com>
2021-10-11 17:14:32 +02:00
Björn Rabenstein
12486b1250
Merge pull request #9481 from prometheus/beorn7/cleanup
...
Style cleanup of all the changes in sparsehistogram so far
2021-10-11 14:01:36 +02:00
beorn7
7a8bb8222c
Style cleanup of all the changes in sparsehistogram so far
...
A lot of this code was hacked together, literally during a
hackathon. This commit intends not to change the code substantially,
but just make the code obey the usual style practices.
A (possibly incomplete) list of areas:
* Generally address linter warnings.
* The `pgk` directory is deprecated as per dev-summit. No new packages should
be added to it. I moved the new `pkg/histogram` package to `model`
anticipating what's proposed in #9478 .
* Make the naming of the Sparse Histogram more consistent. Including
abbreviations, there were just too many names for it: SparseHistogram,
Histogram, Histo, hist, his, shs, h. The idea is to call it "Histogram" in
general. Only add "Sparse" if it is needed to avoid confusion with
conventional Histograms (which is rare because the TSDB really has no notion
of conventional Histograms). Use abbreviations only in local scope, and then
really abbreviate (not just removing three out of seven letters like in
"Histo"). This is in the spirit of
https://github.com/golang/go/wiki/CodeReviewComments#variable-names
* Several other minor name changes.
* A lot of formatting of doc comments. For one, following
https://github.com/golang/go/wiki/CodeReviewComments#comment-sentences
, but also layout question, anticipating how things will look like
when rendered by `godoc` (even where `godoc` doesn't render them
right now because they are for unexported types or not a doc comment
at all but just a normal code comment - consistency is queen!).
* Re-enabled `TestQueryLog` and `TestEndopints` (they pass now,
leaving them disabled was presumably an oversight).
* Bucket iterator for histogram.Histogram is now created with a
method.
* HistogramChunk.iterator now allows iterator recycling. (I think
@dieterbe only commented it out because he was confused by the
question in the comment.)
* HistogramAppender.Append panics now because we decided to treat
staleness marker differently.
Signed-off-by: beorn7 <beorn@grafana.com>
2021-10-11 13:02:03 +02:00
beorn7
fd5ea4e0b5
Merge branch 'main' into sparsehistogram
2021-10-07 23:16:42 +02:00
Björn Rabenstein
96f0683318
Merge pull request #9439 from codesome/counterresetmeta
...
Add info about counter resets in chunk meta
2021-10-07 21:42:55 +02:00
Ganesh Vernekar
5d4dc7e413
Convert the header into an enum
...
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
2021-10-07 19:53:24 +05:30
Pablo Caderno
b878527151
Added deferred close to 'http.File' opened ( #9443 ) ( #9461 )
...
Signed-off-by: Pablo Caderno <kaderno@gmail.com>
2021-10-06 13:02:46 +02:00
Ganesh Vernekar
175ef4ebcf
Add a NotCounterReset flag
...
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
2021-10-06 16:06:34 +05:30
Ganesh Vernekar
a280b6c2da
Fix review comments
...
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
2021-10-06 15:28:10 +05:30
Julien Pivotto
5a4c3734b1
Merge pull request #9457 from prometheus/release-2.30-merge
...
Merge release-2.30 branch into main
2021-10-05 21:12:46 +02:00
Ganesh Vernekar
10d4cb6dc0
Merge remote-tracking branch 'upstream/main' into release-2.30-merge
2021-10-05 20:35:14 +05:30
Ganesh Vernekar
f29caccc42
Cut v2.30.3 ( #9446 )
...
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
2021-10-05 20:31:30 +05:30
Ganesh Vernekar
9d81b2d610
Fix tests
...
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
2021-10-05 14:21:24 +05:30
Ganesh Vernekar
59d77ff16d
Fix build
...
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
2021-10-05 12:57:49 +05:30
Frederic Branczyk
a0819ca84f
Merge pull request #9436 from la3mmchen/fix/9269
...
fix/9269 add documentation for endpointslice
2021-10-05 08:54:42 +02:00
Ganesh Vernekar
10bc6e80ee
Fix panic on failed snapshot replay and don't hard fail replay on disabled exemplars ( #9438 )
...
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
2021-10-05 10:51:25 +05:30
Ganesh Vernekar
eb9931e961
Add info about counter resets in chunk meta
...
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
2021-10-04 18:44:12 +05:30
la3mmchen
6d3a4ed711
fix/9269 add documentation for endpointslice
...
This commits add a documentation for the kubernetes_sd_configs: endpointslice feature.
Signed-off-by: la3mmchen <alex@k3wl.net>
2021-10-03 21:30:39 +02:00
Mayursinh Sarvaiya
1270b87970
chore(ui): debounce effect in timerange query ( #9359 )
...
* chore(ui): debounce effect in timerange query
Signed-off-by: mayursiinh <marvinduff97@gmail.com>
* chore: private declaration of debounceExecuteQuery
Signed-off-by: mayursiinh <marvinduff97@gmail.com>
* fix: lint issue
Signed-off-by: mayursiinh <marvinduff97@gmail.com>
2021-10-03 15:05:16 +02:00
Ivana Huckova
a069e7ec80
Update api.md ( #9429 )
...
Fix timestamp in example in exemplars query. The year was `020` instead of `2020`.
Signed-off-by: Ivana <ivana.huckova@gmail.com>
2021-10-03 12:22:47 +02:00
Ganesh Vernekar
b30db03f35
Cut v2.30.2 ( #9426 )
...
* Don't error on overlapping m-mapped chunks during WAL replay (#9381 )
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
* Reduce log level during WAL replay on overlapping m-map chunks (#9425 )
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
* Cut v2.30.2
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
2021-10-01 17:00:22 +05:30
Ganesh Vernekar
a7d499e19a
Reduce log level during WAL replay on overlapping m-map chunks ( #9425 )
...
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
2021-10-01 15:33:29 +05:30
Ganesh Vernekar
8c597e5166
Don't error on overlapping m-mapped chunks during WAL replay ( #9381 )
...
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
2021-10-01 14:34:12 +05:30