Commit graph

12179 commits

Author SHA1 Message Date
Callum Styan a0f08a8365
Remote write v2: metadata support in every write request (#13394)
* Approach bundling metadata along with samples and exemplars

Signed-off-by: Paschalis Tsilias <paschalist0@gmail.com>

* Add first test; rebase with main

Signed-off-by: Paschalis Tsilias <paschalist0@gmail.com>

* Alternative approach: bundle metadata in TimeSeries protobuf

Signed-off-by: Paschalis Tsilias <paschalist0@gmail.com>

* update go mod to match main branch

Signed-off-by: Callum Styan <callumstyan@gmail.com>

* fix after rebase

Signed-off-by: Callum Styan <callumstyan@gmail.com>

* we're not going to modify the 1.X format anymore

Signed-off-by: Callum Styan <callumstyan@gmail.com>

* Modify AppendMetadata based on the fact that we be putting metadata into
timeseries

Signed-off-by: Callum Styan <callumstyan@gmail.com>

* Rename enums for remote write versions to something that makes more
sense + remove the added `sendMetadata` flag.

Signed-off-by: Callum Styan <callumstyan@gmail.com>

* rename flag that enables writing of metadata records to the WAL

Signed-off-by: Callum Styan <callumstyan@gmail.com>

* additional clean up

Signed-off-by: Callum Styan <callumstyan@gmail.com>

* lint

Signed-off-by: Callum Styan <callumstyan@gmail.com>

* fix usage of require.Len

Signed-off-by: Callum Styan <callumstyan@gmail.com>

* some clean up from review comments

Signed-off-by: Callum Styan <callumstyan@gmail.com>

* more review fixes

Signed-off-by: Callum Styan <callumstyan@gmail.com>

---------

Signed-off-by: Paschalis Tsilias <paschalist0@gmail.com>
Signed-off-by: Callum Styan <callumstyan@gmail.com>
Co-authored-by: Paschalis Tsilias <paschalist0@gmail.com>
2024-01-25 13:25:05 -08:00
Bartlomiej Plotka 242158e7fc
remote: Added test for classic histogram grouping when sending rw; Fixed queue manager test delay. (#13421)
Signed-off-by: bwplotka <bwplotka@gmail.com>
2024-01-24 12:47:59 +00:00
Bartlomiej Plotka f9dc544691
Merge pull request #13372 from prometheus/v2-proto-lint
change enum names to fit buf build recommend enum naming and lint rules
2024-01-04 12:28:23 +01:00
Callum Styan e290381b98 Merge branch 'main' into v2-proto-lint 2024-01-03 16:52:40 -08:00
Callum Styan 6ae6207a7f change enum names to fit buf build recommend enum naming and lint rules
Signed-off-by: Callum Styan <callumstyan@gmail.com>
2024-01-03 16:51:11 -08:00
Bryan Boreham 756202aa4f
Merge pull request #13262 from bboreham/agent-serieshashmap
agent: make the global hash lookup table smaller
2023-12-31 11:27:17 +00:00
Bryan Boreham bad3f23f23 agent: add BenchmarkCreateSeries
Based on the one in tsdb/head_test.go.

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2023-12-31 10:23:43 +00:00
Bryan Boreham e64d7d8928 agent: make the global hash lookup table smaller
This is the same change made in #13040, plus subsequent improvements,
applied to agent-mode code.

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2023-12-31 10:23:43 +00:00
Bartlomiej Plotka b67a61ac89
Merge pull request #13341 from prometheus/prw2.0-main1
Merge main into remote-write-2.0 for latest changes.
2023-12-31 11:15:59 +01:00
Bryan Boreham 1b74378a4c
Merge pull request #13344 from prometheus/revert-13293
Revert "Adding small test update for temp dir using t.TempDir (#13293)"
2023-12-30 22:11:48 +00:00
Bryan Boreham 252031c86f Revert "Adding small test update for temp dir using t.TempDir (#13293)"
This reverts commit 2ddb3596ef.

Various tests are failing in CI after this change; reverting to free up
other work.

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2023-12-30 19:17:30 +00:00
bwplotka 12c0425095 Merge branch 'main' into remote-write-2.0 2023-12-29 12:18:36 +00:00
Mile Druzijanic 2ddb3596ef
Adding small test update for temp dir using t.TempDir (#13293)
* Adding small test update for temp dir using t.TempDir

Signed-off-by: Mile Druzijanic <miledruz@gmail.com>
Signed-off-by: Mile Druzijanic <zedsprogramms@gmail.com>

* removing not required cleanup

Signed-off-by: Mile Druzijanic <zedsprogramms@gmail.com>

---------

Signed-off-by: Mile Druzijanic <miledruz@gmail.com>
Signed-off-by: Mile Druzijanic <zedsprogramms@gmail.com>
2023-12-28 21:49:57 +01:00
Nicolás Pazos 6a03f5a64c
Merge pull request #13052 from npazosmendez/alexnico-remote-write-1-1
remote write 2.0: new proto format with string interning
2023-12-28 16:49:05 -03:00
Nicolás Pazos acd035320c remove old MinSample proto message
Signed-off-by: Nicolás Pazos <npazosmendez@gmail.com>
2023-12-28 12:28:36 -03:00
Björn Rabenstein 6b8e945388
Merge pull request #13289 from fpetkovski/fix-histogram-reuse
Fix reusing float histograms
2023-12-25 22:45:03 +01:00
Filip Petkovski 0e1ae1d1ca
Add comment
Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
2023-12-25 11:41:07 +01:00
Filip Petkovski 35f9620cd1
Expand benchmark
Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
2023-12-25 11:30:29 +01:00
Filip Petkovski 5df3820c7a
Copy last histogram point
Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
2023-12-25 11:20:51 +01:00
Nicolás Pazos baebe1c59d make Metadata not nullable
Signed-off-by: Nicolás Pazos <npazosmendez@gmail.com>
2023-12-21 15:30:18 -03:00
Nicolás Pazos 175bd212cc make proto
Signed-off-by: Nicolás Pazos <npazosmendez@gmail.com>
2023-12-21 13:41:18 -03:00
Nicolás Pazos 6d90d71468 update prometheus version for example
Signed-off-by: Nicolás Pazos <npazosmendez@gmail.com>
2023-12-21 13:08:49 -03:00
Nicolás Pazos fe41ed9067 rename new proto types and move to separate pkg
Signed-off-by: Nicolás Pazos <npazosmendez@gmail.com>
2023-12-21 11:40:36 -03:00
Nicolás Pazos 38c444b942 lint
Signed-off-by: Nicolás Pazos <npazosmendez@gmail.com>
2023-12-21 10:08:15 -03:00
Nicolás Pazos 48f9285b11 define separate proto types for remote write 2.0
Signed-off-by: Nicolás Pazos <npazosmendez@gmail.com>
2023-12-21 09:59:52 -03:00
Julien Pivotto 0763ec841b
Merge pull request #13313 from kalpadiptyaroy/fix-quality-value-accept-header
bug: Fix quality value in accept header
2023-12-21 11:40:30 +01:00
Kumar Kalpadiptya Roy b012366c33 Issue #13268: fix quality value in accept header
Signed-off-by: Kumar Kalpadiptya Roy <kalpadiptya.roy@outlook.com>
2023-12-21 10:33:05 +05:30
Bryan Boreham 75fc8a1535
Merge pull request #13167 from bboreham/simplify-TargetsActive
scrape: simplify TargetsActive function
2023-12-20 12:27:50 +00:00
Bryan Boreham 4d44da2deb
Merge pull request #13176 from bboreham/move-metrictype
Move metric type definitions to common/model
2023-12-20 09:30:57 +00:00
Bryan Boreham 4ca0d57bb9
Merge pull request #13308 from bboreham/validate-relabel
relabel: improve logic for target labels
2023-12-20 09:30:26 +00:00
Bryan Boreham 096ec12912 Update comment about metadata in types.proto
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2023-12-19 18:56:54 +00:00
Bryan Boreham c83e1fc574 textparse: remove MetricType alias
No backwards-compatibility; make a clean break.

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2023-12-19 18:56:54 +00:00
Bryan Boreham 8065bef172 Move metric type definitions to common/model
They are used in multiple repos, so common is a better place for them.
Several packages now don't depend on `model/textparse`, e.g.
`storage/remote`.

Also remove `metadata` struct from `api.go`, since it was identical to
a struct in the `metadata` package.

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2023-12-19 18:56:54 +00:00
Nicolás Pazos 8df1d63885 update example prometheus version
Signed-off-by: Nicolás Pazos <npazosmendez@gmail.com>
2023-12-19 15:56:00 -03:00
Bryan Boreham 99c17b4319
Merge pull request #13177 from bboreham/less-madness
scrape: consistent function names for metadata
2023-12-19 17:51:52 +00:00
Nicolás Pazos a8224ccf3a revert package-lock.json changes
Signed-off-by: Nicolás Pazos <npazosmendez@gmail.com>
2023-12-19 14:31:10 -03:00
Nicolás Pazos d61fda90f2 fix server example
Signed-off-by: Nicolás Pazos <npazosmendez@gmail.com>
2023-12-19 14:29:29 -03:00
Nicolás Pazos 66f93860ce lint fixes
Signed-off-by: Nicolás Pazos <npazosmendez@gmail.com>
2023-12-19 14:29:29 -03:00
Nicolás Pazos dc0888c650 additional merge fixes
Signed-off-by: Nicolás Pazos <npazosmendez@gmail.com>
2023-12-19 14:29:29 -03:00
Nicolás Pazos 934de724ce lint
Signed-off-by: Nicolás Pazos <npazosmendez@gmail.com>
2023-12-19 14:29:29 -03:00
Nicolás Pazos 83325af699 fix custom marshaling
Signed-off-by: Nicolás Pazos <npazosmendez@gmail.com>
2023-12-19 14:29:29 -03:00
Nicolás Pazos 5aab80a71c don't reserve field 3 for new proto and add TODO
Signed-off-by: Nicolás Pazos <npazosmendez@gmail.com>
2023-12-19 14:29:29 -03:00
Nicolás Pazos 4cfd2eaf63 add some TODOs for later
Signed-off-by: Nicolás Pazos <npazosmendez@gmail.com>
2023-12-19 14:29:29 -03:00
Nicolás Pazos 25c8baeb6c cleanup rwSymbolTable
Signed-off-by: Nicolás Pazos <npazosmendez@gmail.com>
2023-12-19 14:29:29 -03:00
Nicolás Pazos ec9300fc1a remove all new rw formats but the []string one
also adapt tests to the new format

Signed-off-by: Nicolás Pazos <npazosmendez@gmail.com>
2023-12-19 14:29:29 -03:00
Nicolás Pazos 31d3956f47 new interning format based on []string indeces
Co-authored-by: bwplotka <bwplotka@gmail.com>
Signed-off-by: Nicolás Pazos <npazosmendez@gmail.com>
2023-12-19 14:29:29 -03:00
Callum Styan 3e48b8a582 fix minor lint issue + use labels Range function since it looks like
the tests fail to do `range labels.Labels` on CI

Signed-off-by: Callum Styan <callumstyan@gmail.com>
Signed-off-by: Nicolás Pazos <npazosmendez@gmail.com>
2023-12-19 14:29:29 -03:00
Callum Styan 18bf4b8c0e fix test panic
Signed-off-by: Callum Styan <callumstyan@gmail.com>
Signed-off-by: Nicolás Pazos <npazosmendez@gmail.com>
2023-12-19 14:29:29 -03:00
Callum Styan 7630577850 more cleanup, address review comments
Signed-off-by: Callum Styan <callumstyan@gmail.com>
Signed-off-by: Nicolás Pazos <npazosmendez@gmail.com>
2023-12-19 14:29:29 -03:00
Callum Styan 58b1a34d89 remove package-lock.json change again
Signed-off-by: Callum Styan <callumstyan@gmail.com>
Signed-off-by: Nicolás Pazos <npazosmendez@gmail.com>
2023-12-19 14:29:29 -03:00