Xiaochao Dong (@damnever)
b3b5c0022e
Simplify the logic as per the comments
...
Signed-off-by: Xiaochao Dong (@damnever) <the.xcdong@gmail.com>
2023-12-25 15:24:59 +08:00
Xiaochao Dong (@damnever)
1601b2a79e
check new line in target
...
Signed-off-by: Xiaochao Dong (@damnever) <the.xcdong@gmail.com>
2023-12-25 11:29:08 +08:00
Xiaochao Dong (@damnever)
2d0d333371
Fix lint issue
...
Signed-off-by: Xiaochao Dong (@damnever) <the.xcdong@gmail.com>
2023-12-25 11:29:08 +08:00
Xiaochao Dong (@damnever)
20e3c295ae
Optimize constant label pair adding with relabel.Replace
...
Signed-off-by: Xiaochao Dong (@damnever) <the.xcdong@gmail.com>
2023-12-25 11:29:00 +08:00
Julien Pivotto
0763ec841b
Merge pull request #13313 from kalpadiptyaroy/fix-quality-value-accept-header
...
bug: Fix quality value in accept header
2023-12-21 11:40:30 +01:00
Kumar Kalpadiptya Roy
b012366c33
Issue #13268 : fix quality value in accept header
...
Signed-off-by: Kumar Kalpadiptya Roy <kalpadiptya.roy@outlook.com>
2023-12-21 10:33:05 +05:30
Bryan Boreham
75fc8a1535
Merge pull request #13167 from bboreham/simplify-TargetsActive
...
scrape: simplify TargetsActive function
2023-12-20 12:27:50 +00:00
Bryan Boreham
4d44da2deb
Merge pull request #13176 from bboreham/move-metrictype
...
Move metric type definitions to common/model
2023-12-20 09:30:57 +00:00
Bryan Boreham
4ca0d57bb9
Merge pull request #13308 from bboreham/validate-relabel
...
relabel: improve logic for target labels
2023-12-20 09:30:26 +00:00
Bryan Boreham
096ec12912
Update comment about metadata in types.proto
...
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2023-12-19 18:56:54 +00:00
Bryan Boreham
c83e1fc574
textparse: remove MetricType alias
...
No backwards-compatibility; make a clean break.
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2023-12-19 18:56:54 +00:00
Bryan Boreham
8065bef172
Move metric type definitions to common/model
...
They are used in multiple repos, so common is a better place for them.
Several packages now don't depend on `model/textparse`, e.g.
`storage/remote`.
Also remove `metadata` struct from `api.go`, since it was identical to
a struct in the `metadata` package.
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2023-12-19 18:56:54 +00:00
Bryan Boreham
99c17b4319
Merge pull request #13177 from bboreham/less-madness
...
scrape: consistent function names for metadata
2023-12-19 17:51:52 +00:00
Bryan Boreham
0289dd6157
relabel: blank replacement deletes label post-regexp
...
If `cfg.TargetLabel` is a template like `$1`, it won't match any labels,
so no point calling `lb.Del` with it.
Similarly if `target` is not a valid label name, it won't match any
labels, so don't call with that either.
The intention seems to have been that a blank _value_ would delete the
target, so change that code to use `target` instead of `cfg.TargetLabel`.
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2023-12-18 16:39:01 +00:00
Bryan Boreham
000182e4b8
relabel: check validity of all test cases
...
Thought this would be a nice check on the `Validate()` function, but
some of the test cases needed tweaking to pass.
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2023-12-18 15:03:24 +00:00
Bryan Boreham
2d4c367d87
relabel: stricter check that target labels are valid
...
For `Lowercase`, `KeepEqual`, etc., we do not expand a regexp, so
the target label name must not contain anything like `${1}`.
Also for the common case that the `Replace` target does not require any
template expansion, check that the entire string passes label name
validity rules.
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2023-12-18 14:58:59 +00:00
Bryan Boreham
9ab7e3b3de
relabel: refactor: extract config.Validate method
...
And add a test for it, which fails because validation is not strong enough.
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2023-12-18 14:54:55 +00:00
Julien Pivotto
5d5303c746
Merge pull request #13285 from daniel-resdiary/DedupGetNic
...
Dedup code handling getting network interface
2023-12-18 15:27:18 +01:00
Julien Pivotto
7600e6cc05
Merge pull request #13294 from mmorel-35/azure
...
build(deps): bump github.com/Azure/azure-sdk-for-go/sdk/resourcemanager
2023-12-18 12:13:50 +01:00
Julien Pivotto
eec006915e
Merge pull request #13288 from diogoteles08/feat/add-minimum-permissions-to-script
...
scripts: Add minimal permissions to script golangci-lint.yml
2023-12-18 12:12:39 +01:00
Julien Pivotto
10557ed8e0
Merge pull request #13278 from Automaat/feat/extend-kuma-sd-api
...
kuma_sd: Extend Kuma SD configuration to allow users to specify ClientId
2023-12-18 12:12:07 +01:00
Matthieu MOREL
952cb41373
build(deps): bump github.com/Azure/azure-sdk-for-go/sdk/resourcemanager
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2023-12-15 10:25:07 +00:00
Diogo Teles Sant'Anna
1a8381a501
Add minimal permissions to script golangci-lint.yml
...
Signed-off-by: Diogo Teles Sant'Anna <diogoteles@google.com>
2023-12-13 19:47:44 +00:00
Arthur Silva Sens
69abd6d9f6
Document feature flag 'created-timestamp-zero-ingestion' ( #13279 )
...
Signed-off-by: Arthur Silva Sens <arthur.sens@coralogix.com>
2023-12-13 15:12:50 +00:00
Daniel Nicholls
0704c72548
Dedup code handling getting network interface
...
Signed-off-by: Daniel Nicholls <daniel.nicholls@resdiary.com>
2023-12-13 14:14:01 +00:00
Björn Rabenstein
775de1a3bd
Merge pull request #13276 from fpetkovski/reuse-float-histograms
...
Reuse float histogram objects
2023-12-13 13:43:01 +01:00
daniel-resdiary
103133124a
Get VM Scale Set NIC ( #13283 )
...
Calling `*armnetwork.InterfacesClient.Get()` doesn't work for Scale Set
VM NIC, because these use a different Resource ID format.
Use `*armnetwork.InterfacesClient.GetVirtualMachineScaleSetNetworkInterface()`
instead. This needs both the scale set name and the instance ID, so
add an `InstanceID` field to the `virtualMachine` struct. `InstanceID`
is empty for a VM that isn't a ScaleSetVM.
Signed-off-by: Daniel Nicholls <daniel.nicholls@resdiary.com>
2023-12-13 12:38:16 +00:00
Filip Petkovski
ea356c472e
Add comment on SampleRingIterator methods
...
Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
2023-12-13 08:35:02 +01:00
Filip Petkovski
bb8363dbb3
Add comment on SampleRingIterator
...
Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
2023-12-13 08:30:02 +01:00
Bryan Boreham
d0c2d9c0b9
Merge pull request #12878 from bboreham/loser-tree
...
postings: use Loser Tree for merge
2023-12-12 21:38:30 +00:00
Björn Rabenstein
9825a80498
Merge pull request #13023 from ptodev/prefer-to-not-register-metrics-globally-sd
...
Allow non-default registry to be used for metrics of SD components
2023-12-12 17:58:36 +01:00
Marcin Skalski
19709f75d0
fix kuma_sd docs
...
Signed-off-by: Marcin Skalski <skalskimarcin33@gmail.com>
2023-12-12 14:49:43 +01:00
Björn Rabenstein
669cad6e6e
Merge pull request #13205 from aknuds1/arve/typos
...
`chunks.Reader`: Fix typo in `ChunkOrIterable` doc string
2023-12-12 13:27:53 +01:00
Björn Rabenstein
4b55a71210
Merge pull request #11583 from windsonsea/story
...
Tweak line wrappings in docs/storage.md
2023-12-12 12:31:02 +01:00
Björn Rabenstein
928d07e3bd
Merge branch 'main' into arve/typos
...
Signed-off-by: Björn Rabenstein <beorn@grafana.com>
2023-12-12 12:02:03 +01:00
Giedrius Statkevičius
f36b56a62c
tsdb: remove unused option ( #13282 )
...
Digging around the TSDB code and I've found that this flag is unused so
let's remove it.
Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
2023-12-12 09:58:54 +00:00
Marcin Skalski
e27232614a
code review
...
Signed-off-by: Marcin Skalski <skalskimarcin33@gmail.com>
2023-12-12 08:32:46 +01:00
Marcin Skalski
48934aaef3
fix go lint
...
Signed-off-by: Marcin Skalski <skalskimarcin33@gmail.com>
2023-12-11 17:04:56 +01:00
Marcin Skalski
0af810aa71
fix go lint
...
Signed-off-by: Marcin Skalski <skalskimarcin33@gmail.com>
2023-12-11 17:01:52 +01:00
Marcin Skalski
d12ccf9fa2
kuma_sd: Extend Kuma SD configuration to allow users to specify ClientId
...
Signed-off-by: Marcin Skalski <skalskimarcin33@gmail.com>
2023-12-11 16:33:42 +01:00
Ben Kochie
91117cb987
Merge pull request #13269 from prometheus/superq/sync_golangci
...
Sync golangci-lint version
2023-12-11 15:48:06 +01:00
Paulin Todev
d2e997030e
Fix linter issues
...
Signed-off-by: Paulin Todev <paulin.todev@gmail.com>
2023-12-11 14:28:37 +00:00
Paulin Todev
27bb57a37b
Define metric label values in one place
...
Signed-off-by: Paulin Todev <paulin.todev@gmail.com>
2023-12-11 13:39:01 +00:00
Paulin Todev
108a749a45
Set up labels for counters in advance
...
Signed-off-by: Paulin Todev <paulin.todev@gmail.com>
2023-12-11 13:39:00 +00:00
Ben Kochie
acc7b3b534
Merge pull request #13155 from mmorel-35/tsdb
...
tsdb: use Go standard errors
2023-12-11 14:13:11 +01:00
Matthieu MOREL
8f6cf3aabb
tsdb: use Go standard errors
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2023-12-11 12:18:54 +00:00
Paulin Todev
6279497124
Remove unnecessary else.
...
This was flagged by the linter.
Signed-off-by: Paulin Todev <paulin.todev@gmail.com>
2023-12-11 11:14:27 +00:00
Paulin Todev
6a5306a53c
Use const labels for Discovery Manager metrics.
...
Signed-off-by: Paulin Todev <paulin.todev@gmail.com>
2023-12-11 11:14:27 +00:00
Paulin Todev
6de80d7fb0
Allow non-default registry to be used for metrics of SD components
...
Signed-off-by: Paulin Todev <paulin.todev@gmail.com>
2023-12-11 11:14:26 +00:00
Filip Petkovski
48df9fc020
Export SampleRingIterator
...
Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
2023-12-11 11:18:08 +01:00