14189 commits

This branch

This branch

All branches

Author	SHA1	Message	Date
György Krajcsovits	bb70370d72	TSDB head: fix race between AppendHistogram and Commit ... Move writing memSeries lastHistogramValue and lastFloatHistogramValue after series creation under lock. The resulting code isn't totally correct in the sense that we're setting these values before Commit() , so they might be overwritten/rolled back later. Also Append of stale sample checks the values without lock, so there's still a potential race. The correct solution would be to set these only in Commit() which we actually do, but then Commit() would also need to process samples in order and not floats first, then histograms, then float histograms - which leads to not knowing what stale marker to write for histograms. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>	2024-10-10 16:59:15 +02:00
György Krajcsovits	631fadc4ca	Unit test for data race in head.Appender.AppendHistogram ... Two Appenders race when creating a series with a native histogram as the memSeries will be common and the lastHistogram field is written without lock. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>	2024-10-10 14:10:07 +02:00
Björn Rabenstein	720a2599a6	Merge pull request #15135 from prometheus/beorn7/docs ... docs: Update chunk layot for NHCB	2024-10-10 12:00:51 +02:00
beorn7	12c39d5421	docs: Some nitpicking in chunks.md ... - `float histogram` → `floathistogram`, as it is used in the code. - Actual link encodings to the code (to find the actual numerical values). - `<bytes>` → `<data>` for consistency. Signed-off-by: beorn7 <beorn@grafana.com>	2024-10-09 14:32:12 +02:00
beorn7	a4cb52ff15	docs: Update chunk layot for NHCB ... Signed-off-by: beorn7 <beorn@grafana.com>	2024-10-09 14:19:20 +02:00
Björn Rabenstein	02d0de9987	Merge pull request #14997 from fionaliao/fl/update-format-docs ... Update chunk format docs with native histograms and OOO	2024-10-09 13:29:01 +02:00
Björn Rabenstein	5e987e7c7d	Merge pull request #15092 from jan--f/clarify-storage-contract ... storage: require selectors to always return matching results	2024-10-09 13:07:59 +02:00
Julius Volz	90f7832447	Merge pull request #15084 from hvnsweeting/patch-1 ... docs: Querying basics: remove what can be graphed	2024-10-08 14:59:07 +02:00
Fiona Liao	8650d25804	Add additional basic nhcb unit tests (#15086) ... * Add additional basic nhcb unit tests * Update promql/promqltest/testdata/histograms.test Signed-off-by: Fiona Liao <fiona.liao@grafana.com> Signed-off-by: Fiona Liao <fiona.y.liao@gmail.com> Co-authored-by: George Krajcsovits <krajorama@users.noreply.github.com>	2024-10-08 14:34:32 +02:00
Viet Hung Nguyen	f0a9f62ce8	[DOCS] Querying basics: what can be graphed ... Put a scalar to query, it can be graphed. So the doc says "an expression that returns an instant vector is the only type which can be graphed." is not correct? And also, a query_range, which used for graph, always return a range vector <https://promlabs.com/blog/2020/06/18/the-anatomy-of-a-promql-query/#range-queries> , so it's confusing to read the above statement. Signed-off-by: Viet Hung Nguyen <hvn@familug.org>	2024-10-08 21:16:26 +09:00
Bryan Boreham	663a66b526	Merge pull request #11224 from dekimsey/consul-catalog-filter-support ... consul: Initial implemenation of catalog filter support	2024-10-08 12:38:17 +01:00
Bryan Boreham	b87b88ddc2	Merge branch 'main' into consul-catalog-filter-support ... Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	2024-10-08 12:20:31 +01:00
Björn Rabenstein	576000a457	Merge pull request #15111 from prometheus/beorn7/doc ... docs: Declare "float literals are time durations" as stable	2024-10-08 12:49:40 +02:00
Julius Volz	7b6259b29b	Merge pull request #15127 from roidelapluie/assets ... Add a note for pre-built assets	2024-10-08 11:37:20 +02:00
Julien	e5f604eb9a	Merge pull request #15045 from prometheus/dependabot/go_modules/github.com/klauspost/compress-1.17.10 ... Bump github.com/klauspost/compress from 1.17.9 to 1.17.10	2024-10-08 11:25:58 +02:00
Julien	24caa3653d	Merge pull request #15040 from prometheus/dependabot/go_modules/github.com/digitalocean/godo-1.126.0 ... Bump github.com/digitalocean/godo from 1.122.0 to 1.126.0	2024-10-08 11:25:37 +02:00
Julien	8406aa9c9c	Add a note for pre-built assets ... Signed-off-by: Julien <roidelapluie@o11y.eu>	2024-10-08 11:23:01 +02:00
dependabot[bot]	5dc59acada	Bump github.com/klauspost/compress from 1.17.9 to 1.17.10 ... Bumps [github.com/klauspost/compress](https://github.com/klauspost/compress) from 1.17.9 to 1.17.10. - [Release notes](https://github.com/klauspost/compress/releases) - [Changelog](https://github.com/klauspost/compress/blob/master/.goreleaser.yml) - [Commits](https://github.com/klauspost/compress/compare/v1.17.9...v1.17.10) --- updated-dependencies: - dependency-name: github.com/klauspost/compress dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>	2024-10-07 20:27:02 +00:00
dependabot[bot]	f3358f3c31	Bump github.com/digitalocean/godo from 1.122.0 to 1.126.0 ... Bumps [github.com/digitalocean/godo](https://github.com/digitalocean/godo) from 1.122.0 to 1.126.0. - [Release notes](https://github.com/digitalocean/godo/releases) - [Changelog](https://github.com/digitalocean/godo/blob/main/CHANGELOG.md) - [Commits](https://github.com/digitalocean/godo/compare/v1.122.0...v1.126.0) --- updated-dependencies: - dependency-name: github.com/digitalocean/godo dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>	2024-10-07 20:26:35 +00:00
Ben Kochie	805954d8f8	Merge pull request #14906 from tjhop/chore/3.0-adopt-slog ... chore!: adopt log/slog, remove go-kit/log	2024-10-07 22:25:16 +02:00
TJ Hoplock	6ebfbd2d54	chore!: adopt log/slog, remove go-kit/log ... For: #14355 This commit updates Prometheus to adopt stdlib's log/slog package in favor of go-kit/log. As part of converting to use slog, several other related changes are required to get prometheus working, including: - removed unused logging util func `RateLimit()` - forward ported the util/logging/Deduper logging by implementing a small custom slog.Handler that does the deduping before chaining log calls to the underlying real slog.Logger - move some of the json file logging functionality to use prom/common package functionality - refactored some of the new json file logging for scraping - changes to promql.QueryLogger interface to swap out logging methods for relevant slog sugar wrappers - updated lots of tests that used/replicated custom logging functionality, attempting to keep the logical goal of the tests consistent after the transition - added a healthy amount of `if logger == nil { $makeLogger }` type conditional checks amongst various functions where none were provided -- old code that used the go-kit/log.Logger interface had several places where there were nil references when trying to use functions like `With()` to add keyvals on the new *slog.Logger type Signed-off-by: TJ Hoplock <t.hoplock@gmail.com>	2024-10-07 15:58:50 -04:00
Julius Volz	65f6103539	Merge pull request #15118 from roidelapluie/notificationsdoc ... Document the notifications API	2024-10-07 15:50:06 +02:00
beorn7	08d4b034da	docs: Declare "float literals are time durations" as stable ... This unifies the documentation of float literals and time durations and updates all references to the old definitions. Signed-off-by: beorn7 <beorn@grafana.com>	2024-10-07 14:22:49 +02:00
Julien	db730fcade	Document the notifications API ... Signed-off-by: Julien <roidelapluie@o11y.eu>	2024-10-07 14:18:54 +02:00
Bartlomiej Plotka	f6e110d588	textparse: Refactored main testing utils for reusability; fixed proto Units. (#15095) ... Signed-off-by: bwplotka <bwplotka@gmail.com>	2024-10-07 12:17:44 +01:00
Julien	2b4ca98247	Merge pull request #15038 from prometheus/dependabot/go_modules/github.com/gophercloud/gophercloud-1.14.1 ... Bump github.com/gophercloud/gophercloud from 1.14.0 to 1.14.1	2024-10-07 12:24:09 +02:00
Julien	1df86df177	Merge pull request #15117 from prometheus/dependabot/go_modules/golang.org/x/tools-0.26.0 ... build(deps): bump golang.org/x/tools from 0.25.0 to 0.26.0	2024-10-07 12:00:28 +02:00
dependabot[bot]	b062dfa4f3	build(deps): bump golang.org/x/tools from 0.25.0 to 0.26.0 ... Bumps [golang.org/x/tools](https://github.com/golang/tools) from 0.25.0 to 0.26.0. - [Release notes](https://github.com/golang/tools/releases) - [Commits](https://github.com/golang/tools/compare/v0.25.0...v0.26.0) --- updated-dependencies: - dependency-name: golang.org/x/tools dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>	2024-10-07 09:45:23 +00:00
Julien	a42e8473ae	Merge pull request #15043 from prometheus/dependabot/go_modules/golang.org/x/tools-0.25.0 ... Bump golang.org/x/tools from 0.24.0 to 0.25.0	2024-10-07 11:44:26 +02:00
Julien	b3f60196c1	Merge pull request #15039 from prometheus/dependabot/go_modules/google.golang.org/grpc-1.67.1 ... Bump google.golang.org/grpc from 1.66.0 to 1.67.1	2024-10-07 11:44:07 +02:00
Julien	9d8f93ea92	Merge pull request #15113 from yeya24/add-missing-allow-overlapping-compaction-flag ... Add missing flag storage.tsdb.allow-overlapping-compaction	2024-10-07 11:17:24 +02:00
Bartlomiej Plotka	8d281c3491	textparse: Refactored benchmark (#15083) ... * textparse: Refactored benchmark. Signed-off-by: bwplotka <bwplotka@gmail.com> * Kill sinks, tested, nothing is inlined. Signed-off-by: bwplotka <bwplotka@gmail.com> * Addressed comments. Signed-off-by: bwplotka <bwplotka@gmail.com> --------- Signed-off-by: bwplotka <bwplotka@gmail.com>	2024-10-07 09:55:26 +01:00
Julien	989db7bc3a	Merge pull request #15042 from prometheus/dependabot/go_modules/go.uber.org/automaxprocs-1.6.0 ... Bump go.uber.org/automaxprocs from 1.5.3 to 1.6.0	2024-10-07 10:50:25 +02:00
dependabot[bot]	5a54ae67ed	Bump actions/checkout from 4.1.6 to 4.2.0 (#15064) ... Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.6 to 4.2.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](a5ac7e51b4...d632683dd7) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2024-10-06 20:01:57 +02:00
Matthieu MOREL	ab64966e9d	fix: use "ErrorContains" or "EqualError" instead of "Contains(t, err.Error()" and "Equal(t, err.Error()" (#15094) ... * fix: use "ErrorContains" or "EqualError" instead of "Contains(t, err.Error()" and "Equal(t, err.Error()" --------- Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>	2024-10-06 16:35:29 +00:00
Ben Ye	6c3d11629b	add missing flag storage.tsdb.allow-overlapping-compaction ... Signed-off-by: Ben Ye <benye@amazon.com>	2024-10-05 17:05:42 -07:00
Julius Volz	a1c2f59bc5	Merge pull request #15096 from prometheus/notification-style-cleanups ... Style cleanups, mostly for web notifications and startup alert	2024-10-04 16:01:03 +02:00
Julien	4fc7b881a1	Merge pull request #15046 from prometheus/dependabot/go_modules/github.com/linode/linodego-1.41.0 ... Bump github.com/linode/linodego from 1.40.0 to 1.41.0	2024-10-04 15:12:17 +02:00
Julien	297667469a	Merge pull request #15090 from roidelapluie/querylogrule ... Fix flakiness of QueryLogTest	2024-10-04 14:57:24 +02:00
Julius Volz	3d2194f561	Style cleanups, mostly for web notifications and startup alert ... Some of the changes are a bit unreadable because the previous files were not saved with the project's linter / auto-formatter settings applied. But it's basically: * For icons that are not Mantine-native components, use the rem() function for computing their size, so they scale correctly with the root font size. See https://mantine.dev/styles/rem/. * Try a different icon for the notifications tray, since the bell icon was already used for Prometheus alerts. Other candidates from https://tabler.io/icons would be IconExclamationCircle or IconDeviceDesktopExclamation or IconMessageCircleExclamation. * The server startup alert looked a bit cramped, introduced a Stack to add spacing between the text and the progress bar. * Added a bit of spacing between notification text and date. Things looked cramped. To make things look ok with that, I also top-aligned the notification text and icon. Signed-off-by: Julius Volz <julius.volz@gmail.com>	2024-10-04 14:14:45 +02:00
Manik Rana	47aeca9663	feat: naive fixes and optimzations for CreatedTimestamp function (#14965) ... * enhance: wip ct parse optimizations Signed-off-by: Manik Rana <manikrana54@gmail.com> * feat: further work on optimization Signed-off-by: Manik Rana <manikrana54@gmail.com> * feat: further improvements and remove unused code Signed-off-by: Manik Rana <manikrana54@gmail.com> * feat: improve optimizations and fix some CT parse errors Signed-off-by: Manik Rana <manikrana54@gmail.com> * fix: check for LsetHash along with name Signed-off-by: Manik Rana <manikrana54@gmail.com> * chore: cleanup and documentation Signed-off-by: Manik Rana <manikrana54@gmail.com> * enhance: improve comments and add cleaner functions Signed-off-by: Manik Rana <manikrana54@gmail.com> * feat: improve comments and add cleaner functions Signed-off-by: Manik Rana <manikrana54@gmail.com> * chore: rename to resetCTParseValues Signed-off-by: Manik Rana <manikrana54@gmail.com> * fix: post-merge fixes Signed-off-by: Manik Rana <manikrana54@gmail.com> * fix: add all possible reserved suffixes Signed-off-by: Manik Rana <manikrana54@gmail.com> * test: separate CT values for each metric Signed-off-by: Manik Rana <manikrana54@gmail.com> --------- Signed-off-by: Manik Rana <manikrana54@gmail.com> Signed-off-by: Manik Rana <Manikrana54@gmail.com>	2024-10-04 13:11:02 +01:00
Julien	023146e918	Merge pull request #15082 from roidelapluie/notifystart ... Notify web UI when starting up and shutting down	2024-10-04 13:40:03 +02:00
Jan Fajerski	563bfdd384	storage: require selectors to always return matching results ... Signed-off-by: Jan Fajerski <jfajersk@redhat.com>	2024-10-04 12:10:16 +02:00
dependabot[bot]	92be29d0dc	Bump google.golang.org/grpc from 1.66.0 to 1.67.1 ... Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.66.0 to 1.67.1. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](https://github.com/grpc/grpc-go/compare/v1.66.0...v1.67.1) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>	2024-10-04 09:25:05 +00:00
dependabot[bot]	5c5cb0e712	Bump golang.org/x/tools from 0.24.0 to 0.25.0 ... Bumps [golang.org/x/tools](https://github.com/golang/tools) from 0.24.0 to 0.25.0. - [Release notes](https://github.com/golang/tools/releases) - [Commits](https://github.com/golang/tools/compare/v0.24.0...v0.25.0) --- updated-dependencies: - dependency-name: golang.org/x/tools dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>	2024-10-04 09:25:04 +00:00
Julien	9d275c23de	cmd/prometheus: Fix flakiness of QueryLogTest ... Now we check that a rule execution has taken place. This also reduces the time to run the rules tests from 45s to 25s. Signed-off-by: Julien <roidelapluie@o11y.eu>	2024-10-04 11:23:57 +02:00
Julien	d98c37478b	Merge pull request #15035 from prometheus/dependabot/go_modules/google.golang.org/api-0.199.0 ... Bump google.golang.org/api from 0.195.0 to 0.199.0	2024-10-04 11:23:46 +02:00
Julien	21e0f83b68	Move notifications in utils ... Signed-off-by: Julien <roidelapluie@o11y.eu>	2024-10-04 10:11:56 +02:00
dependabot[bot]	52cc937af0	Bump go.uber.org/automaxprocs from 1.5.3 to 1.6.0 ... Bumps [go.uber.org/automaxprocs](https://github.com/uber-go/automaxprocs) from 1.5.3 to 1.6.0. - [Release notes](https://github.com/uber-go/automaxprocs/releases) - [Changelog](https://github.com/uber-go/automaxprocs/blob/master/CHANGELOG.md) - [Commits](https://github.com/uber-go/automaxprocs/compare/v1.5.3...v1.6.0) --- updated-dependencies: - dependency-name: go.uber.org/automaxprocs dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>	2024-10-04 07:46:29 +00:00
Julien	34c0f2d48e	Merge pull request #15029 from prometheus/dependabot/go_modules/documentation/examples/remote_storage/github.com/prometheus/common-0.60.0 ... Bump github.com/prometheus/common from 0.57.0 to 0.60.0 in /documentation/examples/remote_storage	2024-10-04 09:44:52 +02:00