mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2024-12-25 21:54:10 -08:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity
8470 commits 243 branches 444 tags 649 MiB
Commit graph

8470 commits

This branch
This branch
All branches
Author SHA1 Message Date
Julien Pivotto e29b47b39e
Merge pull request #8440 from mishamo/master 
Add optional name property to testgroup for better test failure output
 2021-02-09 21:23:24 +01:00
Mauro Stettler 7715fe3219
Add matchers to LabelValues() call (#8400) 
* Accept matchers in querier LabelValues()

Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>

* create matcher to only select metrics which have searched label

Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>

* test case for merge querier with matchers

Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>

* test LabelValues with matchers on head

Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>

* add test for LabelValues on block

Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>

* formatting fix

Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>

* Add comments

Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>

* add missing lock release

Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>

* remove unused parameter

Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>

* Benchmarks for LabelValues() methods on block/head

Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>

* Better comment

Co-authored-by: Julien Pivotto <roidelapluie@gmail.com>
Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>

* update comment

Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>

* minor refactor make code cleaner

Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>

* better comments

Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>

* fix expected errors in test

Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>

* Deleting parameter which can only be empty

Co-authored-by: Ganesh Vernekar <15064823+codesome@users.noreply.github.com>
Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>

* fix comments

Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>

* remove unnecessary lock

Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>

* only lookup label value if label name was looked up

Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>

* Return error when there is one

Co-authored-by: Ganesh Vernekar <15064823+codesome@users.noreply.github.com>
Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>

* Call .Get() on decoder before checking errors

Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>

* only lock head.symMtx when necessary

Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>

* remove unnecessary delete()

Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>

* re-use code instead of duplicating it

Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>

* Consistently return error from LabelValueFor()

Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>

* move helper func from util.go to querier.go

Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>

* Fix test expectation

Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>

Co-authored-by: Ganesh Vernekar <15064823+codesome@users.noreply.github.com>

* ensure result de-duplication and sorting works

Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>

* return named error from LabelValueFor()

Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>

Co-authored-by: Julien Pivotto <roidelapluie@gmail.com>
Co-authored-by: Ganesh Vernekar <15064823+codesome@users.noreply.github.com>
 2021-02-09 23:08:35 +05:30
Ganesh Vernekar 86c71856e8
Add start() and end() pre-processors for @ modifier (#8425) 
* Add start() and end() pre-processors for @ modifier

Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>

* Fix reviews

Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>

* Fix review comments

Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>

* Fix review comments

Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
 2021-02-09 21:33:16 +05:30
misha 1c3e7b4241 Use strings.Builder for neater error formatting 
Signed-off-by: misha <DL-OTTCloudPlatform-Nova@bskyb.internal>
 2021-02-09 15:00:26 +00:00
Dustin Hooten b9f0baf6ff
Combine NewHead() args into a HeadOptions struct (#8452) 
* Combine NewHead() args into a HeadOptions struct

Signed-off-by: Dustin Hooten <dustinhooten@gmail.com>

* remove overrides params

Signed-off-by: Dustin Hooten <dustinhooten@gmail.com>

* address pr feedback

Signed-off-by: Dustin Hooten <dustinhooten@gmail.com>
 2021-02-09 19:42:48 +05:30
Julien Pivotto f2c5c230f1
Merge pull request #8459 from prometheus/fix-labelname-style-bug 
Fix label name leak into class name
 2021-02-08 23:56:29 +01:00
Julien Pivotto 860f08532a
Merge pull request #8424 from prometheus/prom/remote-writer-api 
[FEATURE] Accept remote_write requests in the Prometheus server
 2021-02-08 23:39:34 +01:00
Julius Volz b6544c9048 Fix label name leak into class name 
Similar to https://github.com/prometheus/prometheus/pull/7902, this could lead
to style bugs for label names that correspond to styled CSS class names.

Signed-off-by: Julius Volz <julius.volz@gmail.com>
 2021-02-08 22:24:49 +01:00
Łukasz Mierzwa 885674c5c0
[UI] Fix duplicated keys on /targets page (#8456) 
* [UI] Add a test for duplicated keys in EndpointLink component

I've noticed that I'm getting warnings about multiple children with the same key on /targets page.
This adds a test that fails when that happens.

Signed-off-by: Łukasz Mierzwa <l.mierzwa@gmail.com>

* [UI] Fix duplicated keys on /targets page

Since any URI we render on /targets page can have multi-value params we should use both name and value as components keys.

Signed-off-by: Łukasz Mierzwa <l.mierzwa@gmail.com>
 2021-02-08 22:17:04 +01:00
Tom Wilkie d479151f1f Various enhancements and refactorings for remote write receiver: 
- Remove unrelated changes
- Refactor code out of the API module - that is already getting pretty crowded.
- Don't track reference for AddFast in remote write.  This has the potential to consume unlimited server-side memory if a malicious client pushes a different label set for every series.  For now, its easier and safer to always use the 'slow' path.
- Return 400 on out of order samples.
- Use remote.DecodeWriteRequest in the remote write adapters.
- Put this behing the 'remote-write-server' feature flag
- Add some (very) basic docs.
- Used named return & add test for commit error propagation

Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
 2021-02-08 20:41:23 +00:00
Julien Pivotto 24ba63f9f9
Merge pull request #8446 from simonpasquier/bump-gogo-dep 
Update github.com/gogo/protobuf to v1.3.2
 2021-02-08 20:13:56 +01:00
Simon Pasquier cf269b7ddd Update github.com/gogo/protobuf to v1.3.2 
Fix for CVE-2021-3121

Signed-off-by: Simon Pasquier <spasquie@redhat.com>
 2021-02-08 17:30:46 +01:00
Julien Pivotto dfaa194320
Merge pull request #8451 from roidelapluie/fuzzing-badge 
Add fuzzing badge in readme
 2021-02-08 13:24:52 +01:00
Julien Pivotto e0f1506254
Merge pull request #8455 from mikeee/fix-ci 
Fix CI (Windows Testing)
 2021-02-08 10:06:52 +01:00
mikeee 9fbce46566
Trigger CI 
Signed-off-by: mikeee <hey@mike.ee>
 2021-02-08 00:47:22 +00:00
mikeee 52109966af
Change the CI workflow to powershell and fixes the missing env var issue 
Signed-off-by: mikeee <hey@mike.ee>
 2021-02-08 00:44:58 +00:00
mikeee 9ca24f9d24
Revert to get the latest version of Go 
Signed-off-by: mikeee <hey@mike.ee>
 2021-02-08 00:40:34 +00:00
Julien Pivotto 715b802dba Add fuzzing badge in readme 
From https://google.github.io/oss-fuzz/getting-started/new-project-guide/

Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
 2021-02-07 23:48:46 +01:00
fuling 72475b8a0c [ENHANCEMENT] remote storage:Add default api implementation of remote write 
Signed-off-by: fuling <fuling.lgz@alibaba-inc.com>
 2021-02-07 18:12:48 +00:00
Julien Pivotto ff40af2671
Merge pull request #8448 from roidelapluie/downgrade-go-windows 
Windows CI: downgrade golang
 2021-02-05 17:34:18 +01:00
Julien Pivotto 3ead3926d1 Windows CI: downgrade golang 
Latest releases has a change in behaviour or a bug:

bash: go: command not found
bash: line 1: go: command not found
bash: line 1: go: command not found

Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
 2021-02-05 17:17:54 +01:00
Julien Pivotto 06e53b7ecf
API: Fix global URL when external address has no port (#8359) 
* API: Fix global URL when external address has no port

Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>

* Update test

Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>

* Handle IPv6 correctly.

Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
 2021-02-05 12:45:44 +01:00
Julien Pivotto b0642fb42f
Merge pull request #8444 from prometheus/upgrade_golangci-lint-1.36.0 
Update golangci-lint to 1.36.0
 2021-02-05 09:18:25 +01:00
Julien Pivotto 6368227f0c
Merge pull request #8443 from liguozhong/remote_storage 
[remote storage] remove sendWriteRequestWithBackoff() "s" and "req" param
 2021-02-04 23:28:14 +01:00
Nándor István Krácser 509000269a
remote_write: allow passing along custom HTTP headers (#8416) 
* remote_write: allow passing along custom HTTP headers

Signed-off-by: Nandor Kracser <bonifaido@gmail.com>

* add warning

Signed-off-by: Nandor Kracser <bonifaido@gmail.com>

* remote_write: add header valadtion

Signed-off-by: Nandor Kracser <bonifaido@gmail.com>

* extend tests for bad remote write headers

Signed-off-by: Nandor Kracser <bonifaido@gmail.com>

* remote_write: add note about the authorization header

Signed-off-by: Nandor Kracser <bonifaido@gmail.com>
 2021-02-04 14:18:13 -07:00
Marcelo E. Magallon 75d86c6747 Update golangci-lint to 1.36.0 
In the previous version, 1.18.0, the "megacheck" linter paid attention
to the '//lint:ignore' comment, but that is no longer there.

Newer version pay attention to '//nolint:<linter>,<linter>,...'
comments, optionally followed by a "second" comment introduced by '//'.

Update the directives to use this style.

This is related to prometheus/blackbox_exporter#738 and
prometheus/blackbox_exporter#745.

Signed-off-by: Marcelo E. Magallon <marcelo.magallon@grafana.com>
 2021-02-04 08:53:33 -06:00
fuling 4a407210f5 [remote storage] remove sendWriteRequestWithBackoff() "s" and "req" param 
Signed-off-by: fuling <fuling.lgz@alibaba-inc.com>
 2021-02-04 21:38:32 +08:00
misha c2c5aeb16b Add optional name property to testgroup for better test failure output 
Signed-off-by: misha <DL-OTTCloudPlatform-Nova@bskyb.internal>
 2021-02-04 10:07:22 +00:00
Julien Pivotto 7db09551b0
Merge pull request #8441 from codesome/remove-empty-test 
Remove empty test
 2021-02-04 07:46:32 +01:00
Ganesh Vernekar ed8d31b059
Remove empty test 
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
 2021-02-04 11:53:32 +05:30
Julien Pivotto 67edfc6054
Merge pull request #8436 from codesome/timestamp-at-mod-fix 
Fix timestamp() function for @ modifier
 2021-02-03 16:33:55 +01:00
Julien Pivotto c1f8bd9944
Merge pull request #8432 from roidelapluie/backfillpanic 
backfill: move checkErr before we close the mmaped file
 2021-02-03 16:32:35 +01:00
Ganesh Vernekar b18fde996e
Fix timestamp() function for @ modifier 
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
 2021-02-03 19:13:12 +05:30
Julien Pivotto 41247b6950
Merge pull request #8431 from phith0n/missing-ui-on-windows 
fix: UI error while compiling on Windows
 2021-02-01 22:30:57 +01:00
Julien Pivotto 894354a03c
Merge pull request #6018 from simonpasquier/delete-remote-makefile-common-branch 
scripts/sync_makefiles.sh: delete merged branch
 2021-02-01 21:46:16 +01:00
Julien Pivotto 9334269f2b backfill: move checkErr before we close the mmaped file 
When printing the error, we still need access to the mmapped byte array
of the file. Therefore, we make sure that we run it before closing the
file.

I could have done something more complex like a defer, or not closing
the file, knowing that we would exit the program anyway. However, I
think that in case we extend this in the future, or this is copy/paster
elsewhere, we should continue closing the file. As it is small enough, I
went for the solution to call the function 3 times instead of playing
with a defer.

Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
 2021-02-01 21:18:42 +01:00
phith0n 3825f5837e fix #4596 
Signed-off-by: phith0n <phith0n.ph2f@gmail.com>
 2021-02-02 01:13:48 +08:00
Julien Pivotto b353afcc1b
Merge pull request #8430 from Boulet-/typo 
Typo on plural in checkRules/checkDuplicates
 2021-02-01 17:12:56 +01:00
Jeremy Albinet 4a1f2c097e Typo on plural in checkRules/checkDuplicates 
Signed-off-by: Jeremy Albinet <jalbinet@synthesio.com>
 2021-02-01 15:43:05 +01:00
Björn Rabenstein 9f281cdee5
Merge pull request #8422 from prometheus/beorn7/maintainers 
Update MAINTAINERS.md
 2021-02-01 15:05:26 +01:00
ravilr adc8807851
Update remote-write alert rules mixin (#8423) 
Signed-off-by: ravilr <raviprasad_lr@yahoo.com>
 2021-01-31 20:07:49 +00:00
alex-petrov-vt 91eef5e3bf
Added warnings into react Panel on the Graph page (#8427) 
Signed-off-by: Alex Petrov <alex.petrov.vt@gmail.com>
 2021-01-31 13:48:32 +01:00
beorn7 fac3a4eef5 Avoid minor logical ambiguity 
Signed-off-by: beorn7 <beorn@grafana.com>
 2021-01-29 19:41:35 +01:00
beorn7 00c11bb5f8 Change main/default maintainer from @brian-brazil to @roidelapluie 
Signed-off-by: beorn7 <beorn@grafana.com>
 2021-01-29 19:40:57 +01:00
Chris Marchbanks 275f7e7766
Log recoverable remote write errors as warnings (#8412) 
Signed-off-by: Chris Marchbanks <csmarchbanks@gmail.com>
 2021-01-27 09:38:34 -07:00
Alfred Krohmer fc8004eeec
EC2 SD: fix error handling of NewSessionWithOptions (#8356) 
Last change in 4efca5a introduced a problem where NewDiscovery would
just return a nil value, which is not handled well and didn't allow for
fixing configuration issues at runtime without a reload.

Signed-off-by: Alfred Krohmer <alfred.krohmer@logmein.com>
 2021-01-26 11:27:30 +00:00
Julien Pivotto 02ee690e3c
Merge pull request #8407 from roidelapluie/deprecate-alertmanager-timeout-flag 
Deprecate --alertmanager.timeout
 2021-01-25 23:55:34 +01:00
Goutham Veeramachaneni e572e77d90
Increase the buckets for compaction duration (#8342) 
We're seeing compactions that are taking hours in Cortex which this is
missing. I know while it is not common in Prometheus, I am pretty sure
there are setups where compaction takes longer than 512s. On our own
Prometheus the average compaction duration is 566s.

Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
 2021-01-25 18:12:18 +00:00
Julien Pivotto 2316062d4e Deprecate --alertmanager.timeout 
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
 2021-01-25 12:36:13 +01:00
Ganesh Vernekar b5dfa2414b
Fix flaky TestAtModifier (#8401) 
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
 2021-01-24 20:23:30 +05:30