mirror of
https://github.com/prometheus/prometheus.git
synced 2024-11-13 17:14:05 -08:00
583f3e587c
Optimize histogram iterators Histogram iterators allocate new objects in the AtHistogram and AtFloatHistogram methods, which makes calculating rates over long ranges expensive. In #13215 we allowed an existing object to be reused when converting an integer histogram to a float histogram. This commit follows the same idea and allows injecting an existing object in the AtHistogram and AtFloatHistogram methods. When the injected value is nil, iterators allocate new histograms, otherwise they populate and return the injected object. The commit also adds a CopyTo method to Histogram and FloatHistogram which is used in the BufferedIterator to overwrite items in the ring instead of making new copies. Note that a specialized HPoint pool is needed for all of this to work (`matrixSelectorHPool`). --------- Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> Co-authored-by: George Krajcsovits <krajorama@users.noreply.github.com>
320 lines
9.8 KiB
Go
320 lines
9.8 KiB
Go
// Copyright 2015 The Prometheus Authors
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package web
|
|
|
|
import (
|
|
"errors"
|
|
"fmt"
|
|
"net/http"
|
|
"sort"
|
|
"strings"
|
|
|
|
"github.com/go-kit/log/level"
|
|
"github.com/gogo/protobuf/proto"
|
|
"github.com/prometheus/client_golang/prometheus"
|
|
dto "github.com/prometheus/client_model/go"
|
|
"github.com/prometheus/common/expfmt"
|
|
"github.com/prometheus/common/model"
|
|
"golang.org/x/exp/slices"
|
|
|
|
"github.com/prometheus/prometheus/model/histogram"
|
|
"github.com/prometheus/prometheus/model/labels"
|
|
"github.com/prometheus/prometheus/model/timestamp"
|
|
"github.com/prometheus/prometheus/model/value"
|
|
"github.com/prometheus/prometheus/promql"
|
|
"github.com/prometheus/prometheus/promql/parser"
|
|
"github.com/prometheus/prometheus/storage"
|
|
"github.com/prometheus/prometheus/tsdb"
|
|
"github.com/prometheus/prometheus/tsdb/chunkenc"
|
|
)
|
|
|
|
var (
|
|
federationErrors = prometheus.NewCounter(prometheus.CounterOpts{
|
|
Name: "prometheus_web_federation_errors_total",
|
|
Help: "Total number of errors that occurred while sending federation responses.",
|
|
})
|
|
federationWarnings = prometheus.NewCounter(prometheus.CounterOpts{
|
|
Name: "prometheus_web_federation_warnings_total",
|
|
Help: "Total number of warnings that occurred while sending federation responses.",
|
|
})
|
|
)
|
|
|
|
func registerFederationMetrics(r prometheus.Registerer) {
|
|
r.MustRegister(federationWarnings, federationErrors)
|
|
}
|
|
|
|
func (h *Handler) federation(w http.ResponseWriter, req *http.Request) {
|
|
h.mtx.RLock()
|
|
defer h.mtx.RUnlock()
|
|
|
|
ctx := req.Context()
|
|
|
|
if err := req.ParseForm(); err != nil {
|
|
http.Error(w, fmt.Sprintf("error parsing form values: %v", err), http.StatusBadRequest)
|
|
return
|
|
}
|
|
|
|
matcherSets, err := parser.ParseMetricSelectors(req.Form["match[]"])
|
|
if err != nil {
|
|
http.Error(w, err.Error(), http.StatusBadRequest)
|
|
return
|
|
}
|
|
|
|
var (
|
|
mint = timestamp.FromTime(h.now().Time().Add(-h.lookbackDelta))
|
|
maxt = timestamp.FromTime(h.now().Time())
|
|
format = expfmt.Negotiate(req.Header)
|
|
enc = expfmt.NewEncoder(w, format)
|
|
)
|
|
w.Header().Set("Content-Type", string(format))
|
|
|
|
q, err := h.localStorage.Querier(mint, maxt)
|
|
if err != nil {
|
|
federationErrors.Inc()
|
|
if errors.Is(err, tsdb.ErrNotReady) {
|
|
http.Error(w, err.Error(), http.StatusServiceUnavailable)
|
|
return
|
|
}
|
|
http.Error(w, err.Error(), http.StatusInternalServerError)
|
|
return
|
|
}
|
|
defer q.Close()
|
|
|
|
vec := make(promql.Vector, 0, 8000)
|
|
|
|
hints := &storage.SelectHints{Start: mint, End: maxt}
|
|
|
|
var sets []storage.SeriesSet
|
|
for _, mset := range matcherSets {
|
|
s := q.Select(ctx, true, hints, mset...)
|
|
sets = append(sets, s)
|
|
}
|
|
|
|
set := storage.NewMergeSeriesSet(sets, storage.ChainedSeriesMerge)
|
|
it := storage.NewBuffer(int64(h.lookbackDelta / 1e6))
|
|
var chkIter chunkenc.Iterator
|
|
Loop:
|
|
for set.Next() {
|
|
s := set.At()
|
|
|
|
// TODO(fabxc): allow fast path for most recent sample either
|
|
// in the storage itself or caching layer in Prometheus.
|
|
chkIter = s.Iterator(chkIter)
|
|
it.Reset(chkIter)
|
|
|
|
var (
|
|
t int64
|
|
f float64
|
|
fh *histogram.FloatHistogram
|
|
)
|
|
valueType := it.Seek(maxt)
|
|
switch valueType {
|
|
case chunkenc.ValFloat:
|
|
t, f = it.At()
|
|
case chunkenc.ValFloatHistogram, chunkenc.ValHistogram:
|
|
t, fh = it.AtFloatHistogram(nil)
|
|
default:
|
|
sample, ok := it.PeekBack(1)
|
|
if !ok {
|
|
continue Loop
|
|
}
|
|
t = sample.T()
|
|
switch sample.Type() {
|
|
case chunkenc.ValFloat:
|
|
f = sample.F()
|
|
case chunkenc.ValHistogram:
|
|
fh = sample.H().ToFloat(nil)
|
|
case chunkenc.ValFloatHistogram:
|
|
fh = sample.FH()
|
|
default:
|
|
continue Loop
|
|
}
|
|
}
|
|
// The exposition formats do not support stale markers, so drop them. This
|
|
// is good enough for staleness handling of federated data, as the
|
|
// interval-based limits on staleness will do the right thing for supported
|
|
// use cases (which is to say federating aggregated time series).
|
|
if value.IsStaleNaN(f) || (fh != nil && value.IsStaleNaN(fh.Sum)) {
|
|
continue
|
|
}
|
|
|
|
vec = append(vec, promql.Sample{
|
|
Metric: s.Labels(),
|
|
T: t,
|
|
F: f,
|
|
H: fh,
|
|
})
|
|
}
|
|
if ws := set.Warnings(); len(ws) > 0 {
|
|
level.Debug(h.logger).Log("msg", "Federation select returned warnings", "warnings", ws)
|
|
federationWarnings.Add(float64(len(ws)))
|
|
}
|
|
if set.Err() != nil {
|
|
federationErrors.Inc()
|
|
http.Error(w, set.Err().Error(), http.StatusInternalServerError)
|
|
return
|
|
}
|
|
|
|
slices.SortFunc(vec, func(a, b promql.Sample) int {
|
|
ni := a.Metric.Get(labels.MetricName)
|
|
nj := b.Metric.Get(labels.MetricName)
|
|
return strings.Compare(ni, nj)
|
|
})
|
|
|
|
externalLabels := h.config.GlobalConfig.ExternalLabels.Map()
|
|
if _, ok := externalLabels[model.InstanceLabel]; !ok {
|
|
externalLabels[model.InstanceLabel] = ""
|
|
}
|
|
externalLabelNames := make([]string, 0, len(externalLabels))
|
|
for ln := range externalLabels {
|
|
externalLabelNames = append(externalLabelNames, ln)
|
|
}
|
|
sort.Strings(externalLabelNames)
|
|
|
|
var (
|
|
lastMetricName string
|
|
lastWasHistogram, lastHistogramWasGauge bool
|
|
protMetricFam *dto.MetricFamily
|
|
)
|
|
for _, s := range vec {
|
|
isHistogram := s.H != nil
|
|
if isHistogram &&
|
|
format != expfmt.FmtProtoDelim && format != expfmt.FmtProtoText && format != expfmt.FmtProtoCompact {
|
|
// Can't serve the native histogram.
|
|
// TODO(codesome): Serve them when other protocols get the native histogram support.
|
|
continue
|
|
}
|
|
|
|
nameSeen := false
|
|
globalUsed := map[string]struct{}{}
|
|
protMetric := &dto.Metric{}
|
|
|
|
err := s.Metric.Validate(func(l labels.Label) error {
|
|
if l.Value == "" {
|
|
// No value means unset. Never consider those labels.
|
|
// This is also important to protect against nameless metrics.
|
|
return nil
|
|
}
|
|
if l.Name == labels.MetricName {
|
|
nameSeen = true
|
|
if l.Value == lastMetricName && // We already have the name in the current MetricFamily, and we ignore nameless metrics.
|
|
lastWasHistogram == isHistogram && // The sample type matches (float vs histogram).
|
|
// If it was a histogram, the histogram type (counter vs gauge) also matches.
|
|
(!isHistogram || lastHistogramWasGauge == (s.H.CounterResetHint == histogram.GaugeType)) {
|
|
return nil
|
|
}
|
|
|
|
// Since we now check for the sample type and type of histogram above, we will end up
|
|
// creating multiple metric families for the same metric name. This would technically be
|
|
// an invalid exposition. But since the consumer of this is Prometheus, and Prometheus can
|
|
// parse it fine, we allow it and bend the rules to make federation possible in those cases.
|
|
|
|
// Need to start a new MetricFamily. Ship off the old one (if any) before
|
|
// creating the new one.
|
|
if protMetricFam != nil {
|
|
if err := enc.Encode(protMetricFam); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
protMetricFam = &dto.MetricFamily{
|
|
Type: dto.MetricType_UNTYPED.Enum(),
|
|
Name: proto.String(l.Value),
|
|
}
|
|
if isHistogram {
|
|
if s.H.CounterResetHint == histogram.GaugeType {
|
|
protMetricFam.Type = dto.MetricType_GAUGE_HISTOGRAM.Enum()
|
|
} else {
|
|
protMetricFam.Type = dto.MetricType_HISTOGRAM.Enum()
|
|
}
|
|
}
|
|
lastMetricName = l.Value
|
|
return nil
|
|
}
|
|
protMetric.Label = append(protMetric.Label, &dto.LabelPair{
|
|
Name: proto.String(l.Name),
|
|
Value: proto.String(l.Value),
|
|
})
|
|
if _, ok := externalLabels[l.Name]; ok {
|
|
globalUsed[l.Name] = struct{}{}
|
|
}
|
|
return nil
|
|
})
|
|
if err != nil {
|
|
federationErrors.Inc()
|
|
level.Error(h.logger).Log("msg", "federation failed", "err", err)
|
|
return
|
|
}
|
|
if !nameSeen {
|
|
level.Warn(h.logger).Log("msg", "Ignoring nameless metric during federation", "metric", s.Metric)
|
|
continue
|
|
}
|
|
// Attach global labels if they do not exist yet.
|
|
for _, ln := range externalLabelNames {
|
|
lv := externalLabels[ln]
|
|
if _, ok := globalUsed[ln]; !ok {
|
|
protMetric.Label = append(protMetric.Label, &dto.LabelPair{
|
|
Name: proto.String(ln),
|
|
Value: proto.String(lv),
|
|
})
|
|
}
|
|
}
|
|
|
|
protMetric.TimestampMs = proto.Int64(s.T)
|
|
if !isHistogram {
|
|
lastHistogramWasGauge = false
|
|
protMetric.Untyped = &dto.Untyped{
|
|
Value: proto.Float64(s.F),
|
|
}
|
|
} else {
|
|
lastHistogramWasGauge = s.H.CounterResetHint == histogram.GaugeType
|
|
protMetric.Histogram = &dto.Histogram{
|
|
SampleCountFloat: proto.Float64(s.H.Count),
|
|
SampleSum: proto.Float64(s.H.Sum),
|
|
Schema: proto.Int32(s.H.Schema),
|
|
ZeroThreshold: proto.Float64(s.H.ZeroThreshold),
|
|
ZeroCountFloat: proto.Float64(s.H.ZeroCount),
|
|
NegativeCount: s.H.NegativeBuckets,
|
|
PositiveCount: s.H.PositiveBuckets,
|
|
}
|
|
if len(s.H.PositiveSpans) > 0 {
|
|
protMetric.Histogram.PositiveSpan = make([]*dto.BucketSpan, len(s.H.PositiveSpans))
|
|
for i, sp := range s.H.PositiveSpans {
|
|
protMetric.Histogram.PositiveSpan[i] = &dto.BucketSpan{
|
|
Offset: proto.Int32(sp.Offset),
|
|
Length: proto.Uint32(sp.Length),
|
|
}
|
|
}
|
|
}
|
|
if len(s.H.NegativeSpans) > 0 {
|
|
protMetric.Histogram.NegativeSpan = make([]*dto.BucketSpan, len(s.H.NegativeSpans))
|
|
for i, sp := range s.H.NegativeSpans {
|
|
protMetric.Histogram.NegativeSpan[i] = &dto.BucketSpan{
|
|
Offset: proto.Int32(sp.Offset),
|
|
Length: proto.Uint32(sp.Length),
|
|
}
|
|
}
|
|
}
|
|
}
|
|
lastWasHistogram = isHistogram
|
|
protMetricFam.Metric = append(protMetricFam.Metric, protMetric)
|
|
}
|
|
// Still have to ship off the last MetricFamily, if any.
|
|
if protMetricFam != nil {
|
|
if err := enc.Encode(protMetricFam); err != nil {
|
|
federationErrors.Inc()
|
|
level.Error(h.logger).Log("msg", "federation failed", "err", err)
|
|
}
|
|
}
|
|
}
|