mirror of
https://github.com/prometheus/prometheus.git
synced 2024-09-20 15:57:31 -07:00
47e3c90f9b
Only return an error where callers are doing something with it except simply logging and ignoring. All the errors touched in this commit flag the storage as dirty anyway, and that fact is logged anyway. So most of what is being removed here is just log spam. As discussed earlier, the class of errors that flags the storage as dirty signals fundamental corruption, no even bubbling up a one-time warning to the user (e.g. about incomplete results) isn't helping much because _anything_ happening in the storage has to be doubted from that point on (and in fact retroactively into the past, too). Flagging the storage dirty, and alerting on it (plus marking the state in the web UI) is the only way I can see right now. As a byproduct, I cleaned up the setDirty method a bit and improved the logged errors. |
||
|---|---|---|
| .. | ||
| codable | ||
| fixtures/b0 | ||
| index | ||
| storagetool | ||
| chunk.go | ||
| crashrecovery.go | ||
| delta.go | ||
| delta_helpers.go | ||
| doubledelta.go | ||
| heads.go | ||
| instrumentation.go | ||
| interface.go | ||
| locker.go | ||
| locker_test.go | ||
| mapper.go | ||
| mapper_test.go | ||
| persistence.go | ||
| persistence_test.go | ||
| preload.go | ||
| series.go | ||
| storage.go | ||
| storage_test.go | ||
| test_helpers.go | ||