mirror of
https://github.com/prometheus/prometheus.git
synced 2024-09-19 23:37:31 -07:00
1b92fb10de
I like a bit more of a hint what the PR is supposed to achieve. Also, I took out a suggestion not to write tests. We can decide case-by-case if it's ok not to add a test; no need to encourage it. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
20 lines
870 B
Markdown
20 lines
870 B
Markdown
<!--
|
|
Please give your PR a title in the form "area: short description". For example "tsdb: reduce disk usage by 95%"
|
|
|
|
If your PR is to fix an issue, put "Fixes #issue-number" in the description.
|
|
|
|
Don't forget!
|
|
|
|
- Please sign CNCF's Developer Certificate of Origin and sign-off your commits by adding the -s / --signoff flag to `git commit`. See https://github.com/apps/dco for more information.
|
|
|
|
- If the PR adds or changes a behaviour or fixes a bug of an exported API it would need a unit/e2e test.
|
|
|
|
- Where possible use only exported APIs for tests to simplify the review and make it as close as possible to an actual library usage.
|
|
|
|
- Performance improvements would need a benchmark test to prove it.
|
|
|
|
- All exposed objects should have a comment.
|
|
|
|
- All comments should start with a capital letter and end with a full stop.
|
|
-->
|