Commit graph

691 commits

Author SHA1 Message Date
srowen e3d418f458 Minor change to avoid using synthetic accessor for private member
git-svn-id: https://zxing.googlecode.com/svn/trunk@243 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-03-04 16:35:22 +00:00
srowen 778e3ef688 Typo in Version 25 spec (thanks Brian)
git-svn-id: https://zxing.googlecode.com/svn/trunk@242 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-03-04 16:26:55 +00:00
srowen bdcf60913b Disallow BufferedImage of type TYPE_CUSTOM -- not decoding properly, and is kind of a weird case from ImageIO anyway
git-svn-id: https://zxing.googlecode.com/svn/trunk@241 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-03-03 22:45:52 +00:00
srowen 36a5e32021 Refactored to avoid use of exceptions in parsing, at the suggestion of Jeff Griffin (thanks). These "exceptional cases" are frequent and are expensive; a static parse() / private constructor approach proves no more complex, and a smidge more efficient.
git-svn-id: https://zxing.googlecode.com/svn/trunk@239 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-03-03 21:37:40 +00:00
srowen 905b1f7676 Fix typo in method "isRotate*d*Supported"; don't attempt to rotate images of unknown format
git-svn-id: https://zxing.googlecode.com/svn/trunk@238 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-03-03 21:36:03 +00:00
srowen 7c475c5cad New rotated 1D barcode test case
git-svn-id: https://zxing.googlecode.com/svn/trunk@237 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-03-03 20:50:41 +00:00
srowen 7c1d8184f3 Tries TRY_HARDER too in tests now, to confirm it only improves accuracy, never hurts
git-svn-id: https://zxing.googlecode.com/svn/trunk@236 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-03-03 20:21:22 +00:00
srowen c4ee6727d6 Use TRY_HARDER hint in javase CommandLineRunner. TRY_HARDER now tries rotating the image when dealing with 1D barcodes. Clarified and fixed value type of several items in the "hints" Hashtables.
git-svn-id: https://zxing.googlecode.com/svn/trunk@235 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-03-03 19:48:08 +00:00
srowen 3e5b13abeb Take more advantage of TRY_HARDER
git-svn-id: https://zxing.googlecode.com/svn/trunk@233 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-02-25 23:22:01 +00:00
srowen 1f442884aa Added BarcodeFormat to Result, indicating what type of barcode was detected. Added TRY_HARDER hint. Improved logicalness of results when reading UPC-A code / EAN-13 code starting with 0.
git-svn-id: https://zxing.googlecode.com/svn/trunk@230 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-02-25 23:02:50 +00:00
srowen 848609c0c5 Added "URLTO" format support
git-svn-id: https://zxing.googlecode.com/svn/trunk@229 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-02-25 22:15:36 +00:00
srowen acad53f39b Oops, not clearing row counters when we shift down by two buckets. Fixed.
git-svn-id: https://zxing.googlecode.com/svn/trunk@225 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-02-22 19:18:29 +00:00
srowen 9af91c0cf1 Removed bad test cases -- for now considering this image too blurred for the "easy" test suite
git-svn-id: https://zxing.googlecode.com/svn/trunk@224 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-02-22 19:17:49 +00:00
srowen 5d8e64fdbf Oops, another code typo fix
git-svn-id: https://zxing.googlecode.com/svn/trunk@223 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-02-22 19:13:15 +00:00
srowen 556225ab0a Improved GridSampler API -- no need for reflection anymore. Reintroduced Android GridSampler implementation, which still doesn't quite work yet.
git-svn-id: https://zxing.googlecode.com/svn/trunk@221 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-02-22 17:01:38 +00:00
srowen 4525328e45 Little bug fix affecting QR Codes that run all the way to the left/top edge of an image
git-svn-id: https://zxing.googlecode.com/svn/trunk@215 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-02-19 21:49:26 +00:00
srowen 82bc8e437a Add some basic Code 39, Code 128 tests
git-svn-id: https://zxing.googlecode.com/svn/trunk@214 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-02-19 21:09:55 +00:00
srowen 8c3045d9eb Added "extended mode" to optionally support Extended Code 39
git-svn-id: https://zxing.googlecode.com/svn/trunk@213 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-02-19 19:36:29 +00:00
srowen c09cb7d381 Fixed typo on pattern for "I"
git-svn-id: https://zxing.googlecode.com/svn/trunk@212 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-02-19 19:08:28 +00:00
srowen f363480487 Improved notion of pattern variance in 1D barcode elements, improving decode accuracy slightly. Also fixed a small issue in Code 128 decoder.
git-svn-id: https://zxing.googlecode.com/svn/trunk@211 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-02-19 17:29:16 +00:00
srowen cde4d22ece Refactored Reed-Solomon so it can be used with different GF(256) primitive polynomials
git-svn-id: https://zxing.googlecode.com/svn/trunk@209 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-02-19 16:14:34 +00:00
srowen 833a8b03f7 Another fix to UTF-8 / Shift_JIS guessing
git-svn-id: https://zxing.googlecode.com/svn/trunk@208 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-02-19 16:11:54 +00:00
srowen febdcf8d15 Fixed UTF-8 detection, again, and added unit test
git-svn-id: https://zxing.googlecode.com/svn/trunk@204 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-02-15 16:21:55 +00:00
srowen eb2fa80eaf Biiig standardization of whitespace. 2 space indents now, no tabs.
git-svn-id: https://zxing.googlecode.com/svn/trunk@191 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-02-14 20:25:54 +00:00
srowen 3f3c2fd7e5 More minor javadoc, code tweaks
git-svn-id: https://zxing.googlecode.com/svn/trunk@189 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-02-14 20:05:31 +00:00
srowen 739192b101 Another bug fix
git-svn-id: https://zxing.googlecode.com/svn/trunk@188 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-02-14 19:42:59 +00:00
srowen bbe423c7c2 Oops fixed bug in guessing Shift_JIS -- flipped if condition!
git-svn-id: https://zxing.googlecode.com/svn/trunk@187 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-02-14 19:41:33 +00:00
srowen e334937fa5 Now tries to guess when byte mode is actually encoding text as UTF-8
git-svn-id: https://zxing.googlecode.com/svn/trunk@186 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-02-14 19:34:42 +00:00
srowen ea00e20d22 Major reorg of test cases
git-svn-id: https://zxing.googlecode.com/svn/trunk@180 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-02-13 23:28:52 +00:00
srowen 9f0cd86114 Small optimization to check ranges of bits set in BitArray in bulk
git-svn-id: https://zxing.googlecode.com/svn/trunk@176 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-02-12 17:32:15 +00:00
srowen 51bb41ed24 Check fewer lines, and make sure we don't run off the top/bottom of image
git-svn-id: https://zxing.googlecode.com/svn/trunk@175 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-02-12 17:02:27 +00:00
srowen bd4ec5e4d8 Now make sure javase is built before running tests
git-svn-id: https://zxing.googlecode.com/svn/trunk@174 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-02-12 17:00:55 +00:00
srowen d3a09024f8 Make images smaller for a better test
git-svn-id: https://zxing.googlecode.com/svn/trunk@173 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-02-08 06:40:02 +00:00
srowen dc2c7aa52e Shrunk big images -- more of a challenging test now
git-svn-id: https://zxing.googlecode.com/svn/trunk@172 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-02-07 17:01:13 +00:00
srowen 77ce643b61 Minor javadoc fix
git-svn-id: https://zxing.googlecode.com/svn/trunk@167 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-02-05 22:01:36 +00:00
srowen 7ba2b30d43 Removed unnecessary second decodeRow() method
git-svn-id: https://zxing.googlecode.com/svn/trunk@166 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-02-05 22:00:48 +00:00
srowen 8f7a3346cb Major refactoring of 1D barcode code. Moved into com.google.zxing.oned package. Misc. other changes to support this refactoring
git-svn-id: https://zxing.googlecode.com/svn/trunk@159 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-02-04 19:14:29 +00:00
srowen eb68422111 Added getSize()
git-svn-id: https://zxing.googlecode.com/svn/trunk@153 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-01-22 21:26:57 +00:00
srowen 2798be57ec Few more fixes to how tests are run
git-svn-id: https://zxing.googlecode.com/svn/trunk@152 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-01-22 19:59:11 +00:00
srowen b4d0ffa248 Oops, now need to include JUnit locally
git-svn-id: https://zxing.googlecode.com/svn/trunk@147 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-01-16 22:42:02 +00:00
srowen 35f4a385e2 More test cases from Enrique G. S.
git-svn-id: https://zxing.googlecode.com/svn/trunk@145 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-01-16 22:13:00 +00:00
srowen 552630677f Overhaul unit tests to include more test cases, and begin to establish a decent framework for these black-box tests.
git-svn-id: https://zxing.googlecode.com/svn/trunk@144 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-01-15 20:47:47 +00:00
srowen 20c4317efb Small tweaks to streamline performance and code, and changed row search pattern to search more broadly more quickly, which seems to slightly improve decode performance
git-svn-id: https://zxing.googlecode.com/svn/trunk@140 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-01-10 19:36:33 +00:00
srowen d8ef9bc275 Removed unneeded import
git-svn-id: https://zxing.googlecode.com/svn/trunk@137 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-01-07 21:17:40 +00:00
srowen b112a890fb Improved black point estimation -- favor a point not white so close the white peak
git-svn-id: https://zxing.googlecode.com/svn/trunk@135 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-01-07 16:31:26 +00:00
srowen 80b3dd3632 Trivial move of a commented method to better spot -- won't compile where it is now
git-svn-id: https://zxing.googlecode.com/svn/trunk@134 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-01-02 23:11:41 +00:00
srowen b3ecc20522 Slightly friendlier error message
git-svn-id: https://zxing.googlecode.com/svn/trunk@133 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-01-02 23:08:41 +00:00
dswitkin 31b056997b The UPC decoder now returns a pair of points to indicate the row where the barcode was found.
git-svn-id: https://zxing.googlecode.com/svn/trunk@129 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2007-12-21 20:07:31 +00:00
srowen a9e7e3c8ae Be more forgiving about endpoints that transform to be just off the image
git-svn-id: https://zxing.googlecode.com/svn/trunk@128 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2007-12-21 18:32:49 +00:00
srowen 3fd38e3893 Small logic fix -- OK to end up at border of image in this code
git-svn-id: https://zxing.googlecode.com/svn/trunk@127 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2007-12-21 18:09:03 +00:00
srowen 6fed049a2c Improve correctness of black-run logic in case where patterns are very close to edge
git-svn-id: https://zxing.googlecode.com/svn/trunk@124 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2007-12-18 21:45:44 +00:00
srowen f7ef069a47 Tiny logic improvement
git-svn-id: https://zxing.googlecode.com/svn/trunk@123 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2007-12-18 21:44:08 +00:00
srowen ac3e9d3335 Fixed handling of UPC/QR hints, improved error reporting
git-svn-id: https://zxing.googlecode.com/svn/trunk@121 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2007-12-18 16:43:38 +00:00
srowen fd68032e1a Bug fix from K. Kakima
git-svn-id: https://zxing.googlecode.com/svn/trunk@120 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2007-12-18 16:37:05 +00:00
srowen 0daa06a5e0 Moved com.google.zxing.client.result from core-ext to core, rewrote it for J2ME, changed javame to use it, and removed core-ext
git-svn-id: https://zxing.googlecode.com/svn/trunk@114 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2007-12-12 18:38:22 +00:00
alasdair.john.mackintosh 852669ced6 Don't calculate 1st digit unless checkBothParities is true
git-svn-id: https://zxing.googlecode.com/svn/trunk@102 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2007-12-07 21:06:26 +00:00
dswitkin 776c3db869 Minor changes to support EAN-13.
git-svn-id: https://zxing.googlecode.com/svn/trunk@101 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2007-12-07 20:50:23 +00:00
srowen 611e057250 Added some 'if' braces, changes C-comments to javadocs -- minor stuff
git-svn-id: https://zxing.googlecode.com/svn/trunk@92 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2007-12-06 20:47:05 +00:00
alasdair.john.mackintosh 0ce5a5c57d Add support for EAN-13 barcodes
git-svn-id: https://zxing.googlecode.com/svn/trunk@91 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2007-12-06 19:23:16 +00:00
srowen e459482771 Finally added the beginnings of a decent black-box unit test for QR code decoding
git-svn-id: https://zxing.googlecode.com/svn/trunk@87 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2007-11-30 22:24:02 +00:00
srowen 5ee60cd4e2 Add proguard optimizer support. Switch to compile against WTK class files and target version 1.2 class file output, to possibly fix compatibility issues.
git-svn-id: https://zxing.googlecode.com/svn/trunk@84 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2007-11-29 19:44:05 +00:00
srowen aea9fa22f9 Use max compression on .zip/.jar files
git-svn-id: https://zxing.googlecode.com/svn/trunk@81 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2007-11-28 17:22:39 +00:00
srowen 0dd08d5ed4 I guess build.xml should have a copyright statement too
git-svn-id: https://zxing.googlecode.com/svn/trunk@80 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2007-11-28 17:19:36 +00:00
srowen 0cf90f2197 Now, can build "ZXingReaderBasic" which does not require JSR-234
git-svn-id: https://zxing.googlecode.com/svn/trunk@76 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2007-11-26 20:04:32 +00:00
srowen 2ab0f2e2ad Now makes sure JDK 1.4 / WTK are present. No longer requires Unix-style wc binary, so runs on Windows
git-svn-id: https://zxing.googlecode.com/svn/trunk@74 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2007-11-26 16:21:57 +00:00
srowen b53b6f27cc Should fix problems decoding tiny QR codes without any alignment pattern
git-svn-id: https://zxing.googlecode.com/svn/trunk@63 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2007-11-20 18:51:40 +00:00
srowen a164858fe4 Reference JDK 1.4 classes file location directly to accommodate Mac users, and also include top-level build files in release.
git-svn-id: https://zxing.googlecode.com/svn/trunk@62 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2007-11-20 18:22:52 +00:00
srowen 1c66eceb59 Last updates to build files
git-svn-id: https://zxing.googlecode.com/svn/trunk@60 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2007-11-19 18:33:02 +00:00
dswitkin 25d112c554 Implemented row sampling for histograms and tweaked the valley finding algorithm
for better performance.


git-svn-id: https://zxing.googlecode.com/svn/trunk@56 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2007-11-19 17:26:22 +00:00
srowen eb52d61f46 Initial refactorings to support multiple kinds of black point estimation
git-svn-id: https://zxing.googlecode.com/svn/trunk@50 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2007-11-16 22:06:18 +00:00
srowen 57c5bc3b8e Minor improvements
git-svn-id: https://zxing.googlecode.com/svn/trunk@47 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2007-11-16 16:56:03 +00:00
srowen 09e93c1ae9 Added reference to thresholding resource
git-svn-id: https://zxing.googlecode.com/svn/trunk@45 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2007-11-15 21:00:17 +00:00
srowen f7a402511c Code tweaks and so forth with Daniel
git-svn-id: https://zxing.googlecode.com/svn/trunk@34 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2007-11-14 19:23:23 +00:00
srowen b01673fa29 Added top-level build file, removed local copy of JUnit, added test target to core
git-svn-id: https://zxing.googlecode.com/svn/trunk@32 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2007-11-14 15:27:06 +00:00
dswitkin 89c7787517 Added the initial version of my UPC reader and modified some common files
as necessary to get it building and used by the J2SE command line test.


git-svn-id: https://zxing.googlecode.com/svn/trunk@31 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2007-11-12 23:13:15 +00:00
srowen db56b85644 Tiny tweak
git-svn-id: https://zxing.googlecode.com/svn/trunk@24 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2007-11-09 22:51:09 +00:00
srowen 96ea7e296c Fixed the rest of my typos and added basic unit test
git-svn-id: https://zxing.googlecode.com/svn/trunk@23 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2007-11-09 22:19:46 +00:00
srowen 703852e839 Better, still some bugs
git-svn-id: https://zxing.googlecode.com/svn/trunk@22 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2007-11-09 19:13:28 +00:00
srowen 033ae10187 Replace JAIPerspectiveTransform with PerspectiveTransform
git-svn-id: https://zxing.googlecode.com/svn/trunk@21 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2007-11-08 03:58:13 +00:00
srowen f0a299ec80 Adjust tolerance of method that decides whether a finder/alignment pattern has been crossed so that it passes on low resolution images more correctly -- just a matter of resorting to some floating point math.
git-svn-id: https://zxing.googlecode.com/svn/trunk@18 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2007-11-07 19:18:50 +00:00
srowen 149c7f1b8a Oops, bug fix for MaskPattern100
git-svn-id: https://zxing.googlecode.com/svn/trunk@17 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2007-11-07 18:44:18 +00:00
srowen e73dd9a068 Fix compile problem for JDK 1.4
git-svn-id: https://zxing.googlecode.com/svn/trunk@16 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2007-11-07 18:42:40 +00:00
srowen 9b296c7e1e Added more test cases
git-svn-id: https://zxing.googlecode.com/svn/trunk@15 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2007-11-07 06:52:45 +00:00
srowen 0aeb2f672c More javadoc
git-svn-id: https://zxing.googlecode.com/svn/trunk@14 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2007-11-07 06:42:22 +00:00
srowen d6cfb083a1 More javadoc
git-svn-id: https://zxing.googlecode.com/svn/trunk@13 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2007-11-07 06:40:04 +00:00
srowen cc66a80d3e More javadoc
git-svn-id: https://zxing.googlecode.com/svn/trunk@12 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2007-11-07 06:39:29 +00:00
srowen 424c19f542 More javadoc
git-svn-id: https://zxing.googlecode.com/svn/trunk@11 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2007-11-06 19:41:49 +00:00
srowen 4a39981245 More javadoc
git-svn-id: https://zxing.googlecode.com/svn/trunk@10 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2007-11-06 19:07:08 +00:00
srowen f44627915e Added more javadoc
git-svn-id: https://zxing.googlecode.com/svn/trunk@9 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2007-11-06 18:56:30 +00:00
srowen 265036c128 Fixed dumb bug that caused grid sampling to sample 2x too wide in the horizontal direction.
git-svn-id: https://zxing.googlecode.com/svn/trunk@7 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2007-10-26 17:52:37 +00:00
srowen 7726e8fcb2 git-svn-id: https://zxing.googlecode.com/svn/trunk@6 59b500cc-1b3d-0410-9834-0bbf25fbcc57 2007-10-23 19:12:27 +00:00