Commit graph

167 commits

Author SHA1 Message Date
srowen 88afca0842 Unify UPC-A reader into EAN-13 reader since EAN-13 is a superset and we can take advantage of the commonality to improve performance.
git-svn-id: https://zxing.googlecode.com/svn/trunk@416 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-11 19:30:57 +00:00
dswitkin f431cae59f - Added support for rotation in our blackbox test framework, and refactored the ways tests are created and run.
- Turned on 0 and 180 degree rotation for all 1D formats.
- Turned on 0, 90, 180, and 270 degree rotation for QR.
- Changed the 1D code to re-enable upside down scanning, with a dramatic improvement in barcodes found and fewer false positives.

git-svn-id: https://zxing.googlecode.com/svn/trunk@411 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-11 00:05:51 +00:00
srowen 2cc9d7f630 Tiny bug fix, need to deal with no query params case correctly
git-svn-id: https://zxing.googlecode.com/svn/trunk@410 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-06-10 19:44:47 +00:00
srowen a73fc5919a Added SMSTO support, added subject/body param support in mailto:, improved handling of mailto: and tel: URIs
git-svn-id: https://zxing.googlecode.com/svn/trunk@402 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-05-23 22:40:13 +00:00
srowen c2c8b2fcfb Added handy toString() methods
git-svn-id: https://zxing.googlecode.com/svn/trunk@401 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-05-23 22:20:10 +00:00
srowen 8d31073968 Detector is now a little more skeptical once it has found 3 confirmed finder patterns -- one may be a false positive, so it also checks to see if the estimated module sizes are "pretty similar". If not, keeps looking.
git-svn-id: https://zxing.googlecode.com/svn/trunk@394 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-05-08 15:12:44 +00:00
srowen 40f2cf1a80 Fix some minor javadoc issues
git-svn-id: https://zxing.googlecode.com/svn/trunk@388 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-05-05 17:56:47 +00:00
srowen 08c7c6fadb Checking in somewhat ugly 'fix' for ArrayIndexOutOfBoundsException in rare cases
git-svn-id: https://zxing.googlecode.com/svn/trunk@385 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-05-05 17:31:31 +00:00
srowen 635d904283 Many more little tweaks from IntelliJ inspections
git-svn-id: https://zxing.googlecode.com/svn/trunk@382 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-05-02 19:18:14 +00:00
srowen 188c7fbecb Added preliminary support for MobileTag formats; not enabled yet.
Added "sms:" URI support.

git-svn-id: https://zxing.googlecode.com/svn/trunk@380 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-05-02 18:39:03 +00:00
dswitkin 0987663963 Added some simple sharpening for 1D decoding which allowed a couple more blackbox images to pass. There were a few cases where the format or content is now misdetected, but since the net gain was positive I decided to make those non-fatal errors. In real world use the sharpening seems to help, and I think we can do even better with a better algorithm.
git-svn-id: https://zxing.googlecode.com/svn/trunk@372 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-04-21 18:11:02 +00:00
dswitkin a69a87e98d Replaced the smaller, resized EAN13-2 test images with the full-size originals.
git-svn-id: https://zxing.googlecode.com/svn/trunk@370 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-04-19 18:38:52 +00:00
srowen df25fc1389 Separate out test-unit and test-blackbox targets for running different sorts of tests
git-svn-id: https://zxing.googlecode.com/svn/trunk@369 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-04-18 17:03:04 +00:00
dswitkin 9eceb0593e Added a new test library of 16 blurry EAN-13 barcodes. Currently we cannot decode any of them. I'm checking these in as a baseline so we can evaluate various sharpening techniques.
git-svn-id: https://zxing.googlecode.com/svn/trunk@368 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-04-18 15:51:39 +00:00
dswitkin a2662ebb40 Changed the black box tests to require an absolute number of images to decode successfully, instead of a percentage, and set the high water mark for each test.
git-svn-id: https://zxing.googlecode.com/svn/trunk@367 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-04-18 14:43:56 +00:00
dswitkin a816d5d9b1 Changed the parsing logic to refer to EAN-8 and EAN-13 as UPCs as well, so that the clients can recognize them as product barcodes and offer to do a product search.
git-svn-id: https://zxing.googlecode.com/svn/trunk@366 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-04-18 14:30:02 +00:00
srowen 989dc395f0 Added workaround for NoSuchMethodError on some Nokia JVMs with a superfluous abstract method (thanks Marnix)
git-svn-id: https://zxing.googlecode.com/svn/trunk@364 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-04-16 00:38:54 +00:00
dswitkin ae54d7a937 Changed how many rows we scan while detecting QR finder patterns. The mobile case dynamically calculates this based on the height of the image, and ranges from a small speedup to a big difference for large inputs. Also changed the try harder case to scan every 3rd line for a 3x speedup. The unit tests have the same success rate as before: 16/20 on qr1, 10/10 on qr2.
git-svn-id: https://zxing.googlecode.com/svn/trunk@354 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-04-10 20:26:42 +00:00
srowen 1c9b906442 Workaround for codes that fail to include (required) final TERMINATOR mode indicator
git-svn-id: https://zxing.googlecode.com/svn/trunk@351 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-04-07 22:05:40 +00:00
srowen a5b385e764 Standardize array initializer syntax to use the form without "new type[]", to be consistent and make translation to C++ easier
git-svn-id: https://zxing.googlecode.com/svn/trunk@348 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-04-07 19:42:35 +00:00
srowen 9c1b4a1393 Make two methods public for easier reuse by third-party implementaitons
git-svn-id: https://zxing.googlecode.com/svn/trunk@345 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-04-04 16:34:42 +00:00
srowen 5f25bd00a3 Moved the "geo:" fix to the 'right' place
git-svn-id: https://zxing.googlecode.com/svn/trunk@343 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-04-03 22:18:16 +00:00
mschulkind 87da7e9226 small typo fix.
git-svn-id: https://zxing.googlecode.com/svn/trunk@341 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-04-03 20:34:30 +00:00
srowen d1d7e96238 At last, removing SKIP_N_BARCODES and separating this logic out in a way that individual projects can implement it on their own. It's a bit too onerous and project-specific to live on in the main code.
git-svn-id: https://zxing.googlecode.com/svn/trunk@340 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-04-03 16:39:44 +00:00
srowen 28ea8e02f0 Parsing wasn't correctly ignoring the ':' in prefix!
git-svn-id: https://zxing.googlecode.com/svn/trunk@339 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-04-03 16:12:08 +00:00
srowen 0e7872020c Another fix to ensure that 2 barcodes with the same info are counted separately.
git-svn-id: https://zxing.googlecode.com/svn/trunk@338 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-04-03 15:39:06 +00:00
srowen 01075819c5 "Skip 0 barcodes" was incorrectly not returning the first barcode found
git-svn-id: https://zxing.googlecode.com/svn/trunk@337 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-04-02 14:03:02 +00:00
srowen 012a8c0ce7 Fixed same ResultPoint bug in Code 128 and Code 39 reader; added convenient toString() to Result and GenericResultPoint; added arg checking for Result constructor too
git-svn-id: https://zxing.googlecode.com/svn/trunk@336 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-04-02 13:40:29 +00:00
dswitkin f299f413e0 Fixed the result points for 1D decoding so that we once again get a green line in the Android client across the successful row.
git-svn-id: https://zxing.googlecode.com/svn/trunk@335 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-04-01 21:23:14 +00:00
srowen 11fc234d76 Completed basic support for NFC / NDEF formats applicable to 2D barcodes. Not yet enabled.
git-svn-id: https://zxing.googlecode.com/svn/trunk@329 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-03-31 20:51:24 +00:00
srowen 683a78256d Improved bounds-checking and point-nudging logic in GridSampler. We should check more than endpoints.
git-svn-id: https://zxing.googlecode.com/svn/trunk@317 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-03-26 17:01:13 +00:00
srowen 4473c00147 Restored a corrected Reed-Solomon optimization and fixed a small issue in black box test cases
git-svn-id: https://zxing.googlecode.com/svn/trunk@316 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-03-26 16:22:02 +00:00
srowen c465263306 A few refactorings in anticipation of more formats that needs some common functionality
git-svn-id: https://zxing.googlecode.com/svn/trunk@315 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-03-26 14:46:57 +00:00
srowen 7de539a67c biasTowardsWhite was, embarassingly, not accomplishing anything mathematically. It proved to not have much value so has been removed, to simplify the code.
git-svn-id: https://zxing.googlecode.com/svn/trunk@313 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-03-26 14:42:33 +00:00
srowen 5f1428308d Undo optimization that seems to not be correct in all cases -- will have to evaluate again later
git-svn-id: https://zxing.googlecode.com/svn/trunk@312 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-03-26 14:13:14 +00:00
srowen 3a1e3dc156 Optimized 0- and 1-error case of Reed Solomon decoding a bit
git-svn-id: https://zxing.googlecode.com/svn/trunk@309 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-03-24 20:02:06 +00:00
srowen eec9cd339f More small improvements to SKIP_N_BARCODES -- now remembers value across invocations of doDecode()
git-svn-id: https://zxing.googlecode.com/svn/trunk@305 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-03-20 17:08:07 +00:00
srowen 93054c2213 Restored SKIP_N_BARCODES functionality and corrected a logic error
git-svn-id: https://zxing.googlecode.com/svn/trunk@304 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-03-20 17:01:19 +00:00
srowen 76757bdcd4 More proper support for geo: URLs in Android
git-svn-id: https://zxing.googlecode.com/svn/trunk@301 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-03-19 20:18:28 +00:00
srowen b0f43f0991 "Try harder" mode now tries 2D formats first. BlackPointEstimator more conservative about rejecting histograms with too little dynamic range. Temporarily deprecated SKIP_N_BARCODES hint.
git-svn-id: https://zxing.googlecode.com/svn/trunk@300 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-03-19 18:40:52 +00:00
srowen fc2f28080d Take small advantage of "TRY_HARDER" in QR code decoder
git-svn-id: https://zxing.googlecode.com/svn/trunk@299 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-03-19 17:10:58 +00:00
srowen c28040bc61 Oops, forgot to include in last commit
git-svn-id: https://zxing.googlecode.com/svn/trunk@298 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-03-19 17:10:11 +00:00
srowen 14a9eb7d20 Fixed bug in rotation code for BufferedImageMonochromeBitmapSource; fixed "SKIP_N_BARCODES" behavior to ignore barcodes already found.
git-svn-id: https://zxing.googlecode.com/svn/trunk@297 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-03-19 17:09:27 +00:00
srowen efb0fb9e3b Dumb logic error in boundary case for transformation: "nudging" the rightmost pixel of a line back onto the image was actually nudging the leftmost pixel
git-svn-id: https://zxing.googlecode.com/svn/trunk@296 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-03-19 14:45:49 +00:00
srowen 7129e6a5ee Added overdue Reed-Solomon tests
git-svn-id: https://zxing.googlecode.com/svn/trunk@293 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-03-17 20:48:32 +00:00
srowen 379c3a8cc0 Add support for tel: URIs
git-svn-id: https://zxing.googlecode.com/svn/trunk@292 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-03-17 20:17:20 +00:00
srowen 5248fb1a7e Only parse UPC result out of a UPC format code, to avoid "false positives" from other formats
git-svn-id: https://zxing.googlecode.com/svn/trunk@291 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-03-17 20:16:20 +00:00
srowen 5ae6e5be71 git-svn-id: https://zxing.googlecode.com/svn/trunk@290 59b500cc-1b3d-0410-9834-0bbf25fbcc57 2008-03-17 18:41:10 +00:00
srowen cc06bc326b Fixed naming convention. Everything should be a "ParsedResult"
git-svn-id: https://zxing.googlecode.com/svn/trunk@289 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-03-17 18:24:26 +00:00
srowen b18107391b Nope, disable link from geo: URL to Google Maps. Does not quite work in the browser yet.
git-svn-id: https://zxing.googlecode.com/svn/trunk@287 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2008-03-17 16:50:03 +00:00