srowen
e1dd41a115
Improve detector logic to throw out false positive finder patterns in a more reasonable manner. Current logic didn't quite achieve its goal in some corner cases and needed rethinking and some simplification. Fixes a reported failure from the group list. Net change in passed test cases is -1 otherwise (for 270 degree rotation -- not vital) so I consider it a net tiny win.
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@1039 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-08-23 15:32:01 +00:00
srowen
362236564e
Miscellaneous changes from FindBugs analysis
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@1038 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-08-22 15:16:36 +00:00
srowen
9045bd2409
Update to final HTTP Client binaries
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@1037 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-08-21 16:17:50 +00:00
dswitkin
599d513d73
Made another fix for the Samsung Galaxy, and bumped the version to 2.92.
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@1036 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-08-21 14:18:31 +00:00
dswitkin
fc9bc55213
Made a new fix to turn off the Samsung Galaxy flash, and cut release 2.91.
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@1035 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-08-19 14:52:16 +00:00
srowen
3cab89a732
Make web app work on Servlet/JSP 2.3/1.2 and fix some other mistakes
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@1034 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-08-13 11:11:48 +00:00
srowen
14b2850f92
Issue 224, remove Christian's info since it seems to prevent the build from working for developers?
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@1033 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-08-12 09:15:52 +00:00
srowen
0bf2c2a66e
Boneheaded mistake: was writing transparent pixels
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@1032 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-08-04 21:59:24 +00:00
srowen
9cfc5158b3
Need to use 1.5 jar location
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@1031 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-08-04 15:57:37 +00:00
srowen
b6b9015a7c
Disable email-based decoding -- won't be able to support it soon and it is very rarely used by anyone. Leaving code in for future reference though.
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@1030 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-08-04 08:54:02 +00:00
srowen
95596de0d2
Fix issue 221
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@1029 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-08-04 08:53:05 +00:00
srowen
6dbf893cb0
Add MatrixToImageWriter convenience class, small code tweaks in javase/, make ByteMatrix width/height property getters names standard
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@1028 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-07-30 08:58:57 +00:00
dswitkin
d8b1011324
Fixed some long lines over 100 columns.
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@1027 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-07-23 22:10:43 +00:00
srowen
4331605913
Added error correction level to Result
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@1026 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-07-22 10:40:18 +00:00
srowen
91d8e04d86
Re-enable ProGuard, and finally identified the workaround that seems to make 4.4 work with our code without a VerifyError
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@1025 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-07-22 10:36:11 +00:00
dswitkin
9dc583f556
Set a camera parameter to force the flash off. Also fixed the uninstall build targets.
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@1024 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-07-21 21:36:33 +00:00
dswitkin
d71c099313
Converted the Android client and the test app to use the Android 1.5 SDK, and to use a more efficient preview frame mechanism too. We now require devices to be running Cupcake or a newer version of the platform. This change temporarily removes the Proguard step, which Sean is going to add back.
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@1023 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-07-21 19:33:25 +00:00
srowen
9f475ac33e
Small detector simplification that addresses issue 215 and picks up a net +4 more images decoded in tests
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@1022 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-07-21 09:39:31 +00:00
srowen
636c00e844
Another tweak to get some valid ISO-8859-1 strings like "frédéric" to be guessed correctly
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@1021 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-07-17 09:30:46 +00:00
dswitkin
38f73bca64
Added an optimization to the Android client's LuminanceSource implementation, and removed manual array copies in favor of System.arraycopy().
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@1020 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-07-15 18:32:01 +00:00
dswitkin
c51c5800f6
Added Germany to the list of Google Product Search locales.
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@1019 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-07-10 18:55:04 +00:00
dswitkin
c0cf079ccb
Created v2.9 of Barcode Scanner, and added Japanese translations.
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@1018 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-07-09 15:20:42 +00:00
dswitkin
54e6ed418a
More x, y cleanup and 100 column fixes.
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@1017 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-07-08 21:17:52 +00:00
dswitkin
402880798c
Modified my skew correction code to also work upside down, meaning we now decode three more inverted PDF 417 images.
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@1016 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-07-08 20:38:21 +00:00
dswitkin
b238cb7828
I noticed that the codeword coordinates in PDF 417 barcodes were a few pixels off if there was skew or rotation in the image. I added a simple method to correct the vertical component of these points, and the units tests went from 8/23 to 11/23.
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@1015 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-07-02 20:07:09 +00:00
dswitkin
0944a2bb18
Got 180 degree rotation working for PDF 417, and turned on the appropriate unit tests as a result.
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@1014 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-07-01 19:42:52 +00:00
dswitkin
af2ce46c37
Cleaned up a number of comments and code to fit in 100 columns and added some TODO items.
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@1013 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-07-01 16:35:05 +00:00
dswitkin
e44f00ba75
Converted the last user of the old MonochromeBitmapSource-style calls over to BitMatrix, and removed these deprecated methods.
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@1012 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-07-01 16:13:25 +00:00
dswitkin
c31b489efe
Added the second PDF 417 test to the AllPositiveBlackBoxTester.
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@1011 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-07-01 15:13:44 +00:00
dswitkin
01eed5266e
- Converted parts of the PDF 417 reader to use BitMatrix.
...
- Changed the PDF 417 detector to search the image more broadly, instead of assuming the barcode starts in the left 1/4 and ends in the right 1/4. We now get 8/23 on the real-world blackbox test, and we'll probably do even better with further improvements here.
- Added a quiet zone to two of the unit test images and updated a golden result for one of them. We now get 3/7 on the first test.
- Tried to fix some bugs in the upside down code but it still doesn't work.
git-svn-id: https://zxing.googlecode.com/svn/trunk@1010 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-06-30 21:55:19 +00:00
dswitkin
0667b29155
Added the PDF 417 blackbox tests to the test-blackbox Ant target.
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@1009 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-06-30 18:51:43 +00:00
dswitkin
f5124cec37
Created a new blackbox unit test of real-world PDF 417 images taken with an Android device. Currently we decode 0/23.
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@1008 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-06-30 18:47:34 +00:00
dswitkin
2397216901
Added a few computer-generated PDF 417 barcodes to the blackbox tests. The current code doesn't seem to handle more advanced error correction modes.
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@1007 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-06-30 17:32:12 +00:00
dswitkin
eb8b9677cf
Added the previous Android benchmark I've been using to track performance, as well as a new one which uses wider images and therefore twice as many pixels.
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@1006 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-06-29 22:08:38 +00:00
dswitkin
e2324bc2ae
Added slightly better blackbox unit test stats.
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@1005 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-06-29 21:57:59 +00:00
dswitkin
10dfe7789b
- Got the DataMatrix decoder compiling again with a quick bandaid.
...
- Fixed two bugs in the LocalBlockBinarizer sharpening routine. It can now decode 2132 images in our blackbox tests, compared to 2103 using the global histogram approach.
- Added the PDF 417 blackbox test to AllPositiveBlackBoxTester, and allowed it to complete even if the tests fail.
git-svn-id: https://zxing.googlecode.com/svn/trunk@1004 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-06-29 15:49:42 +00:00
srowen
597fcfb23d
Code analysis tweaks
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@1003 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-06-28 16:33:02 +00:00
christian.brunschen
f09b742ea2
* Throw the actual exception objects, rather than pointers to them, i.e.:
...
- replace |throw new FooException()| with |throw FooException()|
- replace |catch (FooException *ex)| with |catch (FooExceptio ex)|
- update all uses of caught exceptions appropriately:
. replace |ex->foo| with |ex.foo|
. remove all attempts to delete the caught exception(s)
* Add 'const' to the 'char *' declarations for character encoding names
git-svn-id: https://zxing.googlecode.com/svn/trunk@1002 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-06-27 13:22:03 +00:00
dswitkin
cca4b72bfa
Whoops, fixed long-standing bug in the benchmark. Never noticed before because we always used square images.
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@1001 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-06-26 21:18:58 +00:00
dswitkin
c3e5f1fcfd
Modified the CommandLineRunner to use all available decoders, even the ones which aren't considered production quality yet.
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@1000 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-06-26 20:03:10 +00:00
srowen
550511d760
Remove use of BinaryBitmap in QR Code, DM
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@999 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-06-26 19:22:48 +00:00
dswitkin
ce1badea71
Sean had a good idea to add @deprecated Javadoc comments to these three methods to help track down their usage. We can't use a Java @Deprecated annotation because core builds against Java 1.2.
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@998 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-06-26 19:04:12 +00:00
srowen
65f4f7c1c6
Fix an (old?) compile error
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@997 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-06-26 19:03:04 +00:00
dswitkin
8acb0017b1
Updated the Android Test app to use a wider viewfinder, to save images as PNGs instead of JPEGs, and to work on phones without a shutter button.
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@996 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-06-26 18:48:14 +00:00
srowen
a4b2678420
Updates for appspot
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@995 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-06-26 18:08:05 +00:00
srowen
dd067b4ba2
Nevermind, removing javadoc
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@994 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-06-26 18:01:31 +00:00
dswitkin
167197ec7a
Refactored the MonochromeBitmapSource class hierarchy into LuminanceSource, Binarizer, and BinaryBitmap classes. The unit tests pass and I believe the change is complete, but there are some clients like J2ME and Bug that I can't build.
...
This change will allow new thresholding algorithms to be developed and tested, as well as implemented per platform if needed (e.g. in JNI on Android). It should also perform better when multiple 2D Readers are installed, because the underlying image will only be converted to 1 bit once. It also allows some platforms to return luminance data without a copy.
The current state of this checkin is to use the old black point algorithm, which now lives in GlobalHistogramBinarizer. This will be our benchmark and fallback for slower platforms. Going forward we will begin to use LocalBlockBinarizer as I shake out the edge cases and tune it for performance. Currently it is unused.
IMPORTANT: I have temporarily included three methods from MonochromeBitmapSource at the end of BinaryBitmap as a way to make this change in stages. They are deprecated and will be removed soon. All of the Reader classes will need to change the way they examine 1 bit pixels to use the new getBlackRow() and getBlackMatrix() calls.
git-svn-id: https://zxing.googlecode.com/svn/trunk@993 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-06-26 17:49:45 +00:00
srowen
54d65e315d
Try adding current javadoc to SVN
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@992 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-06-26 17:47:15 +00:00
kev.sully
974fb5e403
ISSUE: http://code.google.com/p/zxing/issues/detail?id=42
...
Added PDF417 to list of readers. Will be used only if its specified in a Hint.
git-svn-id: https://zxing.googlecode.com/svn/trunk@987 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-06-26 14:34:16 +00:00
dswitkin
da4f56b022
Fixed some code which was ignoring the result of MonochromeBitmapSource calls, which may work in some cases but isn't legal and failed and in some experiments.
...
git-svn-id: https://zxing.googlecode.com/svn/trunk@986 59b500cc-1b3d-0410-9834-0bbf25fbcc57
2009-06-25 19:46:49 +00:00