2935 commits

Author	SHA1	Message	Date
Michael Kret	be5890536f	feat: HighLevel oauth2 api credentials (#9542)	2024-05-30 16:21:50 +02:00
कारतोफ्फेलस्क्रिप्ट™	596990bed7	ci: Fix vulnerable dev dependencies (no-changelog) (#9545)	2024-05-30 13:54:29 +02:00
कारतोफ्फेलस्क्रिप्ट™	e55bf0393a	fix(core): Try setting postgres search_path on the database (#9530)	2024-05-30 12:09:49 +02:00
Iván Ovejero	4629354705	refactor(core): Increase minimum supported Node.js version to 18.17 (#9533)	2024-05-29 12:22:38 +02:00
Iván Ovejero	dbaac82f79	fix(core): Set source control repository to track remote if ready (#9532)	2024-05-29 10:21:21 +02:00
कारतोफ्फेलस्क्रिप्ट™	ac4e0fbb47	fix(core): Block Public API related REST calls when Public API is not enabled (#9521)	2024-05-28 14:43:22 +02:00
Danny Martini	e07de837b9	test(core): Align test names with route names (no-changelog) (#9518)	2024-05-27 20:41:34 +02:00
Iván Ovejero	008f62aaf4	refactor: Delete dead crash recovery code (no-changelog) (#9512)	2024-05-27 13:55:52 +02:00
Iván Ovejero	8164ca2398	fix(core): Fix worker encryption key warning docs link (no-changelog) (#9513)	2024-05-27 11:50:57 +02:00
Cornelius Suermann	e8c824bad6	build: Bump license-sdk to v2.12.0 (no-changelog) (#9510)	2024-05-25 12:01:17 +02:00
Cornelius Suermann	36b99cd277	Revert "build: Bump license-sdk to v2.11.1 (no-changelog)" ... This reverts commit 2010c5a3cd.	2024-05-24 17:01:39 +02:00
Cornelius Suermann	2010c5a3cd	build: Bump license-sdk to v2.11.1 (no-changelog)	2024-05-24 16:58:33 +02:00
कारतोफ्फेलस्क्रिप्ट™	a77e8dd79e	feat(core): Upgrade all langchain related dependencies (#9504) ... Signed-off-by: Oleg Ivaniv <me@olegivaniv.com> Co-authored-by: Oleg Ivaniv <me@olegivaniv.com>	2024-05-24 14:43:17 +02:00
कारतोफ्फेलस्क्रिप्ट™	6ea8607716	ci: Switch to Node.js 20 by default. Add initial support for Node.js 22 (#9501)	2024-05-24 12:32:50 +02:00
Iván Ovejero	a58be175cc	fix(core): Prevent re-parsing of dynamically loaded options (#9503)	2024-05-24 11:00:15 +02:00
कारतोफ्फेलस्क्रिप्ट™	b585777c79	refactor(core): Use consistent CSRF state validation across oAuth controllers (#9104) ... Co-authored-by: Danny Martini <danny@n8n.io>	2024-05-23 19:08:01 +02:00
Danny Martini	3b93aae6dc	feat(core): Print the name of the migration that cannot be reverted when using n8n db:revert (#9473)	2024-05-23 18:16:26 +02:00
Iván Ovejero	f8683c31e0	refactor(core): Stop reporting EAUTH error codes to Sentry (no-changelog) (#9496)	2024-05-23 15:12:01 +02:00
Iván Ovejero	75408b0113	refactor: Remove skipped tests (no-changelog) (#9497)	2024-05-23 12:29:20 +02:00
कारतोफ्फेलस्क्रिप्ट™	0deb7d0fcc	Merge tag 'n8n@1.43.0'	2024-05-22 17:42:03 +02:00
github-actions[bot]	6bdfaf8f5b	🚀 Release 1.43.0 (#9491) ... Co-authored-by: RicardoE105 <RicardoE105@users.noreply.github.com>	2024-05-22 11:29:57 -04:00
Iván Ovejero	d9616fc36f	fix(core): Fix iFrame not displaying on FE dev mode (no-changelog) (#9492)	2024-05-22 17:29:30 +02:00
Iván Ovejero	9bdc83a399	perf(core): Optimize executions filtering by metadata (#9477)	2024-05-22 17:20:01 +02:00
Iván Ovejero	bc219e0499	refactor(core): Make execution status non-nullable (no-changelog) (#9483)	2024-05-22 16:56:05 +02:00
Iván Ovejero	1cb6c12b4f	refactor(core): Track potentially unneeded inferral of execution status (no-changelog) (#9476)	2024-05-22 16:42:06 +02:00
कारतोफ्फेलस्क्रिप्ट™	fc83005ba0	fix(core): Do not allow admins to delete the instance owner (#9489)	2024-05-22 16:23:40 +02:00
कारतोफ्फेलस्क्रिप्ट™	88b9a4070b	fix(core): Do not allow admins to generate password-reset links for instance owner (#9488)	2024-05-22 16:13:56 +02:00
Iván Ovejero	a217866cef	fix(core): Account for retry of execution aborted by pre-execute hook (#9474)	2024-05-22 15:22:07 +02:00
कारतोफ्फेलस्क्रिप्ट™	3094f1b886	fix(core): Detect DB connection aquisition deadlocks (no-changelog) (#9485) ... Co-authored-by: Danny Martini <danny@n8n.io>	2024-05-22 14:53:23 +02:00
Omar Ajoue	c1eef60ccd	test: Add tests for license manager reinit method (#9471)	2024-05-22 10:26:49 +01:00
Iván Ovejero	d21ad15c1f	fix(core): Fix 431 for large dynamic node parameters (#9384)	2024-05-21 19:11:02 +02:00
Omar Ajoue	747012dcfd	fix: Init license properly with multi main (no-changelog) (#9467)	2024-05-20 13:02:08 +01:00
कारतोफ्फेलस्क्रिप्ट™	6f2d83bffd	fix(core): Setup webhook stopping endpoint after the CORS middleware (no-changelog) (#9454)	2024-05-17 17:55:29 +02:00
Csaba Tuncsik	596c472ecc	feat: RBAC (#8922) ... Signed-off-by: Oleg Ivaniv <me@olegivaniv.com> Co-authored-by: Val <68596159+valya@users.noreply.github.com> Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in> Co-authored-by: Valya Bullions <valya@n8n.io> Co-authored-by: Danny Martini <danny@n8n.io> Co-authored-by: Danny Martini <despair.blue@gmail.com> Co-authored-by: Iván Ovejero <ivov.src@gmail.com> Co-authored-by: Omar Ajoue <krynble@gmail.com> Co-authored-by: oleg <me@olegivaniv.com> Co-authored-by: Michael Kret <michael.k@radency.com> Co-authored-by: Michael Kret <88898367+michael-radency@users.noreply.github.com> Co-authored-by: Elias Meire <elias@meire.dev> Co-authored-by: Giulio Andreini <andreini@netseven.it> Co-authored-by: Giulio Andreini <g.andreini@gmail.com> Co-authored-by: Ayato Hayashi <go12limchangyong@gmail.com>	2024-05-17 10:53:15 +02:00
कारतोफ्फेलस्क्रिप्ट™	0d7358807b	fix(core): Add an option to disable STARTTLS for SMTP connections (#9415)	2024-05-16 10:45:58 +02:00
github-actions[bot]	8f254527e3	🚀 Release 1.42.0 (#9405) ... Co-authored-by: netroy <netroy@users.noreply.github.com>	2024-05-15 12:16:42 +02:00
Iván Ovejero	4d2115c163	refactor: Remove cli/src/helpers (no-changelog) (#9368)	2024-05-13 10:22:11 +02:00
कारतोफ्फेलस्क्रिप्ट™	5025d209ca	fix(core): All calls to plainToInstance should exclude extraneous values (no-changelog) (#9338)	2024-05-08 15:49:41 +02:00
कारतोफ्फेलस्क्रिप्ट™	e217473f9e	Merge tag 'n8n@1.41.0'	2024-05-08 14:19:21 +02:00
Milorad FIlipović	cda062bde6	feat(editor): Remove AI Error Debugging (#9337)	2024-05-08 14:13:47 +02:00
github-actions[bot]	75f74035a1	🚀 Release 1.41.0 (#9342) ... Co-authored-by: ivov <ivov@users.noreply.github.com>	2024-05-08 14:08:46 +02:00
Michael Kret	6b6e8dfc33	feat(Simulate Node): New node (no-changelog) (#9109)	2024-05-08 12:02:36 +01:00
कारतोफ्फेलस्क्रिप्ट™	23b676d7cb	fix(core): Webhooks responding with binary data should not prematurely end the response stream (#9063)	2024-05-07 13:48:20 +02:00
Danny Martini	225fdbb379	fix(core): Report missing SAML attributes early with an actionable error message (#9316)	2024-05-07 10:27:44 +02:00
Iván Ovejero	7b925ab871	refactor(core): Rename ActiveWorkflowRunner to ActiveWorkflowManager (no-changelog) (#9280)	2024-05-06 17:54:05 +02:00
Iván Ovejero	22b6f90950	fix(core): Prevent occassional 429s on license init in multi-main setup (#9284)	2024-05-06 09:04:16 +02:00
Iván Ovejero	7bda92cc7c	refactor(core): Use logger for packages/cli messages (no-changelog) (#9302)	2024-05-03 15:24:27 +02:00
github-actions[bot]	d3e0640674	🚀 Release 1.40.0 (#9286) ... Co-authored-by: elsmr <elsmr@users.noreply.github.com>	2024-05-02 14:30:42 +02:00
Alex Grozav	cd9bc44bdd	feat: Add Ask AI to HTTP Request Node (#8917)	2024-05-02 13:52:15 +03:00
oleg	f05d96cea0	refactor: Update Langchain dependencies (no-changelog) (#9252) ... Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>	2024-04-29 16:15:42 +02:00
Iván Ovejero	2917d04766	refactor(core)!: Switch default Postgres user from root to postgres (#9248)	2024-04-29 14:19:19 +02:00
Yoshino-s	24c3150056	fix(core): Add view engine to webhook server to support forms (#9224)	2024-04-29 10:55:45 +02:00
pengqiseven	8a26f4280a	fix: Typo fixes in various descriptions (no-changelog) (#8854) ... Signed-off-by: pengqiseven <912170095@qq.com> Co-authored-by: pengqiseven <i@sohu.com>	2024-04-29 09:06:32 +01:00
Cornelius Suermann	442aaba116	fix: Elaborate scope of Sustainable Use License (#9233)	2024-04-27 08:38:25 +02:00
Tomi Turtiainen	0b52320635	feat: Upgrade typeorm for separate sqlite read & write connections (#9230)	2024-04-26 16:02:51 +03:00
Iván Ovejero	093dcefafc	fix(core): Stop relying on filesystem for SSH keys (#9217)	2024-04-25 15:09:12 +02:00
Danny Martini	1efeeccc5b	fix(core): Fix browser session refreshes not working (#9212) ... Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>	2024-04-24 18:28:19 +02:00
github-actions[bot]	9bd849202a	🚀 Release 1.39.0 (#9209) ... Co-authored-by: RicardoE105 <RicardoE105@users.noreply.github.com>	2024-04-24 09:18:54 -04:00
कारतोफ्फेलस्क्रिप्ट™	3996d2852a	fix(core): Upgrade mysql2 to address CVE-2024-21511 (#9206)	2024-04-24 11:03:21 +02:00
Michael Kret	2bf0a3933e	feat(Webhook Node): Setting to enable multiple outputs/methods (#9086) ... Co-authored-by: Giulio Andreini <andreini@netseven.it>	2024-04-24 08:46:16 +03:00
Michael Kret	91e59120c4	fix(core): Cache issue (no-changelog) (#9173)	2024-04-19 11:58:18 +03:00
Michael Kret	699fd70c24	feat(n8n Form Trigger Node): Option to remove attribution (#9162)	2024-04-19 11:26:19 +03:00
Alex Grozav	a3eea3ac5e	feat(editor): Refactor and unify executions views (no-changelog) (#8538)	2024-04-19 07:50:18 +02:00
Tomi Turtiainen	be8203a1da	fix(core): Upgrade @n8n/typeorm (no-changelog) (#9163) ... Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>	2024-04-18 17:00:03 +03:00
कारतोफ्फेलस्क्रिप्ट™	ff9ae549fd	fix(core): Improve browserId checks, and add logging (#9161)	2024-04-18 15:53:19 +02:00
कारतोफ्फेलस्क्रिप्ट™	0ed46711f4	feat(core): Setup helmet.js for setting security headers (#9027)	2024-04-18 10:18:09 +02:00
कारतोफ्फेलस्क्रिप्ट™	46e432b177	fix(core): Exclude oAuth callback urls from browser-id checks (#9158)	2024-04-17 19:20:51 +02:00
कारतोफ्फेलस्क्रिप्ट™	9bd8e10b35	feat(core): Upgrade mysql2 to address CVE-2024-21507, CVE-2024-21508, and CVE-2024-21509 (#9154)	2024-04-17 16:43:57 +02:00
github-actions[bot]	1aa92168eb	🚀 Release 1.38.0 (#9153) ... Co-authored-by: netroy <netroy@users.noreply.github.com>	2024-04-17 13:39:33 +02:00
Deborah	fa93fb81b0	docs: Update executions.id.yml to fix typo (#9142)	2024-04-15 12:31:02 +02:00
Danny Martini	3eb5be5f5a	fix(core): Don't create multiple owners when importing credentials or workflows (#9112)	2024-04-12 17:25:59 +02:00
कारतोफ्फेलस्क्रिप्ट™	1b199c08ce	fix(core): Add an option to add additional non-ui routes (no-changelog) (#9122)	2024-04-11 12:20:29 +02:00
Iván Ovejero	cf435c3311	fix(core): Support MySQL in MoveSshKeysToDatabase migration (#9120)	2024-04-11 11:00:20 +02:00
Danny Martini	3bb821f10e	fix(core): Don't revert irreversibble migrations (#9105)	2024-04-11 09:20:48 +02:00
github-actions[bot]	feffc7ffd9	🚀 Release 1.37.0 (#9114) ... Co-authored-by: ivov <ivov@users.noreply.github.com>	2024-04-10 15:42:29 +02:00
Iván Ovejero	a3b59843d5	refactor(core): Lint for cyclomatic complexity in BE packages (no-changelog) (#9111)	2024-04-10 14:02:02 +02:00
कारतोफ्फेलस्क्रिप्ट™	9403657e46	refactor(core): Remove unnecessary indirection in SAML code (no-changelog) (#9103)	2024-04-10 10:55:49 +02:00
कारतोफ्फेलस्क्रिप्ट™	a7108d14f9	fix(core): Some more browser-id related fixes (no-changelog) (#9102)	2024-04-10 10:37:23 +02:00
Iván Ovejero	c2f4d7d796	fix(core): Fix isLeader check in WaitTracker constructor (#9100)	2024-04-09 15:50:10 +02:00
oleg	cfaab0b829	fix(AWS Bedrock Chat Model Node): Improve filtering of Bedrock models & fix Claude 3 (#9085) ... Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>	2024-04-09 14:22:48 +02:00
कारतोफ्फेलस्क्रिप्ट™	28261047c3	feat(core): Prevent session hijacking (#9057)	2024-04-09 11:20:35 +02:00
oleg	936682eeaa	feat(core): Improve Langsmith traces for AI executions (#9081) ... Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>	2024-04-08 22:51:49 +02:00
Val	f4f0a36fe1	feat: Add credential update and delete events to log streaming (#9026)	2024-04-08 08:13:39 +01:00
Iván Ovejero	df56153f8b	refactor(core): Better UX for maxStalledCount queue mode error (#9075)	2024-04-05 20:03:49 +02:00
Iván Ovejero	7bf0f900f1	fix(core): Remove binary data when deleting executions by filter (#9056)	2024-04-05 18:00:35 +02:00
Iván Ovejero	0c90c7c8c1	fix(API): Accept settings.executionOrder in workflow creation (#9072)	2024-04-05 17:49:14 +02:00
Iván Ovejero	ae3f164c5c	test(core): Fix multiple parallel private key checks (no-changelog) (#9012)	2024-04-05 17:45:21 +02:00
Iván Ovejero	4052b6c073	refactor(core)!: Remove legacy --file flag for execute CLI command (#9054)	2024-04-05 14:28:04 +02:00
Iván Ovejero	ff81de3313	fix(core): Ensure TTL safeguard for test webhooks applies only to multi-main setup (#9062)	2024-04-05 14:15:49 +02:00
कारतोफ्फेलस्क्रिप्ट™	ff77ef4b62	ci: Delete some duplicate code in cli tests (no-changelog) (#9049)	2024-04-05 13:47:49 +02:00
Iván Ovejero	b8ab049932	refactor(core, editor): Remove legacy nodesAccess (no-changelog) (#9016)	2024-04-05 13:17:34 +02:00
Iván Ovejero	217b07d735	fix(core): Ensure only leader handles waiting executions (#9014)	2024-04-04 13:28:20 +02:00
Val	0ac985133b	fix: Workflows executed from other workflows not stopping (#9010)	2024-04-04 10:02:37 +01:00
कारतोफ्फेलस्क्रिप्ट™	dc42ac17a6	fix(core): Upgrade express to address CVE-2024-29041 (no-changelog) (#9021)	2024-04-03 17:08:06 +02:00
कारतोफ्फेलस्क्रिप्ट™	a45fd0dbf4	ci(core): Upgrade express-openapi-validator (no-changelog) (#9022)	2024-04-03 16:57:33 +02:00
कारतोफ्फेलस्क्रिप्ट™	76b73a27a0	refactor(core): Delete all auth exclusion config and checks (no-changelog) (#9044)	2024-04-03 16:56:36 +02:00
कारतोफ्फेलस्क्रिप्ट™	072c3db97d	refactor(core): Rename push sessionId to pushRef (#8905)	2024-04-03 13:43:14 +02:00
github-actions[bot]	15fb6cbd4a	🚀 Release 1.36.0 (#9039) ... Co-authored-by: netroy <netroy@users.noreply.github.com>	2024-04-03 12:34:11 +02:00
कारतोफ्फेलस्क्रिप्ट™	e2bde6b751	Merge tag 'n8n@1.35.0'	2024-04-03 12:15:26 +02:00
कारतोफ्फेलस्क्रिप्ट™	a6446fe057	feat(core): Rate-limit login endpoint to mitigate brute force password guessing attacks (#9028)	2024-04-03 12:15:19 +02:00
Iván Ovejero	2aab78b058	feat(core): Introduce AWS secrets manager as external secrets store (#8982)	2024-03-28 10:15:58 +01:00
Michael Kret	e84c27c0ce	feat(Webhook Node): Overhaul (#8889) ... Co-authored-by: Giulio Andreini <andreini@netseven.it>	2024-03-28 10:46:39 +02:00
github-actions[bot]	1b6a1d6372	🚀 Release 1.35.0 (#8988) ... Co-authored-by: ivov <ivov@users.noreply.github.com>	2024-03-27 17:21:10 +01:00
Iván Ovejero	519f945547	refactor: Merge tag n8n@1.34.2 (#8987)	2024-03-27 17:07:10 +01:00
Michael Kret	335f363ca1	feat: Telemetry include basic llm optional promps, trigger on save workflow event (#8981)	2024-03-27 16:16:02 +01:00
Iván Ovejero	ddc0f57116	refactor(core): Store SSH key pair for source control in DB settings (#8965)	2024-03-26 19:09:46 +01:00
Iván Ovejero	260bc07ca9	fix(core): Assign credential ownership correctly in source control import (#8955)	2024-03-26 17:18:41 +01:00
कारतोफ्फेलस्क्रिप्ट™	372d5c7d01	ci: Upgrade eslint, prettier, typescript, and some other dev tooling (no-changelog) (#8895) ... Co-authored-by: Iván Ovejero <ivov.src@gmail.com>	2024-03-26 14:22:57 +01:00
Iván Ovejero	ef45da95f1	test(core): Improve coverage for ActiveWorkflowRunner (no-changelog) (#8946)	2024-03-25 17:59:59 +01:00
Iván Ovejero	7d52419d6f	refactor(core): Remove dead utils (no-changelog) (#8947)	2024-03-25 17:59:42 +01:00
Iván Ovejero	69807a5efb	refactor(core): Unify failed and error execution status (no-changelog) (#8943)	2024-03-25 17:52:07 +01:00
Iván Ovejero	079a1147d4	fix(core): Ensure the generic OAuth2 API credential uses the OAuth2 credential test (#8941)	2024-03-21 13:49:34 +01:00
कारतोफ्फेलस्क्रिप्ट™	669bd830e9	feat(editor): Block the frontend when trying to access n8n from another host over http (#8906)	2024-03-18 18:34:41 +01:00
कारतोफ्फेलस्क्रिप्ट™	c4c319d7cf	feat(core): Add support for SQLite connection pooling (#8722)	2024-03-14 13:45:16 +01:00
कारतोफ्फेलस्क्रिप्ट™	5201484d7a	fix(core): Update xml2js to address CVE-2023-0842 (no-changelog) (#8881)	2024-03-13 17:50:18 +01:00
कारतोफ्फेलस्क्रिप्ट™	6e99e26f69	feat(core): Update ws and handlebars to match langchain peer-dependencies (no-changelog) (#8882)	2024-03-13 17:11:20 +01:00
Alex Grozav	948c383999	feat: Add AI Error Debugging using OpenAI (#8805)	2024-03-13 16:48:00 +02:00
कारतोफ्फेलस्क्रिप्ट™	e3dd353ea7	Merge tag 'n8n@1.33.0'	2024-03-13 14:56:43 +01:00
github-actions[bot]	77adcf171f	🚀 Release 1.33.0 (#8879) ... Co-authored-by: netroy <netroy@users.noreply.github.com>	2024-03-13 14:36:33 +01:00
कारतोफ्फेलस्क्रिप्ट™	a6f7d23ce1	feat(Microsoft SQL Node): Upgrade mssql package (no-changelog) (#8873) ... Co-authored-by: Michael Kret <michael.k@radency.com>	2024-03-13 14:27:12 +01:00
कारतोफ्फेलस्क्रिप्ट™	71f1b23771	feat(core): Update some packages to address CVE-2022-29622 (no-changelog) (#8877)	2024-03-13 12:47:36 +01:00
कारतोफ्फेलस्क्रिप्ट™	b8424fdd98	Merge tag 'n8n@1.32.0'	2024-03-12 19:05:51 +01:00
कारतोफ्फेलस्क्रिप्ट™	c9b3fa1d0f	fix(core): Remove jwks-rsa/jose to address CVE-2024-28176 (no-changelog) (#8868)	2024-03-12 17:22:31 +01:00
Danny Martini	11173a0114	fix: Ignore semver range when upgrading comunity packages (#8863)	2024-03-11 17:12:20 +00:00
Giulio Andreini	5301323906	feat(editor): Improve errors in output panel (#8644) ... Co-authored-by: Michael Kret <michael.k@radency.com>	2024-03-07 18:08:01 +02:00
Omar Ajoue	c6f6254c0e	fix: Always register webhooks on startup (#8830)	2024-03-07 09:25:12 +00:00
github-actions[bot]	9abc0f0f0a	🚀 Release 1.32.0 (#8826) ... Co-authored-by: krynble <krynble@users.noreply.github.com>	2024-03-06 12:42:39 +00:00
Val	0e037add71	fix: PermissionChecker integration tests (no-changelog) (#8776)	2024-03-05 19:18:34 +01:00
कारतोफ्फेलस्क्रिप्ट™	0818824a72	feat(core)!: Set the secure flag on issued cookies (#8812)	2024-03-05 18:57:41 +01:00
कारतोफ्फेलस्क्रिप्ट™	2b0e14e936	fix(core): Refactor push sessionid validation, and add unit tests (no-changelog) (#8815)	2024-03-05 18:57:29 +01:00
कारतोफ्फेलस्क्रिप्ट™	4af907fba8	feat(core): Upgrade expressjs (no-changelog) (#8811)	2024-03-05 17:12:29 +01:00
कारतोफ्फेलस्क्रिप्ट™	62282c2bde	fix(core): Disable CollaborationService (no-changelog) (#8813)	2024-03-05 16:34:43 +01:00
कारतोफ्फेलस्क्रिप्ट™	cdec7c9334	feat(core): Update hashing strategy for JWTs (#8810)	2024-03-05 15:06:29 +01:00
कारतोफ्फेलस्क्रिप्ट™	d1b48ddcac	fix(core): Remove sensitive data from User entity during serialization (no-changelog) (#8773)	2024-02-29 14:20:39 +01:00
कारतोफ्फेलस्क्रिप्ट™	db4a419c8d	refactor(core): Enforce authorization by default on all routes (no-changelog) (#8762)	2024-02-28 17:02:18 +01:00
कारतोफ्फेलस्क्रिप्ट™	2811f77798	refactor(core): Rename RequireGlobalScope to GlobalScope (no-changelog) (#8760)	2024-02-28 14:40:02 +01:00
कारतोफ्फेलस्क्रिप्ट™	56c8791aff	refactor(core): Remove all legacy auth middleware code (no-changelog) (#8755)	2024-02-28 13:12:28 +01:00
github-actions[bot]	2e84684f04	🚀 Release 1.31.0 (#8759) ... Co-authored-by: netroy <netroy@users.noreply.github.com>	2024-02-28 12:18:12 +01:00
कारतोफ्फेलस्क्रिप्ट™	5f6da7b84e	fix(core): Do not report generic webhook execution errors (no-changelog) (#8749)	2024-02-27 12:36:49 +01:00
Omar Ajoue	737170893d	feat: Allow instance owners and admins to edit all credentials (#8716) ... Co-authored-by: Danny Martini <despair.blue@gmail.com>	2024-02-27 08:26:36 +00:00
Alex Grozav	4b01335aa4	feat: Add env variables to support exposing /workflows/demo route and /nodes.json route (#8506) ... Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>	2024-02-23 18:20:12 +02:00
कारतोफ्फेलस्क्रिप्ट™	35fb7102cb	refactor(core): Update auth related typings (no-changelog) (#8686)	2024-02-23 15:08:18 +01:00
Jan Oberhauser	a29b41ec55	fix(core): Fix pairedItem issue with partial manual executions (#8575) ... Co-authored-by: Danny Martini <danny@n8n.io> Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>	2024-02-23 11:43:08 +01:00
github-actions[bot]	8b67dfbed9	🚀 Release 1.30.0 (#8702) ... Co-authored-by: netroy <netroy@users.noreply.github.com>	2024-02-21 15:43:44 +01:00
कारतोफ्फेलस्क्रिप्ट™	059d281fd1	feat(core): Move execution permission checks earlier in the lifecycle (#8677)	2024-02-21 14:47:02 +01:00
Iván Ovejero	5304b320c8	refactor(core): Enrich inaccessible credential error (#8574) ... Co-authored-by: Omar Ajoue <krynble@gmail.com> Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>	2024-02-21 13:04:30 +01:00
Tomi Turtiainen	05e13a68ea	fix: Fix typeorm .save usage (no-changelog) (#8678)	2024-02-20 17:34:54 +02:00
कारतोफ्फेलस्क्रिप्ट™	afd2eb1f4a	fix(core): Report all sqlite transaction rollback errors to Sentry (no-changelog) (#8680)	2024-02-20 15:28:12 +01:00
कारतोफ्फेलस्क्रिप्ट™	b6c8a0c413	refactor(core): Reduce code duplication in DB config (no-changelog) (#8679)	2024-02-20 14:28:53 +01:00
github-actions[bot]	c4e259bcfc	🚀 Release 1.29.0 (#8643) ... Co-authored-by: krynble <krynble@users.noreply.github.com>	2024-02-15 11:08:48 +00:00
Omar Ajoue	540a80e9f9	test: Fix broken workflow tag tests (#8641) ... Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <netroy@users.noreply.github.com> Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>	2024-02-15 10:51:59 +00:00
Danny Martini	24859cfef5	docs: Document own mode removal in BREAKING-CHANGES.md (no-changelog) (#8632)	2024-02-14 16:26:01 +01:00
कारतोफ्फेलस्क्रिप्ट™	a2a3ca160f	fix(core): Improve the startup error when EXECUTIONS_PROCESS is set (#8630) ... Co-authored-by: Omar Ajoue <krynble@gmail.com>	2024-02-14 15:35:42 +01:00
कारतोफ्फेलस्क्रिप्ट™	68498cb72a	fix(core): Upgrade @n8n/typeorm to address postgres timestamp issues (#8627)	2024-02-14 14:17:57 +01:00
Danny Martini	cd8ca8412d	fix(core): Give better error message if executions.process is still used in the configs (#8618)	2024-02-13 12:40:50 +00:00
Danny Martini	ee81015231	docs: Update cursor description in the public api documentation (#8602)	2024-02-09 16:36:57 +01:00
Cornelius Suermann	5a613d4a8b	build: Update License-SDK to v2.10.0 (no-changelog) (#8537)	2024-02-09 16:10:50 +01:00
Omar Ajoue	a743a40376	feat(API): Add tag support to public API (#8588) ... Co-authored-by: Jesús Burgers <jesus.burgers@chakray.co.uk> Co-authored-by: Jesús Burgers <43568066+jburgers-chakray@users.noreply.github.com>	2024-02-09 15:10:03 +00:00
Cornelius Suermann	cd151f1ba9	feat: Include totalUsers in usage metrics during license renewal (no-changelog) (#8598)	2024-02-09 14:15:05 +01:00
oleg	5ab34fe335	fix(API): Fire workflowExecuteBefore hook in runMainProcess (no-changelog) (#8601)	2024-02-09 13:23:00 +01:00
Omar Ajoue	7501ad8f3c	feat: Add support for AI log streaming (#8526) ... Co-authored-by: Oleg Ivaniv <me@olegivaniv.com>	2024-02-09 09:41:01 +00:00
कारतोफ्फेलस्क्रिप्ट™	8e392cfc1d	feat(core): Migrate to n8n's typeorm fork (#8590)	2024-02-08 15:13:29 +01:00
कारतोफ्फेलस्क्रिप्ट™	7826bd842a	feat: Upgrade typeorm, sqlite3, and pg/pg-promise (#8579)	2024-02-08 10:40:18 +01:00
कारतोफ्फेलस्क्रिप्ट™	5750e8e88e	fix(core): Upgrade rudderstack sdk to address npm postInstall issues (#8568)	2024-02-08 10:40:10 +01:00
कारतोफ्फेलस्क्रिप्ट™	40eee3aa49	ci(core): Avoid slow bcrypt calls in tests (no-changelog) (#8570)	2024-02-07 17:56:02 +01:00
github-actions[bot]	1b7ebe463e	🚀 Release 1.28.0 (#8569) ... Co-authored-by: ivov <ivov@users.noreply.github.com>	2024-02-07 15:39:40 +01:00
कारतोफ्फेलस्क्रिप्ट™	c04f92f7fd	refactor(core): Couple of refactors on WorkflowRunner and ActiveExecutions (no-changelog) (#8487)	2024-02-06 18:09:50 +01:00
Iván Ovejero	dc068ce2e6	build: Fix outdated import to fix build (no-changelog) (#8558)	2024-02-06 10:45:30 +01:00
Iván Ovejero	abddbb6227	fix(core): Use trx manager instead of repository for tags overwrite (#8557)	2024-02-06 10:40:32 +01:00
Iván Ovejero	c4e39451db	refactor(core): Continue breaking dependency cycles (no-changelog) (#8545)	2024-02-06 10:08:46 +01:00
Iván Ovejero	28aee7c425	refactor(core): Lock webhook process out of multi-main setup (no-changelog) (#8549)	2024-02-05 18:06:54 +01:00
Iván Ovejero	dca50dcc68	docs: Add encryption key check to breaking changes list (#8551)	2024-02-05 16:39:59 +01:00
Danny Martini	b62c1d7c41	fix: Remove ts-node from overrides and typeorm script (no-changelog) (#8547)	2024-02-05 14:09:22 +01:00
Iván Ovejero	dc5ec8f946	refactor(core): Streamline flows in multi-main mode (no-changelog) (#8446)	2024-02-05 09:26:55 +01:00
कारतोफ्फेलस्क्रिप्ट™	ee5e422094	fix(core): Upgrade nodemailer to address an exploit (#8535)	2024-02-02 14:12:18 +01:00
Iván Ovejero	92f939f827	fix(core): Fix workflow tagging failure due to unique constraint check (#8505)	2024-02-02 12:36:55 +01:00
कारतोफ्फेलस्क्रिप्ट™	4fed68ee34	fix(core): Fix DropRoleMapping migration (#8521)	2024-02-02 12:22:09 +01:00
कारतोफ्फेलस्क्रिप्ट™	5832d3ca46	fix(core): Fix PermissionChecker.check, and add additional unit tests (#8528)	2024-02-02 12:21:53 +01:00
Iván Ovejero	528c07134a	fix(core): Fix test runs of triggers that rely on static data (#8524)	2024-02-01 18:05:23 +01:00
Iván Ovejero	cc41fc7c80	fix(core): Fix new graceful shutdown env being always overridden by deprecated env (#8503)	2024-02-01 11:10:40 +01:00
कारतोफ्फेलस्क्रिप्ट™	88cf1823d3	Merge tag 'n8n@1.27.0'	2024-01-31 20:33:25 +01:00
कारतोफ्फेलस्क्रिप्ट™	d2d0ae6c5d	ci: Fix DB tests (no-changelog) (#8513)	2024-01-31 17:36:50 +01:00
github-actions[bot]	7aa3ef7168	🚀 Release 1.27.0 (#8512) ... Co-authored-by: ivov <ivov@users.noreply.github.com>	2024-01-31 16:08:37 +01:00
कारतोफ्फेलस्क्रिप्ट™	033fd344b5	fix(core): Handle possibly invalid updatedAt timestamps in source-control (#8485)	2024-01-31 14:25:03 +01:00
कारतोफ्फेलस्क्रिप्ट™	839dd96c7d	refactor(core): Move all code related to onServerStarted into InternalHooks (no-changelog) (#8500)	2024-01-31 13:29:17 +01:00
Danny Martini	39e8754784	fix(core): Don't report executions that have been paused as failed to rudderstack and log streams (#8501)	2024-01-31 11:21:15 +01:00
Iván Ovejero	dac511b710	refactor(core): Modernize credentials controllers and services (no-changelog) (#8488) ... Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>	2024-01-31 09:48:48 +01:00
कारतोफ्फेलस्क्रिप्ट™	121a55b691	feat(core): Remove own execution-process mode (#8490)	2024-01-30 12:51:40 +01:00
कारतोफ्फेलस्क्रिप्ट™	5cb55270b7	refactor(core): Replace promisify-d node calls with native promises (no-changelog) (#8464)	2024-01-30 09:49:23 +01:00
Iván Ovejero	238b54c77b	fix(core): Fix stopping and retrying failed executions (#8480)	2024-01-29 16:34:58 +01:00
Iván Ovejero	9e93980957	fix(core): Prevent calling internal hook email event if emailing is disabled (#8462) ... Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>	2024-01-29 16:15:30 +01:00
Iván Ovejero	db48bdd6d1	fix(core): Handle zero execution statistics on metrics collection during license renewal (#8463)	2024-01-26 17:50:19 +01:00
कारतोफ्फेलस्क्रिप्ट™	2fba0e8d58	feat(core): Upgrade Rudderstack SDK to address CVE-2023-45857 (#8368)	2024-01-26 16:58:44 +01:00
Danny Martini	9f11eba0a4	fix(core): Point users to the official documentation when they use n8n --help (#8440)	2024-01-26 15:16:53 +01:00
कारतोफ्फेलस्क्रिप्ट™	c70fa66e76	refactor(core): Use DI for WorkflowRunner (no-changelog) (#8372)	2024-01-26 13:49:39 +01:00
कारतोफ्फेलस्क्रिप्ट™	7c49004018	refactor(core): Use DI for eventBus code - Part 1 (no-changelog) (#8434)	2024-01-26 12:21:15 +01:00
कारतोफ्फेलस्क्रिप्ट™	ef4507c821	Merge tag 'n8n@1.26.0'	2024-01-25 16:49:18 +01:00
कारतोफ्फेलस्क्रिप्ट™	cc2f0ada76	ci: Enforce noUnusedLocals on all backend and nodes packages (no-changelog) (#8428)	2024-01-25 14:33:35 +01:00
कारतोफ्फेलस्क्रिप्ट™	f438082442	fix(core): Run the down migration correctly when transaction: false is set (no-changelog) (#8432)	2024-01-24 19:07:47 +01:00
Michael Kret	ed7d6b7b3a	feat(core): Display conditions in displayOptions (no-changelog) (#7888)	2024-01-24 18:04:46 +02:00
कारतोफ्फेलस्क्रिप्ट™	d6deceacde	refactor(core): Remove roleId indirection (no-changelog) (#8413)	2024-01-24 13:38:57 +01:00
github-actions[bot]	111d2ebe68	🚀 Release 1.26.0 (#8427) ... Co-authored-by: ivov <ivov@users.noreply.github.com>	2024-01-24 13:28:47 +01:00
कारतोफ्फेलस्क्रिप्ट™	1affebd85e	refactor(core): Remove unused code from Server.ts (no-changelog) (#8426)	2024-01-24 12:55:43 +01:00
Cornelius Suermann	a8b4684192	build: Bump license-sdk to v2.9.1 (no-changelog) (#8420)	2024-01-23 14:44:46 +01:00
Iván Ovejero	c0bc94c78f	refactor(core): Finish removing UserManagementHelper (no-changelog) (#8418)	2024-01-23 13:58:31 +01:00
Iván Ovejero	a0a1830696	feat(core): Email recipients on resource shared (#8408)	2024-01-23 12:03:59 +01:00
Danny Martini	ae06fdeb62	fix(core): Fix update workflow cli command being unable to activate all workflows (#8412) ... Co-authored-by: Daniel Schröder <daniel.schroeder@skriptfabrik.com>	2024-01-23 10:59:06 +01:00
Iván Ovejero	49b52c4f1d	refactor(core): Bring active executions into executions controller (no-changelog) (#8371)	2024-01-23 09:48:50 +01:00
कारतोफ्फेलस्क्रिप्ट™	913c8c6b0c	feat(core): Upgrade oclif (no-changelog) (#8381)	2024-01-22 18:25:36 +01:00
Cornelius Suermann	d597c2ab29	feat: Extend collection of usage metrics during license renewal (no-changelog) (#8369) ... Co-authored-by: Iván Ovejero <ivov.src@gmail.com>	2024-01-22 12:29:28 +01:00
Iván Ovejero	f35d4fcbd8	refactor(core): Simplify OrchestrationService (no-changelog) (#8364)	2024-01-22 11:16:29 +01:00
Danny Martini	07e6705256	feat(core): Custom session timeout and refresh configuration (#8342)	2024-01-22 09:54:13 +01:00
Giulio Andreini	f4f496ae85	docs(editor): All buttons to sentence case (no-changelog) (#8399)	2024-01-22 09:20:02 +01:00
Jon	9883eda42e	fix: Fix openapi generation (no-changelog) (#8398)	2024-01-19 18:15:33 +01:00
Iván Ovejero	749ac2b407	fix(core): Adjust starter node priority for manual executions with pinned activators (#8386)	2024-01-19 10:18:04 +01:00
कारतोफ्फेलस्क्रिप्ट™	c7c4ae4514	feat(core): Upgrade swagger (no-changelog) (#8384)	2024-01-18 14:16:14 +01:00
Tomi Turtiainen	f31cc0743f	fix: Force posthog recording to be disabled outside cloud (#8374)	2024-01-18 14:44:27 +02:00
Jon	fc94377036	fix: Fix issue preventing secrets with a - in the path from being imported (#8378)	2024-01-18 09:24:58 +00:00
Tomi Turtiainen	99457019f7	feat: Nudge users to become template creators if eligible (#8357)	2024-01-17 19:07:34 +02:00
कारतोफ्फेलस्क्रिप्ट™	3912c5e7ab	feat(core): Upgrade axios and follow-redirects to address CVE-2023-26159 (#8366)	2024-01-17 16:41:01 +01:00
कारतोफ्फेलस्क्रिप्ट™	639d34769e	feat(core): Upgrade bull and ioredis to address CVE-2023-52079 (#8365)	2024-01-17 16:33:54 +01:00
Tomi Turtiainen	9a1cc56806	fix: Set '@typescript-eslint/return-await' rule to 'always' for node code (no-changelog) (#8363) ... Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>	2024-01-17 17:08:50 +02:00
Iván Ovejero	2eb829a6b4	refactor(core): Use DI in execution services (no-changelog) (#8358)	2024-01-17 15:42:19 +01:00
github-actions[bot]	7268d24259	🚀 Release 1.25.0 (#8362) ... Co-authored-by: netroy <netroy@users.noreply.github.com>	2024-01-17 14:20:55 +01:00
Iván Ovejero	771d2fa341	test(core): Fix cleanup in test teardown script (no-changelog) (#8361)	2024-01-17 14:01:56 +01:00
Omar Ajoue	d5455d7acc	fix(core): Report when waitTill is invalid and handle it (#8356)	2024-01-17 13:08:20 +01:00
कारतोफ्फेलस्क्रिप्ट™	7cdbb424e3	refactor(core): Move methods from WorkflowHelpers into various workflow services (no-changelog) (#8348)	2024-01-17 10:16:13 +01:00
Iván Ovejero	d4c93b1607	fix(core): Prevent issues with missing or mismatching encryption key (#8332)	2024-01-16 18:25:53 +01:00
Iván Ovejero	7bb2d1799e	refactor(core): Consolidate executions controllers (no-changelog) (#8349)	2024-01-16 16:52:21 +01:00
कारतोफ्फेलस्क्रिप्ट™	64ceb16af6	refactor(core): Use DI in PermissionChecker (no-changelog) (#8344)	2024-01-16 14:15:29 +01:00
Iván Ovejero	420b4271a9	refactor(core): Move typeorm operators from Public API (no-changelog) (#8319)	2024-01-16 13:35:43 +01:00
Omar Ajoue	e1acb5911a	refactor: Make execution IDs mandatory in BE (#8299) ... Co-authored-by: Iván Ovejero <ivov.src@gmail.com>	2024-01-16 09:53:17 +00:00
Iván Ovejero	0f4f472a72	refactor(core): Eliminate dead Redis code (no-changelog) (#8292)	2024-01-16 09:31:45 +01:00
Iván Ovejero	5fbd7971e0	fix(core): Account for immediate confirmation request during test webhook creation (#8329)	2024-01-16 09:17:41 +01:00
Ricardo Espinoza	3c2a4000ae	refactor(core): Use DI for LDAP code (no-changelog) (#8248) ... Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>	2024-01-15 09:01:48 -05:00
Iván Ovejero	1a0e285553	feat(core): Implement inter-main communication for test webhooks in multi-main setup (#8267)	2024-01-12 11:48:58 +01:00
oleg	884396ea0d	fix(API): Fix manual chat trigger execution (#8300) ... Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>	2024-01-11 14:01:07 +01:00
Omar Ajoue	8c7f39907f	fix: Properly output saml validation errors (#8284)	2024-01-10 16:56:04 +01:00
github-actions[bot]	8a4231e9f6	🚀 Release 1.24.0 (#8290) ... Co-authored-by: ivov <ivov@users.noreply.github.com>	2024-01-10 16:16:25 +01:00
Omar Ajoue	8a7c629ea1	fix: Store workflow settings when saving an execution (#8288)	2024-01-10 14:20:37 +00:00
Michael Kret	ccde38a8a8	fix(Monday.com Node): Migrate to api 2023-10 (#8254)	2024-01-10 11:17:00 +02:00
Iván Ovejero	5032bf0e34	fix(core): Fix test webhook deregistration (#8247)	2024-01-09 16:02:32 +01:00
Iván Ovejero	0dabe5c74e	fix: Fix user reinvites on FE and BE (#8261)	2024-01-09 13:52:34 +01:00
Tomi Turtiainen	3b996a7da0	feat(core): Validate shutdown handlers on startup (#8260)	2024-01-08 17:46:45 +02:00
Tomi Turtiainen	8affdf680d	fix: Hide cred setup button from canvas (no-changelog) (#8255)	2024-01-08 13:59:04 +02:00
Iván Ovejero	90c065e999	refactor(core): Convert workflows controller to DI (no-changelog) (#8253)	2024-01-08 12:54:23 +01:00
कारतोफ्फेलस्क्रिप्ट™	ac1c642fdd	fix(core): Do not add Authentication header when authentication type is body (#8201)	2024-01-08 12:38:24 +01:00
Jan Oberhauser	ccb2b076f8	fix: Resolve expressions in credentials following paired item (#8250) ... ## Summary Fixes the issue that pairedItem information was not available in expressions that got used in credentials ## Related tickets and issues [PAY-1207](https://linear.app/n8n/issue/PAY-1207/paireditem-expressions-not-working-correctly-in-credentials) ## Review / Merge checklist - [x] PR title and summary are descriptive. **Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise.** ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md)) - [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created. - [ ] Tests included. > A bug is not considered fixed, unless a test is added to prevent it from happening again. > A feature is not complete without tests. --------- Co-authored-by: Omar Ajoue <krynble@gmail.com>	2024-01-08 09:48:20 +00:00
Iván Ovejero	f2939568cf	perf(core): Optimize workflow activation errors (#8242) ... At https://github.com/n8n-io/n8n/pull/8213 we introduced Redis hashes for workflow ownership and manual webhooks... - to remove clutter from multiple related keys at the top level, - to improve performance by preventing serializing-deserializing, and - to guarantee atomicity during concurrent updates in multi-main setup. Workflow activation errors can also benefit from this. Added test coverage as well. To test manually, create a workflow with a trigger with an invalid credential, edit the workflow's `active` column to `true`, and restart. The activation error should show as a red triangle on canvas and in the workflow list.	2024-01-05 13:06:42 +01:00
Iván Ovejero	23a4ac96c0	refactor(core): Continue moving typeorm operators to repositories (no-changelog) (#8212) ... Follow-up to: https://github.com/n8n-io/n8n/pull/8186	2024-01-05 13:06:24 +01:00
Iván Ovejero	f53c482939	perf(core): Improve caching service (#8213) ... Story: https://linear.app/n8n/issue/PAY-1188 - Implement Redis hashes on the caching service, based on Micha's work in #7747, adapted from `node-cache-manager-ioredis-yet`. Optimize workflow ownership lookups and manual webhook lookups with Redis hashes. - Simplify the caching service by removing all currently unused methods and options: `enable`, `disable`, `getCache`, `keys`, `keyValues`, `refreshFunctionEach`, `refreshFunctionMany`, `refreshTtl`, etc. - Remove the flag `N8N_CACHE_ENABLED`. Currently some features on `master` are broken with caching disabled, and test webhooks now rely entirely on caching, for multi-main setup support. We originally introduced this flag to protect against excessive memory usage, but total cache usage is low enough that we decided to drop this setting. Apparently this flag was also never documented. - Overall caching service refactor: use generics, reduce branching, add discriminants for cache kinds for better type safety, type caching events, improve readability, remove outdated docs, etc. Also refactor and expand caching service tests. Follow-up to: https://github.com/n8n-io/n8n/pull/8176 --------- Co-authored-by: Michael Auerswald <michael.auerswald@gmail.com>	2024-01-05 11:52:44 +01:00
Iván Ovejero	22a5f5258d	feat(core): Cache test webhook registrations (#8176) ... In a multi-main setup, we have the following issue. The user's client connects to main A and runs a test webhook, so main A starts listening for a webhook call. A third-party service sends a request to the test webhook URL. The request is forwarded by the load balancer to main B, who is not listening for this webhook call. Therefore, the webhook call is unhandled. To start addressing this, cache test webhook registrations, using Redis for queue mode and in-memory for regular mode. When the third-party service sends a request to the test webhook URL, the request is forwarded by the load balancer to main B, who fetches test webhooks from the cache and, if it finds a match, executes the test webhook. This should be transparent - test webhook behavior should remain the same as so far. Notes: - Test webhook timeouts are not cached. A timeout is only relevant to the process it was created in, so another process retrieving from Redis a "foreign" timeout will be unable to act on it. A timeout also has circular references, so `cache-manager-ioredis-yet` is unable to serialize it. - In a single-main scenario, the timeout remains in the single process and is cleared on test webhook expiration, successful execution, and manual cancellation - all as usual. - In a multi-main scenario, we will need to have the process who received the webhook call send a message to the process who created the webhook directing this originating process to clear the timeout. This will likely be implemented via execution lifecycle hooks and Redis channel messages checking session ID. This implementation is out of scope for this PR and will come next. - Additional data in test webhooks is not cached. From what I can tell, additional data is not needed for test webhooks to be executed. Additional data also has circular references, so `cache-manager-ioredis-yet` is unable to serialize it. Follow-up to: #8155	2024-01-03 16:58:33 +01:00
github-actions[bot]	053503531f	🚀 Release 1.23.0 (#8205) ... # [1.23.0](https://github.com/n8n-io/n8n/compare/n8n@1.22.0...n8n@1.23.0) (2024-01-03) ### Bug Fixes * **Asana Node:** Omit body from GET, HEAD, and DELETE requests ([#8057](https://github.com/n8n-io/n8n/issues/8057)) ([15ffd4f](15ffd4fb9f)) * **core:** Better input validation for the changeRole endpoint ([#8189](https://github.com/n8n-io/n8n/issues/8189)) ([cfe9525](cfe9525dd4)) * **core:** Fix issue that pinnedData is not used with Test-Webhooks ([#8123](https://github.com/n8n-io/n8n/issues/8123)) ([fa8bd8b](fa8bd8b9eb)) * **core:** Handle empty executions table in pruning in migrations ([#8121](https://github.com/n8n-io/n8n/issues/8121)) ([ffaa30d](ffaa30ddc4)) * **core:** Remove circular dependency in WorkflowService and ActiveWorkflowRunner ([#8128](https://github.com/n8n-io/n8n/issues/8128)) ([21788d9](21788d9153)) * **core:** Use pinned data only for manual mode ([#8164](https://github.com/n8n-io/n8n/issues/8164)) ([ea7e76f](ea7e76fa3b)) * **Discord Node:** Remove unnecessary requirement on parameters ([#8060](https://github.com/n8n-io/n8n/issues/8060)) ([ef3a577](ef3a57719e)) * **editor:** Avoid sanitizing output to search node data ([#8126](https://github.com/n8n-io/n8n/issues/8126)) ([c83d9f4](c83d9f45ba)) * **editor:** Enable explicit undo keyboard shortcut across all code editors ([#8178](https://github.com/n8n-io/n8n/issues/8178)) ([cf7f668](cf7f6688ba)) * **editor:** Fix operation change failing in certain conditions ([#8114](https://github.com/n8n-io/n8n/issues/8114)) ([711fa2b](711fa2b925)) * **editor:** Fix templates view layout ([#8196](https://github.com/n8n-io/n8n/issues/8196)) ([d01e42a](d01e42a2aa)) * **editor:** Fix UI urls when hosted behind a path prefix ([#8198](https://github.com/n8n-io/n8n/issues/8198)) ([5c078f1](5c078f1b3d)) * **editor:** Prevent browser zoom when scrolling inside sticky edit mode ([#8116](https://github.com/n8n-io/n8n/issues/8116)) ([e928210](e928210ccd)) * **editor:** Prevent canvas undo/redo when NDV is open ([#8118](https://github.com/n8n-io/n8n/issues/8118)) ([39e45d8](39e45d8b92)) * **editor:** Prevent storing pairedItem data inside of pinData ([#8173](https://github.com/n8n-io/n8n/issues/8173)) ([405e267](405e26757e)) * **GitHub Node:** Fix issue that File->Get did not run once per item ([#8190](https://github.com/n8n-io/n8n/issues/8190)) ([11cda41](11cda41214)) * **Invoice Ninja Node:** Fix issue with custom invoice numbers not working with v5 ([#8200](https://github.com/n8n-io/n8n/issues/8200)) ([3b6ae2d](3b6ae2d0a5)) * **Microsoft Excel 365 Node:** Ensure arg is string during worksheet table search ([#8154](https://github.com/n8n-io/n8n/issues/8154)) ([8e873ca](8e873ca2f3)) * **Notion Node:** Ensure arg is string during page ID extraction ([#8153](https://github.com/n8n-io/n8n/issues/8153)) ([e94b8a6](e94b8a6c30)) * **Redis Trigger Node:** Activating a workflow with a Redis trigger fails ([#8129](https://github.com/n8n-io/n8n/issues/8129)) ([a169b74](a169b74062)) * **Schedule Trigger Node:** Use the correct `moment` import ([#8185](https://github.com/n8n-io/n8n/issues/8185)) ([17a4e2e](17a4e2ea80)) * Show public API upgrade CTA when feature is not enabled ([#8109](https://github.com/n8n-io/n8n/issues/8109)) ([e9c7fd7](e9c7fd7397)) ### Features * **core:** Add closeFunction support to Sub-Nodes ([#7708](https://github.com/n8n-io/n8n/issues/7708)) ([bec0fae](bec0faed9e)) * **core:** Add user.profile.beforeUpdate hook ([#8144](https://github.com/n8n-io/n8n/issues/8144)) ([e126ed7](e126ed74f3)) * **core:** Improvements/overhaul for nodes working with binary data ([#7651](https://github.com/n8n-io/n8n/issues/7651)) ([5e16dd4](5e16dd4ab4)) * **core:** Remove discontinued crypto-js ([#8104](https://github.com/n8n-io/n8n/issues/8104)) ([01e9a79](01e9a79238)) * **core:** Unify application components shutdown ([#8097](https://github.com/n8n-io/n8n/issues/8097)) ([3a881be](3a881be6c2)) * **editor:** Add node execution status indicator to output panel ([#8124](https://github.com/n8n-io/n8n/issues/8124)) ([ab74bad](ab74bade05)) * **editor:** Add template Id to workflow metadata ([#8088](https://github.com/n8n-io/n8n/issues/8088)) ([517b050](517b050d0a)) * **Home Assistant Node:** Use the new Home Assistant logo ([#8150](https://github.com/n8n-io/n8n/issues/8150)) ([518a99e](518a99e528)) * **Qdrant Vector Store Node:** Qdrant vector store support ([#8080](https://github.com/n8n-io/n8n/issues/8080)) ([66460f6](66460f66b0)) * **Wordpress Node:** Add option to ignore error when using self signed certificates ([#8199](https://github.com/n8n-io/n8n/issues/8199)) ([65c8e12](65c8e12b96)) Co-authored-by: ivov <ivov@users.noreply.github.com>	2024-01-03 13:41:28 +01:00
कारतोफ्फेलस्क्रिप्ट™	cfe9525dd4	fix(core): Better input validation for the changeRole endpoint (#8189) ... also refactored the code to 1. stop passing around `scope === 'global'`, since this code can be used only for changing globalRole. 2. leak less details when input validation fails. ## Review / Merge checklist - [x] PR title and summary are descriptive - [x] Tests included	2024-01-03 09:33:35 +01:00
Iván Ovejero	40c1eeeddd	refactor(core): Continue moving typeorm operators to repositories (no-changelog) (#8186) ... Follow-up to: #8163	2024-01-02 17:53:24 +01:00
Tomi Turtiainen	e126ed74f3	feat(core): Add user.profile.beforeUpdate hook (#8144) ... Add `user.profile.beforeUpdate` hook so we can prevent user email change if it overlaps with other users email.	2024-01-02 10:15:12 +02:00
Iván Ovejero	ece48d6a13	refactor(core): Unify workflow controllers (no-changelog) (#8175) ... Combine EE workflows controller into main workflows controller, protecting paid functionality behind feature flag checks.	2023-12-29 14:23:58 +01:00
Iván Ovejero	4bad43dd66	refactor(core): Move typeorm operators from WaitTracker to ExecutionRepository (no-changelog) (#8163) ... Follow-up to: #8145 --------- Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>	2023-12-28 19:22:09 +01:00
Iván Ovejero	e418d42450	refactor(core): Move typeorm operators from various sources into repositories (no-changelog) (#8174) ... Follow-up to: #8165	2023-12-28 13:14:10 +01:00
कारतोफ्फेलस्क्रिप्ट™	c84d3c3bbf	refactor(core): Extract ActiveWebhooks out of ActiveWorkflowRunner (no-changelog) (#8171) ... ## Summary This PR continues refactoring webhooks code for better modularity. Continued from #8069 to bring back `ActiveWebhooks`, but this time actually handling active webhook calls in this class. ## Review / Merge checklist - [x] PR title and summary are descriptive	2023-12-28 10:04:32 +01:00
Iván Ovejero	639afcd7a5	refactor(core): Simplify state in test webhooks (no-changelog) (#8155) ... This PR simplifies state in test webhooks so that it can be cached easily. Caching this state will allow us to start using Redis for manual webhooks, to support manual webhooks to work in multi-main setup. - [x] Convert `workflowWebhooks` to a getter - no need to optimize for deactivation - [x] Remove array from value in `TestWebhooks.webhookUrls` - [x] Consolidate `webhookUrls` and `registeredWebhooks`	2023-12-28 09:28:12 +01:00
Iván Ovejero	0e582594ea	refactor(core): Move more typeorm operators to UserRepository (no-changelog) (#8165) ... Follow-up to: #8163	2023-12-28 09:27:47 +01:00
Iván Ovejero	5aee7a1d48	refactor(core): Move typeorm operators from SourceControlExportService to repositories (no-changelog) (#8168) ... Follow-up to: #8165	2023-12-28 09:27:38 +01:00
Jan Oberhauser	ea7e76fa3b	fix(core): Use pinned data only for manual mode (#8164) ... ## Summary Fixes the issue that pinned data gets also used for production executions. --------- Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>	2023-12-27 18:22:33 +01:00
Iván Ovejero	2c6ffb0153	fix(core): Minor improvements to multi-main setup (no-changelog) (#8012) ... - Move webhook, poller and trigger activation logs closer to activation event - Enrich response of `/debug/multi-main-setup` - Ensure workflow updates broadcast activation state changes only if state changed - Fix bug on workflow activation after leadership change - Ensure debug controller is not available in production --------- Co-authored-by: Omar Ajoue <krynble@gmail.com>	2023-12-27 16:55:01 +01:00
कारतोफ्फेलस्क्रिप्ट™	f69ddcd796	refactor(core): Use Dependency Injection for all Controller classes (no-changelog) (#8146) ... ## Review / Merge checklist - [x] PR title and summary are descriptive	2023-12-27 11:50:43 +01:00
Jan Oberhauser	fa8bd8b9eb	fix(core): Fix issue that pinnedData is not used with Test-Webhooks (#8123) ... ## Summary When a workflow gets started via a Test-Webhook the pinned data does get ignored and the nodes executed anyway. ## Related tickets and issues > Include links to **Linear ticket** or Github issue or Community forum post. Important in order to close *automatically* and provide context to reviewers. ## Review / Merge checklist - [x] PR title and summary are descriptive. **Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise.** ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md)) - [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created. - [X] Tests included. > A bug is not considered fixed, unless a test is added to prevent it from happening again. > A feature is not complete without tests. --------- Co-authored-by: Mutasem Aldmour <mutasem@n8n.io>	2023-12-27 10:51:53 +01:00
Iván Ovejero	7b26a7a621	refactor(core): Move typeorm operators from PruningService to ExecutionRepository (no-changelog) (#8145) ... Follow-up to https://github.com/n8n-io/n8n/pull/8143	2023-12-22 17:49:15 +01:00
Iván Ovejero	a59d78de18	refactor(core): Move more typeorm operators to repositories (no-changelog) (#8143) ... Follow-up to #8139	2023-12-22 16:20:30 +01:00
कारतोफ्फेलस्क्रिप्ट™	4007163651	refactor(core): Delete unused code, and fix typings in tests (no-changelog) (#8142)	2023-12-22 15:41:29 +01:00
कारतोफ्फेलस्क्रिप्ट™	baee47a276	refactor(core): Move all base URLs to UrlService (no-changelog) (#8141) ... This change kept coming up in #6713, #7773, and #8135. So this PR moves the existing code without actually changing anything, to help get rid of some of the circular dependencies. ## Review / Merge checklist - [x] PR title and summary are descriptive.	2023-12-22 15:19:50 +01:00
Iván Ovejero	c6dd935895	refactor(core): Move some typeorm operators to repositories (no-changelog) (#8139) ... Moving some persistence logic to repositories to reduce circular dependencies.	2023-12-22 13:35:23 +01:00
Tomi Turtiainen	3a881be6c2	feat(core): Unify application components shutdown (#8097) ... ## Summary Add `ShutdownService` and `OnShutdown` decorator for more unified way to shutdown different components. Use this new way in the following components: - HTTP(S) server - Pruning service - Push connection - License --------- Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>	2023-12-22 12:39:58 +02:00
कारतोफ्फेलस्क्रिप्ट™	c158ca2471	refactor(core): Upgrade more dependencies to remove axios 0.x (no-changelog) (#8105) ... Had to [fork localtunnel](https://github.com/n8n-io/localtunnel) to get the axios upgrade, since localtunnel doesn't seem to be actively maintained.	2023-12-22 11:39:20 +01:00
कारतोफ्फेलस्क्रिप्ट™	021add0f39	refactor(core): Move active workflows endpoints to a decorated controller class (no-changelog) (#8101) ... This is a continuation of migrating all rest endpoints to decorated controller classes	2023-12-22 11:28:42 +01:00
कारतोफ्फेलस्क्रिप्ट™	21788d9153	fix(core): Remove circular dependency in WorkflowService and ActiveWorkflowRunner (#8128) ... ## Summary A circular dependency between `WorkflowService` and `ActiveWorkflowRunner` is sometimes causing `this.activeWorkflowRunner` to be `undefined` in `WorkflowService`. Breaking this circular dependency should hopefully fix this issue. ## Related tickets and issues #8122 ## Review / Merge checklist - [x] PR title and summary are descriptive - [ ] Tests included	2023-12-21 17:37:08 +01:00
कारतोफ्फेलस्क्रिप्ट™	ffaa30ddc4	fix(core): Handle empty executions table in pruning in migrations (#8121) ... In case someone manually prunes their executions table before upgrading to 1.x, `MigrateIntegerKeysToString` should gracefully handle that, instead of crashing the application. ## Review / Merge checklist - [x] PR title and summary are descriptive	2023-12-21 14:52:42 +01:00
Iván Ovejero	9ac8825a67	refactor(core): Move error execution creation to execution service (no-changelog) (#8006) ... Continue breaking down legacy helpers. Note: `getUserById` is unused.	2023-12-21 14:15:46 +01:00
Iván Ovejero	d1b2affd2c	ci: Add lint rule no-dynamic-import-template (no-changelog) (#8089) ... Follow-up to: https://github.com/n8n-io/n8n/pull/8086 `tsc-alias` as of 1.8.7 is unable to resolve template strings in dynamic imports. Since the module name mapper in Jest is able to, this issue is hard to detect, hence the new lint rule `no-dynamic-import-template`. This is for now specific to `@/` in the `cli` package - we can generalize later if needed. Ideally we should contribute a fix upstream when we have more time. <img width="940" alt="Capture 2023-12-19 at 12 39 55@2x" src="https://github.com/n8n-io/n8n/assets/44588767/78d4a277-ccff-455c-8610-d1bba39d93f2">	2023-12-21 14:15:37 +01:00
कारतोफ्फेलस्क्रिप्ट™	01e9a79238	feat(core): Remove discontinued crypto-js (#8104) ... Since crypto-js was [discontinued](1da3dabf93), [we migrated all our backend encryption to native crypto](https://github.com/n8n-io/n8n/pull/7556). However I decided back then to not remove crypto-js just yet in expressions, as I wanted to use `SubtleCrypto`. Unfortunately for that to work, we'd need to make expressions async. So, to get rid of `crypto-js`, I propose this interim solution. ## Related tickets and issues N8N-7020 ## Review / Merge checklist - [x] PR title and summary are descriptive - [x] Tests included	2023-12-21 14:13:02 +01:00
github-actions[bot]	b67b5ae6b2	🚀 Release 1.22.0 (#8115) ... # [1.22.0](https://github.com/n8n-io/n8n/compare/n8n@1.21.0...n8n@1.22.0) (2023-12-21) ### Bug Fixes * **core:** Close db connection gracefully when exiting ([#8045](https://github.com/n8n-io/n8n/pull/8045)) ([e69707e](e69707efd4)) * **core:** Consider timeout in shutdown an error ([#8050](https://github.com/n8n-io/n8n/pull/8050)) ([4cae976](4cae976a3b)) * **core:** Do not display error when stopping jobless execution in queue mode ([#8007](https://github.com/n8n-io/n8n/pull/8007)) ([8e6b951](8e6b951a76)) * **core:** Fix shutdown if terminating before hooks are initialized ([#8047](https://github.com/n8n-io/n8n/pull/8047)) ([6ae2f5e](6ae2f5efea)) * **core:** Handle multiple termination signals correctly ([#8046](https://github.com/n8n-io/n8n/pull/8046)) ([67bd8ad](67bd8ad698)) * **core:** Initialize queue once in queue mode ([#8025](https://github.com/n8n-io/n8n/pull/8025)) ([53c0b49](53c0b49d15)) * **core:** Prevent axios from force setting a form-urlencoded content-type ([#8117](https://github.com/n8n-io/n8n/pull/8117)) ([bba9576](bba95761e2)) * **core:** Remove circular references before serializing executions in public API ([#8043](https://github.com/n8n-io/n8n/pull/8043)) ([989888d](989888d9bc)) * **core:** Restore workflow ID during execution creation ([#8031](https://github.com/n8n-io/n8n/pull/8031)) ([c5e6ba8](c5e6ba8cdd)) * **core:** Use relative imports for dynamic imports in SecurityAuditService ([#8086](https://github.com/n8n-io/n8n/pull/8086)) ([785bf99](785bf9974e)) * **core:** Stop binary data restoration from preventing execution from finishing ([#8082](https://github.com/n8n-io/n8n/pull/8082)) ([5ffff1b](5ffff1bb22)) * **editor:** Add back credential `use` permission ([#8023](https://github.com/n8n-io/n8n/pull/8023)) ([329e5bf](329e5bf9ee)) * **editor:** Cleanup Executions page component ([#8053](https://github.com/n8n-io/n8n/pull/8053)) ([2689c37](2689c37e87)) * **editor:** Disable auto scroll and list size check when clicking on executions ([#7983](https://github.com/n8n-io/n8n/pull/7983)) ([fcb8b91](fcb8b91f37)) * **editor:** Ensure execution data overrides pinned data when copying in executions view ([#8009](https://github.com/n8n-io/n8n/pull/8009)) ([1d1cb0d](1d1cb0d3c5)) * **editor:** Fix copy/paste issue when switch node is in workflow ([#8103](https://github.com/n8n-io/n8n/pull/8103)) ([4b86926](4b86926752)) * **editor:** Make keyboard shortcuts more strict; don't accept extra Ctrl/Alt/Shift keys ([#8024](https://github.com/n8n-io/n8n/pull/8024)) ([8df49e1](8df49e134d)) * **editor:** Show credential share info only to appropriate users ([#8020](https://github.com/n8n-io/n8n/pull/8020)) ([b29b4d4](b29b4d442b)) * **editor:** Turn off executions list auto-refresh after leaving the page ([#8005](https://github.com/n8n-io/n8n/pull/8005)) ([e3c363d](e3c363d72c)) * **editor:** Update image sizes in template description not to be full width always ([#8037](https://github.com/n8n-io/n8n/pull/8037)) ([63a6e7e](63a6e7e034)) * **ActiveCampaign Node:** Fix pagination issue when loading tags ([#8017](https://github.com/n8n-io/n8n/pull/8017)) ([1943857](1943857231)) * **HTTP Request Node:** Do not create circular references in HTTP request node output ([#8030](https://github.com/n8n-io/n8n/pull/8030)) ([5b7ea16](5b7ea16d9a)) * Upgrade axios to address CVE-2023-45857 ([#7713](https://github.com/n8n-io/n8n/pull/7713)) ([64eb9bb](64eb9bbc36)) ### Features * Add option to `returnIntermediateSteps` for AI agents ([#8113](https://github.com/n8n-io/n8n/pull/8113)) ([7806a65](7806a65229)) * **core:** Add config option to prefer GET request over LIST when using Hashicorp Vault ([#8049](https://github.com/n8n-io/n8n/pull/8049)) ([439a22d](439a22d68f)) * **core:** Add N8N_GRACEFUL_SHUTDOWN_TIMEOUT env var ([#8068](https://github.com/n8n-io/n8n/pull/8068)) ([614f488](614f488386)) * **editor:** Add lead enrichment suggestions to workflow list ([#8042](https://github.com/n8n-io/n8n/pull/8042)) ([36a923c](36a923cf7b)) * **editor:** Finalize workers view ([#8052](https://github.com/n8n-io/n8n/pull/8052)) ([edfa784](edfa78414d)) * **editor:** Gracefully ignore invalid payloads in postMessage handler ([#8096](https://github.com/n8n-io/n8n/pull/8096)) ([9d22c7a](9d22c7a278)) * **editor:** Upgrade frontend tooling to address a few vulnerabilities ([#8100](https://github.com/n8n-io/n8n/pull/8100)) ([19b7f1f](19b7f1ffb1)) * **Filter Node:** Overhaul UI by adding the new filter component ([#8016](https://github.com/n8n-io/n8n/pull/8016)) ([3d53052](3d530522f8)) * **Respond to Webhook Node:** Overhaul with improvements like returning all items ([#8093](https://github.com/n8n-io/n8n/pull/8093)) ([32d397e](32d397eff3)) ### Performance Improvements * **editor:** Improve canvas rendering performance ([#8022](https://github.com/n8n-io/n8n/pull/8022)) ([b780436](b780436a6b)) Co-authored-by: ivov <ivov@users.noreply.github.com>	2023-12-21 13:51:24 +01:00
Omar Ajoue	5ffff1bb22	fix: Stop binary data restoration from preventing execution from finishing (#8082) ... In the case of a filesystem failure to rename the binary files as part of the execution's cleanup process, the execution would fail to be saved and would never finish. This catch prevents it. ## Summary Whenever an execution is wrapping u to save the data, if it uses binary data n8n will try to find possibly misallocated files and place them in the right folder. If this process fails, the execution fails to finish. Given the execution has already finished at this point, and we cannot handle the binary data errors more gracefully, all we can do at this point is log the message as it's a filesystem issue. The rest of the execution saving process should remain as normal. ## Related tickets and issues https://linear.app/n8n/issue/HELP-430 ## Review / Merge checklist - [ ] PR title and summary are descriptive. **Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise.** ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md)) - [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created. - [ ] Tests included. > A bug is not considered fixed, unless a test is added to prevent it from happening again. > A feature is not complete without tests. --------- Co-authored-by: Iván Ovejero <ivov.src@gmail.com>	2023-12-21 09:40:39 +00:00
Iván Ovejero	edfa78414d	feat(editor): Finalize workers view (#8052) ... https://linear.app/n8n/issue/PAY-1065	2023-12-20 17:49:14 +01:00
Iván Ovejero	97aa38e783	ci: Fix Postgres and MySQL tests (no-changelog) (#8106) ... This role query works for sqlite but [fails for Postgres and MySQL](https://github.com/n8n-io/n8n/actions/runs/7269009778/job/19805986017), so generalize by adding alias and accounting for count possibly being `string` in the resulting rows. Run in progress: https://github.com/n8n-io/n8n/actions/runs/7275986797	2023-12-20 15:14:31 +01:00
कारतोफ्फेलस्क्रिप्ट™	81994ce13d	fix(core): Downgrade Rudderstack SDK (no-changelog) (#8107) ... This reverts commit a895ee87fc (#8090) Our telemetry backend is throwing 500s with the updated rudderstack sdk. Until that is resolved, we need to downgrade. ## Review / Merge checklist - [x] PR title and summary are descriptive	2023-12-20 11:59:44 +01:00
Iván Ovejero	9dc491c3a5	refactor(core): Improve test-webhooks (no-changelog) (#8069) ... Remove duplication, improve readability, and expand tests for `TestWebhooks.ts` - in anticipation for storing test webhooks in Redis. --------- Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>	2023-12-19 17:32:02 +01:00
Iván Ovejero	38d1336fa7	refactor: Add telemetry for RBAC (no-changelog) (#8056) ... https://linear.app/n8n/issue/PAY-1142	2023-12-19 17:02:52 +01:00
कारतोफ्फेलस्क्रिप्ट™	a895ee87fc	feat(core): Upgrade Rudderstack SDK (no-changelog) (#8090) ... This helps remove some of the older versions of transient dependencies, like axios 0.x and ioredis 4.x. ## Review / Merge checklist - [x] PR title and summary are descriptive.	2023-12-19 16:53:12 +01:00
कारतोफ्फेलस्क्रिप्ट™	64eb9bbc36	fix: Upgrade axios to address CVE-2023-45857 (#7713) ... [GH Advisory](https://github.com/advisories/GHSA-wf5p-g6vw-rhxx)	2023-12-19 16:17:01 +01:00
Iván Ovejero	8e6b951a76	fix(core): Do not display error when stopping jobless execution in queue mode (#8007) ... No need to surface error to user when stopping a job no longer in queue. https://linear.app/n8n/issue/PAY-1104	2023-12-19 16:11:21 +01:00
कारतोफ्फेलस्क्रिप्ट™	464b565283	ci: Remove unnecessary async/await, enable await-thenable linting rule (no-changelog) (#8076) ... ## Summary We accidentally made some functions `async` in https://github.com/n8n-io/n8n/pull/7846 This PR reverts that change. ## Review / Merge checklist - [x] PR title and summary are descriptive.	2023-12-19 13:52:42 +01:00
कारतोफ्फेलस्क्रिप्ट™	785bf9974e	fix(core): Use relative imports for dynamic imports in SecurityAuditService (#8086) ... `tsc-alias` doesn't seem to replace imports when using template strings ## Related tickets and issues #8085 ## Review / Merge checklist - [x] PR title and summary are descriptive.	2023-12-19 12:41:15 +01:00
कारतोफ्फेलस्क्रिप्ट™	a63d94f28c	refactor(core): Move license endpoints to a decorated controller class (no-changelog) (#8074)	2023-12-19 12:13:19 +01:00
Iván Ovejero	73d400a1bf	refactor(core): Inject dependencies into workflow services (no-changelog) (#8066) ... Inject dependencies into workflow services (no-changelog) Up next: - ~~Make workflow services injectable~~ #8033 - ~~Inject dependencies into workflow services~~ (current) - Consolidate workflow controllers into one - Make workflow controller injectable - Inject dependencies into workflow controller	2023-12-18 16:10:30 +01:00
कारतोफ्फेलस्क्रिप्ट™	a651089a10	refactor(core): Update backend sentry setup to reduce noise (no-changelog) (#8026) ... ## Summary This PR updates our backend sentry setup to remove integrations that don't provide us any value. This also reduces the amount of PII that gets sent to Sentry. [Sample event](https://n8nio.sentry.io/issues/4725315362/) ## Related tickets [ENG-95](https://linear.app/n8n/issue/ENG-95) ## Review / Merge checklist - [x] PR title and summary are descriptive.	2023-12-18 14:26:07 +01:00
Tomi Turtiainen	614f488386	feat(core): Add N8N_GRACEFUL_SHUTDOWN_TIMEOUT env var (#8068) ... Add generic N8N_GRACEFUL_SHUTDOWN_TIMEOUT which controls how long n8n process will wait for graceful exit before exitting forcefully. This variables replaces the QUEUE_WORKER_TIMEOUT variable that was used for worker process. DEPRECATED: QUEUE_WORKER_TIMEOUT deprected QUEUE_WORKER_TIMEOUT environment variable has been replaced with N8N_GRACEFUL_SHUTDOWN_TIMEOUT.	2023-12-18 14:04:19 +02:00
Tomi Turtiainen	4cae976a3b	fix(core): Consider timeout in shutdown an error (#8050) ... If the process doesn't shutdown within a time limit, exit with error code. 1. conceptually something timing out is an error. 2. on successful exit we close down the DB connection gracefully. On an exit timeout we rather not do that, since it will wait for any active connections to close and would possible block the exit.	2023-12-18 10:53:34 +02:00
Tomi Turtiainen	6ae2f5efea	fix(core): Fix shutdown if terminating before hooks are initialized (#8047) ... If the app receives termination signal before hooks have been initialised, the would be objet is undefined error. This PR fixes that.	2023-12-18 09:23:10 +02:00
Jon	439a22d68f	feat: Add config option to prefer GET request over LIST when using Hashicorp Vault (#8049) ... ## Summary Hashicorp Vault prefers a `LIST` HTTP method to be used when fetching secrets but not all environments will allow custom http methods through WAFs. This PR adds `N8N_EXTERNAL_SECRETS_PREFER_GET` which when set to `true` will use GET instead of LIST to fetch secrets. ## Review / Merge checklist - [x] PR title and summary are descriptive. **Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise.** ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md))	2023-12-15 16:20:39 +00:00
Tomi Turtiainen	67bd8ad698	fix(core): Handle multiple termination signals correctly (#8046) ... Prevent possible multiple termination signals initiating the shutdown process multiple times.	2023-12-15 17:35:22 +02:00
Tomi Turtiainen	e69707efd4	fix(core): Close db connection gracefully when exiting (#8045) ... Close db connection gracefully when exiting	2023-12-15 17:16:35 +02:00
Marcus	48d4f4a71b	fix(core): Public API support node's deprecated continueOnFail to upload old workflows (no-changelog) (#8044)	2023-12-15 16:11:53 +01:00
कारतोफ्फेलस्क्रिप्ट™	989888d9bc	fix(core): Remove circular references before serializing executions in public API (#8043) ... ## Summary Handle circular references in the public API for executions created prior to the fix from #8030 ## Related tickets [PAY-1119](https://linear.app/n8n/issue/PAY-1119) ## Review / Merge checklist - [x] PR title and summary are descriptive.	2023-12-15 16:01:41 +01:00
Iván Ovejero	1e7a309e63	refactor(core): Make workflow services injectable (no-changelog) (#8033) ... Refactor static workflow service classes into DI-compatible classes Context: https://n8nio.slack.com/archives/C069HS026UF/p1702466571648889 Up next: - Inject dependencies into workflow services - Consolidate workflow controllers into one - Make workflow controller injectable - Inject dependencies into workflow controller --------- Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>	2023-12-15 12:59:56 +01:00
Iván Ovejero	2da15d0264	refactor(core): Remove ID-less workflow reporting (no-changelog) (#8038) ... We added ID-less workflow reporting at #8031, which has already produced multiple reports coming from internal, enough info to tackle [this story](https://linear.app/n8n/issue/PAY-1147). To prevent an overwhelming number of reports from cloud, this PR removes the reporting for now.	2023-12-15 12:50:09 +01:00
Iván Ovejero	f18bc5f4b7	refactor(core): Warn on sqlite DB detected during init on queue mode (#8034) ... When setting up queue mode, it is easy to overlook that not exporting Postgres env vars will default the worker to use sqlite, which will fail during execution with a non-obvious error. Hence add warnings when starting a worker with an incompatible DB type.	2023-12-15 10:56:35 +01:00
Iván Ovejero	c5e6ba8cdd	fix(core): Restore workflow ID during execution creation (#8031) ... ## Summary Restore workflow ID during execution creation removed by [this PR](https://github.com/n8n-io/n8n/pull/8002/files#diff-c8cbb62ca9ab2ae45e5f565cd8c63fff6475809a6241ea0b90acc575615224af). The missing workflow ID, and more generally the fact that `workflow.id` is optional when it should not be, causes `PermissionChecker.check` to misreport a credential as inaccessible when it should be accessible. More generally, start reporting ID-less workflows so we can root them out and prevent this at type level. ## Related tickets and issues https://n8nio.slack.com/archives/C035KBDA917/p1702539465555529	2023-12-14 18:13:12 +01:00
Iván Ovejero	53c0b49d15	fix(core): Initialize queue once in queue mode (#8025) ... We're initializing the queue twice because of a [bad merge](2c63474538). No associated known bugs but no need to init the queue twice. We should follow up by investigating if any pending bugs can be associated to this.	2023-12-14 16:16:12 +01:00
github-actions[bot]	1516c84dad	🚀 Release 1.21.0 (#8019) ... # [1.21.0](https://github.com/n8n-io/n8n/compare/n8n@1.20.0...n8n@1.21.0) (2023-12-13) ### Bug Fixes * **core:** Ensure inviter and invitee are set correctly in invite link ([#7943](https://github.com/n8n-io/n8n/issues/7943)) ([386bd61](386bd61967)) * **core:** Fix user comparison in same-user subworkflow caller policy ([#7913](https://github.com/n8n-io/n8n/issues/7913)) ([92bab72](92bab72cff)) * **core:** Perform multi-main leader check against key ID ([#7964](https://github.com/n8n-io/n8n/issues/7964)) ([1a87f70](1a87f70e84)) * **core:** Ensure external hooks post workflow execute run in queue mode ([#7947](https://github.com/n8n-io/n8n/issues/7947)) ([3ba7deb](3ba7deb337)) * **core:** Fix issue preventing secrets from loading if the path contains - or / ([#7988](https://github.com/n8n-io/n8n/issues/7988)) ([0ac9594](0ac959463f)) * **core:** Restrict updating/deleting of shared but not owned credentials ([#7950](https://github.com/n8n-io/n8n/issues/7950)) ([42e828d](42e828d5c6)) * **core:** Prevent workflow history saving error from happening ([#7812](https://github.com/n8n-io/n8n/issues/7812)) ([e5581ce](e5581ce802)) * **editor:** Add missing string for worker in log streaming ([#7971](https://github.com/n8n-io/n8n/issues/7971)) ([148bc1d](148bc1d303)) * **editor:** Allow SSH protocol in git repository URL for environments ([#7944](https://github.com/n8n-io/n8n/issues/7944)) ([bc1c72f](bc1c72f992)) * **editor:** Fix bug with node names with certain characters ([#8013](https://github.com/n8n-io/n8n/issues/8013)) ([26f0d57](26f0d57f5f)) * **editor:** Fix Webhook URL expansion icon ([#8011](https://github.com/n8n-io/n8n/issues/8011)) ([b00b905](b00b9057a4)) * **editor:** Prevent opening NDV search if `/` is typed in a contenteditable element ([#7968](https://github.com/n8n-io/n8n/issues/7968)) ([e8a493f](e8a493f718)) * **editor:** Return early in ws message handler if no 'command' keyword is found ([#7946](https://github.com/n8n-io/n8n/issues/7946)) ([5b2defc](5b2defc867)) * **FileMaker Node:** Prevent erroring on zero fields loaded ([#7955](https://github.com/n8n-io/n8n/issues/7955)) ([10ad386](10ad386604)) * **Google Sheets Node:** Prevent erroring on zero sheet search results ([#7957](https://github.com/n8n-io/n8n/issues/7957)) ([9b877a9](9b877a9427)) * **Google Sheets Node:** Prevent erroring when fetching mapping columns ([#7972](https://github.com/n8n-io/n8n/issues/7972)) ([29a1066](29a10668d1)) * **Postgres Node:** Do not include id column in upsert fields selection if it's not unique ([#7975](https://github.com/n8n-io/n8n/issues/7975)) ([435392c](435392cbfe)) * **Postgres Trigger Node:** Increase manual trigger timeout from 30 to 60 seconds ([#8015](https://github.com/n8n-io/n8n/issues/8015)) ([09a5729](09a5729305)) * **Webhook Node:** Binary data handling ([#7804](https://github.com/n8n-io/n8n/issues/7804)) ([565b409](565b409a82)) * **Webhook Node:** Do not create binary data when there is no data in the request ([#8000](https://github.com/n8n-io/n8n/issues/8000)) ([70f0755](70f0755278)) ### Features * **core:** Add config option for external secret update interval ([#7995](https://github.com/n8n-io/n8n/issues/7995)) ([b6c1c04](b6c1c04b54)) * AI nodes usability fixes + Summarization Chain V2 ([#7949](https://github.com/n8n-io/n8n/issues/7949)) ([dcf1286](dcf12867b3)) * **editor:** Data transformation nodes and actions in Nodes Panel ([#7760](https://github.com/n8n-io/n8n/issues/7760)) ([675ec21](675ec21d33)) * **editor:** Add AppCues tracking for onboarding event ([#7945](https://github.com/n8n-io/n8n/issues/7945)) ([04cabaf](04cabafef7)) * **editor:** Add option to disable NDV in workflow previews ([#7990](https://github.com/n8n-io/n8n/issues/7990)) ([393afef](393afef174)) * **editor:** Filter component + implement in If node ([#7490](https://github.com/n8n-io/n8n/issues/7490)) ([8a53434](8a5343401d)) * **editor:** Show template credential setup based on feature flag ([#7989](https://github.com/n8n-io/n8n/issues/7989)) ([08ee307](08ee307209)) * **editor:** Introduce advanced permissions ([#7844](https://github.com/n8n-io/n8n/issues/7844)) ([dbd62a4](dbd62a4992)) * **Google Ads Node:** Update to support v15 ([#7962](https://github.com/n8n-io/n8n/issues/7962)) ([7f01269](7f0126915a)) * **Local File Trigger Node:** Add polling option typically good to watch network files/folders ([#7942](https://github.com/n8n-io/n8n/issues/7942)) ([2fbdfec](2fbdfec0c0)) * **n8n Form Trigger Node:** Improvements ([#7571](https://github.com/n8n-io/n8n/issues/7571)) ([953a58f](953a58f18b)) Co-authored-by: ivov <ivov@users.noreply.github.com>	2023-12-13 16:34:00 +01:00
कारतोफ्फेलस्क्रिप्ट™	d7ce4624c8	Merge tag 'n8n@1.20.0'	2023-12-13 16:11:30 +01:00
Michael Kret	953a58f18b	feat(n8n Form Trigger Node): Improvements (#7571) ... Github issue / Community forum post (link here to close automatically): --------- Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in> Co-authored-by: Giulio Andreini <andreini@netseven.it>	2023-12-13 17:00:51 +02:00
Omar Ajoue	e5581ce802	fix(core): Prevent workflow history saving error from happening (#7812) ... When performing actions such as renaming a workflow or updating its settings, n8n errors with "Failed to save workflow version" in the console although the saving process was successful. We are now correctly checking whether `nodes` and `connections` exist and only then save a snapshot. Github issue / Community forum post (link here to close automatically):	2023-12-13 11:41:06 +00:00
Iván Ovejero	a70a5076ee	refactor(core): Add telemetry for RBAC roles (#7969) ... Add telemetry for RBAC roles, see [requirements](https://linear.app/n8n/issue/PAY-1067/add-telemetry-events-for-adding-and-assigning-admin-users#comment-184619fe).	2023-12-13 12:22:11 +01:00
Iván Ovejero	7b5d0a9546	refactor(core): Introduce import service (no-changelog) (#8001) ... Consolidate import logic into import service. Also fixes: - https://linear.app/n8n/issue/PAY-1086 - https://github.com/n8n-io/n8n/issues/7881 - https://community.n8n.io/t/cli-workflow-imports-failing-after-upgrade-to-v1-18-0/33780 - https://linear.app/n8n/issue/PAY-221 - https://github.com/n8n-io/n8n/issues/5477 - https://community.n8n.io/t/export-workflows-with-tags-got-created/6161	2023-12-13 10:00:21 +01:00
Benjamin Loison	61129863f1	docs: Replace http://faircode.io to https://faircode.io in .md files (#7908) ... ## Summary Commit generated with: ```bash grep -rl 'http://faircode.io' --include=*.md . | xargs sed -i 's/http:\/\/faircode.io/https:\/\/faircode.io/g' ``` ## Review / Merge checklist - [X] PR title and summary are descriptive. **Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise.** ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md)) - [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created. - [ ] Tests included.	2023-12-12 15:23:22 +00:00
Jon	0ac959463f	fix: Fix issue preventing secrets from loading if the path contains - or / (#7988) ... ## Summary Fixes an issue preventing n8n from pulling secrets from Hashicorp Vault KV stores if the secret path contained a `-` or a `/`, An example provided was `integrations/n8n-workflows` which I have tested in my local instance of Vault. This still needs testing with Infisical to make sure nothing breaks there.	2023-12-12 15:21:18 +00:00
Jon	b6c1c04b54	feat: Add config option for external secret update interval (#7995) ... ## Summary Adds `N8N_EXTERNAL_SECRETS_UPDATE_INTERVAL` to allow enterprise users to tweak the update internal for importing new secrets. If using a config file the value is: ``` "externalSecrets": { "updateInterval": 300 } ``` #### How to test the change: 1. Run as normal and check that the secret is updated every 5 minutes 2. Set `N8N_EXTERNAL_SECRETS_UPDATE_INTERVAL` to 10 3. Check the secret is reloaded after 10 seconds ## Review / Merge checklist - [x] PR title and summary are descriptive. **Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise.** ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md)) - [x] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created.	2023-12-12 14:22:14 +00:00
Iván Ovejero	d0e44d450f	feat(core): Add multi-main setup debug endpoint (no-changelog) (#7991) ... ## Summary Provide details about your pull request and what it adds, fixes, or changes. Photos and videos are recommended. Adi's idea here to help diagnose: https://n8nio.slack.com/archives/C069KJBJ8HE/p1702300349277609?thread_ts=1702299930.728029&cid=C069KJBJ8HE ... #### How to test the change: 1. ... ## Issues fixed Include links to Github issue or Community forum post or **Linear ticket**: > Important in order to close automatically and provide context to reviewers ... ## Review / Merge checklist - [ ] PR title and summary are descriptive. **Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise.** ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md)) - [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created. - [ ] Tests included. > A bug is not considered fixed, unless a test is added to prevent it from happening again. A feature is not complete without tests. > > *(internal)* You can use Slack commands to trigger [e2e tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227) or [deploy test instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce) or [deploy early access version on Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).	2023-12-12 15:18:32 +01:00
कारतोफ्फेलस्क्रिप्ट™	1d870412ca	refactor(core): Don't use DB transactions on ExecutionRepository.createNewExecution (#8002) ... Saving execution data is one of the slowest DB operations in the application, and is likely behind some of the sqlite transaction concurrency issues we've been seeing. This not only remove the 2 separate transactions for saving `ExecutionEntity` and `ExecutionData`, but also remove fields from `ExecutionData.workflowData` that don't need to be saved (like `tags`, `shared`, `statistics`, `triggerCount`, etc).	2023-12-12 14:36:56 +01:00
Iván Ovejero	c378f60a25	refactor(core): Introduce password utility (no-changelog) (#7979) ... ## Summary Provide details about your pull request and what it adds, fixes, or changes. Photos and videos are recommended. Continue breaking down `UserManagementHelper.ts` ... #### How to test the change: 1. ... ## Issues fixed Include links to Github issue or Community forum post or **Linear ticket**: > Important in order to close automatically and provide context to reviewers ... ## Review / Merge checklist - [ ] PR title and summary are descriptive. **Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise.** ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md)) - [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created. - [ ] Tests included. > A bug is not considered fixed, unless a test is added to prevent it from happening again. A feature is not complete without tests. > > *(internal)* You can use Slack commands to trigger [e2e tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227) or [deploy test instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce) or [deploy early access version on Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).	2023-12-11 18:23:42 +01:00
Iván Ovejero	bbeeab5d27	refactor(core): Add project reference for @n8n/permissions (no-changelog) (#7987) ... ## Summary Provide details about your pull request and what it adds, fixes, or changes. Photos and videos are recommended. The missing [project ref](https://www.typescriptlang.org/docs/handbook/project-references.html) seems to be preventing the package from being picked up. <img width="1022" alt="Capture 2023-12-11 at 13 49 55@2x" src="https://github.com/n8n-io/n8n/assets/44588767/28b35430-d42f-451c-ae33-d152e1ff040a"> ... #### How to test the change: 1. ... ## Issues fixed Include links to Github issue or Community forum post or **Linear ticket**: > Important in order to close automatically and provide context to reviewers ... ## Review / Merge checklist - [ ] PR title and summary are descriptive. **Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise.** ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md)) - [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created. - [ ] Tests included. > A bug is not considered fixed, unless a test is added to prevent it from happening again. A feature is not complete without tests. > > *(internal)* You can use Slack commands to trigger [e2e tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227) or [deploy test instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce) or [deploy early access version on Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).	2023-12-11 14:37:21 +01:00
Iván Ovejero	f49aebb740	refactor(core): Move instance owner retrieval to ownership service (no-changelog) (#7980) ... ## Summary Provide details about your pull request and what it adds, fixes, or changes. Photos and videos are recommended. Continue breaking down `UserManagementHelper.ts` ... #### How to test the change: 1. ... ## Issues fixed Include links to Github issue or Community forum post or **Linear ticket**: > Important in order to close automatically and provide context to reviewers ... ## Review / Merge checklist - [ ] PR title and summary are descriptive. **Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise.** ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md)) - [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created. - [ ] Tests included. > A bug is not considered fixed, unless a test is added to prevent it from happening again. A feature is not complete without tests. > > *(internal)* You can use Slack commands to trigger [e2e tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227) or [deploy test instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce) or [deploy early access version on Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).	2023-12-11 13:35:09 +01:00
Iván Ovejero	69c2254742	refactor(core): Introduce naming service (no-changelog) (#7985) ... ## Summary Provide details about your pull request and what it adds, fixes, or changes. Photos and videos are recommended. Continue breaking down `GenericHelpers.ts` ... #### How to test the change: 1. ... ## Issues fixed Include links to Github issue or Community forum post or **Linear ticket**: > Important in order to close automatically and provide context to reviewers ... ## Review / Merge checklist - [ ] PR title and summary are descriptive. **Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise.** ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md)) - [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created. - [ ] Tests included. > A bug is not considered fixed, unless a test is added to prevent it from happening again. A feature is not complete without tests. > > *(internal)* You can use Slack commands to trigger [e2e tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227) or [deploy test instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce) or [deploy early access version on Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).	2023-12-11 12:35:14 +01:00
Iván Ovejero	012310b9c1	refactor(core): Upgrade backend Sentry dependencies to 7.86 (no-changelog) (#7982) ... ## Summary Provide details about your pull request and what it adds, fixes, or changes. Photos and videos are recommended. ... #### How to test the change: 1. ... ## Issues fixed Include links to Github issue or Community forum post or **Linear ticket**: > Important in order to close automatically and provide context to reviewers ... ## Review / Merge checklist - [ ] PR title and summary are descriptive. **Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise.** ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md)) - [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created. - [ ] Tests included. > A bug is not considered fixed, unless a test is added to prevent it from happening again. A feature is not complete without tests. > > *(internal)* You can use Slack commands to trigger [e2e tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227) or [deploy test instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce) or [deploy early access version on Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).	2023-12-11 11:08:54 +01:00
Iván Ovejero	193fe5ac1f	refactor(core): Log any hard-deletion errors during pruning (no-changelog) (#7965) ... ## Summary Pruning is a minor background task so hard-deletion errors during pruning should be simply logged for later investigation rather than rethrown. ... #### How to test the change: 1. ... ## Issues fixed Include links to Github issue or Community forum post or **Linear ticket**: > Important in order to close automatically and provide context to reviewers ... ## Review / Merge checklist - [ ] PR title and summary are descriptive. **Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise.** ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md)) - [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created. - [ ] Tests included. > A bug is not considered fixed, unless a test is added to prevent it from happening again. A feature is not complete without tests. > > *(internal)* You can use Slack commands to trigger [e2e tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227) or [deploy test instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce) or [deploy early access version on Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).	2023-12-11 11:08:14 +01:00
Iván Ovejero	76ab411bc0	refactor(core): Instrument multi-main to report failures to renew lease (#7970) ... ## Summary Instrument multi-main to report failures to renew the lease https://linear.app/n8n/issue/PAY-1105 ... #### How to test the change: 1. ... ## Issues fixed Include links to Github issue or Community forum post or **Linear ticket**: > Important in order to close automatically and provide context to reviewers ... ## Review / Merge checklist - [ ] PR title and summary are descriptive. **Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise.** ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md)) - [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created. - [ ] Tests included. > A bug is not considered fixed, unless a test is added to prevent it from happening again. A feature is not complete without tests. > > *(internal)* You can use Slack commands to trigger [e2e tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227) or [deploy test instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce) or [deploy early access version on Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).	2023-12-11 09:45:08 +01:00
Iván Ovejero	1a87f70e84	fix(core): Perform multi-main leader check against key ID (#7964) ... ## Summary Current leader check is based on key presence and multi-main instance type, which can give rise to [this edge case](https://n8nio.slack.com/archives/C04B1GZ4T0U/p1702025497086379?thread_ts=1701962808.817579&cid=C04B1GZ4T0U) where leader fails to realize they lost leadership to a former follower. PR performs the check against the specific key ID instead to prevent this. ... #### How to test the change: 1. ... ## Issues fixed Include links to Github issue or Community forum post or **Linear ticket**: > Important in order to close automatically and provide context to reviewers ... ## Review / Merge checklist - [ ] PR title and summary are descriptive. **Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise.** ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md)) - [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created. - [ ] Tests included. > A bug is not considered fixed, unless a test is added to prevent it from happening again. A feature is not complete without tests. > > *(internal)* You can use Slack commands to trigger [e2e tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227) or [deploy test instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce) or [deploy early access version on Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).	2023-12-08 13:55:55 +01:00
Csaba Tuncsik	dbd62a4992	feat: Introduce advanced permissions (#7844) ... This PR introduces the possibility of inviting new users with an `admin` role and changing the role of already invited users. Also using scoped permission checks where applicable instead of using user role checks. --------- Co-authored-by: Val <68596159+valya@users.noreply.github.com> Co-authored-by: Alex Grozav <alex@grozav.com> Co-authored-by: Iván Ovejero <ivov.src@gmail.com>	2023-12-08 12:52:25 +01:00
Iván Ovejero	8cb9c6b3ea	ci: Introduce no-plain-errors lint rule for BE packages (no-changelog) (#7961) ... ## Summary Require `ApplicationError` or its child classes instead of plain `Error` in BE packages. This ensures the error will be normalized when reported to Sentry, if applicable. Follow-up to: https://github.com/n8n-io/n8n/pulls?q=is%3Apr+is%3Aclosed+applicationerror ... #### How to test the change: 1. ... ## Issues fixed Include links to Github issue or Community forum post or **Linear ticket**: > Important in order to close automatically and provide context to reviewers ... ## Review / Merge checklist - [ ] PR title and summary are descriptive. **Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise.** ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md)) - [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created. - [ ] Tests included. > A bug is not considered fixed, unless a test is added to prevent it from happening again. A feature is not complete without tests. > > *(internal)* You can use Slack commands to trigger [e2e tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227) or [deploy test instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce) or [deploy early access version on Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).	2023-12-08 12:51:49 +01:00
Iván Ovejero	90824b50ed	feat(core): Add package name tag to Sentry errors (no-changelog) (#7958) ... ## Summary Add `packageName` tag to errors reported to Sentry, for filtering ... #### How to test the change: 1. ... ## Issues fixed Include links to Github issue or Community forum post or **Linear ticket**: > Important in order to close automatically and provide context to reviewers ... ## Review / Merge checklist - [ ] PR title and summary are descriptive. **Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise.** ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md)) - [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created. - [ ] Tests included. > A bug is not considered fixed, unless a test is added to prevent it from happening again. A feature is not complete without tests. > > *(internal)* You can use Slack commands to trigger [e2e tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227) or [deploy test instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce) or [deploy early access version on Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).	2023-12-08 11:30:06 +01:00
Iván Ovejero	3206b44974	test(core): Improve tests for subworkflow caller policy checks (no-changelog) (#7954) ... ## Summary Deduplicate, separate, organize and speed up tests for subworkflow caller policy checks. Follow-up to: https://github.com/n8n-io/n8n/pull/7913 ``` PASS test/unit/PermissionChecker.test.ts check() ✓ should allow if workflow has no creds (3 ms) ✓ should allow if requesting user is instance owner (83 ms) ✓ should allow if workflow creds are valid subset (151 ms) ✓ should deny if workflow creds are not valid subset (85 ms) checkSubworkflowExecutePolicy() no caller policy ✓ should fall back to N8N_WORKFLOW_CALLER_POLICY_DEFAULT_OPTION (1 ms) overridden caller policy ✓ if no sharing, policy becomes workflows-from-same-owner (1 ms) workflows-from-list caller policy ✓ should allow if caller list contains parent workflow ID ✓ should deny if caller list does not contain parent workflow ID (1 ms) any caller policy ✓ should not throw workflows-from-same-owner caller policy ✓ should deny if the two workflows are owned by different users (1 ms) ✓ should allow if both workflows are owned by the same user ``` ... #### How to test the change: 1. ... ## Issues fixed Include links to Github issue or Community forum post or **Linear ticket**: > Important in order to close automatically and provide context to reviewers ... ## Review / Merge checklist - [ ] PR title and summary are descriptive. **Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise.** ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md)) - [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created. - [ ] Tests included. > A bug is not considered fixed, unless a test is added to prevent it from happening again. A feature is not complete without tests. > > *(internal)* You can use Slack commands to trigger [e2e tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227) or [deploy test instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce) or [deploy early access version on Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).	2023-12-08 11:21:43 +01:00
Iván Ovejero	c48850d74f	fix(core): Fix expression evaluator filename typo (no-changelog) (#7960) ... ## Summary Provide details about your pull request and what it adds, fixes, or changes. Photos and videos are recommended. ... #### How to test the change: 1. ... ## Issues fixed Include links to Github issue or Community forum post or **Linear ticket**: > Important in order to close automatically and provide context to reviewers ... ## Review / Merge checklist - [ ] PR title and summary are descriptive. **Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise.** ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md)) - [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created. - [ ] Tests included. > A bug is not considered fixed, unless a test is added to prevent it from happening again. A feature is not complete without tests. > > *(internal)* You can use Slack commands to trigger [e2e tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227) or [deploy test instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce) or [deploy early access version on Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).	2023-12-07 17:50:49 +01:00
Iván Ovejero	18bb87ac0c	test(core): Isolate restore binary data ID in execution lifecycle hooks (no-changelog) (#7953) ... ## Summary Move guard into restore function, move tests into own suite, add tests for guard. ... #### How to test the change: 1. ... ## Issues fixed Include links to Github issue or Community forum post or **Linear ticket**: > Important in order to close automatically and provide context to reviewers ... ## Review / Merge checklist - [ ] PR title and summary are descriptive. **Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise.** ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md)) - [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created. - [ ] Tests included. > A bug is not considered fixed, unless a test is added to prevent it from happening again. A feature is not complete without tests. > > *(internal)* You can use Slack commands to trigger [e2e tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227) or [deploy test instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce) or [deploy early access version on Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).	2023-12-07 17:30:47 +01:00
Iván Ovejero	1d46983b24	refactor: Unify severity and level for all application errors for Sentry (no-changelog) (#7956) ... ## Summary Unify `severity` and `level` for all backend application errors for Sentry Follow-up to: https://github.com/n8n-io/n8n/pull/7914#issuecomment-1840433542 ... #### How to test the change: 1. ... ## Issues fixed Include links to Github issue or Community forum post or **Linear ticket**: > Important in order to close automatically and provide context to reviewers ... ## Review / Merge checklist - [ ] PR title and summary are descriptive. **Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise.** ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md)) - [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created. - [ ] Tests included. > A bug is not considered fixed, unless a test is added to prevent it from happening again. A feature is not complete without tests. > > *(internal)* You can use Slack commands to trigger [e2e tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227) or [deploy test instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce) or [deploy early access version on Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).	2023-12-07 16:57:02 +01:00
Val	42e828d5c6	fix: Restrict updating/deleting of shared but not owned credentials (#7950) ... ## Summary Fix shared members being able to edit and delete credentials they don't own #### How to test the change: 1. ... ## Issues fixed Include links to Github issue or Community forum post or **Linear ticket**: > Important in order to close automatically and provide context to reviewers ... ## Review / Merge checklist - [x] PR title and summary are descriptive. **Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise.** ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md)) - [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created. - [x] Tests included. > A bug is not considered fixed, unless a test is added to prevent it from happening again. A feature is not complete without tests. > > *(internal)* You can use Slack commands to trigger [e2e tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227) or [deploy test instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce) or [deploy early access version on Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).	2023-12-07 10:35:40 +00:00
Omar Ajoue	3ba7deb337	fix: Ensure external hooks post workflow execute run in queue mode (#7947) ... ## Summary Since 1.8.x a refactor removed the call to `workflow.postExecute`'s External hook from the execution path. This PR adds it back to the correct place, where workers are supposed to call this, allowing us to avoid having to re-read the execution data in the caller just for the hooks. It is important to have the hooks running in the worker whenever possible to prevent having to read the full execution data in the caller. #### How to test the change: 1. Use the attached hooks file [external-hooks.txt](https://github.com/n8n-io/n8n/files/13597270/external-hooks.txt) setting it up via environment variable using `export EXTERNAL_HOOK_FILES=/path/to/hooks/external-hooks.js` 2. Set up queue mode loading this file in both main and workers 3. See that the message logs will not be displayed without this fix ## Issues fixed Include links to Github issue or Community forum post or **Linear ticket**: ## Review / Merge checklist - [ ] PR title and summary are descriptive. **Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise.** ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md)) - [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created. - [ ] Tests included. > A bug is not considered fixed, unless a test is added to prevent it from happening again. A feature is not complete without tests. > > *(internal)* You can use Slack commands to trigger [e2e tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227) or [deploy test instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce) or [deploy early access version on Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).	2023-12-07 10:00:05 +00:00
Iván Ovejero	386bd61967	fix(core): Ensure inviter and invitee are set correctly in invite link (#7943) ... ## Summary Ensure inviter and invitee are set correctly in invite link ... #### How to test the change: 1. ... ## Issues fixed Include links to Github issue or Community forum post or **Linear ticket**: > Important in order to close automatically and provide context to reviewers https://linear.app/n8n/issue/ADO-1494 ## Review / Merge checklist - [ ] PR title and summary are descriptive. **Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise.** ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md)) - [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created. - [ ] Tests included. > A bug is not considered fixed, unless a test is added to prevent it from happening again. A feature is not complete without tests. > > *(internal)* You can use Slack commands to trigger [e2e tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227) or [deploy test instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce) or [deploy early access version on Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).	2023-12-07 10:53:31 +01:00
Iván Ovejero	3a035cba8b	test(core): Expand user service tests (no-changelog) (#7941) ... ## Summary Expand user service tests ... #### How to test the change: 1. ... ## Issues fixed Include links to Github issue or Community forum post or **Linear ticket**: > Important in order to close automatically and provide context to reviewers ... ## Review / Merge checklist - [ ] PR title and summary are descriptive. **Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise.** ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md)) - [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created. - [ ] Tests included. > A bug is not considered fixed, unless a test is added to prevent it from happening again. A feature is not complete without tests. > > *(internal)* You can use Slack commands to trigger [e2e tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227) or [deploy test instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce) or [deploy early access version on Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).	2023-12-07 09:19:16 +01:00
Michael Kret	565b409a82	fix(Webhook Node): Binary data handling (#7804) ... Github issue / Community forum post (link here to close automatically):	2023-12-06 17:46:40 +02:00
Csaba Tuncsik	c461025f70	test: Add user type of admin to E2E tests (#7935) ... ## Summary Extend existing user types in the E2E database. Currently, we have only owner and member but we need also admin --------- Co-authored-by: Val <68596159+valya@users.noreply.github.com>	2023-12-06 14:31:06 +01:00
Iván Ovejero	92bab72cff	fix(core): Fix user comparison in same-user subworkflow caller policy (#7913) ... https://linear.app/n8n/issue/PAY-992 https://community.n8n.io/t/executing-workflow-using-owner-role-created-by-another-user-fails/33443 --------- Co-authored-by: Omar Ajoue <krynble@gmail.com>	2023-12-06 12:27:11 +00:00
github-actions[bot]	823b589e09	🚀 Release 1.20.0 (#7940) ... # [1.20.0](https://github.com/n8n-io/n8n/compare/n8n@1.19.0...n8n@1.20.0) (2023-12-06) ### Bug Fixes * **AWS DynamoDB Node:** Improve error message parsing ([#7793](https://github.com/n8n-io/n8n/issues/7793)) ([5ba5ed8](5ba5ed8e3c)) * **core:** Allow grace period for binary data deletion after manual execution ([#7889](https://github.com/n8n-io/n8n/issues/7889)) ([61d8aeb](61d8aebeaf)) * **core:** Consolidate ownership and sharing data on workflows and credentials ([#7920](https://github.com/n8n-io/n8n/issues/7920)) ([38b88b9](38b88b946b)) * **core:** Fix hard deletes stopping if database query throws ([#7848](https://github.com/n8n-io/n8n/issues/7848)) ([46dd4d3](46dd4d3105)) * **core:** Make sure mfa secret and recovery codes are not returned on login ([#7936](https://github.com/n8n-io/n8n/issues/7936)) ([f5502cc](f5502cc628)) * **editor:** Fix deletion of last execution at execution preview ([#7883](https://github.com/n8n-io/n8n/issues/7883)) ([ce2d388](ce2d388f05)) * **editor:** Replace isInstanceOwner checks with scopes where applicable ([#7858](https://github.com/n8n-io/n8n/issues/7858)) ([132d691](132d691cbf)) * **Google Sheets Node:** Fix issue with paired items not being set correctly ([#7862](https://github.com/n8n-io/n8n/issues/7862)) ([5207a2f](5207a2fe52)) * **Notion Node:** Fix broken Notion node parameters ([#7864](https://github.com/n8n-io/n8n/issues/7864)) ([51d1f5b](51d1f5b820)), closes [#7791](https://github.com/n8n-io/n8n/issues/7791) ### Features * **BambooHR Node:** Add support for Only Current on company reports ([#7878](https://github.com/n8n-io/n8n/issues/7878)) ([4175801](4175801c90)) * **core:** Allow admin creation ([#7837](https://github.com/n8n-io/n8n/issues/7837)) ([476806e](476806ebb0)) * **editor:** Add sections to create node panel ([#7831](https://github.com/n8n-io/n8n/issues/7831)) ([39fa8d2](39fa8d21bb)) * **editor:** Open template credential setup from collection ([#7882](https://github.com/n8n-io/n8n/issues/7882)) ([627ddb9](627ddb91fb)) * **editor:** Select credentials in template setup if theres only one ([#7879](https://github.com/n8n-io/n8n/issues/7879)) ([fe3417a](fe3417a615)) ### Performance Improvements * **editor:** Improve node rendering performance when opening large workflows ([#7904](https://github.com/n8n-io/n8n/issues/7904)) ([a8049a0](a8049a0def)) * **editor:** Improve performance when opening large workflows with node issues ([#7901](https://github.com/n8n-io/n8n/issues/7901)) ([4bd7ae2](4bd7ae29f7)) Co-authored-by: ivov <ivov@users.noreply.github.com>	2023-12-06 12:26:24 +01:00
Ricardo Espinoza	f5502cc628	fix(core): Make sure mfa secret and recovery codes are not returned on login (#7936) ... ## Summary What: Fix issue of login endpoint returning secret and recovery codes when MFA is enabled. Bug was introduced in this [PR](https://github.com/n8n-io/n8n/pull/6994), specifically in this [line](https://github.com/n8n-io/n8n/pull/6994/files#diff-95a87cb029a3d26e6722df2e68132453fc254fc1f4540cbdaa95cfdbda1893deL91). Why: We should not be filtering the secret and recovery codes Same PR caused the issues on ticket -> https://linear.app/n8n/issue/ADO-1494/on-user-list-copy-password-reset-link-and-copy-invite-link-are-broken ## Review / Merge checklist - [x] PR title and summary are descriptive. **Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise.** ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md)) - [x] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created. - [x] Tests included. > A bug is not considered fixed, unless a test is added to prevent it from happening again. A feature is not complete without tests. > > *(internal)* You can use Slack commands to trigger [e2e tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227) or [deploy test instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce) or [deploy early access version on Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).	2023-12-06 10:00:13 +01:00
Andrey Starostin	46dd4d3105	fix(core): Fix hard deletes stopping if database query throws (#7848) ... I have observed that the next hard deletion timeout is not scheduled if the `hardDeleteOnPruningCycle` function throws when fetching the data from the database. That is because the thrown error is not caught and the `scheduleHardDeletion` method is not called. This PR moves the call to `scheduleHardDeletion` into the `scheduleHardDeletion` for better cohesion, and ensures that it is called even if `hardDeleteOnPruningCycle` throws.	2023-12-05 16:30:32 +01:00
Val	4e55583715	feat: Add admin role to public API (no-changelog) (#7933) ... ## Summary Add the admin global role to the public API. This does not include porting over scopes. #### How to test the change: 1. ... ## Issues fixed Include links to Github issue or Community forum post or **Linear ticket**: > Important in order to close automatically and provide context to reviewers ... ## Review / Merge checklist - [ ] PR title and summary are descriptive. **Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise.** ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md)) - [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created. - [ ] Tests included. > A bug is not considered fixed, unless a test is added to prevent it from happening again. A feature is not complete without tests. > > *(internal)* You can use Slack commands to trigger [e2e tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227) or [deploy test instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce) or [deploy early access version on Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).	2023-12-05 15:00:14 +00:00
Val	9604b87da9	fix: Return scopes on invitation accept endpoint (no-changelog) (#7917) ... ## Summary Return scopes on the invitation accept endpoint. The UI uses information until the user refreshes the pages so it's causing inconsistency for the new admin role. #### How to test the change: 1. ... ## Issues fixed Include links to Github issue or Community forum post or **Linear ticket**: > Important in order to close automatically and provide context to reviewers ... ## Review / Merge checklist - [x] PR title and summary are descriptive. **Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise.** ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md)) - [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created. - [ ] Tests included. > A bug is not considered fixed, unless a test is added to prevent it from happening again. A feature is not complete without tests. > > *(internal)* You can use Slack commands to trigger [e2e tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227) or [deploy test instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce) or [deploy early access version on Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).	2023-12-05 11:18:41 +01:00
Iván Ovejero	38b88b946b	fix(core): Consolidate ownership and sharing data on workflows and credentials (#7920) ... ## Summary Ensure `ownedBy` and `sharedWith` are present and uniform for credentials and workflows. Details in story: https://linear.app/n8n/issue/PAY-987	2023-12-05 10:11:18 +01:00
Iván Ovejero	29e7a98f3e	test(core): Use license mocker in RBAC tests (no-changelog) (#7912) ... ## Summary Provide details about your pull request and what it adds, fixes, or changes. Photos and videos are recommended. ... #### How to test the change: 1. ... ## Issues fixed Include links to Github issue or Community forum post or **Linear ticket**: > Important in order to close automatically and provide context to reviewers ... ## Review / Merge checklist - [ ] PR title and summary are descriptive. **Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise.** ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md)) - [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created. - [ ] Tests included. > A bug is not considered fixed, unless a test is added to prevent it from happening again. A feature is not complete without tests. > > *(internal)* You can use Slack commands to trigger [e2e tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227) or [deploy test instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce) or [deploy early access version on Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).	2023-12-04 13:56:48 +01:00
Iván Ovejero	50a7401de9	docs: Update breaking changes with binary data TTL note (#7894) ... Context: https://n8nio.slack.com/archives/C035KBDA917/p1701418556761549?thread_ts=1701411854.517989&cid=C035KBDA917	2023-12-01 12:52:12 +01:00
Iván Ovejero	07f6662aba	refactor(core): Add log about removed TTL keys for binary data (#7892) ... Context: https://n8nio.slack.com/archives/C035KBDA917/p1701418556761549?thread_ts=1701411854.517989&cid=C035KBDA917	2023-12-01 12:51:45 +01:00