Commit graph

10117 commits

Author SHA1 Message Date
कारतोफ्फेलस्क्रिप्ट™ 96fd2c51bd
fix(core): Show webhook urls for all webhook nodes (no-changelog) (#7783)
This reverts parts of https://github.com/n8n-io/n8n/pull/7113
2023-11-22 17:45:26 +01:00
Csaba Tuncsik 50f568560f
perf: Make frontend linting faster (no-changelog) (#7717)
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-11-22 15:01:22 +01:00
github-actions[bot] e01617ad64
🚀 Release 1.18.0 (#7780)
#
[1.18.0](https://github.com/n8n-io/n8n/compare/n8n@1.17.0...n8n@1.18.0)
(2023-11-22)


### Bug Fixes

* **core:** Account for non-ASCII chars in filename on binary data
download ([#7742](https://github.com/n8n-io/n8n/issues/7742))
([b4ebb1a](b4ebb1a28d))
* **core:** Correct permissions for getstatus
([#7724](https://github.com/n8n-io/n8n/issues/7724))
([f96c1d2](f96c1d2044))
* **core:** Ensure failed executions are saved in queue mode
([#7744](https://github.com/n8n-io/n8n/issues/7744))
([b7c5c74](b7c5c7406f))
* **core:** Guard against node not found on cancelling test webhook
([#7750](https://github.com/n8n-io/n8n/issues/7750))
([6be453b](6be453b716))
* **editor:** Handle permission edge cases (empty scopes)
([#7723](https://github.com/n8n-io/n8n/issues/7723))
([e2ffd39](e2ffd397fc))
* **editor:** Make sure LineController is registered with chart.js
([#7730](https://github.com/n8n-io/n8n/issues/7730))
([ebee1a5](ebee1a5908))
* **editor:** Move workerview entry into settings menu
([#7761](https://github.com/n8n-io/n8n/issues/7761))
([366cd67](366cd672a7))
* **editor:** Only show push to git menu item to owners
([#7766](https://github.com/n8n-io/n8n/issues/7766))
([0d3d33d](0d3d33dd1f))
* **editor:** Show v1 banner dismiss button if owner
([#7722](https://github.com/n8n-io/n8n/issues/7722))
([44d3b3e](44d3b3ed7e))
* **editor:** Use project diagram icon for worker view
([#7764](https://github.com/n8n-io/n8n/issues/7764))
([ff0b651](ff0b6511f7))
* **editor:** Validate user info before submiting
([#7608](https://github.com/n8n-io/n8n/issues/7608))
([2064f7f](2064f7f251))
* **GitHub Node:** Fix issue preventing file edits on branches
([#7734](https://github.com/n8n-io/n8n/issues/7734))
([ce002a6](ce002a6cc6))
* **Google Sheets Node:** Check for `null` before destructuring
([#7729](https://github.com/n8n-io/n8n/issues/7729))
([5d4a52d](5d4a52d3b7))
* **Item Lists Node:** Don't check same type in remove duplicates
operation ([#7678](https://github.com/n8n-io/n8n/issues/7678))
([4f30764](4f307646f3))
* **JotForm Trigger Node:** Fix iteration on form loader
([#7751](https://github.com/n8n-io/n8n/issues/7751))
([82f3202](82f3202a2d))


### Features

* Add Creator hub link to Templates page
([#7721](https://github.com/n8n-io/n8n/issues/7721))
([4dbae0e](4dbae0e2e9))
* **core:** Coordinate manual workflow activation and deactivation in
multi-main scenario ([#7643](https://github.com/n8n-io/n8n/issues/7643))
([4c40825](4c4082503c))
* **editor:** Add node context menu
([#7620](https://github.com/n8n-io/n8n/issues/7620))
([8d12c1a](8d12c1ad8d))
* **editor:** Node IO filter
([#7503](https://github.com/n8n-io/n8n/issues/7503))
([1881765](18817651ec))

Co-authored-by: ivov <ivov@users.noreply.github.com>
2023-11-22 14:32:25 +01:00
कारतोफ्फेलस्क्रिप्ट™ db77353272
fix(core): Pass correct node reference to NodeExecuteFunctions.getLoadOptionsFunctions (no-changelog) (#7779)
NODE-947
2023-11-22 13:24:23 +01:00
Deborah 3c56404f96
docs: Add workflow template contribution to the contributing guide (#7777)
Github issue / Community forum post (link here to close automatically):
2023-11-22 11:40:20 +00:00
Milorad FIlipović 2064f7f251
fix(editor): Validate user info before submiting (#7608)
Validate first and last names before saving them to database. This
should prevent security issue with un-sanitized data that ends up in
emails.

---------

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-11-22 12:14:44 +01:00
कारतोफ्फेलस्क्रिप्ट™ 9b4856e7de
feat(core): Make postgres pool-size configurable (no-changelog) (#7772)
When we upgrade typeorm in #5151, we switched from no pooling to a
default pool-size of 10. This somehow significantly deteriorates the
performance of queries when the application is under load.
2023-11-21 18:13:08 +01:00
Iván Ovejero 3459eb6c2f
refactor(core): Include execution progress in save settings (no-changelog) (#7769) 2023-11-21 17:33:44 +01:00
Iván Ovejero 5bdfcb4224
refactor: Upgrade to TypeScript 5.3 (no-changelog) (#7768)
https://devblogs.microsoft.com/typescript/announcing-typescript-5-3/
2023-11-21 17:30:59 +01:00
Michael Auerswald 0d3d33dd1f
fix(editor): Only show push to git menu item to owners (#7766)
Removes the menu entry of "Push to Git" from the workflow menu for
non-owners, since they would not be able to push in the first place.
2023-11-21 15:20:15 +01:00
Michael Auerswald ff0b6511f7
fix(editor): Use project diagram icon for worker view (#7764)
Swap monster truck for project diagram icon
2023-11-21 15:18:14 +01:00
Marcus 4f307646f3
fix(Item Lists Node): Don't check same type in remove duplicates operation (#7678)
Github issue / Community forum post (link here to close automatically):

---------

Co-authored-by: Michael Kret <michael.k@radency.com>
2023-11-21 13:10:59 +01:00
Michael Auerswald 366cd672a7
fix(editor): Move workerview entry into settings menu (#7761)
As the worker view is not an essential function, it is being moved from
the main side bar to the settings side bar for the time being.
2023-11-21 11:29:24 +01:00
Iván Ovejero b7c5c7406f
fix(core): Ensure failed executions are saved in queue mode (#7744)
This PR adds `status` to run data so that
`determineFinalExecutionStatus` resolves correctly on execution failure
and removes the cleanup that is being duplicated in a worker hook.

Followup to https://github.com/n8n-io/n8n/pull/7138

Should fix:
- https://github.com/n8n-io/n8n/issues/7705
-
https://linear.app/n8n/issue/PAY-964/no-execution-found-after-execution-fails
-
https://linear.app/n8n/issue/PAY-1010/execution-deletion-in-queue-mode-not-complying-with-settings
2023-11-20 16:03:02 +01:00
Deborah ad04986ce7
docs: Update docs links for data transformation functions and ifEmpty (#7758)
Github issue / Community forum post (link here to close automatically):
2023-11-20 13:40:28 +00:00
Elias Meire 8d12c1ad8d
feat(editor): Add node context menu (#7620)
![image](https://github.com/n8n-io/n8n/assets/8850410/5a601fae-cb8e-41bb-beca-ac9ab7065b75)
2023-11-20 14:37:12 +01:00
Milorad FIlipović 4dbae0e2e9
feat: Add Creator hub link to Templates page (#7721)
Replace the `New Blank Workflow` button with link to the new Creator Hub
in the Templates page
2023-11-20 10:51:46 +01:00
Elias Meire c9f6ea141b
fix: Include cypress TypeScript types in /cypress folder (no-changelog) (#7746) 2023-11-20 09:26:25 +01:00
Iván Ovejero 0fda8d9aac
refactor(core): Stop reporting to Sentry NodeApiError outside 500 range (no-changelog) (#7753)
https://n8nio.sentry.io/issues/4312838883 (and many others)

Followup to https://github.com/n8n-io/n8n/pull/7662
2023-11-17 17:49:28 +01:00
Iván Ovejero 6be453b716
fix(core): Guard against node not found on cancelling test webhook (#7750)
https://n8nio.sentry.io/issues/4623682198
2023-11-17 17:10:26 +01:00
Iván Ovejero 82f3202a2d
fix(JotForm Trigger Node): Fix iteration on form loader (#7751)
https://n8nio.sentry.io/issues/4636463129
2023-11-17 16:42:30 +01:00
Iván Ovejero 6d19f88080
refactor(core): Stop reporting to Sentry unknown cred on mapping (no-changelog) (#7752)
https://n8nio.sentry.io/issues/4563418905
2023-11-17 16:17:44 +01:00
Iván Ovejero 4c4082503c
feat(core): Coordinate manual workflow activation and deactivation in multi-main scenario (#7643)
Followup to #7566 | Story: https://linear.app/n8n/issue/PAY-926

### Manual workflow activation and deactivation

In a multi-main scenario, if the user manually activates or deactivates
a workflow, the process (whether leader or follower) that handles the
PATCH request and updates its internal state should send a message into
the command channel, so that all other main processes update their
internal state accordingly:

- Add to `ActiveWorkflows` if activating
- Remove from `ActiveWorkflows` if deactivating
- Remove and re-add to `ActiveWorkflows` if the update did not change
activation status.

After updating their internal state, if activating or deactivating, the
recipient main processes should push a message to all connected
frontends so that these can update their stores and so reflect the value
in the UI.

### Workflow activation errors

On failure to activate a workflow, the main instance should record the
error in Redis - main instances should always pull activation errors
from Redis in a multi-main scenario.

### Leadership change

On leadership change...

- The old leader should stop pruning and the new leader should start
pruning.
- The old leader should remove trigger- and poller-based workflows and
the new leader should add them.
2023-11-17 15:58:50 +01:00
कारतोफ्फेलस्क्रिप्ट™ b3a3f16bc2 ci: Fix "Release: Create Pull Request" workflow 2023-11-17 14:59:01 +01:00
कारतोफ्फेलस्क्रिप्ट™ 2d039010db
fix(editor): Fix Admin panel icon in the sidebar for cloud deployments (no-changelog) (#7738)
Co-authored-by: ricardo <ricardoespinoza105@gmail.com>
Co-authored-by: Mutasem Aldmour <mutasem@n8n.io>
2023-11-17 14:44:47 +01:00
कारतोफ्फेलस्क्रिप्ट™ b66b8c18e9
fix(editor): Remove n8nHooksNext flag (no-changelog) (#7733)
Hooks won't be injected anymore
https://github.com/n8n-io/n8n-hosted-backend/pull/816
2023-11-17 14:44:28 +01:00
Mutasem Aldmour 44d3b3ed7e
fix(editor): Show v1 banner dismiss button if owner (#7722)
Github issue / Community forum post (link here to close automatically):

https://community.n8n.io/t/v1-upgrade-banner-shall-be-dismissed-permanently/32775
2023-11-17 14:15:13 +01:00
Jon ce002a6cc6
fix(GitHub Node): Fix issue preventing file edits on branches (#7734)
Github issue / Community forum post (link here to close automatically):
https://github.com/n8n-io/n8n/issues/7614
2023-11-17 13:07:33 +00:00
कारतोफ्फेलस्क्रिप्ट™ db094f2d7e
fix(core): Fix all dependency versions for backend packages (no-changelog) (#7745)
Once the packages are published to NPM, they don't have the
`pnpm-lock.yaml` to fix dependency versions. Which means that any
dependency with `^` gets auto-upgrade to the latest matching minor,
which can cause issues like
[this](https://github.com/node-cache-manager/node-cache-manager/issues/611).
2023-11-17 13:49:18 +01:00
कारतोफ्फेलस्क्रिप्ट™ fc60e9a809
refactor(core): Convert dynamic node-parameter routes to a decorated controller (no-changelog) (#7284)
1. Reduce a lot of code duplication
2. Move more endpoints out of `Server.ts`
3. Move all query-param parsing and validation into a middleware to make
the route handlers simpler.
2023-11-17 12:03:05 +01:00
Iván Ovejero 05ed86c64b
refactor: Stop reporting to Sentry Facebook multi-webhook error (no-changelog) (#7743)
https://n8nio.sentry.io/issues/4640072705
2023-11-17 11:39:46 +01:00
Iván Ovejero 0408299c7d
refactor(core): Stop reporting to Sentry unrecognized node errors (no-changelog) (#7728)
https://n8nio.sentry.io/issues/4636584213
2023-11-17 10:25:10 +01:00
Iván Ovejero b4ebb1a28d
fix(core): Account for non-ASCII chars in filename on binary data download (#7742)
https://n8nio.sentry.io/issues/4641538638
2023-11-17 10:07:44 +01:00
कारतोफ्फेलस्क्रिप्ट™ abe36691ab
ci: Fix DB tests and Workflow tests (no-changelog) (#7741)
[Workflow Tests](https://github.com/n8n-io/n8n/actions/runs/6901672210)
[DB Tests](https://github.com/n8n-io/n8n/actions/runs/6901673148)
2023-11-17 10:07:19 +01:00
Ricardo Espinoza 8e0ae3cf8c
refactor: Extract Invitation routes to InvitationController (no-changelog) (#7726)
This PR:

- Creates `InvitationController`
- Moves `POST /users` to `POST /invitations` and move related test to
`invitations.api.tests`
- Moves `POST /users/:id` to `POST /invitations/:id/accept` and move
related test to `invitations.api.tests`
- Adjusts FE to use new endpoints
- Moves all the invitation logic to the `UserService`

---------

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-11-16 12:39:43 -05:00
Csaba Tuncsik e2ffd397fc
fix(editor): Handle permission edge cases (empty scopes) (#7723) 2023-11-16 18:08:23 +01:00
कारतोफ्फेलस्क्रिप्ट™ 9d6a68d1c7
ci: Skip the regularly failing tests in 2-credentials.cy.ts (no-changelog) (#7736) 2023-11-16 17:42:58 +01:00
Iván Ovejero 5d4a52d3b7
fix(Google Sheets Node): Check for null before destructuring (#7729)
https://n8nio.sentry.io/issues/4613453684
2023-11-16 16:50:06 +01:00
Val d39bb2540f
feat: Add scopes to /login endpoint (no-changelog) (#7718)
Github issue / Community forum post (link here to close automatically):
2023-11-16 11:11:55 +00:00
कारतोफ्फेलस्क्रिप्ट™ ebee1a5908
fix(editor): Make sure LineController is registered with chart.js (#7730)
Tree shaking in production build of the editor-ui package removed the
LineController, this makes sure it is in the final package.
2023-11-16 11:57:43 +01:00
कारतोफ्फेलस्क्रिप्ट™ 6300ee342c
ci: Push to Channel workflow should update the tags on GCR as well (no-changelog) (#7727) 2023-11-15 22:09:35 +01:00
Michael Auerswald f96c1d2044
fix(core): Correct permissions for getstatus (#7724) 2023-11-15 16:54:33 +01:00
Csaba Tuncsik 18817651ec
feat(editor): Node IO filter (#7503)
Co-authored-by: Omar Ajoue <krynble@gmail.com>
2023-11-15 16:19:48 +01:00
github-actions[bot] 93103c0b08
🚀 Release 1.17.0 (#7720)
#
[1.17.0](https://github.com/n8n-io/n8n/compare/n8n@1.16.0...n8n@1.17.0)
(2023-11-15)


### Bug Fixes

* **Convert to/from binary data Node:** Better mime type defaults
([#7693](https://github.com/n8n-io/n8n/issues/7693))
([9b3be0c](9b3be0cfd8))
* **core:** Consider subworkflows successfully run when in waiting state
([#7699](https://github.com/n8n-io/n8n/issues/7699))
([0e00dab](0e00dab9f5))
* **core:** Fix named parameter resolution in migrations
([#7688](https://github.com/n8n-io/n8n/issues/7688))
([4441ed5](4441ed5116)),
closes [#7628](https://github.com/n8n-io/n8n/issues/7628)
* **core:** Initialize JWT Secret before it's used anywhere
([#7707](https://github.com/n8n-io/n8n/issues/7707))
([3460eb5](3460eb5eeb))
* **core:** Reduce memory usage in credentials risk auditing
([#7663](https://github.com/n8n-io/n8n/issues/7663))
([9fd6319](9fd6319583))
* **Date & Time Node:** Add fromFormat option to solve ambiguous date
strings ([#7675](https://github.com/n8n-io/n8n/issues/7675))
([d2d11e0](d2d11e0208))
* **editor:** Fix resource mapper component being truncated
([#7664](https://github.com/n8n-io/n8n/issues/7664))
([00dff50](00dff50140))
* **editor:** More securely clear executions tab auto refresh timer
([#7685](https://github.com/n8n-io/n8n/issues/7685))
([37dd658](37dd658dc5))
* **editor:** Redirect to workflow editor after saving in debug mode
([#7645](https://github.com/n8n-io/n8n/issues/7645))
([020042e](020042ef1a))
* **Google Sheets Node:** Append exceeding grid limits
([#7684](https://github.com/n8n-io/n8n/issues/7684))
([88efb99](88efb99587))
* **HTTP Request Node:** Support generic credentials when using
pagination ([#7686](https://github.com/n8n-io/n8n/issues/7686))
([48b240b](48b240b026)),
closes [#7653](https://github.com/n8n-io/n8n/issues/7653)
* **HubSpot Node:** Fetching available parameters fails when using
expressions ([#7672](https://github.com/n8n-io/n8n/issues/7672))
([a9ab738](a9ab73896e))
* **HubSpot Node:** Update deal owner on Hubspot Deal
([#7673](https://github.com/n8n-io/n8n/issues/7673))
([3c0734b](3c0734bd2d))
* **Spreadsheet File Node:** Read file as utf-8 in v1
([#7701](https://github.com/n8n-io/n8n/issues/7701))
([786b4ad](786b4adcce))


### Features

* **core:** Expression function $ifEmpty
([#7660](https://github.com/n8n-io/n8n/issues/7660))
([1c7225e](1c7225ebdb))
* **Date & Time Node:** Option to include other fields in output item
([#7661](https://github.com/n8n-io/n8n/issues/7661))
([aea3c50](aea3c50131))
* **Discord Node:** Overhaul
([#5351](https://github.com/n8n-io/n8n/issues/5351))
([6a53c2a](6a53c2a375))
* **Discourse Node:** Add new options to Get Users
([#7674](https://github.com/n8n-io/n8n/issues/7674))
([2e8c841](2e8c841277))
* **editor:** Add color selector to sticky node
([#7453](https://github.com/n8n-io/n8n/issues/7453))
([8359364](8359364536))
* **editor:** Add HTTP request nodes for credentials without a node
([#7157](https://github.com/n8n-io/n8n/issues/7157))
([14035e1](14035e1244))
* **editor:** Add workflow filters to querystring
([#7456](https://github.com/n8n-io/n8n/issues/7456))
([afd637b](afd637b5ea))
* **editor:** Adds a EE view to show worker details and job status
([#7600](https://github.com/n8n-io/n8n/issues/7600))
([cbc6909](cbc690907f))
* **GitLab Node:** Add support for pagination on getIssues
([#7529](https://github.com/n8n-io/n8n/issues/7529))
([0a0798e](0a0798e485))
* **OpenAI Node:** Add dall-e-3 support
([#7655](https://github.com/n8n-io/n8n/issues/7655))
([a9c7188](a9c7188c4d))
* **RabbitMQ Trigger Node:** Add exchange and routing key options
([#7547](https://github.com/n8n-io/n8n/issues/7547))
([5aee2b7](5aee2b768f))
* **Telegram Node:** Add support for markdownv2
([#7679](https://github.com/n8n-io/n8n/issues/7679))
([819b3a7](819b3a746a))
* **Venafi TLS Protect Cloud Node:** Add region parameter to Venafi
protect cloud ([#7689](https://github.com/n8n-io/n8n/issues/7689))
([a08fca5](a08fca51d9))


### Performance Improvements

* **core:** Lazyload security audit reporters
([#7696](https://github.com/n8n-io/n8n/issues/7696))
([b2ca050](b2ca050031))

Co-authored-by: ivov <ivov@users.noreply.github.com>
2023-11-15 15:18:08 +01:00
कारतोफ्फेलस्क्रिप्ट™ 2844ce2bd2
ci: Fix env issues in e2e tests (no-changelog) (#7719) 2023-11-15 13:58:38 +01:00
Giulio Andreini 0cebd28582
fix(editor): Dark mode sticky notes (no-changelog) (#7716) 2023-11-15 12:56:09 +01:00
Ricardo Espinoza 4020c14d59
refactor: Use POST /users to re-invite users (no-changelog) (#7714) 2023-11-15 06:40:57 -05:00
कारतोफ्फेलस्क्रिप्ट™ 3460eb5eeb
fix(core): Initialize JWT Secret before it's used anywhere (#7707)
HELP-394
2023-11-15 12:17:18 +01:00
EMRE TEOMAN 5aee2b768f
feat(RabbitMQ Trigger Node): Add exchange and routing key options (#7547)
RabbitMQ trigger needs binding for some cases. For example, I need to
consume some domain events in my application and they are published with
routing key.

---------

Co-authored-by: teomane <emre.teoman@bordatech.com>
2023-11-15 11:02:54 +00:00
Csaba Tuncsik 27cb7c3c63
test: Add vitest workspace config so VS Code vitest extension works with 1 click (no-changelog) (#7698) 2023-11-15 11:59:41 +01:00