कारतोफ्फेलस्क्रिप्ट™
d1b48ddcac
fix(core): Remove sensitive data from User entity during serialization (no-changelog) ( #8773 )
2024-02-29 14:20:39 +01:00
कारतोफ्फेलस्क्रिप्ट™
db4a419c8d
refactor(core): Enforce authorization by default on all routes (no-changelog) ( #8762 )
2024-02-28 17:02:18 +01:00
कारतोफ्फेलस्क्रिप्ट™
2811f77798
refactor(core): Rename RequireGlobalScope to GlobalScope (no-changelog) ( #8760 )
2024-02-28 14:40:02 +01:00
कारतोफ्फेलस्क्रिप्ट™
56c8791aff
refactor(core): Remove all legacy auth middleware code (no-changelog) ( #8755 )
2024-02-28 13:12:28 +01:00
github-actions[bot]
2e84684f04
🚀 Release 1.31.0 ( #8759 )
...
Co-authored-by: netroy <netroy@users.noreply.github.com>
2024-02-28 12:18:12 +01:00
कारतोफ्फेलस्क्रिप्ट™
5f6da7b84e
fix(core): Do not report generic webhook execution errors (no-changelog) ( #8749 )
2024-02-27 12:36:49 +01:00
Omar Ajoue
737170893d
feat: Allow instance owners and admins to edit all credentials ( #8716 )
...
Co-authored-by: Danny Martini <despair.blue@gmail.com>
2024-02-27 08:26:36 +00:00
Alex Grozav
4b01335aa4
feat: Add env variables to support exposing /workflows/demo route and /nodes.json route ( #8506 )
...
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2024-02-23 18:20:12 +02:00
कारतोफ्फेलस्क्रिप्ट™
35fb7102cb
refactor(core): Update auth related typings (no-changelog) ( #8686 )
2024-02-23 15:08:18 +01:00
Jan Oberhauser
a29b41ec55
fix(core): Fix pairedItem issue with partial manual executions ( #8575 )
...
Co-authored-by: Danny Martini <danny@n8n.io>
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2024-02-23 11:43:08 +01:00
github-actions[bot]
8b67dfbed9
🚀 Release 1.30.0 ( #8702 )
...
Co-authored-by: netroy <netroy@users.noreply.github.com>
2024-02-21 15:43:44 +01:00
कारतोफ्फेलस्क्रिप्ट™
059d281fd1
feat(core): Move execution permission checks earlier in the lifecycle ( #8677 )
2024-02-21 14:47:02 +01:00
Iván Ovejero
5304b320c8
refactor(core): Enrich inaccessible credential error ( #8574 )
...
Co-authored-by: Omar Ajoue <krynble@gmail.com>
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2024-02-21 13:04:30 +01:00
Tomi Turtiainen
05e13a68ea
fix: Fix typeorm .save usage (no-changelog) ( #8678 )
2024-02-20 17:34:54 +02:00
कारतोफ्फेलस्क्रिप्ट™
afd2eb1f4a
fix(core): Report all sqlite transaction rollback errors to Sentry (no-changelog) ( #8680 )
2024-02-20 15:28:12 +01:00
कारतोफ्फेलस्क्रिप्ट™
b6c8a0c413
refactor(core): Reduce code duplication in DB config (no-changelog) ( #8679 )
2024-02-20 14:28:53 +01:00
github-actions[bot]
c4e259bcfc
🚀 Release 1.29.0 ( #8643 )
...
Co-authored-by: krynble <krynble@users.noreply.github.com>
2024-02-15 11:08:48 +00:00
Omar Ajoue
540a80e9f9
test: Fix broken workflow tag tests ( #8641 )
...
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <netroy@users.noreply.github.com>
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2024-02-15 10:51:59 +00:00
Danny Martini
24859cfef5
docs: Document own mode removal in BREAKING-CHANGES.md (no-changelog) ( #8632 )
2024-02-14 16:26:01 +01:00
कारतोफ्फेलस्क्रिप्ट™
a2a3ca160f
fix(core): Improve the startup error when EXECUTIONS_PROCESS is set ( #8630 )
...
Co-authored-by: Omar Ajoue <krynble@gmail.com>
2024-02-14 15:35:42 +01:00
कारतोफ्फेलस्क्रिप्ट™
68498cb72a
fix(core): Upgrade @n8n/typeorm to address postgres timestamp issues ( #8627 )
2024-02-14 14:17:57 +01:00
Danny Martini
cd8ca8412d
fix(core): Give better error message if executions.process is still used in the configs ( #8618 )
2024-02-13 12:40:50 +00:00
Danny Martini
ee81015231
docs: Update cursor description in the public api documentation ( #8602 )
2024-02-09 16:36:57 +01:00
Cornelius Suermann
5a613d4a8b
build: Update License-SDK to v2.10.0 (no-changelog) ( #8537 )
2024-02-09 16:10:50 +01:00
Omar Ajoue
a743a40376
feat(API): Add tag support to public API ( #8588 )
...
Co-authored-by: Jesús Burgers <jesus.burgers@chakray.co.uk>
Co-authored-by: Jesús Burgers <43568066+jburgers-chakray@users.noreply.github.com>
2024-02-09 15:10:03 +00:00
Cornelius Suermann
cd151f1ba9
feat: Include totalUsers in usage metrics during license renewal (no-changelog) ( #8598 )
2024-02-09 14:15:05 +01:00
oleg
5ab34fe335
fix(API): Fire workflowExecuteBefore hook in runMainProcess (no-changelog) ( #8601 )
2024-02-09 13:23:00 +01:00
Omar Ajoue
7501ad8f3c
feat: Add support for AI log streaming ( #8526 )
...
Co-authored-by: Oleg Ivaniv <me@olegivaniv.com>
2024-02-09 09:41:01 +00:00
कारतोफ्फेलस्क्रिप्ट™
8e392cfc1d
feat(core): Migrate to n8n's typeorm fork ( #8590 )
2024-02-08 15:13:29 +01:00
कारतोफ्फेलस्क्रिप्ट™
7826bd842a
feat: Upgrade typeorm, sqlite3, and pg/pg-promise ( #8579 )
2024-02-08 10:40:18 +01:00
कारतोफ्फेलस्क्रिप्ट™
5750e8e88e
fix(core): Upgrade rudderstack sdk to address npm postInstall issues ( #8568 )
2024-02-08 10:40:10 +01:00
कारतोफ्फेलस्क्रिप्ट™
40eee3aa49
ci(core): Avoid slow bcrypt calls in tests (no-changelog) ( #8570 )
2024-02-07 17:56:02 +01:00
github-actions[bot]
1b7ebe463e
🚀 Release 1.28.0 ( #8569 )
...
Co-authored-by: ivov <ivov@users.noreply.github.com>
2024-02-07 15:39:40 +01:00
कारतोफ्फेलस्क्रिप्ट™
c04f92f7fd
refactor(core): Couple of refactors on WorkflowRunner and ActiveExecutions (no-changelog) ( #8487 )
2024-02-06 18:09:50 +01:00
Iván Ovejero
dc068ce2e6
build: Fix outdated import to fix build (no-changelog) ( #8558 )
2024-02-06 10:45:30 +01:00
Iván Ovejero
abddbb6227
fix(core): Use trx manager instead of repository for tags overwrite ( #8557 )
2024-02-06 10:40:32 +01:00
Iván Ovejero
c4e39451db
refactor(core): Continue breaking dependency cycles (no-changelog) ( #8545 )
2024-02-06 10:08:46 +01:00
Iván Ovejero
28aee7c425
refactor(core): Lock webhook process out of multi-main setup (no-changelog) ( #8549 )
2024-02-05 18:06:54 +01:00
Iván Ovejero
dca50dcc68
docs: Add encryption key check to breaking changes list ( #8551 )
2024-02-05 16:39:59 +01:00
Danny Martini
b62c1d7c41
fix: Remove ts-node from overrides and typeorm script (no-changelog) ( #8547 )
2024-02-05 14:09:22 +01:00
Iván Ovejero
dc5ec8f946
refactor(core): Streamline flows in multi-main mode (no-changelog) ( #8446 )
2024-02-05 09:26:55 +01:00
कारतोफ्फेलस्क्रिप्ट™
ee5e422094
fix(core): Upgrade nodemailer to address an exploit ( #8535 )
2024-02-02 14:12:18 +01:00
Iván Ovejero
92f939f827
fix(core): Fix workflow tagging failure due to unique constraint check ( #8505 )
2024-02-02 12:36:55 +01:00
कारतोफ्फेलस्क्रिप्ट™
4fed68ee34
fix(core): Fix DropRoleMapping migration ( #8521 )
2024-02-02 12:22:09 +01:00
कारतोफ्फेलस्क्रिप्ट™
5832d3ca46
fix(core): Fix PermissionChecker.check, and add additional unit tests ( #8528 )
2024-02-02 12:21:53 +01:00
Iván Ovejero
528c07134a
fix(core): Fix test runs of triggers that rely on static data ( #8524 )
2024-02-01 18:05:23 +01:00
Iván Ovejero
cc41fc7c80
fix(core): Fix new graceful shutdown env being always overridden by deprecated env ( #8503 )
2024-02-01 11:10:40 +01:00
कारतोफ्फेलस्क्रिप्ट™
88cf1823d3
Merge tag 'n8n@1.27.0'
2024-01-31 20:33:25 +01:00
कारतोफ्फेलस्क्रिप्ट™
d2d0ae6c5d
ci: Fix DB tests (no-changelog) ( #8513 )
2024-01-31 17:36:50 +01:00
github-actions[bot]
7aa3ef7168
🚀 Release 1.27.0 ( #8512 )
...
Co-authored-by: ivov <ivov@users.noreply.github.com>
2024-01-31 16:08:37 +01:00
कारतोफ्फेलस्क्रिप्ट™
033fd344b5
fix(core): Handle possibly invalid updatedAt timestamps in source-control ( #8485 )
2024-01-31 14:25:03 +01:00
कारतोफ्फेलस्क्रिप्ट™
839dd96c7d
refactor(core): Move all code related to onServerStarted into InternalHooks (no-changelog) ( #8500 )
2024-01-31 13:29:17 +01:00
Danny Martini
39e8754784
fix(core): Don't report executions that have been paused as failed to rudderstack and log streams ( #8501 )
2024-01-31 11:21:15 +01:00
Iván Ovejero
dac511b710
refactor(core): Modernize credentials controllers and services (no-changelog) ( #8488 )
...
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2024-01-31 09:48:48 +01:00
कारतोफ्फेलस्क्रिप्ट™
121a55b691
feat(core): Remove own execution-process mode ( #8490 )
2024-01-30 12:51:40 +01:00
कारतोफ्फेलस्क्रिप्ट™
5cb55270b7
refactor(core): Replace promisify-d node calls with native promises (no-changelog) ( #8464 )
2024-01-30 09:49:23 +01:00
Iván Ovejero
238b54c77b
fix(core): Fix stopping and retrying failed executions ( #8480 )
2024-01-29 16:34:58 +01:00
Iván Ovejero
9e93980957
fix(core): Prevent calling internal hook email event if emailing is disabled ( #8462 )
...
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2024-01-29 16:15:30 +01:00
Iván Ovejero
db48bdd6d1
fix(core): Handle zero execution statistics on metrics collection during license renewal ( #8463 )
2024-01-26 17:50:19 +01:00
कारतोफ्फेलस्क्रिप्ट™
2fba0e8d58
feat(core): Upgrade Rudderstack SDK to address CVE-2023-45857 ( #8368 )
2024-01-26 16:58:44 +01:00
Danny Martini
9f11eba0a4
fix(core): Point users to the official documentation when they use n8n --help ( #8440 )
2024-01-26 15:16:53 +01:00
कारतोफ्फेलस्क्रिप्ट™
c70fa66e76
refactor(core): Use DI for WorkflowRunner (no-changelog) ( #8372 )
2024-01-26 13:49:39 +01:00
कारतोफ्फेलस्क्रिप्ट™
7c49004018
refactor(core): Use DI for eventBus code - Part 1 (no-changelog) ( #8434 )
2024-01-26 12:21:15 +01:00
कारतोफ्फेलस्क्रिप्ट™
ef4507c821
Merge tag 'n8n@1.26.0'
2024-01-25 16:49:18 +01:00
कारतोफ्फेलस्क्रिप्ट™
cc2f0ada76
ci: Enforce noUnusedLocals on all backend and nodes packages (no-changelog) ( #8428 )
2024-01-25 14:33:35 +01:00
कारतोफ्फेलस्क्रिप्ट™
f438082442
fix(core): Run the down migration correctly when transaction: false is set (no-changelog) ( #8432 )
2024-01-24 19:07:47 +01:00
Michael Kret
ed7d6b7b3a
feat(core): Display conditions in displayOptions (no-changelog) ( #7888 )
2024-01-24 18:04:46 +02:00
कारतोफ्फेलस्क्रिप्ट™
d6deceacde
refactor(core): Remove roleId indirection (no-changelog) ( #8413 )
2024-01-24 13:38:57 +01:00
github-actions[bot]
111d2ebe68
🚀 Release 1.26.0 ( #8427 )
...
Co-authored-by: ivov <ivov@users.noreply.github.com>
2024-01-24 13:28:47 +01:00
कारतोफ्फेलस्क्रिप्ट™
1affebd85e
refactor(core): Remove unused code from Server.ts (no-changelog) ( #8426 )
2024-01-24 12:55:43 +01:00
Cornelius Suermann
a8b4684192
build: Bump license-sdk to v2.9.1 (no-changelog) ( #8420 )
2024-01-23 14:44:46 +01:00
Iván Ovejero
c0bc94c78f
refactor(core): Finish removing UserManagementHelper (no-changelog) ( #8418 )
2024-01-23 13:58:31 +01:00
Iván Ovejero
a0a1830696
feat(core): Email recipients on resource shared ( #8408 )
2024-01-23 12:03:59 +01:00
Danny Martini
ae06fdeb62
fix(core): Fix update workflow cli command being unable to activate all workflows ( #8412 )
...
Co-authored-by: Daniel Schröder <daniel.schroeder@skriptfabrik.com>
2024-01-23 10:59:06 +01:00
Iván Ovejero
49b52c4f1d
refactor(core): Bring active executions into executions controller (no-changelog) ( #8371 )
2024-01-23 09:48:50 +01:00
कारतोफ्फेलस्क्रिप्ट™
913c8c6b0c
feat(core): Upgrade oclif (no-changelog) ( #8381 )
2024-01-22 18:25:36 +01:00
Cornelius Suermann
d597c2ab29
feat: Extend collection of usage metrics during license renewal (no-changelog) ( #8369 )
...
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
2024-01-22 12:29:28 +01:00
Iván Ovejero
f35d4fcbd8
refactor(core): Simplify OrchestrationService (no-changelog) ( #8364 )
2024-01-22 11:16:29 +01:00
Danny Martini
07e6705256
feat(core): Custom session timeout and refresh configuration ( #8342 )
2024-01-22 09:54:13 +01:00
Giulio Andreini
f4f496ae85
docs(editor): All buttons to sentence case (no-changelog) ( #8399 )
2024-01-22 09:20:02 +01:00
Jon
9883eda42e
fix: Fix openapi generation (no-changelog) ( #8398 )
2024-01-19 18:15:33 +01:00
Iván Ovejero
749ac2b407
fix(core): Adjust starter node priority for manual executions with pinned activators ( #8386 )
2024-01-19 10:18:04 +01:00
कारतोफ्फेलस्क्रिप्ट™
c7c4ae4514
feat(core): Upgrade swagger (no-changelog) ( #8384 )
2024-01-18 14:16:14 +01:00
Tomi Turtiainen
f31cc0743f
fix: Force posthog recording to be disabled outside cloud ( #8374 )
2024-01-18 14:44:27 +02:00
Jon
fc94377036
fix: Fix issue preventing secrets with a - in the path from being imported ( #8378 )
2024-01-18 09:24:58 +00:00
Tomi Turtiainen
99457019f7
feat: Nudge users to become template creators if eligible ( #8357 )
2024-01-17 19:07:34 +02:00
कारतोफ्फेलस्क्रिप्ट™
3912c5e7ab
feat(core): Upgrade axios and follow-redirects to address CVE-2023-26159 ( #8366 )
2024-01-17 16:41:01 +01:00
कारतोफ्फेलस्क्रिप्ट™
639d34769e
feat(core): Upgrade bull and ioredis to address CVE-2023-52079 ( #8365 )
2024-01-17 16:33:54 +01:00
Tomi Turtiainen
9a1cc56806
fix: Set '@typescript-eslint/return-await' rule to 'always' for node code (no-changelog) ( #8363 )
...
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2024-01-17 17:08:50 +02:00
Iván Ovejero
2eb829a6b4
refactor(core): Use DI in execution services (no-changelog) ( #8358 )
2024-01-17 15:42:19 +01:00
github-actions[bot]
7268d24259
🚀 Release 1.25.0 ( #8362 )
...
Co-authored-by: netroy <netroy@users.noreply.github.com>
2024-01-17 14:20:55 +01:00
Iván Ovejero
771d2fa341
test(core): Fix cleanup in test teardown script (no-changelog) ( #8361 )
2024-01-17 14:01:56 +01:00
Omar Ajoue
d5455d7acc
fix(core): Report when waitTill is invalid and handle it ( #8356 )
2024-01-17 13:08:20 +01:00
कारतोफ्फेलस्क्रिप्ट™
7cdbb424e3
refactor(core): Move methods from WorkflowHelpers into various workflow services (no-changelog) ( #8348 )
2024-01-17 10:16:13 +01:00
Iván Ovejero
d4c93b1607
fix(core): Prevent issues with missing or mismatching encryption key ( #8332 )
2024-01-16 18:25:53 +01:00
Iván Ovejero
7bb2d1799e
refactor(core): Consolidate executions controllers (no-changelog) ( #8349 )
2024-01-16 16:52:21 +01:00
कारतोफ्फेलस्क्रिप्ट™
64ceb16af6
refactor(core): Use DI in PermissionChecker (no-changelog) ( #8344 )
2024-01-16 14:15:29 +01:00
Iván Ovejero
420b4271a9
refactor(core): Move typeorm operators from Public API (no-changelog) ( #8319 )
2024-01-16 13:35:43 +01:00
Omar Ajoue
e1acb5911a
refactor: Make execution IDs mandatory in BE ( #8299 )
...
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
2024-01-16 09:53:17 +00:00
Iván Ovejero
0f4f472a72
refactor(core): Eliminate dead Redis code (no-changelog) ( #8292 )
2024-01-16 09:31:45 +01:00
Iván Ovejero
5fbd7971e0
fix(core): Account for immediate confirmation request during test webhook creation ( #8329 )
2024-01-16 09:17:41 +01:00
Ricardo Espinoza
3c2a4000ae
refactor(core): Use DI for LDAP code (no-changelog) ( #8248 )
...
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2024-01-15 09:01:48 -05:00
Iván Ovejero
1a0e285553
feat(core): Implement inter-main communication for test webhooks in multi-main setup ( #8267 )
2024-01-12 11:48:58 +01:00
oleg
884396ea0d
fix(API): Fix manual chat trigger execution ( #8300 )
...
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
2024-01-11 14:01:07 +01:00
Omar Ajoue
8c7f39907f
fix: Properly output saml validation errors ( #8284 )
2024-01-10 16:56:04 +01:00
github-actions[bot]
8a4231e9f6
🚀 Release 1.24.0 ( #8290 )
...
Co-authored-by: ivov <ivov@users.noreply.github.com>
2024-01-10 16:16:25 +01:00
Omar Ajoue
8a7c629ea1
fix: Store workflow settings when saving an execution ( #8288 )
2024-01-10 14:20:37 +00:00
Michael Kret
ccde38a8a8
fix(Monday.com Node): Migrate to api 2023-10 ( #8254 )
2024-01-10 11:17:00 +02:00
Iván Ovejero
5032bf0e34
fix(core): Fix test webhook deregistration ( #8247 )
2024-01-09 16:02:32 +01:00
Iván Ovejero
0dabe5c74e
fix: Fix user reinvites on FE and BE ( #8261 )
2024-01-09 13:52:34 +01:00
Tomi Turtiainen
3b996a7da0
feat(core): Validate shutdown handlers on startup ( #8260 )
2024-01-08 17:46:45 +02:00
Tomi Turtiainen
8affdf680d
fix: Hide cred setup button from canvas (no-changelog) ( #8255 )
2024-01-08 13:59:04 +02:00
Iván Ovejero
90c065e999
refactor(core): Convert workflows controller to DI (no-changelog) ( #8253 )
2024-01-08 12:54:23 +01:00
कारतोफ्फेलस्क्रिप्ट™
ac1c642fdd
fix(core): Do not add Authentication header when authentication type is body ( #8201 )
2024-01-08 12:38:24 +01:00
Jan Oberhauser
ccb2b076f8
fix: Resolve expressions in credentials following paired item ( #8250 )
...
## Summary
Fixes the issue that pairedItem information was not available in
expressions that got used in credentials
## Related tickets and issues
[PAY-1207](https://linear.app/n8n/issue/PAY-1207/paireditem-expressions-not-working-correctly-in-credentials )
## Review / Merge checklist
- [x] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
> A feature is not complete without tests.
---------
Co-authored-by: Omar Ajoue <krynble@gmail.com>
2024-01-08 09:48:20 +00:00
Iván Ovejero
f2939568cf
perf(core): Optimize workflow activation errors ( #8242 )
...
At https://github.com/n8n-io/n8n/pull/8213 we introduced Redis hashes
for workflow ownership and manual webhooks...
- to remove clutter from multiple related keys at the top level,
- to improve performance by preventing serializing-deserializing, and
- to guarantee atomicity during concurrent updates in multi-main setup.
Workflow activation errors can also benefit from this. Added test
coverage as well.
To test manually, create a workflow with a trigger with an invalid
credential, edit the workflow's `active` column to `true`, and restart.
The activation error should show as a red triangle on canvas and in the
workflow list.
2024-01-05 13:06:42 +01:00
Iván Ovejero
23a4ac96c0
refactor(core): Continue moving typeorm operators to repositories (no-changelog) ( #8212 )
...
Follow-up to: https://github.com/n8n-io/n8n/pull/8186
2024-01-05 13:06:24 +01:00
Iván Ovejero
f53c482939
perf(core): Improve caching service ( #8213 )
...
Story: https://linear.app/n8n/issue/PAY-1188
- Implement Redis hashes on the caching service, based on Micha's work
in #7747 , adapted from `node-cache-manager-ioredis-yet`. Optimize
workflow ownership lookups and manual webhook lookups with Redis hashes.
- Simplify the caching service by removing all currently unused methods
and options: `enable`, `disable`, `getCache`, `keys`, `keyValues`,
`refreshFunctionEach`, `refreshFunctionMany`, `refreshTtl`, etc.
- Remove the flag `N8N_CACHE_ENABLED`. Currently some features on
`master` are broken with caching disabled, and test webhooks now rely
entirely on caching, for multi-main setup support. We originally
introduced this flag to protect against excessive memory usage, but
total cache usage is low enough that we decided to drop this setting.
Apparently this flag was also never documented.
- Overall caching service refactor: use generics, reduce branching, add
discriminants for cache kinds for better type safety, type caching
events, improve readability, remove outdated docs, etc. Also refactor
and expand caching service tests.
Follow-up to: https://github.com/n8n-io/n8n/pull/8176
---------
Co-authored-by: Michael Auerswald <michael.auerswald@gmail.com>
2024-01-05 11:52:44 +01:00
Iván Ovejero
22a5f5258d
feat(core): Cache test webhook registrations ( #8176 )
...
In a multi-main setup, we have the following issue. The user's client
connects to main A and runs a test webhook, so main A starts listening
for a webhook call. A third-party service sends a request to the test
webhook URL. The request is forwarded by the load balancer to main B,
who is not listening for this webhook call. Therefore, the webhook call
is unhandled.
To start addressing this, cache test webhook registrations, using Redis
for queue mode and in-memory for regular mode. When the third-party
service sends a request to the test webhook URL, the request is
forwarded by the load balancer to main B, who fetches test webhooks from
the cache and, if it finds a match, executes the test webhook. This
should be transparent - test webhook behavior should remain the same as
so far.
Notes:
- Test webhook timeouts are not cached. A timeout is only relevant to
the process it was created in, so another process retrieving from Redis
a "foreign" timeout will be unable to act on it. A timeout also has
circular references, so `cache-manager-ioredis-yet` is unable to
serialize it.
- In a single-main scenario, the timeout remains in the single process
and is cleared on test webhook expiration, successful execution, and
manual cancellation - all as usual.
- In a multi-main scenario, we will need to have the process who
received the webhook call send a message to the process who created the
webhook directing this originating process to clear the timeout. This
will likely be implemented via execution lifecycle hooks and Redis
channel messages checking session ID. This implementation is out of
scope for this PR and will come next.
- Additional data in test webhooks is not cached. From what I can tell,
additional data is not needed for test webhooks to be executed.
Additional data also has circular references, so
`cache-manager-ioredis-yet` is unable to serialize it.
Follow-up to: #8155
2024-01-03 16:58:33 +01:00
github-actions[bot]
053503531f
🚀 Release 1.23.0 ( #8205 )
...
#
[1.23.0](https://github.com/n8n-io/n8n/compare/n8n@1.22.0...n8n@1.23.0 )
(2024-01-03)
### Bug Fixes
* **Asana Node:** Omit body from GET, HEAD, and DELETE requests
([#8057 ](https://github.com/n8n-io/n8n/issues/8057 ))
([15ffd4f15ffd4fb9f#8189 ](https://github.com/n8n-io/n8n/issues/8189 ))
([cfe9525cfe9525dd4#8123 ](https://github.com/n8n-io/n8n/issues/8123 ))
([fa8bd8bfa8bd8b9eb#8121 ](https://github.com/n8n-io/n8n/issues/8121 ))
([ffaa30dffaa30ddc4#8128 ](https://github.com/n8n-io/n8n/issues/8128 ))
([21788d921788d9153#8164 ](https://github.com/n8n-io/n8n/issues/8164 ))
([ea7e76fea7e76fa3b#8060 ](https://github.com/n8n-io/n8n/issues/8060 ))
([ef3a577ef3a57719e#8126 ](https://github.com/n8n-io/n8n/issues/8126 ))
([c83d9f4c83d9f45ba#8178 ](https://github.com/n8n-io/n8n/issues/8178 ))
([cf7f668cf7f6688ba#8114 ](https://github.com/n8n-io/n8n/issues/8114 ))
([711fa2b711fa2b925#8196 ](https://github.com/n8n-io/n8n/issues/8196 ))
([d01e42ad01e42a2aa#8198 ](https://github.com/n8n-io/n8n/issues/8198 ))
([5c078f15c078f1b3d#8116 ](https://github.com/n8n-io/n8n/issues/8116 ))
([e928210e928210ccd#8118 ](https://github.com/n8n-io/n8n/issues/8118 ))
([39e45d839e45d8b92#8173 ](https://github.com/n8n-io/n8n/issues/8173 ))
([405e267405e26757e#8190 ](https://github.com/n8n-io/n8n/issues/8190 ))
([11cda4111cda41214#8200 ](https://github.com/n8n-io/n8n/issues/8200 ))
([3b6ae2d3b6ae2d0a5#8154 ](https://github.com/n8n-io/n8n/issues/8154 ))
([8e873ca8e873ca2f3#8153 ](https://github.com/n8n-io/n8n/issues/8153 ))
([e94b8a6e94b8a6c30#8129 ](https://github.com/n8n-io/n8n/issues/8129 ))
([a169b74a169b74062#8185 ](https://github.com/n8n-io/n8n/issues/8185 ))
([17a4e2e17a4e2ea80#8109 ](https://github.com/n8n-io/n8n/issues/8109 ))
([e9c7fd7e9c7fd7397#7708 ](https://github.com/n8n-io/n8n/issues/7708 ))
([bec0faebec0faed9e#8144 ](https://github.com/n8n-io/n8n/issues/8144 ))
([e126ed7e126ed74f3#7651 ](https://github.com/n8n-io/n8n/issues/7651 ))
([5e16dd45e16dd4ab4#8104 ](https://github.com/n8n-io/n8n/issues/8104 ))
([01e9a7901e9a79238#8097 ](https://github.com/n8n-io/n8n/issues/8097 ))
([3a881be3a881be6c2#8124 ](https://github.com/n8n-io/n8n/issues/8124 ))
([ab74badab74bade05#8088 ](https://github.com/n8n-io/n8n/issues/8088 ))
([517b050517b050d0a#8150 ](https://github.com/n8n-io/n8n/issues/8150 ))
([518a99e518a99e528#8080 ](https://github.com/n8n-io/n8n/issues/8080 ))
([66460f666460f66b0#8199 ](https://github.com/n8n-io/n8n/issues/8199 ))
([65c8e1265c8e12b96
2024-01-03 13:41:28 +01:00
कारतोफ्फेलस्क्रिप्ट™
cfe9525dd4
fix(core): Better input validation for the changeRole endpoint ( #8189 )
...
also refactored the code to
1. stop passing around `scope === 'global'`, since this code can be used
only for changing globalRole.
2. leak less details when input validation fails.
## Review / Merge checklist
- [x] PR title and summary are descriptive
- [x] Tests included
2024-01-03 09:33:35 +01:00
Iván Ovejero
40c1eeeddd
refactor(core): Continue moving typeorm operators to repositories (no-changelog) ( #8186 )
...
Follow-up to: #8163
2024-01-02 17:53:24 +01:00
Tomi Turtiainen
e126ed74f3
feat(core): Add user.profile.beforeUpdate hook ( #8144 )
...
Add `user.profile.beforeUpdate` hook so we can prevent user email change
if it overlaps with other users email.
2024-01-02 10:15:12 +02:00
Iván Ovejero
ece48d6a13
refactor(core): Unify workflow controllers (no-changelog) ( #8175 )
...
Combine EE workflows controller into main workflows controller,
protecting paid functionality behind feature flag checks.
2023-12-29 14:23:58 +01:00
Iván Ovejero
4bad43dd66
refactor(core): Move typeorm operators from WaitTracker to ExecutionRepository (no-changelog) ( #8163 )
...
Follow-up to: #8145
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-12-28 19:22:09 +01:00
Iván Ovejero
e418d42450
refactor(core): Move typeorm operators from various sources into repositories (no-changelog) ( #8174 )
...
Follow-up to: #8165
2023-12-28 13:14:10 +01:00
कारतोफ्फेलस्क्रिप्ट™
c84d3c3bbf
refactor(core): Extract ActiveWebhooks out of ActiveWorkflowRunner (no-changelog) ( #8171 )
...
## Summary
This PR continues refactoring webhooks code for better modularity.
Continued from #8069 to bring back `ActiveWebhooks`, but this time
actually handling active webhook calls in this class.
## Review / Merge checklist
- [x] PR title and summary are descriptive
2023-12-28 10:04:32 +01:00
Iván Ovejero
639afcd7a5
refactor(core): Simplify state in test webhooks (no-changelog) ( #8155 )
...
This PR simplifies state in test webhooks so that it can be cached
easily. Caching this state will allow us to start using Redis for manual
webhooks, to support manual webhooks to work in multi-main setup.
- [x] Convert `workflowWebhooks` to a getter - no need to optimize for
deactivation
- [x] Remove array from value in `TestWebhooks.webhookUrls`
- [x] Consolidate `webhookUrls` and `registeredWebhooks`
2023-12-28 09:28:12 +01:00
Iván Ovejero
0e582594ea
refactor(core): Move more typeorm operators to UserRepository (no-changelog) ( #8165 )
...
Follow-up to: #8163
2023-12-28 09:27:47 +01:00
Iván Ovejero
5aee7a1d48
refactor(core): Move typeorm operators from SourceControlExportService to repositories (no-changelog) ( #8168 )
...
Follow-up to: #8165
2023-12-28 09:27:38 +01:00
Jan Oberhauser
ea7e76fa3b
fix(core): Use pinned data only for manual mode ( #8164 )
...
## Summary
Fixes the issue that pinned data gets also used for production executions.
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-12-27 18:22:33 +01:00
Iván Ovejero
2c6ffb0153
fix(core): Minor improvements to multi-main setup (no-changelog) ( #8012 )
...
- Move webhook, poller and trigger activation logs closer to activation
event
- Enrich response of `/debug/multi-main-setup`
- Ensure workflow updates broadcast activation state changes only if
state changed
- Fix bug on workflow activation after leadership change
- Ensure debug controller is not available in production
---------
Co-authored-by: Omar Ajoue <krynble@gmail.com>
2023-12-27 16:55:01 +01:00
कारतोफ्फेलस्क्रिप्ट™
f69ddcd796
refactor(core): Use Dependency Injection for all Controller classes (no-changelog) ( #8146 )
...
## Review / Merge checklist
- [x] PR title and summary are descriptive
2023-12-27 11:50:43 +01:00
Jan Oberhauser
fa8bd8b9eb
fix(core): Fix issue that pinnedData is not used with Test-Webhooks ( #8123 )
...
## Summary
When a workflow gets started via a Test-Webhook the pinned data does get
ignored and the nodes executed anyway.
## Related tickets and issues
> Include links to **Linear ticket** or Github issue or Community forum
post. Important in order to close *automatically* and provide context to
reviewers.
## Review / Merge checklist
- [x] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [X] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
> A feature is not complete without tests.
---------
Co-authored-by: Mutasem Aldmour <mutasem@n8n.io>
2023-12-27 10:51:53 +01:00
Iván Ovejero
7b26a7a621
refactor(core): Move typeorm operators from PruningService to ExecutionRepository (no-changelog) ( #8145 )
...
Follow-up to https://github.com/n8n-io/n8n/pull/8143
2023-12-22 17:49:15 +01:00
Iván Ovejero
a59d78de18
refactor(core): Move more typeorm operators to repositories (no-changelog) ( #8143 )
...
Follow-up to #8139
2023-12-22 16:20:30 +01:00
कारतोफ्फेलस्क्रिप्ट™
4007163651
refactor(core): Delete unused code, and fix typings in tests (no-changelog) ( #8142 )
2023-12-22 15:41:29 +01:00
कारतोफ्फेलस्क्रिप्ट™
baee47a276
refactor(core): Move all base URLs to UrlService (no-changelog) ( #8141 )
...
This change kept coming up in #6713 , #7773 , and #8135 .
So this PR moves the existing code without actually changing anything,
to help get rid of some of the circular dependencies.
## Review / Merge checklist
- [x] PR title and summary are descriptive.
2023-12-22 15:19:50 +01:00
Iván Ovejero
c6dd935895
refactor(core): Move some typeorm operators to repositories (no-changelog) ( #8139 )
...
Moving some persistence logic to repositories to reduce circular
dependencies.
2023-12-22 13:35:23 +01:00
Tomi Turtiainen
3a881be6c2
feat(core): Unify application components shutdown ( #8097 )
...
## Summary
Add `ShutdownService` and `OnShutdown` decorator for more unified way to
shutdown different components. Use this new way in the following
components:
- HTTP(S) server
- Pruning service
- Push connection
- License
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-12-22 12:39:58 +02:00
कारतोफ्फेलस्क्रिप्ट™
c158ca2471
refactor(core): Upgrade more dependencies to remove axios 0.x (no-changelog) ( #8105 )
...
Had to [fork localtunnel](https://github.com/n8n-io/localtunnel ) to get
the axios upgrade, since localtunnel doesn't seem to be actively maintained.
2023-12-22 11:39:20 +01:00
कारतोफ्फेलस्क्रिप्ट™
021add0f39
refactor(core): Move active workflows endpoints to a decorated controller class (no-changelog) ( #8101 )
...
This is a continuation of migrating all rest endpoints to decorated controller classes
2023-12-22 11:28:42 +01:00
कारतोफ्फेलस्क्रिप्ट™
21788d9153
fix(core): Remove circular dependency in WorkflowService and ActiveWorkflowRunner ( #8128 )
...
## Summary
A circular dependency between `WorkflowService` and
`ActiveWorkflowRunner` is sometimes causing `this.activeWorkflowRunner`
to be `undefined` in `WorkflowService`.
Breaking this circular dependency should hopefully fix this issue.
## Related tickets and issues
#8122
## Review / Merge checklist
- [x] PR title and summary are descriptive
- [ ] Tests included
2023-12-21 17:37:08 +01:00
कारतोफ्फेलस्क्रिप्ट™
ffaa30ddc4
fix(core): Handle empty executions table in pruning in migrations ( #8121 )
...
In case someone manually prunes their executions table before upgrading
to 1.x, `MigrateIntegerKeysToString` should gracefully handle that,
instead of crashing the application.
## Review / Merge checklist
- [x] PR title and summary are descriptive
2023-12-21 14:52:42 +01:00
Iván Ovejero
9ac8825a67
refactor(core): Move error execution creation to execution service (no-changelog) ( #8006 )
...
Continue breaking down legacy helpers.
Note: `getUserById` is unused.
2023-12-21 14:15:46 +01:00
Iván Ovejero
d1b2affd2c
ci: Add lint rule no-dynamic-import-template (no-changelog) ( #8089 )
...
Follow-up to: https://github.com/n8n-io/n8n/pull/8086
`tsc-alias` as of 1.8.7 is unable to resolve template strings in dynamic
imports. Since the module name mapper in Jest is able to, this issue is
hard to detect, hence the new lint rule `no-dynamic-import-template`.
This is for now specific to `@/` in the `cli` package - we can
generalize later if needed. Ideally we should contribute a fix upstream
when we have more time.
<img width="940" alt="Capture 2023-12-19 at 12 39 55@2x"
src="https://github.com/n8n-io/n8n/assets/44588767/78d4a277-ccff-455c-8610-d1bba39d93f2 ">
2023-12-21 14:15:37 +01:00
कारतोफ्फेलस्क्रिप्ट™
01e9a79238
feat(core): Remove discontinued crypto-js ( #8104 )
...
Since crypto-js was
[discontinued](1da3dabf93https://github.com/n8n-io/n8n/pull/7556 ).
However I decided back then to not remove crypto-js just yet in
expressions, as I wanted to use `SubtleCrypto`. Unfortunately for that
to work, we'd need to make expressions async.
So, to get rid of `crypto-js`, I propose this interim solution.
## Related tickets and issues
N8N-7020
## Review / Merge checklist
- [x] PR title and summary are descriptive
- [x] Tests included
2023-12-21 14:13:02 +01:00
github-actions[bot]
b67b5ae6b2
🚀 Release 1.22.0 ( #8115 )
...
#
[1.22.0](https://github.com/n8n-io/n8n/compare/n8n@1.21.0...n8n@1.22.0 )
(2023-12-21)
### Bug Fixes
* **core:** Close db connection gracefully when exiting
([#8045 ](https://github.com/n8n-io/n8n/pull/8045 ))
([e69707ee69707efd4#8050 ](https://github.com/n8n-io/n8n/pull/8050 ))
([4cae9764cae976a3b#8007 ](https://github.com/n8n-io/n8n/pull/8007 ))
([8e6b9518e6b951a76#8047 ](https://github.com/n8n-io/n8n/pull/8047 ))
([6ae2f5e6ae2f5efea#8046 ](https://github.com/n8n-io/n8n/pull/8046 ))
([67bd8ad67bd8ad698#8025 ](https://github.com/n8n-io/n8n/pull/8025 ))
([53c0b4953c0b49d15#8117 ](https://github.com/n8n-io/n8n/pull/8117 ))
([bba9576bba95761e2#8043 ](https://github.com/n8n-io/n8n/pull/8043 ))
([989888d989888d9bc#8031 ](https://github.com/n8n-io/n8n/pull/8031 ))
([c5e6ba8c5e6ba8cdd#8086 ](https://github.com/n8n-io/n8n/pull/8086 ))
([785bf99785bf9974e#8082 ](https://github.com/n8n-io/n8n/pull/8082 ))
([5ffff1b5ffff1bb22#8023 ](https://github.com/n8n-io/n8n/pull/8023 ))
([329e5bf329e5bf9ee#8053 ](https://github.com/n8n-io/n8n/pull/8053 ))
([2689c372689c37e87#7983 ](https://github.com/n8n-io/n8n/pull/7983 ))
([fcb8b91fcb8b91f37#8009 ](https://github.com/n8n-io/n8n/pull/8009 ))
([1d1cb0d1d1cb0d3c5#8103 ](https://github.com/n8n-io/n8n/pull/8103 ))
([4b869264b86926752#8024 ](https://github.com/n8n-io/n8n/pull/8024 ))
([8df49e18df49e134d#8020 ](https://github.com/n8n-io/n8n/pull/8020 ))
([b29b4d4b29b4d442b#8005 ](https://github.com/n8n-io/n8n/pull/8005 ))
([e3c363de3c363d72c#8037 ](https://github.com/n8n-io/n8n/pull/8037 ))
([63a6e7e63a6e7e034#8017 ](https://github.com/n8n-io/n8n/pull/8017 ))
([19438571943857231#8030 ](https://github.com/n8n-io/n8n/pull/8030 ))
([5b7ea165b7ea16d9a#7713 ](https://github.com/n8n-io/n8n/pull/7713 ))
([64eb9bb64eb9bbc36#8113 ](https://github.com/n8n-io/n8n/pull/8113 ))
([7806a657806a65229#8049 ](https://github.com/n8n-io/n8n/pull/8049 ))
([439a22d439a22d68f#8068 ](https://github.com/n8n-io/n8n/pull/8068 ))
([614f488614f488386#8042 ](https://github.com/n8n-io/n8n/pull/8042 ))
([36a923c36a923cf7b#8052 ](https://github.com/n8n-io/n8n/pull/8052 ))
([edfa784edfa78414d#8096 ](https://github.com/n8n-io/n8n/pull/8096 ))
([9d22c7a](9d22c7a278#8100 ](https://github.com/n8n-io/n8n/pull/8100 ))
([19b7f1f19b7f1ffb1#8016 ](https://github.com/n8n-io/n8n/pull/8016 ))
([3d530523d530522f8#8093 ](https://github.com/n8n-io/n8n/pull/8093 ))
([32d397e32d397eff3#8022 ](https://github.com/n8n-io/n8n/pull/8022 ))
([b780436b780436a6b
2023-12-21 13:51:24 +01:00
Omar Ajoue
5ffff1bb22
fix: Stop binary data restoration from preventing execution from finishing ( #8082 )
...
In the case of a filesystem failure to rename the binary files as part
of the execution's cleanup process, the execution would fail to be saved
and would never finish. This catch prevents it.
## Summary
Whenever an execution is wrapping u to save the data, if it uses binary
data n8n will try to find possibly misallocated files and place them in
the right folder. If this process fails, the execution fails to finish.
Given the execution has already finished at this point, and we cannot
handle the binary data errors more gracefully, all we can do at this
point is log the message as it's a filesystem issue. The rest of the
execution saving process should remain as normal.
## Related tickets and issues
https://linear.app/n8n/issue/HELP-430
## Review / Merge checklist
- [ ] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
> A feature is not complete without tests.
---------
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
2023-12-21 09:40:39 +00:00
Iván Ovejero
edfa78414d
feat(editor): Finalize workers view ( #8052 )
...
https://linear.app/n8n/issue/PAY-1065
2023-12-20 17:49:14 +01:00
