mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2025-01-08 04:17:29 -08:00
Code Issues Actions 6 Packages Projects Releases Wiki Activity
12402 commits 273 branches 448 tags 665 MiB
Commit graph

12402 commits

This branch
This branch
All branches
Author SHA1 Message Date
Alex Greenbank ad77987bdc
Merge pull request #13498 from prometheus/alexg-content-negotiation-2 
storage/remote: remote write 2.0 content negotiation draft
 2024-04-04 15:16:30 +01:00
Alex Greenbank ae9d2a772a latest tweaks 
Signed-off-by: Alex Greenbank <alex.greenbank@grafana.com>
 2024-04-04 13:27:28 +00:00
Alex Greenbank 377fc5a625 Latest updates to review comments 
Signed-off-by: Alex Greenbank <alex.greenbank@grafana.com>
 2024-04-04 12:59:54 +00:00
Alex Greenbank 4a758f1685 Latest updates to review comments 
Signed-off-by: Alex Greenbank <alex.greenbank@grafana.com>
 2024-04-04 12:56:40 +00:00
Alex Greenbank f73b77d4e3
Update storage/remote/client.go 
Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com>
Signed-off-by: Alex Greenbank <alex.greenbank@grafana.com>
 2024-04-02 15:55:01 +01:00
Alex Greenbank 7b40203302 Changes based on review comments 
Signed-off-by: Alex Greenbank <alex.greenbank@grafana.com>
 2024-04-02 14:51:39 +00:00
Alex Greenbank 95f1ee61cf Fix todos around 405 HEAD handling 
Signed-off-by: Alex Greenbank <alex.greenbank@grafana.com>
 2024-03-21 15:41:39 +00:00
Alex Greenbank e5c5ef1a2d Almost done with lint 
Signed-off-by: Alex Greenbank <alex.greenbank@grafana.com>
 2024-03-20 16:14:14 +00:00
Alex Greenbank ca20eb9f32 Fix another test race 
Signed-off-by: Alex Greenbank <alex.greenbank@grafana.com>
 2024-03-19 19:03:22 +00:00
Alex Greenbank b884b15f39 Fix race in test 
Signed-off-by: Alex Greenbank <alex.greenbank@grafana.com>
 2024-03-19 18:28:20 +00:00
Alex Greenbank 766d947ba5 Lint 
Signed-off-by: Alex Greenbank <alex.greenbank@grafana.com>
 2024-03-19 18:06:48 +00:00
Alex Greenbank 04929dc610 first draft of content negotiation 
Signed-off-by: Alex Greenbank <alex.greenbank@grafana.com>
 2024-03-19 17:16:20 +00:00
Bartlomiej Plotka 0eae349b78
prw2.0: Added support for "custom" layouts for native histogram proto (#13558) 
* prw2.0: Added support for "custom" layouts for native histogram.

Result of the discussions:
* https://github.com/prometheus/prometheus/issues/13475#issuecomment-1931496924
* https://cloud-native.slack.com/archives/C02KR205UMU/p1707301006347199

Signed-off-by: bwplotka <bwplotka@gmail.com>

* prw2.0: Added support for "custom" layouts for native histogram.

Result of the discussions:
* https://github.com/prometheus/prometheus/issues/13475#issuecomment-1931496924
* https://cloud-native.slack.com/archives/C02KR205UMU/p1707301006347199

Signed-off-by: bwplotka <bwplotka@gmail.com>

# Conflicts:
#	prompb/write/v2/types.pb.go

* Update prompb/write/v2/types.proto

Co-authored-by: George Krajcsovits <krajorama@users.noreply.github.com>
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>

* Addressed comments, fixed test.

Signed-off-by: bwplotka <bwplotka@gmail.com>

---------

Signed-off-by: bwplotka <bwplotka@gmail.com>
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
Co-authored-by: George Krajcsovits <krajorama@users.noreply.github.com>
 2024-03-14 13:47:25 +00:00
Bartlomiej Plotka ae414a3e6b
Added commmentary to RW 2.0 protocol for easier adoption and explicit semantics. (#13502) 
* Added commmentary to RW 2.0 protocol for easier adoption and explicit semantics.

Signed-off-by: bwplotka <bwplotka@gmail.com>

* Apply suggestions from code review

Co-authored-by: Nico Pazos <32206519+npazosmendez@users.noreply.github.com>
Signed-off-by: Callum Styan <callumstyan@gmail.com>

---------

Signed-off-by: bwplotka <bwplotka@gmail.com>
Signed-off-by: Callum Styan <callumstyan@gmail.com>
Co-authored-by: Callum Styan <callumstyan@gmail.com>
Co-authored-by: Nico Pazos <32206519+npazosmendez@users.noreply.github.com>
 2024-02-21 18:56:02 -08:00
Nico Pazos 6d86554cf3
Merge pull request #13623 from prometheus/njpm/rw2-sync-main 
remote write 2.0: sync with `main` branch
 2024-02-21 11:36:10 -03:00
Nicolás Pazos 5644522b7c go mod tidy 
Signed-off-by: Nicolás Pazos <npazosmendez@gmail.com>
 2024-02-21 10:56:46 -03:00
Nicolás Pazos 84a83f5c82 Merge branch 'main' into njpm/rw2-sync-main 
Signed-off-by: Nicolás Pazos <npazosmendez@gmail.com>
 2024-02-21 10:50:14 -03:00
Bryan Boreham aba0071480
Merge pull request #13589 from bboreham/trace_id 
Standardise exemplar label as "trace_id"
 2024-02-19 09:34:04 +00:00
Björn Rabenstein ac10cd4d99
Merge pull request #13271 from ywwg/owilliams/utf8 
UTF-8: Add partial support for parsing UTF-8 metric and label names
 2024-02-16 11:42:55 +01:00
Owen Williams a28d7865ad UTF-8: Add support for parsing UTF8 metric and label names 
This adds support for the new grammar of `{"metric_name", "l1"="val"}` to promql and some of the exposition formats.
This grammar will also be valid for non-UTF-8 names.
UTF-8 names will not be considered valid unless model.NameValidationScheme is changed.

This does not update the go expfmt parser in text_parse.go, which will be addressed by https://github.com/prometheus/common/issues/554/.

Part of https://github.com/prometheus/prometheus/issues/13095

Signed-off-by: Owen Williams <owen.williams@grafana.com>
 2024-02-15 14:34:37 -05:00
Bryan Boreham c0e36e6bb3 Standardise exemplar label as "trace_id" 
This is consistent with the OpenTelemetry standard, and an example in OpenMetrics.

https://github.com/open-telemetry/opentelemetry-specification/blob/89aa01348139/specification/metrics/data-model.md#exemplars
https://github.com/OpenObservability/OpenMetrics/blob/138654493130/specification/OpenMetrics.md#exemplars-1

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
 2024-02-15 14:20:08 +00:00
Bryan Boreham d595f5a9b1
Merge pull request #13585 from prometheus/metalmatze-bufbuild 
Update `go get buf.build` in README.md
 2024-02-15 14:08:18 +00:00
Matthias Loibl 0b38a5b774
Update go get buf.build in README.md 
The old import path stopped working. 

```
go get go.buf.build/protocolbuffers/go/prometheus/prometheus
go: unrecognized import path "go.buf.build/protocolbuffers/go/prometheus/prometheus": https fetch: Get "https://go.buf.build/protocolbuffers/go/prometheus/prometheus?go-get=1": dial tcp: lookup go.buf.build on 192.168.2.1:53: no such host
```

We should instead tell users to use the new import paths. 

Signed-off-by: Matthias Loibl <mail@matthiasloibl.com>
 2024-02-15 12:12:36 +01:00
Ziqi Zhao a93859a52f
Prometheus support parse exemplars from native histogram (#13488) 
scrape: support parsing exemplars from native histogram

---------

Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
Signed-off-by: Björn Rabenstein <github@rabenste.in>
Co-authored-by: Björn Rabenstein <github@rabenste.in>
 2024-02-14 17:24:40 +01:00
Bryan Boreham ff6c83269c
Merge pull request #13452 from bboreham/go-cmp 
Tests: Use DeepEqual replacement using go-cmp, which is more flexible
 2024-02-12 15:40:08 +01:00
Björn Rabenstein 1efca80956
Merge pull request #13559 from prometheus/beorn7/promql 
promql: Fix wrongly scoped range vectors
 2024-02-12 14:34:33 +01:00
pschou b66b0a5288
docs: improve "Querying Prometheus" readability (#8492) 
Signed-off-by: schou <pschou@users.noreply.github.com>
Co-authored-by: George Krajcsovits <krajorama@users.noreply.github.com>
Co-authored-by: Bryan Boreham <bjboreham@gmail.com>
 2024-02-09 17:37:14 +00:00
Bryan Boreham 12cac5bd5c tsdb tests: use go-cmp instead of DeepEquals 
Also one simpler call checking nil.

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
 2024-02-08 19:32:33 +00:00
Bryan Boreham 17f48f2b3b Tests: use replacement DeepEquals in more places 
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
 2024-02-08 19:32:33 +00:00
Bryan Boreham d0dee51aac scrape tests: check NaN values directly 
Normally, a NaN value is never equal to any other value. Compare sample
values via `Float64bits` so that NaN values which are exactly the same
will compare equal.

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
 2024-02-08 19:30:20 +00:00
Bryan Boreham 5a6c8f9c15 promtool: use go-cmp instead of DeepEqual 
go-cmp allows more control over unexported fields and implementation
details.

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
 2024-02-08 19:30:20 +00:00
Bryan Boreham 39af788dbd Tests: use replacement DeepEquals using go-cmp 
Use DeepEqual replacement using go-cmp, which is more flexible.

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
 2024-02-08 19:30:20 +00:00
Bryan Boreham d77c30102e utils: add DeepEqual replacement using go-cmp 
go-cmp allows control over how unexported fields and implementation
details are handled.

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
 2024-02-08 19:30:20 +00:00
beorn7 553d92affd model/labels: Fix new lint warning in test 
Signed-off-by: beorn7 <beorn@grafana.com>
 2024-02-07 18:12:26 +01:00
beorn7 86d7618d84 promql: Fix wrongly scoped range vectors 
Fixes #11708.

If a range vector is fixen in time with the @ modifier, it gets still
moved around for different steps in a range query. Since no additional
points are retrieved from the TSDB, this leads to steadily emptying
the range, leading to the weird behavior described in isse #11708.

This only happens for functions listed in `AtModifierUnsafeFunctions`,
and the only of those that takes a range vector is `predict_linear`,
which is the reason why we see it only for this particular function.

Signed-off-by: beorn7 <beorn@grafana.com>
 2024-02-07 18:07:51 +01:00
beorn7 384ab025e0 promql: Expose issue #11708 
The shorter range in the test makes early points drop out of the range
in range queries, exposing the issue.

Signed-off-by: beorn7 <beorn@grafana.com>
 2024-02-07 18:06:05 +01:00
Bryan Boreham 8655fe5401
Merge pull request #13491 from bboreham/faster-store-series 
storage/remote: speed up StoreSeries by re-using labels.Builder
 2024-02-06 17:16:32 +01:00
Bryan Boreham 3ce816fa3b
Merge pull request #13492 from bboreham/no-labelstrings-intern 
labels: make InternStrings a no-op for stringlabels version
 2024-02-06 17:15:10 +01:00
Arve Knudsen 0853e52f4e
util/runtime: Ignore nolintlint failure on OSX (#13546) 
util/runtime: Make nolintlint ignore unconvert linter directive

---------

Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
 2024-02-06 13:53:37 +01:00
Björn Rabenstein 0a3fd8d958
Merge pull request #13543 from aknuds1/arve/portable-genproto 
scripts/genproto.sh: Support OSX sed
 2024-02-06 13:53:01 +01:00
Bryan Boreham 87e4284c99
Merge pull request #13545 from aknuds1/arve/golangci-lint-arm64 
Makefile: enable golangci-lint on ARM64
 2024-02-06 11:26:48 +01:00
Arve Knudsen 7d7787f250 Makefile: Support golangci-lint on ARM64 
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
 2024-02-06 13:51:16 +04:00
Arve Knudsen e43a1d546a scripts/genproto.sh: Support OSX sed 
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
 2024-02-06 12:34:03 +04:00
Bryan Boreham 6005ac6f9d
Merge pull request #9311 from Creatone/creatone/use-testify-3 
tests: Move from t.Errorf and others. (Part 3)
 2024-02-05 18:48:59 +01:00
Peter Štibraný e2b9cfeeeb
Enforce chunks ordering when writing index. (#8085) 
Document conditions on chunks. Add check on chunk time ordering.

Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
 2024-02-04 16:31:49 +01:00
Bryan Boreham 98c4889029
Merge pull request #9298 from Creatone/creatone/use-testify 
tests: Move from t.Errorf and others.
 2024-02-04 16:27:57 +01:00
Bryan Boreham 857138d3ce review feedback 
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
 2024-02-04 15:52:50 +01:00
Bryan Boreham 41f3eeb048
Merge pull request #13497 from captncraig/cmp_signedheaders 
storage/remote: apply custom headers before sigv4 transport
 2024-02-04 14:46:14 +01:00
Matthias Loibl 805d51f6d3
Merge pull request #13505 from wbollock/fix/PrometheusNotIngestingSamples_label_matching 
mixin: PrometheusNotIngestingSamples label matching
 2024-02-03 11:53:18 +00:00
Callum Styan 552620a8ec
remote write 2.0 - follow up improvements (#13478) 
* move remote write proto version config from a remote storage config to a
per remote write configuration option

Signed-off-by: Callum Styan <callumstyan@gmail.com>

* rename scrape config for metadata, fix 2.0 header var name/value (was
1.1), and more clean up

Signed-off-by: Callum Styan <callumstyan@gmail.com>

* address review comments, mostly lint fixes

Signed-off-by: Callum Styan <callumstyan@gmail.com>

* another lint fix

Signed-off-by: Callum Styan <callumstyan@gmail.com>

* lint imports

Signed-off-by: Callum Styan <callumstyan@gmail.com>

---------

Signed-off-by: Callum Styan <callumstyan@gmail.com>
 2024-02-02 15:10:40 -08:00