Tomi Turtiainen
008fd5a917
test: Add e2e tests for cred setup on workflow editor (no-changelog) ( #8245 )
...
## Summary
Follow-up to https://github.com/n8n-io/n8n/pull/8240
Adds e2e tests for the template credential setup in workflow editor
## Related tickets and issues
https://linear.app/n8n/issue/ADO-1463/feature-enable-users-to-close-and-re-open-the-setup
2024-01-08 11:35:18 +02:00
Tomi Turtiainen
3cf6704dbb
feat: Enable cred setup for workflows created from templates (no-changelog) ( #8240 )
...
## Summary
Enable users to open credential setup for workflows that have been
created from templates if they skip it.
Next steps (will be their own PRs):
- Add telemetry events
- Add e2e test
- Hide the button when user sets up all the credentials
- Change the feature flag to a new one
## Related tickets and issues
https://linear.app/n8n/issue/ADO-1637/feature-support-template-credential-setup-for-http-request-nodes-that
2024-01-05 18:07:57 +02:00
Ricardo Espinoza
df5d07bcb8
feat(editor): Update copy: Execute --> Test ( #8137 )
...
## Summary
Title self explanatory
## Related tickets and issues
https://linear.app/n8n/issue/ADO-129/update-copy-execute-test
## Review / Merge checklist
- [x] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
2024-01-05 10:23:51 -05:00
Tomi Turtiainen
8a78ae1739
fix: Add template id to workflows created from templates (no-changelog) ( #8226 )
...
In #8088 template ID was added to workflow metadata, but it was missing
from workflows that were created using the template credential setup.
This fixes that.
2024-01-05 10:36:59 +02:00
Elias Meire
071e6d6b6e
feat(editor): Add fullscreen view to code editor ( #8084 )
...
## Summary
<img width="1240" alt="image"
src="https://github.com/n8n-io/n8n/assets/8850410/2819f4ce-c343-431a-8a88-a1bc9c4b572a ">
<img width="2649" alt="image"
src="https://github.com/n8n-io/n8n/assets/8850410/36862aaf-cc4c-4668-bdc8-cf5a6f00babe ">
1. Add code node and open it
3. Click the fullscreen button in the bottom right
4. A fullscreen dialog should appear and allow editing the code
5. Changes made in the fullscreen dialog should be applied to the
original code editor when closed
It should work the same way for HTML/SQL/JSON editors
⚠️ Modal layout was updated so that modals/dialogs are centered, try to
test some modals
## Related tickets and issues
https://linear.app/n8n/issue/NODE-1009/add-fullscreen-view-to-code-node
## Review / Merge checklist
- [ ] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
> A feature is not complete without tests.
---------
Co-authored-by: Giulio Andreini <andreini@netseven.it>
2024-01-04 17:23:24 +01:00
Tomi Turtiainen
cd3f5b5b1f
fix: Fix template credential setup for nodes that dont have credentials ( #8208 )
...
Fix template credential setup for templates whose workflow includes
nodes that require credentials but the workflow definition does not have
them defined. Like for example
https://n8n.io/workflows/1344-save-email-attachments-to-nextcloud/
2024-01-04 10:21:36 +02:00
Michael Kret
5e16dd4ab4
feat(core): Improvements/overhaul for nodes working with binary data ( #7651 )
...
Github issue / Community forum post (link here to close automatically):
---------
Co-authored-by: Giulio Andreini <andreini@netseven.it>
Co-authored-by: Marcus <marcus@n8n.io>
2024-01-03 13:08:16 +02:00
Milorad FIlipović
d01e42a2aa
fix(editor): Fix templates view layout ( #8196 )
...
## Summary
Recent changes to the template info carousel component broke the layout
of the templates way so it had excessive width when templates categories
carousel was visible.
This PR reverts disables CSS that held it in place.
## Related tickets and issues
Fixes ADO-1628
## Review / Merge checklist
- [ ] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
> A feature is not complete without tests.
2024-01-02 14:13:09 +01:00
कारतोफ्फेलस्क्रिप्ट™
18e476a26a
ci: Fix a flaky e2e test in 5-ndv.cy.ts (no-changelog) ( #8177 )
2023-12-28 15:13:59 +01:00
Jan Oberhauser
fa8bd8b9eb
fix(core): Fix issue that pinnedData is not used with Test-Webhooks ( #8123 )
...
## Summary
When a workflow gets started via a Test-Webhook the pinned data does get
ignored and the nodes executed anyway.
## Related tickets and issues
> Include links to **Linear ticket** or Github issue or Community forum
post. Important in order to close *automatically* and provide context to
reviewers.
## Review / Merge checklist
- [x] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [X] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
> A feature is not complete without tests.
---------
Co-authored-by: Mutasem Aldmour <mutasem@n8n.io>
2023-12-27 10:51:53 +01:00
Milorad FIlipović
517b050d0a
feat(editor): Add template Id to workflow metadata ( #8088 )
...
## Summary
Adding a link between the workflow and the template it originated from
by saving `templateId` in the workflow metadata
## Related tickets and issues
ADO-1537
## Review / Merge checklist
- [x] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [x] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
> A feature is not complete without tests.
2023-12-22 15:07:05 +01:00
Mutasem Aldmour
c83d9f45ba
fix(editor): Avoid sanitizing output to search node data ( #8126 )
...
## Summary
In search feature, output sanitization was added to support `<mark` tag
in output panel to highlight searched text. This removes any html like
data in the input/output panel..
This PR removes sanitization while keeping text highlights..
## Related tickets and issues
https://community.n8n.io/t/n8n-output/33997
https://community.n8n.io/t/html-tags-in-editor-rendered/34240
https://github.com/n8n-io/n8n/issues/8081
https://linear.app/n8n/issue/ADO-1594/node-output-view-not-consistent
https://linear.app/n8n/issue/ADO-1597/bug-xml-display-issue
## Review / Merge checklist
- [X] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
> A feature is not complete without tests.
2023-12-22 15:03:40 +01:00
Milorad FIlipović
ab74bade05
feat(editor): Add node execution status indicator to output panel ( #8124 )
...
## Summary
Adding node execution status indicator to the output panel ([Figma
HiFi](https://www.figma.com/file/iUduV3M4W5wZT7Gw5vgDn1/NDV-output-pane-success-state )).
## Related tickets and issues
Fixes ADO-480
## Review / Merge checklist
- [x] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [x] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
> A feature is not complete without tests.
2023-12-22 12:50:36 +01:00
कारतोफ्फेलस्क्रिप्ट™
021add0f39
refactor(core): Move active workflows endpoints to a decorated controller class (no-changelog) ( #8101 )
...
This is a continuation of migrating all rest endpoints to decorated controller classes
2023-12-22 11:28:42 +01:00
Milorad FIlipović
39e45d8b92
fix(editor): Prevent canvas undo/redo when NDV is open ( #8118 )
...
## Summary
Preventing canvas undo/redo while NDV or any modal is open. We already
had a NDV open check in place but looks like it was broken by unreactive
ref inside `useHistoryHelper` composable.
This PR fixes this by using store getter directly inside the helper
method and adds modal open check.
## Related tickets and issues
Fixes ADO-657
## Review / Merge checklist
- [ ] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
> A feature is not complete without tests.
2023-12-22 08:42:53 +01:00
Milorad FIlipović
711fa2b925
fix(editor): Fix operation change failing in certain conditions ( #8114 )
...
## Summary
This PR handles the case when there are multiple parameters with the
same name but different `options` and `displayOptions`. In this case, if
one of such fields is set, changing the dependent parameter value so the
other should be shown causes an error in case their options are not
compatible (this
[check](7806a65229/packages/workflow/src/NodeHelpers.ts (L786)https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [x] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
> A feature is not complete without tests.
2023-12-22 08:41:20 +01:00
Ricardo Espinoza
e9c7fd7397
fix: Show public API upgrade CTA when feature is not enabled ( #8109 )
...
## Summary
> Describe what the PR does and how to test. Photos and videos are
recommended.
Shows the public API upgrade CTA when the feature is not enabled. Now
trialing users in cloud would see the API on the settings menu and can
upgrade from there.
When public API feature disabled:
<img width="1863" alt="image"
src="https://github.com/n8n-io/n8n/assets/16496553/a9052f6b-151f-4ebb-80df-5ff2fa643e85 ">
When public API feature enabled with no API key:
<img width="1861" alt="image"
src="https://github.com/n8n-io/n8n/assets/16496553/fdfe7296-425e-4410-a8cb-f25535bc9df4 ">
When public API feature enabled with API key:
<img width="1423" alt="image"
src="https://github.com/n8n-io/n8n/assets/16496553/a8426cbf-ff73-43c4-8c60-b00274bca46e ">
## Related tickets and issues
[> Include links to **Linear ticket** or Github issue or Community forum
post. Important in order to close *automatically* and provide context to
r](https://linear.app/n8n/issue/ADO-1282/feature-api-page-missing-for-trial-users )eviewers.
## Review / Merge checklist
- [x] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [x] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
> A feature is not complete without tests.
2023-12-21 09:06:54 -05:00
Iván Ovejero
edfa78414d
feat(editor): Finalize workers view ( #8052 )
...
https://linear.app/n8n/issue/PAY-1065
2023-12-20 17:49:14 +01:00
Elias Meire
8df49e134d
fix(editor): Make keyboard shortcuts more strict; don't accept extra Ctrl/Alt/Shift keys ( #8024 )
...
## Summary
Keyboard shortcuts such as Shift+S get triggered even when other keys
(Ctrl/Alt) are pressed, creating conflicts with browser or OS shortcuts.
This PR makes keyboard shortcuts more strict: the exact combination
needs to be pressed, no extra keys allowed.
--> Ctrl+Shift+S will no longer trigger the Shift+S shortcut to add a
sticky note
## Related tickets and issues
https://n8nio.slack.com/archives/C035KBDA917/p1702545933647959
2023-12-20 12:06:49 +01:00
Alex Grozav
fcff34c401
fix(editor): Move versions check to init function and refactor store (no-changelog) ( #8067 )
2023-12-20 12:49:40 +02:00
Mutasem Aldmour
4b86926752
fix(editor): Fix copy/paste issue when switch node is in workflow ( #8103 )
...
## Summary
Fix bug where copy/pasting a node breaks the view. Issue seems to be
that copied workflow does not have Switch node when workflow is
rerendering..
<img width="1942" alt="Screenshot 2023-12-19 at 18 16 23"
src="https://github.com/n8n-io/n8n/assets/4711238/ad53b8ae-3693-4733-8f6b-7bc9e7b9d216 ">
## Related tickets and issues
[Linear ticket
ADO-1504](https://linear.app/n8n/issue/ADO-1504/unwanted-nodes-connections-after-copypaste-of-n8n-form-trigger )
## Review / Merge checklist
- [X] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [x] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
> A feature is not complete without tests.
2023-12-20 10:13:59 +01:00
Milorad FIlipović
36a923cf7b
feat(editor): Add lead enrichment suggestions to workflow list ( #8042 )
...
## Summary
We want to show lead enrichment template suggestions to cloud users that
agreed to this. This PR introduces the front-end part of this feature
- Handoff document
- Figma Hi-fi
- [How to
test](https://linear.app/n8n/issue/ADO-1549/[n8n-fe]-update-workflows-list-page-to-show-fake-door-templates#comment-b6644c99 )
Tests are being worked on in a separate PR
## Related tickets and issues
Fixes ADO-1546
Fixes ADO-1549
Fixes ADO-1604
## Review / Merge checklist
- [ ] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
> A feature is not complete without tests.
---------
Co-authored-by: ricardo <ricardoespinoza105@gmail.com>
2023-12-19 09:10:03 -05:00
Mutasem Aldmour
63a6e7e034
fix(editor): Update image sizes in template description not to be full width always ( #8037 )
...
## Summary
Update image sizes in template description not to be full width always.
## Related tickets and issues
https://linear.app/n8n/issue/ADO-1506/bug-fix-images-in-template-descriptions
## Review / Merge checklist
- [X] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [x] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
> A feature is not complete without tests.
2023-12-18 17:40:00 +01:00
Csaba Tuncsik
329e5bf9ee
fix(editor): Add back credential use permission ( #8023 )
...
## Summary
A shared credential is not selectable in NDV
Aim
If a credential is shared with a user they should be able to select it
in node details view
2023-12-14 13:36:36 +01:00
Csaba Tuncsik
e3c363d72c
fix(editor): Turn off executions list auto-refresh after leaving the page ( #8005 )
...
## Summary
Fixes the bug when users leave the executions page but there is still an
ongoing request for executions.
---------
Co-authored-by: Alex Grozav <alex@grozav.com>
2023-12-14 11:50:00 +01:00
Csaba Tuncsik
b29b4d442b
fix(editor): Show credential share info only to appropriate users ( #8020 )
...
## Summary
The credential owner should not see the sharing info box
2023-12-14 11:48:51 +01:00
Michael Kret
953a58f18b
feat(n8n Form Trigger Node): Improvements ( #7571 )
...
Github issue / Community forum post (link here to close automatically):
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
Co-authored-by: Giulio Andreini <andreini@netseven.it>
2023-12-13 17:00:51 +02:00
Elias Meire
8a5343401d
feat(editor): Filter component + implement in If node ( #7490 )
...
New Filter component + implementation in If node (v2)
<img width="3283" alt="image"
src="https://github.com/n8n-io/n8n/assets/8850410/35c379ef-4b62-4d06-82e7-673d4edcd652 ">
---------
Co-authored-by: Giulio Andreini <andreini@netseven.it>
Co-authored-by: Michael Kret <michael.k@radency.com>
2023-12-13 14:45:22 +01:00
Tomi Turtiainen
08ee307209
feat(editor): Show template credential setup based on feature flag ( #7989 )
...
Replace the local storage based feature flag with posthog feature flag.
Also:
- Fix bunch of eslint warnings in posthog store
2023-12-11 20:21:10 +02:00
Csaba Tuncsik
dbd62a4992
feat: Introduce advanced permissions ( #7844 )
...
This PR introduces the possibility of inviting new users with an `admin`
role and changing the role of already invited users.
Also using scoped permission checks where applicable instead of using
user role checks.
---------
Co-authored-by: Val <68596159+valya@users.noreply.github.com>
Co-authored-by: Alex Grozav <alex@grozav.com>
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
2023-12-08 12:52:25 +01:00
Elias Meire
675ec21d33
feat: Data transformation nodes and actions in Nodes Panel ( #7760 )
...
- Split Items List node into separate nodes per action
- Review node descriptions
- New icons
- New sections in subcategories
---------
Co-authored-by: Giulio Andreini <andreini@netseven.it>
Co-authored-by: Deborah <deborah@starfallprojects.co.uk>
Co-authored-by: Michael Kret <michael.k@radency.com>
2023-12-08 11:40:05 +01:00
Tomi Turtiainen
a3ca7c7acd
fix: Disable continue button unless at least 1 cred has been filled (no-changelog) ( #7959 )
...
Disable the continue button in template credential setup unless at least
one credential has been (pre-)filled
2023-12-07 19:35:34 +02:00
Csaba Tuncsik
c461025f70
test: Add user type of admin to E2E tests ( #7935 )
...
## Summary
Extend existing user types in the E2E database. Currently, we have only
owner and member but we need also admin
---------
Co-authored-by: Val <68596159+valya@users.noreply.github.com>
2023-12-06 14:31:06 +01:00
Milorad FIlipović
4bd7ae29f7
perf(editor): Improve performance when opening large workflows with node issues ( #7901 )
...
This PR should improve performance when opening large workflows that
contain node issues (Fixes ADO-1521)
**Background**
Main reason for this poor performance is that our `getCurrentWorkflow()`
store getter is unnecessarily heavy but on top of that we are calling it
more than we need. This addresses the second part of the issue by
changing the following:
- Pausing node issue processing while workflows are loading
- Only getting current workflow once (instead for every node) when
calling `refreshNodeIssues`
**Benchmark**
This was tested on a workflow attached to [this Linear
ticket](https://linear.app/n8n/issue/ADO-1501/deliveryhero-enterprise-instance-very-slow-loading-workflows )
and this fix brings down opening time from **~1m10s** to **~28s** on my
laptop.
**Tests**
- [Latest e2e tests
run](https://github.com/n8n-io/n8n/actions/runs/7060874994 )
https://community.n8n.io/t/ui-very-slow-with-more-than-100-nodes/8236/14
2023-12-04 10:57:03 +01:00
Elias Meire
39fa8d21bb
feat(editor): Add sections to create node panel ( #7831 )
...
This PR sets the stage for the node creator to handle sections within
subcategories. No visible changes result from this PR; the next PR will
define sections and assign nodes accordingly.
Sections are configurable in
`packages/editor-ui/src/components/Node/NodeCreator/viewsData.ts`:
```
{
type: 'subcategory',
key: FILES_SUBCATEGORY,
category: CORE_NODES_CATEGORY,
properties: {
title: FILES_SUBCATEGORY,
icon: 'file-alt',
sections: [
{
key: 'popular',
title: i18n.baseText('nodeCreator.sectionNames.popular'),
items: ['n8n-nodes-base.readBinaryFiles', 'n8n-nodes-base.compression'],
},
],
},
},
```
For example:
<img width="302" alt="image"
src="https://github.com/n8n-io/n8n/assets/8850410/74470c07-f4ea-4306-bd4a-8d33bd769b86 ">
---------
Co-authored-by: Michael Kret <michael.k@radency.com>
2023-12-04 10:02:07 +01:00
Tomi Turtiainen
a78729b12f
feat(editor): Allow partial template credential setup (no-changelog) ( #7899 )
...
Enable continue button even if all credentials havent been setup
2023-12-04 09:30:34 +02:00
Tomi Turtiainen
627ddb91fb
feat(editor): Open template credential setup from collection ( #7882 )
...
Open the template credential setup when using a template from the
collection view.
NOTE! This feature is still behind a feature flag. To test, set:
```js
localStorage.setItem('template-credentials-setup', 'true')
```
https://github.com/n8n-io/n8n/assets/10324676/46ccec7c-5a44-429e-99ad-1c10640e99e5
2023-11-30 14:09:12 +02:00
Iván Ovejero
ce2d388f05
fix(editor): Fix deletion of last execution at execution preview ( #7883 )
...
https://linear.app/n8n/issue/PAY-1062
2023-11-30 12:12:26 +01:00
Jan Oberhauser
87def60979
feat: Add AI tool building capabilities ( #7336 )
...
Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/langchain-memory-chat/23733
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Val <68596159+valya@users.noreply.github.com>
Co-authored-by: Alex Grozav <alex@grozav.com>
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
Co-authored-by: Deborah <deborah@starfallprojects.co.uk>
Co-authored-by: Jesper Bylund <mail@jesperbylund.com>
Co-authored-by: Jon <jonathan.bennetts@gmail.com>
Co-authored-by: Michael Kret <88898367+michael-radency@users.noreply.github.com>
Co-authored-by: Giulio Andreini <andreini@netseven.it>
Co-authored-by: Mason Geloso <Mason.geloso@gmail.com>
Co-authored-by: Mason Geloso <hone@Masons-Mac-mini.local>
Co-authored-by: Mutasem Aldmour <mutasem@n8n.io>
2023-11-29 12:13:55 +01:00
Alex Grozav
72852a60eb
feat(editor): Replace middleware for Role checks with Scope checks ( #7847 )
2023-11-29 10:35:40 +02:00
कारतोफ्फेलस्क्रिप्ट™
117962d473
feat(core): Update LLM applications building support (no-changelog) ( #7710 )
...
extracted out of #7336
---------
Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
Co-authored-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Alex Grozav <alex@grozav.com>
2023-11-28 16:47:28 +01:00
Tomi Turtiainen
ac744d6702
test: Ado 1296 add e2e tests ( #7792 )
...
Adds e2e tests for the template credential setup.
2023-11-27 17:18:10 +02:00
कारतोफ्फेलस्क्रिप्ट™
d2c18c5727
fix(core): Use AbortController to notify nodes to abort execution ( #6141 )
...
and add support for cancelling ongoing operations inside a node.
---------
Co-authored-by: Oleg Ivaniv <me@olegivaniv.com>
2023-11-24 18:17:06 +01:00
Elias Meire
da851986f6
feat(editor): Add node name and version to NDV node settings ( #7731 )
...
<img width="580" alt="image"
src="https://github.com/n8n-io/n8n/assets/8850410/85ac1c6e-9116-436a-a2ed-8d0ac162a287 ">
<img width="580" alt="image"
src="https://github.com/n8n-io/n8n/assets/8850410/08b37377-cef5-4f80-80c0-addfdd37f728 ">
---------
Co-authored-by: Giulio Andreini <andreini@netseven.it>
2023-11-23 18:28:07 +01:00
Milorad FIlipović
2064f7f251
fix(editor): Validate user info before submiting ( #7608 )
...
Validate first and last names before saving them to database. This
should prevent security issue with un-sanitized data that ends up in
emails.
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-11-22 12:14:44 +01:00
Michael Auerswald
0d3d33dd1f
fix(editor): Only show push to git menu item to owners ( #7766 )
...
Removes the menu entry of "Push to Git" from the workflow menu for
non-owners, since they would not be able to push in the first place.
2023-11-21 15:20:15 +01:00
Michael Auerswald
366cd672a7
fix(editor): Move workerview entry into settings menu ( #7761 )
...
As the worker view is not an essential function, it is being moved from
the main side bar to the settings side bar for the time being.
2023-11-21 11:29:24 +01:00
Elias Meire
8d12c1ad8d
feat(editor): Add node context menu ( #7620 )
...
2023-11-20 14:37:12 +01:00
Elias Meire
c9f6ea141b
fix: Include cypress TypeScript types in /cypress folder (no-changelog) ( #7746 )
2023-11-20 09:26:25 +01:00
कारतोफ्फेलस्क्रिप्ट™
2d039010db
fix(editor): Fix Admin panel icon in the sidebar for cloud deployments (no-changelog) ( #7738 )
...
Co-authored-by: ricardo <ricardoespinoza105@gmail.com>
Co-authored-by: Mutasem Aldmour <mutasem@n8n.io>
2023-11-17 14:44:47 +01:00
कारतोफ्फेलस्क्रिप्ट™
fc60e9a809
refactor(core): Convert dynamic node-parameter routes to a decorated controller (no-changelog) ( #7284 )
...
1. Reduce a lot of code duplication
2. Move more endpoints out of `Server.ts`
3. Move all query-param parsing and validation into a middleware to make
the route handlers simpler.
2023-11-17 12:03:05 +01:00
Iván Ovejero
0408299c7d
refactor(core): Stop reporting to Sentry unrecognized node errors (no-changelog) ( #7728 )
...
https://n8nio.sentry.io/issues/4636584213
2023-11-17 10:25:10 +01:00
कारतोफ्फेलस्क्रिप्ट™
9d6a68d1c7
ci: Skip the regularly failing tests in 2-credentials.cy.ts (no-changelog) ( #7736 )
2023-11-16 17:42:58 +01:00
Csaba Tuncsik
18817651ec
feat(editor): Node IO filter ( #7503 )
...
Co-authored-by: Omar Ajoue <krynble@gmail.com>
2023-11-15 16:19:48 +01:00
Elias Meire
14035e1244
feat(editor): Add HTTP request nodes for credentials without a node ( #7157 )
...
Github issue / Community forum post (link here to close automatically):
---------
Co-authored-by: Giulio Andreini <g.andreini@gmail.com>
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-11-13 12:11:16 +01:00
Michael Auerswald
cbc690907f
feat(editor): Adds a EE view to show worker details and job status ( #7600 )
...
This change expands on the command channel communication introduced
lately between the main instance(s) and the workers. The frontend gets a
new menu entry "Workers" which will, when opened, trigger a regular call
to getStatus from the workers. The workers then respond via their
response channel to the backend, which then pushes the status to the
frontend.
This introduces the use of ChartJS for metrics.
This feature is still in MVP state and thus disabled by default for the
moment.
2023-11-10 23:48:31 +01:00
कारतोफ्फेलस्क्रिप्ट™
ad596abeb9
ci: Disable Workflow filters e2e tests to unblock the CI (no-changelog) ( #7668 )
2023-11-09 13:30:17 +01:00
Ricardo Espinoza
afd637b5ea
feat(editor): Add workflow filters to querystring ( #7456 )
...
fixes:
https://linear.app/n8n/issue/ADO-1222/feature-save-filters-in-workflows
2023-11-08 08:42:53 -05:00
Ricardo Espinoza
8359364536
feat(editor): Add color selector to sticky node ( #7453 )
...
fixes: https://linear.app/n8n/issue/ADO-1223/feature-sticky-colors
---------
Co-authored-by: Giulio Andreini <g.andreini@gmail.com>
Co-authored-by: Mutasem <mutdmour@gmail.com>
2023-11-08 08:23:57 -05:00
Csaba Tuncsik
020042ef1a
fix(editor): Redirect to workflow editor after saving in debug mode ( #7645 )
2023-11-08 14:04:02 +01:00
Csaba Tuncsik
78b84af8d1
fix(editor): Reset canvas zoom before workspace reset in node view ( #7625 )
2023-11-06 18:15:49 +01:00
Jan Oberhauser
db56a9ee37
fix(editor): Fix issue that frontend breaks with unkown nodes ( #7596 )
...
Because of recent changes does the frontend break when a node is not
known.
Github issue / Community forum post (link here to close automatically):
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Oleg Ivaniv <me@olegivaniv.com>
2023-11-06 13:44:05 +01:00
Alex Grozav
24dfc95974
feat(editor): Improve performance by importing routes dynamically and add route guards (no-changelog) ( #7567 )
...
**Before:**
<img width="657" alt="image"
src="https://github.com/n8n-io/n8n/assets/6179477/0bcced2b-9d3a-43b3-80d7-3c72619941fa ">
**After:**
<img width="660" alt="image"
src="https://github.com/n8n-io/n8n/assets/6179477/e74e0bbf-bf33-49b4-ae11-65f640405ac8 ">
2023-11-03 16:22:37 +02:00
Elias Meire
c92402a3ca
fix(editor): Zoom in/out on canvas the same amount on scroll/gesture ( #7602 )
...
Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/ctrl-mousewheel-zoom-jumps-out-possible-to-avoid/31952
2023-11-03 14:09:18 +01:00
Iván Ovejero
d633753687
fix(editor): Remove unknown credentials on pasting workflow ( #7582 )
...
https://linear.app/n8n/issue/PAY-881
2023-11-02 17:26:39 +01:00
Mutasem Aldmour
2854a0cf46
fix(editor): Allow overriding theme from query params ( #7591 )
...
Allow overriding theme through query params.. to be able to override it
from preview iframe in webcomponent
Github issue / Community forum post (link here to close automatically):
2023-11-02 16:06:33 +01:00
Alex Grozav
721a36637c
feat(editor): Handle pin data edge cases and unify validation (no-changelog) ( #6685 )
...
Github issue / Community forum post (link here to close automatically):
2023-11-02 10:43:02 +02:00
Giulio Andreini
0746783e02
refactor(editor): Color palette updates, introduce dark mode ( #6980 )
...
Github issue / Community forum post (link here to close automatically):
---------
Co-authored-by: Mutasem <mutdmour@gmail.com>
2023-11-01 13:33:36 +01:00
Csaba Tuncsik
3b5e181e66
fix(editor): Fix NDV close after using input select ( #7544 )
2023-10-30 13:44:19 +01:00
Csaba Tuncsik
12a89e6d14
fix(editor): Fix route component caching, incorrect use of array reduce method and enable WF history feature ( #7434 )
...
Co-authored-by: Giulio Andreini <andreini@netseven.it>
2023-10-26 20:47:42 +02:00
Jan Oberhauser
df89685e15
fix(editor): Fixes the issue that Switch Node can not be created ( #7516 )
...
Fixes the issue that currently no Switch-Node can be created by for
example pressing + on the parent node or via tab when another node is
already selected.
Github issue / Community forum post (link here to close automatically):
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Oleg Ivaniv <me@olegivaniv.com>
2023-10-26 09:46:26 +02:00
OlegIvaniv
2febc61ec9
feat(Switch Node): Add support for infinite Switch outputs ( #7499 )
...
Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/add-more-outputs-to-switch-node/3864
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
2023-10-25 14:34:47 +02:00
OlegIvaniv
450e0cc66a
fix(editor): Fix connections disappearing after reactivating canvas and renaming a node ( #7483 )
...
Github issue / Community forum post (link here to close automatically):
-
https://community.n8n.io/t/1-11-1-possible-bug-all-nodes-randomly-losing-their-connectors/31856
- https://community.n8n.io/t/lines-between-nodes-have-disappeared/31846
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
2023-10-23 10:07:33 +02:00
Milorad FIlipović
bc473655fb
fix(editor): Fix canvas selection breaking after interacting with node actions ( #7466 )
...
Sometimes canvas selection stops working after users interact with node
action buttons (for example if node is moved by dragging one of the
buttons)
NOTE: Ticket number in the branch name is wrong, this fixes ADO-1226
2023-10-20 09:26:40 +02:00
Michael Kret
3ddc176dfa
feat(n8n Form Trigger Node): New node ( #7130 )
...
Github issue / Community forum post (link here to close automatically):
based on https://github.com/joffcom/n8n-nodes-form-trigger
---------
Co-authored-by: Giulio Andreini <g.andreini@gmail.com>
2023-10-17 07:09:30 +03:00
Milorad FIlipović
1307d488b9
fix: Fix flaky remote options loading test (no-changelog) ( #7433 )
...
Background: Looks like remote options loading needs a bit of time to
catch up when dependent parameter changes so when using cypress `type`
method without delay it fails to update the values properly. Since this
does not represent actual component behavior when real user interact
with it we added a delay to automated typing.
This PR increases typing delay, giving the component more time to
breathe when run in CI
- [Latest e2e
run](https://github.com/n8n-io/n8n/actions/runs/6506583716 )
- [Video of this specific
test](https://cloud.cypress.io/projects/5hbsdn/runs/aa4f1a7d-b95f-4c8a-acd6-33061d290c7b/test-results/21a1abdf-1e1c-43bf-a640-8cc39b11cc46/video )
2023-10-13 12:30:45 +02:00
Iván Ovejero
ec141416e2
fix(core): Fix expression with paired item with multi-input node ( #7424 )
...
https://linear.app/n8n/issue/PAY-630
Minimal repro:
https://internal.users.n8n.cloud/workflow/9HSkIy4T1LqXbm1H
2023-10-12 17:32:14 +02:00
Milorad FIlipović
367255ab2c
fix(editor): Fix remote options fetching on every keystroke ( #7320 )
...
Github issue / Community forum post (link here to close automatically):
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-10-12 14:18:35 +02:00
Elias Meire
7e06b31a5f
fix(editor): Implement canvas zoom UX improvements ( #7376 )
...
- Fix pinch-to-zoom
- Support command + scroll to zoom
- Improve accuracy of zooming (scroll more = zoom more)
- Zoom limits
- Zoom relative to mouse position
2023-10-10 11:07:58 +02:00
Elias Meire
7b773cc5cc
feat(Loop Over Items (Split in Batches) Node): Automatically add a loop + rename ( #7228 )
...
Github issue / Community forum post (link here to close automatically):
---------
Co-authored-by: Michael Kret <michael.k@radency.com>
2023-10-06 15:31:18 +02:00
Ricardo Espinoza
ab647b231d
fix: Flaky mfa e2e tests (no-changelog) ( #7192 )
...
Github issue / Community forum post (link here to close automatically):
2023-10-06 11:06:38 +02:00
Michael Kret
e5ad1e7e4d
fix(Set Node): Increase search priority ( #7358 )
...
Github issue / Community forum post (link here to close automatically):
2023-10-05 16:19:19 +03:00
Milorad FIlipović
7ebf8f327a
fix(editor): Fix disappearing NDV header in code nodes ( #7290 )
...
Github issue / Community forum post (link here to close automatically):
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-10-05 12:31:52 +02:00
Elias Meire
ddc26c21bd
fix(editor): Fix RLC not loading when an expression can't resolve ( #7295 )
...
Also fixes label (list -> From list)
Github issue / Community forum post (link here to close automatically):
2023-10-04 16:01:44 +02:00
Giulio Andreini
942d0b91fc
docs(editor): New Nodes Panel title for triggers ( #7314 )
...
Github issue / Community forum post (link here to close automatically):
2023-10-04 15:27:40 +02:00
Elias Meire
5e6c1d4f4b
fix(Convert to/from binary data Node): Rename 'Move Binary Data' to 'Convert to/from binary data' ( #7318 )
...
Github issue / Community forum post (link here to close automatically):
2023-10-04 13:23:33 +02:00
कारतोफ्फेलस्क्रिप्ट™
00a4b8b0c6
feat(core): Add support for building LLM applications ( #7235 )
...
This extracts all core and editor changes from #7246 and #7137 , so that
we can get these changes merged first.
ADO-1120
[DB Tests](https://github.com/n8n-io/n8n/actions/runs/6379749011 )
[E2E Tests](https://github.com/n8n-io/n8n/actions/runs/6379751480 )
[Workflow Tests](https://github.com/n8n-io/n8n/actions/runs/6379752828 )
---------
Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
Co-authored-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Alex Grozav <alex@grozav.com>
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-10-02 17:33:43 +02:00
Elias Meire
ec2aa3819c
fix(Notion Node): Rename Notion API Key to Internal Integration Token ( #7176 )
...
Github issue / Community forum post (link here to close automatically):
2023-09-29 09:21:29 +02:00
Mutasem Aldmour
01e9340621
feat: Add onboarding flow ( #7212 )
...
Github issue / Community forum post (link here to close automatically):
2023-09-25 15:49:36 +02:00
Michael Kret
647fc6c555
fix(editor): Fix SQL editor issue ( #7236 )
...
Github issue / Community forum post (link here to close automatically):
2023-09-22 14:17:54 +03:00
Mutasem Aldmour
2491ccf4d9
fix: Ensure new Set node is on top of search list ( #7215 )
...
Github issue / Community forum post (link here to close automatically):
2023-09-20 16:47:51 +02:00
Michael Kret
3a474552b2
feat(Set Node): Overhaul ( #6348 )
...
Github issue / Community forum post (link here to close automatically):
https://github.com/n8n-io/n8n/pull/6348
---------
Co-authored-by: Giulio Andreini <g.andreini@gmail.com>
Co-authored-by: Marcus <marcus@n8n.io>
2023-09-19 13:16:35 +03:00
Iván Ovejero
bb215bd12a
ci: Disable intermittently failing MFA e2e tests (no-changelog) ( #7106 )
...
MFA e2e tests keep intermittently failing, creating distractions
<img width="917" alt="Capture 2023-09-05 at 09 36 45@2x"
src="https://github.com/n8n-io/n8n/assets/44588767/baed58bf-7871-4c84-a9c1-60109f13bb93 ">
Followup story to fix them: https://linear.app/n8n/issue/N8N-6896
2023-09-15 11:33:10 +02:00
Milorad FIlipović
aaf87c3edd
fix(editor): Testing flaky resource mapper feature in e2e tests ( #7165 )
2023-09-14 10:54:25 +02:00
Csaba Tuncsik
c9b79485cf
fix(editor): Unbind workflow endpoint events in case of workspace reset ( #7129 )
2023-09-13 09:00:35 +02:00
कारतोफ्फेलस्क्रिप्ट™
a693b29134
ci: Fix prettier auto-formatting (no-changelog) ( #7063 )
2023-09-01 13:29:31 +02:00
Mutasem Aldmour
8a8d4e8bb3
fix: Load remote resources even if expressions in non requried parameters resolve ( #6987 )
...
Github issue / Community forum post (link here to close automatically):
2023-08-31 16:40:20 +02:00
Mutasem Aldmour
e1922f7383
test: Add tests for parameter lag ( #6942 )
...
Github issue / Community forum post (link here to close automatically):
2023-08-29 14:00:17 +02:00
OlegIvaniv
4600bb3317
fix(editor): Adjust Ask AI tracking events & pass NDV session id (no-changelog) ( #7027 )
...
Github issue / Community forum post (link here to close automatically):
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
2023-08-29 12:53:29 +02:00
Csaba Tuncsik
c833078c87
feat(editor): Debug executions in the editor ( #6834 )
2023-08-25 09:39:14 +02:00
कारतोफ्फेलस्क्रिप्ट™
92d4befea6
fix(core): Fix AddMfaColumns migration for sqlite (no-changelog) ( #7006 )
...
When ever we have migrations that use `.addColumn` or `.dropColumn`,
typeorm recreates tables for sqlite. so, we need to disable foreign key
enforcement for sqlite, or else data in some tables can get deleted
because of `ON DELETE CASCADE`
[This has happened in the
past](https://github.com/n8n-io/n8n/pull/6739 ), and we should really
come up with a way to prevent this from happening again.
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Oleg Ivaniv <me@olegivaniv.com>
2023-08-24 09:31:37 -04:00
Ricardo Espinoza
2b7ba6fdf1
feat(core): Add MFA ( #4767 )
...
https://linear.app/n8n/issue/ADO-947/sync-branch-with-master-and-fix-fe-e2e-tets
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-08-23 22:59:16 -04:00
Ricardo Espinoza
d3f01270c7
fix(editor): Trial banner does not disappear after sign out (no-changelog) ( #6930 )
...
to test in staging use version
`PR-6930-ado-990-trial-banner-does-not-disappear-after-sign-out`
<img width="875" alt="image"
src="https://github.com/n8n-io/n8n/assets/16496553/dfffe60f-bec3-4c48-bd9c-5990c68afa52 ">
2023-08-17 07:57:40 -04:00
Iván Ovejero
7ce5d8fd90
refactor: Upgrade to Prettier 3 (no-changelog) ( #6947 )
...
Supersedes https://github.com/n8n-io/n8n/pull/6937
Excluding fixtures and test workflow JSONs to avoid having to update
tests.
2023-08-16 17:13:57 +02:00
OlegIvaniv
fde6ad1e7f
feat(editor): Ask AI in Code node ( #6672 )
...
* feat(editor): Ask AI tab and CLi connection
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Remove old getSchema util method
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Increase CSS specificity of the CodeNodeEditor global overrides
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* feat(editor): Magic Connect
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Improve AI controller, load conditionally, UX modal imporvements
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Extract-out AI curl
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Move loading phrases to locale, add support for ask ai experiment
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix build
* adjust communication
* fix: Remove duplicate source control preferences fetching (no-changelog) (#6675 )
fix: remove duplicate source control preferences fetching (no-changelog)
* fix(Slack Node): Add UTM params to n8n reference in Slack message (no-changelog) (#6668 )
fix(Slack Node): Add UTM params to n8n reference in Slack message
* fix(FileMaker Node): Improve returned error responses (#6585 )
* fix(Microsoft Outlook Node): Fix issue with category not correctly applying (#6583 )
* feat(Airtable Node): Overhaul (#6200 )
* fix(core): Deleting manual executions should defer deleting binary data (#6680 )
deleting manual executions should defer deleting binary data
* fix(editor): Add paywall state to non owner users for Variables (#6679 )
* fix(editor): Add paywall state to non owner users for Variables
* fix(editor): Add variables view tests
* fix(editor): remove link from paywall state for non owner
* fix(editor): fix displaying logic
* refactor(core): Refactor WorkflowStatistics code (no-changelog) (#6617 )
refactor(core): Refactor WorkflowStatistics code
* fix(editor): Hide Execute Node button for unknown nodes (#6684 )
* feat: Allow hiding credential params on cloud (#6687 )
* fix: Stop n8n from complaining about credentials when saving a new workflow form a template (#6671 )
* fix(core): Upgrade semver to address CVE-2022-25883 (#6689 )
* fix(core): Upgrade semver to address CVE-2022-25883
[GH Advisory](https://github.com/advisories/GHSA-c2qf-rxjj-qqgw )
* enforce the patched version of semver everywhere in the dev setup
* ci: Fix test checker glob (no changelog) (#6682 )
ci: Fix test checker glob
* fix(API): Do not add starting node on workflow creation (#6686 )
* fix(API): Do not add starting node on workflow creation
* chore: Remove comment
* fix(core): Filter out workflows that failed to activate on startup (#6676 )
* fix(core): Deactivate on init workflow that should not be retried
* fix(core): Filter out workflows with activation errors
* fix(core): Load SAML libraries dynamically (#6690 )
load SAML dynamically
* fix(crowd.dev Node): Fix documentation urls for crowd.dev credentials and nodes (#6696 )
* feat(Read PDF Node): Replace pdf-parse with pdfjs, and add support for streaming and encrypted PDFs (#6640 )
* feat: Allow `eslint-config` to be externally consumable (#6694 )
* feat: Allow `eslint-config` to be externally consumable
* refactor: Adjust import styles
* fix(Contentful Node): Fix typo in credential name (no-changelog) (#6692 )
* fix(editor): Ensure default credential values are not detected as dirty state (#6677 )
* fix(editor): Ensure default credential values are not detected as dirty state
* chore: Remove logging
* refactor: Improve comment
* feat(Google Cloud Storage Node): Use streaming for file uploads (#6462 )
fix(Google Cloud Storage Node): Use streaming for file uploads
* fix(editor): Prevent RMC from loading schema if it's already cached (#6695 )
* fix(editor): Prevent RMC from loading schema if it's already cached
* ✅ Adding new tests for RMC
* 👕 Fixing lint errors
* 👌 Updating inline loader styling
* fix(API): Fix issue with workflow setting not supporting newer nanoids (#6699 )
* ci: Fix test workflows (no-changelog) (#6698 )
* ci: Fix test workflows (no-changelog)
We removed `pdf-parse` in #6640 , so we need to get these test PDF files from the `test-workflows` repo instead ([which has been updated to include these files](0f6ef1c804#6700 )
* fix(Postgres Node): For select queries, empty result should be be replaced with `{"success":true}` (#6703 )
* fix(Postgres Node): For select queries, empty result should be be replaced with `{"success":true}`
* ⚡ less checks
---------
Co-authored-by: Michael Kret <michael.k@radency.com>
* feat(editor): Removing `ph-no-capture` class from some elements (#6674 )
* feat(editor): Remove `.ph-no-capture` class from some of the fields
* ✔️ Updating test snapshots
* ⚡ Redacting expressions preview in credentials form
* 🔧 Disable posthog input masking
* 🚨 Testing PostHog iFrame settings
* Reverting iframe test
* ⚡ Hiding API key in PostHog recordings
* ✅ Added tests for redacted values
* ✔️ Updating checkbox snapshots after label component update
* ✔️ Updating test snapshots in editor-ui
* 👕 Fix lint errors
* fix(editor): Remove global link styling in v1 banner (#6705 )
* fix: Add missing indices on sqlite (#6673 )
* fix: enforce tag name uniqueness on sqlite
* rename migration and add other missing indices
* add tags tests
* test: Move test timeout to `/cli` (no-changelog) (#6712 )
* fix(core): Redirect user to previous url after SSO signin (#6710 )
redirect user to previous url after SSO signin
* fix(FTP Node): List recursive ignore . and .. to prevent infinite loops (#6707 )
ignore . and .. to prevent infinite loop
Co-authored-by: Michael Kret <michael.k@radency.com>
* ci: Fix running e2e tests in dev mode (no-changelog) (#6717 )
* fix(Google BigQuery Node): Error description improvement (#6715 )
* fix(GitLab Trigger Node): Fix trigger activation 404 error (#6711 )
* fix webhook checkExists not deleting static data
* improve webhook checkExists not deleting static data
* fix(core): Support redis cluster in queue mode (#6708 )
* support redis cluster
* cleanup, fix config schema
* set default prefix to bull
* fix(editor): Skip error line highlighting if out of range (#6721 )
* fix(AwsS3 Node): Fix issue if bucket name contains a '.' (#6542 )
* test(editor): Add canvas actions E2E tests (#6723 )
* test(editor): Add canvas actions E2E tests
* test(editor): Open category items in node creator when category dropped on canvas
* test(editor): Have new position counted only once in drag
* test(editor): rename test
* feat(Rundeck Node): Add support for node filters (#5633 )
* fix(Gmail Trigger Node): Early returns in case of no data (#6727 )
* fix(core): Use JWT as reset password token (#6714 )
* use jwt to reset password
* increase expiration time to 1d
* drop user id query string
* refactor
* use service instead of package in tests
* sqlite migration
* postgres migration
* mysql migration
* remove unused properties
* remove userId from FE
* fix test for users.api
* move migration to the common folder
* move type assertion to the jwt.service
* Add jwt secret as a readonly property
* use signData instead of sign in user.controller
* remove base class
* remove base class
* add tests
* ci: Fix tests on postgres (no-changelog)
* refactor(core): Prevent community packages queries if feature is disabled (#6728 )
* feat(core): Add cache service (#6729 )
* add cache service
* PR adjustments
* switch to maxSize for memory cache
* Revert "test(editor): Add canvas actions E2E tests" (#6736 )
Revert "test(editor): Add canvas actions E2E tests (#6723 )"
This reverts commit 052d82b220#6718 )
* fix(Telegram Trigger Node): Add guard to 'include' call on null or undefined (#6730 )
* fix(core): Use `exec` in docker images to forward signals correctly (#6732 )
* refactor(core): Move webhook DB access to repository (no-changelog) (#6706 )
* refactor(core): Move webhook DB access to repository (no-changelog)
* make sure `DataSource` is initialized before it's dependencies
at some point I hope to replace `DataSource` with a custom `DatabaseConnection` service class that can then disconnect and reconnect from DB without having to update all repositories.
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
* feat: Environments release using source control (#6653 )
* initial telemetry setup and adjusted pull return
* quicksave before merge
* feat: add conflicting workflow list to pull modal
* feat: update source control pull modal
* fix: fix linting issue
* feat: add Enter keydown event for submitting source control push modal (no-changelog)
feat: add Enter keydown event for submitting source control push modal
* quicksave
* user workflow table for export
* improve telemetry data
* pull api telemetry
* fix lint
* Copy tweaks.
* remove authorName and authorEmail and pick from user
* rename owners.json to workflow_owners.json
* ignore credential conflicts on pull
* feat: several push/pull flow changes and design update
* pull and push return same data format
* fix: add One last step toast for successful pull
* feat: add up to date pull toast
* fix: add proper Learn more link for push and pull modals
* do not await tracking being sent
* fix import
* fix await
* add more sourcecontrolfile status
* Minor copy tweak for "More info".
* Minor copy tweak for "More info".
* ignore variable_stub conflicts on pull
* ignore whitespace differences
* do not show remote workflows that are not yet created
* fix telemetry
* fix toast when pulling deleted wf
* lint fix
* refactor and make some imports dynamic
* fix variable edit validation
* fix telemetry response
* improve telemetry
* fix unintenional delete commit
* fix status unknown issue
* fix up to date toast
* do not export active state and reapply versionid
* use update instead of upsert
* fix: show all workflows when clicking push to git
* feat: update Up to date pull translation
* fix: update read only env checks
* do not update versionid of only active flag changes
* feat: prevent access to new workflow and templates import when read only env
* feat: send only active state and version if workflow state is not dirty
* fix: Detect when only active state has changed and prevent generation a new version ID
* feat: improve readonly env messages
* make getPreferences public
* fix telemetry issue
* fix: add partial workflow update based on dirty state when changing active state
* update unit tests
* fix: remove unsaved changes check in readOnlyEnv
* fix: disable push to git button when read onyl env
* fix: update readonly toast duration
* fix: fix pinning and title input in protected mode
* initial commit (NOT working)
* working push
* cleanup and implement pull
* fix getstatus
* update import to new method
* var and tag diffs are no conflicts
* only show pull conflict for workflows
* refactor and ignore faulty credentials
* add sanitycheck for missing git folder
* prefer fetch over pull and limit depth to 1
* back to pull...
* fix setting branch on initial connect
* fix test
* remove clean workfolder
* refactor: Remove some unnecessary code
* Fixed links to docs.
* fix getstatus query params
* lint fix
* dialog to show local and remote name on conflict
* only show remote name on conflict
* fix credential expression export
* fix: Broken test
* dont show toast on pull with empty var/tags and refactor
* apply frontend changes from old branch
* fix tag with same name import
* fix buttons shown for non instance owners
* prepare local storage key for removal
* refactor: Change wording on pushing and pulling
* refactor: Change menu item
* test: Fix broken test
* Update packages/cli/src/environments/sourceControl/types/sourceControlPushWorkFolder.ts
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
---------
Co-authored-by: Alex Grozav <alex@grozav.com>
Co-authored-by: Giulio Andreini <g.andreini@gmail.com>
Co-authored-by: Omar Ajoue <krynble@gmail.com>
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* fix(core): Fix RemoveResetPasswordColumns migration for sqlite (no-changelog) (#6739 )
* ci: Update changelog generation to work with node 18
* refactor: Remove webhook from `IDatabaseCollections` (no-changelog) (#6745 )
* refactor: Remove webhook from `IDatabaseCollections`
* refactor: Remove also from `collections`
* 🚀 Release 1.1.0 (#6746 )
Co-authored-by: netroy <netroy@users.noreply.github.com>
* fix(Lemlist Node): Fix pagination issues with campaigns and activities (#6734 )
* ci: Fix linting issues (no-changelog) (#6747 )
* fix(core): Allow ignoring SSL issues on generic oauth2 credentials (#6702 )
* refactor: Remove all references to the resetPasswordToken field (no-changelog) (#6751 )
refactor: remove all references to the resetPasswordToken field (no-changelog)
* refactor(core): Use mixins to delete redundant code between Entity classes (no-changelog) (#6616 )
* db entities don't need an ID before they are inserted
* don't define constructors on entity classes, use repository.create instead
* use mixins to reduce duplicate code in db entity classes
* fix: Display source control buttons properly (#6756 )
* feat(editor): Migrate Design System and Editor UI to Vue 3 (#6476 )
* feat: remove vue-fragment (no-changelog)
* feat: partial design-system migration
* feat: migrate info-accordion and info-tip components
* feat: migrate several components to vue 3
* feat: migrated several components
* feat: migrate several components
* feat: migrate several components
* feat: migrate several components
* feat: re-exported all design system components
* fix: fix design for popper components
* fix: editor kind of working, lots of issues to fix
* fix: fix several vue 3 migration issues
* fix: replace @change with @update:modelValue in several places
* fix: fix translation linking
* fix: fix inline-edit input
* fix: fix ndv and dialog design
* fix: update parameter input event bindings
* fix: rename deprecated lifecycle methods
* fix: fix json view mapping
* build: update lock file
* fix(editor): revisit last conflict with master and fix issues
* fix(editor): revisit last conflict with master and fix issues
* fix: fix expression editor bug causing code mirror to no longer be reactive
* fix: fix resource locator bug
* fix: fix vue-agile integration
* fix: remove global import for vue-agile
* fix: replace element-plus buttons with n8n-buttons everywhere
* fix(editor): Fix various element-plus styles (#6571 )
* fix(editor): Fix various element-plus styles
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Remove debugging code
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Address PR comments
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix(editor): Fix loading in production mode [Vue 3] (#6578 )
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix(editor): First round of e2e tests fixes with Vue 3 (#6579 )
* fix(editor): Fix broken smoke and workflow list e2e tests
* ✔️ Fix failing canvas action tests. Updating some selectors used in credentials and workflow tests
* feat: add vue 3 eslint rules and fix issues
* fix: fix tags-dropdown
* fix: fix white-space issues caused by i18n-t
* fix: rename non-generic click events
* fix: fix search in resources list layout
* fix: fix datatable paginator
* fix: fix popper select caret and dropdown size
* fix: add width to action-dropdown
* fix: fix workflow settings icon not being hidden
* fix: refactor newly added code
* fix: fix merge issue
* fix: fix ndv credentials watcher
* fix: fix workflow saving and grabber notch
* fix: fix nodes list panel transition
* fix: fix node title visibility
* fix: fix data unpinning
* fix: fix value access
* fix: show input panel only if trigger panel enabled or not trigger node
* fix: fix tags dropdown and executions status spcing
* fix(editor): Prevent execution list to load back when leaving the route (#6697 )
fix(editor): prevent execution list to load back when leaving the route
* fix: fix drawer visibility
* fix: fix expression toggle padding
* fix: fix expressions editor styling
* chore: prepare for testing
* fix: fix styling for el-button without patching
* test: fix unit tests in design-system
* test: fix most unit tests
* fix: remove import cycle.
* fix: fix personalization modal tests
* fix further resource mapper test adjustments
* fix: fix multiple tests and n8n-route attr duplication
* fix: fix source control tets
* fix: fixed remaining unit tests
* fix: fix workflows and credentials e2e tests
* fix: fix localizeNodeNames
* fix: update ndv e2e tests
* fix: fix popper left placement arrow
* fix: fix 5-ndv e2e tests
* fix: fix 6-code-node e2e tests
* fix(editor): Drop click outside directive from NodeCreator (#6716 )
* fix(editor): Drop click outside directive from NodeCreator
* fix(editor): make sure mouseup outside is unbound at least before the component is unmounted
* fix: fix 10-settings-log-streaming e2e tests
* fix: fix node redrawing
* fix: fix tooltip buttons styling
* fix: fix varous e2e suites
* fix: fix 15-scheduler-node e2e suite
* fix: fix route watcher
* fix: fixed param name update and credential edit
* feat: update event names
* refactor: Remove deprecated `$data` (#6576 )
Co-authored-by: Alex Grozav <alex@grozav.com>
* fix: fix 17-sharing e2e suite
* fix: fix tags dropdown
* fix: fix tags manager
* fix(editor): move :deep selectors to a separate scoped style block
* fix: fix sticky component and inline text edit
* fix: update e2e tests
* fix: remove button override references
* fix(editor): Adjust spacing in templates for Vue 3 (#6744 )
* fix(editor): Adjust spacing in templates
* fix: Undo unneeded change
* fix: Undo unneeded change
* fix(editor): Adjust NDV height for Vue 3 (#6742 )
fix(editor): Adjust NDV height
* fix(editor): Restore collapsed sidebar items for Vue 3 (#6743 )
fix(editor): Restore collapsed sidebar items
* fix: fix linting issues
* fix: fix design-system deps
* fix: post-merge fixes
* fix: update tests
* fix: increase timeout for executionslist tets
* chore: fix linting issue
* fix: fix 14-mapping e2e tests in ci
* fix: re-enable tests
* fix: fix workflow duplication e2e tests after tags update
* fix(editor): Change component prop to be typed
* fix: fix tags dropdown in duplicate wf modal
* fix: fix focus behaviour in tags selector
* fix: fix tag creation
* fix: fix log streaming e2e race condition
* fix(editor): Fix Vue 3 linting issues (#6748 )
* fix(editor): Fix Vue 3 linting issues
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix MainSidebar linter issues
* revert pnpm lock
* update pnpm lock file
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Alex Grozav <alex@grozav.com>
* fix(editor): Some css fixes for vue3 branch (#6749 )
* ✨ Fixing filter button height
* ✨ Update input modal button position
* ✨ Updating tags styling
* ✨ Fix event logging settings spacing
* 👕 Fixing lint errors
* fix: fix linting issues
* Revert to `// eslint-disable-next-line @typescript-eslint/no-misused-promises` disabling of mixins init
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix: fix css issue
* fix(editor): Lint fix
* fix(editor): Fix settings initialisation (#6750 )
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix: fix initial settings loading
* fix: replace realClick with click force
* fix: fix randomly failing mapping e2e tests
* fix(editor): Fix menu item event handling
* fix: fix resource filters dropdown events (#6752 )
* fix: fix resource filters dropdown events
* fix: remove teleported:false
* fix: fix event selection event naming (#6753 )
* fix: removed console.log (#6754 )
* fix: rever await nextTick changes
* fix: redo linting changes
* fix(editor): Redraw node connections if adding more than one node to canvas (#6755 )
* fix(editor): Redraw node connections if adding more than one node to canvas
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Update position before connection two nodes
* Lint fix
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Alex Grozav <alex@grozav.com>
* fix(editor): Fix `ResourceMapper` unit tests (#6758 )
* ✔️ Fix matching columns test
* ✔️ Fix multiple matching columns test
* ✔️ Removing `skip` from the last test
* fix: Allow pasting a big workflow (#6760 )
* fix: pasting a big workflow
* chore: update comment
* refactor: move try/catch to function
* refactor: move try/catch to function
* fix(editor): Fix modal layer width
* fix: fix position changes
* fix: undo it.only
* fix: make undo/redo multiple steps more verbose
* fix: Fix value survey styles (#6764 )
* fix: fix value survey styles
* fix: lint
* Revert "fix: lint"
72869c431f#6767 )
fix: drawer animation
* fix(editor): Fix source control buttons (#6769 )
* fix(editor): Fix App loading & auth (#6768 )
* fix(editor): Fix App loading & auth
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Await promises
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Fix eslint error
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Csaba Tuncsik <csaba@n8n.io>
Co-authored-by: OlegIvaniv <me@olegivaniv.com>
Co-authored-by: Milorad FIlipović <milorad@n8n.io>
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
Co-authored-by: Mutasem Aldmour <4711238+mutdmour@users.noreply.github.com>
* perf(editor): Memoize locale translate calls during actions generation (#6773 )
performance(editor): Memoize locale translate calls during actions generation
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix(editor): Close tags dropdown when modal is opened (#6766 )
* feat: remove vue-fragment (no-changelog)
* feat: partial design-system migration
* feat: migrate info-accordion and info-tip components
* feat: migrate several components to vue 3
* feat: migrated several components
* feat: migrate several components
* feat: migrate several components
* feat: migrate several components
* feat: re-exported all design system components
* fix: fix design for popper components
* fix: editor kind of working, lots of issues to fix
* fix: fix several vue 3 migration issues
* fix: replace @change with @update:modelValue in several places
* fix: fix translation linking
* fix: fix inline-edit input
* fix: fix ndv and dialog design
* fix: update parameter input event bindings
* fix: rename deprecated lifecycle methods
* fix: fix json view mapping
* build: update lock file
* fix(editor): revisit last conflict with master and fix issues
* fix(editor): revisit last conflict with master and fix issues
* fix: fix expression editor bug causing code mirror to no longer be reactive
* fix: fix resource locator bug
* fix: fix vue-agile integration
* fix: remove global import for vue-agile
* fix: replace element-plus buttons with n8n-buttons everywhere
* fix(editor): Fix various element-plus styles (#6571 )
* fix(editor): Fix various element-plus styles
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Remove debugging code
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Address PR comments
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix(editor): Fix loading in production mode [Vue 3] (#6578 )
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix(editor): First round of e2e tests fixes with Vue 3 (#6579 )
* fix(editor): Fix broken smoke and workflow list e2e tests
* ✔️ Fix failing canvas action tests. Updating some selectors used in credentials and workflow tests
* feat: add vue 3 eslint rules and fix issues
* fix: fix tags-dropdown
* fix: fix white-space issues caused by i18n-t
* fix: rename non-generic click events
* fix: fix search in resources list layout
* fix: fix datatable paginator
* fix: fix popper select caret and dropdown size
* fix: add width to action-dropdown
* fix: fix workflow settings icon not being hidden
* fix: refactor newly added code
* fix: fix merge issue
* fix: fix ndv credentials watcher
* fix: fix workflow saving and grabber notch
* fix: fix nodes list panel transition
* fix: fix node title visibility
* fix: fix data unpinning
* fix: fix value access
* fix: show input panel only if trigger panel enabled or not trigger node
* fix: fix tags dropdown and executions status spcing
* fix(editor): Prevent execution list to load back when leaving the route (#6697 )
fix(editor): prevent execution list to load back when leaving the route
* fix: fix drawer visibility
* fix: fix expression toggle padding
* fix: fix expressions editor styling
* chore: prepare for testing
* fix: fix styling for el-button without patching
* test: fix unit tests in design-system
* test: fix most unit tests
* fix: remove import cycle.
* fix: fix personalization modal tests
* fix further resource mapper test adjustments
* fix: fix multiple tests and n8n-route attr duplication
* fix: fix source control tets
* fix: fixed remaining unit tests
* fix: fix workflows and credentials e2e tests
* fix: fix localizeNodeNames
* fix: update ndv e2e tests
* fix: fix popper left placement arrow
* fix: fix 5-ndv e2e tests
* fix: fix 6-code-node e2e tests
* fix(editor): Drop click outside directive from NodeCreator (#6716 )
* fix(editor): Drop click outside directive from NodeCreator
* fix(editor): make sure mouseup outside is unbound at least before the component is unmounted
* fix: fix 10-settings-log-streaming e2e tests
* fix: fix node redrawing
* fix: fix tooltip buttons styling
* fix: fix varous e2e suites
* fix: fix 15-scheduler-node e2e suite
* fix: fix route watcher
* fix: fixed param name update and credential edit
* feat: update event names
* refactor: Remove deprecated `$data` (#6576 )
Co-authored-by: Alex Grozav <alex@grozav.com>
* fix: fix 17-sharing e2e suite
* fix: fix tags dropdown
* fix: fix tags manager
* fix(editor): move :deep selectors to a separate scoped style block
* fix: fix sticky component and inline text edit
* fix: update e2e tests
* fix: remove button override references
* fix(editor): Adjust spacing in templates for Vue 3 (#6744 )
* fix(editor): Adjust spacing in templates
* fix: Undo unneeded change
* fix: Undo unneeded change
* fix(editor): Adjust NDV height for Vue 3 (#6742 )
fix(editor): Adjust NDV height
* fix(editor): Restore collapsed sidebar items for Vue 3 (#6743 )
fix(editor): Restore collapsed sidebar items
* fix: fix linting issues
* fix: fix design-system deps
* fix: post-merge fixes
* fix: update tests
* fix: increase timeout for executionslist tets
* chore: fix linting issue
* fix: fix 14-mapping e2e tests in ci
* fix: re-enable tests
* fix: fix workflow duplication e2e tests after tags update
* fix(editor): Change component prop to be typed
* fix: fix tags dropdown in duplicate wf modal
* fix: fix focus behaviour in tags selector
* fix: fix tag creation
* fix: fix log streaming e2e race condition
* fix(editor): Fix Vue 3 linting issues (#6748 )
* fix(editor): Fix Vue 3 linting issues
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix MainSidebar linter issues
* revert pnpm lock
* update pnpm lock file
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Alex Grozav <alex@grozav.com>
* fix(editor): Some css fixes for vue3 branch (#6749 )
* ✨ Fixing filter button height
* ✨ Update input modal button position
* ✨ Updating tags styling
* ✨ Fix event logging settings spacing
* 👕 Fixing lint errors
* fix: fix linting issues
* Revert to `// eslint-disable-next-line @typescript-eslint/no-misused-promises` disabling of mixins init
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix: fix css issue
* fix(editor): Lint fix
* fix(editor): Fix settings initialisation (#6750 )
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix: fix initial settings loading
* fix: replace realClick with click force
* fix: fix randomly failing mapping e2e tests
* fix(editor): Fix menu item event handling
* fix: fix resource filters dropdown events (#6752 )
* fix: fix resource filters dropdown events
* fix: remove teleported:false
* fix: fix event selection event naming (#6753 )
* fix: removed console.log (#6754 )
* fix: rever await nextTick changes
* fix: redo linting changes
* fix(editor): Redraw node connections if adding more than one node to canvas (#6755 )
* fix(editor): Redraw node connections if adding more than one node to canvas
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Update position before connection two nodes
* Lint fix
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Alex Grozav <alex@grozav.com>
* fix(editor): Fix `ResourceMapper` unit tests (#6758 )
* ✔️ Fix matching columns test
* ✔️ Fix multiple matching columns test
* ✔️ Removing `skip` from the last test
* fix: Allow pasting a big workflow (#6760 )
* fix: pasting a big workflow
* chore: update comment
* refactor: move try/catch to function
* refactor: move try/catch to function
* fix(editor): Fix modal layer width
* fix: fix position changes
* fix: undo it.only
* fix: make undo/redo multiple steps more verbose
* fix: Fix value survey styles (#6764 )
* fix: fix value survey styles
* fix: lint
* Revert "fix: lint"
72869c431f✔️ Updating tag selectors in e2e tests
* ✔️ Using tab to blur dropdown after adding tags
* ✔️ Clicking on the New Tab button instead of the tags dropdown to open it
* Reverting merge changes added by mistake
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Alex Grozav <alex@grozav.com>
Co-authored-by: Csaba Tuncsik <csaba@n8n.io>
Co-authored-by: OlegIvaniv <me@olegivaniv.com>
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
Co-authored-by: Mutasem Aldmour <4711238+mutdmour@users.noreply.github.com>
* fix: Show NodeIcon tooltips by removing pointer-events: none (#6777 )
fix: show NodeIcon tooltips by removing pointer-events: none
* fix: Respect set modal widths (#6771 )
* feat: remove vue-fragment (no-changelog)
* feat: partial design-system migration
* feat: migrate info-accordion and info-tip components
* feat: migrate several components to vue 3
* feat: migrated several components
* feat: migrate several components
* feat: migrate several components
* feat: migrate several components
* feat: re-exported all design system components
* fix: fix design for popper components
* fix: editor kind of working, lots of issues to fix
* fix: fix several vue 3 migration issues
* fix: replace @change with @update:modelValue in several places
* fix: fix translation linking
* fix: fix inline-edit input
* fix: fix ndv and dialog design
* fix: update parameter input event bindings
* fix: rename deprecated lifecycle methods
* fix: fix json view mapping
* build: update lock file
* fix(editor): revisit last conflict with master and fix issues
* fix(editor): revisit last conflict with master and fix issues
* fix: fix expression editor bug causing code mirror to no longer be reactive
* fix: fix resource locator bug
* fix: fix vue-agile integration
* fix: remove global import for vue-agile
* fix: replace element-plus buttons with n8n-buttons everywhere
* fix(editor): Fix various element-plus styles (#6571 )
* fix(editor): Fix various element-plus styles
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Remove debugging code
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Address PR comments
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix(editor): Fix loading in production mode [Vue 3] (#6578 )
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix(editor): First round of e2e tests fixes with Vue 3 (#6579 )
* fix(editor): Fix broken smoke and workflow list e2e tests
* ✔️ Fix failing canvas action tests. Updating some selectors used in credentials and workflow tests
* feat: add vue 3 eslint rules and fix issues
* fix: fix tags-dropdown
* fix: fix white-space issues caused by i18n-t
* fix: rename non-generic click events
* fix: fix search in resources list layout
* fix: fix datatable paginator
* fix: fix popper select caret and dropdown size
* fix: add width to action-dropdown
* fix: fix workflow settings icon not being hidden
* fix: refactor newly added code
* fix: fix merge issue
* fix: fix ndv credentials watcher
* fix: fix workflow saving and grabber notch
* fix: fix nodes list panel transition
* fix: fix node title visibility
* fix: fix data unpinning
* fix: fix value access
* fix: show input panel only if trigger panel enabled or not trigger node
* fix: fix tags dropdown and executions status spcing
* fix(editor): Prevent execution list to load back when leaving the route (#6697 )
fix(editor): prevent execution list to load back when leaving the route
* fix: fix drawer visibility
* fix: fix expression toggle padding
* fix: fix expressions editor styling
* chore: prepare for testing
* fix: fix styling for el-button without patching
* test: fix unit tests in design-system
* test: fix most unit tests
* fix: remove import cycle.
* fix: fix personalization modal tests
* fix further resource mapper test adjustments
* fix: fix multiple tests and n8n-route attr duplication
* fix: fix source control tets
* fix: fixed remaining unit tests
* fix: fix workflows and credentials e2e tests
* fix: fix localizeNodeNames
* fix: update ndv e2e tests
* fix: fix popper left placement arrow
* fix: fix 5-ndv e2e tests
* fix: fix 6-code-node e2e tests
* fix(editor): Drop click outside directive from NodeCreator (#6716 )
* fix(editor): Drop click outside directive from NodeCreator
* fix(editor): make sure mouseup outside is unbound at least before the component is unmounted
* fix: fix 10-settings-log-streaming e2e tests
* fix: fix node redrawing
* fix: fix tooltip buttons styling
* fix: fix varous e2e suites
* fix: fix 15-scheduler-node e2e suite
* fix: fix route watcher
* fix: fixed param name update and credential edit
* feat: update event names
* refactor: Remove deprecated `$data` (#6576 )
Co-authored-by: Alex Grozav <alex@grozav.com>
* fix: fix 17-sharing e2e suite
* fix: fix tags dropdown
* fix: fix tags manager
* fix(editor): move :deep selectors to a separate scoped style block
* fix: fix sticky component and inline text edit
* fix: update e2e tests
* fix: remove button override references
* fix(editor): Adjust spacing in templates for Vue 3 (#6744 )
* fix(editor): Adjust spacing in templates
* fix: Undo unneeded change
* fix: Undo unneeded change
* fix(editor): Adjust NDV height for Vue 3 (#6742 )
fix(editor): Adjust NDV height
* fix(editor): Restore collapsed sidebar items for Vue 3 (#6743 )
fix(editor): Restore collapsed sidebar items
* fix: fix linting issues
* fix: fix design-system deps
* fix: post-merge fixes
* fix: update tests
* fix: increase timeout for executionslist tets
* chore: fix linting issue
* fix: fix 14-mapping e2e tests in ci
* fix: re-enable tests
* fix: fix workflow duplication e2e tests after tags update
* fix(editor): Change component prop to be typed
* fix: fix tags dropdown in duplicate wf modal
* fix: fix focus behaviour in tags selector
* fix: fix tag creation
* fix: fix log streaming e2e race condition
* fix(editor): Fix Vue 3 linting issues (#6748 )
* fix(editor): Fix Vue 3 linting issues
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix MainSidebar linter issues
* revert pnpm lock
* update pnpm lock file
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Alex Grozav <alex@grozav.com>
* fix(editor): Some css fixes for vue3 branch (#6749 )
* ✨ Fixing filter button height
* ✨ Update input modal button position
* ✨ Updating tags styling
* ✨ Fix event logging settings spacing
* 👕 Fixing lint errors
* fix: fix linting issues
* Revert to `// eslint-disable-next-line @typescript-eslint/no-misused-promises` disabling of mixins init
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix: fix css issue
* fix(editor): Lint fix
* fix(editor): Fix settings initialisation (#6750 )
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix: fix initial settings loading
* fix: replace realClick with click force
* fix: fix randomly failing mapping e2e tests
* fix(editor): Fix menu item event handling
* fix: fix resource filters dropdown events (#6752 )
* fix: fix resource filters dropdown events
* fix: remove teleported:false
* fix: fix event selection event naming (#6753 )
* fix: removed console.log (#6754 )
* fix: rever await nextTick changes
* fix: redo linting changes
* fix(editor): Redraw node connections if adding more than one node to canvas (#6755 )
* fix(editor): Redraw node connections if adding more than one node to canvas
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Update position before connection two nodes
* Lint fix
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Alex Grozav <alex@grozav.com>
* fix(editor): Fix `ResourceMapper` unit tests (#6758 )
* ✔️ Fix matching columns test
* ✔️ Fix multiple matching columns test
* ✔️ Removing `skip` from the last test
* fix: Allow pasting a big workflow (#6760 )
* fix: pasting a big workflow
* chore: update comment
* refactor: move try/catch to function
* refactor: move try/catch to function
* fix(editor): Fix modal layer width
* fix: fix position changes
* fix: undo it.only
* fix: make undo/redo multiple steps more verbose
* fix: Fix value survey styles (#6764 )
* fix: fix value survey styles
* fix: lint
* Revert "fix: lint"
72869c431f#6767 )
fix: drawer animation
* fix(editor): Fix source control buttons (#6769 )
* fix: Respect modal width
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Alex Grozav <alex@grozav.com>
Co-authored-by: Csaba Tuncsik <csaba@n8n.io>
Co-authored-by: OlegIvaniv <me@olegivaniv.com>
Co-authored-by: Milorad FIlipović <milorad@n8n.io>
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* fix(editor): Fix tooltip opening delay prop name (#6776 )
fix(editor): fix tooltip opening delay prop name
* fix(editor): Fix collapsed sub menu elements (#6778 )
* fix: Remove number input arrows (no-changelog) (#6782 )
fix: remove number input arrows
* ci: Update most of the dev tooling (no-changelog) (#6780 )
* fix(TheHive Node): Treat `ApiKey` as a secret (#6786 )
* test(editor): Prevent node view unload by default in e2e run (#6787 )
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix(editor): Resolve vue 3 related console-warnings (#6779 )
* fix(editor): Resolve vue 3 related console-warnings
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Use span as component wrapper instead of div
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Wrap popover component in span
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix(editor): Vue3 - Fix modal positioning and multi-select tag sizing (#6783 )
* ✨ Updating modals positioning within the overlay
* 💄 Implemented multi-select variant with small tabs
* ✔️ Removing password link clicks while modal is open in e2e tests
* Set generous timeout for $paramter resolve
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Oleg Ivaniv <me@olegivaniv.com>
* ci: Fix linting issues (no-changelog) (#6788 )
* ci: Fix linting (no-changelog)
* lintfix for nodes-base as well
* fix(editor): Fix code node highlight error (#6791 )
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* feat(core): Credentials for popular SecOps services, Part 1 (#6775 )
* refactor: Clear unused ESLint directives from BE packages (no-changelog) (#6798 )
* refactor(core): Cache workflow ownership (#6738 )
* refactor: Set up ownership service
* refactor: Specify cache keys and values
* refactor: Replace util with service calls
* test: Mock service in tests
* refactor: Use dependency injection
* test: Write tests
* refactor: Apply feedback from Omar and Micha
* test: Fix tests
* test: Fix missing spot
* refactor: Return user entity from cache
* refactor: More dependency injection!
* fix(editor): Prevent text edit dialog from re-opening in same tick (#6781 )
* fix: prevent reopenning textedit dialog in same tick
* fix: add same logic for code edit dialog
* fix: remove stop modifier
* fix: blur input field when closing modal, removing default element-plus behaviour
* test(editor): Do not chain invoke calls after assertions in 24-ndv-paired-item e2e spec (no-changelog) (#6800 )
* test(editor): Do not chaing invoke calls after assertions in 24-ndv-paired-item e2e spec
* Do not chaing realHover after assertion
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Remove .only
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix(Todoist Node): Fix issue with section id being ignored (#6799 )
* test(editor): Add canvas actions E2E tests (#6723 ) (#6790 )
* test(editor): Add canvas actions E2E tests (#6723 )
* test(editor): Add canvas actions E2E tests
* test(editor): Open category items in node creator when category dropped on canvas
* test(editor): Have new position counted only once in drag
* test(editor): rename test
(cherry picked from commit 052d82b220#6797 )
* fix: Review fixes
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix: Fin locales
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Fix merging errors
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Map erros based on statusCode
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Fix code replacing
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Fix code formatting
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Address review points
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Optionally access total_tokens
* Clean-up Ask AI modal
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Store prompt in sessionStorage
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Improve schema generation, only get parent nodes
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Send error messages to telemetry, aske before switching tabs
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Add locale
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Post-merge cleanup
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Move Ask AI into separate folder
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Lint fix
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Constants lint fix
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Add Ask AI e2e tests and fix linting issues
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Move CircleLoader to design-lib
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Replace circle-lodaer and move el-tabs styles to n8n theme
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Fix placeholder & e2e tests
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Remove old CircleLoader
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: ricardo <ricardoespinoza105@gmail.com>
Co-authored-by: Alex Grozav <alex@grozav.com>
Co-authored-by: Romain Dunand <romain@1-more-thing.com>
Co-authored-by: Jon <jonathan.bennetts@gmail.com>
Co-authored-by: Michael Kret <88898367+michael-radency@users.noreply.github.com>
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <netroy@users.noreply.github.com>
Co-authored-by: Csaba Tuncsik <csaba@n8n.io>
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
Co-authored-by: Omar Ajoue <krynble@gmail.com>
Co-authored-by: Michael Auerswald <michael.auerswald@gmail.com>
Co-authored-by: Milorad FIlipović <milorad@n8n.io>
Co-authored-by: Michael Kret <michael.k@radency.com>
Co-authored-by: Val <68596159+valya@users.noreply.github.com>
Co-authored-by: Marcus <56945030+maspio@users.noreply.github.com>
Co-authored-by: Jordan Hall <Jordan@libertyware.co.uk>
Co-authored-by: qg-horie <36725144+qg-horie@users.noreply.github.com>
Co-authored-by: Ricardo Espinoza <ricardo@n8n.io>
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
Co-authored-by: Ali Afsharzadeh <afsharzadeh8@gmail.com>
Co-authored-by: Giulio Andreini <g.andreini@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Mutasem Aldmour <4711238+mutdmour@users.noreply.github.com>
2023-08-16 13:08:10 +02:00
कारतोफ्फेलस्क्रिप्ट™
223284e227
ci: Fix occasional failure of 19-execution.cy.ts (no-changelog) ( #6887 )
2023-08-09 11:12:27 +02:00
Csaba Tuncsik
08982ede4c
fix(editor): Do not show mapping discoverability tooltip after dismiss ( #6862 )
...
* fix(editor): Do not show mapping discoverability tooltip after dismiss
* test: add tooltip design system component test
* fix(editor): no need to dismiss mapping tooltip multiple times
2023-08-07 20:16:01 +02:00
कारतोफ्फेलस्क्रिप्ट™
8126181e18
fix(editor): Avoid infinite loops when resolving the expression {{ $parameter }} (no-changelog) ( #6855 )
...
Co-authored-by: Oleg Ivaniv <me@olegivaniv.com>
2023-08-07 11:52:33 +02:00
Milorad FIlipović
4ac4b850dd
fix(editor): Fix redo when adding node on connection ( #6833 )
...
* fix(editor): Fix redo when adding node on connection
* ✅ Adding tests for pushed nodes
* ✔️ Updating drag command for dragging nodes on the canvas
* 👌 Handling drag end with a command option
2023-08-02 12:48:55 +02:00
Csaba Tuncsik
3d6f5a24af
test(editor): Add canvas actions E2E tests ( #6723 ) ( #6790 )
...
* test(editor): Add canvas actions E2E tests (#6723 )
* test(editor): Add canvas actions E2E tests
* test(editor): Open category items in node creator when category dropped on canvas
* test(editor): Have new position counted only once in drag
* test(editor): rename test
(cherry picked from commit 052d82b220
2023-07-31 12:32:08 +02:00
OlegIvaniv
3801130c7b
test(editor): Do not chain invoke calls after assertions in 24-ndv-paired-item e2e spec (no-changelog) ( #6800 )
...
* test(editor): Do not chaing invoke calls after assertions in 24-ndv-paired-item e2e spec
* Do not chaing realHover after assertion
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Remove .only
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
2023-07-31 11:55:22 +02:00
Milorad FIlipović
4e491b754f
fix(editor): Vue3 - Fix modal positioning and multi-select tag sizing ( #6783 )
...
* ✨ Updating modals positioning within the overlay
* 💄 Implemented multi-select variant with small tabs
* ✔️ Removing password link clicks while modal is open in e2e tests
* Set generous timeout for $paramter resolve
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Oleg Ivaniv <me@olegivaniv.com>
2023-07-28 17:57:25 +02:00
OlegIvaniv
e824ab057d
test(editor): Prevent node view unload by default in e2e run ( #6787 )
...
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
2023-07-28 16:46:26 +02:00
Milorad FIlipović
cf00ba7089
fix(editor): Close tags dropdown when modal is opened ( #6766 )
...
* feat: remove vue-fragment (no-changelog)
* feat: partial design-system migration
* feat: migrate info-accordion and info-tip components
* feat: migrate several components to vue 3
* feat: migrated several components
* feat: migrate several components
* feat: migrate several components
* feat: migrate several components
* feat: re-exported all design system components
* fix: fix design for popper components
* fix: editor kind of working, lots of issues to fix
* fix: fix several vue 3 migration issues
* fix: replace @change with @update:modelValue in several places
* fix: fix translation linking
* fix: fix inline-edit input
* fix: fix ndv and dialog design
* fix: update parameter input event bindings
* fix: rename deprecated lifecycle methods
* fix: fix json view mapping
* build: update lock file
* fix(editor): revisit last conflict with master and fix issues
* fix(editor): revisit last conflict with master and fix issues
* fix: fix expression editor bug causing code mirror to no longer be reactive
* fix: fix resource locator bug
* fix: fix vue-agile integration
* fix: remove global import for vue-agile
* fix: replace element-plus buttons with n8n-buttons everywhere
* fix(editor): Fix various element-plus styles (#6571 )
* fix(editor): Fix various element-plus styles
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Remove debugging code
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Address PR comments
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix(editor): Fix loading in production mode [Vue 3] (#6578 )
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix(editor): First round of e2e tests fixes with Vue 3 (#6579 )
* fix(editor): Fix broken smoke and workflow list e2e tests
* ✔️ Fix failing canvas action tests. Updating some selectors used in credentials and workflow tests
* feat: add vue 3 eslint rules and fix issues
* fix: fix tags-dropdown
* fix: fix white-space issues caused by i18n-t
* fix: rename non-generic click events
* fix: fix search in resources list layout
* fix: fix datatable paginator
* fix: fix popper select caret and dropdown size
* fix: add width to action-dropdown
* fix: fix workflow settings icon not being hidden
* fix: refactor newly added code
* fix: fix merge issue
* fix: fix ndv credentials watcher
* fix: fix workflow saving and grabber notch
* fix: fix nodes list panel transition
* fix: fix node title visibility
* fix: fix data unpinning
* fix: fix value access
* fix: show input panel only if trigger panel enabled or not trigger node
* fix: fix tags dropdown and executions status spcing
* fix(editor): Prevent execution list to load back when leaving the route (#6697 )
fix(editor): prevent execution list to load back when leaving the route
* fix: fix drawer visibility
* fix: fix expression toggle padding
* fix: fix expressions editor styling
* chore: prepare for testing
* fix: fix styling for el-button without patching
* test: fix unit tests in design-system
* test: fix most unit tests
* fix: remove import cycle.
* fix: fix personalization modal tests
* fix further resource mapper test adjustments
* fix: fix multiple tests and n8n-route attr duplication
* fix: fix source control tets
* fix: fixed remaining unit tests
* fix: fix workflows and credentials e2e tests
* fix: fix localizeNodeNames
* fix: update ndv e2e tests
* fix: fix popper left placement arrow
* fix: fix 5-ndv e2e tests
* fix: fix 6-code-node e2e tests
* fix(editor): Drop click outside directive from NodeCreator (#6716 )
* fix(editor): Drop click outside directive from NodeCreator
* fix(editor): make sure mouseup outside is unbound at least before the component is unmounted
* fix: fix 10-settings-log-streaming e2e tests
* fix: fix node redrawing
* fix: fix tooltip buttons styling
* fix: fix varous e2e suites
* fix: fix 15-scheduler-node e2e suite
* fix: fix route watcher
* fix: fixed param name update and credential edit
* feat: update event names
* refactor: Remove deprecated `$data` (#6576 )
Co-authored-by: Alex Grozav <alex@grozav.com>
* fix: fix 17-sharing e2e suite
* fix: fix tags dropdown
* fix: fix tags manager
* fix(editor): move :deep selectors to a separate scoped style block
* fix: fix sticky component and inline text edit
* fix: update e2e tests
* fix: remove button override references
* fix(editor): Adjust spacing in templates for Vue 3 (#6744 )
* fix(editor): Adjust spacing in templates
* fix: Undo unneeded change
* fix: Undo unneeded change
* fix(editor): Adjust NDV height for Vue 3 (#6742 )
fix(editor): Adjust NDV height
* fix(editor): Restore collapsed sidebar items for Vue 3 (#6743 )
fix(editor): Restore collapsed sidebar items
* fix: fix linting issues
* fix: fix design-system deps
* fix: post-merge fixes
* fix: update tests
* fix: increase timeout for executionslist tets
* chore: fix linting issue
* fix: fix 14-mapping e2e tests in ci
* fix: re-enable tests
* fix: fix workflow duplication e2e tests after tags update
* fix(editor): Change component prop to be typed
* fix: fix tags dropdown in duplicate wf modal
* fix: fix focus behaviour in tags selector
* fix: fix tag creation
* fix: fix log streaming e2e race condition
* fix(editor): Fix Vue 3 linting issues (#6748 )
* fix(editor): Fix Vue 3 linting issues
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix MainSidebar linter issues
* revert pnpm lock
* update pnpm lock file
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Alex Grozav <alex@grozav.com>
* fix(editor): Some css fixes for vue3 branch (#6749 )
* ✨ Fixing filter button height
* ✨ Update input modal button position
* ✨ Updating tags styling
* ✨ Fix event logging settings spacing
* 👕 Fixing lint errors
* fix: fix linting issues
* Revert to `// eslint-disable-next-line @typescript-eslint/no-misused-promises` disabling of mixins init
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix: fix css issue
* fix(editor): Lint fix
* fix(editor): Fix settings initialisation (#6750 )
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix: fix initial settings loading
* fix: replace realClick with click force
* fix: fix randomly failing mapping e2e tests
* fix(editor): Fix menu item event handling
* fix: fix resource filters dropdown events (#6752 )
* fix: fix resource filters dropdown events
* fix: remove teleported:false
* fix: fix event selection event naming (#6753 )
* fix: removed console.log (#6754 )
* fix: rever await nextTick changes
* fix: redo linting changes
* fix(editor): Redraw node connections if adding more than one node to canvas (#6755 )
* fix(editor): Redraw node connections if adding more than one node to canvas
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Update position before connection two nodes
* Lint fix
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Alex Grozav <alex@grozav.com>
* fix(editor): Fix `ResourceMapper` unit tests (#6758 )
* ✔️ Fix matching columns test
* ✔️ Fix multiple matching columns test
* ✔️ Removing `skip` from the last test
* fix: Allow pasting a big workflow (#6760 )
* fix: pasting a big workflow
* chore: update comment
* refactor: move try/catch to function
* refactor: move try/catch to function
* fix(editor): Fix modal layer width
* fix: fix position changes
* fix: undo it.only
* fix: make undo/redo multiple steps more verbose
* fix: Fix value survey styles (#6764 )
* fix: fix value survey styles
* fix: lint
* Revert "fix: lint"
72869c431f✔️ Updating tag selectors in e2e tests
* ✔️ Using tab to blur dropdown after adding tags
* ✔️ Clicking on the New Tab button instead of the tags dropdown to open it
* Reverting merge changes added by mistake
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Alex Grozav <alex@grozav.com>
Co-authored-by: Csaba Tuncsik <csaba@n8n.io>
Co-authored-by: OlegIvaniv <me@olegivaniv.com>
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
Co-authored-by: Mutasem Aldmour <4711238+mutdmour@users.noreply.github.com>
2023-07-28 10:45:46 +02:00
Alex Grozav
dd6a4c956a
feat(editor): Migrate Design System and Editor UI to Vue 3 ( #6476 )
...
* feat: remove vue-fragment (no-changelog)
* feat: partial design-system migration
* feat: migrate info-accordion and info-tip components
* feat: migrate several components to vue 3
* feat: migrated several components
* feat: migrate several components
* feat: migrate several components
* feat: migrate several components
* feat: re-exported all design system components
* fix: fix design for popper components
* fix: editor kind of working, lots of issues to fix
* fix: fix several vue 3 migration issues
* fix: replace @change with @update:modelValue in several places
* fix: fix translation linking
* fix: fix inline-edit input
* fix: fix ndv and dialog design
* fix: update parameter input event bindings
* fix: rename deprecated lifecycle methods
* fix: fix json view mapping
* build: update lock file
* fix(editor): revisit last conflict with master and fix issues
* fix(editor): revisit last conflict with master and fix issues
* fix: fix expression editor bug causing code mirror to no longer be reactive
* fix: fix resource locator bug
* fix: fix vue-agile integration
* fix: remove global import for vue-agile
* fix: replace element-plus buttons with n8n-buttons everywhere
* fix(editor): Fix various element-plus styles (#6571 )
* fix(editor): Fix various element-plus styles
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Remove debugging code
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Address PR comments
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix(editor): Fix loading in production mode [Vue 3] (#6578 )
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix(editor): First round of e2e tests fixes with Vue 3 (#6579 )
* fix(editor): Fix broken smoke and workflow list e2e tests
* ✔️ Fix failing canvas action tests. Updating some selectors used in credentials and workflow tests
* feat: add vue 3 eslint rules and fix issues
* fix: fix tags-dropdown
* fix: fix white-space issues caused by i18n-t
* fix: rename non-generic click events
* fix: fix search in resources list layout
* fix: fix datatable paginator
* fix: fix popper select caret and dropdown size
* fix: add width to action-dropdown
* fix: fix workflow settings icon not being hidden
* fix: refactor newly added code
* fix: fix merge issue
* fix: fix ndv credentials watcher
* fix: fix workflow saving and grabber notch
* fix: fix nodes list panel transition
* fix: fix node title visibility
* fix: fix data unpinning
* fix: fix value access
* fix: show input panel only if trigger panel enabled or not trigger node
* fix: fix tags dropdown and executions status spcing
* fix(editor): Prevent execution list to load back when leaving the route (#6697 )
fix(editor): prevent execution list to load back when leaving the route
* fix: fix drawer visibility
* fix: fix expression toggle padding
* fix: fix expressions editor styling
* chore: prepare for testing
* fix: fix styling for el-button without patching
* test: fix unit tests in design-system
* test: fix most unit tests
* fix: remove import cycle.
* fix: fix personalization modal tests
* fix further resource mapper test adjustments
* fix: fix multiple tests and n8n-route attr duplication
* fix: fix source control tets
* fix: fixed remaining unit tests
* fix: fix workflows and credentials e2e tests
* fix: fix localizeNodeNames
* fix: update ndv e2e tests
* fix: fix popper left placement arrow
* fix: fix 5-ndv e2e tests
* fix: fix 6-code-node e2e tests
* fix(editor): Drop click outside directive from NodeCreator (#6716 )
* fix(editor): Drop click outside directive from NodeCreator
* fix(editor): make sure mouseup outside is unbound at least before the component is unmounted
* fix: fix 10-settings-log-streaming e2e tests
* fix: fix node redrawing
* fix: fix tooltip buttons styling
* fix: fix varous e2e suites
* fix: fix 15-scheduler-node e2e suite
* fix: fix route watcher
* fix: fixed param name update and credential edit
* feat: update event names
* refactor: Remove deprecated `$data` (#6576 )
Co-authored-by: Alex Grozav <alex@grozav.com>
* fix: fix 17-sharing e2e suite
* fix: fix tags dropdown
* fix: fix tags manager
* fix(editor): move :deep selectors to a separate scoped style block
* fix: fix sticky component and inline text edit
* fix: update e2e tests
* fix: remove button override references
* fix(editor): Adjust spacing in templates for Vue 3 (#6744 )
* fix(editor): Adjust spacing in templates
* fix: Undo unneeded change
* fix: Undo unneeded change
* fix(editor): Adjust NDV height for Vue 3 (#6742 )
fix(editor): Adjust NDV height
* fix(editor): Restore collapsed sidebar items for Vue 3 (#6743 )
fix(editor): Restore collapsed sidebar items
* fix: fix linting issues
* fix: fix design-system deps
* fix: post-merge fixes
* fix: update tests
* fix: increase timeout for executionslist tets
* chore: fix linting issue
* fix: fix 14-mapping e2e tests in ci
* fix: re-enable tests
* fix: fix workflow duplication e2e tests after tags update
* fix(editor): Change component prop to be typed
* fix: fix tags dropdown in duplicate wf modal
* fix: fix focus behaviour in tags selector
* fix: fix tag creation
* fix: fix log streaming e2e race condition
* fix(editor): Fix Vue 3 linting issues (#6748 )
* fix(editor): Fix Vue 3 linting issues
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix MainSidebar linter issues
* revert pnpm lock
* update pnpm lock file
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Alex Grozav <alex@grozav.com>
* fix(editor): Some css fixes for vue3 branch (#6749 )
* ✨ Fixing filter button height
* ✨ Update input modal button position
* ✨ Updating tags styling
* ✨ Fix event logging settings spacing
* 👕 Fixing lint errors
* fix: fix linting issues
* Revert to `// eslint-disable-next-line @typescript-eslint/no-misused-promises` disabling of mixins init
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix: fix css issue
* fix(editor): Lint fix
* fix(editor): Fix settings initialisation (#6750 )
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix: fix initial settings loading
* fix: replace realClick with click force
* fix: fix randomly failing mapping e2e tests
* fix(editor): Fix menu item event handling
* fix: fix resource filters dropdown events (#6752 )
* fix: fix resource filters dropdown events
* fix: remove teleported:false
* fix: fix event selection event naming (#6753 )
* fix: removed console.log (#6754 )
* fix: rever await nextTick changes
* fix: redo linting changes
* fix(editor): Redraw node connections if adding more than one node to canvas (#6755 )
* fix(editor): Redraw node connections if adding more than one node to canvas
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Update position before connection two nodes
* Lint fix
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Alex Grozav <alex@grozav.com>
* fix(editor): Fix `ResourceMapper` unit tests (#6758 )
* ✔️ Fix matching columns test
* ✔️ Fix multiple matching columns test
* ✔️ Removing `skip` from the last test
* fix: Allow pasting a big workflow (#6760 )
* fix: pasting a big workflow
* chore: update comment
* refactor: move try/catch to function
* refactor: move try/catch to function
* fix(editor): Fix modal layer width
* fix: fix position changes
* fix: undo it.only
* fix: make undo/redo multiple steps more verbose
* fix: Fix value survey styles (#6764 )
* fix: fix value survey styles
* fix: lint
* Revert "fix: lint"
72869c431f#6767 )
fix: drawer animation
* fix(editor): Fix source control buttons (#6769 )
* fix(editor): Fix App loading & auth (#6768 )
* fix(editor): Fix App loading & auth
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Await promises
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Fix eslint error
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Csaba Tuncsik <csaba@n8n.io>
Co-authored-by: OlegIvaniv <me@olegivaniv.com>
Co-authored-by: Milorad FIlipović <milorad@n8n.io>
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
Co-authored-by: Mutasem Aldmour <4711238+mutdmour@users.noreply.github.com>
2023-07-28 09:51:07 +02:00
OlegIvaniv
ed09e9c695
Revert "test(editor): Add canvas actions E2E tests" ( #6736 )
...
Revert "test(editor): Add canvas actions E2E tests (#6723 )"
This reverts commit 052d82b220
2023-07-25 13:26:11 +02:00
Csaba Tuncsik
052d82b220
test(editor): Add canvas actions E2E tests ( #6723 )
...
* test(editor): Add canvas actions E2E tests
* test(editor): Open category items in node creator when category dropped on canvas
* test(editor): Have new position counted only once in drag
* test(editor): rename test
2023-07-24 15:38:37 +02:00
कारतोफ्फेलस्क्रिप्ट™
710421fcc3
ci: Fix running e2e tests in dev mode (no-changelog) ( #6717 )
2023-07-21 11:48:23 +02:00
Michael Kret
b69d20c12e
feat(Airtable Node): Overhaul ( #6200 )
2023-07-17 19:42:30 +03:00
Milorad FIlipović
4240e76253
feat(editor): Implement new banners framework ( #6603 )
...
* ⚡ Implemented new grid row - banners
* ✨ Fixing node creator and executions sidebar position after layout update
* 💄 Added configurable round corners to the Callout component
* ⚡ Fixing mouse position detection and main tab bar position
* ⚡ Implemented basic banner component structure
* ⚡ Implemented banner state and dismiss logic
* ⚡ Fixing grid layout. Updating banners height state dynamically
* ⚡ Fix zoom to fit position, mouse position in demo mode and callout vertical alignment
* ⚡ Implementing proper trial banners logic
* 💄 Only showing execution usage data once the sidebar is fully expanded
* ✨ Implemented permanent/temporary dismiss logic for v1 flag
* ⚡ Minor refactoring of banner logic
* ⚡ Updating permanent dismiss logic to work with all banners
* 👕 Fixing linting errors
* ✔️ Updating Callout component test snapshots
* 💄 Tweaking zoom to fit position
* ✔️ Updating testing endpoints to use new store data
* ✅ Added banners unit tests
* ✔️ Fixing failing banner tests
* ✅ Added more banner tests
* ⚡ Updating banners dimensions on resize, removing leftover code
* ✔️ Removing store import from API file
* 👕 Fixing lint errors
* ⚡ Updating migration files
* ⚡ Using query parameters in migrations
* 👌 Addressing design review feedback
* ⚡ Updating upgrade plan button click
* ⚡ Updating the migrations syntax
* 👌 Updating permanent banner dismiss endpoint and back-end logic
* 👌 Refactoring trial banner component and ui store
* 👌 Addressing more points from code review
* 👌 Moving DOM logic from the store
* ✔️ Updated callout component snapshots
* 👌 Updating mysql migration file
* ✔️ Updating e2e test canvas coordinates after setting it's position to absolute
* 👌 Addressing back-end review feedback
* 👌 Improving typing around banners
* 👕 Fixing lint errors
2023-07-14 15:36:17 +02:00
कारतोफ्फेलस्क्रिप्ट™
66e43b279b
ci: e2e tests don't need to enable saving manual executions
...
saving manual executions is enabled by default now
2023-07-05 20:36:58 +02:00
कारतोफ्फेलस्क्रिप्ट™
e33cc2c27c
Merge remote-tracking branch 'origin/master' into release/1.0.1
2023-07-05 20:01:24 +02:00
OlegIvaniv
f89ef83c76
feat(editor): Prevent saving of workflow when canvas is loading ( #6497 )
...
* feat(editor): Prevent saving of pristine workflow
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Prevent saving if loading
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Fix 7-workflow-actions spec
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Restrict delay intercept to GET only
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Wait for WF patch
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Add helper to remove all active WFs in e2e
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Use META_KEY env var
* Remove cy.wait
* Delete debugging DB reset console log
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Fix clashin mixins `isReadOnly` property
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
2023-06-27 13:05:20 +02:00
Iván Ovejero
52e9882a32
refactor: Remove triggers and actions experiment (no-changelog) ( #6512 )
...
* refactor: Remove triggers and actions experiment
* fix: Use `value` for computed property
* test: Fix e2e
2023-06-27 10:33:21 +02:00
Iván Ovejero
b66d151066
refactor: Remove triggers and actions experiment (no-changelog) ( #6512 )
...
* refactor: Remove triggers and actions experiment
* fix: Use `value` for computed property
* test: Fix e2e
2023-06-26 13:33:31 +02:00
Ricardo Espinoza
3db2707b8e
fix: Show error when referencing node that exist but has not been executed ( #6496 )
...
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-06-23 01:45:54 +02:00
कारतोफ्फेलस्क्रिप्ट™
0e071724ee
ci: Refactor e2e tests to delete boilerplate code (no-changelog) ( #6524 )
2023-06-23 00:38:12 +02:00
Jan Oberhauser
0287d5becd
feat(core): Change node execution order (most top-left one first) ( #6246 )
...
* feat(core): Change node execution order (most top-left one first)
* ⚡ Fix issue with multi-output-nodes
* ⚡ Remove not needed meta-entry in test
* fix the e2e test
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-06-22 21:11:29 +02:00
Iván Ovejero
1197811a1e
fix(core)!: Allow syntax errors and expression errors to fail executions ( #6352 )
...
* fix: Unify expression error behavior for v1
* fix: Add `package.json` to `tsconfig.build.json`
* fix: Make `isFrontend` a constant
* fix: Use CommonJS require to read version
* fix: Use `JSON.parse()` and `fs.readFileSync()`
* feat(editor): Make WF name a link on /executions (#6354 )
* make wf name a link in exec view
* link color
* make wf name a link in exec view
* link color
---------
Co-authored-by: Alex Grozav <alex@grozav.com>
* fix: Try restoring inclusions in tsconfig files
* fix: Try with copy
* refactor: Switch base branch and remove global toggle
* chore: Remove unrelated changes
* chore: Restore lockfile
* fix: Ensure all expression errors fail executions
* uncaught ExpressionErrors should not fail e2e tests
---------
Co-authored-by: romainminaud <romain.minaud@gmail.com>
Co-authored-by: Alex Grozav <alex@grozav.com>
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-06-22 21:04:59 +02:00
Iván Ovejero
8c008f5d22
refactor(core)!: Remove basic-auth, external-jwt-auth, and no-auth options ( #6362 )
...
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-06-22 20:03:47 +02:00
Alex Grozav
0154a97773
feat(editor): Replace root events with event bus events (no-changelog) ( #6454 )
...
* feat: replace root events with event bus events
* fix: prevent cypress from replacing global with globalThis in import path
* feat: remove emitter mixin
* fix: replace component events with event bus
* fix: fix linting issue
* fix: fix breaking expression switch
* chore: prettify ndv e2e suite code
2023-06-20 13:00:53 +03:00
Alex Grozav
596cf07e42
feat: Replace all Vue.set usages with direct assignment and spread operator (no-changelog) ( #6280 )
...
* refactor: replace all Vue.set usages with direct assignment and spread operator
* chore: fix linting issue
* fix: fix updateNodeAtIndex function
* fix: various post-refactoring fixes
* fix: refactor recently added Vue.set directive
2023-06-15 15:30:05 +03:00
Alex Grozav
c2afed4ca1
fix: Fix randomly failing scheduler node e2e tests (no-changelog) ( #6430 )
...
* fix: fix randomly failing scheduler node e2e tests (no-changelog)
* chore: rename variable name
* fix: update all cy.request calls to use backend base url
* fix: add back mistkenly removed workflowId code
* fix: remove unnecessary .then
* fix: update how workflowId is retrieved
2023-06-15 14:40:23 +03:00
Ricardo Espinoza
e95e8de500
refactor(editor): Remove user activation modal (no-changelog) ( #6361 )
...
* Remove user activation modal
* remove export from index.ts
* Update pnpm-lock.yaml
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-06-05 13:47:06 -04:00
कारतोफ्फेलस्क्रिप्ट™
7a7b884793
ci: Reset DB only once per e2e test (no-changelog) ( #6216 )
2023-05-26 17:15:06 +02:00
Alex Grozav
b4fd9ba94d
fix: Add itemSize config to workflows view recycle scroller (no-changelog) ( #6238 )
...
* fix: Add itemSize config to workflows view recycle scroller (no-changelog)
* test: add unit tests to cover recycle scroller height
* fix: revert allWorkflows change
* fix: fix linting issue
* fix: fix sharing e2e test flakiness
2023-05-16 12:07:55 +03:00
Milorad FIlipović
13bcec1661
feat(editor): Updating node reference pattern in expression editor ( #6228 )
...
* feat(editor): Updating node reference pattern in expression editor
* ⚡ Updated node ref when dragging data, telemetry and some comments
* ✔️ Updating tests
* 🔨 Removing old telemetry code, updating the current one based on the review feedback
* ✔️ Updating mapping e2e tests
2023-05-12 11:45:10 +02:00
Mutasem Aldmour
c7177719e5
fix: Prevent overflow when rendering expression hints ( #6214 )
...
* fix: Prevent whitespace overflow
* fix: show overflow ellipsis
* chore: add comment
* chore: clean up other approach
* test: update tests, fix test
* test: uncomment test
2023-05-10 10:32:09 +02:00
OlegIvaniv
e88232ede2
test: Address flaky setup e2e (no-changelog) ( #6085 )
...
* test: Add /setup intercept for `skipSetup` command (no-changelog)
* Drop all tables for e2e reset, intercept account setup request
* Fix linting issues
* Allow to skip setup account request intercept and linting fixes
* Make sure variables are loaded
* Use PATCH for enabling of e2e features
* Do not exclude migration table from truncation
* Add user sign-up intercept
2023-05-03 14:06:06 +02:00
Iván Ovejero
8862e1e7df
fix(editor): Restrict [empty] in parameter input hint to zero-length string ( #6003 )
...
* 🚧 Quick test
* ⚡ Adjust to new requirements
* ⚡ Account for 2x double quotes
* 🔥 Remove excess single quote
* ⏪ Revert per new requirements
* ⏪ Undo more changes to minimize diff
* ⏪ New requirement changes
* 🐛 Prevent excess whitespace from HTML formatting
* 🚚 Rename computed property
* 🧪 Set up e2e tests for parameter input hint
* 🚧 Experiments with unit tests
Pinia stores setup process WIP.
* 🔥 Remove e2e test
* ⏪ Restore `test` command
* 🔥 Remove unit test stub
* 🔥 Remove logging
* 🔥 Remove test ID
* 🧪 Fix e2e test
* 🧪 Tighten text check
2023-05-03 09:41:40 +02:00
Milorad FIlipović
b17d5f9aa0
feat(editor): Add support for loadOptionsDependsOn to RLC ( #6101 )
...
* feat(editor): Add support for `loadOptionsDependsOn` to the Resource Locator component
* 🔥 Removing leftover log
* ✅ Added e2e tests for ResourceLocator component
2023-04-28 12:14:31 +02:00
Omar Ajoue
2e73f4abd0
fix: Correctly allow sharees to test credential when opening the modal ( #6111 )
...
* fix: Prevent incorrect error message when sharee opens a credential
* test: Add testing for automated credential testing
* chore: Remove unnecessary comments
2023-04-28 12:02:28 +02:00
Iván Ovejero
39b544271d
refactor(editor): Add skip option to activation modal ( #6092 )
...
⚡ Add skip option to activation modal
2023-04-27 15:21:53 -04:00
OlegIvaniv
390841bbf0
feat(editor): Enhance Node Creator actions view ( #5954 )
...
* WIP
* WIP
* Extract actions into composable
* WIP: Preserve categories when searching
* WIP
* WIP: Tweak styles
* WIP: Refactor node creator
* WIP: Finish Node Creator node view/subcategories refactor
* WIP: Finished actions refactor
* Cleanup & Lintfix
* WIP: Improve memory managment
* Fix interactions
* WIP
* WIP: Keyboard navigation
* Improve keyboard navigation and memory managment
* Finished view refactor
* FIx custom api calls and activation callouts
* Fix actions tracking and cleanup
* Product review fixes
* Telemetry fixes
* Fix node creator e2es
* Set action name font size and actionsEmpty font weight
* Fix failing credentials spec
* Make sure to select first action item when switching from nodes panel to actions panel
* Add actions panel e2e tests
* Cleanup
* Fix actions generation and cleanup
* Add correct Learn More link and adjust displaying of trigger icon
* Change trigger icon condition to use nodeType group
* Cleanup nodeTypesUtils and snapshots and lintfixes
* Lint fixes
* Refine logic to show trigger icon in node creator
* Add unit tests & clean up
* Add `003_auto_insert_action` experiment, hide empty sections for opposite root view
* Lintfix
* Do not show empty category tooltips and only show activation callout in triger root view
* Fix no-results node creator view
* Spacings tweaks and root rendering logic adjustment
* Add unit tests
* Lint and e2e fixes
* Revert CLI changes, fix unit tests
* Remove useless comments
* Sync master, replace $externalHooks mixin
* Lint fix
* Focus first action when panel slides in, not category
* Address PR comments
* Lint fix
* Remove `setAddedNodeActionParameters` optional track param
* Further simplify setAddedNodeActionParameters
* Fix pnpn lock file
* Fix types imports
* Fix 13-pinning spec
2023-04-26 09:18:10 +02:00
कारतोफ्फेलस्क्रिप्ट™
ca4e0df90b
refactor(editor): Replace monaco-editor/prismjs with CodeMirror ( #5983 )
...
Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
Co-authored-by: Milorad FIlipović <milorad@n8n.io>
Co-authored-by: Alex Grozav <alex@grozav.com>
2023-04-25 16:57:21 +02:00
Mutasem Aldmour
feb2ba09b9
test: Add run linking tests ( #6061 )
...
* test: Add link/unlink test
* test: Add run linking
* test: uncomment other tests
* test: change click
* test: bring back tests, update click
* test: fix flaky paired item test
* test: update flaky tests
* test: add timeouts
* test: update import
2023-04-24 11:07:32 +02:00
Mutasem Aldmour
649389edad
test: Add stickies tests ( #5413 )
...
* test: Add tests for stickies
* test: add sticky basic test
* test: add size dragging tests
* test: add delete sticky test
* test: add editing test
* test: update editing text
* test: add expansion tests
* test: add more tests
* test: clean up tests
* refactor: update dragging tests to make sense
* refactor: upate drag right test
* test: add shrink from right test
* test: refactor some more
* test: fix all tests
* test: clean up
* test: update number
* test: add z-index tests
* test: address comments
* test: fix mistake
* test: wait on save
* test: try button instead
2023-04-21 15:37:09 +02:00
Mutasem Aldmour
a19d4447ac
fix(editor): Resolve expressions for grandparent nodes ( #5859 )
...
* fix(editor): Resolve expressions for grandparent nodes
* test: add tests
* test: add tests for bug
* test: add todos
* test: lintfix
* test: add small waits
* test: add linking tests
* test: add test for branch mapping
* test: update workflow values
* test: comment out test
* test: fix up tests with new values
* chore: remove todos
* test: add ticket number for broken test
* test: refactor a bit
* test: uncomment
* test: fix mapping test
* fix: lint issue
* test: split tests
* Revert "test: split tests"
0290d51d7c
2023-04-21 14:08:51 +02:00
Alex Grozav
723f81bab0
feat: Add variables e2e tests (no-changelog) ( #6027 )
...
* fix: fix n8n-checkbox alignment
* fix: use css variables in checkbox inner margin-top
* test: update snapshots
* feat: add variables e2e tests (no-changelog)
* test: update snapshot
2023-04-20 15:08:13 +03:00
OlegIvaniv
0970ec066d
fix(editor): Fix memory leak in Node Detail View by correctly unsubscribing from event buses ( #6021 )
2023-04-20 12:26:14 +02:00
Deborah
c3d19f52a2
docs: Update the info URL for updating n8n (no-changelog) ( #6018 )
...
update the info URL for updating n8n
2023-04-20 09:10:42 +01:00
Ricardo Espinoza
0c10fbc83f
fix: Small changes to user activation modal (no-changelog) ( #5962 )
2023-04-18 07:28:50 -04:00
Iván Ovejero
b13b7d73e7
fix(core): Fix paired item returning wrong data ( #5898 )
...
* 🐛 Fix paired item returning wrong data
* 🧪 Add e2e test
* ⏪ Restore injection for simulated execution
2023-04-14 13:33:27 +02:00
कारतोफ्फेलस्क्रिप्ट™
bdb5c81a15
ci: Fix E2E tests on master (no-changelog) ( #5960 )
2023-04-12 13:37:25 +02:00
Ricardo Espinoza
725393dae6
feat(editor): Add user activation survey ( #5677 )
...
* ⚡ Add user activation survey
* Fix typo
* Avoid showing the modal when there is a modal view
* Allow to redirect to specific execution
* Improve structure
* Handle errors when sharing feedback
* update withFeatureFlag function
* Fix linting issue
* Set user activation flag on workflowExecutionCompleted event
* Revert update user settings functionality
* Remove unnecessary changes
* fix linting issue
* account for new functionality in tests
* Small improvements
* keep once instace of the model open between tabs
* Add sorting to GET /executions
* type parameters for GET /executions
a
* Add constant for local store key
* Add execution mode filtering
* fix linting issue
* Do not override settings when setting isOnboarded true
* Add update user settings endpoint
* improvements
* revert changes to /GET executions
* Fix typo
* Add userActivated flag to user store
* Add E2E test
* Fix linting issue
* Update pnpm-lock
* Revert unnecessary change
* Centralize user's settings update
* Remove unused ref in userActivationSurvey modal
* Use aliased imports
* Use createEventBus function in component
* Fix tests
2023-04-11 12:43:47 -04:00
OlegIvaniv
d9f1e1e1ed
test(editor): Fix failing licensing related e2e specs (no-changelog) ( #5884 )
...
test(editor): Fix failing licensing related specs
2023-04-03 09:49:55 +02:00
Milorad FIlipović
0a59002ef8
feat(editor): Enable saving workflow when node details view is open ( #5856 )
...
* feat(editor): Enable saving workflow when node details view is open
* ⚡ Preventing event propagation
* ⚡ Move save event handler to `NodeDetailsView`
* ✅ Added e2e tests
* 👕 Fixing linting and removing unnecessary event logic
---------
Co-authored-by: Oleg Ivaniv <oleg@n8n.io>
2023-03-31 13:59:09 +02:00
Mutasem Aldmour
e3884ce378
fix: Add droppable state for booleans when mapping ( #5838 )
2023-03-31 12:35:02 +02:00
OlegIvaniv
1eba4788f2
fix(editor): Prevent NDV schema view pagination ( #5844 )
...
* fix(editor): Prevent NDV schema view pagination
* Linting fixes
2023-03-31 08:31:19 +02:00
Mutasem Aldmour
f8f584c136
fix(editor): Fix mapping with special characters ( #5837 )
...
* fix: Fix mapping with special characters
* refactor: rename var
* test: update more unit tests
* test: update mapping test
* test: update mapping test
2023-03-30 15:50:47 +02:00
OlegIvaniv
0b0024d722
fix(editor): Prevent error from showing-up when duplicating unsaved workflow ( #5833 )
...
* fix(editor): Prevent error from showing-up when duplicating unsaved workflow
* Add unsaved workflow duplicate test
2023-03-30 14:34:04 +02:00
कारतोफ्फेलस्क्रिप्ट™
87e979c19a
feat: Upgrade TypeScript to v5 (no-changelog) ( #5755 )
2023-03-30 13:59:59 +02:00
OlegIvaniv
541850f95f
feat(editor): Add support for schema view in the NDV output ( #5688 )
...
* feat(editor): Add support for schema view in the NDV output
* Make intercepts waiting optional in waitForLoad method
* Update RunDataSchema snapshots
* Do not reset output panel view on execution, properly key run RunDataSchemaItem to make sure they are unique across panels
* Update snapshot tests
* Make adding of schema view button option more readable
2023-03-16 10:19:12 +01:00
OlegIvaniv
de1db927cb
feat(editor): Do not show actions panel for single-action nodes ( #5683 )
2023-03-14 16:41:49 +01:00
OlegIvaniv
a96861b87f
test(editor): Fix the failing 7-workflow-actions spec (no-changelog) ( #5682 )
...
test(editor): Change `IMPORT_WORKFLOW_URL` to fix the failing `7-workflow-actions` spec (no-changelog)
2023-03-14 10:30:13 +01:00
OlegIvaniv
5c4343b828
test(editor): Improve e2e pipeline performance & fix flaky tests (no-changelog) ( #5672 )
...
* Split up canvas spec, extract community nodes related tests into its own spec, various flakiness fixes
* Remove unnecessary cy.waitForLoad from 7-workflow-actiosn spec
2023-03-10 16:54:54 +01:00
कारतोफ्फेलस्क्रिप्ट™
edf6313fa5
ci: Fix e2e tests (no-changelog) ( #5658 )
...
* ci: Fix e2e tests (no-changelog)
* Fix sign-in cypress command
* Run smoke test against head branch instead of base
---------
Co-authored-by: Oleg Ivaniv <oleg@n8n.io>
2023-03-09 17:08:47 +01:00
OlegIvaniv
a9c63f980f
feat(editor): Only redirect new users to blank canvas (no-changelog) ( #5654 )
...
* feat(editor): Bring new users to empty canvas
* fix(editor): Revert empty /workflows redirect
* Provide `COMMIT_INFO_BRANCH` and uncomment demo experiment
* Only change redirect after set-up/sign-up to new canvas
* Fix failing specs
* Prevent redirect for demo experiment
* Fix workflows cards spacing
2023-03-09 15:26:27 +01:00
OlegIvaniv
ac2f89a18a
feat(editor): Do not automatically add manual trigger on node plus ( #5644 )
...
* feat(editor): Do not add manual trigger node if node creator trigger via canvas actions
* Add e2e tests
* Install cypress-plugin-tab, do not use cy.realPress as it hangs the tests
* Exclude tab tests
2023-03-09 15:22:12 +01:00
OlegIvaniv
354edf6886
feat(editor): Redirect users to canvas if they don't have any workflows ( #5629 )
...
* feat(editor): Bring new users to empty canvas
* Fix failing e2e tests and revert CLI implementation
* Revert editor-ui Interface changes
* Try to mock /settings and /active
* Revert canvas test changes, reload after executions in 20-workflow-executions
* Make sure we include manual executiosn before running them in 20-workflow-executions
* Make sure to re-init node view when replacing empty workflows route, show phantom loader
2023-03-08 15:11:13 +01:00
OlegIvaniv
0004dc7ee8
ci(editor): Run e2e tests in parallel and improve build caching ( #5445 )
...
* WIP: Cypress parallel CI run test
* Trigger action on branch push
* Change build artifacts path
* Make sure to checkout the repo for testing job
* Use Cypress action for installing
* Lock cypress action userd version
* Skip node install step since we're using cypress node16 container
* Let Cypress handle pnpm install
* Use setup-node action for caching pnpm
* Set CYPRESS_CACHE_FOLDER
* Set CYPRESS_CACHE_FOLDER
* Manually cache pnpm store
* Dont fix pnpm version
* Use caching action also in testing job
* Zip packages dist before uploading the artifacts and change caching key
* Use absolute build paths for zipping job
* Use zip command in action
* Use tar for zipping packages
* Debuggin directory ls
* Debugging caching of modules
* Attempt to fix permissions issue
* Porivde Cypress executable via `CYPRESS_RUN_BINARY`
* Cache /github/home
* Adjust caching keys
* Debug: search for cypress exec
* Debugging: List dirs
* Use pnpm install action to install node_modules
* Do not log /home/runner
* Use node_modules/.bin Cypress binary
* Use absolute path to nodue modules
* Run Cypress via custom command
* Try with patched cypress action
* Revert logging
* Manually specify cypress config file
* Use absolute paths
* Fix cypress config name
* Debug print cypress config
* Remove debugging, increase to 4 containers
* Increase amount of containers
* Add env-version matrix
* Replace node14 with node18 in testing matrix
* Remove debugging and add node 14
* Use just node14
* Use cypress:base and remove browser req
* Give more general timeouts
* Try with node16
* Change cache directive position
* Replace zip artifact upload with cache
* Cache full packages not just dist
* Test with variable inputs
* Add commit info message
* Remove wrongly commited code
* Allow WF API dispatch
* Try Chrome browser again for comparison
* Include Monaco in the build
* Make e2e workflow re-usable
* Comment out invalid reusable workflow args
* Use electron and add node 14 run
* Fix env arg
* Provide custom ci-build-id
* Refactor remaining e2e workflow to use reusable action
* Remove single matrix directive
* Refactor ci-pull-req
* Make lint job dependant on test jobs
* Disable debugging job
* Make containers dynamic
* Cleanup & install git for linting action
* Use regular buntu image for PR linting
* Debugging failing tests
* Remove fixed spec name
* Debug e2e env var
* Do not use realkeypress which crashes electron runner
* Debugging
* chore: remove console
* chore: remove console
* test: remove node 14 tests
* test: replace test branch with master
* test: use tests in current branch
* test: use relative path
* chore: clean up
* test: only trigger on approval
* ci: update test PR
* ci: use curr branch
* ci: only run 14 on schedule, not for slack command
* ci: only run test on approval
* ci: clean up branch, rename step
* ci: rename steps
* ci: clean up cancel
* ci: clean up env var
* ci: set var
* ci: use chromef
* ci: use electron
* chore: add console log
* chore: add console log
* ci: update to string
* ci: set all env options
* test: build
* ci: fix step issue
* Fix failing tests & upgrade to Cypress 12
* Allow WF dispatch of e2e reusable
* Fix wrong naming in e2e-tests workflow
* Redeploy
* Fix tests
* Fix NDV tests and remove skipping of webhooks execution tests
* Fix clipboard read command
* Fix execution failing tests
* Reset before each 15 and 3
* Fix flaky tests
* Cleanup and log envs
* Test fixes
* Default owner spec fixes
* Get rid of CYPRESS_RUN_ENV
* Increase amount of containers, cleanup and add mock for credentials test call
* Cleanup & fix PR tests unit tests
* Wait for WF to loade in sharing spec
* Do linting and unit tests first
* Use frozen lockfile
* Revert back ci pull request jobs order
* Refine credential input selector and move cy.waitForLoad to correct position in 15-scheduler spec
* test: build
* Wait for WF execution instead of arbitraty timeout in WF execution spec, change order of jobs for ci pull request
* Fix flaky 3-default owner spec and wait for execution list to load in 20-workflow-executions
* Use setup node action
* Remove caching for lint/unit tests
* Experiment with parallel test & lint on ci
* Provide cache key dynamically
* Run e2e in parallel on pr
* Only run node14 e2e on daily schedule
* Make sure to generate generate new ci-build-id on re-runs
* Remove debugging prints
* Address PR comments
* Rename custom onBeforeUnload handler
* Make sure 19-execution spec waits for wf to load properly before import fixtures
---------
Co-authored-by: Mutasem <mutdmour@gmail.com>
2023-03-02 16:50:21 +01:00
Mutasem Aldmour
1f7b478920
fix: Fix mapping paths when appending to empty expression ( #5591 )
...
* fix: Fix mapping when appending to empty expression
* fix: refactor logic out
* test: add tests
* test: add tests
* fix: fix bug where value does not get updated when mapping
* test: add test for bug
* test: add test for bug
2023-03-02 15:02:29 +03:00
कारतोफ्फेलस्क्रिप्ट™
d09ca875ec
ci: Do not reset the server for every e2e sub-test (no-changelog) ( #5521 )
2023-02-24 18:07:35 +01:00
OlegIvaniv
1c0966957d
fix(editor): Fix adding of wrong actions when filtering in the node actions panel (no-changelog) ( #5518 )
2023-02-20 15:59:38 +01:00
OlegIvaniv
9a1e7b52f7
feat(editor): Unify regular and trigger node creator panels ( #5315 )
...
* WIP: Merge TriggerHelperPanel with MainPanel
* WIP: Implement switching between views
* Remove logging
* WIP: Rework search
* Fix category toggling and search results display
* Fix node item description
* Sort actions based on the root view
* Adjust personalisation modal, make trigger canvas node round
* Linting fixes
* Fix filtering of API options
* Fix types and no result state
* Cleanup
* Linting fixes
* Adjust mode prop for node creator tracking
* Fix merging of core nodes and filtering of single placeholder actions
* Lint fixes
* Implement actions override, fix node creator view item spacing and increase click radius of trigger node icon
* Fix keyboard view navigation
* WIP: E2E Tests
* Address product review
* Minor fixes & cleanup
* Fix tests
* Some more test fixes
* Add specs to check actions and panels
* Update personalisation survey snapshot
2023-02-17 15:08:26 +01:00
Csaba Tuncsik
593b5d299a
test(editor): Execution testing from UI perspective (no-changelog) ( #5429 )
...
* test(editor): Execution testing from UI perspective
* test(editor): Execution testing from UI perspective
* test(editor): Execution test rename
* test(editor): Execution test rename and add stop test
* test(editor): Execution test with webhook
* test(editor): Execution test with webhook
2023-02-16 11:41:25 +01:00
Alex Grozav
246189f6da
feat: Add workflow and credential sharing access e2e tests ( #5463 )
...
feat: add workflow and credential sharing access e2e tests
2023-02-14 16:13:00 +02:00
Milorad FIlipović
3b9eec77ec
test(editor): Add e2e tests for executions preview ( #5458 )
...
* ✅ Added initial tests for executions preview
* 🔥 Removing unneeded actions
* 👌 Renaming test suite, moving mock executions logic to util function
2023-02-14 11:39:19 +01:00
Milorad FIlipović
8494c97821
test(editor): Add e2e tests for personal settings page ( #5451 )
...
✅ Added tests for personal user settings
2023-02-10 13:12:06 +01:00
Milorad FIlipović
d9a4c2c66d
test(editor): Add user management e2e tests ( #5438 )
...
* ✅ Added initial UM test using new commands
* ✅ Added rest of the UM tests
2023-02-09 16:00:55 +01:00
Mutasem Aldmour
b8980f6118
test: Add more data mapping tests ( #5389 )
...
* test: Add more data mapping tests
* test: add tests for preview mapping
* test: update wording
* test: add more tests
* test: fix up prev node test
* test: stop popup
* test: add mapping test for paths
* test: revert back param changes
* test: fix mapping tests
* test: reset db
* test: fix up mapping tests
* test: fix up mapping tests
* test: update tests to be more stable
* chore: clean up unused command
* fix: fix up before unload bug
* fix: fix data transformation tests
* test: fix up flaky webhook tests
* test: fix up flaky webhook tests
* test: fix up flaky dt tests
2023-02-09 17:59:01 +03:00
Iván Ovejero
e0c4c25227
test: Add e2e workflow tags (no-changelog) ( #5411 )
...
* 🧪 Add workflow tags tests
* ⚡ Create `openTagManagerModal`
* ⚡ Add wait to prevent detached DOM element
* ⚡ Add wait to mirror other tests
2023-02-09 10:04:12 +01:00
Alex Grozav
e059caf993
feat: Add e2e user invite test suite (no-changelog) ( #5412 )
2023-02-08 22:41:35 +02:00
OlegIvaniv
14d1743595
test(editor): Add canvas dragging tests (no-changelog) ( #5406 )
...
* WIP
* Fix undo/redo tests and add canvas tests
* Cleanup
* Cleanup
* Use drag and draganddrop commands
* Fix hanging CI run
* Undo redo spec
2023-02-08 14:48:28 +01:00
Iván Ovejero
d8865aa917
test: Add e2e for data transformation expressions ( #5375 )
...
* 🧪 Add e2e for data transormation expressions
* ♻️ Apply feedback
2023-02-08 10:41:36 +01:00
Michael Auerswald
9fb1fa1d79
ci: Add E2E tests for Webhook node ( #5402 )
...
* scheduler e2e test and switch to main mode
* adjust e2e options
* rolling back config changes
* webhook e2e tests and disable cypress retries on openmode
* cleanup
2023-02-07 17:51:11 +01:00
Milorad FIlipović
d05203db30
test(editor): Enable adding nodes in between any two nodes on canvas in e2e tests (no-changelog) ( #5393 )
...
* ⚡ Adding source and target test data to connection HTML elements
* ⚡ Using new action to add node on the connection
* 🔥 Removing leftover log
* 🔥 Removing leftover test action
* 👌 Refactoring to address PR feedback
2023-02-07 16:34:08 +01:00
Michael Auerswald
dd652c0b0d
ci: Add E2E test for scheduled trigger ( #5391 )
...
* scheduler e2e test and switch to main mode
* adjust e2e options
* rolling back config changes
2023-02-07 12:41:44 +01:00
Mutasem Aldmour
db49f052bc
test: Add data mapping test ( #5372 )
...
* test: add tests for pinning
* test: add test for value
* test: add pinned data tests
* test: refactor into ndv
* refactor: move to ndv
* refactor: rename node
* test: fix test
* test: fix refactor
* test: remove unused id
* test: update test
* test: chain rename input
* test: refactor invoking text
* test: fix ndv tests
* test: move test id
* test: add tests for mapping
* test: update selectors
* test: add mapping
* test: remove wait
* test: add back line removed by mistake
* test: refactor to support both in/output displays
* test: add display mode switching
* test: fix drop
* chore: clean up change
* refactor: add draganddrop
* fix: fix drag and drop
* test: add mapping test for second value
* test: update text
* test: update param
2023-02-07 07:47:37 +03:00
Milorad FIlipović
03afd3c7cf
test(editor): Improve canvas e2e tests reliability ( #5376 )
...
✔️ Improving reliability of connection actions hover
2023-02-06 16:33:59 +01:00
OlegIvaniv
6985500a7d
fix(core): Fix populating of node custom api call options ( #5347 )
...
* feat(core): Fix populating of node custom api call options
* lint fixes
* Adress PR comments
* Add e2e test and only inject custom API options for latest version
* Make sure to injectCustomApiCallOption for the latest version of node
* feat(cli): Move apiCallOption injection to LoadNodesAndCredentials and add e2e tests to check for custom nodes credentials
* Load nodes and credentials fixtures from a single place
* Console warning if credential is invalid during customApiOptions injection
2023-02-03 13:14:59 +01:00
OlegIvaniv
616074158c
fix(core): Revert custom API option injecting ( #5345 )
...
Revert "feat(core): Fix populating of node custom api call options (#5303 )"
This reverts commit e58bc41d24
2023-02-02 20:03:45 +01:00
OlegIvaniv
e58bc41d24
feat(core): Fix populating of node custom api call options ( #5303 )
...
* feat(core): Fix populating of node custom api call options
* lint fixes
* Adress PR comments
* Add e2e test and only inject custom API options for latest version
* Make sure to injectCustomApiCallOption for the latest version of node
2023-02-02 14:53:08 +01:00
Iván Ovejero
6d811f0d9f
feat(editor): Completions for extensions in expression editor ( #5130 )
...
* 🔥 Remove test extensions
* 🚧 Add test description
* 📘 Expand types
* ⚡ Export extensions
* ⚡ Export collection
* ⚡ Mark all proxies
* ✏️ Rename for clarity
* ⚡ Export from barrel
* ✨ Create datatype completions
* ⚡ Mount datatype completions
* 🧪 Adjust tests
* ⚡ Add `path` prop
* 🔥 Remove `()` from completion labels
* ⚡ Filter out completions for pseudo-proxies
* 🐛 Fix method error
* ⚡ Add metrics
* ✏️ Improve naming
* ✨ Start completion on empty resolvable
* ✨ Implement completion previews
* ⚡ Break out completion manager
* ⚡ Implement in expression editor modal
* ✏️ Improve naming
* ⚡ Filter out irrelevant completions
* ✨ Add preview hint
* ✏️ Improve comments
* 🎨 Style preview hint
* ⚡ Expand `hasNoParams`
* ⚡ Add spacing for readability
* ⚡ Add error codes
* ✏️ Add comment
* 🐛 Fix Esc behavior
* ⚡ Parse Unicode
* ⚡ Throw on invalid `DateTime`
* ⚡ Fix second root completion detection
* ⚡ Switch message at completable prefix position
* 🐛 Fix function names for non-dev build
* 🐛 Fix `json` handling
* 🔥 Comment out previews
* ♻️ Apply feedback
* 🔥 Remove extensions
* 🚚 Rename extensions
* ⚡ Adjust some implementations
* 🔥 Remove dummy extensions
* 🐛 Fix object regex
* ♻️ Apply feedback
* ✏️ Fix typos
* ✏️ Add `fn is not a function` message
* 🔥 Remove check
* ✨ Add `isNotEmpty` for objects
* 🚚 Rename `global` to `alpha`
* 🔥 Remove `encrypt`
* ⚡ Restore `is not a function` error
* ⚡ Support `week` on `extract()`
* 🧪 Fix tests
* ⚡ Add validation to some string extensions
* ⚡ Validate number arrays in some extensions
* 🧪 Fix tests
* ✏️ Improve error message
* ⏪ Revert extensions framework changes
* 🧹 Previews cleanup
* ⚡ Condense blank completions
* ⚡ Refactor dollar completions
* ⚡ Refactor non-dollar completions
* ⚡ Refactor Luxon completions
* ⚡ Refactor datatype completions
* ⚡ Use `DATETIMEUNIT_MAP`
* ✏️ Update test description
* ⏪ Revert "Use `DATETIMEUNIT_MAP`"
This reverts commit 472a77df5c🧪 Add tests
* ♻️ Restore generic extensions
* 🔥 Remove logs
* 🧪 Expand tests
* ✨ Add `Math` completions
* ✏️ List breaking change
* ⚡ Add doc tooltips
* 🐛 Fix node selector regex
* 🐛 Fix `context` resolution
* 🐛 Allow dollar completions in args
* ⚡ Make numeric array methods context-dependent
* 📝 Adjust docs
* 🐛 Fix selector ref
* ⚡ Surface error for valid URL
* 🐛 Disallow whitespace in `isEmail` check
* 🧪 Fix test for `isUrl`
* ⚡ Add comma validator in `toFloat`
* ⚡ Add validation to `$jmespath()`
* ⏪ Revert valid URL error
* ⚡ Adjust `$jmespath()` validation
* 🧪 Adjust `isUrl` test
* ⚡ Remove `{}` and `[]` from compact
* ✏️ Update docs
* 🚚 Rename `stripTags` to `removeTags`
* ⚡ Do not inject whitespace inside resolvable
* ⚡ Make completions aware of `()`
* ✏️ Add note
* ⚡ Update sorting
* ⚡ Hide active node name from node selector
* 🔥 Remove `length()` and its aliases
* ⚡ Validate non-zero for `chunk`
* ✏️ Reword all error messages
* 🐛 Fix `$now` and `$today`
* ⚡ Simplify with `stripExcessParens`
* ⚡ Fold luxon into datatype
* 🧪 Clean up tests
* 🔥 Remove tests for removed methods
* 👕 Fix type
* ⬆️ Upgrade lang pack
* ⏪ Undo change to `vitest` command
* 🔥 Remove unused method
* ⚡ Separate `return` line
* ✏️ Improve description
* 🧪 Expand tests for initial-only completions
* 🧪 Add bracket-aware completions
* ⚡ Make check for `all()` stricter
* ✏️ Adjust explanatory comments
* 🔥 Remove unneded copy
* 🔥 Remove outdated comment
* ⚡ Make naming consistent
* ✏️ Update comments
* ⚡ Improve URL scheme check
* ✏️ Add comment
* 🚚 Move extension
* ✏️ Update `BREAKING-CHANGES.md`
* ✏️ Update upcoming version
* ✏️ Fix grammar
* ✏️ Shorten message
* 🐛 Fix `Esc` behavior
* 🐛 Fix `isNumeric`
* ✨ Support native methods
* 🧪 Skip Pinia tests
* ✏️ Shorten description
* 🔥 Remove outdated comment
* 🧪 Unskip Pinia tests
* ✏️ Add comments
* 🧪 Expand tests to natives
* ✏️ Add clarifying comments
* ⚡ Use `setTimeout` to make telemetry non-blocking
* 🐛 Account for no active node in cred modal
* ✨ Resolve without workflow
* 🔥 Remove `Esc` handling on NDV
* ⚡ Use `isDateTime`
* 🚚 Move `unique` to next phase
This array extension takes optional args.
* ⚡ Merge export
* 🧪 Fix tests
* ⏪ Restore check
* ✏️ Make breaking change description more accurate
* 🧪 Fix e2e tests
2023-02-02 12:35:38 +01:00
OlegIvaniv
766501723b
refactor(editor): Upgrade to jsPlumb 5 ( #4989 )
...
* WIP: Nodeview
* Replace types
* Finish N8nPlus endpoint type
* Working on connector
* Apply prettier
* Fixed prettier issues
* Debugging rendering
* Fixed connectorrs position recalc
* Fix snapping and output labels, WIP dragging
* Fix N8nPlus endpoint rendering issues
* Cleanup
* Fix undo/redo and canvas add button position, cleanup
* Cleanup
* Revert accidental CLI changes
* Fix pnpm-lock
* Address bugs that came up during review
* Reset CLI package from master
* Various fixes
* Fix run items label toggling
* Linter fixes
* Fix stalk size for larger run items label
* Remove comment
* Correctly reset workspace after renaming the node
* Fix canvas e2e tests
* Fix undo/redo tests
* Fix stalk positioning and triggering of endpoint overlays
* Repaint connections on pin removal
* Limit repaintings
* Unbind jsPlumb events on deactivation
* Fix jsPlumb managment of Sticky and minor memort managment improvments
* Address rest of PR points
* Lint fix
* Copy patches folder to docker
* Fix e2e tests
* set allowNonAppliedPatches to allow build
* fix(editor): Handling router errors when navigation is canceled by user (#5271 )
* 🔨 Handling router errors in main sidebar, removing unused code
* 🔨 Handling router errors in modals
* ci(core): Fix docker nightly/custom image build (no-changelog) (#5284 )
* ci(core): Copy patches dir to Docker (no-changelog)
* Update patch
* Update package-lock
* reapply the patch
* skip patchedDependencies after the frontend is built
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
* Fix connector hover state on success
* Remove allowNonAppliedPatches from package.json
---------
Co-authored-by: Milorad FIlipović <milorad@n8n.io>
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-01-30 18:20:50 +01:00
Alex Grozav
b2f59c3f39
feat: Add multiple workflows text search filtering E2E test scenarios (no-changelog) ( #5276 )
...
feat: Add multiple workflows text search filtering E2E test scenarios
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-01-30 14:28:59 +02:00
कारतोफ्फेलस्क्रिप्ट™
845f0f9d20
refactor(core): Switch over all user-management routes to use decorators ( #5115 )
2023-01-27 11:19:47 +01:00
Iván Ovejero
0a7ea89633
fix: Fix formatting/linting for CI (no-changelog) ( #5264 )
...
* ⬆️ Upgrade Prettier
* 📦 Update `pnpm-lock.yaml`
* 🎨 Format all packages
* 🔧 Specify `prettierPath`
2023-01-27 10:18:15 +01:00
Milorad FIlipović
b321c5e4ec
feat(editor): Simplify NDV by moving authentication details to credentials modal ( #5067 )
...
* ⚡ Removing authentication parameter from NDV
* ⚡ Added auth type selector to credentials modal
* 🔨 Extracting reusable logic to util functions
* ⚡ Updating credentials position, adding label for radio buttons
* ⚡ Using first node credentials for nodes with single auth options and hiding auth selector UI in that case
* ⚡ Fixing credentials modal when opened from credentials page
* ⚡ Showing all available credentials in NDV credentials dropdown
* ⚡ Updating node credentials dropdown component to show credentials description. Disabling `Credentials of type not found` error in node
* ⚡ Moving auth related fields from NDV to credentials modal. Added support for multiple auth fileds
* ⚡ Moving NDV fields that authentication depends on to credentials modal
* ⚡ Keeping old auth/credentials UI in NDV for HTTP Request and Webhook nodes. Pre-populating credential type for HTTP request node when selected from 'app action' menu
* 💄 Use old label and field position for nodes that use old credentials UI in NDV
* ⚡ Implementing more generic way to find node's auth fileds
* 📚 Adding comments on parameter hiding logic
* ⚡ Fixing node auth options logic for multiple auth fields
* 👕 Fixing lint errors
* 💄 Addressing design review comments
* ⚡ Not selecting first auth option when opening new credential dialog
* ⚡ Using default credentials name and icon if authentication type is not selected
* ⚡ Updating credential data when auth type is changed
* ⚡ Setting new credentials type for HTTP Request and Webhook nodes
* ⚡ Setting nodes with access when changing auth type
* 👕 Fixing lint error
* ⚡ Updating active node auth type from credentials modal
* ⚡ Syncronizing credentials modal and dropdown
* 👕 Fixing linter error
* ⚡ Handling credential dropdown UI for multiple credentials
* 👕 Removing unused imports
* ⚡ Handling auth selection when default auth type is the first option
* ⚡ Updating credentials change listening logic
* ⚡ Resetting credential data when deleting a credential, disabling 'Details' and 'Sharing' tabs if auth type is not selected
* 🐛 Skipping credentials type check when showing mixed credentials in the dropdown and switching credentials type
* ⚡ Showing credential modal tabs for saved credentials
* ⚡ Preventing renaming credentials when no auth type is selected
* 🐛 Fixing credentials modal when opened from credentials page
* ⚡ Keeping auth radio buttons selected when switching tabs
* ✅ Adding initial batch of credentials NDV tests
* ⚡ Updating node auth filed value when new credential type is selected
* ⚡ Using all available credential types for current node to sync credential dropdown with modal
* ⚡ Sorting mixed credentials by date, simplifying credential dropdown option logic
* 🔨 Extracting some reusable logic to utils
* ⚡ Improving required vs optional credentials detection and using it to show auth radio buttons
* 👕 Fixing lint errors
* ✅ Adding more credentials tests
* ⚡ Filtering credential options based on authentication type
* 🔨 Refactoring credentials and auth utils
* ⚡ Updated handling of auth options in credentials modal to work with new logic
* 🔨 Getting the terminology in line
* 📚 Removing leftover comment
* ⚡ Updating node auth filed detection logic to account for different edge-cases
* ⚡ Adding Wait node as an exception for new UI
* ⚡ Updating NDV display when auth type changes
* ⚡ Updating default credentials name when auth type changes
* ⚡ Hiding auth settings after credentials are saved
* ⚡ Always showing credentials modal menu tabs
* ⚡ Improving main auth field detection logic so it doesn't account for authentication fields which can have `none` value
* ⚡ Restoring accidentally deleted not existing credential issue logic
* ⚡ Updating other nodes when deleted credentials have been updated
* ⚡ Using filtered auth type list to show or hide radio buttons section in credentials modal
* 👕 Addressing lint error
* 👌 Addressing PR review feedback
* 👕 Fixing lint issues
* ⚡ Updating main auth filed detection logic so it checks full dependency path to determine if the field is required or optional
* 👌 Addressing the rest of PR feedback
* ✅ Updating credential tests
* ⚡ Resetting credential data on authentication type change
* ⚡ Created AuthTypeSelector component
* 👌 Addressing PR comments
* ⚡ Not resetting overwritten credential properties when changing auth type
* ⚡ Hiding auth selector section if there are no options to show
2023-01-27 09:05:43 +01:00
Alex Grozav
874c735d0a
feat: Improve workflow list performance using RecycleScroller and on-demand sharing data loading ( #5181 )
...
* feat(editor): Load workflow sharedWith info only when opening share modal (#5125 )
* feat(editor): load workflow sharedWith info only when opening share modal
* fix(editor): update workflow share modal loading state at the end of initialize fn
* feat: initial recycle scroller commit
* feat: prepare recycle scroller for dynamic item sizes (no-changelog)
* feat: add recycle scroller with variable size support and caching
* feat: integrated recycle scroller with existing resources list
* feat: improve recycle scroller performance
* fix: fix recycle-scroller storybook
* fix: update recycle-scroller styles to fix scrollbar size
* chore: undo vite config changes
* chore: undo installed packages
* chore: remove commented code
* chore: remove vue-virtual-scroller code.
* feat: update size cache updating mechanism
* chore: remove console.log
* fix: adjust code for e2e tests
* fix: fix linting issues
2023-01-27 09:51:32 +02:00
Mutasem Aldmour
a89c9c68d1
test: Add tests for pinning data ( #5157 )
...
* test: add tests for pinning
* test: add test for value
* test: add pinned data tests
* test: refactor into ndv
* refactor: move to ndv
* refactor: rename node
* test: fix test
* test: fix refactor
* test: remove unused id
* test: update test
* test: chain rename input
* test: refactor invoking text
* test: fix ndv tests
* test: move test id
* test: update selectors
2023-01-18 15:48:36 +01:00
OlegIvaniv
582865c7e9
feat(editor): Supress validation errors for freshly added nodes ( #5149 )
...
* feat(editor): Supress validation errors when node is added from node creator
* Supress initial errors also for resource locator inputs
* Use nodeMetadata prop to store node's `pristine` state
* Revert `setNodeParameters` check for `nodeMetadata`
* Rename getIsNodePristine to isNodePristine
2023-01-16 14:55:58 +01:00
Michael Auerswald
871a1d7dad
fix(editor): Fixes event bus test ( #5119 )
...
* create webhook instead of sentry destination
* remove wait()
2023-01-10 11:45:51 +01:00
Mutasem Aldmour
7df0728999
test: Fix default owner test to be able to reach setup page ( #5113 )
...
test: fix default owner test
2023-01-09 17:23:39 +01:00
Iván Ovejero
bae1487a53
test: Fix e2e tests for inline expression editor ( #5108 )
...
🧪 Fix e2e tests for inline expression editor
2023-01-09 11:44:15 +01:00
Michael Auerswald
b67f803cbe
feat: Add global event bus ( #4860 )
...
* fix branch
* fix deserialize, add filewriter
* add catchAll eventGroup/Name
* adding simple Redis sender and receiver to eventbus
* remove native node threads
* improve eventbus
* refactor and simplify
* more refactoring and syslog client
* more refactor, improved endpoints and eventbus
* remove local broker and receivers from mvp
* destination de/serialization
* create MessageEventBusDestinationEntity
* db migrations, load destinations at startup
* add delete destination endpoint
* pnpm merge and circular import fix
* delete destination fix
* trigger log file shuffle after size reached
* add environment variables for eventbus
* reworking event messages
* serialize to thread fix
* some refactor and lint fixing
* add emit to eventbus
* cleanup and fix sending unsent
* quicksave frontend trial
* initial EventTree vue component
* basic log streaming settings in vue
* http request code merge
* create destination settings modals
* fix eventmessage options types
* credentials are loaded
* fix and clean up frontend code
* move request code to axios
* update lock file
* merge fix
* fix redis build
* move destination interfaces into workflow pkg
* revive sentry as destination
* migration fixes and frontend cleanup
* N8N-5777 / N8N-5789 N8N-5788
* N8N-5784
* N8N-5782 removed event levels
* N8N-5790 sentry destination cleanup
* N8N-5786 and refactoring
* N8N-5809 and refactor/cleanup
* UI fixes and anonymize renaming
* N8N-5837
* N8N-5834
* fix no-items UI issues
* remove card / settings label in modal
* N8N-5842 fix
* disable webhook auth for now and update ui
* change sidebar to tabs
* remove payload option
* extend audit events with more user data
* N8N-5853 and UI revert to sidebar
* remove redis destination
* N8N-5864 / N8N-5868 / N8N-5867 / N8N-5865
* ui and licensing fixes
* add node events and info bubbles to frontend
* ui wording changes
* frontend tests
* N8N-5896 and ee rename
* improves backend tests
* merge fix
* fix backend test
* make linter happy
* remove unnecessary cfg / limit actions to owners
* fix multiple sentry DSN and anon bug
* eslint fix
* more tests and fixes
* merge fix
* fix workflow audit events
* remove 'n8n.workflow.execution.error' event
* merge fix
* lint fix
* lint fix
* review fixes
* fix merge
* prettier fixes
* merge
* review changes
* use loggerproxy
* remove catch from internal hook promises
* fix tests
* lint fix
* include review PR changes
* review changes
* delete duplicate lines from a bad merge
* decouple log-streaming UI options from public API
* logstreaming -> log-streaming for consistency
* do not make unnecessary api calls when log streaming is disabled
* prevent sentryClient.close() from being called if init failed
* fix the e2e test for log-streaming
* review changes
* cleanup
* use `private` for one last private property
* do not use node prefix package names.. just yet
* remove unused import
* fix the tests
because there is a folder called `events`, tsc-alias is messing up all imports for native events module.
https://github.com/justkey007/tsc-alias/issues/152
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-01-04 09:47:48 +01:00
Csaba Tuncsik
0da338f9b5
feat(editor): Add usage and plan pages ( #4819 )
...
* feat(editor): Usage and plan page (#4793 )
feat(editor): usage and plan page
* feat(editor): Update Usage and plan page (#4842 )
* feat(editor): usage and plan store
* feat(editor): usage and plan page updates
* feat(editor): usage and plan add buttons and alert
* tes(editor): usage and plan store
* tes(editor): usage remove refresh button and add link to view plans
* tes(editor): usage use info tip
* tes(editor): usage info style
* feat(editor): Get quotas data (#4866 )
feat(editor): get quotas data
* feat(editor): In-app experience (#4875 )
* feat: Add license quotas endpoint
* feat: Add trigger count to workflow activation process
* refactor: Get quotas from db
* feat: Add license information
* ✨ - finalised GET /license endpoint
* 🔨 - getActiveTriggerCount return 0 instead of null
* 🐛 - ignore manualTrigger when counting active triggers
* ✨ - add activation endpoint
* ✨ - added renew endpoint
* 🔨 - added return type interfaces
* 🔨 - handle license errors where methods are called
* 🔨 - rename function to match name from lib
* feat(editor): usage add plans buttons logic
* 🚨 - testing new License methods
* feat(editor): usage add more business logic
* chore(editor): code formatting
* 🚨 - added license api tests
* fix(editor): usage store
* fix(editor): usage update translations
* feat(editor): usage add license activation modal
* feat(editor): usage change subscription app url
* feat(editor): usage add contact us link
* feat(editor): usage fix modal width
* ✨ - Add renewal tracking metric
* ✨ - add license data to pulse event
* 🔨 - set default triggercount on entity model
* ✨ - add db migrations for mysql and postgres
* fix(editor): Usage api call data processing and error handling
* fix(editor): Usage fix activation query key
* 🚨 - add initDb to telemetry tests
* 🔨 - move getlicensedata to licenseservice
* 🔨 - return 403 instead of 404 to non owners
* 🔨 - move owner checking to middleware
* 🐛 - fixed incorrectly returned error from middleware
* 🐛 - using mock instead of test db for pulse tests
* fix(editor): Usage fix activation and add success messages
* fix(editor): Usage should not renew activation right after activation
* 🚨 - skipping failing pulse tests for now
* fix(editor): Usage add telemetry calls and apply design review outcomes
* feat(editor): Hide usage page according to BE flag
* feat(editor): Usage modify key activation flow
* feat(editor): Usage change subscription app url
* feat(editor): Usage add telemetry for manage plan
* feat(editor): Usage extend link url query params
* feat(editor): Usage add line chart if there is a workflow limit
* feat(editor): Usage remove query after key activation redirection
* fix(editor): Usage handle limit exceeded workflow chart, add focus to input when modal opened
* fix(editor): Usage activation can return router promise when removing query
* fix(editor): Usage and plan design review
* 🐛 - fix renew endpoint hanging issue
* 🐛 - fix license activation bug
* fix(editor): Usage proper translation for plans and/or editions
* fix(editor): Usage apply David's review results
* fix(editor): Usage page set as default and first under Settings
* fix(editor): Usage open subscription app in new tab
* fix(editor): Usage page having key query param a plan links
* test: Fix broken test
* fix(editor): Usage page address review
* 🧪 Flush promises on telemetry tests
* ⚡ Extract helper with `setImmediate`
* 🔥 Remove leftovers
* ⚡ Use Adi's helper
* refactor: Comment broken tests
* refactor: add Tenant id to settings
* feat: add environment to license endpoints
* refactor: Move license environment to general settings
* fix: fix routing bug
* fix(editor): Usage page some code review changes and formatting
* fix(editor): Usage page remove direct usage of reusable translation keys
* fix(editor): Usage page async await instead of then
* fix(editor): Usage page show some content only if network requests in component mounted were successful
* chore(editor): code formatting
* fix(editor): Usage checking license environment
* feat(editor): Improve license activation error messages (no-changelog) (#4958 )
* fix(editor): Usage changing activation error title
* remove unnecessary import
* fix(editor): Usage refactor notification showing
* fix(editor): Usage using notification directly in store actions
Co-authored-by: Omar Ajoue <krynble@gmail.com>
Co-authored-by: freyamade <freya@n8n.io>
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
Co-authored-by: Mutasem <mutdmour@gmail.com>
Co-authored-by: Cornelius Suermann <cornelius@n8n.io>
* fix(editor): Usage change mounted lifecycle logic
* fix(editor): Usage return after successful activation in mounted
* fix: remove console log
* test: fix tests related to settings (#4979 )
Co-authored-by: Omar Ajoue <krynble@gmail.com>
Co-authored-by: freyamade <freya@n8n.io>
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
Co-authored-by: Mutasem <mutdmour@gmail.com>
Co-authored-by: Cornelius Suermann <cornelius@n8n.io>
Co-authored-by: Mutasem Aldmour <4711238+mutdmour@users.noreply.github.com>
2022-12-20 10:52:01 +01:00
Milorad FIlipović
96296e1724
test(editor): Add canvas actions e2e tests ( #4950 )
...
* ✅ Added some more workflow actions tests
* ✅ Updating duplicate workflow tests
* ✅ Fixed duplicate workflow tests
* ✅ Added first batch of canvas tests
* ✅ Added zoom and select tests
* ✅ Added tests for adding and deleting nodes
* ✅ Adding a wait before clicking connection action buttons
* ✅ Adding tests for node actions
* 👌 Addressing review feedback
* 👌 Addressing PR feedback
2022-12-20 10:33:20 +01:00
Iván Ovejero
3028ad3c61
refactor: Format root-level dirs (no-changelog) ( #4938 )
...
🎨 Format root-level dirs
2022-12-15 16:39:59 +01:00
Iván Ovejero
4208040495
test(editor): Add e2e tests for inline expression editor ( #4936 )
...
🧪 Add tests for inline expression editor
2022-12-15 15:36:28 +01:00
Milorad FIlipović
9956547504
test(editor): Add more tests for workflow actions (no-changelog) ( #4931 )
...
* ✅ Added test for importing workflow from URL
* ✅ Added test for importing workflow from file
* ✅ Added test ids for workflow settings elements
* ✅ Added test for changing workflow settings
* ✅ Adding back missing test id for delete node button
2022-12-14 17:13:03 +01:00
Iván Ovejero
a1259898c0
feat(editor): Inline expression editor ( #4814 )
...
* WIP
* 🔥 Remove unneeded watch
* ⚡ Further setup
* ⚡ Fix import
* ⚡ Minor tweaks
* 🔥 Remove logging
* 🎨 Add some styling
* 🎨 More styling changes
* 🐛 Fix wrong marking of stale data
* 🎨 Prevent fx on dragging
* 🔥 Remove logging
* ⚡ Refine draggable target offsets
* refactor(editor): Consolidate expression management logic (#4836 )
* ⚡ Extract `ExpressionFunctionIcon`
* ⚡ Simplify syntax
* ⚡ Move to mixin
* 🎨 Format
* 📘 Unify types
* ⚡ Dedup double brace handler
* ⚡ Consolidate resolvable highlighter
* 🎨 Format
* ⚡ Consolidate language pack
* ✏️ Add comment
* ⚡ Move completions to plugins
* ⚡ Partially deduplicate themes
* refactor(editor): Apply styling feedback to inline expression editor (#4846 )
* 🎨 Adjust styling for expression parameter input
* 🎨 Style outputs differently
* ⚡ Set single line for RLC
* 🎨 Style both openers identically
* 🐛 Prevent defocus on resize
* ⚡ Adjust line height
* 🎨 Adjust border with for expression input
* ⚡ Fix font family for inline output
* ⚡ Set up telemetry
* ⚡ Complete telemetry
* ⚡ Simplify event source
* ⚡ Set monospaced font for inline output
* 🎨 Hide cursor on schema pill drop
* 🧪 Update snapshots
* ⚡ Consolidate editor styles
* ✏️ Add tech debt comments
* ⚡ Improve naming
* ⚡ Improve inside resolvable detection
* ⚡ Improve var naming
* 🔥 Remove outdated comment
* 🚚 Move constant to data
* ✏️ Clarify comments
* 🔥 Remove outdated comments
* 🔥 Remove unneeded try-catch
* 🔥 Remove unneeded method
* 🔥 Remove unneeded check
* 🔥 Remove `openExpression` check
* 🔥 Remove unused timeout
* 🔥 Remove commented out sections
* ⚡ Use Pinia naming convention
* ⚡ Re-evaluate on change of `ndvInputData`
* 🐛 Fix handling of `0` in number-type input
* 🐛 Surface focus and blur for mapping hints
* 🔥 Remove logging
* ✏️ Reword error
* ⚡ Change kebab-case to PascalCase
* ⚡ Refactor state fields for clarity
* ⚡ Support double bracing on selection
* 🎨 More styling
* ⚡ Miscellaneous cleanup
* ⚡ Disregard error on drop
* 🎨 Fix schema pill styling
* 🎨 More `background` to `background-color` fixes
* 🧪 Update snapshots
* 🎨 Replace non-existing var with white
* 🧪 Update snapshot
* 📦 Integrate `codemirror-lang-n8n-expression`
* 🎨 Fix formatting
* 🧪 Re-update test snapshots
* 🧪 Update selectors for inline editor
* 🔥 Remove unused test ID
* 📘 Add type for `currentNodePaneType`
* ⚡ Refactor mixin to util
* ⚡ Use `:global`
* 🔥 Remove comment
* ⚡ Add watch
* ⚡ Change import style
* 👕 Fix lint
* ⚡ Refactor preventing blur on resize
* 🔥 Remove comment
* 🧪 Re-update snapshots
* 🎨 Prettify
* 👕 Fix lint
* 🔥 Remove comment
Co-authored-by: Mutasem <mutdmour@gmail.com>
2022-12-14 14:43:02 +01:00
Milorad FIlipović
69e9bf082b
test(editor): Add e2e tests for undo/redo ( #4904 )
...
* ✨ Added history store and mixin
* ✨ Implemented node position change undo/redo
* ✨ Implemented move nodes bulk command
* ⚡ Not clearing the redo stack after pushing the bulk command
* 🔨 Implemented commands using classes
* 🔥 Removed unnecessary interfaces and actions
* 🔥 Removing unused constants
* 🔨 Refactoring classes file
* ⚡ Adding eventBus to command obects
* ✨ Added undo/redo support for adding and removing nodes
* ✨ Implemented initial add/remove connections undo support
* ⚡ Covering some corner cases with reconnecting nodes
* ⚡ Adding undo support for reconnecting nodes
* ⚡ Fixing going back and forward between undo and redo
* ✨ Implemented async command revert
* ⚡ Preventing push to undo if bulk redo/undo is in progress
* ⚡ Handling re-connecting nodes and stopped pushing empty bulk actions to undo stack
* ✨ Handling adding a node between two connected nodes
* ⚡ Handling the case of removing multiple connections on the same index. Adding debounce to undo/redo keyboard calls
* ⚡ Removing unnecessary timeouts, adding missing awaits, refactoring
* ⚡ Resetting history when opening new workflow, fixing incorrect bulk recording when inserting node
* ✔️ Fixing lint error
* ⚡ Minor refactoring + some temporary debugging logs
* ⚡ Preserving node properties when undoing it's removal, removing some unused repaint code
* ✨ Added undo/redo support for import workflow and node enable/disable
* 🔥 Removing some unused constant
* ✨ Added undo/redo support for renaming nodes
* ⚡ Fixing rename history recording
* ✨ Added undo/redo support for duplicating nodes
* 📈 Implemented telemetry events
* 🔨 A bit of refactoring
* ⚡ Fixing edgecases in removing connection and moving nodes
* ⚡ Handling case of adding duplicate nodes when going back and forward in history
* ⚡ Recording connections added directly to store
* ⚡ Moving main history reset after wf is opened
* 🔨 Simplifying rename recording
* 📈 Adding NDV telemetry event, updating existing event name case
* 📈 Updating telemetry events
* ✅ Added initial undo/redo tests
* ⚡ Fixing duplicate connections on undo/redo
* ⚡ Stopping undo events from firing constantly on keydown
* ✅ Added connection test for undo/redo
* 📈 Updated telemetry event for hitting undo in NDV
* ⚡ Adding undo support for disabling nodes using keyboard shortcuts
* ✅ Added more tests for adding and deleting nodes undo/redo
* ⚡ Preventing adding duplicate connection commands to history
* 📈 Adding connection assertions to delete node tests
* ⚡ Clearing redo stack when new change is added
* ⚡ Preventing adding connection actions to undo stack while redoing them
* 👌 Addressing PR comments part 1
* 👌 Moving undo logic for disabling nodes to `NodeView`
* 👌 Implemented command comparing logic
* ⚡ Fix for not clearing redo stack on every user action
* ⚡ Fixing recording when moving nodes
* ⚡ Fixing undo for moving connections
* ⚡ Fixing tracking new nodes after latest merge
* ⚡ Fixing broken bulk delete
* ✅ Added tests for moving nodes
* ✅ Added tests for deleting connections
* ✅ Added tests for disabling nodes
* ✅ Added node rename tests
* ✅ Added tests for duplicating and pasting nodes
* ✅ Added multi-step undo/redo tests
* ✅ Fixing assertion condition
* ✅ Fixing timeout issue between keyboard strokes
* ⬆️ Updating pnpm lock file
* ✅ Waiting for page load to finish before each test
* ✅ Adding proper handling of meta key press
* 🚨 Temporarily disabling slack notifications
* ✅ Adding check before clicking connection actions
* ⚡ Removing comments from other undo tests
* 🎨 Fixing a typo
2022-12-14 10:33:44 +01:00
OlegIvaniv
297a043875
test(editor): Fix flaky workflow tags e2e tests and store screenshots from CI runs ( #4903 )
...
* test(editor): Fix flaky add tags e2e specs, and upload cypress artifacts on failure
* Only run smoke test to debug the pipeline
* Add waitForLoad command and revert debugging changes
2022-12-13 11:55:51 +01:00
OlegIvaniv
79fe57dad8
feat(editor): Node creator actions ( #4696 )
...
* WIP: Node Actions List UI
* WIP: Recommended Actions and preseting of fields
* WIP: Resource category
* 🎨 Moved actions categorisation to the server
* 🏷️ Add missing INodeAction type
* ✨ Improve SSR categorisation, fix adding of mixed actions
* ♻️ Refactor CategorizedItems to composition api, style fixes
* WIP: Adding multiple nodes
* ♻️ Refactor rest of the NodeCreator component to composition API, conver globalLinkActions to composable
* ✨ Allow actions dragging, fix search and refactor passing of actions to categorized items
* 💄 Fix node actions title
* Migrate to the pinia store, add posthog feature and various fixes
* 🐛 Fix filtering of trigger actions when not merged
* fix: N8N-5439 — Do not use simple node item when at NodeHelperPanel root
* 🐛 Design review fixes
* 🐛 Fix disabling of merged actions
* Fix trigger root filtering
* ✨ Allow for custom node actions parser, introduce hubspot parser
* 🐛 Fix initial node params validation, fix position of second added node
* 🐛 Introduce operations category, removed canvas node names overrride, fix API actions display and prevent dragging of action nodes
* ✨ Prevent NDV auto-open feature flag
* 🐛 Inject recommened action for trigger nodes without actions
* Refactored NodeCreatorNode to Storybook, change filtering of merged nodes for the trigger helper panel, minor fixes
* Improve rendering of app nodes and animation
* Cleanup, any only enable accordion transition on triggerhelperpanel
* Hide node creator scrollbars in Firefox
* Minor styles fixes
* Do not copy the array in rendering method
* Removed unused props
* Fix memory leak
* Fix categorisation of regular nodes with a single resource
* Implement telemetry calls for node actions
* Move categorization to FE
* Fix client side actions categorisation
* Skip custom action show
* Only load tooltip for NodeIcon if necessary
* Fix lodash startCase import
* Remove lodash.startcase
* Cleanup
* Fix node creator autofocus on "tab"
* Prevent posthog getFeatureFlag from crashing
* Debugging preview env search issues
* Remove logs
* Make sure the pre-filled params are update not overwritten
* Get rid of transition in itemiterator
* WIP: Rough version of NodeActions keyboard navigation, replace nodeCreator composable with Pinia store module
* Rewrite to add support for ActionItem to ItemIterator and make CategorizedItems accept items props
* Fix category item counter & cleanup
* Add APIHint to actions search no-result, clean up NodeCreatorNode
* Improve node actions no results message
* Remove logging, fix filtering of recommended placeholder category
* Remove unused NodeActions component and node merging feature falg
* Do not show regular nodes without actions
* Make sure to add manual trigger when adding http node via actions hint
* Fixed api hint footer line height
* Prevent pointer-events od NodeIcon img and remove "this" from template
* Address PR points
* Fix e2e specs
* Make sure canvas ia loaded
* Make sure canvas ia loaded before opening nodeCreator in e2e spec
* Fix flaky workflows tags e2e getter
* Imrpove node creator click outside UX, add manual node to regular nodes added from trigger panel
* Add manual trigger node if dragging regular from trigger panel
2022-12-09 10:56:36 +01:00
OlegIvaniv
1c36c37a12
test(editor): Fix flaky e2e tests ( #4779 )
...
* test(editor): Fix default-owner and credentials saving e2e specs
* test(editor): fix webhook node test
* test(editor): add cy command for browser permissions
* test(editor): add cy command for reading clipboard
* Fix 3-default-owner spec
* Resolve review comments
* Merge spec
* Fix http node and expression editor modal specs
* Add optional param to credentials modal saving action to wait for the test endpoint
* Improve sidebar items clicking and increase credentials saving timeout
* Rename http e2e spec to fix ordering
* Fix pasting and copying of nodes e2e spec
* Make sure to only access error.cause if it exists
* Wait longer for the keyboard press
* Make sure to focus the body when typing
* Try type delay
* Use meta key based on the running platform
* Fix flaky workflowTagElements getter
Co-authored-by: Csaba Tuncsik <csaba@n8n.io>
2022-12-07 18:16:38 +01:00
Milorad FIlipović
e07e32f14d
test(editor): Add more workflow actions tests ( #4799 )
...
* ⚡ Making workflow actions tests skip setup, changing suite number
* 🔥 Removing unnecessary imports and vars
* ✅ Adding workflow tags and copy/paste tests
* ✅ Added tests for copying and pasting nodes
* Update cypress/support/commands.ts
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* 👌 Moving paste data to fixtures
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
2022-12-05 14:31:14 +01:00
Iván Ovejero
59771c80ea
feat(editor): Overhaul expression editor modal ( #4631 )
...
* feat(editor): Integrate CodeMirror into expression editor modal (#4563 )
* ✨ Initial setup
* 👕 Fix lint
* ⚡ Extract segments
* ⚡ Implement var insertion
* 👕 Ignore `.d.cts`
* ⚡ Refactor to simplify
* ✨ Add brace handler
* ✨ Fully replace input and output
* feat(editor): Adjust resolved expression to match parameter input hint (#4600 )
* ✨ Initial adjustments
* 🐛 Prevent empty decorations
* ⚡ Adjust resolved expression to match param input hint
* ✏️ Improve comment
* 👕 Remove lint rule
* ✏️ Fix typo
* ✏️ Fix closing brace
* ⚡ Clean up `displayableSegments()`
* feat(editor): Apply styling to expression editor modal (#4607 )
🎨 Apply styling
* feat(core): Improve errors in evaluated expression (#4619 )
* 🐛 Fix env var access for FE
* 🔥 Remove excess closing bracket
* 🚧 Set up TODO
* ✏️ Update copy
* ⚡ Deny env vars access to FE
* 👕 Remove unneeded lint exception
* 📘 Remove unneeded typing
* feat(editor): Dynamically delay evaluation resolution (#4625 )
* ✏️ Update copy
* ⚡ Dynamically delay evaluation resolution
* 🔥 Remove unneeded computed property
* refactor(editor): Pre-review cleanup (#4627 )
* 🔥 Remove `ExpressionInput` component
* 🔥 Remove Quill
* ✏️ Rename i18n key
* 🎨 Place border on correct element
* 🐛 Handle syntax errors
* ⚡ Add sample autocompletions
* 🐛 Fix auto-extending behavior
* feat(editor): Improve escaping behavior (#4641 )
* 🎨 Hide hint on small screen
* ⚡ Improve escaping
* refactor(editor): Apply styling feedback to expression editor modal (#4660 )
* 🎨 Restyle hint
* 🎨 Restyle param input hint
* 🔥 Remove `e.g.`
* ⚡ Tweak delay
* 🎨 Restyle output
* 🎨 Tweak theme
* ✏️ Tweak copy
* refactor(editor): Apply feedback 2022.11.22 (#4697 )
* 🎨 Change background color
* ⚡ Focus on mount
* ⚡ Account for preexisting braces on injection
* 🐛 Fix `$workflow` showing as not saved
* ✏️ Tweak copy
* 🐛 Fix readonly focus
* ⚡ Focus input on paste
* ⚡ Sync inputs with modal
* ✏️ Tweak copy
* refactor(editor): Apply feedback 2022.11.23 (#4705 )
* ⚡ Allow newlines
* ⚡ Set cursor at end of content
* ⚡ Do not defocus on paste on Chrome
* ⚡ Fix import
* 🧪 Add e2e tests
* ⚡ Cleanup
* ⚡ Add telemetry
* 🔥 Remove log
* ⚡ Expose error properties
* 🧪 Rename test
* ⚡ Move `getCurrentWorkflow()` call
* ⏪ Revert highlighting removal per feedback
* ⚡ Add i18n keys
* 🚚 Move computed property to local state
* 🎨 Use CSS vars
* ⚡ Update `pnpm-lock.yaml`
* ⚡ Apply readonly state
* ⚡ Use prop
* ⚡ Complete fix
2022-12-01 13:26:22 +01:00
OlegIvaniv
830bda5f55
test(editor): Intercept credentials save and test request and wait for them in e2e test ( #4778 )
...
test(editor): Intercept credentials save and test request and wait for them to complete before doing assertions
2022-12-01 10:01:03 +01:00
Csaba Tuncsik
430cc65a4e
test: E2E NDV ( #4712 )
...
* test: start testing node details view
* test: deleting workflow after test
* test: rename deleteWorkflow command
* test: webhook node
* test: roll back deleting workflow in workflow test
* test: check output display modes after webhook node invoked
* test: simplifying test
* test: simplifying test
* test: adding more tests related to NDV
* test: adding more tests related to NDV
* test: update after merge
* Merge remote-tracking branch 'origin/master' into n8n-5494-e2e-ndv
# Conflicts:
# cypress/pages/workflow.ts
* test: improving test blocks
* test: NDV change node input
* test: NDV change node input
* test: NDV fix missing command
* test(editor): Add NDV page object
2022-12-01 09:26:38 +01:00
OlegIvaniv
c486ffcf2d
refactor(editor): Patch ElementUI tooltip memory leak ( #4769 )
...
* refactor(editor): Fix ElementUI tooltip memory leak
* fix(editor): Remove patch console.logs and revert node-creator test
2022-11-30 17:27:41 +01:00
OlegIvaniv
92c77127d6
test: Skip e2e check of rendered nodes in node creator ( #4761 )
2022-11-29 15:13:50 +02:00
कारतोफ्फेलस्क्रिप्ट™
f023e957b0
fix: Fix the e2e tests on master (no-changelog) ( #4746 )
2022-11-28 21:01:44 +02:00
Alex Grozav
622118f983
feat: Make use of db:reset in all test suites (no-changelog) ( #4739 )
...
* feat: Make use of db:reset in all test suites
* refactor: Rename task to no longer use db: prefix
* feat: wrap cypress tasks into commands
* refactor: rename resetDatabase to resetAll
* fix: update test:e2e:all to use --headless
2022-11-28 18:11:33 +01:00
Iván Ovejero
8f6fd009b9
test: Set up e2e tests for Code node ( #4730 )
...
* 🧪 Set up Code node tests
* ⚡ Address comments
2022-11-28 16:54:13 +01:00
Alex Grozav
14f81c2725
test: Update getters, add search and sort tests for credentials (no-changelog) ( #4716 )
...
* test(e2e): Update getters, add search and sort tests for credentials
* fix: Refactor sortOptions getter
* fix: fix merge conflict
* fix: removed double key
* fix: Add db and session reset for every credentials suite run
2022-11-28 12:11:39 +02:00
Milorad FIlipović
e3aeaa9a87
fix(editor): Fix for broken selectors for workflows tests (no-changelog) ( #4734 )
...
Fixing broken selectors for workflows tests
2022-11-25 17:10:28 +01:00
OlegIvaniv
2d31720b82
test: Reset DB and skip set-up before running node creator e2e ( #4733 )
...
* test: Reset DB and skip set-up before runing
* remove second db:reset call in node-creator e2e spec
2022-11-25 17:01:49 +01:00
Milorad FIlipović
cb3bfc32f7
test: Setup e2e tests for workflow actions ( #4724 )
...
* ✅ Adding first batch of workflow actions tests
* ✅ Adding loading handling logic and new workflow actions tests
* ✅ Added workflow activation and rename tests
* 👌 Addressing review feedback
* 🔥 Removing leftover commented code
2022-11-25 15:32:09 +01:00
Iván Ovejero
39a5dc57a8
fix: Fix HTTP Request node e2e test in full run (no-changelog) ( #4728 )
...
🐛 Reset state
2022-11-25 13:57:34 +01:00
OlegIvaniv
aa3d9c7fea
test: Add e2e tests for node creator ( #4714 )
...
* test: Add basic e2e tests for node creator
* add spec to check if all nodes are rendered
* revert SearchBar.vue changes
* fixed manual key typo
Co-authored-by: Mutasem Aldmour <4711238+mutdmour@users.noreply.github.com>
* Add custom component tests
* Fix wrongly resolved merge conflcit
Co-authored-by: Mutasem Aldmour <4711238+mutdmour@users.noreply.github.com>
2022-11-25 13:52:33 +01:00
Iván Ovejero
62d30f2b43
test: Set up e2e tests for HTTP Request node ( #4718 )
...
* 🧪 Add test identifiers
* ⚡ Add getters
* 🧪 Add initial test
* ⚡ Refactor to use actions
* ⚡ Refactor per Oleg's advice
* 🐛 Fix overlapping input label IDs
2022-11-25 13:09:44 +01:00
Mutasem Aldmour
95b97078e8
test: Add e2e tests for workflow/credential migrations when enabling UM ( #4719 )
...
* add tests
* ci: Setup cypress tasks for resetting DB, and setting up an owner
* add test tests to check for settings
* add more tests
* clean up
* rename tag
* update test id
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2022-11-24 23:22:09 +01:00
कारतोफ्फेलस्क्रिप्ट™
e409813ea9
ci: Setup cypress tasks for resetting DB, and setting up an owner ( #4717 )
...
* ci: Setup cypress tasks for resetting DB, and setting up an owner
* address Ivan's comments
2022-11-24 18:32:00 +01:00
Mutasem Aldmour
d46050c974
test: Add initial e2e tests for default owner setup ( #4710 )
...
* use user-folder override consistently everywhere, including for the `.cache` folder
* use consistent config for e2e tesing, skipping config loading from env and config files
* simplify all the cypress commands, and run all e2e tests on master
* add tests for skipping owner setup
* add todos
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2022-11-24 12:52:09 +01:00
Iván Ovejero
78119c9f22
refactor: Consolidate .prettierignore patterns (no-changelog) ( #4692 )
...
* ⚡ Consolidate Prettier ignore patterns
* ⚡ Let Prettier select file types to format
* 🎨 Apply formatting
2022-11-22 14:11:29 +01:00
Alex Grozav
b5b44d1b59
feat: Add credentials E2E test suite and page object ( #4596 )
...
* fix: Fix inferred type of X cannot be named error after pnpm update
* feat: Change page objects to expose actions and getters. Add credential creation suite
2022-11-22 11:37:26 +02:00
OlegIvaniv
50f7538779
refactor(editor): Add Workflows view e2e tests ( #4573 )
2022-11-11 09:07:14 +01:00
Alex Grozav
77644860c0
feat: Add cypress e2e tests for signup and signin ( #3490 )
...
* feat: Added cypress setup files.
* feat: Added server bootup and initial test run.
* feat: Added e2e tests for signin, signup, and personalization form.
* feat: Added e2e tests for adding a function node.
* feat: Added set node and workflow execution steps.
* feat: Added test id to main sidebar.
* feat: Added test for creating a new workflow.
* feat: Finished test for creating a blank workflow
* chore: Removed screenshots from e2e tests.
* refactor: change e2e tests to per page structure
* feat: add cypress type enchancements
* feat: add typescript for cypress tests
* fix: remove component after merge
* feat: update cypress definitions
* feat: add cypress cleanup task
* refactor: update cypress script names
* ci: add smoke tests to workflow
* chore: remove cypress example files
* feat: update signup flow to be reusable
* fix: fix signup route for cypress page object
* fix: remove cypress reset command
* fix: remove unused imports
* fix: Add unhandled error catcher
2022-11-08 14:21:10 +02:00
