Tomi Turtiainen
99457019f7
feat: Nudge users to become template creators if eligible ( #8357 )
2024-01-17 19:07:34 +02:00
कारतोफ्फेलस्क्रिप्ट™
3912c5e7ab
feat(core): Upgrade axios and follow-redirects to address CVE-2023-26159 ( #8366 )
2024-01-17 16:41:01 +01:00
github-actions[bot]
7268d24259
🚀 Release 1.25.0 ( #8362 )
...
Co-authored-by: netroy <netroy@users.noreply.github.com>
2024-01-17 14:20:55 +01:00
Iván Ovejero
159b328587
fix(editor): Capture indexed access expressions when building completions ( #8331 )
2024-01-17 11:02:40 +01:00
Tomi Turtiainen
dfa486e4f2
fix: Change setup credentials modal title (no-changelog) ( #8338 )
2024-01-16 09:31:44 +02:00
Ricardo Espinoza
4277e92ec0
feat(editor): Add new /templates/search
endpoint ( #8227 )
...
Updating n8n front-end to use the new search endpoint powered by TypeSense.
Endpoint is deployed on staging API so, in order to test it, use this env var:
```export N8N_TEMPLATES_HOST=https://api-staging.n8n.io/api ```
**NOTE**: This PR should not be merged until [backend changes](https://github.com/n8n-io/creators-site/pull/118 ) are merged and released.
## Related tickets and issues
https://linear.app/n8n/issue/ADO-1555/update-in-app-search-to-work-with-the-new-back-end
## Review / Merge checklist
- [x] PR title and summary are descriptive. **Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise.** ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it from happening again.
> A feature is not complete without tests.
2024-01-15 16:19:24 -05:00
Ricardo Espinoza
6b92d49ea5
fix(editor): Fix issue with synchronization table on LDAP not loading data ( #8327 )
...
## Summary
When we migrated to Vue3, we updated to a new component and did not provide the right props.
before:
https://www.loom.com/share/ce12b21fdda44176b3e949a00c582252
now:
https://www.loom.com/share/354d1dcb51bd47a9910d5bfe34c7c9b8
## Related tickets and issues
https://linear.app/n8n/issue/PAY-1134/ldap-synchronization-table-in-ui-remains-empty-even-after-successful
## Review / Merge checklist
- [x] PR title and summary are descriptive. **Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise.** ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
2024-01-15 09:03:10 -05:00
Tomi Turtiainen
135553bd6b
feat: Redirect users without feature flag from template cred setup (no-changelog) ( #8302 )
2024-01-12 12:10:39 +02:00
Alex Grozav
1824ff6a13
fix(editor): Add back missing computed prop (no-changelog) ( #8306 )
2024-01-11 16:56:42 +02:00
Alex Grozav
361cda6a7e
fix: Disable @typescript-eslint/no-use-before-define
rule (no-changelog) ( #8304 )
2024-01-11 16:15:54 +02:00
Alex Grozav
2b98835bf4
fix(editor): Remove pinData mixin (no-changelog) ( #8303 )
2024-01-11 15:04:52 +02:00
Csaba Tuncsik
3b8ccb9fb9
fix(editor): Properly set colors for connections and labels on nodes with pinned data ( #8209 )
...
Co-authored-by: Alex Grozav <alex@grozav.com>
2024-01-11 14:03:23 +01:00
Elias Meire
dcc76f3480
fix(editor): Add read only mode to filter component ( #8285 )
2024-01-11 10:28:15 +01:00
Tomi Turtiainen
d877d3ce92
fix: Adjust cred setup telemetry (no-changelog) ( #8294 )
2024-01-10 19:41:25 +02:00
कारतोफ्फेलस्क्रिप्ट™
53612def31
Merge tag 'n8n@1.24.0'
2024-01-10 16:23:39 +01:00
github-actions[bot]
8a4231e9f6
🚀 Release 1.24.0 ( #8290 )
...
Co-authored-by: ivov <ivov@users.noreply.github.com>
2024-01-10 16:16:25 +01:00
Alex Grozav
d32e6a60da
feat(editor): Migrate deviceSupportHelpers mixin to useDeviceSupport composable (no-changelog) ( #8289 )
2024-01-10 16:42:01 +02:00
Tomi Turtiainen
23abd8fb49
fix: Small ui fixes to workflow cred setup modal (no-changelog) ( #8280 )
2024-01-09 18:32:42 +02:00
Iván Ovejero
d5dcbbf8e5
ci: Fix lint setup in chat
package (no-changelog) ( #8275 )
2024-01-09 16:37:05 +01:00
Iván Ovejero
0dabe5c74e
fix: Fix user reinvites on FE and BE ( #8261 )
2024-01-09 13:52:34 +01:00
Alex Grozav
af49e95cc7
feat: Add Chat Trigger node ( #7409 )
...
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
Co-authored-by: Jesper Bylund <mail@jesperbylund.com>
Co-authored-by: OlegIvaniv <me@olegivaniv.com>
Co-authored-by: Deborah <deborah@starfallprojects.co.uk>
Co-authored-by: Jan Oberhauser <janober@users.noreply.github.com>
Co-authored-by: Jon <jonathan.bennetts@gmail.com>
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
Co-authored-by: Michael Kret <88898367+michael-radency@users.noreply.github.com>
Co-authored-by: Giulio Andreini <andreini@netseven.it>
Co-authored-by: Mason Geloso <Mason.geloso@gmail.com>
Co-authored-by: Mason Geloso <hone@Masons-Mac-mini.local>
Co-authored-by: Mutasem Aldmour <mutasem@n8n.io>
2024-01-09 13:11:39 +02:00
Jesper Bylund
9d40ae8b74
fix(editor): Tweaking button sizes in execution preview ( #8206 )
2024-01-09 10:20:22 +00:00
Tomi Turtiainen
38d91c43e3
fix: Adjust set up template button styles (no-changelog) ( #8259 )
2024-01-08 16:34:28 +02:00
Tomi Turtiainen
b6c42cc084
fix(editor): Unify canvas button positioning ( #8258 )
2024-01-08 14:44:56 +02:00
Tomi Turtiainen
04836e5c56
feat: Rename template cred setup feature flag (no-changelog) ( #8257 )
2024-01-08 14:33:21 +02:00
Alex Grozav
8c8caac4e8
feat(editor): Migrate debounce mixin to useDebounce composable (no-changelog) ( #8244 )
2024-01-08 14:00:49 +02:00
Tomi Turtiainen
8affdf680d
fix: Hide cred setup button from canvas (no-changelog) ( #8255 )
2024-01-08 13:59:04 +02:00
Tomi Turtiainen
7899f7aca5
fix: Adjust telemetry from canvas (no-changelog) ( #8252 )
2024-01-08 13:56:16 +02:00
Tomi Turtiainen
008fd5a917
test: Add e2e tests for cred setup on workflow editor (no-changelog) ( #8245 )
...
## Summary
Follow-up to https://github.com/n8n-io/n8n/pull/8240
Adds e2e tests for the template credential setup in workflow editor
## Related tickets and issues
https://linear.app/n8n/issue/ADO-1463/feature-enable-users-to-close-and-re-open-the-setup
2024-01-08 11:35:18 +02:00
Tomi Turtiainen
3cf6704dbb
feat: Enable cred setup for workflows created from templates (no-changelog) ( #8240 )
...
## Summary
Enable users to open credential setup for workflows that have been
created from templates if they skip it.
Next steps (will be their own PRs):
- Add telemetry events
- Add e2e test
- Hide the button when user sets up all the credentials
- Change the feature flag to a new one
## Related tickets and issues
https://linear.app/n8n/issue/ADO-1637/feature-support-template-credential-setup-for-http-request-nodes-that
2024-01-05 18:07:57 +02:00
Ricardo Espinoza
df5d07bcb8
feat(editor): Update copy: Execute
--> Test
( #8137 )
...
## Summary
Title self explanatory
## Related tickets and issues
https://linear.app/n8n/issue/ADO-129/update-copy-execute-test
## Review / Merge checklist
- [x] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
2024-01-05 10:23:51 -05:00
Ricardo Espinoza
2d6e406e21
fix(editor): Vertically center workflow preview loading state ( #8231 )
...
## Summary
Title self explanatory
before:
<img width="1198" alt="image"
src="https://github.com/n8n-io/n8n/assets/16496553/26c29cad-b376-40fd-9881-343f5e722d58 ">
now:
<img width="1211" alt="image"
src="https://github.com/n8n-io/n8n/assets/16496553/9f2d4020-6bf8-481a-b69f-eddb57cfaaae ">
## Related tickets and issues
[ado-1645-fix-center-loading-preview-loading-state
](https://linear.app/n8n/issue/ADO-1645/fix-center-loading-preview-loading-state )
## Review / Merge checklist
- [ x] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
2024-01-05 09:04:39 -05:00
oleg
184ed8e17d
refactor: Migrate genericHelpers
mixin to composable ( #8220 )
...
## Summary
- Moved out canvas loading handling to canvas store
- Tag editable routes via meta to remove router dependency from generic
helpers
- Replace all occurrences of `genericHelpers` mixin with composable and
audit usage
- Moved out `isRedirectSafe` and `getRedirectQueryParameter` out of
genericHelpers to remove dependency on router
Removing the router dependency is important, because `useRouter` and
`useRoute` compostables are only available if called from component
instance. So if composable is nested within another composable, we
wouldn't be able to use these. In this case we'd always need to inject
the router and pass it through several composables. That's why I moved
the `readonly` logic to router meta and `isRedirectSafe` and
`getRedirectQueryParameter` out as they were only used in a single
component.
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
2024-01-05 12:23:28 +01:00
Tomi Turtiainen
6e78d2346e
fix: Adjust 'use template' feature telemetry (no-changelog) ( #8232 )
...
- Add extra params to 'User closed cred setup' event
- Fire 'User closed cred setup' only when template has creds
- Skip cred setup page if template has no creds required
- Fire 'User inserted workflow template' also in cred setup
2024-01-05 11:52:10 +02:00
Tomi Turtiainen
8a78ae1739
fix: Add template id to workflows created from templates (no-changelog) ( #8226 )
...
In #8088 template ID was added to workflow metadata, but it was missing
from workflows that were created using the template credential setup.
This fixes that.
2024-01-05 10:36:59 +02:00
Elias Meire
071e6d6b6e
feat(editor): Add fullscreen view to code editor ( #8084 )
...
## Summary
<img width="1240" alt="image"
src="https://github.com/n8n-io/n8n/assets/8850410/2819f4ce-c343-431a-8a88-a1bc9c4b572a ">
<img width="2649" alt="image"
src="https://github.com/n8n-io/n8n/assets/8850410/36862aaf-cc4c-4668-bdc8-cf5a6f00babe ">
1. Add code node and open it
3. Click the fullscreen button in the bottom right
4. A fullscreen dialog should appear and allow editing the code
5. Changes made in the fullscreen dialog should be applied to the
original code editor when closed
It should work the same way for HTML/SQL/JSON editors
⚠️ Modal layout was updated so that modals/dialogs are centered, try to
test some modals
## Related tickets and issues
https://linear.app/n8n/issue/NODE-1009/add-fullscreen-view-to-code-node
## Review / Merge checklist
- [ ] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
> A feature is not complete without tests.
---------
Co-authored-by: Giulio Andreini <andreini@netseven.it>
2024-01-04 17:23:24 +01:00
Ricardo Espinoza
8f22a265d6
fix(editor): Only load suggested templates for owners ( #8228 )
...
## Summary
Title is self explanatory
2024-01-04 10:19:25 -05:00
Alex Grozav
b50d8058cf
feat(editor): Migrate pinData mixin to usePinnedData composable (no-changelog) ( #8207 )
...
## Summary
Required as part of NodeView refactoring:
- Migrates `pinData` mixin to `usePinnedData` composable.
- Adds `useActiveNode` and `useNodeType` composables
## Related tickets and issues
https://linear.app/n8n/issue/N8N-6355/pindata
## Review / Merge checklist
- [x] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [x] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [x] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
> A feature is not complete without tests.
2024-01-04 11:22:56 +02:00
Michael Kret
f4092a9e49
feat(Switch Node): Overhaul ( #7855 )
...
Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/switch-node-to-more-than-one-path/32791/2
https://community.n8n.io/t/switch-node-routing-same-value-multiple-output/29424
---------
Co-authored-by: Elias Meire <elias@meire.dev>
Co-authored-by: Giulio Andreini <andreini@netseven.it>
2024-01-04 11:03:03 +02:00
Tomi Turtiainen
cd3f5b5b1f
fix: Fix template credential setup for nodes that dont have credentials ( #8208 )
...
Fix template credential setup for templates whose workflow includes
nodes that require credentials but the workflow definition does not have
them defined. Like for example
https://n8n.io/workflows/1344-save-email-attachments-to-nextcloud/
2024-01-04 10:21:36 +02:00
Ricardo Espinoza
4186884740
fix: Stop showing fake door templates when user clicks on "use template" (no-changelog) ( #8219 )
...
## Summary
We stop showing the fake-door templates when the user clicks on "notify
me when it's is available" (this notification is shown when the user
clicks on "use template"). This PR changes this behavior and stop
showing the fakedoor templates when the user clicks on "use template".
Additionally, also increases the "template coming soon" notification
time from 4.5 seconds to 10 seconds.
<img width="395" alt="image"
src="https://github.com/n8n-io/n8n/assets/16496553/2e643b1f-dd52-46f0-951f-29e630241f73 ">
2024-01-03 17:04:30 -05:00
Ricardo Espinoza
8a3c87f69c
fix(editor): Items count display in running workflow ( #8148 )
...
## Summary
> Describe what the PR does and how to test. Photos and videos are
recommended.
Every time the `MainHeader` component is created, we register a new
handler for the "push" messages. Unfortunately this becomes an issue if
you go multiple times to a page that renders the `MainHeader`, e.g
`/workflow/:id`, without refreshing the page; because all handlers will
be called, causing behavior duplication.
I added the possibility of passing an ID, and made impossible to have
multiple handlers with the same ID However, it does not seems to be
needed to support an array of handlers in the pushConnection store. If
that is the case:
1. We might want to have only one handler for the push connections at
all times, which would be a much simpler approach.
2. Register the handler on app.mount instead.
The issue seems to have been introduced
[here](https://github.com/n8n-io/n8n/pull/7763/files#diff-f5dae80a64b9951bb6691f1b9d439423cf84fa0cc9601b3f2c00904f3135e8deR48 )
Before the change:
https://www.loom.com/share/85cf8ef896254d848a13a6c6438daa47
With the change:
https://www.loom.com/share/f5c4ffac421d46cc8e389364e1c357d3
## Related tickets and issues
https://linear.app/n8n/issue/ADO-1596/bug-items-count-display-in-running-workflow
## Review / Merge checklist
- [x] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
> A feature is not complete without tests.
2024-01-03 11:31:33 -05:00
github-actions[bot]
053503531f
🚀 Release 1.23.0 ( #8205 )
...
#
[1.23.0](https://github.com/n8n-io/n8n/compare/n8n@1.22.0...n8n@1.23.0 )
(2024-01-03)
### Bug Fixes
* **Asana Node:** Omit body from GET, HEAD, and DELETE requests
([#8057 ](https://github.com/n8n-io/n8n/issues/8057 ))
([15ffd4f
](15ffd4fb9f
))
* **core:** Better input validation for the changeRole endpoint
([#8189 ](https://github.com/n8n-io/n8n/issues/8189 ))
([cfe9525
](cfe9525dd4
))
* **core:** Fix issue that pinnedData is not used with Test-Webhooks
([#8123 ](https://github.com/n8n-io/n8n/issues/8123 ))
([fa8bd8b
](fa8bd8b9eb
))
* **core:** Handle empty executions table in pruning in migrations
([#8121 ](https://github.com/n8n-io/n8n/issues/8121 ))
([ffaa30d
](ffaa30ddc4
))
* **core:** Remove circular dependency in WorkflowService and
ActiveWorkflowRunner
([#8128 ](https://github.com/n8n-io/n8n/issues/8128 ))
([21788d9
](21788d9153
))
* **core:** Use pinned data only for manual mode
([#8164 ](https://github.com/n8n-io/n8n/issues/8164 ))
([ea7e76f
](ea7e76fa3b
))
* **Discord Node:** Remove unnecessary requirement on parameters
([#8060 ](https://github.com/n8n-io/n8n/issues/8060 ))
([ef3a577
](ef3a57719e
))
* **editor:** Avoid sanitizing output to search node data
([#8126 ](https://github.com/n8n-io/n8n/issues/8126 ))
([c83d9f4
](c83d9f45ba
))
* **editor:** Enable explicit undo keyboard shortcut across all code
editors ([#8178 ](https://github.com/n8n-io/n8n/issues/8178 ))
([cf7f668
](cf7f6688ba
))
* **editor:** Fix operation change failing in certain conditions
([#8114 ](https://github.com/n8n-io/n8n/issues/8114 ))
([711fa2b
](711fa2b925
))
* **editor:** Fix templates view layout
([#8196 ](https://github.com/n8n-io/n8n/issues/8196 ))
([d01e42a
](d01e42a2aa
))
* **editor:** Fix UI urls when hosted behind a path prefix
([#8198 ](https://github.com/n8n-io/n8n/issues/8198 ))
([5c078f1
](5c078f1b3d
))
* **editor:** Prevent browser zoom when scrolling inside sticky edit
mode ([#8116 ](https://github.com/n8n-io/n8n/issues/8116 ))
([e928210
](e928210ccd
))
* **editor:** Prevent canvas undo/redo when NDV is open
([#8118 ](https://github.com/n8n-io/n8n/issues/8118 ))
([39e45d8
](39e45d8b92
))
* **editor:** Prevent storing pairedItem data inside of pinData
([#8173 ](https://github.com/n8n-io/n8n/issues/8173 ))
([405e267
](405e26757e
))
* **GitHub Node:** Fix issue that File->Get did not run once per item
([#8190 ](https://github.com/n8n-io/n8n/issues/8190 ))
([11cda41
](11cda41214
))
* **Invoice Ninja Node:** Fix issue with custom invoice numbers not
working with v5 ([#8200 ](https://github.com/n8n-io/n8n/issues/8200 ))
([3b6ae2d
](3b6ae2d0a5
))
* **Microsoft Excel 365 Node:** Ensure arg is string during worksheet
table search ([#8154 ](https://github.com/n8n-io/n8n/issues/8154 ))
([8e873ca
](8e873ca2f3
))
* **Notion Node:** Ensure arg is string during page ID extraction
([#8153 ](https://github.com/n8n-io/n8n/issues/8153 ))
([e94b8a6
](e94b8a6c30
))
* **Redis Trigger Node:** Activating a workflow with a Redis trigger
fails ([#8129 ](https://github.com/n8n-io/n8n/issues/8129 ))
([a169b74
](a169b74062
))
* **Schedule Trigger Node:** Use the correct `moment` import
([#8185 ](https://github.com/n8n-io/n8n/issues/8185 ))
([17a4e2e
](17a4e2ea80
))
* Show public API upgrade CTA when feature is not enabled
([#8109 ](https://github.com/n8n-io/n8n/issues/8109 ))
([e9c7fd7
](e9c7fd7397
))
### Features
* **core:** Add closeFunction support to Sub-Nodes
([#7708 ](https://github.com/n8n-io/n8n/issues/7708 ))
([bec0fae
](bec0faed9e
))
* **core:** Add user.profile.beforeUpdate hook
([#8144 ](https://github.com/n8n-io/n8n/issues/8144 ))
([e126ed7
](e126ed74f3
))
* **core:** Improvements/overhaul for nodes working with binary data
([#7651 ](https://github.com/n8n-io/n8n/issues/7651 ))
([5e16dd4
](5e16dd4ab4
))
* **core:** Remove discontinued crypto-js
([#8104 ](https://github.com/n8n-io/n8n/issues/8104 ))
([01e9a79
](01e9a79238
))
* **core:** Unify application components shutdown
([#8097 ](https://github.com/n8n-io/n8n/issues/8097 ))
([3a881be
](3a881be6c2
))
* **editor:** Add node execution status indicator to output panel
([#8124 ](https://github.com/n8n-io/n8n/issues/8124 ))
([ab74bad
](ab74bade05
))
* **editor:** Add template Id to workflow metadata
([#8088 ](https://github.com/n8n-io/n8n/issues/8088 ))
([517b050
](517b050d0a
))
* **Home Assistant Node:** Use the new Home Assistant logo
([#8150 ](https://github.com/n8n-io/n8n/issues/8150 ))
([518a99e
](518a99e528
))
* **Qdrant Vector Store Node:** Qdrant vector store support
([#8080 ](https://github.com/n8n-io/n8n/issues/8080 ))
([66460f6
](66460f66b0
))
* **Wordpress Node:** Add option to ignore error when using self signed
certificates ([#8199 ](https://github.com/n8n-io/n8n/issues/8199 ))
([65c8e12
](65c8e12b96
))
Co-authored-by: ivov <ivov@users.noreply.github.com>
2024-01-03 13:41:28 +01:00
Michael Kret
5e16dd4ab4
feat(core): Improvements/overhaul for nodes working with binary data ( #7651 )
...
Github issue / Community forum post (link here to close automatically):
---------
Co-authored-by: Giulio Andreini <andreini@netseven.it>
Co-authored-by: Marcus <marcus@n8n.io>
2024-01-03 13:08:16 +02:00
कारतोफ्फेलस्क्रिप्ट™
5c078f1b3d
fix(editor): Fix UI urls when hosted behind a path prefix ( #8198 )
...
fixes #8061
2024-01-03 11:37:01 +01:00
कारतोफ्फेलस्क्रिप्ट™
cfe9525dd4
fix(core): Better input validation for the changeRole endpoint ( #8189 )
...
also refactored the code to
1. stop passing around `scope === 'global'`, since this code can be used
only for changing globalRole.
2. leak less details when input validation fails.
## Review / Merge checklist
- [x] PR title and summary are descriptive
- [x] Tests included
2024-01-03 09:33:35 +01:00
Iván Ovejero
0ca2759d75
refactor: Optimize SVG icons for nodes ( #8195 )
...
Running `svgo` to optimize icon size for nodes.
2024-01-02 17:40:08 +01:00
Milorad FIlipović
d01e42a2aa
fix(editor): Fix templates view layout ( #8196 )
...
## Summary
Recent changes to the template info carousel component broke the layout
of the templates way so it had excessive width when templates categories
carousel was visible.
This PR reverts disables CSS that held it in place.
## Related tickets and issues
Fixes ADO-1628
## Review / Merge checklist
- [ ] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
> A feature is not complete without tests.
2024-01-02 14:13:09 +01:00
Alex Grozav
f5a4bfe40c
feat(editor): Migrate copyPaste mixin to composables (no-changelog) ( #8179 )
2023-12-29 12:13:24 +02:00
कारतोफ्फेलस्क्रिप्ट™
216ec079c9
feat(editor): Create separate components for JS and JSON editors (no-changelog) ( #8156 )
...
## Summary
This is part-1 of refactoring our code editors to extract different type
of editors into their own components.
In part-2 we'll
1. delete a of unused or duplicate code
2. switch to a `useEditor` composable to bring more UX consistency
across all the code editors.
## Review / Merge checklist
- [x] PR title and summary are descriptive
- [x] Tests included
2023-12-29 10:49:27 +01:00
कारतोफ्फेलस्क्रिप्ट™
1286d6583c
ci: Disable import/no-extraneous-dependencies
in frontend tests (no-changelog) ( #8182 )
...
supersedes #8180
2023-12-29 10:45:55 +01:00
कारतोफ्फेलस्क्रिप्ट™
cf7f6688ba
fix(editor): Enable explicit undo keyboard shortcut across all code editors ( #8178 )
...
Fixes [ADO-801](https://linear.app/n8n/issue/ADO-801 ),
[PAY-632](https://linear.app/n8n/issue/PAY-632 ), and
[PAY-730](https://linear.app/n8n/issue/PAY-730 )
Also fixes #5297
## Review / Merge checklist
- [x] PR title and summary are descriptive
2023-12-28 14:55:23 +01:00
Alex Grozav
405e26757e
fix(editor): Prevent storing pairedItem data inside of pinData ( #8173 )
...
## Summary
When pinning data after an execution, the pairedItem data gets stored in
the pinData field. This creates problems during executions.
Before:
<img width="1141" alt="image"
src="https://github.com/n8n-io/n8n/assets/6179477/e555d00a-6ff2-4601-8072-3194a0c5e1c2 ">
After:
<img width="1140" alt="image"
src="https://github.com/n8n-io/n8n/assets/6179477/d97e9d90-28f5-4dcc-b63e-62497c646994 ">
## Related tickets and issues
https://linear.app/n8n/issue/PAY-812/wrong-error-shown-when-paireditem-fails-because-of-incorrect-pinned
## Review / Merge checklist
- [x] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [x] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [x] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
> A feature is not complete without tests.
2023-12-28 12:59:01 +02:00
कारतोफ्फेलस्क्रिप्ट™
68cff4c59e
refactor(editor): Improve linting for component and prop names (no-changelog) ( #8169 )
2023-12-28 09:49:58 +01:00
Milorad FIlipović
517b050d0a
feat(editor): Add template Id to workflow metadata ( #8088 )
...
## Summary
Adding a link between the workflow and the template it originated from
by saving `templateId` in the workflow metadata
## Related tickets and issues
ADO-1537
## Review / Merge checklist
- [x] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [x] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
> A feature is not complete without tests.
2023-12-22 15:07:05 +01:00
Mutasem Aldmour
c83d9f45ba
fix(editor): Avoid sanitizing output to search node data ( #8126 )
...
## Summary
In search feature, output sanitization was added to support `<mark` tag
in output panel to highlight searched text. This removes any html like
data in the input/output panel..
This PR removes sanitization while keeping text highlights..
## Related tickets and issues
https://community.n8n.io/t/n8n-output/33997
https://community.n8n.io/t/html-tags-in-editor-rendered/34240
https://github.com/n8n-io/n8n/issues/8081
https://linear.app/n8n/issue/ADO-1594/node-output-view-not-consistent
https://linear.app/n8n/issue/ADO-1597/bug-xml-display-issue
## Review / Merge checklist
- [X] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
> A feature is not complete without tests.
2023-12-22 15:03:40 +01:00
Milorad FIlipović
ab74bade05
feat(editor): Add node execution status indicator to output panel ( #8124 )
...
## Summary
Adding node execution status indicator to the output panel ([Figma
HiFi](https://www.figma.com/file/iUduV3M4W5wZT7Gw5vgDn1/NDV-output-pane-success-state )).
## Related tickets and issues
Fixes ADO-480
## Review / Merge checklist
- [x] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [x] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
> A feature is not complete without tests.
2023-12-22 12:50:36 +01:00
कारतोफ्फेलस्क्रिप्ट™
021add0f39
refactor(core): Move active workflows endpoints to a decorated controller class (no-changelog) ( #8101 )
...
This is a continuation of migrating all rest endpoints to decorated controller classes
2023-12-22 11:28:42 +01:00
Milorad FIlipović
39e45d8b92
fix(editor): Prevent canvas undo/redo when NDV is open ( #8118 )
...
## Summary
Preventing canvas undo/redo while NDV or any modal is open. We already
had a NDV open check in place but looks like it was broken by unreactive
ref inside `useHistoryHelper` composable.
This PR fixes this by using store getter directly inside the helper
method and adds modal open check.
## Related tickets and issues
Fixes ADO-657
## Review / Merge checklist
- [ ] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
> A feature is not complete without tests.
2023-12-22 08:42:53 +01:00
Milorad FIlipović
711fa2b925
fix(editor): Fix operation change failing in certain conditions ( #8114 )
...
## Summary
This PR handles the case when there are multiple parameters with the
same name but different `options` and `displayOptions`. In this case, if
one of such fields is set, changing the dependent parameter value so the
other should be shown causes an error in case their options are not
compatible (this
[check](7806a65229/packages/workflow/src/NodeHelpers.ts (L786)
)).
#### Example:
LDAP node has two `options` properties with the same name:
1. `attributes` with predefined options (`add`, `replace`, `delete`).
Shown when **Update** operation is selected
2. `attributes` with a collection of `attribute` objects. Shows for the
**Create** operation
Setting one of these parameter values and switching operation so the
other is shown breaks the app.
This PR checks if there is a value saved for such parameter and removes
it before calling `getNodeParameters` in `valueChanged` handler.
## Related tickets and issues
Fixes ADO-1589
## Review / Merge checklist
- [x] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [x] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
> A feature is not complete without tests.
2023-12-22 08:41:20 +01:00
Ricardo Espinoza
e9c7fd7397
fix: Show public API upgrade CTA when feature is not enabled ( #8109 )
...
## Summary
> Describe what the PR does and how to test. Photos and videos are
recommended.
Shows the public API upgrade CTA when the feature is not enabled. Now
trialing users in cloud would see the API on the settings menu and can
upgrade from there.
When public API feature disabled:
<img width="1863" alt="image"
src="https://github.com/n8n-io/n8n/assets/16496553/a9052f6b-151f-4ebb-80df-5ff2fa643e85 ">
When public API feature enabled with no API key:
<img width="1861" alt="image"
src="https://github.com/n8n-io/n8n/assets/16496553/fdfe7296-425e-4410-a8cb-f25535bc9df4 ">
When public API feature enabled with API key:
<img width="1423" alt="image"
src="https://github.com/n8n-io/n8n/assets/16496553/a8426cbf-ff73-43c4-8c60-b00274bca46e ">
## Related tickets and issues
[> Include links to **Linear ticket** or Github issue or Community forum
post. Important in order to close *automatically* and provide context to
r](https://linear.app/n8n/issue/ADO-1282/feature-api-page-missing-for-trial-users )eviewers.
## Review / Merge checklist
- [x] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [x] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
> A feature is not complete without tests.
2023-12-21 09:06:54 -05:00
github-actions[bot]
b67b5ae6b2
🚀 Release 1.22.0 ( #8115 )
...
#
[1.22.0](https://github.com/n8n-io/n8n/compare/n8n@1.21.0...n8n@1.22.0 )
(2023-12-21)
### Bug Fixes
* **core:** Close db connection gracefully when exiting
([#8045 ](https://github.com/n8n-io/n8n/pull/8045 ))
([e69707e
](e69707efd4
))
* **core:** Consider timeout in shutdown an error
([#8050 ](https://github.com/n8n-io/n8n/pull/8050 ))
([4cae976
](4cae976a3b
))
* **core:** Do not display error when stopping jobless execution in
queue mode ([#8007 ](https://github.com/n8n-io/n8n/pull/8007 ))
([8e6b951
](8e6b951a76
))
* **core:** Fix shutdown if terminating before hooks are initialized
([#8047 ](https://github.com/n8n-io/n8n/pull/8047 ))
([6ae2f5e
](6ae2f5efea
))
* **core:** Handle multiple termination signals correctly
([#8046 ](https://github.com/n8n-io/n8n/pull/8046 ))
([67bd8ad
](67bd8ad698
))
* **core:** Initialize queue once in queue mode
([#8025 ](https://github.com/n8n-io/n8n/pull/8025 ))
([53c0b49
](53c0b49d15
))
* **core:** Prevent axios from force setting a form-urlencoded
content-type ([#8117 ](https://github.com/n8n-io/n8n/pull/8117 ))
([bba9576
](bba95761e2
))
* **core:** Remove circular references before serializing executions in
public API ([#8043 ](https://github.com/n8n-io/n8n/pull/8043 ))
([989888d
](989888d9bc
))
* **core:** Restore workflow ID during execution creation
([#8031 ](https://github.com/n8n-io/n8n/pull/8031 ))
([c5e6ba8
](c5e6ba8cdd
))
* **core:** Use relative imports for dynamic imports in
SecurityAuditService ([#8086 ](https://github.com/n8n-io/n8n/pull/8086 ))
([785bf99
](785bf9974e
))
* **core:** Stop binary data restoration from preventing execution from
finishing ([#8082 ](https://github.com/n8n-io/n8n/pull/8082 ))
([5ffff1b
](5ffff1bb22
))
* **editor:** Add back credential `use` permission
([#8023 ](https://github.com/n8n-io/n8n/pull/8023 ))
([329e5bf
](329e5bf9ee
))
* **editor:** Cleanup Executions page component
([#8053 ](https://github.com/n8n-io/n8n/pull/8053 ))
([2689c37
](2689c37e87
))
* **editor:** Disable auto scroll and list size check when clicking on
executions ([#7983 ](https://github.com/n8n-io/n8n/pull/7983 ))
([fcb8b91
](fcb8b91f37
))
* **editor:** Ensure execution data overrides pinned data when copying
in executions view ([#8009 ](https://github.com/n8n-io/n8n/pull/8009 ))
([1d1cb0d
](1d1cb0d3c5
))
* **editor:** Fix copy/paste issue when switch node is in workflow
([#8103 ](https://github.com/n8n-io/n8n/pull/8103 ))
([4b86926
](4b86926752
))
* **editor:** Make keyboard shortcuts more strict; don't accept extra
Ctrl/Alt/Shift keys ([#8024 ](https://github.com/n8n-io/n8n/pull/8024 ))
([8df49e1
](8df49e134d
))
* **editor:** Show credential share info only to appropriate users
([#8020 ](https://github.com/n8n-io/n8n/pull/8020 ))
([b29b4d4
](b29b4d442b
))
* **editor:** Turn off executions list auto-refresh after leaving the
page ([#8005 ](https://github.com/n8n-io/n8n/pull/8005 ))
([e3c363d
](e3c363d72c
))
* **editor:** Update image sizes in template description not to be full
width always ([#8037 ](https://github.com/n8n-io/n8n/pull/8037 ))
([63a6e7e
](63a6e7e034
))
* **ActiveCampaign Node:** Fix pagination issue when loading tags
([#8017 ](https://github.com/n8n-io/n8n/pull/8017 ))
([1943857
](1943857231
))
* **HTTP Request Node:** Do not create circular references in HTTP
request node output ([#8030 ](https://github.com/n8n-io/n8n/pull/8030 ))
([5b7ea16
](5b7ea16d9a
))
* Upgrade axios to address CVE-2023-45857
([#7713 ](https://github.com/n8n-io/n8n/pull/7713 ))
([64eb9bb
](64eb9bbc36
))
### Features
* Add option to `returnIntermediateSteps` for AI agents
([#8113 ](https://github.com/n8n-io/n8n/pull/8113 ))
([7806a65
](7806a65229
))
* **core:** Add config option to prefer GET request over LIST when using
Hashicorp Vault ([#8049 ](https://github.com/n8n-io/n8n/pull/8049 ))
([439a22d
](439a22d68f
))
* **core:** Add N8N_GRACEFUL_SHUTDOWN_TIMEOUT env var
([#8068 ](https://github.com/n8n-io/n8n/pull/8068 ))
([614f488
](614f488386
))
* **editor:** Add lead enrichment suggestions to workflow list
([#8042 ](https://github.com/n8n-io/n8n/pull/8042 ))
([36a923c
](36a923cf7b
))
* **editor:** Finalize workers view
([#8052 ](https://github.com/n8n-io/n8n/pull/8052 ))
([edfa784
](edfa78414d
))
* **editor:** Gracefully ignore invalid payloads in postMessage handler
([#8096 ](https://github.com/n8n-io/n8n/pull/8096 ))
([9d22c7a](9d22c7a278
))
* **editor:** Upgrade frontend tooling to address a few vulnerabilities
([#8100 ](https://github.com/n8n-io/n8n/pull/8100 ))
([19b7f1f
](19b7f1ffb1
))
* **Filter Node:** Overhaul UI by adding the new filter component
([#8016 ](https://github.com/n8n-io/n8n/pull/8016 ))
([3d53052
](3d530522f8
))
* **Respond to Webhook Node:** Overhaul with improvements like returning
all items ([#8093 ](https://github.com/n8n-io/n8n/pull/8093 ))
([32d397e
](32d397eff3
))
### Performance Improvements
* **editor:** Improve canvas rendering performance
([#8022 ](https://github.com/n8n-io/n8n/pull/8022 ))
([b780436
](b780436a6b
))
Co-authored-by: ivov <ivov@users.noreply.github.com>
2023-12-21 13:51:24 +01:00
Iván Ovejero
edfa78414d
feat(editor): Finalize workers view ( #8052 )
...
https://linear.app/n8n/issue/PAY-1065
2023-12-20 17:49:14 +01:00
Iván Ovejero
d917dfe9f8
refactor(editor): Remove tracking for SAML test success (no-changelog) ( #8108 )
...
Follow-up to: https://github.com/n8n-io/n8n/pull/8102
It turns out that SAML test success cannot be tracked on the FE. We
might track on the BE, but after further discussion with Product, we do
not really need to track this property, so this PR simply removes it.
2023-12-20 15:23:00 +01:00
Elias Meire
8df49e134d
fix(editor): Make keyboard shortcuts more strict; don't accept extra Ctrl/Alt/Shift keys ( #8024 )
...
## Summary
Keyboard shortcuts such as Shift+S get triggered even when other keys
(Ctrl/Alt) are pressed, creating conflicts with browser or OS shortcuts.
This PR makes keyboard shortcuts more strict: the exact combination
needs to be pressed, no extra keys allowed.
--> Ctrl+Shift+S will no longer trigger the Shift+S shortcut to add a
sticky note
## Related tickets and issues
https://n8nio.slack.com/archives/C035KBDA917/p1702545933647959
2023-12-20 12:06:49 +01:00
Alex Grozav
fcff34c401
fix(editor): Move versions check to init function and refactor store (no-changelog) ( #8067 )
2023-12-20 12:49:40 +02:00
Iván Ovejero
faadfd6d4a
refactor(editor): Add telemetry for SSO/SAML (no-changelog) ( #8102 )
...
https://linear.app/n8n/issue/PAY-1142
2023-12-20 11:41:39 +01:00
Iván Ovejero
1d1cb0d3c5
fix(editor): Ensure execution data overrides pinned data when copying in executions view ( #8009 )
...
https://linear.app/n8n/issue/PAY-1063
https://community.n8n.io/t/execution-history-node-output-copy-to-clipboard-copies-pinned-data-instead-of-executed-node-output/33248?u=mutedjam
2023-12-20 10:42:26 +01:00
Mutasem Aldmour
4b86926752
fix(editor): Fix copy/paste issue when switch node is in workflow ( #8103 )
...
## Summary
Fix bug where copy/pasting a node breaks the view. Issue seems to be
that copied workflow does not have Switch node when workflow is
rerendering..
<img width="1942" alt="Screenshot 2023-12-19 at 18 16 23"
src="https://github.com/n8n-io/n8n/assets/4711238/ad53b8ae-3693-4733-8f6b-7bc9e7b9d216 ">
## Related tickets and issues
[Linear ticket
ADO-1504](https://linear.app/n8n/issue/ADO-1504/unwanted-nodes-connections-after-copypaste-of-n8n-form-trigger )
## Review / Merge checklist
- [X] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [x] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
> A feature is not complete without tests.
2023-12-20 10:13:59 +01:00
कारतोफ्फेलस्क्रिप्ट™
3a0155059e
feat(editor): De-duplicate frontend devDependencies (no-changelog) ( #8094 )
...
`@n8n/chat` was pulling in a lot of duplicate dependencies. This PR
updates all frontend packages to use an many of the same versions of
frontend devDependencies as possible.
## Review / Merge checklist
- [x] PR title and summary are descriptive
2023-12-19 17:43:46 +01:00
Iván Ovejero
38d1336fa7
refactor: Add telemetry for RBAC (no-changelog) ( #8056 )
...
https://linear.app/n8n/issue/PAY-1142
2023-12-19 17:02:52 +01:00
कारतोफ्फेलस्क्रिप्ट™
64eb9bbc36
fix: Upgrade axios to address CVE-2023-45857 ( #7713 )
...
[GH Advisory](https://github.com/advisories/GHSA-wf5p-g6vw-rhxx )
2023-12-19 16:17:01 +01:00
कारतोफ्फेलस्क्रिप्ट™
9d22c7a278
feat(editor): Gracefully ignore invalid payloads in postMessage handler ( #8096 )
...
It's possible for browser extensions to send `message` events to an n8n window.
This change improves the already existing check to ignore invalid messages.
Fixes https://community.n8n.io/t/errors-in-the-browser-console-on-n8n-1-version/33910
2023-12-19 15:20:29 +01:00
Milorad FIlipović
36a923cf7b
feat(editor): Add lead enrichment suggestions to workflow list ( #8042 )
...
## Summary
We want to show lead enrichment template suggestions to cloud users that
agreed to this. This PR introduces the front-end part of this feature
- Handoff document
- Figma Hi-fi
- [How to
test](https://linear.app/n8n/issue/ADO-1549/[n8n-fe]-update-workflows-list-page-to-show-fake-door-templates#comment-b6644c99 )
Tests are being worked on in a separate PR
## Related tickets and issues
Fixes ADO-1546
Fixes ADO-1549
Fixes ADO-1604
## Review / Merge checklist
- [ ] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
> A feature is not complete without tests.
---------
Co-authored-by: ricardo <ricardoespinoza105@gmail.com>
2023-12-19 09:10:03 -05:00
Alex Grozav
5ed4d19059
feat: Add opt-in enterprise license trial checkbox (no-changelog) ( #7826 )
...
<img width="518" alt="image"
src="https://github.com/n8n-io/n8n/assets/6179477/6422a057-de94-49dc-90fd-7381b5642902 ">
---------
Co-authored-by: Omar Ajoue <krynble@gmail.com>
2023-12-19 14:58:30 +02:00
Iván Ovejero
a7ffed245a
refactor(editor): Add telemetry for log streaming (no-changelog) ( #8075 )
...
https://linear.app/n8n/issue/PAY-1065
2023-12-19 13:18:13 +01:00
Iván Ovejero
d44602913f
refactor(editor): Add telemetry for debug in editor (no-changelog) ( #8073 )
...
https://linear.app/n8n/issue/PAY-1142
2023-12-19 12:23:30 +01:00
Mutasem Aldmour
63a6e7e034
fix(editor): Update image sizes in template description not to be full width always ( #8037 )
...
## Summary
Update image sizes in template description not to be full width always.
## Related tickets and issues
https://linear.app/n8n/issue/ADO-1506/bug-fix-images-in-template-descriptions
## Review / Merge checklist
- [X] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [x] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
> A feature is not complete without tests.
2023-12-18 17:40:00 +01:00
Iván Ovejero
62ce962ec9
refactor(editor): Add telemetry for workflow history (no-changelog) ( #8072 )
...
https://linear.app/n8n/issue/PAY-1142
2023-12-18 16:10:45 +01:00
Iván Ovejero
8fc9888541
refactor(editor): Add telemetry for workers view ( #8055 )
...
https://linear.app/n8n/issue/PAY-1142
2023-12-18 12:21:13 +01:00
Csaba Tuncsik
aad57e2da1
fix(editor): Update wording when an instance owner or admin is viewing a credential they do not own (no-changelog) ( #8054 )
...
## Summary
Now that instance admins and owners can share on credentials, we need to
tweak the wording so it's clear what they can do in the UI and the
access they have.
### Acceptance Criteria
When an instance owner/admin views a credential they do not own, we
should show the following text `You can view this credential because you
have permission to read and share (and rename or delete it too).`
When an instance owner/admin views a credential they do not own and has
NOT been shared with them, we should show the following text `You can
view this credential because you have permission to read and share (and
rename or delete it too). You can share it with yourself or other users
to use it in a workflow.`
2023-12-18 08:31:00 +00:00
Csaba Tuncsik
2689c37e87
fix(editor): Cleanup Executions page component ( #8053 )
...
## Summary
Remove duplicated `created` VUE component lifecycle method
2023-12-15 18:18:25 +01:00
Csaba Tuncsik
329e5bf9ee
fix(editor): Add back credential use
permission ( #8023 )
...
## Summary
A shared credential is not selectable in NDV
Aim
If a credential is shared with a user they should be able to select it
in node details view
2023-12-14 13:36:36 +01:00
Csaba Tuncsik
fcb8b91f37
fix(editor): Disable auto scroll and list size check when clicking on executions ( #7983 )
...
## Summary
Auto scrolling to the active execution is unnecessary as well as
checking if more items can be loaded.
#### How to test the change:
1. Open a workflow with a long list of executions (preferably with more
executions that fits in the list when first rendered and need to use
infinite scroll to load more items)
2. Go to executions tabs
3. Scroll to the bottom
4. Click on an item that is visible only if the list is scrolled down.
The list should not be scrolled to the active item automatically
2023-12-14 12:37:03 +01:00
Alex Grozav
3436f15e82
fix(editor): Fix dialogVisibleChanged hooks event when meta.value is undefined (no-changelog) ( #7986 )
...
## Summary
Provide details about your pull request and what it adds, fixes, or
changes. Photos and videos are recommended.
In specific scenarios `meta.value` can come as `undefined`, causing the
hook to fail.
#### How to test the change:
1. Close Expression editor modal dialog with empty value
## Issues fixed
Include links to Github issue or Community forum post or **Linear
ticket**:
> Important in order to close automatically and provide context to
reviewers
https://linear.app/n8n/issue/N8N-7084/typeerror-evalueslice-is-not-a-function-in-evalueslice1-evalueslice-is
https://n8nio.sentry.io/issues/4715787194/
## Review / Merge checklist
- [x] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again. A feature is not complete without tests.
>
> *(internal)* You can use Slack commands to trigger [e2e
tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227 )
or [deploy test
instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce )
or [deploy early access version on
Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e ).
2023-12-14 13:13:02 +02:00
oleg
b780436a6b
perf(editor): Improve canvas rendering performance ( #8022 )
...
## Summary
- Refactor usage of `setSuspendDrawing`, removing it from loops and only
calling it after batch operations are done
- Batch adding of nodes to improve copy/paste and workflow load
performance
- Cache i18n calls
- Debounce connections dragging handler if there are more than 20 nodes
## Related tickets and issues
> Include links to **Linear ticket** or Github issue or Community forum
post. Important in order to close *automatically* and provide context to
reviewers.
- https://community.n8n.io/t/slow-ui-in-big-scenarios/33830/8
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
2023-12-14 12:01:00 +01:00
Csaba Tuncsik
e3c363d72c
fix(editor): Turn off executions list auto-refresh after leaving the page ( #8005 )
...
## Summary
Fixes the bug when users leave the executions page but there is still an
ongoing request for executions.
---------
Co-authored-by: Alex Grozav <alex@grozav.com>
2023-12-14 11:50:00 +01:00
Csaba Tuncsik
b29b4d442b
fix(editor): Show credential share info only to appropriate users ( #8020 )
...
## Summary
The credential owner should not see the sharing info box
![image](https://github.com/n8n-io/n8n/assets/5410822/d85b47f8-f4cf-4009-beaf-03bc62008feb )
2023-12-14 11:48:51 +01:00
github-actions[bot]
1516c84dad
🚀 Release 1.21.0 ( #8019 )
...
#
[1.21.0](https://github.com/n8n-io/n8n/compare/n8n@1.20.0...n8n@1.21.0 )
(2023-12-13)
### Bug Fixes
* **core:** Ensure inviter and invitee are set correctly in invite link
([#7943 ](https://github.com/n8n-io/n8n/issues/7943 ))
([386bd61
](386bd61967
))
* **core:** Fix user comparison in same-user subworkflow caller policy
([#7913 ](https://github.com/n8n-io/n8n/issues/7913 ))
([92bab72
](92bab72cff
))
* **core:** Perform multi-main leader check against key ID
([#7964 ](https://github.com/n8n-io/n8n/issues/7964 ))
([1a87f70
](1a87f70e84
))
* **core:** Ensure external hooks post workflow execute run in queue
mode ([#7947 ](https://github.com/n8n-io/n8n/issues/7947 ))
([3ba7deb
](3ba7deb337
))
* **core:** Fix issue preventing secrets from loading if the path
contains - or / ([#7988 ](https://github.com/n8n-io/n8n/issues/7988 ))
([0ac9594
](0ac959463f
))
* **core:** Restrict updating/deleting of shared but not owned
credentials ([#7950 ](https://github.com/n8n-io/n8n/issues/7950 ))
([42e828d
](42e828d5c6
))
* **core:** Prevent workflow history saving error from happening
([#7812 ](https://github.com/n8n-io/n8n/issues/7812 ))
([e5581ce
](e5581ce802
))
* **editor:** Add missing string for worker in log streaming
([#7971 ](https://github.com/n8n-io/n8n/issues/7971 ))
([148bc1d
](148bc1d303
))
* **editor:** Allow SSH protocol in git repository URL for environments
([#7944 ](https://github.com/n8n-io/n8n/issues/7944 ))
([bc1c72f
](bc1c72f992
))
* **editor:** Fix bug with node names with certain characters
([#8013 ](https://github.com/n8n-io/n8n/issues/8013 ))
([26f0d57
](26f0d57f5f
))
* **editor:** Fix Webhook URL expansion icon
([#8011 ](https://github.com/n8n-io/n8n/issues/8011 ))
([b00b905
](b00b9057a4
))
* **editor:** Prevent opening NDV search if `/` is typed in a
contenteditable element
([#7968 ](https://github.com/n8n-io/n8n/issues/7968 ))
([e8a493f
](e8a493f718
))
* **editor:** Return early in ws message handler if no 'command' keyword
is found ([#7946 ](https://github.com/n8n-io/n8n/issues/7946 ))
([5b2defc
](5b2defc867
))
* **FileMaker Node:** Prevent erroring on zero fields loaded
([#7955 ](https://github.com/n8n-io/n8n/issues/7955 ))
([10ad386
](10ad386604
))
* **Google Sheets Node:** Prevent erroring on zero sheet search results
([#7957 ](https://github.com/n8n-io/n8n/issues/7957 ))
([9b877a9
](9b877a9427
))
* **Google Sheets Node:** Prevent erroring when fetching mapping columns
([#7972 ](https://github.com/n8n-io/n8n/issues/7972 ))
([29a1066
](29a10668d1
))
* **Postgres Node:** Do not include id column in upsert fields selection
if it's not unique ([#7975 ](https://github.com/n8n-io/n8n/issues/7975 ))
([435392c
](435392cbfe
))
* **Postgres Trigger Node:** Increase manual trigger timeout from 30 to
60 seconds ([#8015 ](https://github.com/n8n-io/n8n/issues/8015 ))
([09a5729
](09a5729305
))
* **Webhook Node:** Binary data handling
([#7804 ](https://github.com/n8n-io/n8n/issues/7804 ))
([565b409
](565b409a82
))
* **Webhook Node:** Do not create binary data when there is no data in
the request ([#8000 ](https://github.com/n8n-io/n8n/issues/8000 ))
([70f0755
](70f0755278
))
### Features
* **core:** Add config option for external secret update interval
([#7995 ](https://github.com/n8n-io/n8n/issues/7995 ))
([b6c1c04
](b6c1c04b54
))
* AI nodes usability fixes + Summarization Chain V2
([#7949 ](https://github.com/n8n-io/n8n/issues/7949 ))
([dcf1286
](dcf12867b3
))
* **editor:** Data transformation nodes and actions in Nodes Panel
([#7760 ](https://github.com/n8n-io/n8n/issues/7760 ))
([675ec21
](675ec21d33
))
* **editor:** Add AppCues tracking for onboarding event
([#7945 ](https://github.com/n8n-io/n8n/issues/7945 ))
([04cabaf
](04cabafef7
))
* **editor:** Add option to disable NDV in workflow previews
([#7990 ](https://github.com/n8n-io/n8n/issues/7990 ))
([393afef
](393afef174
))
* **editor:** Filter component + implement in If node
([#7490 ](https://github.com/n8n-io/n8n/issues/7490 ))
([8a53434
](8a5343401d
))
* **editor:** Show template credential setup based on feature flag
([#7989 ](https://github.com/n8n-io/n8n/issues/7989 ))
([08ee307
](08ee307209
))
* **editor:** Introduce advanced permissions
([#7844 ](https://github.com/n8n-io/n8n/issues/7844 ))
([dbd62a4
](dbd62a4992
))
* **Google Ads Node:** Update to support v15
([#7962 ](https://github.com/n8n-io/n8n/issues/7962 ))
([7f01269
](7f0126915a
))
* **Local File Trigger Node:** Add polling option typically good to
watch network files/folders
([#7942 ](https://github.com/n8n-io/n8n/issues/7942 ))
([2fbdfec
](2fbdfec0c0
))
* **n8n Form Trigger Node:** Improvements
([#7571 ](https://github.com/n8n-io/n8n/issues/7571 ))
([953a58f
](953a58f18b
))
Co-authored-by: ivov <ivov@users.noreply.github.com>
2023-12-13 16:34:00 +01:00
कारतोफ्फेलस्क्रिप्ट™
d7ce4624c8
Merge tag 'n8n@1.20.0'
2023-12-13 16:11:30 +01:00
Michael Kret
953a58f18b
feat(n8n Form Trigger Node): Improvements ( #7571 )
...
Github issue / Community forum post (link here to close automatically):
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
Co-authored-by: Giulio Andreini <andreini@netseven.it>
2023-12-13 17:00:51 +02:00
Jan Oberhauser
26f0d57f5f
fix(editor): Fix bug with node names with certain characters ( #8013 )
...
## Summary
Fixes the issue that dots and other special characters can not be used
in node-names
## Related tickets and issues
https://linear.app/n8n/issue/ADO-1244/nodes-wont-output-data-if-the-name-contains-some-characters
https://community.n8n.io/t/bug-report-name-of-node-affects-output-data/31674
https://community.n8n.io/t/stripe-output-data/32418/1
https://community.n8n.io/t/monday-com-returning-items-but-no-data/31834
https://community.n8n.io/t/no-data-while-there-is-actually-data/32563
https://community.n8n.io/t/bug-report-periods-in-node-names/34119
https://github.com/n8n-io/n8n/issues/7896
## Review / Merge checklist
- [ ] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
> A feature is not complete without tests.
---------
Co-authored-by: Alex Grozav <alex@grozav.com>
2023-12-13 14:57:01 +00:00
Elias Meire
8a5343401d
feat(editor): Filter component + implement in If node ( #7490 )
...
New Filter component + implementation in If node (v2)
<img width="3283" alt="image"
src="https://github.com/n8n-io/n8n/assets/8850410/35c379ef-4b62-4d06-82e7-673d4edcd652 ">
---------
Co-authored-by: Giulio Andreini <andreini@netseven.it>
Co-authored-by: Michael Kret <michael.k@radency.com>
2023-12-13 14:45:22 +01:00
Jan Oberhauser
b00b9057a4
fix(editor): Fix Webhook URL expansion icon ( #8011 )
...
Changes the rotation of the icon.
New collapsed:
![Screenshot from 2023-12-13
12-06-12](https://github.com/n8n-io/n8n/assets/6249596/2991a660-d6b4-4272-88cf-6a2356d02a7e )
New expanded:
![Screenshot from 2023-12-13
12-06-22](https://github.com/n8n-io/n8n/assets/6249596/0766db9e-b868-49a8-9009-dfff4ab0b13b )
2023-12-13 12:40:44 +01:00
Giulio Andreini
8f364087c9
docs(editor): Change to Summarize icon and Advanced section description (no-changelog) ( #8008 )
...
## Summary
- Change the description of the Advanced" section
- Replace the icon of Summarize
## Related tickets and issues
https://linear.app/n8n/issue/NODE-984/data-transformations-menu-minor-fixes
## Review / Merge checklist
- [ ] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
> A feature is not complete without tests.
2023-12-13 12:18:29 +01:00
Benjamin Loison
61129863f1
docs: Replace
http://faircode.io to
https://faircode.io in .md
files ( #7908 )
...
## Summary
Commit generated with:
```bash
grep -rl 'http://faircode.io ' --include=*.md . | xargs sed -i 's/http:\/\/faircode.io/https:\/\/faircode.io/g'
```
## Review / Merge checklist
- [X] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [ ] Tests included.
2023-12-12 15:23:22 +00:00
Tomi Turtiainen
08ee307209
feat(editor): Show template credential setup based on feature flag ( #7989 )
...
Replace the local storage based feature flag with posthog feature flag.
Also:
- Fix bunch of eslint warnings in posthog store
2023-12-11 20:21:10 +02:00
Milorad FIlipović
240d259260
refactor(editor): Rename CollectionCard and CollectionCardCarousel ( #7994 )
...
## Summary
As part of the plan to reuse current `CollectionCarousel` component,
this PR makes it, and the cards it uses, more generic by renaming them
and adds a new property to card component which can be used to hide the
item count.
#### How to test the change:
Until the component that will use this is implmeneted, this can be
tested manually:
1. Run n8n
2. Set `showItemCount` property for workflow collection cards to `false`
3. Check if workflow count is showing (it shouldn't) and if everything
rendering correctly
## Issues fixed
Fixes ADO-1567
## Review / Merge checklist
- [ ] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again. A feature is not complete without tests.
>
> *(internal)* You can use Slack commands to trigger [e2e
tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227 )
or [deploy test
instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce )
or [deploy early access version on
Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e ).
2023-12-11 17:37:26 +01:00
Milorad FIlipović
393afef174
feat(editor): Add option to disable NDV in workflow previews ( #7990 )
...
## Summary
This PR adds a new property to the `WorkflowPreview` component that
controls if the Node Details View can be opened in each workflow preview
or not.
This property is passed on to underlying `iframe` via the `postMessage`
and is used to disable pointer events for nodes and stickies in that
preview.
#### How to test the change:
Until the component that uses this flag is implemented this can be
tested manually. In this example, we'll use `WorkflowPreview` as part of
the `TemplatesWorkflowView` component
1. Pass `:canOpenNDV="false"` to this component
2. Run n8n
3. Open any template preview and check if nodes and stickies are
interactive
4. Open any workflow execution preview -> Nodes and Stickies should be
interactive
## Issues fixed
Fixes ADO-1548
## Review / Merge checklist
- [ ] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again. A feature is not complete without tests.
>
> *(internal)* You can use Slack commands to trigger [e2e
tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227 )
or [deploy test
instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce )
or [deploy early access version on
Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e ).
2023-12-11 15:30:01 +01:00
Jon
97e39c39d9
docs: Replace references to set node (no-changelog) ( #7973 )
...
## Summary
This replaces the set node references with edit fields.
Ref: https://n8nio.slack.com/archives/C036PA5D42D/p1702040900165709
2023-12-11 10:10:03 +00:00