mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-11-14 08:34:07 -08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity
9785 commits 1050 branches 1593 tags 390 MiB
Commit graph

8779 commits

Author SHA1 Message Date
कारतोफ्फेलस्क्रिप्ट™ 9bdb85c4ce
fix(core): Prevent executions from becoming forever running (#7569) 
Fixes CP-867
Possibly also fixes PAY-323 and PAY-412
 2023-11-01 13:51:13 +01:00
Giulio Andreini 0746783e02
refactor(editor): Color palette updates, introduce dark mode (#6980) 
Github issue / Community forum post (link here to close automatically):

---------

Co-authored-by: Mutasem <mutdmour@gmail.com>
 2023-11-01 13:33:36 +01:00
Yoshino-s b72040aa54
feat(n8n Form Trigger Node): Add text area and password input types (#7474) 
Signed-off-by: yoshino-s <cy-cui@outlook.com>
 2023-11-01 12:23:28 +00:00
Milorad FIlipović ce14f6266b
feat(editor): Implement the UserStack design system component (#7559) 
Adds [`UserStack`
component](https://www.figma.com/file/5MfPO6Eg2YVfXETAzoGahf/Debt-days-August2023?type=design&node-id=10-13056&mode=design&t=tuJAgCdzkN506SlE-0)
to our design system
 2023-11-01 09:26:06 +01:00
Csaba Tuncsik b94b8b2eb0
fix(editor): Rename and move isObjectLiteral utility function (no-changelog) (#7565) 2023-10-31 21:28:01 +01:00
Iván Ovejero c6b688387c
refactor(core): Enable useUnknownInCatchVariables in workflow package (no-changelog) (#7549) 2023-10-31 13:59:33 +01:00
Michael Auerswald b350568505
fix(core): Fix data decryption on credentials import (#7560) 
Due to a change, during the credentials import command, the core's
Credential object is being called through its prototype. This caused the
Credential's cipher variable to not be set, thus no cipher service being
available during import. This fix catches this edge case and provides a
fix.
 2023-10-31 13:15:09 +01:00
OlegIvaniv 774d521dbd
fix(editor): Keep NodeView component alive for TEMPLATE_IMPORT and WORKFLOW_ONBOARDING routes (no-changelog) (#7557) 
Github issue / Community forum post (link here to close automatically):
 2023-10-31 10:03:57 +01:00
OlegIvaniv 7a56e58a60
fix(Switch Node): Allow sortable Switch rules (#7555) 
Github issue / Community forum post (link here to close automatically):

Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
 2023-10-31 09:13:31 +01:00
Jan Oberhauser 655efeaf66
feat(core): Add optional Error-Output (#7460) 
Add an additional optional error output to which all items get sent that
could not be processed.
![Screenshot from 2023-10-18
17-29-15](https://github.com/n8n-io/n8n/assets/6249596/e9732807-ab2b-4662-a5f6-bdff24f7ad55)

Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/error-connector-for-nodes/3094

https://community.n8n.io/t/error-handling-at-node-level-detect-node-execution-status/26791

---------

Co-authored-by: OlegIvaniv <me@olegivaniv.com>
 2023-10-30 18:42:47 +01:00
Iván Ovejero 442c73e63b
feat(core): Set up leader selection for multiple main instances (#7527) 
https://linear.app/n8n/issue/PAY-933/set-up-leader-selection-for-multiple-main-instances

- [x] Set up new envs
- [x] Add config and license checks
- [x] Implement `MultiMainInstancePublisher`
- [x] Expand `RedisServicePubSubPublisher` to support
`MultiMainInstancePublisher`
- [x] Init `MultiMainInstancePublisher` on startup and destroy on
shutdown
- [x] Add to sandbox plans
- [x] Test manually

Note: This is only for setup - coordinating in reaction to leadership
changes will come in later PRs.
 2023-10-30 16:22:32 +01:00
Csaba Tuncsik 3b5e181e66
fix(editor): Fix NDV close after using input select (#7544) 2023-10-30 13:44:19 +01:00
Iván Ovejero 784b43330b
refactor(GitHub Trigger Node): Stop reporting to Sentry permission errors (no-changelog) (#7552) 
https://n8nio.sentry.io/issues/4581327606/
 2023-10-30 12:12:43 +01:00
Jackson ea5cd3140f
docs: Fix spelling issue in Gmail trigger node (#7545) 
IDK how I noticed this
 2023-10-30 11:30:53 +01:00
OlegIvaniv 3ab04e4f9e
ci(core): Extract local e2e run script (no-changelog) (#7551) 
Github issue / Community forum post (link here to close automatically):

---------

Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
 2023-10-30 11:18:51 +01:00
Csaba Tuncsik 2853fcff73
fix(editor): Fix NDV unexpected re-render (#7532) 2023-10-30 09:22:08 +01:00
Iván Ovejero 233683ce1a
refactor(core): Remove webhook deregistration on shutdown flag (#7543) 
Removal missing from [original
PR](https://github.com/n8n-io/n8n/pull/7515) after initial revert.
 2023-10-27 18:48:21 +02:00
Iván Ovejero 18dcea8c19
refactor(Slack Node): Stop reporting to Sentry errors from missing scopes (no-changelog) (#7542) 
https://n8nio.sentry.io/issues/4570238312
 2023-10-27 16:46:05 +02:00
Iván Ovejero 6796ba75a1
refactor(core): Stop reporting to Sentry stopping execution with wrong status (no-changelog) (#7541) 
https://n8nio.sentry.io/issues/4257040218/
 2023-10-27 16:14:01 +02:00
कारतोफ्फेलस्क्रिप्ट™ c05bc6728d
fix(editor): Handle localStorage being blocked/unavailable (#7348) 2023-10-27 15:51:20 +02:00
कारतोफ्फेलस्क्रिप्ट™ 35bb42c1b9
refactor(core): Avoid passing around static state like default timezone (no-changelog) (#7221) 2023-10-27 14:17:52 +02:00
Iván Ovejero 62c096710f
refactor: Run lintfix (no-changelog) (#7537) 
- Fix autofixable violations
- Remove unused directives
- Allow for PascalCased variables - needed for dynamically imported or
assigned classes, decorators, routers, etc.
 2023-10-27 14:15:02 +02:00
Alex Grozav 1c4ac02db5
fix(editor): Fix executions sidebar height (no-changelog) (#6909) 
<img width="1397" alt="image"
src="https://github.com/n8n-io/n8n/assets/6179477/cb142085-3b21-4e18-9f0d-92c5c4018578">
 2023-10-27 14:32:23 +03:00
Iván Ovejero 07857e78a9
refactor(core): Stop reporting to Sentry non-execution of workflow with issues (#7533) 
https://n8nio.sentry.io/issues/4578929841/
 2023-10-27 10:09:23 +02:00
Iván Ovejero 9762705833
fix(Jira Software Node): Handle missing issue types in issue types loader (#7534) 
https://n8nio.sentry.io/issues/4576849854
 2023-10-27 10:09:14 +02:00
Omar Ajoue 87996a1fcf
refactor(core): Stop reporting non-error to sentry (issue 4229454473) (no-changelog) (#7525) 
This PR aims to stop reporting issues such as [this
one](https://n8nio.sentry.io/issues/4229454473/events/42b96bfd6a334c15a84499e981cf90eb/?project=4503924908883968).

Github issue / Community forum post (link here to close automatically):
 2023-10-27 09:25:07 +02:00
Csaba Tuncsik 12a89e6d14
fix(editor): Fix route component caching, incorrect use of array reduce method and enable WF history feature (#7434) 
Co-authored-by: Giulio Andreini <andreini@netseven.it>
 2023-10-26 20:47:42 +02:00
Iván Ovejero ae616f146b
fix(editor): Do not truncate form inputs (#7528) 2023-10-26 17:54:51 +02:00
Omar Ajoue 3d95b243e9
feat(core): Make queue mode settings configurable (#7526) 
This PR allows users to configure the settings to Bull, possibly
reducing the errors with `maxStalledCount` and other issues, that
usually happen either when a worker crashes or when the event loop is
super busy. Increasing the lease time and the `maxStalledCount` settings
might improve UX.

Github issue / Community forum post (link here to close automatically):
 2023-10-26 17:30:16 +02:00
Iván Ovejero ae8c7a635e
refactor(core)!: Remove webhook deregistration at startup and shutdown (#7515) 
https://linear.app/n8n/issue/PAY-932/deprecate-flag-to-skip-webhook-deregistration-on-shutdown
 2023-10-26 14:37:54 +02:00
Iván Ovejero 5477e3fb45
refactor(core): Move execution save settings into lifecycle function (no-changelog) (#7370) 
Move the handling of execution save settings into a tested lifecycle
function as discussed with Omar
 2023-10-26 14:35:38 +02:00
कारतोफ्फेलस्क्रिप्ट™ 1055bd3762
fix(core): Handle missing resultData in runData (#7523) 2023-10-26 13:15:19 +02:00
Iván Ovejero d8ec6eac40
refactor(FileMaker Node): Prevent reporting to Sentry attempted loadOptions calls without credentials (no-changelog) (#7520) 
Severity is lost when wrapping the error, but there is no need to change
the error type here.

https://n8nio.slack.com/archives/C03MZF137FV/p1698308092989739
 2023-10-26 12:02:35 +02:00
Iván Ovejero a277807404
refactor(Airtable Node): Prevent reporting to Sentry failure to find table (no-changelog) (#7521) 
https://n8nio.sentry.io/issues/4356342982/?project=4503924908883968&query=is%3Aunresolved&referrer=issue-stream&statsPeriod=14d&stream_index=8
 2023-10-26 12:02:23 +02:00
Iván Ovejero d885daa6a1
refactor(Google Sheets Node): Prevent reporting to Sentry failure to find spreadsheet (no-changelog) (#7518) 
To silence this very frequently reported error:
https://n8nio.sentry.io/issues/3823103947/?project=4503924908883968&query=&referrer=issue-stream&statsPeriod=90d&stream_index=0
 2023-10-26 11:33:11 +02:00
कारतोफ्फेलस्क्रिप्ट™ 65e5593233
fix(core): Upgrade crypto-js to address CVE-2023-46233 (#7519) 
[GH Advisory](https://github.com/advisories/GHSA-xwcq-pm8m-c4vf)
 2023-10-26 11:21:53 +02:00
Jan Oberhauser df89685e15
fix(editor): Fixes the issue that Switch Node can not be created (#7516) 
Fixes the issue that currently no Switch-Node can be created by for
example pressing + on the parent node or via tab when another node is
already selected.

Github issue / Community forum post (link here to close automatically):

---------

Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Oleg Ivaniv <me@olegivaniv.com>
 2023-10-26 09:46:26 +02:00
Iván Ovejero 742c8a8534
fix(core): Ensure execution deletion in worker lifecycle hook (#7481) 
Reported by customer
[here](https://n8nio.slack.com/archives/C05PUALKZHD/p1697446945481249?thread_ts=1697196557.638169&cid=C05PUALKZHD),
apparently a very old long-standing bug for queue mode. Please review
closely as I am not familiar with queue mode.
 2023-10-25 19:13:06 +02:00
कारतोफ्फेलस्क्रिप्ट™ 05586a900d
refactor(core): Make Logger a service (no-changelog) (#7494) 2023-10-25 16:35:22 +02:00
github-actions[bot] db4e61ba24
🚀 Release 1.14.0 (#7514) 
# [1.14.0](https://github.com/n8n-io/n8n/compare/n8n@1.13.0...n8n@1.14.0)
(2023-10-25)


### Features

* **Switch Node:** Add support for infinite Switch outputs
([#7499](https://github.com/n8n-io/n8n/issues/7499))
([2febc61](2febc61ec9))

Co-authored-by: netroy <netroy@users.noreply.github.com>
 2023-10-25 15:34:57 +02:00
कारतोफ्फेलस्क्रिप्ट™ 0643487403 ci: Fix oclif manifest generation 2023-10-25 14:51:10 +02:00
कारतोफ्फेलस्क्रिप्ट™ 28aabb845a Merge remote-tracking branch 'origin/release/1.13.0' 2023-10-25 14:50:48 +02:00
OlegIvaniv 2febc61ec9
feat(Switch Node): Add support for infinite Switch outputs (#7499) 
Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/add-more-outputs-to-switch-node/3864

---------

Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
 2023-10-25 14:34:47 +02:00
github-actions[bot] 2987587e34
🚀 Release 1.13.0 (#7512) 
# [1.13.0](https://github.com/n8n-io/n8n/compare/n8n@1.12.0...n8n@1.13.0)
(2023-10-25)


### Bug Fixes

* **core:** Do not return `inviteAcceptUrl` in response if email was
sent ([#7465](https://github.com/n8n-io/n8n/issues/7465))
([55c6a1b](55c6a1b0d3))
* **core:** Ensure nodes post-processors run in the correct order
([#7500](https://github.com/n8n-io/n8n/issues/7500))
([6f45298](6f45298d3d))
* **core:** Fix `frontend.settings` external hook execution
([#7496](https://github.com/n8n-io/n8n/issues/7496))
([774fe20](774fe202bf))
* **core:** Handle gzip and deflate compressed request payloads
([#7461](https://github.com/n8n-io/n8n/issues/7461))
([83762e0](83762e051d))
* **core:** Reduce logging overhead for levels that do not output
([#7479](https://github.com/n8n-io/n8n/issues/7479))
([76c0481](76c04815f7))
* **Customer.io Node:** Fix api endpoint when using EU region
([#7485](https://github.com/n8n-io/n8n/issues/7485))
([519680c](519680c2cf))
* **editor:** Allow importing the same workflow multiple times
([#7458](https://github.com/n8n-io/n8n/issues/7458))
([3c0a166](3c0a166f7f))
* **editor:** Fix canvas selection breaking after interacting with node
actions ([#7466](https://github.com/n8n-io/n8n/issues/7466))
([bc47365](bc473655fb))
* **editor:** Fix connections disappearing after reactivating canvas and
renaming a node ([#7483](https://github.com/n8n-io/n8n/issues/7483))
([450e0cc](450e0cc66a))
* **Google Sheets Node:** Append or update runs forever when without
column headers ([#7463](https://github.com/n8n-io/n8n/issues/7463))
([ab6a9bb](ab6a9bbac2))
* **Microsoft SQL Node:** Prevent SQL injection
([#7467](https://github.com/n8n-io/n8n/issues/7467))
([a739245](a739245332))
* **MQTT Trigger Node:** Fix node causing a start up hang when active
([#7498](https://github.com/n8n-io/n8n/issues/7498))
([baecb93](baecb93bef))
* **MySQL Node:** Resolve expressions in v1
([#7464](https://github.com/n8n-io/n8n/issues/7464))
([5c46bb0](5c46bb09c1))
* **Redis Node:** Fix adding sets data types
([#7444](https://github.com/n8n-io/n8n/issues/7444))
([4e66023](4e66023cd4))
* **Spreadsheet File Node:** Fix include empty cells not working with v2
([#7505](https://github.com/n8n-io/n8n/issues/7505))
([05e6f2a](05e6f2a6ac))


### Features

* **core:** Add support for oauth based service accounts with UM SMTP
([#7311](https://github.com/n8n-io/n8n/issues/7311))
([647372b](647372be27))
* **editor:** Add PH tracking to event
([#7511](https://github.com/n8n-io/n8n/issues/7511))
([c47d27d](c47d27dd6d))
* **Facebook Lead Ads Trigger Node:** Add Facebook Lead Ads Trigger Node
([#7113](https://github.com/n8n-io/n8n/issues/7113))
([ac814a9](ac814a9c61))
* **Ghost Node:** Add support for lexical format
([#7488](https://github.com/n8n-io/n8n/issues/7488))
([7b1973c](7b1973c058))
* **RSS Feed Trigger Node:** Add RSS feed trigger node
([#7386](https://github.com/n8n-io/n8n/issues/7386))
([689360e](689360ee06))

Co-authored-by: netroy <netroy@users.noreply.github.com>
 2023-10-25 14:29:28 +02:00
कारतोफ्फेलस्क्रिप्ट™ 6f45298d3d
fix(core): Ensure nodes post-processors run in the correct order (#7500) 
Fixes #7497
 2023-10-25 13:59:38 +02:00
Mutasem Aldmour c47d27dd6d
feat(editor): Add PH tracking to event (#7511) 
Github issue / Community forum post (link here to close automatically):
 2023-10-25 12:18:19 +02:00
Val 93cfabbeac
fix(core): Fix workflow activation with history and workflow history for EE (no-changelog) (#7508) 
Github issue / Community forum post (link here to close automatically):
 2023-10-25 11:07:11 +01:00
Iván Ovejero 671c95760b
refactor(core): Make executions pruning more resilient (#7480) 
This PR converts the hard-deletion interval to a timeout:
- to prevent the interval from not being restored when hard deletion
throws, and
- to prevent a long-running hard deletion from leading to duplicate
deletions.
 2023-10-24 16:16:45 +02:00
Jon 05e6f2a6ac
fix(Spreadsheet File Node): Fix include empty cells not working with v2 (#7505) 
Github issue / Community forum post (link here to close automatically):
Ticket#763644
 2023-10-24 14:22:45 +01:00
कारतोफ्फेलस्क्रिप्ट™ 8ff9f97493
fix(core): Create instance settings directory recursively (no-changelog) (#7506) 2023-10-24 15:10:22 +02:00
Michael Kret a739245332
fix(Microsoft SQL Node): Prevent SQL injection (#7467) 
Github issue / Community forum post (link here to close automatically):

---------

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
 2023-10-24 12:36:44 +03:00
Iván Ovejero 78243edd18
refactor(core): Make pruning via lifecycle configuration in S3 mode mandatory (#7482) 
Since we do not store which executions produced binary data, for pruning
on S3 we need to query for binary data items for each execution in order
to delete them. To minimize requests to S3, allow the user to skip
pruning requests when setting TTL at bucket level.
 2023-10-24 10:37:02 +02:00
कारतोफ्फेलस्क्रिप्ट™ a9fdd018f4
fix(core): Always derive instanceId from the encryption key (no-changlog) (#7501) 
This was the expected behavior, until I changed it in
https://github.com/n8n-io/n8n/pull/7471
 2023-10-24 09:55:57 +02:00
Val baecb93bef
fix(MQTT Trigger Node): Fix node causing a start up hang when active (#7498) 
Github issue / Community forum post (link here to close automatically):
 2023-10-24 09:37:49 +02:00
Cornelius Suermann 3ef771ea38
feat: Collect usage metrics on license renewal (no-changelog) (#7486) 2023-10-23 21:39:29 +02:00
Ricardo Espinoza 774fe202bf
fix(core): Fix frontend.settings external hook execution (#7496) 2023-10-23 11:46:13 -04:00
Burak Akgün 4e66023cd4
fix(Redis Node): Fix adding sets data types (#7444) 
Fixes #6339
 2023-10-23 16:33:44 +01:00
Val 41236b7e08
fix: Save new version of the workflow instead of the previous (no-changelog) (#7428) 
Github issue / Community forum post (link here to close automatically):
 2023-10-23 16:30:36 +02:00
कारतोफ्फेलस्क्रिप्ट™ b6de910cbe
refactor(core): Abstract away InstanceSettings and encryptionKey into injectable services (no-changelog) (#7471) 
This change ensures that things like `encryptionKey` and `instanceId`
are always available directly where they are needed, instead of passing
them around throughout the code.
 2023-10-23 13:39:35 +02:00
Léo Martinez 519680c2cf
fix(Customer.io Node): Fix api endpoint when using EU region (#7485) 
Fixes #7484
 2023-10-23 10:01:48 +01:00
MC Naveen 7b1973c058
feat(Ghost Node): Add support for lexical format (#7488) 2023-10-23 10:00:38 +01:00
OlegIvaniv 450e0cc66a
fix(editor): Fix connections disappearing after reactivating canvas and renaming a node (#7483) 
Github issue / Community forum post (link here to close automatically):
-
https://community.n8n.io/t/1-11-1-possible-bug-all-nodes-randomly-losing-their-connectors/31856
- https://community.n8n.io/t/lines-between-nodes-have-disappeared/31846

---------

Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
 2023-10-23 10:07:33 +02:00
कारतोफ्फेलस्क्रिप्ट™ 76c04815f7
fix(core): Reduce logging overhead for levels that do not output (#7479) 
all current logging calls execute `callsites()` to figure out what code
tried to log. This happens even for logging methods that aren't supposed
to create any output. Under moderate load, this can take up quite a lot
of resources. This PR changes the logger to make all ignorable logging
methods a No-Op.

In a small benchmark with a simple webhook, with log-level set to
`warn`, and using `ab -c 50 -n 500
http://localhost:5678/webhook/testing`, these were the response times:

### Before

![Before](https://github.com/n8n-io/n8n/assets/196144/01680fd9-3d2a-4f7f-bb1c-5b03bd7d5bc3)

### After

![After](https://github.com/n8n-io/n8n/assets/196144/ccacb20a-48ca-455a-a8cb-098c9c0e352e)
 2023-10-20 18:26:33 +02:00
Iván Ovejero 0b42d1aa71
refactor(core): Limit soft-deletions to pruning only (#7469) 
Based on customer feedback, we should limit soft deletions to pruning
only, to prevent executions from piling up in very high volume cases.
 2023-10-20 15:02:47 +02:00
कारतोफ्फेलस्क्रिप्ट™ 3c0a166f7f
fix(editor): Allow importing the same workflow multiple times (#7458) 
Fixes #7457
 2023-10-20 13:58:30 +02:00
Elias Meire ac814a9c61
feat(Facebook Lead Ads Trigger Node): Add Facebook Lead Ads Trigger Node (#7113) 
Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/facebook-lead-ads-integration/4590/19

---------

Co-authored-by: Marcus <marcus@n8n.io>
 2023-10-20 13:43:55 +02:00
Jon 647372be27
feat(core): Add support for oauth based service accounts with UM SMTP (#7311) 
This PR adds support for using OAuth based service accounts for the User
Management SMTP connection.

Tested using a Google Service Account.
 2023-10-20 11:36:40 +01:00
कारतोफ्फेलस्क्रिप्ट™ 91dfc4d513
feat(core): Update LLM applications building support (no-changelog) (#7418) 
extracted out of #7336

---------

Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
Co-authored-by: OlegIvaniv <me@olegivaniv.com>
Co-authored-by: Jan Oberhauser <janober@users.noreply.github.com>
Co-authored-by: Val <68596159+valya@users.noreply.github.com>
Co-authored-by: Alex Grozav <alex@grozav.com>
Co-authored-by: Deborah <deborah@starfallprojects.co.uk>
Co-authored-by: Jesper Bylund <mail@jesperbylund.com>
Co-authored-by: Jon <jonathan.bennetts@gmail.com>
 2023-10-20 10:52:56 +02:00
Iván Ovejero 34f3f8001e
fix(n8n Form Trigger Node): Fix typos (no-changelog) (#7472) 2023-10-20 10:49:58 +02:00
Michael Kret 5c46bb09c1
fix(MySQL Node): Resolve expressions in v1 (#7464) 
Github issue / Community forum post (link here to close automatically):
 2023-10-20 11:09:39 +03:00
Milorad FIlipović bc473655fb
fix(editor): Fix canvas selection breaking after interacting with node actions (#7466) 
Sometimes canvas selection stops working after users interact with node
action buttons (for example if node is moved by dragging one of the
buttons)
NOTE: Ticket number in the branch name is wrong, this fixes ADO-1226
 2023-10-20 09:26:40 +02:00
Iván Ovejero b50376cf52
refactor(core): Make executions pruning settings configurable (#7468) 2023-10-19 16:57:12 +02:00
Csaba Tuncsik c7c8048430
feat(editor): Workflow history [WIP] - Remove pinned data from workflow history version preview (no-changelog) (#7406) 2023-10-19 14:38:00 +02:00
Csaba Tuncsik 82129694c6
feat(editor): Workflow history [WIP] - Add cloned workflow link to success toast message (no-changelog) (#7405) 2023-10-19 14:02:59 +02:00
कारतोफ्फेलस्क्रिप्ट™ 55c6a1b0d3
fix(core): Do not return inviteAcceptUrl in response if email was sent (#7465) 2023-10-19 13:58:06 +02:00
Michael Kret ab6a9bbac2
fix(Google Sheets Node): Append or update runs forever when without column headers (#7463) 
Github issue / Community forum post (link here to close automatically):

---------

Co-authored-by: Marcus <marcus@n8n.io>
 2023-10-19 14:54:13 +03:00
Jon 689360ee06
feat(RSS Feed Trigger Node): Add RSS feed trigger node (#7386) 
Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/rss-trigger/14203
 2023-10-19 08:49:18 +01:00
कारतोफ्फेलस्क्रिप्ट™ 83762e051d
fix(core): Handle gzip and deflate compressed request payloads (#7461) 
NODE-870
 2023-10-18 21:52:15 +02:00
github-actions[bot] ef58a23d21
🚀 Release 1.12.0 (#7459) 
# [1.12.0](https://github.com/n8n-io/n8n/compare/n8n@1.11.0...n8n@1.12.0)
(2023-10-18)


### Bug Fixes

* **core:** Add check that queue is defined and remove cyclic dependency
([#7404](https://github.com/n8n-io/n8n/issues/7404))
([45f2ef3](45f2ef373e))
* **core:** Do not throw when deleting workflows with executions without
binary-data ([#7411](https://github.com/n8n-io/n8n/issues/7411))
([2b6a15e](2b6a15e478))
* **core:** Fix expression with paired item with multi-input node
([#7424](https://github.com/n8n-io/n8n/issues/7424))
([ec14141](ec141416e2))
* **core:** Fix ignoring crashed executions without event msgs
([#7368](https://github.com/n8n-io/n8n/issues/7368))
([2f4d91b](2f4d91b2cd))
* **core:** Pg-promise de-initialization fix
([#7417](https://github.com/n8n-io/n8n/issues/7417))
([7703904](77039044eb))
* **core:** Prevent false stalled jobs in queue mode from displaying as
errored ([#7435](https://github.com/n8n-io/n8n/issues/7435))
([e01b9e5](e01b9e5ae1))
* **core:** Prevent undefined issues when restoring binary data
([#7419](https://github.com/n8n-io/n8n/issues/7419))
([46977a2](46977a2aff))
* **editor:** Fix remote options fetching on every keystroke
([#7320](https://github.com/n8n-io/n8n/issues/7320))
([367255a](367255ab2c))
* **editor:** Open only one tab with plans page
([#7377](https://github.com/n8n-io/n8n/issues/7377))
([c599006](c599006b91))
* **Google Sheets Node:** Update by row_number, restored 'Handling Extra
Data Option', updated Cell Format default
([#7357](https://github.com/n8n-io/n8n/issues/7357))
([d8531a5](d8531a53b9))
* **Ldap Node:** Fix issue with connections not closing correctly
([#7432](https://github.com/n8n-io/n8n/issues/7432))
([c3f0be8](c3f0be809f))
* **Set Node:** Null should not throw an error
([#7416](https://github.com/n8n-io/n8n/issues/7416))
([e9b6ab0](e9b6ab04cd))
* **TheHive 5 Node:** Observable encoding in alert > create fix
([#7450](https://github.com/n8n-io/n8n/issues/7450))
([a2d2e3d](a2d2e3dda7))


### Features

* **core:** Make executions pruning interval configurable
([#7439](https://github.com/n8n-io/n8n/issues/7439))
([40707fa](40707fa692))
* **Google Calendar Trigger Node:** Add support for cancelled events
([#7436](https://github.com/n8n-io/n8n/issues/7436))
([9d241a0](9d241a0d6d))
* **HubSpot Trigger Node:** Add support for ticket related events
([#7156](https://github.com/n8n-io/n8n/issues/7156))
([57c6093](57c609384a))
* **n8n Form Trigger Node:** New node
([#7130](https://github.com/n8n-io/n8n/issues/7130))
([3ddc176](3ddc176dfa))
* **Spreadsheet File Node:** Improve CSV parsing
([#7448](https://github.com/n8n-io/n8n/issues/7448))
([79f23fb](79f23fb939))

Co-authored-by: netroy <netroy@users.noreply.github.com>
 2023-10-18 17:43:29 +02:00
Iván Ovejero 40707fa692
feat(core): Make executions pruning interval configurable (#7439) 2023-10-18 17:01:57 +02:00
कारतोफ्फेलस्क्रिप्ट™ 79f23fb939
feat(Spreadsheet File Node): Improve CSV parsing (#7448) 
This adds support for
1. custom delimiters
2. reading offsets to avoid having to read a large CSV all at once
3. excluding byte-order-mark

NODE-861
#7443
 2023-10-18 16:57:37 +02:00
Michael Kret d8531a53b9
fix(Google Sheets Node): Tweaks (#7357) 
Github issue / Community forum post (link here to close automatically):
 2023-10-17 18:41:30 +03:00
Michael Kret a2d2e3dda7
fix(TheHive 5 Node): Observable encoding in alert > create fix (#7450) 
Github issue / Community forum post (link here to close automatically):
 2023-10-17 16:53:44 +03:00
Michael Kret 3ddc176dfa
feat(n8n Form Trigger Node): New node (#7130) 
Github issue / Community forum post (link here to close automatically):

based on https://github.com/joffcom/n8n-nodes-form-trigger

---------

Co-authored-by: Giulio Andreini <g.andreini@gmail.com>
 2023-10-17 07:09:30 +03:00
Deborah 869b8f14ca
fix(Convert to/from binary data Node): Change Mime to MIME (no-changelog) (#7446) 
Github issue / Community forum post (link here to close automatically):
 2023-10-16 16:54:16 +01:00
Jon 9d241a0d6d
feat(Google Calendar Trigger Node): Add support for cancelled events (#7436) 
Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/google-calendar-trigger-deleted-events/10612

This PR adds support for triggering workflows when Google Calendar
events are cancelled.
 2023-10-16 14:09:23 +01:00
Damian Karzon 57c609384a
feat(HubSpot Trigger Node): Add support for ticket related events (#7156) 2023-10-13 16:52:22 +01:00
Michael Auerswald e01b9e5ae1
fix(core): Prevent false stalled jobs in queue mode from displaying as errored (#7435) 
This is related to an issue with how Bull handles stalled jobs, see
https://github.com/OptimalBits/bull/issues/1415 for reference.

CPU intensive workflows can in certain cases take a long while to finish
up, thereby blocking the thread and causing Bull queue to think the job
has stalled, even though it finished successfully. In these cases the
error handling could then overwrite the successful execution data with
the error message.
 2023-10-13 16:07:08 +02:00
Inga c599006b91
fix(editor): Open only one tab with plans page (#7377) 
## Issue

In community edition, clicking on "View plans" button on "Settings" ->
"Usage and plan" page (e.g. http://127.0.0.1:5678/settings/usage) opens
two new tabs with n8n pricing (one of them with UTM tracking, another
without).
This was introduced in #6317 , when click handler of "View plans" link
container [started
calling](https://github.com/n8n-io/n8n/pull/6317/files#diff-0bf26afac8a06e03b3d39d0668f22408859355b585a9ab420800c125e33f0691R109)
`uiStore.goToUpgrade(...)` which opens n8n pricing in a new tab, while
browser opens another tab for the link URL.

The simplest fix, implemented in this PR, is to prevent default event
handling (so that, after `onViewPlans` is called, browser will not
attempt to process the click additionally as clicking on the link),
similarly to how it is prevented on some other pages. It only solves the
immediate problem of browser opening two new tabs on clicking "View
plans".

Note that **I didn't implement any tests for the changed behavior**,
because it was not covered by tests before, and I couldn't quite figure
out how to cover it now within the existing test approach (considering
that testing the fact that only one new tab is open will likely require
to write entirely new tests relying on puppeteer; as far as I can see,
no existing `editor-ui` tests are doing anything like that). I'll gladly
implement tests for the new behavior if you tell me how you would like
them to look.
The existing tests for `editor-ui` still pass; I didn't run tests for
other subpackages (see "additional contribution notes" below).

## Additional notes on the issue.

I'm not sure that the change in this PR is the correct long-term
solution for the issue, because the URLs for these two methods (custom
click handler for link container and default link handling) are slightly
different:
* Custom click handler calls `useTelemetryStore().track('User clicked
upgrade CTA', ...)`; then calls `sendUsageTelemetry('view_plans')` (it
feels weird that two calls to telemetry are made); then opens new tab
for `https://n8n.io/pricing?utm_campaign=open&source=usage_page` (note
that prior to #7316 the second call to telemetry was done after the new
tab is opened, not before);
* Link itself refers to another page, with slightly different tracking
parameters:
`https://subscription.n8n.io/?instanceid=[REDACTED]&version=1.10.0&callback=http%3A%2F%2F127.0.0.1%3A5678%2Fsettings%2Fusage&source=usage_page`;
but this page redirects to `https://n8n.io/pricing/`.
It is not clear which one of the two is the right way of doing things.
Although `goToUpgrade` is called in 20 places throughout `editor-ui`,
while `viewPlansUrl`, as far as I can see, is used for this button only.

Additionally, since Settings pages don't work without JS anyway, I can
only think of two separate scenarios where any tab would be opened:
* Left-clicking the link (or Ctrl-clicking, or pressing Space or Enter
when the link is focused, or tapping): previously, both custom click
handler was executed and link's `href` was opened; in this PR, only
custom click handler is executed (similarly to how it is done in the
other places where `goToUpgrade` is called);
* Right-clicking (or long tapping, or opening context menu in any other
way) and selecting "open link in new tab" (or similar): opens a new tab
for URL from the `href` attribute (and does not send any telemetry at
all).

I'd say that the better permanent solution would probably be to get rid
of one of these methods entirely, and only rely on another in all cases
(for me, as an outside contributor, the preferred way would be for
custom click handler to only send telemetry, while letting my browser
handle the actual navigation). However, that would be a large change,
much more than one line in this PR.
Additionally, other similar places where `goToUpgrade` is currently
called (directly or indirectly) would also need to be adapted for this
change.

## Additional contribution notes

As a first-time contributor, I've encountered several things I didn't
expect; I'm not sure if they should be expected or are issues:

1. Tests for the entire monorepo consume a lot of RAM; 20GB free RAM was
not enough, so I couldn't run tests for the entire monorepo and had to
only run them for `packages/editor-ui`;
2. Linting is very slow; `pnpm lint` in `packages/editor-ui` takes ten
minutes to complete;
3. It seems that types are not checked. Code OSS highlights numerous
errors in code files: for example, `'debug'` is incompatible with
`CloudUpdateLinkSourceType` expected by `goToUpgrade` here:
3e7a4d3b2c/packages/editor-ui/src/composables/useExecutionDebugging.ts (L128)
However, I'm not getting any errors during build. There is a `typecheck`
script defined in `package.json`, but `pnpm typecheck` fails with:
    ```
    n8n-toy-demo:~/projects/n8n/packages/editor-ui$ pnpm typecheck

> n8n-editor-ui@1.10.0 typecheck
/home/inga/projects/n8n/packages/editor-ui
    > vue-tsc --emitDeclarationOnly

error TS5069: Option 'emitDeclarationOnly' cannot be specified without
specifying
    option 'declaration' or option 'composite'.


    Found 1 error.

     ELIFECYCLE  Command failed with exit code 1.
    n8n-toy-demo:~/projects/n8n/packages/editor-ui$ 
    ```
Replacing `--emitDeclarationsOnly` with `--noEmit` in `package.json`
unblocks typechecking and results in seemingly, at first glance, correct
"Found 1924 errors in 306 files" (at least several of the reported
errors that I've checked seem to be correct).
But maybe I'm missing something and there are not in fact two thousands
type errors in `editor-ui`?
 2023-10-13 14:14:26 +02:00
Iván Ovejero c6ee1e30c0
refactor(core): Add binary data S3 to telemetry (#7412) 
https://n8nio.slack.com/archives/C04B1GZ4T0U/p1697033523039729
 2023-10-13 13:16:43 +02:00
pemontto c3f0be809f
fix(Ldap Node): Fix issue with connections not closing correctly (#7432) 2023-10-13 12:15:54 +01:00
Michael Auerswald 45f2ef373e
fix(core): Add check that queue is defined and remove cyclic dependency (#7404) 
In a rare edge case an undefined queue could be returned - this should
not happen and now an error is thrown.
Also using the opportunity to remove a cyclic dependency from the Queue.
 2023-10-13 11:53:59 +02:00
Iván Ovejero 609f0837cf
test(core): Add test for suppressing error on non-existing filepath (no-changelog) (#7421) 
Follow-up to #7411
 2023-10-13 11:52:17 +02:00
Iván Ovejero ec141416e2
fix(core): Fix expression with paired item with multi-input node (#7424) 
https://linear.app/n8n/issue/PAY-630

Minimal repro:
https://internal.users.n8n.cloud/workflow/9HSkIy4T1LqXbm1H
 2023-10-12 17:32:14 +02:00
Michael Kret e9b6ab04cd
fix(Set Node): Null should not throw an error (#7416) 
Github issue / Community forum post (link here to close automatically):
 2023-10-12 18:07:12 +03:00
Omar Ajoue 46977a2aff
fix: Prevent undefined issues when restoring binary data (#7419) 
Github issue / Community forum post (link here to close automatically):

---------

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
 2023-10-12 16:41:51 +02:00
Milorad FIlipović 367255ab2c
fix(editor): Fix remote options fetching on every keystroke (#7320) 
Github issue / Community forum post (link here to close automatically):

---------

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
 2023-10-12 14:18:35 +02:00
Michael Kret 77039044eb
fix(core): Pg-promise de-initialization fix (#7417) 
Github issue / Community forum post (link here to close automatically):

https://community.n8n.io/t/postgres-node-called-end-on-pool-more-than-once/30585/1
 2023-10-12 12:10:14 +03:00
कारतोफ्फेलस्क्रिप्ट™ 2b6a15e478
fix(core): Do not throw when deleting workflows with executions without binary-data (#7411) 
Fixes https://n8nio.sentry.io/issues/4508969090
 2023-10-11 18:00:06 +02:00
Iván Ovejero 54e900955a
refactor(core): Move frontend settings to service (no-changelog) (#7396) 
Quick follow-up to https://github.com/n8n-io/n8n/pull/7283
 2023-10-11 17:12:19 +02:00
कारतोफ्फेलस्क्रिप्ट™ 1e0753516c Merge tag 'n8n@1.11.0' 2023-10-11 15:55:52 +02:00
Michael Auerswald 2f4d91b2cd
fix(core): Fix ignoring crashed executions without event msgs (#7368) 
when the event logs do not contain messages for running executions, the
recovery/crash detection on startup would skip these. this PR fixes
that.
 2023-10-11 14:22:43 +02:00
github-actions[bot] e6ba841c5f
🚀 Release 1.11.0 (#7402) 
# [1.11.0](https://github.com/n8n-io/n8n/compare/n8n@1.10.0...n8n@1.11.0)
(2023-10-11)


### Bug Fixes

* **core:** Add an option to enable postgres ssl with default certs
([#6889](https://github.com/n8n-io/n8n/issues/6889))
([789e1e7](789e1e7ed4))
* **core:** Fix error on missing paired item data
([#7399](https://github.com/n8n-io/n8n/issues/7399))
([47e8953](47e8953ec9))
* **core:** Missing pairing info
([#7326](https://github.com/n8n-io/n8n/issues/7326))
([e2c3c7a](e2c3c7aceb))
* **core:** Prevent object deletion request on no prefix match
([#7366](https://github.com/n8n-io/n8n/issues/7366))
([63e11e4](63e11e4be9))
* **editor:** Fix completions for `.json` on quoted node name in Code
node ([#7382](https://github.com/n8n-io/n8n/issues/7382))
([86e7ec7](86e7ec796a))
* **editor:** Implement canvas zoom UX improvements
([#7376](https://github.com/n8n-io/n8n/issues/7376))
([7e06b31](7e06b31a5f))
* **editor:** Make workflow history button available only for dev builds
([#7392](https://github.com/n8n-io/n8n/issues/7392))
([7ed466d](7ed466db7f))
* **editor:** Remove excess margin below run data editor
([#7372](https://github.com/n8n-io/n8n/issues/7372))
([3fa2764](3fa27647d8))
* **editor:** Sanitize HTML binary-data before rendering in the UI
([#7400](https://github.com/n8n-io/n8n/issues/7400))
([2b075bf](2b075bfc2d))
* **editor:** Use display option's @Version specifier
([#7351](https://github.com/n8n-io/n8n/issues/7351))
([afbf0c3](afbf0c3d5e))
* **Google BigQuery Node:** Location default to jobReference
([#7354](https://github.com/n8n-io/n8n/issues/7354))
([97bb703](97bb703d0a))
* **Google Drive Trigger Node:** Add Shared Drives support
([#7369](https://github.com/n8n-io/n8n/issues/7369))
([3e7a4d3](3e7a4d3b2c))
* **Google Sheets Node:** Fix "Maximum call stack size exceeded" error
on too many rows ([#7384](https://github.com/n8n-io/n8n/issues/7384))
([732b15a](732b15a1fa))
* **HTML Node:** Update property fields to not use expressions on drag
([#7379](https://github.com/n8n-io/n8n/issues/7379))
([77643e5](77643e5ccb))
* **Notion Node:** Handle empty values correctly for Notion selects +
multi selects ([#7383](https://github.com/n8n-io/n8n/issues/7383))
([fbcd1d4](fbcd1d40ed))
* **Set Node:** Increase search priority
([#7358](https://github.com/n8n-io/n8n/issues/7358))
([e5ad1e7](e5ad1e7e4d))
* **Webhook Node:** Backward compatible form-data parsing for non-array
files ([#7385](https://github.com/n8n-io/n8n/issues/7385))
([6479eb1](6479eb180f))


### Features

* **core:** Add Job Summary to Worker response
([#7360](https://github.com/n8n-io/n8n/issues/7360))
([b8608ce](b8608cee6d))
* **core:** Integrate object store as binary data manager
([#7253](https://github.com/n8n-io/n8n/issues/7253))
([1a661e6](1a661e6d00))
* **core:** Switch binary filesystem mode to nested path structure
([#7307](https://github.com/n8n-io/n8n/issues/7307))
([0847623](0847623f85))
* **editor:** Make PDF and Audio binary-data viewable in the UI
([#7367](https://github.com/n8n-io/n8n/issues/7367))
([8187be1](8187be1b7d))
* **editor:** Support autologin for upgrade path
([#7316](https://github.com/n8n-io/n8n/issues/7316))
([1dfa052](1dfa052301))
* **Execute Workflow Node:** Run once for each item mode
([#7289](https://github.com/n8n-io/n8n/issues/7289))
([c8c14ca](c8c14ca0af))
* **Item Lists Node:** Split merge binary data
([#7297](https://github.com/n8n-io/n8n/issues/7297))
([965db8f](965db8f7f2))
* **Loop Over Items (Split in Batches) Node:** Automatically add a loop
+ rename ([#7228](https://github.com/n8n-io/n8n/issues/7228))
([7b773cc](7b773cc5cc))
* **Notion Node:** Fetch child blocks recursively
([#7304](https://github.com/n8n-io/n8n/issues/7304))
([193181a](193181a9c6))

Co-authored-by: netroy <netroy@users.noreply.github.com>
 2023-10-11 13:38:34 +02:00
कारतोफ्फेलस्क्रिप्ट™ 2b075bfc2d
fix(editor): Sanitize HTML binary-data before rendering in the UI (#7400) 2023-10-11 12:09:19 +02:00
Iván Ovejero 47e8953ec9
fix(core): Fix error on missing paired item data (#7399) 
<img width="1015" alt="Capture 2023-10-11 at 10 07 02@2x"
src="https://github.com/n8n-io/n8n/assets/44588767/0305f62d-0a7b-4ce7-b78f-a8d8454e2532">
 2023-10-11 11:34:55 +02:00
Csaba Tuncsik 53c3379282
feat(editor): Workflow history [WIP]- Create workflow history item preview component (no-changelog) (#7378) 
Co-authored-by: Giulio Andreini <g.andreini@gmail.com>
 2023-10-11 10:13:04 +02:00
Michael Kret 965db8f7f2
feat(Item Lists Node): Split merge binary data (#7297) 
Github issue / Community forum post (link here to close automatically):

---------

Co-authored-by: Marcus <marcus@n8n.io>
 2023-10-11 10:59:51 +03:00
Michael Kret e2c3c7aceb
fix(core): Missing pairing info (#7326) 
Github issue / Community forum post (link here to close automatically):
 2023-10-10 18:36:20 +03:00
कारतोफ्फेलस्क्रिप्ट™ 6479eb180f
fix(Webhook Node): Backward compatible form-data parsing for non-array files (#7385) 
Fixes
https://community.n8n.io/t/possible-bug-0-added-to-end-of-files-sent-via-webhook/31169
 2023-10-10 15:19:05 +02:00
Omar Ajoue 7ed466db7f
fix(editor): Make workflow history button available only for dev builds (#7392) 
Github issue / Community forum post (link here to close automatically):

---------

Co-authored-by: Csaba Tuncsik <csaba.tuncsik@gmail.com>
 2023-10-10 12:15:18 +02:00
Elias Meire 7e06b31a5f
fix(editor): Implement canvas zoom UX improvements (#7376) 
- Fix pinch-to-zoom
- Support command + scroll to zoom
- Improve accuracy of zooming (scroll more = zoom more)
- Zoom limits
- Zoom relative to mouse position
 2023-10-10 11:07:58 +02:00
Iván Ovejero 0847623f85
feat(core): Switch binary filesystem mode to nested path structure (#7307) 
Depends on #7253 | Story:
[PAY-863](https://linear.app/n8n/issue/PAY-863/switch-binary-filesystem-mode-to-nested-path-structure)

This PR introduces `filesystem-v2` to store binary data in the
filesystem in the same format as `s3`.
 2023-10-10 10:06:06 +02:00
Iván Ovejero 86e7ec796a
fix(editor): Fix completions for .json on quoted node name in Code node (#7382) 
To reproduce, request completion with `$input.first().json.` from a node
with a quote in the name, e.g. `When clicking "Execute Workflow"`.

Context:
https://linear.app/n8n/issue/PAY-635/autocomplete-only-supports-3-levels-of-children#comment-234f738b
 2023-10-10 10:05:41 +02:00
Elias Meire fbcd1d40ed
fix(Notion Node): Handle empty values correctly for Notion selects + multi selects (#7383) 
Github issue / Community forum post (link here to close automatically):
 2023-10-09 18:04:41 +02:00
कारतोफ्फेलस्क्रिप्ट™ 8187be1b7d
feat(editor): Make PDF and Audio binary-data viewable in the UI (#7367) 
fixes #7361
 2023-10-09 17:43:57 +02:00
कारतोफ्फेलस्क्रिप्ट™ 732b15a1fa
fix(Google Sheets Node): Fix "Maximum call stack size exceeded" error on too many rows (#7384) 
Fixes:

1. https://community.n8n.io/t/google-sheets-error-maximum-call-stack-size-exceeded/31006
2. https://community.n8n.io/t/error-maximum-call-stack-size-exceeded-in-google-sheet-read-rows/20307
 2023-10-09 16:58:16 +02:00
कारतोफ्फेलस्क्रिप्ट™ c5ee06cc61
refactor(core): Refactor nodes loading (no-changelog) (#7283) 
fixes PAY-605
 2023-10-09 16:09:23 +02:00
कारतोफ्फेलस्क्रिप्ट™ 789e1e7ed4
fix(core): Add an option to enable postgres ssl with default certs (#6889) 
CP-809
 2023-10-09 13:55:03 +02:00
Csaba Tuncsik b3247e5935
feat(editor): Workflow history [WIP]- Add restore and clone into new workflow actions (no-changelog) (#7359) 2023-10-09 13:50:08 +02:00
Jon 77643e5ccb
fix(HTML Node): Update property fields to not use expressions on drag (#7379) 
When dragging an expression into a "binary property" or "json property"
field we should use the key name rather than the expression.
 2023-10-09 10:23:46 +01:00
Ricardo Espinoza a43f720658
fix: Add role check for upgrade path (#7374) 
Github issue / Community forum post (link here to close automatically):

---------

Co-authored-by: Mutasem <mutdmour@gmail.com>
 2023-10-09 11:18:08 +02:00
Iván Ovejero 3fa27647d8
fix(editor): Remove excess margin below run data editor (#7372) 
https://n8nio.slack.com/archives/C03594NKD7W/p1696605203051309

<img width="581" alt="Capture 2023-10-06 at 17 48 51@2x"
src="https://github.com/n8n-io/n8n/assets/44588767/c00ecd2e-1f6b-4041-9854-1b6012513a5d">
 2023-10-09 09:20:37 +02:00
Elias Meire 3e7a4d3b2c
fix(Google Drive Trigger Node): Add Shared Drives support (#7369) 
Github issue / Community forum post (link here to close automatically):

https://community.n8n.io/t/google-drive-node-cant-access-google-shared-drives/8760
 2023-10-06 19:59:33 +02:00
Michael Auerswald b8608cee6d
feat(core): Add Job Summary to Worker response (#7360) 2023-10-06 17:52:27 +02:00
Michael Kret c8c14ca0af
feat(Execute Workflow Node): Run once for each item mode (#7289) 
Github issue / Community forum post (link here to close automatically):
 2023-10-06 18:04:33 +03:00
कारतोफ्फेलस्क्रिप्ट™ 597669aa62
refactor(core): Move copyInputItems to node helpers (no-changelog) (#7299) 2023-10-06 16:25:58 +02:00
Iván Ovejero 34bda535e6
refactor(core): Create controller for binary data (no-changelog) (#7363) 
This PR adds a controller for binary data + integration tests.
 2023-10-06 16:21:13 +02:00
Iván Ovejero 63e11e4be9
fix(core): Prevent object deletion request on no prefix match (#7366) 2023-10-06 15:46:39 +02:00
Elias Meire 7b773cc5cc
feat(Loop Over Items (Split in Batches) Node): Automatically add a loop + rename (#7228) 
Github issue / Community forum post (link here to close automatically):

---------

Co-authored-by: Michael Kret <michael.k@radency.com>
 2023-10-06 15:31:18 +02:00
Michael Auerswald afa683a06f
refactor(core): Have one orchestration service per instance type (#7303) 
webhook instances will not listen to either worker or event log messages
on the Redis pub/sub channel
 2023-10-06 13:58:11 +02:00
Michael Kret 193181a9c6
feat(Notion Node): Fetch child blocks recursively (#7304) 
Github issue / Community forum post (link here to close automatically):
 2023-10-06 14:55:44 +03:00
Michael Kret 97bb703d0a
fix(Google BigQuery Node): Location default to jobReference (#7354) 
Github issue / Community forum post (link here to close automatically):
 2023-10-06 14:16:55 +03:00
Ricardo Espinoza 1dfa052301
feat(editor): Support autologin for upgrade path (#7316) 
Github issue / Community forum post (link here to close automatically):
 2023-10-06 13:16:27 +02:00
Cornelius Suermann f4d8c9eed5
feat: Improve error msg when attempting to redeem the same activation code multiple times (no-changelog) (#7355) 2023-10-05 17:08:30 +02:00
Csaba Tuncsik cd12a5990a
feat(editor): Workflow history [WIP]- Improve switching between workflow history and editor (no-changelog) (#7353) 2023-10-05 15:49:59 +02:00
Iván Ovejero 1a661e6d00
feat(core): Integrate object store as binary data manager (#7253) 
Depends on: #7225 | Story:
[PAY-848](https://linear.app/n8n/issue/PAY-848)

This PR integrates the object store service as a new binary data manager
for Enterprise.
 2023-10-05 15:25:17 +02:00
Michael Kret e5ad1e7e4d
fix(Set Node): Increase search priority (#7358) 
Github issue / Community forum post (link here to close automatically):
 2023-10-05 16:19:19 +03:00
Tomi Turtiainen afbf0c3d5e
fix(editor): Use display option's @Version specifier (#7351) 
Nodes can have properties that have a displayOption which specifies a
version
for which node versions that property applies to. We should take this
into
account when forming the action types for a Node in the NodeList.

For example Notion node has 2 version which have different Page
operations.
 2023-10-05 15:57:47 +03:00
github-actions[bot] aa1bf95136
🚀 Release 1.10.0 (#7350) 
# [1.10.0](https://github.com/n8n-io/n8n/compare/n8n@1.9.0...n8n@1.10.0)
(2023-10-05)


### Bug Fixes

* **Convert to/from binary data Node:** Rename 'Move Binary Data' to
'Convert to/from binary data'
([#7318](https://github.com/n8n-io/n8n/issues/7318))
([5e6c1d4](5e6c1d4f4b))
* **core:** Account for itemless case on restoring binary data ID
([#7305](https://github.com/n8n-io/n8n/issues/7305))
([1691223](1691223789))
* **core:** Fix pruning of non-finished executions
([#7333](https://github.com/n8n-io/n8n/issues/7333))
([1b4848a](1b4848afcb))
* **editor:** Disable email confirmation banner for trialing users
([#7340](https://github.com/n8n-io/n8n/issues/7340))
([6d3d178](6d3d1789db))
* **editor:** Display value of selected matching column in RMC
([#7298](https://github.com/n8n-io/n8n/issues/7298))
([3aac22b](3aac22b4c1))
* **editor:** Fix canvas endpoint snapping when dragging connection
([#7346](https://github.com/n8n-io/n8n/issues/7346))
([b59b908](b59b9086d7))
* **editor:** Fix disappearing NDV header in code nodes
([#7290](https://github.com/n8n-io/n8n/issues/7290))
([7ebf8f3](7ebf8f327a))
* **editor:** Fix RLC not loading when an expression can't resolve
([#7295](https://github.com/n8n-io/n8n/issues/7295))
([ddc26c2](ddc26c21bd))
* **editor:** Separate cloud endpoint calls
([#7312](https://github.com/n8n-io/n8n/issues/7312))
([04dfcd7](04dfcd73be))
* **Jira Software Node:** Get all users in dropdown/RLC
([#7322](https://github.com/n8n-io/n8n/issues/7322))
([3704760](3704760724)),
closes [#2670](https://github.com/n8n-io/n8n/issues/2670)
* **Notion Node:** Rename Notion API Key to Internal Integration Token
([#7176](https://github.com/n8n-io/n8n/issues/7176))
([ec2aa38](ec2aa3819c))
* **Postgres Node:** Node requires comma-separated string even when
using a single parameter through an expression
([#7300](https://github.com/n8n-io/n8n/issues/7300))
([763d451](763d4514fa))
* **Set Node:** Do not stringify null and undefined
([#7313](https://github.com/n8n-io/n8n/issues/7313))
([f0a6687](f0a66873b9))
* **Typeform Trigger Node:** Change output format for TypeForm trigger
to object instead of array
([#7315](https://github.com/n8n-io/n8n/issues/7315))
([b3fc00e](b3fc00e045))


### Features

* **core:** Add "Sent by n8n" attribution
([#7183](https://github.com/n8n-io/n8n/issues/7183))
([8f9fe62](8f9fe6269b))
* **core:** Add support for building LLM applications
([#7235](https://github.com/n8n-io/n8n/issues/7235))
([00a4b8b](00a4b8b0c6)),
closes [#7246](https://github.com/n8n-io/n8n/issues/7246)
[#7137](https://github.com/n8n-io/n8n/issues/7137)
* Workflow History pruning and prune time settings
([#7343](https://github.com/n8n-io/n8n/issues/7343))
([0adc533](0adc533719))

Co-authored-by: krynble <krynble@users.noreply.github.com>
 2023-10-05 14:12:37 +02:00
Omar Ajoue 5cfd87692f
refactor: Add log messages to debug worker init issues (#7238) 
Github issue / Community forum post (link here to close automatically):
 2023-10-05 13:37:25 +02:00
कारतोफ्फेलस्क्रिप्ट™ 169175080a
ci: Fix WorkflowHistoryManager tests (no-changelog) (#7356) 
[DB Tests](https://github.com/n8n-io/n8n/actions/runs/6418058186)
 2023-10-05 13:14:57 +02:00
Milorad FIlipović 7ebf8f327a
fix(editor): Fix disappearing NDV header in code nodes (#7290) 
Github issue / Community forum post (link here to close automatically):

---------

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
 2023-10-05 12:31:52 +02:00
Csaba Tuncsik 4bc9164032
feat(editor): Workflow history [WIP]- Add workflow history opening button to main header component (no-changelog) (#7310) 
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
 2023-10-04 16:45:18 +02:00
OlegIvaniv b59b9086d7
fix(editor): Fix canvas endpoint snapping when dragging connection (#7346) 
Github issue / Community forum post (link here to close automatically):

Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
 2023-10-04 16:10:42 +02:00
Elias Meire ddc26c21bd
fix(editor): Fix RLC not loading when an expression can't resolve (#7295) 
Also fixes label (list -> From list)

Github issue / Community forum post (link here to close automatically):
 2023-10-04 16:01:44 +02:00
Tomi Turtiainen 1b4848afcb
fix(core): Fix pruning of non-finished executions (#7333) 
This fixes a bug in the pruning (soft-delete). The pruning was a bit too
aggressive, as it also pruned executions that weren't in an end state
yet. This only becomes an issue if there are long-running executions
(e.g. workflow with Wait node) or the prune parameters are set to keep
only a tiny number of executions.
 2023-10-04 16:32:05 +03:00
Giulio Andreini 942d0b91fc
docs(editor): New Nodes Panel title for triggers (#7314) 
Github issue / Community forum post (link here to close automatically):
 2023-10-04 15:27:40 +02:00
Val 0adc533719
feat: Workflow History pruning and prune time settings (#7343) 
Github issue / Community forum post (link here to close automatically):
 2023-10-04 13:57:21 +01:00
Milorad FIlipović 6d3d1789db
fix(editor): Disable email confirmation banner for trialing users (#7340) 
Github issue / Community forum post (link here to close automatically):
 2023-10-04 13:36:51 +02:00
Elias Meire 5e6c1d4f4b
fix(Convert to/from binary data Node): Rename 'Move Binary Data' to 'Convert to/from binary data' (#7318) 
Github issue / Community forum post (link here to close automatically):
 2023-10-04 13:23:33 +02:00
Elias Meire b3fc00e045
fix(Typeform Trigger Node): Change output format for TypeForm trigger to object instead of array (#7315) 
Github issue / Community forum post (link here to close automatically):

---------

Co-authored-by: Michael Kret <michael.k@radency.com>
 2023-10-04 12:39:31 +02:00
Elias Meire 3aac22b4c1
fix(editor): Display value of selected matching column in RMC (#7298) 
Github issue / Community forum post (link here to close automatically):
 2023-10-04 12:36:24 +02:00
कारतोफ्फेलस्क्रिप्ट™ 101255d186
ci: Make builds release-channel aware. Add support for scheduled beta builds (#7323) 
ADO-1121

---------

Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
 2023-10-03 20:49:04 +02:00
Michael Kret 8f9fe6269b
feat(core): Add "Sent by n8n" attribution (#7183) 
Github issue / Community forum post (link here to close automatically):

---------

Co-authored-by: Giulio Andreini <g.andreini@gmail.com>
 2023-10-03 11:18:59 +03:00
Michael Kret f0a66873b9
fix(Set Node): Do not stringify null and undefined (#7313) 
Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/null-and-undefined-in-string-fields/31060/1
 2023-10-03 11:18:33 +03:00
Elias Meire 3704760724
fix(Jira Software Node): Get all users in dropdown/RLC (#7322) 
Github issue / Community forum post (link here to close automatically):

fixes #2670

---------

Co-authored-by: Michael Kret <michael.k@radency.com>
 2023-10-03 10:04:58 +02:00
greyliath e7a90c73b3
fix(Acuity Scheduling Trigger Node): Update logo for Acuity Scheduling (no-changelog) (#7321) 2023-10-02 17:17:47 +01:00
कारतोफ्फेलस्क्रिप्ट™ 00a4b8b0c6
feat(core): Add support for building LLM applications (#7235) 
This extracts all core and editor changes from #7246 and #7137, so that
we can get these changes merged first.

ADO-1120

[DB Tests](https://github.com/n8n-io/n8n/actions/runs/6379749011)
[E2E Tests](https://github.com/n8n-io/n8n/actions/runs/6379751480)
[Workflow Tests](https://github.com/n8n-io/n8n/actions/runs/6379752828)

---------

Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
Co-authored-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Alex Grozav <alex@grozav.com>
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
 2023-10-02 17:33:43 +02:00
Milorad FIlipović 04dfcd73be
fix(editor): Separate cloud endpoint calls (#7312) 
This PR untangles calls to cloud endpoints so failure in one of them
doesn't stop others to go through.
 2023-10-02 14:25:03 +02:00
Iván Ovejero 1691223789
fix(core): Account for itemless case on restoring binary data ID (#7305) 
https://linear.app/n8n/issue/PAY-862
 2023-10-02 09:13:55 +02:00
Csaba Tuncsik d1b6c7fd79
feat(editor): Workflow history [WIP]- create workflow history list component (no-changelog) (#7186) 
Co-authored-by: Omar Ajoue <krynble@gmail.com>
 2023-09-29 17:48:36 +02:00
Omar Ajoue ec0379378e
feat(core): Add plan name to telemetry (no-changelog) (#7296) 
Github issue / Community forum post (link here to close automatically):
 2023-09-29 15:41:32 +02:00
कारतोफ्फेलस्क्रिप्ट™ 6a1557bc50 Merge tag 'n8n@1.9.0' 2023-09-29 14:28:06 +02:00
कारतोफ्फेलस्क्रिप्ट™ f8406c04b1
ci: Fix typescript incremental builds (no-changelog) (#7275) 
`tsBuildInfoFile` is supposed to be relative to `tsconfig` like `outDir`
is.
Because of this, we are currently saving the TS incremental build cache
for all packages in the same file. This is likely causing issues where
the built backend code sometimes does not accurately map to the current
source code.

This PR changes the incremental build setup to keep the cache in
individual `dist` folders, like it used to be up until a 2 months ago,
before https://github.com/n8n-io/n8n/pull/6816.
 2023-09-29 13:26:06 +02:00
Michael Kret 763d4514fa
fix(Postgres Node): Node requires comma-separated string even when using a single parameter through an expression (#7300) 
Github issue / Community forum post (link here to close automatically):
 2023-09-29 13:27:31 +03:00
Elias Meire ec2aa3819c
fix(Notion Node): Rename Notion API Key to Internal Integration Token (#7176) 
Github issue / Community forum post (link here to close automatically):
 2023-09-29 09:21:29 +02:00
github-actions[bot] 167124ceb8
🚀 Release 1.9.0 (#7288) 
# [1.9.0](https://github.com/n8n-io/n8n/compare/n8n@1.8.0...n8n@1.9.0)
(2023-09-28)


### Bug Fixes

* **Airtable Node:** Attachments field type fix
([#7227](https://github.com/n8n-io/n8n/issues/7227))
([2af967c](2af967cf88))
* **core:** Change WorkflowHistory nodes/connections columns to be json
([#7282](https://github.com/n8n-io/n8n/issues/7282))
([a80abad](a80abad3af))
* **core:** Fix binary data manager check on pruning
([#7251](https://github.com/n8n-io/n8n/issues/7251))
([484035e](484035eb51))
* **core:** Fix missing execution ID in webhook-based workflow producing
binary data ([#7244](https://github.com/n8n-io/n8n/issues/7244))
([33991e9](33991e92d0))
* **core:** Handle filename* with quotes in Content-Disposition header
([#7229](https://github.com/n8n-io/n8n/issues/7229))
([67b985f](67b985fe89))
* **core:** Make DNS resolution order configurable
([#7272](https://github.com/n8n-io/n8n/issues/7272))
([5b3121c](5b3121c415))
* **core:** Make senderId required for all command messages
([#7252](https://github.com/n8n-io/n8n/issues/7252))
([4b01428](4b014286cf))
* **core:** Prevent executions from displaying Running status
incorrectly ([#7261](https://github.com/n8n-io/n8n/issues/7261))
([861cac5](861cac5257))
* **core:** Use consistent timezone-aware timestamps in postgres
([#6948](https://github.com/n8n-io/n8n/issues/6948))
([0132514](0132514f8b)),
closes [#2178](https://github.com/n8n-io/n8n/issues/2178)
[#2810](https://github.com/n8n-io/n8n/issues/2810)
[#3855](https://github.com/n8n-io/n8n/issues/3855)
[#2813](https://github.com/n8n-io/n8n/issues/2813)
* **editor:** Add debug feature docs link
([#7240](https://github.com/n8n-io/n8n/issues/7240))
([4614e1e](4614e1e1c9))
* **editor:** Fix SQL editor issue
([#7236](https://github.com/n8n-io/n8n/issues/7236))
([647fc6c](647fc6c555))
* **editor:** Ensure new Set node is on top of search list
([#7215](https://github.com/n8n-io/n8n/issues/7215))
([2491ccf](2491ccf4d9))
* **editor:** Forbid password reset when cloud account is limited in the
number of users [7188](https://github.com/n8n-io/n8n/issues/7188)
([303bc8e](303bc8e71e))
* **HTTP Request Node:** Add suggestion how to fix '429 - too many
requests' errors ([#7293](https://github.com/n8n-io/n8n/issues/7293))
([0bc33b1](0bc33b1cc2))
* **Item Lists Node:** Concatenate operation pairedItems fix
([#7286](https://github.com/n8n-io/n8n/issues/7286))
([cde23a1](cde23a1bb1))
* **Respond to Webhook Node:** JSON output from expression fix
([#7294](https://github.com/n8n-io/n8n/issues/7294))
([8bc369d](8bc369dd40))


### Features

* Add onboarding flow
([#7212](https://github.com/n8n-io/n8n/issues/7212))
([01e9340](01e9340621))
* **core:** Add secrets provider reload and refactor
([#7277](https://github.com/n8n-io/n8n/issues/7277))
([53a7502](53a7502d20))
* **core:** Add Tournament as the new default expression evaluator
([#6964](https://github.com/n8n-io/n8n/issues/6964))
([bf74f09](bf74f09d69))
* **core:** Initial workflow history API
([#7234](https://github.com/n8n-io/n8n/issues/7234))
([0083a9e](0083a9e45d))
* **core:** Introduce object store service
([#7225](https://github.com/n8n-io/n8n/issues/7225))
([fa84545](fa845453bb))
* **editor:** Add user cloud ID to telemetry
[#7232](https://github.com/n8n-io/n8n/issues/7232)
([60c152d](60c152dc72))
* **editor:** Rework banners framework and add email confirmation banner
([#7205](https://github.com/n8n-io/n8n/issues/7205))
([b0e98b5](b0e98b59a6))
* **MISP Node:** Update credential to support HTTP Request node
([#7268](https://github.com/n8n-io/n8n/issues/7268))
([e4c302c](e4c302c683))


### Performance Improvements

* **core:** Skip unneeded calls on every pruning cycle
([#7260](https://github.com/n8n-io/n8n/issues/7260))
([db01164](db01164ce1))

Co-authored-by: netroy <netroy@users.noreply.github.com>
 2023-09-28 17:22:28 +02:00
कारतोफ्फेलस्क्रिप्ट™ cf5a0ca456
ci: Refactor DB tests (no-changelog) (#7292) 
[DB tests](https://github.com/n8n-io/n8n/actions/runs/6340094467)
 2023-09-28 16:53:05 +02:00
Marcus 0bc33b1cc2
fix(HTTP Request Node): Add suggestion how to fix '429 - too many requests' errors (#7293) 
Github issue / Community forum post (link here to close automatically):
 2023-09-28 16:00:45 +02:00
Michael Kret 8bc369dd40
fix(Respond to Webhook Node): JSON output from expression fix (#7294) 
Github issue / Community forum post (link here to close automatically):
https://github.com/n8n-io/n8n/issues/7077
 2023-09-28 16:46:00 +03:00
Michael Auerswald 53a7502d20
feat(core): Add secrets provider reload and refactor (#7277) 
This PR adds a message for queue mode which triggers an external secrets
provider reload inside the workers if the configuration has changed on
the main instance.

It also refactors some of the message handler code to remove cyclic
dependencies, as well as remove unnecessary duplicate redis clients
inside services (thanks to no more cyclic deps)
 2023-09-28 12:57:35 +02:00
Val a80abad3af
fix(core): Change WorkflowHistory nodes/connections columns to be json (#7282) 
Github issue / Community forum post (link here to close automatically):
 2023-09-28 10:37:33 +02:00
Michael Kret cde23a1bb1
fix(Item Lists Node): Concatenate operation pairedItems fix (#7286) 
Github issue / Community forum post (link here to close automatically):

---------

Co-authored-by: Jonathan Bennetts <jonathan.bennetts@gmail.com>
 2023-09-28 10:20:54 +03:00
कारतोफ्फेलस्क्रिप्ट™ 0132514f8b
fix(core): Use consistent timezone-aware timestamps in postgres (#6948) 
Fixes:
* ENG-51 / N8N-2490
* PAY-397
* #2178
* #2810
* #3855

Supersedes #2813

[DB
Tests](https://github.com/n8n-io/n8n/actions/runs/6000780146/job/16273596338)
 2023-09-27 18:44:47 +02:00
कारतोफ्फेलस्क्रिप्ट™ ebce6fe1b0
refactor(core): Skip sending webhook activation errors to Sentry (no-changelog) (#7171) 2023-09-27 16:57:52 +02:00
Michael Auerswald 07d072c28f
fix(core): Bump License SDK Version (no-changelog) (#7279) 2023-09-27 16:29:09 +02:00
Val 0083a9e45d
feat(core): Initial workflow history API (#7234) 
Github issue / Community forum post (link here to close automatically):
 2023-09-27 15:22:39 +01:00
Milorad FIlipović d936ca0c9f
fix(editor): Update cloud endpoint paths (no-changelog) (#7274) 
Github issue / Community forum post (link here to close automatically):
 2023-09-27 13:44:03 +02:00
Omar Ajoue 861cac5257
fix(core): Prevent executions from displaying Running status incorrectly (#7261) 
Github issue / Community forum post (link here to close automatically):

https://linear.app/n8n/issue/HELP-338/large-number-of-long-running-executions-for-nadjalemlist#comment-18d1fc96

After investigating this issue with @ivov and @flipswitchingmonkey we've
identified this missing assignment of execution status.

This is the only inconsistency we've found that could cause executions
to continue displaying as `Running` even after finished.
 2023-09-27 12:38:53 +02:00
कारतोफ्फेलस्क्रिप्ट™ 5b3121c415
fix(core): Make DNS resolution order configurable (#7272) 2023-09-27 12:19:18 +02:00
Jon e4c302c683
feat(MISP Node): Update credential to support HTTP Request node (#7268) 2023-09-27 11:05:48 +01:00
Michael Auerswald 6d7fe95c58
fix(core): Do not set ttl globally in test (no-changelog) (#7271) 2023-09-27 12:03:15 +02:00
Jon cd6e22887f
docs: Update alias for iCalendar node (#7269) 2023-09-27 09:49:40 +01:00
Iván Ovejero fa845453bb
feat(core): Introduce object store service (#7225) 
Depends on https://github.com/n8n-io/n8n/pull/7220 | Story:
[PAY-840](https://linear.app/n8n/issue/PAY-840/introduce-object-store-service-and-manager-for-binary-data)

This PR introduces an object store service for Enterprise edition. Note
that the service is tested but currently unused - it will be integrated
soon as a binary data manager, and later for execution data.
`amazonaws.com` in the host is temporarily hardcoded until we integrate
the service and test against AWS, Cloudflare and Backblaze, in the next
PR.

This is ready for review - the PR it depends on is approved and waiting
for CI.

---------

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
 2023-09-27 09:42:35 +02:00
Jon 2c4e25c06b
fix(PagerDuty Node): Fix typos for incident descriptions (no-changelog) (#7267) 2023-09-27 08:07:58 +01:00
Iván Ovejero db01164ce1
perf(core): Skip unneeded calls on every pruning cycle (#7260) 2023-09-26 16:53:38 +02:00
Alex Grozav 0824800dff
fix(editor): Fix issue that double incoming connection often does not resolve expression (no-changelog) (#7257) 
Cherry-picked from AI Tool Creation branch

---------

Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
 2023-09-26 14:33:42 +01:00
Michael Auerswald 4b014286cf
fix(core): Make senderId required for all command messages (#7252) 
all commands sent between main instance and workers need to contain a
server id to prevent senders from reacting to their own messages,
causing loops

this PR makes sure all sent messages contain a sender id by default as
part of constructing a sending redis client.

---------

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
 2023-09-26 13:58:06 +02:00
Iván Ovejero 77d6e3fc07
refactor(core): Include workflow ID in binary data writes (no-changelog) (#7220) 
Depends on: https://github.com/n8n-io/n8n/pull/7195 | Story:
[PAY-837](https://linear.app/n8n/issue/PAY-837/implement-object-store-manager-for-binary-data)

This PR includes `workflowId` in binary data writes so that the S3
manager can support this filepath structure
`/workflows/{workflowId}/executions/{executionId}/binaryData/{binaryFilename}`
to easily delete binary data for workflows. Also all binary data service
and manager methods that take `workflowId` and `executionId` are made
consistent in arg order.

Note: `workflowId` is included in filesystem mode for compatibility with
the common interface, but `workflowId` will remain unused by filesystem
mode until we decide to restructure how this mode stores data.

---------

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
 2023-09-25 18:04:52 +02:00
Iván Ovejero 75541e91f2
refactor(core)!: Make getBinaryStream async (#7247) 
Story: [PAY-846](https://linear.app/n8n/issue/PAY-846) | Related:
https://github.com/n8n-io/n8n/pull/7225

For the S3 backend for external storage of binary data and execution
data, the `getAsStream` method in the binary data manager interface used
by FS and S3 will need to become async. This is a breaking change for
nodes-base.
 2023-09-25 16:59:45 +02:00
Iván Ovejero 484035eb51
fix(core): Fix binary data manager check on pruning (#7251) 
Ensure that we do not attempt to prune binary data in `default` binary
data mode.
 2023-09-25 16:50:11 +02:00
Ricardo Espinoza d47986aec3
fix: Bug when trailing user reset password on instance (no-changelog) (#7250) 
Github issue / Community forum post (link here to close automatically):
 2023-09-25 09:55:33 -04:00
Mutasem Aldmour 01e9340621
feat: Add onboarding flow (#7212) 
Github issue / Community forum post (link here to close automatically):
 2023-09-25 15:49:36 +02:00
Ricardo Espinoza 60c152dc72
feat: Add user cloud it to telemetry (#7232) 
Github issue / Community forum post (link here to close automatically):
 2023-09-25 12:59:41 +02:00
Iván Ovejero 33991e92d0
fix(core): Fix missing execution ID in webhook-based workflow producing binary data (#7244) 
Story: https://linear.app/n8n/issue/PAY-839

This is a longstanding bug, fixed now so that the S3 backend for binary
data can use execution IDs as part of the filename.

To reproduce:

1. Set up a workflow with a POST Webhook node that accepts binary data.
2. Activate the workflow and call it sending a binary file, e.g. `curl
-X POST -F "file=@/path/to/binary/file/test.jpg"
http://localhost:5678/webhook/uuid`
3. Check `~/.n8n/binaryData`. The binary data and metadata files will be
missing the execution ID, e.g. `11869055-83c4-4493-876a-9092c4708b9b`
instead of `39011869055-83c4-4493-876a-9092c4708b9b`.
 2023-09-25 12:30:28 +02:00
Iván Ovejero dcc9cc13ed
feat(core): Remove storeMetadata and getSize from binary data manager interface (no-changelog) (#7195) 
Depends on: #7164 | Story:
[PAY-838](https://linear.app/n8n/issue/PAY-838/introduce-object-store-service-for-binary-data)

This PR removes `storeMetadata` and `getSize` from the binary data
manager interface, as these are specific to filesystem mode. Also this
disambiguates identifiers:

```
binaryDataId
filesystem:289b4aac51e-dac6-4167-b793-6d5c415e2b47 {mode}:{fileId}

fileId - FS
289b4aac51e-dac6-4167-b793-6d5c415e2b47 {executionId}{uuid}

fileId - S3
/workflows/{workflowId}/executions/{executionId}/binary_data/b4aac51e-dac6-4167-b793-6d5c415e2b47
```

Note: The object store changes originally in this PR were extracted out
into the final PR.

---------

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
 2023-09-25 10:07:06 +02:00
Iván Ovejero 6d6e2488c6
refactor(core): Generalize binary data manager interface (no-changelog) (#7164) 
Depends on: #7092 | Story:
[PAY-768](https://linear.app/n8n/issue/PAY-768)

This PR: 
- Generalizes the `IBinaryDataManager` interface.
- Adjusts `Filesystem.ts` to satisfy the interface.
- Sets up an S3 client stub to be filled in in the next PR.
- Turns `BinaryDataManager` into an injectable service.
- Adjusts the config schema and adds new validators.

Note that the PR looks large but all the main changes are in
`packages/core/src/binaryData`.

Out of scope:
- `BinaryDataManager` (now `BinaryDataService`) and `Filesystem.ts` (now
`fs.client.ts`) were slightly refactored for maintainability, but fully
overhauling them is **not** the focus of this PR, which is meant to
clear the way for the S3 implementation. Future improvements for these
two should include setting up a backwards-compatible dir structure that
makes it easier to locate binary data files to delete, removing
duplication, simplifying cloning methods, using integers for binary data
size instead of `prettyBytes()`, writing tests for existing binary data
logic, etc.

---------

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
 2023-09-22 17:22:12 +02:00
Csaba Tuncsik 4614e1e1c9
fix(editor): Add debug feature docs link (#7240) 2023-09-22 13:27:08 +02:00
Michael Kret 647fc6c555
fix(editor): Fix SQL editor issue (#7236) 
Github issue / Community forum post (link here to close automatically):
 2023-09-22 14:17:54 +03:00
Iván Ovejero e8e44f6b6e
refactor(core): Log binary data file write errors (no-changelog) (#7237) 
This PR adds logging for binary data file write errors, to capture why
executions sometimes point to non-existing binary data files. See
[Sentry
error](https://n8nio.sentry.io/issues/4495134693/?alert_rule_id=14556563&alert_type=issue&notification_uuid=4b50a5da-6ae9-472e-9658-984cca824762&project=4503924908883968&referrer=slack).
 2023-09-22 11:48:20 +02:00
Jon c0df5cdfd4
fix(APITemplate.io Node): Fix action description for create pdf (no-changelog) (#7226) 
Github issue / Community forum post (link here to close automatically):
https://github.com/n8n-io/n8n/issues/7224
 2023-09-22 07:27:00 +01:00
Val bf74f09d69
feat(core): Add Tournament as the new default expression evaluator (#6964) 
Github issue / Community forum post (link here to close automatically):

---------

Co-authored-by: Omar Ajoue <krynble@gmail.com>
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
 2023-09-21 13:57:45 +01:00
Elias Meire 67b985fe89
fix(core): Handle filename* with quotes in Content-Disposition header (#7229) 
Github issue / Community forum post (link here to close automatically):
 2023-09-21 14:54:10 +02:00
Michael Kret 2af967cf88
fix(Airtable Node): Attachments field type fix (#7227) 
Github issue / Community forum post (link here to close automatically):

https://community.n8n.io/t/possible-airtable-bug-when-creating-attachment-record/29288
 2023-09-21 15:00:41 +03:00
Ricardo Espinoza 303bc8e71e
fix: Issue enforcing user limits on start plan (#7188) 2023-09-21 05:56:40 -04:00
Milorad FIlipović b0e98b59a6
feat(editor): Rework banners framework and add email confirmation banner (#7205) 
This PR introduces banner framework overhaul:
First version of the banner framework was built to allow multiple
banners to be shown at the same time. Since that proven to be the case
we don't need and it turned out to be pretty messy keeping only one
banner visible in such setup, this PR reworks it so it renders only one
banner at a time, based on [this priority
list](https://www.notion.so/n8n/Banner-stack-60948c4167c743718fde80d6745258d5?pvs=4#6afd052ec8d146a1b0fab8884a19add7)
that is assembled together with our product & design team.

### How to test banner stack:
1. Available banners and their priorities are registered
[here](f9f122d46d/packages/editor-ui/src/components/banners/BannerStack.vue (L14))
2. Banners are pushed to stack using `pushBannerToStack` action, for
example:
```
useUIStore().pushBannerToStack('TRIAL');
```
4. Try pushing different banners to stack and check if only the one with
highest priorities is showing up

### How to test the _Email confirmation_ banner:
1. Comment out [this
line](b80d2e3bec/packages/editor-ui/src/stores/cloudPlan.store.ts (L59)),
so cloud data is always fetched
2. Create an
[override](https://chrome.google.com/webstore/detail/resource-override/pkoacgokdfckfpndoffpifphamojphii)
(URL -> File) that will serve user data that triggers this banner:
- **URL**: `*/rest/cloud/proxy/admin/user/me`
- **File**:
```
{
    "confirmed": false,
    "id": 1,
    "email": "test@test.com",
    "username": "test"
}
```
3. Run n8n
 2023-09-21 09:47:21 +02:00
Mutasem Aldmour 2491ccf4d9
fix: Ensure new Set node is on top of search list (#7215) 
Github issue / Community forum post (link here to close automatically):
 2023-09-20 16:47:51 +02:00
कारतोफ्फेलस्क्रिप्ट™ 8bb22292d5 Merge tag 'n8n@1.8.0' 2023-09-20 16:20:34 +02:00
Iván Ovejero cd08c8e4c6
refactor(core): Implement soft-deletions for executions (#7092) 
Based on #7065 | Story: https://linear.app/n8n/issue/PAY-771

n8n on filesystem mode marks binary data to delete on manual execution
deletion, on unsaved execution completion, and on every execution
pruning cycle. We later prune binary data in a separate cycle via these
marker files, based on the configured TTL. In the context of introducing
an S3 client to manage binary data, the filesystem mode's mark-and-prune
setup is too tightly coupled to the general binary data management
client interface.

This PR...
- Ensures the deletion of an execution causes the deletion of any binary
data associated to it. This does away with the need for binary data TTL
and simplifies the filesystem mode's mark-and-prune setup.
- Refactors all execution deletions (including pruning) to cause soft
deletions, hard-deletes soft-deleted executions based on the existing
pruning config, and adjusts execution endpoints to filter out
soft-deleted executions. This reduces DB load, and keeps binary data
around long enough for users to access it when building workflows with
unsaved executions.
- Moves all execution pruning work from an execution lifecycle hook to
`execution.repository.ts`. This keeps related logic in a single place.
- Removes all marking logic from the binary data manager. This
simplifies the interface that the S3 client will meet.
- Adds basic sanity-check tests to pruning logic and execution deletion.

Out of scope:

- Improving existing pruning logic.
- Improving existing execution repository logic.
- Adjusting dir structure for filesystem mode.

---------

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
 2023-09-20 15:21:42 +02:00
Giulio Andreini 09a7cf0980
docs(Google Sheets Node): Operations naming update (no-changelog) (#7211) 
Github issue / Community forum post (link here to close automatically):
 2023-09-20 15:20:56 +02:00
github-actions[bot] ecd5d93c19
🚀 Release 1.8.0 (#7219) 
# [1.8.0](https://github.com/n8n-io/n8n/compare/n8n@1.7.0...n8n@1.8.0)
(2023-09-20)


### Bug Fixes

* **core:** Make parsing of content-type and content-disposition headers
more flexible ([#7217](https://github.com/n8n-io/n8n/issues/7217))
([d41546b](d41546b899)),
closes [#7149](https://github.com/n8n-io/n8n/issues/7149)
* **core:** Resolve domains to IPv4 first
([#7206](https://github.com/n8n-io/n8n/issues/7206))
([e9ce531](e9ce531210))
* **editor:** Add ssh key type selection to source control settings when
regenerating key ([#7172](https://github.com/n8n-io/n8n/issues/7172))
([54bf66d](54bf66d335))
* **editor:** No need to add click emitting click events, VUE delegates
the handler to the root element of the component
([#7182](https://github.com/n8n-io/n8n/issues/7182))
([3c055e4](3c055e4d8d))
* **editor:** Prevent duplicate creation of credential for OAuth2
([#7163](https://github.com/n8n-io/n8n/issues/7163))
([07a6417](07a6417f0f))
* **editor:** Testing flaky resource mapper feature in e2e tests
([#7165](https://github.com/n8n-io/n8n/issues/7165))
([aaf87c3](aaf87c3edd))
* **HTML Node:** Add pairedItem support for 'Convert to HTML Table'
operation ([#7196](https://github.com/n8n-io/n8n/issues/7196))
([6bc477b](6bc477b50e))
* **HTTP Request Node:** Decrease default timeout to 5min
([#7177](https://github.com/n8n-io/n8n/issues/7177))
([321780d](321780d4a2))
* **seven Node:** Rename sms77 to seven, fix credentials test
([#7180](https://github.com/n8n-io/n8n/issues/7180))
([cf776b8](cf776b8f17))
* **X (Formerly Twitter) Node:** Rename Twitter to X (keep Twitter
alias) ([#7179](https://github.com/n8n-io/n8n/issues/7179))
([d317e09](d317e09c59))


### Features

* **core:** Add command to trigger license refresh on workers
([#7184](https://github.com/n8n-io/n8n/issues/7184))
([9f797b9](9f797b96d8))
* **core:** Add rsa option to ssh key generation
([#7154](https://github.com/n8n-io/n8n/issues/7154))
([fdac2c8](fdac2c8572))
* **Linear Node:** Add support for OAuth2
([#7201](https://github.com/n8n-io/n8n/issues/7201))
([12a3168](12a3168367))
* **Microsoft Outlook Node:** Node overhaul
([#4449](https://github.com/n8n-io/n8n/issues/4449))
([556a613](556a6132ba))
* **Set Node:** Overhaul
([#6348](https://github.com/n8n-io/n8n/issues/6348))
([3a47455](3a474552b2))

Co-authored-by: krynble <krynble@users.noreply.github.com>
 2023-09-20 15:10:20 +02:00
Elias Meire d41546b899
fix(core): Make parsing of content-type and content-disposition headers more flexible (#7217) 
fixes #7149
 2023-09-20 14:40:06 +02:00
Marcus 6bc477b50e
fix(HTML Node): Add pairedItem support for 'Convert to HTML Table' operation (#7196) 
Github issue / Community forum post (link here to close automatically):

Co-authored-by: Michael Kret <michael.k@radency.com>
 2023-09-20 13:56:53 +02:00
Elias Meire 321780d4a2
fix(HTTP Request Node): Decrease default timeout to 5min (#7177) 
Github issue / Community forum post (link here to close automatically):

fixes https://github.com/n8n-io/n8n/issues/7081
 2023-09-20 12:38:34 +02:00
Jon 12a3168367
feat(Linear Node): Add support for OAuth2 (#7201) 2023-09-20 10:19:12 +01:00
कारतोफ्फेलस्क्रिप्ट™ e9ce531210
fix(core): Resolve domains to IPv4 first (#7206) 2023-09-19 15:56:38 +02:00
Iván Ovejero 28598ed1a7
ci: Fix tests failing on MySQL (no-changelog) (#7208) 
https://github.com/n8n-io/n8n/actions/runs/6229338666/job/16907667212
 2023-09-19 15:42:39 +02:00
Michael Kret 3a474552b2
feat(Set Node): Overhaul (#6348) 
Github issue / Community forum post (link here to close automatically):
https://github.com/n8n-io/n8n/pull/6348

---------

Co-authored-by: Giulio Andreini <g.andreini@gmail.com>
Co-authored-by: Marcus <marcus@n8n.io>
 2023-09-19 13:16:35 +03:00
Cornelius Suermann 050ba706d3
fix: Attempt license renewal when n8n starts (no-changelog) (#7204) 
This change is needed so that the newly introduced floating licenses
will be attempted to be claimed when n8n starts up.
 2023-09-19 12:10:23 +02:00
Elias Meire cf776b8f17
fix(seven Node): Rename sms77 to seven, fix credentials test (#7180) 
Github issue / Community forum post (link here to close automatically):
 2023-09-19 10:26:53 +02:00
Jon 8b3aa0d68f
fix(Spotify Node): Fix typos in descriptions (no-changelog) (#7194) 
Github issue / Community forum post (link here to close automatically):
https://github.com/n8n-io/n8n/issues/7191
 2023-09-18 15:05:15 +01:00
Michael Auerswald 9f797b96d8
feat(core): Add command to trigger license refresh on workers (#7184) 
This PR implements the updated license SDK so that worker and webhook
instances do not auto-renew licenses any more.

Instead, they receive a `reloadLicense` command via the Redis client
that will fetch the updated license after it was saved on the main
instance

This also contains some refactoring with moving redis sub and pub
clients into the event bus directly, to prevent cyclic dependency
issues.
 2023-09-17 11:05:54 +02:00
Elias Meire d317e09c59
fix(X (Formerly Twitter) Node): Rename Twitter to X (keep Twitter alias) (#7179) 
Github issue / Community forum post (link here to close automatically):
 2023-09-15 15:04:16 +02:00
Csaba Tuncsik 240b2f075e
feat(editor): Add Workflow history route and base page (no-changelog) (#7161) 2023-09-15 13:17:04 +02:00
Michael Kret 556a6132ba
feat(Microsoft Outlook Node): Node overhaul (#4449) 
[N8N-4995](https://linear.app/n8n/issue/N8N-4995)

---------

Co-authored-by: Giulio Andreini <g.andreini@gmail.com>
 2023-09-15 12:52:18 +03:00
Csaba Tuncsik 3c055e4d8d
fix(editor): No need to add click emitting click events, VUE delegates the handler to the root element of the component (#7182) 2023-09-15 11:22:30 +02:00
कारतोफ्फेलस्क्रिप्ट™ c18ba370d5
ci: Remove eslint diff plugin. Run full linting on PRs (no-changelog) (#7175) 2023-09-14 16:55:06 +02:00
Csaba Tuncsik 54bf66d335
fix(editor): Add ssh key type selection to source control settings when regenerating key (#7172) 2023-09-14 14:40:34 +02:00
Michael Auerswald fdac2c8572
feat(core): Add rsa option to ssh key generation (#7154) 
PR adds a new field to the SourceControlPreferences as well as to the
POST parameters for the `source-control/preferences` and
`source-control/generate-key-pair` endpoints. Both now accept an
optional string parameter `keyGeneratorType` of `'ed25519' | 'rsa'`

Calling the `source-control/generate-key-pair` endpoint with the
parameter set, it will also update the stored preferences accordingly
(so that in the future new keys will use the same method)

By default ed25519 is being used. The default may be changed using a new
environment parameter:

`N8N_SOURCECONTROL_DEFAULT_SSH_KEY_TYPE` which can be `rsa` or `ed25519`

RSA keys are generated with a length of 4096 bytes.
 2023-09-14 11:34:51 +02:00
Milorad FIlipović aaf87c3edd
fix(editor): Testing flaky resource mapper feature in e2e tests (#7165) 2023-09-14 10:54:25 +02:00
Michael Auerswald 0c6169ee22
refactor(core): Move event and telemetry handling into workers in queue mode (#7138) 
# Motivation

In Queue mode, finished executions would cause the main instance to
always pull all execution data from the database, unflatten it and then
use it to send out event log events and telemetry events, as well as
required returns to Respond to Webhook nodes etc.

This could cause OOM errors when the data was large, since it had to be
fully unpacked and transformed on the main instance’s side, using up a
lot of memory (and time).

This PR attempts to limit this behaviour to only happen in those
required cases where the data has to be forwarded to some waiting
webhook, for example.

# Changes

Execution data is only required in cases, where the active execution has
a `postExecutePromise` attached to it. These usually forward the data to
some other endpoint (e.g. a listening webhook connection).

By adding a helper `getPostExecutePromiseCount()`, we can decide that in
cases where there is nothing listening at all, there is no reason to
pull the data on the main instance.

Previously, there would always be postExecutePromises because the
telemetry events were called. Now, these have been moved into the
workers, which have been given the various InternalHooks calls to their
hook function arrays, so they themselves issue these telemetry and event
calls.

This results in all event log messages to now be logged on the worker’s
event log, as well as the worker’s eventbus being the one to send out
the events to destinations. The main event log does…pretty much nothing.

We are not logging executions on the main event log any more, because
this would require all events to be replicated 1:1 from the workers to
the main instance(s) (this IS possible and implemented, see the worker’s
`replicateToRedisEventLogFunction` - but it is not enabled to reduce the
amount of traffic over redis).

Partial events in the main log could confuse the recovery process and
would result in, ironically, the recovery corrupting the execution data
by considering them crashed.

# Refactor

I have also used the opportunity to reduce duplicate code and move some
of the hook functionality into
`packages/cli/src/executionLifecycleHooks/shared/sharedHookFunctions.ts`
in preparation for a future full refactor of the hooks
 2023-09-14 07:58:15 +02:00
Csaba Tuncsik 07a6417f0f
fix(editor): Prevent duplicate creation of credential for OAuth2 (#7163) 
This PR solves the issue reported in [this
ticket](https://linear.app/n8n/issue/PAY-825/click-to-connect-for-google-sheets-does-not-work-when-cred-is-not).

Basically when trying to connect OAuth2 credentials, n8n would create
the credential twice, possibly causing transaction issues.

This PR prevents n8n from firing a duplicate creation request,
effectively fixing the bug about duplicate creation.
 2023-09-13 17:28:43 +02:00
github-actions[bot] a6e027b3ff
🚀 Release 1.7.0 (#7162) 
# [1.7.0](https://github.com/n8n-io/n8n/compare/n8n@1.6.0...n8n@1.7.0)
(2023-09-13)


### Bug Fixes

* **Code Node:** Disable WASM to address CVE-2023-37903
([#7122](https://github.com/n8n-io/n8n/issues/7122))
([36a8e91](36a8e911e6))
* **Code Node:** Upgrade vm2 to address CVE-2023-37466
([#7123](https://github.com/n8n-io/n8n/issues/7123))
([0a35025](0a35025e5e))
* **core:** Disable Node.js custom inspection to address CVE-2023-37903
([#7125](https://github.com/n8n-io/n8n/issues/7125))
([a223734](a223734a4a))
* **editor** Account for nanoid workflow ids for subworkflow execute
policy ([#7094](https://github.com/n8n-io/n8n/issues/7094))
([67092c0](67092c0a1b))
* **editor:** Tweak hover area of workflow / cred cards
([#7108](https://github.com/n8n-io/n8n/issues/7108))
([217de21](217de21605))
* **editor:** Unbind workflow endpoint events in case of workspace reset
([#7129](https://github.com/n8n-io/n8n/issues/7129))
([c9b7948](c9b79485cf))
* **editor:** Update git repo url validation regex
([#7151](https://github.com/n8n-io/n8n/issues/7151))
([e51f173](e51f173608))
* **Google Cloud Firestore Node:** Fix empty string interpreted as
number ([#7136](https://github.com/n8n-io/n8n/issues/7136))
([915cfa0](915cfa0f6a))
* **HubSpot Node:** Fix issue with contact lists not working
([#5582](https://github.com/n8n-io/n8n/issues/5582))
([6e5a4f6](6e5a4f6a58))
* **Postgres Node:** Fix automatic column mapping
([#7121](https://github.com/n8n-io/n8n/issues/7121))
([92af131](92af1314fe))
* **Zoho CRM Node:** Fix issue with Sales Order not updating
([#6959](https://github.com/n8n-io/n8n/issues/6959))
([fd800b6](fd800b674b))


### Features

* **core:** Add an option to enable WAL mode for SQLite
([#7118](https://github.com/n8n-io/n8n/issues/7118))
([1d1a022](1d1a022def))
* **core:** Add commands to workers to respond with current state
([#7029](https://github.com/n8n-io/n8n/issues/7029))
([7b49cf2](7b49cf2a2c))
* **Salesforce Node:** Add fax field to lead option
([#7030](https://github.com/n8n-io/n8n/issues/7030))
([01f875a](01f875a94d))

Co-authored-by: netroy <netroy@users.noreply.github.com>
 2023-09-13 14:55:52 +02:00
कारतोफ्फेलस्क्रिप्ट™ 34ebffea45
refactor(core): Move workerCommandHandler into worker.ts (no-changelog) (#7160) 2023-09-13 14:51:41 +02:00
Csaba Tuncsik 217de21605
fix(editor): Tweak hover area of workflow / cred cards (#7108) 
Context

When a user is attempting to interact with a foreground action inside an
entity card (workflow, credential, community node, logging destination),
they might accidentally open that entity instead of interacting with a
foreground action.

For these card components, actions are always placed on right side. 

A/C

Area around right "column" of entity cards (workflow, cred, community
node, logging destination) should not be a hoverable area (that opens
that entity when clicked). This area is roughly highlighted in screen
shot below in orange.


![image](https://github.com/n8n-io/n8n/assets/5410822/0916bcd5-e972-4367-a862-41d2086a2334)
 2023-09-13 12:21:26 +02:00
Omar Ajoue 67092c0a1b
fix: Account for nanoid workflow ids for subworkflow execute policy (#7094) 
Github issue / Community forum post (link here to close automatically):

Since the change to allow workflow IDs to become strings in Nano ID
formats, this input broke.

This PR allows all characters that comprise workflow IDs.

---------

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
 2023-09-13 09:56:58 +02:00
Csaba Tuncsik c9b79485cf
fix(editor): Unbind workflow endpoint events in case of workspace reset (#7129) 2023-09-13 09:00:35 +02:00
कारतोफ्फेलस्क्रिप्ट™ 22edc03cab
fix(core): Ignore missing user-agent on bot check (no-changelog) (#7153) 2023-09-12 19:57:25 +02:00
Jon 6e5a4f6a58
fix(HubSpot Node): Fix issue with contact lists not working (#5582) 2023-09-12 17:04:39 +01:00
Quang-Linh LE 915cfa0f6a
fix(Google Cloud Firestore Node): Fix empty string interpreted as number (#7136) 2023-09-12 10:03:33 +01:00
greyliath b67a6fc432
docs(editor): Update .round() function in NumberExtensions.ts for clarity (#7150) 2023-09-12 09:24:29 +01:00
Csaba Tuncsik e51f173608
fix(editor): Update git repo url validation regex (#7151) 2023-09-11 20:54:03 +02:00
Jon fd800b674b
fix(Zoho CRM Node): Fix issue with Sales Order not updating (#6959) 2023-09-11 17:15:52 +01:00
Jon 5c6cccd4fa
docs: Add concatenate alias to Split in Batches (#7133) 
Github issue / Community forum post (link here to close automatically):
 2023-09-08 12:49:16 +01:00
कारतोफ्फेलस्क्रिप्ट™ 1d1a022def
feat(core): Add an option to enable WAL mode for SQLite (#7118) 
https://www.sqlite.org/wal.html
 2023-09-07 15:58:48 +02:00
कारतोफ्फेलस्क्रिप्ट™ 67aaad15eb
refactor(core): Use a Set for deletedProperties in AugmentObject (no-changelog) (#7131) 2023-09-07 15:07:32 +02:00
Michael Auerswald 7b49cf2a2c
feat(core): Add commands to workers to respond with current state (#7029) 
This PR adds new endpoints to the REST API:
`/orchestration/worker/status` and `/orchestration/worker/id`

Currently these just trigger the return of status / ids from the workers
via the redis back channel, this still needs to be handled and passed
through to the frontend.

It also adds the eventbus to each worker, and triggers a reload of those
eventbus instances when the configuration changes on the main instances.
 2023-09-07 14:44:19 +02:00
कारतोफ्फेलस्क्रिप्ट™ 0a35025e5e
fix(Code Node): Upgrade vm2 to address CVE-2023-37466 (#7123) 
[GH Advisory](https://github.com/advisories/GHSA-cchq-frgv-rjh5)

Actual fix
[here](26168e6dfe).
 2023-09-07 14:18:15 +02:00
Jon f07d97fa6e
docs: Add email alias to Outlook and GMail (#7127) 2023-09-07 10:42:34 +01:00
कारतोफ्फेलस्क्रिप्ट™ a223734a4a
fix(core): Disable Node.js custom inspection to address CVE-2023-37903 (#7125) 
This seems like a better fix than #7122
 2023-09-07 10:25:59 +02:00
MC Naveen 01f875a94d
feat(Salesforce Node): Add fax field to lead option (#7030) 
Closes:
https://community.n8n.io/t/there-is-no-fax-field-in-the-saleforce-lead-cretion/29829
 2023-09-07 08:07:37 +01:00
Deborah 9af626a1b3
docs: Docs links for TheHive and TheHive5 (#7124) 
Github issue / Community forum post (link here to close automatically):
 2023-09-07 07:49:55 +01:00
कारतोफ्फेलस्क्रिप्ट™ 92af1314fe
fix(Postgres Node): Fix automatic column mapping (#7121) 
NODE-757
 2023-09-06 16:32:50 +02:00
कारतोफ्फेलस्क्रिप्ट™ 36a8e911e6
fix(Code Node): Disable WASM to address CVE-2023-37903 (#7122) 
[GH Advisory](https://github.com/advisories/GHSA-g644-9gfx-q4q4)
 2023-09-06 16:11:39 +02:00
github-actions[bot] 955bd327ff
🚀 Release 1.6.0 (#7120) 
# [1.6.0](https://github.com/n8n-io/n8n/compare/n8n@1.5.1...n8n@1.6.0)
(2023-09-06)


### Bug Fixes

* **core:** Add support for in-transit encryption (TLS) on Redis
connections ([#7047](https://github.com/n8n-io/n8n/issues/7047))
([a910757](a910757cc5))
* **core:** Disallow orphan executions
([#7069](https://github.com/n8n-io/n8n/issues/7069))
([8a28e98](8a28e98ec8))
* **core:** Split event bus controller into community and ee
([#7107](https://github.com/n8n-io/n8n/issues/7107))
([011ee2e](011ee2e04b))
* **editor:** Standardize save text
([#7093](https://github.com/n8n-io/n8n/issues/7093))
([58b3492](58b3492b0d))
* Ensure all new executions are saved
([#7061](https://github.com/n8n-io/n8n/issues/7061))
([b8e06d2](b8e06d245f))
* Load remote resources even if expressions in non requried parameters
resolve ([#6987](https://github.com/n8n-io/n8n/issues/6987))
([8a8d4e8](8a8d4e8bb3))
* **Postgres Node:** Connection pool of the database object has been
destroyed ([#7074](https://github.com/n8n-io/n8n/issues/7074))
([9dd5f0e](9dd5f0e579))
* **Postgres Node:** Tunnel doesn't always close
([#7087](https://github.com/n8n-io/n8n/issues/7087))
([58e55ba](58e55ba669))


### Features

* **core:** Add list query middleware to credentials
([#7041](https://github.com/n8n-io/n8n/issues/7041))
([fd78021](fd78021b68))
* **core:** Add support for floating licenses
([#7090](https://github.com/n8n-io/n8n/issues/7090))
([e26553f](e26553f198))
* **core:** Migration for soft deletions for executions
([#7088](https://github.com/n8n-io/n8n/issues/7088))
([413e0bc](413e0bccb4))
* **HTTP Request Node:** Determine binary file name from
content-disposition headers
([#7032](https://github.com/n8n-io/n8n/issues/7032))
([273d091](273d0913fe))
* **TheHive Node:** Overhaul
([#6457](https://github.com/n8n-io/n8n/issues/6457))
([73e782e](73e782e2cf))

Co-authored-by: netroy <netroy@users.noreply.github.com>
 2023-09-06 13:35:31 +02:00
कारतोफ्फेलस्क्रिप्ट™ 273d0913fe
feat(HTTP Request Node): Determine binary file name from content-disposition headers (#7032) 
Fixes: 

https://community.n8n.io/t/http-request-node-read-filename-from-content-disposition-header-when-downloading-files/13453

https://community.n8n.io/t/read-filename-from-content-disposition-header-when-downloading-files/22192
 2023-09-06 12:38:37 +02:00
Omar Ajoue 25dc4d7825
feat: Add workflow history repository files (no-changelog) (#7071) 2023-09-06 12:23:40 +02:00
कारतोफ्फेलस्क्रिप्ट™ 689a77cc87
refactor(Spreadsheet File Node): Reduce memory usage when loading CSV files (#7095) 
Co-authored-by: Michael Kret <michael.k@radency.com>
 2023-09-06 11:58:00 +02:00
कारतोफ्फेलस्क्रिप्ट™ 2f647974f4
refactor: Use actual nodes/credentials in cli and core tests (no-changelog) (#7115) 2023-09-06 10:23:47 +02:00
कारतोफ्फेलस्क्रिप्ट™ a910757cc5
fix(core): Add support for in-transit encryption (TLS) on Redis connections (#7047) 
Fixes https://community.n8n.io/t/upgrade-from-1-1-1-to-1-2-0/30148
 2023-09-05 18:18:50 +02:00
कारतोफ्फेलस्क्रिप्ट™ cc37a5046a
fix(core): Lazy-load express-openapi-validator to reduce initial memory spike (no-changelog) (#7111) 2023-09-05 14:42:14 +02:00
कारतोफ्फेलस्क्रिप्ट™ 36f246929e
ci: Fix linting (no-changelog) (#7110) 2023-09-05 14:41:56 +02:00
Iván Ovejero 0036a4726c
refactor(core): Move static data handling to workflow service (no-changelog) (#7104) 2023-09-05 13:42:31 +02:00
Michael Auerswald 011ee2e04b
fix(core): Split event bus controller into community and ee (#7107) 2023-09-05 13:32:09 +02:00
कारतोफ्फेलस्क्रिप्ट™ 6aa7b93473
refactor(core): Deprecate prepareOutputData (no-changelog) (#7091) 2023-09-05 12:59:02 +02:00
Iván Ovejero b7320f5322
refactor(core): Set up ExecutionMetadata service (no-changelog) (#7103) 
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
 2023-09-05 09:13:30 +02:00
कारतोफ्फेलस्क्रिप्ट™ cffda65b33
refactor(core): Add an option to use simple recovery process by default (#7097) 2023-09-04 19:58:36 +02:00
कारतोफ्फेलस्क्रिप्ट™ ee36f2d20b
refactor(core): Disable slow-query log by default (no-changelog) (#7096) 
Fixes:
https://community.n8n.io/t/stop-logging-full-query-for-execution/29732

[Slack
Conversation](https://n8nio.slack.com/archives/C035KBDA917/p1693218994681939)
 2023-09-04 17:59:08 +02:00
Michael Kret 73e782e2cf
feat(TheHive Node): Overhaul (#6457) 2023-09-04 18:15:52 +03:00
कारतोफ्फेलस्क्रिप्ट™ f286bd33c1
ci: Fix linting (no-changelog) (#7099) 2023-09-04 17:07:11 +02:00
Iván Ovejero 8a28e98ec8
fix(core): Disallow orphan executions (#7069) 
Until https://github.com/n8n-io/n8n/pull/7061 we had an edge case where
a manual unsaved workflow when run creates an orphan execution, i.e. a
saved execution not pointing to any workflow. This execution is only
ever visible to the instance owner (even if triggered by a member), and
is wrongly stored as unfinished and crashed. This PR enforces that the
DB disallows any such executions from making it into the DB.

This is needed also for the S3 client, which will include the
`workflowId` in the path-like filename.

---------

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
 2023-09-04 16:57:10 +02:00
Deborah 58b3492b0d
fix(editor): Standardize save text (#7093) 
Github issue / Community forum post (link here to close automatically):

---------

Co-authored-by: Jonathan Bennetts <jonathan.bennetts@gmail.com>
 2023-09-04 15:28:30 +01:00
Cornelius Suermann e26553f198
feat(core): Add support for floating licenses (#7090) 
This PR updates the license-sdk to v2.5.0 which introduces optional
support for floating licenses.
 2023-09-04 15:56:20 +02:00
Iván Ovejero fd78021b68
feat(core): Add list query middleware to credentials (#7041) 2023-09-04 15:00:25 +02:00
Iván Ovejero 413e0bccb4
feat(core): Migration for soft deletions for executions (#7088) 
Based on https://github.com/n8n-io/n8n/pull/7065

---------

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
 2023-09-04 14:34:03 +02:00
Michael Kret 58e55ba669
fix(Postgres Node): Tunnel doesn't always close (#7087) 2023-09-04 13:26:02 +03:00
Deborah 400949daa4
docs(Strapi Node): Update Strapi.node.json with correct credentials URL (#7060) 
Github issue / Community forum post (link here to close automatically):
 2023-09-04 10:47:24 +01:00
Iván Ovejero 442b910ffb
refactor(core): Consolidate CredentialsService.getMany() (no-changelog) (#7028) 
Consolidate `CredentialsService.getMany()` in preparation for adding
list query middleware to `GET /credentials`.
 2023-09-04 10:37:16 +02:00
Michael Kret 9dd5f0e579
fix(Postgres Node): Connection pool of the database object has been destroyed (#7074) 
Github issue / Community forum post (link here to close automatically):
 2023-09-01 22:19:10 +03:00
Iván Ovejero 008cdcce56
ci: Fix lint to fix build (#7076) 2023-09-01 16:23:23 +02:00
कारतोफ्फेलस्क्रिप्ट™ 97f87ae0fc
refactor(core): Add addColumns and dropColumns to the migrations DSL (no-changelog) (#7073) 2023-09-01 15:19:49 +02:00
Iván Ovejero 51093f649d
refactor: Move community package logic to service (no-changelog) (#6973) 2023-09-01 15:13:19 +02:00
कारतोफ्फेलस्क्रिप्ट™ 2432dcc661
fix(core): Prevent bots from scanning the application (no-changelog) (#7066) 
N8N-6878
 2023-09-01 13:54:35 +02:00
कारतोफ्फेलस्क्रिप्ट™ a693b29134
ci: Fix prettier auto-formatting (no-changelog) (#7063) 2023-09-01 13:29:31 +02:00
Iván Ovejero fa3d7070b0
refactor(core): Remove unneeded call from CreateWorkflowHistoryTable migration (no-changelog) (#7072) 
https://github.com/n8n-io/n8n/pull/7069/files#r1312786460
 2023-09-01 12:16:24 +02:00
Iván Ovejero 95cb127dfa
refactor(core): Remove slow LDAP query and unused telemetry event (#7068) 
https://linear.app/n8n/issue/PAY-660
 2023-09-01 12:05:14 +02:00
Iván Ovejero b8e06d245f
fix: Ensure all new executions are saved (#7061) 2023-09-01 09:32:39 +02:00
Mutasem Aldmour 8a8d4e8bb3
fix: Load remote resources even if expressions in non requried parameters resolve (#6987) 
Github issue / Community forum post (link here to close automatically):
 2023-08-31 16:40:20 +02:00
Iván Ovejero 8cd4db0ab7
refactor(core): Simplify marking logic in binary data manager (no-changelog) (#7046) 
- For a saved execution, we write to disk binary data and metadata.
These two are only ever deleted via `POST /executions/delete`. No marker
file, so untouched by pruning.
- For an unsaved execution, we write to disk binary data, binary data
metadata, and a marker file at `/meta`. We later delete all three during
pruning.
- The third flow is legacy. Currently, if the execution is unsaved, we
actually store it in the DB while running the workflow and immediately
after the workflow is finished during the `onWorkflowPostExecute()` hook
we delete that execution, so the second flow applies. But formerly, we
did not store unsaved executions in the DB ("ephemeral executions") and
so we needed to write a marker file at `/persistMeta` so that, if the
ephemeral execution crashed after the step where binary data was stored,
we had a way to later delete its associated dangling binary data via a
second pruning cycle, and if the ephemeral execution succeeded, then we
immediately cleaned up the marker file at `/persistMeta` during the
`onWorkflowPostExecute()` hook.

This creation and cleanup at `/persistMeta` is still happening, but this
third flow no longer has a purpose, as we now store unsaved executions
in the DB and delete them immediately after. Hence the third flow can be
removed.
 2023-08-31 16:02:20 +02:00
github-actions[bot] 24cb23adfc
🚀 Release 1.5.1 (#7059) 
## [1.5.1](https://github.com/n8n-io/n8n/compare/n8n@1.5.0...n8n@1.5.1)
(2023-08-31)


### Features

* **Strapi Node:** Add token credentials
([#7048](https://github.com/n8n-io/n8n/issues/7048))
([c01bca5](c01bca562b))

Co-authored-by: netroy <netroy@users.noreply.github.com>
 2023-08-31 14:47:59 +02:00
कारतोफ्फेलस्क्रिप्ट™ 9cfe5e3c66 Merge tag 'n8n@1.5.0' 2023-08-31 14:01:47 +02:00
github-actions[bot] 0ca2c780ed
🚀 Release 1.5.0 (#7056) 
# [1.5.0](https://github.com/n8n-io/n8n/compare/n8n@1.4.0...n8n@1.5.0)
(2023-08-31)


### Bug Fixes

* **Agile CRM Node:** Fix issue with company address not working
([#6997](https://github.com/n8n-io/n8n/issues/6997))
([2f81652](2f81652400))
* **Code Node:** Switch over to vm2 fork
([#7018](https://github.com/n8n-io/n8n/issues/7018))
([dfe0fa6](dfe0fa65f8))
* **core:** Invalid NODES_INCLUDE should not crash the app
([#7038](https://github.com/n8n-io/n8n/issues/7038))
([04e3178](04e3178901)),
closes [#6683](https://github.com/n8n-io/n8n/issues/6683)
* **core:** Setup websocket keep-live messages
([#6866](https://github.com/n8n-io/n8n/issues/6866))
([8bdb07d](8bdb07d33d)),
closes [#6757](https://github.com/n8n-io/n8n/issues/6757)
* **core:** Throw `NodeSSLError` only for nodes that allow ignoring SSL
issues ([#6928](https://github.com/n8n-io/n8n/issues/6928))
([a01c3fb](a01c3fbc19))
* **Date & Time Node:** Dont parse date if it's not set (null or
undefined) ([#7050](https://github.com/n8n-io/n8n/issues/7050))
([d72f79f](d72f79ffb3))
* **editor:** Fix sending of Ask AI tracking events
([#7002](https://github.com/n8n-io/n8n/issues/7002))
([fb05afa](fb05afa165))
* **Microsoft Excel 365 Node:** Support for more extensions in workbook
rlc ([#7020](https://github.com/n8n-io/n8n/issues/7020))
([d6e1cf2](d6e1cf232f))
* **MongoDB Node:** Stringify response ObjectIDs
([#6990](https://github.com/n8n-io/n8n/issues/6990))
([9ca990b](9ca990b993))
* **MongoDB Node:** Upgrade mongodb package to address CVE-2021-32050
([#7054](https://github.com/n8n-io/n8n/issues/7054))
([d3f6356](d3f635657c))
* **Postgres Node:** Empty return data fix for Postgres and MySQL
([#7016](https://github.com/n8n-io/n8n/issues/7016))
([176ccd6](176ccd62bc))
* **Webhook Node:** Fix URL params for webhooks
([#6986](https://github.com/n8n-io/n8n/issues/6986))
([596b569](596b5695cd))


### Features

* **core:** External Secrets storage for credentials
([#6477](https://github.com/n8n-io/n8n/issues/6477))
([ed927d3](ed927d34b2))
* **core:** Add MFA ([#4767](https://github.com/n8n-io/n8n/issues/4767))
([2b7ba6f](2b7ba6fdf1))
* **core:** Add filtering, selection and pagination to users
([#6994](https://github.com/n8n-io/n8n/issues/6994))
([b716241](b716241b42))
* **editor:** Debug executions in the editor
([#6834](https://github.com/n8n-io/n8n/issues/6834))
([c833078](c833078c87))
* **RSS Read Node:** Add support for self signed certificates
([#7039](https://github.com/n8n-io/n8n/issues/7039))
([3b9f0fe](3b9f0fed7a))

Co-authored-by: netroy <netroy@users.noreply.github.com>
 2023-08-31 12:57:20 +02:00
Elias Meire c01bca562b
feat(Strapi Node): Add token credentials (#7048) 
Co-authored-by: Michael Kret <michael.k@radency.com>
 2023-08-31 12:46:28 +02:00
Elias Meire d72f79ffb3
fix(Date & Time Node): Dont parse date if it's not set (null or undefined) (#7050) 
Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/date-time-node-transforming-null-to-19700101/29339

null/undefined input was converted to 01/01/1970 instead of being passed
through as-is
 2023-08-31 12:33:26 +02:00
कारतोफ्फेलस्क्रिप्ट™ d3f635657c
fix(MongoDB Node): Upgrade mongodb package to address CVE-2021-32050 (#7054) 
[GH Advisory](https://github.com/advisories/GHSA-vxvm-qww3-2fh7)
 2023-08-31 12:29:43 +02:00
कारतोफ्फेलस्क्रिप्ट™ 281c0ae829
ci: Define explicit charset for mysql/mariadb test database (no-changelog) (#7053) 
[DB
Tests](https://github.com/n8n-io/n8n/actions/runs/6035513299/job/16375993427)
 2023-08-31 11:57:40 +02:00
Jon 3b9f0fed7a
feat(RSS Read Node): Add support for self signed certificates (#7039) 2023-08-30 16:11:47 +01:00
कारतोफ्फेलस्क्रिप्ट™ dfe0fa65f8
fix(Code Node): Switch over to vm2 fork (#7018) 
[Fork is here](https://github.com/n8n-io/vm2). Currently there are no
modifications in it.
 2023-08-30 11:17:04 +02:00
Marcus 9ca990b993
fix(MongoDB Node): Stringify response ObjectIDs (#6990) 
Github issue / Community forum post (link here to close automatically):
 2023-08-29 17:44:37 +02:00
Deborah 8a01d063c9
docs(editor): Update docs links for community nodes (#7044) 2023-08-29 16:40:33 +01:00