Iván Ovejero
61d8aebeaf
fix(core): Allow grace period for binary data deletion after manual execution ( #7889 )
...
https://linear.app/n8n/issue/PAY-1079
2023-12-01 10:13:53 +01:00
Val
5f4a9524ec
refactor(core): Add central license mock for integration tests (no-changelog) ( #7871 )
...
Github issue / Community forum post (link here to close automatically):
2023-11-30 09:23:09 +01:00
Val
cd474f1562
feat: Allow owner to share workflows/credentials they don't own (no-changelog) ( #7869 )
...
Github issue / Community forum post (link here to close automatically):
2023-11-29 16:32:27 +00:00
Omar Ajoue
74b4513298
feat(core): Add Advanced Permissions to FE settings (no-changelog) ( #7867 )
...
Github issue / Community forum post (link here to close automatically):
2023-11-29 15:56:35 +01:00
Val
1cb92ffe16
feat: Replace owner checks with scope checks (no-changelog) ( #7846 )
...
Github issue / Community forum post (link here to close automatically):
2023-11-29 14:48:36 +00:00
कारतोफ्फेलस्क्रिप्ट™
6d9342e676
Merge tag 'n8n@1.19.0'
2023-11-29 14:12:24 +01:00
Iván Ovejero
476806ebb0
feat(core): Allow admin creation ( #7837 )
...
https://linear.app/n8n/issue/PAY-1038
2023-11-29 13:55:41 +01:00
github-actions[bot]
303cf31331
🚀 Release 1.19.0 ( #7863 )
...
#
[1.19.0](https://github.com/n8n-io/n8n/compare/n8n@1.18.0...n8n@1.19.0 )
(2023-11-29)
### Bug Fixes
* **core:** Ensure member and admin cannot be promoted to owner
([#7830 ](https://github.com/n8n-io/n8n/issues/7830 ))
([9b87a59
](9b87a596ca
)),
closes
[/linear.app/n8n/issue/PAY-985/add-user-role-modification-endpoint#comment-62355f6](https://github.com//linear.app/n8n/issue/PAY-985/add-user-role-modification-endpoint/issues/comment-62355f6 )
* **core:** Prevent error messages due to statistics about data loading
([#7824 ](https://github.com/n8n-io/n8n/issues/7824 ))
([847f6ac
](847f6ac771
))
* **core:** Tighten checks for multi-main setup usage
([#7788 ](https://github.com/n8n-io/n8n/issues/7788 ))
([fdb2c18
](fdb2c18ecc
))
* **core:** Use AbortController to notify nodes to abort execution
([#6141 ](https://github.com/n8n-io/n8n/issues/6141 ))
([d2c18c5
](d2c18c5727
))
* **editor:** Add telemetry to workflow history
([#7811 ](https://github.com/n8n-io/n8n/issues/7811 ))
([d497041
](d4970410e1
))
* **editor:** Allow owners and admins to share workflows and credentials
they don't own ([#7833 ](https://github.com/n8n-io/n8n/issues/7833 ))
([3ab3ec9
](3ab3ec9da8
))
* **editor:** Disable context menu actions in read-only mode
([#7789 ](https://github.com/n8n-io/n8n/issues/7789 ))
([902beff
](902beffce5
))
* **editor:** Fix cloud plan data loading on instance
([#7841 ](https://github.com/n8n-io/n8n/issues/7841 ))
([8b99384
](8b99384367
))
* **editor:** Fix credential icon for old node type version
([#7843 ](https://github.com/n8n-io/n8n/issues/7843 ))
([4074107
](4074107511
))
* **editor:** Fix icon for unknown node type
([#7842 ](https://github.com/n8n-io/n8n/issues/7842 ))
([28ac5a7
](28ac5a750e
))
* **editor:** Fix mouse position in workflow previews
([#7853 ](https://github.com/n8n-io/n8n/issues/7853 ))
([c063398
](c0633987bf
))
* **editor:** Show nice error when environment is not set up
([#7778 ](https://github.com/n8n-io/n8n/issues/7778 ))
([5835e05
](5835e055d3
))
* **editor:** Suppress dev server websocket messages in workflow view
([#7808 ](https://github.com/n8n-io/n8n/issues/7808 ))
([685ffd7
](685ffd7413
))
* **Google Sheets Node:** Read operation execute for each item
([#7800 ](https://github.com/n8n-io/n8n/issues/7800 ))
([d548872
](d5488725a8
))
* **HTTP Request Node:** Enable expressions for binary input data fields
([#7782 ](https://github.com/n8n-io/n8n/issues/7782 ))
([6208af0
](6208af07eb
))
* **Microsoft SQL Node:** Prevent double escaping table name
([#7801 ](https://github.com/n8n-io/n8n/issues/7801 ))
([73ec753
](73ec7533ce
))
### Features
* Add AI tool building capabilities
([#7336 ](https://github.com/n8n-io/n8n/issues/7336 ))
([87def60
](87def60979
))
* Add initial scope checks via decorators
([#7737 ](https://github.com/n8n-io/n8n/issues/7737 ))
([a37f1cb
](a37f1cb0ba
))
* Ado 1296 spike credential setup in templates
([#7786 ](https://github.com/n8n-io/n8n/issues/7786 ))
([aae45b0
](aae45b043b
))
* **core:** Add Support for custom CORS origins for webhooks
([#7455 ](https://github.com/n8n-io/n8n/issues/7455 ))
([99a9ea4
](99a9ea497a
))
* **core:** Allow user role modification
([#7797 ](https://github.com/n8n-io/n8n/issues/7797 ))
([7a86d36
](7a86d36068
))
* **core:** Set up endpoint for all existing roles with license flag
([#7834 ](https://github.com/n8n-io/n8n/issues/7834 ))
([2356fb0
](2356fb0f0c
))
* **editor:** Add node name and version to NDV node settings
([#7731 ](https://github.com/n8n-io/n8n/issues/7731 ))
([da85198
](da851986f6
))
* **editor:** Add routing middleware, permission checks, RBAC store,
RBAC component ([#7702 ](https://github.com/n8n-io/n8n/issues/7702 ))
([67a8891
](67a88914f2
))
* **editor:** Replace middleware for Role checks with Scope checks
([#7847 ](https://github.com/n8n-io/n8n/issues/7847 ))
([72852a6
](72852a60eb
))
* **editor:** Show avatars for users currently working on the same
workflow ([#7763 ](https://github.com/n8n-io/n8n/issues/7763 ))
([77bc8ec
](77bc8ecd4b
))
* **Notion Node:** Option to simplify output in getChildBlocks operation
([#7791 ](https://github.com/n8n-io/n8n/issues/7791 ))
([d667bca
](d667bca658
))
* **Slack Node:** Add support for getting the profile of a user
([#7829 ](https://github.com/n8n-io/n8n/issues/7829 ))
([90bb6ba
](90bb6ba417
))
Co-authored-by: ivov <ivov@users.noreply.github.com>
2023-11-29 13:17:03 +01:00
Val
e282ea242d
fix: Return scopes on owner setup endpoint (no-changelog) ( #7860 )
...
Github issue / Community forum post (link here to close automatically):
2023-11-29 11:33:32 +00:00
Iván Ovejero
c08c5cc37b
refactor(core): Switch plain errors in cli
to ApplicationError
( #7857 )
...
Ensure all errors in `cli` are `ApplicationError` or children of it and
contain no variables in the message, to continue normalizing all the
errors we report to Sentry
Follow-up to: https://github.com/n8n-io/n8n/pull/7839
2023-11-29 12:25:10 +01:00
Jan Oberhauser
87def60979
feat: Add AI tool building capabilities ( #7336 )
...
Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/langchain-memory-chat/23733
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Val <68596159+valya@users.noreply.github.com>
Co-authored-by: Alex Grozav <alex@grozav.com>
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
Co-authored-by: Deborah <deborah@starfallprojects.co.uk>
Co-authored-by: Jesper Bylund <mail@jesperbylund.com>
Co-authored-by: Jon <jonathan.bennetts@gmail.com>
Co-authored-by: Michael Kret <88898367+michael-radency@users.noreply.github.com>
Co-authored-by: Giulio Andreini <andreini@netseven.it>
Co-authored-by: Mason Geloso <Mason.geloso@gmail.com>
Co-authored-by: Mason Geloso <hone@Masons-Mac-mini.local>
Co-authored-by: Mutasem Aldmour <mutasem@n8n.io>
2023-11-29 12:13:55 +01:00
Alex Grozav
72852a60eb
feat(editor): Replace middleware for Role checks with Scope checks ( #7847 )
2023-11-29 10:35:40 +02:00
कारतोफ्फेलस्क्रिप्ट™
117962d473
feat(core): Update LLM applications building support (no-changelog) ( #7710 )
...
extracted out of #7336
---------
Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
Co-authored-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Alex Grozav <alex@grozav.com>
2023-11-28 16:47:28 +01:00
Iván Ovejero
2356fb0f0c
feat(core): Set up endpoint for all existing roles with license flag ( #7834 )
...
https://linear.app/n8n/issue/PAY-1034/create-endpoint-to-list-all-existing-roles
2023-11-28 14:16:47 +01:00
Val
a37f1cb0ba
feat: Add initial scope checks via decorators ( #7737 )
2023-11-28 11:41:34 +00:00
Csaba Tuncsik
3ab3ec9da8
fix(editor): Allow owners and admins to share workflows and credentials they don't own ( #7833 )
2023-11-28 11:44:55 +01:00
Iván Ovejero
1c6178759c
refactor(core): Reorganize error hierarchy in cli
package (no-changelog) ( #7839 )
...
Ensure all errors in `cli` inherit from `ApplicationError` to continue
normalizing all the errors we report to Sentry
Follow-up to: https://github.com/n8n-io/n8n/pull/7820
2023-11-28 10:19:27 +01:00
Iván Ovejero
9b87a596ca
fix(core): Ensure member and admin cannot be promoted to owner ( #7830 )
...
https://linear.app/n8n/issue/PAY-985/add-user-role-modification-endpoint#comment-62355f6b
2023-11-27 17:35:58 +01:00
Omar Ajoue
847f6ac771
fix(core): Prevent error messages due to statistics about data loading ( #7824 )
...
Statistics collection about the first time a workflow loads data simply
attempts an insert to db, and if it fails, we just ignore.
This was causing this query to fire against production workflows
multiple times, and since we want to insert only and detect whether the
insertion failed, performing a select first provides gains both in terms
of performance, as it's usually faster than trying an insertion as well
as preventing unnecessary noise in logs.
Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/duplicate-key-value-violates-unique-constraint-workflow-statistics-pkey-still-happening/29283
https://github.com/n8n-io/n8n/issues/7256
https://community.n8n.io/t/error-log-arriving-in-postgres/30191
https://github.com/n8n-io/n8n/issues/7256
https://community.n8n.io/t/cant-launch-webhooks-unable-to-find-data-of-execution/31867
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-11-27 15:43:48 +01:00
Iván Ovejero
dff8456382
refactor(core): Reorganize error hierarchy in core
and workflow
packages (no-changelog) ( #7820 )
...
Ensure all errors in `core` and `workflow` inherit from
`ApplicationError` so that we start normalizing all the errors we report
to Sentry
Follow-up to:
https://github.com/n8n-io/n8n/pull/7757#discussion_r1404338844
### `core` package
`ApplicationError`
- `FileSystemError` (abstract)
- `FileNotFoundError`
- `DisallowedFilepathError`
- `BinaryDataError` (abstract)
- `InvalidModeError`
- `InvalidManagerError`
- `InvalidExecutionMetadataError`
### `workflow` package
`ApplicationError`
- `ExecutionBaseError` (abstract)
- `WorkflowActivationError`
- `WorkflowDeactivationError`
- `WebhookTakenError`
- `WorkflowOperationError`
- `SubworkflowOperationError`
- `CliWorkflowOperationError`
- `ExpressionError`
- `ExpressionExtensionError`
- `NodeError` (abstract)
- `NodeOperationError`
- `NodeApiError`
- `NodeSSLError`
Up next:
- Reorganize errors in `cli`
- Flatten the hierarchy in `workflow` (do we really need
`ExecutionBaseError`?)
- Remove `ExecutionError` type
- Stop throwing plain `Error`s
- Replace `severity` with `level`
- Add node and credential types as `tags`
- Add workflow IDs and execution IDs as `extras`
2023-11-27 15:33:21 +01:00
Val
27e048c201
feat: Add Licensed decorator (no-changelog) ( #7828 )
...
Github issue / Community forum post (link here to close automatically):
2023-11-27 13:46:18 +00:00
Val
5acb7b94c0
refactor: Refactor variables controller into a RestController (no-changelog) ( #7822 )
...
Github issue / Community forum post (link here to close automatically):
2023-11-27 12:17:09 +00:00
Iván Ovejero
7b8532d3a3
refactor(core): Move execution progress saving to standalone utility (no-changelog) ( #7770 )
...
This PR continues the effort of moving logic inside execution lifecycle
hooks into standalone testable functions, as a stepping stone to
refactoring the hooks themselves.
2023-11-27 13:10:43 +01:00
Iván Ovejero
75a5807c72
perf(core): Make user controller tests faster (no-changelog) ( #7819 )
...
Before: `17.949 s`
After: `3.886 s`
Followup to:
https://github.com/n8n-io/n8n/pull/7797#discussion_r1404148034
2023-11-27 11:56:06 +01:00
कारतोफ्फेलस्क्रिप्ट™
1b60cfb8f1
ci: Fix new user patching endpoint tests (no-changelog) ( #7816 )
...
user ids are uuids, and in the future we should add proper input
validation to prevent invalid user ids reaching the DB like this.
2023-11-27 09:35:09 +01:00
Csaba Tuncsik
152883eed1
build: Upgrade lint related packages ( #7790 )
2023-11-27 09:11:52 +01:00
Iván Ovejero
eec2ec1ff8
refactor(core): Consolidate path-related errors in Sentry (no-changelog) ( #7757 )
...
Keep reporting [path-related
errors](https://n8nio.sentry.io/issues/4649493725 ) in Sentry but
consolidate them in a single error group.
Also, add `options.extra` as `meta` so they remain visible in debug
logs:
```
2023-11-24T11:50:54.852Z | error | ReportableError: Something went wrong "{ test: 123, file: 'LoggerProxy.js', function: 'exports.error' }"
```
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-11-24 14:42:46 +01:00
Iván Ovejero
7a86d36068
feat(core): Allow user role modification ( #7797 )
...
https://linear.app/n8n/issue/PAY-985
```
PATCH /users/:id/role
unauthenticated user
✓ should receive 401 (349 ms)
member
✓ should fail to demote owner to member (349 ms)
✓ should fail to demote owner to admin (359 ms)
✓ should fail to demote admin to member (381 ms)
✓ should fail to promote other member to owner (353 ms)
✓ should fail to promote other member to admin (377 ms)
✓ should fail to promote self to admin (354 ms)
✓ should fail to promote self to owner (371 ms)
admin
✓ should receive 400 on invalid payload (351 ms)
✓ should receive 404 on unknown target user (351 ms)
✓ should fail to demote owner to admin (349 ms)
✓ should fail to demote owner to member (347 ms)
✓ should fail to promote member to owner (384 ms)
✓ should fail to promote admin to owner (350 ms)
✓ should be able to demote admin to member (354 ms)
✓ should be able to demote self to member (350 ms)
✓ should be able to promote member to admin (349 ms)
owner
✓ should be able to promote member to admin (349 ms)
✓ should be able to demote admin to member (349 ms)
✓ should fail to demote self to admin (348 ms)
✓ should fail to demote self to member (354 ms)
```
2023-11-24 11:40:08 +01:00
Val
865192adf0
feat: Add global admin role (no-changelog) ( #7781 )
...
Github issue / Community forum post (link here to close automatically):
2023-11-23 13:38:11 +00:00
Michael Auerswald
5835e055d3
fix(editor): Show nice error when environment is not set up ( #7778 )
...
Adds a nicer error message with a link for owners who press Push to Git
without having a repository connected yet.
2023-11-23 13:50:03 +01:00
Iván Ovejero
fdb2c18ecc
fix(core): Tighten checks for multi-main setup usage ( #7788 )
...
https://n8nio.slack.com/archives/C05HRPLSGTT/p1700731476321999?thread_ts=1700729359.746899&cid=C05HRPLSGTT
2023-11-23 12:18:39 +01:00
Csaba Tuncsik
e128b23a2b
build: Upgrade to Vite 5 ( #7784 )
2023-11-23 11:55:02 +01:00
Milorad FIlipović
77bc8ecd4b
feat(editor): Show avatars for users currently working on the same workflow ( #7763 )
...
This PR introduces the following changes:
- New Vue stores: `collaborationStore` and `pushConnectionStore`
- Front-end push connection handling overhaul: Keep only a singe
connection open and handle it from the new store
- Add user avatars in the editor header when there are multiple users
working on the same workflow
- Sending a heartbeat event to back-end service periodically to confirm
user is still active
- Back-end overhauls (authored by @tomi):
- Implementing a cleanup procedure that removes inactive users
- Refactoring collaboration service current implementation
---------
Co-authored-by: Tomi Turtiainen <10324676+tomi@users.noreply.github.com>
2023-11-23 10:14:34 +01:00
Michael Kret
99a9ea497a
feat(core): Add Support for custom CORS origins for webhooks ( #7455 )
...
node-850
https://community.n8n.io/t/add-ability-to-set-cors-allow-list-in-n8n-webhooks/7610
https://community.n8n.io/t/configure-cors-pre-flight-request-option-method-in-the-roadmap/32189
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-11-22 17:49:56 +01:00
github-actions[bot]
e01617ad64
🚀 Release 1.18.0 ( #7780 )
...
#
[1.18.0](https://github.com/n8n-io/n8n/compare/n8n@1.17.0...n8n@1.18.0 )
(2023-11-22)
### Bug Fixes
* **core:** Account for non-ASCII chars in filename on binary data
download ([#7742 ](https://github.com/n8n-io/n8n/issues/7742 ))
([b4ebb1a
](b4ebb1a28d
))
* **core:** Correct permissions for getstatus
([#7724 ](https://github.com/n8n-io/n8n/issues/7724 ))
([f96c1d2
](f96c1d2044
))
* **core:** Ensure failed executions are saved in queue mode
([#7744 ](https://github.com/n8n-io/n8n/issues/7744 ))
([b7c5c74
](b7c5c7406f
))
* **core:** Guard against node not found on cancelling test webhook
([#7750 ](https://github.com/n8n-io/n8n/issues/7750 ))
([6be453b
](6be453b716
))
* **editor:** Handle permission edge cases (empty scopes)
([#7723 ](https://github.com/n8n-io/n8n/issues/7723 ))
([e2ffd39
](e2ffd397fc
))
* **editor:** Make sure LineController is registered with chart.js
([#7730 ](https://github.com/n8n-io/n8n/issues/7730 ))
([ebee1a5
](ebee1a5908
))
* **editor:** Move workerview entry into settings menu
([#7761 ](https://github.com/n8n-io/n8n/issues/7761 ))
([366cd67
](366cd672a7
))
* **editor:** Only show push to git menu item to owners
([#7766 ](https://github.com/n8n-io/n8n/issues/7766 ))
([0d3d33d
](0d3d33dd1f
))
* **editor:** Show v1 banner dismiss button if owner
([#7722 ](https://github.com/n8n-io/n8n/issues/7722 ))
([44d3b3e
](44d3b3ed7e
))
* **editor:** Use project diagram icon for worker view
([#7764 ](https://github.com/n8n-io/n8n/issues/7764 ))
([ff0b651
](ff0b6511f7
))
* **editor:** Validate user info before submiting
([#7608 ](https://github.com/n8n-io/n8n/issues/7608 ))
([2064f7f
](2064f7f251
))
* **GitHub Node:** Fix issue preventing file edits on branches
([#7734 ](https://github.com/n8n-io/n8n/issues/7734 ))
([ce002a6
](ce002a6cc6
))
* **Google Sheets Node:** Check for `null` before destructuring
([#7729 ](https://github.com/n8n-io/n8n/issues/7729 ))
([5d4a52d
](5d4a52d3b7
))
* **Item Lists Node:** Don't check same type in remove duplicates
operation ([#7678 ](https://github.com/n8n-io/n8n/issues/7678 ))
([4f30764
](4f307646f3
))
* **JotForm Trigger Node:** Fix iteration on form loader
([#7751 ](https://github.com/n8n-io/n8n/issues/7751 ))
([82f3202
](82f3202a2d
))
### Features
* Add Creator hub link to Templates page
([#7721 ](https://github.com/n8n-io/n8n/issues/7721 ))
([4dbae0e
](4dbae0e2e9
))
* **core:** Coordinate manual workflow activation and deactivation in
multi-main scenario ([#7643 ](https://github.com/n8n-io/n8n/issues/7643 ))
([4c40825
](4c4082503c
))
* **editor:** Add node context menu
([#7620 ](https://github.com/n8n-io/n8n/issues/7620 ))
([8d12c1a
](8d12c1ad8d
))
* **editor:** Node IO filter
([#7503 ](https://github.com/n8n-io/n8n/issues/7503 ))
([1881765
](18817651ec
))
Co-authored-by: ivov <ivov@users.noreply.github.com>
2023-11-22 14:32:25 +01:00
कारतोफ्फेलस्क्रिप्ट™
db77353272
fix(core): Pass correct node reference to NodeExecuteFunctions.getLoadOptionsFunctions (no-changelog) ( #7779 )
...
NODE-947
2023-11-22 13:24:23 +01:00
Milorad FIlipović
2064f7f251
fix(editor): Validate user info before submiting ( #7608 )
...
Validate first and last names before saving them to database. This
should prevent security issue with un-sanitized data that ends up in
emails.
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-11-22 12:14:44 +01:00
कारतोफ्फेलस्क्रिप्ट™
9b4856e7de
feat(core): Make postgres pool-size configurable (no-changelog) ( #7772 )
...
When we upgrade typeorm in #5151 , we switched from no pooling to a
default pool-size of 10. This somehow significantly deteriorates the
performance of queries when the application is under load.
2023-11-21 18:13:08 +01:00
Iván Ovejero
3459eb6c2f
refactor(core): Include execution progress in save settings (no-changelog) ( #7769 )
2023-11-21 17:33:44 +01:00
Iván Ovejero
b7c5c7406f
fix(core): Ensure failed executions are saved in queue mode ( #7744 )
...
This PR adds `status` to run data so that
`determineFinalExecutionStatus` resolves correctly on execution failure
and removes the cleanup that is being duplicated in a worker hook.
Followup to https://github.com/n8n-io/n8n/pull/7138
Should fix:
- https://github.com/n8n-io/n8n/issues/7705
-
https://linear.app/n8n/issue/PAY-964/no-execution-found-after-execution-fails
-
https://linear.app/n8n/issue/PAY-1010/execution-deletion-in-queue-mode-not-complying-with-settings
2023-11-20 16:03:02 +01:00
Iván Ovejero
6d19f88080
refactor(core): Stop reporting to Sentry unknown cred on mapping (no-changelog) ( #7752 )
...
https://n8nio.sentry.io/issues/4563418905
2023-11-17 16:17:44 +01:00
Iván Ovejero
4c4082503c
feat(core): Coordinate manual workflow activation and deactivation in multi-main scenario ( #7643 )
...
Followup to #7566 | Story: https://linear.app/n8n/issue/PAY-926
### Manual workflow activation and deactivation
In a multi-main scenario, if the user manually activates or deactivates
a workflow, the process (whether leader or follower) that handles the
PATCH request and updates its internal state should send a message into
the command channel, so that all other main processes update their
internal state accordingly:
- Add to `ActiveWorkflows` if activating
- Remove from `ActiveWorkflows` if deactivating
- Remove and re-add to `ActiveWorkflows` if the update did not change
activation status.
After updating their internal state, if activating or deactivating, the
recipient main processes should push a message to all connected
frontends so that these can update their stores and so reflect the value
in the UI.
### Workflow activation errors
On failure to activate a workflow, the main instance should record the
error in Redis - main instances should always pull activation errors
from Redis in a multi-main scenario.
### Leadership change
On leadership change...
- The old leader should stop pruning and the new leader should start
pruning.
- The old leader should remove trigger- and poller-based workflows and
the new leader should add them.
2023-11-17 15:58:50 +01:00
कारतोफ्फेलस्क्रिप्ट™
db094f2d7e
fix(core): Fix all dependency versions for backend packages (no-changelog) ( #7745 )
...
Once the packages are published to NPM, they don't have the
`pnpm-lock.yaml` to fix dependency versions. Which means that any
dependency with `^` gets auto-upgrade to the latest matching minor,
which can cause issues like
[this](https://github.com/node-cache-manager/node-cache-manager/issues/611 ).
2023-11-17 13:49:18 +01:00
कारतोफ्फेलस्क्रिप्ट™
fc60e9a809
refactor(core): Convert dynamic node-parameter routes to a decorated controller (no-changelog) ( #7284 )
...
1. Reduce a lot of code duplication
2. Move more endpoints out of `Server.ts`
3. Move all query-param parsing and validation into a middleware to make
the route handlers simpler.
2023-11-17 12:03:05 +01:00
Iván Ovejero
0408299c7d
refactor(core): Stop reporting to Sentry unrecognized node errors (no-changelog) ( #7728 )
...
https://n8nio.sentry.io/issues/4636584213
2023-11-17 10:25:10 +01:00
Iván Ovejero
b4ebb1a28d
fix(core): Account for non-ASCII chars in filename on binary data download ( #7742 )
...
https://n8nio.sentry.io/issues/4641538638
2023-11-17 10:07:44 +01:00
Ricardo Espinoza
8e0ae3cf8c
refactor: Extract Invitation routes to InvitationController (no-changelog) ( #7726 )
...
This PR:
- Creates `InvitationController`
- Moves `POST /users` to `POST /invitations` and move related test to
`invitations.api.tests`
- Moves `POST /users/:id` to `POST /invitations/:id/accept` and move
related test to `invitations.api.tests`
- Adjusts FE to use new endpoints
- Moves all the invitation logic to the `UserService`
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-11-16 12:39:43 -05:00
Csaba Tuncsik
e2ffd397fc
fix(editor): Handle permission edge cases (empty scopes) ( #7723 )
2023-11-16 18:08:23 +01:00
Val
d39bb2540f
feat: Add scopes to /login endpoint (no-changelog) ( #7718 )
...
Github issue / Community forum post (link here to close automatically):
2023-11-16 11:11:55 +00:00
Michael Auerswald
f96c1d2044
fix(core): Correct permissions for getstatus ( #7724 )
2023-11-15 16:54:33 +01:00
github-actions[bot]
93103c0b08
🚀 Release 1.17.0 ( #7720 )
...
#
[1.17.0](https://github.com/n8n-io/n8n/compare/n8n@1.16.0...n8n@1.17.0 )
(2023-11-15)
### Bug Fixes
* **Convert to/from binary data Node:** Better mime type defaults
([#7693 ](https://github.com/n8n-io/n8n/issues/7693 ))
([9b3be0c
](9b3be0cfd8
))
* **core:** Consider subworkflows successfully run when in waiting state
([#7699 ](https://github.com/n8n-io/n8n/issues/7699 ))
([0e00dab
](0e00dab9f5
))
* **core:** Fix named parameter resolution in migrations
([#7688 ](https://github.com/n8n-io/n8n/issues/7688 ))
([4441ed5
](4441ed5116
)),
closes [#7628 ](https://github.com/n8n-io/n8n/issues/7628 )
* **core:** Initialize JWT Secret before it's used anywhere
([#7707 ](https://github.com/n8n-io/n8n/issues/7707 ))
([3460eb5
](3460eb5eeb
))
* **core:** Reduce memory usage in credentials risk auditing
([#7663 ](https://github.com/n8n-io/n8n/issues/7663 ))
([9fd6319
](9fd6319583
))
* **Date & Time Node:** Add fromFormat option to solve ambiguous date
strings ([#7675 ](https://github.com/n8n-io/n8n/issues/7675 ))
([d2d11e0
](d2d11e0208
))
* **editor:** Fix resource mapper component being truncated
([#7664 ](https://github.com/n8n-io/n8n/issues/7664 ))
([00dff50
](00dff50140
))
* **editor:** More securely clear executions tab auto refresh timer
([#7685 ](https://github.com/n8n-io/n8n/issues/7685 ))
([37dd658
](37dd658dc5
))
* **editor:** Redirect to workflow editor after saving in debug mode
([#7645 ](https://github.com/n8n-io/n8n/issues/7645 ))
([020042e
](020042ef1a
))
* **Google Sheets Node:** Append exceeding grid limits
([#7684 ](https://github.com/n8n-io/n8n/issues/7684 ))
([88efb99
](88efb99587
))
* **HTTP Request Node:** Support generic credentials when using
pagination ([#7686 ](https://github.com/n8n-io/n8n/issues/7686 ))
([48b240b
](48b240b026
)),
closes [#7653 ](https://github.com/n8n-io/n8n/issues/7653 )
* **HubSpot Node:** Fetching available parameters fails when using
expressions ([#7672 ](https://github.com/n8n-io/n8n/issues/7672 ))
([a9ab738
](a9ab73896e
))
* **HubSpot Node:** Update deal owner on Hubspot Deal
([#7673 ](https://github.com/n8n-io/n8n/issues/7673 ))
([3c0734b
](3c0734bd2d
))
* **Spreadsheet File Node:** Read file as utf-8 in v1
([#7701 ](https://github.com/n8n-io/n8n/issues/7701 ))
([786b4ad
](786b4adcce
))
### Features
* **core:** Expression function $ifEmpty
([#7660 ](https://github.com/n8n-io/n8n/issues/7660 ))
([1c7225e
](1c7225ebdb
))
* **Date & Time Node:** Option to include other fields in output item
([#7661 ](https://github.com/n8n-io/n8n/issues/7661 ))
([aea3c50
](aea3c50131
))
* **Discord Node:** Overhaul
([#5351 ](https://github.com/n8n-io/n8n/issues/5351 ))
([6a53c2a
](6a53c2a375
))
* **Discourse Node:** Add new options to Get Users
([#7674 ](https://github.com/n8n-io/n8n/issues/7674 ))
([2e8c841
](2e8c841277
))
* **editor:** Add color selector to sticky node
([#7453 ](https://github.com/n8n-io/n8n/issues/7453 ))
([8359364
](8359364536
))
* **editor:** Add HTTP request nodes for credentials without a node
([#7157 ](https://github.com/n8n-io/n8n/issues/7157 ))
([14035e1
](14035e1244
))
* **editor:** Add workflow filters to querystring
([#7456 ](https://github.com/n8n-io/n8n/issues/7456 ))
([afd637b
](afd637b5ea
))
* **editor:** Adds a EE view to show worker details and job status
([#7600 ](https://github.com/n8n-io/n8n/issues/7600 ))
([cbc6909
](cbc690907f
))
* **GitLab Node:** Add support for pagination on getIssues
([#7529 ](https://github.com/n8n-io/n8n/issues/7529 ))
([0a0798e
](0a0798e485
))
* **OpenAI Node:** Add dall-e-3 support
([#7655 ](https://github.com/n8n-io/n8n/issues/7655 ))
([a9c7188
](a9c7188c4d
))
* **RabbitMQ Trigger Node:** Add exchange and routing key options
([#7547 ](https://github.com/n8n-io/n8n/issues/7547 ))
([5aee2b7
](5aee2b768f
))
* **Telegram Node:** Add support for markdownv2
([#7679 ](https://github.com/n8n-io/n8n/issues/7679 ))
([819b3a7
](819b3a746a
))
* **Venafi TLS Protect Cloud Node:** Add region parameter to Venafi
protect cloud ([#7689 ](https://github.com/n8n-io/n8n/issues/7689 ))
([a08fca5
](a08fca51d9
))
### Performance Improvements
* **core:** Lazyload security audit reporters
([#7696 ](https://github.com/n8n-io/n8n/issues/7696 ))
([b2ca050
](b2ca050031
))
Co-authored-by: ivov <ivov@users.noreply.github.com>
2023-11-15 15:18:08 +01:00
कारतोफ्फेलस्क्रिप्ट™
2844ce2bd2
ci: Fix env issues in e2e tests (no-changelog) ( #7719 )
2023-11-15 13:58:38 +01:00
Ricardo Espinoza
4020c14d59
refactor: Use POST /users to re-invite users (no-changelog) ( #7714 )
2023-11-15 06:40:57 -05:00
कारतोफ्फेलस्क्रिप्ट™
3460eb5eeb
fix(core): Initialize JWT Secret before it's used anywhere ( #7707 )
...
HELP-394
2023-11-15 12:17:18 +01:00
कारतोफ्फेलस्क्रिप्ट™
4441ed5116
fix(core): Fix named parameter resolution in migrations ( #7688 )
...
Fixes #7628
2023-11-15 10:31:08 +01:00
Michael Auerswald
0e00dab9f5
fix(core): Consider subworkflows successfully run when in waiting state ( #7699 )
...
Github issue / Community forum post (link here to close automatically):
https://github.com/n8n-io/n8n/issues/7189
2023-11-14 11:04:24 +01:00
Elias Meire
14035e1244
feat(editor): Add HTTP request nodes for credentials without a node ( #7157 )
...
Github issue / Community forum post (link here to close automatically):
---------
Co-authored-by: Giulio Andreini <g.andreini@gmail.com>
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-11-13 12:11:16 +01:00
Iván Ovejero
b2ca050031
perf(core): Lazyload security audit reporters ( #7696 )
...
Also converting to service.
Followup to https://github.com/n8n-io/n8n/pull/7663
2023-11-13 11:50:43 +01:00
Michael Auerswald
cbc690907f
feat(editor): Adds a EE view to show worker details and job status ( #7600 )
...
This change expands on the command channel communication introduced
lately between the main instance(s) and the workers. The frontend gets a
new menu entry "Workers" which will, when opened, trigger a regular call
to getStatus from the workers. The workers then respond via their
response channel to the backend, which then pushes the status to the
frontend.
This introduces the use of ChartJS for metrics.
This feature is still in MVP state and thus disabled by default for the
moment.
2023-11-10 23:48:31 +01:00
Ricardo Espinoza
0ddafd2b82
test: Unify users.controller.test and users.api.test (no-changelog) ( #7658 )
...
Groundwork to be able to safely refactor and move the invitation logic
to the UserService.
Fixes ADO-1358
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-11-10 09:41:58 -05:00
कारतोफ्फेलस्क्रिप्ट™
000e76e3b4
ci(core): Reduce memory usage in tests (part-2) (no-changelog) ( #7671 )
...
This also gets rid of `Db.collection`, which was another source of
circular dependencies.
2023-11-10 15:04:26 +01:00
Iván Ovejero
f73a0597ba
refactor: Add rule no-constant-binary-expression
(no-changelog) ( #7670 )
...
https://eslint.org/docs/latest/rules/no-constant-binary-expression
2023-11-09 17:50:59 +01:00
कारतोफ्फेलस्क्रिप्ट™
9fd6319583
fix(core): Reduce memory usage in credentials risk auditing ( #7663 )
2023-11-09 14:39:16 +01:00
कारतोफ्फेलस्क्रिप्ट™
5edf722209
ci: Stop disabling linting rules that are explicitly set to warn
(no-changelog) ( #7669 )
2023-11-09 14:05:39 +01:00
Iván Ovejero
16a1a92f18
refactor(core): Stop reporting to Sentry credential-not-found error (no-changelog) ( #7665 )
...
https://n8nio.sentry.io/issues/4528134408
2023-11-09 10:55:13 +01:00
कारतोफ्फेलस्क्रिप्ट™
0346b211a7
ci(core): Reduce memory usage in tests (part-1) (no-changelog) ( #7654 )
2023-11-08 16:29:39 +01:00
github-actions[bot]
e5c6a1bdf9
🚀 Release 1.16.0 ( #7652 )
...
#
[1.16.0](https://github.com/n8n-io/n8n/compare/n8n@1.15.1...n8n@1.16.0 )
(2023-11-08)
### Bug Fixes
* **core:** Comply with custom default for workflow saving settings
([#7634 ](https://github.com/n8n-io/n8n/issues/7634 ))
([48c068f
](48c068f97b
))
* **core:** Decrease reset password token expire time
([#7598 ](https://github.com/n8n-io/n8n/issues/7598 ))
([2aa7f63
](2aa7f6375a
))
* **core:** Ensure `init` before checking leader or follower in
multi-main scenario ([#7621 ](https://github.com/n8n-io/n8n/issues/7621 ))
([a994ba5
](a994ba5e8d
))
* **core:** Ensure pruning starts only after migrations have completed
([#7626 ](https://github.com/n8n-io/n8n/issues/7626 ))
([f748de9
](f748de9567
))
* **core:** Fix accessor error when running partial execution
([#7618 ](https://github.com/n8n-io/n8n/issues/7618 ))
([26361df
](26361dfcd3
)),
closes [#6229 ](https://github.com/n8n-io/n8n/issues/6229 )
* **core:** Make password-reset urls valid only for single-use
([#7622 ](https://github.com/n8n-io/n8n/issues/7622 ))
([6031424
](60314248f4
))
* **Crypto Node:** Fix issue with value not appearing for Sign action
([#7619 ](https://github.com/n8n-io/n8n/issues/7619 ))
([5df583f
](5df583f783
))
* **editor:** Allow overriding theme from query params
([#7591 ](https://github.com/n8n-io/n8n/issues/7591 ))
([2854a0c
](2854a0cf46
))
* **editor:** Fix issue that frontend breaks with unkown nodes
([#7596 ](https://github.com/n8n-io/n8n/issues/7596 ))
([db56a9e
](db56a9ee37
))
* **editor:** Fix local storage flags defaulting to undefined string
([#7603 ](https://github.com/n8n-io/n8n/issues/7603 ))
([151e60f
](151e60f829
))
* **editor:** Fix workflow history prune time limit (getting hours
instead of days) ([#7644 ](https://github.com/n8n-io/n8n/issues/7644 ))
([3d5a485
](3d5a485bcf
))
* **editor:** Hide not supported node options
([#7597 ](https://github.com/n8n-io/n8n/issues/7597 ))
([b532a7b
](b532a7bdb7
))
* **editor:** Remove unknown credentials on pasting workflow
([#7582 ](https://github.com/n8n-io/n8n/issues/7582 ))
([d633753
](d633753687
))
* **editor:** Reset canvas zoom before workspace reset in node view
([#7625 ](https://github.com/n8n-io/n8n/issues/7625 ))
([78b84af
](78b84af8d1
))
* **editor:** Zoom in/out on canvas the same amount on scroll/gesture
([#7602 ](https://github.com/n8n-io/n8n/issues/7602 ))
([c92402a
](c92402a3ca
))
* **Facebook Lead Ads Trigger Node:** Fix issue with missing scope for
business management ([#7616 ](https://github.com/n8n-io/n8n/issues/7616 ))
([32b85ba
](32b85ba2fe
))
### Features
* **core:** Add the node version to telemetry in node_graph_string
([#7449 ](https://github.com/n8n-io/n8n/issues/7449 ))
([59dc36a
](59dc36abd9
))
* **core:** Coordinate workflow activation in multiple main scenario in
internal API ([#7566 ](https://github.com/n8n-io/n8n/issues/7566 ))
([c857e42
](c857e42677
))
* **core:** Initial support for two-way communication over websockets
([#7570 ](https://github.com/n8n-io/n8n/issues/7570 ))
([ac87701
](ac877014ed
))
* **core:** Log executed migrations with info level
([#7586 ](https://github.com/n8n-io/n8n/issues/7586 ))
([7dac9ab
](7dac9ab82c
))
* **core:** Rate limit forgot password endpoint
([#7604 ](https://github.com/n8n-io/n8n/issues/7604 ))
([5790e25
](5790e251b8
))
* **LinkedIn Node:** Add support for Article thumbnails
([#7489 ](https://github.com/n8n-io/n8n/issues/7489 ))
([e6d3d1a
](e6d3d1a4c2
))
* **NocoDB Node:** Add new data apis and workspace support
([#7329 ](https://github.com/n8n-io/n8n/issues/7329 ))
([da2d2a8
](da2d2a83bb
))
Co-authored-by: ivov <ivov@users.noreply.github.com>
2023-11-08 14:20:22 +01:00
Iván Ovejero
3a776e0132
refactor(core): Stop reporting to Sentry missing-node-on-retry error (no-changelog) ( #7648 )
...
https://n8nio.sentry.io/issues/4612370603
2023-11-08 10:09:33 +01:00
Iván Ovejero
48c068f97b
fix(core): Comply with custom default for workflow saving settings ( #7634 )
...
https://linear.app/n8n/issue/PAY-982
2023-11-07 16:26:55 +01:00
Tomi Turtiainen
ac877014ed
feat(core): Initial support for two-way communication over websockets ( #7570 )
...
- Enable two-way communication with web sockets
- Enable sending push messages to specific users
- Add collaboration service for managing active users for workflow
Missing things:
- State is currently kept only in memory, making this not work in
multi-master setups
- Removing a user from active users in situations where they go inactive
or we miss the "workflow closed" message
- I think a timer based solution for this would cover most edge cases.
I.e. have FE ping every X minutes, BE removes the user unless they have
received a ping in Y minutes, where Y > X
- FE changes to be added later by @MiloradFilipovic
Github issue / Community forum post (link here to close automatically):
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-11-07 17:26:45 +02:00
कारतोफ्फेलस्क्रिप्ट™
f0fc5b16d3
ci(core): Load config schema after process.env has been overwritten (no-changelog) ( #7550 )
2023-11-07 15:58:28 +01:00
कारतोफ्फेलस्क्रिप्ट™
60314248f4
fix(core): Make password-reset urls valid only for single-use ( #7622 )
2023-11-07 15:35:43 +01:00
Ricardo Espinoza
b3470fd64d
fix: Error handling on forgot password page (no-changelog) ( #7633 )
...
fixes:
https://linear.app/n8n/issue/ADO-1339/fix-error-handling-on-forgot-password-page
2023-11-07 08:45:58 -05:00
Iván Ovejero
f748de9567
fix(core): Ensure pruning starts only after migrations have completed ( #7626 )
...
https://linear.app/n8n/issue/PAY-986/bug-execution-pruning-timer-is-started-before-the-database-is-ready
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-11-07 13:56:01 +01:00
Iván Ovejero
c857e42677
feat(core): Coordinate workflow activation in multiple main scenario in internal API ( #7566 )
...
Story: https://linear.app/n8n/issue/PAY-926
This PR coordinates workflow activation on instance startup and on
leadership change in multiple main scenario in the internal API. Part 3
on manual workflow activation and deactivation will be a separate PR.
### Part 1: Instance startup
In multi-main scenario, on starting an instance...
- [x] If the instance is the leader, it should add webhooks, triggers
and pollers.
- [x] If the instance is the follower, it should not add webhooks,
triggers or pollers.
- [x] Unit tests.
### Part 2: Leadership change
In multi-main scenario, if the main instance leader dies…
- [x] The new main instance leader must activate all trigger- and
poller-based workflows, excluding webhook-based workflows.
- [x] The old main instance leader must deactivate all trigger- and
poller-based workflows, excluding webhook-based workflows.
- [x] Unit tests.
To test, start two instances and check behavior on startup and
leadership change:
```
EXECUTIONS_MODE=queue N8N_LEADER_SELECTION_ENABLED=true N8N_LICENSE_TENANT_ID=... N8N_LICENSE_ACTIVATION_KEY=... N8N_LOG_LEVEL=debug npm run start
EXECUTIONS_MODE=queue N8N_LEADER_SELECTION_ENABLED=true N8N_LICENSE_TENANT_ID=... N8N_LICENSE_ACTIVATION_KEY=... N8N_LOG_LEVEL=debug N8N_PORT=5679 npm run start
```
2023-11-07 13:48:48 +01:00
Iván Ovejero
a994ba5e8d
fix(core): Ensure init
before checking leader or follower in multi-main scenario ( #7621 )
...
This PR ensures `MultiMainInstancePublisher` is initialized before
checking if the instance is leader or follower. Followers skip license
init, license check, and pruning start and stop.
2023-11-06 12:03:35 +01:00
Ricardo Espinoza
5790e251b8
feat(core): Rate limit forgot password endpoint ( #7604 )
...
Github issue / Community forum post (link here to close automatically):
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <netroy@users.noreply.github.com>
2023-11-03 13:44:12 -04:00
कारतोफ्फेलस्क्रिप्ट™
acec9bad71
refactor(core): Convert OAuth1/OAuth2 routes to decorated controller classes (no-changelog) ( #5973 )
2023-11-03 17:20:54 +01:00
Tomi Turtiainen
2aa7f6375a
fix(core): Decrease reset password token expire time ( #7598 )
...
Decrease the expiration time from 1 day to 20 minutes
Github issue / Community forum post (link here to close automatically):
2023-11-03 13:32:08 +02:00
कारतोफ्फेलस्क्रिप्ट™
bb2c266e48
Merge tag 'n8n@1.15.1'
2023-11-02 18:11:06 +01:00
github-actions[bot]
fbce8f5298
🚀 Release 1.15.1 ( #7592 )
...
##
[1.15.1](https://github.com/n8n-io/n8n/compare/n8n@1.14.0...n8n@1.15.1 )
(2023-11-02)
### Bug Fixes
* **core:** Ensure execution deletion in worker lifecycle hook
([#7481 ](https://github.com/n8n-io/n8n/issues/7481 ))
([742c8a8
](742c8a8534
))
* **core:** Fix data encryption on credentials import
([#7560 ](https://github.com/n8n-io/n8n/issues/7560 ))
([b350568
](b350568505
))
* **core:** Fix issue that prevents owner logging in when using ldap
([#7408 ](https://github.com/n8n-io/n8n/issues/7408 ))
([479f902
](479f90231d
))
* **core:** Handle missing resultData in runData
([#7523 ](https://github.com/n8n-io/n8n/issues/7523 ))
([1055bd3
](1055bd3762
))
* **core:** Permission check for subworkflow properly checking for
workflow settings ([#7576 ](https://github.com/n8n-io/n8n/issues/7576 ))
([437c95e
](437c95e84e
))
* **core:** Prevent executions from becoming forever running
([#7569 ](https://github.com/n8n-io/n8n/issues/7569 ))
([9bdb85c
](9bdb85c4ce
))
* **core:** Upgrade crypto-js to address CVE-2023-46233
([#7519 ](https://github.com/n8n-io/n8n/issues/7519 ))
([65e5593
](65e5593233
))
* **editor:** Do not truncate form inputs
([#7528 ](https://github.com/n8n-io/n8n/issues/7528 ))
([ae616f1
](ae616f146b
))
* **editor:** Fix NDV close after using input select
([#7544 ](https://github.com/n8n-io/n8n/issues/7544 ))
([3b5e181
](3b5e181e66
))
* **editor:** Fix NDV unexpected re-render
([#7532 ](https://github.com/n8n-io/n8n/issues/7532 ))
([2853fcf
](2853fcff73
))
* **editor:** Fix route component caching, incorrect use of array reduce
method and enable WF history feature
([#7434 ](https://github.com/n8n-io/n8n/issues/7434 ))
([12a89e6
](12a89e6d14
))
* **editor:** Fixes the issue that Switch Node can not be created
([#7516 ](https://github.com/n8n-io/n8n/issues/7516 ))
([df89685
](df89685e15
))
* **editor:** Handle `localStorage` being blocked/unavailable
([#7348 ](https://github.com/n8n-io/n8n/issues/7348 ))
([c05bc67
](c05bc6728d
))
* Fix dark mode small issues
([#7573 ](https://github.com/n8n-io/n8n/issues/7573 ))
([1d81afc
](1d81afcbdf
))
* **Jira Software Node:** Handle missing issue types in issue types
loader ([#7534 ](https://github.com/n8n-io/n8n/issues/7534 ))
([9762705
](9762705833
))
* **Switch Node:** Allow sortable Switch rules
([#7555 ](https://github.com/n8n-io/n8n/issues/7555 ))
([7a56e58
](7a56e58a60
))
### Features
* **core:** Add optional Error-Output
([#7460 ](https://github.com/n8n-io/n8n/issues/7460 ))
([655efea
](655efeaf66
))
* **core:** Make queue mode settings configurable
([#7526 ](https://github.com/n8n-io/n8n/issues/7526 ))
([3d95b24
](3d95b243e9
))
* **core:** Set up leader selection for multiple main instances
([#7527 ](https://github.com/n8n-io/n8n/issues/7527 ))
([442c73e
](442c73e63b
))
* **editor:** Implement the `UserStack` design system component
([#7559 ](https://github.com/n8n-io/n8n/issues/7559 ))
([ce14f62
](ce14f6266b
))
* **HTTP Request Node:** Add pagination support
([#5993 ](https://github.com/n8n-io/n8n/issues/5993 ))
([cc2bd2e
](cc2bd2e19c
))
* **HTTP Request Node:** Update icon and default color
([#7572 ](https://github.com/n8n-io/n8n/issues/7572 ))
([ff279ab
](ff279ab411
))
* **n8n Form Trigger Node:** Add text area and password input types
([#7474 ](https://github.com/n8n-io/n8n/issues/7474 ))
([b72040a
](b72040aa54
))
* **editor:** Dark mode is here! You can change it under personal
settings.([#6980 ](https://github.com/n8n-io/n8n/pull/6980 ))
([0746783
](0746783e02
))
---------
Co-authored-by: krynble <krynble@users.noreply.github.com>
Co-authored-by: Omar Ajoue <krynble@gmail.com>
2023-11-02 14:52:11 +01:00
Iván Ovejero
1c77d6597f
refactor(core): Ensure only leader handles licensing in multi-main scenario ( #7558 )
...
https://linear.app/n8n/issue/PAY-953/ensure-only-main-instance-leader-handles-licensing
2023-11-02 14:16:22 +01:00
Tomi Turtiainen
7dac9ab82c
feat(core): Log executed migrations with info level ( #7586 )
...
To help debugging possible issues in startup and migrations, log the
executed migrations with log level 'info', instead of 'debug'.
Github issue / Community forum post (link here to close automatically):
2023-11-02 14:24:04 +02:00
Iván Ovejero
921d213ae5
refactor(core): Create pruning service (no-changelog) ( #7564 )
...
https://linear.app/n8n/issue/PAY-954/ensure-only-main-instance-leader-handles-pruning
2023-11-02 12:24:25 +01:00
github-actions[bot]
73e9a216b7
🚀 Release 1.15.0 ( #7580 )
...
#
[1.15.0](https://github.com/n8n-io/n8n/compare/n8n@1.14.0...n8n@1.15.0 )
(2023-11-02)
### Bug Fixes
* **core:** Ensure execution deletion in worker lifecycle hook
([#7481 ](https://github.com/n8n-io/n8n/issues/7481 ))
([742c8a8
](742c8a8534
))
* **core:** Fix data encryption on credentials import
([#7560 ](https://github.com/n8n-io/n8n/issues/7560 ))
([b350568
](b350568505
))
* **core:** Fix issue that prevents owner logging in when using ldap
([#7408 ](https://github.com/n8n-io/n8n/issues/7408 ))
([479f902
](479f90231d
))
* **core:** Handle missing resultData in runData
([#7523 ](https://github.com/n8n-io/n8n/issues/7523 ))
([1055bd3
](1055bd3762
))
* **core:** Permission check for subworkflow properly checking for
workflow settings ([#7576 ](https://github.com/n8n-io/n8n/issues/7576 ))
([437c95e
](437c95e84e
))
* **core:** Prevent executions from becoming forever running
([#7569 ](https://github.com/n8n-io/n8n/issues/7569 ))
([9bdb85c
](9bdb85c4ce
))
* **core:** Upgrade crypto-js to address CVE-2023-46233
([#7519 ](https://github.com/n8n-io/n8n/issues/7519 ))
([65e5593
](65e5593233
))
* **editor:** Do not truncate form inputs
([#7528 ](https://github.com/n8n-io/n8n/issues/7528 ))
([ae616f1
](ae616f146b
))
* **editor:** Fix NDV close after using input select
([#7544 ](https://github.com/n8n-io/n8n/issues/7544 ))
([3b5e181
](3b5e181e66
))
* **editor:** Fix NDV unexpected re-render
([#7532 ](https://github.com/n8n-io/n8n/issues/7532 ))
([2853fcf
](2853fcff73
))
* **editor:** Fix route component caching, incorrect use of array reduce
method and enable WF history feature
([#7434 ](https://github.com/n8n-io/n8n/issues/7434 ))
([12a89e6
](12a89e6d14
))
* **editor:** Fixes the issue that Switch Node can not be created
([#7516 ](https://github.com/n8n-io/n8n/issues/7516 ))
([df89685
](df89685e15
))
* **editor:** Handle `localStorage` being blocked/unavailable
([#7348 ](https://github.com/n8n-io/n8n/issues/7348 ))
([c05bc67
](c05bc6728d
))
* **Jira Software Node:** Handle missing issue types in issue types
loader ([#7534 ](https://github.com/n8n-io/n8n/issues/7534 ))
([9762705
](9762705833
))
* **Switch Node:** Allow sortable Switch rules
([#7555 ](https://github.com/n8n-io/n8n/issues/7555 ))
([7a56e58
](7a56e58a60
))
### Features
* **core:** Add optional Error-Output
([#7460 ](https://github.com/n8n-io/n8n/issues/7460 ))
([655efea
](655efeaf66
))
* **core:** Make queue mode settings configurable
([#7526 ](https://github.com/n8n-io/n8n/issues/7526 ))
([3d95b24
](3d95b243e9
))
* **core:** Set up leader selection for multiple main instances
([#7527 ](https://github.com/n8n-io/n8n/issues/7527 ))
([442c73e
](442c73e63b
))
* **editor:** Implement the `UserStack` design system component
([#7559 ](https://github.com/n8n-io/n8n/issues/7559 ))
([ce14f62
](ce14f6266b
))
* **HTTP Request Node:** Add pagination support
([#5993 ](https://github.com/n8n-io/n8n/issues/5993 ))
([cc2bd2e
](cc2bd2e19c
))
* **HTTP Request Node:** Update icon and default color
([#7572 ](https://github.com/n8n-io/n8n/issues/7572 ))
([ff279ab
](ff279ab411
))
* **n8n Form Trigger Node:** Add text area and password input types
([#7474 ](https://github.com/n8n-io/n8n/issues/7474 ))
([b72040a
](b72040aa54
))
* **editor:** Dark mode is here! You can change it under personal
settings.([#6980 ](https://github.com/n8n-io/n8n/pull/6980 ))
([0746783
](0746783e02
))
---------
Co-authored-by: krynble <krynble@users.noreply.github.com>
Co-authored-by: Omar Ajoue <krynble@gmail.com>
2023-11-02 11:47:11 +01:00
Jon
479f90231d
fix(core): Fix issue that prevents owner logging in when using ldap ( #7408 )
...
This PR prioritises the internal email account over LDAP for the Owner.
---------
Co-authored-by: ricardo <ricardoespinoza105@gmail.com>
2023-11-01 23:02:49 -04:00
Omar Ajoue
437c95e84e
fix(core): Permission check for subworkflow properly checking for workflow settings ( #7576 )
...
The `sharing` related code is legacy that was not removed. Subworkflow
execution should check workflow settings alone, and this is now
reflected in the code.
Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/bug-when-using-the-execute-workflow-node-when-workflow-is-shared/32207
---------
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
2023-11-01 18:31:34 +01:00
कारतोफ्फेलस्क्रिप्ट™
9bdb85c4ce
fix(core): Prevent executions from becoming forever running ( #7569 )
...
Fixes CP-867
Possibly also fixes PAY-323 and PAY-412
2023-11-01 13:51:13 +01:00
Yoshino-s
b72040aa54
feat(n8n Form Trigger Node): Add text area and password input types ( #7474 )
...
Signed-off-by: yoshino-s <cy-cui@outlook.com>
2023-11-01 12:23:28 +00:00
Michael Auerswald
b350568505
fix(core): Fix data decryption on credentials import ( #7560 )
...
Due to a change, during the credentials import command, the core's
Credential object is being called through its prototype. This caused the
Credential's cipher variable to not be set, thus no cipher service being
available during import. This fix catches this edge case and provides a
fix.
2023-10-31 13:15:09 +01:00
Jan Oberhauser
655efeaf66
feat(core): Add optional Error-Output ( #7460 )
...
Add an additional optional error output to which all items get sent that
could not be processed.
![Screenshot from 2023-10-18
17-29-15](https://github.com/n8n-io/n8n/assets/6249596/e9732807-ab2b-4662-a5f6-bdff24f7ad55 )
Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/error-connector-for-nodes/3094
https://community.n8n.io/t/error-handling-at-node-level-detect-node-execution-status/26791
---------
Co-authored-by: OlegIvaniv <me@olegivaniv.com>
2023-10-30 18:42:47 +01:00
Iván Ovejero
442c73e63b
feat(core): Set up leader selection for multiple main instances ( #7527 )
...
https://linear.app/n8n/issue/PAY-933/set-up-leader-selection-for-multiple-main-instances
- [x] Set up new envs
- [x] Add config and license checks
- [x] Implement `MultiMainInstancePublisher`
- [x] Expand `RedisServicePubSubPublisher` to support
`MultiMainInstancePublisher`
- [x] Init `MultiMainInstancePublisher` on startup and destroy on
shutdown
- [x] Add to sandbox plans
- [x] Test manually
Note: This is only for setup - coordinating in reaction to leadership
changes will come in later PRs.
2023-10-30 16:22:32 +01:00
OlegIvaniv
3ab04e4f9e
ci(core): Extract local e2e run script (no-changelog) ( #7551 )
...
Github issue / Community forum post (link here to close automatically):
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-10-30 11:18:51 +01:00
Iván Ovejero
233683ce1a
refactor(core): Remove webhook deregistration on shutdown flag ( #7543 )
...
Removal missing from [original
PR](https://github.com/n8n-io/n8n/pull/7515 ) after initial revert.
2023-10-27 18:48:21 +02:00
Iván Ovejero
6796ba75a1
refactor(core): Stop reporting to Sentry stopping execution with wrong status (no-changelog) ( #7541 )
...
https://n8nio.sentry.io/issues/4257040218/
2023-10-27 16:14:01 +02:00
कारतोफ्फेलस्क्रिप्ट™
35bb42c1b9
refactor(core): Avoid passing around static state like default timezone (no-changelog) ( #7221 )
2023-10-27 14:17:52 +02:00
Iván Ovejero
62c096710f
refactor: Run lintfix
(no-changelog) ( #7537 )
...
- Fix autofixable violations
- Remove unused directives
- Allow for PascalCased variables - needed for dynamically imported or
assigned classes, decorators, routers, etc.
2023-10-27 14:15:02 +02:00
Omar Ajoue
87996a1fcf
refactor(core): Stop reporting non-error to sentry (issue 4229454473) (no-changelog) ( #7525 )
...
This PR aims to stop reporting issues such as [this
one](https://n8nio.sentry.io/issues/4229454473/events/42b96bfd6a334c15a84499e981cf90eb/?project=4503924908883968 ).
Github issue / Community forum post (link here to close automatically):
2023-10-27 09:25:07 +02:00
Omar Ajoue
3d95b243e9
feat(core): Make queue mode settings configurable ( #7526 )
...
This PR allows users to configure the settings to Bull, possibly
reducing the errors with `maxStalledCount` and other issues, that
usually happen either when a worker crashes or when the event loop is
super busy. Increasing the lease time and the `maxStalledCount` settings
might improve UX.
Github issue / Community forum post (link here to close automatically):
2023-10-26 17:30:16 +02:00
Iván Ovejero
ae8c7a635e
refactor(core)!: Remove webhook deregistration at startup and shutdown ( #7515 )
...
https://linear.app/n8n/issue/PAY-932/deprecate-flag-to-skip-webhook-deregistration-on-shutdown
2023-10-26 14:37:54 +02:00
Iván Ovejero
5477e3fb45
refactor(core): Move execution save settings into lifecycle function (no-changelog) ( #7370 )
...
Move the handling of execution save settings into a tested lifecycle
function as discussed with Omar
2023-10-26 14:35:38 +02:00
कारतोफ्फेलस्क्रिप्ट™
1055bd3762
fix(core): Handle missing resultData in runData ( #7523 )
2023-10-26 13:15:19 +02:00
Iván Ovejero
742c8a8534
fix(core): Ensure execution deletion in worker lifecycle hook ( #7481 )
...
Reported by customer
[here](https://n8nio.slack.com/archives/C05PUALKZHD/p1697446945481249?thread_ts=1697196557.638169&cid=C05PUALKZHD ),
apparently a very old long-standing bug for queue mode. Please review
closely as I am not familiar with queue mode.
2023-10-25 19:13:06 +02:00
कारतोफ्फेलस्क्रिप्ट™
05586a900d
refactor(core): Make Logger a service (no-changelog) ( #7494 )
2023-10-25 16:35:22 +02:00
github-actions[bot]
db4e61ba24
🚀 Release 1.14.0 ( #7514 )
...
# [1.14.0](https://github.com/n8n-io/n8n/compare/n8n@1.13.0...n8n@1.14.0 )
(2023-10-25)
### Features
* **Switch Node:** Add support for infinite Switch outputs
([#7499 ](https://github.com/n8n-io/n8n/issues/7499 ))
([2febc61
](2febc61ec9
))
Co-authored-by: netroy <netroy@users.noreply.github.com>
2023-10-25 15:34:57 +02:00
कारतोफ्फेलस्क्रिप्ट™
0643487403
ci: Fix oclif manifest generation
2023-10-25 14:51:10 +02:00
github-actions[bot]
2987587e34
🚀 Release 1.13.0 ( #7512 )
...
# [1.13.0](https://github.com/n8n-io/n8n/compare/n8n@1.12.0...n8n@1.13.0 )
(2023-10-25)
### Bug Fixes
* **core:** Do not return `inviteAcceptUrl` in response if email was
sent ([#7465 ](https://github.com/n8n-io/n8n/issues/7465 ))
([55c6a1b
](55c6a1b0d3
))
* **core:** Ensure nodes post-processors run in the correct order
([#7500 ](https://github.com/n8n-io/n8n/issues/7500 ))
([6f45298
](6f45298d3d
))
* **core:** Fix `frontend.settings` external hook execution
([#7496 ](https://github.com/n8n-io/n8n/issues/7496 ))
([774fe20](774fe202bf
))
* **core:** Handle gzip and deflate compressed request payloads
([#7461 ](https://github.com/n8n-io/n8n/issues/7461 ))
([83762e0
](83762e051d
))
* **core:** Reduce logging overhead for levels that do not output
([#7479 ](https://github.com/n8n-io/n8n/issues/7479 ))
([76c0481
](76c04815f7
))
* **Customer.io Node:** Fix api endpoint when using EU region
([#7485 ](https://github.com/n8n-io/n8n/issues/7485 ))
([519680c
](519680c2cf
))
* **editor:** Allow importing the same workflow multiple times
([#7458 ](https://github.com/n8n-io/n8n/issues/7458 ))
([3c0a166
](3c0a166f7f
))
* **editor:** Fix canvas selection breaking after interacting with node
actions ([#7466 ](https://github.com/n8n-io/n8n/issues/7466 ))
([bc47365
](bc473655fb
))
* **editor:** Fix connections disappearing after reactivating canvas and
renaming a node ([#7483 ](https://github.com/n8n-io/n8n/issues/7483 ))
([450e0cc
](450e0cc66a
))
* **Google Sheets Node:** Append or update runs forever when without
column headers ([#7463 ](https://github.com/n8n-io/n8n/issues/7463 ))
([ab6a9bb
](ab6a9bbac2
))
* **Microsoft SQL Node:** Prevent SQL injection
([#7467 ](https://github.com/n8n-io/n8n/issues/7467 ))
([a739245
](a739245332
))
* **MQTT Trigger Node:** Fix node causing a start up hang when active
([#7498 ](https://github.com/n8n-io/n8n/issues/7498 ))
([baecb93
](baecb93bef
))
* **MySQL Node:** Resolve expressions in v1
([#7464 ](https://github.com/n8n-io/n8n/issues/7464 ))
([5c46bb0
](5c46bb09c1
))
* **Redis Node:** Fix adding sets data types
([#7444 ](https://github.com/n8n-io/n8n/issues/7444 ))
([4e66023
](4e66023cd4
))
* **Spreadsheet File Node:** Fix include empty cells not working with v2
([#7505 ](https://github.com/n8n-io/n8n/issues/7505 ))
([05e6f2a
](05e6f2a6ac
))
### Features
* **core:** Add support for oauth based service accounts with UM SMTP
([#7311 ](https://github.com/n8n-io/n8n/issues/7311 ))
([647372b
](647372be27
))
* **editor:** Add PH tracking to event
([#7511 ](https://github.com/n8n-io/n8n/issues/7511 ))
([c47d27d
](c47d27dd6d
))
* **Facebook Lead Ads Trigger Node:** Add Facebook Lead Ads Trigger Node
([#7113 ](https://github.com/n8n-io/n8n/issues/7113 ))
([ac814a9
](ac814a9c61
))
* **Ghost Node:** Add support for lexical format
([#7488 ](https://github.com/n8n-io/n8n/issues/7488 ))
([7b1973c
](7b1973c058
))
* **RSS Feed Trigger Node:** Add RSS feed trigger node
([#7386 ](https://github.com/n8n-io/n8n/issues/7386 ))
([689360e
](689360ee06
))
Co-authored-by: netroy <netroy@users.noreply.github.com>
2023-10-25 14:29:28 +02:00
कारतोफ्फेलस्क्रिप्ट™
6f45298d3d
fix(core): Ensure nodes post-processors run in the correct order ( #7500 )
...
Fixes #7497
2023-10-25 13:59:38 +02:00
Val
93cfabbeac
fix(core): Fix workflow activation with history and workflow history for EE (no-changelog) ( #7508 )
...
Github issue / Community forum post (link here to close automatically):
2023-10-25 11:07:11 +01:00
Iván Ovejero
671c95760b
refactor(core): Make executions pruning more resilient ( #7480 )
...
This PR converts the hard-deletion interval to a timeout:
- to prevent the interval from not being restored when hard deletion
throws, and
- to prevent a long-running hard deletion from leading to duplicate
deletions.
2023-10-24 16:16:45 +02:00
Iván Ovejero
78243edd18
refactor(core): Make pruning via lifecycle configuration in S3 mode mandatory ( #7482 )
...
Since we do not store which executions produced binary data, for pruning
on S3 we need to query for binary data items for each execution in order
to delete them. To minimize requests to S3, allow the user to skip
pruning requests when setting TTL at bucket level.
2023-10-24 10:37:02 +02:00
Cornelius Suermann
3ef771ea38
feat: Collect usage metrics on license renewal (no-changelog) ( #7486 )
2023-10-23 21:39:29 +02:00
Ricardo Espinoza
774fe202bf
fix(core): Fix frontend.settings
external hook execution ( #7496 )
2023-10-23 11:46:13 -04:00
Val
41236b7e08
fix: Save new version of the workflow instead of the previous (no-changelog) ( #7428 )
...
Github issue / Community forum post (link here to close automatically):
2023-10-23 16:30:36 +02:00
कारतोफ्फेलस्क्रिप्ट™
b6de910cbe
refactor(core): Abstract away InstanceSettings and encryptionKey
into injectable services (no-changelog) ( #7471 )
...
This change ensures that things like `encryptionKey` and `instanceId`
are always available directly where they are needed, instead of passing
them around throughout the code.
2023-10-23 13:39:35 +02:00
कारतोफ्फेलस्क्रिप्ट™
76c04815f7
fix(core): Reduce logging overhead for levels that do not output ( #7479 )
...
all current logging calls execute `callsites()` to figure out what code
tried to log. This happens even for logging methods that aren't supposed
to create any output. Under moderate load, this can take up quite a lot
of resources. This PR changes the logger to make all ignorable logging
methods a No-Op.
In a small benchmark with a simple webhook, with log-level set to
`warn`, and using `ab -c 50 -n 500
http://localhost:5678/webhook/testing `, these were the response times:
### Before
![Before](https://github.com/n8n-io/n8n/assets/196144/01680fd9-3d2a-4f7f-bb1c-5b03bd7d5bc3 )
### After
![After](https://github.com/n8n-io/n8n/assets/196144/ccacb20a-48ca-455a-a8cb-098c9c0e352e )
2023-10-20 18:26:33 +02:00
Iván Ovejero
0b42d1aa71
refactor(core): Limit soft-deletions to pruning only ( #7469 )
...
Based on customer feedback, we should limit soft deletions to pruning
only, to prevent executions from piling up in very high volume cases.
2023-10-20 15:02:47 +02:00
Jon
647372be27
feat(core): Add support for oauth based service accounts with UM SMTP ( #7311 )
...
This PR adds support for using OAuth based service accounts for the User
Management SMTP connection.
Tested using a Google Service Account.
2023-10-20 11:36:40 +01:00
Iván Ovejero
b50376cf52
refactor(core): Make executions pruning settings configurable ( #7468 )
2023-10-19 16:57:12 +02:00
कारतोफ्फेलस्क्रिप्ट™
55c6a1b0d3
fix(core): Do not return inviteAcceptUrl
in response if email was sent ( #7465 )
2023-10-19 13:58:06 +02:00
कारतोफ्फेलस्क्रिप्ट™
83762e051d
fix(core): Handle gzip and deflate compressed request payloads ( #7461 )
...
NODE-870
2023-10-18 21:52:15 +02:00
github-actions[bot]
ef58a23d21
🚀 Release 1.12.0 ( #7459 )
...
# [1.12.0](https://github.com/n8n-io/n8n/compare/n8n@1.11.0...n8n@1.12.0 )
(2023-10-18)
### Bug Fixes
* **core:** Add check that queue is defined and remove cyclic dependency
([#7404 ](https://github.com/n8n-io/n8n/issues/7404 ))
([45f2ef3
](45f2ef373e
))
* **core:** Do not throw when deleting workflows with executions without
binary-data ([#7411 ](https://github.com/n8n-io/n8n/issues/7411 ))
([2b6a15e
](2b6a15e478
))
* **core:** Fix expression with paired item with multi-input node
([#7424 ](https://github.com/n8n-io/n8n/issues/7424 ))
([ec14141
](ec141416e2
))
* **core:** Fix ignoring crashed executions without event msgs
([#7368 ](https://github.com/n8n-io/n8n/issues/7368 ))
([2f4d91b
](2f4d91b2cd
))
* **core:** Pg-promise de-initialization fix
([#7417 ](https://github.com/n8n-io/n8n/issues/7417 ))
([7703904
](77039044eb
))
* **core:** Prevent false stalled jobs in queue mode from displaying as
errored ([#7435 ](https://github.com/n8n-io/n8n/issues/7435 ))
([e01b9e5
](e01b9e5ae1
))
* **core:** Prevent undefined issues when restoring binary data
([#7419 ](https://github.com/n8n-io/n8n/issues/7419 ))
([46977a2
](46977a2aff
))
* **editor:** Fix remote options fetching on every keystroke
([#7320 ](https://github.com/n8n-io/n8n/issues/7320 ))
([367255a
](367255ab2c
))
* **editor:** Open only one tab with plans page
([#7377 ](https://github.com/n8n-io/n8n/issues/7377 ))
([c599006
](c599006b91
))
* **Google Sheets Node:** Update by row_number, restored 'Handling Extra
Data Option', updated Cell Format default
([#7357 ](https://github.com/n8n-io/n8n/issues/7357 ))
([d8531a5
](d8531a53b9
))
* **Ldap Node:** Fix issue with connections not closing correctly
([#7432 ](https://github.com/n8n-io/n8n/issues/7432 ))
([c3f0be8
](c3f0be809f
))
* **Set Node:** Null should not throw an error
([#7416 ](https://github.com/n8n-io/n8n/issues/7416 ))
([e9b6ab0
](e9b6ab04cd
))
* **TheHive 5 Node:** Observable encoding in alert > create fix
([#7450 ](https://github.com/n8n-io/n8n/issues/7450 ))
([a2d2e3d
](a2d2e3dda7
))
### Features
* **core:** Make executions pruning interval configurable
([#7439 ](https://github.com/n8n-io/n8n/issues/7439 ))
([40707fa
](40707fa692
))
* **Google Calendar Trigger Node:** Add support for cancelled events
([#7436 ](https://github.com/n8n-io/n8n/issues/7436 ))
([9d241a0
](9d241a0d6d
))
* **HubSpot Trigger Node:** Add support for ticket related events
([#7156 ](https://github.com/n8n-io/n8n/issues/7156 ))
([57c6093
](57c609384a
))
* **n8n Form Trigger Node:** New node
([#7130 ](https://github.com/n8n-io/n8n/issues/7130 ))
([3ddc176
](3ddc176dfa
))
* **Spreadsheet File Node:** Improve CSV parsing
([#7448 ](https://github.com/n8n-io/n8n/issues/7448 ))
([79f23fb
](79f23fb939
))
Co-authored-by: netroy <netroy@users.noreply.github.com>
2023-10-18 17:43:29 +02:00
Iván Ovejero
40707fa692
feat(core): Make executions pruning interval configurable ( #7439 )
2023-10-18 17:01:57 +02:00
Michael Kret
3ddc176dfa
feat(n8n Form Trigger Node): New node ( #7130 )
...
Github issue / Community forum post (link here to close automatically):
based on https://github.com/joffcom/n8n-nodes-form-trigger
---------
Co-authored-by: Giulio Andreini <g.andreini@gmail.com>
2023-10-17 07:09:30 +03:00
Michael Auerswald
e01b9e5ae1
fix(core): Prevent false stalled jobs in queue mode from displaying as errored ( #7435 )
...
This is related to an issue with how Bull handles stalled jobs, see
https://github.com/OptimalBits/bull/issues/1415 for reference.
CPU intensive workflows can in certain cases take a long while to finish
up, thereby blocking the thread and causing Bull queue to think the job
has stalled, even though it finished successfully. In these cases the
error handling could then overwrite the successful execution data with
the error message.
2023-10-13 16:07:08 +02:00
Iván Ovejero
c6ee1e30c0
refactor(core): Add binary data S3 to telemetry ( #7412 )
...
https://n8nio.slack.com/archives/C04B1GZ4T0U/p1697033523039729
2023-10-13 13:16:43 +02:00
Michael Auerswald
45f2ef373e
fix(core): Add check that queue is defined and remove cyclic dependency ( #7404 )
...
In a rare edge case an undefined queue could be returned - this should
not happen and now an error is thrown.
Also using the opportunity to remove a cyclic dependency from the Queue.
2023-10-13 11:53:59 +02:00
Omar Ajoue
46977a2aff
fix: Prevent undefined issues when restoring binary data ( #7419 )
...
Github issue / Community forum post (link here to close automatically):
---------
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
2023-10-12 16:41:51 +02:00
Iván Ovejero
54e900955a
refactor(core): Move frontend settings to service (no-changelog) ( #7396 )
...
Quick follow-up to https://github.com/n8n-io/n8n/pull/7283
2023-10-11 17:12:19 +02:00
कारतोफ्फेलस्क्रिप्ट™
1e0753516c
Merge tag 'n8n@1.11.0'
2023-10-11 15:55:52 +02:00
Michael Auerswald
2f4d91b2cd
fix(core): Fix ignoring crashed executions without event msgs ( #7368 )
...
when the event logs do not contain messages for running executions, the
recovery/crash detection on startup would skip these. this PR fixes
that.
2023-10-11 14:22:43 +02:00
github-actions[bot]
e6ba841c5f
🚀 Release 1.11.0 ( #7402 )
...
# [1.11.0](https://github.com/n8n-io/n8n/compare/n8n@1.10.0...n8n@1.11.0 )
(2023-10-11)
### Bug Fixes
* **core:** Add an option to enable postgres ssl with default certs
([#6889 ](https://github.com/n8n-io/n8n/issues/6889 ))
([789e1e7
](789e1e7ed4
))
* **core:** Fix error on missing paired item data
([#7399 ](https://github.com/n8n-io/n8n/issues/7399 ))
([47e8953
](47e8953ec9
))
* **core:** Missing pairing info
([#7326 ](https://github.com/n8n-io/n8n/issues/7326 ))
([e2c3c7a
](e2c3c7aceb
))
* **core:** Prevent object deletion request on no prefix match
([#7366 ](https://github.com/n8n-io/n8n/issues/7366 ))
([63e11e4
](63e11e4be9
))
* **editor:** Fix completions for `.json` on quoted node name in Code
node ([#7382 ](https://github.com/n8n-io/n8n/issues/7382 ))
([86e7ec7
](86e7ec796a
))
* **editor:** Implement canvas zoom UX improvements
([#7376 ](https://github.com/n8n-io/n8n/issues/7376 ))
([7e06b31
](7e06b31a5f
))
* **editor:** Make workflow history button available only for dev builds
([#7392 ](https://github.com/n8n-io/n8n/issues/7392 ))
([7ed466d
](7ed466db7f
))
* **editor:** Remove excess margin below run data editor
([#7372 ](https://github.com/n8n-io/n8n/issues/7372 ))
([3fa2764
](3fa27647d8
))
* **editor:** Sanitize HTML binary-data before rendering in the UI
([#7400 ](https://github.com/n8n-io/n8n/issues/7400 ))
([2b075bf
](2b075bfc2d
))
* **editor:** Use display option's @Version specifier
([#7351 ](https://github.com/n8n-io/n8n/issues/7351 ))
([afbf0c3
](afbf0c3d5e
))
* **Google BigQuery Node:** Location default to jobReference
([#7354 ](https://github.com/n8n-io/n8n/issues/7354 ))
([97bb703
](97bb703d0a
))
* **Google Drive Trigger Node:** Add Shared Drives support
([#7369 ](https://github.com/n8n-io/n8n/issues/7369 ))
([3e7a4d3
](3e7a4d3b2c
))
* **Google Sheets Node:** Fix "Maximum call stack size exceeded" error
on too many rows ([#7384 ](https://github.com/n8n-io/n8n/issues/7384 ))
([732b15a
](732b15a1fa
))
* **HTML Node:** Update property fields to not use expressions on drag
([#7379 ](https://github.com/n8n-io/n8n/issues/7379 ))
([77643e5
](77643e5ccb
))
* **Notion Node:** Handle empty values correctly for Notion selects +
multi selects ([#7383 ](https://github.com/n8n-io/n8n/issues/7383 ))
([fbcd1d4
](fbcd1d40ed
))
* **Set Node:** Increase search priority
([#7358 ](https://github.com/n8n-io/n8n/issues/7358 ))
([e5ad1e7
](e5ad1e7e4d
))
* **Webhook Node:** Backward compatible form-data parsing for non-array
files ([#7385 ](https://github.com/n8n-io/n8n/issues/7385 ))
([6479eb1
](6479eb180f
))
### Features
* **core:** Add Job Summary to Worker response
([#7360 ](https://github.com/n8n-io/n8n/issues/7360 ))
([b8608ce
](b8608cee6d
))
* **core:** Integrate object store as binary data manager
([#7253 ](https://github.com/n8n-io/n8n/issues/7253 ))
([1a661e6
](1a661e6d00
))
* **core:** Switch binary filesystem mode to nested path structure
([#7307 ](https://github.com/n8n-io/n8n/issues/7307 ))
([0847623](0847623f85
))
* **editor:** Make PDF and Audio binary-data viewable in the UI
([#7367 ](https://github.com/n8n-io/n8n/issues/7367 ))
([8187be1
](8187be1b7d
))
* **editor:** Support autologin for upgrade path
([#7316 ](https://github.com/n8n-io/n8n/issues/7316 ))
([1dfa052
](1dfa052301
))
* **Execute Workflow Node:** Run once for each item mode
([#7289 ](https://github.com/n8n-io/n8n/issues/7289 ))
([c8c14ca
](c8c14ca0af
))
* **Item Lists Node:** Split merge binary data
([#7297 ](https://github.com/n8n-io/n8n/issues/7297 ))
([965db8f
](965db8f7f2
))
* **Loop Over Items (Split in Batches) Node:** Automatically add a loop
+ rename ([#7228 ](https://github.com/n8n-io/n8n/issues/7228 ))
([7b773cc
](7b773cc5cc
))
* **Notion Node:** Fetch child blocks recursively
([#7304 ](https://github.com/n8n-io/n8n/issues/7304 ))
([193181a
](193181a9c6
))
Co-authored-by: netroy <netroy@users.noreply.github.com>
2023-10-11 13:38:34 +02:00
कारतोफ्फेलस्क्रिप्ट™
6479eb180f
fix(Webhook Node): Backward compatible form-data parsing for non-array files ( #7385 )
...
Fixes
https://community.n8n.io/t/possible-bug-0-added-to-end-of-files-sent-via-webhook/31169
2023-10-10 15:19:05 +02:00
Iván Ovejero
0847623f85
feat(core): Switch binary filesystem mode to nested path structure ( #7307 )
...
Depends on #7253 | Story:
[PAY-863](https://linear.app/n8n/issue/PAY-863/switch-binary-filesystem-mode-to-nested-path-structure )
This PR introduces `filesystem-v2` to store binary data in the
filesystem in the same format as `s3`.
2023-10-10 10:06:06 +02:00
कारतोफ्फेलस्क्रिप्ट™
c5ee06cc61
refactor(core): Refactor nodes loading (no-changelog) ( #7283 )
...
fixes PAY-605
2023-10-09 16:09:23 +02:00
कारतोफ्फेलस्क्रिप्ट™
789e1e7ed4
fix(core): Add an option to enable postgres ssl with default certs ( #6889 )
...
CP-809
2023-10-09 13:55:03 +02:00
Michael Auerswald
b8608cee6d
feat(core): Add Job Summary to Worker response ( #7360 )
2023-10-06 17:52:27 +02:00
Iván Ovejero
34bda535e6
refactor(core): Create controller for binary data (no-changelog) ( #7363 )
...
This PR adds a controller for binary data + integration tests.
2023-10-06 16:21:13 +02:00
Michael Auerswald
afa683a06f
refactor(core): Have one orchestration service per instance type ( #7303 )
...
webhook instances will not listen to either worker or event log messages
on the Redis pub/sub channel
2023-10-06 13:58:11 +02:00
Cornelius Suermann
f4d8c9eed5
feat: Improve error msg when attempting to redeem the same activation code multiple times (no-changelog) ( #7355 )
2023-10-05 17:08:30 +02:00
Iván Ovejero
1a661e6d00
feat(core): Integrate object store as binary data manager ( #7253 )
...
Depends on: #7225 | Story:
[PAY-848](https://linear.app/n8n/issue/PAY-848 )
This PR integrates the object store service as a new binary data manager
for Enterprise.
2023-10-05 15:25:17 +02:00
github-actions[bot]
aa1bf95136
🚀 Release 1.10.0 ( #7350 )
...
# [1.10.0](https://github.com/n8n-io/n8n/compare/n8n@1.9.0...n8n@1.10.0 )
(2023-10-05)
### Bug Fixes
* **Convert to/from binary data Node:** Rename 'Move Binary Data' to
'Convert to/from binary data'
([#7318 ](https://github.com/n8n-io/n8n/issues/7318 ))
([5e6c1d4
](5e6c1d4f4b
))
* **core:** Account for itemless case on restoring binary data ID
([#7305 ](https://github.com/n8n-io/n8n/issues/7305 ))
([1691223
](1691223789
))
* **core:** Fix pruning of non-finished executions
([#7333 ](https://github.com/n8n-io/n8n/issues/7333 ))
([1b4848a
](1b4848afcb
))
* **editor:** Disable email confirmation banner for trialing users
([#7340 ](https://github.com/n8n-io/n8n/issues/7340 ))
([6d3d178
](6d3d1789db
))
* **editor:** Display value of selected matching column in RMC
([#7298 ](https://github.com/n8n-io/n8n/issues/7298 ))
([3aac22b
](3aac22b4c1
))
* **editor:** Fix canvas endpoint snapping when dragging connection
([#7346 ](https://github.com/n8n-io/n8n/issues/7346 ))
([b59b908
](b59b9086d7
))
* **editor:** Fix disappearing NDV header in code nodes
([#7290 ](https://github.com/n8n-io/n8n/issues/7290 ))
([7ebf8f3
](7ebf8f327a
))
* **editor:** Fix RLC not loading when an expression can't resolve
([#7295 ](https://github.com/n8n-io/n8n/issues/7295 ))
([ddc26c2
](ddc26c21bd
))
* **editor:** Separate cloud endpoint calls
([#7312 ](https://github.com/n8n-io/n8n/issues/7312 ))
([04dfcd7
](04dfcd73be
))
* **Jira Software Node:** Get all users in dropdown/RLC
([#7322 ](https://github.com/n8n-io/n8n/issues/7322 ))
([3704760
](3704760724
)),
closes [#2670 ](https://github.com/n8n-io/n8n/issues/2670 )
* **Notion Node:** Rename Notion API Key to Internal Integration Token
([#7176 ](https://github.com/n8n-io/n8n/issues/7176 ))
([ec2aa38
](ec2aa3819c
))
* **Postgres Node:** Node requires comma-separated string even when
using a single parameter through an expression
([#7300 ](https://github.com/n8n-io/n8n/issues/7300 ))
([763d451
](763d4514fa
))
* **Set Node:** Do not stringify null and undefined
([#7313 ](https://github.com/n8n-io/n8n/issues/7313 ))
([f0a6687
](f0a66873b9
))
* **Typeform Trigger Node:** Change output format for TypeForm trigger
to object instead of array
([#7315 ](https://github.com/n8n-io/n8n/issues/7315 ))
([b3fc00e
](b3fc00e045
))
### Features
* **core:** Add "Sent by n8n" attribution
([#7183 ](https://github.com/n8n-io/n8n/issues/7183 ))
([8f9fe62
](8f9fe6269b
))
* **core:** Add support for building LLM applications
([#7235 ](https://github.com/n8n-io/n8n/issues/7235 ))
([00a4b8b
](00a4b8b0c6
)),
closes [#7246 ](https://github.com/n8n-io/n8n/issues/7246 )
[#7137 ](https://github.com/n8n-io/n8n/issues/7137 )
* Workflow History pruning and prune time settings
([#7343 ](https://github.com/n8n-io/n8n/issues/7343 ))
([0adc533
](0adc533719
))
Co-authored-by: krynble <krynble@users.noreply.github.com>
2023-10-05 14:12:37 +02:00
Omar Ajoue
5cfd87692f
refactor: Add log messages to debug worker init issues ( #7238 )
...
Github issue / Community forum post (link here to close automatically):
2023-10-05 13:37:25 +02:00
कारतोफ्फेलस्क्रिप्ट™
169175080a
ci: Fix WorkflowHistoryManager tests (no-changelog) ( #7356 )
...
[DB Tests](https://github.com/n8n-io/n8n/actions/runs/6418058186 )
2023-10-05 13:14:57 +02:00
Tomi Turtiainen
1b4848afcb
fix(core): Fix pruning of non-finished executions ( #7333 )
...
This fixes a bug in the pruning (soft-delete). The pruning was a bit too
aggressive, as it also pruned executions that weren't in an end state
yet. This only becomes an issue if there are long-running executions
(e.g. workflow with Wait node) or the prune parameters are set to keep
only a tiny number of executions.
2023-10-04 16:32:05 +03:00
Val
0adc533719
feat: Workflow History pruning and prune time settings ( #7343 )
...
Github issue / Community forum post (link here to close automatically):
2023-10-04 13:57:21 +01:00
कारतोफ्फेलस्क्रिप्ट™
101255d186
ci: Make builds release-channel aware. Add support for scheduled beta builds ( #7323 )
...
ADO-1121
---------
Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
2023-10-03 20:49:04 +02:00
कारतोफ्फेलस्क्रिप्ट™
00a4b8b0c6
feat(core): Add support for building LLM applications ( #7235 )
...
This extracts all core and editor changes from #7246 and #7137 , so that
we can get these changes merged first.
ADO-1120
[DB Tests](https://github.com/n8n-io/n8n/actions/runs/6379749011 )
[E2E Tests](https://github.com/n8n-io/n8n/actions/runs/6379751480 )
[Workflow Tests](https://github.com/n8n-io/n8n/actions/runs/6379752828 )
---------
Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
Co-authored-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Alex Grozav <alex@grozav.com>
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-10-02 17:33:43 +02:00
Iván Ovejero
1691223789
fix(core): Account for itemless case on restoring binary data ID ( #7305 )
...
https://linear.app/n8n/issue/PAY-862
2023-10-02 09:13:55 +02:00
Csaba Tuncsik
d1b6c7fd79
feat(editor): Workflow history [WIP]- create workflow history list component (no-changelog) ( #7186 )
...
Co-authored-by: Omar Ajoue <krynble@gmail.com>
2023-09-29 17:48:36 +02:00
Omar Ajoue
ec0379378e
feat(core): Add plan name to telemetry (no-changelog) ( #7296 )
...
Github issue / Community forum post (link here to close automatically):
2023-09-29 15:41:32 +02:00
कारतोफ्फेलस्क्रिप्ट™
6a1557bc50
Merge tag 'n8n@1.9.0'
2023-09-29 14:28:06 +02:00
कारतोफ्फेलस्क्रिप्ट™
f8406c04b1
ci: Fix typescript incremental builds (no-changelog) ( #7275 )
...
`tsBuildInfoFile` is supposed to be relative to `tsconfig` like `outDir`
is.
Because of this, we are currently saving the TS incremental build cache
for all packages in the same file. This is likely causing issues where
the built backend code sometimes does not accurately map to the current
source code.
This PR changes the incremental build setup to keep the cache in
individual `dist` folders, like it used to be up until a 2 months ago,
before https://github.com/n8n-io/n8n/pull/6816 .
2023-09-29 13:26:06 +02:00
github-actions[bot]
167124ceb8
🚀 Release 1.9.0 ( #7288 )
...
# [1.9.0](https://github.com/n8n-io/n8n/compare/n8n@1.8.0...n8n@1.9.0 )
(2023-09-28)
### Bug Fixes
* **Airtable Node:** Attachments field type fix
([#7227 ](https://github.com/n8n-io/n8n/issues/7227 ))
([2af967c
](2af967cf88
))
* **core:** Change WorkflowHistory nodes/connections columns to be json
([#7282 ](https://github.com/n8n-io/n8n/issues/7282 ))
([a80abad
](a80abad3af
))
* **core:** Fix binary data manager check on pruning
([#7251 ](https://github.com/n8n-io/n8n/issues/7251 ))
([484035e
](484035eb51
))
* **core:** Fix missing execution ID in webhook-based workflow producing
binary data ([#7244 ](https://github.com/n8n-io/n8n/issues/7244 ))
([33991e9
](33991e92d0
))
* **core:** Handle filename* with quotes in Content-Disposition header
([#7229 ](https://github.com/n8n-io/n8n/issues/7229 ))
([67b985f
](67b985fe89
))
* **core:** Make DNS resolution order configurable
([#7272 ](https://github.com/n8n-io/n8n/issues/7272 ))
([5b3121c
](5b3121c415
))
* **core:** Make senderId required for all command messages
([#7252 ](https://github.com/n8n-io/n8n/issues/7252 ))
([4b01428
](4b014286cf
))
* **core:** Prevent executions from displaying Running status
incorrectly ([#7261 ](https://github.com/n8n-io/n8n/issues/7261 ))
([861cac5
](861cac5257
))
* **core:** Use consistent timezone-aware timestamps in postgres
([#6948 ](https://github.com/n8n-io/n8n/issues/6948 ))
([0132514
](0132514f8b
)),
closes [#2178 ](https://github.com/n8n-io/n8n/issues/2178 )
[#2810 ](https://github.com/n8n-io/n8n/issues/2810 )
[#3855 ](https://github.com/n8n-io/n8n/issues/3855 )
[#2813 ](https://github.com/n8n-io/n8n/issues/2813 )
* **editor:** Add debug feature docs link
([#7240 ](https://github.com/n8n-io/n8n/issues/7240 ))
([4614e1e
](4614e1e1c9
))
* **editor:** Fix SQL editor issue
([#7236 ](https://github.com/n8n-io/n8n/issues/7236 ))
([647fc6c
](647fc6c555
))
* **editor:** Ensure new Set node is on top of search list
([#7215 ](https://github.com/n8n-io/n8n/issues/7215 ))
([2491ccf
](2491ccf4d9
))
* **editor:** Forbid password reset when cloud account is limited in the
number of users [7188](https://github.com/n8n-io/n8n/issues/7188 )
([303bc8e
](303bc8e71e
))
* **HTTP Request Node:** Add suggestion how to fix '429 - too many
requests' errors ([#7293 ](https://github.com/n8n-io/n8n/issues/7293 ))
([0bc33b1
](0bc33b1cc2
))
* **Item Lists Node:** Concatenate operation pairedItems fix
([#7286 ](https://github.com/n8n-io/n8n/issues/7286 ))
([cde23a1
](cde23a1bb1
))
* **Respond to Webhook Node:** JSON output from expression fix
([#7294 ](https://github.com/n8n-io/n8n/issues/7294 ))
([8bc369d
](8bc369dd40
))
### Features
* Add onboarding flow
([#7212 ](https://github.com/n8n-io/n8n/issues/7212 ))
([01e9340
](01e9340621
))
* **core:** Add secrets provider reload and refactor
([#7277 ](https://github.com/n8n-io/n8n/issues/7277 ))
([53a7502
](53a7502d20
))
* **core:** Add Tournament as the new default expression evaluator
([#6964 ](https://github.com/n8n-io/n8n/issues/6964 ))
([bf74f09
](bf74f09d69
))
* **core:** Initial workflow history API
([#7234 ](https://github.com/n8n-io/n8n/issues/7234 ))
([0083a9e
](0083a9e45d
))
* **core:** Introduce object store service
([#7225 ](https://github.com/n8n-io/n8n/issues/7225 ))
([fa84545
](fa845453bb
))
* **editor:** Add user cloud ID to telemetry
[#7232 ](https://github.com/n8n-io/n8n/issues/7232 )
([60c152d
](60c152dc72
))
* **editor:** Rework banners framework and add email confirmation banner
([#7205 ](https://github.com/n8n-io/n8n/issues/7205 ))
([b0e98b5
](b0e98b59a6
))
* **MISP Node:** Update credential to support HTTP Request node
([#7268 ](https://github.com/n8n-io/n8n/issues/7268 ))
([e4c302c
](e4c302c683
))
### Performance Improvements
* **core:** Skip unneeded calls on every pruning cycle
([#7260 ](https://github.com/n8n-io/n8n/issues/7260 ))
([db01164
](db01164ce1
))
Co-authored-by: netroy <netroy@users.noreply.github.com>
2023-09-28 17:22:28 +02:00
कारतोफ्फेलस्क्रिप्ट™
cf5a0ca456
ci: Refactor DB tests (no-changelog) ( #7292 )
...
[DB tests](https://github.com/n8n-io/n8n/actions/runs/6340094467 )
2023-09-28 16:53:05 +02:00
Michael Auerswald
53a7502d20
feat(core): Add secrets provider reload and refactor ( #7277 )
...
This PR adds a message for queue mode which triggers an external secrets
provider reload inside the workers if the configuration has changed on
the main instance.
It also refactors some of the message handler code to remove cyclic
dependencies, as well as remove unnecessary duplicate redis clients
inside services (thanks to no more cyclic deps)
2023-09-28 12:57:35 +02:00
Val
a80abad3af
fix(core): Change WorkflowHistory nodes/connections columns to be json ( #7282 )
...
Github issue / Community forum post (link here to close automatically):
2023-09-28 10:37:33 +02:00
कारतोफ्फेलस्क्रिप्ट™
0132514f8b
fix(core): Use consistent timezone-aware timestamps in postgres ( #6948 )
...
Fixes:
* ENG-51 / N8N-2490
* PAY-397
* #2178
* #2810
* #3855
Supersedes #2813
[DB
Tests](https://github.com/n8n-io/n8n/actions/runs/6000780146/job/16273596338 )
2023-09-27 18:44:47 +02:00
कारतोफ्फेलस्क्रिप्ट™
ebce6fe1b0
refactor(core): Skip sending webhook activation errors to Sentry (no-changelog) ( #7171 )
2023-09-27 16:57:52 +02:00
Michael Auerswald
07d072c28f
fix(core): Bump License SDK Version (no-changelog) ( #7279 )
2023-09-27 16:29:09 +02:00
Val
0083a9e45d
feat(core): Initial workflow history API ( #7234 )
...
Github issue / Community forum post (link here to close automatically):
2023-09-27 15:22:39 +01:00
कारतोफ्फेलस्क्रिप्ट™
5b3121c415
fix(core): Make DNS resolution order configurable ( #7272 )
2023-09-27 12:19:18 +02:00
Michael Auerswald
6d7fe95c58
fix(core): Do not set ttl globally in test (no-changelog) ( #7271 )
2023-09-27 12:03:15 +02:00
Iván Ovejero
fa845453bb
feat(core): Introduce object store service ( #7225 )
...
Depends on https://github.com/n8n-io/n8n/pull/7220 | Story:
[PAY-840](https://linear.app/n8n/issue/PAY-840/introduce-object-store-service-and-manager-for-binary-data )
This PR introduces an object store service for Enterprise edition. Note
that the service is tested but currently unused - it will be integrated
soon as a binary data manager, and later for execution data.
`amazonaws.com` in the host is temporarily hardcoded until we integrate
the service and test against AWS, Cloudflare and Backblaze, in the next
PR.
This is ready for review - the PR it depends on is approved and waiting
for CI.
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-09-27 09:42:35 +02:00
Iván Ovejero
db01164ce1
perf(core): Skip unneeded calls on every pruning cycle ( #7260 )
2023-09-26 16:53:38 +02:00
Michael Auerswald
4b014286cf
fix(core): Make senderId required for all command messages ( #7252 )
...
all commands sent between main instance and workers need to contain a
server id to prevent senders from reacting to their own messages,
causing loops
this PR makes sure all sent messages contain a sender id by default as
part of constructing a sending redis client.
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-09-26 13:58:06 +02:00
Iván Ovejero
77d6e3fc07
refactor(core): Include workflow ID in binary data writes (no-changelog) ( #7220 )
...
Depends on: https://github.com/n8n-io/n8n/pull/7195 | Story:
[PAY-837](https://linear.app/n8n/issue/PAY-837/implement-object-store-manager-for-binary-data )
This PR includes `workflowId` in binary data writes so that the S3
manager can support this filepath structure
`/workflows/{workflowId}/executions/{executionId}/binaryData/{binaryFilename}`
to easily delete binary data for workflows. Also all binary data service
and manager methods that take `workflowId` and `executionId` are made
consistent in arg order.
Note: `workflowId` is included in filesystem mode for compatibility with
the common interface, but `workflowId` will remain unused by filesystem
mode until we decide to restructure how this mode stores data.
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-09-25 18:04:52 +02:00
Iván Ovejero
75541e91f2
refactor(core)!: Make getBinaryStream
async ( #7247 )
...
Story: [PAY-846](https://linear.app/n8n/issue/PAY-846 ) | Related:
https://github.com/n8n-io/n8n/pull/7225
For the S3 backend for external storage of binary data and execution
data, the `getAsStream` method in the binary data manager interface used
by FS and S3 will need to become async. This is a breaking change for
nodes-base.
2023-09-25 16:59:45 +02:00
Ricardo Espinoza
d47986aec3
fix: Bug when trailing user reset password on instance (no-changelog) ( #7250 )
...
Github issue / Community forum post (link here to close automatically):
2023-09-25 09:55:33 -04:00
Mutasem Aldmour
01e9340621
feat: Add onboarding flow ( #7212 )
...
Github issue / Community forum post (link here to close automatically):
2023-09-25 15:49:36 +02:00
Iván Ovejero
33991e92d0
fix(core): Fix missing execution ID in webhook-based workflow producing binary data ( #7244 )
...
Story: https://linear.app/n8n/issue/PAY-839
This is a longstanding bug, fixed now so that the S3 backend for binary
data can use execution IDs as part of the filename.
To reproduce:
1. Set up a workflow with a POST Webhook node that accepts binary data.
2. Activate the workflow and call it sending a binary file, e.g. `curl
-X POST -F "file=@/path/to/binary/file/test.jpg"
http://localhost:5678/webhook/uuid `
3. Check `~/.n8n/binaryData`. The binary data and metadata files will be
missing the execution ID, e.g. `11869055-83c4-4493-876a-9092c4708b9b`
instead of `39011869055-83c4-4493-876a-9092c4708b9b`.
2023-09-25 12:30:28 +02:00
Iván Ovejero
6d6e2488c6
refactor(core): Generalize binary data manager interface (no-changelog) ( #7164 )
...
Depends on: #7092 | Story:
[PAY-768](https://linear.app/n8n/issue/PAY-768 )
This PR:
- Generalizes the `IBinaryDataManager` interface.
- Adjusts `Filesystem.ts` to satisfy the interface.
- Sets up an S3 client stub to be filled in in the next PR.
- Turns `BinaryDataManager` into an injectable service.
- Adjusts the config schema and adds new validators.
Note that the PR looks large but all the main changes are in
`packages/core/src/binaryData`.
Out of scope:
- `BinaryDataManager` (now `BinaryDataService`) and `Filesystem.ts` (now
`fs.client.ts`) were slightly refactored for maintainability, but fully
overhauling them is **not** the focus of this PR, which is meant to
clear the way for the S3 implementation. Future improvements for these
two should include setting up a backwards-compatible dir structure that
makes it easier to locate binary data files to delete, removing
duplication, simplifying cloning methods, using integers for binary data
size instead of `prettyBytes()`, writing tests for existing binary data
logic, etc.
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-09-22 17:22:12 +02:00
Val
bf74f09d69
feat(core): Add Tournament as the new default expression evaluator ( #6964 )
...
Github issue / Community forum post (link here to close automatically):
---------
Co-authored-by: Omar Ajoue <krynble@gmail.com>
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-09-21 13:57:45 +01:00
Ricardo Espinoza
303bc8e71e
fix: Issue enforcing user limits on start plan ( #7188 )
2023-09-21 05:56:40 -04:00
कारतोफ्फेलस्क्रिप्ट™
8bb22292d5
Merge tag 'n8n@1.8.0'
2023-09-20 16:20:34 +02:00
Iván Ovejero
cd08c8e4c6
refactor(core): Implement soft-deletions for executions ( #7092 )
...
Based on #7065 | Story: https://linear.app/n8n/issue/PAY-771
n8n on filesystem mode marks binary data to delete on manual execution
deletion, on unsaved execution completion, and on every execution
pruning cycle. We later prune binary data in a separate cycle via these
marker files, based on the configured TTL. In the context of introducing
an S3 client to manage binary data, the filesystem mode's mark-and-prune
setup is too tightly coupled to the general binary data management
client interface.
This PR...
- Ensures the deletion of an execution causes the deletion of any binary
data associated to it. This does away with the need for binary data TTL
and simplifies the filesystem mode's mark-and-prune setup.
- Refactors all execution deletions (including pruning) to cause soft
deletions, hard-deletes soft-deleted executions based on the existing
pruning config, and adjusts execution endpoints to filter out
soft-deleted executions. This reduces DB load, and keeps binary data
around long enough for users to access it when building workflows with
unsaved executions.
- Moves all execution pruning work from an execution lifecycle hook to
`execution.repository.ts`. This keeps related logic in a single place.
- Removes all marking logic from the binary data manager. This
simplifies the interface that the S3 client will meet.
- Adds basic sanity-check tests to pruning logic and execution deletion.
Out of scope:
- Improving existing pruning logic.
- Improving existing execution repository logic.
- Adjusting dir structure for filesystem mode.
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-09-20 15:21:42 +02:00
github-actions[bot]
ecd5d93c19
🚀 Release 1.8.0 ( #7219 )
...
# [1.8.0](https://github.com/n8n-io/n8n/compare/n8n@1.7.0...n8n@1.8.0 )
(2023-09-20)
### Bug Fixes
* **core:** Make parsing of content-type and content-disposition headers
more flexible ([#7217 ](https://github.com/n8n-io/n8n/issues/7217 ))
([d41546b
](d41546b899
)),
closes [#7149 ](https://github.com/n8n-io/n8n/issues/7149 )
* **core:** Resolve domains to IPv4 first
([#7206 ](https://github.com/n8n-io/n8n/issues/7206 ))
([e9ce531
](e9ce531210
))
* **editor:** Add ssh key type selection to source control settings when
regenerating key ([#7172 ](https://github.com/n8n-io/n8n/issues/7172 ))
([54bf66d
](54bf66d335
))
* **editor:** No need to add click emitting click events, VUE delegates
the handler to the root element of the component
([#7182 ](https://github.com/n8n-io/n8n/issues/7182 ))
([3c055e4
](3c055e4d8d
))
* **editor:** Prevent duplicate creation of credential for OAuth2
([#7163 ](https://github.com/n8n-io/n8n/issues/7163 ))
([07a6417
](07a6417f0f
))
* **editor:** Testing flaky resource mapper feature in e2e tests
([#7165 ](https://github.com/n8n-io/n8n/issues/7165 ))
([aaf87c3
](aaf87c3edd
))
* **HTML Node:** Add pairedItem support for 'Convert to HTML Table'
operation ([#7196 ](https://github.com/n8n-io/n8n/issues/7196 ))
([6bc477b
](6bc477b50e
))
* **HTTP Request Node:** Decrease default timeout to 5min
([#7177 ](https://github.com/n8n-io/n8n/issues/7177 ))
([321780d
](321780d4a2
))
* **seven Node:** Rename sms77 to seven, fix credentials test
([#7180 ](https://github.com/n8n-io/n8n/issues/7180 ))
([cf776b8
](cf776b8f17
))
* **X (Formerly Twitter) Node:** Rename Twitter to X (keep Twitter
alias) ([#7179 ](https://github.com/n8n-io/n8n/issues/7179 ))
([d317e09
](d317e09c59
))
### Features
* **core:** Add command to trigger license refresh on workers
([#7184 ](https://github.com/n8n-io/n8n/issues/7184 ))
([9f797b9
](9f797b96d8
))
* **core:** Add rsa option to ssh key generation
([#7154 ](https://github.com/n8n-io/n8n/issues/7154 ))
([fdac2c8
](fdac2c8572
))
* **Linear Node:** Add support for OAuth2
([#7201 ](https://github.com/n8n-io/n8n/issues/7201 ))
([12a3168
](12a3168367
))
* **Microsoft Outlook Node:** Node overhaul
([#4449 ](https://github.com/n8n-io/n8n/issues/4449 ))
([556a613
](556a6132ba
))
* **Set Node:** Overhaul
([#6348 ](https://github.com/n8n-io/n8n/issues/6348 ))
([3a47455
](3a474552b2
))
Co-authored-by: krynble <krynble@users.noreply.github.com>
2023-09-20 15:10:20 +02:00
कारतोफ्फेलस्क्रिप्ट™
e9ce531210
fix(core): Resolve domains to IPv4 first ( #7206 )
2023-09-19 15:56:38 +02:00
Iván Ovejero
28598ed1a7
ci: Fix tests failing on MySQL (no-changelog) ( #7208 )
...
https://github.com/n8n-io/n8n/actions/runs/6229338666/job/16907667212
2023-09-19 15:42:39 +02:00
Cornelius Suermann
050ba706d3
fix: Attempt license renewal when n8n starts (no-changelog) ( #7204 )
...
This change is needed so that the newly introduced floating licenses
will be attempted to be claimed when n8n starts up.
2023-09-19 12:10:23 +02:00
Michael Auerswald
9f797b96d8
feat(core): Add command to trigger license refresh on workers ( #7184 )
...
This PR implements the updated license SDK so that worker and webhook
instances do not auto-renew licenses any more.
Instead, they receive a `reloadLicense` command via the Redis client
that will fetch the updated license after it was saved on the main
instance
This also contains some refactoring with moving redis sub and pub
clients into the event bus directly, to prevent cyclic dependency
issues.
2023-09-17 11:05:54 +02:00
Csaba Tuncsik
240b2f075e
feat(editor): Add Workflow history route and base page (no-changelog) ( #7161 )
2023-09-15 13:17:04 +02:00
Michael Auerswald
fdac2c8572
feat(core): Add rsa option to ssh key generation ( #7154 )
...
PR adds a new field to the SourceControlPreferences as well as to the
POST parameters for the `source-control/preferences` and
`source-control/generate-key-pair` endpoints. Both now accept an
optional string parameter `keyGeneratorType` of `'ed25519' | 'rsa'`
Calling the `source-control/generate-key-pair` endpoint with the
parameter set, it will also update the stored preferences accordingly
(so that in the future new keys will use the same method)
By default ed25519 is being used. The default may be changed using a new
environment parameter:
`N8N_SOURCECONTROL_DEFAULT_SSH_KEY_TYPE` which can be `rsa` or `ed25519`
RSA keys are generated with a length of 4096 bytes.
2023-09-14 11:34:51 +02:00
Michael Auerswald
0c6169ee22
refactor(core): Move event and telemetry handling into workers in queue mode ( #7138 )
...
# Motivation
In Queue mode, finished executions would cause the main instance to
always pull all execution data from the database, unflatten it and then
use it to send out event log events and telemetry events, as well as
required returns to Respond to Webhook nodes etc.
This could cause OOM errors when the data was large, since it had to be
fully unpacked and transformed on the main instance’s side, using up a
lot of memory (and time).
This PR attempts to limit this behaviour to only happen in those
required cases where the data has to be forwarded to some waiting
webhook, for example.
# Changes
Execution data is only required in cases, where the active execution has
a `postExecutePromise` attached to it. These usually forward the data to
some other endpoint (e.g. a listening webhook connection).
By adding a helper `getPostExecutePromiseCount()`, we can decide that in
cases where there is nothing listening at all, there is no reason to
pull the data on the main instance.
Previously, there would always be postExecutePromises because the
telemetry events were called. Now, these have been moved into the
workers, which have been given the various InternalHooks calls to their
hook function arrays, so they themselves issue these telemetry and event
calls.
This results in all event log messages to now be logged on the worker’s
event log, as well as the worker’s eventbus being the one to send out
the events to destinations. The main event log does…pretty much nothing.
We are not logging executions on the main event log any more, because
this would require all events to be replicated 1:1 from the workers to
the main instance(s) (this IS possible and implemented, see the worker’s
`replicateToRedisEventLogFunction` - but it is not enabled to reduce the
amount of traffic over redis).
Partial events in the main log could confuse the recovery process and
would result in, ironically, the recovery corrupting the execution data
by considering them crashed.
# Refactor
I have also used the opportunity to reduce duplicate code and move some
of the hook functionality into
`packages/cli/src/executionLifecycleHooks/shared/sharedHookFunctions.ts`
in preparation for a future full refactor of the hooks
2023-09-14 07:58:15 +02:00
github-actions[bot]
a6e027b3ff
🚀 Release 1.7.0 ( #7162 )
...
# [1.7.0](https://github.com/n8n-io/n8n/compare/n8n@1.6.0...n8n@1.7.0 )
(2023-09-13)
### Bug Fixes
* **Code Node:** Disable WASM to address CVE-2023-37903
([#7122 ](https://github.com/n8n-io/n8n/issues/7122 ))
([36a8e91
](36a8e911e6
))
* **Code Node:** Upgrade vm2 to address CVE-2023-37466
([#7123 ](https://github.com/n8n-io/n8n/issues/7123 ))
([0a35025
](0a35025e5e
))
* **core:** Disable Node.js custom inspection to address CVE-2023-37903
([#7125 ](https://github.com/n8n-io/n8n/issues/7125 ))
([a223734
](a223734a4a
))
* **editor** Account for nanoid workflow ids for subworkflow execute
policy ([#7094 ](https://github.com/n8n-io/n8n/issues/7094 ))
([67092c0
](67092c0a1b
))
* **editor:** Tweak hover area of workflow / cred cards
([#7108 ](https://github.com/n8n-io/n8n/issues/7108 ))
([217de21
](217de21605
))
* **editor:** Unbind workflow endpoint events in case of workspace reset
([#7129 ](https://github.com/n8n-io/n8n/issues/7129 ))
([c9b7948
](c9b79485cf
))
* **editor:** Update git repo url validation regex
([#7151 ](https://github.com/n8n-io/n8n/issues/7151 ))
([e51f173
](e51f173608
))
* **Google Cloud Firestore Node:** Fix empty string interpreted as
number ([#7136 ](https://github.com/n8n-io/n8n/issues/7136 ))
([915cfa0
](915cfa0f6a
))
* **HubSpot Node:** Fix issue with contact lists not working
([#5582 ](https://github.com/n8n-io/n8n/issues/5582 ))
([6e5a4f6
](6e5a4f6a58
))
* **Postgres Node:** Fix automatic column mapping
([#7121 ](https://github.com/n8n-io/n8n/issues/7121 ))
([92af131
](92af1314fe
))
* **Zoho CRM Node:** Fix issue with Sales Order not updating
([#6959 ](https://github.com/n8n-io/n8n/issues/6959 ))
([fd800b6
](fd800b674b
))
### Features
* **core:** Add an option to enable WAL mode for SQLite
([#7118 ](https://github.com/n8n-io/n8n/issues/7118 ))
([1d1a022
](1d1a022def
))
* **core:** Add commands to workers to respond with current state
([#7029 ](https://github.com/n8n-io/n8n/issues/7029 ))
([7b49cf2
](7b49cf2a2c
))
* **Salesforce Node:** Add fax field to lead option
([#7030 ](https://github.com/n8n-io/n8n/issues/7030 ))
([01f875a
](01f875a94d
))
Co-authored-by: netroy <netroy@users.noreply.github.com>
2023-09-13 14:55:52 +02:00
कारतोफ्फेलस्क्रिप्ट™
34ebffea45
refactor(core): Move workerCommandHandler into worker.ts (no-changelog) ( #7160 )
2023-09-13 14:51:41 +02:00
कारतोफ्फेलस्क्रिप्ट™
22edc03cab
fix(core): Ignore missing user-agent on bot check (no-changelog) ( #7153 )
2023-09-12 19:57:25 +02:00
कारतोफ्फेलस्क्रिप्ट™
1d1a022def
feat(core): Add an option to enable WAL mode for SQLite ( #7118 )
...
https://www.sqlite.org/wal.html
2023-09-07 15:58:48 +02:00
Michael Auerswald
7b49cf2a2c
feat(core): Add commands to workers to respond with current state ( #7029 )
...
This PR adds new endpoints to the REST API:
`/orchestration/worker/status` and `/orchestration/worker/id`
Currently these just trigger the return of status / ids from the workers
via the redis back channel, this still needs to be handled and passed
through to the frontend.
It also adds the eventbus to each worker, and triggers a reload of those
eventbus instances when the configuration changes on the main instances.
2023-09-07 14:44:19 +02:00
कारतोफ्फेलस्क्रिप्ट™
a223734a4a
fix(core): Disable Node.js custom inspection to address CVE-2023-37903 ( #7125 )
...
This seems like a better fix than #7122
2023-09-07 10:25:59 +02:00
github-actions[bot]
955bd327ff
🚀 Release 1.6.0 ( #7120 )
...
# [1.6.0](https://github.com/n8n-io/n8n/compare/n8n@1.5.1...n8n@1.6.0 )
(2023-09-06)
### Bug Fixes
* **core:** Add support for in-transit encryption (TLS) on Redis
connections ([#7047 ](https://github.com/n8n-io/n8n/issues/7047 ))
([a910757
](a910757cc5
))
* **core:** Disallow orphan executions
([#7069 ](https://github.com/n8n-io/n8n/issues/7069 ))
([8a28e98
](8a28e98ec8
))
* **core:** Split event bus controller into community and ee
([#7107 ](https://github.com/n8n-io/n8n/issues/7107 ))
([011ee2e
](011ee2e04b
))
* **editor:** Standardize save text
([#7093 ](https://github.com/n8n-io/n8n/issues/7093 ))
([58b3492
](58b3492b0d
))
* Ensure all new executions are saved
([#7061 ](https://github.com/n8n-io/n8n/issues/7061 ))
([b8e06d2
](b8e06d245f
))
* Load remote resources even if expressions in non requried parameters
resolve ([#6987 ](https://github.com/n8n-io/n8n/issues/6987 ))
([8a8d4e8
](8a8d4e8bb3
))
* **Postgres Node:** Connection pool of the database object has been
destroyed ([#7074 ](https://github.com/n8n-io/n8n/issues/7074 ))
([9dd5f0e
](9dd5f0e579
))
* **Postgres Node:** Tunnel doesn't always close
([#7087 ](https://github.com/n8n-io/n8n/issues/7087 ))
([58e55ba
](58e55ba669
))
### Features
* **core:** Add list query middleware to credentials
([#7041 ](https://github.com/n8n-io/n8n/issues/7041 ))
([fd78021
](fd78021b68
))
* **core:** Add support for floating licenses
([#7090 ](https://github.com/n8n-io/n8n/issues/7090 ))
([e26553f
](e26553f198
))
* **core:** Migration for soft deletions for executions
([#7088 ](https://github.com/n8n-io/n8n/issues/7088 ))
([413e0bc
](413e0bccb4
))
* **HTTP Request Node:** Determine binary file name from
content-disposition headers
([#7032 ](https://github.com/n8n-io/n8n/issues/7032 ))
([273d091
](273d0913fe
))
* **TheHive Node:** Overhaul
([#6457 ](https://github.com/n8n-io/n8n/issues/6457 ))
([73e782e
](73e782e2cf
))
Co-authored-by: netroy <netroy@users.noreply.github.com>
2023-09-06 13:35:31 +02:00
कारतोफ्फेलस्क्रिप्ट™
273d0913fe
feat(HTTP Request Node): Determine binary file name from content-disposition headers ( #7032 )
...
Fixes:
https://community.n8n.io/t/http-request-node-read-filename-from-content-disposition-header-when-downloading-files/13453
https://community.n8n.io/t/read-filename-from-content-disposition-header-when-downloading-files/22192
2023-09-06 12:38:37 +02:00
Omar Ajoue
25dc4d7825
feat: Add workflow history repository files (no-changelog) ( #7071 )
2023-09-06 12:23:40 +02:00
कारतोफ्फेलस्क्रिप्ट™
2f647974f4
refactor: Use actual nodes/credentials in cli and core tests (no-changelog) ( #7115 )
2023-09-06 10:23:47 +02:00
कारतोफ्फेलस्क्रिप्ट™
a910757cc5
fix(core): Add support for in-transit encryption (TLS) on Redis connections ( #7047 )
...
Fixes https://community.n8n.io/t/upgrade-from-1-1-1-to-1-2-0/30148
2023-09-05 18:18:50 +02:00
कारतोफ्फेलस्क्रिप्ट™
cc37a5046a
fix(core): Lazy-load express-openapi-validator to reduce initial memory spike (no-changelog) ( #7111 )
2023-09-05 14:42:14 +02:00
कारतोफ्फेलस्क्रिप्ट™
36f246929e
ci: Fix linting (no-changelog) ( #7110 )
2023-09-05 14:41:56 +02:00
Iván Ovejero
0036a4726c
refactor(core): Move static data handling to workflow service (no-changelog) ( #7104 )
2023-09-05 13:42:31 +02:00
Michael Auerswald
011ee2e04b
fix(core): Split event bus controller into community and ee ( #7107 )
2023-09-05 13:32:09 +02:00
कारतोफ्फेलस्क्रिप्ट™
6aa7b93473
refactor(core): Deprecate prepareOutputData
(no-changelog) ( #7091 )
2023-09-05 12:59:02 +02:00