Elias Meire
939e471ed1
fix(editor): Fix collection select label (no-changelog) ( #7978 )
...
## Summary
before & after
<img width="575" alt="image"
src="https://github.com/n8n-io/n8n/assets/8850410/e7d5ecd5-427e-4664-897f-5a42e68e3661 ">
#### How to test the change:
1. Add Pipedrive > Create Deal
2. Click on "Add Field" under "Additional Fields"
3. Options should be properly displayed (Title case)
## Issues fixed
https://linear.app/n8n/issue/NODE-977
## Review / Merge checklist
- [ ] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again. A feature is not complete without tests.
>
> *(internal)* You can use Slack commands to trigger [e2e
tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227 )
or [deploy test
instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce )
or [deploy early access version on
Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e ).
2023-12-11 09:50:21 +01:00
Iván Ovejero
76ab411bc0
refactor(core): Instrument multi-main to report failures to renew lease ( #7970 )
...
## Summary
Instrument multi-main to report failures to renew the lease
https://linear.app/n8n/issue/PAY-1105
...
#### How to test the change:
1. ...
## Issues fixed
Include links to Github issue or Community forum post or **Linear
ticket**:
> Important in order to close automatically and provide context to
reviewers
...
## Review / Merge checklist
- [ ] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again. A feature is not complete without tests.
>
> *(internal)* You can use Slack commands to trigger [e2e
tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227 )
or [deploy test
instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce )
or [deploy early access version on
Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e ).
2023-12-11 09:45:08 +01:00
Iván Ovejero
148bc1d303
fix(editor): Add missing string for worker in log streaming ( #7971 )
...
## Summary
Add missing string for worker in log streaming
Before: https://share.cleanshot.com/bN9ydg7N
After: https://share.cleanshot.com/sFLnFMJK
...
#### How to test the change:
1. ...
## Issues fixed
Include links to Github issue or Community forum post or **Linear
ticket**:
> Important in order to close automatically and provide context to
reviewers
...
## Review / Merge checklist
- [ ] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again. A feature is not complete without tests.
>
> *(internal)* You can use Slack commands to trigger [e2e
tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227 )
or [deploy test
instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce )
or [deploy early access version on
Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e ).
2023-12-11 09:44:58 +01:00
Iván Ovejero
29a10668d1
fix(Google Sheets Node): Prevent erroring when fetching mapping columns ( #7972 )
...
## Summary
https://n8nio.sentry.io/issues/4709551520
Follow-up to: https://github.com/n8n-io/n8n/pull/7957
...
#### How to test the change:
1. ...
## Issues fixed
Include links to Github issue or Community forum post or **Linear
ticket**:
> Important in order to close automatically and provide context to
reviewers
...
## Review / Merge checklist
- [ ] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again. A feature is not complete without tests.
>
> *(internal)* You can use Slack commands to trigger [e2e
tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227 )
or [deploy test
instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce )
or [deploy early access version on
Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e ).
2023-12-08 17:25:42 +01:00
oleg
35fbc37c8e
refactor(editor): Refactor nodeHelpers mixin to composable ( #7810 )
...
- Convert `nodeHelpers` mixin into composable and fix types
- Replace usage of the mixin with the new composable
- Add missing store imports in components that were dependent on opaque
imports from nodeHelpers mixin
- Refactor the `CollectionParameter` component to the modern script
setup syntax
Github issue / Community forum post (link here to close automatically):
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
2023-12-08 16:59:03 +01:00
Csaba Tuncsik
e8a493f718
fix(editor): Prevent opening NDV search if / is typed in a contenteditable element ( #7968 )
...
## Summary
Prevent opening NDV search if `/` is typed in a contenteditable element
...
#### How to test the change:
1. Create a workflow with a Code node that has some input and output
2. Run the workflow and then open the Code node
3. Type `/` anywhere in the Code node
#### Expected behavior:
NDV search should not be opened and focused
2023-12-08 16:16:05 +01:00
Jon
7f0126915a
feat(Google Ads Node): Update to support v15 ( #7962 )
...
Updates Google Ads node to use the v15 API for
https://community.n8n.io/t/google-ads-400-bad-request-error/21709/26
2023-12-08 14:41:49 +00:00
Iván Ovejero
1a87f70e84
fix(core): Perform multi-main leader check against key ID ( #7964 )
...
## Summary
Current leader check is based on key presence and multi-main instance
type, which can give rise to [this edge
case](https://n8nio.slack.com/archives/C04B1GZ4T0U/p1702025497086379?thread_ts=1701962808.817579&cid=C04B1GZ4T0U )
where leader fails to realize they lost leadership to a former follower.
PR performs the check against the specific key ID instead to prevent
this.
...
#### How to test the change:
1. ...
## Issues fixed
Include links to Github issue or Community forum post or **Linear
ticket**:
> Important in order to close automatically and provide context to
reviewers
...
## Review / Merge checklist
- [ ] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again. A feature is not complete without tests.
>
> *(internal)* You can use Slack commands to trigger [e2e
tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227 )
or [deploy test
instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce )
or [deploy early access version on
Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e ).
2023-12-08 13:55:55 +01:00
Iván Ovejero
94582552f6
ci: Fix lint in nodes-base to fix build (no-changelog) ( #7966 )
...
## Summary
We recently merged the `no-plain-errors` rule and one instance seems to
have slipped through.
Ref: https://github.com/n8n-io/n8n/pull/7961
...
#### How to test the change:
1. ...
## Issues fixed
Include links to Github issue or Community forum post or **Linear
ticket**:
> Important in order to close automatically and provide context to
reviewers
...
## Review / Merge checklist
- [ ] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again. A feature is not complete without tests.
>
> *(internal)* You can use Slack commands to trigger [e2e
tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227 )
or [deploy test
instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce )
or [deploy early access version on
Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e ).
2023-12-08 13:43:10 +01:00
Csaba Tuncsik
5b2defc867
fix(editor): Return early in ws message handler if no 'command' keyword is found ( #7946 )
...
## Summary
Avoid processing websocket messages not n8n sent (filter on 'command'
keyword)
2023-12-08 13:42:50 +01:00
oleg
dcf12867b3
feat: AI nodes usability fixes + Summarization Chain V2 ( #7949 )
...
Fixes:
- Refactor connection snapping when dragging and enable it also for
non-main connection types
- Fix propagation of errors from sub-nodes
- Fix chat scrolling when sending/receiving messages
- Prevent empty chat messages
- Fix sub-node selected styles
- Fix output names text overflow
Usability improvements:
- Auto-add manual chat trigger for agents & chain nodes
- Various labels and description updates
- Make the output parser input optional for Basic LLM Chain
- Summarization Chain V2 with a simplified document loader & text
chunking mode
#### How to test the change:
Example workflow showcasing different operation mode of the new
summarization chain:
[Summarization_V2.json](https://github.com/n8n-io/n8n/files/13599901/Summarization_V2.json )
## Issues fixed
Include links to Github issue or Community forum post or **Linear
ticket**:
> Important in order to close automatically and provide context to
reviewers
-
https://www.notion.so/n8n/David-Langchain-Posthog-notes-7a9294938420403095f4508f1a21d31d
- https://linear.app/n8n/issue/N8N-7070/ux-fixes-batch
- https://linear.app/n8n/issue/N8N-7071/ai-sub-node-bugs
## Review / Merge checklist
- [x] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [x] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again. A feature is not complete without tests.
>
> *(internal)* You can use Slack commands to trigger [e2e
tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227 )
or [deploy test
instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce )
or [deploy early access version on
Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e ).
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Elias Meire <elias@meire.dev>
2023-12-08 13:42:32 +01:00
Csaba Tuncsik
dbd62a4992
feat: Introduce advanced permissions ( #7844 )
...
This PR introduces the possibility of inviting new users with an `admin`
role and changing the role of already invited users.
Also using scoped permission checks where applicable instead of using
user role checks.
---------
Co-authored-by: Val <68596159+valya@users.noreply.github.com>
Co-authored-by: Alex Grozav <alex@grozav.com>
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
2023-12-08 12:52:25 +01:00
Iván Ovejero
e00577b1d3
refactor(core): Remove unneeded high-frequency log (no-changelog) ( #7963 )
...
## Summary
Remove unneeded high-frequency log
...
#### How to test the change:
1. ...
## Issues fixed
Include links to Github issue or Community forum post or **Linear
ticket**:
> Important in order to close automatically and provide context to
reviewers
...
## Review / Merge checklist
- [ ] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again. A feature is not complete without tests.
>
> *(internal)* You can use Slack commands to trigger [e2e
tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227 )
or [deploy test
instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce )
or [deploy early access version on
Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e ).
2023-12-08 12:52:07 +01:00
Iván Ovejero
8cb9c6b3ea
ci: Introduce no-plain-errors lint rule for BE packages (no-changelog) ( #7961 )
...
## Summary
Require `ApplicationError` or its child classes instead of plain `Error`
in BE packages. This ensures the error will be normalized when reported
to Sentry, if applicable.
Follow-up to:
https://github.com/n8n-io/n8n/pulls?q=is%3Apr+is%3Aclosed+applicationerror
...
#### How to test the change:
1. ...
## Issues fixed
Include links to Github issue or Community forum post or **Linear
ticket**:
> Important in order to close automatically and provide context to
reviewers
...
## Review / Merge checklist
- [ ] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again. A feature is not complete without tests.
>
> *(internal)* You can use Slack commands to trigger [e2e
tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227 )
or [deploy test
instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce )
or [deploy early access version on
Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e ).
2023-12-08 12:51:49 +01:00
Elias Meire
675ec21d33
feat: Data transformation nodes and actions in Nodes Panel ( #7760 )
...
- Split Items List node into separate nodes per action
- Review node descriptions
- New icons
- New sections in subcategories
---------
Co-authored-by: Giulio Andreini <andreini@netseven.it>
Co-authored-by: Deborah <deborah@starfallprojects.co.uk>
Co-authored-by: Michael Kret <michael.k@radency.com>
2023-12-08 11:40:05 +01:00
Iván Ovejero
90824b50ed
feat(core): Add package name tag to Sentry errors (no-changelog) ( #7958 )
...
## Summary
Add `packageName` tag to errors reported to Sentry, for filtering
...
#### How to test the change:
1. ...
## Issues fixed
Include links to Github issue or Community forum post or **Linear
ticket**:
> Important in order to close automatically and provide context to
reviewers
...
## Review / Merge checklist
- [ ] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again. A feature is not complete without tests.
>
> *(internal)* You can use Slack commands to trigger [e2e
tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227 )
or [deploy test
instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce )
or [deploy early access version on
Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e ).
2023-12-08 11:30:06 +01:00
Iván Ovejero
3206b44974
test(core): Improve tests for subworkflow caller policy checks (no-changelog) ( #7954 )
...
## Summary
Deduplicate, separate, organize and speed up tests for subworkflow
caller policy checks.
Follow-up to: https://github.com/n8n-io/n8n/pull/7913
```
PASS test/unit/PermissionChecker.test.ts
check()
✓ should allow if workflow has no creds (3 ms)
✓ should allow if requesting user is instance owner (83 ms)
✓ should allow if workflow creds are valid subset (151 ms)
✓ should deny if workflow creds are not valid subset (85 ms)
checkSubworkflowExecutePolicy()
no caller policy
✓ should fall back to N8N_WORKFLOW_CALLER_POLICY_DEFAULT_OPTION (1 ms)
overridden caller policy
✓ if no sharing, policy becomes workflows-from-same-owner (1 ms)
workflows-from-list caller policy
✓ should allow if caller list contains parent workflow ID
✓ should deny if caller list does not contain parent workflow ID (1 ms)
any caller policy
✓ should not throw
workflows-from-same-owner caller policy
✓ should deny if the two workflows are owned by different users (1 ms)
✓ should allow if both workflows are owned by the same user
```
...
#### How to test the change:
1. ...
## Issues fixed
Include links to Github issue or Community forum post or **Linear
ticket**:
> Important in order to close automatically and provide context to
reviewers
...
## Review / Merge checklist
- [ ] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again. A feature is not complete without tests.
>
> *(internal)* You can use Slack commands to trigger [e2e
tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227 )
or [deploy test
instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce )
or [deploy early access version on
Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e ).
2023-12-08 11:21:43 +01:00
Tomi Turtiainen
a3ca7c7acd
fix: Disable continue button unless at least 1 cred has been filled (no-changelog) ( #7959 )
...
Disable the continue button in template credential setup unless at least
one credential has been (pre-)filled
2023-12-07 19:35:34 +02:00
Iván Ovejero
c48850d74f
fix(core): Fix expression evaluator filename typo (no-changelog) ( #7960 )
...
## Summary
Provide details about your pull request and what it adds, fixes, or
changes. Photos and videos are recommended.
...
#### How to test the change:
1. ...
## Issues fixed
Include links to Github issue or Community forum post or **Linear
ticket**:
> Important in order to close automatically and provide context to
reviewers
...
## Review / Merge checklist
- [ ] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again. A feature is not complete without tests.
>
> *(internal)* You can use Slack commands to trigger [e2e
tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227 )
or [deploy test
instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce )
or [deploy early access version on
Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e ).
2023-12-07 17:50:49 +01:00
Iván Ovejero
18bb87ac0c
test(core): Isolate restore binary data ID in execution lifecycle hooks (no-changelog) ( #7953 )
...
## Summary
Move guard into restore function, move tests into own suite, add tests
for guard.
...
#### How to test the change:
1. ...
## Issues fixed
Include links to Github issue or Community forum post or **Linear
ticket**:
> Important in order to close automatically and provide context to
reviewers
...
## Review / Merge checklist
- [ ] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again. A feature is not complete without tests.
>
> *(internal)* You can use Slack commands to trigger [e2e
tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227 )
or [deploy test
instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce )
or [deploy early access version on
Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e ).
2023-12-07 17:30:47 +01:00
Iván Ovejero
1d46983b24
refactor: Unify severity and level for all application errors for Sentry (no-changelog) ( #7956 )
...
## Summary
Unify `severity` and `level` for all backend application errors for
Sentry
Follow-up to:
https://github.com/n8n-io/n8n/pull/7914#issuecomment-1840433542
...
#### How to test the change:
1. ...
## Issues fixed
Include links to Github issue or Community forum post or **Linear
ticket**:
> Important in order to close automatically and provide context to
reviewers
...
## Review / Merge checklist
- [ ] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again. A feature is not complete without tests.
>
> *(internal)* You can use Slack commands to trigger [e2e
tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227 )
or [deploy test
instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce )
or [deploy early access version on
Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e ).
2023-12-07 16:57:02 +01:00
Tomi Turtiainen
dc1f14b0be
fix(editor): Send correct telemetry events in credential setup (no-changelog) ( #7926 )
...
Send the `User opened cred setup` and `User closed cred setup` events
specified
[here](https://www.notion.so/n8n/Handoff-a1150c38f6e042db91fdf61c56900967?pvs=4 )
2023-12-07 17:25:33 +02:00
Mutasem Aldmour
04cabafef7
feat(editor): Add AppCues tracking for onboarding event ( #7945 )
...
## Summary
We want to trigger a flow, every time the template onboarding event is
triggered. AppCues no longer supports flows triggering through Segment,
except directly.
#### How to test the change:
1. Open on Cloud, where AppCues scripts are available
2. import workflow through /workflows/onboarding/1946
3. Ensure event is sent.. if flow is enabled, flow should show
<img width="1702" alt="Screenshot 2023-12-07 at 14 39 51"
src="https://github.com/n8n-io/n8n/assets/4711238/e58daae8-4364-41a4-bfda-25edeea6cc69 ">
## Issues fixed
Include links to Github issue or Community forum post or **Linear
ticket**:
> Important in order to close automatically and provide context to
reviewers
https://linear.app/n8n/issue/ADO-1455/bug-appcues-trigger
## Review / Merge checklist
- [X] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [x] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again. A feature is not complete without tests.
>
> *(internal)* You can use Slack commands to trigger [e2e
tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227 )
or [deploy test
instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce )
or [deploy early access version on
Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e ).
2023-12-07 16:22:41 +01:00
Iván Ovejero
10ad386604
fix(FileMaker Node): Prevent erroring on zero fields loaded ( #7955 )
...
## Summary
https://n8nio.sentry.io/issues/4703111361
...
#### How to test the change:
1. ...
## Issues fixed
Include links to Github issue or Community forum post or **Linear
ticket**:
> Important in order to close automatically and provide context to
reviewers
...
## Review / Merge checklist
- [ ] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again. A feature is not complete without tests.
>
> *(internal)* You can use Slack commands to trigger [e2e
tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227 )
or [deploy test
instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce )
or [deploy early access version on
Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e ).
2023-12-07 16:13:49 +01:00
Iván Ovejero
9b877a9427
fix(Google Sheets Node): Prevent erroring on zero sheet search results ( #7957 )
...
## Summary
https://n8nio.sentry.io/issues/4695063783
...
#### How to test the change:
1. ...
## Issues fixed
Include links to Github issue or Community forum post or **Linear
ticket**:
> Important in order to close automatically and provide context to
reviewers
...
## Review / Merge checklist
- [ ] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again. A feature is not complete without tests.
>
> *(internal)* You can use Slack commands to trigger [e2e
tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227 )
or [deploy test
instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce )
or [deploy early access version on
Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e ).
2023-12-07 16:12:07 +01:00
Tomi Turtiainen
b63f9cc533
feat(editor): Add user opened cred modal telemetry event (no-changelog) ( #7927 )
...
## Summary
Add `User opened Credential modal` telemetry event to the template
credential setup page, as specified
[here](https://www.notion.so/n8n/Handoff-a1150c38f6e042db91fdf61c56900967?pvs=4 )
2023-12-07 16:05:43 +02:00
Val
42e828d5c6
fix: Restrict updating/deleting of shared but not owned credentials ( #7950 )
...
## Summary
Fix shared members being able to edit and delete credentials they don't
own
#### How to test the change:
1. ...
## Issues fixed
Include links to Github issue or Community forum post or **Linear
ticket**:
> Important in order to close automatically and provide context to
reviewers
...
## Review / Merge checklist
- [x] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [x] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again. A feature is not complete without tests.
>
> *(internal)* You can use Slack commands to trigger [e2e
tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227 )
or [deploy test
instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce )
or [deploy early access version on
Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e ).
2023-12-07 10:35:40 +00:00
Omar Ajoue
3ba7deb337
fix: Ensure external hooks post workflow execute run in queue mode ( #7947 )
...
## Summary
Since 1.8.x a refactor removed the call to `workflow.postExecute`'s
External hook from the execution path. This PR adds it back to the
correct place, where workers are supposed to call this, allowing us to
avoid having to re-read the execution data in the caller just for the
hooks.
It is important to have the hooks running in the worker whenever
possible to prevent having to read the full execution data in the
caller.
#### How to test the change:
1. Use the attached hooks file
[external-hooks.txt](https://github.com/n8n-io/n8n/files/13597270/external-hooks.txt )
setting it up via environment variable using `export
EXTERNAL_HOOK_FILES=/path/to/hooks/external-hooks.js`
2. Set up queue mode loading this file in both main and workers
3. See that the message logs will not be displayed without this fix
## Issues fixed
Include links to Github issue or Community forum post or **Linear
ticket**:
## Review / Merge checklist
- [ ] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again. A feature is not complete without tests.
>
> *(internal)* You can use Slack commands to trigger [e2e
tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227 )
or [deploy test
instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce )
or [deploy early access version on
Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e ).
2023-12-07 10:00:05 +00:00
Iván Ovejero
386bd61967
fix(core): Ensure inviter and invitee are set correctly in invite link ( #7943 )
...
## Summary
Ensure inviter and invitee are set correctly in invite link
...
#### How to test the change:
1. ...
## Issues fixed
Include links to Github issue or Community forum post or **Linear
ticket**:
> Important in order to close automatically and provide context to
reviewers
https://linear.app/n8n/issue/ADO-1494
## Review / Merge checklist
- [ ] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again. A feature is not complete without tests.
>
> *(internal)* You can use Slack commands to trigger [e2e
tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227 )
or [deploy test
instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce )
or [deploy early access version on
Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e ).
2023-12-07 10:53:31 +01:00
Iván Ovejero
bc1c72f992
fix(editor): Allow SSH protocol in git repository URL for environments ( #7944 )
...
## Summary
Allow SSH protocol in git repository URL for environments
...
#### How to test the change:
1. ...
## Issues fixed
Include links to Github issue or Community forum post or **Linear
ticket**:
> Important in order to close automatically and provide context to
reviewers
https://linear.app/n8n/issue/PAY-1097
## Review / Merge checklist
- [x] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [x] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again. A feature is not complete without tests.
>
> *(internal)* You can use Slack commands to trigger [e2e
tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227 )
or [deploy test
instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce )
or [deploy early access version on
Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e ).
2023-12-07 09:19:32 +01:00
Iván Ovejero
3a035cba8b
test(core): Expand user service tests (no-changelog) ( #7941 )
...
## Summary
Expand user service tests
...
#### How to test the change:
1. ...
## Issues fixed
Include links to Github issue or Community forum post or **Linear
ticket**:
> Important in order to close automatically and provide context to
reviewers
...
## Review / Merge checklist
- [ ] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again. A feature is not complete without tests.
>
> *(internal)* You can use Slack commands to trigger [e2e
tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227 )
or [deploy test
instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce )
or [deploy early access version on
Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e ).
2023-12-07 09:19:16 +01:00
Michael Kret
565b409a82
fix(Webhook Node): Binary data handling ( #7804 )
...
Github issue / Community forum post (link here to close automatically):
2023-12-06 17:46:40 +02:00
Alex Grozav
92fa6233d3
fix: Run dev command only for core packages (no-changelog) ( #7928 )
...
## Summary
Provide details about your pull request and what it adds, fixes, or
changes. Photos and videos are recommended.
- Filters out `@n8n/chat` and `n8n-design-system` from `pnpm run dev`
- Fixes dev/build error appearing due to code string `import ... from
'@n8n/chat'`
#### How to test the change:
1. `pnpm run dev` should work as expected
2. The command should not run for the two packages above
3. The error regarding `@n8n/chat` should no longer appear
## Issues fixed
Include links to Github issue or Community forum post or **Linear
ticket**:
> Important in order to close automatically and provide context to
reviewers
https://linear.app/n8n/issue/PAY-1089/run-dev-command-only-for-core-packages
## Review / Merge checklist
- [x] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [x] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [x] Tests included. N/A
> A bug is not considered fixed, unless a test is added to prevent it
from happening again. A feature is not complete without tests.
>
> *(internal)* You can use Slack commands to trigger [e2e
tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227 )
or [deploy test
instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce )
or [deploy early access version on
Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e ).
2023-12-06 17:28:33 +02:00
Alex Grozav
885dba6f12
refactor: Migrate externalHooks mixin to composables (no-changelog) ( #7930 )
...
## Summary
Provide details about your pull request and what it adds, fixes, or
changes. Photos and videos are recommended.
As part of NodeView refactor, this PR migrates all externalHooks calls
to `useExternalHooks` composable.
#### How to test the change:
1. Run using env `export N8N_DEPLOYMENT_TYPE=cloud`
2. Hooks should still run as expected
## Issues fixed
Include links to Github issue or Community forum post or **Linear
ticket**:
> Important in order to close automatically and provide context to
reviewers
https://linear.app/n8n/issue/N8N-6349/externalhooks
## Review / Merge checklist
- [x] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [x] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [x] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again. A feature is not complete without tests.
>
> *(internal)* You can use Slack commands to trigger [e2e
tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227 )
or [deploy test
instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce )
or [deploy early access version on
Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e ).
2023-12-06 17:28:09 +02:00
Csaba Tuncsik
c461025f70
test: Add user type of admin to E2E tests ( #7935 )
...
## Summary
Extend existing user types in the E2E database. Currently, we have only
owner and member but we need also admin
---------
Co-authored-by: Val <68596159+valya@users.noreply.github.com>
2023-12-06 14:31:06 +01:00
Iván Ovejero
92bab72cff
fix(core): Fix user comparison in same-user subworkflow caller policy ( #7913 )
...
https://linear.app/n8n/issue/PAY-992
https://community.n8n.io/t/executing-workflow-using-owner-role-created-by-another-user-fails/33443
---------
Co-authored-by: Omar Ajoue <krynble@gmail.com>
2023-12-06 12:27:11 +00:00
github-actions[bot]
823b589e09
🚀 Release 1.20.0 ( #7940 )
...
#
[1.20.0](https://github.com/n8n-io/n8n/compare/n8n@1.19.0...n8n@1.20.0 )
(2023-12-06)
### Bug Fixes
* **AWS DynamoDB Node:** Improve error message parsing
([#7793 ](https://github.com/n8n-io/n8n/issues/7793 ))
([5ba5ed85ba5ed8e3c#7889 ](https://github.com/n8n-io/n8n/issues/7889 ))
([61d8aeb61d8aebeaf#7920 ](https://github.com/n8n-io/n8n/issues/7920 ))
([38b88b938b88b946b#7848 ](https://github.com/n8n-io/n8n/issues/7848 ))
([46dd4d346dd4d3105#7936 ](https://github.com/n8n-io/n8n/issues/7936 ))
([f5502ccf5502cc628#7883 ](https://github.com/n8n-io/n8n/issues/7883 ))
([ce2d388ce2d388f05#7858 ](https://github.com/n8n-io/n8n/issues/7858 ))
([132d691132d691cbf#7862 ](https://github.com/n8n-io/n8n/issues/7862 ))
([5207a2f5207a2fe52#7864 ](https://github.com/n8n-io/n8n/issues/7864 ))
([51d1f5b51d1f5b820#7791 ](https://github.com/n8n-io/n8n/issues/7791 )
### Features
* **BambooHR Node:** Add support for Only Current on company reports
([#7878 ](https://github.com/n8n-io/n8n/issues/7878 ))
([41758014175801c90#7837 ](https://github.com/n8n-io/n8n/issues/7837 ))
([476806e476806ebb0#7831 ](https://github.com/n8n-io/n8n/issues/7831 ))
([39fa8d239fa8d21bb#7882 ](https://github.com/n8n-io/n8n/issues/7882 ))
([627ddb9627ddb91fb#7879 ](https://github.com/n8n-io/n8n/issues/7879 ))
([fe3417afe3417a615#7904 ](https://github.com/n8n-io/n8n/issues/7904 ))
([a8049a0a8049a0def#7901 ](https://github.com/n8n-io/n8n/issues/7901 ))
([4bd7ae24bd7ae29f7
2023-12-06 12:26:24 +01:00
Ricardo Espinoza
f5502cc628
fix(core): Make sure mfa secret and recovery codes are not returned on login ( #7936 )
...
## Summary
What: Fix issue of login endpoint returning secret and recovery codes
when MFA is enabled. Bug was introduced in this
[PR](https://github.com/n8n-io/n8n/pull/6994 ), specifically in this
[line](https://github.com/n8n-io/n8n/pull/6994/files#diff-95a87cb029a3d26e6722df2e68132453fc254fc1f4540cbdaa95cfdbda1893deL91 ).
Why: We should not be filtering the secret and recovery codes
Same PR caused the issues on ticket ->
https://linear.app/n8n/issue/ADO-1494/on-user-list-copy-password-reset-link-and-copy-invite-link-are-broken
## Review / Merge checklist
- [x] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [x] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [x] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again. A feature is not complete without tests.
>
> *(internal)* You can use Slack commands to trigger [e2e
tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227 )
or [deploy test
instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce )
or [deploy early access version on
Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e ).
2023-12-06 10:00:13 +01:00
Andrey Starostin
46dd4d3105
fix(core): Fix hard deletes stopping if database query throws ( #7848 )
...
I have observed that the next hard deletion timeout is not scheduled if
the `hardDeleteOnPruningCycle` function throws when fetching the data
from the database. That is because the thrown error is not caught and
the `scheduleHardDeletion` method is not called.
This PR moves the call to `scheduleHardDeletion` into the
`scheduleHardDeletion` for better cohesion, and ensures that it is
called even if `hardDeleteOnPruningCycle` throws.
2023-12-05 16:30:32 +01:00
Val
4e55583715
feat: Add admin role to public API (no-changelog) ( #7933 )
...
## Summary
Add the admin global role to the public API. This does not include
porting over scopes.
#### How to test the change:
1. ...
## Issues fixed
Include links to Github issue or Community forum post or **Linear
ticket**:
> Important in order to close automatically and provide context to
reviewers
...
## Review / Merge checklist
- [ ] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again. A feature is not complete without tests.
>
> *(internal)* You can use Slack commands to trigger [e2e
tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227 )
or [deploy test
instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce )
or [deploy early access version on
Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e ).
2023-12-05 15:00:14 +00:00
Jon
4175801c90
feat(BambooHR Node): Add support for Only Current on company reports ( #7878 )
...
Github issue / Community forum post (link here to close automatically):
https://github.com/n8n-io/n8n/issues/7876
API Docs for reference:
https://documentation.bamboohr.com/reference/get-company-report-1
2023-12-05 10:34:28 +00:00
Val
9604b87da9
fix: Return scopes on invitation accept endpoint (no-changelog) ( #7917 )
...
## Summary
Return scopes on the invitation accept endpoint. The UI uses information
until the user refreshes the pages so it's causing inconsistency for the
new admin role.
#### How to test the change:
1. ...
## Issues fixed
Include links to Github issue or Community forum post or **Linear
ticket**:
> Important in order to close automatically and provide context to
reviewers
...
## Review / Merge checklist
- [x] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again. A feature is not complete without tests.
>
> *(internal)* You can use Slack commands to trigger [e2e
tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227 )
or [deploy test
instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce )
or [deploy early access version on
Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e ).
2023-12-05 11:18:41 +01:00
Iván Ovejero
e77fd5d286
refactor: Switch plain errors in nodes-base to ApplicationError (no-changelog) ( #7914 )
...
Ensure all errors in `nodes-base` are `ApplicationError` or children of
it and contain no variables in the message, to continue normalizing all
the backend errors we report to Sentry. Also, skip reporting to Sentry
errors from user input and from external APIs. In future we should
refine `ApplicationError` to more specific errors.
Follow-up to: [#7877 ](https://github.com/n8n-io/n8n/pull/7877 )
- [x] Test workflows:
https://github.com/n8n-io/n8n/actions/runs/7084627970
- [x] e2e: https://github.com/n8n-io/n8n/actions/runs/7084936861
---------
Co-authored-by: Michael Kret <michael.k@radency.com>
2023-12-05 11:17:08 +01:00
Iván Ovejero
38b88b946b
fix(core): Consolidate ownership and sharing data on workflows and credentials ( #7920 )
...
## Summary
Ensure `ownedBy` and `sharedWith` are present and uniform for
credentials and workflows.
Details in story: https://linear.app/n8n/issue/PAY-987
2023-12-05 10:11:18 +01:00
Alex Grozav
0a745d16e4
fix(editor): Add missing workflow id from route (no-changelog) ( #7918 )
...
## Summary
Fixes missing workflow id from route.
#### How to test the change:
1. Go to executions page for a workflow without executions
2. Wait for autoRefresh to start
3. Error appears in console due to missing `name` parameter
## Issues fixed
Include links to Github issue or Community forum post or **Linear
ticket**:
> Important in order to close automatically and provide context to
reviewers
https://linear.app/n8n/issue/N8N-7075/error-missing-required-param-name
## Review / Merge checklist
- [x] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [x] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again. A feature is not complete without tests.
>
> *(internal)* You can use Slack commands to trigger [e2e
tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227 )
or [deploy test
instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce )
or [deploy early access version on
Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e ).
2023-12-05 10:43:40 +02:00
Alex Grozav
6b678b5b9e
fix(editor): Use hasOwnProperty to check for canvas key on connector (no-changelog) ( #7921 )
...
## Summary
Provide details about your pull request and what it adds, fixes, or
changes. Photos and videos are recommended.
Fixes `key in object` check by replacing with `hasOwnProperty`.
## Issues fixed
Include links to Github issue or Community forum post or **Linear
ticket**:
> Important in order to close automatically and provide context to
reviewers
https://linear.app/n8n/issue/N8N-7077/typeerror-cannot-use-in-operator-to-search-for-canvas-in-null
## Review / Merge checklist
- [x] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [x] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again. A feature is not complete without tests.
>
> *(internal)* You can use Slack commands to trigger [e2e
tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227 )
or [deploy test
instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce )
or [deploy early access version on
Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e ).
2023-12-05 10:34:25 +02:00
Alex Grozav
7c57332d8f
fix(editor): Add missing activeNode check for redrawing (no-changelog) ( #7919 )
...
## Summary
Wasn't able to reproduce, but `activeNode` sporadically returns null in
some scenarios. Added appropriate check.
## Issues fixed
Include links to Github issue or Community forum post or **Linear
ticket**:
> Important in order to close automatically and provide context to
reviewers
https://linear.app/n8n/issue/N8N-7076/typeerror-cannot-read-properties-of-null-reading-name
## Review / Merge checklist
- [x] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [x] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again. A feature is not complete without tests.
>
> *(internal)* You can use Slack commands to trigger [e2e
tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227 )
or [deploy test
instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce )
or [deploy early access version on
Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e ).
2023-12-05 10:34:15 +02:00
oleg
e4ae11c2ad
fix: Remove Tensorflow embeddings node (no-changelog) ( #7922 )
...
## Summary
This PR removes `embeddingsTensorFlow` node and reverts our fix to
accommodate the Docker build in #7893 .
The node itself has been extracted as a [community node available from
npm](https://www.npmjs.com/package/n8n-nodes-tensorflow )
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
2023-12-04 17:48:10 +01:00
Tomi Turtiainen
6448d4c8a5
fix(editor): Tune credential template layout (no-changelog) ( #7903 )
...
Add max width to the content and scale it based on that
2023-12-04 15:27:38 +02:00
Iván Ovejero
29e7a98f3e
test(core): Use license mocker in RBAC tests (no-changelog) ( #7912 )
...
## Summary
Provide details about your pull request and what it adds, fixes, or
changes. Photos and videos are recommended.
...
#### How to test the change:
1. ...
## Issues fixed
Include links to Github issue or Community forum post or **Linear
ticket**:
> Important in order to close automatically and provide context to
reviewers
...
## Review / Merge checklist
- [ ] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again. A feature is not complete without tests.
>
> *(internal)* You can use Slack commands to trigger [e2e
tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227 )
or [deploy test
instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce )
or [deploy early access version on
Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e ).
2023-12-04 13:56:48 +01:00
Milorad FIlipović
4bd7ae29f7
perf(editor): Improve performance when opening large workflows with node issues ( #7901 )
...
This PR should improve performance when opening large workflows that
contain node issues (Fixes ADO-1521)
**Background**
Main reason for this poor performance is that our `getCurrentWorkflow()`
store getter is unnecessarily heavy but on top of that we are calling it
more than we need. This addresses the second part of the issue by
changing the following:
- Pausing node issue processing while workflows are loading
- Only getting current workflow once (instead for every node) when
calling `refreshNodeIssues`
**Benchmark**
This was tested on a workflow attached to [this Linear
ticket](https://linear.app/n8n/issue/ADO-1501/deliveryhero-enterprise-instance-very-slow-loading-workflows )
and this fix brings down opening time from **~1m10s** to **~28s** on my
laptop.
**Tests**
- [Latest e2e tests
run](https://github.com/n8n-io/n8n/actions/runs/7060874994 )
https://community.n8n.io/t/ui-very-slow-with-more-than-100-nodes/8236/14
2023-12-04 10:57:03 +01:00
Csaba Tuncsik
132d691cbf
fix(editor): Replace isInstanceOwner checks with scopes where applicable ( #7858 )
...
Co-authored-by: Alex Grozav <alex@grozav.com>
2023-12-04 10:02:54 +01:00
Elias Meire
39fa8d21bb
feat(editor): Add sections to create node panel ( #7831 )
...
This PR sets the stage for the node creator to handle sections within
subcategories. No visible changes result from this PR; the next PR will
define sections and assign nodes accordingly.
Sections are configurable in
`packages/editor-ui/src/components/Node/NodeCreator/viewsData.ts`:
```
{
type: 'subcategory',
key: FILES_SUBCATEGORY,
category: CORE_NODES_CATEGORY,
properties: {
title: FILES_SUBCATEGORY,
icon: 'file-alt',
sections: [
{
key: 'popular',
title: i18n.baseText('nodeCreator.sectionNames.popular'),
items: ['n8n-nodes-base.readBinaryFiles', 'n8n-nodes-base.compression'],
},
],
},
},
```
For example:
<img width="302" alt="image"
src="https://github.com/n8n-io/n8n/assets/8850410/74470c07-f4ea-4306-bd4a-8d33bd769b86 ">
---------
Co-authored-by: Michael Kret <michael.k@radency.com>
2023-12-04 10:02:07 +01:00
Deborah
485a0c73cb
docs: Fix typo in tooltip relating to JMESPath ( #7910 )
2023-12-04 08:19:36 +00:00
Tomi Turtiainen
a78729b12f
feat(editor): Allow partial template credential setup (no-changelog) ( #7899 )
...
Enable continue button even if all credentials havent been setup
2023-12-04 09:30:34 +02:00
Milorad FIlipović
a8049a0def
perf(editor): Improve node rendering performance when opening large workflows ( #7904 )
...
## Summary
In an effort to do as little processing as possible in each `Node`
component, this PR passes current workflow object to it as a property
instead of calling the slow `getCurrentWorkflow` store getter a few
times in each node. This should substantially improve loading times for
large workflows.
As a benchmark, I was using a workflow from [this Linear
ticket](https://linear.app/n8n/issue/ADO-1501/deliveryhero-enterprise-instance-very-slow-loading-workflows )
and this fix brought down opening time by **20 seconds**. Together with
fixes from #7901 , this workflow was opening in less than **10 seconds**
on my laptop.
[Latest e2e run](https://github.com/n8n-io/n8n/actions/runs/7062162739 )
#### How to test the change:
1. Open a large workflow
2. Observe loading time
## Issues fixed
ADO-1523
https://community.n8n.io/t/ui-very-slow-with-more-than-100-nodes/8236/14
## Review / Merge checklist
- [x] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again. A feature is not complete without tests.
>
> *(internal)* You can use Slack commands to trigger [e2e
tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227 )
or [deploy test
instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce )
or [deploy early access version on
Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e ).
2023-12-01 17:50:11 +01:00
Tomi Turtiainen
38e4b56280
fix(editor): Tune styles of template credential setup (no-changelog) ( #7898 )
2023-12-01 16:00:48 +02:00
Tomi Turtiainen
f8e93b3852
fix: Fix credential setup for templates with unnamed credentials (no-changelog) ( #7891 )
...
The template credentials were matched before solely based on the
credential name on the template. This fixes the matching to use both
credential type name and credential name.
2023-12-01 14:56:51 +02:00
Iván Ovejero
50a7401de9
docs: Update breaking changes with binary data TTL note ( #7894 )
...
Context:
https://n8nio.slack.com/archives/C035KBDA917/p1701418556761549?thread_ts=1701411854.517989&cid=C035KBDA917
2023-12-01 12:52:12 +01:00
Iván Ovejero
07f6662aba
refactor(core): Add log about removed TTL keys for binary data ( #7892 )
...
Context:
https://n8nio.slack.com/archives/C035KBDA917/p1701418556761549?thread_ts=1701411854.517989&cid=C035KBDA917
2023-12-01 12:51:45 +01:00
Iván Ovejero
61d8aebeaf
fix(core): Allow grace period for binary data deletion after manual execution ( #7889 )
...
https://linear.app/n8n/issue/PAY-1079
2023-12-01 10:13:53 +01:00
Michael Kret
ade3acf800
fix(Google Sheets Node): Missing version fo RMC (no-changelog) ( #7886 )
...
Github issue / Community forum post (link here to close automatically):
2023-11-30 17:24:43 +02:00
Tomi Turtiainen
fe3417a615
feat(editor): Select credentials in template setup if theres only one ( #7879 )
...
Automatically select credentials in the template credential setup if
there's only one available.
NOTE! This feature is still behind a feature flag. To test, set:
```js
localStorage.setItem('template-credentials-setup', 'true')
```
https://github.com/n8n-io/n8n/assets/10324676/edc1f586-214f-4c37-b7ec-dd1786433dc1
2023-11-30 15:46:14 +02:00
Iván Ovejero
e0b7f89035
refactor(core): Separate API response from error in execution error causes (no-changelog) ( #7880 )
...
Store the third-party API response error separately from the error
stored as `cause`
Follow-up to:
https://github.com/n8n-io/n8n/pull/7820#discussion_r1406009154
2023-11-30 14:44:10 +01:00
Iván Ovejero
b024cc52e7
ci: Fix lint warnings in @n8n/chat and @n8n/nodes-langchain (no-changelog) ( #7884 )
...
Solve lint warnings shown on all PRs for `@n8n/chat` and
`@n8n/nodes-langchain`
Example: https://github.com/n8n-io/n8n/pull/7883/files
2023-11-30 13:22:27 +01:00
Tomi Turtiainen
627ddb91fb
feat(editor): Open template credential setup from collection ( #7882 )
...
Open the template credential setup when using a template from the
collection view.
NOTE! This feature is still behind a feature flag. To test, set:
```js
localStorage.setItem('template-credentials-setup', 'true')
```
https://github.com/n8n-io/n8n/assets/10324676/46ccec7c-5a44-429e-99ad-1c10640e99e5
2023-11-30 14:09:12 +02:00
Iván Ovejero
67702c2485
refactor(core): Switch plain errors in workflow to ApplicationError (no-changelog) ( #7877 )
...
Ensure all errors in `workflow` are `ApplicationError` or children of it
and contain no variables in the message, to continue normalizing all the
errors we report to Sentry
Follow-up to: https://github.com/n8n-io/n8n/pull/7873
2023-11-30 12:46:45 +01:00
Iván Ovejero
ce2d388f05
fix(editor): Fix deletion of last execution at execution preview ( #7883 )
...
https://linear.app/n8n/issue/PAY-1062
2023-11-30 12:12:26 +01:00
oleg
e834f14991
refactor: Remove Epub document loader override (no-changelog) ( #7874 )
...
- Remove Epub document loader override, use standard Langchain loader
- Use temporary buffer file for document loader processing and pass just
the path
- Remove replace `@gxl/epub-parser` library with `epub2`
Github issue / Community forum post (link here to close automatically):
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-11-30 11:59:37 +01:00
Val
5f4a9524ec
refactor(core): Add central license mock for integration tests (no-changelog) ( #7871 )
...
Github issue / Community forum post (link here to close automatically):
2023-11-30 09:23:09 +01:00
Iván Ovejero
b16dd21909
refactor(core): Switch plain errors in core to ApplicationError (no-changelog) ( #7873 )
...
Ensure all errors in `core` are `ApplicationError` or children of it and
contain no variables in the message, to continue normalizing all the
errors we report to Sentry
Follow-up to: https://github.com/n8n-io/n8n/pull/7857
2023-11-30 09:06:19 +01:00
Val
cd474f1562
feat: Allow owner to share workflows/credentials they don't own (no-changelog) ( #7869 )
...
Github issue / Community forum post (link here to close automatically):
2023-11-29 16:32:27 +00:00
Csaba Tuncsik
14f53def07
fix(editor): Restrict workflow and credential sharing to their owners (no-changelog) ( #7870 )
...
Removing scope permission checks on workflow and credential sharing and
relying only on resource ownership.
Every user can share only the workflows and credentials they created.
2023-11-29 16:36:49 +01:00
Omar Ajoue
74b4513298
feat(core): Add Advanced Permissions to FE settings (no-changelog) ( #7867 )
...
Github issue / Community forum post (link here to close automatically):
2023-11-29 15:56:35 +01:00
Val
1cb92ffe16
feat: Replace owner checks with scope checks (no-changelog) ( #7846 )
...
Github issue / Community forum post (link here to close automatically):
2023-11-29 14:48:36 +00:00
कारतोफ्फेलस्क्रिप्ट™
d5762a7539
ci: Fix docker builds for releases ( #7865 )
2023-11-29 15:25:50 +01:00
Jon
5207a2fe52
fix(Google Sheets Node): Fix issue with paired items not being set correctly ( #7862 )
...
https://community.n8n.io/t/error-unknown-top-level-item-key-paireditems-item-0/33536/
Co-authored-by: Michael Kret <michael.k@radency.com>
2023-11-29 14:12:50 +00:00
oleg
51d1f5b820
fix(Notion Node): Fix broken Notion node parameters ( #7864 )
...
We've introduced a new version(`2.1` of Notion node in #7791 but not all
`diplayOptions` conditions were updated. This would effectively prevent
most of the required Notion fields from loading.
This PR adds the new version to all `@version` display conditions which
contain version `2`.
https://github.com/n8n-io/n8n/assets/12657221/4254c646-43b6-46b3-adcc-1b17746901da
Github issue / Community forum post (link here to close automatically):
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Michael Kret <michael.k@radency.com>
2023-11-29 15:11:54 +01:00
कारतोफ्फेलस्क्रिप्ट™
6d9342e676
Merge tag 'n8n@1.19.0'
2023-11-29 14:12:24 +01:00
Iván Ovejero
476806ebb0
feat(core): Allow admin creation ( #7837 )
...
https://linear.app/n8n/issue/PAY-1038
2023-11-29 13:55:41 +01:00
Marcus
5ba5ed8e3c
fix(AWS DynamoDB Node): Improve error message parsing ( #7793 )
...
Github issue / Community forum post (link here to close automatically):
2023-11-29 13:44:13 +01:00
github-actions[bot]
303cf31331
🚀 Release 1.19.0 ( #7863 )
...
#
[1.19.0](https://github.com/n8n-io/n8n/compare/n8n@1.18.0...n8n@1.19.0 )
(2023-11-29)
### Bug Fixes
* **core:** Ensure member and admin cannot be promoted to owner
([#7830 ](https://github.com/n8n-io/n8n/issues/7830 ))
([9b87a599b87a596cahttps://github.com//linear.app/n8n/issue/PAY-985/add-user-role-modification-endpoint/issues/comment-62355f6 )
* **core:** Prevent error messages due to statistics about data loading
([#7824 ](https://github.com/n8n-io/n8n/issues/7824 ))
([847f6ac847f6ac771#7788 ](https://github.com/n8n-io/n8n/issues/7788 ))
([fdb2c18fdb2c18ecc#6141 ](https://github.com/n8n-io/n8n/issues/6141 ))
([d2c18c5d2c18c5727#7811 ](https://github.com/n8n-io/n8n/issues/7811 ))
([d497041d4970410e1#7833 ](https://github.com/n8n-io/n8n/issues/7833 ))
([3ab3ec93ab3ec9da8#7789 ](https://github.com/n8n-io/n8n/issues/7789 ))
([902beff902beffce5#7841 ](https://github.com/n8n-io/n8n/issues/7841 ))
([8b993848b99384367#7843 ](https://github.com/n8n-io/n8n/issues/7843 ))
([40741074074107511#7842 ](https://github.com/n8n-io/n8n/issues/7842 ))
([28ac5a728ac5a750e#7853 ](https://github.com/n8n-io/n8n/issues/7853 ))
([c063398c0633987bf#7778 ](https://github.com/n8n-io/n8n/issues/7778 ))
([5835e055835e055d3#7808 ](https://github.com/n8n-io/n8n/issues/7808 ))
([685ffd7685ffd7413#7800 ](https://github.com/n8n-io/n8n/issues/7800 ))
([d548872d5488725a8#7782 ](https://github.com/n8n-io/n8n/issues/7782 ))
([6208af06208af07eb#7801 ](https://github.com/n8n-io/n8n/issues/7801 ))
([73ec75373ec7533ce#7336 ](https://github.com/n8n-io/n8n/issues/7336 ))
([87def6087def60979#7737 ](https://github.com/n8n-io/n8n/issues/7737 ))
([a37f1cba37f1cb0ba#7786 ](https://github.com/n8n-io/n8n/issues/7786 ))
([aae45b0aae45b043b#7455 ](https://github.com/n8n-io/n8n/issues/7455 ))
([99a9ea499a9ea497a#7797 ](https://github.com/n8n-io/n8n/issues/7797 ))
([7a86d367a86d36068#7834 ](https://github.com/n8n-io/n8n/issues/7834 ))
([2356fb02356fb0f0c#7731 ](https://github.com/n8n-io/n8n/issues/7731 ))
([da85198da851986f6#7702 ](https://github.com/n8n-io/n8n/issues/7702 ))
([67a889167a88914f2#7847 ](https://github.com/n8n-io/n8n/issues/7847 ))
([72852a672852a60eb#7763 ](https://github.com/n8n-io/n8n/issues/7763 ))
([77bc8ec77bc8ecd4b#7791 ](https://github.com/n8n-io/n8n/issues/7791 ))
([d667bcad667bca658#7829 ](https://github.com/n8n-io/n8n/issues/7829 ))
([90bb6ba90bb6ba417
2023-11-29 13:17:03 +01:00
Michael Kret
c72229fbe2
fix(core): Rename ’Marketing & Content' category to 'Marketing' (no-changelog) ( #7823 )
...
Github issue / Community forum post (link here to close automatically):
2023-11-29 13:37:46 +02:00
Val
e282ea242d
fix: Return scopes on owner setup endpoint (no-changelog) ( #7860 )
...
Github issue / Community forum post (link here to close automatically):
2023-11-29 11:33:32 +00:00
Iván Ovejero
c08c5cc37b
refactor(core): Switch plain errors in cli to ApplicationError ( #7857 )
...
Ensure all errors in `cli` are `ApplicationError` or children of it and
contain no variables in the message, to continue normalizing all the
errors we report to Sentry
Follow-up to: https://github.com/n8n-io/n8n/pull/7839
2023-11-29 12:25:10 +01:00
Jan Oberhauser
87def60979
feat: Add AI tool building capabilities ( #7336 )
...
Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/langchain-memory-chat/23733
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Val <68596159+valya@users.noreply.github.com>
Co-authored-by: Alex Grozav <alex@grozav.com>
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
Co-authored-by: Deborah <deborah@starfallprojects.co.uk>
Co-authored-by: Jesper Bylund <mail@jesperbylund.com>
Co-authored-by: Jon <jonathan.bennetts@gmail.com>
Co-authored-by: Michael Kret <88898367+michael-radency@users.noreply.github.com>
Co-authored-by: Giulio Andreini <andreini@netseven.it>
Co-authored-by: Mason Geloso <Mason.geloso@gmail.com>
Co-authored-by: Mason Geloso <hone@Masons-Mac-mini.local>
Co-authored-by: Mutasem Aldmour <mutasem@n8n.io>
2023-11-29 12:13:55 +01:00
Milorad FIlipović
8b99384367
fix(editor): Fix cloud plan data loading on instance ( #7841 )
...
Moving cloud hooks and store initialization logic after users are
authenticated. This will ensure user local account is available when
their cloud plan data is being fetched.
This PR also adds the following error handling improvements:
- Added error handling to the same initialization logic
- Fixed empty `catch` clauses inside the cloud store which caused it to
silently fail and complicated debugging of this bug
2023-11-29 10:51:15 +01:00
Jon
90bb6ba417
feat(Slack Node): Add support for getting the profile of a user ( #7829 )
...
Github issue / Community forum post (link here to close automatically):
https://github.com/n8n-io/n8n/issues/7825
This adds support for getting a users profile which returns different
data to the existing user info (Get) operation we have.
Test Workflow
```
{
"meta": {
"instanceId": "8c8c5237b8e37b006a7adce87f4369350c58e41f3ca9de16196d3197f69eabcd"
},
"nodes": [
{
"parameters": {},
"id": "69f437fb-9962-4d51-91bb-0ef4b3827e49",
"name": "When clicking \"Execute Workflow\"",
"type": "n8n-nodes-base.manualTrigger",
"typeVersion": 1,
"position": [
880,
380
]
},
{
"parameters": {
"resource": "user",
"user": {
"__rl": true,
"value": "U035F563JSW",
"mode": "list",
"cachedResultName": "jonathan"
}
},
"id": "826828db-598b-40c7-b085-5b01f2c10d73",
"name": "Get Info",
"type": "n8n-nodes-base.slack",
"typeVersion": 2.1,
"position": [
1120,
260
],
"credentials": {
"slackApi": {
"id": "E4DnXIyNuRxi5GSz",
"name": "Slack account"
}
}
},
{
"parameters": {
"resource": "user",
"operation": "getProfile",
"user": {
"__rl": true,
"value": "U035F563JSW",
"mode": "list",
"cachedResultName": "jonathan"
}
},
"id": "9de02c3f-e17c-4a32-a64e-11aaa0b36120",
"name": "Get Profile",
"type": "n8n-nodes-base.slack",
"typeVersion": 2.1,
"position": [
1120,
440
],
"credentials": {
"slackApi": {
"id": "E4DnXIyNuRxi5GSz",
"name": "Slack account"
}
}
}
],
"connections": {
"When clicking \"Execute Workflow\"": {
"main": [
[
{
"node": "Get Info",
"type": "main",
"index": 0
},
{
"node": "Get Profile",
"type": "main",
"index": 0
}
]
]
}
},
"pinData": {}
}
```
2023-11-29 08:37:18 +00:00
Alex Grozav
72852a60eb
feat(editor): Replace middleware for Role checks with Scope checks ( #7847 )
2023-11-29 10:35:40 +02:00
Csaba Tuncsik
d4970410e1
fix(editor): Add telemetry to workflow history ( #7811 )
2023-11-29 09:09:21 +01:00
Milorad FIlipović
c0633987bf
fix(editor): Fix mouse position in workflow previews ( #7853 )
...
This PR fixes mouse position detection in workflow previews (executions
preview and workflow history view):
https://github.com/n8n-io/n8n/assets/2598782/83237b76-b099-4560-9c47-a963f0848297
**Cause**:
We were setting `isDemo` state in canvas store only when the `NodeView`
component is activated, which never happens for `NodeView` instances
that are kept alive (above mentioned workflow previews)
**Fix**:
This workflow updates store state also when the `NodeView` component is
mounted.
2023-11-28 19:02:19 +01:00
Tomi Turtiainen
28ac5a750e
fix(editor): Fix icon for unknown node type ( #7842 )
2023-11-28 19:16:51 +02:00
कारतोफ्फेलस्क्रिप्ट™
2f8cb419df
ci: Fix editor tests when coverage is enabled (no-changelog) ( #7827 )
...
[Test run
](https://github.com/n8n-io/n8n/actions/runs/7021272455/job/19103012704 )
2023-11-28 18:04:30 +01:00
Csaba Tuncsik
685ffd7413
fix(editor): Suppress dev server websocket messages in workflow view ( #7808 )
2023-11-28 17:30:44 +01:00
कारतोफ्फेलस्क्रिप्ट™
117962d473
feat(core): Update LLM applications building support (no-changelog) ( #7710 )
...
extracted out of #7336
---------
Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
Co-authored-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Alex Grozav <alex@grozav.com>
2023-11-28 16:47:28 +01:00
कारतोफ्फेलस्क्रिप्ट™
4a89504d54
fix(editor): Fix push connection on WorkerList and CommunityNodes pages (no-changelog) ( #7851 )
2023-11-28 16:45:50 +01:00
Csaba Tuncsik
e87e928144
fix(editor): Remove ability for users to select admin role in the UI (no-changelog) ( #7850 )
2023-11-28 15:11:02 +01:00
Iván Ovejero
2356fb0f0c
feat(core): Set up endpoint for all existing roles with license flag ( #7834 )
...
https://linear.app/n8n/issue/PAY-1034/create-endpoint-to-list-all-existing-roles
2023-11-28 14:16:47 +01:00
Tomi Turtiainen
4074107511
fix(editor): Fix credential icon for old node type version ( #7843 )
...
If a credential was for a node's older version, its icon was not shown.
2023-11-28 15:14:22 +02:00
Val
a37f1cb0ba
feat: Add initial scope checks via decorators ( #7737 )
2023-11-28 11:41:34 +00:00
कारतोफ्फेलस्क्रिप्ट™
753cbc1e96
refactor(editor): Delete some barrel files and reduce circular dependencies (no-changelog) ( #7838 )
2023-11-28 12:15:08 +01:00
Csaba Tuncsik
3ab3ec9da8
fix(editor): Allow owners and admins to share workflows and credentials they don't own ( #7833 )
2023-11-28 11:44:55 +01:00
Iván Ovejero
1c6178759c
refactor(core): Reorganize error hierarchy in cli package (no-changelog) ( #7839 )
...
Ensure all errors in `cli` inherit from `ApplicationError` to continue
normalizing all the errors we report to Sentry
Follow-up to: https://github.com/n8n-io/n8n/pull/7820
2023-11-28 10:19:27 +01:00
Jon
38f24a6184
fix(Google Calendar Trigger Node): Fix issue preventing birthday and holiday calendars from working ( #7832 )
...
Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/issue-with-some-google-calendars/33411
---------
Co-authored-by: Michael Kret <michael.k@radency.com>
2023-11-28 09:11:05 +00:00
Michael Kret
d5488725a8
fix(Google Sheets Node): Read operation execute for each item ( #7800 )
...
Github issue / Community forum post (link here to close automatically):
2023-11-28 11:02:11 +02:00
Michael Kret
df691fba0c
fix(core): Node version in the user added node to workflow canvas event (no-changelog) ( #7814 )
...
Github issue / Community forum post (link here to close automatically):
2023-11-27 19:50:20 +02:00
Iván Ovejero
9b87a596ca
fix(core): Ensure member and admin cannot be promoted to owner ( #7830 )
...
https://linear.app/n8n/issue/PAY-985/add-user-role-modification-endpoint#comment-62355f6b
2023-11-27 17:35:58 +01:00
Tomi Turtiainen
ac744d6702
test: Ado 1296 add e2e tests ( #7792 )
...
Adds e2e tests for the template credential setup.
2023-11-27 17:18:10 +02:00
Omar Ajoue
847f6ac771
fix(core): Prevent error messages due to statistics about data loading ( #7824 )
...
Statistics collection about the first time a workflow loads data simply
attempts an insert to db, and if it fails, we just ignore.
This was causing this query to fire against production workflows
multiple times, and since we want to insert only and detect whether the
insertion failed, performing a select first provides gains both in terms
of performance, as it's usually faster than trying an insertion as well
as preventing unnecessary noise in logs.
Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/duplicate-key-value-violates-unique-constraint-workflow-statistics-pkey-still-happening/29283
https://github.com/n8n-io/n8n/issues/7256
https://community.n8n.io/t/error-log-arriving-in-postgres/30191
https://github.com/n8n-io/n8n/issues/7256
https://community.n8n.io/t/cant-launch-webhooks-unable-to-find-data-of-execution/31867
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-11-27 15:43:48 +01:00
Michael Kret
73ec7533ce
fix(Microsoft SQL Node): Prevent double escaping table name ( #7801 )
...
Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/issue-my-mssql-update-in-latest-version/32966
2023-11-27 16:41:35 +02:00
Iván Ovejero
dff8456382
refactor(core): Reorganize error hierarchy in core and workflow packages (no-changelog) ( #7820 )
...
Ensure all errors in `core` and `workflow` inherit from
`ApplicationError` so that we start normalizing all the errors we report
to Sentry
Follow-up to:
https://github.com/n8n-io/n8n/pull/7757#discussion_r1404338844
### `core` package
`ApplicationError`
- `FileSystemError` (abstract)
- `FileNotFoundError`
- `DisallowedFilepathError`
- `BinaryDataError` (abstract)
- `InvalidModeError`
- `InvalidManagerError`
- `InvalidExecutionMetadataError`
### `workflow` package
`ApplicationError`
- `ExecutionBaseError` (abstract)
- `WorkflowActivationError`
- `WorkflowDeactivationError`
- `WebhookTakenError`
- `WorkflowOperationError`
- `SubworkflowOperationError`
- `CliWorkflowOperationError`
- `ExpressionError`
- `ExpressionExtensionError`
- `NodeError` (abstract)
- `NodeOperationError`
- `NodeApiError`
- `NodeSSLError`
Up next:
- Reorganize errors in `cli`
- Flatten the hierarchy in `workflow` (do we really need
`ExecutionBaseError`?)
- Remove `ExecutionError` type
- Stop throwing plain `Error`s
- Replace `severity` with `level`
- Add node and credential types as `tags`
- Add workflow IDs and execution IDs as `extras`
2023-11-27 15:33:21 +01:00
Tomi Turtiainen
aae45b043b
feat: Ado 1296 spike credential setup in templates ( #7786 )
...
- Add a 'Setup template credentials' view to setup the credentials of a
template before it is created
2023-11-27 16:30:28 +02:00
Val
27e048c201
feat: Add Licensed decorator (no-changelog) ( #7828 )
...
Github issue / Community forum post (link here to close automatically):
2023-11-27 13:46:18 +00:00
Michael Kret
d667bca658
feat(Notion Node): Option to simplify output in getChildBlocks operation ( #7791 )
...
Github issue / Community forum post (link here to close automatically):
---------
Co-authored-by: Marcus <marcus@n8n.io>
2023-11-27 15:02:57 +02:00
Csaba Tuncsik
137e23853f
feat: Add user role select to users list settings page ( #7796 )
...
2023-11-27 13:38:03 +01:00
Val
5acb7b94c0
refactor: Refactor variables controller into a RestController (no-changelog) ( #7822 )
...
Github issue / Community forum post (link here to close automatically):
2023-11-27 12:17:09 +00:00
Iván Ovejero
7b8532d3a3
refactor(core): Move execution progress saving to standalone utility (no-changelog) ( #7770 )
...
This PR continues the effort of moving logic inside execution lifecycle
hooks into standalone testable functions, as a stepping stone to
refactoring the hooks themselves.
2023-11-27 13:10:43 +01:00
कारतोफ्फेलस्क्रिप्ट™
2807ddcd0d
fix(editor): Setup push connection in NodeView (no-changelog) ( #7821 )
2023-11-27 12:48:48 +01:00
Iván Ovejero
75a5807c72
perf(core): Make user controller tests faster (no-changelog) ( #7819 )
...
Before: `17.949 s`
After: `3.886 s`
Followup to:
https://github.com/n8n-io/n8n/pull/7797#discussion_r1404148034
2023-11-27 11:56:06 +01:00
Csaba Tuncsik
83086af247
build: Fix vite config (switch to module type) ( #7818 )
2023-11-27 10:56:57 +01:00
Alex Grozav
7cc7f226e5
fix(editor): Fix broken element-plus loading spinner (no-changelog) ( #7817 )
...
<img width="976" alt="image"
src="https://github.com/n8n-io/n8n/assets/6179477/aea8a4c8-277e-4527-b6e9-a5c3427097b6 ">
<img width="117" alt="image"
src="https://github.com/n8n-io/n8n/assets/6179477/14c8876c-5e26-4154-9fdf-8b1fe9e5f806 ">
2023-11-27 10:50:50 +02:00
कारतोफ्फेलस्क्रिप्ट™
1b60cfb8f1
ci: Fix new user patching endpoint tests (no-changelog) ( #7816 )
...
user ids are uuids, and in the future we should add proper input
validation to prevent invalid user ids reaching the DB like this.
2023-11-27 09:35:09 +01:00
Csaba Tuncsik
152883eed1
build: Upgrade lint related packages ( #7790 )
2023-11-27 09:11:52 +01:00
कारतोफ्फेलस्क्रिप्ट™
d2c18c5727
fix(core): Use AbortController to notify nodes to abort execution ( #6141 )
...
and add support for cancelling ongoing operations inside a node.
---------
Co-authored-by: Oleg Ivaniv <me@olegivaniv.com>
2023-11-24 18:17:06 +01:00
Milorad FIlipović
0ec67dabf7
fix(editor): Fix UserStack vertical centering (no-changelog) ( #7806 )
...
Dropdown items in `UserStack`component are not properly vertically
aligned. That's particularly noticeable when the items are hovered:
2023-11-24 16:38:11 +01:00
Iván Ovejero
eec2ec1ff8
refactor(core): Consolidate path-related errors in Sentry (no-changelog) ( #7757 )
...
Keep reporting [path-related
errors](https://n8nio.sentry.io/issues/4649493725 ) in Sentry but
consolidate them in a single error group.
Also, add `options.extra` as `meta` so they remain visible in debug
logs:
```
2023-11-24T11:50:54.852Z | error | ReportableError: Something went wrong "{ test: 123, file: 'LoggerProxy.js', function: 'exports.error' }"
```
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-11-24 14:42:46 +01:00
Iván Ovejero
7a86d36068
feat(core): Allow user role modification ( #7797 )
...
https://linear.app/n8n/issue/PAY-985
```
PATCH /users/:id/role
unauthenticated user
✓ should receive 401 (349 ms)
member
✓ should fail to demote owner to member (349 ms)
✓ should fail to demote owner to admin (359 ms)
✓ should fail to demote admin to member (381 ms)
✓ should fail to promote other member to owner (353 ms)
✓ should fail to promote other member to admin (377 ms)
✓ should fail to promote self to admin (354 ms)
✓ should fail to promote self to owner (371 ms)
admin
✓ should receive 400 on invalid payload (351 ms)
✓ should receive 404 on unknown target user (351 ms)
✓ should fail to demote owner to admin (349 ms)
✓ should fail to demote owner to member (347 ms)
✓ should fail to promote member to owner (384 ms)
✓ should fail to promote admin to owner (350 ms)
✓ should be able to demote admin to member (354 ms)
✓ should be able to demote self to member (350 ms)
✓ should be able to promote member to admin (349 ms)
owner
✓ should be able to promote member to admin (349 ms)
✓ should be able to demote admin to member (349 ms)
✓ should fail to demote self to admin (348 ms)
✓ should fail to demote self to member (354 ms)
```
2023-11-24 11:40:08 +01:00
Tomi Turtiainen
87fa3c2985
test: Remove obsolete snapshot ( #7803 )
...
Fixes
```
Snapshots 1 obsolete
↳ src/components/banners/__tests__/V1Banner.spec.ts
· V1 Banner > should render banner if user is not woner 1
```
2023-11-24 11:53:28 +02:00
Elias Meire
da851986f6
feat(editor): Add node name and version to NDV node settings ( #7731 )
...
<img width="580" alt="image"
src="https://github.com/n8n-io/n8n/assets/8850410/85ac1c6e-9116-436a-a2ed-8d0ac162a287 ">
<img width="580" alt="image"
src="https://github.com/n8n-io/n8n/assets/8850410/08b37377-cef5-4f80-80c0-addfdd37f728 ">
---------
Co-authored-by: Giulio Andreini <andreini@netseven.it>
2023-11-23 18:28:07 +01:00
Elias Meire
902beffce5
fix(editor): Disable context menu actions in read-only mode ( #7789 )
...
Github issue / Community forum post (link here to close automatically):
2023-11-23 17:10:45 +01:00
Val
865192adf0
feat: Add global admin role (no-changelog) ( #7781 )
...
Github issue / Community forum post (link here to close automatically):
2023-11-23 13:38:11 +00:00
Michael Auerswald
5835e055d3
fix(editor): Show nice error when environment is not set up ( #7778 )
...
Adds a nicer error message with a link for owners who press Push to Git
without having a repository connected yet.
2023-11-23 13:50:03 +01:00
Alex Grozav
67a88914f2
feat(editor): Add routing middleware, permission checks, RBAC store, RBAC component ( #7702 )
...
Github issue / Community forum post (link here to close automatically):
---------
Co-authored-by: Csaba Tuncsik <csaba@n8n.io>
2023-11-23 13:22:47 +02:00
Iván Ovejero
fdb2c18ecc
fix(core): Tighten checks for multi-main setup usage ( #7788 )
...
https://n8nio.slack.com/archives/C05HRPLSGTT/p1700731476321999?thread_ts=1700729359.746899&cid=C05HRPLSGTT
2023-11-23 12:18:39 +01:00
Marcus
6208af07eb
fix(HTTP Request Node): Enable expressions for binary input data fields ( #7782 )
...
Github issue / Community forum post (link here to close automatically):
https://github.com/n8n-io/n8n/issues/7775
2023-11-23 11:58:50 +01:00
Csaba Tuncsik
e128b23a2b
build: Upgrade to Vite 5 ( #7784 )
2023-11-23 11:55:02 +01:00
Milorad FIlipović
77bc8ecd4b
feat(editor): Show avatars for users currently working on the same workflow ( #7763 )
...
This PR introduces the following changes:
- New Vue stores: `collaborationStore` and `pushConnectionStore`
- Front-end push connection handling overhaul: Keep only a singe
connection open and handle it from the new store
- Add user avatars in the editor header when there are multiple users
working on the same workflow
- Sending a heartbeat event to back-end service periodically to confirm
user is still active
- Back-end overhauls (authored by @tomi):
- Implementing a cleanup procedure that removes inactive users
- Refactoring collaboration service current implementation
---------
Co-authored-by: Tomi Turtiainen <10324676+tomi@users.noreply.github.com>
2023-11-23 10:14:34 +01:00
Michael Kret
99a9ea497a
feat(core): Add Support for custom CORS origins for webhooks ( #7455 )
...
node-850
https://community.n8n.io/t/add-ability-to-set-cors-allow-list-in-n8n-webhooks/7610
https://community.n8n.io/t/configure-cors-pre-flight-request-option-method-in-the-roadmap/32189
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-11-22 17:49:56 +01:00
कारतोफ्फेलस्क्रिप्ट™
96fd2c51bd
fix(core): Show webhook urls for all webhook nodes (no-changelog) ( #7783 )
...
This reverts parts of https://github.com/n8n-io/n8n/pull/7113
2023-11-22 17:45:26 +01:00
Csaba Tuncsik
50f568560f
perf: Make frontend linting faster (no-changelog) ( #7717 )
...
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-11-22 15:01:22 +01:00
github-actions[bot]
e01617ad64
🚀 Release 1.18.0 ( #7780 )
...
#
[1.18.0](https://github.com/n8n-io/n8n/compare/n8n@1.17.0...n8n@1.18.0 )
(2023-11-22)
### Bug Fixes
* **core:** Account for non-ASCII chars in filename on binary data
download ([#7742 ](https://github.com/n8n-io/n8n/issues/7742 ))
([b4ebb1ab4ebb1a28d#7724 ](https://github.com/n8n-io/n8n/issues/7724 ))
([f96c1d2f96c1d2044#7744 ](https://github.com/n8n-io/n8n/issues/7744 ))
([b7c5c74b7c5c7406f#7750 ](https://github.com/n8n-io/n8n/issues/7750 ))
([6be453b6be453b716#7723 ](https://github.com/n8n-io/n8n/issues/7723 ))
([e2ffd39e2ffd397fc#7730 ](https://github.com/n8n-io/n8n/issues/7730 ))
([ebee1a5ebee1a5908#7761 ](https://github.com/n8n-io/n8n/issues/7761 ))
([366cd67366cd672a7#7766 ](https://github.com/n8n-io/n8n/issues/7766 ))
([0d3d33d0d3d33dd1f#7722 ](https://github.com/n8n-io/n8n/issues/7722 ))
([44d3b3e44d3b3ed7e#7764 ](https://github.com/n8n-io/n8n/issues/7764 ))
([ff0b651ff0b6511f7#7608 ](https://github.com/n8n-io/n8n/issues/7608 ))
([2064f7f2064f7f251#7734 ](https://github.com/n8n-io/n8n/issues/7734 ))
([ce002a6ce002a6cc6#7729 ](https://github.com/n8n-io/n8n/issues/7729 ))
([5d4a52d5d4a52d3b7#7678 ](https://github.com/n8n-io/n8n/issues/7678 ))
([4f307644f307646f3#7751 ](https://github.com/n8n-io/n8n/issues/7751 ))
([82f320282f3202a2d#7721 ](https://github.com/n8n-io/n8n/issues/7721 ))
([4dbae0e4dbae0e2e9#7643 ](https://github.com/n8n-io/n8n/issues/7643 ))
([4c408254c4082503c#7620 ](https://github.com/n8n-io/n8n/issues/7620 ))
([8d12c1a8d12c1ad8d#7503 ](https://github.com/n8n-io/n8n/issues/7503 ))
([188176518817651ec
2023-11-22 14:32:25 +01:00
कारतोफ्फेलस्क्रिप्ट™
db77353272
fix(core): Pass correct node reference to NodeExecuteFunctions.getLoadOptionsFunctions (no-changelog) ( #7779 )
...
NODE-947
2023-11-22 13:24:23 +01:00
Milorad FIlipović
2064f7f251
fix(editor): Validate user info before submiting ( #7608 )
...
Validate first and last names before saving them to database. This
should prevent security issue with un-sanitized data that ends up in
emails.
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-11-22 12:14:44 +01:00
कारतोफ्फेलस्क्रिप्ट™
9b4856e7de
feat(core): Make postgres pool-size configurable (no-changelog) ( #7772 )
...
When we upgrade typeorm in #5151 , we switched from no pooling to a
default pool-size of 10. This somehow significantly deteriorates the
performance of queries when the application is under load.
2023-11-21 18:13:08 +01:00
Iván Ovejero
3459eb6c2f
refactor(core): Include execution progress in save settings (no-changelog) ( #7769 )
2023-11-21 17:33:44 +01:00
Michael Auerswald
0d3d33dd1f
fix(editor): Only show push to git menu item to owners ( #7766 )
...
Removes the menu entry of "Push to Git" from the workflow menu for
non-owners, since they would not be able to push in the first place.
2023-11-21 15:20:15 +01:00
Michael Auerswald
ff0b6511f7
fix(editor): Use project diagram icon for worker view ( #7764 )
...
Swap monster truck for project diagram icon
2023-11-21 15:18:14 +01:00
Marcus
4f307646f3
fix(Item Lists Node): Don't check same type in remove duplicates operation ( #7678 )
...
Github issue / Community forum post (link here to close automatically):
---------
Co-authored-by: Michael Kret <michael.k@radency.com>
2023-11-21 13:10:59 +01:00
Michael Auerswald
366cd672a7
fix(editor): Move workerview entry into settings menu ( #7761 )
...
As the worker view is not an essential function, it is being moved from
the main side bar to the settings side bar for the time being.
2023-11-21 11:29:24 +01:00
Iván Ovejero
b7c5c7406f
fix(core): Ensure failed executions are saved in queue mode ( #7744 )
...
This PR adds `status` to run data so that
`determineFinalExecutionStatus` resolves correctly on execution failure
and removes the cleanup that is being duplicated in a worker hook.
Followup to https://github.com/n8n-io/n8n/pull/7138
Should fix:
- https://github.com/n8n-io/n8n/issues/7705
-
https://linear.app/n8n/issue/PAY-964/no-execution-found-after-execution-fails
-
https://linear.app/n8n/issue/PAY-1010/execution-deletion-in-queue-mode-not-complying-with-settings
2023-11-20 16:03:02 +01:00
Deborah
ad04986ce7
docs: Update docs links for data transformation functions and ifEmpty ( #7758 )
...
Github issue / Community forum post (link here to close automatically):
2023-11-20 13:40:28 +00:00
Elias Meire
8d12c1ad8d
feat(editor): Add node context menu ( #7620 )
...
2023-11-20 14:37:12 +01:00
Milorad FIlipović
4dbae0e2e9
feat: Add Creator hub link to Templates page ( #7721 )
...
Replace the `New Blank Workflow` button with link to the new Creator Hub
in the Templates page
2023-11-20 10:51:46 +01:00
Iván Ovejero
0fda8d9aac
refactor(core): Stop reporting to Sentry NodeApiError outside 500 range (no-changelog) ( #7753 )
...
https://n8nio.sentry.io/issues/4312838883 (and many others)
Followup to https://github.com/n8n-io/n8n/pull/7662
2023-11-17 17:49:28 +01:00
Iván Ovejero
6be453b716
fix(core): Guard against node not found on cancelling test webhook ( #7750 )
...
https://n8nio.sentry.io/issues/4623682198
2023-11-17 17:10:26 +01:00
Iván Ovejero
82f3202a2d
fix(JotForm Trigger Node): Fix iteration on form loader ( #7751 )
...
https://n8nio.sentry.io/issues/4636463129
2023-11-17 16:42:30 +01:00
Iván Ovejero
6d19f88080
refactor(core): Stop reporting to Sentry unknown cred on mapping (no-changelog) ( #7752 )
...
https://n8nio.sentry.io/issues/4563418905
2023-11-17 16:17:44 +01:00
Iván Ovejero
4c4082503c
feat(core): Coordinate manual workflow activation and deactivation in multi-main scenario ( #7643 )
...
Followup to #7566 | Story: https://linear.app/n8n/issue/PAY-926
### Manual workflow activation and deactivation
In a multi-main scenario, if the user manually activates or deactivates
a workflow, the process (whether leader or follower) that handles the
PATCH request and updates its internal state should send a message into
the command channel, so that all other main processes update their
internal state accordingly:
- Add to `ActiveWorkflows` if activating
- Remove from `ActiveWorkflows` if deactivating
- Remove and re-add to `ActiveWorkflows` if the update did not change
activation status.
After updating their internal state, if activating or deactivating, the
recipient main processes should push a message to all connected
frontends so that these can update their stores and so reflect the value
in the UI.
### Workflow activation errors
On failure to activate a workflow, the main instance should record the
error in Redis - main instances should always pull activation errors
from Redis in a multi-main scenario.
### Leadership change
On leadership change...
- The old leader should stop pruning and the new leader should start
pruning.
- The old leader should remove trigger- and poller-based workflows and
the new leader should add them.
2023-11-17 15:58:50 +01:00
कारतोफ्फेलस्क्रिप्ट™
2d039010db
fix(editor): Fix Admin panel icon in the sidebar for cloud deployments (no-changelog) ( #7738 )
...
Co-authored-by: ricardo <ricardoespinoza105@gmail.com>
Co-authored-by: Mutasem Aldmour <mutasem@n8n.io>
2023-11-17 14:44:47 +01:00
कारतोफ्फेलस्क्रिप्ट™
b66b8c18e9
fix(editor): Remove n8nHooksNext flag (no-changelog) ( #7733 )
...
Hooks won't be injected anymore
https://github.com/n8n-io/n8n-hosted-backend/pull/816
2023-11-17 14:44:28 +01:00
Mutasem Aldmour
44d3b3ed7e
fix(editor): Show v1 banner dismiss button if owner ( #7722 )
...
Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/v1-upgrade-banner-shall-be-dismissed-permanently/32775
2023-11-17 14:15:13 +01:00
Jon
ce002a6cc6
fix(GitHub Node): Fix issue preventing file edits on branches ( #7734 )
...
Github issue / Community forum post (link here to close automatically):
https://github.com/n8n-io/n8n/issues/7614
2023-11-17 13:07:33 +00:00
कारतोफ्फेलस्क्रिप्ट™
db094f2d7e
fix(core): Fix all dependency versions for backend packages (no-changelog) ( #7745 )
...
Once the packages are published to NPM, they don't have the
`pnpm-lock.yaml` to fix dependency versions. Which means that any
dependency with `^` gets auto-upgrade to the latest matching minor,
which can cause issues like
[this](https://github.com/node-cache-manager/node-cache-manager/issues/611 ).
2023-11-17 13:49:18 +01:00
कारतोफ्फेलस्क्रिप्ट™
fc60e9a809
refactor(core): Convert dynamic node-parameter routes to a decorated controller (no-changelog) ( #7284 )
...
1. Reduce a lot of code duplication
2. Move more endpoints out of `Server.ts`
3. Move all query-param parsing and validation into a middleware to make
the route handlers simpler.
2023-11-17 12:03:05 +01:00
Iván Ovejero
05ed86c64b
refactor: Stop reporting to Sentry Facebook multi-webhook error (no-changelog) ( #7743 )
...
https://n8nio.sentry.io/issues/4640072705
2023-11-17 11:39:46 +01:00
Iván Ovejero
0408299c7d
refactor(core): Stop reporting to Sentry unrecognized node errors (no-changelog) ( #7728 )
...
https://n8nio.sentry.io/issues/4636584213
2023-11-17 10:25:10 +01:00
Iván Ovejero
b4ebb1a28d
fix(core): Account for non-ASCII chars in filename on binary data download ( #7742 )
...
https://n8nio.sentry.io/issues/4641538638
2023-11-17 10:07:44 +01:00
Ricardo Espinoza
8e0ae3cf8c
refactor: Extract Invitation routes to InvitationController (no-changelog) ( #7726 )
...
This PR:
- Creates `InvitationController`
- Moves `POST /users` to `POST /invitations` and move related test to
`invitations.api.tests`
- Moves `POST /users/:id` to `POST /invitations/:id/accept` and move
related test to `invitations.api.tests`
- Adjusts FE to use new endpoints
- Moves all the invitation logic to the `UserService`
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-11-16 12:39:43 -05:00
Csaba Tuncsik
e2ffd397fc
fix(editor): Handle permission edge cases (empty scopes) ( #7723 )
2023-11-16 18:08:23 +01:00
Iván Ovejero
5d4a52d3b7
fix(Google Sheets Node): Check for null before destructuring ( #7729 )
...
https://n8nio.sentry.io/issues/4613453684
2023-11-16 16:50:06 +01:00
Val
d39bb2540f
feat: Add scopes to /login endpoint (no-changelog) ( #7718 )
...
Github issue / Community forum post (link here to close automatically):
2023-11-16 11:11:55 +00:00
कारतोफ्फेलस्क्रिप्ट™
ebee1a5908
fix(editor): Make sure LineController is registered with chart.js ( #7730 )
...
Tree shaking in production build of the editor-ui package removed the
LineController, this makes sure it is in the final package.
2023-11-16 11:57:43 +01:00
Michael Auerswald
f96c1d2044
fix(core): Correct permissions for getstatus ( #7724 )
2023-11-15 16:54:33 +01:00
Csaba Tuncsik
18817651ec
feat(editor): Node IO filter ( #7503 )
...
Co-authored-by: Omar Ajoue <krynble@gmail.com>
2023-11-15 16:19:48 +01:00
github-actions[bot]
93103c0b08
🚀 Release 1.17.0 ( #7720 )
...
#
[1.17.0](https://github.com/n8n-io/n8n/compare/n8n@1.16.0...n8n@1.17.0 )
(2023-11-15)
### Bug Fixes
* **Convert to/from binary data Node:** Better mime type defaults
([#7693 ](https://github.com/n8n-io/n8n/issues/7693 ))
([9b3be0c9b3be0cfd8#7699 ](https://github.com/n8n-io/n8n/issues/7699 ))
([0e00dab0e00dab9f5#7688 ](https://github.com/n8n-io/n8n/issues/7688 ))
([4441ed54441ed5116#7628 ](https://github.com/n8n-io/n8n/issues/7628 )
* **core:** Initialize JWT Secret before it's used anywhere
([#7707 ](https://github.com/n8n-io/n8n/issues/7707 ))
([3460eb53460eb5eeb#7663 ](https://github.com/n8n-io/n8n/issues/7663 ))
([9fd63199fd6319583#7675 ](https://github.com/n8n-io/n8n/issues/7675 ))
([d2d11e0d2d11e0208#7664 ](https://github.com/n8n-io/n8n/issues/7664 ))
([00dff5000dff50140#7685 ](https://github.com/n8n-io/n8n/issues/7685 ))
([37dd65837dd658dc5#7645 ](https://github.com/n8n-io/n8n/issues/7645 ))
([020042e020042ef1a#7684 ](https://github.com/n8n-io/n8n/issues/7684 ))
([88efb9988efb99587#7686 ](https://github.com/n8n-io/n8n/issues/7686 ))
([48b240b48b240b026#7653 ](https://github.com/n8n-io/n8n/issues/7653 )
* **HubSpot Node:** Fetching available parameters fails when using
expressions ([#7672 ](https://github.com/n8n-io/n8n/issues/7672 ))
([a9ab738a9ab73896e#7673 ](https://github.com/n8n-io/n8n/issues/7673 ))
([3c0734b3c0734bd2d#7701 ](https://github.com/n8n-io/n8n/issues/7701 ))
([786b4ad786b4adcce#7660 ](https://github.com/n8n-io/n8n/issues/7660 ))
([1c7225e1c7225ebdb#7661 ](https://github.com/n8n-io/n8n/issues/7661 ))
([aea3c50aea3c50131#5351 ](https://github.com/n8n-io/n8n/issues/5351 ))
([6a53c2a6a53c2a375#7674 ](https://github.com/n8n-io/n8n/issues/7674 ))
([2e8c8412e8c841277#7453 ](https://github.com/n8n-io/n8n/issues/7453 ))
([83593648359364536#7157 ](https://github.com/n8n-io/n8n/issues/7157 ))
([14035e114035e1244#7456 ](https://github.com/n8n-io/n8n/issues/7456 ))
([afd637bafd637b5ea#7600 ](https://github.com/n8n-io/n8n/issues/7600 ))
([cbc6909cbc690907f#7529 ](https://github.com/n8n-io/n8n/issues/7529 ))
([0a0798e0a0798e485#7655 ](https://github.com/n8n-io/n8n/issues/7655 ))
([a9c7188a9c7188c4d#7547 ](https://github.com/n8n-io/n8n/issues/7547 ))
([5aee2b75aee2b768f#7679 ](https://github.com/n8n-io/n8n/issues/7679 ))
([819b3a7819b3a746a#7689 ](https://github.com/n8n-io/n8n/issues/7689 ))
([a08fca5a08fca51d9#7696 ](https://github.com/n8n-io/n8n/issues/7696 ))
([b2ca050b2ca050031
2023-11-15 15:18:08 +01:00
कारतोफ्फेलस्क्रिप्ट™
2844ce2bd2
ci: Fix env issues in e2e tests (no-changelog) ( #7719 )
2023-11-15 13:58:38 +01:00
Giulio Andreini
0cebd28582
fix(editor): Dark mode sticky notes (no-changelog) ( #7716 )
2023-11-15 12:56:09 +01:00
Ricardo Espinoza
4020c14d59
refactor: Use POST /users to re-invite users (no-changelog) ( #7714 )
2023-11-15 06:40:57 -05:00
कारतोफ्फेलस्क्रिप्ट™
3460eb5eeb
fix(core): Initialize JWT Secret before it's used anywhere ( #7707 )
...
HELP-394
2023-11-15 12:17:18 +01:00
EMRE TEOMAN
5aee2b768f
feat(RabbitMQ Trigger Node): Add exchange and routing key options ( #7547 )
...
RabbitMQ trigger needs binding for some cases. For example, I need to
consume some domain events in my application and they are published with
routing key.
---------
Co-authored-by: teomane <emre.teoman@bordatech.com>
2023-11-15 11:02:54 +00:00
Jon
5b9ec8eeb5
docs(DebugHelper Node): Add aliases to improve discoverability ( #7676 )
...
Github issue / Community forum post (link here to close automatically):
2023-11-15 10:54:36 +00:00
Jon
2e8c841277
feat(Discourse Node): Add new options to Get Users ( #7674 )
2023-11-15 10:07:09 +00:00
Jon
b1f678856b
docs(Google Sheets Node): Change Get Many to Get Row(s) ( #7677 )
...
Github issue / Community forum post (link here to close automatically):
2023-11-15 10:05:36 +00:00
Michael Kret
88efb99587
fix(Google Sheets Node): Append exceeding grid limits ( #7684 )
...
Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/error-appending-data-with-google-sheets/28691
2023-11-15 11:33:47 +02:00
कारतोफ्फेलस्क्रिप्ट™
4441ed5116
fix(core): Fix named parameter resolution in migrations ( #7688 )
...
Fixes #7628
2023-11-15 10:31:08 +01:00
Jon
91c3ea87fe
fix(HubSpot Node): Fix typo in Company update fields (no-changelog) ( #7711 )
...
Github issue / Community forum post (link here to close automatically):
2023-11-15 08:43:43 +00:00
Elias Meire
48b240b026
fix(HTTP Request Node): Support generic credentials when using pagination ( #7686 )
...
Github issue / Community forum post (link here to close automatically):
fixes #7653
Co-authored-by: Michael Kret <michael.k@radency.com>
2023-11-15 09:13:33 +01:00
Anton Dollmaier
0a0798e485
feat(GitLab Node): Add support for pagination on getIssues ( #7529 )
2023-11-14 17:49:29 +00:00
Giulio Andreini
f1e7ef0117
fix(editor): Dark mode switch style fix and other tweaks (no-changelog) ( #7599 )
...
Github issue / Community forum post (link here to close automatically):
2023-11-14 17:13:30 +01:00
Jon
a9c7188c4d
feat(OpenAI Node): Add dall-e-3 support ( #7655 )
...
Adds support for dall-e-3 under Image
Removes GPT 4 Vision from Chat completion for now
Cleans up Model list for text completion by removing dall-e and tts
2023-11-14 10:34:45 +00:00
Jon
819b3a746a
feat(Telegram Node): Add support for markdownv2 ( #7679 )
...
Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/telegram-markdownv2-style/32675
2023-11-14 10:33:35 +00:00
Elias Meire
786b4adcce
fix(Spreadsheet File Node): Read file as utf-8 in v1 ( #7701 )
...
Github issue / Community forum post (link here to close automatically):
2023-11-14 11:27:37 +01:00
Michael Auerswald
0e00dab9f5
fix(core): Consider subworkflows successfully run when in waiting state ( #7699 )
...
Github issue / Community forum post (link here to close automatically):
https://github.com/n8n-io/n8n/issues/7189
2023-11-14 11:04:24 +01:00
Michael Kret
9b3be0cfd8
fix(Convert to/from binary data Node): Better mime type defaults ( #7693 )
...
Github issue / Community forum post (link here to close automatically):
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-11-13 16:52:50 +02:00
Alex Grozav
a262c450f7
feat: Rewrite Front End cloud and posthog hooks using TypeScript (no-changelog) ( #5491 )
2023-11-13 15:10:42 +02:00
Elias Meire
a9ab73896e
fix(HubSpot Node): Fetching available parameters fails when using expressions ( #7672 )
...
This fix affects all nodes, will fix this issue in all nodes
Github issue / Community forum post (link here to close automatically):
Co-authored-by: Michael Kret <michael.k@radency.com>
2023-11-13 12:28:55 +01:00
Michael Kret
1c7225ebdb
feat(core): Expression function $ifEmpty ( #7660 )
...
Github issue / Community forum post (link here to close automatically):
---------
Co-authored-by: Elias Meire <elias@meire.dev>
2023-11-13 13:28:41 +02:00
Elias Meire
14035e1244
feat(editor): Add HTTP request nodes for credentials without a node ( #7157 )
...
Github issue / Community forum post (link here to close automatically):
---------
Co-authored-by: Giulio Andreini <g.andreini@gmail.com>
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-11-13 12:11:16 +01:00
Michael Kret
460ac85fda
fix(core): Send pairedItem error to Posthog (no-changelog) ( #7697 )
...
Github issue / Community forum post (link here to close automatically):
2023-11-13 13:07:12 +02:00
Iván Ovejero
b2ca050031
perf(core): Lazyload security audit reporters ( #7696 )
...
Also converting to service.
Followup to https://github.com/n8n-io/n8n/pull/7663
2023-11-13 11:50:43 +01:00
Ricardo Espinoza
a08fca51d9
feat(Venafi TLS Protect Cloud Node): Add region parameter to Venafi protect cloud ( #7689 )
...
Github issue / Community forum post (link here to close automatically):
2023-11-11 10:35:56 -05:00
Michael Auerswald
cbc690907f
feat(editor): Adds a EE view to show worker details and job status ( #7600 )
...
This change expands on the command channel communication introduced
lately between the main instance(s) and the workers. The frontend gets a
new menu entry "Workers" which will, when opened, trigger a regular call
to getStatus from the workers. The workers then respond via their
response channel to the backend, which then pushes the status to the
frontend.
This introduces the use of ChartJS for metrics.
This feature is still in MVP state and thus disabled by default for the
moment.
2023-11-10 23:48:31 +01:00
Ricardo Espinoza
0ddafd2b82
test: Unify users.controller.test and users.api.test (no-changelog) ( #7658 )
...
Groundwork to be able to safely refactor and move the invitation logic
to the UserService.
Fixes ADO-1358
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-11-10 09:41:58 -05:00
कारतोफ्फेलस्क्रिप्ट™
000e76e3b4
ci(core): Reduce memory usage in tests (part-2) (no-changelog) ( #7671 )
...
This also gets rid of `Db.collection`, which was another source of
circular dependencies.
2023-11-10 15:04:26 +01:00
Csaba Tuncsik
37dd658dc5
fix(editor): More securely clear executions tab auto refresh timer ( #7685 )
2023-11-10 14:51:49 +01:00
Elias Meire
d2d11e0208
fix(Date & Time Node): Add fromFormat option to solve ambiguous date strings ( #7675 )
...
Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/spreadsheet-date-issue/31551
---------
Co-authored-by: Michael Kret <michael.k@radency.com>
2023-11-10 14:30:13 +01:00
Elias Meire
3c0734bd2d
fix(HubSpot Node): Update deal owner on Hubspot Deal ( #7673 )
...
Github issue / Community forum post (link here to close automatically):
2023-11-10 11:10:11 +01:00
Elias Meire
00dff50140
fix(editor): Fix resource mapper component being truncated ( #7664 )
...
Github issue / Community forum post (link here to close automatically):
2023-11-10 10:43:47 +01:00
Iván Ovejero
f73a0597ba
refactor: Add rule no-constant-binary-expression (no-changelog) ( #7670 )
...
https://eslint.org/docs/latest/rules/no-constant-binary-expression
2023-11-09 17:50:59 +01:00
Giulio Andreini
40dc5a0d85
docs(Send Email Node): Add description to Email Format (no-changelog) ( #7667 )
...
Github issue / Community forum post (link here to close automatically):
Co-authored-by: Marcus <marcus@n8n.io>
2023-11-09 17:09:01 +01:00
Michael Kret
aea3c50131
feat(Date & Time Node): Option to include other fields in output item ( #7661 )
...
Github issue / Community forum post (link here to close automatically):
Community:
https://community.n8n.io/t/date-time-deletes-incoming-props/27492/3
GH Issue: https://github.com/n8n-io/n8n/issues/7646
---------
Co-authored-by: Marcus <marcus@n8n.io>
2023-11-09 17:57:33 +02:00
Michael Kret
18623c7376
feat(Microsoft Excel 365 Node): Alias update (no-changelog) ( #7659 )
...
Github issue / Community forum post (link here to close automatically):
2023-11-09 16:56:59 +02:00
कारतोफ्फेलस्क्रिप्ट™
9fd6319583
fix(core): Reduce memory usage in credentials risk auditing ( #7663 )
2023-11-09 14:39:16 +01:00
कारतोफ्फेलस्क्रिप्ट™
5edf722209
ci: Stop disabling linting rules that are explicitly set to warn (no-changelog) ( #7669 )
2023-11-09 14:05:39 +01:00
Iván Ovejero
16a1a92f18
refactor(core): Stop reporting to Sentry credential-not-found error (no-changelog) ( #7665 )
...
https://n8nio.sentry.io/issues/4528134408
2023-11-09 10:55:13 +01:00
Val
0468ded0db
feat: Add permissions package (no-changelog) ( #7650 )
...
Github issue / Community forum post (link here to close automatically):
2023-11-08 15:42:40 +00:00
कारतोफ्फेलस्क्रिप्ट™
0346b211a7
ci(core): Reduce memory usage in tests (part-1) (no-changelog) ( #7654 )
2023-11-08 16:29:39 +01:00
Michael Kret
6a53c2a375
feat(Discord Node): Overhaul ( #5351 )
...
Github issue / Community forum post (link here to close automatically):
---------
Co-authored-by: Giulio Andreini <g.andreini@gmail.com>
Co-authored-by: Marcus <marcus@n8n.io>
2023-11-08 16:11:23 +02:00
Ricardo Espinoza
afd637b5ea
feat(editor): Add workflow filters to querystring ( #7456 )
...
fixes:
https://linear.app/n8n/issue/ADO-1222/feature-save-filters-in-workflows
2023-11-08 08:42:53 -05:00
कारतोफ्फेलस्क्रिप्ट™
8171ad4fa8
Merge tag 'n8n@1.16.0'
2023-11-08 14:31:09 +01:00
Ricardo Espinoza
8359364536
feat(editor): Add color selector to sticky node ( #7453 )
...
fixes: https://linear.app/n8n/issue/ADO-1223/feature-sticky-colors
---------
Co-authored-by: Giulio Andreini <g.andreini@gmail.com>
Co-authored-by: Mutasem <mutdmour@gmail.com>
2023-11-08 08:23:57 -05:00
github-actions[bot]
e5c6a1bdf9
🚀 Release 1.16.0 ( #7652 )
...
#
[1.16.0](https://github.com/n8n-io/n8n/compare/n8n@1.15.1...n8n@1.16.0 )
(2023-11-08)
### Bug Fixes
* **core:** Comply with custom default for workflow saving settings
([#7634 ](https://github.com/n8n-io/n8n/issues/7634 ))
([48c068f48c068f97b#7598 ](https://github.com/n8n-io/n8n/issues/7598 ))
([2aa7f632aa7f6375a#7621 ](https://github.com/n8n-io/n8n/issues/7621 ))
([a994ba5a994ba5e8d#7626 ](https://github.com/n8n-io/n8n/issues/7626 ))
([f748de9f748de9567#7618 ](https://github.com/n8n-io/n8n/issues/7618 ))
([26361df26361dfcd3#6229 ](https://github.com/n8n-io/n8n/issues/6229 )
* **core:** Make password-reset urls valid only for single-use
([#7622 ](https://github.com/n8n-io/n8n/issues/7622 ))
([603142460314248f4#7619 ](https://github.com/n8n-io/n8n/issues/7619 ))
([5df583f5df583f783#7591 ](https://github.com/n8n-io/n8n/issues/7591 ))
([2854a0c2854a0cf46#7596 ](https://github.com/n8n-io/n8n/issues/7596 ))
([db56a9edb56a9ee37#7603 ](https://github.com/n8n-io/n8n/issues/7603 ))
([151e60f151e60f829#7644 ](https://github.com/n8n-io/n8n/issues/7644 ))
([3d5a4853d5a485bcf#7597 ](https://github.com/n8n-io/n8n/issues/7597 ))
([b532a7bb532a7bdb7#7582 ](https://github.com/n8n-io/n8n/issues/7582 ))
([d633753d633753687#7625 ](https://github.com/n8n-io/n8n/issues/7625 ))
([78b84af78b84af8d1#7602 ](https://github.com/n8n-io/n8n/issues/7602 ))
([c92402ac92402a3ca#7616 ](https://github.com/n8n-io/n8n/issues/7616 ))
([32b85ba32b85ba2fe#7449 ](https://github.com/n8n-io/n8n/issues/7449 ))
([59dc36a59dc36abd9#7566 ](https://github.com/n8n-io/n8n/issues/7566 ))
([c857e42c857e42677#7570 ](https://github.com/n8n-io/n8n/issues/7570 ))
([ac87701ac877014ed#7586 ](https://github.com/n8n-io/n8n/issues/7586 ))
([7dac9ab7dac9ab82c#7604 ](https://github.com/n8n-io/n8n/issues/7604 ))
([5790e255790e251b8#7489 ](https://github.com/n8n-io/n8n/issues/7489 ))
([e6d3d1ae6d3d1a4c2#7329 ](https://github.com/n8n-io/n8n/issues/7329 ))
([da2d2a8da2d2a83bb
2023-11-08 14:20:22 +01:00
Csaba Tuncsik
020042ef1a
fix(editor): Redirect to workflow editor after saving in debug mode ( #7645 )
2023-11-08 14:04:02 +01:00
Jon
5df583f783
fix(Crypto Node): Fix issue with value not appearing for Sign action ( #7619 )
...
Github issue / Community forum post (link here to close automatically):
https://github.com/n8n-io/n8n/issues/7611
2023-11-08 10:22:15 +00:00
mertmit
da2d2a83bb
feat(NocoDB Node): Add new data apis and workspace support ( #7329 )
...
- Changed old NocoDB logo with new one
To support new release of [NocoDB
(v0.202.4)](https://github.com/nocodb/nocodb/releases/tag/0.202.4 ):
- Added a new version(3) to support new data apis and workspaces
- Renamed `project` to `base` for new version (kept labels for old
versions for backwards compatibility)
---------
Signed-off-by: mertmit <mertmit99@gmail.com>
Co-authored-by: Jonathan Bennetts <jonathan.bennetts@gmail.com>
2023-11-08 10:04:35 +00:00
Yulian Diaz
32b85ba2fe
fix(Facebook Lead Ads Trigger Node): Fix issue with missing scope for business management ( #7616 )
...
Github issue / Community forum post (link here to close automatically):
Community:
https://community.n8n.io/t/facebook-lead-trigger-issue-with-permissions/32500
GH Issue: https://github.com/n8n-io/n8n/issues/7615
2023-11-08 10:02:18 +00:00
Iván Ovejero
3a776e0132
refactor(core): Stop reporting to Sentry missing-node-on-retry error (no-changelog) ( #7648 )
...
https://n8nio.sentry.io/issues/4612370603
2023-11-08 10:09:33 +01:00
Csaba Tuncsik
3d5a485bcf
fix(editor): Fix workflow history prune time limit (getting hours instead of days) ( #7644 )
2023-11-07 17:44:58 +01:00
Iván Ovejero
48c068f97b
fix(core): Comply with custom default for workflow saving settings ( #7634 )
...
https://linear.app/n8n/issue/PAY-982
2023-11-07 16:26:55 +01:00
Tomi Turtiainen
ac877014ed
feat(core): Initial support for two-way communication over websockets ( #7570 )
...
- Enable two-way communication with web sockets
- Enable sending push messages to specific users
- Add collaboration service for managing active users for workflow
Missing things:
- State is currently kept only in memory, making this not work in
multi-master setups
- Removing a user from active users in situations where they go inactive
or we miss the "workflow closed" message
- I think a timer based solution for this would cover most edge cases.
I.e. have FE ping every X minutes, BE removes the user unless they have
received a ping in Y minutes, where Y > X
- FE changes to be added later by @MiloradFilipovic
Github issue / Community forum post (link here to close automatically):
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-11-07 17:26:45 +02:00
कारतोफ्फेलस्क्रिप्ट™
a3a26109c6
ci: Conditionally re-enable coverage for frontend packages (no-changelog) ( #7641 )
...
Disabled coverage in https://github.com/n8n-io/n8n/pull/7637 , but forgot
to conditionally re-enable them for builds on `master`
2023-11-07 15:59:25 +01:00
कारतोफ्फेलस्क्रिप्ट™
f0fc5b16d3
ci(core): Load config schema after process.env has been overwritten (no-changelog) ( #7550 )
2023-11-07 15:58:28 +01:00
कारतोफ्फेलस्क्रिप्ट™
60314248f4
fix(core): Make password-reset urls valid only for single-use ( #7622 )
2023-11-07 15:35:43 +01:00
Ricardo Espinoza
b3470fd64d
fix: Error handling on forgot password page (no-changelog) ( #7633 )
...
fixes:
https://linear.app/n8n/issue/ADO-1339/fix-error-handling-on-forgot-password-page
2023-11-07 08:45:58 -05:00
कारतोफ्फेलस्क्रिप्ट™
2f665683fc
ci: Improve CI performance (no-changelog) ( #7637 )
...
1. Split backend and frontend tests to avoid them running in parallel
2. Enable coverage only on `master`
2023-11-07 14:19:39 +01:00
Iván Ovejero
f748de9567
fix(core): Ensure pruning starts only after migrations have completed ( #7626 )
...
https://linear.app/n8n/issue/PAY-986/bug-execution-pruning-timer-is-started-before-the-database-is-ready
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-11-07 13:56:01 +01:00
Iván Ovejero
c857e42677
feat(core): Coordinate workflow activation in multiple main scenario in internal API ( #7566 )
...
Story: https://linear.app/n8n/issue/PAY-926
This PR coordinates workflow activation on instance startup and on
leadership change in multiple main scenario in the internal API. Part 3
on manual workflow activation and deactivation will be a separate PR.
### Part 1: Instance startup
In multi-main scenario, on starting an instance...
- [x] If the instance is the leader, it should add webhooks, triggers
and pollers.
- [x] If the instance is the follower, it should not add webhooks,
triggers or pollers.
- [x] Unit tests.
### Part 2: Leadership change
In multi-main scenario, if the main instance leader dies…
- [x] The new main instance leader must activate all trigger- and
poller-based workflows, excluding webhook-based workflows.
- [x] The old main instance leader must deactivate all trigger- and
poller-based workflows, excluding webhook-based workflows.
- [x] Unit tests.
To test, start two instances and check behavior on startup and
leadership change:
```
EXECUTIONS_MODE=queue N8N_LEADER_SELECTION_ENABLED=true N8N_LICENSE_TENANT_ID=... N8N_LICENSE_ACTIVATION_KEY=... N8N_LOG_LEVEL=debug npm run start
EXECUTIONS_MODE=queue N8N_LEADER_SELECTION_ENABLED=true N8N_LICENSE_TENANT_ID=... N8N_LICENSE_ACTIVATION_KEY=... N8N_LOG_LEVEL=debug N8N_PORT=5679 npm run start
```
2023-11-07 13:48:48 +01:00
Mutasem Aldmour
151e60f829
fix(editor): Fix local storage flags defaulting to undefined string ( #7603 )
...
useStorage takes the default value `undefined` and sets it in local
storage.. also returns "undefined" as string which breaks onboarding
flows
Github issue / Community forum post (link here to close automatically):
2023-11-07 10:06:08 +01:00
Csaba Tuncsik
78b84af8d1
fix(editor): Reset canvas zoom before workspace reset in node view ( #7625 )
2023-11-06 18:15:49 +01:00
कारतोफ्फेलस्क्रिप्ट™
4934462b41
fix(editor): More dark-mode fixes (no-changelog) ( #7624 )
...
This fixes:
1. The `OR` divider background when SSO Login is enabled
2. Scanning of QR code in settings in dark mode
2023-11-06 14:32:38 +01:00
Iván Ovejero
26361dfcd3
fix(core): Fix accessor error when running partial execution ( #7618 )
...
https://n8nio.sentry.io/issues/3760335947
Followup to #6229
2023-11-06 13:48:13 +01:00
Jan Oberhauser
db56a9ee37
fix(editor): Fix issue that frontend breaks with unkown nodes ( #7596 )
...
Because of recent changes does the frontend break when a node is not
known.
Github issue / Community forum post (link here to close automatically):
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Oleg Ivaniv <me@olegivaniv.com>
2023-11-06 13:44:05 +01:00
Iván Ovejero
a994ba5e8d
fix(core): Ensure init before checking leader or follower in multi-main scenario ( #7621 )
...
This PR ensures `MultiMainInstancePublisher` is initialized before
checking if the instance is leader or follower. Followers skip license
init, license check, and pruning start and stop.
2023-11-06 12:03:35 +01:00
Iván Ovejero
52f655f3d2
refactor(Google Sheets Node): Stop reporting to Sentry sheet not found error (no-changelog) ( #7617 )
...
https://n8nio.sentry.io/issues/4264383378
2023-11-06 11:36:22 +01:00
Ricardo Espinoza
b11c4de039
fix(editor): Focus mfa token input (no-changelog) ( #7610 )
...
Github issue / Community forum post (link here to close automatically):
2023-11-04 20:34:05 -04:00
Ricardo Espinoza
5790e251b8
feat(core): Rate limit forgot password endpoint ( #7604 )
...
Github issue / Community forum post (link here to close automatically):
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <netroy@users.noreply.github.com>
2023-11-03 13:44:12 -04:00
कारतोफ्फेलस्क्रिप्ट™
acec9bad71
refactor(core): Convert OAuth1/OAuth2 routes to decorated controller classes (no-changelog) ( #5973 )
2023-11-03 17:20:54 +01:00
Omar Ajoue
c6049a2e97
feat(editor): Fix some UTM tags (no-changelog) ( #7583 )
...
Github issue / Community forum post (link here to close automatically):
2023-11-03 16:17:39 +01:00
Alex Grozav
24dfc95974
feat(editor): Improve performance by importing routes dynamically and add route guards (no-changelog) ( #7567 )
...
**Before:**
<img width="657" alt="image"
src="https://github.com/n8n-io/n8n/assets/6179477/0bcced2b-9d3a-43b3-80d7-3c72619941fa ">
**After:**
<img width="660" alt="image"
src="https://github.com/n8n-io/n8n/assets/6179477/e74e0bbf-bf33-49b4-ae11-65f640405ac8 ">
2023-11-03 16:22:37 +02:00
Elias Meire
c92402a3ca
fix(editor): Zoom in/out on canvas the same amount on scroll/gesture ( #7602 )
...
Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/ctrl-mousewheel-zoom-jumps-out-possible-to-avoid/31952
2023-11-03 14:09:18 +01:00
कारतोफ्फेलस्क्रिप्ट™
0bd4e742da
refactor(core): Migrate from crypto-js to native crypto ( #7556 )
...
[`crypto-js` has been
discontinued](1da3dabf93
2023-11-03 13:26:20 +01:00
Alex Grozav
135f9214f5
feat(editor): Update storybook to 7.5.2 (no-changelog) ( #7601 )
...
Github issue / Community forum post (link here to close automatically):
2023-11-03 14:14:51 +02:00
Tomi Turtiainen
2aa7f6375a
fix(core): Decrease reset password token expire time ( #7598 )
...
Decrease the expiration time from 1 day to 20 minutes
Github issue / Community forum post (link here to close automatically):
2023-11-03 13:32:08 +02:00
Jan Oberhauser
b532a7bdb7
fix(editor): Hide not supported node options ( #7597 )
...
Currently Trigger-Nodes and Sub-Nodes display options that do not make
sense or work like:
- Always Output Data
- Execute Once
- On Error
This PR hides those options for nodes that can not make use of them
anyway to not confuse users.
Github issue / Community forum post (link here to close automatically):
2023-11-03 12:18:00 +01:00
Csaba Tuncsik
85e1a10021
refactor(editor): Simplify data count in NDV (no-changelog) ( #7568 )
2023-11-03 12:07:04 +01:00
Iván Ovejero
6d42fad31a
refactor(core): Consolidate binary file not found errors (no-changelog) ( #7585 )
...
Logging was originally to see if there was a binary data file failing to
be written for [this
user](https://linear.app/n8n/issue/PAY-844/filesystem-binary-data-mode-causing-alerts-in-cloud )
but the cause was not a file failed to be written but a missing `fileId`
in a binary data item in an execution. The error should no longer be
thrown as of 1.12. See story for more info.
This PR is for cleanup and to consolidate any file not found errors in
the context of binary data, to track if this happens again.
2023-11-03 11:41:15 +01:00
Jon
e6d3d1a4c2
feat(LinkedIn Node): Add support for Article thumbnails ( #7489 )
...
Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/linkedin-post-not-showing-image-for-url/10789/
This adds a new property to add a thumbnail binary property for articles
this fixes the previews no longer working because of the LinkedIn API
change.
2023-11-03 09:50:28 +00:00
Milorad FIlipović
9c55702661
fix(editor): Fix flaky ResourceMapper unit tests (no-changelog) ( #7593 )
...
Github issue / Community forum post (link here to close automatically):
2023-11-03 09:56:19 +01:00
कारतोफ्फेलस्क्रिप्ट™
bb2c266e48
Merge tag 'n8n@1.15.1'
2023-11-02 18:11:06 +01:00
Iván Ovejero
d633753687
fix(editor): Remove unknown credentials on pasting workflow ( #7582 )
...
https://linear.app/n8n/issue/PAY-881
2023-11-02 17:26:39 +01:00
Iván Ovejero
81f43805aa
refactor(core): Stop reporting to Sentry node parameter value extraction failure (no-changelog) ( #7587 )
...
https://n8nio.sentry.io/issues/4595192919
2023-11-02 16:28:44 +01:00
Mutasem Aldmour
2854a0cf46
fix(editor): Allow overriding theme from query params ( #7591 )
...
Allow overriding theme through query params.. to be able to override it
from preview iframe in webcomponent
Github issue / Community forum post (link here to close automatically):
2023-11-02 16:06:33 +01:00
github-actions[bot]
fbce8f5298
🚀 Release 1.15.1 ( #7592 )
...
##
[1.15.1](https://github.com/n8n-io/n8n/compare/n8n@1.14.0...n8n@1.15.1 )
(2023-11-02)
### Bug Fixes
* **core:** Ensure execution deletion in worker lifecycle hook
([#7481 ](https://github.com/n8n-io/n8n/issues/7481 ))
([742c8a8742c8a8534#7560 ](https://github.com/n8n-io/n8n/issues/7560 ))
([b350568b350568505#7408 ](https://github.com/n8n-io/n8n/issues/7408 ))
([479f902479f90231d#7523 ](https://github.com/n8n-io/n8n/issues/7523 ))
([1055bd31055bd3762#7576 ](https://github.com/n8n-io/n8n/issues/7576 ))
([437c95e437c95e84e#7569 ](https://github.com/n8n-io/n8n/issues/7569 ))
([9bdb85c9bdb85c4ce#7519 ](https://github.com/n8n-io/n8n/issues/7519 ))
([65e559365e5593233#7528 ](https://github.com/n8n-io/n8n/issues/7528 ))
([ae616f1ae616f146b#7544 ](https://github.com/n8n-io/n8n/issues/7544 ))
([3b5e1813b5e181e66#7532 ](https://github.com/n8n-io/n8n/issues/7532 ))
([2853fcf2853fcff73#7434 ](https://github.com/n8n-io/n8n/issues/7434 ))
([12a89e612a89e6d14#7516 ](https://github.com/n8n-io/n8n/issues/7516 ))
([df89685df89685e15#7348 ](https://github.com/n8n-io/n8n/issues/7348 ))
([c05bc67c05bc6728d#7573 ](https://github.com/n8n-io/n8n/issues/7573 ))
([1d81afc1d81afcbdf#7534 ](https://github.com/n8n-io/n8n/issues/7534 ))
([97627059762705833#7555 ](https://github.com/n8n-io/n8n/issues/7555 ))
([7a56e587a56e58a60#7460 ](https://github.com/n8n-io/n8n/issues/7460 ))
([655efea655efeaf66#7526 ](https://github.com/n8n-io/n8n/issues/7526 ))
([3d95b243d95b243e9#7527 ](https://github.com/n8n-io/n8n/issues/7527 ))
([442c73e442c73e63b#7559 ](https://github.com/n8n-io/n8n/issues/7559 ))
([ce14f62ce14f6266b#5993 ](https://github.com/n8n-io/n8n/issues/5993 ))
([cc2bd2ecc2bd2e19c#7572 ](https://github.com/n8n-io/n8n/issues/7572 ))
([ff279abff279ab411#7474 ](https://github.com/n8n-io/n8n/issues/7474 ))
([b72040ab72040aa54#6980 ](https://github.com/n8n-io/n8n/pull/6980 ))
([07467830746783e02
2023-11-02 14:52:11 +01:00
Michael Kret
59dc36abd9
feat(core): Add the node version to telemetry in node_graph_string ( #7449 )
...
Github issue / Community forum post (link here to close automatically):
2023-11-02 15:18:41 +02:00
Iván Ovejero
1c77d6597f
refactor(core): Ensure only leader handles licensing in multi-main scenario ( #7558 )
...
https://linear.app/n8n/issue/PAY-953/ensure-only-main-instance-leader-handles-licensing
2023-11-02 14:16:22 +01:00
Tomi Turtiainen
7dac9ab82c
feat(core): Log executed migrations with info level ( #7586 )
...
To help debugging possible issues in startup and migrations, log the
executed migrations with log level 'info', instead of 'debug'.
Github issue / Community forum post (link here to close automatically):
2023-11-02 14:24:04 +02:00
Iván Ovejero
921d213ae5
refactor(core): Create pruning service (no-changelog) ( #7564 )
...
https://linear.app/n8n/issue/PAY-954/ensure-only-main-instance-leader-handles-pruning
2023-11-02 12:24:25 +01:00
github-actions[bot]
73e9a216b7
🚀 Release 1.15.0 ( #7580 )
...
#
[1.15.0](https://github.com/n8n-io/n8n/compare/n8n@1.14.0...n8n@1.15.0 )
(2023-11-02)
### Bug Fixes
* **core:** Ensure execution deletion in worker lifecycle hook
([#7481 ](https://github.com/n8n-io/n8n/issues/7481 ))
([742c8a8742c8a8534#7560 ](https://github.com/n8n-io/n8n/issues/7560 ))
([b350568b350568505#7408 ](https://github.com/n8n-io/n8n/issues/7408 ))
([479f902479f90231d#7523 ](https://github.com/n8n-io/n8n/issues/7523 ))
([1055bd31055bd3762#7576 ](https://github.com/n8n-io/n8n/issues/7576 ))
([437c95e437c95e84e#7569 ](https://github.com/n8n-io/n8n/issues/7569 ))
([9bdb85c9bdb85c4ce#7519 ](https://github.com/n8n-io/n8n/issues/7519 ))
([65e559365e5593233#7528 ](https://github.com/n8n-io/n8n/issues/7528 ))
([ae616f1ae616f146b#7544 ](https://github.com/n8n-io/n8n/issues/7544 ))
([3b5e1813b5e181e66#7532 ](https://github.com/n8n-io/n8n/issues/7532 ))
([2853fcf2853fcff73#7434 ](https://github.com/n8n-io/n8n/issues/7434 ))
([12a89e612a89e6d14#7516 ](https://github.com/n8n-io/n8n/issues/7516 ))
([df89685df89685e15#7348 ](https://github.com/n8n-io/n8n/issues/7348 ))
([c05bc67c05bc6728d#7534 ](https://github.com/n8n-io/n8n/issues/7534 ))
([97627059762705833#7555 ](https://github.com/n8n-io/n8n/issues/7555 ))
([7a56e587a56e58a60#7460 ](https://github.com/n8n-io/n8n/issues/7460 ))
([655efea655efeaf66#7526 ](https://github.com/n8n-io/n8n/issues/7526 ))
([3d95b243d95b243e9#7527 ](https://github.com/n8n-io/n8n/issues/7527 ))
([442c73e442c73e63b#7559 ](https://github.com/n8n-io/n8n/issues/7559 ))
([ce14f62ce14f6266b#5993 ](https://github.com/n8n-io/n8n/issues/5993 ))
([cc2bd2ecc2bd2e19c#7572 ](https://github.com/n8n-io/n8n/issues/7572 ))
([ff279abff279ab411#7474 ](https://github.com/n8n-io/n8n/issues/7474 ))
([b72040ab72040aa54#6980 ](https://github.com/n8n-io/n8n/pull/6980 ))
([07467830746783e02
2023-11-02 11:47:11 +01:00
Jan Oberhauser
be49778388
fix(editor): Fix more dark mode issues (no-changelog) ( #7578 )
...
Github issue / Community forum post (link here to close automatically):
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
Co-authored-by: Giulio Andreini <andreini@netseven.it>
2023-11-02 10:57:08 +01:00
Alex Grozav
721a36637c
feat(editor): Handle pin data edge cases and unify validation (no-changelog) ( #6685 )
...
Github issue / Community forum post (link here to close automatically):
2023-11-02 10:43:02 +02:00
Jon
479f90231d
fix(core): Fix issue that prevents owner logging in when using ldap ( #7408 )
...
This PR prioritises the internal email account over LDAP for the Owner.
---------
Co-authored-by: ricardo <ricardoespinoza105@gmail.com>
2023-11-01 23:02:49 -04:00
Omar Ajoue
437c95e84e
fix(core): Permission check for subworkflow properly checking for workflow settings ( #7576 )
...
The `sharing` related code is legacy that was not removed. Subworkflow
execution should check workflow settings alone, and this is now
reflected in the code.
Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/bug-when-using-the-execute-workflow-node-when-workflow-is-shared/32207
---------
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
2023-11-01 18:31:34 +01:00
कारतोफ्फेलस्क्रिप्ट™
100291e109
refactor(editor): Dark theme improvements (no-changelog) ( #7574 )
...
Co-authored-by: Mutasem Aldmour <4711238+mutdmour@users.noreply.github.com>
2023-11-01 17:56:15 +01:00
कारतोफ्फेलस्क्रिप्ट™
ff279ab411
feat(HTTP Request Node): Update icon and default color ( #7572 )
...
extracted from https://github.com/n8n-io/n8n/pull/7157
Co-authored-by: Elias Meire <elias@meire.dev>
2023-11-01 17:35:47 +01:00
Mutasem Aldmour
1d81afcbdf
fix: Fix dark mode small issues ( #7573 )
...
Github issue / Community forum post (link here to close automatically):
2023-11-01 16:27:32 +01:00
Jan Oberhauser
cc2bd2e19c
feat(HTTP Request Node): Add pagination support ( #5993 )
...
Is still WIP and does not implement the correct UI yet.
Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/pagination-included-into-http-node/15080
https://community.n8n.io/t/how-to-paginate-through-data-in-http-requests/28103
2023-11-01 14:24:43 +01:00
कारतोफ्फेलस्क्रिप्ट™
9bdb85c4ce
fix(core): Prevent executions from becoming forever running ( #7569 )
...
Fixes CP-867
Possibly also fixes PAY-323 and PAY-412
2023-11-01 13:51:13 +01:00
Giulio Andreini
0746783e02
refactor(editor): Color palette updates, introduce dark mode ( #6980 )
...
Github issue / Community forum post (link here to close automatically):
---------
Co-authored-by: Mutasem <mutdmour@gmail.com>
2023-11-01 13:33:36 +01:00
Yoshino-s
b72040aa54
feat(n8n Form Trigger Node): Add text area and password input types ( #7474 )
...
Signed-off-by: yoshino-s <cy-cui@outlook.com>
2023-11-01 12:23:28 +00:00
Milorad FIlipović
ce14f6266b
feat(editor): Implement the UserStack design system component ( #7559 )
...
Adds [`UserStack`
component](https://www.figma.com/file/5MfPO6Eg2YVfXETAzoGahf/Debt-days-August2023?type=design&node-id=10-13056&mode=design&t=tuJAgCdzkN506SlE-0 )
to our design system
2023-11-01 09:26:06 +01:00
Csaba Tuncsik
b94b8b2eb0
fix(editor): Rename and move isObjectLiteral utility function (no-changelog) ( #7565 )
2023-10-31 21:28:01 +01:00
Iván Ovejero
c6b688387c
refactor(core): Enable useUnknownInCatchVariables in workflow package (no-changelog) ( #7549 )
2023-10-31 13:59:33 +01:00
Michael Auerswald
b350568505
fix(core): Fix data decryption on credentials import ( #7560 )
...
Due to a change, during the credentials import command, the core's
Credential object is being called through its prototype. This caused the
Credential's cipher variable to not be set, thus no cipher service being
available during import. This fix catches this edge case and provides a
fix.
2023-10-31 13:15:09 +01:00
OlegIvaniv
774d521dbd
fix(editor): Keep NodeView component alive for TEMPLATE_IMPORT and WORKFLOW_ONBOARDING routes (no-changelog) ( #7557 )
...
Github issue / Community forum post (link here to close automatically):
2023-10-31 10:03:57 +01:00
OlegIvaniv
7a56e58a60
fix(Switch Node): Allow sortable Switch rules ( #7555 )
...
Github issue / Community forum post (link here to close automatically):
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
2023-10-31 09:13:31 +01:00
Jan Oberhauser
655efeaf66
feat(core): Add optional Error-Output ( #7460 )
...
Add an additional optional error output to which all items get sent that
could not be processed.
Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/error-connector-for-nodes/3094
https://community.n8n.io/t/error-handling-at-node-level-detect-node-execution-status/26791
---------
Co-authored-by: OlegIvaniv <me@olegivaniv.com>
2023-10-30 18:42:47 +01:00
Iván Ovejero
442c73e63b
feat(core): Set up leader selection for multiple main instances ( #7527 )
...
https://linear.app/n8n/issue/PAY-933/set-up-leader-selection-for-multiple-main-instances
- [x] Set up new envs
- [x] Add config and license checks
- [x] Implement `MultiMainInstancePublisher`
- [x] Expand `RedisServicePubSubPublisher` to support
`MultiMainInstancePublisher`
- [x] Init `MultiMainInstancePublisher` on startup and destroy on
shutdown
- [x] Add to sandbox plans
- [x] Test manually
Note: This is only for setup - coordinating in reaction to leadership
changes will come in later PRs.
2023-10-30 16:22:32 +01:00
Csaba Tuncsik
3b5e181e66
fix(editor): Fix NDV close after using input select ( #7544 )
2023-10-30 13:44:19 +01:00
Iván Ovejero
784b43330b
refactor(GitHub Trigger Node): Stop reporting to Sentry permission errors (no-changelog) ( #7552 )
...
https://n8nio.sentry.io/issues/4581327606/
2023-10-30 12:12:43 +01:00
Jackson
ea5cd3140f
docs: Fix spelling issue in Gmail trigger node ( #7545 )
...
IDK how I noticed this
2023-10-30 11:30:53 +01:00
OlegIvaniv
3ab04e4f9e
ci(core): Extract local e2e run script (no-changelog) ( #7551 )
...
Github issue / Community forum post (link here to close automatically):
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-10-30 11:18:51 +01:00
Csaba Tuncsik
2853fcff73
fix(editor): Fix NDV unexpected re-render ( #7532 )
2023-10-30 09:22:08 +01:00
Iván Ovejero
233683ce1a
refactor(core): Remove webhook deregistration on shutdown flag ( #7543 )
...
Removal missing from [original
PR](https://github.com/n8n-io/n8n/pull/7515 ) after initial revert.
2023-10-27 18:48:21 +02:00
Iván Ovejero
18dcea8c19
refactor(Slack Node): Stop reporting to Sentry errors from missing scopes (no-changelog) ( #7542 )
...
https://n8nio.sentry.io/issues/4570238312
2023-10-27 16:46:05 +02:00
Iván Ovejero
6796ba75a1
refactor(core): Stop reporting to Sentry stopping execution with wrong status (no-changelog) ( #7541 )
...
https://n8nio.sentry.io/issues/4257040218/
2023-10-27 16:14:01 +02:00
कारतोफ्फेलस्क्रिप्ट™
c05bc6728d
fix(editor): Handle localStorage being blocked/unavailable ( #7348 )
2023-10-27 15:51:20 +02:00
कारतोफ्फेलस्क्रिप्ट™
35bb42c1b9
refactor(core): Avoid passing around static state like default timezone (no-changelog) ( #7221 )
2023-10-27 14:17:52 +02:00
Iván Ovejero
62c096710f
refactor: Run lintfix (no-changelog) ( #7537 )
...
- Fix autofixable violations
- Remove unused directives
- Allow for PascalCased variables - needed for dynamically imported or
assigned classes, decorators, routers, etc.
2023-10-27 14:15:02 +02:00
Alex Grozav
1c4ac02db5
fix(editor): Fix executions sidebar height (no-changelog) ( #6909 )
...
<img width="1397" alt="image"
src="https://github.com/n8n-io/n8n/assets/6179477/cb142085-3b21-4e18-9f0d-92c5c4018578 ">
2023-10-27 14:32:23 +03:00
Iván Ovejero
07857e78a9
refactor(core): Stop reporting to Sentry non-execution of workflow with issues ( #7533 )
...
https://n8nio.sentry.io/issues/4578929841/
2023-10-27 10:09:23 +02:00
Iván Ovejero
9762705833
fix(Jira Software Node): Handle missing issue types in issue types loader ( #7534 )
...
https://n8nio.sentry.io/issues/4576849854
2023-10-27 10:09:14 +02:00
Omar Ajoue
87996a1fcf
refactor(core): Stop reporting non-error to sentry (issue 4229454473) (no-changelog) ( #7525 )
...
This PR aims to stop reporting issues such as [this
one](https://n8nio.sentry.io/issues/4229454473/events/42b96bfd6a334c15a84499e981cf90eb/?project=4503924908883968 ).
Github issue / Community forum post (link here to close automatically):
2023-10-27 09:25:07 +02:00
Csaba Tuncsik
12a89e6d14
fix(editor): Fix route component caching, incorrect use of array reduce method and enable WF history feature ( #7434 )
...
Co-authored-by: Giulio Andreini <andreini@netseven.it>
2023-10-26 20:47:42 +02:00
Iván Ovejero
ae616f146b
fix(editor): Do not truncate form inputs ( #7528 )
2023-10-26 17:54:51 +02:00
Omar Ajoue
3d95b243e9
feat(core): Make queue mode settings configurable ( #7526 )
...
This PR allows users to configure the settings to Bull, possibly
reducing the errors with `maxStalledCount` and other issues, that
usually happen either when a worker crashes or when the event loop is
super busy. Increasing the lease time and the `maxStalledCount` settings
might improve UX.
Github issue / Community forum post (link here to close automatically):
2023-10-26 17:30:16 +02:00
Iván Ovejero
ae8c7a635e
refactor(core)!: Remove webhook deregistration at startup and shutdown ( #7515 )
...
https://linear.app/n8n/issue/PAY-932/deprecate-flag-to-skip-webhook-deregistration-on-shutdown
2023-10-26 14:37:54 +02:00
Iván Ovejero
5477e3fb45
refactor(core): Move execution save settings into lifecycle function (no-changelog) ( #7370 )
...
Move the handling of execution save settings into a tested lifecycle
function as discussed with Omar
2023-10-26 14:35:38 +02:00
कारतोफ्फेलस्क्रिप्ट™
1055bd3762
fix(core): Handle missing resultData in runData ( #7523 )
2023-10-26 13:15:19 +02:00
Iván Ovejero
d8ec6eac40
refactor(FileMaker Node): Prevent reporting to Sentry attempted loadOptions calls without credentials (no-changelog) ( #7520 )
...
Severity is lost when wrapping the error, but there is no need to change
the error type here.
https://n8nio.slack.com/archives/C03MZF137FV/p1698308092989739
2023-10-26 12:02:35 +02:00
Iván Ovejero
a277807404
refactor(Airtable Node): Prevent reporting to Sentry failure to find table (no-changelog) ( #7521 )
...
https://n8nio.sentry.io/issues/4356342982/?project=4503924908883968&query=is%3Aunresolved&referrer=issue-stream&statsPeriod=14d&stream_index=8
2023-10-26 12:02:23 +02:00
Iván Ovejero
d885daa6a1
refactor(Google Sheets Node): Prevent reporting to Sentry failure to find spreadsheet (no-changelog) ( #7518 )
...
To silence this very frequently reported error:
https://n8nio.sentry.io/issues/3823103947/?project=4503924908883968&query=&referrer=issue-stream&statsPeriod=90d&stream_index=0
2023-10-26 11:33:11 +02:00
कारतोफ्फेलस्क्रिप्ट™
65e5593233
fix(core): Upgrade crypto-js to address CVE-2023-46233 ( #7519 )
...
[GH Advisory](https://github.com/advisories/GHSA-xwcq-pm8m-c4vf )
2023-10-26 11:21:53 +02:00
Jan Oberhauser
df89685e15
fix(editor): Fixes the issue that Switch Node can not be created ( #7516 )
...
Fixes the issue that currently no Switch-Node can be created by for
example pressing + on the parent node or via tab when another node is
already selected.
Github issue / Community forum post (link here to close automatically):
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Oleg Ivaniv <me@olegivaniv.com>
2023-10-26 09:46:26 +02:00
Iván Ovejero
742c8a8534
fix(core): Ensure execution deletion in worker lifecycle hook ( #7481 )
...
Reported by customer
[here](https://n8nio.slack.com/archives/C05PUALKZHD/p1697446945481249?thread_ts=1697196557.638169&cid=C05PUALKZHD ),
apparently a very old long-standing bug for queue mode. Please review
closely as I am not familiar with queue mode.
2023-10-25 19:13:06 +02:00
कारतोफ्फेलस्क्रिप्ट™
05586a900d
refactor(core): Make Logger a service (no-changelog) ( #7494 )
2023-10-25 16:35:22 +02:00
github-actions[bot]
db4e61ba24
🚀 Release 1.14.0 ( #7514 )
...
# [1.14.0](https://github.com/n8n-io/n8n/compare/n8n@1.13.0...n8n@1.14.0 )
(2023-10-25)
### Features
* **Switch Node:** Add support for infinite Switch outputs
([#7499 ](https://github.com/n8n-io/n8n/issues/7499 ))
([2febc612febc61ec9
2023-10-25 15:34:57 +02:00
कारतोफ्फेलस्क्रिप्ट™
0643487403
ci: Fix oclif manifest generation
2023-10-25 14:51:10 +02:00
कारतोफ्फेलस्क्रिप्ट™
28aabb845a
Merge remote-tracking branch 'origin/release/1.13.0'
2023-10-25 14:50:48 +02:00
OlegIvaniv
2febc61ec9
feat(Switch Node): Add support for infinite Switch outputs ( #7499 )
...
Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/add-more-outputs-to-switch-node/3864
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
2023-10-25 14:34:47 +02:00
github-actions[bot]
2987587e34
🚀 Release 1.13.0 ( #7512 )
...
# [1.13.0](https://github.com/n8n-io/n8n/compare/n8n@1.12.0...n8n@1.13.0 )
(2023-10-25)
### Bug Fixes
* **core:** Do not return `inviteAcceptUrl` in response if email was
sent ([#7465 ](https://github.com/n8n-io/n8n/issues/7465 ))
([55c6a1b55c6a1b0d3#7500 ](https://github.com/n8n-io/n8n/issues/7500 ))
([6f452986f45298d3d#7496 ](https://github.com/n8n-io/n8n/issues/7496 ))
([774fe20774fe202bf#7461 ](https://github.com/n8n-io/n8n/issues/7461 ))
([83762e083762e051d#7479 ](https://github.com/n8n-io/n8n/issues/7479 ))
([76c048176c04815f7#7485 ](https://github.com/n8n-io/n8n/issues/7485 ))
([519680c519680c2cf#7458 ](https://github.com/n8n-io/n8n/issues/7458 ))
([3c0a1663c0a166f7f#7466 ](https://github.com/n8n-io/n8n/issues/7466 ))
([bc47365bc473655fb#7483 ](https://github.com/n8n-io/n8n/issues/7483 ))
([450e0cc450e0cc66a#7463 ](https://github.com/n8n-io/n8n/issues/7463 ))
([ab6a9bbab6a9bbac2#7467 ](https://github.com/n8n-io/n8n/issues/7467 ))
([a739245a739245332#7498 ](https://github.com/n8n-io/n8n/issues/7498 ))
([baecb93baecb93bef#7464 ](https://github.com/n8n-io/n8n/issues/7464 ))
([5c46bb05c46bb09c1#7444 ](https://github.com/n8n-io/n8n/issues/7444 ))
([4e660234e66023cd4#7505 ](https://github.com/n8n-io/n8n/issues/7505 ))
([05e6f2a05e6f2a6ac#7311 ](https://github.com/n8n-io/n8n/issues/7311 ))
([647372b647372be27#7511 ](https://github.com/n8n-io/n8n/issues/7511 ))
([c47d27dc47d27dd6d#7113 ](https://github.com/n8n-io/n8n/issues/7113 ))
([ac814a9ac814a9c61#7488 ](https://github.com/n8n-io/n8n/issues/7488 ))
([7b1973c7b1973c058#7386 ](https://github.com/n8n-io/n8n/issues/7386 ))
([689360e689360ee06
2023-10-25 14:29:28 +02:00
कारतोफ्फेलस्क्रिप्ट™
6f45298d3d
fix(core): Ensure nodes post-processors run in the correct order ( #7500 )
...
Fixes #7497
2023-10-25 13:59:38 +02:00
Mutasem Aldmour
c47d27dd6d
feat(editor): Add PH tracking to event ( #7511 )
...
Github issue / Community forum post (link here to close automatically):
2023-10-25 12:18:19 +02:00
Val
93cfabbeac
fix(core): Fix workflow activation with history and workflow history for EE (no-changelog) ( #7508 )
...
Github issue / Community forum post (link here to close automatically):
2023-10-25 11:07:11 +01:00
Iván Ovejero
671c95760b
refactor(core): Make executions pruning more resilient ( #7480 )
...
This PR converts the hard-deletion interval to a timeout:
- to prevent the interval from not being restored when hard deletion
throws, and
- to prevent a long-running hard deletion from leading to duplicate
deletions.
2023-10-24 16:16:45 +02:00
Jon
05e6f2a6ac
fix(Spreadsheet File Node): Fix include empty cells not working with v2 ( #7505 )
...
Github issue / Community forum post (link here to close automatically):
Ticket#763644
2023-10-24 14:22:45 +01:00
कारतोफ्फेलस्क्रिप्ट™
8ff9f97493
fix(core): Create instance settings directory recursively (no-changelog) ( #7506 )
2023-10-24 15:10:22 +02:00
Michael Kret
a739245332
fix(Microsoft SQL Node): Prevent SQL injection ( #7467 )
...
Github issue / Community forum post (link here to close automatically):
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-10-24 12:36:44 +03:00
Iván Ovejero
78243edd18
refactor(core): Make pruning via lifecycle configuration in S3 mode mandatory ( #7482 )
...
Since we do not store which executions produced binary data, for pruning
on S3 we need to query for binary data items for each execution in order
to delete them. To minimize requests to S3, allow the user to skip
pruning requests when setting TTL at bucket level.
2023-10-24 10:37:02 +02:00
कारतोफ्फेलस्क्रिप्ट™
a9fdd018f4
fix(core): Always derive instanceId from the encryption key (no-changlog) ( #7501 )
...
This was the expected behavior, until I changed it in
https://github.com/n8n-io/n8n/pull/7471
2023-10-24 09:55:57 +02:00
Val
baecb93bef
fix(MQTT Trigger Node): Fix node causing a start up hang when active ( #7498 )
...
Github issue / Community forum post (link here to close automatically):
2023-10-24 09:37:49 +02:00
Cornelius Suermann
3ef771ea38
feat: Collect usage metrics on license renewal (no-changelog) ( #7486 )
2023-10-23 21:39:29 +02:00
Ricardo Espinoza
774fe202bf
fix(core): Fix frontend.settings external hook execution ( #7496 )
2023-10-23 11:46:13 -04:00
Burak Akgün
4e66023cd4
fix(Redis Node): Fix adding sets data types ( #7444 )
...
Fixes #6339
2023-10-23 16:33:44 +01:00
Val
41236b7e08
fix: Save new version of the workflow instead of the previous (no-changelog) ( #7428 )
...
Github issue / Community forum post (link here to close automatically):
2023-10-23 16:30:36 +02:00
कारतोफ्फेलस्क्रिप्ट™
b6de910cbe
refactor(core): Abstract away InstanceSettings and encryptionKey into injectable services (no-changelog) ( #7471 )
...
This change ensures that things like `encryptionKey` and `instanceId`
are always available directly where they are needed, instead of passing
them around throughout the code.
2023-10-23 13:39:35 +02:00
Léo Martinez
519680c2cf
fix(Customer.io Node): Fix api endpoint when using EU region ( #7485 )
...
Fixes #7484
2023-10-23 10:01:48 +01:00
MC Naveen
7b1973c058
feat(Ghost Node): Add support for lexical format ( #7488 )
2023-10-23 10:00:38 +01:00
OlegIvaniv
450e0cc66a
fix(editor): Fix connections disappearing after reactivating canvas and renaming a node ( #7483 )
...
Github issue / Community forum post (link here to close automatically):
-
https://community.n8n.io/t/1-11-1-possible-bug-all-nodes-randomly-losing-their-connectors/31856
- https://community.n8n.io/t/lines-between-nodes-have-disappeared/31846
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
2023-10-23 10:07:33 +02:00
कारतोफ्फेलस्क्रिप्ट™
76c04815f7
fix(core): Reduce logging overhead for levels that do not output ( #7479 )
...
all current logging calls execute `callsites()` to figure out what code
tried to log. This happens even for logging methods that aren't supposed
to create any output. Under moderate load, this can take up quite a lot
of resources. This PR changes the logger to make all ignorable logging
methods a No-Op.
In a small benchmark with a simple webhook, with log-level set to
`warn`, and using `ab -c 50 -n 500
http://localhost:5678/webhook/testing `, these were the response times:
### Before
### After
2023-10-20 18:26:33 +02:00
Iván Ovejero
0b42d1aa71
refactor(core): Limit soft-deletions to pruning only ( #7469 )
...
Based on customer feedback, we should limit soft deletions to pruning
only, to prevent executions from piling up in very high volume cases.
2023-10-20 15:02:47 +02:00
कारतोफ्फेलस्क्रिप्ट™
3c0a166f7f
fix(editor): Allow importing the same workflow multiple times ( #7458 )
...
Fixes #7457
2023-10-20 13:58:30 +02:00
Elias Meire
ac814a9c61
feat(Facebook Lead Ads Trigger Node): Add Facebook Lead Ads Trigger Node ( #7113 )
...
Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/facebook-lead-ads-integration/4590/19
---------
Co-authored-by: Marcus <marcus@n8n.io>
2023-10-20 13:43:55 +02:00
Jon
647372be27
feat(core): Add support for oauth based service accounts with UM SMTP ( #7311 )
...
This PR adds support for using OAuth based service accounts for the User
Management SMTP connection.
Tested using a Google Service Account.
2023-10-20 11:36:40 +01:00
कारतोफ्फेलस्क्रिप्ट™
91dfc4d513
feat(core): Update LLM applications building support (no-changelog) ( #7418 )
...
extracted out of #7336
---------
Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
Co-authored-by: OlegIvaniv <me@olegivaniv.com>
Co-authored-by: Jan Oberhauser <janober@users.noreply.github.com>
Co-authored-by: Val <68596159+valya@users.noreply.github.com>
Co-authored-by: Alex Grozav <alex@grozav.com>
Co-authored-by: Deborah <deborah@starfallprojects.co.uk>
Co-authored-by: Jesper Bylund <mail@jesperbylund.com>
Co-authored-by: Jon <jonathan.bennetts@gmail.com>
2023-10-20 10:52:56 +02:00
Iván Ovejero
34f3f8001e
fix(n8n Form Trigger Node): Fix typos (no-changelog) ( #7472 )
2023-10-20 10:49:58 +02:00
Michael Kret
5c46bb09c1
fix(MySQL Node): Resolve expressions in v1 ( #7464 )
...
Github issue / Community forum post (link here to close automatically):
2023-10-20 11:09:39 +03:00
Milorad FIlipović
bc473655fb
fix(editor): Fix canvas selection breaking after interacting with node actions ( #7466 )
...
Sometimes canvas selection stops working after users interact with node
action buttons (for example if node is moved by dragging one of the
buttons)
NOTE: Ticket number in the branch name is wrong, this fixes ADO-1226
2023-10-20 09:26:40 +02:00
Iván Ovejero
b50376cf52
refactor(core): Make executions pruning settings configurable ( #7468 )
2023-10-19 16:57:12 +02:00
Csaba Tuncsik
c7c8048430
feat(editor): Workflow history [WIP] - Remove pinned data from workflow history version preview (no-changelog) ( #7406 )
2023-10-19 14:38:00 +02:00
Csaba Tuncsik
82129694c6
feat(editor): Workflow history [WIP] - Add cloned workflow link to success toast message (no-changelog) ( #7405 )
2023-10-19 14:02:59 +02:00
कारतोफ्फेलस्क्रिप्ट™
55c6a1b0d3
fix(core): Do not return inviteAcceptUrl in response if email was sent ( #7465 )
2023-10-19 13:58:06 +02:00
Michael Kret
ab6a9bbac2
fix(Google Sheets Node): Append or update runs forever when without column headers ( #7463 )
...
Github issue / Community forum post (link here to close automatically):
---------
Co-authored-by: Marcus <marcus@n8n.io>
2023-10-19 14:54:13 +03:00
Jon
689360ee06
feat(RSS Feed Trigger Node): Add RSS feed trigger node ( #7386 )
...
Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/rss-trigger/14203
2023-10-19 08:49:18 +01:00
कारतोफ्फेलस्क्रिप्ट™
83762e051d
fix(core): Handle gzip and deflate compressed request payloads ( #7461 )
...
NODE-870
2023-10-18 21:52:15 +02:00
github-actions[bot]
ef58a23d21
🚀 Release 1.12.0 ( #7459 )
...
# [1.12.0](https://github.com/n8n-io/n8n/compare/n8n@1.11.0...n8n@1.12.0 )
(2023-10-18)
### Bug Fixes
* **core:** Add check that queue is defined and remove cyclic dependency
([#7404 ](https://github.com/n8n-io/n8n/issues/7404 ))
([45f2ef345f2ef373e#7411 ](https://github.com/n8n-io/n8n/issues/7411 ))
([2b6a15e2b6a15e478#7424 ](https://github.com/n8n-io/n8n/issues/7424 ))
([ec14141ec141416e2#7368 ](https://github.com/n8n-io/n8n/issues/7368 ))
([2f4d91b2f4d91b2cd#7417 ](https://github.com/n8n-io/n8n/issues/7417 ))
([770390477039044eb#7435 ](https://github.com/n8n-io/n8n/issues/7435 ))
([e01b9e5e01b9e5ae1#7419 ](https://github.com/n8n-io/n8n/issues/7419 ))
([46977a246977a2aff#7320 ](https://github.com/n8n-io/n8n/issues/7320 ))
([367255a367255ab2c#7377 ](https://github.com/n8n-io/n8n/issues/7377 ))
([c599006c599006b91#7357 ](https://github.com/n8n-io/n8n/issues/7357 ))
([d8531a5d8531a53b9#7432 ](https://github.com/n8n-io/n8n/issues/7432 ))
([c3f0be8c3f0be809f#7416 ](https://github.com/n8n-io/n8n/issues/7416 ))
([e9b6ab0e9b6ab04cd#7450 ](https://github.com/n8n-io/n8n/issues/7450 ))
([a2d2e3da2d2e3dda7#7439 ](https://github.com/n8n-io/n8n/issues/7439 ))
([40707fa40707fa692#7436 ](https://github.com/n8n-io/n8n/issues/7436 ))
([9d241a09d241a0d6d#7156 ](https://github.com/n8n-io/n8n/issues/7156 ))
([57c609357c609384a#7130 ](https://github.com/n8n-io/n8n/issues/7130 ))
([3ddc1763ddc176dfa#7448 ](https://github.com/n8n-io/n8n/issues/7448 ))
([79f23fb79f23fb939
2023-10-18 17:43:29 +02:00
Iván Ovejero
40707fa692
feat(core): Make executions pruning interval configurable ( #7439 )
2023-10-18 17:01:57 +02:00
कारतोफ्फेलस्क्रिप्ट™
79f23fb939
feat(Spreadsheet File Node): Improve CSV parsing ( #7448 )
...
This adds support for
1. custom delimiters
2. reading offsets to avoid having to read a large CSV all at once
3. excluding byte-order-mark
NODE-861
#7443
2023-10-18 16:57:37 +02:00
Michael Kret
d8531a53b9
fix(Google Sheets Node): Tweaks ( #7357 )
...
Github issue / Community forum post (link here to close automatically):
2023-10-17 18:41:30 +03:00
Michael Kret
a2d2e3dda7
fix(TheHive 5 Node): Observable encoding in alert > create fix ( #7450 )
...
Github issue / Community forum post (link here to close automatically):
2023-10-17 16:53:44 +03:00
Michael Kret
3ddc176dfa
feat(n8n Form Trigger Node): New node ( #7130 )
...
Github issue / Community forum post (link here to close automatically):
based on https://github.com/joffcom/n8n-nodes-form-trigger
---------
Co-authored-by: Giulio Andreini <g.andreini@gmail.com>
2023-10-17 07:09:30 +03:00
Deborah
869b8f14ca
fix(Convert to/from binary data Node): Change Mime to MIME (no-changelog) ( #7446 )
...
Github issue / Community forum post (link here to close automatically):
2023-10-16 16:54:16 +01:00
Jon
9d241a0d6d
feat(Google Calendar Trigger Node): Add support for cancelled events ( #7436 )
...
Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/google-calendar-trigger-deleted-events/10612
This PR adds support for triggering workflows when Google Calendar
events are cancelled.
2023-10-16 14:09:23 +01:00
Damian Karzon
57c609384a
feat(HubSpot Trigger Node): Add support for ticket related events ( #7156 )
2023-10-13 16:52:22 +01:00
Michael Auerswald
e01b9e5ae1
fix(core): Prevent false stalled jobs in queue mode from displaying as errored ( #7435 )
...
This is related to an issue with how Bull handles stalled jobs, see
https://github.com/OptimalBits/bull/issues/1415 for reference.
CPU intensive workflows can in certain cases take a long while to finish
up, thereby blocking the thread and causing Bull queue to think the job
has stalled, even though it finished successfully. In these cases the
error handling could then overwrite the successful execution data with
the error message.
2023-10-13 16:07:08 +02:00
Inga
c599006b91
fix(editor): Open only one tab with plans page ( #7377 )
...
## Issue
In community edition, clicking on "View plans" button on "Settings" ->
"Usage and plan" page (e.g. http://127.0.0.1:5678/settings/usage ) opens
two new tabs with n8n pricing (one of them with UTM tracking, another
without).
This was introduced in #6317 , when click handler of "View plans" link
container [started
calling](https://github.com/n8n-io/n8n/pull/6317/files#diff-0bf26afac8a06e03b3d39d0668f22408859355b585a9ab420800c125e33f0691R109 )
`uiStore.goToUpgrade(...)` which opens n8n pricing in a new tab, while
browser opens another tab for the link URL.
The simplest fix, implemented in this PR, is to prevent default event
handling (so that, after `onViewPlans` is called, browser will not
attempt to process the click additionally as clicking on the link),
similarly to how it is prevented on some other pages. It only solves the
immediate problem of browser opening two new tabs on clicking "View
plans".
Note that **I didn't implement any tests for the changed behavior**,
because it was not covered by tests before, and I couldn't quite figure
out how to cover it now within the existing test approach (considering
that testing the fact that only one new tab is open will likely require
to write entirely new tests relying on puppeteer; as far as I can see,
no existing `editor-ui` tests are doing anything like that). I'll gladly
implement tests for the new behavior if you tell me how you would like
them to look.
The existing tests for `editor-ui` still pass; I didn't run tests for
other subpackages (see "additional contribution notes" below).
## Additional notes on the issue.
I'm not sure that the change in this PR is the correct long-term
solution for the issue, because the URLs for these two methods (custom
click handler for link container and default link handling) are slightly
different:
* Custom click handler calls `useTelemetryStore().track('User clicked
upgrade CTA', ...)`; then calls `sendUsageTelemetry('view_plans')` (it
feels weird that two calls to telemetry are made); then opens new tab
for `https://n8n.io/pricing?utm_campaign=open&source=usage_page ` (note
that prior to #7316 the second call to telemetry was done after the new
tab is opened, not before);
* Link itself refers to another page, with slightly different tracking
parameters:
`https://subscription.n8n.io/?instanceid=[REDACTED]&version=1.10.0&callback=http%3A%2F%2F127.0.0.1%3A5678%2Fsettings%2Fusage&source=usage_page `;
but this page redirects to `https://n8n.io/pricing/ `.
It is not clear which one of the two is the right way of doing things.
Although `goToUpgrade` is called in 20 places throughout `editor-ui`,
while `viewPlansUrl`, as far as I can see, is used for this button only.
Additionally, since Settings pages don't work without JS anyway, I can
only think of two separate scenarios where any tab would be opened:
* Left-clicking the link (or Ctrl-clicking, or pressing Space or Enter
when the link is focused, or tapping): previously, both custom click
handler was executed and link's `href` was opened; in this PR, only
custom click handler is executed (similarly to how it is done in the
other places where `goToUpgrade` is called);
* Right-clicking (or long tapping, or opening context menu in any other
way) and selecting "open link in new tab" (or similar): opens a new tab
for URL from the `href` attribute (and does not send any telemetry at
all).
I'd say that the better permanent solution would probably be to get rid
of one of these methods entirely, and only rely on another in all cases
(for me, as an outside contributor, the preferred way would be for
custom click handler to only send telemetry, while letting my browser
handle the actual navigation). However, that would be a large change,
much more than one line in this PR.
Additionally, other similar places where `goToUpgrade` is currently
called (directly or indirectly) would also need to be adapted for this
change.
## Additional contribution notes
As a first-time contributor, I've encountered several things I didn't
expect; I'm not sure if they should be expected or are issues:
1. Tests for the entire monorepo consume a lot of RAM; 20GB free RAM was
not enough, so I couldn't run tests for the entire monorepo and had to
only run them for `packages/editor-ui`;
2. Linting is very slow; `pnpm lint` in `packages/editor-ui` takes ten
minutes to complete;
3. It seems that types are not checked. Code OSS highlights numerous
errors in code files: for example, `'debug'` is incompatible with
`CloudUpdateLinkSourceType` expected by `goToUpgrade` here:
3e7a4d3b2c/packages/editor-ui/src/composables/useExecutionDebugging.ts (L128)
2023-10-13 14:14:26 +02:00
Iván Ovejero
c6ee1e30c0
refactor(core): Add binary data S3 to telemetry ( #7412 )
...
https://n8nio.slack.com/archives/C04B1GZ4T0U/p1697033523039729
2023-10-13 13:16:43 +02:00
pemontto
c3f0be809f
fix(Ldap Node): Fix issue with connections not closing correctly ( #7432 )
2023-10-13 12:15:54 +01:00
Michael Auerswald
45f2ef373e
fix(core): Add check that queue is defined and remove cyclic dependency ( #7404 )
...
In a rare edge case an undefined queue could be returned - this should
not happen and now an error is thrown.
Also using the opportunity to remove a cyclic dependency from the Queue.
2023-10-13 11:53:59 +02:00
Iván Ovejero
609f0837cf
test(core): Add test for suppressing error on non-existing filepath (no-changelog) ( #7421 )
...
Follow-up to #7411
2023-10-13 11:52:17 +02:00
Iván Ovejero
ec141416e2
fix(core): Fix expression with paired item with multi-input node ( #7424 )
...
https://linear.app/n8n/issue/PAY-630
Minimal repro:
https://internal.users.n8n.cloud/workflow/9HSkIy4T1LqXbm1H
2023-10-12 17:32:14 +02:00
Michael Kret
e9b6ab04cd
fix(Set Node): Null should not throw an error ( #7416 )
...
Github issue / Community forum post (link here to close automatically):
2023-10-12 18:07:12 +03:00
Omar Ajoue
46977a2aff
fix: Prevent undefined issues when restoring binary data ( #7419 )
...
Github issue / Community forum post (link here to close automatically):
---------
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
2023-10-12 16:41:51 +02:00
Milorad FIlipović
367255ab2c
fix(editor): Fix remote options fetching on every keystroke ( #7320 )
...
Github issue / Community forum post (link here to close automatically):
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-10-12 14:18:35 +02:00
Michael Kret
77039044eb
fix(core): Pg-promise de-initialization fix ( #7417 )
...
Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/postgres-node-called-end-on-pool-more-than-once/30585/1
2023-10-12 12:10:14 +03:00
कारतोफ्फेलस्क्रिप्ट™
2b6a15e478
fix(core): Do not throw when deleting workflows with executions without binary-data ( #7411 )
...
Fixes https://n8nio.sentry.io/issues/4508969090
2023-10-11 18:00:06 +02:00
Iván Ovejero
54e900955a
refactor(core): Move frontend settings to service (no-changelog) ( #7396 )
...
Quick follow-up to https://github.com/n8n-io/n8n/pull/7283
2023-10-11 17:12:19 +02:00
कारतोफ्फेलस्क्रिप्ट™
1e0753516c
Merge tag 'n8n@1.11.0'
2023-10-11 15:55:52 +02:00
Michael Auerswald
2f4d91b2cd
fix(core): Fix ignoring crashed executions without event msgs ( #7368 )
...
when the event logs do not contain messages for running executions, the
recovery/crash detection on startup would skip these. this PR fixes
that.
2023-10-11 14:22:43 +02:00
github-actions[bot]
e6ba841c5f
🚀 Release 1.11.0 ( #7402 )
...
# [1.11.0](https://github.com/n8n-io/n8n/compare/n8n@1.10.0...n8n@1.11.0 )
(2023-10-11)
### Bug Fixes
* **core:** Add an option to enable postgres ssl with default certs
([#6889 ](https://github.com/n8n-io/n8n/issues/6889 ))
([789e1e7789e1e7ed4#7399 ](https://github.com/n8n-io/n8n/issues/7399 ))
([47e895347e8953ec9#7326 ](https://github.com/n8n-io/n8n/issues/7326 ))
([e2c3c7ae2c3c7aceb#7366 ](https://github.com/n8n-io/n8n/issues/7366 ))
([63e11e463e11e4be9#7382 ](https://github.com/n8n-io/n8n/issues/7382 ))
([86e7ec786e7ec796a#7376 ](https://github.com/n8n-io/n8n/issues/7376 ))
([7e06b317e06b31a5f#7392 ](https://github.com/n8n-io/n8n/issues/7392 ))
([7ed466d7ed466db7f#7372 ](https://github.com/n8n-io/n8n/issues/7372 ))
([3fa27643fa27647d8#7400 ](https://github.com/n8n-io/n8n/issues/7400 ))
([2b075bf2b075bfc2d#7351 ](https://github.com/n8n-io/n8n/issues/7351 ))
([afbf0c3afbf0c3d5e#7354 ](https://github.com/n8n-io/n8n/issues/7354 ))
([97bb70397bb703d0a#7369 ](https://github.com/n8n-io/n8n/issues/7369 ))
([3e7a4d33e7a4d3b2c#7384 ](https://github.com/n8n-io/n8n/issues/7384 ))
([732b15a732b15a1fa#7379 ](https://github.com/n8n-io/n8n/issues/7379 ))
([77643e577643e5ccb#7383 ](https://github.com/n8n-io/n8n/issues/7383 ))
([fbcd1d4fbcd1d40ed#7358 ](https://github.com/n8n-io/n8n/issues/7358 ))
([e5ad1e7e5ad1e7e4d#7385 ](https://github.com/n8n-io/n8n/issues/7385 ))
([6479eb16479eb180f#7360 ](https://github.com/n8n-io/n8n/issues/7360 ))
([b8608ceb8608cee6d#7253 ](https://github.com/n8n-io/n8n/issues/7253 ))
([1a661e61a661e6d00#7307 ](https://github.com/n8n-io/n8n/issues/7307 ))
([0847623](0847623f85#7367 ](https://github.com/n8n-io/n8n/issues/7367 ))
([8187be18187be1b7d#7316 ](https://github.com/n8n-io/n8n/issues/7316 ))
([1dfa0521dfa052301#7289 ](https://github.com/n8n-io/n8n/issues/7289 ))
([c8c14cac8c14ca0af#7297 ](https://github.com/n8n-io/n8n/issues/7297 ))
([965db8f965db8f7f2#7228 ](https://github.com/n8n-io/n8n/issues/7228 ))
([7b773cc7b773cc5cc#7304 ](https://github.com/n8n-io/n8n/issues/7304 ))
([193181a193181a9c6
2023-10-11 13:38:34 +02:00
कारतोफ्फेलस्क्रिप्ट™
2b075bfc2d
fix(editor): Sanitize HTML binary-data before rendering in the UI ( #7400 )
2023-10-11 12:09:19 +02:00
Iván Ovejero
47e8953ec9
fix(core): Fix error on missing paired item data ( #7399 )
...
<img width="1015" alt="Capture 2023-10-11 at 10 07 02@2x"
src="https://github.com/n8n-io/n8n/assets/44588767/0305f62d-0a7b-4ce7-b78f-a8d8454e2532 ">
2023-10-11 11:34:55 +02:00
Csaba Tuncsik
53c3379282
feat(editor): Workflow history [WIP]- Create workflow history item preview component (no-changelog) ( #7378 )
...
Co-authored-by: Giulio Andreini <g.andreini@gmail.com>
2023-10-11 10:13:04 +02:00
Michael Kret
965db8f7f2
feat(Item Lists Node): Split merge binary data ( #7297 )
...
Github issue / Community forum post (link here to close automatically):
---------
Co-authored-by: Marcus <marcus@n8n.io>
2023-10-11 10:59:51 +03:00
Michael Kret
e2c3c7aceb
fix(core): Missing pairing info ( #7326 )
...
Github issue / Community forum post (link here to close automatically):
2023-10-10 18:36:20 +03:00
कारतोफ्फेलस्क्रिप्ट™
6479eb180f
fix(Webhook Node): Backward compatible form-data parsing for non-array files ( #7385 )
...
Fixes
https://community.n8n.io/t/possible-bug-0-added-to-end-of-files-sent-via-webhook/31169
2023-10-10 15:19:05 +02:00
Omar Ajoue
7ed466db7f
fix(editor): Make workflow history button available only for dev builds ( #7392 )
...
Github issue / Community forum post (link here to close automatically):
---------
Co-authored-by: Csaba Tuncsik <csaba.tuncsik@gmail.com>
2023-10-10 12:15:18 +02:00
Elias Meire
7e06b31a5f
fix(editor): Implement canvas zoom UX improvements ( #7376 )
...
- Fix pinch-to-zoom
- Support command + scroll to zoom
- Improve accuracy of zooming (scroll more = zoom more)
- Zoom limits
- Zoom relative to mouse position
2023-10-10 11:07:58 +02:00
Iván Ovejero
0847623f85
feat(core): Switch binary filesystem mode to nested path structure ( #7307 )
...
Depends on #7253 | Story:
[PAY-863](https://linear.app/n8n/issue/PAY-863/switch-binary-filesystem-mode-to-nested-path-structure )
This PR introduces `filesystem-v2` to store binary data in the
filesystem in the same format as `s3`.
2023-10-10 10:06:06 +02:00
Iván Ovejero
86e7ec796a
fix(editor): Fix completions for .json on quoted node name in Code node ( #7382 )
...
To reproduce, request completion with `$input.first().json.` from a node
with a quote in the name, e.g. `When clicking "Execute Workflow"`.
Context:
https://linear.app/n8n/issue/PAY-635/autocomplete-only-supports-3-levels-of-children#comment-234f738b
2023-10-10 10:05:41 +02:00
Elias Meire
fbcd1d40ed
fix(Notion Node): Handle empty values correctly for Notion selects + multi selects ( #7383 )
...
Github issue / Community forum post (link here to close automatically):
2023-10-09 18:04:41 +02:00
कारतोफ्फेलस्क्रिप्ट™
8187be1b7d
feat(editor): Make PDF and Audio binary-data viewable in the UI ( #7367 )
...
fixes #7361
2023-10-09 17:43:57 +02:00
कारतोफ्फेलस्क्रिप्ट™
732b15a1fa
fix(Google Sheets Node): Fix "Maximum call stack size exceeded" error on too many rows ( #7384 )
...
Fixes:
1. https://community.n8n.io/t/google-sheets-error-maximum-call-stack-size-exceeded/31006
2. https://community.n8n.io/t/error-maximum-call-stack-size-exceeded-in-google-sheet-read-rows/20307
2023-10-09 16:58:16 +02:00
कारतोफ्फेलस्क्रिप्ट™
c5ee06cc61
refactor(core): Refactor nodes loading (no-changelog) ( #7283 )
...
fixes PAY-605
2023-10-09 16:09:23 +02:00
कारतोफ्फेलस्क्रिप्ट™
789e1e7ed4
fix(core): Add an option to enable postgres ssl with default certs ( #6889 )
...
CP-809
2023-10-09 13:55:03 +02:00
Csaba Tuncsik
b3247e5935
feat(editor): Workflow history [WIP]- Add restore and clone into new workflow actions (no-changelog) ( #7359 )
2023-10-09 13:50:08 +02:00
Jon
77643e5ccb
fix(HTML Node): Update property fields to not use expressions on drag ( #7379 )
...
When dragging an expression into a "binary property" or "json property"
field we should use the key name rather than the expression.
2023-10-09 10:23:46 +01:00
Ricardo Espinoza
a43f720658
fix: Add role check for upgrade path ( #7374 )
...
Github issue / Community forum post (link here to close automatically):
---------
Co-authored-by: Mutasem <mutdmour@gmail.com>
2023-10-09 11:18:08 +02:00
Iván Ovejero
3fa27647d8
fix(editor): Remove excess margin below run data editor ( #7372 )
...
https://n8nio.slack.com/archives/C03594NKD7W/p1696605203051309
<img width="581" alt="Capture 2023-10-06 at 17 48 51@2x"
src="https://github.com/n8n-io/n8n/assets/44588767/c00ecd2e-1f6b-4041-9854-1b6012513a5d ">
2023-10-09 09:20:37 +02:00
Elias Meire
3e7a4d3b2c
fix(Google Drive Trigger Node): Add Shared Drives support ( #7369 )
...
Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/google-drive-node-cant-access-google-shared-drives/8760
2023-10-06 19:59:33 +02:00
Michael Auerswald
b8608cee6d
feat(core): Add Job Summary to Worker response ( #7360 )
2023-10-06 17:52:27 +02:00
