mudhorn/n8n - Forgejo: Beyond coding. We forge.

mirror of https://github.com/n8n-io/n8n.git synced 2024-12-25 04:34:06 -08:00

Author	SHA1	Message	Date
github-actions[bot]	9abc0f0f0a	🚀 Release 1.32.0 (#8826 ) Co-authored-by: krynble <krynble@users.noreply.github.com>	2024-03-06 12:42:39 +00:00
Val	0e037add71	fix: PermissionChecker integration tests (no-changelog) (#8776 )	2024-03-05 19:18:34 +01:00
कारतोफ्फेलस्क्रिप्ट™	0818824a72	feat(core)!: Set the `secure` flag on issued cookies (#8812 )	2024-03-05 18:57:41 +01:00
कारतोफ्फेलस्क्रिप्ट™	2b0e14e936	fix(core): Refactor push sessionid validation, and add unit tests (no-changelog) (#8815 )	2024-03-05 18:57:29 +01:00
कारतोफ्फेलस्क्रिप्ट™	4af907fba8	feat(core): Upgrade expressjs (no-changelog) (#8811 )	2024-03-05 17:12:29 +01:00
कारतोफ्फेलस्क्रिप्ट™	62282c2bde	fix(core): Disable CollaborationService (no-changelog) (#8813 )	2024-03-05 16:34:43 +01:00
कारतोफ्फेलस्क्रिप्ट™	cdec7c9334	feat(core): Update hashing strategy for JWTs (#8810 )	2024-03-05 15:06:29 +01:00
कारतोफ्फेलस्क्रिप्ट™	d1b48ddcac	fix(core): Remove sensitive data from User entity during serialization (no-changelog) (#8773 )	2024-02-29 14:20:39 +01:00
कारतोफ्फेलस्क्रिप्ट™	db4a419c8d	refactor(core): Enforce authorization by default on all routes (no-changelog) (#8762 )	2024-02-28 17:02:18 +01:00
कारतोफ्फेलस्क्रिप्ट™	2811f77798	refactor(core): Rename RequireGlobalScope to GlobalScope (no-changelog) (#8760 )	2024-02-28 14:40:02 +01:00
कारतोफ्फेलस्क्रिप्ट™	56c8791aff	refactor(core): Remove all legacy auth middleware code (no-changelog) (#8755 )	2024-02-28 13:12:28 +01:00
github-actions[bot]	2e84684f04	🚀 Release 1.31.0 (#8759 ) Co-authored-by: netroy <netroy@users.noreply.github.com>	2024-02-28 12:18:12 +01:00
कारतोफ्फेलस्क्रिप्ट™	5f6da7b84e	fix(core): Do not report generic webhook execution errors (no-changelog) (#8749 )	2024-02-27 12:36:49 +01:00
Omar Ajoue	737170893d	feat: Allow instance owners and admins to edit all credentials (#8716 ) Co-authored-by: Danny Martini <despair.blue@gmail.com>	2024-02-27 08:26:36 +00:00
Alex Grozav	4b01335aa4	feat: Add env variables to support exposing `/workflows/demo` route and `/nodes.json` route (#8506 ) Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>	2024-02-23 18:20:12 +02:00
कारतोफ्फेलस्क्रिप्ट™	35fb7102cb	refactor(core): Update auth related typings (no-changelog) (#8686 )	2024-02-23 15:08:18 +01:00
Jan Oberhauser	a29b41ec55	fix(core): Fix pairedItem issue with partial manual executions (#8575 ) Co-authored-by: Danny Martini <danny@n8n.io> Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>	2024-02-23 11:43:08 +01:00
github-actions[bot]	8b67dfbed9	🚀 Release 1.30.0 (#8702 ) Co-authored-by: netroy <netroy@users.noreply.github.com>	2024-02-21 15:43:44 +01:00
कारतोफ्फेलस्क्रिप्ट™	059d281fd1	feat(core): Move execution permission checks earlier in the lifecycle (#8677 )	2024-02-21 14:47:02 +01:00
Iván Ovejero	5304b320c8	refactor(core): Enrich inaccessible credential error (#8574 ) Co-authored-by: Omar Ajoue <krynble@gmail.com> Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>	2024-02-21 13:04:30 +01:00
Tomi Turtiainen	05e13a68ea	fix: Fix typeorm .save usage (no-changelog) (#8678 )	2024-02-20 17:34:54 +02:00
कारतोफ्फेलस्क्रिप्ट™	afd2eb1f4a	fix(core): Report all sqlite transaction rollback errors to Sentry (no-changelog) (#8680 )	2024-02-20 15:28:12 +01:00
कारतोफ्फेलस्क्रिप्ट™	b6c8a0c413	refactor(core): Reduce code duplication in DB config (no-changelog) (#8679 )	2024-02-20 14:28:53 +01:00
github-actions[bot]	c4e259bcfc	🚀 Release 1.29.0 (#8643 ) Co-authored-by: krynble <krynble@users.noreply.github.com>	2024-02-15 11:08:48 +00:00
Omar Ajoue	540a80e9f9	test: Fix broken workflow tag tests (#8641 ) Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <netroy@users.noreply.github.com> Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>	2024-02-15 10:51:59 +00:00
Danny Martini	24859cfef5	docs: Document own mode removal in `BREAKING-CHANGES.md` (no-changelog) (#8632 )	2024-02-14 16:26:01 +01:00
कारतोफ्फेलस्क्रिप्ट™	a2a3ca160f	fix(core): Improve the startup error when EXECUTIONS_PROCESS is set (#8630 ) Co-authored-by: Omar Ajoue <krynble@gmail.com>	2024-02-14 15:35:42 +01:00
कारतोफ्फेलस्क्रिप्ट™	68498cb72a	fix(core): Upgrade `@n8n/typeorm` to address postgres timestamp issues (#8627 )	2024-02-14 14:17:57 +01:00
Danny Martini	cd8ca8412d	fix(core): Give better error message if `executions.process` is still used in the configs (#8618 )	2024-02-13 12:40:50 +00:00
Danny Martini	ee81015231	docs: Update cursor description in the public api documentation (#8602 )	2024-02-09 16:36:57 +01:00
Cornelius Suermann	5a613d4a8b	build: Update License-SDK to v2.10.0 (no-changelog) (#8537 )	2024-02-09 16:10:50 +01:00
Omar Ajoue	a743a40376	feat(API): Add tag support to public API (#8588 ) Co-authored-by: Jesús Burgers <jesus.burgers@chakray.co.uk> Co-authored-by: Jesús Burgers <43568066+jburgers-chakray@users.noreply.github.com>	2024-02-09 15:10:03 +00:00
Cornelius Suermann	cd151f1ba9	feat: Include totalUsers in usage metrics during license renewal (no-changelog) (#8598 )	2024-02-09 14:15:05 +01:00
oleg	5ab34fe335	fix(API): Fire workflowExecuteBefore hook in runMainProcess (no-changelog) (#8601 )	2024-02-09 13:23:00 +01:00
Omar Ajoue	7501ad8f3c	feat: Add support for AI log streaming (#8526 ) Co-authored-by: Oleg Ivaniv <me@olegivaniv.com>	2024-02-09 09:41:01 +00:00
कारतोफ्फेलस्क्रिप्ट™	8e392cfc1d	feat(core): Migrate to n8n's typeorm fork (#8590 )	2024-02-08 15:13:29 +01:00
कारतोफ्फेलस्क्रिप्ट™	7826bd842a	feat: Upgrade typeorm, sqlite3, and pg/pg-promise (#8579 )	2024-02-08 10:40:18 +01:00
कारतोफ्फेलस्क्रिप्ट™	5750e8e88e	fix(core): Upgrade rudderstack sdk to address npm postInstall issues (#8568 )	2024-02-08 10:40:10 +01:00
कारतोफ्फेलस्क्रिप्ट™	40eee3aa49	ci(core): Avoid slow bcrypt calls in tests (no-changelog) (#8570 )	2024-02-07 17:56:02 +01:00
github-actions[bot]	1b7ebe463e	🚀 Release 1.28.0 (#8569 ) Co-authored-by: ivov <ivov@users.noreply.github.com>	2024-02-07 15:39:40 +01:00
कारतोफ्फेलस्क्रिप्ट™	c04f92f7fd	refactor(core): Couple of refactors on WorkflowRunner and ActiveExecutions (no-changelog) (#8487 )	2024-02-06 18:09:50 +01:00
Iván Ovejero	dc068ce2e6	build: Fix outdated import to fix build (no-changelog) (#8558 )	2024-02-06 10:45:30 +01:00
Iván Ovejero	abddbb6227	fix(core): Use trx manager instead of repository for tags overwrite (#8557 )	2024-02-06 10:40:32 +01:00
Iván Ovejero	c4e39451db	refactor(core): Continue breaking dependency cycles (no-changelog) (#8545 )	2024-02-06 10:08:46 +01:00
Iván Ovejero	28aee7c425	refactor(core): Lock `webhook` process out of multi-main setup (no-changelog) (#8549 )	2024-02-05 18:06:54 +01:00
Iván Ovejero	dca50dcc68	docs: Add encryption key check to breaking changes list (#8551 )	2024-02-05 16:39:59 +01:00
Danny Martini	b62c1d7c41	fix: Remove ts-node from overrides and typeorm script (no-changelog) (#8547 )	2024-02-05 14:09:22 +01:00
Iván Ovejero	dc5ec8f946	refactor(core): Streamline flows in multi-main mode (no-changelog) (#8446 )	2024-02-05 09:26:55 +01:00
कारतोफ्फेलस्क्रिप्ट™	ee5e422094	fix(core): Upgrade nodemailer to address an exploit (#8535 )	2024-02-02 14:12:18 +01:00
Iván Ovejero	92f939f827	fix(core): Fix workflow tagging failure due to unique constraint check (#8505 )	2024-02-02 12:36:55 +01:00
कारतोफ्फेलस्क्रिप्ट™	4fed68ee34	fix(core): Fix DropRoleMapping migration (#8521 )	2024-02-02 12:22:09 +01:00
कारतोफ्फेलस्क्रिप्ट™	5832d3ca46	fix(core): Fix PermissionChecker.check, and add additional unit tests (#8528 )	2024-02-02 12:21:53 +01:00
Iván Ovejero	528c07134a	fix(core): Fix test runs of triggers that rely on static data (#8524 )	2024-02-01 18:05:23 +01:00
Iván Ovejero	cc41fc7c80	fix(core): Fix new graceful shutdown env being always overridden by deprecated env (#8503 )	2024-02-01 11:10:40 +01:00
कारतोफ्फेलस्क्रिप्ट™	88cf1823d3	Merge tag 'n8n@1.27.0'	2024-01-31 20:33:25 +01:00
कारतोफ्फेलस्क्रिप्ट™	d2d0ae6c5d	ci: Fix DB tests (no-changelog) (#8513 )	2024-01-31 17:36:50 +01:00
github-actions[bot]	7aa3ef7168	🚀 Release 1.27.0 (#8512 ) Co-authored-by: ivov <ivov@users.noreply.github.com>	2024-01-31 16:08:37 +01:00
कारतोफ्फेलस्क्रिप्ट™	033fd344b5	fix(core): Handle possibly invalid `updatedAt` timestamps in source-control (#8485 )	2024-01-31 14:25:03 +01:00
कारतोफ्फेलस्क्रिप्ट™	839dd96c7d	refactor(core): Move all code related to `onServerStarted` into `InternalHooks` (no-changelog) (#8500 )	2024-01-31 13:29:17 +01:00
Danny Martini	39e8754784	fix(core): Don't report executions that have been paused as failed to rudderstack and log streams (#8501 )	2024-01-31 11:21:15 +01:00
Iván Ovejero	dac511b710	refactor(core): Modernize credentials controllers and services (no-changelog) (#8488 ) Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>	2024-01-31 09:48:48 +01:00
कारतोफ्फेलस्क्रिप्ट™	121a55b691	feat(core): Remove `own` execution-process mode (#8490 )	2024-01-30 12:51:40 +01:00
कारतोफ्फेलस्क्रिप्ट™	5cb55270b7	refactor(core): Replace promisify-d node calls with native promises (no-changelog) (#8464 )	2024-01-30 09:49:23 +01:00
Iván Ovejero	238b54c77b	fix(core): Fix stopping and retrying failed executions (#8480 )	2024-01-29 16:34:58 +01:00
Iván Ovejero	9e93980957	fix(core): Prevent calling internal hook email event if emailing is disabled (#8462 ) Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>	2024-01-29 16:15:30 +01:00
Iván Ovejero	db48bdd6d1	fix(core): Handle zero execution statistics on metrics collection during license renewal (#8463 )	2024-01-26 17:50:19 +01:00
कारतोफ्फेलस्क्रिप्ट™	2fba0e8d58	feat(core): Upgrade Rudderstack SDK to address CVE-2023-45857 (#8368 )	2024-01-26 16:58:44 +01:00
Danny Martini	9f11eba0a4	fix(core): Point users to the official documentation when they use `n8n --help` (#8440 )	2024-01-26 15:16:53 +01:00
कारतोफ्फेलस्क्रिप्ट™	c70fa66e76	refactor(core): Use DI for WorkflowRunner (no-changelog) (#8372 )	2024-01-26 13:49:39 +01:00
कारतोफ्फेलस्क्रिप्ट™	7c49004018	refactor(core): Use DI for eventBus code - Part 1 (no-changelog) (#8434 )	2024-01-26 12:21:15 +01:00
कारतोफ्फेलस्क्रिप्ट™	ef4507c821	Merge tag 'n8n@1.26.0'	2024-01-25 16:49:18 +01:00
कारतोफ्फेलस्क्रिप्ट™	cc2f0ada76	ci: Enforce `noUnusedLocals` on all backend and nodes packages (no-changelog) (#8428 )	2024-01-25 14:33:35 +01:00
कारतोफ्फेलस्क्रिप्ट™	f438082442	fix(core): Run the down migration correctly when `transaction: false` is set (no-changelog) (#8432 )	2024-01-24 19:07:47 +01:00
Michael Kret	ed7d6b7b3a	feat(core): Display conditions in displayOptions (no-changelog) (#7888 )	2024-01-24 18:04:46 +02:00
कारतोफ्फेलस्क्रिप्ट™	d6deceacde	refactor(core): Remove roleId indirection (no-changelog) (#8413 )	2024-01-24 13:38:57 +01:00
github-actions[bot]	111d2ebe68	🚀 Release 1.26.0 (#8427 ) Co-authored-by: ivov <ivov@users.noreply.github.com>	2024-01-24 13:28:47 +01:00
कारतोफ्फेलस्क्रिप्ट™	1affebd85e	refactor(core): Remove unused code from Server.ts (no-changelog) (#8426 )	2024-01-24 12:55:43 +01:00
Cornelius Suermann	a8b4684192	build: Bump license-sdk to v2.9.1 (no-changelog) (#8420 )	2024-01-23 14:44:46 +01:00
Iván Ovejero	c0bc94c78f	refactor(core): Finish removing `UserManagementHelper` (no-changelog) (#8418 )	2024-01-23 13:58:31 +01:00
Iván Ovejero	a0a1830696	feat(core): Email recipients on resource shared (#8408 )	2024-01-23 12:03:59 +01:00
Danny Martini	ae06fdeb62	fix(core): Fix update workflow cli command being unable to activate all workflows (#8412 ) Co-authored-by: Daniel Schröder <daniel.schroeder@skriptfabrik.com>	2024-01-23 10:59:06 +01:00
Iván Ovejero	49b52c4f1d	refactor(core): Bring active executions into executions controller (no-changelog) (#8371 )	2024-01-23 09:48:50 +01:00
कारतोफ्फेलस्क्रिप्ट™	913c8c6b0c	feat(core): Upgrade oclif (no-changelog) (#8381 )	2024-01-22 18:25:36 +01:00
Cornelius Suermann	d597c2ab29	feat: Extend collection of usage metrics during license renewal (no-changelog) (#8369 ) Co-authored-by: Iván Ovejero <ivov.src@gmail.com>	2024-01-22 12:29:28 +01:00
Iván Ovejero	f35d4fcbd8	refactor(core): Simplify `OrchestrationService` (no-changelog) (#8364 )	2024-01-22 11:16:29 +01:00
Danny Martini	07e6705256	feat(core): Custom session timeout and refresh configuration (#8342 )	2024-01-22 09:54:13 +01:00
Giulio Andreini	f4f496ae85	docs(editor): All buttons to sentence case (no-changelog) (#8399 )	2024-01-22 09:20:02 +01:00
Jon	9883eda42e	fix: Fix openapi generation (no-changelog) (#8398 )	2024-01-19 18:15:33 +01:00
Iván Ovejero	749ac2b407	fix(core): Adjust starter node priority for manual executions with pinned activators (#8386 )	2024-01-19 10:18:04 +01:00
कारतोफ्फेलस्क्रिप्ट™	c7c4ae4514	feat(core): Upgrade swagger (no-changelog) (#8384 )	2024-01-18 14:16:14 +01:00
Tomi Turtiainen	f31cc0743f	fix: Force posthog recording to be disabled outside cloud (#8374 )	2024-01-18 14:44:27 +02:00
Jon	fc94377036	fix: Fix issue preventing secrets with a - in the path from being imported (#8378 )	2024-01-18 09:24:58 +00:00
Tomi Turtiainen	99457019f7	feat: Nudge users to become template creators if eligible (#8357 )	2024-01-17 19:07:34 +02:00
कारतोफ्फेलस्क्रिप्ट™	3912c5e7ab	feat(core): Upgrade axios and follow-redirects to address CVE-2023-26159 (#8366 )	2024-01-17 16:41:01 +01:00
कारतोफ्फेलस्क्रिप्ट™	639d34769e	feat(core): Upgrade bull and ioredis to address CVE-2023-52079 (#8365 )	2024-01-17 16:33:54 +01:00
Tomi Turtiainen	9a1cc56806	fix: Set '@typescript-eslint/return-await' rule to 'always' for node code (no-changelog) (#8363 ) Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>	2024-01-17 17:08:50 +02:00
Iván Ovejero	2eb829a6b4	refactor(core): Use DI in execution services (no-changelog) (#8358 )	2024-01-17 15:42:19 +01:00
github-actions[bot]	7268d24259	🚀 Release 1.25.0 (#8362 ) Co-authored-by: netroy <netroy@users.noreply.github.com>	2024-01-17 14:20:55 +01:00
Iván Ovejero	771d2fa341	test(core): Fix cleanup in test teardown script (no-changelog) (#8361 )	2024-01-17 14:01:56 +01:00
Omar Ajoue	d5455d7acc	fix(core): Report when waitTill is invalid and handle it (#8356 )	2024-01-17 13:08:20 +01:00
कारतोफ्फेलस्क्रिप्ट™	7cdbb424e3	refactor(core): Move methods from WorkflowHelpers into various workflow services (no-changelog) (#8348 )	2024-01-17 10:16:13 +01:00
Iván Ovejero	d4c93b1607	fix(core): Prevent issues with missing or mismatching encryption key (#8332 )	2024-01-16 18:25:53 +01:00
Iván Ovejero	7bb2d1799e	refactor(core): Consolidate executions controllers (no-changelog) (#8349 )	2024-01-16 16:52:21 +01:00
कारतोफ्फेलस्क्रिप्ट™	64ceb16af6	refactor(core): Use DI in PermissionChecker (no-changelog) (#8344 )	2024-01-16 14:15:29 +01:00
Iván Ovejero	420b4271a9	refactor(core): Move `typeorm` operators from Public API (no-changelog) (#8319 )	2024-01-16 13:35:43 +01:00
Omar Ajoue	e1acb5911a	refactor: Make execution IDs mandatory in BE (#8299 ) Co-authored-by: Iván Ovejero <ivov.src@gmail.com>	2024-01-16 09:53:17 +00:00
Iván Ovejero	0f4f472a72	refactor(core): Eliminate dead Redis code (no-changelog) (#8292 )	2024-01-16 09:31:45 +01:00
Iván Ovejero	5fbd7971e0	fix(core): Account for immediate confirmation request during test webhook creation (#8329 )	2024-01-16 09:17:41 +01:00
Ricardo Espinoza	3c2a4000ae	refactor(core): Use DI for LDAP code (no-changelog) (#8248 ) Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>	2024-01-15 09:01:48 -05:00
Iván Ovejero	1a0e285553	feat(core): Implement inter-main communication for test webhooks in multi-main setup (#8267 )	2024-01-12 11:48:58 +01:00
oleg	884396ea0d	fix(API): Fix manual chat trigger execution (#8300 ) Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>	2024-01-11 14:01:07 +01:00
Omar Ajoue	8c7f39907f	fix: Properly output saml validation errors (#8284 )	2024-01-10 16:56:04 +01:00
github-actions[bot]	8a4231e9f6	🚀 Release 1.24.0 (#8290 ) Co-authored-by: ivov <ivov@users.noreply.github.com>	2024-01-10 16:16:25 +01:00
Omar Ajoue	8a7c629ea1	fix: Store workflow settings when saving an execution (#8288 )	2024-01-10 14:20:37 +00:00
Michael Kret	ccde38a8a8	fix(Monday.com Node): Migrate to api 2023-10 (#8254 )	2024-01-10 11:17:00 +02:00
Iván Ovejero	5032bf0e34	fix(core): Fix test webhook deregistration (#8247 )	2024-01-09 16:02:32 +01:00
Iván Ovejero	0dabe5c74e	fix: Fix user reinvites on FE and BE (#8261 )	2024-01-09 13:52:34 +01:00
Tomi Turtiainen	3b996a7da0	feat(core): Validate shutdown handlers on startup (#8260 )	2024-01-08 17:46:45 +02:00
Tomi Turtiainen	8affdf680d	fix: Hide cred setup button from canvas (no-changelog) (#8255 )	2024-01-08 13:59:04 +02:00
Iván Ovejero	90c065e999	refactor(core): Convert workflows controller to DI (no-changelog) (#8253 )	2024-01-08 12:54:23 +01:00
कारतोफ्फेलस्क्रिप्ट™	ac1c642fdd	fix(core): Do not add Authentication header when `authentication` type is `body` (#8201 )	2024-01-08 12:38:24 +01:00
Jan Oberhauser	ccb2b076f8	fix: Resolve expressions in credentials following paired item (#8250 ) ## Summary Fixes the issue that pairedItem information was not available in expressions that got used in credentials ## Related tickets and issues [PAY-1207](https://linear.app/n8n/issue/PAY-1207/paireditem-expressions-not-working-correctly-in-credentials) ## Review / Merge checklist - [x] PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise. ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md)) - [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created. - [ ] Tests included. > A bug is not considered fixed, unless a test is added to prevent it from happening again. > A feature is not complete without tests. --------- Co-authored-by: Omar Ajoue <krynble@gmail.com>	2024-01-08 09:48:20 +00:00
Iván Ovejero	f2939568cf	perf(core): Optimize workflow activation errors (#8242 ) At https://github.com/n8n-io/n8n/pull/8213 we introduced Redis hashes for workflow ownership and manual webhooks... - to remove clutter from multiple related keys at the top level, - to improve performance by preventing serializing-deserializing, and - to guarantee atomicity during concurrent updates in multi-main setup. Workflow activation errors can also benefit from this. Added test coverage as well. To test manually, create a workflow with a trigger with an invalid credential, edit the workflow's `active` column to `true`, and restart. The activation error should show as a red triangle on canvas and in the workflow list.	2024-01-05 13:06:42 +01:00
Iván Ovejero	23a4ac96c0	refactor(core): Continue moving `typeorm` operators to repositories (no-changelog) (#8212 ) Follow-up to: https://github.com/n8n-io/n8n/pull/8186	2024-01-05 13:06:24 +01:00
Iván Ovejero	f53c482939	perf(core): Improve caching service (#8213 ) Story: https://linear.app/n8n/issue/PAY-1188 - Implement Redis hashes on the caching service, based on Micha's work in #7747, adapted from `node-cache-manager-ioredis-yet`. Optimize workflow ownership lookups and manual webhook lookups with Redis hashes. - Simplify the caching service by removing all currently unused methods and options: `enable`, `disable`, `getCache`, `keys`, `keyValues`, `refreshFunctionEach`, `refreshFunctionMany`, `refreshTtl`, etc. - Remove the flag `N8N_CACHE_ENABLED`. Currently some features on `master` are broken with caching disabled, and test webhooks now rely entirely on caching, for multi-main setup support. We originally introduced this flag to protect against excessive memory usage, but total cache usage is low enough that we decided to drop this setting. Apparently this flag was also never documented. - Overall caching service refactor: use generics, reduce branching, add discriminants for cache kinds for better type safety, type caching events, improve readability, remove outdated docs, etc. Also refactor and expand caching service tests. Follow-up to: https://github.com/n8n-io/n8n/pull/8176 --------- Co-authored-by: Michael Auerswald <michael.auerswald@gmail.com>	2024-01-05 11:52:44 +01:00
Iván Ovejero	22a5f5258d	feat(core): Cache test webhook registrations (#8176 ) In a multi-main setup, we have the following issue. The user's client connects to main A and runs a test webhook, so main A starts listening for a webhook call. A third-party service sends a request to the test webhook URL. The request is forwarded by the load balancer to main B, who is not listening for this webhook call. Therefore, the webhook call is unhandled. To start addressing this, cache test webhook registrations, using Redis for queue mode and in-memory for regular mode. When the third-party service sends a request to the test webhook URL, the request is forwarded by the load balancer to main B, who fetches test webhooks from the cache and, if it finds a match, executes the test webhook. This should be transparent - test webhook behavior should remain the same as so far. Notes: - Test webhook timeouts are not cached. A timeout is only relevant to the process it was created in, so another process retrieving from Redis a "foreign" timeout will be unable to act on it. A timeout also has circular references, so `cache-manager-ioredis-yet` is unable to serialize it. - In a single-main scenario, the timeout remains in the single process and is cleared on test webhook expiration, successful execution, and manual cancellation - all as usual. - In a multi-main scenario, we will need to have the process who received the webhook call send a message to the process who created the webhook directing this originating process to clear the timeout. This will likely be implemented via execution lifecycle hooks and Redis channel messages checking session ID. This implementation is out of scope for this PR and will come next. - Additional data in test webhooks is not cached. From what I can tell, additional data is not needed for test webhooks to be executed. Additional data also has circular references, so `cache-manager-ioredis-yet` is unable to serialize it. Follow-up to: #8155	2024-01-03 16:58:33 +01:00
github-actions[bot]	053503531f	🚀 Release 1.23.0 (#8205 ) # [1.23.0](https://github.com/n8n-io/n8n/compare/n8n@1.22.0...n8n@1.23.0) (2024-01-03) ### Bug Fixes * Asana Node: Omit body from GET, HEAD, and DELETE requests ([#8057](https://github.com/n8n-io/n8n/issues/8057)) ([`15ffd4f`](`15ffd4fb9f`)) * core: Better input validation for the changeRole endpoint ([#8189](https://github.com/n8n-io/n8n/issues/8189)) ([`cfe9525`](`cfe9525dd4`)) * core: Fix issue that pinnedData is not used with Test-Webhooks ([#8123](https://github.com/n8n-io/n8n/issues/8123)) ([`fa8bd8b`](`fa8bd8b9eb`)) * core: Handle empty executions table in pruning in migrations ([#8121](https://github.com/n8n-io/n8n/issues/8121)) ([`ffaa30d`](`ffaa30ddc4`)) * core: Remove circular dependency in WorkflowService and ActiveWorkflowRunner ([#8128](https://github.com/n8n-io/n8n/issues/8128)) ([`21788d9`](`21788d9153`)) * core: Use pinned data only for manual mode ([#8164](https://github.com/n8n-io/n8n/issues/8164)) ([`ea7e76f`](`ea7e76fa3b`)) * Discord Node: Remove unnecessary requirement on parameters ([#8060](https://github.com/n8n-io/n8n/issues/8060)) ([`ef3a577`](`ef3a57719e`)) * editor: Avoid sanitizing output to search node data ([#8126](https://github.com/n8n-io/n8n/issues/8126)) ([`c83d9f4`](`c83d9f45ba`)) * editor: Enable explicit undo keyboard shortcut across all code editors ([#8178](https://github.com/n8n-io/n8n/issues/8178)) ([`cf7f668`](`cf7f6688ba`)) * editor: Fix operation change failing in certain conditions ([#8114](https://github.com/n8n-io/n8n/issues/8114)) ([`711fa2b`](`711fa2b925`)) * editor: Fix templates view layout ([#8196](https://github.com/n8n-io/n8n/issues/8196)) ([`d01e42a`](`d01e42a2aa`)) * editor: Fix UI urls when hosted behind a path prefix ([#8198](https://github.com/n8n-io/n8n/issues/8198)) ([`5c078f1`](`5c078f1b3d`)) * editor: Prevent browser zoom when scrolling inside sticky edit mode ([#8116](https://github.com/n8n-io/n8n/issues/8116)) ([`e928210`](`e928210ccd`)) * editor: Prevent canvas undo/redo when NDV is open ([#8118](https://github.com/n8n-io/n8n/issues/8118)) ([`39e45d8`](`39e45d8b92`)) * editor: Prevent storing pairedItem data inside of pinData ([#8173](https://github.com/n8n-io/n8n/issues/8173)) ([`405e267`](`405e26757e`)) * GitHub Node: Fix issue that File->Get did not run once per item ([#8190](https://github.com/n8n-io/n8n/issues/8190)) ([`11cda41`](`11cda41214`)) * Invoice Ninja Node: Fix issue with custom invoice numbers not working with v5 ([#8200](https://github.com/n8n-io/n8n/issues/8200)) ([`3b6ae2d`](`3b6ae2d0a5`)) * Microsoft Excel 365 Node: Ensure arg is string during worksheet table search ([#8154](https://github.com/n8n-io/n8n/issues/8154)) ([`8e873ca`](`8e873ca2f3`)) * Notion Node: Ensure arg is string during page ID extraction ([#8153](https://github.com/n8n-io/n8n/issues/8153)) ([`e94b8a6`](`e94b8a6c30`)) * Redis Trigger Node: Activating a workflow with a Redis trigger fails ([#8129](https://github.com/n8n-io/n8n/issues/8129)) ([`a169b74`](`a169b74062`)) * Schedule Trigger Node: Use the correct `moment` import ([#8185](https://github.com/n8n-io/n8n/issues/8185)) ([`17a4e2e`](`17a4e2ea80`)) * Show public API upgrade CTA when feature is not enabled ([#8109](https://github.com/n8n-io/n8n/issues/8109)) ([`e9c7fd7`](`e9c7fd7397`)) ### Features * core: Add closeFunction support to Sub-Nodes ([#7708](https://github.com/n8n-io/n8n/issues/7708)) ([`bec0fae`](`bec0faed9e`)) * core: Add user.profile.beforeUpdate hook ([#8144](https://github.com/n8n-io/n8n/issues/8144)) ([`e126ed7`](`e126ed74f3`)) * core: Improvements/overhaul for nodes working with binary data ([#7651](https://github.com/n8n-io/n8n/issues/7651)) ([`5e16dd4`](`5e16dd4ab4`)) * core: Remove discontinued crypto-js ([#8104](https://github.com/n8n-io/n8n/issues/8104)) ([`01e9a79`](`01e9a79238`)) * core: Unify application components shutdown ([#8097](https://github.com/n8n-io/n8n/issues/8097)) ([`3a881be`](`3a881be6c2`)) * editor: Add node execution status indicator to output panel ([#8124](https://github.com/n8n-io/n8n/issues/8124)) ([`ab74bad`](`ab74bade05`)) * editor: Add template Id to workflow metadata ([#8088](https://github.com/n8n-io/n8n/issues/8088)) ([`517b050`](`517b050d0a`)) * Home Assistant Node: Use the new Home Assistant logo ([#8150](https://github.com/n8n-io/n8n/issues/8150)) ([`518a99e`](`518a99e528`)) * Qdrant Vector Store Node: Qdrant vector store support ([#8080](https://github.com/n8n-io/n8n/issues/8080)) ([`66460f6`](`66460f66b0`)) * Wordpress Node: Add option to ignore error when using self signed certificates ([#8199](https://github.com/n8n-io/n8n/issues/8199)) ([`65c8e12`](`65c8e12b96`)) Co-authored-by: ivov <ivov@users.noreply.github.com>	2024-01-03 13:41:28 +01:00
कारतोफ्फेलस्क्रिप्ट™	cfe9525dd4	fix(core): Better input validation for the changeRole endpoint (#8189 ) also refactored the code to 1. stop passing around `scope === 'global'`, since this code can be used only for changing globalRole. 2. leak less details when input validation fails. ## Review / Merge checklist - [x] PR title and summary are descriptive - [x] Tests included	2024-01-03 09:33:35 +01:00
Iván Ovejero	40c1eeeddd	refactor(core): Continue moving `typeorm` operators to repositories (no-changelog) (#8186 ) Follow-up to: #8163	2024-01-02 17:53:24 +01:00
Tomi Turtiainen	e126ed74f3	feat(core): Add user.profile.beforeUpdate hook (#8144 ) Add `user.profile.beforeUpdate` hook so we can prevent user email change if it overlaps with other users email.	2024-01-02 10:15:12 +02:00
Iván Ovejero	ece48d6a13	refactor(core): Unify workflow controllers (no-changelog) (#8175 ) Combine EE workflows controller into main workflows controller, protecting paid functionality behind feature flag checks.	2023-12-29 14:23:58 +01:00
Iván Ovejero	4bad43dd66	refactor(core): Move `typeorm` operators from `WaitTracker` to `ExecutionRepository` (no-changelog) (#8163 ) Follow-up to: #8145 --------- Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>	2023-12-28 19:22:09 +01:00
Iván Ovejero	e418d42450	refactor(core): Move `typeorm` operators from various sources into repositories (no-changelog) (#8174 ) Follow-up to: #8165	2023-12-28 13:14:10 +01:00
कारतोफ्फेलस्क्रिप्ट™	c84d3c3bbf	refactor(core): Extract ActiveWebhooks out of ActiveWorkflowRunner (no-changelog) (#8171 ) ## Summary This PR continues refactoring webhooks code for better modularity. Continued from #8069 to bring back `ActiveWebhooks`, but this time actually handling active webhook calls in this class. ## Review / Merge checklist - [x] PR title and summary are descriptive	2023-12-28 10:04:32 +01:00
Iván Ovejero	639afcd7a5	refactor(core): Simplify state in test webhooks (no-changelog) (#8155 ) This PR simplifies state in test webhooks so that it can be cached easily. Caching this state will allow us to start using Redis for manual webhooks, to support manual webhooks to work in multi-main setup. - [x] Convert `workflowWebhooks` to a getter - no need to optimize for deactivation - [x] Remove array from value in `TestWebhooks.webhookUrls` - [x] Consolidate `webhookUrls` and `registeredWebhooks`	2023-12-28 09:28:12 +01:00
Iván Ovejero	0e582594ea	refactor(core): Move more `typeorm` operators to `UserRepository` (no-changelog) (#8165 ) Follow-up to: #8163	2023-12-28 09:27:47 +01:00
Iván Ovejero	5aee7a1d48	refactor(core): Move `typeorm` operators from `SourceControlExportService` to repositories (no-changelog) (#8168 ) Follow-up to: #8165	2023-12-28 09:27:38 +01:00
Jan Oberhauser	ea7e76fa3b	fix(core): Use pinned data only for manual mode (#8164 ) ## Summary Fixes the issue that pinned data gets also used for production executions. --------- Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>	2023-12-27 18:22:33 +01:00
Iván Ovejero	2c6ffb0153	fix(core): Minor improvements to multi-main setup (no-changelog) (#8012 ) - Move webhook, poller and trigger activation logs closer to activation event - Enrich response of `/debug/multi-main-setup` - Ensure workflow updates broadcast activation state changes only if state changed - Fix bug on workflow activation after leadership change - Ensure debug controller is not available in production --------- Co-authored-by: Omar Ajoue <krynble@gmail.com>	2023-12-27 16:55:01 +01:00
कारतोफ्फेलस्क्रिप्ट™	f69ddcd796	refactor(core): Use Dependency Injection for all Controller classes (no-changelog) (#8146 ) ## Review / Merge checklist - [x] PR title and summary are descriptive	2023-12-27 11:50:43 +01:00
Jan Oberhauser	fa8bd8b9eb	fix(core): Fix issue that pinnedData is not used with Test-Webhooks (#8123 ) ## Summary When a workflow gets started via a Test-Webhook the pinned data does get ignored and the nodes executed anyway. ## Related tickets and issues > Include links to Linear ticket or Github issue or Community forum post. Important in order to close automatically and provide context to reviewers. ## Review / Merge checklist - [x] PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise. ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md)) - [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created. - [X] Tests included. > A bug is not considered fixed, unless a test is added to prevent it from happening again. > A feature is not complete without tests. --------- Co-authored-by: Mutasem Aldmour <mutasem@n8n.io>	2023-12-27 10:51:53 +01:00
Iván Ovejero	7b26a7a621	refactor(core): Move `typeorm` operators from `PruningService` to `ExecutionRepository` (no-changelog) (#8145 ) Follow-up to https://github.com/n8n-io/n8n/pull/8143	2023-12-22 17:49:15 +01:00
Iván Ovejero	a59d78de18	refactor(core): Move more `typeorm` operators to repositories (no-changelog) (#8143 ) Follow-up to #8139	2023-12-22 16:20:30 +01:00
कारतोफ्फेलस्क्रिप्ट™	4007163651	refactor(core): Delete unused code, and fix typings in tests (no-changelog) (#8142 )	2023-12-22 15:41:29 +01:00
कारतोफ्फेलस्क्रिप्ट™	baee47a276	refactor(core): Move all base URLs to UrlService (no-changelog) (#8141 ) This change kept coming up in #6713, #7773, and #8135. So this PR moves the existing code without actually changing anything, to help get rid of some of the circular dependencies. ## Review / Merge checklist - [x] PR title and summary are descriptive.	2023-12-22 15:19:50 +01:00
Iván Ovejero	c6dd935895	refactor(core): Move some `typeorm` operators to repositories (no-changelog) (#8139 ) Moving some persistence logic to repositories to reduce circular dependencies.	2023-12-22 13:35:23 +01:00
Tomi Turtiainen	3a881be6c2	feat(core): Unify application components shutdown (#8097 ) ## Summary Add `ShutdownService` and `OnShutdown` decorator for more unified way to shutdown different components. Use this new way in the following components: - HTTP(S) server - Pruning service - Push connection - License --------- Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>	2023-12-22 12:39:58 +02:00
कारतोफ्फेलस्क्रिप्ट™	c158ca2471	refactor(core): Upgrade more dependencies to remove axios 0.x (no-changelog) (#8105 ) Had to [fork localtunnel](https://github.com/n8n-io/localtunnel) to get the axios upgrade, since localtunnel doesn't seem to be actively maintained.	2023-12-22 11:39:20 +01:00
कारतोफ्फेलस्क्रिप्ट™	021add0f39	refactor(core): Move active workflows endpoints to a decorated controller class (no-changelog) (#8101 ) This is a continuation of migrating all rest endpoints to decorated controller classes	2023-12-22 11:28:42 +01:00
कारतोफ्फेलस्क्रिप्ट™	21788d9153	fix(core): Remove circular dependency in WorkflowService and ActiveWorkflowRunner (#8128 ) ## Summary A circular dependency between `WorkflowService` and `ActiveWorkflowRunner` is sometimes causing `this.activeWorkflowRunner` to be `undefined` in `WorkflowService`. Breaking this circular dependency should hopefully fix this issue. ## Related tickets and issues #8122 ## Review / Merge checklist - [x] PR title and summary are descriptive - [ ] Tests included	2023-12-21 17:37:08 +01:00
कारतोफ्फेलस्क्रिप्ट™	ffaa30ddc4	fix(core): Handle empty executions table in pruning in migrations (#8121 ) In case someone manually prunes their executions table before upgrading to 1.x, `MigrateIntegerKeysToString` should gracefully handle that, instead of crashing the application. ## Review / Merge checklist - [x] PR title and summary are descriptive	2023-12-21 14:52:42 +01:00
Iván Ovejero	9ac8825a67	refactor(core): Move error execution creation to execution service (no-changelog) (#8006 ) Continue breaking down legacy helpers. Note: `getUserById` is unused.	2023-12-21 14:15:46 +01:00
Iván Ovejero	d1b2affd2c	ci: Add lint rule `no-dynamic-import-template` (no-changelog) (#8089 ) Follow-up to: https://github.com/n8n-io/n8n/pull/8086 `tsc-alias` as of 1.8.7 is unable to resolve template strings in dynamic imports. Since the module name mapper in Jest is able to, this issue is hard to detect, hence the new lint rule `no-dynamic-import-template`. This is for now specific to `@/` in the `cli` package - we can generalize later if needed. Ideally we should contribute a fix upstream when we have more time. <img width="940" alt="Capture 2023-12-19 at 12 39 55@2x" src="https://github.com/n8n-io/n8n/assets/44588767/78d4a277-ccff-455c-8610-d1bba39d93f2">	2023-12-21 14:15:37 +01:00
कारतोफ्फेलस्क्रिप्ट™	01e9a79238	feat(core): Remove discontinued crypto-js (#8104 ) Since crypto-js was [discontinued](`1da3dabf93`), [we migrated all our backend encryption to native crypto](https://github.com/n8n-io/n8n/pull/7556). However I decided back then to not remove crypto-js just yet in expressions, as I wanted to use `SubtleCrypto`. Unfortunately for that to work, we'd need to make expressions async. So, to get rid of `crypto-js`, I propose this interim solution. ## Related tickets and issues N8N-7020 ## Review / Merge checklist - [x] PR title and summary are descriptive - [x] Tests included	2023-12-21 14:13:02 +01:00
github-actions[bot]	b67b5ae6b2	🚀 Release 1.22.0 (#8115 ) # [1.22.0](https://github.com/n8n-io/n8n/compare/n8n@1.21.0...n8n@1.22.0) (2023-12-21) ### Bug Fixes * core: Close db connection gracefully when exiting ([#8045](https://github.com/n8n-io/n8n/pull/8045)) ([`e69707e`](`e69707efd4`)) * core: Consider timeout in shutdown an error ([#8050](https://github.com/n8n-io/n8n/pull/8050)) ([`4cae976`](`4cae976a3b`)) * core: Do not display error when stopping jobless execution in queue mode ([#8007](https://github.com/n8n-io/n8n/pull/8007)) ([`8e6b951`](`8e6b951a76`)) * core: Fix shutdown if terminating before hooks are initialized ([#8047](https://github.com/n8n-io/n8n/pull/8047)) ([`6ae2f5e`](`6ae2f5efea`)) * core: Handle multiple termination signals correctly ([#8046](https://github.com/n8n-io/n8n/pull/8046)) ([`67bd8ad`](`67bd8ad698`)) * core: Initialize queue once in queue mode ([#8025](https://github.com/n8n-io/n8n/pull/8025)) ([`53c0b49`](`53c0b49d15`)) * core: Prevent axios from force setting a form-urlencoded content-type ([#8117](https://github.com/n8n-io/n8n/pull/8117)) ([`bba9576`](`bba95761e2`)) * core: Remove circular references before serializing executions in public API ([#8043](https://github.com/n8n-io/n8n/pull/8043)) ([`989888d`](`989888d9bc`)) * core: Restore workflow ID during execution creation ([#8031](https://github.com/n8n-io/n8n/pull/8031)) ([`c5e6ba8`](`c5e6ba8cdd`)) * core: Use relative imports for dynamic imports in SecurityAuditService ([#8086](https://github.com/n8n-io/n8n/pull/8086)) ([`785bf99`](`785bf9974e`)) * core: Stop binary data restoration from preventing execution from finishing ([#8082](https://github.com/n8n-io/n8n/pull/8082)) ([`5ffff1b`](`5ffff1bb22`)) * editor: Add back credential `use` permission ([#8023](https://github.com/n8n-io/n8n/pull/8023)) ([`329e5bf`](`329e5bf9ee`)) * editor: Cleanup Executions page component ([#8053](https://github.com/n8n-io/n8n/pull/8053)) ([`2689c37`](`2689c37e87`)) * editor: Disable auto scroll and list size check when clicking on executions ([#7983](https://github.com/n8n-io/n8n/pull/7983)) ([`fcb8b91`](`fcb8b91f37`)) * editor: Ensure execution data overrides pinned data when copying in executions view ([#8009](https://github.com/n8n-io/n8n/pull/8009)) ([`1d1cb0d`](`1d1cb0d3c5`)) * editor: Fix copy/paste issue when switch node is in workflow ([#8103](https://github.com/n8n-io/n8n/pull/8103)) ([`4b86926`](`4b86926752`)) * editor: Make keyboard shortcuts more strict; don't accept extra Ctrl/Alt/Shift keys ([#8024](https://github.com/n8n-io/n8n/pull/8024)) ([`8df49e1`](`8df49e134d`)) * editor: Show credential share info only to appropriate users ([#8020](https://github.com/n8n-io/n8n/pull/8020)) ([`b29b4d4`](`b29b4d442b`)) * editor: Turn off executions list auto-refresh after leaving the page ([#8005](https://github.com/n8n-io/n8n/pull/8005)) ([`e3c363d`](`e3c363d72c`)) * editor: Update image sizes in template description not to be full width always ([#8037](https://github.com/n8n-io/n8n/pull/8037)) ([`63a6e7e`](`63a6e7e034`)) * ActiveCampaign Node: Fix pagination issue when loading tags ([#8017](https://github.com/n8n-io/n8n/pull/8017)) ([`1943857`](`1943857231`)) * HTTP Request Node: Do not create circular references in HTTP request node output ([#8030](https://github.com/n8n-io/n8n/pull/8030)) ([`5b7ea16`](`5b7ea16d9a`)) * Upgrade axios to address CVE-2023-45857 ([#7713](https://github.com/n8n-io/n8n/pull/7713)) ([`64eb9bb`](`64eb9bbc36`)) ### Features * Add option to `returnIntermediateSteps` for AI agents ([#8113](https://github.com/n8n-io/n8n/pull/8113)) ([`7806a65`](`7806a65229`)) * core: Add config option to prefer GET request over LIST when using Hashicorp Vault ([#8049](https://github.com/n8n-io/n8n/pull/8049)) ([`439a22d`](`439a22d68f`)) * core: Add N8N_GRACEFUL_SHUTDOWN_TIMEOUT env var ([#8068](https://github.com/n8n-io/n8n/pull/8068)) ([`614f488`](`614f488386`)) * editor: Add lead enrichment suggestions to workflow list ([#8042](https://github.com/n8n-io/n8n/pull/8042)) ([`36a923c`](`36a923cf7b`)) * editor: Finalize workers view ([#8052](https://github.com/n8n-io/n8n/pull/8052)) ([`edfa784`](`edfa78414d`)) * editor: Gracefully ignore invalid payloads in postMessage handler ([#8096](https://github.com/n8n-io/n8n/pull/8096)) ([9d22c7a](`9d22c7a278`)) * editor: Upgrade frontend tooling to address a few vulnerabilities ([#8100](https://github.com/n8n-io/n8n/pull/8100)) ([`19b7f1f`](`19b7f1ffb1`)) * Filter Node: Overhaul UI by adding the new filter component ([#8016](https://github.com/n8n-io/n8n/pull/8016)) ([`3d53052`](`3d530522f8`)) * Respond to Webhook Node: Overhaul with improvements like returning all items ([#8093](https://github.com/n8n-io/n8n/pull/8093)) ([`32d397e`](`32d397eff3`)) ### Performance Improvements * editor: Improve canvas rendering performance ([#8022](https://github.com/n8n-io/n8n/pull/8022)) ([`b780436`](`b780436a6b`)) Co-authored-by: ivov <ivov@users.noreply.github.com>	2023-12-21 13:51:24 +01:00
Omar Ajoue	5ffff1bb22	fix: Stop binary data restoration from preventing execution from finishing (#8082 ) In the case of a filesystem failure to rename the binary files as part of the execution's cleanup process, the execution would fail to be saved and would never finish. This catch prevents it. ## Summary Whenever an execution is wrapping u to save the data, if it uses binary data n8n will try to find possibly misallocated files and place them in the right folder. If this process fails, the execution fails to finish. Given the execution has already finished at this point, and we cannot handle the binary data errors more gracefully, all we can do at this point is log the message as it's a filesystem issue. The rest of the execution saving process should remain as normal. ## Related tickets and issues https://linear.app/n8n/issue/HELP-430 ## Review / Merge checklist - [ ] PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise. ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md)) - [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created. - [ ] Tests included. > A bug is not considered fixed, unless a test is added to prevent it from happening again. > A feature is not complete without tests. --------- Co-authored-by: Iván Ovejero <ivov.src@gmail.com>	2023-12-21 09:40:39 +00:00
Iván Ovejero	edfa78414d	feat(editor): Finalize workers view (#8052 ) https://linear.app/n8n/issue/PAY-1065	2023-12-20 17:49:14 +01:00
Iván Ovejero	97aa38e783	ci: Fix Postgres and MySQL tests (no-changelog) (#8106 ) This role query works for sqlite but [fails for Postgres and MySQL](https://github.com/n8n-io/n8n/actions/runs/7269009778/job/19805986017), so generalize by adding alias and accounting for count possibly being `string` in the resulting rows. Run in progress: https://github.com/n8n-io/n8n/actions/runs/7275986797	2023-12-20 15:14:31 +01:00
कारतोफ्फेलस्क्रिप्ट™	81994ce13d	fix(core): Downgrade Rudderstack SDK (no-changelog) (#8107 ) This reverts commit `a895ee87fc` (#8090) Our telemetry backend is throwing 500s with the updated rudderstack sdk. Until that is resolved, we need to downgrade. ## Review / Merge checklist - [x] PR title and summary are descriptive	2023-12-20 11:59:44 +01:00
Iván Ovejero	9dc491c3a5	refactor(core): Improve test-webhooks (no-changelog) (#8069 ) Remove duplication, improve readability, and expand tests for `TestWebhooks.ts` - in anticipation for storing test webhooks in Redis. --------- Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>	2023-12-19 17:32:02 +01:00
Iván Ovejero	38d1336fa7	refactor: Add telemetry for RBAC (no-changelog) (#8056 ) https://linear.app/n8n/issue/PAY-1142	2023-12-19 17:02:52 +01:00
कारतोफ्फेलस्क्रिप्ट™	a895ee87fc	feat(core): Upgrade Rudderstack SDK (no-changelog) (#8090 ) This helps remove some of the older versions of transient dependencies, like axios 0.x and ioredis 4.x. ## Review / Merge checklist - [x] PR title and summary are descriptive.	2023-12-19 16:53:12 +01:00
कारतोफ्फेलस्क्रिप्ट™	64eb9bbc36	fix: Upgrade axios to address CVE-2023-45857 (#7713 ) [GH Advisory](https://github.com/advisories/GHSA-wf5p-g6vw-rhxx)	2023-12-19 16:17:01 +01:00
Iván Ovejero	8e6b951a76	fix(core): Do not display error when stopping jobless execution in queue mode (#8007 ) No need to surface error to user when stopping a job no longer in queue. https://linear.app/n8n/issue/PAY-1104	2023-12-19 16:11:21 +01:00
कारतोफ्फेलस्क्रिप्ट™	464b565283	ci: Remove unnecessary async/await, enable await-thenable linting rule (no-changelog) (#8076 ) ## Summary We accidentally made some functions `async` in https://github.com/n8n-io/n8n/pull/7846 This PR reverts that change. ## Review / Merge checklist - [x] PR title and summary are descriptive.	2023-12-19 13:52:42 +01:00
कारतोफ्फेलस्क्रिप्ट™	785bf9974e	fix(core): Use relative imports for dynamic imports in SecurityAuditService (#8086 ) `tsc-alias` doesn't seem to replace imports when using template strings ## Related tickets and issues #8085 ## Review / Merge checklist - [x] PR title and summary are descriptive.	2023-12-19 12:41:15 +01:00
कारतोफ्फेलस्क्रिप्ट™	a63d94f28c	refactor(core): Move license endpoints to a decorated controller class (no-changelog) (#8074 )	2023-12-19 12:13:19 +01:00
Iván Ovejero	73d400a1bf	refactor(core): Inject dependencies into workflow services (no-changelog) (#8066 ) Inject dependencies into workflow services (no-changelog) Up next: - ~~Make workflow services injectable~~ #8033 - ~~Inject dependencies into workflow services~~ (current) - Consolidate workflow controllers into one - Make workflow controller injectable - Inject dependencies into workflow controller	2023-12-18 16:10:30 +01:00
कारतोफ्फेलस्क्रिप्ट™	a651089a10	refactor(core): Update backend sentry setup to reduce noise (no-changelog) (#8026 ) ## Summary This PR updates our backend sentry setup to remove integrations that don't provide us any value. This also reduces the amount of PII that gets sent to Sentry. [Sample event](https://n8nio.sentry.io/issues/4725315362/) ## Related tickets [ENG-95](https://linear.app/n8n/issue/ENG-95) ## Review / Merge checklist - [x] PR title and summary are descriptive.	2023-12-18 14:26:07 +01:00
Tomi Turtiainen	614f488386	feat(core): Add N8N_GRACEFUL_SHUTDOWN_TIMEOUT env var (#8068 ) Add generic N8N_GRACEFUL_SHUTDOWN_TIMEOUT which controls how long n8n process will wait for graceful exit before exitting forcefully. This variables replaces the QUEUE_WORKER_TIMEOUT variable that was used for worker process. DEPRECATED: QUEUE_WORKER_TIMEOUT deprected QUEUE_WORKER_TIMEOUT environment variable has been replaced with N8N_GRACEFUL_SHUTDOWN_TIMEOUT.	2023-12-18 14:04:19 +02:00
Tomi Turtiainen	4cae976a3b	fix(core): Consider timeout in shutdown an error (#8050 ) If the process doesn't shutdown within a time limit, exit with error code. 1. conceptually something timing out is an error. 2. on successful exit we close down the DB connection gracefully. On an exit timeout we rather not do that, since it will wait for any active connections to close and would possible block the exit.	2023-12-18 10:53:34 +02:00
Tomi Turtiainen	6ae2f5efea	fix(core): Fix shutdown if terminating before hooks are initialized (#8047 ) If the app receives termination signal before hooks have been initialised, the would be objet is undefined error. This PR fixes that.	2023-12-18 09:23:10 +02:00
Jon	439a22d68f	feat: Add config option to prefer GET request over LIST when using Hashicorp Vault (#8049 ) ## Summary Hashicorp Vault prefers a `LIST` HTTP method to be used when fetching secrets but not all environments will allow custom http methods through WAFs. This PR adds `N8N_EXTERNAL_SECRETS_PREFER_GET` which when set to `true` will use GET instead of LIST to fetch secrets. ## Review / Merge checklist - [x] PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise. ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md))	2023-12-15 16:20:39 +00:00
Tomi Turtiainen	67bd8ad698	fix(core): Handle multiple termination signals correctly (#8046 ) Prevent possible multiple termination signals initiating the shutdown process multiple times.	2023-12-15 17:35:22 +02:00
Tomi Turtiainen	e69707efd4	fix(core): Close db connection gracefully when exiting (#8045 ) Close db connection gracefully when exiting	2023-12-15 17:16:35 +02:00
Marcus	48d4f4a71b	fix(core): Public API support node's deprecated continueOnFail to upload old workflows (no-changelog) (#8044 )	2023-12-15 16:11:53 +01:00
कारतोफ्फेलस्क्रिप्ट™	989888d9bc	fix(core): Remove circular references before serializing executions in public API (#8043 ) ## Summary Handle circular references in the public API for executions created prior to the fix from #8030 ## Related tickets [PAY-1119](https://linear.app/n8n/issue/PAY-1119) ## Review / Merge checklist - [x] PR title and summary are descriptive.	2023-12-15 16:01:41 +01:00
Iván Ovejero	1e7a309e63	refactor(core): Make workflow services injectable (no-changelog) (#8033 ) Refactor static workflow service classes into DI-compatible classes Context: https://n8nio.slack.com/archives/C069HS026UF/p1702466571648889 Up next: - Inject dependencies into workflow services - Consolidate workflow controllers into one - Make workflow controller injectable - Inject dependencies into workflow controller --------- Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>	2023-12-15 12:59:56 +01:00
Iván Ovejero	2da15d0264	refactor(core): Remove ID-less workflow reporting (no-changelog) (#8038 ) We added ID-less workflow reporting at #8031, which has already produced multiple reports coming from internal, enough info to tackle [this story](https://linear.app/n8n/issue/PAY-1147). To prevent an overwhelming number of reports from cloud, this PR removes the reporting for now.	2023-12-15 12:50:09 +01:00
Iván Ovejero	f18bc5f4b7	refactor(core): Warn on sqlite DB detected during init on queue mode (#8034 ) When setting up queue mode, it is easy to overlook that not exporting Postgres env vars will default the worker to use sqlite, which will fail during execution with a non-obvious error. Hence add warnings when starting a worker with an incompatible DB type.	2023-12-15 10:56:35 +01:00
Iván Ovejero	c5e6ba8cdd	fix(core): Restore workflow ID during execution creation (#8031 ) ## Summary Restore workflow ID during execution creation removed by [this PR](https://github.com/n8n-io/n8n/pull/8002/files#diff-c8cbb62ca9ab2ae45e5f565cd8c63fff6475809a6241ea0b90acc575615224af). The missing workflow ID, and more generally the fact that `workflow.id` is optional when it should not be, causes `PermissionChecker.check` to misreport a credential as inaccessible when it should be accessible. More generally, start reporting ID-less workflows so we can root them out and prevent this at type level. ## Related tickets and issues https://n8nio.slack.com/archives/C035KBDA917/p1702539465555529	2023-12-14 18:13:12 +01:00
Iván Ovejero	53c0b49d15	fix(core): Initialize queue once in queue mode (#8025 ) We're initializing the queue twice because of a [bad merge](`2c63474538`). No associated known bugs but no need to init the queue twice. We should follow up by investigating if any pending bugs can be associated to this.	2023-12-14 16:16:12 +01:00
github-actions[bot]	1516c84dad	🚀 Release 1.21.0 (#8019 ) # [1.21.0](https://github.com/n8n-io/n8n/compare/n8n@1.20.0...n8n@1.21.0) (2023-12-13) ### Bug Fixes * core: Ensure inviter and invitee are set correctly in invite link ([#7943](https://github.com/n8n-io/n8n/issues/7943)) ([`386bd61`](`386bd61967`)) * core: Fix user comparison in same-user subworkflow caller policy ([#7913](https://github.com/n8n-io/n8n/issues/7913)) ([`92bab72`](`92bab72cff`)) * core: Perform multi-main leader check against key ID ([#7964](https://github.com/n8n-io/n8n/issues/7964)) ([`1a87f70`](`1a87f70e84`)) * core: Ensure external hooks post workflow execute run in queue mode ([#7947](https://github.com/n8n-io/n8n/issues/7947)) ([`3ba7deb`](`3ba7deb337`)) * core: Fix issue preventing secrets from loading if the path contains - or / ([#7988](https://github.com/n8n-io/n8n/issues/7988)) ([`0ac9594`](`0ac959463f`)) * core: Restrict updating/deleting of shared but not owned credentials ([#7950](https://github.com/n8n-io/n8n/issues/7950)) ([`42e828d`](`42e828d5c6`)) * core: Prevent workflow history saving error from happening ([#7812](https://github.com/n8n-io/n8n/issues/7812)) ([`e5581ce`](`e5581ce802`)) * editor: Add missing string for worker in log streaming ([#7971](https://github.com/n8n-io/n8n/issues/7971)) ([`148bc1d`](`148bc1d303`)) * editor: Allow SSH protocol in git repository URL for environments ([#7944](https://github.com/n8n-io/n8n/issues/7944)) ([`bc1c72f`](`bc1c72f992`)) * editor: Fix bug with node names with certain characters ([#8013](https://github.com/n8n-io/n8n/issues/8013)) ([`26f0d57`](`26f0d57f5f`)) * editor: Fix Webhook URL expansion icon ([#8011](https://github.com/n8n-io/n8n/issues/8011)) ([`b00b905`](`b00b9057a4`)) * editor: Prevent opening NDV search if `/` is typed in a contenteditable element ([#7968](https://github.com/n8n-io/n8n/issues/7968)) ([`e8a493f`](`e8a493f718`)) * editor: Return early in ws message handler if no 'command' keyword is found ([#7946](https://github.com/n8n-io/n8n/issues/7946)) ([`5b2defc`](`5b2defc867`)) * FileMaker Node: Prevent erroring on zero fields loaded ([#7955](https://github.com/n8n-io/n8n/issues/7955)) ([`10ad386`](`10ad386604`)) * Google Sheets Node: Prevent erroring on zero sheet search results ([#7957](https://github.com/n8n-io/n8n/issues/7957)) ([`9b877a9`](`9b877a9427`)) * Google Sheets Node: Prevent erroring when fetching mapping columns ([#7972](https://github.com/n8n-io/n8n/issues/7972)) ([`29a1066`](`29a10668d1`)) * Postgres Node: Do not include id column in upsert fields selection if it's not unique ([#7975](https://github.com/n8n-io/n8n/issues/7975)) ([`435392c`](`435392cbfe`)) * Postgres Trigger Node: Increase manual trigger timeout from 30 to 60 seconds ([#8015](https://github.com/n8n-io/n8n/issues/8015)) ([`09a5729`](`09a5729305`)) * Webhook Node: Binary data handling ([#7804](https://github.com/n8n-io/n8n/issues/7804)) ([`565b409`](`565b409a82`)) * Webhook Node: Do not create binary data when there is no data in the request ([#8000](https://github.com/n8n-io/n8n/issues/8000)) ([`70f0755`](`70f0755278`)) ### Features * core: Add config option for external secret update interval ([#7995](https://github.com/n8n-io/n8n/issues/7995)) ([`b6c1c04`](`b6c1c04b54`)) * AI nodes usability fixes + Summarization Chain V2 ([#7949](https://github.com/n8n-io/n8n/issues/7949)) ([`dcf1286`](`dcf12867b3`)) * editor: Data transformation nodes and actions in Nodes Panel ([#7760](https://github.com/n8n-io/n8n/issues/7760)) ([`675ec21`](`675ec21d33`)) * editor: Add AppCues tracking for onboarding event ([#7945](https://github.com/n8n-io/n8n/issues/7945)) ([`04cabaf`](`04cabafef7`)) * editor: Add option to disable NDV in workflow previews ([#7990](https://github.com/n8n-io/n8n/issues/7990)) ([`393afef`](`393afef174`)) * editor: Filter component + implement in If node ([#7490](https://github.com/n8n-io/n8n/issues/7490)) ([`8a53434`](`8a5343401d`)) * editor: Show template credential setup based on feature flag ([#7989](https://github.com/n8n-io/n8n/issues/7989)) ([`08ee307`](`08ee307209`)) * editor: Introduce advanced permissions ([#7844](https://github.com/n8n-io/n8n/issues/7844)) ([`dbd62a4`](`dbd62a4992`)) * Google Ads Node: Update to support v15 ([#7962](https://github.com/n8n-io/n8n/issues/7962)) ([`7f01269`](`7f0126915a`)) * Local File Trigger Node: Add polling option typically good to watch network files/folders ([#7942](https://github.com/n8n-io/n8n/issues/7942)) ([`2fbdfec`](`2fbdfec0c0`)) * n8n Form Trigger Node: Improvements ([#7571](https://github.com/n8n-io/n8n/issues/7571)) ([`953a58f`](`953a58f18b`)) Co-authored-by: ivov <ivov@users.noreply.github.com>	2023-12-13 16:34:00 +01:00
कारतोफ्फेलस्क्रिप्ट™	d7ce4624c8	Merge tag 'n8n@1.20.0'	2023-12-13 16:11:30 +01:00
Michael Kret	953a58f18b	feat(n8n Form Trigger Node): Improvements (#7571 ) Github issue / Community forum post (link here to close automatically): --------- Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in> Co-authored-by: Giulio Andreini <andreini@netseven.it>	2023-12-13 17:00:51 +02:00
Omar Ajoue	e5581ce802	fix(core): Prevent workflow history saving error from happening (#7812 ) When performing actions such as renaming a workflow or updating its settings, n8n errors with "Failed to save workflow version" in the console although the saving process was successful. We are now correctly checking whether `nodes` and `connections` exist and only then save a snapshot. Github issue / Community forum post (link here to close automatically):	2023-12-13 11:41:06 +00:00
Iván Ovejero	a70a5076ee	refactor(core): Add telemetry for RBAC roles (#7969 ) Add telemetry for RBAC roles, see [requirements](https://linear.app/n8n/issue/PAY-1067/add-telemetry-events-for-adding-and-assigning-admin-users#comment-184619fe).	2023-12-13 12:22:11 +01:00
Iván Ovejero	7b5d0a9546	refactor(core): Introduce import service (no-changelog) (#8001 ) Consolidate import logic into import service. Also fixes: - https://linear.app/n8n/issue/PAY-1086 - https://github.com/n8n-io/n8n/issues/7881 - https://community.n8n.io/t/cli-workflow-imports-failing-after-upgrade-to-v1-18-0/33780 - https://linear.app/n8n/issue/PAY-221 - https://github.com/n8n-io/n8n/issues/5477 - https://community.n8n.io/t/export-workflows-with-tags-got-created/6161	2023-12-13 10:00:21 +01:00
Benjamin Loison	61129863f1	docs: Replace `http://faircode.io` to `https://faircode.io` in `.md` files (#7908 ) ## Summary Commit generated with: ```bash grep -rl 'http://faircode.io' --include=.md . \| xargs sed -i 's/http:\/\/faircode.io/https:\/\/faircode.io/g' ``` ## Review / Merge checklist - [X] PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise.* ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md)) - [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created. - [ ] Tests included.	2023-12-12 15:23:22 +00:00
Jon	0ac959463f	fix: Fix issue preventing secrets from loading if the path contains - or / (#7988 ) ## Summary Fixes an issue preventing n8n from pulling secrets from Hashicorp Vault KV stores if the secret path contained a `-` or a `/`, An example provided was `integrations/n8n-workflows` which I have tested in my local instance of Vault. This still needs testing with Infisical to make sure nothing breaks there.	2023-12-12 15:21:18 +00:00
Jon	b6c1c04b54	feat: Add config option for external secret update interval (#7995 ) ## Summary Adds `N8N_EXTERNAL_SECRETS_UPDATE_INTERVAL` to allow enterprise users to tweak the update internal for importing new secrets. If using a config file the value is: ``` "externalSecrets": { "updateInterval": 300 } ``` #### How to test the change: 1. Run as normal and check that the secret is updated every 5 minutes 2. Set `N8N_EXTERNAL_SECRETS_UPDATE_INTERVAL` to 10 3. Check the secret is reloaded after 10 seconds ## Review / Merge checklist - [x] PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise. ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md)) - [x] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created.	2023-12-12 14:22:14 +00:00
Iván Ovejero	d0e44d450f	feat(core): Add multi-main setup debug endpoint (no-changelog) (#7991 ) ## Summary Provide details about your pull request and what it adds, fixes, or changes. Photos and videos are recommended. Adi's idea here to help diagnose: https://n8nio.slack.com/archives/C069KJBJ8HE/p1702300349277609?thread_ts=1702299930.728029&cid=C069KJBJ8HE ... #### How to test the change: 1. ... ## Issues fixed Include links to Github issue or Community forum post or Linear ticket: > Important in order to close automatically and provide context to reviewers ... ## Review / Merge checklist - [ ] PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise. ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md)) - [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created. - [ ] Tests included. > A bug is not considered fixed, unless a test is added to prevent it from happening again. A feature is not complete without tests. > > (internal) You can use Slack commands to trigger [e2e tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227) or [deploy test instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce) or [deploy early access version on Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).	2023-12-12 15:18:32 +01:00
कारतोफ्फेलस्क्रिप्ट™	1d870412ca	refactor(core): Don't use DB transactions on ExecutionRepository.createNewExecution (#8002 ) Saving execution data is one of the slowest DB operations in the application, and is likely behind some of the sqlite transaction concurrency issues we've been seeing. This not only remove the 2 separate transactions for saving `ExecutionEntity` and `ExecutionData`, but also remove fields from `ExecutionData.workflowData` that don't need to be saved (like `tags`, `shared`, `statistics`, `triggerCount`, etc).	2023-12-12 14:36:56 +01:00
Iván Ovejero	c378f60a25	refactor(core): Introduce password utility (no-changelog) (#7979 ) ## Summary Provide details about your pull request and what it adds, fixes, or changes. Photos and videos are recommended. Continue breaking down `UserManagementHelper.ts` ... #### How to test the change: 1. ... ## Issues fixed Include links to Github issue or Community forum post or Linear ticket: > Important in order to close automatically and provide context to reviewers ... ## Review / Merge checklist - [ ] PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise. ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md)) - [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created. - [ ] Tests included. > A bug is not considered fixed, unless a test is added to prevent it from happening again. A feature is not complete without tests. > > (internal) You can use Slack commands to trigger [e2e tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227) or [deploy test instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce) or [deploy early access version on Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).	2023-12-11 18:23:42 +01:00
Iván Ovejero	bbeeab5d27	refactor(core): Add project reference for `@n8n/permissions` (no-changelog) (#7987 ) ## Summary Provide details about your pull request and what it adds, fixes, or changes. Photos and videos are recommended. The missing [project ref](https://www.typescriptlang.org/docs/handbook/project-references.html) seems to be preventing the package from being picked up. <img width="1022" alt="Capture 2023-12-11 at 13 49 55@2x" src="https://github.com/n8n-io/n8n/assets/44588767/28b35430-d42f-451c-ae33-d152e1ff040a"> ... #### How to test the change: 1. ... ## Issues fixed Include links to Github issue or Community forum post or Linear ticket: > Important in order to close automatically and provide context to reviewers ... ## Review / Merge checklist - [ ] PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise. ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md)) - [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created. - [ ] Tests included. > A bug is not considered fixed, unless a test is added to prevent it from happening again. A feature is not complete without tests. > > (internal) You can use Slack commands to trigger [e2e tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227) or [deploy test instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce) or [deploy early access version on Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).	2023-12-11 14:37:21 +01:00
Iván Ovejero	f49aebb740	refactor(core): Move instance owner retrieval to ownership service (no-changelog) (#7980 ) ## Summary Provide details about your pull request and what it adds, fixes, or changes. Photos and videos are recommended. Continue breaking down `UserManagementHelper.ts` ... #### How to test the change: 1. ... ## Issues fixed Include links to Github issue or Community forum post or Linear ticket: > Important in order to close automatically and provide context to reviewers ... ## Review / Merge checklist - [ ] PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise. ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md)) - [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created. - [ ] Tests included. > A bug is not considered fixed, unless a test is added to prevent it from happening again. A feature is not complete without tests. > > (internal) You can use Slack commands to trigger [e2e tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227) or [deploy test instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce) or [deploy early access version on Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).	2023-12-11 13:35:09 +01:00
Iván Ovejero	69c2254742	refactor(core): Introduce naming service (no-changelog) (#7985 ) ## Summary Provide details about your pull request and what it adds, fixes, or changes. Photos and videos are recommended. Continue breaking down `GenericHelpers.ts` ... #### How to test the change: 1. ... ## Issues fixed Include links to Github issue or Community forum post or Linear ticket: > Important in order to close automatically and provide context to reviewers ... ## Review / Merge checklist - [ ] PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise. ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md)) - [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created. - [ ] Tests included. > A bug is not considered fixed, unless a test is added to prevent it from happening again. A feature is not complete without tests. > > (internal) You can use Slack commands to trigger [e2e tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227) or [deploy test instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce) or [deploy early access version on Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).	2023-12-11 12:35:14 +01:00
Iván Ovejero	012310b9c1	refactor(core): Upgrade backend Sentry dependencies to 7.86 (no-changelog) (#7982 ) ## Summary Provide details about your pull request and what it adds, fixes, or changes. Photos and videos are recommended. ... #### How to test the change: 1. ... ## Issues fixed Include links to Github issue or Community forum post or Linear ticket: > Important in order to close automatically and provide context to reviewers ... ## Review / Merge checklist - [ ] PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise. ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md)) - [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created. - [ ] Tests included. > A bug is not considered fixed, unless a test is added to prevent it from happening again. A feature is not complete without tests. > > (internal) You can use Slack commands to trigger [e2e tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227) or [deploy test instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce) or [deploy early access version on Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).	2023-12-11 11:08:54 +01:00
Iván Ovejero	193fe5ac1f	refactor(core): Log any hard-deletion errors during pruning (no-changelog) (#7965 ) ## Summary Pruning is a minor background task so hard-deletion errors during pruning should be simply logged for later investigation rather than rethrown. ... #### How to test the change: 1. ... ## Issues fixed Include links to Github issue or Community forum post or Linear ticket: > Important in order to close automatically and provide context to reviewers ... ## Review / Merge checklist - [ ] PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise. ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md)) - [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created. - [ ] Tests included. > A bug is not considered fixed, unless a test is added to prevent it from happening again. A feature is not complete without tests. > > (internal) You can use Slack commands to trigger [e2e tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227) or [deploy test instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce) or [deploy early access version on Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).	2023-12-11 11:08:14 +01:00
Iván Ovejero	76ab411bc0	refactor(core): Instrument multi-main to report failures to renew lease (#7970 ) ## Summary Instrument multi-main to report failures to renew the lease https://linear.app/n8n/issue/PAY-1105 ... #### How to test the change: 1. ... ## Issues fixed Include links to Github issue or Community forum post or Linear ticket: > Important in order to close automatically and provide context to reviewers ... ## Review / Merge checklist - [ ] PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise. ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md)) - [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created. - [ ] Tests included. > A bug is not considered fixed, unless a test is added to prevent it from happening again. A feature is not complete without tests. > > (internal) You can use Slack commands to trigger [e2e tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227) or [deploy test instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce) or [deploy early access version on Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).	2023-12-11 09:45:08 +01:00
Iván Ovejero	1a87f70e84	fix(core): Perform multi-main leader check against key ID (#7964 ) ## Summary Current leader check is based on key presence and multi-main instance type, which can give rise to [this edge case](https://n8nio.slack.com/archives/C04B1GZ4T0U/p1702025497086379?thread_ts=1701962808.817579&cid=C04B1GZ4T0U) where leader fails to realize they lost leadership to a former follower. PR performs the check against the specific key ID instead to prevent this. ... #### How to test the change: 1. ... ## Issues fixed Include links to Github issue or Community forum post or Linear ticket: > Important in order to close automatically and provide context to reviewers ... ## Review / Merge checklist - [ ] PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise. ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md)) - [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created. - [ ] Tests included. > A bug is not considered fixed, unless a test is added to prevent it from happening again. A feature is not complete without tests. > > (internal) You can use Slack commands to trigger [e2e tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227) or [deploy test instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce) or [deploy early access version on Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).	2023-12-08 13:55:55 +01:00
Csaba Tuncsik	dbd62a4992	feat: Introduce advanced permissions (#7844 ) This PR introduces the possibility of inviting new users with an `admin` role and changing the role of already invited users. Also using scoped permission checks where applicable instead of using user role checks. --------- Co-authored-by: Val <68596159+valya@users.noreply.github.com> Co-authored-by: Alex Grozav <alex@grozav.com> Co-authored-by: Iván Ovejero <ivov.src@gmail.com>	2023-12-08 12:52:25 +01:00
Iván Ovejero	8cb9c6b3ea	ci: Introduce `no-plain-errors` lint rule for BE packages (no-changelog) (#7961 ) ## Summary Require `ApplicationError` or its child classes instead of plain `Error` in BE packages. This ensures the error will be normalized when reported to Sentry, if applicable. Follow-up to: https://github.com/n8n-io/n8n/pulls?q=is%3Apr+is%3Aclosed+applicationerror ... #### How to test the change: 1. ... ## Issues fixed Include links to Github issue or Community forum post or Linear ticket: > Important in order to close automatically and provide context to reviewers ... ## Review / Merge checklist - [ ] PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise. ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md)) - [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created. - [ ] Tests included. > A bug is not considered fixed, unless a test is added to prevent it from happening again. A feature is not complete without tests. > > (internal) You can use Slack commands to trigger [e2e tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227) or [deploy test instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce) or [deploy early access version on Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).	2023-12-08 12:51:49 +01:00
Iván Ovejero	90824b50ed	feat(core): Add package name tag to Sentry errors (no-changelog) (#7958 ) ## Summary Add `packageName` tag to errors reported to Sentry, for filtering ... #### How to test the change: 1. ... ## Issues fixed Include links to Github issue or Community forum post or Linear ticket: > Important in order to close automatically and provide context to reviewers ... ## Review / Merge checklist - [ ] PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise. ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md)) - [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created. - [ ] Tests included. > A bug is not considered fixed, unless a test is added to prevent it from happening again. A feature is not complete without tests. > > (internal) You can use Slack commands to trigger [e2e tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227) or [deploy test instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce) or [deploy early access version on Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).	2023-12-08 11:30:06 +01:00
Iván Ovejero	3206b44974	test(core): Improve tests for subworkflow caller policy checks (no-changelog) (#7954 ) ## Summary Deduplicate, separate, organize and speed up tests for subworkflow caller policy checks. Follow-up to: https://github.com/n8n-io/n8n/pull/7913 ``` PASS test/unit/PermissionChecker.test.ts check() ✓ should allow if workflow has no creds (3 ms) ✓ should allow if requesting user is instance owner (83 ms) ✓ should allow if workflow creds are valid subset (151 ms) ✓ should deny if workflow creds are not valid subset (85 ms) checkSubworkflowExecutePolicy() no caller policy ✓ should fall back to N8N_WORKFLOW_CALLER_POLICY_DEFAULT_OPTION (1 ms) overridden caller policy ✓ if no sharing, policy becomes workflows-from-same-owner (1 ms) workflows-from-list caller policy ✓ should allow if caller list contains parent workflow ID ✓ should deny if caller list does not contain parent workflow ID (1 ms) any caller policy ✓ should not throw workflows-from-same-owner caller policy ✓ should deny if the two workflows are owned by different users (1 ms) ✓ should allow if both workflows are owned by the same user ``` ... #### How to test the change: 1. ... ## Issues fixed Include links to Github issue or Community forum post or Linear ticket: > Important in order to close automatically and provide context to reviewers ... ## Review / Merge checklist - [ ] PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise. ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md)) - [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created. - [ ] Tests included. > A bug is not considered fixed, unless a test is added to prevent it from happening again. A feature is not complete without tests. > > (internal) You can use Slack commands to trigger [e2e tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227) or [deploy test instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce) or [deploy early access version on Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).	2023-12-08 11:21:43 +01:00
Iván Ovejero	c48850d74f	fix(core): Fix expression evaluator filename typo (no-changelog) (#7960 ) ## Summary Provide details about your pull request and what it adds, fixes, or changes. Photos and videos are recommended. ... #### How to test the change: 1. ... ## Issues fixed Include links to Github issue or Community forum post or Linear ticket: > Important in order to close automatically and provide context to reviewers ... ## Review / Merge checklist - [ ] PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise. ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md)) - [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created. - [ ] Tests included. > A bug is not considered fixed, unless a test is added to prevent it from happening again. A feature is not complete without tests. > > (internal) You can use Slack commands to trigger [e2e tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227) or [deploy test instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce) or [deploy early access version on Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).	2023-12-07 17:50:49 +01:00
Iván Ovejero	18bb87ac0c	test(core): Isolate restore binary data ID in execution lifecycle hooks (no-changelog) (#7953 ) ## Summary Move guard into restore function, move tests into own suite, add tests for guard. ... #### How to test the change: 1. ... ## Issues fixed Include links to Github issue or Community forum post or Linear ticket: > Important in order to close automatically and provide context to reviewers ... ## Review / Merge checklist - [ ] PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise. ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md)) - [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created. - [ ] Tests included. > A bug is not considered fixed, unless a test is added to prevent it from happening again. A feature is not complete without tests. > > (internal) You can use Slack commands to trigger [e2e tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227) or [deploy test instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce) or [deploy early access version on Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).	2023-12-07 17:30:47 +01:00
Iván Ovejero	1d46983b24	refactor: Unify `severity` and `level` for all application errors for Sentry (no-changelog) (#7956 ) ## Summary Unify `severity` and `level` for all backend application errors for Sentry Follow-up to: https://github.com/n8n-io/n8n/pull/7914#issuecomment-1840433542 ... #### How to test the change: 1. ... ## Issues fixed Include links to Github issue or Community forum post or Linear ticket: > Important in order to close automatically and provide context to reviewers ... ## Review / Merge checklist - [ ] PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise. ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md)) - [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created. - [ ] Tests included. > A bug is not considered fixed, unless a test is added to prevent it from happening again. A feature is not complete without tests. > > (internal) You can use Slack commands to trigger [e2e tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227) or [deploy test instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce) or [deploy early access version on Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).	2023-12-07 16:57:02 +01:00
Val	42e828d5c6	fix: Restrict updating/deleting of shared but not owned credentials (#7950 ) ## Summary Fix shared members being able to edit and delete credentials they don't own #### How to test the change: 1. ... ## Issues fixed Include links to Github issue or Community forum post or Linear ticket: > Important in order to close automatically and provide context to reviewers ... ## Review / Merge checklist - [x] PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise. ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md)) - [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created. - [x] Tests included. > A bug is not considered fixed, unless a test is added to prevent it from happening again. A feature is not complete without tests. > > (internal) You can use Slack commands to trigger [e2e tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227) or [deploy test instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce) or [deploy early access version on Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).	2023-12-07 10:35:40 +00:00
Omar Ajoue	3ba7deb337	fix: Ensure external hooks post workflow execute run in queue mode (#7947 ) ## Summary Since 1.8.x a refactor removed the call to `workflow.postExecute`'s External hook from the execution path. This PR adds it back to the correct place, where workers are supposed to call this, allowing us to avoid having to re-read the execution data in the caller just for the hooks. It is important to have the hooks running in the worker whenever possible to prevent having to read the full execution data in the caller. #### How to test the change: 1. Use the attached hooks file [external-hooks.txt](https://github.com/n8n-io/n8n/files/13597270/external-hooks.txt) setting it up via environment variable using `export EXTERNAL_HOOK_FILES=/path/to/hooks/external-hooks.js` 2. Set up queue mode loading this file in both main and workers 3. See that the message logs will not be displayed without this fix ## Issues fixed Include links to Github issue or Community forum post or Linear ticket: ## Review / Merge checklist - [ ] PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise. ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md)) - [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created. - [ ] Tests included. > A bug is not considered fixed, unless a test is added to prevent it from happening again. A feature is not complete without tests. > > (internal) You can use Slack commands to trigger [e2e tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227) or [deploy test instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce) or [deploy early access version on Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).	2023-12-07 10:00:05 +00:00
Iván Ovejero	386bd61967	fix(core): Ensure inviter and invitee are set correctly in invite link (#7943 ) ## Summary Ensure inviter and invitee are set correctly in invite link ... #### How to test the change: 1. ... ## Issues fixed Include links to Github issue or Community forum post or Linear ticket: > Important in order to close automatically and provide context to reviewers https://linear.app/n8n/issue/ADO-1494 ## Review / Merge checklist - [ ] PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise. ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md)) - [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created. - [ ] Tests included. > A bug is not considered fixed, unless a test is added to prevent it from happening again. A feature is not complete without tests. > > (internal) You can use Slack commands to trigger [e2e tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227) or [deploy test instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce) or [deploy early access version on Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).	2023-12-07 10:53:31 +01:00
Iván Ovejero	3a035cba8b	test(core): Expand user service tests (no-changelog) (#7941 ) ## Summary Expand user service tests ... #### How to test the change: 1. ... ## Issues fixed Include links to Github issue or Community forum post or Linear ticket: > Important in order to close automatically and provide context to reviewers ... ## Review / Merge checklist - [ ] PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise. ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md)) - [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created. - [ ] Tests included. > A bug is not considered fixed, unless a test is added to prevent it from happening again. A feature is not complete without tests. > > (internal) You can use Slack commands to trigger [e2e tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227) or [deploy test instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce) or [deploy early access version on Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).	2023-12-07 09:19:16 +01:00
Michael Kret	565b409a82	fix(Webhook Node): Binary data handling (#7804 ) Github issue / Community forum post (link here to close automatically):	2023-12-06 17:46:40 +02:00
Csaba Tuncsik	c461025f70	test: Add user type of admin to E2E tests (#7935 ) ## Summary Extend existing user types in the E2E database. Currently, we have only owner and member but we need also admin --------- Co-authored-by: Val <68596159+valya@users.noreply.github.com>	2023-12-06 14:31:06 +01:00
Iván Ovejero	92bab72cff	fix(core): Fix user comparison in same-user subworkflow caller policy (#7913 ) https://linear.app/n8n/issue/PAY-992 https://community.n8n.io/t/executing-workflow-using-owner-role-created-by-another-user-fails/33443 --------- Co-authored-by: Omar Ajoue <krynble@gmail.com>	2023-12-06 12:27:11 +00:00
github-actions[bot]	823b589e09	🚀 Release 1.20.0 (#7940 ) # [1.20.0](https://github.com/n8n-io/n8n/compare/n8n@1.19.0...n8n@1.20.0) (2023-12-06) ### Bug Fixes * AWS DynamoDB Node: Improve error message parsing ([#7793](https://github.com/n8n-io/n8n/issues/7793)) ([`5ba5ed8`](`5ba5ed8e3c`)) * core: Allow grace period for binary data deletion after manual execution ([#7889](https://github.com/n8n-io/n8n/issues/7889)) ([`61d8aeb`](`61d8aebeaf`)) * core: Consolidate ownership and sharing data on workflows and credentials ([#7920](https://github.com/n8n-io/n8n/issues/7920)) ([`38b88b9`](`38b88b946b`)) * core: Fix hard deletes stopping if database query throws ([#7848](https://github.com/n8n-io/n8n/issues/7848)) ([`46dd4d3`](`46dd4d3105`)) * core: Make sure mfa secret and recovery codes are not returned on login ([#7936](https://github.com/n8n-io/n8n/issues/7936)) ([`f5502cc`](`f5502cc628`)) * editor: Fix deletion of last execution at execution preview ([#7883](https://github.com/n8n-io/n8n/issues/7883)) ([`ce2d388`](`ce2d388f05`)) * editor: Replace isInstanceOwner checks with scopes where applicable ([#7858](https://github.com/n8n-io/n8n/issues/7858)) ([`132d691`](`132d691cbf`)) * Google Sheets Node: Fix issue with paired items not being set correctly ([#7862](https://github.com/n8n-io/n8n/issues/7862)) ([`5207a2f`](`5207a2fe52`)) * Notion Node: Fix broken Notion node parameters ([#7864](https://github.com/n8n-io/n8n/issues/7864)) ([`51d1f5b`](`51d1f5b820`)), closes [#7791](https://github.com/n8n-io/n8n/issues/7791) ### Features * BambooHR Node: Add support for Only Current on company reports ([#7878](https://github.com/n8n-io/n8n/issues/7878)) ([`4175801`](`4175801c90`)) * core: Allow admin creation ([#7837](https://github.com/n8n-io/n8n/issues/7837)) ([`476806e`](`476806ebb0`)) * editor: Add sections to create node panel ([#7831](https://github.com/n8n-io/n8n/issues/7831)) ([`39fa8d2`](`39fa8d21bb`)) * editor: Open template credential setup from collection ([#7882](https://github.com/n8n-io/n8n/issues/7882)) ([`627ddb9`](`627ddb91fb`)) * editor: Select credentials in template setup if theres only one ([#7879](https://github.com/n8n-io/n8n/issues/7879)) ([`fe3417a`](`fe3417a615`)) ### Performance Improvements * editor: Improve node rendering performance when opening large workflows ([#7904](https://github.com/n8n-io/n8n/issues/7904)) ([`a8049a0`](`a8049a0def`)) * editor: Improve performance when opening large workflows with node issues ([#7901](https://github.com/n8n-io/n8n/issues/7901)) ([`4bd7ae2`](`4bd7ae29f7`)) Co-authored-by: ivov <ivov@users.noreply.github.com>	2023-12-06 12:26:24 +01:00
Ricardo Espinoza	f5502cc628	fix(core): Make sure mfa secret and recovery codes are not returned on login (#7936 ) ## Summary What: Fix issue of login endpoint returning secret and recovery codes when MFA is enabled. Bug was introduced in this [PR](https://github.com/n8n-io/n8n/pull/6994), specifically in this [line](https://github.com/n8n-io/n8n/pull/6994/files#diff-95a87cb029a3d26e6722df2e68132453fc254fc1f4540cbdaa95cfdbda1893deL91). Why: We should not be filtering the secret and recovery codes Same PR caused the issues on ticket -> https://linear.app/n8n/issue/ADO-1494/on-user-list-copy-password-reset-link-and-copy-invite-link-are-broken ## Review / Merge checklist - [x] PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise. ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md)) - [x] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created. - [x] Tests included. > A bug is not considered fixed, unless a test is added to prevent it from happening again. A feature is not complete without tests. > > (internal) You can use Slack commands to trigger [e2e tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227) or [deploy test instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce) or [deploy early access version on Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).	2023-12-06 10:00:13 +01:00
Andrey Starostin	46dd4d3105	fix(core): Fix hard deletes stopping if database query throws (#7848 ) I have observed that the next hard deletion timeout is not scheduled if the `hardDeleteOnPruningCycle` function throws when fetching the data from the database. That is because the thrown error is not caught and the `scheduleHardDeletion` method is not called. This PR moves the call to `scheduleHardDeletion` into the `scheduleHardDeletion` for better cohesion, and ensures that it is called even if `hardDeleteOnPruningCycle` throws.	2023-12-05 16:30:32 +01:00
Val	4e55583715	feat: Add admin role to public API (no-changelog) (#7933 ) ## Summary Add the admin global role to the public API. This does not include porting over scopes. #### How to test the change: 1. ... ## Issues fixed Include links to Github issue or Community forum post or Linear ticket: > Important in order to close automatically and provide context to reviewers ... ## Review / Merge checklist - [ ] PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise. ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md)) - [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created. - [ ] Tests included. > A bug is not considered fixed, unless a test is added to prevent it from happening again. A feature is not complete without tests. > > (internal) You can use Slack commands to trigger [e2e tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227) or [deploy test instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce) or [deploy early access version on Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).	2023-12-05 15:00:14 +00:00
Val	9604b87da9	fix: Return scopes on invitation accept endpoint (no-changelog) (#7917 ) ## Summary Return scopes on the invitation accept endpoint. The UI uses information until the user refreshes the pages so it's causing inconsistency for the new admin role. #### How to test the change: 1. ... ## Issues fixed Include links to Github issue or Community forum post or Linear ticket: > Important in order to close automatically and provide context to reviewers ... ## Review / Merge checklist - [x] PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise. ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md)) - [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created. - [ ] Tests included. > A bug is not considered fixed, unless a test is added to prevent it from happening again. A feature is not complete without tests. > > (internal) You can use Slack commands to trigger [e2e tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227) or [deploy test instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce) or [deploy early access version on Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).	2023-12-05 11:18:41 +01:00
Iván Ovejero	38b88b946b	fix(core): Consolidate ownership and sharing data on workflows and credentials (#7920 ) ## Summary Ensure `ownedBy` and `sharedWith` are present and uniform for credentials and workflows. Details in story: https://linear.app/n8n/issue/PAY-987	2023-12-05 10:11:18 +01:00
Iván Ovejero	29e7a98f3e	test(core): Use license mocker in RBAC tests (no-changelog) (#7912 ) ## Summary Provide details about your pull request and what it adds, fixes, or changes. Photos and videos are recommended. ... #### How to test the change: 1. ... ## Issues fixed Include links to Github issue or Community forum post or Linear ticket: > Important in order to close automatically and provide context to reviewers ... ## Review / Merge checklist - [ ] PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise. ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md)) - [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created. - [ ] Tests included. > A bug is not considered fixed, unless a test is added to prevent it from happening again. A feature is not complete without tests. > > (internal) You can use Slack commands to trigger [e2e tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227) or [deploy test instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce) or [deploy early access version on Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).	2023-12-04 13:56:48 +01:00
Iván Ovejero	50a7401de9	docs: Update breaking changes with binary data TTL note (#7894 ) Context: https://n8nio.slack.com/archives/C035KBDA917/p1701418556761549?thread_ts=1701411854.517989&cid=C035KBDA917	2023-12-01 12:52:12 +01:00
Iván Ovejero	07f6662aba	refactor(core): Add log about removed TTL keys for binary data (#7892 ) Context: https://n8nio.slack.com/archives/C035KBDA917/p1701418556761549?thread_ts=1701411854.517989&cid=C035KBDA917	2023-12-01 12:51:45 +01:00
Iván Ovejero	61d8aebeaf	fix(core): Allow grace period for binary data deletion after manual execution (#7889 ) https://linear.app/n8n/issue/PAY-1079	2023-12-01 10:13:53 +01:00
Val	5f4a9524ec	refactor(core): Add central license mock for integration tests (no-changelog) (#7871 ) Github issue / Community forum post (link here to close automatically):	2023-11-30 09:23:09 +01:00
Val	cd474f1562	feat: Allow owner to share workflows/credentials they don't own (no-changelog) (#7869 ) Github issue / Community forum post (link here to close automatically):	2023-11-29 16:32:27 +00:00
Omar Ajoue	74b4513298	feat(core): Add Advanced Permissions to FE settings (no-changelog) (#7867 ) Github issue / Community forum post (link here to close automatically):	2023-11-29 15:56:35 +01:00
Val	1cb92ffe16	feat: Replace owner checks with scope checks (no-changelog) (#7846 ) Github issue / Community forum post (link here to close automatically):	2023-11-29 14:48:36 +00:00
कारतोफ्फेलस्क्रिप्ट™	6d9342e676	Merge tag 'n8n@1.19.0'	2023-11-29 14:12:24 +01:00
Iván Ovejero	476806ebb0	feat(core): Allow admin creation (#7837 ) https://linear.app/n8n/issue/PAY-1038	2023-11-29 13:55:41 +01:00
github-actions[bot]	303cf31331	🚀 Release 1.19.0 (#7863 ) # [1.19.0](https://github.com/n8n-io/n8n/compare/n8n@1.18.0...n8n@1.19.0) (2023-11-29) ### Bug Fixes * core: Ensure member and admin cannot be promoted to owner ([#7830](https://github.com/n8n-io/n8n/issues/7830)) ([`9b87a59`](`9b87a596ca`)), closes [/linear.app/n8n/issue/PAY-985/add-user-role-modification-endpoint#comment-62355f6](https://github.com//linear.app/n8n/issue/PAY-985/add-user-role-modification-endpoint/issues/comment-62355f6) * core: Prevent error messages due to statistics about data loading ([#7824](https://github.com/n8n-io/n8n/issues/7824)) ([`847f6ac`](`847f6ac771`)) * core: Tighten checks for multi-main setup usage ([#7788](https://github.com/n8n-io/n8n/issues/7788)) ([`fdb2c18`](`fdb2c18ecc`)) * core: Use AbortController to notify nodes to abort execution ([#6141](https://github.com/n8n-io/n8n/issues/6141)) ([`d2c18c5`](`d2c18c5727`)) * editor: Add telemetry to workflow history ([#7811](https://github.com/n8n-io/n8n/issues/7811)) ([`d497041`](`d4970410e1`)) * editor: Allow owners and admins to share workflows and credentials they don't own ([#7833](https://github.com/n8n-io/n8n/issues/7833)) ([`3ab3ec9`](`3ab3ec9da8`)) * editor: Disable context menu actions in read-only mode ([#7789](https://github.com/n8n-io/n8n/issues/7789)) ([`902beff`](`902beffce5`)) * editor: Fix cloud plan data loading on instance ([#7841](https://github.com/n8n-io/n8n/issues/7841)) ([`8b99384`](`8b99384367`)) * editor: Fix credential icon for old node type version ([#7843](https://github.com/n8n-io/n8n/issues/7843)) ([`4074107`](`4074107511`)) * editor: Fix icon for unknown node type ([#7842](https://github.com/n8n-io/n8n/issues/7842)) ([`28ac5a7`](`28ac5a750e`)) * editor: Fix mouse position in workflow previews ([#7853](https://github.com/n8n-io/n8n/issues/7853)) ([`c063398`](`c0633987bf`)) * editor: Show nice error when environment is not set up ([#7778](https://github.com/n8n-io/n8n/issues/7778)) ([`5835e05`](`5835e055d3`)) * editor: Suppress dev server websocket messages in workflow view ([#7808](https://github.com/n8n-io/n8n/issues/7808)) ([`685ffd7`](`685ffd7413`)) * Google Sheets Node: Read operation execute for each item ([#7800](https://github.com/n8n-io/n8n/issues/7800)) ([`d548872`](`d5488725a8`)) * HTTP Request Node: Enable expressions for binary input data fields ([#7782](https://github.com/n8n-io/n8n/issues/7782)) ([`6208af0`](`6208af07eb`)) * Microsoft SQL Node: Prevent double escaping table name ([#7801](https://github.com/n8n-io/n8n/issues/7801)) ([`73ec753`](`73ec7533ce`)) ### Features * Add AI tool building capabilities ([#7336](https://github.com/n8n-io/n8n/issues/7336)) ([`87def60`](`87def60979`)) * Add initial scope checks via decorators ([#7737](https://github.com/n8n-io/n8n/issues/7737)) ([`a37f1cb`](`a37f1cb0ba`)) * Ado 1296 spike credential setup in templates ([#7786](https://github.com/n8n-io/n8n/issues/7786)) ([`aae45b0`](`aae45b043b`)) * core: Add Support for custom CORS origins for webhooks ([#7455](https://github.com/n8n-io/n8n/issues/7455)) ([`99a9ea4`](`99a9ea497a`)) * core: Allow user role modification ([#7797](https://github.com/n8n-io/n8n/issues/7797)) ([`7a86d36`](`7a86d36068`)) * core: Set up endpoint for all existing roles with license flag ([#7834](https://github.com/n8n-io/n8n/issues/7834)) ([`2356fb0`](`2356fb0f0c`)) * editor: Add node name and version to NDV node settings ([#7731](https://github.com/n8n-io/n8n/issues/7731)) ([`da85198`](`da851986f6`)) * editor: Add routing middleware, permission checks, RBAC store, RBAC component ([#7702](https://github.com/n8n-io/n8n/issues/7702)) ([`67a8891`](`67a88914f2`)) * editor: Replace middleware for Role checks with Scope checks ([#7847](https://github.com/n8n-io/n8n/issues/7847)) ([`72852a6`](`72852a60eb`)) * editor: Show avatars for users currently working on the same workflow ([#7763](https://github.com/n8n-io/n8n/issues/7763)) ([`77bc8ec`](`77bc8ecd4b`)) * Notion Node: Option to simplify output in getChildBlocks operation ([#7791](https://github.com/n8n-io/n8n/issues/7791)) ([`d667bca`](`d667bca658`)) * Slack Node: Add support for getting the profile of a user ([#7829](https://github.com/n8n-io/n8n/issues/7829)) ([`90bb6ba`](`90bb6ba417`)) Co-authored-by: ivov <ivov@users.noreply.github.com>	2023-11-29 13:17:03 +01:00
Val	e282ea242d	fix: Return scopes on owner setup endpoint (no-changelog) (#7860 ) Github issue / Community forum post (link here to close automatically):	2023-11-29 11:33:32 +00:00
Iván Ovejero	c08c5cc37b	refactor(core): Switch plain errors in `cli` to `ApplicationError` (#7857 ) Ensure all errors in `cli` are `ApplicationError` or children of it and contain no variables in the message, to continue normalizing all the errors we report to Sentry Follow-up to: https://github.com/n8n-io/n8n/pull/7839	2023-11-29 12:25:10 +01:00
Jan Oberhauser	87def60979	feat: Add AI tool building capabilities (#7336 ) Github issue / Community forum post (link here to close automatically): https://community.n8n.io/t/langchain-memory-chat/23733 --------- Signed-off-by: Oleg Ivaniv <me@olegivaniv.com> Co-authored-by: Oleg Ivaniv <me@olegivaniv.com> Co-authored-by: Val <68596159+valya@users.noreply.github.com> Co-authored-by: Alex Grozav <alex@grozav.com> Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in> Co-authored-by: Deborah <deborah@starfallprojects.co.uk> Co-authored-by: Jesper Bylund <mail@jesperbylund.com> Co-authored-by: Jon <jonathan.bennetts@gmail.com> Co-authored-by: Michael Kret <88898367+michael-radency@users.noreply.github.com> Co-authored-by: Giulio Andreini <andreini@netseven.it> Co-authored-by: Mason Geloso <Mason.geloso@gmail.com> Co-authored-by: Mason Geloso <hone@Masons-Mac-mini.local> Co-authored-by: Mutasem Aldmour <mutasem@n8n.io>	2023-11-29 12:13:55 +01:00
Alex Grozav	72852a60eb	feat(editor): Replace middleware for Role checks with Scope checks (#7847 )	2023-11-29 10:35:40 +02:00
कारतोफ्फेलस्क्रिप्ट™	117962d473	feat(core): Update LLM applications building support (no-changelog) (#7710 ) extracted out of #7336 --------- Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com> Co-authored-by: Oleg Ivaniv <me@olegivaniv.com> Co-authored-by: Alex Grozav <alex@grozav.com>	2023-11-28 16:47:28 +01:00
Iván Ovejero	2356fb0f0c	feat(core): Set up endpoint for all existing roles with license flag (#7834 ) https://linear.app/n8n/issue/PAY-1034/create-endpoint-to-list-all-existing-roles	2023-11-28 14:16:47 +01:00
Val	a37f1cb0ba	feat: Add initial scope checks via decorators (#7737 )	2023-11-28 11:41:34 +00:00
Csaba Tuncsik	3ab3ec9da8	fix(editor): Allow owners and admins to share workflows and credentials they don't own (#7833 )	2023-11-28 11:44:55 +01:00
Iván Ovejero	1c6178759c	refactor(core): Reorganize error hierarchy in `cli` package (no-changelog) (#7839 ) Ensure all errors in `cli` inherit from `ApplicationError` to continue normalizing all the errors we report to Sentry Follow-up to: https://github.com/n8n-io/n8n/pull/7820	2023-11-28 10:19:27 +01:00
Iván Ovejero	9b87a596ca	fix(core): Ensure member and admin cannot be promoted to owner (#7830 ) https://linear.app/n8n/issue/PAY-985/add-user-role-modification-endpoint#comment-62355f6b	2023-11-27 17:35:58 +01:00
Omar Ajoue	847f6ac771	fix(core): Prevent error messages due to statistics about data loading (#7824 ) Statistics collection about the first time a workflow loads data simply attempts an insert to db, and if it fails, we just ignore. This was causing this query to fire against production workflows multiple times, and since we want to insert only and detect whether the insertion failed, performing a select first provides gains both in terms of performance, as it's usually faster than trying an insertion as well as preventing unnecessary noise in logs. Github issue / Community forum post (link here to close automatically): https://community.n8n.io/t/duplicate-key-value-violates-unique-constraint-workflow-statistics-pkey-still-happening/29283 https://github.com/n8n-io/n8n/issues/7256 https://community.n8n.io/t/error-log-arriving-in-postgres/30191 https://github.com/n8n-io/n8n/issues/7256 https://community.n8n.io/t/cant-launch-webhooks-unable-to-find-data-of-execution/31867 --------- Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>	2023-11-27 15:43:48 +01:00
Iván Ovejero	dff8456382	refactor(core): Reorganize error hierarchy in `core` and `workflow` packages (no-changelog) (#7820 ) Ensure all errors in `core` and `workflow` inherit from `ApplicationError` so that we start normalizing all the errors we report to Sentry Follow-up to: https://github.com/n8n-io/n8n/pull/7757#discussion_r1404338844 ### `core` package `ApplicationError` - `FileSystemError` (abstract) - `FileNotFoundError` - `DisallowedFilepathError` - `BinaryDataError` (abstract) - `InvalidModeError` - `InvalidManagerError` - `InvalidExecutionMetadataError` ### `workflow` package `ApplicationError` - `ExecutionBaseError` (abstract) - `WorkflowActivationError` - `WorkflowDeactivationError` - `WebhookTakenError` - `WorkflowOperationError` - `SubworkflowOperationError` - `CliWorkflowOperationError` - `ExpressionError` - `ExpressionExtensionError` - `NodeError` (abstract) - `NodeOperationError` - `NodeApiError` - `NodeSSLError` Up next: - Reorganize errors in `cli` - Flatten the hierarchy in `workflow` (do we really need `ExecutionBaseError`?) - Remove `ExecutionError` type - Stop throwing plain `Error`s - Replace `severity` with `level` - Add node and credential types as `tags` - Add workflow IDs and execution IDs as `extras`	2023-11-27 15:33:21 +01:00
Val	27e048c201	feat: Add Licensed decorator (no-changelog) (#7828 ) Github issue / Community forum post (link here to close automatically):	2023-11-27 13:46:18 +00:00
Val	5acb7b94c0	refactor: Refactor variables controller into a RestController (no-changelog) (#7822 ) Github issue / Community forum post (link here to close automatically):	2023-11-27 12:17:09 +00:00
Iván Ovejero	7b8532d3a3	refactor(core): Move execution progress saving to standalone utility (no-changelog) (#7770 ) This PR continues the effort of moving logic inside execution lifecycle hooks into standalone testable functions, as a stepping stone to refactoring the hooks themselves.	2023-11-27 13:10:43 +01:00
Iván Ovejero	75a5807c72	perf(core): Make user controller tests faster (no-changelog) (#7819 ) Before: `17.949 s` After: `3.886 s` Followup to: https://github.com/n8n-io/n8n/pull/7797#discussion_r1404148034	2023-11-27 11:56:06 +01:00
कारतोफ्फेलस्क्रिप्ट™	1b60cfb8f1	ci: Fix new user patching endpoint tests (no-changelog) (#7816 ) user ids are uuids, and in the future we should add proper input validation to prevent invalid user ids reaching the DB like this.	2023-11-27 09:35:09 +01:00
Csaba Tuncsik	152883eed1	build: Upgrade lint related packages (#7790 )	2023-11-27 09:11:52 +01:00
Iván Ovejero	eec2ec1ff8	refactor(core): Consolidate path-related errors in Sentry (no-changelog) (#7757 ) Keep reporting [path-related errors](https://n8nio.sentry.io/issues/4649493725) in Sentry but consolidate them in a single error group. Also, add `options.extra` as `meta` so they remain visible in debug logs: ``` 2023-11-24T11:50:54.852Z \| error \| ReportableError: Something went wrong "{ test: 123, file: 'LoggerProxy.js', function: 'exports.error' }" ``` --------- Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>	2023-11-24 14:42:46 +01:00
Iván Ovejero	7a86d36068	feat(core): Allow user role modification (#7797 ) https://linear.app/n8n/issue/PAY-985 ``` PATCH /users/:id/role unauthenticated user ✓ should receive 401 (349 ms) member ✓ should fail to demote owner to member (349 ms) ✓ should fail to demote owner to admin (359 ms) ✓ should fail to demote admin to member (381 ms) ✓ should fail to promote other member to owner (353 ms) ✓ should fail to promote other member to admin (377 ms) ✓ should fail to promote self to admin (354 ms) ✓ should fail to promote self to owner (371 ms) admin ✓ should receive 400 on invalid payload (351 ms) ✓ should receive 404 on unknown target user (351 ms) ✓ should fail to demote owner to admin (349 ms) ✓ should fail to demote owner to member (347 ms) ✓ should fail to promote member to owner (384 ms) ✓ should fail to promote admin to owner (350 ms) ✓ should be able to demote admin to member (354 ms) ✓ should be able to demote self to member (350 ms) ✓ should be able to promote member to admin (349 ms) owner ✓ should be able to promote member to admin (349 ms) ✓ should be able to demote admin to member (349 ms) ✓ should fail to demote self to admin (348 ms) ✓ should fail to demote self to member (354 ms) ```	2023-11-24 11:40:08 +01:00
Val	865192adf0	feat: Add global admin role (no-changelog) (#7781 ) Github issue / Community forum post (link here to close automatically):	2023-11-23 13:38:11 +00:00
Michael Auerswald	5835e055d3	fix(editor): Show nice error when environment is not set up (#7778 ) Adds a nicer error message with a link for owners who press Push to Git without having a repository connected yet.	2023-11-23 13:50:03 +01:00
Iván Ovejero	fdb2c18ecc	fix(core): Tighten checks for multi-main setup usage (#7788 ) https://n8nio.slack.com/archives/C05HRPLSGTT/p1700731476321999?thread_ts=1700729359.746899&cid=C05HRPLSGTT	2023-11-23 12:18:39 +01:00
Csaba Tuncsik	e128b23a2b	build: Upgrade to Vite 5 (#7784 )	2023-11-23 11:55:02 +01:00
Milorad FIlipović	77bc8ecd4b	feat(editor): Show avatars for users currently working on the same workflow (#7763 ) This PR introduces the following changes: - New Vue stores: `collaborationStore` and `pushConnectionStore` - Front-end push connection handling overhaul: Keep only a singe connection open and handle it from the new store - Add user avatars in the editor header when there are multiple users working on the same workflow - Sending a heartbeat event to back-end service periodically to confirm user is still active - Back-end overhauls (authored by @tomi): - Implementing a cleanup procedure that removes inactive users - Refactoring collaboration service current implementation --------- Co-authored-by: Tomi Turtiainen <10324676+tomi@users.noreply.github.com>	2023-11-23 10:14:34 +01:00
Michael Kret	99a9ea497a	feat(core): Add Support for custom CORS origins for webhooks (#7455 ) node-850 https://community.n8n.io/t/add-ability-to-set-cors-allow-list-in-n8n-webhooks/7610 https://community.n8n.io/t/configure-cors-pre-flight-request-option-method-in-the-roadmap/32189 --------- Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>	2023-11-22 17:49:56 +01:00
github-actions[bot]	e01617ad64	🚀 Release 1.18.0 (#7780 ) # [1.18.0](https://github.com/n8n-io/n8n/compare/n8n@1.17.0...n8n@1.18.0) (2023-11-22) ### Bug Fixes * core: Account for non-ASCII chars in filename on binary data download ([#7742](https://github.com/n8n-io/n8n/issues/7742)) ([`b4ebb1a`](`b4ebb1a28d`)) * core: Correct permissions for getstatus ([#7724](https://github.com/n8n-io/n8n/issues/7724)) ([`f96c1d2`](`f96c1d2044`)) * core: Ensure failed executions are saved in queue mode ([#7744](https://github.com/n8n-io/n8n/issues/7744)) ([`b7c5c74`](`b7c5c7406f`)) * core: Guard against node not found on cancelling test webhook ([#7750](https://github.com/n8n-io/n8n/issues/7750)) ([`6be453b`](`6be453b716`)) * editor: Handle permission edge cases (empty scopes) ([#7723](https://github.com/n8n-io/n8n/issues/7723)) ([`e2ffd39`](`e2ffd397fc`)) * editor: Make sure LineController is registered with chart.js ([#7730](https://github.com/n8n-io/n8n/issues/7730)) ([`ebee1a5`](`ebee1a5908`)) * editor: Move workerview entry into settings menu ([#7761](https://github.com/n8n-io/n8n/issues/7761)) ([`366cd67`](`366cd672a7`)) * editor: Only show push to git menu item to owners ([#7766](https://github.com/n8n-io/n8n/issues/7766)) ([`0d3d33d`](`0d3d33dd1f`)) * editor: Show v1 banner dismiss button if owner ([#7722](https://github.com/n8n-io/n8n/issues/7722)) ([`44d3b3e`](`44d3b3ed7e`)) * editor: Use project diagram icon for worker view ([#7764](https://github.com/n8n-io/n8n/issues/7764)) ([`ff0b651`](`ff0b6511f7`)) * editor: Validate user info before submiting ([#7608](https://github.com/n8n-io/n8n/issues/7608)) ([`2064f7f`](`2064f7f251`)) * GitHub Node: Fix issue preventing file edits on branches ([#7734](https://github.com/n8n-io/n8n/issues/7734)) ([`ce002a6`](`ce002a6cc6`)) * Google Sheets Node: Check for `null` before destructuring ([#7729](https://github.com/n8n-io/n8n/issues/7729)) ([`5d4a52d`](`5d4a52d3b7`)) * Item Lists Node: Don't check same type in remove duplicates operation ([#7678](https://github.com/n8n-io/n8n/issues/7678)) ([`4f30764`](`4f307646f3`)) * JotForm Trigger Node: Fix iteration on form loader ([#7751](https://github.com/n8n-io/n8n/issues/7751)) ([`82f3202`](`82f3202a2d`)) ### Features * Add Creator hub link to Templates page ([#7721](https://github.com/n8n-io/n8n/issues/7721)) ([`4dbae0e`](`4dbae0e2e9`)) * core: Coordinate manual workflow activation and deactivation in multi-main scenario ([#7643](https://github.com/n8n-io/n8n/issues/7643)) ([`4c40825`](`4c4082503c`)) * editor: Add node context menu ([#7620](https://github.com/n8n-io/n8n/issues/7620)) ([`8d12c1a`](`8d12c1ad8d`)) * editor: Node IO filter ([#7503](https://github.com/n8n-io/n8n/issues/7503)) ([`1881765`](`18817651ec`)) Co-authored-by: ivov <ivov@users.noreply.github.com>	2023-11-22 14:32:25 +01:00
कारतोफ्फेलस्क्रिप्ट™	db77353272	fix(core): Pass correct node reference to NodeExecuteFunctions.getLoadOptionsFunctions (no-changelog) (#7779 ) NODE-947	2023-11-22 13:24:23 +01:00
Milorad FIlipović	2064f7f251	fix(editor): Validate user info before submiting (#7608 ) Validate first and last names before saving them to database. This should prevent security issue with un-sanitized data that ends up in emails. --------- Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>	2023-11-22 12:14:44 +01:00
कारतोफ्फेलस्क्रिप्ट™	9b4856e7de	feat(core): Make postgres pool-size configurable (no-changelog) (#7772 ) When we upgrade typeorm in #5151, we switched from no pooling to a default pool-size of 10. This somehow significantly deteriorates the performance of queries when the application is under load.	2023-11-21 18:13:08 +01:00
Iván Ovejero	3459eb6c2f	refactor(core): Include execution progress in save settings (no-changelog) (#7769 )	2023-11-21 17:33:44 +01:00
Iván Ovejero	b7c5c7406f	fix(core): Ensure failed executions are saved in queue mode (#7744 ) This PR adds `status` to run data so that `determineFinalExecutionStatus` resolves correctly on execution failure and removes the cleanup that is being duplicated in a worker hook. Followup to https://github.com/n8n-io/n8n/pull/7138 Should fix: - https://github.com/n8n-io/n8n/issues/7705 - https://linear.app/n8n/issue/PAY-964/no-execution-found-after-execution-fails - https://linear.app/n8n/issue/PAY-1010/execution-deletion-in-queue-mode-not-complying-with-settings	2023-11-20 16:03:02 +01:00
Iván Ovejero	6d19f88080	refactor(core): Stop reporting to Sentry unknown cred on mapping (no-changelog) (#7752 ) https://n8nio.sentry.io/issues/4563418905	2023-11-17 16:17:44 +01:00
Iván Ovejero	4c4082503c	feat(core): Coordinate manual workflow activation and deactivation in multi-main scenario (#7643 ) Followup to #7566 \| Story: https://linear.app/n8n/issue/PAY-926 ### Manual workflow activation and deactivation In a multi-main scenario, if the user manually activates or deactivates a workflow, the process (whether leader or follower) that handles the PATCH request and updates its internal state should send a message into the command channel, so that all other main processes update their internal state accordingly: - Add to `ActiveWorkflows` if activating - Remove from `ActiveWorkflows` if deactivating - Remove and re-add to `ActiveWorkflows` if the update did not change activation status. After updating their internal state, if activating or deactivating, the recipient main processes should push a message to all connected frontends so that these can update their stores and so reflect the value in the UI. ### Workflow activation errors On failure to activate a workflow, the main instance should record the error in Redis - main instances should always pull activation errors from Redis in a multi-main scenario. ### Leadership change On leadership change... - The old leader should stop pruning and the new leader should start pruning. - The old leader should remove trigger- and poller-based workflows and the new leader should add them.	2023-11-17 15:58:50 +01:00
कारतोफ्फेलस्क्रिप्ट™	db094f2d7e	fix(core): Fix all dependency versions for backend packages (no-changelog) (#7745 ) Once the packages are published to NPM, they don't have the `pnpm-lock.yaml` to fix dependency versions. Which means that any dependency with `^` gets auto-upgrade to the latest matching minor, which can cause issues like [this](https://github.com/node-cache-manager/node-cache-manager/issues/611).	2023-11-17 13:49:18 +01:00
कारतोफ्फेलस्क्रिप्ट™	fc60e9a809	refactor(core): Convert dynamic node-parameter routes to a decorated controller (no-changelog) (#7284 ) 1. Reduce a lot of code duplication 2. Move more endpoints out of `Server.ts` 3. Move all query-param parsing and validation into a middleware to make the route handlers simpler.	2023-11-17 12:03:05 +01:00
Iván Ovejero	0408299c7d	refactor(core): Stop reporting to Sentry unrecognized node errors (no-changelog) (#7728 ) https://n8nio.sentry.io/issues/4636584213	2023-11-17 10:25:10 +01:00
Iván Ovejero	b4ebb1a28d	fix(core): Account for non-ASCII chars in filename on binary data download (#7742 ) https://n8nio.sentry.io/issues/4641538638	2023-11-17 10:07:44 +01:00
Ricardo Espinoza	8e0ae3cf8c	refactor: Extract Invitation routes to InvitationController (no-changelog) (#7726 ) This PR: - Creates `InvitationController` - Moves `POST /users` to `POST /invitations` and move related test to `invitations.api.tests` - Moves `POST /users/:id` to `POST /invitations/:id/accept` and move related test to `invitations.api.tests` - Adjusts FE to use new endpoints - Moves all the invitation logic to the `UserService` --------- Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>	2023-11-16 12:39:43 -05:00
Csaba Tuncsik	e2ffd397fc	fix(editor): Handle permission edge cases (empty scopes) (#7723 )	2023-11-16 18:08:23 +01:00
Val	d39bb2540f	feat: Add scopes to /login endpoint (no-changelog) (#7718 ) Github issue / Community forum post (link here to close automatically):	2023-11-16 11:11:55 +00:00
Michael Auerswald	f96c1d2044	fix(core): Correct permissions for getstatus (#7724 )	2023-11-15 16:54:33 +01:00
github-actions[bot]	93103c0b08	🚀 Release 1.17.0 (#7720 ) # [1.17.0](https://github.com/n8n-io/n8n/compare/n8n@1.16.0...n8n@1.17.0) (2023-11-15) ### Bug Fixes * Convert to/from binary data Node: Better mime type defaults ([#7693](https://github.com/n8n-io/n8n/issues/7693)) ([`9b3be0c`](`9b3be0cfd8`)) * core: Consider subworkflows successfully run when in waiting state ([#7699](https://github.com/n8n-io/n8n/issues/7699)) ([`0e00dab`](`0e00dab9f5`)) * core: Fix named parameter resolution in migrations ([#7688](https://github.com/n8n-io/n8n/issues/7688)) ([`4441ed5`](`4441ed5116`)), closes [#7628](https://github.com/n8n-io/n8n/issues/7628) * core: Initialize JWT Secret before it's used anywhere ([#7707](https://github.com/n8n-io/n8n/issues/7707)) ([`3460eb5`](`3460eb5eeb`)) * core: Reduce memory usage in credentials risk auditing ([#7663](https://github.com/n8n-io/n8n/issues/7663)) ([`9fd6319`](`9fd6319583`)) * Date & Time Node: Add fromFormat option to solve ambiguous date strings ([#7675](https://github.com/n8n-io/n8n/issues/7675)) ([`d2d11e0`](`d2d11e0208`)) * editor: Fix resource mapper component being truncated ([#7664](https://github.com/n8n-io/n8n/issues/7664)) ([`00dff50`](`00dff50140`)) * editor: More securely clear executions tab auto refresh timer ([#7685](https://github.com/n8n-io/n8n/issues/7685)) ([`37dd658`](`37dd658dc5`)) * editor: Redirect to workflow editor after saving in debug mode ([#7645](https://github.com/n8n-io/n8n/issues/7645)) ([`020042e`](`020042ef1a`)) * Google Sheets Node: Append exceeding grid limits ([#7684](https://github.com/n8n-io/n8n/issues/7684)) ([`88efb99`](`88efb99587`)) * HTTP Request Node: Support generic credentials when using pagination ([#7686](https://github.com/n8n-io/n8n/issues/7686)) ([`48b240b`](`48b240b026`)), closes [#7653](https://github.com/n8n-io/n8n/issues/7653) * HubSpot Node: Fetching available parameters fails when using expressions ([#7672](https://github.com/n8n-io/n8n/issues/7672)) ([`a9ab738`](`a9ab73896e`)) * HubSpot Node: Update deal owner on Hubspot Deal ([#7673](https://github.com/n8n-io/n8n/issues/7673)) ([`3c0734b`](`3c0734bd2d`)) * Spreadsheet File Node: Read file as utf-8 in v1 ([#7701](https://github.com/n8n-io/n8n/issues/7701)) ([`786b4ad`](`786b4adcce`)) ### Features * core: Expression function $ifEmpty ([#7660](https://github.com/n8n-io/n8n/issues/7660)) ([`1c7225e`](`1c7225ebdb`)) * Date & Time Node: Option to include other fields in output item ([#7661](https://github.com/n8n-io/n8n/issues/7661)) ([`aea3c50`](`aea3c50131`)) * Discord Node: Overhaul ([#5351](https://github.com/n8n-io/n8n/issues/5351)) ([`6a53c2a`](`6a53c2a375`)) * Discourse Node: Add new options to Get Users ([#7674](https://github.com/n8n-io/n8n/issues/7674)) ([`2e8c841`](`2e8c841277`)) * editor: Add color selector to sticky node ([#7453](https://github.com/n8n-io/n8n/issues/7453)) ([`8359364`](`8359364536`)) * editor: Add HTTP request nodes for credentials without a node ([#7157](https://github.com/n8n-io/n8n/issues/7157)) ([`14035e1`](`14035e1244`)) * editor: Add workflow filters to querystring ([#7456](https://github.com/n8n-io/n8n/issues/7456)) ([`afd637b`](`afd637b5ea`)) * editor: Adds a EE view to show worker details and job status ([#7600](https://github.com/n8n-io/n8n/issues/7600)) ([`cbc6909`](`cbc690907f`)) * GitLab Node: Add support for pagination on getIssues ([#7529](https://github.com/n8n-io/n8n/issues/7529)) ([`0a0798e`](`0a0798e485`)) * OpenAI Node: Add dall-e-3 support ([#7655](https://github.com/n8n-io/n8n/issues/7655)) ([`a9c7188`](`a9c7188c4d`)) * RabbitMQ Trigger Node: Add exchange and routing key options ([#7547](https://github.com/n8n-io/n8n/issues/7547)) ([`5aee2b7`](`5aee2b768f`)) * Telegram Node: Add support for markdownv2 ([#7679](https://github.com/n8n-io/n8n/issues/7679)) ([`819b3a7`](`819b3a746a`)) * Venafi TLS Protect Cloud Node: Add region parameter to Venafi protect cloud ([#7689](https://github.com/n8n-io/n8n/issues/7689)) ([`a08fca5`](`a08fca51d9`)) ### Performance Improvements * core: Lazyload security audit reporters ([#7696](https://github.com/n8n-io/n8n/issues/7696)) ([`b2ca050`](`b2ca050031`)) Co-authored-by: ivov <ivov@users.noreply.github.com>	2023-11-15 15:18:08 +01:00
कारतोफ्फेलस्क्रिप्ट™	2844ce2bd2	ci: Fix env issues in e2e tests (no-changelog) (#7719 )	2023-11-15 13:58:38 +01:00
Ricardo Espinoza	4020c14d59	refactor: Use POST /users to re-invite users (no-changelog) (#7714 )	2023-11-15 06:40:57 -05:00
कारतोफ्फेलस्क्रिप्ट™	3460eb5eeb	fix(core): Initialize JWT Secret before it's used anywhere (#7707 ) HELP-394	2023-11-15 12:17:18 +01:00
कारतोफ्फेलस्क्रिप्ट™	4441ed5116	fix(core): Fix named parameter resolution in migrations (#7688 ) Fixes #7628	2023-11-15 10:31:08 +01:00
Michael Auerswald	0e00dab9f5	fix(core): Consider subworkflows successfully run when in waiting state (#7699 ) Github issue / Community forum post (link here to close automatically): https://github.com/n8n-io/n8n/issues/7189	2023-11-14 11:04:24 +01:00
Elias Meire	14035e1244	feat(editor): Add HTTP request nodes for credentials without a node (#7157 ) Github issue / Community forum post (link here to close automatically): --------- Co-authored-by: Giulio Andreini <g.andreini@gmail.com> Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>	2023-11-13 12:11:16 +01:00
Iván Ovejero	b2ca050031	perf(core): Lazyload security audit reporters (#7696 ) Also converting to service. Followup to https://github.com/n8n-io/n8n/pull/7663	2023-11-13 11:50:43 +01:00
Michael Auerswald	cbc690907f	feat(editor): Adds a EE view to show worker details and job status (#7600 ) This change expands on the command channel communication introduced lately between the main instance(s) and the workers. The frontend gets a new menu entry "Workers" which will, when opened, trigger a regular call to getStatus from the workers. The workers then respond via their response channel to the backend, which then pushes the status to the frontend. This introduces the use of ChartJS for metrics. This feature is still in MVP state and thus disabled by default for the moment.	2023-11-10 23:48:31 +01:00
Ricardo Espinoza	0ddafd2b82	test: Unify users.controller.test and users.api.test (no-changelog) (#7658 ) Groundwork to be able to safely refactor and move the invitation logic to the UserService. Fixes ADO-1358 --------- Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>	2023-11-10 09:41:58 -05:00
कारतोफ्फेलस्क्रिप्ट™	000e76e3b4	ci(core): Reduce memory usage in tests (part-2) (no-changelog) (#7671 ) This also gets rid of `Db.collection`, which was another source of circular dependencies.	2023-11-10 15:04:26 +01:00
Iván Ovejero	f73a0597ba	refactor: Add rule `no-constant-binary-expression` (no-changelog) (#7670 ) https://eslint.org/docs/latest/rules/no-constant-binary-expression	2023-11-09 17:50:59 +01:00
कारतोफ्फेलस्क्रिप्ट™	9fd6319583	fix(core): Reduce memory usage in credentials risk auditing (#7663 )	2023-11-09 14:39:16 +01:00
कारतोफ्फेलस्क्रिप्ट™	5edf722209	ci: Stop disabling linting rules that are explicitly set to `warn` (no-changelog) (#7669 )	2023-11-09 14:05:39 +01:00
Iván Ovejero	16a1a92f18	refactor(core): Stop reporting to Sentry credential-not-found error (no-changelog) (#7665 ) https://n8nio.sentry.io/issues/4528134408	2023-11-09 10:55:13 +01:00
कारतोफ्फेलस्क्रिप्ट™	0346b211a7	ci(core): Reduce memory usage in tests (part-1) (no-changelog) (#7654 )	2023-11-08 16:29:39 +01:00
github-actions[bot]	e5c6a1bdf9	🚀 Release 1.16.0 (#7652 ) # [1.16.0](https://github.com/n8n-io/n8n/compare/n8n@1.15.1...n8n@1.16.0) (2023-11-08) ### Bug Fixes * core: Comply with custom default for workflow saving settings ([#7634](https://github.com/n8n-io/n8n/issues/7634)) ([`48c068f`](`48c068f97b`)) * core: Decrease reset password token expire time ([#7598](https://github.com/n8n-io/n8n/issues/7598)) ([`2aa7f63`](`2aa7f6375a`)) * core: Ensure `init` before checking leader or follower in multi-main scenario ([#7621](https://github.com/n8n-io/n8n/issues/7621)) ([`a994ba5`](`a994ba5e8d`)) * core: Ensure pruning starts only after migrations have completed ([#7626](https://github.com/n8n-io/n8n/issues/7626)) ([`f748de9`](`f748de9567`)) * core: Fix accessor error when running partial execution ([#7618](https://github.com/n8n-io/n8n/issues/7618)) ([`26361df`](`26361dfcd3`)), closes [#6229](https://github.com/n8n-io/n8n/issues/6229) * core: Make password-reset urls valid only for single-use ([#7622](https://github.com/n8n-io/n8n/issues/7622)) ([`6031424`](`60314248f4`)) * Crypto Node: Fix issue with value not appearing for Sign action ([#7619](https://github.com/n8n-io/n8n/issues/7619)) ([`5df583f`](`5df583f783`)) * editor: Allow overriding theme from query params ([#7591](https://github.com/n8n-io/n8n/issues/7591)) ([`2854a0c`](`2854a0cf46`)) * editor: Fix issue that frontend breaks with unkown nodes ([#7596](https://github.com/n8n-io/n8n/issues/7596)) ([`db56a9e`](`db56a9ee37`)) * editor: Fix local storage flags defaulting to undefined string ([#7603](https://github.com/n8n-io/n8n/issues/7603)) ([`151e60f`](`151e60f829`)) * editor: Fix workflow history prune time limit (getting hours instead of days) ([#7644](https://github.com/n8n-io/n8n/issues/7644)) ([`3d5a485`](`3d5a485bcf`)) * editor: Hide not supported node options ([#7597](https://github.com/n8n-io/n8n/issues/7597)) ([`b532a7b`](`b532a7bdb7`)) * editor: Remove unknown credentials on pasting workflow ([#7582](https://github.com/n8n-io/n8n/issues/7582)) ([`d633753`](`d633753687`)) * editor: Reset canvas zoom before workspace reset in node view ([#7625](https://github.com/n8n-io/n8n/issues/7625)) ([`78b84af`](`78b84af8d1`)) * editor: Zoom in/out on canvas the same amount on scroll/gesture ([#7602](https://github.com/n8n-io/n8n/issues/7602)) ([`c92402a`](`c92402a3ca`)) * Facebook Lead Ads Trigger Node: Fix issue with missing scope for business management ([#7616](https://github.com/n8n-io/n8n/issues/7616)) ([`32b85ba`](`32b85ba2fe`)) ### Features * core: Add the node version to telemetry in node_graph_string ([#7449](https://github.com/n8n-io/n8n/issues/7449)) ([`59dc36a`](`59dc36abd9`)) * core: Coordinate workflow activation in multiple main scenario in internal API ([#7566](https://github.com/n8n-io/n8n/issues/7566)) ([`c857e42`](`c857e42677`)) * core: Initial support for two-way communication over websockets ([#7570](https://github.com/n8n-io/n8n/issues/7570)) ([`ac87701`](`ac877014ed`)) * core: Log executed migrations with info level ([#7586](https://github.com/n8n-io/n8n/issues/7586)) ([`7dac9ab`](`7dac9ab82c`)) * core: Rate limit forgot password endpoint ([#7604](https://github.com/n8n-io/n8n/issues/7604)) ([`5790e25`](`5790e251b8`)) * LinkedIn Node: Add support for Article thumbnails ([#7489](https://github.com/n8n-io/n8n/issues/7489)) ([`e6d3d1a`](`e6d3d1a4c2`)) * NocoDB Node: Add new data apis and workspace support ([#7329](https://github.com/n8n-io/n8n/issues/7329)) ([`da2d2a8`](`da2d2a83bb`)) Co-authored-by: ivov <ivov@users.noreply.github.com>	2023-11-08 14:20:22 +01:00
Iván Ovejero	3a776e0132	refactor(core): Stop reporting to Sentry missing-node-on-retry error (no-changelog) (#7648 ) https://n8nio.sentry.io/issues/4612370603	2023-11-08 10:09:33 +01:00
Iván Ovejero	48c068f97b	fix(core): Comply with custom default for workflow saving settings (#7634 ) https://linear.app/n8n/issue/PAY-982	2023-11-07 16:26:55 +01:00
Tomi Turtiainen	ac877014ed	feat(core): Initial support for two-way communication over websockets (#7570 ) - Enable two-way communication with web sockets - Enable sending push messages to specific users - Add collaboration service for managing active users for workflow Missing things: - State is currently kept only in memory, making this not work in multi-master setups - Removing a user from active users in situations where they go inactive or we miss the "workflow closed" message - I think a timer based solution for this would cover most edge cases. I.e. have FE ping every X minutes, BE removes the user unless they have received a ping in Y minutes, where Y > X - FE changes to be added later by @MiloradFilipovic Github issue / Community forum post (link here to close automatically): --------- Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>	2023-11-07 17:26:45 +02:00
कारतोफ्फेलस्क्रिप्ट™	f0fc5b16d3	ci(core): Load config schema after process.env has been overwritten (no-changelog) (#7550 )	2023-11-07 15:58:28 +01:00
कारतोफ्फेलस्क्रिप्ट™	60314248f4	fix(core): Make password-reset urls valid only for single-use (#7622 )	2023-11-07 15:35:43 +01:00
Ricardo Espinoza	b3470fd64d	fix: Error handling on forgot password page (no-changelog) (#7633 ) fixes: https://linear.app/n8n/issue/ADO-1339/fix-error-handling-on-forgot-password-page	2023-11-07 08:45:58 -05:00
Iván Ovejero	f748de9567	fix(core): Ensure pruning starts only after migrations have completed (#7626 ) https://linear.app/n8n/issue/PAY-986/bug-execution-pruning-timer-is-started-before-the-database-is-ready --------- Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>	2023-11-07 13:56:01 +01:00
Iván Ovejero	c857e42677	feat(core): Coordinate workflow activation in multiple main scenario in internal API (#7566 ) Story: https://linear.app/n8n/issue/PAY-926 This PR coordinates workflow activation on instance startup and on leadership change in multiple main scenario in the internal API. Part 3 on manual workflow activation and deactivation will be a separate PR. ### Part 1: Instance startup In multi-main scenario, on starting an instance... - [x] If the instance is the leader, it should add webhooks, triggers and pollers. - [x] If the instance is the follower, it should not add webhooks, triggers or pollers. - [x] Unit tests. ### Part 2: Leadership change In multi-main scenario, if the main instance leader dies… - [x] The new main instance leader must activate all trigger- and poller-based workflows, excluding webhook-based workflows. - [x] The old main instance leader must deactivate all trigger- and poller-based workflows, excluding webhook-based workflows. - [x] Unit tests. To test, start two instances and check behavior on startup and leadership change: ``` EXECUTIONS_MODE=queue N8N_LEADER_SELECTION_ENABLED=true N8N_LICENSE_TENANT_ID=... N8N_LICENSE_ACTIVATION_KEY=... N8N_LOG_LEVEL=debug npm run start EXECUTIONS_MODE=queue N8N_LEADER_SELECTION_ENABLED=true N8N_LICENSE_TENANT_ID=... N8N_LICENSE_ACTIVATION_KEY=... N8N_LOG_LEVEL=debug N8N_PORT=5679 npm run start ```	2023-11-07 13:48:48 +01:00
Iván Ovejero	a994ba5e8d	fix(core): Ensure `init` before checking leader or follower in multi-main scenario (#7621 ) This PR ensures `MultiMainInstancePublisher` is initialized before checking if the instance is leader or follower. Followers skip license init, license check, and pruning start and stop.	2023-11-06 12:03:35 +01:00
Ricardo Espinoza	5790e251b8	feat(core): Rate limit forgot password endpoint (#7604 ) Github issue / Community forum post (link here to close automatically): --------- Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <netroy@users.noreply.github.com>	2023-11-03 13:44:12 -04:00
कारतोफ्फेलस्क्रिप्ट™	acec9bad71	refactor(core): Convert OAuth1/OAuth2 routes to decorated controller classes (no-changelog) (#5973 )	2023-11-03 17:20:54 +01:00
Tomi Turtiainen	2aa7f6375a	fix(core): Decrease reset password token expire time (#7598 ) Decrease the expiration time from 1 day to 20 minutes Github issue / Community forum post (link here to close automatically):	2023-11-03 13:32:08 +02:00
कारतोफ्फेलस्क्रिप्ट™	bb2c266e48	Merge tag 'n8n@1.15.1'	2023-11-02 18:11:06 +01:00
github-actions[bot]	fbce8f5298	🚀 Release 1.15.1 (#7592 ) ## [1.15.1](https://github.com/n8n-io/n8n/compare/n8n@1.14.0...n8n@1.15.1) (2023-11-02) ### Bug Fixes * core: Ensure execution deletion in worker lifecycle hook ([#7481](https://github.com/n8n-io/n8n/issues/7481)) ([`742c8a8`](`742c8a8534`)) * core: Fix data encryption on credentials import ([#7560](https://github.com/n8n-io/n8n/issues/7560)) ([`b350568`](`b350568505`)) * core: Fix issue that prevents owner logging in when using ldap ([#7408](https://github.com/n8n-io/n8n/issues/7408)) ([`479f902`](`479f90231d`)) * core: Handle missing resultData in runData ([#7523](https://github.com/n8n-io/n8n/issues/7523)) ([`1055bd3`](`1055bd3762`)) * core: Permission check for subworkflow properly checking for workflow settings ([#7576](https://github.com/n8n-io/n8n/issues/7576)) ([`437c95e`](`437c95e84e`)) * core: Prevent executions from becoming forever running ([#7569](https://github.com/n8n-io/n8n/issues/7569)) ([`9bdb85c`](`9bdb85c4ce`)) * core: Upgrade crypto-js to address CVE-2023-46233 ([#7519](https://github.com/n8n-io/n8n/issues/7519)) ([`65e5593`](`65e5593233`)) * editor: Do not truncate form inputs ([#7528](https://github.com/n8n-io/n8n/issues/7528)) ([`ae616f1`](`ae616f146b`)) * editor: Fix NDV close after using input select ([#7544](https://github.com/n8n-io/n8n/issues/7544)) ([`3b5e181`](`3b5e181e66`)) * editor: Fix NDV unexpected re-render ([#7532](https://github.com/n8n-io/n8n/issues/7532)) ([`2853fcf`](`2853fcff73`)) * editor: Fix route component caching, incorrect use of array reduce method and enable WF history feature ([#7434](https://github.com/n8n-io/n8n/issues/7434)) ([`12a89e6`](`12a89e6d14`)) * editor: Fixes the issue that Switch Node can not be created ([#7516](https://github.com/n8n-io/n8n/issues/7516)) ([`df89685`](`df89685e15`)) * editor: Handle `localStorage` being blocked/unavailable ([#7348](https://github.com/n8n-io/n8n/issues/7348)) ([`c05bc67`](`c05bc6728d`)) * Fix dark mode small issues ([#7573](https://github.com/n8n-io/n8n/issues/7573)) ([`1d81afc`](`1d81afcbdf`)) * Jira Software Node: Handle missing issue types in issue types loader ([#7534](https://github.com/n8n-io/n8n/issues/7534)) ([`9762705`](`9762705833`)) * Switch Node: Allow sortable Switch rules ([#7555](https://github.com/n8n-io/n8n/issues/7555)) ([`7a56e58`](`7a56e58a60`)) ### Features * core: Add optional Error-Output ([#7460](https://github.com/n8n-io/n8n/issues/7460)) ([`655efea`](`655efeaf66`)) * core: Make queue mode settings configurable ([#7526](https://github.com/n8n-io/n8n/issues/7526)) ([`3d95b24`](`3d95b243e9`)) * core: Set up leader selection for multiple main instances ([#7527](https://github.com/n8n-io/n8n/issues/7527)) ([`442c73e`](`442c73e63b`)) * editor: Implement the `UserStack` design system component ([#7559](https://github.com/n8n-io/n8n/issues/7559)) ([`ce14f62`](`ce14f6266b`)) * HTTP Request Node: Add pagination support ([#5993](https://github.com/n8n-io/n8n/issues/5993)) ([`cc2bd2e`](`cc2bd2e19c`)) * HTTP Request Node: Update icon and default color ([#7572](https://github.com/n8n-io/n8n/issues/7572)) ([`ff279ab`](`ff279ab411`)) * n8n Form Trigger Node: Add text area and password input types ([#7474](https://github.com/n8n-io/n8n/issues/7474)) ([`b72040a`](`b72040aa54`)) * editor: Dark mode is here! You can change it under personal settings.([#6980](https://github.com/n8n-io/n8n/pull/6980)) ([`0746783`](`0746783e02`)) --------- Co-authored-by: krynble <krynble@users.noreply.github.com> Co-authored-by: Omar Ajoue <krynble@gmail.com>	2023-11-02 14:52:11 +01:00
Iván Ovejero	1c77d6597f	refactor(core): Ensure only leader handles licensing in multi-main scenario (#7558 ) https://linear.app/n8n/issue/PAY-953/ensure-only-main-instance-leader-handles-licensing	2023-11-02 14:16:22 +01:00
Tomi Turtiainen	7dac9ab82c	feat(core): Log executed migrations with info level (#7586 ) To help debugging possible issues in startup and migrations, log the executed migrations with log level 'info', instead of 'debug'. Github issue / Community forum post (link here to close automatically):	2023-11-02 14:24:04 +02:00
Iván Ovejero	921d213ae5	refactor(core): Create pruning service (no-changelog) (#7564 ) https://linear.app/n8n/issue/PAY-954/ensure-only-main-instance-leader-handles-pruning	2023-11-02 12:24:25 +01:00
github-actions[bot]	73e9a216b7	🚀 Release 1.15.0 (#7580 ) # [1.15.0](https://github.com/n8n-io/n8n/compare/n8n@1.14.0...n8n@1.15.0) (2023-11-02) ### Bug Fixes * core: Ensure execution deletion in worker lifecycle hook ([#7481](https://github.com/n8n-io/n8n/issues/7481)) ([`742c8a8`](`742c8a8534`)) * core: Fix data encryption on credentials import ([#7560](https://github.com/n8n-io/n8n/issues/7560)) ([`b350568`](`b350568505`)) * core: Fix issue that prevents owner logging in when using ldap ([#7408](https://github.com/n8n-io/n8n/issues/7408)) ([`479f902`](`479f90231d`)) * core: Handle missing resultData in runData ([#7523](https://github.com/n8n-io/n8n/issues/7523)) ([`1055bd3`](`1055bd3762`)) * core: Permission check for subworkflow properly checking for workflow settings ([#7576](https://github.com/n8n-io/n8n/issues/7576)) ([`437c95e`](`437c95e84e`)) * core: Prevent executions from becoming forever running ([#7569](https://github.com/n8n-io/n8n/issues/7569)) ([`9bdb85c`](`9bdb85c4ce`)) * core: Upgrade crypto-js to address CVE-2023-46233 ([#7519](https://github.com/n8n-io/n8n/issues/7519)) ([`65e5593`](`65e5593233`)) * editor: Do not truncate form inputs ([#7528](https://github.com/n8n-io/n8n/issues/7528)) ([`ae616f1`](`ae616f146b`)) * editor: Fix NDV close after using input select ([#7544](https://github.com/n8n-io/n8n/issues/7544)) ([`3b5e181`](`3b5e181e66`)) * editor: Fix NDV unexpected re-render ([#7532](https://github.com/n8n-io/n8n/issues/7532)) ([`2853fcf`](`2853fcff73`)) * editor: Fix route component caching, incorrect use of array reduce method and enable WF history feature ([#7434](https://github.com/n8n-io/n8n/issues/7434)) ([`12a89e6`](`12a89e6d14`)) * editor: Fixes the issue that Switch Node can not be created ([#7516](https://github.com/n8n-io/n8n/issues/7516)) ([`df89685`](`df89685e15`)) * editor: Handle `localStorage` being blocked/unavailable ([#7348](https://github.com/n8n-io/n8n/issues/7348)) ([`c05bc67`](`c05bc6728d`)) * Jira Software Node: Handle missing issue types in issue types loader ([#7534](https://github.com/n8n-io/n8n/issues/7534)) ([`9762705`](`9762705833`)) * Switch Node: Allow sortable Switch rules ([#7555](https://github.com/n8n-io/n8n/issues/7555)) ([`7a56e58`](`7a56e58a60`)) ### Features * core: Add optional Error-Output ([#7460](https://github.com/n8n-io/n8n/issues/7460)) ([`655efea`](`655efeaf66`)) * core: Make queue mode settings configurable ([#7526](https://github.com/n8n-io/n8n/issues/7526)) ([`3d95b24`](`3d95b243e9`)) * core: Set up leader selection for multiple main instances ([#7527](https://github.com/n8n-io/n8n/issues/7527)) ([`442c73e`](`442c73e63b`)) * editor: Implement the `UserStack` design system component ([#7559](https://github.com/n8n-io/n8n/issues/7559)) ([`ce14f62`](`ce14f6266b`)) * HTTP Request Node: Add pagination support ([#5993](https://github.com/n8n-io/n8n/issues/5993)) ([`cc2bd2e`](`cc2bd2e19c`)) * HTTP Request Node: Update icon and default color ([#7572](https://github.com/n8n-io/n8n/issues/7572)) ([`ff279ab`](`ff279ab411`)) * n8n Form Trigger Node: Add text area and password input types ([#7474](https://github.com/n8n-io/n8n/issues/7474)) ([`b72040a`](`b72040aa54`)) * editor: Dark mode is here! You can change it under personal settings.([#6980](https://github.com/n8n-io/n8n/pull/6980)) ([`0746783`](`0746783e02`)) --------- Co-authored-by: krynble <krynble@users.noreply.github.com> Co-authored-by: Omar Ajoue <krynble@gmail.com>	2023-11-02 11:47:11 +01:00
Jon	479f90231d	fix(core): Fix issue that prevents owner logging in when using ldap (#7408 ) This PR prioritises the internal email account over LDAP for the Owner. --------- Co-authored-by: ricardo <ricardoespinoza105@gmail.com>	2023-11-01 23:02:49 -04:00
Omar Ajoue	437c95e84e	fix(core): Permission check for subworkflow properly checking for workflow settings (#7576 ) The `sharing` related code is legacy that was not removed. Subworkflow execution should check workflow settings alone, and this is now reflected in the code. Github issue / Community forum post (link here to close automatically): https://community.n8n.io/t/bug-when-using-the-execute-workflow-node-when-workflow-is-shared/32207 --------- Co-authored-by: Iván Ovejero <ivov.src@gmail.com>	2023-11-01 18:31:34 +01:00
कारतोफ्फेलस्क्रिप्ट™	9bdb85c4ce	fix(core): Prevent executions from becoming forever running (#7569 ) Fixes CP-867 Possibly also fixes PAY-323 and PAY-412	2023-11-01 13:51:13 +01:00
Yoshino-s	b72040aa54	feat(n8n Form Trigger Node): Add text area and password input types (#7474 ) Signed-off-by: yoshino-s <cy-cui@outlook.com>	2023-11-01 12:23:28 +00:00
Michael Auerswald	b350568505	fix(core): Fix data decryption on credentials import (#7560 ) Due to a change, during the credentials import command, the core's Credential object is being called through its prototype. This caused the Credential's cipher variable to not be set, thus no cipher service being available during import. This fix catches this edge case and provides a fix.	2023-10-31 13:15:09 +01:00
Jan Oberhauser	655efeaf66	feat(core): Add optional Error-Output (#7460 ) Add an additional optional error output to which all items get sent that could not be processed. ![Screenshot from 2023-10-18 17-29-15](https://github.com/n8n-io/n8n/assets/6249596/e9732807-ab2b-4662-a5f6-bdff24f7ad55) Github issue / Community forum post (link here to close automatically): https://community.n8n.io/t/error-connector-for-nodes/3094 https://community.n8n.io/t/error-handling-at-node-level-detect-node-execution-status/26791 --------- Co-authored-by: OlegIvaniv <me@olegivaniv.com>	2023-10-30 18:42:47 +01:00
Iván Ovejero	442c73e63b	feat(core): Set up leader selection for multiple main instances (#7527 ) https://linear.app/n8n/issue/PAY-933/set-up-leader-selection-for-multiple-main-instances - [x] Set up new envs - [x] Add config and license checks - [x] Implement `MultiMainInstancePublisher` - [x] Expand `RedisServicePubSubPublisher` to support `MultiMainInstancePublisher` - [x] Init `MultiMainInstancePublisher` on startup and destroy on shutdown - [x] Add to sandbox plans - [x] Test manually Note: This is only for setup - coordinating in reaction to leadership changes will come in later PRs.	2023-10-30 16:22:32 +01:00
OlegIvaniv	3ab04e4f9e	ci(core): Extract local e2e run script (no-changelog) (#7551 ) Github issue / Community forum post (link here to close automatically): --------- Signed-off-by: Oleg Ivaniv <me@olegivaniv.com> Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>	2023-10-30 11:18:51 +01:00
Iván Ovejero	233683ce1a	refactor(core): Remove webhook deregistration on shutdown flag (#7543 ) Removal missing from [original PR](https://github.com/n8n-io/n8n/pull/7515) after initial revert.	2023-10-27 18:48:21 +02:00
Iván Ovejero	6796ba75a1	refactor(core): Stop reporting to Sentry stopping execution with wrong status (no-changelog) (#7541 ) https://n8nio.sentry.io/issues/4257040218/	2023-10-27 16:14:01 +02:00
कारतोफ्फेलस्क्रिप्ट™	35bb42c1b9	refactor(core): Avoid passing around static state like default timezone (no-changelog) (#7221 )	2023-10-27 14:17:52 +02:00
Iván Ovejero	62c096710f	refactor: Run `lintfix` (no-changelog) (#7537 ) - Fix autofixable violations - Remove unused directives - Allow for PascalCased variables - needed for dynamically imported or assigned classes, decorators, routers, etc.	2023-10-27 14:15:02 +02:00
Omar Ajoue	87996a1fcf	refactor(core): Stop reporting non-error to sentry (issue 4229454473) (no-changelog) (#7525 ) This PR aims to stop reporting issues such as [this one](https://n8nio.sentry.io/issues/4229454473/events/42b96bfd6a334c15a84499e981cf90eb/?project=4503924908883968). Github issue / Community forum post (link here to close automatically):	2023-10-27 09:25:07 +02:00
Omar Ajoue	3d95b243e9	feat(core): Make queue mode settings configurable (#7526 ) This PR allows users to configure the settings to Bull, possibly reducing the errors with `maxStalledCount` and other issues, that usually happen either when a worker crashes or when the event loop is super busy. Increasing the lease time and the `maxStalledCount` settings might improve UX. Github issue / Community forum post (link here to close automatically):	2023-10-26 17:30:16 +02:00
Iván Ovejero	ae8c7a635e	refactor(core)!: Remove webhook deregistration at startup and shutdown (#7515 ) https://linear.app/n8n/issue/PAY-932/deprecate-flag-to-skip-webhook-deregistration-on-shutdown	2023-10-26 14:37:54 +02:00
Iván Ovejero	5477e3fb45	refactor(core): Move execution save settings into lifecycle function (no-changelog) (#7370 ) Move the handling of execution save settings into a tested lifecycle function as discussed with Omar	2023-10-26 14:35:38 +02:00
कारतोफ्फेलस्क्रिप्ट™	1055bd3762	fix(core): Handle missing resultData in runData (#7523 )	2023-10-26 13:15:19 +02:00
Iván Ovejero	742c8a8534	fix(core): Ensure execution deletion in worker lifecycle hook (#7481 ) Reported by customer [here](https://n8nio.slack.com/archives/C05PUALKZHD/p1697446945481249?thread_ts=1697196557.638169&cid=C05PUALKZHD), apparently a very old long-standing bug for queue mode. Please review closely as I am not familiar with queue mode.	2023-10-25 19:13:06 +02:00
कारतोफ्फेलस्क्रिप्ट™	05586a900d	refactor(core): Make Logger a service (no-changelog) (#7494 )	2023-10-25 16:35:22 +02:00
github-actions[bot]	db4e61ba24	🚀 Release 1.14.0 (#7514 ) # [1.14.0](https://github.com/n8n-io/n8n/compare/n8n@1.13.0...n8n@1.14.0) (2023-10-25) ### Features * Switch Node: Add support for infinite Switch outputs ([#7499](https://github.com/n8n-io/n8n/issues/7499)) ([`2febc61`](`2febc61ec9`)) Co-authored-by: netroy <netroy@users.noreply.github.com>	2023-10-25 15:34:57 +02:00
कारतोफ्फेलस्क्रिप्ट™	0643487403	ci: Fix oclif manifest generation	2023-10-25 14:51:10 +02:00
github-actions[bot]	2987587e34	🚀 Release 1.13.0 (#7512 ) # [1.13.0](https://github.com/n8n-io/n8n/compare/n8n@1.12.0...n8n@1.13.0) (2023-10-25) ### Bug Fixes * core: Do not return `inviteAcceptUrl` in response if email was sent ([#7465](https://github.com/n8n-io/n8n/issues/7465)) ([`55c6a1b`](`55c6a1b0d3`)) * core: Ensure nodes post-processors run in the correct order ([#7500](https://github.com/n8n-io/n8n/issues/7500)) ([`6f45298`](`6f45298d3d`)) * core: Fix `frontend.settings` external hook execution ([#7496](https://github.com/n8n-io/n8n/issues/7496)) ([`774fe20`](`774fe202bf`)) * core: Handle gzip and deflate compressed request payloads ([#7461](https://github.com/n8n-io/n8n/issues/7461)) ([`83762e0`](`83762e051d`)) * core: Reduce logging overhead for levels that do not output ([#7479](https://github.com/n8n-io/n8n/issues/7479)) ([`76c0481`](`76c04815f7`)) * Customer.io Node: Fix api endpoint when using EU region ([#7485](https://github.com/n8n-io/n8n/issues/7485)) ([`519680c`](`519680c2cf`)) * editor: Allow importing the same workflow multiple times ([#7458](https://github.com/n8n-io/n8n/issues/7458)) ([`3c0a166`](`3c0a166f7f`)) * editor: Fix canvas selection breaking after interacting with node actions ([#7466](https://github.com/n8n-io/n8n/issues/7466)) ([`bc47365`](`bc473655fb`)) * editor: Fix connections disappearing after reactivating canvas and renaming a node ([#7483](https://github.com/n8n-io/n8n/issues/7483)) ([`450e0cc`](`450e0cc66a`)) * Google Sheets Node: Append or update runs forever when without column headers ([#7463](https://github.com/n8n-io/n8n/issues/7463)) ([`ab6a9bb`](`ab6a9bbac2`)) * Microsoft SQL Node: Prevent SQL injection ([#7467](https://github.com/n8n-io/n8n/issues/7467)) ([`a739245`](`a739245332`)) * MQTT Trigger Node: Fix node causing a start up hang when active ([#7498](https://github.com/n8n-io/n8n/issues/7498)) ([`baecb93`](`baecb93bef`)) * MySQL Node: Resolve expressions in v1 ([#7464](https://github.com/n8n-io/n8n/issues/7464)) ([`5c46bb0`](`5c46bb09c1`)) * Redis Node: Fix adding sets data types ([#7444](https://github.com/n8n-io/n8n/issues/7444)) ([`4e66023`](`4e66023cd4`)) * Spreadsheet File Node: Fix include empty cells not working with v2 ([#7505](https://github.com/n8n-io/n8n/issues/7505)) ([`05e6f2a`](`05e6f2a6ac`)) ### Features * core: Add support for oauth based service accounts with UM SMTP ([#7311](https://github.com/n8n-io/n8n/issues/7311)) ([`647372b`](`647372be27`)) * editor: Add PH tracking to event ([#7511](https://github.com/n8n-io/n8n/issues/7511)) ([`c47d27d`](`c47d27dd6d`)) * Facebook Lead Ads Trigger Node: Add Facebook Lead Ads Trigger Node ([#7113](https://github.com/n8n-io/n8n/issues/7113)) ([`ac814a9`](`ac814a9c61`)) * Ghost Node: Add support for lexical format ([#7488](https://github.com/n8n-io/n8n/issues/7488)) ([`7b1973c`](`7b1973c058`)) * RSS Feed Trigger Node: Add RSS feed trigger node ([#7386](https://github.com/n8n-io/n8n/issues/7386)) ([`689360e`](`689360ee06`)) Co-authored-by: netroy <netroy@users.noreply.github.com>	2023-10-25 14:29:28 +02:00
कारतोफ्फेलस्क्रिप्ट™	6f45298d3d	fix(core): Ensure nodes post-processors run in the correct order (#7500 ) Fixes #7497	2023-10-25 13:59:38 +02:00
Val	93cfabbeac	fix(core): Fix workflow activation with history and workflow history for EE (no-changelog) (#7508 ) Github issue / Community forum post (link here to close automatically):	2023-10-25 11:07:11 +01:00
Iván Ovejero	671c95760b	refactor(core): Make executions pruning more resilient (#7480 ) This PR converts the hard-deletion interval to a timeout: - to prevent the interval from not being restored when hard deletion throws, and - to prevent a long-running hard deletion from leading to duplicate deletions.	2023-10-24 16:16:45 +02:00
Iván Ovejero	78243edd18	refactor(core): Make pruning via lifecycle configuration in S3 mode mandatory (#7482 ) Since we do not store which executions produced binary data, for pruning on S3 we need to query for binary data items for each execution in order to delete them. To minimize requests to S3, allow the user to skip pruning requests when setting TTL at bucket level.	2023-10-24 10:37:02 +02:00
Cornelius Suermann	3ef771ea38	feat: Collect usage metrics on license renewal (no-changelog) (#7486 )	2023-10-23 21:39:29 +02:00
Ricardo Espinoza	774fe202bf	fix(core): Fix `frontend.settings` external hook execution (#7496 )	2023-10-23 11:46:13 -04:00
Val	41236b7e08	fix: Save new version of the workflow instead of the previous (no-changelog) (#7428 ) Github issue / Community forum post (link here to close automatically):	2023-10-23 16:30:36 +02:00
कारतोफ्फेलस्क्रिप्ट™	b6de910cbe	refactor(core): Abstract away InstanceSettings and `encryptionKey` into injectable services (no-changelog) (#7471 ) This change ensures that things like `encryptionKey` and `instanceId` are always available directly where they are needed, instead of passing them around throughout the code.	2023-10-23 13:39:35 +02:00
कारतोफ्फेलस्क्रिप्ट™	76c04815f7	fix(core): Reduce logging overhead for levels that do not output (#7479 ) all current logging calls execute `callsites()` to figure out what code tried to log. This happens even for logging methods that aren't supposed to create any output. Under moderate load, this can take up quite a lot of resources. This PR changes the logger to make all ignorable logging methods a No-Op. In a small benchmark with a simple webhook, with log-level set to `warn`, and using `ab -c 50 -n 500 http://localhost:5678/webhook/testing`, these were the response times: ### Before ![Before](https://github.com/n8n-io/n8n/assets/196144/01680fd9-3d2a-4f7f-bb1c-5b03bd7d5bc3) ### After ![After](https://github.com/n8n-io/n8n/assets/196144/ccacb20a-48ca-455a-a8cb-098c9c0e352e)	2023-10-20 18:26:33 +02:00
Iván Ovejero	0b42d1aa71	refactor(core): Limit soft-deletions to pruning only (#7469 ) Based on customer feedback, we should limit soft deletions to pruning only, to prevent executions from piling up in very high volume cases.	2023-10-20 15:02:47 +02:00
Jon	647372be27	feat(core): Add support for oauth based service accounts with UM SMTP (#7311 ) This PR adds support for using OAuth based service accounts for the User Management SMTP connection. Tested using a Google Service Account.	2023-10-20 11:36:40 +01:00
Iván Ovejero	b50376cf52	refactor(core): Make executions pruning settings configurable (#7468 )	2023-10-19 16:57:12 +02:00
कारतोफ्फेलस्क्रिप्ट™	55c6a1b0d3	fix(core): Do not return `inviteAcceptUrl` in response if email was sent (#7465 )	2023-10-19 13:58:06 +02:00
कारतोफ्फेलस्क्रिप्ट™	83762e051d	fix(core): Handle gzip and deflate compressed request payloads (#7461 ) NODE-870	2023-10-18 21:52:15 +02:00
github-actions[bot]	ef58a23d21	🚀 Release 1.12.0 (#7459 ) # [1.12.0](https://github.com/n8n-io/n8n/compare/n8n@1.11.0...n8n@1.12.0) (2023-10-18) ### Bug Fixes * core: Add check that queue is defined and remove cyclic dependency ([#7404](https://github.com/n8n-io/n8n/issues/7404)) ([`45f2ef3`](`45f2ef373e`)) * core: Do not throw when deleting workflows with executions without binary-data ([#7411](https://github.com/n8n-io/n8n/issues/7411)) ([`2b6a15e`](`2b6a15e478`)) * core: Fix expression with paired item with multi-input node ([#7424](https://github.com/n8n-io/n8n/issues/7424)) ([`ec14141`](`ec141416e2`)) * core: Fix ignoring crashed executions without event msgs ([#7368](https://github.com/n8n-io/n8n/issues/7368)) ([`2f4d91b`](`2f4d91b2cd`)) * core: Pg-promise de-initialization fix ([#7417](https://github.com/n8n-io/n8n/issues/7417)) ([`7703904`](`77039044eb`)) * core: Prevent false stalled jobs in queue mode from displaying as errored ([#7435](https://github.com/n8n-io/n8n/issues/7435)) ([`e01b9e5`](`e01b9e5ae1`)) * core: Prevent undefined issues when restoring binary data ([#7419](https://github.com/n8n-io/n8n/issues/7419)) ([`46977a2`](`46977a2aff`)) * editor: Fix remote options fetching on every keystroke ([#7320](https://github.com/n8n-io/n8n/issues/7320)) ([`367255a`](`367255ab2c`)) * editor: Open only one tab with plans page ([#7377](https://github.com/n8n-io/n8n/issues/7377)) ([`c599006`](`c599006b91`)) * Google Sheets Node: Update by row_number, restored 'Handling Extra Data Option', updated Cell Format default ([#7357](https://github.com/n8n-io/n8n/issues/7357)) ([`d8531a5`](`d8531a53b9`)) * Ldap Node: Fix issue with connections not closing correctly ([#7432](https://github.com/n8n-io/n8n/issues/7432)) ([`c3f0be8`](`c3f0be809f`)) * Set Node: Null should not throw an error ([#7416](https://github.com/n8n-io/n8n/issues/7416)) ([`e9b6ab0`](`e9b6ab04cd`)) * TheHive 5 Node: Observable encoding in alert > create fix ([#7450](https://github.com/n8n-io/n8n/issues/7450)) ([`a2d2e3d`](`a2d2e3dda7`)) ### Features * core: Make executions pruning interval configurable ([#7439](https://github.com/n8n-io/n8n/issues/7439)) ([`40707fa`](`40707fa692`)) * Google Calendar Trigger Node: Add support for cancelled events ([#7436](https://github.com/n8n-io/n8n/issues/7436)) ([`9d241a0`](`9d241a0d6d`)) * HubSpot Trigger Node: Add support for ticket related events ([#7156](https://github.com/n8n-io/n8n/issues/7156)) ([`57c6093`](`57c609384a`)) * n8n Form Trigger Node: New node ([#7130](https://github.com/n8n-io/n8n/issues/7130)) ([`3ddc176`](`3ddc176dfa`)) * Spreadsheet File Node: Improve CSV parsing ([#7448](https://github.com/n8n-io/n8n/issues/7448)) ([`79f23fb`](`79f23fb939`)) Co-authored-by: netroy <netroy@users.noreply.github.com>	2023-10-18 17:43:29 +02:00
Iván Ovejero	40707fa692	feat(core): Make executions pruning interval configurable (#7439 )	2023-10-18 17:01:57 +02:00
Michael Kret	3ddc176dfa	feat(n8n Form Trigger Node): New node (#7130 ) Github issue / Community forum post (link here to close automatically): based on https://github.com/joffcom/n8n-nodes-form-trigger --------- Co-authored-by: Giulio Andreini <g.andreini@gmail.com>	2023-10-17 07:09:30 +03:00
Michael Auerswald	e01b9e5ae1	fix(core): Prevent false stalled jobs in queue mode from displaying as errored (#7435 ) This is related to an issue with how Bull handles stalled jobs, see https://github.com/OptimalBits/bull/issues/1415 for reference. CPU intensive workflows can in certain cases take a long while to finish up, thereby blocking the thread and causing Bull queue to think the job has stalled, even though it finished successfully. In these cases the error handling could then overwrite the successful execution data with the error message.	2023-10-13 16:07:08 +02:00
Iván Ovejero	c6ee1e30c0	refactor(core): Add binary data S3 to telemetry (#7412 ) https://n8nio.slack.com/archives/C04B1GZ4T0U/p1697033523039729	2023-10-13 13:16:43 +02:00

... 5 6 7 8 9 ...

2809 commits